[I] 4.9.7版本rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp等漏洞 [rocketmq]
luofeng3465 opened a new issue, #7678: URL: https://github.com/apache/rocketmq/issues/7678 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos7.8 ### RocketMQ version 4.9.7 ### JDK Version 1.8 ### Describe the Bug 4.9.7版本安全部门 rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp扫码出jar包的版本漏洞，不修不上上线生产，涉及CVE如下： CVE-2022-1471 | 9.8 | org.yaml : snakeyaml : 1.30 -- | -- | -- CVE-2022-25857 | 7.5 | org.yaml : snakeyaml : 1.30 CVE-2020-1938 | 9.8 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2022-25762 | 8.6 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2019-17563 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2020-11996 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2020-13934 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2020-17527 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2021-25122 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2021-41079 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2022-42252 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2023-24998 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2023-46589 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 sonatype-2023-4382 | 7.5 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2020-9484 | 7 | org.apache.tomcat.embed : tomcat-embed-core : 8.5.46 CVE-2023-33246 | 9.8 | org.apache.rocketmq : rocketmq-broker : 4.9.7 sonatype-2021-0789 | 8.4 | io.netty : netty-all : 4.1.65.Final CVE-2021-37136 | 7.5 | io.netty : netty-all : 4.1.65.Final CVE-2021-37137 | 7.5 | io.netty : netty-all : 4.1.65.Final CVE-2022-41881 | 7.5 | io.netty : netty-all : 4.1.65.Final sonatype-2023-4380 | 7.5 | io.netty : netty-all : 4.1.65.Final CVE-2023-3635 | 7.5 | com.squareup.okio : okio : 2.8.0 CVE-2021-0341 | 7.5 | com.squareup.okhttp3 : okhttp : 4.9.0 CVE-2023-2976 | 7.1 | com.google.guava : guava : 31.0.1-jre sonatype-2021-1694 | 7.5 | com.google.code.gson : gson : 2.8.6 CVE-2023-6378 | 7.5 | ch.qos.logback : logback-core : 1.2.10 CVE-2023-6378 | 7.5 | ch.qos.logback : logback-classic : 1.2.10 ### Steps to Reproduce 漏洞扫描 ### What Did You Expect to See? 扫描出漏洞 ### What Did You See Instead? 升级版本 ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] JDK17 + Springboot3 +rocketmq-spring-boot-starter2.2.3启动报错 [rocketmq-spring]
shen-hong-wei commented on issue #603: URL: https://github.com/apache/rocketmq-spring/issues/603#issuecomment-1862445172 >  我发现问题了，是指定了rocketmq子依赖的版本，导致版本之间没有拉齐导致的，根本问题还是父子工程，目前没问题了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] JDK17 + Springboot3 +rocketmq-spring-boot-starter2.2.3启动报错 [rocketmq-spring]
KouShenhai commented on issue #603: URL: https://github.com/apache/rocketmq-spring/issues/603#issuecomment-1862447204 ok,ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] JDK17 + Springboot3 +rocketmq-spring-boot-starter2.2.3启动报错 [rocketmq-spring]
shen-hong-wei closed issue #603: JDK17 + Springboot3 +rocketmq-spring-boot-starter2.2.3启动报错 URL: https://github.com/apache/rocketmq-spring/issues/603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] consumer shutdown will result in unspent mark consumption success [rocketmq-client-go]
zc24 opened a new issue, #1120:
URL: https://github.com/apache/rocketmq-client-go/issues/1120
if consumer all return ConsumeRetryLater, when consumer run
consumer.shutdown. View message trace The message was successfully consumed
`err = cs.Subscribe("topic", selector, func(ctx context.Context, ext
...*primitive.MessageExt) (consumer.ConsumeResult, error) {
for i := range ext {
fmt.Printf("%+v\n", ext[i])
}
return consumer.ConsumeRetryLater, nil
})
if err != nil {
fmt.Println(err)
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] [Enhancement]Cancel the serialization of RemotingCommand processTimer property [rocketmq]
mxsm opened a new issue, #7679: URL: https://github.com/apache/rocketmq/issues/7679 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary  The processTimer property of RemotingCommand should not be serialized ### Motivation The processTimer property of RemotingCommand should not be serialized ### Describe the Solution You'd Like Cancel the serialization of this field ### Describe Alternatives You've Considered - This field serialization to the client is useless firstly, - secondly, the increased amount of serialized byte data increases the transmitted data. - Thirdly, the time of serialization is increased. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 4.9.7版本rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp等漏洞 [rocketmq]
RongtongJin closed issue #7678: 4.9.7版本rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp等漏洞 URL: https://github.com/apache/rocketmq/issues/7678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 4.9.7版本rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp等漏洞 [rocketmq]
RongtongJin commented on issue #7678: URL: https://github.com/apache/rocketmq/issues/7678#issuecomment-1862541859 部分已经修复在4.9.x，你也可以提交pr到4.9.x的分支，后续进行发版。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7676] use clientDecode for consuming message directly [rocketmq]
RongtongJin commented on PR #7677: URL: https://github.com/apache/rocketmq/pull/7677#issuecomment-1862548325 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 4.9.7版本rocketmq扫描出snakeyaml、tomcat-embed-core、netty-all、okhttp等漏洞 [rocketmq]
RongtongJin commented on issue #7678: URL: https://github.com/apache/rocketmq/issues/7678#issuecomment-1862579031 这个扫描也有点问题，比如 tomcat-embed-core其实并不会带入实际的打包lib中 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
RongtongJin opened a new issue, #7680: URL: https://github.com/apache/rocketmq/issues/7680 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Bump guava version from 31.1-jre to 32.0.1-jre ### Motivation Bump guava version from 31.1-jre to 32.0.1-jre ### Describe the Solution You'd Like Bump guava version from 31.1-jre to 32.0.1-jre ### Describe Alternatives You've Considered No ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7680] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
RongtongJin opened a new pull request, #7681: URL: https://github.com/apache/rocketmq/pull/7681 ### Which Issue(s) This PR Fixes Fixes #7680 ### Brief Description Bump guava version from 31.1-jre to 32.0.1-jre ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 95c3f5cc7cafc8fc005dce6e5b7f57aa30b64300 / RongtongJin Bump guava version from 31.1-jre to 32.0.1-jre Report URL: https://github.com/apache/rocketmq/actions/runs/7261322937 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Iterating map variable "delayLevelTable" in order should be JDK-independent [rocketmq]
RongtongJin closed issue #7669: [Enhancement] Iterating map variable "delayLevelTable" in order should be JDK-independent URL: https://github.com/apache/rocketmq/issues/7669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap from ConcurrentHashMap (#7675)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 9dec4cf5fe [ISSUE #7669] map variable delayLevelTable changed to
ConcurrentSkipListMap from ConcurrentHashMap (#7675)
9dec4cf5fe is described below
commit 9dec4cf5fea916cd64fc47f6a3f036e5017b6622
Author: YASH PATEL <121890726+yp969...@users.noreply.github.com>
AuthorDate: Tue Dec 19 17:17:13 2023 +0530
[ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap
from ConcurrentHashMap (#7675)
---
.../apache/rocketmq/broker/schedule/ScheduleMessageService.java | 5 +++--
.../main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java | 8
.../main/java/org/apache/rocketmq/store/DefaultMessageStore.java | 5 +++--
3 files changed, 10 insertions(+), 8 deletions(-)
diff --git
a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
index 0c2e6507bd..ef7e4f6789 100644
---
a/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
+++
b/broker/src/main/java/org/apache/rocketmq/broker/schedule/ScheduleMessageService.java
@@ -23,6 +23,7 @@ import java.util.Queue;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.ScheduledExecutorService;
@@ -70,8 +71,8 @@ public class ScheduleMessageService extends ConfigManager {
private static final long WAIT_FOR_SHUTDOWN = 5000L;
private static final long DELAY_FOR_A_SLEEP = 10L;
-private final ConcurrentMap delayLevelTable =
-new ConcurrentHashMap<>(32);
+private final ConcurrentSkipListMap delayLevelTable =
+new ConcurrentSkipListMap<>();
private final ConcurrentMap
offsetTable =
new ConcurrentHashMap<>(32);
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
index c0d00d8640..e907a1ccc3 100644
--- a/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
+++ b/proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java
@@ -24,7 +24,7 @@ import java.util.Comparator;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
@@ -199,7 +199,7 @@ public class ProxyConfig implements ConfigFile {
private boolean useDelayLevel = false;
private String messageDelayLevel = "1s 5s 10s 30s 1m 2m 3m 4m 5m 6m 7m 8m
9m 10m 20m 30m 1h 2h";
-private transient Map
delayLevelTable = new ConcurrentHashMap<>();
+private transient ConcurrentSkipListMap delayLevelTable = new ConcurrentSkipListMap<>();
private String metricCollectorMode =
MetricCollectorMode.OFF.getModeString();
// Example address: 127.0.0.1:1234
@@ -291,7 +291,7 @@ public class ProxyConfig implements ConfigFile {
}
public void parseDelayLevel() {
-this.delayLevelTable = new ConcurrentHashMap<>();
+this.delayLevelTable = new ConcurrentSkipListMap<>();
Map timeUnitTable = new HashMap<>();
timeUnitTable.put("s", 1000L);
timeUnitTable.put("m", 1000L * 60);
@@ -1124,7 +1124,7 @@ public class ProxyConfig implements ConfigFile {
this.messageDelayLevel = messageDelayLevel;
}
-public Map getDelayLevelTable() {
+public ConcurrentSkipListMap getDelayLevelTable() {
return delayLevelTable;
}
diff --git
a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
index dc5f312e5a..aa72b1617d 100644
--- a/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
+++ b/store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
@@ -46,6 +46,7 @@ import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.ConcurrentMap;
+import java.util.concurrent.ConcurrentSkipListMap;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.LinkedBlockingQueue;
@@ -190,8 +191,8 @@ public class DefaultMessageStore implements MessageStore {
private SendMessageBackHook sendMessageBackHook;
-private final ConcurrentMap d
Re: [PR] [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipL… [rocketmq]
RongtongJin merged PR #7675: URL: https://github.com/apache/rocketmq/pull/7675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9dec4cf5fea916cd64fc47f6a3f036e5017b6622 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap from ConcurrentHashMap (#7675) Report URL: https://github.com/apache/rocketmq/actions/runs/7261362485 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7261347095 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9dec4cf5fea916cd64fc47f6a3f036e5017b6622 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap from ConcurrentHashMap (#7675) Report URL: https://github.com/apache/rocketmq/actions/runs/7261362502 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7680] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
codecov-commenter commented on PR #7681: URL: https://github.com/apache/rocketmq/pull/7681#issuecomment-1862640288 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `9 lines` in your changes are missing coverage. Please review. > Comparison is base [(`71a7a65`)](https://app.codecov.io/gh/apache/rocketmq/commit/71a7a659bed15110d1146091bfb7a51d28ade562?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.17% compared to head [(`95c3f5c`)](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.14%. > Report is 5 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | 25.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7681 +/- ## = - Coverage 43.17% 43.14% -0.04% - Complexity 9797 9801 +4 = Files 1165 1165 Lines 8447784482 +5 Branches 1096610968 +2 = - Hits 3647436447 -27 - Misses 4347343514 +41 + Partials4530 4521 -9 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7681?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 95c3f5cc7cafc8fc005dce6e5b7f57aa30b64300 / RongtongJin Bump guava version from 31.1-jre to 32.0.1-jre Report URL: https://github.com/apache/rocketmq/actions/runs/7261322947 With regards, GitHub Actions via GitBox
[PR] fix iterator.remove() bug [rocketmq]
EvanMi opened a new pull request, #7682: URL: https://github.com/apache/rocketmq/pull/7682 ### Brief Description bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] remote connect exception [rocketmq-dashboard]
Jedore commented on issue #181: URL: https://github.com/apache/rocketmq-dashboard/issues/181#issuecomment-1862688220 > I tried all the options none of them fixed the issue back then and I had to move to a different MQ. Will try this now also it would be great if the blogs or documentation is in English as few cn domains are blocked in other countries atleast for the frequently encountered errors Hahaha, I will write my solution about this issue(the first hole I met about rocketmq, may be more holes) in my blog, but ... I've switched to rabbitmq ... @Carlos1729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 9dec4cf5fea916cd64fc47f6a3f036e5017b6622 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap from ConcurrentHashMap (#7675) Report URL: https://github.com/apache/rocketmq/actions/runs/7261362484 With regards, GitHub Actions via GitBox
[PR] [ISSUE #7679]Optimize the serialization of RemotingCommand processTimer property [rocketmq]
mxsm opened a new pull request, #7683: URL: https://github.com/apache/rocketmq/pull/7683 ### Which Issue(s) This PR Fixes Fixes #7679 ### Brief Description - Optimize the serialization of RemotingCommand processTimer property ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix iterator.remove() bug [rocketmq]
RongtongJin commented on PR #7682: URL: https://github.com/apache/rocketmq/pull/7682#issuecomment-1862780539 Hi @EvanMi Could you create an issue related the pr？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 6875abac8925008d9eb9c8185a5bf65973892ae1 / mxsm [ISSUE #7679]Optimize the serialization of RemotingCommand processTimer property Report URL: https://github.com/apache/rocketmq/actions/runs/7262656260 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 9dec4cf5fea916cd64fc47f6a3f036e5017b6622 / YASH PATEL <121890726+yp969...@users.noreply.github.com> [ISSUE #7669] map variable delayLevelTable changed to ConcurrentSkipListMap from ConcurrentHashMap (#7675) Report URL: https://github.com/apache/rocketmq/actions/runs/7262683636 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7679]Optimize the serialization of RemotingCommand processTimer property [rocketmq]
codecov-commenter commented on PR #7683: URL: https://github.com/apache/rocketmq/pull/7683#issuecomment-1862822889 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7683?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9dec4cf`)](https://app.codecov.io/gh/apache/rocketmq/commit/9dec4cf5fea916cd64fc47f6a3f036e5017b6622?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.12% compared to head [(`6875aba`)](https://app.codecov.io/gh/apache/rocketmq/pull/7683?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.11%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7683 +/- ## = - Coverage 43.12% 43.11% -0.01% - Complexity 9793 9797 +4 = Files 1165 1165 Lines 8448284482 Branches 1096810968 = - Hits 3642936427 -2 - Misses 4352343533 +10 + Partials4530 4522 -8 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7683?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [code smell] System.currentTimeMillis() is a static method ,wrap it as a class method is inconvenient. [rocketmq]
github-actions[bot] commented on issue #5720: URL: https://github.com/apache/rocketmq/issues/5720#issuecomment-1863639803 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [code bug] the index++ may reach negative value [rocketmq]
github-actions[bot] commented on issue #5716: URL: https://github.com/apache/rocketmq/issues/5716#issuecomment-1863639841 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Is there a way to customize client host in trace data? [rocketmq]
github-actions[bot] commented on issue #5497: URL: https://github.com/apache/rocketmq/issues/5497#issuecomment-1863639878 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7679]Optimize the serialization of RemotingCommand processTimer property [rocketmq]
RongtongJin merged PR #7683: URL: https://github.com/apache/rocketmq/pull/7683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement]Cancel the serialization of RemotingCommand processTimer property [rocketmq]
RongtongJin closed issue #7679: [Enhancement]Cancel the serialization of RemotingCommand processTimer property URL: https://github.com/apache/rocketmq/issues/7679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7679] Optimize the serialization of RemotingCommand processTimer property (#7683)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 403ad6f66c [ISSUE #7679] Optimize the serialization of RemotingCommand
processTimer property (#7683)
403ad6f66c is described below
commit 403ad6f66ce9910b23b15be6f540626db4c961ee
Author: mxsm
AuthorDate: Wed Dec 20 08:45:08 2023 +0800
[ISSUE #7679] Optimize the serialization of RemotingCommand processTimer
property (#7683)
---
.../java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java
b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java
index e93072adff..0fa275e822 100644
---
a/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java
+++
b/remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java
@@ -95,7 +95,7 @@ public class RemotingCommand {
private transient byte[] body;
private boolean suspended;
-private Stopwatch processTimer;
+private transient Stopwatch processTimer;
protected RemotingCommand() {
}
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 403ad6f66ce9910b23b15be6f540626db4c961ee / mxsm [ISSUE #7679] Optimize the serialization of RemotingCommand processTimer property (#7683) Report URL: https://github.com/apache/rocketmq/actions/runs/7269406324 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user EvanMi (triggered by RongtongJin). Head commit for run: 7bff5a755bc2728584ae55241c5972471cb79ac7 / mipengcheng3 add testcase Report URL: https://github.com/apache/rocketmq/actions/runs/7262114015 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user EvanMi (triggered by EvanMi). Head commit for run: 403ad6f66ce9910b23b15be6f540626db4c961ee / mxsm [ISSUE #7679] Optimize the serialization of RemotingCommand processTimer property (#7683) Report URL: https://github.com/apache/rocketmq/actions/runs/7269435471 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 403ad6f66ce9910b23b15be6f540626db4c961ee / mxsm [ISSUE #7679] Optimize the serialization of RemotingCommand processTimer property (#7683) Report URL: https://github.com/apache/rocketmq/actions/runs/7269406323 With regards, GitHub Actions via GitBox
Re: [PR] fix iterator.remove() bug [rocketmq]
codecov-commenter commented on PR #7682: URL: https://github.com/apache/rocketmq/pull/7682#issuecomment-1863688277 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `1 lines` in your changes are missing coverage. Please review. > Comparison is base [(`9dec4cf`)](https://app.codecov.io/gh/apache/rocketmq/commit/9dec4cf5fea916cd64fc47f6a3f036e5017b6622?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.12% compared to head [(`7bff5a7`)](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.19%. > Report is 1 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...ava/org/apache/rocketmq/store/MappedFileQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01hcHBlZEZpbGVRdWV1ZS5qYXZh) | 75.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7682 +/- ## = + Coverage 43.12% 43.19% +0.07% - Complexity 9793 9806 +13 = Files 1165 1165 Lines 8448284485 +3 Branches 1096810969 +1 = + Hits 3642936492 +63 + Misses 4352343465 -58 + Partials4530 4528 -2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7682?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating [rocketmq]
EvanMi opened a new issue, #7684: URL: https://github.com/apache/rocketmq/issues/7684 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment all ### RocketMQ version all ### JDK Version all ### Describe the Bug CopyOnWriteArray#listIterator do not support remove action when iterating, but MappedFileQueue#resetOffset used it ### Steps to Reproduce see #7682 testcase ### What Did You Expect to See? reset success ### What Did You See Instead? failed ### Additional Context PR #7682 fixed this promblem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix iterator.remove() bug [rocketmq]
EvanMi commented on PR #7682: URL: https://github.com/apache/rocketmq/pull/7682#issuecomment-1863735780 > Hi @EvanMi Could you create an issue related the pr？ see https://github.com/apache/rocketmq/issues/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix iterator.remove() bug [rocketmq]
EvanMi commented on PR #7682: URL: https://github.com/apache/rocketmq/pull/7682#issuecomment-1863736870 > Hi @EvanMi Could you create an issue related the pr？ see https://github.com/apache/rocketmq/issues/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7676] use clientDecode for consuming message directly [rocketmq]
cserwen merged PR #7677: URL: https://github.com/apache/rocketmq/pull/7677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7676] use clientDecode for consuming message directly (#7677)
This is an automated email from the ASF dual-hosted git repository.
cserwen pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new c10121697a [ISSUE #7676] use clientDecode for consuming message
directly (#7677)
c10121697a is described below
commit c10121697ae50ad19ac0dea1ef22690caba14e99
Author: cserwen
AuthorDate: Wed Dec 20 10:12:15 2023 +0800
[ISSUE #7676] use clientDecode for consuming message directly (#7677)
Co-authored-by: dengzhiwen1
---
.../java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
index 31b879ffed..2f18c610c1 100644
---
a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
+++
b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
@@ -208,7 +208,7 @@ public class ClientRemotingProcessor implements
NettyRequestProcessor {
(ConsumeMessageDirectlyResultRequestHeader) request
.decodeCommandCustomHeader(ConsumeMessageDirectlyResultRequestHeader.class);
-final MessageExt msg =
MessageDecoder.decode(ByteBuffer.wrap(request.getBody()));
+final MessageExt msg =
MessageDecoder.clientDecode(ByteBuffer.wrap(request.getBody()), true);
ConsumeMessageDirectlyResult result =
this.mqClientFactory.consumeMessageDirectly(msg,
requestHeader.getConsumerGroup(), requestHeader.getBrokerName());
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: c10121697ae50ad19ac0dea1ef22690caba14e99 / cserwen [ISSUE #7676] use clientDecode for consuming message directly (#7677) Co-authored-by: dengzhiwen1 Report URL: https://github.com/apache/rocketmq/actions/runs/7270128472 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Use clientDecode for consuming message directly [rocketmq]
cserwen closed issue #7676: [Enhancement] Use clientDecode for consuming message directly URL: https://github.com/apache/rocketmq/issues/7676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: c10121697ae50ad19ac0dea1ef22690caba14e99 / cserwen [ISSUE #7676] use clientDecode for consuming message directly (#7677) Co-authored-by: dengzhiwen1 Report URL: https://github.com/apache/rocketmq/actions/runs/7270128471 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 45fcb68baec2cdb1417ba26c235d00c52bc14f09 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7207983610 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 87d3276669e0d68eb9b6d1ecda628e2322dcb5c8 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270319211 With regards, GitHub Actions via GitBox
[I] grpc-js Call cancelled [rocketmq-clients]
eric-projects opened a new issue, #653:
URL: https://github.com/apache/rocketmq-clients/issues/653
### Before Creating the Bug Report
- [X] I found a bug, not just asking a question, which should be created in
[GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions).
- [X] I have searched the [GitHub
Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub
Discussions](https://github.com/apache/rocketmq-clients/discussions) of this
repository and believe that this is not a duplicate.
- [X] I have confirmed that this bug belongs to the current repository, not
other repositories of RocketMQ.
### Programming Language of the Client
Node.js
### Runtime Platform Environment
ubuntu20.04.5
### RocketMQ Version of the Client/Server
5.0
### Run or Compiler Version
nodejs 18.17.0，18.0.0，16.19.0
### Describe the Bug
Producer [class Producer extends BaseClient]
Error: 1 CANCELLED: Call cancelled
at callErrorFromStatus
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
at Object.onReceiveStatus
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:192:76)
at Object.onReceiveStatus
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:360:141)
at Object.onReceiveStatus
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:323:181)
at
/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/resolving-call.js:99:78
at process.processTicksAndRejections
(node:internal/process/task_queues:77:11)
for call at
at ServiceClientImpl.makeUnaryRequest
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/client.js:160:32)
at ServiceClientImpl.queryRoute
(/root/rocketmq-clients/nodejs/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
at /root/rocketmq-clients/nodejs/dist/client/RpcClient.js:62:20
at new Promise ()
at RpcClient.queryRoute
(/root/rocketmq-clients/nodejs/dist/client/RpcClient.js:61:16)
at RpcClientManager.queryRoute
(/root/rocketmq-clients/nodejs/dist/client/RpcClientManager.js:66:32)
at #fetchTopicRoute
(/root/rocketmq-clients/nodejs/dist/client/BaseClient.js:178:54)
at Producer.getRouteData
(/root/rocketmq-clients/nodejs/dist/client/BaseClient.js:170:57)
at #getPublishingLoadBalancer
(/root/rocketmq-clients/nodejs/dist/producer/Producer.js:216:47)
at #send
(/root/rocketmq-clients/nodejs/dist/producer/Producer.js:142:67) {
code: 1,
details: 'Call cancelled',
metadata: Metadata { internalRepr: Map(0) {}, options: {} }
}
### Steps to Reproduce
1、pull rocketmq-clients code
2、pull proto code
3、 cd rocketmq-clients/nodejs
4、 npm install
5、 npm run init
6、 npm run build
7、 use dist folder run Producer test
### What Did You Expect to See?
message send success
### What Did You See Instead?
run error :Error: 1 CANCELLED: Call cancelled
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: c10121697ae50ad19ac0dea1ef22690caba14e99 / cserwen [ISSUE #7676] use clientDecode for consuming message directly (#7677) Co-authored-by: dengzhiwen1 Report URL: https://github.com/apache/rocketmq/actions/runs/7270331842 With regards, GitHub Actions via GitBox
Re: [I] grpc-js Call cancelled [rocketmq-clients]
eric-projects commented on issue #653: URL: https://github.com/apache/rocketmq-clients/issues/653#issuecomment-1863775831   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 87d3276669e0d68eb9b6d1ecda628e2322dcb5c8 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270319210 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] slave sync acl [rocketmq]
cserwen commented on issue #7672: URL: https://github.com/apache/rocketmq/issues/7672#issuecomment-1863782587 Maybe it's because the adminClient will send RPC requests to all Brokers to update the acl config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 87d3276669e0d68eb9b6d1ecda628e2322dcb5c8 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270319213 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 87d3276669e0d68eb9b6d1ecda628e2322dcb5c8 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270319211 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
ShannonDing closed issue #7680: [Enhancement] Bump guava version from 31.1-jre to 32.0.1-jre URL: https://github.com/apache/rocketmq/issues/7680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: Bump guava version from 31.1-jre to 32.0.1-jre (#7681)
This is an automated email from the ASF dual-hosted git repository. dinglei pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new fbfc066695 Bump guava version from 31.1-jre to 32.0.1-jre (#7681) fbfc066695 is described below commit fbfc066695fe5485b116284b5eafb0e9decef87c Author: rongtong AuthorDate: Wed Dec 20 11:49:20 2023 +0800 Bump guava version from 31.1-jre to 32.0.1-jre (#7681) --- pom.xml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 57fb1b4083..49c92d2fa0 100644 --- a/pom.xml +++ b/pom.xml @@ -108,7 +108,7 @@ 4.2.2 3.12.0 2.7 -31.1-jre +32.0.1-jre 2.9.0 0.3.1-alpha 2.0 @@ -893,6 +893,10 @@ com.google.code.gson gson + +com.google.j2objc +j2objc-annotations +
Re: [PR] [ISSUE #7680] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
ShannonDing merged PR #7681: URL: https://github.com/apache/rocketmq/pull/7681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The bornTime is not set when using the popMessage API in cluster mode. [rocketmq]
dingshuangxi888 opened a new issue, #7686: URL: https://github.com/apache/rocketmq/issues/7686 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Linux ### RocketMQ version develop ### JDK Version Java 11 ### Describe the Bug The bornTime is not set when using the popMessage API in cluster mode, So it will cause "timeout too much" error. And will never receive any messages.  ### Steps to Reproduce Use gRPC client to receive message by Proxy, you can not receive any messages. ### What Did You Expect to See? When using the gRPC client to receive messages, it will return correctly. ### What Did You See Instead? When using the gRPC client to receive messages, it will return correctly. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7270740262 With regards, GitHub Actions via GitBox
[PR] [ISSUE #7686] The bornTime is not set when using the popMessage API in cluster mode. [rocketmq]
dingshuangxi888 opened a new pull request, #7687: URL: https://github.com/apache/rocketmq/pull/7687 ### Which Issue(s) This PR Fixes Fixes #7686 ### Brief Description The bornTime is not set when using the popMessage API in cluster mode, So it will cause "timeout too much" error. And will never receive any messages. ### How Did You Test This Change? Fix before: Use gRPC client to receive message by Proxy, you can not receive any messages. Fix after: Use gRPC client to receive message by Proxy, you can receive all messages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: b9257234f5c1e9e861e4f70e6ecaf04ce8c5ee6e / ShuangxiDing The bornTime is not set when using the popMessage API in cluster mode. Report URL: https://github.com/apache/rocketmq/actions/runs/7270841382 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: dc252f829660ec626bb20fe0bc1ae8fd257a2d35 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270862042 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7270740260 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7270861127 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7270878958 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7270740265 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7686] The bornTime is not set when using the popMessage API in cluster mode. [rocketmq]
codecov-commenter commented on PR #7687: URL: https://github.com/apache/rocketmq/pull/7687#issuecomment-1863828814 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `40 lines` in your changes are missing coverage. Please review. > Comparison is base [(`46962c2`)](https://app.codecov.io/gh/apache/rocketmq/commit/46962c262c37554ff09afe9e02c7baf66a5ecc73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.97% compared to head [(`b925723`)](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.14%. > Report is 40 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | 58.13% | [8 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...a/org/apache/rocketmq/store/MessageExtEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VFeHRFbmNvZGVyLmphdmE=) | 78.26% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [.../java/org/apache/rocketmq/store/MultiDispatch.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL011bHRpRGlzcGF0Y2guamF2YQ==) | 87.09% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...rocketmq/common/message/MessageExtBrokerInner.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QnJva2VySW5uZXIuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...org/apache/rocketmq/common/utils/MessageUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvTWVzc2FnZVV0aWxzLmphdmE=) | 88.00% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...q/proxy/service/message/ClusterMessageService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvbWVzc2FnZS9DbHVzdGVyTWVzc2FnZVNlcnZpY2UuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...pache/rocketmq/store/queue/MultiDispatchUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL011bHRpRGlzcGF0Y2hVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: dc252f829660ec626bb20fe0bc1ae8fd257a2d35 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7270862052 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: b9257234f5c1e9e861e4f70e6ecaf04ce8c5ee6e / ShuangxiDing The bornTime is not set when using the popMessage API in cluster mode. Report URL: https://github.com/apache/rocketmq/actions/runs/7270841395 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: fac58f3c6e6c2484663c2b067c1ec4cd2fbdb99a / ShuangxiDing The bornTime is not set when using the popMessage API in cluster mode. Report URL: https://github.com/apache/rocketmq/actions/runs/7271608308 With regards, GitHub Actions via GitBox
[PR] [4.9.x] Bump guava version from 31.1-jre to 32.0.1-jre [rocketmq]
RongtongJin opened a new pull request, #7688: URL: https://github.com/apache/rocketmq/pull/7688 ### Which Issue(s) This PR Fixes Fixes #7680 ### Brief Description Bump guava version from 31.1-jre to 32.0.1-jre ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: fbfc066695fe5485b116284b5eafb0e9decef87c / rongtong Bump guava version from 31.1-jre to 32.0.1-jre (#7681) Report URL: https://github.com/apache/rocketmq/actions/runs/7271632485 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7684] Fix iterator.remove() bug (#7682)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new f0a3e933b9 [ISSUE #7684] Fix iterator.remove() bug (#7682)
f0a3e933b9 is described below
commit f0a3e933b91c1e5ec964e44073643b7bb8cc5e50
Author: EvanMi <43713766+eva...@users.noreply.github.com>
AuthorDate: Wed Dec 20 14:34:53 2023 +0800
[ISSUE #7684] Fix iterator.remove() bug (#7682)
* bugfix: CopyOnWriteArray#listIterator do not support remove action when
iterating
* add testcase
-
Co-authored-by: mipengcheng3
---
.../java/org/apache/rocketmq/store/MappedFileQueue.java | 8 +++-
.../org/apache/rocketmq/store/MappedFileQueueTest.java| 15 +++
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java
b/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java
index 9a0824829e..e32c16a82a 100644
--- a/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java
+++ b/store/src/main/java/org/apache/rocketmq/store/MappedFileQueue.java
@@ -406,6 +406,7 @@ public class MappedFileQueue implements Swappable {
}
ListIterator iterator =
this.mappedFiles.listIterator(mappedFiles.size());
+List toRemoves = new ArrayList<>();
while (iterator.hasPrevious()) {
mappedFileLast = iterator.previous();
@@ -416,9 +417,14 @@ public class MappedFileQueue implements Swappable {
mappedFileLast.setCommittedPosition(where);
break;
} else {
-iterator.remove();
+toRemoves.add(mappedFileLast);
}
}
+
+if (!toRemoves.isEmpty()) {
+this.mappedFiles.removeAll(toRemoves);
+}
+
return true;
}
diff --git
a/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java
b/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java
index d92b3cbc0d..3cc17c659b 100644
--- a/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java
+++ b/store/src/test/java/org/apache/rocketmq/store/MappedFileQueueTest.java
@@ -477,6 +477,21 @@ public class MappedFileQueueTest {
TimeUnit.SECONDS.sleep(3);
}
+@Test
+public void testReset() {
+final String fixedMsg = "0123456789abcdef";
+MappedFileQueue mappedFileQueue =
+new MappedFileQueue(storePath + File.separator + "a/", 64,
null);
+for (int i = 0; i < 8; i++) {
+MappedFile mappedFile = mappedFileQueue.getLastMappedFile(0);
+assertThat(mappedFile).isNotNull();
+assertThat(mappedFile.appendMessage(fixedMsg.getBytes())).isTrue();
+}
+assertThat(mappedFileQueue.getMappedFiles().size()).isEqualTo(2);
+assertThat(mappedFileQueue.resetOffset(0)).isTrue();
+assertThat(mappedFileQueue.getMappedFiles().size()).isEqualTo(1);
+}
+
@After
public void destroy() {
File file = new File(storePath);
Re: [PR] [ISSUE #7684] Fix iterator.remove() bug [rocketmq]
RongtongJin merged PR #7682: URL: https://github.com/apache/rocketmq/pull/7682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f0a3e933b91c1e5ec964e44073643b7bb8cc5e50 / EvanMi <43713766+eva...@users.noreply.github.com> [ISSUE #7684] Fix iterator.remove() bug (#7682) * bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating * add testcase - Co-authored-by: mipengcheng3 Report URL: https://github.com/apache/rocketmq/actions/runs/7271884595 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f0a3e933b91c1e5ec964e44073643b7bb8cc5e50 / EvanMi <43713766+eva...@users.noreply.github.com> [ISSUE #7684] Fix iterator.remove() bug (#7682) * bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating * add testcase - Co-authored-by: mipengcheng3 Report URL: https://github.com/apache/rocketmq/actions/runs/7271884599 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f0a3e933b91c1e5ec964e44073643b7bb8cc5e50 / EvanMi <43713766+eva...@users.noreply.github.com> [ISSUE #7684] Fix iterator.remove() bug (#7682) * bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating * add testcase - Co-authored-by: mipengcheng3 Report URL: https://github.com/apache/rocketmq/actions/runs/7271884593 With regards, GitHub Actions via GitBox
Re: [I] [Bug] bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating [rocketmq]
RongtongJin closed issue #7684: [Bug] bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating URL: https://github.com/apache/rocketmq/issues/7684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
