Re: [I] localdatetime 使用jackson序列化无法解析问题版本2.2.2 [rocketmq-spring]
sheltonsuen commented on issue #524: URL: https://github.com/apache/rocketmq-spring/issues/524#issuecomment-1859101052 same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [RIP-68] RocketMQ EventBridge Dashboard [rocketmq-eventbridge]
atticusmiles commented on issue #146: URL: https://github.com/apache/rocketmq-eventbridge/issues/146#issuecomment-1859174931 Any progress on this dashboard? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7659]Trim property [rocketmq]
RongtongJin merged PR #7660: URL: https://github.com/apache/rocketmq/pull/7660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [ISSUE #7659] Many Broker configuration items are Boolean values. If a space is added after true, the configuration will not take effect. [rocketmq]
RongtongJin closed issue #7659: [ISSUE #7659] Many Broker configuration items are Boolean values. If a space is added after true, the configuration will not take effect. URL: https://github.com/apache/rocketmq/issues/7659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user javens0601 (triggered by RongtongJin). Head commit for run: c936a5bb061ba1ec6f5cd23930d38fde7364deec / jinwei2 [BUG #7662] fix: updateAccessConfig when groupPerms is empty Report URL: https://github.com/apache/rocketmq/actions/runs/7208754255 With regards, GitHub Actions via GitBox
(rocketmq) branch develop updated: [ISSUE #7659]Trim property
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 086a726c5d [ISSUE #7659]Trim property
086a726c5d is described below
commit 086a726c5da01da8869b045000de7dae5f1e2937
Author: Dongyuan Pan
AuthorDate: Mon Dec 18 08:29:54 2023 +0800
[ISSUE #7659]Trim property
---
common/src/main/java/org/apache/rocketmq/common/MixAll.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/src/main/java/org/apache/rocketmq/common/MixAll.java
b/common/src/main/java/org/apache/rocketmq/common/MixAll.java
index 407ef2842c..c11eb377b9 100644
--- a/common/src/main/java/org/apache/rocketmq/common/MixAll.java
+++ b/common/src/main/java/org/apache/rocketmq/common/MixAll.java
@@ -376,6 +376,7 @@ public class MixAll {
} else if (cn.equals("float") ||
cn.equals("Float")) {
arg = Float.parseFloat(property);
} else if (cn.equals("String")) {
+property = property.trim();
arg = property;
} else {
continue;
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 086a726c5da01da8869b045000de7dae5f1e2937 / Dongyuan Pan [ISSUE #7659]Trim property Report URL: https://github.com/apache/rocketmq/actions/runs/7242018689 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user javens0601 (triggered by RongtongJin). Head commit for run: c936a5bb061ba1ec6f5cd23930d38fde7364deec / jinwei2 [BUG #7662] fix: updateAccessConfig when groupPerms is empty Report URL: https://github.com/apache/rocketmq/actions/runs/7208754245 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 086a726c5da01da8869b045000de7dae5f1e2937 / Dongyuan Pan [ISSUE #7659]Trim property Report URL: https://github.com/apache/rocketmq/actions/runs/7242018694 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user javens0601 (triggered by javens0601). Head commit for run: 086a726c5da01da8869b045000de7dae5f1e2937 / Dongyuan Pan [ISSUE #7659]Trim property Report URL: https://github.com/apache/rocketmq/actions/runs/7242035068 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 086a726c5da01da8869b045000de7dae5f1e2937 / Dongyuan Pan [ISSUE #7659]Trim property Report URL: https://github.com/apache/rocketmq/actions/runs/7242018693 With regards, GitHub Actions via GitBox
Re: [PR] lock.lock() before try [rocketmq]
fuyou001 commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1859368482 更标准做法，是要放到try外面。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user javens0601 (triggered by RongtongJin). Head commit for run: c936a5bb061ba1ec6f5cd23930d38fde7364deec / jinwei2 [BUG #7662] fix: updateAccessConfig when groupPerms is empty Report URL: https://github.com/apache/rocketmq/actions/runs/7208754249 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 086a726c5da01da8869b045000de7dae5f1e2937 / Dongyuan Pan [ISSUE #7659]Trim property Report URL: https://github.com/apache/rocketmq/actions/runs/7242018690 With regards, GitHub Actions via GitBox
Re: [I] [Enhancement] ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false [rocketmq]
ShannonDing closed issue #7656: [Enhancement] ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false URL: https://github.com/apache/rocketmq/issues/7656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7656] ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false [rocketmq]
ShannonDing merged PR #7657: URL: https://github.com/apache/rocketmq/pull/7657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657)
This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 80c0330f75 ConfirmOffset directly takes the max offset when
allAckInSyncStateSet is false (#7657)
80c0330f75 is described below
commit 80c0330f752dcf3219cb8631f3004c1725bedf1e
Author: rongtong
AuthorDate: Mon Dec 18 10:10:28 2023 +0800
ConfirmOffset directly takes the max offset when allAckInSyncStateSet is
false (#7657)
---
.../java/org/apache/rocketmq/store/CommitLog.java | 23 --
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
index 35c1d0e2d7..cc29cca5d9 100644
--- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
+++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
@@ -314,6 +314,7 @@ public class CommitLog implements Swappable {
/**
* When the normal exit, data recovery, all memory data have been flush
+ *
* @throws RocksDBException only in rocksdb mode
*/
public void recoverNormally(long maxPhyOffsetOfConsumeQueue) throws
RocksDBException {
@@ -636,7 +637,8 @@ public class CommitLog implements Swappable {
public long getConfirmOffset() {
if
(this.defaultMessageStore.getBrokerConfig().isEnableControllerMode()) {
if
(this.defaultMessageStore.getMessageStoreConfig().getBrokerRole() !=
BrokerRole.SLAVE && !this.defaultMessageStore.getRunningFlags().isFenced()) {
-if (((AutoSwitchHAService)
this.defaultMessageStore.getHaService()).getLocalSyncStateSet().size() == 1) {
+if (((AutoSwitchHAService)
this.defaultMessageStore.getHaService()).getLocalSyncStateSet().size() == 1
+||
!this.defaultMessageStore.getMessageStoreConfig().isAllAckInSyncStateSet()) {
return this.defaultMessageStore.getMaxPhyOffset();
}
// First time it will compute the confirmOffset.
@@ -1214,7 +1216,7 @@ public class CommitLog implements Swappable {
}
} catch (RocksDBException e) {
return CompletableFuture.completedFuture(new
PutMessageResult(PutMessageStatus.UNKNOWN_ERROR, result));
-} finally {
+} finally {
topicQueueLock.unlock(topicQueueKey);
}
@@ -1840,7 +1842,8 @@ public class CommitLog implements Swappable {
this.messageStoreConfig = messageStoreConfig;
}
-public AppendMessageResult handlePropertiesForLmqMsg(ByteBuffer
preEncodeBuffer, final MessageExtBrokerInner msgInner) {
+public AppendMessageResult handlePropertiesForLmqMsg(ByteBuffer
preEncodeBuffer,
+final MessageExtBrokerInner msgInner) {
if (msgInner.isEncodeCompleted()) {
return null;
}
@@ -1850,10 +1853,10 @@ public class CommitLog implements Swappable {
msgInner.setPropertiesString(MessageDecoder.messageProperties2String(msgInner.getProperties()));
final byte[] propertiesData =
-msgInner.getPropertiesString() == null ? null :
msgInner.getPropertiesString().getBytes(MessageDecoder.CHARSET_UTF8);
+msgInner.getPropertiesString() == null ? null :
msgInner.getPropertiesString().getBytes(MessageDecoder.CHARSET_UTF8);
boolean needAppendLastPropertySeparator = enabledAppendPropCRC &&
propertiesData != null && propertiesData.length > 0
-&& propertiesData[propertiesData.length - 1] !=
MessageDecoder.PROPERTY_SEPARATOR;
+&& propertiesData[propertiesData.length - 1] !=
MessageDecoder.PROPERTY_SEPARATOR;
final int propertiesLength = (propertiesData == null ? 0 :
propertiesData.length) + (needAppendLastPropertySeparator ? 1 : 0) +
crc32ReservedLength;
@@ -2312,7 +2315,7 @@ public class CommitLog implements Swappable {
return true;
}
-int pos = (int)(offset %
defaultMessageStore.getMessageStoreConfig().getMappedFileSizeCommitLog());
+int pos = (int) (offset %
defaultMessageStore.getMessageStoreConfig().getMappedFileSizeCommitLog());
int realIndex = pos / pageSize / sampleSteps;
return bytes.length - 1 >= realIndex && bytes[realIndex] != 0;
}
@@ -2356,8 +2359,8 @@ public class CommitLog implements Swappable {
private byte[] checkFileInPageCache(MappedFile mappedFile) {
long fileSize = mappedFile.getFileSize();
-final long address =
((DirectBuffer)mappedFile.getMappedByteBuffer()).address();
-int pageNums = (int)(fileSize + this.pageSize - 1) / this.pageSize;
+final long address = ((DirectBuffer)
mappedFile.
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7242723940 With regards, GitHub Actions via GitBox
Re: [I] 【question】The ledger cluster restarts from a node and triggers elections slowly [rocketmq]
LittleBoy18 closed issue #7620: 【question】The ledger cluster restarts from a node and triggers elections slowly URL: https://github.com/apache/rocketmq/issues/7620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7242723935 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7242723936 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7242723933 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user cserwen (triggered by cserwen). Head commit for run: 45fcb68baec2cdb1417ba26c235d00c52bc14f09 / cserwen feat: support to send trace for batchSend Report URL: https://github.com/apache/rocketmq/actions/runs/7207983619 With regards, GitHub Actions via GitBox
Re: [I] broker重启偶发topic perm权限被修改为4 [rocketmq]
RongtongJin closed issue #7600: broker重启偶发topic perm权限被修改为4 URL: https://github.com/apache/rocketmq/issues/7600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 服务端无法获取客户端的真实IP [rocketmq]
RongtongJin closed issue #7561: 服务端无法获取客户端的真实IP URL: https://github.com/apache/rocketmq/issues/7561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] There is something wrong with the function of messageTrack [rocketmq-dashboard]
Luokejin opened a new issue, #190: URL: https://github.com/apache/rocketmq-dashboard/issues/190 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/). **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? - What did you expect to see? - What did you see instead? 2. Please tell us about your environment: 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): **FEATURE REQUEST** 1. Please describe the feature you are requesting. 2. Provide any additional detail on your proposed use case for this feature. 2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? 4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here, - ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] eventBridge目标源，不支持http [rocketmq-eventbridge]
jiangzhoukim commented on issue #155: URL: https://github.com/apache/rocketmq-eventbridge/issues/155#issuecomment-1859617861 请问创建http目标源接口需要传什么参数 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] Producer connection is incorrect when use otel statistics [rocketmq]
zhiliatom opened a new issue, #7671: URL: https://github.com/apache/rocketmq/issues/7671 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos7 ### RocketMQ version 5.1.5.SNAPSHOT ### JDK Version jdk1.8 ### Describe the Bug the producer connections is actually include the group of "CLIENT_INNER_PRODUCER" which doesn't want to be counted to user. Chinese version： 生产者的数量统计结果包含了CLIENT_INNER_PRODUCER 这个内部组的生产者，对用户展示的结果不符合实际启动的生产者数量 ### Steps to Reproduce 1. use otel metrics minitor producer connections 2. when start "N" consumer client and no producer client ### What Did You Expect to See? producer connection is zero ### What Did You See Instead? producer connection is "N" ,the same with consumer connections ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #610] Fix doc error about metricsGrpcExporterTarget [rocketmq-site]
zhiliatom commented on PR #611: URL: https://github.com/apache/rocketmq-site/pull/611#issuecomment-1859653586 @RongtongJin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Enhancement] slave sync acl [rocketmq]
leizhiyuan opened a new issue, #7672:
URL: https://github.com/apache/rocketmq/issues/7672
### Before Creating the Enhancement Request
- [X] I have confirmed that this should be classified as an enhancement
rather than a bug/feature.
### Summary
slave sync acl
### Motivation
slave sync acl
### Describe the Solution You'd Like
slave sync acl
### Describe Alternatives You've Considered
slave sync acl
### Additional Context
org.apache.rocketmq.broker.slave.SlaveSynchronize#syncAll
```
this.syncTopicConfig();
this.syncConsumerOffset();
this.syncDelayOffset();
this.syncSubscriptionGroupConfig();
this.syncMessageRequestMode();
if (brokerController.getMessageStoreConfig().isTimerWheelEnable()) {
this.syncTimerMetrics();
}
```
is there any reason we do not sync acl config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [ISSUE #7671] filter inner producer client when report to metrics [rocketmq]
zhiliatom opened a new pull request, #7673: URL: https://github.com/apache/rocketmq/pull/7673 ### Which Issue(s) This PR Fixes Fixes #7671 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user zhiliatom (triggered by zhiliatom). Head commit for run: 6decae3595439c0e043c0495efc37023768b3260 / zhiliatom [ISSUE #7671] filter inner producer client when report to metrics Report URL: https://github.com/apache/rocketmq/actions/runs/7244777646 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user zhiliatom (triggered by zhiliatom). Head commit for run: 80c0330f752dcf3219cb8631f3004c1725bedf1e / rongtong ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false (#7657) Report URL: https://github.com/apache/rocketmq/actions/runs/7244797278 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user zhiliatom (triggered by zhiliatom). Head commit for run: 6decae3595439c0e043c0495efc37023768b3260 / zhiliatom [ISSUE #7671] filter inner producer client when report to metrics Report URL: https://github.com/apache/rocketmq/actions/runs/7244777641 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7671] filter inner producer client when report to metrics [rocketmq]
codecov-commenter commented on PR #7673: URL: https://github.com/apache/rocketmq/pull/7673#issuecomment-1859694696 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `16 lines` in your changes are missing coverage. Please review. > Comparison is base [(`71a7a65`)](https://app.codecov.io/gh/apache/rocketmq/commit/71a7a659bed15110d1146091bfb7a51d28ade562?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.17% compared to head [(`6decae3`)](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.13%. > Report is 4 commits behind head on develop. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../rocketmq/broker/metrics/BrokerMetricsManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbWV0cmljcy9Ccm9rZXJNZXRyaWNzTWFuYWdlci5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | 25.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7673 +/- ## = - Coverage 43.17% 43.13% -0.05% - Complexity 9797 9798 +1 = Files 1165 1165 Lines 8447784486 +9 Branches 1096610968 +2 = - Hits 3647436441 -33 - Misses 4347343516 +43 + Partials4530 4529 -1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7673?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user zhiliatom (triggered by zhiliatom). Head commit for run: 6decae3595439c0e043c0495efc37023768b3260 / zhiliatom [ISSUE #7671] filter inner producer client when report to metrics Report URL: https://github.com/apache/rocketmq/actions/runs/7244777638 With regards, GitHub Actions via GitBox
