[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user gaoyf (triggered by gaoyf). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyonwriteset (#7583) * fix ISSUE #7534 * reformat code * Remove the useless unit test - Co-authored-by: RongtongJin Report URL: https://github.com/apache/rocketmq/actions/runs/7057268130 With regards, GitHub Actions via GitBox
Re: [PR] lock.lock() before try [rocketmq]
lizhimins commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835656950 在外面没什么问题。参考：https://juejin.cn/post/7269962653795270671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix slave acting master bug [rocketmq]
codecov-commenter commented on PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#issuecomment-1835658936 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `7 lines` in your changes are missing coverage. Please review. > Comparison is base [(`65faea2`)](https://app.codecov.io/gh/apache/rocketmq/commit/65faea22fd54fd9875f2ca9d3088b4dc46d31cce?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.19% compared to head [(`3509621`)](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.16%. | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...apache/rocketmq/store/timer/TimerMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...apache/rocketmq/broker/slave/SlaveSynchronize.java](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvc2xhdmUvU2xhdmVTeW5jaHJvbml6ZS5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#7603 +/- ## = - Coverage 43.19% 43.16% -0.03% - Complexity 9782 9783 +1 = Files 1162 1162 Lines 8437884381 +3 Branches 1095510957 +2 = - Hits 3645136427 -24 - Misses 4339743434 +37 + Partials4530 4520 -10 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] lock.lock() before try [rocketmq]
joeCarf commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835661113 > 在外面没什么问题。参考：https://juejin.cn/post/7269962653795270671 原写法是写到里面了，这个pr是改到外面的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] lock.lock() before try [rocketmq]
shenjianeng commented on PR #7582:
URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835681345
> 在外面没什么问题。参考：https://juejin.cn/post/7269962653795270671
看下 jdk
的官方文档建议吧，https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/ReentrantLock.html
> It is recommended practice to *always* immediately follow a call to `lock`
with a `try` block, most typically in a before/after construction such as:
>
> ```java
> class X {
>private final ReentrantLock lock = new ReentrantLock();
>// ...
>
>public void m() {
> lock.lock(); // block until condition holds
> try {
>// ... method body
> } finally {
>lock.unlock()
> }
>}
> }
> ```
作为开源项目，带头做好榜样。
而且上面掘金文章结尾有几句话：
> 1. 最好是把 lock.lock() 加锁方法写到 try 外面，是一种规范，而不是强制。
>
> 2. 如果你非要写到 try 里面，那么写到 try 语句块的第一行，或者 lock 加锁方法前面不会存在可能出现异常的代码。
>
> 3. 最后，如果你代码中加锁放到了 try 语句里，麻烦参考第 1 点
严格来讲，1 和 2 的结论，可能在 ReentrantLock 这个实现下是没问题的，但 lock 是接口，会有任意实现多种实现。
在不同的实现下，lock.lock() 方法抛出异常是很有可能的，因此不能放在 try 当中。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user gaoyf (triggered by gaoyf). Head commit for run: 350962115900b3c376395c354f8f4881c5fa205d / yongfeigao fix timerCheckPoint of the master is not updated, causing the timer message to be replayed after master is restarted Report URL: https://github.com/apache/rocketmq/actions/runs/7057248789 With regards, GitHub Actions via GitBox
[I] 项目升级rocketmq-client 5.1.4版本后，org.apache.rocketmq.mqtt.ds.store.LmqQueueStoreManager#maxOffset 方法，报throw new MQClientException("The broker[" + queue.getBrokerName() + "] not exist", null); [rocketm
lzkisok opened a new issue, #228: URL: https://github.com/apache/rocketmq-mqtt/issues/228 原因如下：  如上图，获取不到brokerAddr 更近一步的原因是：   如上图，DefaultMQPullConsumer，没有topic，不会调用this.updateTopicRouteInfoFromNameServer(topic);导致this.brokerAddrTable为空，获取失败 this.updateTopicRouteInfoFromNameServer() 方法在rocketmq-client 4.9.3版本中的写法如下图：  可以正常调用。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] 项目升级rocketmq-client 5.1.4版本后，org.apache.rocketmq.mqtt.ds.store.LmqQueueStoreManager#maxOffset 方法，报throw new MQClientException("The broker[" + queue.getBrokerName() + "] not exist", null); [roc
lzkisok commented on issue #228: URL: https://github.com/apache/rocketmq-mqtt/issues/228#issuecomment-1835810291  请问目前我的解决办法是否够优雅？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [RIP-68] RocketMQ ACL 2.0 [rocketmq]
echooymxq commented on issue #7560: URL: https://github.com/apache/rocketmq/issues/7560#issuecomment-1835936073 @dingshuangxi888 The namesrv not stateless actually. such as in controller mode, maybe the controller mode is special case. but there's some kvConfig.json about orderConf, and rocketmq-mqtt also rely on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Support Timing Messages with Arbitrary Time Delay. [rocketmq-apis]
echooymxq opened a new issue, #83: URL: https://github.com/apache/rocketmq-apis/issues/83 When there are clock issues on the client and server side, it can cause timer message deliver not correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Support Timing Messages with Arbitrary Time Delay. [rocketmq-apis]
fanlunyong commented on issue #83: URL: https://github.com/apache/rocketmq-apis/issues/83#issuecomment-1836368538 这是来自QQ邮箱的自动回复邮件。 您好，请您放心您的邮件我已经收到。我将在看过邮件后，尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Support Timing Messages with Arbitrary Time Delay.(#83) [rocketmq-apis]
echooymxq opened a new pull request, #84: URL: https://github.com/apache/rocketmq-apis/pull/84 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]
echooymxq opened a new issue, #643: URL: https://github.com/apache/rocketmq-clients/issues/643 ### Programming Language of the Client Not related to the specified programming language ### Is Your Feature Request Related to a Problem? When there are clock issues on the client and server side, it can cause timer message deliver not correct. ### Describe the Solution You'd Like The deliver timestamp and deliver delay time is optional, higher priority for the timestamp. ### Describe Alternatives You've Considered N/A ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]
echooymxq commented on issue #643: URL: https://github.com/apache/rocketmq-clients/issues/643#issuecomment-1836425287 link https://github.com/apache/rocketmq-apis/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Trigger a build for rocketmq [rocketmq]
Aishwarya-Lad opened a new pull request, #7605: URL: https://github.com/apache/rocketmq/pull/7605 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Trigger a build for rocketmq [rocketmq]
Aishwarya-Lad closed pull request #7605: Trigger a build for rocketmq URL: https://github.com/apache/rocketmq/pull/7605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Test ti pr 2 [rocketmq]
Aishwarya-Lad opened a new pull request, #7606: URL: https://github.com/apache/rocketmq/pull/7606 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support Timing Messages with Arbitrary Time Delay.(#83) [rocketmq-apis]
lizhanhui commented on PR #84: URL: https://github.com/apache/rocketmq-apis/pull/84#issuecomment-1837001012 It's true that there is some nuance between delay-delivery-message and scheduled-message when time source is considered. But, IMO, we may offer two API for them using the same underlying implementation. Aka, express the concept of delay-delivery through existing `delivery_timestamp` field as [JMS 2.0 Spec](https://www.ibm.com/docs/en/ibm-mq/8.0?topic=functionality-jms-20-delivery-delay) > With JMS 2.0, you can specify a delivery delay when sending a message. The queue manager does not deliver the message until after the specified delivery delay has elapsed. > An application can specify a delivery delay in milliseconds, when it sends a message, by using either MessageProducer.setDeliveryDelay(long deliveryDelay) or JMSProducer.setDeliveryDelay(long deliveryDelay). **This value is added to the time at which the message is sent and gives the earliest time at which any other application can get that message**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]
lizhanhui commented on issue #643: URL: https://github.com/apache/rocketmq-clients/issues/643#issuecomment-1837001863 @echooymxq Left a message [here](https://github.com/apache/rocketmq-apis/pull/84#issuecomment-1837001012) and look forward to your feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix slave acting master bug [rocketmq]
joeCarf commented on code in PR #7603:
URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1412724350
##
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##
@@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt
msgExt, boolean needRoll)
} else {
msgInner.setTopic(msgInner.getProperty(MessageConst.PROPERTY_REAL_TOPIC));
msgInner.setQueueId(Integer.parseInt(msgInner.getProperty(MessageConst.PROPERTY_REAL_QUEUE_ID)));
-MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_TOPIC);
-MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_QUEUE_ID);
+// MessageAccessor.clearProperty(msgInner,
MessageConst.PROPERTY_REAL_TOPIC);
Review Comment:
could you explain why comment these lines and how the second bug occurs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
