[I] Controller pod controllerDLegerPeers wrong address [rocketmq-operator]

2023-11-16 Thread via GitHub


drivebyer opened a new issue, #193:
URL: https://github.com/apache/rocketmq-operator/issues/193

   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   apply cr:
   ```
   apiVersion: rocketmq.apache.org/v1alpha1
   kind: Controller
   metadata:
 name: rmq-wy-controller
 namespace: mcamel-system
   spec:
 affinity:
   podAntiAffinity:
 preferredDuringSchedulingIgnoredDuringExecution:
 - podAffinityTerm:
 labelSelector:
   matchLabels:
 app: controller
 controller_cr: rmq-wy-controller-controller
 topologyKey: kubernetes.io/hostname
   weight: 60
 controllerImage: ghcr.m.daocloud.io/ksmartdata/rocketmq-controller:v5.1.4
 hostPath: /data/rocketmq/controller
 imagePullPolicy: IfNotPresent
 resources:
   limits:
 cpu: "1"
 memory: 2Gi
   requests:
 cpu: 500m
 memory: 1Gi
 size: 1
 storageMode: EmptyDir
 volumeClaimTemplates:
 - metadata:
 name: controller-storage
   spec:
 accessModes:
 - ReadWriteOnce
 resources:
   requests:
 storage: 8Gi
   status: {}
   ```
   
   - What did you expect to see?
   the k8s create pod with such environment:
   ```
   - name: controllerDLegerPeers
  value: 
rmq-wy-controller0-rmq-wy-controller-0.rmq-wy-controller-svc-headless:9878
   ```
   
   The address is wrong:
   https://github.com/apache/rocketmq-operator/assets/32033618/36a8409e-00fa-444e-a553-b1960a29b3ef";>
   
   
   - What did you see instead?
   the address should be `rmq-wy-controller-0.rmq-wy-controller-svc-headless`, 
see:
   https://github.com/apache/rocketmq-operator/assets/32033618/2d91090b-4a9d-480f-95aa-0b7a48d25421";>
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions how to fix, etc):


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Enhancement] transactionProducer get the topic route before sending the message [rocketmq]

2023-11-16 Thread via GitHub


panzhi33 opened a new issue, #7567:
URL: https://github.com/apache/rocketmq/issues/7567

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   当前topic是和message绑定的,只有发送消息了才能获取到topic 
route。因此服务重启后,事务消息Producer必须发送一条消息后才能回查之前的半事务消息。
   在业务流量比较低的时候,服务重启后可能很长时间业务都不会发送事务消息,导致在此期间,之前发送的半事务消息一直不会回查,降低了消息的时效性。
   
   The current topic is bound to message, and the topic route can only be 
obtained when a message is sent. Therefore, after the service is restarted, the 
transactionProducer must send a message before it can check the previous 
semi-transaction message.
   When business traffic is relatively low, the business may not send 
transaction messages for a long time after the service is restarted. As a 
result, during this period, previously sent semi-transaction messages will not 
be check, reducing the timeliness of the messages.
   
   ### Motivation
   
   transactionProducer get the topic route before sending the message
   
   ### Describe the Solution You'd Like
   
   transactionProducer get the topic route before sending the message
   
   ### Describe Alternatives You've Considered
   
   no
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [ISSUE #7567] transactionProducer get the topic route before sending the message [rocketmq]

2023-11-16 Thread via GitHub


panzhi33 opened a new pull request, #7568:
URL: https://github.com/apache/rocketmq/pull/7568

   
   
   ### Which Issue(s) This PR Fixes
   
   
   
   Fixes #issue_id
   
   ### Brief Description
   
   
   
   ### How Did You Test This Change?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #7567] transactionProducer get the topic route before sending the message [rocketmq]

2023-11-16 Thread via GitHub


panzhi33 closed pull request #7568: [ISSUE #7567] transactionProducer get the 
topic route before sending the message
URL: https://github.com/apache/rocketmq/pull/7568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [ISSUE #7567] transactionProducer get the topic route before sending the message [rocketmq]

2023-11-16 Thread via GitHub


panzhi33 opened a new pull request, #7569:
URL: https://github.com/apache/rocketmq/pull/7569

   
   
   ### Which Issue(s) This PR Fixes
   
   
   
   Fixes #issue_id
   
   ### Brief Description
   
   
   
   ### How Did You Test This Change?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Coverage" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
94709c6ca7b40c9ef60f49f219977e4392407a9d / zhouxiang 

Use : as separator

Report URL: https://github.com/apache/rocketmq/actions/runs/6888585591

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
94709c6ca7b40c9ef60f49f219977e4392407a9d / zhouxiang 

Use : as separator

Report URL: https://github.com/apache/rocketmq/actions/runs/6888585590

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
94709c6ca7b40c9ef60f49f219977e4392407a9d / zhouxiang 

Use : as separator

Report URL: https://github.com/apache/rocketmq/actions/runs/6888585592

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user panzhi33 (triggered by panzhi33).

Head commit for run:
651a5ca992988b90c7e4884e9975db0938557def / Jixiang Jin 
[ISSUE #7562] BugFix for estimating message accumulation correctly (#7563)

Report URL: https://github.com/apache/rocketmq/actions/runs/6888486277

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user panzhi33 (triggered by panzhi33).

Head commit for run:
651a5ca992988b90c7e4884e9975db0938557def / Jixiang Jin 
[ISSUE #7562] BugFix for estimating message accumulation correctly (#7563)

Report URL: https://github.com/apache/rocketmq/actions/runs/6888518804

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Coverage" is working again!

2023-11-16 Thread GitBox


The GitHub Actions job "Coverage" on rocketmq.git has succeeded.
Run started by GitHub user panzhi33 (triggered by panzhi33).

Head commit for run:
a49206ff302ad9aef488cccae1d75bb7ac272c0c / panzhi33 
transactionProducer get the topic route before sending the message

Report URL: https://github.com/apache/rocketmq/actions/runs/6888459958

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user drpmma (triggered by drpmma).

Head commit for run:
651a5ca992988b90c7e4884e9975db0938557def / Jixiang Jin 
[ISSUE #7562] BugFix for estimating message accumulation correctly (#7563)

Report URL: https://github.com/apache/rocketmq/actions/runs/6888611075

With regards,
GitHub Actions via GitBox



[PR] [ISSUE #93] Fix controller peers address string [rocketmq-operator]

2023-11-16 Thread via GitHub


drivebyer opened a new pull request, #194:
URL: https://github.com/apache/rocketmq-operator/pull/194

   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   **Please go through this checklist to help us incorporate your contribution 
quickly and easily.**
   
   Notice: `It would be helpful if you could finish the following checklist 
(the last one is not necessary) before request the community to review your PR`.
   
   - [ ] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq-operator/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a Github issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Check RBAC rights for Kubernetes roles.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. 
   - [ ] Run `make docker-build` to build docker image for operator, try your 
changes from Pod inside your Kubernetes cluster, **not just locally**. Also 
provide screenshots to show that the RocketMQ cluster is healthy after the 
changes. 
   - [ ] Before committing your changes, remember to run `make manifests` to 
make sure the CRD files are updated. 
   - [ ] Update documentation if necessary.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user panzhi33 (triggered by panzhi33).

Head commit for run:
a49206ff302ad9aef488cccae1d75bb7ac272c0c / panzhi33 
transactionProducer get the topic route before sending the message

Report URL: https://github.com/apache/rocketmq/actions/runs/6888459955

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user panzhi33 (triggered by panzhi33).

Head commit for run:
a49206ff302ad9aef488cccae1d75bb7ac272c0c / panzhi33 
transactionProducer get the topic route before sending the message

Report URL: https://github.com/apache/rocketmq/actions/runs/6888490863

With regards,
GitHub Actions via GitBox



Re: [PR] Update 02RocketMQEventBridgeOverview.md [rocketmq-site]

2023-11-16 Thread via GitHub


RongtongJin merged PR #604:
URL: https://github.com/apache/rocketmq-site/pull/604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-site) branch new-official-website updated: Update 02RocketMQEventBridgeOverview.md (#604)

2023-11-16 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch new-official-website
in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git


The following commit(s) were added to refs/heads/new-official-website by this 
push:
 new 39d5fd21a8 Update 02RocketMQEventBridgeOverview.md (#604)
39d5fd21a8 is described below

commit 39d5fd21a883fd5252e500a31e3e21d5815b4451
Author: obbo <48118455+ozw...@users.noreply.github.com>
AuthorDate: Thu Nov 16 18:12:09 2023 +0800

Update 02RocketMQEventBridgeOverview.md (#604)

更新两处文字错误。
---
 .../version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md 
b/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
index 5644cbfb65..aa90c39120 100644
--- a/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
+++ b/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
@@ -97,9 +97,9 @@ B:完全解耦方式
 
事件格式用来描述事件的具体内容。这相当于市场经济的一个买卖契约。生产者发送的事件格式是什么,得确定下来,不能总是变;消费者以什么格式接收事件也得确定下来,不然整个市场就乱套了。
 
 **第4. 订阅"规则":**
-我们得给消费者一个,把投递事件到目标端的能力,并且投递前可以对事件进行过滤和转换,让它可以适配目标端API接收参数的格式,我们把这个过程叫做创建订阅规则。
+我们得给消费者一个,把事件投递到目标端的能力,并且投递前可以对事件进行过滤和转换,让它可以适配目标端API接收参数的格式,我们把这个过程叫做创建订阅规则。
 
 **第5. 事件总线:**
-最后我们还得有一个存储事件的地方,就是最图中最中间的事件总线。
+最后我们还得有一个存储事件的地方,就是下图中最中间的事件总线。
 
-![image](../picture/07eventbridge/HowEventBridgeWork.png)
\ No newline at end of file
+![image](../picture/07eventbridge/HowEventBridgeWork.png)



Re: [PR] Optimization 01RocketMQConnectOverview.md and 02RocketMQEventBridgeOverview.md description [rocketmq-site]

2023-11-16 Thread via GitHub


RongtongJin merged PR #601:
URL: https://github.com/apache/rocketmq-site/pull/601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-site) branch new-official-website updated: Optimization 01RocketMQConnectOverview.md and 02RocketMQEventBridgeOverview.md description (#601)

2023-11-16 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch new-official-website
in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git


The following commit(s) were added to refs/heads/new-official-website by this 
push:
 new 5816f96274 Optimization 01RocketMQConnectOverview.md and 
02RocketMQEventBridgeOverview.md description (#601)
5816f96274 is described below

commit 5816f96274e90703e397f36e1798fc926096f05a
Author: vate <806019...@qq.com>
AuthorDate: Thu Nov 16 18:12:41 2023 +0800

Optimization 01RocketMQConnectOverview.md and 
02RocketMQEventBridgeOverview.md description (#601)

* Update 01RocketMQ Connect Overview.md

优化文档内容

* Update 01RocketMQ Connect Overview.md

* Update 01RocketMQ Connect Overview.md

* update 02RocketMQEventBridgeOverview.md

优化不通顺的地方、以及打错的部分
---
 .../07-eventbridge/02RocketMQEventBridgeOverview.md  |  8 
 .../version-5.0/10-connect/01RocketMQ Connect Overview.md| 12 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git 
a/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md 
b/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
index aa90c39120..b6def537c5 100644
--- a/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
+++ b/versioned_docs/version-5.0/07-eventbridge/02RocketMQEventBridgeOverview.md
@@ -35,7 +35,7 @@ Event,则是明确已经发生的事情。比如
 
 ### 2、无期望
 ```text
-事件是客观的描述一个事物的状态或属性值的变化,但对于如何处理事件本身并没有做任何期望。 
相比之下,Command和Query则都是有期望的,他们希望系统做出改变或则返回结果,但是Event只是客观描述系统的一个变化。
+事件是客观的描述一个事物的状态或属性值的变化,但对于如何处理事件本身并没有做任何期望。 
相比之下,Command和Query则都是有期望的,他们希望系统做出改变或者返回结果,但是Event只是客观描述系统的一个变化。
 ```
 举个例子: 交通信号灯,从绿灯变成黄灯,只是描述了一个客观事实,本身并没有客观期望。在不同国家地区,对这个事件赋予了不同的期望。 
比如,在日本黄灯等于红灯,而在俄罗斯闯黄灯是被默许的。
 
@@ -62,7 +62,7 @@ Event,则是明确已经发生的事情。比如
 对比我们常见的消息,因为上下游一般是确定的,常常为了性能和传输效率,则会做到尽可能的精简,只要满足“计划经济”指定安排的消费者需求即可。
 ## RocketMQ EventBridge 的典型应用场景
 ### 场景1:事件通知
-微服务中,我们常常会遇到需要把一个微服务中生产的消息,通知给其他消费者。这里我们对比三种方式:
+微服务中,我们常常会遇到需要把一个微服务中生产的消息,通知给其他消费者的场景。这里我们对比三种方式:
 
 A:强依赖方式
 
@@ -74,7 +74,7 @@ B:半解耦方式
 
 B:完全解耦方式
 
-这种方式下,消费者不需要引入SDK订阅Broker,只需要按照自己的业务领域模型设计API,消息服务会将上游的事件,过滤并转换成API需要的事件格式。既没有调用链路上的依赖,也没有业务上的依赖。当上游生产者的事件数据格式发生变化时,消息服务会做兼容性校验,可以拒绝生产者发送事件或则进行告警。
+这种方式下,消费者不需要引入SDK订阅Broker,只需要按照自己的业务领域模型设计API,消息服务会将上游的事件,过滤并转换成API需要的事件格式。既没有调用链路上的依赖,也没有业务上的依赖。当上游生产者的事件数据格式发生变化时,消息服务会做兼容性校验,可以拒绝生产者发送事件或者进行告警。
 
 
 ![image](../picture/07eventbridge/ThreeStages.png)
@@ -85,7 +85,7 @@ B:完全解耦方式
 ![image](../picture/07eventbridge/EventCenter.png)
 
 ## RocketMQ EventBridge 是如何工作的?
-为了解决上述两个应用场景中提到的问题,EventBridge从5个方便入手:
+为了解决上述两个应用场景中提到的问题,EventBridge从以下5个方面入手:
 
 **第1. 确定事件标准:**
 
因为事件不是给自己看的,而是给所有人看的。它没有明确的消费者,所有都是潜在的消费者。所以,我们需要规范化事件的定义,让所有人都能看得懂,一目了然。目前CNCF旗下的CloudEvent,以逐渐成为广泛的事实标准,因此,我们选取了CloudEvent
 作为我们的EventBridge的事件标准。
diff --git a/versioned_docs/version-5.0/10-connect/01RocketMQ Connect 
Overview.md b/versioned_docs/version-5.0/10-connect/01RocketMQ Connect 
Overview.md
index 4021e99dd1..119443b881 100644
--- a/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md  
+++ b/versioned_docs/version-5.0/10-connect/01RocketMQ Connect Overview.md  
@@ -1,7 +1,7 @@
 # RocketMQ Connect 概览
 
-RocketMQ 
Connect是RocketMQ数据集成重要组件,可将各种系统中的数据通过高效,可靠,流的方式,流入流出到RocketMQ,它是独立于RocketMQ的一个单独的分布式,可扩展,可容错系统,
-它具备低延时,高可靠性,高性能,低代码,扩展性强等特点,可以实现各种异构数据系统的连接,构建数据管道,ETL,CDC,数据湖等能力。
+RocketMQ 
Connect是RocketMQ数据集成重要组件,可将各种系统中的数据通过高效,可靠,流的方式,流入流出到RocketMQ,它是独立于RocketMQ的,一个单独的分布式、可扩展、可容错系统,
+它具备低延时,高可靠性,高性能,低代码,扩展性强等特点,可以实现各种异构数据系统的连接,以及构建数据管道,ETL,CDC,数据湖等能力。
 
 
 ![RocketMQ Connect Overview](../picture/32rocketmq-connect/overview.png)
@@ -16,15 +16,15 @@ RocketMQ Connect是一个独立的的分布式,可伸缩,容错的系统,
 
 ![RocketMQ Connect使用场景](../picture/32rocketmq-connect/scene.png)
 
-在业务系统中,利用MySQL完善的事务支持,处理数据的增删改,使用ElasticSearch,Solr等实现强大的搜索能力,或者将产生的业务数据同步到数据分析系统,数据湖中(例如hudi),对数据进一步处理从而让数据产生更高的价值。使用RocketMQ
 
Connect很容易实现这样的数据管道的能力,只需要配置3个任务,第一个从MySQL获取数据的任务,第二,三个是从RocketMQ消费数据到ElasticSearch,Hudi的任务,配置3个任务就实现了从MySQL到ElasticSearch,MySQL到hudi的两条数据管道,既可以满足业务中事务的需求,搜索的需求,又可以构建数据湖。
+在业务系统中,利用MySQL完善的事务支持,处理数据的增删改,使用ElasticSearch,Solr等实现强大的搜索能力,或者将产生的业务数据同步到数据分析系统,数据湖中(例如hudi),对数据进一步处理从而让数据产生更高的价值。使用RocketMQ
 
Connect很容易实现这样的数据管道的能力,只需要配置3个任务,第一个是从MySQL获取数据的任务,第二,三个是从RocketMQ消费数据到ElasticSearch,Hudi的任务,配置3个任务就实现了从MySQL到ElasticSearch,MySQL到hudi的两条数据管道,既可以满足业务对事务、搜索的需求,也可以用于构建数据湖。
 
 # CDC
 
-CDC作为ETL模式之一,可以通过近乎实时的增量捕获数据库的 INSERT、UPDATE,DELETE变化,RocketMQ 
Connect流试数据传输,具备高可用,低延时等特性,通过Connector很容易实现CDC。
+CDC作为ETL模式之一,可以近乎实时的捕获增量数据库INSERT、UPDATE,DELETE变化,RocketMQ 
Connect流试数据传输,具备高可用,低延时等特性,通过Connector很容易实现CDC。
 
 ### Connector 部署
 
-在创建Connector时,一般是通过配置完成的,Connector一般包含逻辑的Connector连接器和执行数据复制的Task即物理线程,如下图所示,两个Connector连接器和它们对应的运行Task任务。
+创建Connector,一般通过配置即可完成,Connector包含逻辑的Connector连接器和执行数据复制的Task(即物理线程),如下图所示,两个Connector连接器和它们对应的运行Task任务。
 
 ![RocketMQ Connect任务模型1](../picture/32rocketmq-connect/deploy1.png)
 
@@ -33,

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user panzhi33 (triggered by RongtongJin).

Head commit for run:
a49206ff302ad9aef488cccae1d75bb7ac272c0c / panzhi33 
transactionProducer get the topic route before sending the message

Report URL: https://github.com/apache/rocketmq/actions/runs/6888490863

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #93] Fix controller peers address string [rocketmq-operator]

2023-11-16 Thread via GitHub


drivebyer commented on PR #194:
URL: 
https://github.com/apache/rocketmq-operator/pull/194#issuecomment-1814267066

   > IMO the original implementation is correct, pls refer to the 
[example](https://rocketmq.apache.org/docs/deploymentOperations/03autofailover#embedding-the-controller-in-the-nameserver-for-deployment).
   
   Indeed, it is. I would close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #93] Fix controller peers address string [rocketmq-operator]

2023-11-16 Thread via GitHub


drivebyer closed pull request #194: [ISSUE #93] Fix controller peers address 
string
URL: https://github.com/apache/rocketmq-operator/pull/194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Controller pod controllerDLegerPeers wrong address [rocketmq-operator]

2023-11-16 Thread via GitHub


drivebyer closed issue #193: Controller pod controllerDLegerPeers wrong address
URL: https://github.com/apache/rocketmq-operator/issues/193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] Typo in README [rocketmq-operator]

2023-11-16 Thread via GitHub


caigy opened a new issue, #195:
URL: https://github.com/apache/rocketmq-operator/issues/195

   'Iamge' should be 'Image' In README: 
   `![Docker 
Iamge](https://img.shields.io/docker/image-size/apache/rocketmq-operator)`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [ISSUE #195] fix a typo in readme [rocketmq-operator]

2023-11-16 Thread via GitHub


caigy merged PR #191:
URL: https://github.com/apache/rocketmq-operator/pull/191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Typo in README [rocketmq-operator]

2023-11-16 Thread via GitHub


caigy closed issue #195: Typo in README
URL: https://github.com/apache/rocketmq-operator/issues/195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-operator) branch master updated: fix a typo in readme (#191)

2023-11-16 Thread caigy
This is an automated email from the ASF dual-hosted git repository.

caigy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq-operator.git


The following commit(s) were added to refs/heads/master by this push:
 new a866571  fix a typo in readme (#191)
a866571 is described below

commit a8665716c8028741ec106814798e39fe07e6dcaa
Author: usernameisnull 
AuthorDate: Thu Nov 16 19:35:36 2023 +0800

fix a typo in readme (#191)
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index e6e8672..ffa4cdc 100644
--- a/README.md
+++ b/README.md
@@ -8,7 +8,7 @@
 ![Docker 
Automated](https://img.shields.io/docker/automated/apache/rocketmq-operator)
 [![Docker 
Pulls](https://img.shields.io/docker/pulls/apache/rocketmq-operator)](https://hub.docker.com/r/apache/rocketmq-operator)
 [![Docker 
TAG](https://img.shields.io/docker/v/apache/rocketmq-operator?label=tags&sort=date)](https://hub.docker.com/r/apache/rocketmq-operator/tags)
-![Docker 
Iamge](https://img.shields.io/docker/image-size/apache/rocketmq-operator)
+![Docker 
Image](https://img.shields.io/docker/image-size/apache/rocketmq-operator)
 [![Average time to resolve an 
issue](http://isitmaintained.com/badge/resolution/apache/rocketmq-operator.svg)](http://isitmaintained.com/project/apache/rocketmq-operator
 "Average time to resolve an issue")
 [![Percentage of issues still 
open](http://isitmaintained.com/badge/open/apache/rocketmq-operator.svg)](http://isitmaintained.com/project/apache/rocketmq-operator
 "Percentage of issues still open")
 [![Twitter 
Follow](https://img.shields.io/twitter/follow/ApacheRocketMQ?style=social)](https://twitter.com/intent/follow?screen_name=ApacheRocketMQ)



Re: [I] [Feature Request] Add e2e test [rocketmq-operator]

2023-11-16 Thread via GitHub


caigy commented on issue #190:
URL: 
https://github.com/apache/rocketmq-operator/issues/190#issuecomment-1814276730

   Good idea. It'll be valuable for improving quality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] RocketMQ 4.9.2 unsupport subscribe 2 topic with 1 consumer group in 2 process [rocketmq]

2023-11-16 Thread via GitHub


github-actions[bot] closed issue #5473: RocketMQ 4.9.2 unsupport subscribe 2 
topic with 1 consumer group in 2 process
URL: https://github.com/apache/rocketmq/issues/5473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] RocketMQ 4.9.2 unsupport subscribe 2 topic with 1 consumer group in 2 process [rocketmq]

2023-11-16 Thread via GitHub


github-actions[bot] commented on issue #5473:
URL: https://github.com/apache/rocketmq/issues/5473#issuecomment-1815524161

   This issue was closed because it has been inactive for 3 days since being 
marked as stale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] consumeExecutor use LinkedBlockingQueue which is not bounded as param of ThreadPoolExecutor [rocketmq]

2023-11-16 Thread via GitHub


github-actions[bot] commented on issue #5417:
URL: https://github.com/apache/rocketmq/issues/5417#issuecomment-1815524182

   This issue is stale because it has been open for 365 days with no activity. 
It will be closed in 3 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [RIP-67] RocketMQ ACL 2.0 [rocketmq]

2023-11-16 Thread via GitHub


BeiQiaoT commented on issue #7560:
URL: https://github.com/apache/rocketmq/issues/7560#issuecomment-1815577388

   Wow~ looking forward to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[I] [Bug] PopProcessQueue's lastPopTimestamp defaults to 0, resulting in rebalance failed [rocketmq]

2023-11-16 Thread via GitHub


HScarb opened a new issue, #7570:
URL: https://github.com/apache/rocketmq/issues/7570

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   Ubuntu 22.04.1 LTS
   
   ### RocketMQ version
   
   RocketMQ 5.1.4
   
   ### JDK Version
   
   JDK 8
   
   ### Describe the Bug
   
   The field `lastPopTimestamp` in PopProcessQueue is not explicitly assigned a 
default value, it will default to 0, resulting in immediate expiration when pop 
consuming.
   
   ### Steps to Reproduce
   
   1. Create a topic `TopicTest` in a cluster with 2 brokers.
   2. Run `PopConsumer`
   
   ### What Did You Expect to See?
   
   Rebalance success with no error log.
   
   ### What Did You See Instead?
   
   Rebalance failed with error logs:
   
   ```log
   2023-11-17 10:20:33.270 ERROR [46212] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - [BUG]doRebalance, CID_JODIE_1, try remove 
unnecessary pop mq, MessageQueue [topic=TopicTest, brokerName=broker-b, 
queueId=-1], because pop is pause, so try to fixed it
   2023-11-17 10:20:33.682 ERROR [46212] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - [BUG]doRebalance, CID_JODIE_1, try remove 
unnecessary pop mq, MessageQueue [topic=TopicTest, brokerName=broker-a, 
queueId=-1], because pop is pause, so try to fixed it
   ```
   
   full log:
   ```log
   2023-11-17 10:20:30.814 INFO  [46212] [NettyClientPublicExecutor_5] 
[o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's 
notification[x.x.x.x:10931], the consumer group: CID_JODIE_1 changed, rebalance 
immediately
   2023-11-17 10:20:30.846 INFO  [46212] [RebalanceService] 
[RocketmqRemoting#?:?] - createChannel: connect remote host[x.x.x.x:10911] 
success, AbstractBootstrap$PendingRegistrationPromise@738740e1(success)
   2023-11-17 10:20:30.846 INFO  [46212] [main] [RocketmqRemoting#?:?] - 
createChannel: connect remote host[x.x.x.x:10911] success, 
AbstractBootstrap$PendingRegistrationPromise@738740e1(success)
   2023-11-17 10:20:30.846 INFO  [46212] [NettyClientWorkerThread_3] 
[RocketmqRemoting#?:?] - NETTY CLIENT PIPELINE: ACTIVE, x.x.x.x:10911
   2023-11-17 10:20:30.846 WARN  [46212] [NettyEventExecutor] 
[o.a.r.c.i.f.MQClientInstance#?:?] - sendHeartbeatToAllBrokerWithLockV2 lock 
heartBeat, but failed.
   2023-11-17 10:20:30.881 INFO  [46212] [NettyClientPublicExecutor_7] 
[o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's 
notification[100.95.190.210:10911], the consumer group: CID_JODIE_1 changed, 
rebalance immediately
   2023-11-17 10:20:30.881 INFO  [46212] [main] 
[o.a.r.c.i.f.MQClientInstance#?:?] - send heart beat to broker[broker-a 0 
100.95.190.210:10911] success
   2023-11-17 10:20:30.881 INFO  [46212] [main] 
[o.a.r.c.i.f.MQClientInstance#?:?] - HeartbeatData 
[clientID=10.173.92.229@46212#2054135766774700, producerDataSet=[ProducerData 
[groupName=CLIENT_INNER_PRODUCER]], consumerDataSet=[ConsumerData 
[groupName=CID_JODIE_1, consumeType=CONSUME_PASSIVELY, messageModel=CLUSTERING, 
consumeFromWhere=CONSUME_FROM_FIRST_OFFSET, unitMode=false, 
subscriptionDataSet=[SubscriptionData [classFilterMode=false, topic=TopicTest, 
subString=*, tagsSet=[], codeSet=[], subVersion=1700187629600, 
expressionType=TAG], SubscriptionData [classFilterMode=false, 
topic=%RETRY%CID_JODIE_1, subString=*, tagsSet=[], codeSet=[], 
subVersion=1700187629606, expressionType=TAG]
   2023-11-17 10:20:30.923 INFO  [46212] [RebalanceService] 
[o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue 
offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, 
brokerName=broker-b, queueId=0], offsetTableSize=0
   2023-11-17 10:20:30.965 INFO  [46212] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, 
MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-b, queueId=0]
   2023-11-17 10:20:30.966 INFO  [46212] [RebalanceService] 
[o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue 
offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, 
brokerName=broker-a, queueId=0], offsetTableSize=1
   2023-11-17 10:20:31.000 INFO  [46212] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, 
MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0]
   2023-11-17 10:20:31.001 INFO  [46212] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - broker rebalanced result changed. 
allocateMessageQueueStrategyName=AVG, group=CID_JODIE_1

Re: [I] consumeExecutor use LinkedBlockingQueue which is not bounded as param of ThreadPoolExecutor [rocketmq]

2023-11-16 Thread via GitHub


sunheyi6 commented on issue #5417:
URL: https://github.com/apache/rocketmq/issues/5417#issuecomment-1815654929

   > The key point what i want to express is not 'oom' but only 
'consumeThreadMin 'works as corepoolsize, param 'consumeThreadMax 'does not 
work我想表达的关键点不是'oom'而是只有'consumeThreadMin'作为corepoolsize起作用,param'consumeThreadMax'不起作用
   
   Will it be because the consumer's workload is insufficient to require 
additional threads, so consumeThreadMax does not take effect?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [ISSUE #7570] fix: add default value for lastPopTimestamp [rocketmq]

2023-11-16 Thread via GitHub


HScarb opened a new pull request, #7571:
URL: https://github.com/apache/rocketmq/pull/7571

   
   
   ### Which Issue(s) This PR Fixes
   
   
   
   Fixes #7570
   
   ### Brief Description
   
   
   
   Add default value as current time for lastPopTimestamp.
   
   ### How Did You Test This Change?
   
   
   
   Run `PopConsumer`, there are no errors in the client log.
   ```log
   2023-11-17 10:26:42.442 INFO  [66096] [NettyClientPublicExecutor_5] 
[o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's 
notification[x.x.x.x:10931], the consumer group: CID_JODIE_1 changed, rebalance 
immediately
   2023-11-17 10:26:42.475 INFO  [66096] [main] [RocketmqRemoting#?:?] - 
createChannel: connect remote host[x.x.x.x:10911] success, 
AbstractBootstrap$PendingRegistrationPromise@bf1ec20(success)
   2023-11-17 10:26:42.475 INFO  [66096] [NettyClientWorkerThread_3] 
[RocketmqRemoting#?:?] - NETTY CLIENT PIPELINE: ACTIVE, x.x.x.x:10911
   2023-11-17 10:26:42.475 WARN  [66096] [NettyEventExecutor] 
[o.a.r.c.i.f.MQClientInstance#?:?] - sendHeartbeatToAllBrokerWithLockV2 lock 
heartBeat, but failed.
   2023-11-17 10:26:42.509 INFO  [66096] [NettyClientPublicExecutor_8] 
[o.a.r.c.i.ClientRemotingProcessor#?:?] - receive broker's 
notification[x.x.x.x:10911], the consumer group: CID_JODIE_1 changed, rebalance 
immediately
   2023-11-17 10:26:42.509 INFO  [66096] [main] 
[o.a.r.c.i.f.MQClientInstance#?:?] - send heart beat to broker[broker-a 0 
x.x.x.x:10911] success
   2023-11-17 10:26:42.509 INFO  [66096] [main] 
[o.a.r.c.i.f.MQClientInstance#?:?] - HeartbeatData 
[clientID=10.173.92.229@66096#2054507404466400, producerDataSet=[ProducerData 
[groupName=CLIENT_INNER_PRODUCER]], consumerDataSet=[ConsumerData 
[groupName=CID_JODIE_1, consumeType=CONSUME_PASSIVELY, messageModel=CLUSTERING, 
consumeFromWhere=CONSUME_FROM_FIRST_OFFSET, unitMode=false, 
subscriptionDataSet=[SubscriptionData [classFilterMode=false, topic=TopicTest, 
subString=*, tagsSet=[], codeSet=[], subVersion=1700188001236, 
expressionType=TAG], SubscriptionData [classFilterMode=false, 
topic=%RETRY%CID_JODIE_1, subString=*, tagsSet=[], codeSet=[], 
subVersion=1700188001243, expressionType=TAG]
   2023-11-17 10:26:42.521 INFO  [66096] [RebalanceService] 
[o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue 
offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, 
brokerName=broker-b, queueId=0], offsetTableSize=0
   2023-11-17 10:26:42.562 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, 
MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-b, queueId=0]
   2023-11-17 10:26:42.563 INFO  [66096] [RebalanceService] 
[o.a.r.c.c.s.RemoteBrokerOffsetStore#?:?] - remove unnecessary messageQueue 
offset. group=CID_JODIE_1, mq=MessageQueue [topic=%RETRY%CID_JODIE_1, 
brokerName=broker-a, queueId=0], offsetTableSize=1
   2023-11-17 10:26:42.598 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new mq, 
MessageQueue [topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0]
   2023-11-17 10:26:42.599 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - broker rebalanced result changed. 
allocateMessageQueueStrategyName=AVG, group=CID_JODIE_1, 
topic=%RETRY%CID_JODIE_1, clientId=10.173.92.229@66096#2054507404466400, 
assignmentSet=[MessageQueueAssignment [MessageQueue=MessageQueue 
[topic=%RETRY%CID_JODIE_1, brokerName=broker-a, queueId=0], Mode=PULL], 
MessageQueueAssignment [MessageQueue=MessageQueue [topic=%RETRY%CID_JODIE_1, 
brokerName=broker-b, queueId=0], Mode=PULL]]
   2023-11-17 10:26:42.599 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - %RETRY%CID_JODIE_1 Rebalance changed, also 
update version: 1700188001243, 1700188002599
   2023-11-17 10:26:42.741 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new pop mq, 
MessageQueue [topic=TopicTest, brokerName=broker-a, queueId=-1]
   2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - doRebalance, CID_JODIE_1, add a new pop mq, 
MessageQueue [topic=TopicTest, brokerName=broker-b, queueId=-1]
   2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - broker rebalanced result changed. 
allocateMessageQueueStrategyName=AVG, group=CID_JODIE_1, topic=TopicTest, 
clientId=10.173.92.229@66096#2054507404466400, 
assignmentSet=[MessageQueueAssignment [MessageQueue=MessageQueue 
[topic=TopicTest, brokerName=broker-a, queueId=-1], Mode=POP], 
MessageQueueAssignment [MessageQueue=MessageQueue [topic=TopicTest, 
brokerName=broker-b, queueId=-1], Mode=POP]]
   2023-11-17 10:26:42.742 INFO  [66096] [RebalanceService] 
[o.a.r.c.i.c.RebalanceImpl#?:?] - TopicTest Rebalance changed, also update 
version: 1700188001236, 1700188002742
   
   ```


-- 
This is an automated message from the Apache Git Service.
To r

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has 
succeeded.
Run started by GitHub user HScarb (triggered by HScarb).

Head commit for run:
71debe63c8d16e6f0ff66e401fb352eb06b293e7 / cnScarb 
[ISSUE #7570] fix: add default value for lastPopTimestamp

Report URL: https://github.com/apache/rocketmq/actions/runs/6899155198

With regards,
GitHub Actions via GitBox



Re: [PR] [ISSUE #7570] fix: add default value for lastPopTimestamp [rocketmq]

2023-11-16 Thread via GitHub


codecov-commenter commented on PR #7571:
URL: https://github.com/apache/rocketmq/pull/7571#issuecomment-1815671484

   ## 
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   Attention: `1 lines` in your changes are missing coverage. Please review.
   > Comparison is base 
[(`651a5ca`)](https://app.codecov.io/gh/apache/rocketmq/commit/651a5ca992988b90c7e4884e9975db0938557def?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.15% compared to head 
[(`71debe6`)](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 43.09%.
   
   | 
[Files](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...rocketmq/client/impl/consumer/PopProcessQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qb3BQcm9jZXNzUXVldWUuamF2YQ==)
 | 0.00% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ## develop#7571  +/-   ##
   =
   - Coverage  43.15%   43.09%   -0.06% 
   + Complexity  9712 9705   -7 
   =
 Files   1159 1159  
 Lines  8404084041   +1 
 Branches   1092310923  
   =
   - Hits   3626636219  -47 
   - Misses 4326243302  +40 
   - Partials4512 4520   +8 
   ```
   
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7571?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed.
Run started by GitHub user HScarb (triggered by HScarb).

Head commit for run:
651a5ca992988b90c7e4884e9975db0938557def / Jixiang Jin 
[ISSUE #7562] BugFix for estimating message accumulation correctly (#7563)

Report URL: https://github.com/apache/rocketmq/actions/runs/6899172509

With regards,
GitHub Actions via GitBox



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
failed.
Run started by GitHub user HScarb (triggered by HScarb).

Head commit for run:
71debe63c8d16e6f0ff66e401fb352eb06b293e7 / cnScarb 
[ISSUE #7570] fix: add default value for lastPopTimestamp

Report URL: https://github.com/apache/rocketmq/actions/runs/6899155196

With regards,
GitHub Actions via GitBox



[I] [Bug] JDK1.8 连接就报错,换成JDK17不报错能连接 [rocketmq-clients]

2023-11-16 Thread via GitHub


DoubleJee opened a new issue, #637:
URL: https://github.com/apache/rocketmq-clients/issues/637

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq-clients/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Programming Language of the Client
   
   Java
   
   ### Runtime Platform Environment
   
   **这是jdk1.8的:**
   
   2023-11-17 11:00:47.038 INFO  [21311] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.c.SimpleConsumerImpl#?:?] - Begin to start the rocketmq simple 
consumer, clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   2023-11-17 11:00:47.040 INFO  [21311] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientImpl#?:?] - Begin to start the rocketmq client, 
clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   2023-11-17 11:00:47.041 INFO  [21311] [ClientManagerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientManagerImpl#?:?] - Begin to start the client manager, 
clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   2023-11-17 11:00:47.047 INFO  [21311] [ClientManagerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientManagerImpl#?:?] - The client manager starts successfully, 
clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   2023-11-17 11:00:47.047 INFO  [21311] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientImpl#?:?] - Begin to fetch topic(s) route data from remote 
during client startup, clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d, 
topics=[topic_post_clicks_local]
   2023-11-17 11:00:48.058 INFO  [21311] [RocketmqClientScheduler-0-1] 
[o.a.r.c.j.i.ClientManagerImpl#?:?] - Start to log statistics, 
clientVersion=**5.0.5**, clientWrapperVersion=null, clientEndpoints=隐藏先:8080, 
os description=[Mac OS X 13.4], java description=[**Oracle Corporation Java 
HotSpot(TM) 64-Bit Server VM 25.361-b09**], 
clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   2023-11-17 11:00:51.583 ERROR [21311] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.c.SimpleConsumerImpl#?:?] - Failed to start the rocketmq simple 
consumer, try to shutdown it, clientId=gzzdeMacBook-Air.local@21311@0@k2y50xh3d
   java.util.concurrent.ExecutionException: 
org.apache.rocketmq.shaded.io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: 
deadline exceeded after 2.917840542s. [buffered_nanos=2926200084, 
waiting_for_connection]
at 
org.apache.rocketmq.shaded.com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:588)
at 
org.apache.rocketmq.shaded.com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:567)
at 
org.apache.rocketmq.shaded.com.google.common.util.concurrent.FluentFuture$TrustedFuture.get(FluentFuture.java:91)
at 
org.apache.rocketmq.client.java.impl.ClientImpl.startUp(ClientImpl.java:188)
at 
org.apache.rocketmq.client.java.impl.consumer.SimpleConsumerImpl.startUp(SimpleConsumerImpl.java:93)
at 
org.apache.rocketmq.shaded.com.google.common.util.concurrent.AbstractIdleService$DelegateService$1.run(AbstractIdleService.java:62)
at 
org.apache.rocketmq.shaded.com.google.common.util.concurrent.Callables.lambda$threadRenaming$3(Callables.java:103)
at java.lang.Thread.run(Thread.java:750)
   Caused by: org.apache.rocketmq.shaded.io.grpc.StatusRuntimeException: 
DEADLINE_EXCEEDED: deadline exceeded after 2.917840542s. 
[buffered_nanos=2926200084, waiting_for_connection]
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   **这是jdk11的能正常连接,代码一样:**
   
   
   2023-11-17 11:09:19.557 INFO  [21493] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.c.SimpleConsumerImpl#?:?] - Begin to start the rocketmq simple 
consumer, clientId=gzzdeMacBook-Air.local@21493@0@k9hnmpuge
   2023-11-17 11:09:19.558 INFO  [21493] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientImpl#?:?] - Begin to start the rocketmq client, 
clientId=gzzdeMacBook-Air.local@21493@0@k9hnmpuge
   2023-11-17 11:09:19.558 INFO  [21493] [ClientManagerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientManagerImpl#?:?] - Begin to start the client manager, 
clientId=gzzdeMacBook-Air.local@21493@0@k9hnmpuge
   2023-11-17 11:09:19.560 INFO  [21493] [ClientManagerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientManagerImpl#?:?] - The client manager starts successfully, 
clientId=gzzdeMacBook-Air.local@21493@0@k9hnmpuge
   2023-11-17 11:09:19.560 INFO  [21493] [SimpleConsumerImpl-0 STARTING] 
[o.a.r.c.j.i.ClientImpl#?:?] - Begin to fetch topic(s) route data from remote 
during client startup, clientId=gzzdeMacBook-Air.local@21493@0@k9hnmpuge, 
topics=[topic_post_clicks_local]
   2023-11-17 11:09:20.561 INFO  [21493] [RocketmqClientScheduler-0-2] 
[

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-11-16 Thread via GitHub


GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396767331


##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.controller.impl;
+
+import com.alipay.sofa.jraft.Node;
+import com.alipay.sofa.jraft.RaftGroupService;
+import com.alipay.sofa.jraft.Status;
+import com.alipay.sofa.jraft.conf.Configuration;
+import com.alipay.sofa.jraft.entity.NodeId;
+import com.alipay.sofa.jraft.entity.PeerId;
+import com.alipay.sofa.jraft.entity.Task;
+import com.alipay.sofa.jraft.option.NodeOptions;
+import org.apache.commons.io.FileUtils;
+import org.apache.rocketmq.common.ControllerConfig;
+import org.apache.rocketmq.common.constant.LoggerName;
+import org.apache.rocketmq.controller.Controller;
+import org.apache.rocketmq.controller.helper.BrokerLifecycleListener;
+import org.apache.rocketmq.controller.impl.closure.ControllerClosure;
+import org.apache.rocketmq.controller.impl.task.BrokerCloseChannelRequest;
+import org.apache.rocketmq.controller.impl.task.CheckNotActiveBrokerRequest;
+import org.apache.rocketmq.controller.impl.task.GetBrokerLiveInfoRequest;
+import org.apache.rocketmq.controller.impl.task.GetSyncStateDataRequest;
+import 
org.apache.rocketmq.controller.impl.task.RaftBrokerHeartBeatEventRequest;
+import org.apache.rocketmq.remoting.ChannelEventListener;
+import org.apache.rocketmq.remoting.CommandCustomHeader;
+import org.apache.rocketmq.remoting.RemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyRemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyServerConfig;
+import org.apache.rocketmq.remoting.protocol.RemotingCommand;
+import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
+import org.apache.rocketmq.remoting.protocol.RequestCode;
+import org.apache.rocketmq.remoting.protocol.ResponseCode;
+import org.apache.rocketmq.remoting.protocol.body.SyncStateSet;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.AlterSyncStateSetRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.ElectMasterRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.GetMetaDataResponseHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.GetReplicaInfoRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.admin.CleanControllerBrokerDataRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.ApplyBrokerIdRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.GetNextBrokerIdRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.RegisterBrokerToControllerRequestHeader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+public class JRaftController implements Controller {
+private static final Logger log = 
LoggerFactory.getLogger(LoggerName.CONTROLLER_LOGGER_NAME);
+private final RaftGroupService raftGroupService;
+private final Node node;
+private final JRaftControllerStateMachine stateMachine;
+private final ControllerConfig controllerConfig;
+private final List brokerLifecycleListeners;
+private final Map peerIdToAddr;
+private final NettyRemotingServer remotingServer;
+
+public JRaftController(ControllerConfig controllerConfig,
+final ChannelEventListener channelEventListener) throws IOException {
+this.controllerConfig = controllerConfig;
+this.brokerLifecycleListeners = new ArrayList<>();
+
+final NodeOptions nodeOptions = new NodeOptions();
+
nodeOptions.setElectionTimeoutMs(controllerConfig.getjRaftElectionTimeoutMs());
+
nodeOptions.setSnapshotIntervalSecs(controllerConfig.getjRaftSnapshotIntervalSecs());
+final PeerId serverId = new PeerId();
+if (!serverId.parse(controllerConfig.getjRaftServerId())) {
+ 

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-11-16 Thread via GitHub


GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396767643


##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.controller.impl;
+
+import com.alipay.sofa.jraft.Node;
+import com.alipay.sofa.jraft.RaftGroupService;
+import com.alipay.sofa.jraft.Status;
+import com.alipay.sofa.jraft.conf.Configuration;
+import com.alipay.sofa.jraft.entity.NodeId;
+import com.alipay.sofa.jraft.entity.PeerId;
+import com.alipay.sofa.jraft.entity.Task;
+import com.alipay.sofa.jraft.option.NodeOptions;
+import org.apache.commons.io.FileUtils;
+import org.apache.rocketmq.common.ControllerConfig;
+import org.apache.rocketmq.common.constant.LoggerName;
+import org.apache.rocketmq.controller.Controller;
+import org.apache.rocketmq.controller.helper.BrokerLifecycleListener;
+import org.apache.rocketmq.controller.impl.closure.ControllerClosure;
+import org.apache.rocketmq.controller.impl.task.BrokerCloseChannelRequest;
+import org.apache.rocketmq.controller.impl.task.CheckNotActiveBrokerRequest;
+import org.apache.rocketmq.controller.impl.task.GetBrokerLiveInfoRequest;
+import org.apache.rocketmq.controller.impl.task.GetSyncStateDataRequest;
+import 
org.apache.rocketmq.controller.impl.task.RaftBrokerHeartBeatEventRequest;
+import org.apache.rocketmq.remoting.ChannelEventListener;
+import org.apache.rocketmq.remoting.CommandCustomHeader;
+import org.apache.rocketmq.remoting.RemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyRemotingServer;
+import org.apache.rocketmq.remoting.netty.NettyServerConfig;
+import org.apache.rocketmq.remoting.protocol.RemotingCommand;
+import org.apache.rocketmq.remoting.protocol.RemotingSerializable;
+import org.apache.rocketmq.remoting.protocol.RequestCode;
+import org.apache.rocketmq.remoting.protocol.ResponseCode;
+import org.apache.rocketmq.remoting.protocol.body.SyncStateSet;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.AlterSyncStateSetRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.ElectMasterRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.GetMetaDataResponseHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.GetReplicaInfoRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.admin.CleanControllerBrokerDataRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.ApplyBrokerIdRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.GetNextBrokerIdRequestHeader;
+import 
org.apache.rocketmq.remoting.protocol.header.controller.register.RegisterBrokerToControllerRequestHeader;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+
+public class JRaftController implements Controller {
+private static final Logger log = 
LoggerFactory.getLogger(LoggerName.CONTROLLER_LOGGER_NAME);
+private final RaftGroupService raftGroupService;
+private final Node node;
+private final JRaftControllerStateMachine stateMachine;
+private final ControllerConfig controllerConfig;
+private final List brokerLifecycleListeners;
+private final Map peerIdToAddr;
+private final NettyRemotingServer remotingServer;
+
+public JRaftController(ControllerConfig controllerConfig,
+final ChannelEventListener channelEventListener) throws IOException {
+this.controllerConfig = controllerConfig;
+this.brokerLifecycleListeners = new ArrayList<>();
+
+final NodeOptions nodeOptions = new NodeOptions();
+
nodeOptions.setElectionTimeoutMs(controllerConfig.getjRaftElectionTimeoutMs());
+
nodeOptions.setSnapshotIntervalSecs(controllerConfig.getjRaftSnapshotIntervalSecs());
+final PeerId serverId = new PeerId();
+if (!serverId.parse(controllerConfig.getjRaftServerId())) {
+ 

Re: [PR] Update 04transactionmessage.md [rocketmq-site]

2023-11-16 Thread via GitHub


RongtongJin merged PR #605:
URL: https://github.com/apache/rocketmq-site/pull/605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(rocketmq-site) branch new-official-website updated (5816f96274 -> 7a4a861a53)

2023-11-16 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a change to branch new-official-website
in repository https://gitbox.apache.org/repos/asf/rocketmq-site.git


from 5816f96274 Optimization 01RocketMQConnectOverview.md and 
02RocketMQEventBridgeOverview.md description (#601)
 add 7a4a861a53 Update 04transactionmessage.md (#605)

No new revisions were added by this update.

Summary of changes:
 versioned_docs/version-5.0/04-featureBehavior/04transactionmessage.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-11-16 Thread GitBox


The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has 
succeeded.
Run started by GitHub user HScarb (triggered by RongtongJin).

Head commit for run:
71debe63c8d16e6f0ff66e401fb352eb06b293e7 / cnScarb 
[ISSUE #7570] fix: add default value for lastPopTimestamp

Report URL: https://github.com/apache/rocketmq/actions/runs/6899155196

With regards,
GitHub Actions via GitBox