Re: [I] [Bug] 无法启动Broker+Proxy [rocketmq]
HappyAxin commented on issue #7520: URL: https://github.com/apache/rocketmq/issues/7520#issuecomment-1788542179 > > run `bin/mqadmin clusterList -n 127.0.0.1:9876` to check broker and namesrv started or not > > proxy启动时报错  系统是64位，之前的人装的是32位的Java，版本对不上，修改Java版本就行了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 无法启动Broker+Proxy [rocketmq]
HappyAxin closed issue #7520: [Bug] 无法启动Broker+Proxy URL: https://github.com/apache/rocketmq/issues/7520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Cluster 界面的Today Produce Count、 Today Consume Count数量不对？ [rocketmq-dashboard]
sdoqwer1poiu opened a new issue, #186: URL: https://github.com/apache/rocketmq-dashboard/issues/186 场景一（单机）： 第一步：打开Cluster界面 第二步：假如此时向单机发送12条消息，Today Produce Count与Today Consume Count都是12，此时是正确的。（下面这张图片不一致时因为我执行了场景一的步骤，可以往下看为什么回这样）  第三步：如果此时我去Message界面搜索一下消息是否发送成功，或查看消息长什么样子  第四步：我再切换到Cluster界面（没变的话点一下刷新），就可以看见Today Consume Count数量噌噌噌变化，数量越多拜变化的越吓人，如果你再去Message界面多搜索几次消息。Cluster界面的这个值还会猛增。我觉得Message界面的搜索操作应该不得影响Cluster界面的Today Consume Count值吧？！。  场景二（集群：双主）（这个就不附图片了，文字描述）： 第一步：打开Cluster界面 第二步：假如此时向集群发送12条消息，按理说broker1和broker2的Today Produce Count加起来是12，结果broker1和broker2的Today Produce Count加起来是36。相当于我程序每生产一条消息，web界面却显示我生产3条，而且这三条是随机的，但是去Message界面查询却真的只有12条消息，只是Today Produce Count的数量不正确。（同理，去Message界面界面进行查询操作后，Cluster界面的Today Consume Count数量跟【场景一】相同，也会猛增） 这两个场景都会导致不想知道rockerMQ每天到底真实生成多少，消费多少消息。相当于Cluster界面完全就没起到一个统计作用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cluster 界面的Today Produce Count、 Today Consume Count数量不对？ [rocketmq-dashboard]
sdoqwer1poiu commented on issue #186: URL: https://github.com/apache/rocketmq-dashboard/issues/186#issuecomment-1788628446 希望大佬些尽管解决一下，谢谢了！如果需要场景2的浮现，我再复现一下，项目忙，只能紧急来提个issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7523] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH [rocketmq]
RongtongJin commented on code in PR #7524:
URL: https://github.com/apache/rocketmq/pull/7524#discussion_r1378578178
##
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##
@@ -1634,12 +1634,18 @@ private void swapRequests() {
private void doCommit() {
if (!this.requestsRead.isEmpty()) {
for (GroupCommitRequest req : this.requestsRead) {
-// There may be a message in the next file, so a maximum of
-// two times the flush
-boolean flushOK =
CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset();
-for (int i = 0; i < 2 && !flushOK; i++) {
+boolean flushOK = false;
Review Comment:
How about flushOK=CommitLog.this.mappedFileQueue.getFlushedWhere() >=
req.getNextOffset() when init？ Prevent every request from flushing at least
once.
##
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##
@@ -1634,12 +1634,18 @@ private void swapRequests() {
private void doCommit() {
if (!this.requestsRead.isEmpty()) {
for (GroupCommitRequest req : this.requestsRead) {
-// There may be a message in the next file, so a maximum of
-// two times the flush
-boolean flushOK =
CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset();
-for (int i = 0; i < 2 && !flushOK; i++) {
+boolean flushOK = false;
Review Comment:
How about flushOK=CommitLog.this.mappedFileQueue.getFlushedWhere() >=
req.getNextOffset() when init？ Prevent every request from flushing at least
once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 2876500cea7bf0f4bd75b958fe8e86b3951d5952 / zfj polish Report URL: https://github.com/apache/rocketmq/actions/runs/6718192365 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6718221713 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 2876500cea7bf0f4bd75b958fe8e86b3951d5952 / zfj polish Report URL: https://github.com/apache/rocketmq/actions/runs/6718192361 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7523] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH [rocketmq]
codecov-commenter commented on PR #7524: URL: https://github.com/apache/rocketmq/pull/7524#issuecomment-1788719316 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7524?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7524](https://app.codecov.io/gh/apache/rocketmq/pull/7524?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2876500) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/26fa0501482bbf31c2a64a33f329ab9744ac3800?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (26fa050) will **increase** coverage by `0.02%`. > The diff coverage is `66.66%`. ```diff @@ Coverage Diff @@ ## develop#7524 +/- ## = + Coverage 42.98% 43.01% +0.02% - Complexity 9674 9680 +6 = Files 1158 1158 Lines 8398283987 +5 Branches 1091610917 +1 = + Hits 3610236128 +26 + Misses 4338043366 -14 + Partials4500 4493 -7 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `58.78% <66.66%> (-0.16%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7524/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 2876500cea7bf0f4bd75b958fe8e86b3951d5952 / zfj polish Report URL: https://github.com/apache/rocketmq/actions/runs/6718192355 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7523] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH [rocketmq]
fujian-zfj commented on code in PR #7524:
URL: https://github.com/apache/rocketmq/pull/7524#discussion_r1378659522
##
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##
@@ -1634,12 +1634,18 @@ private void swapRequests() {
private void doCommit() {
if (!this.requestsRead.isEmpty()) {
for (GroupCommitRequest req : this.requestsRead) {
-// There may be a message in the next file, so a maximum of
-// two times the flush
-boolean flushOK =
CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset();
-for (int i = 0; i < 2 && !flushOK; i++) {
+boolean flushOK = false;
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 6889bbb91dd8def61609b5045cd345397de97b78 / zfj add log Report URL: https://github.com/apache/rocketmq/actions/runs/6719029516 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 26fa0501482bbf31c2a64a33f329ab9744ac3800 / fuyou001 [ISSUE #7501] The broker supports idempotence in creating topics (#7502) Report URL: https://github.com/apache/rocketmq/actions/runs/6719060524 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 6889bbb91dd8def61609b5045cd345397de97b78 / zfj add log Report URL: https://github.com/apache/rocketmq/actions/runs/6719029525 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user fujian-zfj (triggered by fujian-zfj). Head commit for run: 6889bbb91dd8def61609b5045cd345397de97b78 / zfj add log Report URL: https://github.com/apache/rocketmq/actions/runs/6719029527 With regards, GitHub Actions via GitBox
Re: [I] NPE occurs when the instance username and password are not set [rocketmq]
github-actions[bot] commented on issue #5442: URL: https://github.com/apache/rocketmq/issues/5442#issuecomment-1789858094 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [code]is the refcount's set value correct? [rocketmq]
github-actions[bot] commented on issue #5440: URL: https://github.com/apache/rocketmq/issues/5440#issuecomment-1789858113 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Bug] The interface definition of queryMessage is not clear, and the query result may exceed the maxNum passed. [rocketmq]
leizhiyuan opened a new issue, #7526: URL: https://github.com/apache/rocketmq/issues/7526 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment none ### RocketMQ version 4.x, 5.x ### JDK Version _No response_ ### Describe the Bug When multiple brokers are involved, the internal implementation of this SDK is to query simultaneously and aggregate the results. In this way, each broker may return up to 64 records. Currently, there is no truncation in place for the final result, so it may exceed the parameter setting. ### Steps to Reproduce review the code ### What Did You Expect to See? return size <=maxNum ### What Did You See Instead? return size > maxNum ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] 自定义sendMessageHook的sendMessageAfter被执行多次 [rocketmq]
drpmma commented on issue #7519: URL: https://github.com/apache/rocketmq/issues/7519#issuecomment-1789981186 Maybe it is more appropriate to address this issue in [rocketmq-spring](https://github.com/apache/rocketmq-spring) repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [FEATURE REQUEST]When to upgrade to SpringBoot3 and RocketMQ 5.x？ [rocketmq-spring]
HappyAxin commented on issue #592: URL: https://github.com/apache/rocketmq-spring/issues/592#issuecomment-1790009425 Has the program stopped being maintained? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [FEATURE REQUEST]When to upgrade to SpringBoot3 and RocketMQ 5.x？ [rocketmq-spring]
HappyAxin commented on issue #592: URL: https://github.com/apache/rocketmq-spring/issues/592#issuecomment-1790011654 Why doesn't your supported version work with the latest version of RocketMQ? Don't you work together? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #7523] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH [rocketmq]
RongtongJin merged PR #7524: URL: https://github.com/apache/rocketmq/pull/7524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Bug] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH [rocketmq]
RongtongJin closed issue #7523: [Bug] message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH URL: https://github.com/apache/rocketmq/issues/7523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(rocketmq) branch develop updated: [ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524)
This is an automated email from the ASF dual-hosted git repository.
jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 46962c262c [ISSUE #7523] Message will flush timeout when
transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524)
46962c262c is described below
commit 46962c262c37554ff09afe9e02c7baf66a5ecc73
Author: fujian-zfj <2573259...@qq.com>
AuthorDate: Thu Nov 2 13:47:16 2023 +0800
[ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true
and flushDiskType=SYNC_FLUSH (#7524)
* typo int readme[ecosystem]
* enableTransientPool and sync_flush will cause flush_time_out
* polish
* add log
---
.../main/java/org/apache/rocketmq/store/CommitLog.java | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
index 3d3ee86b8f..6c3afde70f 100644
--- a/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
+++ b/store/src/main/java/org/apache/rocketmq/store/CommitLog.java
@@ -1634,12 +1634,21 @@ public class CommitLog implements Swappable {
private void doCommit() {
if (!this.requestsRead.isEmpty()) {
for (GroupCommitRequest req : this.requestsRead) {
-// There may be a message in the next file, so a maximum of
-// two times the flush
boolean flushOK =
CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset();
-for (int i = 0; i < 2 && !flushOK; i++) {
+for (int i = 0; i < 1000 && !flushOK; i++) {
CommitLog.this.mappedFileQueue.flush(0);
flushOK =
CommitLog.this.mappedFileQueue.getFlushedWhere() >= req.getNextOffset();
+if (flushOK) {
+break;
+} else {
+// When transientStorePoolEnable is true, the
messages in writeBuffer may not be committed
+// to pageCache very quickly, and flushOk here may
almost be false, so we can sleep 1ms to
+// wait for the messages to be committed to
pageCache.
+try {
+Thread.sleep(1);
+} catch (InterruptedException ignored) {
+}
+}
}
req.wakeupCustomer(flushOK ? PutMessageStatus.PUT_OK :
PutMessageStatus.FLUSH_DISK_TIMEOUT);
@@ -1846,7 +1855,7 @@ public class CommitLog implements Swappable {
// Record ConsumeQueue information
Long queueOffset = msgInner.getQueueOffset();
-// this msg maybe a inner-batch msg.
+// this msg maybe an inner-batch msg.
short messageNum = getMessageNum(msgInner);
// Transaction messages that require special handling
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 46962c262c37554ff09afe9e02c7baf66a5ecc73 / fujian-zfj <2573259...@qq.com> [ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524) * typo int readme[ecosystem] * enableTransientPool and sync_flush will cause flush_time_out * polish * add log Report URL: https://github.com/apache/rocketmq/actions/runs/6728804799 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 46962c262c37554ff09afe9e02c7baf66a5ecc73 / fujian-zfj <2573259...@qq.com> [ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524) * typo int readme[ecosystem] * enableTransientPool and sync_flush will cause flush_time_out * polish * add log Report URL: https://github.com/apache/rocketmq/actions/runs/6728804804 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 46962c262c37554ff09afe9e02c7baf66a5ecc73 / fujian-zfj <2573259...@qq.com> [ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524) * typo int readme[ecosystem] * enableTransientPool and sync_flush will cause flush_time_out * polish * add log Report URL: https://github.com/apache/rocketmq/actions/runs/6728804798 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: ac69160a47f817bc4ccfb2007dd6e7a4a57f8c2a / Dongyuan Pan fix unit test Report URL: https://github.com/apache/rocketmq/actions/runs/6729031727 With regards, GitHub Actions via GitBox
[I] [Feature] Need Support JDK21!!! [rocketmq]
HappyAxin opened a new issue, #7527: URL: https://github.com/apache/rocketmq/issues/7527 ### Is Your Feature Request Related to a Problem? None ### Describe the Solution You'd Like  ### Describe Alternatives You've Considered Need Support JDK21!!! ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user DongyuanPan (triggered by DongyuanPan). Head commit for run: 46962c262c37554ff09afe9e02c7baf66a5ecc73 / fujian-zfj <2573259...@qq.com> [ISSUE #7523] Message will flush timeout when transientStorePoolEnable=true and flushDiskType=SYNC_FLUSH (#7524) * typo int readme[ecosystem] * enableTransientPool and sync_flush will cause flush_time_out * polish * add log Report URL: https://github.com/apache/rocketmq/actions/runs/6729058275 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7511]Lock granularity issue causing LMQ message loss [rocketmq]
codecov-commenter commented on PR #7525: URL: https://github.com/apache/rocketmq/pull/7525#issuecomment-1790163918 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7525](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ac69160) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/26fa0501482bbf31c2a64a33f329ab9744ac3800?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (26fa050) will **increase** coverage by `0.06%`. > Report is 1 commits behind head on develop. > The diff coverage is `74.01%`. ```diff @@ Coverage Diff @@ ## develop#7525 +/- ## = + Coverage 42.98% 43.05% +0.06% - Complexity 9674 9692 +18 = Files 1158 1159 +1 Lines 8398284041 +59 Branches 1091610923 +7 = + Hits 3610236183 +81 + Misses 4338043350 -30 - Partials4500 4508 +8 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...n/java/org/apache/rocketmq/store/ConsumeQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbnN1bWVRdWV1ZS5qYXZh) | `67.73% <100.00%> (-0.29%)` | :arrow_down: | | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `46.64% <ø> (ø)` | | | [...ocketmq/store/queue/AbstractConsumeQueueStore.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL0Fic3RyYWN0Q29uc3VtZVF1ZXVlU3RvcmUuamF2YQ==) | `94.11% <100.00%> (+0.56%)` | :arrow_up: | | [...ache/rocketmq/store/queue/QueueOffsetOperator.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL1F1ZXVlT2Zmc2V0T3BlcmF0b3IuamF2YQ==) | `87.80% <100.00%> (ø)` | | | [...ache/rocketmq/store/queue/RocksDBConsumeQueue.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL1JvY2tzREJDb25zdW1lUXVldWUuamF2YQ==) | `38.58% <ø> (+6.13%)` | :arrow_up: | | [...pache/rocketmq/store/queue/MultiDispatchUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL011bHRpRGlzcGF0Y2hVdGlscy5qYXZh) | `61.90% <0.00%> (ø)` | | | [...rocketmq/common/message/MessageExtBrokerInner.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QnJva2VySW5uZXIuamF2YQ==) | `52.83% <0.00%> (-3.17%)` | :arrow_down: | | [.../java/org/apache/rocketmq/store/MultiDispatch.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL011bHRpRGlzcGF0Y2guamF2YQ==) | `87.09% <87.09%> (ø)` | | | [...a/org/apache/rocketmq/store/MessageExtEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N
