[PR] fix bug when create rocketmq producer [rocketmq-spring]
percyzhang opened a new pull request, #591: URL: https://github.com/apache/rocketmq-spring/pull/591 ## What is the purpose of the change fix bug when create rocket mq producer ## Brief changelog fix bug when create rocket mq producer ## Verifying this change fix bug when create rocket mq producer Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The pr template is outdated for licence and checkstyle [rocketmq]
github-actions[bot] commented on issue #5353: URL: https://github.com/apache/rocketmq/issues/5353#issuecomment-1774240351 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] The pr template is outdated for licence and checkstyle [rocketmq]
github-actions[bot] closed issue #5353: The pr template is outdated for licence and checkstyle URL: https://github.com/apache/rocketmq/issues/5353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [5318]defaultlitepullconsumer support resetoffset [rocketmq]
github-actions[bot] commented on PR #5321: URL: https://github.com/apache/rocketmq/pull/5321#issuecomment-1774240376 This PR was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [5318]defaultlitepullconsumer support resetoffset [rocketmq]
github-actions[bot] closed pull request #5321: [5318]defaultlitepullconsumer support resetoffset URL: https://github.com/apache/rocketmq/pull/5321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" is working again!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6607115932 With regards, GitHub Actions via GitBox
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
tensory2022 commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1774373252 @joeCarf I never doubt the offset will be updated to broker, what I care is whether it is done by the method updateConsumeOffset(). If not, the code comment should be corrected. In additon, you might need to think over this point: "而LocalFileOffsetStore中只会写到本地文件中" . Whether you use LocalFileOffsetStore or RemoteBrokerOffsetStore, the offset will be synchronized to broker by a scheduled service which runs every 10 seconds. I hope you understand what I'm saying, thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1774426203 i get your point, and i will submit a pr to enhance it. btw, i didn't find the `scheduled service which runs every 10 seconds` in LocalFileOffsetStore, will you plz show me the code location -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]
joeCarf opened a new pull request, #7490: URL: https://github.com/apache/rocketmq/pull/7490 ### Which Issue(s) This PR Fixes Fixes #7489 ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Code comments of updateConsumeOffset() should be corrected [rocketmq]
joeCarf commented on issue #7489: URL: https://github.com/apache/rocketmq/issues/7489#issuecomment-1774433611 plz take a look at this pr https://github.com/apache/rocketmq/pull/7490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: 3cd1ed396f0defce8f625af9624cc49afc544918 / joeCarf enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6608850367 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: d9cf5e7b6b9263c2d1c3aee6d0c7dbd69852e604 / Ao Qiao Merge branch 'apache:develop' into fix_7489 Report URL: https://github.com/apache/rocketmq/actions/runs/6608856271 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6608871014 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "E2E test for pull request" failed!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: 3968c186a59db96701ade8c343bc6a5d31ee2d24 / weihubeats [ISSUE #7231] Fix: proxy client language error (#7200) * Adding null does not update * add langeuga code * add langeuga code * add langeuga code * add langeuga code * add langeuga code * Rerun ci * Rerun ci * Rerun ci * remove redundant package imports * redundant line * modify the parameter passed as proxyContext to language * format Report URL: https://github.com/apache/rocketmq/actions/runs/6608866264 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: 3cd1ed396f0defce8f625af9624cc49afc544918 / joeCarf enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6608850412 With regards, GitHub Actions via GitBox
Re: [PR] [ISSUE #7489] Code comment enhancement in example [rocketmq]
codecov-commenter commented on PR #7490: URL: https://github.com/apache/rocketmq/pull/7490#issuecomment-1774450478 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7490?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7490](https://app.codecov.io/gh/apache/rocketmq/pull/7490?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3cd1ed3) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/f0f15b5e21acd3caf9141375be5db3ef726a2173?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f0f15b5) will **increase** coverage by `0.04%`. > Report is 2 commits behind head on develop. > The diff coverage is `n/a`. > :exclamation: Current head 3cd1ed3 differs from pull request most recent head d9cf5e7. Consider uploading reports for the commit d9cf5e7 to get more accurate results ```diff @@ Coverage Diff @@ ## develop#7490 +/- ## = + Coverage 42.93% 42.98% +0.04% - Complexity 9660 9672 +12 = Files 1161 1161 Lines 8393083933 +3 Branches 1089810898 = + Hits 3603836075 +37 + Misses 4341043385 -25 + Partials4482 4473 -9 ``` [see 17 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7490/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: 3cd1ed396f0defce8f625af9624cc49afc544918 / joeCarf enhance code comment Report URL: https://github.com/apache/rocketmq/actions/runs/6608850362 With regards, GitHub Actions via GitBox
