Re: [PR] Added the java4.x client cluster filter pull test content [rocketmq-e2e]
cryptoya commented on code in PR #51:
URL: https://github.com/apache/rocketmq-e2e/pull/51#discussion_r1361598975
##
java/e2e-v4/src/test/java/org/apache/rocketmq/client/producer/ProducerInitTest.java:
##
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.client.producer;
+
+import org.apache.rocketmq.client.exception.MQClientException;
+import org.apache.rocketmq.enums.TESTSET;
+import org.apache.rocketmq.factory.AclClient;
+import org.apache.rocketmq.frame.BaseOperate;
+import org.apache.rocketmq.remoting.RPCHook;
+import org.apache.rocketmq.utils.RandomUtils;
+import org.junit.jupiter.api.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.UUID;
+
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+
+@Tag(TESTSET.CLIENT)
+@Tag(TESTSET.SMOKE)
+public class ProducerInitTest extends BaseOperate {
+private static final Logger log =
LoggerFactory.getLogger(ProducerInitTest.class);
+private static String topic;
+
+@BeforeAll
+public static void setUpAll() {
+String methodName =
Thread.currentThread().getStackTrace()[1].getMethodName();
+topic = getTopic(methodName);
+}
+
+@BeforeEach
+public void setUp() {
+}
+
+@AfterEach
+public void tearDown() {
+}
+
+@Test
+@DisplayName("Producer is normally set,expected success")
+public void testNormalSetting() {
+try {
+DefaultMQProducer producer = new
DefaultMQProducer(RandomUtils.getStringByUUID(), rpcHook);
+producer.setNamesrvAddr(namesrvAddr);
+producer.setInstanceName(UUID.randomUUID().toString());
+producer.start();
+producer.shutdown();
+} catch (MQClientException e) {
+Assertions.fail("Send message failed, expected success, message:"
+ e.getMessage());
+}
+}
+
+
+@Disabled
+@DisplayName("The NAMESRV_ADDR setting of the Producer failed, expect
ONSClientException to throw")
+public void testErrorNameSrvAddr() {
+assertThrows(Exception.class, () -> {
+DefaultMQProducer producer = new
DefaultMQProducer(RandomUtils.getStringByUUID(), rpcHook);
+producer.setNamesrvAddr("https://www.aliyun.com";);
+producer.setInstanceName(UUID.randomUUID().toString());
+producer.start();
+producer.shutdown();
+}, "Expected ClientException to throw, but it didn't");
+}
+
+@Test
+@DisplayName("The Producer does not set the AccessKey, expect an exception
occurs when the client start")
+public void testUnsetAK() {
+assertThrows(Exception.class, () -> {
+RPCHook aclRPCHook = AclClient.getAclRPCHook(null,
account.getSecretKey());
+DefaultMQProducer producer = new
DefaultMQProducer(RandomUtils.getStringByUUID(), aclRPCHook);
+producer.setNamesrvAddr(namesrvAddr);
+producer.setInstanceName(UUID.randomUUID().toString());
+producer.start();
+producer.shutdown();
+}, "Expected ClientException to throw, but it didn't");
+}
+
+@Test
+@DisplayName("The Producer does not set the SecretKey, expect an exception
occurs when the client start")
+public void testUnsetSK() {
+assertThrows(Exception.class, () -> {
+RPCHook aclRPCHook =
AclClient.getAclRPCHook(account.getAccessKey(), "");
+DefaultMQProducer producer = new
DefaultMQProducer(RandomUtils.getStringByUUID(), aclRPCHook);
+producer.setNamesrvAddr(namesrvAddr);
+producer.setInstanceName(UUID.randomUUID().toString());
+producer.start();
+producer.shutdown();
+}, "Expected ClientException to throw, but it didn't");
+}
+
+@Disabled
+@DisplayName("The Producer does not set the Properties, expect an
exception occurs when the client start")
+public void testUnsetProperties() {
+assertThrows(Exception.class, () -> {
+DefaultMQProducer producer = new
DefaultMQProducer(RandomUtils.getStringByUUID(),(RPCHook) null);
+producer.setNamesrvAddr(namesrvAddr);
+producer
Re: [I] "GetTransport of:x.x.x.x:yyyy get timed_mutex timeout" and "No route info of this topic" error while sending mq message [rocketmq-client-cpp]
kqbi commented on issue #455: URL: https://github.com/apache/rocketmq-client-cpp/issues/455#issuecomment-1765796284 遇到了一样的问题： ``` [2023-10-17 11:43:50.265332](warning):###Current Producer@CPP CORE VERSION: 2.2.0, BUILD TIME: 17:30:34 03-26-2020[start:68] [2023-10-17 11:43:50.273087](warning):ClientID:172.17.0.1@8372#DEFAULT[showClientConfigs:259] [2023-10-17 11:43:50.273155](warning):GroupName:DEFAULT_PRODUCER[showClientConfigs:260] [2023-10-17 11:43:50.273170](warning):NameServer:172.30.33.67:9876[showClientConfigs:261] [2023-10-17 11:43:50.273181](warning):NameServerDomain:[showClientConfigs:262] [2023-10-17 11:43:50.273192](warning):NameSpace:[showClientConfigs:263] [2023-10-17 11:43:50.273203](warning):InstanceName:DEFAULT[showClientConfigs:264] [2023-10-17 11:43:50.273214](warning):UnitName:[showClientConfigs:265] [2023-10-17 11:43:50.273225](warning):PullThreadNum:8[showClientConfigs:266] [2023-10-17 11:43:50.273235](warning):TcpConnectTimeout:3000 ms[showClientConfigs:267] [2023-10-17 11:43:50.273263](warning):TcpTransportTryLockTimeout:3 s[showClientConfigs:268] [2023-10-17 11:43:50.273274](warning):EnableSsl:false[showClientConfigs:269] [2023-10-17 11:43:50.273285](warning):SslPropertyFile:/etc/rocketmq/tls.properties[showClientConfigs:270] [2023-10-17 11:43:50.273296](warning):OpenMessageTrace:false[showClientConfigs:271] [2023-10-17 11:43:50.273308](warning):SendMsgTimeout:3000 ms[logConfigs:685] [2023-10-17 11:43:50.273319](warning):CompressMsgBodyOverHowmuch:4096[logConfigs:686] [2023-10-17 11:43:50.273330](warning):MaxMessageSize:131072[logConfigs:687] [2023-10-17 11:43:50.273340](warning):CompressLevel:5[logConfigs:688] [2023-10-17 11:43:50.273351](warning):RetryTimes:5[logConfigs:689] [2023-10-17 11:43:50.273362](warning):RetryTimes4Async:1[logConfigs:690] [2023-10-17 11:43:50.273376](info):Message Trace set to false, Will not send trace messages.[dealWithMessageTrace:696] [2023-10-17 11:43:50.274316](info):m_tcpConnectTimeout:3000, m_tcpTransportTryLockTimeout:3, m_pullThreadNum:8[TcpRemotingClient:72] [2023-10-17 11:43:50.27](info):TcpRemotingClient::boost asio async service running[boost_asio_work:78] [2023-10-17 11:43:50.274403](debug):MQClientFactory construct[MQClientFactory:54] [2023-10-17 11:43:50.274793](info):MQClient start,groupname:DEFAULT_PRODUCER,clientID:172.17.0.1@8372#DEFAULT,instanceName:DEFAULT,nameserveraddr:172.30.33.67:9876[start:156] [2023-10-17 11:43:50.274810](info):DefaultMQProducerImpl:DEFAULT_PRODUCER start[start:77] [2023-10-17 11:43:50.274828](debug):registerProducer success:DEFAULT_PRODUCER[registerProducer:341] [2023-10-17 11:43:50.274844](info):updateNameServerAddressList: [172.30.33.67:9876][updateNameServerAddressList:134] [2023-10-17 11:43:50.274864](info):update Namesrv:172.30.33.67:9876[updateNameServerAddressList:159] [2023-10-17 11:43:50.274880](info):user specfied name server address: 172.30.33.67:9876[registerProducer:351] [2023-10-17 11:43:50.274893](info):MQClientFactory:172.17.0.1@8372#DEFAULT start[start:74] [2023-10-17 11:43:50.274947](warning):sendheartbeat brokeradd is empty[sendHeartbeatToAllBroker:772] [2023-10-17 11:43:50.275012](info):start scheduled task:172.17.0.1@8372#DEFAULT[startScheduledTask:891] [2023-10-17 11:43:50.285094](warning):sendheartbeat brokeradd is empty[sendHeartbeatToAllBroker:772] [2023-10-17 11:43:53.276534](info):updateTopicRouteInfo: didn't get the session_credentials from any producers and consumers, please re-intialize it if application needs authentication[getSessionCredentialsFromOneOfProducerOrConsumer:1225] [2023-10-17 11:43:53.276701](debug):updateTopicRouteInfoFromNameServer start. Topic:TBW102[updateTopicRouteInfoFromNameServer:168] [2023-10-17 11:43:53.276772](debug):before insert declared filed,MAP SIZE is:2[doBeforeRequest:43] [2023-10-17 11:43:53.276801](debug):after insert declared filed, MAP SIZE is:3[doBeforeRequest:47] [2023-10-17 11:43:53.276824](debug):total msg info are:ALIYUNTBW102, size is:12[doBeforeRequest:63] [2023-10-17 11:43:53.276992](debug):InvokeSync:[invokeSync:202] [2023-10-17 11:43:53.277015](debug):GetTransport of NameServer[GetTransport:292] [2023-10-17 11:43:53.277029](debug):--CreateNameserverTransport--[CreateNameServerTransport:368] [2023-10-17 11:43:53.277064](info):namesrvIndex is:1, index:0, namesrvaddrlist size:1[CreateNameServerTransport:389] [2023-10-17 11:43:53.277091](debug):connect to [172.30.33.67:9876].[connect:149] [2023-10-17 11:43:53.277600](info):try to connect to fd:23, addr:172.30.33.67[connect:186] [2023-10-17 11:43:53.278591](debug):socket: 23, addr: 172.30.33.67, port: 9876[buildPeerAddrPort:332] [2023-10-17 11:43:53.278757](info):eventcb: received event:80 on fd:23[eventCallback:205] [2023-10-17 11:43:53.278778](info):eventcb: connect to fd:23 successfully[event
Re: [PR] Fix unstable UtilAllTest#testCalculateFileSizeInPath on Windows [rocketmq]
mureinik commented on PR #7419: URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1765808449 I've rebased this PR on to of the current `develop` branch that includes #7445. IMHO, this is a "cleaner" solution to the same problem, although #7445 already properly fixes it. In other words, this PR does not fix any test failure anymore, but IMHO does improve the style/readability of the test. Of course, if the maintainers disagree, I'll close it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added the java4.x client cluster filter pull test content [rocketmq-e2e]
cryptoya commented on code in PR #51:
URL: https://github.com/apache/rocketmq-e2e/pull/51#discussion_r1361642543
##
java/e2e-v4/src/test/java/org/apache/rocketmq/cluster/ClusterTest.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.cluster;
+
+import org.apache.rocketmq.client.rmq.RMQNormalConsumer;
+import org.apache.rocketmq.client.rmq.RMQNormalProducer;
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.enums.TESTSET;
+import org.apache.rocketmq.factory.ConsumerFactory;
+import org.apache.rocketmq.factory.ProducerFactory;
+import org.apache.rocketmq.frame.BaseOperate;
+import org.apache.rocketmq.listener.rmq.concurrent.RMQNormalListener;
+import org.apache.rocketmq.utils.NameUtils;
+import org.apache.rocketmq.utils.RandomUtils;
+import org.apache.rocketmq.utils.VerifyUtils;
+import org.junit.jupiter.api.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Tag(TESTSET.MODEL)
+@Tag(TESTSET.SMOKE)
+public class ClusterTest extends BaseOperate {
+private final Logger log = LoggerFactory.getLogger(ClusterTest.class);
+private String tag;
+private final static int SEND_NUM = 100;
+private RMQNormalConsumer pushConsumer01;
+private RMQNormalConsumer pushConsumer02;
+private RMQNormalConsumer pushConsumer03;
+private RMQNormalConsumer pullConsumer;
+private RMQNormalProducer producer;
+
+@BeforeEach
+public void setUp() {
+tag = NameUtils.getRandomTagName();
+}
+
+@BeforeEach
+public void tearDown() {
+if (pushConsumer01 != null) {
+pushConsumer01.shutdown();
+}
+if (pushConsumer02 != null) {
+pushConsumer02.shutdown();
+}
+if (pushConsumer03 != null) {
+pushConsumer03.shutdown();
+}
+if (pullConsumer != null) {
+pullConsumer.shutdown();
+}
+if (producer != null) {
+producer.shutdown();
+}
+}
+
+@Test
+@DisplayName("Send 100 normal messages synchronously, start three
consumers on different GroupId, and expect each client to consume up to 100
messages")
Review Comment:
增加一下MessageModel为广播模式的场景
##
java/e2e-v4/src/test/java/org/apache/rocketmq/cluster/ClusterTest.java:
##
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.cluster;
+
+import org.apache.rocketmq.client.rmq.RMQNormalConsumer;
+import org.apache.rocketmq.client.rmq.RMQNormalProducer;
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.enums.TESTSET;
+import org.apache.rocketmq.factory.ConsumerFactory;
+import org.apache.rocketmq.factory.ProducerFactory;
+import org.apache.rocketmq.frame.BaseOperate;
+import org.apache.rocketmq.listener.rmq.concurrent.RMQNormalListener;
+import org.apache.rocketmq.utils.NameUtils;
+import org.apache.rocketmq.utils.RandomUtils;
+import org.apache.rocketmq.utils.VerifyUtils;
+import org.junit.jupiter.api.*;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Tag(TESTSET.MODEL)
+@Tag(TESTSET.SMOKE)
+public class ClusterTest extends BaseOperate {
+private final Logger log = LoggerFactory.getLogger(ClusterTest.class);
+private String tag;
+private final static int SEND_NUM = 100;
+private RMQNormalConsumer pushConsumer01;
+private RMQNormalConsumer pushConsumer02
[I] [Feature] ACL 远程地址配置 支持域名 [rocketmq]
jackshenonly opened a new issue, #7470:
URL: https://github.com/apache/rocketmq/issues/7470
### Is Your Feature Request Related to a Problem?
希望在acl 配置文件中，如下参数whiteRemoteAddress, globalWhiteRemoteAddresses
，支持hosts域名的配置。
`globalWhiteRemoteAddresses `
`- 127.0.0.1`
`- 192.168.3.*`
### Describe the Solution You'd Like
cat /etc/hosts
`127.0.0.1 domain1 `
`127.0.0.2 domain2 `
`127.0.0.3 domain3 `
希望达到如下效果
`globalWhiteRemoteAddresses `
`- domain1`
`- domain2 `
`- domain3`
目前这样配置的话，会有AclException
```
public OneRemoteAddressStrategy(String netaddress) {
this.netaddress = netaddress;
InetAddressValidator validator =
InetAddressValidator.getInstance();
if (!(validator.isValidInet4Address(netaddress) ||
validator.isValidInet6Address(netaddress))) {
throw new AclException(String.format("**Netaddress examine
Exception netaddress** is %s", netaddress));
}
}
```
### Describe Alternatives You've Considered
方便配置。
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GH] (rocketmq-clients): Workflow run "Build" is working again!
The GitHub Actions job "Build" on rocketmq-clients.git has succeeded. Run started by GitHub user xdkxlk (triggered by aaron-ai). Head commit for run: 19a4afc268d8f71b9289f9340a7df7a54b0cff22 / guyinyou <36399867+guyin...@users.noreply.github.com> golang: change log output location (#625) Co-authored-by: guyinyou Report URL: https://github.com/apache/rocketmq-clients/actions/runs/6529487361 With regards, GitHub Actions via GitBox
Re: [PR] Optimize ConsumeMessageOrderlyService enumerated types of comparison [rocketmq]
fqgsoftwareengineer closed pull request #7408: Optimize ConsumeMessageOrderlyService enumerated types of comparison URL: https://github.com/apache/rocketmq/pull/7408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize ConsumeMessageOrderlyService enumerated types of comparison [rocketmq]
fqgsoftwareengineer commented on code in PR #7408:
URL: https://github.com/apache/rocketmq/pull/7408#discussion_r1361788081
##
client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageOrderlyService.java:
##
@@ -86,7 +86,7 @@ public ConsumeMessageOrderlyService(DefaultMQPushConsumerImpl
defaultMQPushConsu
}
public void start() {
-if
(MessageModel.CLUSTERING.equals(ConsumeMessageOrderlyService.this.defaultMQPushConsumerImpl.messageModel()))
{
+if
(MessageModel.CLUSTERING==ConsumeMessageOrderlyService.this.defaultMQPushConsumerImpl.messageModel())
{
Review Comment:
Space formatting has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Optimize ConsumeMessageOrderlyService enumerated types of comparison [rocketmq]
fqgsoftwareengineer closed pull request #7408: Optimize ConsumeMessageOrderlyService enumerated types of comparison URL: https://github.com/apache/rocketmq/pull/7408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Optimize ConsumeMessageOrderlyService enumerated types of comparison [rocketmq]
fqgsoftwareengineer closed pull request #7408: Optimize ConsumeMessageOrderlyService enumerated types of comparison URL: https://github.com/apache/rocketmq/pull/7408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
leizhiyuan commented on issue #7461: URL: https://github.com/apache/rocketmq/issues/7461#issuecomment-1766043759 now, you can use this method, when delete this method (Incompatible，when show in release note) , there will provide a new method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? [rocketmq]
wuwen5 closed issue #7461: [Enhancement] Why is this method marked `Deprecated` and is there a new method that can be replaced? URL: https://github.com/apache/rocketmq/issues/7461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [ISSUE #523 & OSPP2023] Feature: support archetype to create connectors [rocketmq-connect]
ShannonDing merged PR #525: URL: https://github.com/apache/rocketmq-connect/pull/525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq-connect] branch master updated: [ISSUE #523 & OSPP2023] Feature: support archetype to create connectors (#525)
This is an automated email from the ASF dual-hosted git repository. dinglei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-connect.git The following commit(s) were added to refs/heads/master by this push: new 8dcf2b37 [ISSUE #523 & OSPP2023] Feature: support archetype to create connectors (#525) 8dcf2b37 is described below commit 8dcf2b37f247e2261512df8e00df7f875d4190d0 Author: Ao Qiao AuthorDate: Tue Oct 17 18:05:20 2023 +0800 [ISSUE #523 & OSPP2023] Feature: support archetype to create connectors (#525) * initial commit * commit * rename * finish source connector * finish sink connector * add license * Update README.md * Update connect-standalone.conf * support archetype * Delete README.md --- .../README.md | 36 .../rocketmq-connect-connectors-archetype/pom.xml | 37 .../META-INF/maven/archetype-metadata.xml | 66 .../main/resources/archetype-resources/README.md | 55 ++ .../src/main/resources/archetype-resources/pom.xml | 188 + .../java/config/__dbNameToCamel__BaseConfig.java | 131 ++ .../java/config/__dbNameToCamel__Constants.java| 50 ++ .../java/config/__dbNameToCamel__SinkConfig.java | 34 .../java/config/__dbNameToCamel__SourceConfig.java | 45 + .../java/helper/__dbNameToCamel__HelperClient.java | 72 .../main/java/helper/__dbNameToCamel__Record.java | 25 +++ .../java/sink/__dbNameToCamel__SinkConnector.java | 60 +++ .../main/java/sink/__dbNameToCamel__SinkTask.java | 69 .../source/__dbNameToCamel__SourceConnector.java | 60 +++ .../java/source/__dbNameToCamel__SourceTask.java | 167 ++ .../java/sink/__dbNameToCamel__SinkTaskTest.java | 86 ++ .../source/__dbNameToCamel__SourceTaskTest.java| 28 +++ .../resources/projects/basic/archetype.properties | 11 ++ .../src/test/resources/projects/basic/goal.txt | 0 19 files changed, 1220 insertions(+) diff --git a/connectors/rocketmq-connect-connectors-archetype/README.md b/connectors/rocketmq-connect-connectors-archetype/README.md new file mode 100644 index ..e9fee6f0 --- /dev/null +++ b/connectors/rocketmq-connect-connectors-archetype/README.md @@ -0,0 +1,36 @@ +## How to Use Connnector-Archetype + +1. 进入脚手架文件夹 + + ```shell + cd rocketmq-connect-connectors-archetype/ + ``` + +2. 将脚手架安装到本地 + + ```shell + mvn -e clean install + ``` + +3. 创建connector模版工程 + + ```shell + cd connectors/ + mvn archetype:generate \ +-DarchetypeGroupId=org.apache.rocketmq \ +-DarchetypeArtifactId=rocketmq-connect-connectors-archetype \ +-DarchetypeVersion=1.0-SNAPSHOT \ +-DdatabaseName= + ``` + + 例：创建Clickhouse-Connector + + ```shell + mvn archetype:generate \ +-DarchetypeGroupId=org.apache.rocketmq \ +-DarchetypeArtifactId=rocketmq-connect-connectors-archetype \ +-DarchetypeVersion=1.0-SNAPSHOT \ +-DdatabaseName=clickhouse + ``` + +4. 如上指令将创建一个connector的框架，开发者主要关心`helper/xxxHelperClient`以及`SourceTask`,`xxxSinkTask`的实现即可，剩余配置可以按需修改。 diff --git a/connectors/rocketmq-connect-connectors-archetype/pom.xml b/connectors/rocketmq-connect-connectors-archetype/pom.xml new file mode 100644 index ..6081f655 --- /dev/null +++ b/connectors/rocketmq-connect-connectors-archetype/pom.xml @@ -0,0 +1,37 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.rocketmq + rocketmq-connect-connectors-archetype + 1.0-SNAPSHOT + maven-archetype + + rocketmq-connect-connectors-archetype + + + + +org.apache.maven.archetype +archetype-packaging +3.2.1 + + + + + + + maven-archetype-plugin + 3.2.1 + + + + + + + + The Apache Software License, Version 2.0 + http://www.apache.org/licenses/LICENSE-2.0.txt + + + diff --git a/connectors/rocketmq-connect-connectors-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml b/connectors/rocketmq-connect-connectors-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml new file mode 100644 index ..ba974e82 --- /dev/null +++ b/connectors/rocketmq-connect-connectors-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml @@ -0,0 +1,66 @@ + +https://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.1.0 http://maven.apache.org/xsd/archetype-descriptor-1.1.0.xsd"; name="rocketmq-connect-connectors-archetype" + xmlns="https://maven.apache.org/plugins/maven-archetype-plugin/archetype-descriptor/1.1.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-i
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f6df61f65c12d488a52dbcceb72e5e6b57b7b27b / RongtongJin Renaming variable names from cacheAble to isCached Report URL: https://github.com/apache/rocketmq/actions/runs/6546806029 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user guyinyou (triggered by RongtongJin). Head commit for run: 880c22ff011cd2e95effae15d20458373e7539fb / guyinyou Added CRC32 check for full data Report URL: https://github.com/apache/rocketmq/actions/runs/6531735979 With regards, GitHub Actions via GitBox
Re: [I] consumeThreadMax can not work in most cases [rocketmq]
github-actions[bot] commented on issue #5290: URL: https://github.com/apache/rocketmq/issues/5290#issuecomment-1767381436 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" failed!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d73b6013825db9124e39a37db67094e34b9c3d88 / Zhouxiang Zhan [ISSUE #7330] Fix channel connect issue for goaway (#7467) * add waitChannelFuture for goaway * add body for retry channel Report URL: https://github.com/apache/rocketmq/actions/runs/6554416514 With regards, GitHub Actions via GitBox
[PR] style: polish code to pass checkstyle [rocketmq-e2e]
TheR1sing3un opened a new pull request, #53: URL: https://github.com/apache/rocketmq-e2e/pull/53 1. polish code to pass checkstyle https://github.com/apache/rocketmq-e2e/assets/87409330/460a495d-7137-430a-8814-fb3a30887ddf";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] AddBroker removes parsing configuration from body [rocketmq]
RongtongJin opened a new pull request, #7472: URL: https://github.com/apache/rocketmq/pull/7472 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f49a226e2219c3b01153865153462fb8887f7ccd / RongtongJin AddBroker removes parsing configuration from body Report URL: https://github.com/apache/rocketmq/actions/runs/629359 With regards, GitHub Actions via GitBox
Re: [PR] AddBroker removes parsing configuration from body [rocketmq]
codecov-commenter commented on PR #7472: URL: https://github.com/apache/rocketmq/pull/7472#issuecomment-1767546116 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7472](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f49a226) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/0f01df460f78c383a35338aa77eb0fda4c8f2dd3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0f01df4) will **decrease** coverage by `0.01%`. > Report is 2 commits behind head on develop. > The diff coverage is `25.00%`. ```diff @@ Coverage Diff @@ ## develop#7472 +/- ## = - Coverage 42.97% 42.97% -0.01% + Complexity 9665 9664 -1 = Files 1161 1161 Lines 8392083926 +6 Branches 1089810898 = + Hits 3606436066 +2 - Misses 4337943387 +8 + Partials4477 4473 -4 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...e/rocketmq/container/BrokerContainerProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udGFpbmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb250YWluZXIvQnJva2VyQ29udGFpbmVyUHJvY2Vzc29yLmphdmE=) | `4.16% <0.00%> (ø)` | | | [...he/rocketmq/broker/processor/PopReviveService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcFJldml2ZVNlcnZpY2UuamF2YQ==) | `36.38% <25.00%> (ø)` | | | [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://app.codecov.io/gh/apache/rocketmq/pull/7472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `40.29% <31.25%> (-0.24%)` | :arrow_down: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7472/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f49a226e2219c3b01153865153462fb8887f7ccd / RongtongJin AddBroker removes parsing configuration from body Report URL: https://github.com/apache/rocketmq/actions/runs/629366 With regards, GitHub Actions via GitBox
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: f49a226e2219c3b01153865153462fb8887f7ccd / RongtongJin AddBroker removes parsing configuration from body Report URL: https://github.com/apache/rocketmq/actions/runs/629366 With regards, GitHub Actions via GitBox
Re: [PR] AddBroker removes parsing configuration from body [rocketmq]
ShannonDing merged PR #7472: URL: https://github.com/apache/rocketmq/pull/7472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: AddBroker removes parsing configuration from body (#7472)
This is an automated email from the ASF dual-hosted git repository.
dinglei pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 82b2f8eefa AddBroker removes parsing configuration from body (#7472)
82b2f8eefa is described below
commit 82b2f8eefac157843c6ccec80d94f202c06bd195
Author: rongtong
AuthorDate: Wed Oct 18 13:51:47 2023 +0800
AddBroker removes parsing configuration from body (#7472)
---
.../org/apache/rocketmq/container/BrokerContainerProcessor.java | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git
a/container/src/main/java/org/apache/rocketmq/container/BrokerContainerProcessor.java
b/container/src/main/java/org/apache/rocketmq/container/BrokerContainerProcessor.java
index 2ac69112d7..5b825fe811 100644
---
a/container/src/main/java/org/apache/rocketmq/container/BrokerContainerProcessor.java
+++
b/container/src/main/java/org/apache/rocketmq/container/BrokerContainerProcessor.java
@@ -91,11 +91,10 @@ public class BrokerContainerProcessor implements
NettyRequestProcessor {
LOGGER.error("addBroker load config from {} failed, {}",
configPath, e);
}
} else {
-byte[] body = request.getBody();
-if (body != null) {
-String bodyStr = new String(body, MixAll.DEFAULT_CHARSET);
-brokerProperties = MixAll.string2Properties(bodyStr);
-}
+LOGGER.error("addBroker config path is empty");
+response.setCode(ResponseCode.SYSTEM_ERROR);
+response.setRemark("addBroker config path is empty");
+return response;
}
if (brokerProperties == null) {
[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user ShannonDing (triggered by ShannonDing). Head commit for run: 82b2f8eefac157843c6ccec80d94f202c06bd195 / rongtong AddBroker removes parsing configuration from body (#7472) Report URL: https://github.com/apache/rocketmq/actions/runs/6556776559 With regards, GitHub Actions via GitBox
