[GitHub] [rocketmq] wash1983 opened a new issue, #7417: [Enhancement] messagetrace config at server broker
wash1983 opened a new issue, #7417: URL: https://github.com/apache/rocketmq/issues/7417 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary messagetrace 目前是在producer 和consumer中通过enablemessagetrace 参数优由客户端控制，目前已经上了很多业务。能否在不动客户端配置的情况下在服务器端开通messagetrace，统一所有的发送，消费等运送至tracetopic.1是简化客户端的配置和修改程序的风险。2.避免某些客户端漏掉开启而躲过了记录。3.某些业务场景要求所有的都需要开启，这样也能避免客户端故意不开启造成躲过记录 ### Motivation a ### Describe the Solution You'd Like a ### Describe Alternatives You've Considered a ### Additional Context a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] mureinik opened a new issue, #7418: [Bug] UtilAllTest.testCalculateFileSizeInPath is unstable in Windows
mureinik opened a new issue, #7418: URL: https://github.com/apache/rocketmq/issues/7418 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment ``` $ mvn -v Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584) Maven home: C:\Users\allon\Downloads\apache-maven-3.9.0 Java version: 1.8.0_272, vendor: AdoptOpenJDK, runtime: C:\Program Files\AdoptOpenJDK\jdk-8.0.272.10-hotspot\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` ### RocketMQ version branch: develop Git commit: 4f1b42a7c5557bcadd6b9982a0c9bd876622c69e ### JDK Version AdoptOpenJDK 1.8.0_272 ### Describe the Bug When building the repo on the machine described above `UtilAllTest.testCalculateFileSizeInPath` fails: ``` Failed tests: UtilAllTest.testCalculateFileSizeInPath:242 expected:<0> but was:<5252> ``` ### Steps to Reproduce Run `mvn install`. I saw the failure on the machine described above, did not try with other machines. ### What Did You Expect to See? The test should pass ### What Did You See Instead? The teest fails ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] dugudongfangshuo opened a new issue, #587: 最新的版本2.2.4不支持定时消息吗
dugudongfangshuo opened a new issue, #587:
URL: https://github.com/apache/rocketmq-spring/issues/587
最新的版本2.2.4不支持定时消息吗，使用syncSendDelayTimeSecondsf方法报错：
[MyScheduler_Worker-1] ERROR
org.apache.rocketmq.spring.core.RocketMQTemplate:661 - syncSend failed.
destination:rent_house_payment_notice, message:GenericMessage
[payload={"recordid":"1707795483898519554","createTime":"2023-10-01T18:27:53.004"},
headers={id=d4a71db4-f2cc-db46-277d-e15c387d5709, timestamp=1696156073022}],
detail exception info:
org.apache.rocketmq.remoting.exception.RemotingTooMuchRequestException:
sendDefaultImpl call timeout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] shriVATSA54 opened a new pull request, #7420: Enhancement/change method name/issue7313
shriVATSA54 opened a new pull request, #7420: URL: https://github.com/apache/rocketmq/pull/7420 ### issue=> #7313 https://github.com/apache/rocketmq/issues/7313This is link for my issue. Fixes #7313  ### Brief Description There was an Enhancement change needed to change method name from addTopicToWhiteList of this TieredStoreTopicBlackListFilter class should be renamed to addTopicToBlackList . In three places it was required to change the name which I have done. **Note: This was my first ever contributions if you need some changes or if I committed mistake please do say and give feedback** ### How Did You Test This Change? I have tried running the file and are running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on issue #4933: [RIP-46] Rocketmq producer side supports idempotency
github-actions[bot] commented on issue #4933: URL: https://github.com/apache/rocketmq/issues/4933#issuecomment-174224 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-clients] github-actions[bot] commented on issue #592: [Feature] 事务消息是否可以增加异步回查方法
github-actions[bot] commented on issue #592: URL: https://github.com/apache/rocketmq-clients/issues/592#issuecomment-1742252813 This issue is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Snapshot Daily Release Automation" is working again!
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 4f1b42a7c5557bcadd6b9982a0c9bd876622c69e / ShuangxiDing [ISSUE #7410] Handle the Exception when the Proxy requests the client Co-authored-by: 徒钟 Report URL: https://github.com/apache/rocketmq/actions/runs/6374356218 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq] shriVATSA54 commented on pull request #7420: Enhancement Optimization Method Name #7313
shriVATSA54 commented on PR #7420: URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1742418362 > you can change the title like `[ISSUE #]x` As per your request I have made changes in Title. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] joeCarf commented on pull request #7420: Enhancement Optimization Method Name #7313
joeCarf commented on PR #7420: URL: https://github.com/apache/rocketmq/pull/7420#issuecomment-1742439061  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] joeCarf commented on a diff in pull request #7416: Added condition to check topic is present or not
joeCarf commented on code in PR #7416:
URL: https://github.com/apache/rocketmq/pull/7416#discussion_r1342306389
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -381,6 +381,11 @@ public void createTopic(final String addr, final String
defaultTopic, final Topi
throws RemotingException, MQBrokerException, InterruptedException,
MQClientException {
Validators.checkTopicConfig(topicConfig);
+if
(getTopicListFromNameServer(timeoutMillis).getTopicList().contains(topicConfig.getTopicName()))
{
+
Review Comment:
redundant line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] AayushSaini101 commented on a diff in pull request #7416: Added condition to check topic is present or not
AayushSaini101 commented on code in PR #7416:
URL: https://github.com/apache/rocketmq/pull/7416#discussion_r1342308776
##
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java:
##
@@ -381,6 +381,11 @@ public void createTopic(final String addr, final String
defaultTopic, final Topi
throws RemotingException, MQBrokerException, InterruptedException,
MQClientException {
Validators.checkTopicConfig(topicConfig);
+if
(getTopicListFromNameServer(timeoutMillis).getTopicList().contains(topicConfig.getTopicName()))
{
+
Review Comment:
Thank you @joeCarf I will change. Actually, i want to fetch all the topics
present in the cluster but unable to find out. I checked this approach but this
is not working, and causing a test case to fail. When i debug the test case. I
found the getTopicList() method returning null response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: c901206f68b10b71703c37059e0f3e5103a72c82 / joeCarf fix Issue7883 Report URL: https://github.com/apache/rocketmq/actions/runs/6376743169 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq]: Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user joeCarf (triggered by joeCarf). Head commit for run: c901206f68b10b71703c37059e0f3e5103a72c82 / joeCarf fix Issue7883 Report URL: https://github.com/apache/rocketmq/actions/runs/6376743175 With regards, GitHub Actions via GitBox
