[GitHub] [rocketmq]: Workflow run "PR-CI" is working again!
The GitHub Actions job "PR-CI" on rocketmq.git has succeeded. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: a35bcae2bb8f245895369c9c99e73d451dba5ba6 / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6335592999 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Bazel" failed!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: a35bcae2bb8f245895369c9c99e73d451dba5ba6 / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6335592993 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq] dingshuangxi888 opened a new issue, #7410: [Bug] Exception not handled when the Proxy requests the client.
dingshuangxi888 opened a new issue, #7410: URL: https://github.com/apache/rocketmq/issues/7410 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Linux ### RocketMQ version develop ### JDK Version Java11 ### Describe the Bug The proxy does not handle exceptions from the requesting client. ### Steps to Reproduce 1. the proxy request to client for get consumer running info. 2. the client deal with the request by timeout. 3. the proxy does not retrun the result for caller. ### What Did You Expect to See? The proxy will handle exceptions from the requesting client, and return the result for callers. ### What Did You See Instead? There is some many CompletableFuture the not deal with the execption. ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "E2E test for pull request" is working again!
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: 0a6ae4605fef4eaab6262fbd370aba887d8ae58b / tiger lee <1026203...@qq.com> [ISSUE #7396] Fix wrong word in BrokerController#doResterBrokerAll (#7397) Report URL: https://github.com/apache/rocketmq/actions/runs/6335632170 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq] codecov-commenter commented on pull request #7405: Enhancement MQClientInstance #7402
codecov-commenter commented on PR #7405: URL: https://github.com/apache/rocketmq/pull/7405#issuecomment-1738615689 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#7405](https://app.codecov.io/gh/apache/rocketmq/pull/7405?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a35bcae) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/0a6ae4605fef4eaab6262fbd370aba887d8ae58b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0a6ae46) will **decrease** coverage by `0.01%`. > The diff coverage is `90.90%`. ```diff @@ Coverage Diff @@ ## develop#7405 +/- ## = - Coverage 42.62% 42.62% -0.01% - Complexity 9462 9470 +8 = Files 1150 1150 Lines 8275082758 +8 Branches 1077910781 +2 = + Hits 3526935272 +3 - Misses 4305343066 +13 + Partials4428 4420 -8 ``` | [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://app.codecov.io/gh/apache/rocketmq/pull/7405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `45.31% <100.00%> (+0.40%)` | :arrow_up: | | [...rocketmq/client/impl/factory/MQClientInstance.java](https://app.codecov.io/gh/apache/rocketmq/pull/7405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `46.51% <87.50%> (-0.33%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7405/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: a35bcae2bb8f245895369c9c99e73d451dba5ba6 / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6335593000 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq-client-go] 0daypwn closed issue #933: topic with namespace and retry is block
0daypwn closed issue #933: topic with namespace and retry is block URL: https://github.com/apache/rocketmq-client-go/issues/933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: a35bcae2bb8f245895369c9c99e73d451dba5ba6 / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6335593001 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq] dingshuangxi888 opened a new pull request, #7411: [ISSUE #7410]Handle the Exception when the Proxy requests the client.
dingshuangxi888 opened a new pull request, #7411: URL: https://github.com/apache/rocketmq/pull/7411 ### Which Issue(s) This PR Fixes Fixes #7410 ### Brief Description The proxy does not handle exceptions from the requesting client. ### How Did You Test This Change? 1. the proxy request to client for get consumer running info. 2. the client deal with the request by timeout. 3. the proxy will retrun the result for caller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Bazel" is working again!
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: 13f1c06cbb6b96e9c195165a6217ed76d3db2f7a / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6336058419 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq]: Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: e03d3a2b41ba0abc38ff674dd8855919ab526b82 / 徒钟 Handle the Exception when the Proxy requests the client. Report URL: https://github.com/apache/rocketmq/actions/runs/6336078535 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq]: Workflow run "Coverage" is working again!
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user shirenchuang (triggered by shirenchuang). Head commit for run: 13f1c06cbb6b96e9c195165a6217ed76d3db2f7a / 石臻臻 [ISSUE #7402] Enhancement MQClientInstance (#7405) Report URL: https://github.com/apache/rocketmq/actions/runs/6336058411 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq-client-go] 0daypwn commented on issue #1051: Close the channel before sending data if the consumer has been shutdown.
0daypwn commented on issue #1051: URL: https://github.com/apache/rocketmq-client-go/issues/1051#issuecomment-1738694697 https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/consumer/consumer.go#L296-L306 consumer/consumer.go 这部分是基类 需要考虑 consumer/push_consumer.go consuemr/pull_consumer.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Maven" is working again!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user dingshuangxi888 (triggered by dingshuangxi888). Head commit for run: e03d3a2b41ba0abc38ff674dd8855919ab526b82 / 徒钟 Handle the Exception when the Proxy requests the client. Report URL: https://github.com/apache/rocketmq/actions/runs/6336078536 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #1052: [ISSUE #1051 ] Close the channel before sending data if the consumer has been shutdown.
0daypwn commented on PR #1052: URL: https://github.com/apache/rocketmq-client-go/pull/1052#issuecomment-1738724280 https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/consumer/consumer.go#L296-L306 谁写入channel，谁负责关闭 是个好习惯 在已经有 close(pq.closeChan) 之后，再 close(pq.msgCh) 这个操作完全是多余的，关闭还会导致上述写入的风险。 在 close(pq.closeChan) 之后，只要不 close(pq.msgCh)， pq.putMessage 和 pq.getMessage 即使select到 msgCh 也不会有影响。 pq.putMessage 和 pq.getMessage 之后是一定可以return的。 因此我认为可以只去掉 close(pq.msgCh) 这部分即可 @cserwen 另外 consumer/consumer.go 这部分是基类 修改需要考虑 consumer/push_consumer.go consuemr/pull_consumer.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] xdkxlk closed issue #7410: [Bug] Exception not handled when the Proxy requests the client.
xdkxlk closed issue #7410: [Bug] Exception not handled when the Proxy requests the client. URL: https://github.com/apache/rocketmq/issues/7410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] xdkxlk merged pull request #7411: [ISSUE #7410]Handle the Exception when the Proxy requests the client failed.
xdkxlk merged PR #7411: URL: https://github.com/apache/rocketmq/pull/7411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[rocketmq] branch develop updated: [ISSUE #7410] Handle the Exception when the Proxy requests the client
This is an automated email from the ASF dual-hosted git repository.
kaili pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 4f1b42a7c5 [ISSUE #7410] Handle the Exception when the Proxy requests
the client
4f1b42a7c5 is described below
commit 4f1b42a7c5557bcadd6b9982a0c9bd876622c69e
Author: ShuangxiDing
AuthorDate: Thu Sep 28 16:52:02 2023 +0800
[ISSUE #7410] Handle the Exception when the Proxy requests the client
Co-authored-by: 徒钟
---
.../proxy/remoting/channel/RemotingChannel.java| 23 --
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git
a/proxy/src/main/java/org/apache/rocketmq/proxy/remoting/channel/RemotingChannel.java
b/proxy/src/main/java/org/apache/rocketmq/proxy/remoting/channel/RemotingChannel.java
index 40946cabf8..d755fdcc49 100644
---
a/proxy/src/main/java/org/apache/rocketmq/proxy/remoting/channel/RemotingChannel.java
+++
b/proxy/src/main/java/org/apache/rocketmq/proxy/remoting/channel/RemotingChannel.java
@@ -34,6 +34,7 @@ import org.apache.rocketmq.common.utils.NetworkUtil;
import org.apache.rocketmq.logging.org.slf4j.Logger;
import org.apache.rocketmq.logging.org.slf4j.LoggerFactory;
import org.apache.rocketmq.proxy.common.channel.ChannelHelper;
+import org.apache.rocketmq.proxy.common.utils.ExceptionUtils;
import org.apache.rocketmq.proxy.common.utils.FutureUtils;
import org.apache.rocketmq.proxy.config.ConfigurationManager;
import
org.apache.rocketmq.proxy.processor.channel.ChannelExtendAttributeGetter;
@@ -158,10 +159,15 @@ public class RemotingChannel extends ProxyChannel
implements RemoteChannelConver
if (response.getCode() == ResponseCode.SUCCESS) {
ConsumerRunningInfo consumerRunningInfo =
ConsumerRunningInfo.decode(response.getBody(), ConsumerRunningInfo.class);
responseFuture.complete(new
ProxyRelayResult<>(ResponseCode.SUCCESS, "", consumerRunningInfo));
+} else {
+String errMsg = String.format("get consumer running
info failed, code:%s remark:%s", response.getCode(), response.getRemark());
+RuntimeException e = new RuntimeException(errMsg);
+responseFuture.completeExceptionally(e);
}
-String errMsg = String.format("get consumer running info
failed, code:%s remark:%s", response.getCode(), response.getRemark());
-RuntimeException e = new RuntimeException(errMsg);
-responseFuture.completeExceptionally(e);
+})
+.exceptionally(t -> {
+
responseFuture.completeExceptionally(ExceptionUtils.getRealException(t));
+return null;
});
return CompletableFuture.completedFuture(null);
} catch (Throwable t) {
@@ -183,10 +189,15 @@ public class RemotingChannel extends ProxyChannel
implements RemoteChannelConver
if (response.getCode() == ResponseCode.SUCCESS) {
ConsumeMessageDirectlyResult result =
ConsumeMessageDirectlyResult.decode(response.getBody(),
ConsumeMessageDirectlyResult.class);
responseFuture.complete(new
ProxyRelayResult<>(ResponseCode.SUCCESS, "", result));
+} else {
+String errMsg = String.format("consume message
directly failed, code:%s remark:%s", response.getCode(), response.getRemark());
+RuntimeException e = new RuntimeException(errMsg);
+responseFuture.completeExceptionally(e);
}
-String errMsg = String.format("consume message directly
failed, code:%s remark:%s", response.getCode(), response.getRemark());
-RuntimeException e = new RuntimeException(errMsg);
-responseFuture.completeExceptionally(e);
+})
+.exceptionally(t -> {
+
responseFuture.completeExceptionally(ExceptionUtils.getRealException(t));
+return null;
});
return CompletableFuture.completedFuture(null);
} catch (Throwable t) {
[GitHub] [rocketmq]: Workflow run "PUSH-CI" failed!
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user xdkxlk (triggered by xdkxlk). Head commit for run: 4f1b42a7c5557bcadd6b9982a0c9bd876622c69e / ShuangxiDing [ISSUE #7410] Handle the Exception when the Proxy requests the client Co-authored-by: 徒钟 Report URL: https://github.com/apache/rocketmq/actions/runs/6336682519 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq-client-go] 0daypwn commented on issue #1075: After mq message consumption fails, the number of the message in the retry queue continues to grow
0daypwn commented on issue #1075: URL: https://github.com/apache/rocketmq-client-go/issues/1075#issuecomment-1738794844 我认为你只是使用了错误的 option https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/consumer/push_consumer.go#L1399-L1405 WithMaxReconsumeTimes 才是正确的重试次数，默认是-1 无限重试 https://github.com/apache/rocketmq-client-go/blob/master/consumer/option.go#L270-L276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] 0daypwn commented on issue #1079: 请教，在client端设置消息的key-value怎么没在rocketmq-console上体现呀？
0daypwn commented on issue #1079: URL: https://github.com/apache/rocketmq-client-go/issues/1079#issuecomment-1738807196 你这个问题应该提在 https://github.com/apache/rocketmq-dashboard client支持With和Get https://github.com/apache/rocketmq-client-go/blob/da20ee7b0743a08ecf1fc53403f530b74eea2257/primitive/message.go#L151-L159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] redlsz opened a new issue, #7412: [Bug] Pop revive message error when the checkpoint is a reput one
redlsz opened a new issue, #7412: URL: https://github.com/apache/rocketmq/issues/7412 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment centos ### RocketMQ version 5.1.0 ### JDK Version JDK 8 ### Describe the Bug https://github.com/apache/rocketmq/assets/103550934/c2e3a238-e6b9-4a96-bf33-188b21340119";> https://github.com/apache/rocketmq/assets/103550934/a795b64c-6153-48ad-81f6-843e2b1c251a";> When get business message from store, the input brokerName is null. ### Steps to Reproduce Mock a case that will trigger reput checkpoint (org.apache.rocketmq.broker.processor.PopReviveService#rePutCK) ### What Did You Expect to See? revive success ### What Did You See Instead? revive error ### Additional Context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq]: Workflow run "Coverage" failed!
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 8ca36448db485d348e7c7cc5efc2bbdb5bf05a88 / redlsz Fix pop revive message error when reput checkpoint Report URL: https://github.com/apache/rocketmq/actions/runs/6337501227 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Maven" failed!
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 8ca36448db485d348e7c7cc5efc2bbdb5bf05a88 / redlsz Fix pop revive message error when reput checkpoint Report URL: https://github.com/apache/rocketmq/actions/runs/6337501232 With regards, GitHub Actions via GitBox
[GitHub] [rocketmq] GitPopcorn opened a new issue, #7414: [Bug] The quick-start configurations for controller mode just support broker name "broker-a"
GitPopcorn opened a new issue, #7414: URL: https://github.com/apache/rocketmq/issues/7414 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment Windows 10 21H2 19044,2006 ### RocketMQ version 5.1.3 ### JDK Version 1.8.0_341 ### Describe the Bug After replace the default broker name "broker-a" to "broker-b" in the official quick-start configurations for controller mode, the quick-start demo will not work, and the broker can not be register. ### Steps to Reproduce - Download binary release package `rocketmq-all-5.1.3-bin-release.zip`, unpack it. - Replace the default broker name "broker-a" to "broker-b" in the quick-start configurations for controller mode below: - `rocketmq-all-5.1.3-bin-release\conf\controller\quick-start\broker-n0.conf` - `rocketmq-all-5.1.3-bin-release\conf\controller\quick-start\broker-n1.conf` - Try start RocketMQ in controller mode jsut as document said, with commands below: - `rocketmq-all-5.1.3-bin-release\bin\mqnamesrv -c ..\conf\controller\quick-start\namesrv.conf` - `rocketmq-all-5.1.3-bin-release\bin\mqbroker -n localhost:9876 -c ..\conf\controller\quick-start\broker-n0.conf` - `rocketmq-all-5.1.3-bin-release\bin\mqbroker -n localhost:9876 -c ..\conf\controller\quick-start\broker-n0.conf` - `java -Xms128m -Xmx512m -jar rocketmq-dashboard-1.0.0.jar --server.port=8999 "--rocketmq.config.namesrvAddr=localhost:9876;"` - You will see all the service running well, but the dashboard just can not find correct cluster, and the admin command `rocketmq-all-5.1.3-bin-release\bin\mqadmin getSyncStateSet -a "localhost:9878" -b "broker-b"` won't return right information. - As a contrast, you can replace the broker name back and restart all the service, see how every thing goes right. - Be attention to replace the param `-b "broker-b"` to `-b "broker-a"`. ### What Did You Expect to See? The brokers register and be elected correctly with uniform broker name "broker-b" or "broker-c" or any other valid broker name that is not forbidden. ### What Did You See Instead? It only worked with default broker name "broker-a". ### Additional Context - Is there any document that have mentioned about we can not use any broker name rather than "broker-a" when using a controller mode? - And is there any description in the introduction to tell us could we set multiple master-slave broker group in one controller group? - In fact, I have also test it in my server with a CentOS as operation system, so I'm confirmed that there do be some bug or design in this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer opened a new pull request, #183: [ISSUE #176] Support manage multi cluster
drivebyer opened a new pull request, #183: URL: https://github.com/apache/rocketmq-operator/pull/183 ## What is the purpose of the change In order to manage multi cluster by one operator. ## Brief changelog XX ## Verifying this change 1. tested against old cluster() 2. tested against creating two cluster in one namespace **Please go through this checklist to help us incorporate your contribution quickly and easily.** Notice: `It would be helpful if you could finish the following checklist (the last one is not necessary) before request the community to review your PR`. - [ ] Make sure there is a [Github issue](https://github.com/apache/rocketmq-operator/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check RBAC rights for Kubernetes roles. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. - [ ] Run `make docker-build` to build docker image for operator, try your changes from Pod inside your Kubernetes cluster, **not just locally**. Also provide screenshots to show that the RocketMQ cluster is healthy after the changes. - [ ] Before committing your changes, remember to run `make manifests` to make sure the CRD files are updated. - [ ] Update documentation if necessary. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer commented on pull request #183: [ISSUE #176] Support manage multi cluster
drivebyer commented on PR #183: URL: https://github.com/apache/rocketmq-operator/pull/183#issuecomment-1739151512 PTAL @caigy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] shsun opened a new issue, #7415: transactionCheckMax and transactionCheckInterval work incorrectly
shsun opened a new issue, #7415: URL: https://github.com/apache/rocketmq/issues/7415 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I have searched the [GitHub Issues](https://github.com/apache/rocketmq/issues) and [GitHub Discussions](https://github.com/apache/rocketmq/discussions) of this repository and believe that this is not a duplicate. - [X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ. ### Runtime platform environment OS: macOS-11.2.3 ### RocketMQ version rocketmq-all-5.1.3-bin-release ### JDK Version java version "1.8.0_181" Java(TM) SE Runtime Environment (build 1.8.0_181-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode) ### Describe the Bug transactionTimeout/transactionCheckMax/transactionCheckInterval work incorrectly! ### Steps to Reproduce 1. add the 3 properties in broker.conf ``` # NOTE 以下3个(transactionTimeout/transactionCheckMax/transactionCheckInterval)回查相关的设置似乎并不生效!! # 指定TM(producer)在指定秒内应将最终确认状态发送给TC(rocket-mq-broker)，否则引发消息回查。默认为60秒。单位为毫秒. transactionTimeout=2 # 指定最多回查次数，超过后将丢弃消息并记录错误日志。默认15次。15次后还没成功就回滚. transactionCheckMax=5 # 消息回查的时间间隔, 默认为60秒. 单位为毫秒. transactionCheckInterval=2 ``` 2. start mqnamesrv, mqbroker and mqproxy one by one 3. send transaction-message but sleep 60-minutes in LocalTransaction to make the callback-function(TransactionChecker.check) be fired. 4. just return TransactionResolution.UNKNOWN in callback-function(TransactionChecker.check) 5. ### What Did You Expect to See? 1. the transactionTimeout is 20s 2. the callback-function(TransactionChecker.check) be fired 5 times. just as i set in the broker.conf 3. the transactionCheckInterval is 20s ### What Did You See Instead? Actually, i repeat my test-case 5 times with new 5 new topics, but got 5 different results. 1. the transactionTimeout in 25s~35s 2. sometimes the callback-function(TransactionChecker.check) be fired 17 times sometimes the callback-function(TransactionChecker.check) be fired 14 times sometimes the callback-function(TransactionChecker.check) be fired 15 times sometimes the callback-function(TransactionChecker.check) be fired twice in the same time, but the total times is 15. 3. the transactionCheckInterval is 30s, not 20s nor 60s. ### Additional Context In Chinese: 5次同样的测试， 得到5种不同结果。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
