[incubator-nuttx] 02/02: board: Run ./tools/refresh.sh --silent all
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 0aeb132d15ac31b48789e71785711ba8f78d5659 Author: Xiang Xiao AuthorDate: Mon Nov 8 19:47:28 2021 +0800 board: Run ./tools/refresh.sh --silent all Signed-off-by: Xiang Xiao --- boards/arm/kl/freedom-kl25z/configs/nsh/defconfig| 1 - boards/arm/kl/freedom-kl26z/configs/nsh/defconfig| 1 - boards/arm/kl/teensy-lc/configs/nsh/defconfig| 1 - boards/arm/nuc1xx/nutiny-nuc120/configs/nsh/defconfig| 1 - boards/arm/s32k1xx/s32k118evb/configs/nsh/defconfig | 1 - boards/arm/stm32/b-g431b-esc1/configs/foc_b16/defconfig | 1 + boards/arm/stm32/b-g431b-esc1/configs/foc_f32/defconfig | 1 + boards/arm/stm32/nucleo-f103rb/configs/ihm07m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f302r8/configs/ihm07m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f302r8/configs/ihm07m1_f32/defconfig | 1 + boards/arm/stm32/nucleo-f446re/configs/ihm08m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f446re/configs/ihm08m1_f32/defconfig | 1 + boards/arm/stm32/nucleo-g431rb/configs/ihm16m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-g431rb/configs/ihm16m1_f32/defconfig | 1 + boards/arm/stm32/stm32f103-minimum/configs/hello/defconfig | 1 - boards/arm/stm32/stm32ldiscovery/configs/chrono/defconfig| 1 - boards/arm/stm32/stm32ldiscovery/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/nucleo-f072rb/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/nucleo-f091rc/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/stm32f051-discovery/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/stm32f072-discovery/configs/nsh/defconfig | 1 - boards/avr/at90usb/micropendous3/configs/hello/defconfig | 1 - boards/avr/at90usb/teensy-2.0/configs/hello/defconfig| 1 - boards/avr/at90usb/teensy-2.0/configs/nsh/defconfig | 1 - boards/avr/at90usb/teensy-2.0/configs/usbmsc/defconfig | 1 - boards/avr/atmega/amber/configs/hello/defconfig | 1 - boards/avr/atmega/arduino-mega2560/configs/hello/defconfig | 1 - boards/avr/atmega/arduino-mega2560/configs/nsh/defconfig | 1 - boards/avr/atmega/moteino-mega/configs/hello/defconfig | 1 - boards/avr/atmega/moteino-mega/configs/nsh/defconfig | 1 - boards/mips/pic32mx/mirtoo/configs/nxffs/defconfig | 1 - boards/or1k/mor1kx/or1k/configs/nsh/defconfig| 1 - boards/renesas/m16c/skp16c26/configs/ostest/defconfig| 1 - boards/risc-v/bl602/bl602evb/configs/elf/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/fpu/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/gpio/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/i2c/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/nsh/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/spi/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/spiflash/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/timer/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/wifi/defconfig | 1 + boards/risc-v/fe310/hifive1-revb/configs/nsh/defconfig | 1 - boards/risc-v/litex/arty_a7/configs/nsh/defconfig| 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/buttons/defconfig | 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/nsh-itcm/defconfig | 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/nsh/defconfig | 1 - boards/z80/z8/z8encore000zco/configs/ostest/defconfig| 1 - boards/z80/z8/z8f64200100kit/configs/ostest/defconfig| 1 - boards/z80/z80/z80sim/configs/nsh/defconfig | 1 - boards/z80/z80/z80sim/configs/ostest/defconfig | 1 - 51 files changed, 10 insertions(+), 41 deletions(-) diff --git a/boards/arm/kl/freedom-kl25z/configs/nsh/defconfig b/boards/arm/kl/freedom-kl25z/configs/nsh/defconfig index 8b29866..047ef89 100644 --- a/boards/arm/kl/freedom-kl25z/configs/nsh/defconfig +++ b/boards/arm/kl/freedom-kl25z/configs/nsh/defconfig @@ -24,7 +24,6 @@ CONFIG_BOARD_LOOPSPERMSEC=2988 CONFIG_BUILTIN=y CONFIG_DEFAULT_SMALL=y CONFIG_DISABLE_MOUNTPOINT=y -CONFIG_DISABLE_MQUEUE=y CONFIG_EXAMPLES_PWM=y CONFIG_KL_TPM0=y CONFIG_KL_TPM0_PWM=y diff --git a/boards/arm/kl/freedom-kl26z/configs/nsh/defconfig b/boards/arm/kl/freedom-kl26z/configs/nsh/defconfig index 4a522a3..0427de7 100644 --- a/boards/arm/kl/freedom-kl26z/configs/nsh/defconfig +++ b/boards/arm/kl/freedom-kl26z/configs/nsh/defconfig @@ -24,7 +24,6 @@ CONFIG_BOARD_LOOPSPERMSEC=2988 CONFIG_BUILTIN=y CONFIG_DEFAULT_SMALL=y CONFIG_DISABLE_MOUNTPOINT=y -CONFIG_DISABLE_MQUEUE=y CONFIG_EXAMPLES_PWM=
[incubator-nuttx] branch master updated (b8c33e5 -> 0aeb132)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b8c33e5 esp32c3: Fix GPIO Output on pins 18 and 19 USB/JTAG new e57203e sched: Disable message queue by default when DEFAULT_SMALL equals y new 0aeb132 board: Run ./tools/refresh.sh --silent all The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: boards/arm/kl/freedom-kl25z/configs/nsh/defconfig| 1 - boards/arm/kl/freedom-kl26z/configs/nsh/defconfig| 1 - boards/arm/kl/teensy-lc/configs/nsh/defconfig| 1 - boards/arm/nuc1xx/nutiny-nuc120/configs/nsh/defconfig| 1 - boards/arm/s32k1xx/s32k118evb/configs/nsh/defconfig | 1 - boards/arm/stm32/b-g431b-esc1/configs/foc_b16/defconfig | 1 + boards/arm/stm32/b-g431b-esc1/configs/foc_f32/defconfig | 1 + boards/arm/stm32/nucleo-f103rb/configs/ihm07m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f302r8/configs/ihm07m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f302r8/configs/ihm07m1_f32/defconfig | 1 + boards/arm/stm32/nucleo-f446re/configs/ihm08m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-f446re/configs/ihm08m1_f32/defconfig | 1 + boards/arm/stm32/nucleo-g431rb/configs/ihm16m1_b16/defconfig | 1 + boards/arm/stm32/nucleo-g431rb/configs/ihm16m1_f32/defconfig | 1 + boards/arm/stm32/stm32f103-minimum/configs/hello/defconfig | 1 - boards/arm/stm32/stm32ldiscovery/configs/chrono/defconfig| 1 - boards/arm/stm32/stm32ldiscovery/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/nucleo-f072rb/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/nucleo-f091rc/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/stm32f051-discovery/configs/nsh/defconfig | 1 - boards/arm/stm32f0l0g0/stm32f072-discovery/configs/nsh/defconfig | 1 - boards/avr/at90usb/micropendous3/configs/hello/defconfig | 1 - boards/avr/at90usb/teensy-2.0/configs/hello/defconfig| 1 - boards/avr/at90usb/teensy-2.0/configs/nsh/defconfig | 1 - boards/avr/at90usb/teensy-2.0/configs/usbmsc/defconfig | 1 - boards/avr/atmega/amber/configs/hello/defconfig | 1 - boards/avr/atmega/arduino-mega2560/configs/hello/defconfig | 1 - boards/avr/atmega/arduino-mega2560/configs/nsh/defconfig | 1 - boards/avr/atmega/moteino-mega/configs/hello/defconfig | 1 - boards/avr/atmega/moteino-mega/configs/nsh/defconfig | 1 - boards/mips/pic32mx/mirtoo/configs/nxffs/defconfig | 1 - boards/or1k/mor1kx/or1k/configs/nsh/defconfig| 1 - boards/renesas/m16c/skp16c26/configs/ostest/defconfig| 1 - boards/risc-v/bl602/bl602evb/configs/elf/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/fpu/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/gpio/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/i2c/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/nsh/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/spi/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/spiflash/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/timer/defconfig | 1 - boards/risc-v/bl602/bl602evb/configs/wifi/defconfig | 1 + boards/risc-v/fe310/hifive1-revb/configs/nsh/defconfig | 1 - boards/risc-v/litex/arty_a7/configs/nsh/defconfig| 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/buttons/defconfig | 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/nsh-itcm/defconfig | 1 - boards/risc-v/rv32m1/rv32m1-vega/configs/nsh/defconfig | 1 - boards/z80/z8/z8encore000zco/configs/ostest/defconfig| 1 - boards/z80/z8/z8f64200100kit/configs/ostest/defconfig| 1 - boards/z80/z80/z80sim/configs/nsh/defconfig | 1 - boards/z80/z80/z80sim/configs/ostest/defconfig | 1 - sched/Kconfig| 3 ++- 52 files changed, 12 insertions(+), 42 deletions(-)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #4799: sched: Disable message queue by default when DEFAULT_SMALL equals y
Ouss4 merged pull request #4799: URL: https://github.com/apache/incubator-nuttx/pull/4799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 01/02: sched: Disable message queue by default when DEFAULT_SMALL equals y
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e57203eca44a0d5ff86640d1c88cdef27b473c19 Author: Xiang Xiao AuthorDate: Mon Nov 8 11:10:12 2021 +0800 sched: Disable message queue by default when DEFAULT_SMALL equals y Signed-off-by: Xiang Xiao --- sched/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sched/Kconfig b/sched/Kconfig index 69b1992..6209e8c 100644 --- a/sched/Kconfig +++ b/sched/Kconfig @@ -41,7 +41,8 @@ config DISABLE_PTHREAD config DISABLE_MQUEUE bool "Disable POSIX message queue support" - default n + default y if DEFAULT_SMALL + default n if !DEFAULT_SMALL config DISABLE_ENVIRON bool "Disable environment variable support"
[incubator-nuttx] 02/02: boards: Fix warning: selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit e3bcfe5cfaf949c20027fe99ef4b5443740f1a50 Author: Xiang Xiao AuthorDate: Mon Nov 8 01:56:12 2021 +0800 boards: Fix warning: selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS) Signed-off-by: Xiang Xiao --- boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig | 1 + boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig | 1 + boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig | 1 + boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig | 1 + boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig | 1 + 5 files changed, 5 insertions(+) diff --git a/boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig b/boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig index 979dab9..a49d054 100644 --- a/boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig +++ b/boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig @@ -8,6 +8,7 @@ # CONFIG_NET_CAN_CANFD is not set # CONFIG_NET_ETHERNET is not set # CONFIG_NET_IPv4 is not set +CONFIG_ALLOW_GPL_COMPONENTS=y CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="imxrt1060-evk" CONFIG_ARCH_BOARD_IMXRT1060_EVK=y diff --git a/boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig b/boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig index f9c4244..0a4081e 100644 --- a/boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig +++ b/boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig @@ -7,6 +7,7 @@ # # CONFIG_NET_ETHERNET is not set # CONFIG_NET_IPv4 is not set +CONFIG_ALLOW_GPL_COMPONENTS=y CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="imxrt1060-evk" CONFIG_ARCH_BOARD_IMXRT1060_EVK=y diff --git a/boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig b/boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig index 8ca0765..cb56968 100644 --- a/boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig +++ b/boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig @@ -8,6 +8,7 @@ # CONFIG_NET_CAN_CANFD is not set # CONFIG_NET_ETHERNET is not set # CONFIG_NET_IPv4 is not set +CONFIG_ALLOW_GPL_COMPONENTS=y CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="imxrt1064-evk" CONFIG_ARCH_BOARD_IMXRT1064_EVK=y diff --git a/boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig b/boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig index 83c2391..30cb640 100644 --- a/boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig +++ b/boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig @@ -7,6 +7,7 @@ # # CONFIG_NET_ETHERNET is not set # CONFIG_NET_IPv4 is not set +CONFIG_ALLOW_GPL_COMPONENTS=y CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="imxrt1064-evk" CONFIG_ARCH_BOARD_IMXRT1064_EVK=y diff --git a/boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig b/boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig index 65c14c1..de28f0b 100644 --- a/boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig +++ b/boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig @@ -7,6 +7,7 @@ # # CONFIG_NET_ETHERNET is not set # CONFIG_NET_IPv4 is not set +CONFIG_ALLOW_GPL_COMPONENTS=y CONFIG_ARCH="arm" CONFIG_ARCH_BOARD="teensy-4.x" CONFIG_ARCH_BOARD_TEENSY_4X=y
[incubator-nuttx] 01/02: boards/imx6: Fix symbol value '' invalid for TESTING_OSTEST_FPUSIZE
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 7c5c77ff7b463e9958f91106fc6262f0bddb64d5 Author: Xiang Xiao AuthorDate: Mon Nov 8 01:50:31 2021 +0800 boards/imx6: Fix symbol value '' invalid for TESTING_OSTEST_FPUSIZE Signed-off-by: Xiang Xiao --- boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig | 1 + boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig | 1 + boards/arm/imx6/sabre-6quad/configs/nsh/defconfig| 1 + 3 files changed, 3 insertions(+) diff --git a/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig b/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig index 106629d..734d64e 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig @@ -97,6 +97,7 @@ CONFIG_SYSTEM_NSH_SYMTAB_COUNTNAME="g_nsymbols" CONFIG_SYSTEM_PING=y CONFIG_TESTING_GETPRIME=y CONFIG_TESTING_OSTEST=y +CONFIG_TESTING_OSTEST_FPUTESTDISABLE=y CONFIG_UART1_SERIAL_CONSOLE=y CONFIG_USERMAIN_STACKSIZE=3072 CONFIG_USER_ENTRYPOINT="nsh_main" diff --git a/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig b/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig index 88cdd84..679336a 100644 --- a/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig @@ -99,6 +99,7 @@ CONFIG_SYSTEM_SYSTEM=y CONFIG_SYSTEM_TASKSET=y CONFIG_TESTING_GETPRIME=y CONFIG_TESTING_OSTEST=y +CONFIG_TESTING_OSTEST_FPUTESTDISABLE=y CONFIG_TESTING_SMP=y CONFIG_UART1_SERIAL_CONSOLE=y CONFIG_USERMAIN_STACKSIZE=3072 diff --git a/boards/arm/imx6/sabre-6quad/configs/nsh/defconfig b/boards/arm/imx6/sabre-6quad/configs/nsh/defconfig index 9edeba2..20dac96 100644 --- a/boards/arm/imx6/sabre-6quad/configs/nsh/defconfig +++ b/boards/arm/imx6/sabre-6quad/configs/nsh/defconfig @@ -61,5 +61,6 @@ CONFIG_SYMTAB_ORDEREDBYNAME=y CONFIG_SYSTEM_NSH=y CONFIG_TESTING_GETPRIME=y CONFIG_TESTING_OSTEST=y +CONFIG_TESTING_OSTEST_FPUTESTDISABLE=y CONFIG_UART1_SERIAL_CONSOLE=y CONFIG_USER_ENTRYPOINT="nsh_main"
[incubator-nuttx] branch master updated (0aeb132 -> e3bcfe5)
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 0aeb132 board: Run ./tools/refresh.sh --silent all new 7c5c77f boards/imx6: Fix symbol value '' invalid for TESTING_OSTEST_FPUSIZE new e3bcfe5 boards: Fix warning: selects CANUTILS_LIBCANUTILS which has unmet direct dependencies (NET_CAN && ALLOW_GPL_COMPONENTS) The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: boards/arm/imx6/sabre-6quad/configs/netnsh/defconfig | 1 + boards/arm/imx6/sabre-6quad/configs/netnsh_smp/defconfig | 1 + boards/arm/imx6/sabre-6quad/configs/nsh/defconfig| 1 + boards/arm/imxrt/imxrt1060-evk/configs/can/defconfig | 1 + boards/arm/imxrt/imxrt1060-evk/configs/canfd/defconfig | 1 + boards/arm/imxrt/imxrt1064-evk/configs/can/defconfig | 1 + boards/arm/imxrt/imxrt1064-evk/configs/canfd/defconfig | 1 + boards/arm/imxrt/teensy-4.x/configs/can-4.1/defconfig| 1 + 8 files changed, 8 insertions(+)
[GitHub] [incubator-nuttx] Ouss4 merged pull request #4797: Fix the build warning come from kconfig-frontend
Ouss4 merged pull request #4797: URL: https://github.com/apache/incubator-nuttx/pull/4797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment
a-lunev commented on pull request #4659: URL: https://github.com/apache/incubator-nuttx/pull/4659#issuecomment-965026412 > separate? maybe. but they can be implemented with the common machinary. Yes, the congestion window control code is of course expected to be tightly integrated into the existing NuttX code. I mean this is an extra algorithm that it would be reasonable to enable via menuconfig as an option. And this new potential code (congestion window control) could be activated by means of conditional compilation (#ifdef #endif) like e.g. CONFIG_NET_TCP_DELAYED_ACK, CONFIG_NET_TCP_WINDOW_SCALE and CONFIG_NET_TCP_FAST_RETRANSMIT_WATERMARK options, that just extend the basic NuttX TCP/IP functionality (optionally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] a-lunev commented on pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment
a-lunev commented on pull request #4659:
URL: https://github.com/apache/incubator-nuttx/pull/4659#issuecomment-965029814
My patch (PR #4659) does not add a new functionality. It just fixes the
existing basic retransmission part in NuttX TCP/IP stack ("unbuffered send"
mode).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] juniskane opened a new pull request #4815: stm32l4 dfumode: enable for STM32L4+ chips
juniskane opened a new pull request #4815: URL: https://github.com/apache/incubator-nuttx/pull/4815 ## Summary Allow also STM32L4+ boards to call stm32l4_dfumode() function. ## Impact Feature port from one MCU subarch to another ## Testing Tested that DFU mode entry works on STM32L4R5AI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
juniskane commented on a change in pull request #4774: URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746620057 ## File path: drivers/ioexpander/gpio.c ## @@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd, unsigned long arg) * Name: gpio_pin_register * * Description: - * Register GPIO pin device driver. - * - * - Input pin types will be registered at /dev/gpinN - * - Output pin types will be registered at /dev/gpoutN - * - Interrupt pin types will be registered at /dev/gpintN - * - * Where N is the provided minor number in the range of 0-99. + * Register GPIO pin device driver at /dev/gpioN, where N is the provided + * minor number in the range of 0-99. Review comment: Didn't some previous commit remove the limit of 99? Comment still valid? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
acassis commented on a change in pull request #4774: URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746633945 ## File path: drivers/ioexpander/gpio.c ## @@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd, unsigned long arg) * Name: gpio_pin_register * * Description: - * Register GPIO pin device driver. - * - * - Input pin types will be registered at /dev/gpinN - * - Output pin types will be registered at /dev/gpoutN - * - Interrupt pin types will be registered at /dev/gpintN - * - * Where N is the provided minor number in the range of 0-99. + * Register GPIO pin device driver at /dev/gpioN, where N is the provided + * minor number in the range of 0-99. Review comment: You are right, 99 is not the limit anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] jarivanewijk commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
jarivanewijk commented on a change in pull request #4774: URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746637626 ## File path: drivers/ioexpander/gpio.c ## @@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd, unsigned long arg) * Name: gpio_pin_register * * Description: - * Register GPIO pin device driver. - * - * - Input pin types will be registered at /dev/gpinN - * - Output pin types will be registered at /dev/gpoutN - * - Interrupt pin types will be registered at /dev/gpintN - * - * Where N is the provided minor number in the range of 0-99. + * Register GPIO pin device driver at /dev/gpioN, where N is the provided + * minor number in the range of 0-99. Review comment: I was not aware. I will update the comments. So there's no limit anymore? (except for the maximum number that the int type can hold, of course). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4782: sem: remove limitation of irq context when do sem_trywait
davids5 commented on a change in pull request #4782: URL: https://github.com/apache/incubator-nuttx/pull/4782#discussion_r746684541 ## File path: sched/semaphore/sem_trywait.c ## @@ -69,10 +69,6 @@ int nxsem_trywait(FAR sem_t *sem) irqstate_t flags; int ret; - /* This API should not be called from interrupt handlers */ Review comment: Why not leave this wrapped in `ifndef CONFIG_DEBUG_MM` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4814: net/can/can_recvmsg.c : put can_readahead in critical section
xiaoxiang781216 commented on a change in pull request #4814: URL: https://github.com/apache/incubator-nuttx/pull/4814#discussion_r746812221 ## File path: mm/iob/iob_free_queue_qentry.c ## @@ -57,6 +57,7 @@ void iob_free_queue_qentry(FAR struct iob_s *iob, FAR struct iob_qentry_s *prev = NULL; FAR struct iob_qentry_s *qentry; + irqstate_t iflags = enter_critical_section(); Review comment: change all iflags to flags, and remove the first and second patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: stm32l4 dfumode: enable for STM32L4+ chips
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 201c67a stm32l4 dfumode: enable for STM32L4+ chips
201c67a is described below
commit 201c67acbdfbedee57d2ad06e9d691eb801734dd
Author: Juha Niskanen
AuthorDate: Wed Nov 10 12:47:38 2021 +0200
stm32l4 dfumode: enable for STM32L4+ chips
---
arch/arm/src/stm32l4/stm32l4_dfumode.c | 10 ++
arch/arm/src/stm32l4/stm32l4_dfumode.h | 2 +-
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/arm/src/stm32l4/stm32l4_dfumode.c
b/arch/arm/src/stm32l4/stm32l4_dfumode.c
index f81d4a2..b68dd06 100644
--- a/arch/arm/src/stm32l4/stm32l4_dfumode.c
+++ b/arch/arm/src/stm32l4/stm32l4_dfumode.c
@@ -46,6 +46,8 @@ static inline void rcc_reset(void)
{
uint32_t regval;
+ /* Enable the MSI clock */
+
regval = getreg32(STM32L4_RCC_CR);
regval |= RCC_CR_MSION;
putreg32(regval, STM32L4_RCC_CR);
@@ -63,11 +65,11 @@ static inline void rcc_reset(void)
putreg32(0x, STM32L4_RCC_CFGR);
- /* Reset HSION, HSEON, CSSON and PLLON bits */
+ /* Reset enable bits for other clocks than MSI */
regval = getreg32(STM32L4_RCC_CR);
regval &= ~(RCC_CR_HSION | RCC_CR_HSIKERON | RCC_CR_HSEON |
- RCC_CR_HSIASFS | RCC_CR_CSSON | RCC_CR_PLLON | RCC_CR_PLLON |
+ RCC_CR_HSIASFS | RCC_CR_CSSON | RCC_CR_PLLON |
RCC_CR_PLLSAI1ON | RCC_CR_PLLSAI2ON);
putreg32(regval, STM32L4_RCC_CR);
@@ -121,7 +123,7 @@ static inline void apb_reset(void)
*
/
-#if defined(CONFIG_STM32L4_STM32L4X6)
+#if defined(CONFIG_STM32L4_STM32L4X6) || defined(CONFIG_STM32L4_STM32L4XR)
void stm32l4_dfumode(void)
{
uint32_t regval;
@@ -131,7 +133,7 @@ void stm32l4_dfumode(void)
_warn("Entering DFU mode...\n");
#endif
- /* disable all peripherals, interrupts and switch to HSI */
+ /* disable all peripherals, interrupts and switch to MSI */
rcc_reset();
apb_reset();
diff --git a/arch/arm/src/stm32l4/stm32l4_dfumode.h
b/arch/arm/src/stm32l4/stm32l4_dfumode.h
index 460bbb7..bad5968 100644
--- a/arch/arm/src/stm32l4/stm32l4_dfumode.h
+++ b/arch/arm/src/stm32l4/stm32l4_dfumode.h
@@ -39,7 +39,7 @@
*
/
-#if defined(CONFIG_STM32L4_STM32L4X6)
+#if defined(CONFIG_STM32L4_STM32L4X6) || defined(CONFIG_STM32L4_STM32L4XR)
void stm32l4_dfumode(void) noreturn_function;
#endif
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4815: stm32l4 dfumode: enable for STM32L4+ chips
xiaoxiang781216 merged pull request #4815: URL: https://github.com/apache/incubator-nuttx/pull/4815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] 02/03: fs:procfs: add tcbinfo procfs interface
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e53aeea60ee38882b08a1526da07bd05506dfd37
Author: zhuyanlin
AuthorDate: Thu Oct 14 19:39:44 2021 +0800
fs:procfs: add tcbinfo procfs interface
Add tcbinfo in procfs system.
Signed-off-by: zhuyanlin
---
fs/procfs/Kconfig| 5 +
fs/procfs/Make.defs | 2 +-
fs/procfs/fs_procfs.c| 5 +
fs/procfs/fs_procfstcbinfo.c | 299 +++
4 files changed, 310 insertions(+), 1 deletion(-)
diff --git a/fs/procfs/Kconfig b/fs/procfs/Kconfig
index f0bd7a6..6d28080 100644
--- a/fs/procfs/Kconfig
+++ b/fs/procfs/Kconfig
@@ -131,5 +131,10 @@ config FS_PROCFS_EXCLUDE_SMARTFS
depends on FS_SMARTFS
default n
+config FS_PROCFS_EXCLUDE_TCBINFO
+ bool "Exclude tcbinfo procfs"
+ depends on DEBUG_TCBINFO
+ default n
+
endmenu # Exclude individual procfs entries
endif # FS_PROCFS
diff --git a/fs/procfs/Make.defs b/fs/procfs/Make.defs
index 8145c16..c7104eb 100644
--- a/fs/procfs/Make.defs
+++ b/fs/procfs/Make.defs
@@ -23,7 +23,7 @@ ifeq ($(CONFIG_FS_PROCFS),y)
CSRCS += fs_procfs.c fs_procfsutil.c fs_procfsproc.c fs_procfsuptime.c
CSRCS += fs_procfscpuload.c fs_procfsmeminfo.c fs_procfsiobinfo.c
-CSRCS += fs_procfsversion.c
+CSRCS += fs_procfsversion.c fs_procfstcbinfo.c
ifeq ($(CONFIG_SCHED_CRITMONITOR),y)
CSRCS += fs_procfscritmon.c
diff --git a/fs/procfs/fs_procfs.c b/fs/procfs/fs_procfs.c
index e0a41c7..85a53e4 100644
--- a/fs/procfs/fs_procfs.c
+++ b/fs/procfs/fs_procfs.c
@@ -70,6 +70,7 @@ extern const struct procfs_operations iobinfo_operations;
extern const struct procfs_operations module_operations;
extern const struct procfs_operations uptime_operations;
extern const struct procfs_operations version_operations;
+extern const struct procfs_operations tcbinfo_operations;
/* This is not good. These are implemented in other sub-systems. Having to
* deal with them here is not a good coupling. What is really needed is a
@@ -165,6 +166,10 @@ static const struct procfs_entry_s g_procfs_entries[] =
#if !defined(CONFIG_FS_PROCFS_EXCLUDE_VERSION)
{ "version", &version_operations, PROCFS_FILE_TYPE },
#endif
+
+#if defined(CONFIG_DEBUG_TCBINFO) && !defined(CONFIG_FS_PROCFS_EXCLUDE_TCBINFO)
+ { "tcbinfo", &tcbinfo_operations, PROCFS_FILE_TYPE },
+#endif
};
#ifdef CONFIG_FS_PROCFS_REGISTER
diff --git a/fs/procfs/fs_procfstcbinfo.c b/fs/procfs/fs_procfstcbinfo.c
new file mode 100644
index 000..8551b66
--- /dev/null
+++ b/fs/procfs/fs_procfstcbinfo.c
@@ -0,0 +1,299 @@
+/
+ * fs/procfs/fs_procfstcbinfo.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#include
+#include
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include
+#include
+#include
+
+#if !defined(CONFIG_DISABLE_MOUNTPOINT) && defined(CONFIG_FS_PROCFS)
+#ifdef CONFIG_DEBUG_TCBINFO
+
+/
+ * Pre-processor Definitions
+ /
+
+/* Determines the size of an intermediate buffer that must be large enough
+ * to handle the longest line generated by this logic.
+ */
+
+#define TCBINFO_LINELEN 128
+
+/
+ * Private Types
+ /
+
+/* This structure describes one open "file" */
+
+struct tcbinfo_file_s
+{
+ struct procfs_file_s base;/* Base open file structure */
+ unsigned int linesize; /* Number of valid characters in line[] */
+ char line[TCBINFO_
[incubator-nuttx] branch master updated (201c67a -> 407bc04)
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 201c67a stm32l4 dfumode: enable for STM32L4+ chips
new 012bd14 arch:debug: add struct for task aware debug.
new e53aeea fs:procfs: add tcbinfo procfs interface
new 407bc04 tools: add gdbplugin for JLinkGDBServer nuttx thread aware
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
Kconfig| 8 +
.../src/arm/arm_tcbinfo.c} | 52 +-
.../src/armv6-m/arm_tcbinfo.c} | 59 +-
arch/arm/src/armv7-a/arm_tcbinfo.c | 108
arch/arm/src/armv7-m/arm_tcbinfo.c | 114
arch/arm/src/armv7-r/arm_tcbinfo.c | 108
arch/arm/src/armv8-m/arm_tcbinfo.c | 114
arch/risc-v/src/common/riscv_tcbinfo.c | 118
fs/procfs/Kconfig | 5 +
fs/procfs/Make.defs| 2 +-
fs/procfs/fs_procfs.c | 5 +
.../{fs_procfsversion.c => fs_procfstcbinfo.c} | 103 ++--
include/nuttx/sched.h | 35 ++
tools/Config.mk| 3 +
tools/Makefile.host| 20 +-
tools/jlink-nuttx.c| 643 +
16 files changed, 1396 insertions(+), 101 deletions(-)
copy arch/{x86_64/src/intel64/up_restore_auxstate.c =>
arm/src/arm/arm_tcbinfo.c} (69%)
copy arch/{x86_64/src/intel64/up_restore_auxstate.c =>
arm/src/armv6-m/arm_tcbinfo.c} (66%)
create mode 100644 arch/arm/src/armv7-a/arm_tcbinfo.c
create mode 100644 arch/arm/src/armv7-m/arm_tcbinfo.c
create mode 100644 arch/arm/src/armv7-r/arm_tcbinfo.c
create mode 100644 arch/arm/src/armv8-m/arm_tcbinfo.c
create mode 100644 arch/risc-v/src/common/riscv_tcbinfo.c
copy fs/procfs/{fs_procfsversion.c => fs_procfstcbinfo.c} (74%)
create mode 100644 tools/jlink-nuttx.c
[incubator-nuttx] 03/03: tools: add gdbplugin for JLinkGDBServer nuttx thread aware
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 407bc04934737cdf9e473a64b4663c6aefa9312a Author: zhuyanlin AuthorDate: Mon Oct 11 21:38:51 2021 +0800 tools: add gdbplugin for JLinkGDBServer nuttx thread aware Use `JLinkGDBServer -rtos libnuttxplugin` to add this plugin. Then in gdb can use command: - `info threads` to show all threads infos - `thread (id) ` to switch thread. - `bt` to show thread backtrace. Signed-off-by: zhuyanlin --- tools/Config.mk | 3 + tools/Makefile.host | 20 +- tools/jlink-nuttx.c | 643 3 files changed, 663 insertions(+), 3 deletions(-) diff --git a/tools/Config.mk b/tools/Config.mk index 770950a..b200e6a 100644 --- a/tools/Config.mk +++ b/tools/Config.mk @@ -92,6 +92,9 @@ endif ifeq ($(CONFIG_HOST_WINDOWS),y) HOSTEXEEXT ?= .exe + HOSTDYNEXT ?= .dll +else ifeq ($(CONFIG_HOST_LINUX),y) + HOSTDYNEXT ?= .so endif # This define is passed as EXTRAFLAGS for kernel-mode builds. It is also passed diff --git a/tools/Makefile.host b/tools/Makefile.host index a49b397..fdc06a4 100644 --- a/tools/Makefile.host +++ b/tools/Makefile.host @@ -35,7 +35,8 @@ all: b16$(HOSTEXEEXT) bdf-converter$(HOSTEXEEXT) cmpconfig$(HOSTEXEEXT) \ mksymtab$(HOSTEXEEXT) mksyscall$(HOSTEXEEXT) mkversion$(HOSTEXEEXT) \ cnvwindeps$(HOSTEXEEXT) nxstyle$(HOSTEXEEXT) initialconfig$(HOSTEXEEXT) \ gencromfs$(HOSTEXEEXT) convert-comments$(HOSTEXEEXT) lowhex$(HOSTEXEEXT) \ -detab$(HOSTEXEEXT) rmcr$(HOSTEXEEXT) incdir$(HOSTEXEEXT) +detab$(HOSTEXEEXT) rmcr$(HOSTEXEEXT) incdir$(HOSTEXEEXT) \ +jlink-nuttx$(HOSTDYNEXT) default: mkconfig$(HOSTEXEEXT) mksyscall$(HOSTEXEEXT) mkdeps$(HOSTEXEEXT) \ cnvwindeps$(HOSTEXEEXT) incdir$(HOSTEXEEXT) @@ -43,9 +44,11 @@ ifdef HOSTEXEEXT .PHONY: b16 bdf-converter cmpconfig clean configure kconfig2html mkconfig \ mkdeps mksymtab mksyscall mkversion cnvwindeps nxstyle initialconfig \ gencromfs convert-comments lowhex detab rmcr incdir -else -.PHONY: clean endif +ifdef HOSTDYNEXT +.PHONY: jlink-nuttx +endif +.PHONY: clean # b16 - Fixed precision math conversion tool @@ -222,6 +225,15 @@ ifdef HOSTEXEEXT mkdeps: mkdeps$(HOSTEXEEXT) endif +# jlink-nuttx - Create jlink GDBServer nuttx plugin + +jlink-nuttx$(HOSTDYNEXT): jlink-nuttx.c + $(Q) $(HOSTCC) $(HOSTCFLAGS) -shared jlink-nuttx.c -o jlink-nuttx$(HOSTDYNEXT) + +ifdef HOSTDYNEXT +jlink-nuttx: jlink-nuttx$(HOSTDYNEXT) +endif + clean: $(call DELFILE, b16) $(call DELFILE, b16.exe) @@ -258,6 +270,8 @@ clean: $(call DELFILE, nxstyle.exe) $(call DELFILE, rmcr) $(call DELFILE, rmcr.exe) + $(call DELFILE, jlink-nuttx.so) + $(call DELFILE, jlink-nuttx.dll) ifneq ($(CONFIG_WINDOWS_NATIVE),y) $(Q) rm -rf *.dSYM endif diff --git a/tools/jlink-nuttx.c b/tools/jlink-nuttx.c new file mode 100644 index 000..ee20c94 --- /dev/null +++ b/tools/jlink-nuttx.c @@ -0,0 +1,643 @@ +/ + * tools/jlink-nuttx.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + / + +/ + * Included Files + / + +#include +#include +#include +#include +#include +#include + +/ + * Pre-processor Definitions + / + +/* Marcos for J-Link plugin API */ + +#define PLUGIN_VER100 +#define DISPLAY_LENGTH256 +#define THREADID_BASE 1 + +/* Marco for TCB struct size */ + +#define TCB_NAMESIZE 256 + +/* Marcos for J-Link API ops */ + +#define REALLOC(ptr, size)g_plugin_priv.jops->realloc(ptr, size) +#define ALLOC(size) g_plugin_priv.jops->all
[incubator-nuttx] 01/03: arch:debug: add struct for task aware debug.
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 012bd1494c59d21486e2554ea5d83503027aebe8
Author: zhuyanlin
AuthorDate: Wed Oct 13 21:15:04 2021 +0800
arch:debug: add struct for task aware debug.
When enable DEBUG_TCBINFO config, a global struct will
provide, then debuggers can aware nuttx task infomation.
Signed-off-by: zhuyanlin
---
Kconfig| 8 +++
arch/arm/src/arm/arm_tcbinfo.c | 64 ++
arch/arm/src/armv6-m/arm_tcbinfo.c | 71
arch/arm/src/armv7-a/arm_tcbinfo.c | 108 ++
arch/arm/src/armv7-m/arm_tcbinfo.c | 114 +++
arch/arm/src/armv7-r/arm_tcbinfo.c | 108 ++
arch/arm/src/armv8-m/arm_tcbinfo.c | 114 +++
arch/risc-v/src/common/riscv_tcbinfo.c | 118 +
include/nuttx/sched.h | 35 ++
9 files changed, 740 insertions(+)
diff --git a/Kconfig b/Kconfig
index 126139e..1772e71 100644
--- a/Kconfig
+++ b/Kconfig
@@ -546,6 +546,14 @@ endmenu # Customize Header Files
menu "Debug Options"
+config DEBUG_TCBINFO
+ bool "Enable TCBinfo struct for debug"
+ default n
+ ---help---
+ Enables tcbinfo struct for debugger infomation.
+ Selecting this option will enable g_tcbinfo in arch and
+ procfs.
+
config DEBUG_ALERT
bool
default n
diff --git a/arch/arm/src/arm/arm_tcbinfo.c b/arch/arm/src/arm/arm_tcbinfo.c
new file mode 100644
index 000..f2e9745
--- /dev/null
+++ b/arch/arm/src/arm/arm_tcbinfo.c
@@ -0,0 +1,64 @@
+/
+ * arch/arm/src/arm/arm_tcbinfo.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ /
+
+/
+ * Included Files
+ /
+
+#include
+
+#ifdef CONFIG_DEBUG_TCBINFO
+
+#include
+#include
+
+/
+ * Public Data
+ /
+
+const struct tcbinfo_s g_tcbinfo =
+{
+ TCB_PID_OFF,
+ TCB_STATE_OFF,
+ TCB_PRI_OFF,
+ TCB_NAME_OFF,
+
+ XCPTCONTEXT_REGS,
+
+ TCB_REG_OFF(REG_R0),
+ TCB_REG_OFF(REG_R1),
+ TCB_REG_OFF(REG_R2),
+ TCB_REG_OFF(REG_R3),
+ TCB_REG_OFF(REG_R4),
+ TCB_REG_OFF(REG_R5),
+ TCB_REG_OFF(REG_R6),
+ TCB_REG_OFF(REG_R7),
+ TCB_REG_OFF(REG_R8),
+ TCB_REG_OFF(REG_R9),
+ TCB_REG_OFF(REG_R10),
+ TCB_REG_OFF(REG_R11),
+ TCB_REG_OFF(REG_R12),
+ TCB_REG_OFF(REG_R13),
+ TCB_REG_OFF(REG_R14),
+ TCB_REG_OFF(REG_R15),
+ TCB_REG_OFF(REG_CPSR),
+};
+
+#endif
diff --git a/arch/arm/src/armv6-m/arm_tcbinfo.c
b/arch/arm/src/armv6-m/arm_tcbinfo.c
new file mode 100644
index 000..45be317
--- /dev/null
+++ b/arch/arm/src/armv6-m/arm_tcbinfo.c
@@ -0,0 +1,71 @@
+/
+ * arch/arm/src/armv6-m/arm_tcbinfo.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ *
[GitHub] [incubator-nuttx] acassis merged pull request #4810: debug: add tools for task aware debug
acassis merged pull request #4810: URL: https://github.com/apache/incubator-nuttx/pull/4810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: clock.h: Remove the unnecessary L from macro
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 69d3545 clock.h: Remove the unnecessary L from macro 69d3545 is described below commit 69d35455c7780fbf082cc2322b2aeada9ba669ff Author: Xiang Xiao AuthorDate: Mon Nov 8 22:37:50 2021 +0800 clock.h: Remove the unnecessary L from macro It's safe for the number <= 32767 since C standard require int at least 16bit Signed-off-by: Xiang Xiao --- include/nuttx/clock.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/include/nuttx/clock.h b/include/nuttx/clock.h index 7790f68..55e49c6 100644 --- a/include/nuttx/clock.h +++ b/include/nuttx/clock.h @@ -84,32 +84,32 @@ #define NSEC_PER_SEC 10L /* Seconds */ #define USEC_PER_SEC 100L -#define MSEC_PER_SEC1000L -#define DSEC_PER_SEC 10L -#define HSEC_PER_SEC 2L +#define MSEC_PER_SEC1000 +#define DSEC_PER_SEC 10 +#define HSEC_PER_SEC 2 #define NSEC_PER_HSEC 5L /* Half seconds */ #define USEC_PER_HSEC 50L -#define MSEC_PER_HSEC500L -#define DSEC_PER_HSEC 5L +#define MSEC_PER_HSEC500 +#define DSEC_PER_HSEC 5 #define NSEC_PER_DSEC 1L /* Deciseconds */ #define USEC_PER_DSEC 10L -#define MSEC_PER_DSEC100L +#define MSEC_PER_DSEC100 #define NSEC_PER_MSEC100L /* Milliseconds */ -#define USEC_PER_MSEC 1000L +#define USEC_PER_MSEC 1000 -#define NSEC_PER_USEC 1000L /* Microseconds */ +#define NSEC_PER_USEC 1000 /* Microseconds */ -#define SEC_PER_MIN 60L +#define SEC_PER_MIN 60 #define NSEC_PER_MIN (NSEC_PER_SEC * SEC_PER_MIN) #define USEC_PER_MIN (USEC_PER_SEC * SEC_PER_MIN) #define MSEC_PER_MIN (MSEC_PER_SEC * SEC_PER_MIN) #define DSEC_PER_MIN (DSEC_PER_SEC * SEC_PER_MIN) #define HSEC_PER_MIN (HSEC_PER_SEC * SEC_PER_MIN) -#define MIN_PER_HOUR 60L +#define MIN_PER_HOUR 60 #define NSEC_PER_HOUR (NSEC_PER_MIN * MIN_PER_HOUR) #define USEC_PER_HOUR (USEC_PER_MIN * MIN_PER_HOUR) #define MSEC_PER_HOUR (MSEC_PER_MIN * MIN_PER_HOUR) @@ -117,7 +117,7 @@ #define HSEC_PER_HOUR (HSEC_PER_MIN * MIN_PER_HOUR) #define SEC_PER_HOUR (SEC_PER_MIN * MIN_PER_HOUR) -#define HOURS_PER_DAY 24L +#define HOURS_PER_DAY 24 #define SEC_PER_DAY(HOURS_PER_DAY * SEC_PER_HOUR) /* If CONFIG_SCHED_TICKLESS is not defined, then the interrupt interval of
[GitHub] [incubator-nuttx] acassis merged pull request #4801: clock.h: Remove the unnecessary L from macro
acassis merged pull request #4801: URL: https://github.com/apache/incubator-nuttx/pull/4801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4747: Revert "libc: Implement fesetround & fegetround for arm"
gustavonihei merged pull request #4747: URL: https://github.com/apache/incubator-nuttx/pull/4747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: Revert "libc: Implement fesetround & fegetround for arm"
This is an automated email from the ASF dual-hosted git repository. gustavonihei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new bec1b0b Revert "libc: Implement fesetround & fegetround for arm" bec1b0b is described below commit bec1b0bc9259e079859a42cc137b1d20b8c281dc Author: Xiang Xiao AuthorDate: Sun Oct 31 17:24:10 2021 +0800 Revert "libc: Implement fesetround & fegetround for arm" Since the toolchain provide the implementation now. This reverts commit fe992a5b6c91f2caa2ad9ac92d0876b5ec39978a. --- include/fenv.h | 44 -- libs/libc/machine/arm/Make.defs | 2 - libs/libc/machine/arm/arm_fenv.c | 120 --- 3 files changed, 166 deletions(-) diff --git a/include/fenv.h b/include/fenv.h deleted file mode 100644 index 81e44a8..000 --- a/include/fenv.h +++ /dev/null @@ -1,44 +0,0 @@ -/ - * include/fenv.h - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The - * ASF licenses this file to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations - * under the License. - * - / - -#ifndef __INCLUDE_FENV_H -#define __INCLUDE_FENV_H - -/ - * Included Files - / - -/ - * Pre-processor Definitions - / - -#define FE_TONEAREST 0 -#define FE_DOWNWARD1 -#define FE_UPWARD 2 -#define FE_TOWARDZERO 3 - -/ - * Public Function Prototypes - / - -int fegetround(void); -int fesetround(int round); - -#endif /* __INCLUDE_FENV_H */ \ No newline at end of file diff --git a/libs/libc/machine/arm/Make.defs b/libs/libc/machine/arm/Make.defs index c1b096e..d9d60ce 100644 --- a/libs/libc/machine/arm/Make.defs +++ b/libs/libc/machine/arm/Make.defs @@ -46,7 +46,5 @@ ifeq ($(CONFIG_CXX_EXCEPTION),y) CSRCS += gnu_unwind_find_exidx.c endif -CSRCS += arm_fenv.c - DEPPATH += --dep-path machine/arm VPATH += :machine/arm diff --git a/libs/libc/machine/arm/arm_fenv.c b/libs/libc/machine/arm/arm_fenv.c deleted file mode 100644 index 12ca8c4..000 --- a/libs/libc/machine/arm/arm_fenv.c +++ /dev/null @@ -1,120 +0,0 @@ -/ - * libs/libc/machine/arm/arm_fenv.c - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. The - * ASF licenses this file to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance with the - * License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations - * under the License. - * - / - -/ - * Included Files - / - -#include -#include - -/ - * Pre-processor Definitions - / - -#define ARM_FPSCR_TONEAREST 0x -#define ARM_FPSCR_DOWNWARD0x0040 -#define ARM_FPSCR_UPWARD 0x0080 -#define ARM_FPSCR_TOWARDZERO 0x
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4816: arch/arm: Remove EXPERIMENTAL from ARCH_TRUSTZONE_XXX
xiaoxiang781216 opened a new pull request #4816: URL: https://github.com/apache/incubator-nuttx/pull/4816 ## Summary since it work on the product device ## Impact No, since the feature depend on EXPERIMENTAL is still off by default. ## Testing internal device -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4803: sched/signal: add spinlock to g_sigfreeaction
xiaoxiang781216 commented on a change in pull request #4803:
URL: https://github.com/apache/incubator-nuttx/pull/4803#discussion_r746858845
##
File path: sched/signal/sig_action.c
##
@@ -38,10 +38,55 @@
#include "group/group.h"
#include "signal/signal.h"
+/
+ * Private Data
+ /
+
+/* g_sigactionalloc is a pointer to the start of the allocated blocks of
+ * signal actions.
+ */
+
+static sigactq_t *g_sigactionalloc;
+
/
* Private Functions
/
+/
+ * Name: nxsig_alloc_actionblock
+ *
+ * Description:
+ * Allocate a block of signal actions and place them
+ * on the free list.
+ *
+ /
+
+static void nxsig_alloc_actionblock(void)
+{
+ FAR sigactq_t *sigact;
+ irqstate_t flags;
+ int i;
+
+ /* Allocate a block of signal actions */
+
+ g_sigactionalloc =
Review comment:
let's remove g_sigactionalloc, which isn't really needed at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4782: sem: remove limitation of irq context when do sem_trywait
xiaoxiang781216 commented on a change in pull request #4782: URL: https://github.com/apache/incubator-nuttx/pull/4782#discussion_r746864219 ## File path: sched/semaphore/sem_trywait.c ## @@ -69,10 +69,6 @@ int nxsem_trywait(FAR sem_t *sem) irqstate_t flags; int ret; - /* This API should not be called from interrupt handlers */ Review comment: Since the behavior change happen only when CONFIG_DEBUG_MM is defined, we can simply to: 1. #ifndef CONFIG_DEBUG_MM the below debug assert 2. keep _SEM_TRYWAIT in mm/mm_heap/mm_sem.c with CONFIG_DEBUG_MM guard 3. Remove all other assert Do you think so? @davids5 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
xiaoxiang781216 commented on a change in pull request #4774: URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746865886 ## File path: drivers/ioexpander/gpio.c ## @@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd, unsigned long arg) * Name: gpio_pin_register * * Description: - * Register GPIO pin device driver. - * - * - Input pin types will be registered at /dev/gpinN - * - Output pin types will be registered at /dev/gpoutN - * - Interrupt pin types will be registered at /dev/gpintN - * - * Where N is the provided minor number in the range of 0-99. + * Register GPIO pin device driver at /dev/gpioN, where N is the provided + * minor number in the range of 0-99. Review comment: Here is the PR: https://github.com/apache/incubator-nuttx/pull/4697. Sorry, forget to update the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment
xiaoxiang781216 merged pull request #4659: URL: https://github.com/apache/incubator-nuttx/pull/4659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4659: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment
xiaoxiang781216 commented on pull request #4659: URL: https://github.com/apache/incubator-nuttx/pull/4659#issuecomment-965617057 So, let's merge this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[incubator-nuttx] branch master updated: net/tcp(unbuffered): retransmit only one the earliest not acknowledged segment (according to RFC 6298 (5.4)).
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1e07b6d net/tcp(unbuffered): retransmit only one the earliest not
acknowledged segment (according to RFC 6298 (5.4)).
1e07b6d is described below
commit 1e07b6d528ab52dd179e6631991c683749c7635d
Author: Alexander Lunev
AuthorDate: Tue Oct 12 07:15:54 2021 +0300
net/tcp(unbuffered): retransmit only one the earliest not acknowledged
segment
(according to RFC 6298 (5.4)).
---
net/tcp/tcp.h | 3 +++
net/tcp/tcp_appsend.c | 18 +-
net/tcp/tcp_send_unbuffered.c | 36
3 files changed, 52 insertions(+), 5 deletions(-)
diff --git a/net/tcp/tcp.h b/net/tcp/tcp.h
index 7e55d36..245cba1 100644
--- a/net/tcp/tcp.h
+++ b/net/tcp/tcp.h
@@ -172,6 +172,9 @@ struct tcp_conn_s
uint8_t rcvseq[4]; /* The sequence number that we expect to
* receive next */
uint8_t sndseq[4]; /* The sequence number that was last sent by us */
+#if !defined(CONFIG_NET_TCP_WRITE_BUFFERS)
+ uint32_t rexmit_seq;/* The sequence number to be retrasmitted */
+#endif
uint8_t crefs; /* Reference counts on this instance */
#if defined(CONFIG_NET_IPv4) && defined(CONFIG_NET_IPv6)
uint8_t domain;/* IP domain: PF_INET or PF_INET6 */
diff --git a/net/tcp/tcp_appsend.c b/net/tcp/tcp_appsend.c
index c31a942..467d567 100644
--- a/net/tcp/tcp_appsend.c
+++ b/net/tcp/tcp_appsend.c
@@ -316,7 +316,23 @@ void tcp_rexmit(FAR struct net_driver_s *dev, FAR struct
tcp_conn_s *conn,
#ifdef CONFIG_NET_TCP_WRITE_BUFFERS
if (dev->d_sndlen > 0)
#else
- if (dev->d_sndlen > 0 && conn->tx_unacked > 0)
+ if ((result & TCP_REXMIT) != 0 &&
+ dev->d_sndlen > 0 && conn->tx_unacked > 0)
+{
+ uint32_t saveseq;
+
+ /* According to RFC 6298 (5.4), retransmit the earliest segment
+ * that has not been acknowledged by the TCP receiver.
+ */
+
+ saveseq = tcp_getsequence(conn->sndseq);
+ tcp_setsequence(conn->sndseq, conn->rexmit_seq);
+
+ tcp_send(dev, conn, TCP_ACK | TCP_PSH, dev->d_sndlen + hdrlen);
+
+ tcp_setsequence(conn->sndseq, saveseq);
+}
+ else if (dev->d_sndlen > 0 && conn->tx_unacked > 0)
#endif
{
uint32_t seq;
diff --git a/net/tcp/tcp_send_unbuffered.c b/net/tcp/tcp_send_unbuffered.c
index c309e27..aa3605b 100644
--- a/net/tcp/tcp_send_unbuffered.c
+++ b/net/tcp/tcp_send_unbuffered.c
@@ -236,13 +236,41 @@ static uint16_t tcpsend_eventhandler(FAR struct
net_driver_s *dev,
else if ((flags & TCP_REXMIT) != 0)
{
- /* Yes.. in this case, reset the number of bytes that have been sent
- * to the number of bytes that have been ACKed.
+ /* According to RFC 6298 (5.4), retransmit the earliest segment
+ * that has not been acknowledged by the TCP receiver.
*/
- pstate->snd_sent = pstate->snd_acked;
+ /* Reconstruct the length of the earliest segment to be retransmitted */
- /* Fall through to re-send data from the last that was ACKed */
+ uint32_t sndlen = pstate->snd_buflen - pstate->snd_acked;
+
+ if (sndlen > conn->mss)
+{
+ sndlen = conn->mss;
+}
+
+ conn->rexmit_seq = pstate->snd_isn + pstate->snd_acked;
+
+#ifdef NEED_IPDOMAIN_SUPPORT
+ /* If both IPv4 and IPv6 support are enabled, then we will need to
+ * select which one to use when generating the outgoing packet.
+ * If only one domain is selected, then the setup is already in
+ * place and we need do nothing.
+ */
+
+ tcpsend_ipselect(dev, conn);
+#endif
+ /* Then set-up to send that amount of data. (this won't actually
+ * happen until the polling cycle completes).
+ */
+
+ devif_send(dev,
+ &pstate->snd_buffer[pstate->snd_acked],
+ sndlen);
+
+ /* Continue waiting */
+
+ return flags;
}
/* Check for a loss of connection */
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
gustavonihei commented on a change in pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746971209
##
File path: drivers/ioexpander/gpio.c
##
@@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
* Name: gpio_pin_register
*
* Description:
- * Register GPIO pin device driver.
- *
- * - Input pin types will be registered at /dev/gpinN
- * - Output pin types will be registered at /dev/gpoutN
- * - Interrupt pin types will be registered at /dev/gpintN
- *
- * Where N is the provided minor number in the range of 0-99.
+ * Register GPIO pin device driver at /dev/gpioN, where N is the provided
+ * minor number in the range of 0-99.
*
/
int gpio_pin_register(FAR struct gpio_dev_s *dev, int minor)
{
- FAR const char *fmt;
- char devname[32];
+ char devname[16];
Review comment:
```suggestion
char devname[32];
```
If we consider the max value for `int minor`, it requires more than 16
characters. This change should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
gustavonihei commented on a change in pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746972143
##
File path: drivers/ioexpander/gpio.c
##
@@ -578,47 +568,16 @@ int gpio_pin_register(FAR struct gpio_dev_s *dev, int
minor)
* Name: gpio_pin_unregister
*
* Description:
- * Unregister GPIO pin device driver.
- *
- * - Input pin types will be registered at /dev/gpinN
- * - Output pin types will be registered at /dev/gpoutN
- * - Interrupt pin types will be registered at /dev/gpintN
- *
- * Where N is the provided minor number in the range of 0-99.
- *
+ * Unregister GPIO pin device driver at /dev/gpioN, where N is the provided
+ * minor number in the range of 0-99.
*
/
void gpio_pin_unregister(FAR struct gpio_dev_s *dev, int minor)
{
- FAR const char *fmt;
char devname[16];
Review comment:
```suggestion
char devname[32];
```
If we consider the max value for int minor, it requires more than 16
characters.
##
File path: drivers/ioexpander/gpio.c
##
@@ -562,13 +554,11 @@ int gpio_pin_register(FAR struct gpio_dev_s *dev, int
minor)
{
return ret;
}
-
- fmt = "/dev/gpint%u";
}
break;
}
- snprintf(devname, 16, fmt, (unsigned int)minor);
+ snprintf(devname, 16, "/dev/gpio%u", (unsigned int) minor);
Review comment:
```suggestion
snprintf(devname, sizeof(devname), "/dev/gpio%u", (unsigned int) minor);
```
Using `sizeof` to make it less error prone to future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a change in pull request #4774: GPIO driver: Use generic /dev/gpioN
acassis commented on a change in pull request #4774:
URL: https://github.com/apache/incubator-nuttx/pull/4774#discussion_r746978316
##
File path: drivers/ioexpander/gpio.c
##
@@ -511,20 +511,14 @@ static int gpio_ioctl(FAR struct file *filep, int cmd,
unsigned long arg)
* Name: gpio_pin_register
*
* Description:
- * Register GPIO pin device driver.
- *
- * - Input pin types will be registered at /dev/gpinN
- * - Output pin types will be registered at /dev/gpoutN
- * - Interrupt pin types will be registered at /dev/gpintN
- *
- * Where N is the provided minor number in the range of 0-99.
+ * Register GPIO pin device driver at /dev/gpioN, where N is the provided
+ * minor number in the range of 0-99.
*
/
int gpio_pin_register(FAR struct gpio_dev_s *dev, int minor)
{
- FAR const char *fmt;
- char devname[32];
+ char devname[16];
Review comment:
I think the right size (including \0) is 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[incubator-nuttx-website] branch asf-site updated: Publishing web: dae81ea3c7ae113846bd7d94778d565c9f4d4c43 docs: 1e07b6d528ab52dd179e6631991c683749c7635d
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new cfe06e1 Publishing web: dae81ea3c7ae113846bd7d94778d565c9f4d4c43 docs: 1e07b6d528ab52dd179e6631991c683749c7635d cfe06e1 is described below commit cfe06e14e6babb03d80d3c4adb483bb16420b24e Author: Abdelatif AuthorDate: Thu Nov 11 00:08:47 2021 + Publishing web: dae81ea3c7ae113846bd7d94778d565c9f4d4c43 docs: 1e07b6d528ab52dd179e6631991c683749c7635d --- content/docs/10.0.0/index.html | 2 +- content/docs/10.0.1/index.html | 2 +- content/docs/10.1.0/index.html | 2 +- content/docs/latest/index.html | 2 +- content/feed.xml | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/content/docs/10.0.0/index.html b/content/docs/10.0.0/index.html index ab30cb9..db0a882 100644 --- a/content/docs/10.0.0/index.html +++ b/content/docs/10.0.0/index.html @@ -207,7 +207,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 10 November 21 at 00:06 +Last Updated: 11 November 21 at 00:06 Table of Contents diff --git a/content/docs/10.0.1/index.html b/content/docs/10.0.1/index.html index 60cafcb..5aa9a7e 100644 --- a/content/docs/10.0.1/index.html +++ b/content/docs/10.0.1/index.html @@ -213,7 +213,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 32-bit microcontroller environments, the primary governing standards in NuttX are Posix and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 10 November 21 at 00:06 +Last Updated: 11 November 21 at 00:06 Table of Contents diff --git a/content/docs/10.1.0/index.html b/content/docs/10.1.0/index.html index 79d94d7..012ac92 100644 --- a/content/docs/10.1.0/index.html +++ b/content/docs/10.1.0/index.html @@ -213,7 +213,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 10 November 21 at 00:07 +Last Updated: 11 November 21 at 00:06 Table of Contents diff --git a/content/docs/latest/index.html b/content/docs/latest/index.html index c7dce59..79b78dc 100644 --- a/content/docs/latest/index.html +++ b/content/docs/latest/index.html @@ -214,7 +214,7 @@ by following these NuttX Documentation¶ NuttX is a real-time operating system (RTOS) with an emphasis on standards compliance and small footprint. Scalable from 8-bit to 64-bit microcontroller environments, the primary governing standards in NuttX are POSIX and ANSI standards. Additional standard APIs from Unix and other common RTOS’s (such as VxWorks) are adopted for functionality not available under these standards, or for functionality that is not appropriate for deeply-embedded environments (such as fork()). -Last Updated: 10 November 21 at 00:07 +Last Updated: 11 November 21 at 00:07 Table of Contents diff --git a/content/feed.xml b/content/feed.xml index 9c4366f..1bc42be 100644 --- a/content/feed.xml +++ b/content/feed.xml @@ -5,8 +5,8 @@ / -Wed, 10 Nov 2021 00:09:00 + -Wed, 10 Nov 2021 00:09:00 + +Thu, 11 Nov 2021 00:08:45 + +Thu, 11 Nov 2021 00:08:45 + Jekyll v3.8.5
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #4782: sem: remove limitation of irq context when do sem_trywait
davids5 commented on a change in pull request #4782: URL: https://github.com/apache/incubator-nuttx/pull/4782#discussion_r747113311 ## File path: sched/semaphore/sem_trywait.c ## @@ -69,10 +69,6 @@ int nxsem_trywait(FAR sem_t *sem) irqstate_t flags; int ret; - /* This API should not be called from interrupt handlers */ Review comment: @xiaoxiang781216 Simple is always better. If all code path lead to the one check that would be preferred. If not add them where needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on pull request #4811: procfs: fix ps can't log out Group id
GUIDINGLI commented on pull request #4811: URL: https://github.com/apache/incubator-nuttx/pull/4811#issuecomment-965951032 @gustavonihei How do yo think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #4782: sem: remove limitation of irq context when do sem_trywait
GUIDINGLI commented on a change in pull request #4782: URL: https://github.com/apache/incubator-nuttx/pull/4782#discussion_r747174852 ## File path: sched/semaphore/sem_trywait.c ## @@ -69,10 +69,6 @@ int nxsem_trywait(FAR sem_t *sem) irqstate_t flags; int ret; - /* This API should not be called from interrupt handlers */ Review comment: @davids5 Directly remove is the simply way to sem_trywait(), use CONFIG_DEBUG_MM under `sched` folder is NOT suitable. I strongly suggest keep current code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4814: net/can/can_recvmsg.c : put can_readahead in critical section
xiaoxiang781216 commented on pull request #4814: URL: https://github.com/apache/incubator-nuttx/pull/4814#issuecomment-965969812 Let's merge two patch into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-nuttx] eenurkka opened a new pull request #4817: mpfs: uart: add a way to configure uart3 and uart4
eenurkka opened a new pull request #4817: URL: https://github.com/apache/incubator-nuttx/pull/4817 Currently configuring the uart3/4 as the serial console doesn't work. Apply proper changes in mpfs_config.h that enables the following configuration options: - CONFIG_UART3_SERIAL_CONSOLE - CONFIG_UART4_SERIAL_CONSOLE Also, fix a typo in mpfs_lowputc.c that gives a compile error if defined. Signed-off-by: Eero Nurkkala ## Summary Now uart3 and uart4 may be configured for the serial console. ## Impact No impact, these haven't been used before for this purpose. Now there's more flexibility on which UART to use for the NuttX. ## Testing Tested on Polarfire Icicle kit with NuttX running on hart3, while running Linux on hart1, hart2 and hart4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
