[GitHub] [inlong] fuweng11 opened a new pull request, #7402: [INLONG-7401][Manager] Fix the problem of partitions could not be created based on numPartitions in the inlong group
fuweng11 opened a new pull request, #7402: URL: https://github.com/apache/inlong/pull/7402 ### Prepare a Pull Request - Fixes #7401 ### Motivation Fix the problem of partitions could not be created based on numPartitions in the inlong group ### Modifications Fix the problem of partitions could not be created based on numPartitions in the inlong group -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] e-mhui opened a new pull request, #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
e-mhui opened a new pull request, #7403: URL: https://github.com/apache/inlong/pull/7403 Upgrade Oracle CDC to version 2.3 - Fixes #7400 ### Motivation Upgrade Oracle CDC to version 2.3 ### Modifications 1. modify `pom.xml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7402: [INLONG-7401][Manager] Fix the problem of partitions could not be created based on numPartitions
healchow commented on code in PR #7402:
URL: https://github.com/apache/inlong/pull/7402#discussion_r1113189263
##
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##
@@ -49,7 +49,7 @@
public class PulsarOperator {
private static final Logger LOGGER =
LoggerFactory.getLogger(InlongClusterServiceImpl.class);
-private static final int MAX_PARTITION = 100;
+private static final int MAX_PARTITION = 1000;
Review Comment:
Please add some comment for the value, such as:
```suggestion
/**
*The maximum number of partitions, which is an empirical value,
* generally does not exceed 1000 in large clusters.
*/
private static final int MAX_PARTITION = 1000;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [inlong] healchow commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
healchow commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1438655116 Hi @e-mhui, I see you committed some unrelated commits in this PR. From my practice, you can reset hard from the master branch before pushing your commit. 1. `git stash -m "your new codes"` , save your local changes into stash stack. 2. `git pull upstream master` , if there are conflicts, ignore them. 3. `git reset --hard upstream/master` , this operation will keep your local branch the same as the upstream master branch. 4. `git stash pop` , continue to do your work, and then commit, finally create a pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] healchow commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
healchow commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1438660739 In this scenario, you can do like this: 1. record your commit hash, it is `3f9f62ccd3ae421f90058ee0da12802f15327772`. 2. `git pull upstream master` 3. `git reset --hard upstream/master` 4. `git cherry-pick 3f9f62ccd3ae421f90058ee0da12802f15327772` 5. `git push your-repo(default is origin) INLONG-7400 (your currently branch) -f` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
e-mhui commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1439339017 > In this PR, it seems that you just need commit the final change, so you can do like this: > >  > > 1. record your commit hash, it is `3f9f62ccd3ae421f90058ee0da12802f15327772`. > 2. `git pull upstream master` > 3. `git reset --hard upstream/master` > 4. `git cherry-pick 3f9f62ccd3ae421f90058ee0da12802f15327772` > 5. `git push your-repo(default is origin) INLONG-7400 (your currently branch) -f` Thank you for your help, it has done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
yunqingmoswu commented on code in PR #7403: URL: https://github.com/apache/inlong/pull/7403#discussion_r1113758310 ## inlong-sort/sort-connectors/oracle-cdc/pom.xml: ## @@ -30,7 +30,7 @@ Apache InLong - Sort-connector-oracle-cdc -1.7.0.Final +1.6.4.Final Review Comment: The version of oracle-cdc is upgraded but the version of debezium is lower? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] EMsnap commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
EMsnap commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1439347149 Please add description on the reason for updating version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] e-mhui commented on a diff in pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
e-mhui commented on code in PR #7403: URL: https://github.com/apache/inlong/pull/7403#discussion_r1113762226 ## inlong-sort/sort-connectors/oracle-cdc/pom.xml: ## @@ -30,7 +30,7 @@ Apache InLong - Sort-connector-oracle-cdc -1.7.0.Final +1.6.4.Final Review Comment: Flink cdc 2.3 depends on the 1.6.4 version of debezium, and the 1.7.0 version of debezium conflicts with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] liaorui commented on a diff in pull request #7394: [INLONG-7391][Sort] Support CSV format and dirty data collecting for StarRocks connector all db migrating
liaorui commented on code in PR #7394:
URL: https://github.com/apache/inlong/pull/7394#discussion_r1113763610
##
inlong-sort/sort-connectors/base/src/test/java/org/apache/inlong/sort/base/dirty/RegexReplaceTest.java:
##
@@ -32,7 +32,7 @@ public void testRegexReplacement() throws IOException {
identifier[0] = "yizhouyang";
identifier[1] = "table2";
String pattern = "${database}-${table}-${DIRTY_MESSAGE}";
-String answer = DirtySinkHelper.regexReplace(pattern,
DirtyType.BATCH_LOAD_ERROR, "mock message", identifier);
+String answer = DirtySinkHelper.regexReplace(pattern,
DirtyType.BATCH_LOAD_ERROR, "mock message");
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
e-mhui commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1439368431 > Please add description on the reason for updating version It has done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] gong commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
gong commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1439382271 @e-mhui Please update license file of license module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] haifxu opened a new pull request, #7405: [INLONG-7404][Agent] Fix error of Redis connector
haifxu opened a new pull request, #7405: URL: https://github.com/apache/inlong/pull/7405 ### Prepare a Pull Request - Fixes #7404 ### Motivation 1. Missing redis job for Redis connector. ### Modifications 1. Add `RedisJob`. ### Verifying this change  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] e-mhui commented on pull request #7403: [INLONG-7400][Sort] Upgrade Oracle CDC to version 2.3
e-mhui commented on PR #7403: URL: https://github.com/apache/inlong/pull/7403#issuecomment-1439386046 > @e-mhui Please update license file of license module done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [inlong] healchow merged pull request #7402: [INLONG-7401][Manager] Fix that cannot create Pulsar partitions based on numPartitions param
healchow merged PR #7402: URL: https://github.com/apache/inlong/pull/7402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[inlong] branch master updated (730feee34 -> 2c6de2ac9)
This is an automated email from the ASF dual-hosted git repository. healchow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from 730feee34 [INLONG-7395][Manager] Reduce log in SortSouceService and SortClusterService (#7396) add 2c6de2ac9 [INLONG-7401][Manager] Fix that cannot create Pulsar partitions based on numPartitions param (#7402) No new revisions were added by this update. Summary of changes: .../manager/service/resource/queue/pulsar/PulsarOperator.java | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)
