Re: [I] [Apache][Infra] Committer: How to bind GitHub account to Apache account [incubator-graphar]
sighingnow commented on issue #437: URL: https://github.com/apache/incubator-graphar/issues/437#issuecomment-2044103334 Done.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Update the doucument with apache guide [incubator-graphar]
acezen opened a new pull request, #444: URL: https://github.com/apache/incubator-graphar/pull/444 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have read the [CONTRIBUTING](https://github.com/alibaba/GraphAr/blob/main/CONTRIBUTING.rst) doc - [ ] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Spark-java-refactor] Split java-info to a single submodule [incubator-graphar]
acezen commented on issue #445: URL: https://github.com/apache/incubator-graphar/issues/445#issuecomment-2046472215 the discussion note can find in [GraphAr meeting note(2024-04-09)](https://docs.google.com/document/d/1fzMW_6lzTbR0YGa3C0pY3ca_ZYuPSBkmrNtfWXlnYr8/edit#heading=h.k1ts4kvvl8jq) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Feat][Doc] Update the repository url and the docs url [incubator-graphar]
acezen merged PR #444: URL: https://github.com/apache/incubator-graphar/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] chore: fix the header of pyspark source code [incubator-graphar]
acezen opened a new pull request, #446: URL: https://github.com/apache/incubator-graphar/pull/446 ## Proposed changes as title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: fix the header of pyspark source code [incubator-graphar]
acezen merged PR #446: URL: https://github.com/apache/incubator-graphar/pull/446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Add community page [incubator-graphar-website]
acezen opened a new pull request, #9: URL: https://github.com/apache/incubator-graphar-website/pull/9 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Add community message [incubator-graphar-website]
acezen merged PR #9: URL: https://github.com/apache/incubator-graphar-website/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] chore: Removing the community and release related document (already moved to website) [incubator-graphar]
acezen opened a new pull request, #447: URL: https://github.com/apache/incubator-graphar/pull/447 ## Proposed changes related #432 In https://github.com/apache/incubator-graphar-website/pull/9, the community and release related document has been add to the website, we should remove them from here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: Removing the community and release related document (already moved to website) [incubator-graphar]
acezen merged PR #447: URL: https://github.com/apache/incubator-graphar/pull/447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] [Docs] Reorg the documents to adapt website building [incubator-graphar]
acezen opened a new pull request, #448: URL: https://github.com/apache/incubator-graphar/pull/448 ## Proposed changes Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have read the [CONTRIBUTING](https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.rst) doc - [ ] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] chore: run docs CI on ubuntu-latest and separate license check to individual CI [incubator-graphar]
acezen opened a new pull request, #449: URL: https://github.com/apache/incubator-graphar/pull/449 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen commented on PR #448: URL: https://github.com/apache/incubator-graphar/pull/448#issuecomment-2049064241 cc/ @lixueclaire @Thespica @SemyonSinchenko This pull request make a lot of change to the document, may need your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
SemyonSinchenko commented on code in PR #448:
URL: https://github.com/apache/incubator-graphar/pull/448#discussion_r1560586502
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
+you create a SparkSession:
+
+```python
+from pyspark.sql import SparkSession
+
+spark = (
+SparkSession
+.builder
+.master("local[1]")
+.appName("graphar-local-tests")
+.config("spark.jars", "../../spark/target/graphar-0.1.0-SNAPSHOT.jar")
+.config("spark.log.level", "INFO")
+.getOrCreate()
+)
+```
+
+
+ .. rubric:: GraphAr PySpark initialize
+ :name: graphar-pyspark-initialize
+
+## GraphAr PySpark initialize
+
+PySpark bindings are heavily relying on JVM-calls via ``py4j``. To
+initiate all the neccessary things for it just call
+``graphar_pyspark.initialize()``:
+
+```python
+from graphar_pyspark import initialize
+
+initialize(spark)
+```
+
+## GraphAr objects
+
+Now you can import, create and modify all the classes you can work
Review Comment:
```suggestion
Now you can import, create and modify all the classes you can
```
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
+you create a SparkSession:
+
+```python
+from pyspark.sql import SparkSession
+
+spark = (
+SparkSession
+.builder
+.master("local[1]")
+.appName("graphar-local-tests")
+.config("spark.jars", "../../spark/target/graphar-0.1.0-SNAPSHOT.jar")
+.config("spark.log.level", "INFO")
+.getOrCreate()
+)
+```
+
+
+ .. rubric:: GraphAr PySpark initialize
+ :name: graphar-pyspark-initialize
+
+## GraphAr PySpark initialize
+
+PySpark bindings are heavily relying on JVM-calls via ``py4j``. To
+initiate all the neccessary things for it just call
+``graphar_pyspark.initialize()``:
+
+```python
+from graphar_pyspark import initialize
+
+initialize(spark)
+```
+
+## GraphAr objects
+
+Now you can import, create and modify all the classes you can work
+call from [scala API of
GraphAr](https://graphar.apache.org/docs/libraries/spark).
+For simplify using of graphar from python constants, like GAR-types,
+supported file-types, etc. are placed in ``graphar_pyspark.enums``.
+
+```python
+from graphar_pyspark.info import Property, PropertyGroup, AdjList,
AdjListType, VertexInfo, EdgeInfo, GraphInfo
+from graphar_pyspark.enums import GarType, FileType
+```
+
+Main objects of GraphAr are the following:
+
+- GraphInfo
+- VertexInfo
+- EdgeInfo
+
+You can check [Scala library
documentation](https://graphar.apache.org/docs/spark#information-classes)
Review Comment:
Is it possible to use relative paths instead? It would be better than full
links. Is it working in apache-like websites?
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
+you create a SparkSession:
+
+```python
+from pyspark.sql import SparkSession
+
+spark = (
+SparkSession
+.builder
+.master("local[1]")
+.appName("graphar-local-tests")
+.config("spark.jars", "../../spark/target/graphar-0.1.0-SNAPSHOT.jar")
Review Comment:
```suggestion
.config("spark.jars",
"../../spark/graphar/target/graphar-0.1.0-SNAPSHOT.jar")
```
Because of submodules
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
+you create a SparkSession:
+
+```python
+from pyspark.sql import SparkSession
+
+spark = (
+SparkSession
+.builder
+.master("local[1]")
+.appName("graphar-local-tests")
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen commented on code in PR #448:
URL: https://github.com/apache/incubator-graphar/pull/448#discussion_r1560609249
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
+you create a SparkSession:
+
+```python
+from pyspark.sql import SparkSession
+
+spark = (
+SparkSession
+.builder
+.master("local[1]")
+.appName("graphar-local-tests")
+.config("spark.jars", "../../spark/target/graphar-0.1.0-SNAPSHOT.jar")
+.config("spark.log.level", "INFO")
+.getOrCreate()
+)
+```
+
+
+ .. rubric:: GraphAr PySpark initialize
+ :name: graphar-pyspark-initialize
+
+## GraphAr PySpark initialize
+
+PySpark bindings are heavily relying on JVM-calls via ``py4j``. To
+initiate all the neccessary things for it just call
+``graphar_pyspark.initialize()``:
+
+```python
+from graphar_pyspark import initialize
+
+initialize(spark)
+```
+
+## GraphAr objects
+
+Now you can import, create and modify all the classes you can work
+call from [scala API of
GraphAr](https://graphar.apache.org/docs/libraries/spark).
+For simplify using of graphar from python constants, like GAR-types,
+supported file-types, etc. are placed in ``graphar_pyspark.enums``.
+
+```python
+from graphar_pyspark.info import Property, PropertyGroup, AdjList,
AdjListType, VertexInfo, EdgeInfo, GraphInfo
+from graphar_pyspark.enums import GarType, FileType
+```
+
+Main objects of GraphAr are the following:
+
+- GraphInfo
+- VertexInfo
+- EdgeInfo
+
+You can check [Scala library
documentation](https://graphar.apache.org/docs/spark#information-classes)
Review Comment:
yes, we can replace with relative path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen commented on code in PR #448:
URL: https://github.com/apache/incubator-graphar/pull/448#discussion_r1560609946
##
docs/libraries/pyspark/how-to.md:
##
@@ -0,0 +1,212 @@
+---
+id: how-to
+title: How to use GraphAr PySpark package
+sidebar_position: 1
+---
+
+
+## GraphAr PySpark
+
+``graphar_pyspark`` is implemented as bindings to GraphAr spark scala
+library. You should have ``graphar-0.1.0-SNAPSHOT.jar`` in your
+Apache Spark JVM classpath. Otherwise you will get an exception. To
+add it spceify ``config("spark.jars", "path-to-graphar-jar")`` when
Review Comment:
Thanks for pointing the typo, maybe we can add a CI to check typos, I will
try to add in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: run docs CI on ubuntu-latest and separate license check to individual CI [incubator-graphar]
acezen merged PR #449: URL: https://github.com/apache/incubator-graphar/pull/449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Remove the docs content and use content in incubator-graphar repo [incubator-graphar-website]
acezen opened a new pull request, #10: URL: https://github.com/apache/incubator-graphar-website/pull/10 We put the dev docs in [incubartor-graphar/docs](https://github.com/apache/incubator-graphar/blob/main/docs), remove the docs content of this repo and refine the building process to sync the docs from incubator-graphar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen commented on PR #448: URL: https://github.com/apache/incubator-graphar/pull/448#issuecomment-2049405354 The path has been replaced with relative path, and I add a TODO for add markdown lint and typo check CI, please review again, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
Thespica commented on PR #448: URL: https://github.com/apache/incubator-graphar/pull/448#issuecomment-2049578642 Hi, @acezen the changes itself is LGTM. But when I try to build locally and take a look, I find it a little bit bothering. Can you write some letters that teach how to build documents locally in docs/README.md or docs for developers? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen commented on PR #448: URL: https://github.com/apache/incubator-graphar/pull/448#issuecomment-2049653020 > Hi, @acezen the change itself is LGTM. > > But when I try to build locally and take a look, I find it a little bit bothering. Can you write some letters that teach how to build documents locally in docs/README.md or docs for developers? hi,@Thespica, I have put the instruction how to build docs in apache-incubator-website README(they share the same process) and would merge after this PR. The docs/README would have a link to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Reorganize the documents to adapt website building [incubator-graphar]
acezen merged PR #448: URL: https://github.com/apache/incubator-graphar/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Remove the docs content and use content in incubator-graphar repo instead [incubator-graphar-website]
acezen merged PR #10: URL: https://github.com/apache/incubator-graphar-website/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Add API reference pages place holder [incubator-graphar-website]
acezen opened a new pull request, #11: URL: https://github.com/apache/incubator-graphar-website/pull/11 Now the API references are not ready, add place holder to avoid page not found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Add API reference pages place holder to avoid page not found error [incubator-graphar-website]
acezen merged PR #11: URL: https://github.com/apache/incubator-graphar-website/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] [Minor][Doc] Fix issues in the documentation [incubator-graphar]
lixueclaire opened a new pull request, #450: URL: https://github.com/apache/incubator-graphar/pull/450 ## Proposed changes as titled. ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] I have read the [CONTRIBUTING](https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.rst) doc - [x] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Minor][Doc] Fix issues in the documentation [incubator-graphar]
acezen merged PR #450: URL: https://github.com/apache/incubator-graphar/pull/450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Add devdoc CI to fetch the dev docs and deploy, trigger by manual or … [incubator-graphar-website]
acezen opened a new pull request, #12: URL: https://github.com/apache/incubator-graphar-website/pull/12 …certain schedule time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Add devdoc CI to fetch the dev docs and deploy, trigger by manual or … [incubator-graphar-website]
acezen merged PR #12: URL: https://github.com/apache/incubator-graphar-website/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] [Improve][DevInfra] Use korandoru/hawkeye to check license header [incubator-graphar]
acezen opened a new pull request, #452: URL: https://github.com/apache/incubator-graphar/pull/452 ## Proposed changes related #451 ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have read the [CONTRIBUTING](https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.rst) doc - [ ] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments Fix #451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Improve][DevInfra] Use korandoru/hawkeye to check license header [incubator-graphar]
acezen merged PR #452: URL: https://github.com/apache/incubator-graphar/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Feat][DevInfra] Use `korandoru / hawkeye` to check license header [incubator-graphar]
acezen closed issue #451: [Feat][DevInfra] Use `korandoru / hawkeye` to check license header URL: https://github.com/apache/incubator-graphar/issues/451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Refine the API reference generation process for libraries [incubator-graphar]
acezen opened a new pull request, #453: URL: https://github.com/apache/incubator-graphar/pull/453 ## Proposed changes related issue ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have read the [CONTRIBUTING](https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.rst) doc - [ ] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Refine the API reference generation process for libraries [incubator-graphar]
acezen commented on PR #453: URL: https://github.com/apache/incubator-graphar/pull/453#issuecomment-2058110635 hi, @SemyonSinchenko. The [CI report](https://github.com/apache/incubator-graphar/actions/runs/8698896273/job/23856591503?pr=453) seems that generate GraphAr PySpark docs need to install pyspark first, I'm not sure pyspark is necessary for docs building or not. Maybe I set something wrong? Can you help me with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Add api reference generation process [incubator-graphar-website]
acezen opened a new pull request, #13: URL: https://github.com/apache/incubator-graphar-website/pull/13 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
SemyonSinchenko commented on code in PR #453:
URL: https://github.com/apache/incubator-graphar/pull/453#discussion_r1566702548
##
.github/workflows/spark.yaml:
##
@@ -52,38 +52,44 @@ jobs:
spark-hadoop: "spark-3.3.4-bin-hadoop3"
steps:
-- uses: actions/checkout@v3
+- uses: actions/checkout@v4
with:
submodules: true
- name: Code Format Check
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
mvn --no-transfer-progress spotless:check
-popd
- name: Build GraphAr Spark
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
echo "Build ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress clean package -DskipTests
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-popd
+mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
+
+- name: Build Spark Docs
+ working-directory: spark
+ run: |
+export JAVA_HOME=${JAVA_HOME_11_X64}
+echo "Build ${{ matrix.mvn-profile }}"
+# FIXME: the install is not necessary, but it is a workaround for the
issue
+mvn install -DskipTests -Dspotless.check.skip=true
Review Comment:
I would like to add --no-transfer-progress
##
.github/workflows/spark.yaml:
##
@@ -52,38 +52,44 @@ jobs:
spark-hadoop: "spark-3.3.4-bin-hadoop3"
steps:
-- uses: actions/checkout@v3
+- uses: actions/checkout@v4
with:
submodules: true
- name: Code Format Check
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
mvn --no-transfer-progress spotless:check
-popd
- name: Build GraphAr Spark
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
echo "Build ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress clean package -DskipTests
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-popd
+mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
+
+- name: Build Spark Docs
+ working-directory: spark
+ run: |
+export JAVA_HOME=${JAVA_HOME_11_X64}
+echo "Build ${{ matrix.mvn-profile }}"
+# FIXME: the install is not necessary, but it is a workaround for the
issue
+mvn install -DskipTests -Dspotless.check.skip=true
+mvn scala:doc
- name: Run test
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
export SPARK_TESTING=1
-pushd spark
echo "Test ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress test -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
-popd
+mvn test -Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
Review Comment:
It is better to have --no-transfer-progress; otherwise, it is almost
impossible to read logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
SemyonSinchenko commented on PR #453: URL: https://github.com/apache/incubator-graphar/pull/453#issuecomment-2058226388 > hi, @SemyonSinchenko. The [CI report](https://github.com/apache/incubator-graphar/actions/runs/8698896273/job/23856591503?pr=453) seems that generate GraphAr PySpark docs need to install pyspark first, I'm not sure pyspark is necessary for docs building or not. Maybe I set something wrong? Can you help me with this? Yes, it is needed. Under the hood sphinx, actually imports all the Python files to build a tree. On a stage of the importkng all the dependencies should be fulfilled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
acezen commented on code in PR #453:
URL: https://github.com/apache/incubator-graphar/pull/453#discussion_r1566728495
##
.github/workflows/spark.yaml:
##
@@ -52,38 +52,44 @@ jobs:
spark-hadoop: "spark-3.3.4-bin-hadoop3"
steps:
-- uses: actions/checkout@v3
+- uses: actions/checkout@v4
with:
submodules: true
- name: Code Format Check
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
mvn --no-transfer-progress spotless:check
-popd
- name: Build GraphAr Spark
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
echo "Build ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress clean package -DskipTests
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-popd
+mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
+
+- name: Build Spark Docs
+ working-directory: spark
+ run: |
+export JAVA_HOME=${JAVA_HOME_11_X64}
+echo "Build ${{ matrix.mvn-profile }}"
+# FIXME: the install is not necessary, but it is a workaround for the
issue
+mvn install -DskipTests -Dspotless.check.skip=true
+mvn scala:doc
- name: Run test
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
export SPARK_TESTING=1
-pushd spark
echo "Test ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress test -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
-popd
+mvn test -Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
Review Comment:
added back.
##
.github/workflows/spark.yaml:
##
@@ -52,38 +52,44 @@ jobs:
spark-hadoop: "spark-3.3.4-bin-hadoop3"
steps:
-- uses: actions/checkout@v3
+- uses: actions/checkout@v4
with:
submodules: true
- name: Code Format Check
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
mvn --no-transfer-progress spotless:check
-popd
- name: Build GraphAr Spark
+ working-directory: spark
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
-pushd spark
echo "Build ${{ matrix.mvn-profile }}"
-mvn --no-transfer-progress clean package -DskipTests
-Dspotless.check.skip=true -P ${{ matrix.mvn-profile }}
-popd
+mvn clean package -DskipTests -Dspotless.check.skip=true -P ${{
matrix.mvn-profile }}
+
+- name: Build Spark Docs
+ working-directory: spark
+ run: |
+export JAVA_HOME=${JAVA_HOME_11_X64}
+echo "Build ${{ matrix.mvn-profile }}"
+# FIXME: the install is not necessary, but it is a workaround for the
issue
+mvn install -DskipTests -Dspotless.check.skip=true
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
acezen commented on PR #453: URL: https://github.com/apache/incubator-graphar/pull/453#issuecomment-2058560221 > > hi, @SemyonSinchenko. The [CI report](https://github.com/apache/incubator-graphar/actions/runs/8698896273/job/23856591503?pr=453) seems that generate GraphAr PySpark docs need to install pyspark first, I'm not sure pyspark is necessary for docs building or not. Maybe I set something wrong? Can you help me with this? > > Yes, it is needed. Under the hood sphinx, actually imports all the Python files to build a tree. On a stage of the importing all the dependencies should be fulfilled. Thanks Sem, added pyspark install in docs generation process, the CI has passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
SemyonSinchenko commented on code in PR #453:
URL: https://github.com/apache/incubator-graphar/pull/453#discussion_r1567080373
##
.github/workflows/java.yml:
##
@@ -61,18 +61,22 @@ jobs:
sudo apt-get install llvm-11 clang-11 lld-11 libclang-11-dev
libz-dev -y
- name: Code Format Check
+working-directory: java
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
- pushd java
mvn spotless:check
Review Comment:
Maybe let's add --no-transfer-progress in java too? Without that option, it
will be much harder to read logs in GitHub actions. I would recommend using
that option in every place in CI; that option was introduced for CI builds
mostly to make logs readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
acezen commented on code in PR #453:
URL: https://github.com/apache/incubator-graphar/pull/453#discussion_r1567086483
##
.github/workflows/java.yml:
##
@@ -61,18 +61,22 @@ jobs:
sudo apt-get install llvm-11 clang-11 lld-11 libclang-11-dev
libz-dev -y
- name: Code Format Check
+working-directory: java
run: |
export JAVA_HOME=${JAVA_HOME_11_X64}
- pushd java
mvn spotless:check
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
acezen commented on PR #453: URL: https://github.com/apache/incubator-graphar/pull/453#issuecomment-2060219702 @lixueclaire @Thespica any comments? I prepare to merge the PR today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
Thespica commented on PR #453: URL: https://github.com/apache/incubator-graphar/pull/453#issuecomment-2060344235 > @lixueclaire @Thespica any comments? I prepare to merge the PR today. LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [Docs] Refine the API reference generation process for libraries [incubator-graphar]
acezen merged PR #453: URL: https://github.com/apache/incubator-graphar/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Infra] IP Clearance and Code Cleanup [incubator-graphar]
CalvinKirs commented on issue #430: URL: https://github.com/apache/incubator-graphar/issues/430#issuecomment-2060571053 Third Party Licensing Policy: https://www.apache.org/legal/resolved.html For binary dependencies, JUnit (EPL)is a perfectly viable option. check here: https://www.apache.org/legal/resolved.html#binary-only-inclusion-condition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Add api reference generation process [incubator-graphar-website]
acezen merged PR #13: URL: https://github.com/apache/incubator-graphar-website/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Infra] IP Clearance and Code Cleanup [incubator-graphar]
acezen commented on issue #430: URL: https://github.com/apache/incubator-graphar/issues/430#issuecomment-2060649077 > Third Party Licensing Policy: https://www.apache.org/legal/resolved.html For binary dependencies, JUnit (EPL)is a perfectly viable option. check here: https://www.apache.org/legal/resolved.html#binary-only-inclusion-condition Thanks for the clarification:) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Direct cpp api reference to correct location [incubator-graphar-website]
acezen opened a new pull request, #14: URL: https://github.com/apache/incubator-graphar-website/pull/14 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Direct cpp api reference to correct location & Add generate api docs to devdoc.yml too [incubator-graphar-website]
acezen merged PR #14: URL: https://github.com/apache/incubator-graphar-website/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] [FEAT][C++] Use `#program once` to replace `#ifndef` as include guards [incubator-graphar]
acezen opened a new pull request, #455: URL: https://github.com/apache/incubator-graphar/pull/455 ## Proposed changes This change use `#program once` to replace `#ifndef` as include guards ## Further comments Fixs #454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] [FEAT][C++] Cast to correct schema when get chunk with property reader [incubator-graphar]
acezen opened a new pull request, #456: URL: https://github.com/apache/incubator-graphar/pull/456 ## Proposed changes as issue #219 describe, the chunk table get from arrow chunk reader may not has the same type with schema. This change help to fix the problem by cast the chunk table to what they should be(schema), if cast failed, raise error. ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [ ] I have read the [CONTRIBUTING](https://github.com/apache/incubator-graphar/blob/main/CONTRIBUTING.rst) doc - [ ] I have signed the CLA - [ ] Lint and unit tests pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments fixes #219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [FEAT][C++] Use `#pragma once` to replace `#ifndef` as include guards [incubator-graphar]
acezen merged PR #455: URL: https://github.com/apache/incubator-graphar/pull/455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] [BugFix][C++] Cast to correct schema when get chunk with property reader [incubator-graphar]
acezen merged PR #456: URL: https://github.com/apache/incubator-graphar/pull/456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Bug]: DataType inconsistent for Int32 in CSV file format [incubator-graphar]
acezen closed issue #219: [Bug]: DataType inconsistent for Int32 in CSV file format URL: https://github.com/apache/incubator-graphar/issues/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Feat][C++] Use `#pragma once` to replace include guard [incubator-graphar]
acezen closed issue #454: [Feat][C++] Use `#pragma once` to replace include guard URL: https://github.com/apache/incubator-graphar/issues/454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Feat][C++] Use `#pragma once` to replace include guard [incubator-graphar]
acezen commented on issue #454: URL: https://github.com/apache/incubator-graphar/issues/454#issuecomment-2066240085 close as resoved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave edited a discussion: fail to run example
high_level_writer_example
It is ok to Build with examples and then run high_level_writer_example.
But when I create a new project and imitate the code of
high_level_writer_example.
The running result is：
Vertices builder
vertex_count=3
dump vertices collection successfully!
Edges builder
Assertion failed in "/home/chenyinbo/cppject/graphar-example/main-temp.cpp",
line 76
Probable bug in software.
I have observed the generated folder and there is no problem on vertex file
How to find where the problem lies（why it is fail to build edge）
main-temp.cpp
```
#include
#include "arrow/api.h"
#include "arrow/filesystem/api.h"
#include "./config.h"
#include "gar/api.h"
#include "gar/writer/edges_builder.h"
#include "gar/writer/vertices_builder.h"
void vertices_builder() {
// construct vertices builder
std::string vertex_meta_file =
"/home/chenyinbo/cppject/graphar-example/person.vertex.yml";
auto vertex_meta = graphar::Yaml::LoadFile(vertex_meta_file).value();
auto vertex_info = graphar::VertexInfo::Load(vertex_meta).value();
graphar::IdType start_index = 0;
graphar::builder::VerticesBuilder builder(vertex_info,
"/home/chenyinbo/cppject/graphar-example/generate-temp/", start_index);
// set validate level
builder.SetValidateLevel(graphar::ValidateLevel::strong_validate);
// prepare vertex data
int vertex_count = 3;
std::vector property_names = {"id", "firstName", "lastName",
"gender"};
std::vector id = {0, 1, 2};
std::vector firstName = {"John", "Jane", "Alice"};
std::vector lastName = {"Smith", "Doe", "Wonderland"};
std::vector gender = {"male", "famale", "famale"};
// add vertices
for (int i = 0; i < vertex_count; i++) {
graphar::builder::Vertex v;
v.AddProperty(property_names[0], id[i]);
v.AddProperty(property_names[1], firstName[i]);
v.AddProperty(property_names[2], lastName[i]);
v.AddProperty(property_names[3], gender[i]);
ASSERT(builder.AddVertex(v).ok());
}
// dump
ASSERT(builder.GetNum() == vertex_count);
std::cout << "vertex_count=" << builder.GetNum() << std::endl;
ASSERT(builder.Dump().ok());
std::cout << "dump vertices collection successfully!" << std::endl;
// clear vertices
builder.Clear();
ASSERT(builder.GetNum() == 0);
}
void edges_builder() {
// construct edges builder
std::string edge_meta_file =
"/home/chenyinbo/cppject/graphar-example/person_knows_person.edge.yml";
auto edge_meta = graphar::Yaml::LoadFile(edge_meta_file).value();
auto edge_info = graphar::EdgeInfo::Load(edge_meta).value();
auto vertex_count = 3;
graphar::builder::EdgesBuilder builder(
edge_info,
"/home/chenyinbo/cppject/graphar-example/generate-temp/",
graphar::AdjListType::ordered_by_dest, vertex_count);
// set validate level
builder.SetValidateLevel(graphar::ValidateLevel::strong_validate);
// prepare edge data
int edge_count = 4;
std::vector property_names = {"creationDate"};
std::vector src = {1, 0, 0, 2};
std::vector dst = {0, 1, 2, 1};
std::vector creationDate = {"2010-01-01", "2011-01-01",
"2012-01-01", "2013-01-01"};
// add edges
for (int i = 0; i < edge_count; i++) {
graphar::builder::Edge e(src[i], dst[i]);
e.AddProperty("creationDate", creationDate[i]);
ASSERT(builder.AddEdge(e).ok());
}
// dump
ASSERT(builder.GetNum() == edge_count);
std::cout << "edge_count=" << builder.GetNum() << std::endl;
ASSERT(builder.Dump().ok());
std::cout << "dump edges collection successfully!" << std::endl;
// clear edges
builder.Clear();
ASSERT(builder.GetNum() == 0);
}
int main(int argc, char* argv[]) {
// vertices builder
std::cout << "Vertices builder" << std::endl;
std::cout << "---" << std::endl;
vertices_builder();
std::cout << std::endl;
// edges builder
std::cout << "Edges builder" << std::endl;
std::cout << "" << std::endl;
edges_builder();
}
```
GitHub link: https://github.com/apache/incubator-graphar/discussions/457
This is an automatically sent email for commits@graphar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave added a comment to the discussion: fail to run example high_level_writer_example  GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165059 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave added a comment to the discussion: fail to run example
high_level_writer_example
CMakeLists.txt
```
cmake_minimum_required(VERSION 3.0)
project(GrapharExample)
# 查找Boost库
find_package(Boost REQUIRED COMPONENTS graph)
include_directories(${Boost_INCLUDE_DIRS})
# 查找Arrow库
find_package(Arrow REQUIRED)
include_directories(${Arrow_INCLUDE_DIRS})
# 指定gar库的头文件目录
include_directories(/usr/local/include/gar)
# 指定gar库的库文件目录
link_directories(/usr/local/lib/gar)
# 添加你的执行文件
add_executable(graphar-example main-temp.cpp)
# 链接所需的库
target_link_libraries(graphar-example
${Boost_LIBRARIES}
${Arrow_LIBRARIES}
gar
)
```
person.vertex.yml
```
label: person
chunk_size: 100
prefix: vertex/person/
property_groups:
- properties:
- name: id
data_type: int64
is_primary: true
file_type: csv
- properties:
- name: firstName
data_type: string
is_primary: false
- name: lastName
data_type: string
is_primary: false
- name: gender
data_type: string
is_primary: false
file_type: csv
version: gar/v1
```
person_knows_person.edge.yml
```
src_label: person
edge_label: knows
dst_label: person
chunk_size: 1024
src_chunk_size: 100
dst_chunk_size: 100
directed: false
prefix: edge/person_knows_person/
adj_lists:
- ordered: true
aligned_by: src
file_type: csv
property_groups:
- properties:
- name: creationDate
data_type: string
is_primary: false
file_type: csv
version: gar/v1
```
main-temp.cpp
```
#include
#include "arrow/api.h"
#include "arrow/filesystem/api.h"
#include "./config.h"
#include "gar/api.h"
#include "gar/writer/edges_builder.h"
#include "gar/writer/vertices_builder.h"
void vertices_builder() {
// construct vertices builder
std::string vertex_meta_file =
"/home/chenyinbo/cppject/graphar-example/person.vertex.yml";
auto vertex_meta = graphar::Yaml::LoadFile(vertex_meta_file).value();
auto vertex_info = graphar::VertexInfo::Load(vertex_meta).value();
graphar::IdType start_index = 0;
graphar::builder::VerticesBuilder builder(vertex_info,
"/home/chenyinbo/cppject/graphar-example/generate-temp/", start_index);
// set validate level
builder.SetValidateLevel(graphar::ValidateLevel::strong_validate);
// prepare vertex data
int vertex_count = 3;
std::vector property_names = {"id", "firstName", "lastName",
"gender"};
std::vector id = {0, 1, 2};
std::vector firstName = {"John", "Jane", "Alice"};
std::vector lastName = {"Smith", "Doe", "Wonderland"};
std::vector gender = {"male", "famale", "famale"};
// add vertices
for (int i = 0; i < vertex_count; i++) {
graphar::builder::Vertex v;
v.AddProperty(property_names[0], id[i]);
v.AddProperty(property_names[1], firstName[i]);
v.AddProperty(property_names[2], lastName[i]);
v.AddProperty(property_names[3], gender[i]);
ASSERT(builder.AddVertex(v).ok());
}
// dump
ASSERT(builder.GetNum() == vertex_count);
std::cout << "vertex_count=" << builder.GetNum() << std::endl;
ASSERT(builder.Dump().ok());
std::cout << "dump vertices collection successfully!" << std::endl;
// clear vertices
builder.Clear();
ASSERT(builder.GetNum() == 0);
}
void edges_builder() {
// construct edges builder
std::string edge_meta_file =
"/home/chenyinbo/cppject/graphar-example/person_knows_person.edge.yml";
auto edge_meta = graphar::Yaml::LoadFile(edge_meta_file).value();
auto edge_info = graphar::EdgeInfo::Load(edge_meta).value();
auto vertex_count = 3;
graphar::builder::EdgesBuilder builder(
edge_info,
"/home/chenyinbo/cppject/graphar-example/generate-temp/",
graphar::AdjListType::ordered_by_dest, vertex_count);
// set validate level
builder.SetValidateLevel(graphar::ValidateLevel::strong_validate);
// prepare edge data
int edge_count = 4;
std::vector property_names = {"creationDate"};
std::vector src = {1, 0, 0, 2};
std::vector dst = {0, 1, 2, 1};
std::vector creationDate = {"2010-01-01", "2011-01-01",
"2012-01-01", "2013-01-01"};
// add edges
for (int i = 0; i < edge_count; i++) {
graphar::builder::Edge e(src[i], dst[i]);
e.AddProperty("creationDate", creationDate[i]);
ASSERT(builder.AddEdge(e).ok());
}
// dump
ASSERT(builder.GetNum() == edge_count);
std::cout << "edge_count=" << builder.GetNum() << std::endl;
ASSERT(builder.Dump().ok());
std::cout << "dump edges collection successfully!" << std::endl;
// clear edges
builder.Clear();
ASSERT(builder.GetNum() == 0);
}
int main(int argc, char* argv[]) {
// vertices builder
std::cout << "Vertices builder" << std::endl;
std::cout << "---" << std::end
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave edited a discussion: fail to run example high_level_writer_example It is ok to Build with examples and then run high_level_writer_example. But when I create a new project and imitate the code of high_level_writer_example. The running result is： Vertices builder vertex_count=3 dump vertices collection successfully! Edges builder Assertion failed in "/home/chenyinbo/cppject/graphar-example/main-temp.cpp", line 76 Probable bug in software. I have observed the generated folder and there is no problem on vertex file How to find where the problem lies（why it is fail to build edge） GitHub link: https://github.com/apache/incubator-graphar/discussions/457 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example Thank for posting the question, I will take a look to the code. GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165294 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen added a comment to the discussion: fail to run example high_level_writer_example Thank for post the question, I will take a look to the code. GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165294 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen added a comment to the discussion: fail to run example
high_level_writer_example
how about log out the error message of AddEdge operation:
```c++
auto st = builder.AddEdge(e);
if (!st.ok()) {
std::cout << "Failing adding edge: " << st.message() << std::endl;
}
```
GitHub link:
https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165372
This is an automatically sent email for commits@graphar.apache.org.
To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that AddEdge need edge info contain both ordered_by_source and ordered_by_dest adj list, which is not right. I will open an issue to fix that. And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv - ordered: true aligned_by: dst file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen added a comment to the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that AddEdge need edge info contain both ordered_by_source and ordered_by_dest adj list, which it not right. I will open an issue to fix that. And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv - ordered: true aligned_by: dst file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that you has passed the wrong adj list in **LINE 58**, which should be `ordered_by_src`(same the the edge info), but you pass `ordered_by_dst`. And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that you has passed the wrong adj list in **LINE 58**, which should be `ordered_by_src`(same the the edge info), but you passed `ordered_by_dst`. And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that you has passed the wrong adj list in **LINE 58**, which should be `ordered_by_source`(same the the edge info), but you passed `ordered_by_dst`. And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that you has passed the wrong adj list in **LINE 58**, which should be `ordered_by_source`(same with the the edge info), but you passed `ordered_by_dst`. ```c++ graphar::builder::EdgesBuilder builder( edge_info, "/home/chenyinbo/cppject/graphar-example/generate-temp/", graphar::AdjListType::ordered_by_dest, vertex_count); ``` And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user acezen edited a comment on the discussion: fail to run example high_level_writer_example I have reproduce the problem: https://github.com/apache/incubator-graphar/assets/11835645/b8d50052-32be-4709-977c-77339337504c";> It seems that you has passed the wrong adj list in **LINE 58**, which should be `ordered_by_source`(same the the edge info), but you passed `ordered_by_dst`. ```c++ graphar::builder::EdgesBuilder builder( edge_info, "/home/chenyinbo/cppject/graphar-example/generate-temp/", graphar::AdjListType::ordered_by_dest, vertex_count); ``` And btw, now the property group is independent from adj list, try update the `person_knows_person.edge.yml` to: ```yaml src_label: person edge_label: knows dst_label: person chunk_size: 1024 src_chunk_size: 100 dst_chunk_size: 100 directed: false prefix: edge/person_knows_person/ adj_lists: - ordered: true aligned_by: src file_type: csv property_groups: - file_type: csv properties: - name: creationDate data_type: string is_primary: false version: gar/v1 GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165534 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave added a comment to the discussion: fail to run example high_level_writer_example Thank you, I will give it a try next week GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9165631 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [D] fail to run example high_level_writer_example [incubator-graphar]
GitHub user Agwave added a comment to the discussion: fail to run example high_level_writer_example Thank you @acezen for your assistance! Your solution worked perfectly. GitHub link: https://github.com/apache/incubator-graphar/discussions/457#discussioncomment-9182726 This is an automatically sent email for commits@graphar.apache.org. To unsubscribe, please send an email to: commits-unsubscr...@graphar.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] docs: Update CONTRIBUTING.md and READMEs [incubator-graphar]
acezen opened a new pull request, #458: URL: https://github.com/apache/incubator-graphar/pull/458 ## Proposed changes related issue #432 - Update `CONTRIBUTING` and `README` - Update the related template for pull request and issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] feat(c++): Replace with URI parse from arrow::internal::URI with boost::URL [incubator-graphar]
acezen opened a new pull request, #460: URL: https://github.com/apache/incubator-graphar/pull/460 ## Proposed changes as #459 describe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] feat(c++): Use simple-uri-parser as uri parser, remove the rely on arrow::internal::URI [incubator-graphar]
acezen merged PR #460: URL: https://github.com/apache/incubator-graphar/pull/460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] docs: Update CONTRIBUTING.md and READMEs [incubator-graphar]
acezen merged PR #458: URL: https://github.com/apache/incubator-graphar/pull/458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Infra][Doc] Update the documents with Apache branding guide and incubator-graphar-website [incubator-graphar]
acezen commented on issue #432: URL: https://github.com/apache/incubator-graphar/issues/432#issuecomment-2071474957 The sub-items have done, close the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Infra][Doc] Update the documents with Apache branding guide and incubator-graphar-website [incubator-graphar]
acezen closed issue #432: [Infra][Doc] Update the documents with Apache branding guide and incubator-graphar-website URL: https://github.com/apache/incubator-graphar/issues/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[I] feat(c++): move the `result.hpp` third-party dependency from external directory to third-party directory [incubator-graphar]
acezen opened a new issue, #461: URL: https://github.com/apache/incubator-graphar/issues/461 ### Describe the enhancement requested Currently the single header third-party dependency [result](https://github.com/bitwizeshift/result) is put in the external directory for historical reason. To following GraphAr's code organization(third-party dependency should put in the third-party directory), it's better to move the result to third-party directory. ### Component(s) C++ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] feat(c++): move the result.hpp third-party dependency from external d… [incubator-graphar]
acezen opened a new pull request, #462: URL: https://github.com/apache/incubator-graphar/pull/462 …irectory to third-party directory ### Reason for this PR as issue #461 describe ### What changes are included in this PR? ### Are these changes tested? move the result.hpp to thirdparty ### Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Infra][Incubator] The tracking issue for Apache incubator code import process [incubator-graphar]
acezen closed issue #416: [Infra][Incubator] The tracking issue for Apache incubator code import process URL: https://github.com/apache/incubator-graphar/issues/416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] feat(c++): move the result.hpp third-party dependency from external directory to third-party directory [incubator-graphar]
acezen merged PR #462: URL: https://github.com/apache/incubator-graphar/pull/462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] chore: Update directory paths in README files [incubator-graphar]
jasinliu opened a new pull request, #464: URL: https://github.com/apache/incubator-graphar/pull/464 ### Reason for this PR ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: Update directory paths in README files [incubator-graphar]
liuxiaocs7 commented on code in PR #464: URL: https://github.com/apache/incubator-graphar/pull/464#discussion_r1577724006 ## cpp/README.md: ## @@ -42,7 +42,7 @@ repository and navigated to the ``cpp`` subdirectory: ```bash $ git clone https://github.com/apache/incubator-graphar.git -$ cd GraphAr +$ cd incubator-graphar Review Comment: how about ``` $ git clone https://github.com/apache/graphar.git $ cd graphar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: Update directory paths in README files [incubator-graphar]
acezen commented on code in PR #464: URL: https://github.com/apache/incubator-graphar/pull/464#discussion_r1577725274 ## cpp/README.md: ## @@ -42,7 +42,7 @@ repository and navigated to the ``cpp`` subdirectory: ```bash $ git clone https://github.com/apache/incubator-graphar.git -$ cd GraphAr +$ cd incubator-graphar Review Comment: incubator-graphar is ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: Update directory paths in README files [incubator-graphar]
acezen commented on PR #464: URL: https://github.com/apache/incubator-graphar/pull/464#issuecomment-2074738745 The CI failed is because `sudo apt-get update` got failed in github host, see https://github.com/orgs/community/discussions/120966 it's not related to this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] chore: Update directory paths in README files [incubator-graphar]
acezen merged PR #464: URL: https://github.com/apache/incubator-graphar/pull/464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] docs: including incubator disclaimer text as footer to api reference [incubator-graphar]
acezen opened a new pull request, #465: URL: https://github.com/apache/incubator-graphar/pull/465 ### Reason for this PR as https://github.com/apache/incubator-graphar-website/issues/15 describe ### What changes are included in this PR? add incubator disclaimer text to api reference pages ### Are these changes tested? ### Are there any user-facing changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] docs: include incubator disclaimer text as footer to api reference [incubator-graphar]
acezen merged PR #465: URL: https://github.com/apache/incubator-graphar/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] Add download page [incubator-graphar-website]
acezen opened a new pull request, #16: URL: https://github.com/apache/incubator-graphar-website/pull/16 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] Add download page [incubator-graphar-website]
acezen merged PR #16: URL: https://github.com/apache/incubator-graphar-website/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] [Feat][Format] Support extra metadata in graph info level that provide users to has user defined metadata [incubator-graphar]
acezen closed issue #354: [Feat][Format] Support extra metadata in graph info level that provide users to has user defined metadata URL: https://github.com/apache/incubator-graphar/issues/354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] Tracking issue of GraphAr first Apache release [incubator-graphar]
SemyonSinchenko commented on issue #466: URL: https://github.com/apache/incubator-graphar/issues/466#issuecomment-2078850506 Are we going to have Maven and PyPi packages for spark/pyspark? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [I] Tracking issue of GraphAr first Apache release [incubator-graphar]
acezen commented on issue #466: URL: https://github.com/apache/incubator-graphar/issues/466#issuecomment-2078921269 > Are we going to have Maven and PyPi packages for spark/pyspark? This is what I want to discuss in the dev list. We can release a source release. But I think it's better to release the binary package if we can (which we should evaluate the current status wether spark/pyspark/java is ready for a binary release) Since apache release process has more concern about the knowledge copyright, we can be familiar with the release procedure through the first release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[I] feat(java): Add aggregator POM for java and spark library to manage the dependency [incubator-graphar]
acezen opened a new issue, #468: URL: https://github.com/apache/incubator-graphar/issues/468 ### Describe the enhancement requested discussion thread: https://lists.apache.org/thread/hnh2b1pyf6vd0kwok5ggplrso23hrb25 ### Component(s) Java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] feat(java): Add aggregator POM for java and spark library to manage the dependency [incubator-graphar]
acezen opened a new pull request, #469: URL: https://github.com/apache/incubator-graphar/pull/469 ### Reason for this PR Add aggregator POM for java and spark library to easy manage the dependency ### What changes are included in this PR? add aggregator pom ### Are these changes tested? yes ### Are there any user-facing changes? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
[PR] feat(java): Split java-info to a single module [incubator-graphar]
Thespica opened a new pull request, #470: URL: https://github.com/apache/incubator-graphar/pull/470 ### Reason for this PR Split the java-info into a single module, which has the same level as spark. Related issue: #445 ### What changes are included in this PR? 1. move code under spark/java into java-info 2. add pom.xml and .scalafmt.conf 3. ignore maven target directory ### Are these changes tested? yes ### Are there any user-facing changes? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] feat(java): Split java-info to a single module [incubator-graphar]
acezen commented on PR #470: URL: https://github.com/apache/incubator-graphar/pull/470#issuecomment-2083125829 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] feat(java): Split java-info to a single module [incubator-graphar]
acezen merged PR #470: URL: https://github.com/apache/incubator-graphar/pull/470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
Re: [PR] feat(java): Add aggregator POM for java and spark library to manage the dependency [incubator-graphar]
acezen commented on PR #469: URL: https://github.com/apache/incubator-graphar/pull/469#issuecomment-2084225146 Hi, @SemyonSinchenko @Thespica I would like to get some advice about put the `spark` and `java` libraries to a directory like `maven-projects` next step, that would make the code structure clear and easy for developer to split the libraries into modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org For additional commands, e-mail: commits-h...@graphar.apache.org
