Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2543511278 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [fix](s3) improve error msg #45360 [doris]
github-actions[bot] commented on PR #45432: URL: https://github.com/apache/doris/pull/45432#issuecomment-2543455567 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [fix](catalog) opt the count pushdown rule for iceberg/paimon/hive scan node (#44038) (#45224)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new af0c1acb351 [fix](catalog) opt the count pushdown rule for
iceberg/paimon/hive scan node (#44038) (#45224)
af0c1acb351 is described below
commit af0c1acb351b44d9edbb1ded9d7a223dfbfeabd0
Author: Mingyu Chen (Rayner)
AuthorDate: Sat Dec 14 20:32:06 2024 -0800
[fix](catalog) opt the count pushdown rule for iceberg/paimon/hive scan
node (#44038) (#45224)
bp #44038
---
be/src/vec/exec/format/table/iceberg_reader.cpp| 18 ++--
be/src/vec/exec/format/table/iceberg_reader.h | 4 +-
be/src/vec/exec/format/table/paimon_reader.cpp | 3 +
be/src/vec/exec/scan/vfile_scanner.cpp | 4 +
.../doris/analysis/TableValuedFunctionRef.java | 5 +-
.../apache/doris/datasource/FileQueryScanNode.java | 27 +-
.../org/apache/doris/datasource/FileScanNode.java | 79
.../org/apache/doris/datasource/FileSplit.java | 5 +-
.../org/apache/doris/datasource/FileSplitter.java | 104 +
.../apache/doris/datasource/SplitAssignment.java | 2 +-
.../org/apache/doris/datasource/SplitCreator.java | 2 +-
.../apache/doris/datasource/SplitGenerator.java| 5 +-
.../doris/datasource/hive/source/HiveScanNode.java | 52 ---
.../doris/datasource/hive/source/HiveSplit.java| 6 +-
.../doris/datasource/hudi/source/HudiScanNode.java | 8 +-
.../datasource/iceberg/source/IcebergScanNode.java | 42 +
.../datasource/iceberg/source/IcebergSplit.java| 11 +--
.../lakesoul/source/LakeSoulScanNode.java | 7 +-
.../maxcompute/source/MaxComputeScanNode.java | 28 +++---
.../datasource/paimon/source/PaimonScanNode.java | 65 +++--
.../datasource/paimon/source/PaimonSplit.java | 7 +-
.../source/TrinoConnectorScanNode.java | 9 +-
.../doris/datasource/tvf/source/TVFScanNode.java | 22 -
.../glue/translator/PhysicalPlanTranslator.java| 20 ++--
.../apache/doris/planner/SingleNodePlanner.java| 24 ++---
.../tablefunction/DataGenTableValuedFunction.java | 3 +-
.../ExternalFileTableValuedFunction.java | 5 +-
.../GroupCommitTableValuedFunction.java| 3 +-
.../tablefunction/JdbcQueryTableValueFunction.java | 3 +-
.../tablefunction/MetadataTableValuedFunction.java | 3 +-
.../tablefunction/QueryTableValueFunction.java | 3 +-
.../doris/tablefunction/TableValuedFunctionIf.java | 3 +-
.../paimon/test_paimon_catalog.out | 80
.../iceberg/test_iceberg_optimize_count.groovy | 2 +-
.../paimon/test_paimon_catalog.groovy | 14 +++
35 files changed, 450 insertions(+), 228 deletions(-)
diff --git a/be/src/vec/exec/format/table/iceberg_reader.cpp
b/be/src/vec/exec/format/table/iceberg_reader.cpp
index 8f130ca6002..837269b0bb3 100644
--- a/be/src/vec/exec/format/table/iceberg_reader.cpp
+++ b/be/src/vec/exec/format/table/iceberg_reader.cpp
@@ -96,25 +96,25 @@
IcebergTableReader::IcebergTableReader(std::unique_ptr file_forma
_iceberg_profile.delete_rows_sort_time =
ADD_CHILD_TIMER(_profile, "DeleteRowsSortTime", iceberg_profile);
if (range.table_format_params.iceberg_params.__isset.row_count) {
-_remaining_push_down_count =
range.table_format_params.iceberg_params.row_count;
+_remaining_table_level_row_count =
range.table_format_params.iceberg_params.row_count;
} else {
-_remaining_push_down_count = -1;
+_remaining_table_level_row_count = -1;
}
}
Status IcebergTableReader::get_next_block(Block* block, size_t* read_rows,
bool* eof) {
// already get rows from be
-if (_push_down_agg_type == TPushAggOp::type::COUNT &&
_remaining_push_down_count > 0) {
-auto rows =
-std::min(_remaining_push_down_count,
(int64_t)_state->query_options().batch_size);
-_remaining_push_down_count -= rows;
+if (_push_down_agg_type == TPushAggOp::type::COUNT &&
_remaining_table_level_row_count > 0) {
+auto rows = std::min(_remaining_table_level_row_count,
+ (int64_t)_state->query_options().batch_size);
+_remaining_table_level_row_count -= rows;
auto mutate_columns = block->mutate_columns();
for (auto& col : mutate_columns) {
col->resize(rows);
}
block->set_columns(std::move(mutate_columns));
*read_rows = rows;
-if (_remaining_push_down_count == 0) {
+if (_remaining_table_level_row_count == 0) {
*eof = true;
}
@@ -164,7 +164,7 @@ Status IcebergTableReader::get_columns(
Status IcebergTableReader::init_row_filters(const TFileRangeDesc& range,
io::IOContext* io_ctx) {
// We get the
Re: [PR] [fix](catalog) opt the count pushdown rule for iceberg/paimon/hive scan node (#44038) [doris]
morningman merged PR #45224: URL: https://github.com/apache/doris/pull/45224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) cache the Configuration object [doris]
morningman commented on PR #45433: URL: https://github.com/apache/doris/pull/45433#issuecomment-2543444323 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](hms table)Some optimizations for hms external table [doris]
github-actions[bot] commented on PR #44909: URL: https://github.com/apache/doris/pull/44909#issuecomment-2543435424 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](hms table)Some optimizations for hms external table [doris]
github-actions[bot] commented on PR #44909: URL: https://github.com/apache/doris/pull/44909#issuecomment-2543435430 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [fix](s3) improve error msg #45360 [doris]
morningman commented on PR #45432: URL: https://github.com/apache/doris/pull/45432#issuecomment-2543435744 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [fix](s3) improve error msg #45360 [doris]
morningman closed pull request #45432: branch-2.1: [fix](s3) improve error msg #45360 URL: https://github.com/apache/doris/pull/45432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](s3) improve error msg #45360 [doris]
doris-robot commented on PR #45431: URL: https://github.com/apache/doris/pull/45431#issuecomment-2543436496 TPC-H: Total hot run time: 40247 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 774aa388c1210151317f1876ae08822d6b8c0fe2, data reload: false -- Round 1 -- q1 17572 731272257225 q2 2055165 157 157 q3 10717 108311561083 q4 10554 738 711 711 q5 7724278627352735 q6 232 145 143 143 q7 967 619 607 607 q8 9591189219571892 q9 7730637163276327 q10 6974230822952295 q11 464 260 255 255 q12 400 210 207 207 q13 17786 294329682943 q14 238 204 206 204 q15 554 521 525 521 q16 684 619 613 613 q17 962 524 581 524 q18 7191649865586498 q19 1862105410291029 q20 451 198 194 194 q21 4045313432423134 q22 1037950 969 950 Total cold run time: 109790 ms Total hot run time: 40247 ms - Round 2, with runtime_filter_mode=off - q1 7304720471687168 q2 325 232 232 232 q3 2863288928102810 q4 1993184317591759 q5 5680569756815681 q6 218 138 141 138 q7 2195177218001772 q8 3270355334793479 q9 8710889587738773 q10 3520348335283483 q11 598 510 499 499 q12 779 598 606 598 q13 16549 314931253125 q14 313 280 265 265 q15 565 519 513 513 q16 724 671 675 671 q17 1845162616141614 q18 8238773674887488 q19 2366158015221522 q20 2063185718181818 q21 5471533552555255 q22 1120101110071007 Total cold run time: 76709 ms Total hot run time: 59670 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 4e9012fd8e4 branch-3.0: [fix](hive) fix block decompressor bug #45289
(#45377)
4e9012fd8e4 is described below
commit 4e9012fd8e48f1ab080bac275afa22bd7d0b143f
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Sat Dec 14 20:56:50 2024 -0800
branch-3.0: [fix](hive) fix block decompressor bug #45289 (#45377)
Cherry-picked from #45289
Co-authored-by: Socrates
---
be/src/exec/decompressor.cpp | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/be/src/exec/decompressor.cpp b/be/src/exec/decompressor.cpp
index 9365bb00288..5da2e6acbb9 100644
--- a/be/src/exec/decompressor.cpp
+++ b/be/src/exec/decompressor.cpp
@@ -492,15 +492,15 @@ Status Lz4BlockDecompressor::decompress(uint8_t* input,
size_t input_len, size_t
auto* output_ptr = output;
while (input_len > 0) {
-//if faild , fall back to large block begin
-auto* large_block_input_ptr = input_ptr;
-auto* large_block_output_ptr = output_ptr;
-
if (input_len < sizeof(uint32_t)) {
-return Status::InvalidArgument(strings::Substitute(
-"fail to do hadoop-lz4 decompress, input_len=$0",
input_len));
+*more_input_bytes = sizeof(uint32_t) - input_len;
+break;
}
+//if faild, fall back to large block begin
+auto* large_block_input_ptr = input_ptr;
+auto* large_block_output_ptr = output_ptr;
+
uint32_t remaining_decompressed_large_block_len =
BigEndian::Load32(input_ptr);
input_ptr += sizeof(uint32_t);
@@ -609,15 +609,15 @@ Status SnappyBlockDecompressor::decompress(uint8_t*
input, size_t input_len,
auto* output_ptr = output;
while (input_len > 0) {
-//if faild , fall back to large block begin
-auto* large_block_input_ptr = input_ptr;
-auto* large_block_output_ptr = output_ptr;
-
if (input_len < sizeof(uint32_t)) {
-return Status::InvalidArgument(strings::Substitute(
-"fail to do hadoop-snappy decompress, input_len=$0",
input_len));
+*more_input_bytes = sizeof(uint32_t) - input_len;
+break;
}
+//if faild, fall back to large block begin
+auto* large_block_input_ptr = input_ptr;
+auto* large_block_output_ptr = output_ptr;
+
uint32_t remaining_decompressed_large_block_len =
BigEndian::Load32(input_ptr);
input_ptr += sizeof(uint32_t);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45289-branch-3.0 deleted (was 0f23d3ef78c)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45289-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git was 0f23d3ef78c [fix](hive) fix block decompressor bug (#45289) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](hive) fix block decompressor bug #45289 [doris]
morningman merged PR #45377: URL: https://github.com/apache/doris/pull/45377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
github-actions[bot] commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543517664 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
github-actions[bot] commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543517673 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (c3ccb98d93 -> d564a7299d)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard c3ccb98d93 Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 new d564a7299d Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (c3ccb98d93) \ N -- N -- N refs/heads/asf-site (d564a7299d) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/1.2/search-index.json | 2 +- docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/1.2/search-index.json | 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-2.1: [fix](s3) improve error msg #45360 [doris]
doris-robot commented on PR #45432: URL: https://github.com/apache/doris/pull/45432#issuecomment-2543443646 TeamCity be ut coverage result: Function Coverage: 36.48% (9569/26231) Line Coverage: 27.93% (78670/281651) Region Coverage: 26.60% (40386/151828) Branch Coverage: 23.35% (20455/87594) Coverage Report: http://coverage.selectdb-in.cc/coverage/7ff164ebc14c91c91ee20d6d0932ee6e2e869a8b_7ff164ebc14c91c91ee20d6d0932ee6e2e869a8b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) cache the Configuration object [doris]
Thearas commented on PR #45433: URL: https://github.com/apache/doris/pull/45433#issuecomment-2543438873 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](catalog) cache the Configuration object [doris]
morningman opened a new pull request, #45433: URL: https://github.com/apache/doris/pull/45433 ### What problem does this PR solve? Problem Summary: Creating Configuration object is very costy, so we cache it for better performance ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](catalog) cache the Configuration object [doris]
morningman commented on PR #45433: URL: https://github.com/apache/doris/pull/45433#issuecomment-2543438955 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-254305 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543068105 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](fe) Disable releases for Apache snapshots repo [doris]
Thearas commented on PR #45423: URL: https://github.com/apache/doris/pull/45423#issuecomment-2543078350 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](fe) Disable releases for Apache snapshots repo [doris]
adoroszlai opened a new pull request, #45423: URL: https://github.com/apache/doris/pull/45423 ### What problem does this PR solve? Problem Summary: while building `fe`, Maven looks for release artifacts in `snapshots` repo (and gets HTTP 404). Repro: ``` $ mvn -DskipTests clean package ... Downloading from snapshots: https://repository.apache.org/content/repositories/snapshots/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom Downloading from cloudera: https://repository.cloudera.com/repository/libs-release-local/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom Downloaded from central: https://repo.maven.apache.org/maven2/com/google/cloud/first-party-dependencies/3.19.0/first-party-dependencies-3.19.0.pom (3.2 kB at 269 kB/s) Downloading from snapshots: https://repository.apache.org/content/repositories/snapshots/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom Downloading from cloudera: https://repository.cloudera.com/repository/libs-release-local/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom Downloading from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom Downloaded from central: https://repo.maven.apache.org/maven2/com/google/cloud/google-cloud-shared-config/1.6.1/google-cloud-shared-config-1.6.1.pom (30 kB at 2.7 MB/s) ... ``` Repository list shows `snapshots` is configured for `releases+snapshots`: ``` $ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories ... [INFO] --- toolbox:0.6.0:list-repositories (default-cli) @ fe --- [INFO] Remote repositories used by project org.apache.doris:fe:pom:1.2-SNAPSHOT. [INFO] * central (https://repo.maven.apache.org/maven2/, default, releases) [INFO]First introduced on root [INFO] * snapshots (https://repository.apache.org/content/repositories/snapshots/, default, releases+snapshots) [INFO]First introduced on root [INFO] * cloudera (https://repository.cloudera.com/repository/libs-release-local/, default, releases+snapshots) [INFO]First introduced on root [INFO] * apache.snapshots (https://repository.apache.org/snapshots, default, snapshots) [INFO]First introduced on root [INFO] * sonatype-nexus-snapshots (https://oss.sonatype.org/content/repositories/snapshots, default, snapshots) [INFO]First introduced on org.awaitility:awaitility:jar:4.2.0 (compile) ``` Excerpt from same list with the fix: ``` $ mvn -N --batch-mode eu.maveniverse.maven.plugins:toolbox:list-repositories ... [INFO] * snapshots (https://repository.apache.org/content/repositories/snapshots/, default, snapshots) ... ``` ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [x] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup)(cooldown) backup/restore for cooldown data [doris]
justfortaste commented on PR #43642: URL: https://github.com/apache/doris/pull/43642#issuecomment-2543082691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup)(cooldown) backup/restore for cooldown data [doris]
github-actions[bot] commented on PR #43642: URL: https://github.com/apache/doris/pull/43642#issuecomment-2543084347 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
doris-robot commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543080162 TeamCity be ut coverage result: Function Coverage: 39.26% (10274/26172) Line Coverage: 29.83% (85287/285941) Region Coverage: 28.86% (43719/151503) Branch Coverage: 25.32% (22122/87380) Coverage Report: http://coverage.selectdb-in.cc/coverage/de8451ba13307a712d282850d246db34b34899fc_de8451ba13307a712d282850d246db34b34899fc/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
zhiqiang- commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543058302 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test][doc] add example how to recover data when insert overwrite and truncate cases [doris]
hello-stephen commented on PR #45424: URL: https://github.com/apache/doris/pull/45424#issuecomment-2543104065 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [test][doc] add example how to recover data when insert overwrite and truncate cases [doris]
Vallishp opened a new pull request, #45424: URL: https://github.com/apache/doris/pull/45424 … ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [X] Other reason Document for how to recover data when insert overwrite or truncate done - - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test][doc] add example how to recover data when insert overwrite and truncate cases [doris]
Vallishp commented on PR #45424: URL: https://github.com/apache/doris/pull/45424#issuecomment-2543104093 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Fixes [doris]
rijeshkp opened a new pull request, #45426: URL: https://github.com/apache/doris/pull/45426 ### What problem does this PR solve? Issue Number: close #42847 Related PR: #xxx Problem Summary: Support for Admin Check Partition Version Command in Nereids ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fixes [doris]
hello-stephen commented on PR #45426: URL: https://github.com/apache/doris/pull/45426#issuecomment-2543133593 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement adminSetPartitionVersionCommand in nereids [doris]
rijeshkp commented on PR #45426: URL: https://github.com/apache/doris/pull/45426#issuecomment-2543133986 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement adminSetPartitionVersionCommand in nereids [doris]
Vallishp commented on code in PR #45426:
URL: https://github.com/apache/doris/pull/45426#discussion_r1885083711
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetPartitionVersionCommand.java:
##
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.PropertyAnalyzer;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.TableNameInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.base.Strings;
+
+import java.util.Map;
+
+/**
+ * admin set partition version command
+ */
+public class AdminSetPartitionVersionCommand extends Command implements
ForwardNoSync {
+long partitionId = -1;
+long visibleVersion = -1;
+private final TableNameInfo tableName;
+private final Map properties;
+
+/**
+ * constructor
+ */
+public AdminSetPartitionVersionCommand(TableNameInfo tableName,
Map properties) {
+super(PlanType.ADMIN_SET_PARTITION_VERSION);
+this.tableName = tableName;
+this.properties = properties;
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+
+// check auth
+if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
+}
+
+Util.prohibitExternalCatalog(tableName.getCtl(),
this.getClass().getSimpleName());
+
+checkProperties();
+
+String database = tableName.getDb();
Review Comment:
you can use tableName.analyze(ctx) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (2cb406f6e0 -> 35f11369d0)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard 2cb406f6e0 Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 new 35f11369d0 Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (2cb406f6e0) \ N -- N -- N refs/heads/asf-site (35f11369d0) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/1.2/search-index.json | 2 +- docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/1.2/search-index.json | 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
koarz commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543048979 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
doris-robot commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543073878 TeamCity be ut coverage result: Function Coverage: 38.76% (10109/26082) Line Coverage: 29.70% (84881/285791) Region Coverage: 28.77% (43568/151459) Branch Coverage: 25.31% (22130/87424) Coverage Report: http://coverage.selectdb-in.cc/coverage/b4725ef42840021206b4d74a14b803b57e73f1f4_b4725ef42840021206b4d74a14b803b57e73f1f4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix]fix performence compile error [doris]
koarz opened a new pull request, #45425: URL: https://github.com/apache/doris/pull/45425 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
koarz commented on PR #45425: URL: https://github.com/apache/doris/pull/45425#issuecomment-2543109172 run performence -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
hello-stephen commented on PR #45425: URL: https://github.com/apache/doris/pull/45425#issuecomment-2543109110 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](backup)(cooldown) backup/restore for cooldown data [doris]
doris-robot commented on PR #43642: URL: https://github.com/apache/doris/pull/43642#issuecomment-2543111358 TeamCity be ut coverage result: Function Coverage: 38.74% (10107/26088) Line Coverage: 29.68% (84856/285888) Region Coverage: 28.75% (43555/151514) Branch Coverage: 25.30% (22128/87456) Coverage Report: http://coverage.selectdb-in.cc/coverage/328a6e5bab9045bfe4dbe511bf671477923c37f4_328a6e5bab9045bfe4dbe511bf671477923c37f4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
koarz commented on PR #45425: URL: https://github.com/apache/doris/pull/45425#issuecomment-2543111284 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
koarz commented on PR #45425: URL: https://github.com/apache/doris/pull/45425#issuecomment-2543113396 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]Remove be special handling of date types and bugs in registration functions [doris]
github-actions[bot] commented on PR #45159: URL: https://github.com/apache/doris/pull/45159#issuecomment-2543114981 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
doris-robot commented on PR #45425: URL: https://github.com/apache/doris/pull/45425#issuecomment-2543150709 TPC-H: Total hot run time: 38423 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8263bab45e474ef0a429e69808f0435083b83cf4, data reload: false -- Round 1 -- q1 17586 740772837283 q2 2052183 181 181 q3 10529 987 1108987 q4 10525 713 773 713 q5 7629253524512451 q6 235 149 149 149 q7 999 642 615 615 q8 9466170618191706 q9 7065639463536353 q10 6899217121782171 q11 463 259 256 256 q12 407 230 224 224 q13 17801 296729692967 q14 251 213 214 213 q15 577 540 514 514 q16 675 582 604 582 q17 919 530 543 530 q18 7033667465376537 q19 13351013992 992 q20 458 179 184 179 q21 3646271425152515 q22 350 313 305 305 Total cold run time: 106900 ms Total hot run time: 38423 ms - Round 2, with runtime_filter_mode=off - q1 7570748675467486 q2 311 230 237 230 q3 2723257525922575 q4 1843174317291729 q5 5435548557095485 q6 224 137 141 137 q7 2111178917561756 q8 3181336433493349 q9 8804852986788529 q10 3444338434043384 q11 573 522 500 500 q12 804 610 619 610 q13 9349308232133082 q14 299 272 281 272 q15 1052527 526 526 q16 684 688 665 665 q17 1766158215761576 q18 7984787276707670 q19 1683160715221522 q20 2024184218541842 q21 5181504249764976 q22 601 519 553 519 Total cold run time: 67646 ms Total hot run time: 58420 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Enhancement] (nereids)implement showStatusCommand in nereids [doris]
msridhar78 opened a new pull request, #45427: URL: https://github.com/apache/doris/pull/45427 ### What problem does this PR solve? Issue Number: close #42730 Related PR: #xxx Problem Summary: [Enhancement] (nereids)implement showStatusCommand in nereids ### Release note None ### Check List (For Author) - Test - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix performence compile error [doris]
koarz closed pull request #45425: [fix]fix performence compile error URL: https://github.com/apache/doris/pull/45425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Exec](expr) Opt the compound pred performace [doris]
HappenLee commented on code in PR #45414:
URL: https://github.com/apache/doris/pull/45414#discussion_r1885099968
##
be/src/vec/exprs/vcompound_pred.h:
##
@@ -158,12 +158,15 @@ class VCompoundPred : public VectorizedFnCall {
if (_can_fast_execute && fast_execute(context, block,
result_column_id)) {
return Status::OK();
}
-if (get_num_children() == 1 ||
!_all_child_is_compound_and_not_const()) {
+if (get_num_children() == 1 || !_all_child_is_not_const()) {
Review Comment:
`not` predicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showStatusCommand in nereids [doris]
hello-stephen commented on PR #45427: URL: https://github.com/apache/doris/pull/45427#issuecomment-2543163657 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Exec](expr) Opt the compound pred performace [doris]
HappenLee commented on PR #45414: URL: https://github.com/apache/doris/pull/45414#issuecomment-2543166510 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] (nereids)implement showCatalogsCommand in nereids [doris]
msridhar78 commented on issue #42744: URL: https://github.com/apache/doris/issues/42744#issuecomment-2543166570 Pls ignore - I think other PR already implements this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix-3.0](smooth-upgrade) Fix smooth upgrade of function is_ip_address_in_range [doris]
zclllyybb opened a new pull request, #45428: URL: https://github.com/apache/doris/pull/45428 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: The origin PR is https://github.com/apache/doris/pull/35239. for branch-3.0 it was merged in 3.0.0 but forgot to register old version. now in branch-3.0 we fix it in this PR. and will pick it to branch-2.0 in https://github.com/apache/doris/pull/45358 which must be merged in 2.1.8. then: ``` FROMTOresult 217-218+✅ 217-303-💥 218+303-✅ 218+304+✅ 303-304+✅ ``` this is our best result. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [x] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [x] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix-3.0](smooth-upgrade) Fix smooth upgrade of function is_ip_address_in_range [doris]
Thearas commented on PR #45428: URL: https://github.com/apache/doris/pull/45428#issuecomment-2543175135 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Exec](expr) Opt the compound pred performace [doris]
HappenLee commented on PR #45414: URL: https://github.com/apache/doris/pull/45414#issuecomment-2543177069 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore]((upgrade) Add comment hints to guide to use new upgrade compatible method [doris]
github-actions[bot] commented on code in PR #45429: URL: https://github.com/apache/doris/pull/45429#discussion_r1885118473 ## be/src/agent/be_exec_version_manager.h: ## @@ -18,9 +18,9 @@ #pragma once #include Review Comment: warning: 'fmt/format.h' file not found [clang-diagnostic-error] ```cpp #include ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test][doc] add example how to recover data when insert overwrite and truncate cases [doris]
zclllyybb commented on code in PR #45424:
URL: https://github.com/apache/doris/pull/45424#discussion_r1885116122
##
regression-test/suites/doc/admin-manual/data-admin/recover_more_cases.md.groovy:
##
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+import org.junit.jupiter.api.Assertions;
+
+suite("docs/admin-manual/data-admin/recover_more_cases.md",
"p0,nonConcurrent") {
Review Comment:
why this case is need to be nonConcurrent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore]((upgrade) Add comment hints to guide to use new upgrade compatible method [doris]
zclllyybb opened a new pull request, #45429: URL: https://github.com/apache/doris/pull/45429 ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore]((upgrade) Add comment hints to guide to use new upgrade compatible method [doris]
zclllyybb commented on PR #45429: URL: https://github.com/apache/doris/pull/45429#issuecomment-2543179606 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]
doris-robot commented on PR #45358: URL: https://github.com/apache/doris/pull/45358#issuecomment-2543188168 TeamCity be ut coverage result: Function Coverage: 36.47% (9569/26237) Line Coverage: 27.93% (78653/281598) Region Coverage: 26.60% (40370/151761) Branch Coverage: 23.36% (20446/87542) Coverage Report: http://coverage.selectdb-in.cc/coverage/f9cfe7b03e20e8a65b57dcead24065350047379d_f9cfe7b03e20e8a65b57dcead24065350047379d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.1](functions) clean some ip functions code and make IS_IP_ADDRESS_IN_RANGE DEPENDS_ON_ARGUMENT [doris]
zclllyybb commented on PR #45358: URL: https://github.com/apache/doris/pull/45358#issuecomment-2543176574 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix-3.0](smooth-upgrade) Fix smooth upgrade of function is_ip_address_in_range [doris]
zclllyybb commented on PR #45428: URL: https://github.com/apache/doris/pull/45428#issuecomment-2543176550 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore]((upgrade) Add comment hints to guide to use new upgrade compatible method [doris]
Thearas commented on PR #45429: URL: https://github.com/apache/doris/pull/45429#issuecomment-2543179584 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Exec](expr) Opt the compound pred performace [doris]
doris-robot commented on PR #45414: URL: https://github.com/apache/doris/pull/45414#issuecomment-2543191600 TeamCity be ut coverage result: Function Coverage: 38.75% (10108/26083) Line Coverage: 29.70% (84889/285845) Region Coverage: 28.76% (43569/151469) Branch Coverage: 25.32% (22139/87426) Coverage Report: http://coverage.selectdb-in.cc/coverage/0ce7a6978d5992888b562fb2836e1daac815631a_0ce7a6978d5992888b562fb2836e1daac815631a/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement adminSetPartitionVersionCommand in nereids [doris]
rijeshkp commented on code in PR #45426:
URL: https://github.com/apache/doris/pull/45426#discussion_r1885129072
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminSetPartitionVersionCommand.java:
##
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.catalog.Env;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.util.PropertyAnalyzer;
+import org.apache.doris.common.util.Util;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.TableNameInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import com.google.common.base.Strings;
+
+import java.util.Map;
+
+/**
+ * admin set partition version command
+ */
+public class AdminSetPartitionVersionCommand extends Command implements
ForwardNoSync {
+long partitionId = -1;
+long visibleVersion = -1;
+private final TableNameInfo tableName;
+private final Map properties;
+
+/**
+ * constructor
+ */
+public AdminSetPartitionVersionCommand(TableNameInfo tableName,
Map properties) {
+super(PlanType.ADMIN_SET_PARTITION_VERSION);
+this.tableName = tableName;
+this.properties = properties;
+}
+
+@Override
+public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
+
+// check auth
+if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
+
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
+}
+
+Util.prohibitExternalCatalog(tableName.getCtl(),
this.getClass().getSimpleName());
+
+checkProperties();
+
+String database = tableName.getDb();
Review Comment:
Thanks. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch asf-site updated (35f11369d0 -> c3ccb98d93)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/doris-website.git discard 35f11369d0 Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 new c3ccb98d93 Automated deployment with doris branch @ fcb4a82eb4f09783e0c80380d9ff02ccd2e7d707 This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (35f11369d0) \ N -- N -- N refs/heads/asf-site (c3ccb98d93) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/1.2/search-index.json | 2 +- docs/2.0/search-index.json | 2 +- docs/3.0/search-index.json | 2 +- docs/dev/search-index.json | 2 +- search-index.json| 2 +- zh-CN/docs/1.2/search-index.json | 2 +- zh-CN/docs/2.0/search-index.json | 2 +- zh-CN/docs/3.0/search-index.json | 2 +- zh-CN/docs/dev/search-index.json | 2 +- zh-CN/search-index.json | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showDatabasesCommand in nereids [doris]
Thearas commented on PR #45421: URL: https://github.com/apache/doris/pull/45421#issuecomment-2542997330 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] (nereids)implement showDatabasesCommand in nereids [doris]
msridhar78 commented on PR #45421: URL: https://github.com/apache/doris/pull/45421#issuecomment-2542997468 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Enhancement] (nereids)implement showDatabasesCommand in nereids [doris]
msridhar78 opened a new pull request, #45421: URL: https://github.com/apache/doris/pull/45421 ### What problem does this PR solve? Issue Number: close #42741 Related PR: #xxx Problem Summary: [Enhancement] (nereids)implement showDatabasesCommand in nereids ### Release note None ### Check List (For Author) - Test - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
hello-stephen commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543036360 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt] Optimization for short circuit of CompoundPred [doris]
zhiqiang- opened a new pull request, #45422: URL: https://github.com/apache/doris/pull/45422 ### What problem does this PR solve? Related PR: https://github.com/apache/doris/pull/45414 Problem Summary: https://github.com/apache/doris/pull/45414 optimized short circuit of CompoundPred. But for some cases, it will introduce perf recession since AND/OR process of CompoundPred is not as efficient as Function AND/OR. Previous ```sql mysqlslap -hd3 -uroot -P9130 --create-schema=test_db -c 10 -i 100 -q "SELECT count(k) FROM sbtest1 WHERE k BETWEEN 10809931 AND 16922183 OR k BETWEEN 17788920 AND 27291942 OR k BETWEEN 23293962 AND 24940261 OR k BETWEEN 28108000 AND 28870202 OR k BETWEEN 23014347 AND 26008115 OR k BETWEEN 17817024 AND 29749077 OR k BETWEEN 8776291 AND 19869309 OR k BETWEEN 12846851 AND 15917660 OR k BETWEEN 21899521 AND 25614482 OR k BETWEEN 4850578 AND 8454295;" Benchmark Average number of seconds to run all queries: 0.315 seconds Minimum number of seconds to run all queries: 0.307 seconds Maximum number of seconds to run all queries: 0.328 seconds Number of clients running queries: 10 Average number of queries per client: 1 ``` Now ```sql mysqlslap -hd3 -uroot -P9130 --create-schema=test_db -c 10 -i 100 -q "SELECT count(k) FROM sbtest1 WHERE k BETWEEN 10809931 AND 16922183 OR k BETWEEN 17788920 AND 27291942 OR k BETWEEN 23293962 AND 24940261 OR k BETWEEN 28108000 AND 28870202 OR k BETWEEN 23014347 AND 26008115 OR k BETWEEN 17817024 AND 29749077 OR k BETWEEN 8776291 AND 19869309 OR k BETWEEN 12846851 AND 15917660 OR k BETWEEN 21899521 AND 25614482 OR k BETWEEN 4850578 AND 8454295;" Benchmark Average number of seconds to run all queries: 0.222 seconds Minimum number of seconds to run all queries: 0.215 seconds Maximum number of seconds to run all queries: 0.263 seconds Number of clients running queries: 10 Average number of queries per client: 1 ``` BTW, the performance recession only occurs when compound predicate can be short circuited in most cases. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [ ] No. - [ ] Yes. - Does this need documentation? - [ ] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt] Optimization for short circuit of CompoundPred [doris]
github-actions[bot] commented on PR #45422: URL: https://github.com/apache/doris/pull/45422#issuecomment-2543038227 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] Issue on docs [doris-website]
isiuni01 opened a new issue, #1520: URL: https://github.com/apache/doris-website/issues/1520 Path:/docs/3.0/install/cluster-deployment/run-docker-cluster Hi, I am new to Doris and docker. I am trying to install it locally with docker. I wanted to report that the base image present in the proposed DockerFile **(openjdk:8u342-jdk)** is not compatible with Doris 3.0 in the moment I try to build the service **(docker compose up)** i get: `The jdk_version is 8, must be 17.` I tried several other options without finding a good one. Do you have any suggestions for a working one? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix localtime etc. show wrong title [doris]
github-actions[bot] commented on PR #36333: URL: https://github.com/apache/doris/pull/36333#issuecomment-2543384971 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](query) optimize the scan key range generation for query [doris]
github-actions[bot] closed pull request #36322: [improvement](query) optimize the scan key range generation for query URL: https://github.com/apache/doris/pull/36322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](ddl) Support CREATE DB with COMMENT [doris]
github-actions[bot] commented on PR #34625: URL: https://github.com/apache/doris/pull/34625#issuecomment-2543385004 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](agg) support second key [doris]
github-actions[bot] commented on PR #36352: URL: https://github.com/apache/doris/pull/36352#issuecomment-2543384965 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive) support hive3 timestamp with local time zone [doris]
github-actions[bot] commented on PR #35664: URL: https://github.com/apache/doris/pull/35664#issuecomment-2543384994 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](doc) update array-intersect [doris]
github-actions[bot] closed pull request #31459: [fix](doc) update array-intersect URL: https://github.com/apache/doris/pull/31459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tvf) Tvf supports to parse the enclose character in csv files [doris]
github-actions[bot] commented on PR #45407: URL: https://github.com/apache/doris/pull/45407#issuecomment-2543421334 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tvf) Tvf supports to parse the enclose character in csv files [doris]
github-actions[bot] commented on PR #45407: URL: https://github.com/apache/doris/pull/45407#issuecomment-2543421341 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tvf) Tvf supports to parse the enclose character in csv files [doris]
morningman commented on PR #45407: URL: https://github.com/apache/doris/pull/45407#issuecomment-2543421389 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](Export) Cancel the export job when the ring buffer have no enough slot (#45244)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 12dcb17eedb [fix](Export) Cancel the export job when the ring buffer
have no enough slot (#45244)
12dcb17eedb is described below
commit 12dcb17eedbca64e854a067d20fd04c0218eb152
Author: Tiewei Fang
AuthorDate: Sun Dec 15 10:48:42 2024 +0800
[fix](Export) Cancel the export job when the ring buffer have no enough
slot (#45244)
Problem Summary:
If there happen exceptions in `addMemoryTask`, we must update the state
of the export job to `CANCELLED` because we have added this export job
in `ExportMgr`.
---
.../src/main/java/org/apache/doris/load/ExportMgr.java | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
b/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
index 94ae436ee6d..ed6ee29bb9c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java
@@ -122,8 +122,16 @@ public class ExportMgr {
job.getBrokerDesc());
}
// ATTN: Must add task after edit log, otherwise the job may finish
before adding job.
-for (int i = 0; i < job.getCopiedTaskExecutors().size(); i++) {
-
Env.getCurrentEnv().getTransientTaskManager().addMemoryTask(job.getCopiedTaskExecutors().get(i));
+try {
+for (int i = 0; i < job.getCopiedTaskExecutors().size(); i++) {
+
Env.getCurrentEnv().getTransientTaskManager().addMemoryTask(job.getCopiedTaskExecutors().get(i));
+}
+} catch (Exception e) {
+// If there happens exceptions in `addMemoryTask`
+// we must update the state of export job to `CANCELLED`
+// because we have added this export in `ExportMgr`
+job.updateExportJobState(ExportJobState.CANCELLED, 0L, null,
+ExportFailMsg.CancelType.RUN_FAIL, e.getMessage());
}
LOG.info("add export job. {}", job);
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Export) Cancel the export job when the ring buffer have no enough slot [doris]
morningman merged PR #45244: URL: https://github.com/apache/doris/pull/45244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](tvf) Tvf supports to parse the enclose character in csv files [doris]
github-actions[bot] commented on PR #45407: URL: https://github.com/apache/doris/pull/45407#issuecomment-2543422128 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45244-branch-3.0 created (now 9edea93a8b2)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45244-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 9edea93a8b2 branch-3.0: [Chore](dependencies)Upgrade Fe dependencies #44872 (#45354) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](Export) Cancel the export job when the ring buffer have no enough slot #45244 [doris]
dataroaring closed pull request #45430: branch-3.0: [fix](Export) Cancel the export job when the ring buffer have no enough slot #45244 URL: https://github.com/apache/doris/pull/45430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45244-branch-3.0 updated (9edea93a8b2 -> f7647ad1db6)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45244-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git from 9edea93a8b2 branch-3.0: [Chore](dependencies)Upgrade Fe dependencies #44872 (#45354) add f7647ad1db6 [fix](Export) Cancel the export job when the ring buffer have no enough slot (#45244) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/doris/load/ExportMgr.java | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] branch-3.0: [fix](Export) Cancel the export job when the ring buffer have no enough slot #45244 [doris]
github-actions[bot] opened a new pull request, #45430: URL: https://github.com/apache/doris/pull/45430 Cherry-picked from #45244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](Export) Cancel the export job when the ring buffer have no enough slot #45244 [doris]
hello-stephen commented on PR #45430: URL: https://github.com/apache/doris/pull/45430#issuecomment-2543422318 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) opt the count pushdown rule for iceberg/paimon/hive scan node (#44038) [doris]
morningman commented on PR #45224: URL: https://github.com/apache/doris/pull/45224#issuecomment-2543420478 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] branch-3.0: [fix](Export) Cancel the export job when the ring buffer have no enough slot #45244 [doris]
hello-stephen commented on PR #45430: URL: https://github.com/apache/doris/pull/45430#issuecomment-2543422302 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR). Please clearly describe your PR: 1. What problem was fixed (it's best to include specific error reporting information). How it was fixed. 2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be. 3. What features were added. Why was this function added? 4. Which code was refactored and why was this part of the code refactored? 5. Which functions were optimized and what is the difference before and after the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg) Fill in the detailed error information [doris]
github-actions[bot] commented on PR #45415: URL: https://github.com/apache/doris/pull/45415#issuecomment-2543423188 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](iceberg) Fill in the detailed error information [doris]
github-actions[bot] commented on PR #45415: URL: https://github.com/apache/doris/pull/45415#issuecomment-2543423195 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [Fix](hudi) Fix some errors caused by resolving code conflicts (#45355)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 39f47311a0f [Fix](hudi) Fix some errors caused by resolving code
conflicts (#45355)
39f47311a0f is described below
commit 39f47311a0fca08b35f2ce640c1b63adff9a7957
Author: Socrates
AuthorDate: Sun Dec 15 11:04:11 2024 +0800
[Fix](hudi) Fix some errors caused by resolving code conflicts (#45355)
### What problem does this PR solve?
Problem Summary:
Fix some errors caused by resolving code conflicts
---
.../java/org/apache/doris/datasource/hudi/source/HudiScanNode.java| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java
index e1dfaa40aef..486fdea74a0 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java
@@ -125,8 +125,8 @@ public class HudiScanNode extends HiveScanNode {
*/
public HudiScanNode(PlanNodeId id, TupleDescriptor desc, boolean
needCheckColumnPriv,
Optional scanParams,
Optional incrementalRelation,
-SessionVariable sv) {
-super(id, desc, "HUDI_SCAN_NODE", StatisticalType.HUDI_SCAN_NODE,
needCheckColumnPriv, sv);
+SessionVariable sessionVariable) {
+super(id, desc, "HUDI_SCAN_NODE", StatisticalType.HUDI_SCAN_NODE,
needCheckColumnPriv, sessionVariable);
isCowTable = hmsTable.isHoodieCowTable();
if (LOG.isDebugEnabled()) {
if (isCowTable) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](hudi) Fix some errors caused by resolving code conflicts [doris]
morningman merged PR #45355: URL: https://github.com/apache/doris/pull/45355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45355-branch-3.0 created (now 9edea93a8b2)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45355-branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git at 9edea93a8b2 branch-3.0: [Chore](dependencies)Upgrade Fe dependencies #44872 (#45354) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](external)fix split and get the schema [doris]
github-actions[bot] commented on PR #45408: URL: https://github.com/apache/doris/pull/45408#issuecomment-2543423937 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch auto-pick-45355-branch-2.1 created (now 6dabdd6a8ce)
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch auto-pick-45355-branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git at 6dabdd6a8ce branch-2.1: [fix](txn insert) txn insert show error url #45254 (#45381) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated (6dabdd6a8ce -> 249ffa44c05)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 6dabdd6a8ce branch-2.1: [fix](txn insert) txn insert show error url #45254 (#45381) add 249ffa44c05 branch-2.1 [Chore](dependencies)Upgrade Fe dependencies #44872 (#45362) No new revisions were added by this update. Summary of changes: fe/pom.xml | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
