Re: [PR] [Opt](flexible partial update) let `SegmentWriter` do not support flexible partial update [doris]
doris-robot commented on PR #41950: URL: https://github.com/apache/doris/pull/41950#issuecomment-2415988580 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile)open compile check in some file [doris]
Mryange commented on PR #41940: URL: https://github.com/apache/doris/pull/41940#issuecomment-2415994191 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)modify agg function nullability in PhysicalHashAggregate [doris]
doris-robot commented on PR #41943: URL: https://github.com/apache/doris/pull/41943#issuecomment-2415994387 ClickBench: Total hot run time: 32.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 9282bafb87df28dd40e2dce256768e6aeebd32b1, data reload: false query1 0.040.030.03 query2 0.060.030.03 query3 0.230.060.07 query4 1.650.100.10 query5 0.510.520.49 query6 1.120.720.73 query7 0.020.010.01 query8 0.040.050.03 query9 0.560.490.55 query10 0.560.560.54 query11 0.140.110.11 query12 0.140.110.10 query13 0.600.600.59 query14 2.722.722.71 query15 0.900.820.84 query16 0.380.360.38 query17 1.051.061.01 query18 0.200.200.20 query19 1.921.821.93 query20 0.020.010.00 query21 15.36 0.570.57 query22 2.342.411.68 query23 16.88 1.030.69 query24 2.971.800.66 query25 0.300.200.09 query26 0.340.130.12 query27 0.040.040.04 query28 10.46 1.101.07 query29 12.54 3.233.24 query30 0.240.060.06 query31 2.870.380.38 query32 3.290.460.45 query33 3.023.053.05 query34 16.89 4.484.42 query35 4.514.524.53 query36 0.680.490.48 query37 0.090.060.06 query38 0.050.030.04 query39 0.030.020.02 query40 0.160.130.12 query41 0.080.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 106.06 s Total hot run time: 32.03 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] [doris]
Mryange closed pull request #41426: [only test] URL: https://github.com/apache/doris/pull/41426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
github-actions[bot] commented on PR #41949: URL: https://github.com/apache/doris/pull/41949#issuecomment-2416000967 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Opt](flexible partial update) let `SegmentWriter` do not support flexible partial update [doris]
bobhan1 opened a new pull request, #41950: URL: https://github.com/apache/doris/pull/41950 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](flexible partial update) let `SegmentWriter` do not support flexible partial update [doris]
bobhan1 commented on PR #41950: URL: https://github.com/apache/doris/pull/41950#issuecomment-2415988623 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
Gabriel39 commented on PR #41949: URL: https://github.com/apache/doris/pull/41949#issuecomment-2415986533 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function)fix date_floor function return wrong result [doris]
github-actions[bot] commented on PR #41948: URL: https://github.com/apache/doris/pull/41948#issuecomment-2415992074 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](flexible partial update) let `SegmentWriter` do not support flexible partial update [doris]
github-actions[bot] commented on PR #41950: URL: https://github.com/apache/doris/pull/41950#issuecomment-2415997983 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) Fix load failed where not set database in session [doris]
zxealous commented on PR #41951: URL: https://github.com/apache/doris/pull/41951#issuecomment-2416008130 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) Fix load failed where not set database in session [doris]
doris-robot commented on PR #41951: URL: https://github.com/apache/doris/pull/41951#issuecomment-2416006833 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids) Fix load failed where not set database in session [doris]
zxealous opened a new pull request, #41951: URL: https://github.com/apache/doris/pull/41951 ## Proposed changes Issue Number: close #xxx load failed where not set database in session LOAD LABEL test_db.label_11 ( DATA INFILE("hdfs://hdfs01:9000/user/") INTO TABLE `test_load_tb`) WITH BROKER "broker" ( "username" = "user", "password" = ""); ERROR 1105 (HY000): errCode = 2, detailMessage = Current database is not set. use label's database if not set database in session -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [test](inverted index) TopN Optimization Test for Composite Key. [doris]
zzzxl1993 opened a new pull request, #41952: URL: https://github.com/apache/doris/pull/41952 ## Proposed changes 1. Prevent incorrect use of composite keys in TopN optimization, which could lead to performance degradation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](inverted index) TopN Optimization Test for Composite Key. [doris]
doris-robot commented on PR #41952: URL: https://github.com/apache/doris/pull/41952#issuecomment-2416010441 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](inverted index) TopN Optimization Test for Composite Key. [doris]
zzzxl1993 commented on PR #41952: URL: https://github.com/apache/doris/pull/41952#issuecomment-2416010650 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](External Catalog) Remove unnecessary conjuncts handling in External Catalog [doris]
zy-kkk commented on PR #41218: URL: https://github.com/apache/doris/pull/41218#issuecomment-2416011314 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) fix filtered database when use_meta_cache=true [doris]
zy-kkk commented on PR #41939: URL: https://github.com/apache/doris/pull/41939#issuecomment-2416015958 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile)open compile check in some file [doris]
github-actions[bot] commented on PR #41940: URL: https://github.com/apache/doris/pull/41940#issuecomment-2416014181 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416043289 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [refine](exchange) refine exchange sink/ buffer code [doris]
Mryange opened a new pull request, #41955: URL: https://github.com/apache/doris/pull/41955 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
Mryange commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416043371 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids)support set command [doris]
starocean999 commented on PR #41913: URL: https://github.com/apache/doris/pull/41913#issuecomment-2416452032 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) Fix load failed where not set database in session [doris]
zxealous commented on PR #41951: URL: https://github.com/apache/doris/pull/41951#issuecomment-2416454027 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416460614 TPC-DS: Total hot run time: 191802 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 57c6a33b9c9443482165171e92a548892b3e4d8f, data reload: false query1 962 378 374 374 query2 6540206920492049 query3 6786209 218 209 query4 34266 23588 23579 23579 query5 4317470 471 470 query6 257 163 171 163 query7 4606301 300 300 query8 298 235 225 225 query9 9631270327022702 query10 461 270 266 266 query11 18114 15345 15311 15311 query12 149 106 98 98 query13 1659450 424 424 query14 10486 749974587458 query15 265 171 182 171 query16 7948457 485 457 query17 1659566 559 559 query18 2125300 309 300 query19 373 158 149 149 query20 117 108 107 107 query21 217 108 110 108 query22 4545420841954195 query23 35086 34028 33856 33856 query24 11158 278427692769 query25 676 410 421 410 query26 1314168 161 161 query27 2820289 292 289 query28 7974243524172417 query29 915 435 430 430 query30 318 157 160 157 query31 1037793 816 793 query32 103 57 61 57 query33 790 299 301 299 query34 967 528 554 528 query35 875 751 751 751 query36 1092957 963 957 query37 160 92 92 92 query38 4099397039253925 query39 1492143114071407 query40 296 105 104 104 query41 49 45 46 45 query42 119 101 97 97 query43 548 493 470 470 query44 1202807 801 801 query45 195 166 173 166 query46 1153683 713 683 query47 1921179418101794 query48 428 335 331 331 query49 1165447 434 434 query50 799 381 393 381 query51 7055695670156956 query52 99 91 87 87 query53 257 185 183 183 query54 1320444 437 437 query55 80 80 78 78 query56 284 270 263 263 query57 1350117011601160 query58 259 260 264 260 query59 3148301230463012 query60 289 289 278 278 query61 135 129 98 98 query62 877 661 653 653 query63 222 187 184 184 query64 5354645 602 602 query65 3277326331863186 query66 1441309 314 309 query67 15922 15667 15696 15667 query68 4421591 552 552 query69 424 288 283 283 query70 1191109311291093 query71 338 280 275 275 query72 6323393140213931 query73 792 358 363 358 query74 10229 903889888988 query75 3415262427012624 query76 2700976 870 870 query77 426 303 300 300 query78 10626 964896229622 query79 2439605 622 605 query80 1733455 453 453 query81 579 242 238 238 query82 876 140 137 137 query83 259 139 147 139 query84 272 70 67 67 query85 1511303 274 274 query86 469 300 308 300 query87 4480430342484248 query88 3746224022232223 query89 408 287 296 287 query90 2069185 185 185 query91 138 98 98 98 query92 73 48 48 48 query93 1633544 535 535 query94 1142289 280 280 query95 349 239 241 239 query96 619 287 291 287 query97 3274312030843084 query98 229 201 190 190 query99 1768129813041298 Total cold run time: 304852 ms Total hot run time: 191802 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416471895 ClickBench: Total hot run time: 33.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 57c6a33b9c9443482165171e92a548892b3e4d8f, data reload: false query1 0.030.040.04 query2 0.070.020.03 query3 0.230.060.06 query4 1.640.100.10 query5 0.490.500.51 query6 1.140.720.73 query7 0.020.020.01 query8 0.040.030.04 query9 0.570.500.51 query10 0.550.560.55 query11 0.140.110.10 query12 0.130.130.11 query13 0.600.590.59 query14 2.832.712.79 query15 0.890.830.82 query16 0.390.370.38 query17 1.051.001.05 query18 0.230.220.21 query19 1.951.882.07 query20 0.010.010.01 query21 15.38 0.560.58 query22 2.442.412.70 query23 16.91 1.190.81 query24 2.591.021.52 query25 0.180.090.14 query26 0.530.140.13 query27 0.040.040.04 query28 10.53 1.091.08 query29 12.52 3.243.22 query30 0.260.060.07 query31 2.870.390.37 query32 3.280.450.46 query33 3.003.013.03 query34 16.93 4.434.51 query35 4.484.524.46 query36 0.690.510.48 query37 0.080.060.06 query38 0.050.040.04 query39 0.030.020.02 query40 0.160.130.14 query41 0.070.020.02 query42 0.030.020.02 query43 0.030.030.03 Total cold run time: 106.08 s Total hot run time: 33.27 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) Fix load failed where not set database in session [doris]
zxealous commented on PR #41951: URL: https://github.com/apache/doris/pull/41951#issuecomment-2416460243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) cloud mode support txn load for mow tables [doris]
mymeiyi commented on PR #41932: URL: https://github.com/apache/doris/pull/41932#issuecomment-2416476064 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](functions) impl scalar functions trim_in、ltrim_in and rtrim_in [doris]
zhiqiang- commented on PR #41681: URL: https://github.com/apache/doris/pull/41681#issuecomment-2416480616 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](Variant) forbid variant type as hash join key (#41673) [doris]
morrySnow commented on PR #41974: URL: https://github.com/apache/doris/pull/41974#issuecomment-2416487820 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](Variant) forbid variant type as hash join key (#41673) [doris]
morrySnow opened a new pull request, #41974: URL: https://github.com/apache/doris/pull/41974 pick from master #41673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](Variant) forbid variant type as hash join key (#41673) [doris]
doris-robot commented on PR #41974: URL: https://github.com/apache/doris/pull/41974#issuecomment-2416487744 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894)
This is an automated email from the ASF dual-hosted git repository. lijibing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new c9886c5c4c6 [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894) c9886c5c4c6 is described below commit c9886c5c4c607cd45c9df2a83e48be9f288b8112 Author: Jibing-Li <64681310+jibing...@users.noreply.github.com> AuthorDate: Wed Oct 16 19:11:34 2024 +0800 [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894) Use min row count of all replicas with same version as tablet/table row count. Because replica with the least row count means it perform more compaction operation than the others. Use it as tablet row count is more accurate. Meanwhile, use min row count as tablet row count while choosing tablets during sample analyze. --- .../main/java/org/apache/doris/catalog/Tablet.java | 17 ++ .../org/apache/doris/catalog/TabletStatMgr.java| 11 +-- .../apache/doris/statistics/OlapAnalysisTask.java | 5 +-- .../java/org/apache/doris/catalog/TabletTest.java | 36 ++ 4 files changed, 65 insertions(+), 4 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java index 9fb44f07126..2dfdab1ad3d 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java @@ -528,6 +528,23 @@ public class Tablet extends MetaObject { return singleReplica ? Double.valueOf(s.average().orElse(0)).longValue() : s.sum(); } +// Get the least row count among all valid replicas. +// The replica with the least row count is the most accurate one. Because it performs most compaction. +public long getMinReplicaRowCount(long version) { +long minRowCount = Long.MAX_VALUE; +long maxReplicaVersion = 0; +for (Replica r : replicas) { +if (r.isAlive() +&& r.checkVersionCatchUp(version, false) +&& (r.getVersion() > maxReplicaVersion +|| r.getVersion() == maxReplicaVersion && r.getRowCount() < minRowCount)) { +minRowCount = r.getRowCount(); +maxReplicaVersion = r.getVersion(); +} +} +return minRowCount == Long.MAX_VALUE ? 0 : minRowCount; +} + /** * A replica is healthy only if * 1. the backend is available diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java b/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java index 18e1bfd6526..aa46c362e38 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/TabletStatMgr.java @@ -134,15 +134,18 @@ public class TabletStatMgr extends MasterDaemon { Long tabletDataSize = 0L; Long tabletRemoteDataSize = 0L; -Long tabletRowCount = 0L; +Long tabletRowCount = Long.MAX_VALUE; boolean tabletReported = false; for (Replica replica : tablet.getReplicas()) { LOG.debug("Table {} replica {} current version {}, report version {}", olapTable.getName(), replica.getId(), replica.getVersion(), replica.getLastReportVersion()); +// Replica with less row count is more accurate than the others +// when replicas' version are identical. Because less row count +// means this replica does more compaction than the others. if (replica.checkVersionCatchUp(version, false) -&& replica.getRowCount() >= tabletRowCount) { +&& replica.getRowCount() < tabletRowCount) { // 1. If replica version and reported replica version are all equal to // PARTITION_INIT_VERSION, set tabletReported to true, which indicates this // tablet is empty for sure when previous report. @@ -173,6 +176,10 @@ public class TabletStatMgr extends MasterDaemon { tableDataSize += tabletDataSize; tableRemoteDataSize += tabletRemoteDataSize; +// When all BEs are down, avoid set Long.MAX_VALUE to index
Re: [PR] [improvement](statistics)Use min row count of all replicas as tablet/table row count. [doris]
Jibing-Li merged PR #41894: URL: https://github.com/apache/doris/pull/41894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](Nereids) use 1 as narrowest column when do column pruning on union (#41719) [doris]
morrySnow opened a new pull request, #41975: URL: https://github.com/apache/doris/pull/41975 pick from master #41719 just like previous PR #41548 this PR process union node to ensure not require any column from its children when it is required by its parent with empty slot set -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) use 1 as narrowest column when do column pruning on union (#41719) [doris]
doris-robot commented on PR #41975: URL: https://github.com/apache/doris/pull/41975#issuecomment-2416498498 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) use 1 as narrowest column when do column pruning on union (#41719) [doris]
morrySnow commented on PR #41975: URL: https://github.com/apache/doris/pull/41975#issuecomment-2416499881 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](planner) change decimal literal toSql as plainString (#41809) [doris]
doris-robot commented on PR #41976: URL: https://github.com/apache/doris/pull/41976#issuecomment-2416503628 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [chore](planner) change decimal literal toSql as plainString (#41809) [doris]
morrySnow opened a new pull request, #41976: URL: https://github.com/apache/doris/pull/41976 pick from master #41809 for example, 0 with decimal(38,4) will return 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](planner) change decimal literal toSql as plainString (#41809) [doris]
morrySnow commented on PR #41976: URL: https://github.com/apache/doris/pull/41976#issuecomment-2416503787 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Fix date floor [doris]
zhangstar333 opened a new pull request, #41948: URL: https://github.com/apache/doris/pull/41948 ## Proposed changes ``` void resize_fill(size_t n, const T& value) { size_t old_size = this->size(); if (n > old_size) { this->reserve(n); std::fill(t_end(), t_end() + n - old_size, value); } this->c_end = this->c_start + this->byte_size(n); } ``` if n is not greater than old_size, it's will not fill the data with value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fix date floor [doris]
doris-robot commented on PR #41948: URL: https://github.com/apache/doris/pull/41948#issuecomment-2415982175 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)modify agg function nullability in PhysicalHashAggregate [doris]
doris-robot commented on PR #41943: URL: https://github.com/apache/doris/pull/41943#issuecomment-2415982752 TPC-DS: Total hot run time: 192170 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 9282bafb87df28dd40e2dce256768e6aeebd32b1, data reload: false query1 878 410 401 401 query2 6281204819991999 query3 8681195 198 195 query4 34248 23648 23802 23648 query5 3536476 466 466 query6 290 168 170 168 query7 4194296 297 296 query8 305 232 231 231 query9 9621273727382737 query10 476 266 279 266 query11 19171 15423 15430 15423 query12 144 102 99 99 query13 1569442 422 422 query14 9994760771657165 query15 261 175 173 173 query16 7979490 496 490 query17 1657594 577 577 query18 2235307 316 307 query19 368 160 153 153 query20 139 116 114 114 query21 218 104 103 103 query22 4698460746424607 query23 34736 34169 34126 34126 query24 10931 267627022676 query25 649 408 388 388 query26 1162156 164 156 query27 2248286 290 286 query28 7365244624442444 query29 821 432 420 420 query30 257 150 152 150 query31 1039814 770 770 query32 95 57 56 56 query33 775 288 290 288 query34 912 510 507 507 query35 935 750 760 750 query36 1094932 962 932 query37 154 91 84 84 query38 4126402439383938 query39 1507144813951395 query40 214 97 98 97 query41 48 43 44 43 query42 125 96 101 96 query43 537 494 493 493 query44 1294802 824 802 query45 198 168 163 163 query46 1136688 676 676 query47 1940186518401840 query48 423 316 338 316 query49 914 426 440 426 query50 817 380 420 380 query51 7072698069296929 query52 96 90 83 83 query53 251 176 180 176 query54 1176429 408 408 query55 77 77 73 73 query56 253 256 253 253 query57 1303116111461146 query58 242 240 249 240 query59 3337318729652965 query60 287 259 267 259 query61 102 97 99 97 query62 862 675 680 675 query63 219 184 180 180 query64 3931650 648 648 query65 3285322532463225 query66 841 295 299 295 query67 16028 15817 15693 15693 query68 4669548 558 548 query69 526 283 287 283 query70 1206113011551130 query71 347 268 277 268 query72 7408394239323932 query73 773 353 365 353 query74 10215 896190028961 query75 3462264026542640 query76 3266919 896 896 query77 627 291 286 286 query78 10687 966895709570 query79 1878590 593 590 query80 1501439 450 439 query81 592 240 244 240 query82 686 138 137 137 query83 293 138 130 130 query84 282 72 68 68 query85 1667290 283 283 query86 437 306 299 299 query87 4394430143684301 query88 3092219721672167 query89 401 290 287 287 query90 2122185 185 185 query91 139 99 99 99 query92 59 47 50 47 query93 1531531 534 531 query94 1192279 306 279 query95 351 240 249 240 query96 612 279 283 279 query97 3297314931393139 query98 216 203 191 191 query99 1553128912961289 Total cold run time: 302238 ms Total hot run time: 192170 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Improvement](local shuffle) Improve local shuffle strategy [doris]
github-actions[bot] commented on PR #41789: URL: https://github.com/apache/doris/pull/41789#issuecomment-2415983839 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](function)fix date_floor function return wrong result [doris]
zhangstar333 commented on PR #41948: URL: https://github.com/apache/doris/pull/41948#issuecomment-2415986147 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
doris-robot commented on PR #41949: URL: https://github.com/apache/doris/pull/41949#issuecomment-2415986298 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
Gabriel39 opened a new pull request, #41949: URL: https://github.com/apache/doris/pull/41949 Fix data distribution after analytic operator ## Proposed changes pick #41902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
github-actions[bot] commented on PR #41953: URL: https://github.com/apache/doris/pull/41953#issuecomment-2416424256 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
github-actions[bot] commented on PR #41953: URL: https://github.com/apache/doris/pull/41953#issuecomment-2416424179 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
Gabriel39 merged PR #41949: URL: https://github.com/apache/doris/pull/41949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](analytic) Fix data distribution after analytic operator (#41902) (#41949)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new 7d99d5fcc48 [fix](analytic) Fix data distribution after analytic operator (#41902) (#41949) 7d99d5fcc48 is described below commit 7d99d5fcc482c84efe9ad6236baa8dc49241dee5 Author: Gabriel AuthorDate: Wed Oct 16 18:41:56 2024 +0800 [fix](analytic) Fix data distribution after analytic operator (#41902) (#41949) Fix data distribution after analytic operator pick #41902 --- be/src/pipeline/exec/analytic_sink_operator.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/be/src/pipeline/exec/analytic_sink_operator.h b/be/src/pipeline/exec/analytic_sink_operator.h index 0269ba15be0..8fb3645daa8 100644 --- a/be/src/pipeline/exec/analytic_sink_operator.h +++ b/be/src/pipeline/exec/analytic_sink_operator.h @@ -101,17 +101,16 @@ public: DataDistribution required_data_distribution() const override { if (_partition_by_eq_expr_ctxs.empty()) { return {ExchangeType::PASSTHROUGH}; -} else if (_order_by_eq_expr_ctxs.empty()) { +} else { return _is_colocate && _require_bucket_distribution && !_followed_by_shuffled_operator ? DataDistribution(ExchangeType::BUCKET_HASH_SHUFFLE, _partition_exprs) : DataDistribution(ExchangeType::HASH_SHUFFLE, _partition_exprs); } -return DataSinkOperatorX::required_data_distribution(); } bool require_data_distribution() const override { return true; } bool require_shuffled_data_distribution() const override { -return !_partition_by_eq_expr_ctxs.empty() && _order_by_eq_expr_ctxs.empty(); +return !_partition_by_eq_expr_ctxs.empty(); } private: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416431748 TPC-H: Total hot run time: 41206 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 57c6a33b9c9443482165171e92a548892b3e4d8f, data reload: false -- Round 1 -- q1 17575 788573307330 q2 2059155 157 155 q3 10578 112311621123 q4 10223 826 764 764 q5 7729308530033003 q6 245 155 153 153 q7 1044607 605 605 q8 9352191519951915 q9 6680643264606432 q10 7058240824932408 q11 447 248 256 248 q12 414 224 221 221 q13 17803 300130053001 q14 258 217 207 207 q15 574 528 522 522 q16 664 576 583 576 q17 971 501 484 484 q18 7446695367826782 q19 13581039944 944 q20 479 183 184 183 q21 4260321631773177 q22 10951012973 973 Total cold run time: 108312 ms Total hot run time: 41206 ms - Round 2, with runtime_filter_mode=off - q1 7314731472827282 q2 322 231 233 231 q3 2936279928622799 q4 1965171817341718 q5 5467552355265523 q6 229 140 142 140 q7 2136171217461712 q8 3232339534413395 q9 8525855285748552 q10 3523347334493449 q11 574 496 488 488 q12 817 632 620 620 q13 8550303030553030 q14 306 261 274 261 q15 560 519 517 517 q16 683 632 641 632 q17 1823159015841584 q18 7903754574527452 q19 1682149015181490 q20 2043178218011782 q21 5472531952775277 q22 1122101610231016 Total cold run time: 67184 ms Total hot run time: 58950 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](move-memtable) do not retry open streams (#41550) [doris]
kaijchen opened a new pull request, #41972: URL: https://github.com/apache/doris/pull/41972 backport #41550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) do not retry open streams (#41550) [doris]
kaijchen commented on PR #41972: URL: https://github.com/apache/doris/pull/41972#issuecomment-2416418085 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) do not retry open streams (#41550) [doris]
doris-robot commented on PR #41972: URL: https://github.com/apache/doris/pull/41972#issuecomment-2416417786 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement]use awaitility.await() [doris]
github-actions[bot] commented on PR #41514: URL: https://github.com/apache/doris/pull/41514#issuecomment-2416422203 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-3.0) pick #40542 #40914 [doris]
doris-robot commented on PR #41973: URL: https://github.com/apache/doris/pull/41973#issuecomment-2416442244 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [pick](branch-3.0) pick #40542 #40914 [doris]
xinyiZzz commented on PR #41973: URL: https://github.com/apache/doris/pull/41973#issuecomment-2416442269 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [pick](branch-3.0) pick #40542 #40914 [doris]
xinyiZzz opened a new pull request, #41973: URL: https://github.com/apache/doris/pull/41973 pick #40542 #40914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416446434 TeamCity be ut coverage result: Function Coverage: 37.46% (9709/25919) Line Coverage: 28.74% (80647/280614) Region Coverage: 28.17% (41714/148085) Branch Coverage: 24.75% (21214/85700) Coverage Report: http://coverage.selectdb-in.cc/coverage/57c6a33b9c9443482165171e92a548892b3e4d8f_57c6a33b9c9443482165171e92a548892b3e4d8f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
doris-robot commented on PR #41953: URL: https://github.com/apache/doris/pull/41953#issuecomment-2416024662 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [minor](refactor) Delete unused code [doris]
Gabriel39 commented on PR #41953: URL: https://github.com/apache/doris/pull/41953#issuecomment-2416024859 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](local shuffle) Improve local shuffle strategy [doris]
Gabriel39 commented on PR #41789: URL: https://github.com/apache/doris/pull/41789#issuecomment-2416022510 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [minor](refactor) Delete unused code [doris]
Gabriel39 opened a new pull request, #41953: URL: https://github.com/apache/doris/pull/41953 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) Improved top-N optimization by refining the sorting column check. (#39496) [doris]
zzzxl1993 commented on PR #41954: URL: https://github.com/apache/doris/pull/41954#issuecomment-2416030068 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](inverted index) Improved top-N optimization by refining the sorting column check. (#39496) [doris]
zzzxl1993 opened a new pull request, #41954: URL: https://github.com/apache/doris/pull/41954 https://github.com/apache/doris/pull/39496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](inverted index) Improved top-N optimization by refining the sorting column check. (#39496) [doris]
doris-robot commented on PR #41954: URL: https://github.com/apache/doris/pull/41954#issuecomment-2416029875 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json (#41217) [doris]
hubgeter commented on PR #41963: URL: https://github.com/apache/doris/pull/41963#issuecomment-2416121135 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json (#41217) [doris]
github-actions[bot] commented on PR #41960: URL: https://github.com/apache/doris/pull/41960#issuecomment-2416122426 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json (#41217) [doris]
hubgeter opened a new pull request, #41963: URL: https://github.com/apache/doris/pull/41963 bp #41217 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) fix filtered database when use_meta_cache=true [doris]
doris-robot commented on PR #41939: URL: https://github.com/apache/doris/pull/41939#issuecomment-2416122267 TPC-H: Total hot run time: 41126 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 260975e27ac69ebb2e1c84ba61e28e09a0df399b, data reload: false -- Round 1 -- q1 17589 736871987198 q2 2030272 283 272 q3 12035 104211421042 q4 10576 836 860 836 q5 7766306730633063 q6 238 151 147 147 q7 1009625 609 609 q8 9348195619471947 q9 6963644463696369 q10 7036243924362436 q11 442 251 247 247 q12 409 218 216 216 q13 17794 298630032986 q14 251 222 211 211 q15 573 513 528 513 q16 651 588 574 574 q17 963 591 446 446 q18 7220669967756699 q19 1351956 973 956 q20 465 182 175 175 q21 3916319332773193 q22 11241010991 991 Total cold run time: 109749 ms Total hot run time: 41126 ms - Round 2, with runtime_filter_mode=off - q1 7221720272137202 q2 325 225 224 224 q3 3026298129292929 q4 2131183217781778 q5 5725574557635745 q6 248 147 147 147 q7 2270188017981798 q8 3352352434003400 q9 8896891889138913 q10 3579360035743574 q11 591 489 488 488 q12 831 647 657 647 q13 10069 322032273220 q14 309 278 269 269 q15 574 523 530 523 q16 693 643 638 638 q17 1830160915961596 q18 8211780176407640 q19 1735138216021382 q20 2104185518631855 q21 5572538353415341 q22 1181104610711046 Total cold run time: 70473 ms Total hot run time: 60355 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](SchemaChange) refactor variant root column iterator to make row… [doris]
doris-robot commented on PR #41941: URL: https://github.com/apache/doris/pull/41941#issuecomment-2416126883 TeamCity be ut coverage result: Function Coverage: 36.03% (9343/25930) Line Coverage: 27.61% (76764/277996) Region Coverage: 26.41% (39426/149257) Branch Coverage: 23.20% (20056/86464) Coverage Report: http://coverage.selectdb-in.cc/coverage/05fa9fdc467241b383b960f75b0750d98964fecd_05fa9fdc467241b383b960f75b0750d98964fecd/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](serde)fix the bug in DataTypeNullableSerDe.deserialize_column_from_fixed_json (#41217) [doris]
doris-robot commented on PR #41963: URL: https://github.com/apache/doris/pull/41963#issuecomment-2416120983 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](ExternalTable)Optimize the performance of getCachedRowCount when reading ExternalTable (#41659) [doris]
hubgeter commented on PR #41962: URL: https://github.com/apache/doris/pull/41962#issuecomment-2416117142 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](ExternalTable)Optimize the performance of getCachedRowCount when reading ExternalTable (#41659) [doris]
doris-robot commented on PR #41962: URL: https://github.com/apache/doris/pull/41962#issuecomment-2416116657 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch-30) fix rpad function return error result (#41399) [doris]
zhangstar333 commented on PR #41961: URL: https://github.com/apache/doris/pull/41961#issuecomment-2416116692 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [cherry-pick](branch-30) fix rpad function return error result (#41399) [doris]
doris-robot commented on PR #41961: URL: https://github.com/apache/doris/pull/41961#issuecomment-2416116135 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [cherry-pick](branch-30) fix rpad function return error result (#41399) [doris]
zhangstar333 opened a new pull request, #41961: URL: https://github.com/apache/doris/pull/41961 ## Proposed changes cherry-pick from master (#41399) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [improve](profile) add timer for record udf execute time (#41779)
This is an automated email from the ASF dual-hosted git repository. zhangstar333 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new db5717d7d63 [improve](profile) add timer for record udf execute time (#41779) db5717d7d63 is described below commit db5717d7d63ea7e988ed069a8624e5596236ef1d Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com> AuthorDate: Wed Oct 16 16:42:26 2024 +0800 [improve](profile) add timer for record udf execute time (#41779) ## Proposed changes https://github.com/user-attachments/assets/d4f4e2fc-6736-4660-a2c7-12e01eb1a4d1";> --- be/src/pipeline/pipeline_task.h| 2 ++ be/src/udf/udf.h | 9 + be/src/vec/exprs/vcase_expr.cpp| 2 +- be/src/vec/exprs/vcast_expr.cpp| 2 +- be/src/vec/exprs/vectorized_fn_call.cpp| 3 ++- be/src/vec/exprs/vexpr.cpp | 9 - be/src/vec/exprs/vexpr.h | 3 ++- be/src/vec/exprs/vin_predicate.cpp | 2 +- be/src/vec/exprs/vmatch_predicate.cpp | 2 +- be/src/vec/functions/function.h| 2 ++ be/src/vec/functions/function_java_udf.cpp | 3 ++- be/src/vec/functions/function_java_udf.h | 2 ++ 12 files changed, 33 insertions(+), 8 deletions(-) diff --git a/be/src/pipeline/pipeline_task.h b/be/src/pipeline/pipeline_task.h index 223420ea55a..febc9634c49 100644 --- a/be/src/pipeline/pipeline_task.h +++ b/be/src/pipeline/pipeline_task.h @@ -224,6 +224,8 @@ public: RuntimeState* runtime_state() const { return _state; } +RuntimeProfile* get_task_profile() const { return _task_profile.get(); } + std::string task_name() const { return fmt::format("task{}({})", _index, _pipeline->_name); } void stop_if_finished() { diff --git a/be/src/udf/udf.h b/be/src/udf/udf.h index 39af2ad1c25..d717c18ccec 100644 --- a/be/src/udf/udf.h +++ b/be/src/udf/udf.h @@ -26,6 +26,7 @@ #include #include "runtime/types.h" +#include "util/runtime_profile.h" #include "vec/common/arena.h" namespace doris { @@ -88,6 +89,12 @@ public: _jsonb_string_as_string = jsonb_string_as_string; } +void set_udf_execute_timer(RuntimeProfile::Counter* udf_execute_timer) { +_udf_execute_timer = udf_execute_timer; +} + +RuntimeProfile::Counter* get_udf_execute_timer() { return _udf_execute_timer; } + // Cast flag, when enable string_as_jsonb_string, string casting to jsonb will not parse string // instead just insert a string literal bool string_as_jsonb_string() const { return _string_as_jsonb_string; } @@ -176,6 +183,8 @@ private: std::vector> _constant_cols; +//udf execute timer +RuntimeProfile::Counter* _udf_execute_timer = nullptr; bool _check_overflow_for_decimal = false; bool _string_as_jsonb_string = false; diff --git a/be/src/vec/exprs/vcase_expr.cpp b/be/src/vec/exprs/vcase_expr.cpp index dee60b5a6f1..d6573a0e25f 100644 --- a/be/src/vec/exprs/vcase_expr.cpp +++ b/be/src/vec/exprs/vcase_expr.cpp @@ -84,7 +84,7 @@ Status VCaseExpr::open(RuntimeState* state, VExprContext* context, for (auto& i : _children) { RETURN_IF_ERROR(i->open(state, context, scope)); } -RETURN_IF_ERROR(VExpr::init_function_context(context, scope, _function)); +RETURN_IF_ERROR(VExpr::init_function_context(state, context, scope, _function)); if (scope == FunctionContext::FRAGMENT_LOCAL) { RETURN_IF_ERROR(VExpr::get_const_col(context, nullptr)); } diff --git a/be/src/vec/exprs/vcast_expr.cpp b/be/src/vec/exprs/vcast_expr.cpp index 56072967058..6cd914080cd 100644 --- a/be/src/vec/exprs/vcast_expr.cpp +++ b/be/src/vec/exprs/vcast_expr.cpp @@ -87,7 +87,7 @@ doris::Status VCastExpr::open(doris::RuntimeState* state, VExprContext* context, for (auto& i : _children) { RETURN_IF_ERROR(i->open(state, context, scope)); } -RETURN_IF_ERROR(VExpr::init_function_context(context, scope, _function)); +RETURN_IF_ERROR(VExpr::init_function_context(state, context, scope, _function)); if (scope == FunctionContext::FRAGMENT_LOCAL) { RETURN_IF_ERROR(VExpr::get_const_col(context, nullptr)); } diff --git a/be/src/vec/exprs/vectorized_fn_call.cpp b/be/src/vec/exprs/vectorized_fn_call.cpp index 65d4230488a..cd9138ee971 100644 --- a/be/src/vec/exprs/vectorized_fn_call.cpp +++ b/be/src/vec/exprs/vectorized_fn_call.cpp @@ -27,6 +27,7 @@ #include "common/config.h" #include "common/consts.h" #include "common/status.h" +#include "pipeline/pipeline_task.h" #include "runtime/runtime_state.h" #include "udf/udf.h" #include "vec/columns/column.h" @@ -124,7 +125,7 @@ Status VectorizedFnCall::open(RuntimeState* state, VExprContext* context, for (auto& i : _children) { RETURN_IF_ERROR(i->open(state, context, scope)); } -RETURN_I
Re: [PR] [fix](jni)fix jni use timezone_obj get timezone be core. [doris]
doris-robot commented on PR #41956: URL: https://github.com/apache/doris/pull/41956#issuecomment-2416119484 TeamCity be ut coverage result: Function Coverage: 37.47% (9709/25914) Line Coverage: 28.74% (80640/280606) Region Coverage: 28.17% (41714/148071) Branch Coverage: 24.75% (21211/85698) Coverage Report: http://coverage.selectdb-in.cc/coverage/bdb5e9db04233e470931bdf3767a65f399db5994_bdb5e9db04233e470931bdf3767a65f399db5994/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](exchange) refine exchange sink/ buffer code [doris]
doris-robot commented on PR #41955: URL: https://github.com/apache/doris/pull/41955#issuecomment-2416120044 TeamCity be ut coverage result: Function Coverage: 37.47% (9709/25914) Line Coverage: 28.74% (80637/280605) Region Coverage: 28.17% (41718/148070) Branch Coverage: 24.75% (21212/85698) Coverage Report: http://coverage.selectdb-in.cc/coverage/53c2d4ccb98e809d4137af9ce4f2e2d68cae8946_53c2d4ccb98e809d4137af9ce4f2e2d68cae8946/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [env](compile)open compile check in some file [doris]
doris-robot commented on PR #41940: URL: https://github.com/apache/doris/pull/41940#issuecomment-2416119262 TeamCity be ut coverage result: Function Coverage: 37.46% (9708/25914) Line Coverage: 28.72% (80596/280607) Region Coverage: 28.17% (41712/148071) Branch Coverage: 24.74% (21204/85698) Coverage Report: http://coverage.selectdb-in.cc/coverage/e569c9c22eb126134b8fdbc05d0bfe9b278c81f4_e569c9c22eb126134b8fdbc05d0bfe9b278c81f4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](profile) add timer for record udf execute time [doris]
zhangstar333 merged PR #41779: URL: https://github.com/apache/doris/pull/41779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](conv) fix conv function parser string failure return wrong result (#40530) [doris]
doris-robot commented on PR #41964: URL: https://github.com/apache/doris/pull/41964#issuecomment-2416133344 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](conv) fix conv function parser string failure return wrong result (#40530) [doris]
zhangstar333 opened a new pull request, #41964: URL: https://github.com/apache/doris/pull/41964 ## Proposed changes Issue Number: close #39618 cherry-pick from master (#40530) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](conv) fix conv function parser string failure return wrong result (#40530) [doris]
zhangstar333 commented on PR #41964: URL: https://github.com/apache/doris/pull/41964#issuecomment-2416133545 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) Fix load failed where not set database in session [doris]
doris-robot commented on PR #41951: URL: https://github.com/apache/doris/pull/41951#issuecomment-2416136500 TPC-DS: Total hot run time: 192589 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a0097a0fec876f4ec0982bc23caa6c2e5e47d420, data reload: false query1 909 395 406 395 query2 6249211820382038 query3 8681200 202 200 query4 34212 23791 23628 23628 query5 3354473 489 473 query6 259 171 154 154 query7 4183288 298 288 query8 309 238 228 228 query9 9632272427432724 query10 462 270 271 270 query11 17844 15344 15317 15317 query12 154 101 101 101 query13 1557428 410 410 query14 9438773177737731 query15 248 173 179 173 query16 7900485 464 464 query17 1611595 567 567 query18 2153297 313 297 query19 357 157 167 157 query20 121 117 113 113 query21 213 113 117 113 query22 4802476245574557 query23 35211 34298 35052 34298 query24 11463 283527842784 query25 651 411 391 391 query26 1626164 166 164 query27 2559282 274 274 query28 7772243424092409 query29 981 438 422 422 query30 268 151 148 148 query31 1049812 771 771 query32 94 54 53 53 query33 768 313 308 308 query34 945 511 530 511 query35 887 753 753 753 query36 1134969 941 941 query37 178 87 87 87 query38 3968391939363919 query39 1494145114241424 query40 255 96 98 96 query41 47 44 45 44 query42 128 109 101 101 query43 540 492 495 492 query44 1255806 807 806 query45 194 163 165 163 query46 1146714 694 694 query47 1909185618491849 query48 419 326 322 322 query49 1033440 423 423 query50 822 385 405 385 query51 7063693069496930 query52 103 86 88 86 query53 262 181 183 181 query54 1249424 430 424 query55 79 82 75 75 query56 285 269 250 250 query57 1309114511401140 query58 241 255 224 224 query59 3283292731282927 query60 286 268 260 260 query61 104 103 104 103 query62 817 686 665 665 query63 220 193 189 189 query64 5008641 613 613 query65 3290322132233221 query66 1174304 320 304 query67 15933 15577 15771 15577 query68 4517581 550 550 query69 548 287 286 286 query70 1107113011131113 query71 400 278 285 278 query72 7255395639103910 query73 772 350 354 350 query74 9931893488658865 query75 3448269026752675 query76 3325884 915 884 query77 462 291 289 289 query78 10629 955195569551 query79 2728594 609 594 query80 1204431 457 431 query81 593 239 236 236 query82 719 137 135 135 query83 261 135 130 130 query84 256 75 72 72 query85 1250316 294 294 query86 372 295 296 295 query87 4544430743254307 query88 3377223021672167 query89 423 288 290 288 query90 2000184 184 184 query91 136 98 98 98 query92 56 48 46 46 query93 1652542 537 537 query94 865 294 292 292 query95 351 248 248 248 query96 616 276 285 276 query97 3291310831653108 query98 227 206 192 192 query99 1660132213091309 Total cold run time: 303125 ms Total hot run time: 192589 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [opt](inverted index) Improved top-N optimization by refining the sorting column check. (#39496) [doris]
doris-robot commented on PR #41954: URL: https://github.com/apache/doris/pull/41954#issuecomment-2416137609 TeamCity be ut coverage result: Function Coverage: 36.02% (9342/25938) Line Coverage: 27.59% (76729/278092) Region Coverage: 26.40% (39426/149314) Branch Coverage: 23.18% (20056/86524) Coverage Report: http://coverage.selectdb-in.cc/coverage/ce26f05859fa6e8bffa7e6b53b8d7f8e364d1798_ce26f05859fa6e8bffa7e6b53b8d7f8e364d1798/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](analytic) Fix data distribution after analytic operator (#41902) [doris]
doris-robot commented on PR #41949: URL: https://github.com/apache/doris/pull/41949#issuecomment-2416136458 TeamCity be ut coverage result: Function Coverage: 36.01% (9341/25938) Line Coverage: 27.59% (76719/278093) Region Coverage: 26.40% (39418/149311) Branch Coverage: 23.18% (20057/86520) Coverage Report: http://coverage.selectdb-in.cc/coverage/4ea5a441bb68cae1826bd71f2a068f5394bcd872_4ea5a441bb68cae1826bd71f2a068f5394bcd872/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](case) test_limit result is unstable [doris]
morrySnow opened a new pull request, #41977: URL: https://github.com/apache/doris/pull/41977 pick from master #41938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](case) test_limit result is unstable [doris]
doris-robot commented on PR #41977: URL: https://github.com/apache/doris/pull/41977#issuecomment-2416511925 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](case) test_limit result is unstable [doris]
morrySnow commented on PR #41977: URL: https://github.com/apache/doris/pull/41977#issuecomment-2416513643 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](catalog) fix filtered database when use_meta_cache=true [doris]
morningman commented on PR #41939: URL: https://github.com/apache/doris/pull/41939#issuecomment-2416515397 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](External Catalog) Remove unnecessary conjuncts handling in External Catalog [doris]
github-actions[bot] commented on PR #41218: URL: https://github.com/apache/doris/pull/41218#issuecomment-2416519084 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fixed the limit offset error [doris]
felixwluo commented on PR #41967: URL: https://github.com/apache/doris/pull/41967#issuecomment-2416524291 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](nereids)support set command [doris]
doris-robot commented on PR #41913: URL: https://github.com/apache/doris/pull/41913#issuecomment-2416533449 TPC-H: Total hot run time: 41163 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 879c0e2bab46b0dd2ae3dbd9ec12409304770be0, data reload: false -- Round 1 -- q1 17554 740272697269 q2 2034306 299 299 q3 11934 105811301058 q4 10566 891 844 844 q5 7780312130303030 q6 238 151 148 148 q7 1020622 606 606 q8 9358196419091909 q9 6561646063946394 q10 7040245324112411 q11 438 245 242 242 q12 423 220 212 212 q13 17763 298530022985 q14 248 221 207 207 q15 568 522 518 518 q16 624 589 578 578 q17 981 547 575 547 q18 7188677066476647 q19 1353103210281028 q20 479 180 182 180 q21 3944304231153042 q22 100910251009 Total cold run time: 109205 ms Total hot run time: 41163 ms - Round 2, with runtime_filter_mode=off - q1 7257724272417241 q2 324 235 229 229 q3 2970296329032903 q4 2159187517991799 q5 5763575057935750 q6 237 145 145 145 q7 2258187517521752 q8 3391353434393439 q9 8919889489528894 q10 3599356735113511 q11 581 489 492 489 q12 820 657 627 627 q13 9426317231893172 q14 317 279 282 279 q15 562 521 524 521 q16 708 669 626 626 q17 1839161815931593 q18 8254791676947694 q19 1727147113811381 q20 2153186318861863 q21 5497533155335331 q22 1194107710481048 Total cold run time: 69955 ms Total hot run time: 60287 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894) [doris]
doris-robot commented on PR #41978: URL: https://github.com/apache/doris/pull/41978#issuecomment-2416541931 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement](statistics)Use min row count of all replicas as tablet/table row count. (#41894) [doris]
Jibing-Li opened a new pull request, #41978: URL: https://github.com/apache/doris/pull/41978 backport: https://github.com/apache/doris/pull/41894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) fixed the limit offset error [doris]
felixwluo commented on PR #41936: URL: https://github.com/apache/doris/pull/41936#issuecomment-2416544721 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ecosystem](kettle) add kettle plugin for ecosystem [doris-website]
KassieZ commented on code in PR #1193: URL: https://github.com/apache/doris-website/pull/1193#discussion_r1802611132 ## common_docs_zh/ecosystem/kettle.md: ## @@ -0,0 +1,81 @@ +--- +{ +"title": "Kettle Plugin", +"language": "zh-CN" +} +--- + + + +# Kettle doris stream load插件 + +[Kettle](https://pentaho.com/) doris stream load 插件,用于在Kettle中通过 Stream Load 将其他数据源的数据写入到 Doris 中。 + +这个插件是利用 Doris 的 Stream Load 功能进行数据导入的。需要配合 Kettle 服务一起使用。 + +## 关于 Kettle + +Kettle 是一款开源的ETL(Extract, Transform, Load)工具,最早由 Pentaho 公司开发,Kettle 是 Pentaho 产品套件中的核心组件之一,主要用于数据集成和数据处理,能够轻松完成从各种来源提取数据、对数据进行清洗和转换,并将其加载到目标系统中的任务。 + + +更多信息请参阅:`https://pentaho.com/` + +## 使用手册 + +### 下载Kettle安装 +Kettle 下载地址: https://pentaho.com/download/#download-pentaho +下载后解压,运行spoon.sh即可启动kettle +也可以自行编译,参考[编译章节](https://github.com/pentaho/pentaho-kettle?tab=readme-ov-file#how-to-build) + +### 编译Doris的stream load插件 Review Comment: please add blank ## common_docs_zh/ecosystem/kettle.md: ## @@ -0,0 +1,81 @@ +--- +{ +"title": "Kettle Plugin", +"language": "zh-CN" +} +--- + + + +# Kettle doris stream load插件 + +[Kettle](https://pentaho.com/) doris stream load 插件,用于在Kettle中通过 Stream Load 将其他数据源的数据写入到 Doris 中。 Review Comment: please capitalize Doris , Stream Load , and add blank between Chinese and English -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org