Re: [PR] [regression-test](test-json) enhance the robustness and stability of Doris in handling semi-structure types [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40362:
URL: https://github.com/apache/doris/pull/40362#issuecomment-2328049011

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Bug](exchange) fix tablet sink shuffle without project not match the output tuple [doris]

2024-09-04 Thread via GitHub


zhangstar333 commented on PR #40299:
URL: https://github.com/apache/doris/pull/40299#issuecomment-2328053294

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [regression-test](test-json) enhance the robustness and stability of Doris in handling semi-structure types [doris]

2024-09-04 Thread via GitHub


eldenmoon commented on PR #40362:
URL: https://github.com/apache/doris/pull/40362#issuecomment-2328053531

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](mtmv) Support to contain select constant clause when create async materialized view [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40244:
URL: https://github.com/apache/doris/pull/40244#issuecomment-2328054929

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](array/map) Fix semi-structure data column [doris]

2024-09-04 Thread via GitHub


Gabriel39 commented on PR #40363:
URL: https://github.com/apache/doris/pull/40363#issuecomment-2328059594

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-04 Thread via GitHub


xinyiZzz commented on code in PR #40344:
URL: https://github.com/apache/doris/pull/40344#discussion_r1743172103


##
be/src/common/daemon.cpp:
##
@@ -396,6 +472,34 @@ void Daemon::je_purge_dirty_pages_thread() const {
 } while (true);
 }
 
+void Daemon::cache_adjust_capacity_thread() {
+std::unique_ptr profile = 
std::make_unique("");

Review Comment:
   fixed



##
be/src/common/daemon.cpp:
##
@@ -396,6 +472,34 @@ void Daemon::je_purge_dirty_pages_thread() const {
 } while (true);
 }
 
+void Daemon::cache_adjust_capacity_thread() {
+std::unique_ptr profile = 
std::make_unique("");
+do {
+std::unique_lock 
l(doris::GlobalMemoryArbitrator::cache_adjust_capacity_lock);
+while (_stop_background_threads_latch.count() != 0 &&
+   
!doris::GlobalMemoryArbitrator::cache_adjust_capacity_notify.load(
+   std::memory_order_relaxed)) {
+doris::GlobalMemoryArbitrator::cache_adjust_capacity_cv.wait_for(
+l, std::chrono::seconds(1));
+}
+if (_stop_background_threads_latch.count() == 0) {
+break;
+}
+if (config::disable_memory_gc) {
+continue;
+}
+auto freed_mem = 
CacheManager::instance()->for_each_cache_refresh_capacity(
+GlobalMemoryArbitrator::last_cache_capacity_adjust_weighted, 
profile.get());

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [test](inverted index) refine test_ignore_above case, add compound query sql [doris]

2024-09-04 Thread via GitHub


airborne12 merged PR #40355:
URL: https://github.com/apache/doris/pull/40355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated: [test](inverted index) refine test_ignore_above case, add compound query sql (#40355)

2024-09-04 Thread airborne
This is an automated email from the ASF dual-hosted git repository.

airborne pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new dde1e0f5d7f [test](inverted index) refine test_ignore_above case, add 
compound query sql (#40355)
dde1e0f5d7f is described below

commit dde1e0f5d7f5347feb2d6786172427636cc3f60b
Author: airborne12 
AuthorDate: Wed Sep 4 14:56:56 2024 +0800

[test](inverted index) refine test_ignore_above case, add compound query 
sql (#40355)

## Proposed changes

Make test_ignore_above case more robust, add compound query for it.
---
 regression-test/data/inverted_index_p0/test_ignore_above_in_index.out  | 3 +++
 .../suites/inverted_index_p0/test_ignore_above_in_index.groovy | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git 
a/regression-test/data/inverted_index_p0/test_ignore_above_in_index.out 
b/regression-test/data/inverted_index_p0/test_ignore_above_in_index.out
index 718bd29e5d9..66d0935327d 100644
--- a/regression-test/data/inverted_index_p0/test_ignore_above_in_index.out
+++ b/regression-test/data/inverted_index_p0/test_ignore_above_in_index.out
@@ -5,3 +5,6 @@
 -- !sql --
 772
 
+-- !sql --
+971
+
diff --git 
a/regression-test/suites/inverted_index_p0/test_ignore_above_in_index.groovy 
b/regression-test/suites/inverted_index_p0/test_ignore_above_in_index.groovy
index d6b42661441..bde764fa332 100644
--- a/regression-test/suites/inverted_index_p0/test_ignore_above_in_index.groovy
+++ b/regression-test/suites/inverted_index_p0/test_ignore_above_in_index.groovy
@@ -84,6 +84,7 @@ suite("test_ignore_above_in_index", "p0") {
 assertTrue(json.NumberLoadedRows > 0 && json.LoadBytes > 0)
 }
 }
-
+sql """ set enable_common_expr_pushdown = true; """
 qt_sql "select count() from ${tableName2} where clientip > '17.0';"
+qt_sql "select count() from ${tableName2} where clientip > '17.0' or 
status = 200;"
 }


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Compatibility](agg-state) add be_exec_version check to avoid aggregation data format changed le… [doris]

2024-09-04 Thread via GitHub


HappenLee commented on code in PR #40193:
URL: https://github.com/apache/doris/pull/40193#discussion_r1743177705


##
be/src/olap/rowset/segment_v2/column_reader.h:
##
@@ -242,12 +244,19 @@ class ColumnReader {
 
 Status _calculate_row_ranges(const std::vector& page_indexes, 
RowRanges* row_ranges);
 
+Status check_be_exec_version(int read_be_exec_version) {

Review Comment:
   what the func do?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](array/map) Fix semi-structure data column [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40363:
URL: https://github.com/apache/doris/pull/40363#issuecomment-2328071049

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhancement] support information_schema.partitions [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40153:
URL: https://github.com/apache/doris/pull/40153#issuecomment-2328074577

   TeamCity be ut coverage result:
Function Coverage: 36.83% (9392/25500) 
Line Coverage: 28.26% (77435/274047)
Region Coverage: 27.67% (39972/144484)
Branch Coverage: 24.30% (20336/83672)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/bca6487298d823064128c9ae8d484701002c37e4_bca6487298d823064128c9ae8d484701002c37e4/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Fix](Variant) use uinque id to access column reader (#39841) [doris]

2024-09-04 Thread via GitHub


eldenmoon commented on PR #40269:
URL: https://github.com/apache/doris/pull/40269#issuecomment-2328078040

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](scanner profile) More counter for scanner [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40144:
URL: https://github.com/apache/doris/pull/40144#issuecomment-2328087477

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [test](inverted index)Add fault injection cases for index writing [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #39649:
URL: https://github.com/apache/doris/pull/39649#issuecomment-2328096755

   TeamCity be ut coverage result:
Function Coverage: 36.85% (9395/25495) 
Line Coverage: 28.26% (77536/274411)
Region Coverage: 27.61% (40023/144979)
Branch Coverage: 24.25% (20344/83890)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/a19202a1ab1686af9b0f353b61eea6208c38ffbb_a19202a1ab1686af9b0f353b61eea6208c38ffbb/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](scanner profile) More counter for scanner [doris]

2024-09-04 Thread via GitHub


zhiqiang- commented on PR #40144:
URL: https://github.com/apache/doris/pull/40144#issuecomment-2328097507

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Featrue](default value) Support `bitmap_empty` default value [doris]

2024-09-04 Thread via GitHub


Yukang-Lian commented on PR #40364:
URL: https://github.com/apache/doris/pull/40364#issuecomment-2328104019

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](nereids)stats derive for min()/max() agg function [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40126:
URL: https://github.com/apache/doris/pull/40126#issuecomment-2328109463

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](nereids)stats derive for min()/max() agg function [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40126:
URL: https://github.com/apache/doris/pull/40126#issuecomment-2328109532

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat]reserve and spill [doris]

2024-09-04 Thread via GitHub


yiguolei commented on code in PR #39883:
URL: https://github.com/apache/doris/pull/39883#discussion_r1743210426


##
be/src/pipeline/exec/aggregation_source_operator.cpp:
##
@@ -22,17 +22,13 @@
 
 #include "common/exception.h"
 #include "pipeline/exec/operator.h"
+#include "runtime/thread_context.h"
 #include "vec/exprs/vectorized_agg_fn.h"
+#include "vec/exprs/vexpr_fwd.h"
 
 namespace doris::pipeline {
 
-AggLocalState::AggLocalState(RuntimeState* state, OperatorXBase* parent)
-: Base(state, parent),
-  _get_results_timer(nullptr),
-  _serialize_result_timer(nullptr),

Review Comment:
   why delete these code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix]Add unused parameter timeout [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40365:
URL: https://github.com/apache/doris/pull/40365#issuecomment-2328122889

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix]Add unused parameter timeout [doris]

2024-09-04 Thread via GitHub


wonderzerg opened a new pull request, #40365:
URL: https://github.com/apache/doris/pull/40365

   ## Proposed changes
   
   
   Parameter timeout in function "getInfoRequest" is forgotten.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix]Add unused parameter timeout [doris]

2024-09-04 Thread via GitHub


wonderzerg commented on PR #40365:
URL: https://github.com/apache/doris/pull/40365#issuecomment-2328125972

   please assign me a label, and this is a separate commit, thanks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) fixed the limit offset error [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #39316:
URL: https://github.com/apache/doris/pull/39316#issuecomment-2328139270

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) fixed the limit offset error [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #39316:
URL: https://github.com/apache/doris/pull/39316#issuecomment-2328139195

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids) fixed the limit offset error [doris]

2024-09-04 Thread via GitHub


morrySnow commented on PR #39316:
URL: https://github.com/apache/doris/pull/39316#issuecomment-2328142328

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](agg-func) linear_histogram [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #39546:
URL: https://github.com/apache/doris/pull/39546#issuecomment-2328148210

   
   
   TPC-DS: Total hot run time: 187191 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 4f7ee867ea52ccbab68c59fae77f1e988d8aad89, 
data reload: false
   
   query1   900 375 369 369
   query2   6467192318611861
   query3   6654213 218 213
   query4   27794   23196   23214   23196
   query5   4134511 479 479
   query6   272 171 162 162
   query7   4576294 310 294
   query8   255 205 222 205
   query9   8672253125192519
   query10  451 274 282 274
   query11  17926   15056   15147   15056
   query12  144 102 107 102
   query13  1635382 372 372
   query14  9862722068206820
   query15  288 164 177 164
   query16  8110456 483 456
   query17  1579581 578 578
   query18  2130286 277 277
   query19  214 142 145 142
   query20  117 110 117 110
   query21  219 104 103 103
   query22  4239416439803980
   query23  33923   33594   33322   33322
   query24  3   288528422842
   query25  632 379 391 379
   query26  1197161 152 152
   query27  2601285 278 278
   query28  7332206720482048
   query29  830 412 406 406
   query30  312 164 157 157
   query31  1003791 784 784
   query32  103 54  57  54
   query33  761 300 281 281
   query34  1035472 508 472
   query35  859 753 708 708
   query36  1084900 955 900
   query37  172 101 87  87
   query38  4017384638653846
   query39  1465140013971397
   query40  203 117 116 116
   query41  48  47  46  46
   query42  122 95  99  95
   query43  488 467 463 463
   query44  1196742 734 734
   query45  196 174 173 173
   query46  1109754 715 715
   query47  1911179018421790
   query48  397 294 289 289
   query49  1085445 471 445
   query50  817 399 406 399
   query51  7029688468526852
   query52  102 88  87  87
   query53  263 189 188 188
   query54  1007464 482 464
   query55  80  75  76  75
   query56  280 253 257 253
   query57  1198105210921052
   query58  251 232 224 224
   query59  2859259726152597
   query60  302 267 260 260
   query61  101 97  118 97
   query62  864 676 658 658
   query63  221 187 182 182
   query64  4298677 679 677
   query65  3289320031403140
   query66  1426343 339 339
   query67  15697   15310   15304   15304
   query68  3546598 580 580
   query69  452 277 273 273
   query70  1097109311191093
   query71  348 275 283 275
   query72  6373400441214004
   query73  739 324 328 324
   query74  9204877087668766
   query75  3377268626482648
   query76  2250106610461046
   query77  481 323 340 323
   query78  10444   909790329032
   query79  1044547 524 524
   query80  705 516 521 516
   query81  567 240 245 240
   query82  244 153 145 145
   query83  229 156 160 156
   query84  226 84  76  76
   query85  992 318 399 318
   query86  304 293 298 293
   query87  4420427041854185
   query88  2919236523492349
   query89  383 288 286 286
   query90  1983196 190 190
   query91  127 100 104 100
   query92  61  49  52  49
   query93  1064550 549 549
   query94  736 258 281 258
   query95  381 258 258 258
   query96  586 262 267 262
   query97  3140304330513043
   query98  222 196 193 193
   query99  1500129612781278
   Total cold run time: 282060 ms
   Total hot run time: 187191 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to 

[PR] [fix](multi table) do not use strlen to calculate the length of msg [doris]

2024-09-04 Thread via GitHub


sollhui opened a new pull request, #40367:
URL: https://github.com/apache/doris/pull/40367

   Meet code dump when using single stream multi table load:
   ```
   SUMMARY: AddressSanitizer: heap-buffer-overflow 
/root/doris/be/src/io/fs/multi_table_pipe.cpp:99:22 in 
doris::io::MultiTablePipe::dispatch(std::__cxx11::basic_string, std::allocator> const&, char const*, unsigned 
long, doris::Status (doris::io::KafkaConsumerPipe::*)(char const*, unsigned 
long))
   ```
   
   1. It is hard to guaranteed that  msg is a C-style string ending in '\0' 
character. If not, it may cause the core dump to access memory out of bounds.
   2. It is not need to calculate the length of msg twice.
   
   Therefore,  deleting the logic that using strlen to calculate the length of 
msg.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](multi table) do not use strlen to calculate the length of msg [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40367:
URL: https://github.com/apache/doris/pull/40367#issuecomment-2328150175

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](multi table) do not use strlen to calculate the length of msg [doris]

2024-09-04 Thread via GitHub


sollhui commented on PR #40367:
URL: https://github.com/apache/doris/pull/40367#issuecomment-2328150469

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328153804

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [cherry-pick](branch-2.1) Pick "[Fix](group commit) Fix table not found fault when disable group commit (#39731)" [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40323:
URL: https://github.com/apache/doris/pull/40323#issuecomment-2328156814

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](agg-func) linear_histogram [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #39546:
URL: https://github.com/apache/doris/pull/39546#issuecomment-2328158493

   
   
   ClickBench: Total hot run time: 32.67 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 4f7ee867ea52ccbab68c59fae77f1e988d8aad89, 
data reload: false
   
   query1   0.050.040.04
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.670.090.08
   query5   0.530.500.50
   query6   1.130.730.74
   query7   0.020.020.02
   query8   0.040.040.04
   query9   0.540.480.49
   query10  0.550.550.55
   query11  0.160.110.12
   query12  0.160.120.13
   query13  0.610.590.58
   query14  2.052.082.04
   query15  0.900.830.83
   query16  0.370.360.37
   query17  1.061.001.01
   query18  0.210.200.21
   query19  1.961.771.86
   query20  0.010.000.01
   query21  15.43   0.680.67
   query22  4.057.222.53
   query23  18.27   1.431.26
   query24  2.080.240.22
   query25  0.140.080.08
   query26  0.270.180.18
   query27  0.080.080.07
   query28  13.27   1.031.01
   query29  12.62   3.373.41
   query30  0.250.060.06
   query31  2.870.400.41
   query32  3.240.490.48
   query33  2.953.012.97
   query34  16.99   4.424.34
   query35  4.454.434.43
   query36  0.660.480.49
   query37  0.190.160.15
   query38  0.150.140.15
   query39  0.040.030.04
   query40  0.160.120.14
   query41  0.090.050.05
   query42  0.050.050.05
   query43  0.050.040.04
   Total cold run time: 110.68 s
   Total hot run time: 32.67 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix]Add unused parameter timeout [doris]

2024-09-04 Thread via GitHub


wonderzerg commented on PR #40365:
URL: https://github.com/apache/doris/pull/40365#issuecomment-2328167575

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](OrcWriter) fix be core when upgrading BE without upgrading FE [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40282:
URL: https://github.com/apache/doris/pull/40282#issuecomment-2328168562

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](nereids) fix bug for A>n, where A.max is infinity #39936 [doris]

2024-09-04 Thread via GitHub


englefly opened a new pull request, #40368:
URL: https://github.com/apache/doris/pull/40368

   ## Proposed changes
   pick #39936 
   Issue Number: close #xxx
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhencement](sample) add delta and kudu samples [doris]

2024-09-04 Thread via GitHub


morningman merged PR #40067:
URL: https://github.com/apache/doris/pull/40067


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (0baa9366703 -> b2738496b79)

2024-09-04 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 0baa9366703 [test](mtmv) SSB mv rewrite test use little data set for 
test performance (#40188)
 add b2738496b79 [enhencement](sample) add delta and kudu samples (#40067)

No new revisions were added by this update.

Summary of changes:
 samples/datalake/deltalake_and_kudu/README.md  | 147 ++
 .../customer/_delta_log/.json  |   7 +
 ...110d-44ca-aed8-93ed65c19492-c000.snappy.parquet | Bin 0 -> 392744 bytes
 ...a84b-4e2c-9e6f-5ac6a59ee91d-c000.snappy.parquet | Bin 0 -> 392284 bytes
 ...bafd-46a7-b231-400a174b520c-c000.snappy.parquet | Bin 0 -> 390594 bytes
 ...ef95-4fbe-95c9-2012fd9dbaed-c000.snappy.parquet | Bin 0 -> 389205 bytes
 samples/datalake/deltalake_and_kudu/login-doris.sh |  20 ++
 samples/datalake/deltalake_and_kudu/login-spark.sh |  20 ++
 .../scripts/create-delta-table.sh  |  37 +++
 .../deltalake_and_kudu/scripts/doris-sql.sql   |  20 ++
 .../deltalake_and_kudu/scripts/spark-delta.sh  |  36 +++
 .../deltalake_and_kudu/scripts/spark-delta.sql |   1 +
 .../deltalake_and_kudu/scripts/start_doris.sh  |  28 ++
 .../start-trinoconnector-compose.sh| 181 
 .../stop-trinoconnector-compose.sh |  22 ++
 .../deltalake_and_kudu/trinoconnector-compose.env  |  22 ++
 .../deltalake_and_kudu/trinoconnector-compose.yml  | 323 +
 17 files changed, 864 insertions(+)
 create mode 100644 samples/datalake/deltalake_and_kudu/README.md
 create mode 100644 
samples/datalake/deltalake_and_kudu/data/customer/_delta_log/.json
 create mode 100644 
samples/datalake/deltalake_and_kudu/data/customer/part-0-44ff362c-110d-44ca-aed8-93ed65c19492-c000.snappy.parquet
 create mode 100644 
samples/datalake/deltalake_and_kudu/data/customer/part-1-749ded2d-a84b-4e2c-9e6f-5ac6a59ee91d-c000.snappy.parquet
 create mode 100644 
samples/datalake/deltalake_and_kudu/data/customer/part-2-137a1b68-bafd-46a7-b231-400a174b520c-c000.snappy.parquet
 create mode 100644 
samples/datalake/deltalake_and_kudu/data/customer/part-3-75203d54-ef95-4fbe-95c9-2012fd9dbaed-c000.snappy.parquet
 create mode 100755 samples/datalake/deltalake_and_kudu/login-doris.sh
 create mode 100755 samples/datalake/deltalake_and_kudu/login-spark.sh
 create mode 100644 
samples/datalake/deltalake_and_kudu/scripts/create-delta-table.sh
 create mode 100644 samples/datalake/deltalake_and_kudu/scripts/doris-sql.sql
 create mode 100755 samples/datalake/deltalake_and_kudu/scripts/spark-delta.sh
 create mode 100644 samples/datalake/deltalake_and_kudu/scripts/spark-delta.sql
 create mode 100755 samples/datalake/deltalake_and_kudu/scripts/start_doris.sh
 create mode 100755 
samples/datalake/deltalake_and_kudu/start-trinoconnector-compose.sh
 create mode 100755 
samples/datalake/deltalake_and_kudu/stop-trinoconnector-compose.sh
 create mode 100644 
samples/datalake/deltalake_and_kudu/trinoconnector-compose.env
 create mode 100644 
samples/datalake/deltalake_and_kudu/trinoconnector-compose.yml


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](nereids)support correlated scalar subquery without scalar agg [doris]

2024-09-04 Thread via GitHub


starocean999 commented on PR #39471:
URL: https://github.com/apache/doris/pull/39471#issuecomment-2328183874

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)let query be able to forwarded to master [doris]

2024-09-04 Thread via GitHub


starocean999 commented on PR #40119:
URL: https://github.com/apache/doris/pull/40119#issuecomment-2328189471

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40369:
URL: https://github.com/apache/doris/pull/40369#issuecomment-2328198894

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


w41ter commented on PR #40369:
URL: https://github.com/apache/doris/pull/40369#issuecomment-2328199018

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


w41ter opened a new pull request, #40369:
URL: https://github.com/apache/doris/pull/40369

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](regression-test) 👀 [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40370:
URL: https://github.com/apache/doris/pull/40370#issuecomment-2328200274

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](nereids)stats derive for min()/max() agg function [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40126:
URL: https://github.com/apache/doris/pull/40126#issuecomment-2328204078

   
   
   TPC-H: Total hot run time: 38205 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 736a5d4332daa025b8551ec5f8542b19cfff4589, 
data reload: false
   
   -- Round 1 --
   q1   17615   478842714271
   q2   2006181 175 175
   q3   11891   964 1156964
   q4   10531   670 680 670
   q5   7762286628072807
   q6   233 140 137 137
   q7   951 612 604 604
   q8   9316204820612048
   q9   7277657965716571
   q10  6993236222302230
   q11  438 241 245 241
   q12  402 218 228 218
   q13  19025   305330713053
   q14  279 239 241 239
   q15  544 492 481 481
   q16  599 508 503 503
   q17  987 726 735 726
   q18  7168682968456829
   q19  1388970 1080970
   q20  688 328 328 328
   q21  4370312831323128
   q22  1129102510121012
   Total cold run time: 111592 ms
   Total hot run time: 38205 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4393430842904290
   q2   373 274 278 274
   q3   2913264527382645
   q4   1976166416891664
   q5   5689567358035673
   q6   226 136 145 136
   q7   2223183718821837
   q8   3319346934893469
   q9   888488068806
   q10  3623340433753375
   q11  589 503 507 503
   q12  843 660 672 660
   q13  15255   325533033255
   q14  334 289 296 289
   q15  542 489 492 489
   q16  616 585 580 580
   q17  1864156315301530
   q18  8077780478187804
   q19  1721148116971481
   q20  2144191019381910
   q21  5719567756395639
   q22  1144106211041062
   Total cold run time: 72471 ms
   Total hot run time: 57371 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Featrue](default value) Support `bitmap_empty` default value [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40364:
URL: https://github.com/apache/doris/pull/40364#issuecomment-2328206287

   TeamCity be ut coverage result:
Function Coverage: 36.85% (9395/25495) 
Line Coverage: 28.28% (77470/273942)
Region Coverage: 27.68% (39985/144438)
Branch Coverage: 24.33% (20352/83642)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/71fe6708e4570bcaff8d3cdc60c3b830cfac11fb_71fe6708e4570bcaff8d3cdc60c3b830cfac11fb/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328206344

   TeamCity be ut coverage result:
Function Coverage: 36.84% (9393/25499) 
Line Coverage: 28.27% (77456/274035)
Region Coverage: 27.67% (39976/144487)
Branch Coverage: 24.31% (20341/83672)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e_9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](multi table) do not use strlen to calculate the length of msg [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40367:
URL: https://github.com/apache/doris/pull/40367#issuecomment-2328206480

   TeamCity be ut coverage result:
Function Coverage: 36.84% (9393/25495) 
Line Coverage: 28.28% (77477/273937)
Region Coverage: 27.67% (39968/144434)
Branch Coverage: 24.32% (20339/83640)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/434994907262cf5c00209eb9f5f2d9201ca2389b_434994907262cf5c00209eb9f5f2d9201ca2389b/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](scanner profile) More counter for scanner [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40144:
URL: https://github.com/apache/doris/pull/40144#issuecomment-2328207423

   TeamCity be ut coverage result:
Function Coverage: 36.83% (9392/25498) 
Line Coverage: 28.28% (77466/273956)
Region Coverage: 27.67% (39971/144439)
Branch Coverage: 24.32% (20338/83642)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/4d0909ff703ab02b5782bba3612d88429d201d1a_4d0909ff703ab02b5782bba3612d88429d201d1a/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](restore) support atomic restore [doris]

2024-09-04 Thread via GitHub


w41ter commented on PR #40353:
URL: https://github.com/apache/doris/pull/40353#issuecomment-2328208745

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Add config max_backup_tablets_per_job [doris-website]

2024-09-04 Thread via GitHub


w41ter merged PR #1056:
URL: https://github.com/apache/doris-website/pull/1056


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris-website) branch master updated: Add config max_backup_tablets_per_job (#1056)

2024-09-04 Thread w41ter
This is an automated email from the ASF dual-hosted git repository.

w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 33f260acaa Add config max_backup_tablets_per_job (#1056)
33f260acaa is described below

commit 33f260acaa5e9d64bebaa3555e77b4919b110ecd
Author: walter 
AuthorDate: Wed Sep 4 16:16:11 2024 +0800

Add config max_backup_tablets_per_job (#1056)
---
 docs/admin-manual/config/fe-config.md  | 12 +++-
 .../current/admin-manual/config/fe-config.md   | 10 ++
 .../version-2.0/admin-manual/config/fe-config.md   | 14 ++
 .../version-2.1/admin-manual/config/fe-config.md   | 14 ++
 .../version-3.0/admin-manual/config/fe-config.md   | 10 ++
 .../version-2.0/admin-manual/config/fe-config.md   | 14 ++
 .../version-2.1/admin-manual/config/fe-config.md   | 14 ++
 .../version-3.0/admin-manual/config/fe-config.md   | 12 +++-
 8 files changed, 98 insertions(+), 2 deletions(-)

diff --git a/docs/admin-manual/config/fe-config.md 
b/docs/admin-manual/config/fe-config.md
index ed546d125e..e2c93896af 100644
--- a/docs/admin-manual/config/fe-config.md
+++ b/docs/admin-manual/config/fe-config.md
@@ -2584,6 +2584,16 @@ Default: 10
 
 This configuration is mainly used to control the number of backup/restore 
tasks recorded in each database.
 
+ `max_backup_tablets_per_job`
+
+Default: 30
+
+IsMutable:true
+
+MasterOnly:true
+
+Control the max num of tablets per backup job involved, to avoid FE OOM caused 
by saving too much metadata.
+
  `enable_quantile_state_type`
 
 Default:false
@@ -2747,4 +2757,4 @@ To ensure compatibility with the MySQL ecosystem, Doris 
includes a built-in data
 
 Default value: 2000
 
-For auto-partitioned tables to prevent users from accidentally creating a 
large number of partitions, the number of partitions allowed per OLAP table is 
`max_auto_partition_num`. Default 2000.
\ No newline at end of file
+For auto-partitioned tables to prevent users from accidentally creating a 
large number of partitions, the number of partitions allowed per OLAP table is 
`max_auto_partition_num`. Default 2000.
diff --git 
a/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/config/fe-config.md
 
b/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/config/fe-config.md
index cc5354c53e..2b53ac8c56 100644
--- 
a/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/config/fe-config.md
+++ 
b/i18n/zh-CN/docusaurus-plugin-content-docs/current/admin-manual/config/fe-config.md
@@ -2583,6 +2583,16 @@ SmallFileMgr 中存储的最大文件数
 
 此配置用于控制每个 DB 能够记录的 backup/restore 任务的数量
 
+ `max_backup_tablets_per_job`
+
+默认值:30
+
+是否可以动态配置:true
+
+是否为 Master FE 节点独有的配置项:true
+
+此配置用于控制每个 backup job 最大涉及的 tablets 数量,以避免因保存过多元数据导致 FE OOM。
+
  `enable_quantile_state_type`
 
 默认值:false
diff --git 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.0/admin-manual/config/fe-config.md
 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.0/admin-manual/config/fe-config.md
index de8ad6320b..505113ccab 100644
--- 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.0/admin-manual/config/fe-config.md
+++ 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.0/admin-manual/config/fe-config.md
@@ -2584,6 +2584,20 @@ SmallFileMgr 中存储的最大文件数
 
 此配置用于控制每个 DB 能够记录的 backup/restore 任务的数量
 
+ `max_backup_tablets_per_job`
+
+默认值:30
+
+是否可以动态配置:true
+
+是否为 Master FE 节点独有的配置项:true
+
+此配置用于控制每个 backup job 最大涉及的 tablets 数量,以避免因保存过多元数据导致 FE OOM。
+
+:::tips 提示
+从 Apache Doris 2.0.15 开始支持该配置
+:::
+
  `enable_quantile_state_type`
 
 默认值:false
diff --git 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/config/fe-config.md
 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/config/fe-config.md
index c897069986..573eedb1b6 100644
--- 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/config/fe-config.md
+++ 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/admin-manual/config/fe-config.md
@@ -2611,6 +2611,20 @@ SmallFileMgr 中存储的最大文件数
 
 此配置用于控制每个 DB 能够记录的 backup/restore 任务的数量
 
+ `max_backup_tablets_per_job`
+
+默认值:30
+
+是否可以动态配置:true
+
+是否为 Master FE 节点独有的配置项:true
+
+此配置用于控制每个 backup job 最大涉及的 tablets 数量,以避免因保存过多元数据导致 FE OOM。
+
+:::tips 提示
+从 Apache Doris 2.1.6 开始支持该配置
+:::
+
  `enable_quantile_state_type`
 
 默认值:false
diff --git 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/admin-manual/config/fe-config.md
 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/admin-manual/config/fe-config.md
index cc5354c53e..2b53ac8c56 100644
--- 
a/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/admin-manual/config/fe-config.md
+++ 
b/i18n/zh-CN/docusaurus-plugin-content-docs/version-3.0/admin-manual/config/fe-co

Re: [PR] [improvement](mtmv) Optimize the materialized view hint info when explain [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #39998:
URL: https://github.com/apache/doris/pull/39998#issuecomment-2328219505

   
   
   TPC-H: Total hot run time: 38001 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c7778de9e85c375aee214c5e190ae5aea9ebddca, 
data reload: false
   
   -- Round 1 --
   q1   17605   437543234323
   q2   2020180 176 176
   q3   11704   101611661016
   q4   10517   676 765 676
   q5   7760285428282828
   q6   230 142 139 139
   q7   958 611 588 588
   q8   9364205820932058
   q9   7190652865416528
   q10  6995226922052205
   q11  459 238 237 237
   q12  394 218 221 218
   q13  17754   312931213121
   q14  284 242 231 231
   q15  532 496 486 486
   q16  610 533 528 528
   q17  983 700 692 692
   q18  7237678467916784
   q19  13941087967 967
   q20  688 337 335 335
   q21  3948299928682868
   q22  1133997 1009997
   Total cold run time: 109759 ms
   Total hot run time: 38001 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4334430342814281
   q2   371 280 285 280
   q3   2862264326612643
   q4   1918161616281616
   q5   5570571856885688
   q6   221 135 138 135
   q7   2286179218871792
   q8   3318342134443421
   q9   8873885288028802
   q10  3560335233653352
   q11  613 521 515 515
   q12  835 637 644 637
   q13  14608   323033523230
   q14  326 281 296 281
   q15  540 505 511 505
   q16  627 566 570 566
   q17  1833154215171517
   q18  8185791978697869
   q19  1717144715051447
   q20  2220190219051902
   q21  5754540252985298
   q22  1144105610941056
   Total cold run time: 71715 ms
   Total hot run time: 56833 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Featrue](default value) Support `bitmap_empty` default value [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40364:
URL: https://github.com/apache/doris/pull/40364#issuecomment-2328219511

   
   
   TPC-H: Total hot run time: 38011 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 71fe6708e4570bcaff8d3cdc60c3b830cfac11fb, 
data reload: false
   
   -- Round 1 --
   q1   17606   435042794279
   q2   2007182 175 175
   q3   12014   960 1140960
   q4   10515   751 697 697
   q5   7790282828262826
   q6   227 142 140 140
   q7   951 623 600 600
   q8   9334208720702070
   q9   7058650965596509
   q10  6981216822492168
   q11  455 236 238 236
   q12  405 232 233 232
   q13  17785   306330363036
   q14  282 247 238 238
   q15  517 484 485 484
   q16  584 526 524 524
   q17  971 597 711 597
   q18  7365689368206820
   q19  1394999 961 961
   q20  711 349 331 331
   q21  4191311431543114
   q22  1135101410231014
   Total cold run time: 110278 ms
   Total hot run time: 38011 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4401432243264322
   q2   382 270 274 270
   q3   2883266326002600
   q4   1934165816541654
   q5   5585565557095655
   q6   249 144 141 141
   q7   2235180718421807
   q8   3281345834303430
   q9   8850882688448826
   q10  3627341334153413
   q11  625 528 502 502
   q12  831 682 656 656
   q13  14406   316733273167
   q14  327 308 298 298
   q15  535 498 494 494
   q16  597 575 580 575
   q17  1826156815271527
   q18  8098783179407831
   q19  1745164516941645
   q20  2184189319571893
   q21  5821543654435436
   q22  1126103410821034
   Total cold run time: 71548 ms
   Total hot run time: 57176 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328221501

   
   
   TPC-H: Total hot run time: 37776 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, 
data reload: false
   
   -- Round 1 --
   q1   17607   443343424342
   q2   2018202 172 172
   q3   11642   934 1147934
   q4   10523   715 683 683
   q5   7735283027882788
   q6   224 139 144 139
   q7   947 607 598 598
   q8   9324204020822040
   q9   7119651664916491
   q10  7002219821742174
   q11  454 248 247 247
   q12  396 233 238 233
   q13  17766   303530793035
   q14  273 236 236 236
   q15  540 496 494 494
   q16  598 505 511 505
   q17  958 743 743 743
   q18  7321678069526780
   q19  1385105010381038
   q20  647 339 330 330
   q21  4025301327642764
   q22  1092102710101010
   Total cold run time: 109596 ms
   Total hot run time: 37776 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4325433342784278
   q2   372 280 275 275
   q3   2851260826252608
   q4   1941165516571655
   q5   5574564656895646
   q6   222 134 137 134
   q7   2295181418231814
   q8   3308342134213421
   q9   8834874287928742
   q10  3496337633533353
   q11  631 519 512 512
   q12  793 667 670 667
   q13  15168   324432993244
   q14  318 304 291 291
   q15  539 502 493 493
   q16  613 594 602 594
   q17  1838156615721566
   q18  8203779378327793
   q19  1733165914381438
   q20  2164191618821882
   q21  5680546854105410
   q22  1129105910641059
   Total cold run time: 72027 ms
   Total hot run time: 56875 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](scanner profile) More counter for scanner [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40144:
URL: https://github.com/apache/doris/pull/40144#issuecomment-2328224256

   
   
   TPC-H: Total hot run time: 43293 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 4d0909ff703ab02b5782bba3612d88429d201d1a, 
data reload: false
   
   -- Round 1 --
   q1   17616   464042994299
   q2   2029183 177 177
   q3   11159   114711991147
   q4   10572   766 740 740
   q5   7860420441724172
   q6   220 140 141 140
   q7   1106740 722 722
   q8   9380280027912791
   q9   8655747475257474
   q10  6999219621702170
   q11  465 254 263 254
   q12  430 247 254 247
   q13  17773   309130893089
   q14  285 243 244 243
   q15  541 502 499 499
   q16  596 504 498 498
   q17  1482129712941294
   q18  7590688470666884
   q19  13811015919 919
   q20  684 332 330 330
   q21  4834424541804180
   q22  1112102710241024
   Total cold run time: 112769 ms
   Total hot run time: 43293 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4332431243194312
   q2   397 278 273 273
   q3   2991287428642864
   q4   2004187718091809
   q5   5677565255815581
   q6   229 149 138 138
   q7   2295183118531831
   q8   3350346434223422
   q9   8774894288298829
   q10  3611330533573305
   q11  607 514 536 514
   q12  852 652 645 645
   q13  15331   330633063306
   q14  312 296 297 296
   q15  551 488 525 488
   q16  659 591 608 591
   q17  1822155115431543
   q18  8238794180387941
   q19  1758169115901590
   q20  2120190818881888
   q21  5776555853865386
   q22  1128107910551055
   Total cold run time: 72814 ms
   Total hot run time: 57607 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](nereids)stats derive for min()/max() agg function [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40126:
URL: https://github.com/apache/doris/pull/40126#issuecomment-2328229068

   
   
   TPC-DS: Total hot run time: 192719 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 736a5d4332daa025b8551ec5f8542b19cfff4589, 
data reload: false
   
   query1   1247880 864 864
   query2   6479195819941958
   query3   10713   406741174067
   query4   60012   26607   23183   23183
   query5   5394510 528 510
   query6   398 164 174 164
   query7   5825309 297 297
   query8   290 208 214 208
   query9   9010252525232523
   query10  503 277 282 277
   query11  18215   15041   15530   15041
   query12  149 108 100 100
   query13  1553395 380 380
   query14  11249   686665256525
   query15  246 189 172 172
   query16  7549470 448 448
   query17  1143579 589 579
   query18  2019301 308 301
   query19  307 170 144 144
   query20  126 112 110 110
   query21  213 104 106 104
   query22  4639447546634475
   query23  34425   33340   33493   33340
   query24  5995291029212910
   query25  525 383 372 372
   query26  684 153 157 153
   query27  1799278 275 275
   query28  3834205320382038
   query29  687 400 408 400
   query30  246 151 157 151
   query31  915 765 712 712
   query32  84  52  55  52
   query33  473 297 288 288
   query34  864 485 475 475
   query35  819 740 731 731
   query36  1059930 930 930
   query37  149 95  84  84
   query38  4060393839033903
   query39  1473140013891389
   query40  203 113 118 113
   query41  49  48  47  47
   query42  117 98  99  98
   query43  517 480 485 480
   query44  1063739 739 739
   query45  201 168 169 168
   query46  1088780 727 727
   query47  1899182518101810
   query48  380 307 305 305
   query49  775 445 444 444
   query50  819 422 425 422
   query51  7050688569036885
   query52  101 86  91  86
   query53  262 185 180 180
   query54  570 463 450 450
   query55  74  74  76  74
   query56  290 265 260 260
   query57  1235109610981096
   query58  232 243 244 243
   query59  3049281328482813
   query60  304 280 295 280
   query61  129 121 122 121
   query62  766 662 662 662
   query63  222 185 189 185
   query64  2955764 747 747
   query65  3211319431463146
   query66  685 356 359 356
   query67  15390   15243   15320   15243
   query68  3169592 594 592
   query69  399 292 287 287
   query70  1171113210671067
   query71  370 285 281 281
   query72  6490405440544054
   query73  753 332 326 326
   query74  9110891288408840
   query75  3336268726392639
   query76  1424105810051005
   query77  552 326 309 309
   query78  9636914097969140
   query79  1646538 531 531
   query80  831 519 508 508
   query81  541 238 234 234
   query82  380 146 146 146
   query83  167 148 152 148
   query84  265 76  74  74
   query85  814 279 276 276
   query86  317 303 283 283
   query87  4359435342914291
   query88  2995234823402340
   query89  404 287 286 286
   query90  1888195 188 188
   query91  122 99  99  99
   query92  68  50  50  50
   query93  1106532 531 531
   query94  829 287 300 287
   query95  338 256 247 247
   query96  590 264 265 264
   query97  3230310731073107
   query98  218 206 204 204
   query99  1761127212891272
   Total cold run time: 308285 ms
   Total hot run time: 192719 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [opt](in expr) Optimize the IN expression by skipping constant columns. [doris]

2024-09-04 Thread via GitHub


BiteThet merged PR #39912:
URL: https://github.com/apache/doris/pull/39912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (b2738496b79 -> 5eab877c890)

2024-09-04 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository.

panxiaolei pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from b2738496b79 [enhencement](sample) add delta and kudu samples (#40067)
 add 5eab877c890 [opt](in expr) Optimize the IN expression by skipping 
constant columns. (#39912)

No new revisions were added by this update.

Summary of changes:
 be/src/vec/exprs/vexpr.h  |  1 -
 be/src/vec/exprs/vin_predicate.cpp| 27 ---
 be/src/vec/exprs/vin_predicate.h  |  4 
 be/src/vec/functions/function_collection_in.h |  5 ++---
 4 files changed, 30 insertions(+), 7 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](cluster key) fix mow cluster key with schema change [doris]

2024-09-04 Thread via GitHub


mymeiyi opened a new pull request, #40372:
URL: https://github.com/apache/doris/pull/40372

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40372:
URL: https://github.com/apache/doris/pull/40372#issuecomment-2328235913

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Featrue](default value) Support `bitmap_empty` default value [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40364:
URL: https://github.com/apache/doris/pull/40364#issuecomment-2328245613

   
   
   TPC-DS: Total hot run time: 192907 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 71fe6708e4570bcaff8d3cdc60c3b830cfac11fb, 
data reload: false
   
   query1   1242864 875 864
   query2   6311199720191997
   query3   10731   399939763976
   query4   60340   26489   23059   23059
   query5   5348505 506 505
   query6   410 171 171 171
   query7   5795293 288 288
   query8   283 202 197 197
   query9   9059248324842483
   query10  479 270 255 255
   query11  17619   14908   15388   14908
   query12  145 104 101 101
   query13  1558429 411 411
   query14  10085   723872897238
   query15  249 166 182 166
   query16  7620454 512 454
   query17  1114586 572 572
   query18  2028293 292 292
   query19  295 148 145 145
   query20  125 107 110 107
   query21  206 110 104 104
   query22  4781475648114756
   query23  34279   33240   33389   33240
   query24  5975285129012851
   query25  525 383 405 383
   query26  694 162 176 162
   query27  1771279 278 278
   query28  3717205620412041
   query29  692 404 409 404
   query30  233 153 144 144
   query31  953 765 737 737
   query32  83  49  57  49
   query33  463 286 276 276
   query34  866 475 485 475
   query35  831 751 718 718
   query36  1043923 944 923
   query37  143 92  87  87
   query38  3956391438123812
   query39  1585141413901390
   query40  197 113 111 111
   query41  46  45  43  43
   query42  111 99  94  94
   query43  522 462 479 462
   query44  1103740 735 735
   query45  205 168 163 163
   query46  1082748 728 728
   query47  1935185918431843
   query48  387 310 301 301
   query49  766 441 446 441
   query50  800 442 442 442
   query51  7025681167586758
   query52  100 88  86  86
   query53  247 178 177 177
   query54  576 471 456 456
   query55  78  73  73  73
   query56  292 268 266 266
   query57  1207108810671067
   query58  226 255 247 247
   query59  3080271728002717
   query60  289 276 277 276
   query61  125 123 120 120
   query62  735 667 665 665
   query63  223 186 185 185
   query64  2936746 748 746
   query65  3205317932003179
   query66  686 348 348 348
   query67  15487   15304   15252   15252
   query68  3072596 609 596
   query69  421 285 289 285
   query70  1202116410931093
   query71  362 284 278 278
   query72  6517410340634063
   query73  746 325 333 325
   query74  9216879587878787
   query75  3343269327092693
   query76  1447105510331033
   query77  520 325 326 325
   query78  9853936491779177
   query79  1071530 540 530
   query80  947 508 503 503
   query81  561 240 233 233
   query82  239 137 141 137
   query83  168 144 146 144
   query84  265 75  72  72
   query85  938 279 278 278
   query86  388 295 292 292
   query87  4374425441654165
   query88  3117236323632363
   query89  382 288 289 288
   query90  1825193 187 187
   query91  121 99  106 99
   query92  60  50  48  48
   query93  1468537 545 537
   query94  770 288 291 288
   query95  343 250 254 250
   query96  600 272 279 272
   query97  3217309330763076
   query98  219 196 205 196
   query99  1631132312941294
   Total cold run time: 306706 ms
   Total hot run time: 192907 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to

Re: [PR] [improvement](mtmv) Optimize the materialized view hint info when explain [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #39998:
URL: https://github.com/apache/doris/pull/39998#issuecomment-2328245682

   
   
   TPC-DS: Total hot run time: 194272 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c7778de9e85c375aee214c5e190ae5aea9ebddca, 
data reload: false
   
   query1   1240900 874 874
   query2   6396193418981898
   query3   10599   394440253944
   query4   59393   24399   23039   23039
   query5   5486518 506 506
   query6   424 188 179 179
   query7   5771311 296 296
   query8   288 202 201 201
   query9   8744250524892489
   query10  473 278 264 264
   query11  18122   15002   15205   15002
   query12  164 110 110 110
   query13  1562392 392 392
   query14  10161   737273097309
   query15  233 180 193 180
   query16  7607421 470 421
   query17  1251576 583 576
   query18  2069292 286 286
   query19  309 145 149 145
   query20  118 109 109 109
   query21  208 106 103 103
   query22  4588449044374437
   query23  34125   34024   33539   33539
   query24  6003284028182818
   query25  521 388 372 372
   query26  694 155 156 155
   query27  1788284 274 274
   query28  3653205820372037
   query29  685 407 409 407
   query30  239 151 156 151
   query31  938 744 795 744
   query32  83  48  55  48
   query33  496 282 282 282
   query34  853 477 475 475
   query35  837 732 707 707
   query36  1039928 952 928
   query37  154 91  87  87
   query38  3999389339003893
   query39  1462140013991399
   query40  194 120 117 117
   query41  48  49  47  47
   query42  118 92  94  92
   query43  497 479 467 467
   query44  1103740 744 740
   query45  194 166 165 165
   query46  1092732 737 732
   query47  1898179918191799
   query48  376 304 309 304
   query49  763 436 448 436
   query50  821 405 421 405
   query51  6984689568226822
   query52  100 85  91  85
   query53  254 179 179 179
   query54  586 459 463 459
   query55  85  81  74  74
   query56  286 263 271 263
   query57  1193107910551055
   query58  243 236 245 236
   query59  2986284228782842
   query60  304 281 285 281
   query61  122 118 117 117
   query62  744 647 654 647
   query63  224 195 185 185
   query64  2932781 748 748
   query65  3234313631493136
   query66  638 348 347 347
   query67  15431   15207   15124   15124
   query68  3203581 583 581
   query69  402 285 288 285
   query70  1144114111141114
   query71  348 290 277 277
   query72  6503415242194152
   query73  738 322 324 322
   query74  9222881388648813
   query75  3418270126462646
   query76  15241013956 956
   query77  521 323 313 313
   query78  11378   11018   10602   10602
   query79  1250537 530 530
   query80  967 528 507 507
   query81  576 233 234 233
   query82  285 145 147 145
   query83  280 147 154 147
   query84  269 78  77  77
   query85  736 275 280 275
   query86  423 290 269 269
   query87  4536439942214221
   query88  3114233523372335
   query89  381 278 279 278
   query90  2000190 191 190
   query91  127 104 100 100
   query92  61  50  52  50
   query93  1072535 536 535
   query94  789 294 297 294
   query95  346 284 251 251
   query96  590 261 269 261
   query97  3258314730903090
   query98  219 203 197 197
   query99  1558130112461246
   Total cold run time: 307463 ms
   Total hot run time: 194272 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t

Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328247721

   
   
   TPC-DS: Total hot run time: 193148 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, 
data reload: false
   
   query1   1251889 862 862
   query2   6354188118461846
   query3   10604   397540333975
   query4   59649   25867   23491   23491
   query5   5407507 489 489
   query6   407 173 165 165
   query7   5871305 288 288
   query8   285 216 214 214
   query9   9119251425052505
   query10  504 285 260 260
   query11  17179   15102   15427   15102
   query12  146 103 99  99
   query13  1571403 377 377
   query14  11107   759072957295
   query15  246 172 183 172
   query16  7444479 463 463
   query17  1167584 585 584
   query18  1808302 309 302
   query19  283 171 156 156
   query20  120 113 118 113
   query21  210 106 109 106
   query22  4522440144524401
   query23  34309   33578   33720   33578
   query24  5906289128552855
   query25  557 410 391 391
   query26  686 154 156 154
   query27  1801286 279 279
   query28  3895205520312031
   query29  683 424 433 424
   query30  242 155 152 152
   query31  933 767 792 767
   query32  83  54  54  54
   query33  484 301 291 291
   query34  842 479 477 477
   query35  831 732 750 732
   query36  1075941 914 914
   query37  149 101 93  93
   query38  4053390839353908
   query39  1449139513871387
   query40  196 115 116 115
   query41  47  50  45  45
   query42  125 96  99  96
   query43  506 452 486 452
   query44  1102743 751 743
   query45  196 166 166 166
   query46  1105749 754 749
   query47  1916179018381790
   query48  378 303 295 295
   query49  764 437 439 437
   query50  806 424 426 424
   query51  6947699968926892
   query52  99  94  93  93
   query53  254 176 181 176
   query54  578 468 465 465
   query55  76  78  77  77
   query56  293 264 276 264
   query57  1177106310871063
   query58  226 273 228 228
   query59  2974280027922792
   query60  305 282 302 282
   query61  126 124 120 120
   query62  775 656 654 654
   query63  214 193 192 192
   query64  2989663 699 663
   query65  3185313731803137
   query66  698 339 342 339
   query67  15291   15211   15057   15057
   query68  4405569 557 557
   query69  429 283 296 283
   query70  1192107210441044
   query71  370 279 284 279
   query72  6562397539413941
   query73  739 319 329 319
   query74  9319886289268862
   query75  3325266526932665
   query76  17401068983 983
   query77  529 321 316 316
   query78  10533   909390789078
   query79  1174532 544 532
   query80  784 499 545 499
   query81  562 234 236 234
   query82  251 138 146 138
   query83  223 148 147 147
   query84  260 74  88  74
   query85  838 295 275 275
   query86  363 300 289 289
   query87  4448424343294243
   query88  3869236023352335
   query89  380 289 279 279
   query90  2007191 192 191
   query91  123 99  103 99
   query92  57  50  51  50
   query93  1146535 538 535
   query94  761 337 294 294
   query95  354 256 248 248
   query96  579 264 269 264
   query97  3183311030863086
   query98  216 214 199 199
   query99  1779129712521252
   Total cold run time: 309080 ms
   Total hot run time: 193148 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t

Re: [PR] [fix](nereids)let query be able to forwarded to master [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40119:
URL: https://github.com/apache/doris/pull/40119#issuecomment-2328250887

   
   
   TPC-H: Total hot run time: 37878 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a367a749e0a3be52041ee371d3bef439b5078dc3, 
data reload: false
   
   -- Round 1 --
   q1   17619   465043184318
   q2   2016183 169 169
   q3   11472   958 1102958
   q4   10416   708 673 673
   q5   7769283128102810
   q6   226 136 138 136
   q7   953 607 605 605
   q8   9322204420752044
   q9   7037654365556543
   q10  7015220321722172
   q11  460 241 239 239
   q12  398 229 226 226
   q13  17761   304230763042
   q14  275 236 233 233
   q15  523 498 506 498
   q16  621 515 523 515
   q17  974 707 685 685
   q18  7476686768076807
   q19  1386103310241024
   q20  655 332 347 332
   q21  4375282129682821
   q22  1131108610281028
   Total cold run time: 109880 ms
   Total hot run time: 37878 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4367427942634263
   q2   369 272 276 272
   q3   2865266626652665
   q4   1912159216551592
   q5   5614567356715671
   q6   224 136 146 136
   q7   2281178418251784
   q8   3289340434413404
   q9   8823885988668859
   q10  3585335833923358
   q11  610 503 536 503
   q12  810 691 685 685
   q13  15365   324132693241
   q14  334 302 296 296
   q15  551 487 506 487
   q16  601 604 585 585
   q17  1829154915431543
   q18  8170783178157815
   q19  1930161915801580
   q20  2194195019001900
   q21  5799548054765476
   q22  1121104110231023
   Total cold run time: 72643 ms
   Total hot run time: 57138 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328259463

   
   
   ClickBench: Total hot run time: 32.29 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.680.080.08
   query5   0.510.490.50
   query6   1.140.730.73
   query7   0.020.010.01
   query8   0.050.040.05
   query9   0.550.470.48
   query10  0.540.540.55
   query11  0.160.120.11
   query12  0.150.120.12
   query13  0.620.590.58
   query14  2.102.052.06
   query15  0.900.820.84
   query16  0.350.380.38
   query17  1.051.051.06
   query18  0.210.210.21
   query19  1.841.731.81
   query20  0.020.010.01
   query21  15.40   0.680.66
   query22  4.237.171.89
   query23  18.27   1.361.41
   query24  1.860.290.23
   query25  0.140.090.08
   query26  0.280.180.18
   query27  0.070.090.07
   query28  13.24   1.031.01
   query29  12.62   3.393.39
   query30  0.240.060.05
   query31  2.880.410.40
   query32  3.230.480.48
   query33  2.983.073.03
   query34  17.16   4.414.42
   query35  4.444.444.42
   query36  0.660.500.49
   query37  0.180.150.16
   query38  0.160.160.15
   query39  0.060.030.04
   query40  0.160.130.13
   query41  0.090.040.05
   query42  0.060.050.05
   query43  0.040.040.04
   Total cold run time: 110.69 s
   Total hot run time: 32.29 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


gavinchou commented on code in PR #40369:
URL: https://github.com/apache/doris/pull/40369#discussion_r1743317902


##
cloud/src/common/bvars.cpp:
##
@@ -177,6 +177,7 @@ bvar::Status 
g_bvar_fdb_workload_transactions_committed_hz(
 "fdb_workload_transactions_committed_hz", BVAR_FDB_INVALID_VALUE);
 bvar::Status g_bvar_fdb_workload_transactions_rejected_hz(
 "fdb_workload_transactions_rejected_hz", BVAR_FDB_INVALID_VALUE);
+bvar::Status 
g_bvar_fdb_client_thread_busyness("fdb_client_thread_busyness", 0.0);

Review Comment:
   make it an integer, consider naming something related to 'percent'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](array/map) Fix semi-structure data column [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40363:
URL: https://github.com/apache/doris/pull/40363#issuecomment-2328269801

   
   
   TPC-H: Total hot run time: 38215 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 99150632e24ee70221d0bbdf81ec5a7bb51b0b5b, 
data reload: false
   
   -- Round 1 --
   q1   17623   454742934293
   q2   2028179 178 178
   q3   11800   968 1161968
   q4   10509   757 667 667
   q5   7762283328202820
   q6   231 142 139 139
   q7   962 618 604 604
   q8   9307207920632063
   q9   7179651765576517
   q10  6994221421582158
   q11  444 246 241 241
   q12  400 226 221 221
   q13  17757   308430663066
   q14  284 232 231 231
   q15  531 490 498 490
   q16  587 517 504 504
   q17  988 793 750 750
   q18  7355683269386832
   q19  1374115210561056
   q20  684 328 325 325
   q21  4301307631963076
   q22  1148101810161016
   Total cold run time: 110248 ms
   Total hot run time: 38215 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4350431042724272
   q2   389 279 263 263
   q3   2869261627012616
   q4   1949166416171617
   q5   5628564356945643
   q6   236 138 143 138
   q7   2245181218081808
   q8   3317343134413431
   q9   8828882787508750
   q10  3575339333563356
   q11  620 504 505 504
   q12  842 666 626 626
   q13  14740   325032353235
   q14  317 296 298 296
   q15  540 513 501 501
   q16  637 588 592 588
   q17  1847153515561535
   q18  8311782380317823
   q19  1745163415891589
   q20  2158195719441944
   q21  5744554853555355
   q22  1143107010481048
   Total cold run time: 72030 ms
   Total hot run time: 56938 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [debug][don't merge] add debug logs for DORIS-14951 [doris]

2024-09-04 Thread via GitHub


kaijchen opened a new pull request, #40373:
URL: https://github.com/apache/doris/pull/40373

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Disable sql_limit variable when query rewrite by materialize view [doris]

2024-09-04 Thread via GitHub


seawinde commented on PR #40106:
URL: https://github.com/apache/doris/pull/40106#issuecomment-2328283382

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](nereids)let query be able to forwarded to master [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40119:
URL: https://github.com/apache/doris/pull/40119#issuecomment-2328287843

   
   
   ClickBench: Total hot run time: 31.71 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a367a749e0a3be52041ee371d3bef439b5078dc3, 
data reload: false
   
   query1   0.050.040.04
   query2   0.080.040.03
   query3   0.220.050.05
   query4   1.680.080.07
   query5   0.520.510.48
   query6   1.140.730.72
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.550.470.47
   query10  0.530.520.52
   query11  0.160.120.11
   query12  0.150.120.12
   query13  0.610.580.58
   query14  2.112.082.10
   query15  0.900.810.84
   query16  0.370.370.36
   query17  1.001.001.04
   query18  0.220.200.20
   query19  1.781.711.76
   query20  0.010.000.01
   query21  15.39   0.680.67
   query22  4.027.891.60
   query23  18.22   1.361.30
   query24  2.080.240.23
   query25  0.150.080.09
   query26  0.280.180.18
   query27  0.080.070.07
   query28  13.21   1.011.02
   query29  12.61   3.403.40
   query30  0.240.070.05
   query31  2.890.390.40
   query32  3.250.490.48
   query33  3.033.022.98
   query34  17.06   4.374.42
   query35  4.434.474.45
   query36  0.660.480.47
   query37  0.180.150.16
   query38  0.160.150.15
   query39  0.050.040.04
   query40  0.160.120.13
   query41  0.090.050.05
   query42  0.050.040.05
   query43  0.040.040.03
   Total cold run time: 110.48 s
   Total hot run time: 31.71 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Compatibility](agg-state) add be_exec_version check to avoid aggregation data format changed le… [doris]

2024-09-04 Thread via GitHub


BiteThet commented on PR #40193:
URL: https://github.com/apache/doris/pull/40193#issuecomment-2328290333

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [debug][don't merge] add debug logs for DORIS-14951 [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40373:
URL: https://github.com/apache/doris/pull/40373#issuecomment-2328298409

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feat]reserve and spill [doris]

2024-09-04 Thread via GitHub


yiguolei commented on code in PR #39883:
URL: https://github.com/apache/doris/pull/39883#discussion_r1743344841


##
be/src/pipeline/exec/aggregation_sink_operator.cpp:
##
@@ -394,6 +399,9 @@ Status 
AggSinkLocalState::_merge_with_serialized_key_helper(vectorized::Block* b
 Status AggSinkLocalState::_merge_without_key(vectorized::Block* block) {
 SCOPED_TIMER(_merge_timer);
 DCHECK(_agg_data->without_key != nullptr);
+
+_memory_usage_last_executing = 0;
+ScopedMemTracker mem_tracker(_memory_usage_last_executing);

Review Comment:
   不要这么定义,参考SCOPED_TIMER。
   定义一个宏,然后传入一个counter的指针。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [debug][don't merge] add debug logs for DORIS-14951 [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40373:
URL: https://github.com/apache/doris/pull/40373#issuecomment-2328311780

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


Mryange commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328332834

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc [doris]

2024-09-04 Thread via GitHub


kaijchen commented on PR #40074:
URL: https://github.com/apache/doris/pull/40074#issuecomment-2328342522

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feat](nereids) support pull up predicate from set operator [doris]

2024-09-04 Thread via GitHub


feiniaofeiafei commented on PR #39450:
URL: https://github.com/apache/doris/pull/39450#issuecomment-2328343784

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](brpc_client_cache) resolve hostname in DNS cache before passing to brpc [doris]

2024-09-04 Thread via GitHub


kaijchen commented on PR #40074:
URL: https://github.com/apache/doris/pull/40074#issuecomment-2328347688

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Generate mtmv cache should use ADMIN user, and rewritten plan should not check policy [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40374:
URL: https://github.com/apache/doris/pull/40374#issuecomment-2328348667

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Generate mtmv cache should use ADMIN user, and rewritten plan should not check privilege [doris]

2024-09-04 Thread via GitHub


seawinde commented on PR #40374:
URL: https://github.com/apache/doris/pull/40374#issuecomment-2328350810

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhancement](show) Move storage policy info from show create table to show partitions [doris]

2024-09-04 Thread via GitHub


TangSiyang2001 commented on PR #39923:
URL: https://github.com/apache/doris/pull/39923#issuecomment-2328358770

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](aes_encrypt) support GCM mode for aes_encrypt and aes_decrypt [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40004:
URL: https://github.com/apache/doris/pull/40004#issuecomment-2328367207

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Opt](delete) Skip newly inserted rows check in non-strict mode partial update if the row's delete sign is marked [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40322:
URL: https://github.com/apache/doris/pull/40322#issuecomment-2328371343

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Revert "[fix](compaction) fix the longest continuous rowsets cannot be selected when missing rowsets (#38728) (#39262)" [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40375:
URL: https://github.com/apache/doris/pull/40375#issuecomment-2328373508

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](nereids)support correlated scalar subquery without scalar agg [doris]

2024-09-04 Thread via GitHub


morrySnow commented on code in PR #39471:
URL: https://github.com/apache/doris/pull/39471#discussion_r1743263010


##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FillUpMissingSlots.java:
##
@@ -274,7 +304,8 @@ public void resolve(Expression expression) {
 // We couldn't find the equivalent expression in output 
expressions and group-by expressions,
 // so we should check whether the expression is valid.
 if (expression instanceof SlotReference) {
-if (checkSlot) {
+if (checkSlot && (!outerScope.isPresent()
+|| 
!outerScope.get().getCorrelatedSlots().contains(expression))) {

Review Comment:
   add some comments



##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/AlwaysNotNullable.java:
##
@@ -27,4 +30,10 @@ public interface AlwaysNotNullable extends ComputeNullable {
 default boolean nullable() {
 return false;
 }
+
+// return value of this function if the input data is empty.
+// for example, count(*) of empty table is 0;
+default Expression resultForEmptyInput() {
+throw new AnalysisException("should implement resultForEmptyInput() 
for " + this.getClass());
+}

Review Comment:
   remove default impl



##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/FillUpMissingSlots.java:
##
@@ -59,14 +60,18 @@ public List buildRules() {
 return ImmutableList.of(
 RuleType.FILL_UP_SORT_PROJECT.build(
 logicalSort(logicalProject())
-.then(sort -> {
+.thenApply(ctx -> {
+LogicalSort> sort = ctx.root;
+Optional outerScope = 
ctx.cascadesContext.getOuterScope();
 LogicalProject project = sort.child();
 Set projectOutputSet = project.getOutputSet();
 Set notExistedInProject = 
sort.getOrderKeys().stream()
 .map(OrderKey::getExpr)
 .map(Expression::getInputSlots)
 .flatMap(Set::stream)
-.filter(s -> !projectOutputSet.contains(s))
+.filter(s -> !projectOutputSet.contains(s)
+&& (!outerScope.isPresent() || 
!outerScope.get()
+
.getCorrelatedSlots().contains(s)))

Review Comment:
   add some comments?



##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/MapAgg.java:
##
@@ -69,4 +71,9 @@ public MapAgg withDistinctAndChildren(boolean distinct, 
List childre
 public List getSignatures() {
 return SIGNATURES;
 }
+
+@Override
+public Expression resultForEmptyInput() {
+return new MapLiteral(new ArrayList<>(), new ArrayList<>(), 
this.getDataType());

Review Comment:
   ditto



##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/CollectSet.java:
##
@@ -101,4 +103,9 @@ public  R accept(ExpressionVisitor visitor, C 
context) {
 public List getSignatures() {
 return SIGNATURES;
 }
+
+@Override
+public Expression resultForEmptyInput() {
+return new ArrayLiteral(new ArrayList<>(), this.getDataType());

Review Comment:
   ditto



##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/GroupArrayIntersect.java:
##
@@ -73,4 +75,9 @@ public  R accept(ExpressionVisitor visitor, C 
context) {
 public List getSignatures() {
 return SIGNATURES;
 }
+
+@Override
+public Expression resultForEmptyInput() {
+return new ArrayLiteral(new ArrayList<>(), this.getDataType());

Review Comment:
   ditto



##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalProject.java:
##
@@ -192,7 +194,15 @@ public List getOutputs() {
 
 @Override
 public Plan pruneOutputs(List prunedOutputs) {
-return withProjects(prunedOutputs);
+List allProjects = new ArrayList<>(prunedOutputs);
+for (NamedExpression expression : projects) {
+if (expression.containsType(NoneMovableFunction.class)) {
+if (!prunedOutputs.contains(expression)) {
+allProjects.add(expression);
+}
+}
+}
+return withProjects(allProjects);

Review Comment:
   could we first generate need added NoneMovableFunction list, use new list 
only if NoneMovableFunction list is not empty?



##
regression-test/suites/nereids_p0/subquery/correlated_scalar_subquery.groovy:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem

Re: [PR] [fix](mtmv) Fix written by mv successfully but not get mv lock. If use mv, data maybe wrong [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40173:
URL: https://github.com/apache/doris/pull/40173#issuecomment-2328377791

   
   
   TPC-DS: Total hot run time: 187502 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit fa6df865ec728ac1e5d449b81523abea492cc1bd, 
data reload: false
   
   query1   912 373 367 367
   query2   6488192619281926
   query3   6656210 215 210
   query4   26831   23153   23025   23025
   query5   4160504 498 498
   query6   254 166 165 165
   query7   4591294 298 294
   query8   242 205 201 201
   query9   8617250325002500
   query10  434 264 262 262
   query11  17850   14979   15135   14979
   query12  144 103 107 103
   query13  1628367 378 367
   query14  10026   643568776435
   query15  291 167 176 167
   query16  7946462 445 445
   query17  1574562 576 562
   query18  2120283 282 282
   query19  197 137 144 137
   query20  116 108 105 105
   query21  211 103 103 103
   query22  4526454243894389
   query23  34088   33425   33220   33220
   query24  11133   289628382838
   query25  630 378 390 378
   query26  1219150 155 150
   query27  2341281 283 281
   query28  7245206720452045
   query29  823 415 425 415
   query30  307 159 154 154
   query31  997 781 796 781
   query32  101 53  56  53
   query33  773 309 272 272
   query34  996 469 478 469
   query35  882 723 716 716
   query36  1076947 919 919
   query37  168 95  84  84
   query38  4043398138213821
   query39  1455144014011401
   query40  204 117 111 111
   query41  46  48  45  45
   query42  122 96  100 96
   query43  517 473 480 473
   query44  1214750 748 748
   query45  197 171 171 171
   query46  1094764 743 743
   query47  1877178018191780
   query48  369 303 301 301
   query49  1088423 424 423
   query50  803 420 405 405
   query51  6887690569096905
   query52  99  86  85  85
   query53  253 186 184 184
   query54  1014457 466 457
   query55  75  74  80  74
   query56  286 264 246 246
   query57  1213105410751054
   query58  252 224 222 222
   query59  2941272129292721
   query60  290 264 265 264
   query61  101 101 103 101
   query62  835 646 674 646
   query63  216 178 185 178
   query64  4252710 646 646
   query65  3202315531273127
   query66  1424336 354 336
   query67  15748   15421   15441   15421
   query68  3297582 589 582
   query69  402 275 283 275
   query70  1167105610831056
   query71  334 277 260 260
   query72  6473415141854151
   query73  733 324 334 324
   query74  9190892988268826
   query75  3394270226352635
   query76  1961995 1068995
   query77  484 321 325 321
   query78  9812920991089108
   query79  1021540 521 521
   query80  733 525 603 525
   query81  597 237 232 232
   query82  249 140 147 140
   query83  219 151 150 150
   query84  223 75  78  75
   query85  911 286 283 283
   query86  323 294 298 294
   query87  4527436143254325
   query88  3173237824222378
   query89  370 286 287 286
   query90  1896193 183 183
   query91  122 102 101 101
   query92  63  49  47  47
   query93  1015547 540 540
   query94  954 298 286 286
   query95  362 252 251 251
   query96  582 264 269 264
   query97  3260310231013101
   query98  227 221 208 208
   query99  1657130412971297
   Total cold run time: 280441 ms
   Total hot run time: 187502 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to 

Re: [PR] [fix](Nereids) handle continuous filter or project in plan [doris]

2024-09-04 Thread via GitHub


morrySnow commented on PR #40176:
URL: https://github.com/apache/doris/pull/40176#issuecomment-2328381047

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Revert "[fix](compaction) fix the longest continuous rowsets cannot be selected when missing rowsets (#38728) (#39262)" [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40375:
URL: https://github.com/apache/doris/pull/40375#issuecomment-2328385135

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Fix written by mv successfully but not get mv lock. If use mv, data maybe wrong [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40173:
URL: https://github.com/apache/doris/pull/40173#issuecomment-2328389114

   
   
   ClickBench: Total hot run time: 32.12 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit fa6df865ec728ac1e5d449b81523abea492cc1bd, 
data reload: false
   
   query1   0.040.040.04
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.680.090.09
   query5   0.500.490.51
   query6   1.120.730.72
   query7   0.020.010.02
   query8   0.050.040.05
   query9   0.550.470.49
   query10  0.540.550.54
   query11  0.150.110.12
   query12  0.140.120.13
   query13  0.600.580.58
   query14  2.102.062.06
   query15  0.910.810.82
   query16  0.380.380.36
   query17  1.061.050.99
   query18  0.230.210.20
   query19  1.851.741.75
   query20  0.010.020.01
   query21  15.40   0.660.67
   query22  4.377.112.14
   query23  18.28   1.401.23
   query24  2.070.210.24
   query25  0.150.090.08
   query26  0.290.180.17
   query27  0.080.070.08
   query28  13.28   1.031.01
   query29  12.59   3.263.27
   query30  0.250.050.05
   query31  2.870.400.39
   query32  3.260.490.48
   query33  2.943.022.97
   query34  17.03   4.394.42
   query35  4.494.494.47
   query36  0.650.480.49
   query37  0.180.150.15
   query38  0.150.150.15
   query39  0.050.040.03
   query40  0.160.120.13
   query41  0.090.050.05
   query42  0.060.050.05
   query43  0.040.040.04
   Total cold run time: 110.97 s
   Total hot run time: 32.12 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Disable sql_limit variable when query rewrite by materialize view [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40106:
URL: https://github.com/apache/doris/pull/40106#issuecomment-2328389524

   
   
   ClickBench: Total hot run time: 32.04 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 17238e654faff8ea606944968ff7c95d5bd5e00f, 
data reload: false
   
   query1   0.050.050.04
   query2   0.080.040.04
   query3   0.230.050.05
   query4   1.680.070.07
   query5   0.500.500.50
   query6   1.130.740.73
   query7   0.010.020.01
   query8   0.050.050.05
   query9   0.550.510.50
   query10  0.550.560.54
   query11  0.150.120.11
   query12  0.160.120.12
   query13  0.600.590.59
   query14  2.122.062.06
   query15  0.920.820.82
   query16  0.380.380.37
   query17  1.041.050.96
   query18  0.210.220.20
   query19  1.881.721.82
   query20  0.020.010.01
   query21  15.40   0.670.66
   query22  4.556.542.11
   query23  18.22   1.291.23
   query24  2.070.220.22
   query25  0.150.080.08
   query26  0.270.180.18
   query27  0.070.080.07
   query28  13.26   1.021.00
   query29  12.65   3.273.30
   query30  0.250.050.05
   query31  2.890.380.39
   query32  3.270.480.48
   query33  2.972.943.01
   query34  17.19   4.394.39
   query35  4.424.434.43
   query36  0.660.490.47
   query37  0.190.170.16
   query38  0.150.140.15
   query39  0.040.030.03
   query40  0.150.130.13
   query41  0.110.050.05
   query42  0.060.040.04
   query43  0.040.040.04
   Total cold run time: 111.34 s
   Total hot run time: 32.04 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch branch-3.0 updated: [fix](catalog) hide some properties in show create catalog stmt (#39946) (#40329)

2024-09-04 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
 new dd9f1ecf1f9 [fix](catalog) hide some properties in show create catalog 
stmt (#39946) (#40329)
dd9f1ecf1f9 is described below

commit dd9f1ecf1f9634abdde5e88783e23c5a172659bd
Author: Mingyu Chen 
AuthorDate: Wed Sep 4 17:40:26 2024 +0800

[fix](catalog) hide some properties in show create catalog stmt (#39946) 
(#40329)

bp #39946
---
 .../java/org/apache/doris/analysis/CreateCatalogStmt.java  |  4 ++--
 .../java/org/apache/doris/common/util/PrintableMap.java|  7 ++-
 .../main/java/org/apache/doris/datasource/CatalogMgr.java  | 14 --
 .../java/org/apache/doris/datasource/ExternalCatalog.java  |  6 ++
 .../java/org/apache/doris/datasource/CatalogMgrTest.java   |  7 +--
 5 files changed, 27 insertions(+), 11 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateCatalogStmt.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateCatalogStmt.java
index f4c0360f9c3..3d68a26178b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateCatalogStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateCatalogStmt.java
@@ -26,6 +26,7 @@ import org.apache.doris.common.UserException;
 import org.apache.doris.common.util.PrintableMap;
 import org.apache.doris.common.util.PropertyAnalyzer;
 import org.apache.doris.common.util.Util;
+import org.apache.doris.datasource.ExternalCatalog;
 import org.apache.doris.datasource.InternalCatalog;
 import org.apache.doris.mysql.privilege.PrivPredicate;
 import org.apache.doris.qe.ConnectContext;
@@ -41,7 +42,6 @@ import java.util.Map;
  * Statement for create a new catalog.
  */
 public class CreateCatalogStmt extends DdlStmt implements NotFallbackInParser {
-public static final String CREATE_TIME_PROP = "create_time";
 private final boolean ifNotExists;
 private final String catalogName;
 private final String resource;
@@ -101,7 +101,7 @@ public class CreateCatalogStmt extends DdlStmt implements 
NotFallbackInParser {
 }
 
 String currentDateTime = 
LocalDateTime.now(ZoneId.systemDefault()).toString().replace("T", " ");
-properties.put(CREATE_TIME_PROP, currentDateTime);
+properties.put(ExternalCatalog.CREATE_TIME, currentDateTime);
 PropertyAnalyzer.checkCatalogProperties(properties, false);
 }
 
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/common/util/PrintableMap.java 
b/fe/fe-core/src/main/java/org/apache/doris/common/util/PrintableMap.java
index 734f0ae2268..3ad8274d664 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/util/PrintableMap.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/util/PrintableMap.java
@@ -43,6 +43,7 @@ public class PrintableMap {
 private boolean wrap;
 private boolean hidePassword;
 private String entryDelimiter = ",";
+private Set additionalHiddenKeys = Sets.newHashSet();
 
 public static final Set SENSITIVE_KEY;
 public static final Set HIDDEN_KEY;
@@ -98,6 +99,10 @@ public class PrintableMap {
 this.hidePassword = hidePassword;
 }
 
+public void setAdditionalHiddenKeys(Set additionalHiddenKeys) {
+this.additionalHiddenKeys = additionalHiddenKeys;
+}
+
 @Override
 public String toString() {
 if (map == null) {
@@ -119,7 +124,7 @@ public class PrintableMap {
 List> entries = new ArrayList<>();
 while (iter.hasNext()) {
 Map.Entry entry = iter.next();
-if (!HIDDEN_KEY.contains(entry.getKey())) {
+if (!HIDDEN_KEY.contains(entry.getKey()) && 
!additionalHiddenKeys.contains(entry.getKey())) {
 entries.add(entry);
 }
 }
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java 
b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
index b1febf202d8..c2a5ea673c2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java
@@ -36,6 +36,7 @@ import org.apache.doris.common.CaseSensibility;
 import org.apache.doris.common.DdlException;
 import org.apache.doris.common.ErrorCode;
 import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.FeConstants;
 import org.apache.doris.common.PatternMatcher;
 import org.apache.doris.common.PatternMatcherWrapper;
 import org.apache.doris.common.UserException;
@@ -88,8 +89,6 @@ public class CatalogMgr implements Writable, 
GsonPostProcessable {
 public static final String METADATA_REFRESH_INTERVAL_SEC = 
"metadata_refresh_interval_sec";
 public static final String CATALOG_TYPE_PROP = "type";
 
-private static final String YES = "yes";
-
 private fin

Re: [PR] [Chore] add arrow shade [doris-flink-connector]

2024-09-04 Thread via GitHub


JNSimba merged PR #481:
URL: https://github.com/apache/doris-flink-connector/pull/481


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40372:
URL: https://github.com/apache/doris/pull/40372#issuecomment-2328398290

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


w41ter commented on PR #40369:
URL: https://github.com/apache/doris/pull/40369#issuecomment-2328404868

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](function) Optimize ConvertTz function when using constant parameters. [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40366:
URL: https://github.com/apache/doris/pull/40366#issuecomment-2328413175

   
   
   TPC-H: Total hot run time: 37967 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 9ba30fb1bee5a5d9e301729e2d9f3ee9a240fc7e, 
data reload: false
   
   -- Round 1 --
   q1   17648   436742904290
   q2   2019177 184 177
   q3   11821   977 1140977
   q4   10530   721 666 666
   q5   7761287028282828
   q6   231 140 140 140
   q7   956 619 629 619
   q8   9348204620722046
   q9   7161656565846565
   q10  6992221922582219
   q11  469 236 240 236
   q12  397 219 220 219
   q13  17766   308331143083
   q14  277 231 235 231
   q15  527 491 501 491
   q16  600 504 506 504
   q17  980 709 731 709
   q18  7241694368466846
   q19  1378100910151009
   q20  686 334 328 328
   q21  4521317128042804
   q22  11181028980 980
   Total cold run time: 110427 ms
   Total hot run time: 37967 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4356434942954295
   q2   383 271 261 261
   q3   2893263126292629
   q4   1928164416681644
   q5   5631567857295678
   q6   230 140 137 137
   q7   2246183818121812
   q8   3321344434543444
   q9   8904888488498849
   q10  3551340034103400
   q11  618 509 516 509
   q12  839 660 691 660
   q13  13306   336433113311
   q14  336 281 305 281
   q15  536 487 487 487
   q16  601 596 576 576
   q17  1848155015391539
   q18  8168782478967824
   q19  1710150115901501
   q20  2152190919351909
   q21  5875546555105465
   q22  1141106110341034
   Total cold run time: 70573 ms
   Total hot run time: 57245 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cloud) export fdb client busyness [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40369:
URL: https://github.com/apache/doris/pull/40369#issuecomment-2328414795

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](mtmv) Support to add is_used_in_rewrite property when create materialized view [doris]

2024-09-04 Thread via GitHub


doris-robot commented on PR #40332:
URL: https://github.com/apache/doris/pull/40332#issuecomment-2328422018

   
   
   ClickBench: Total hot run time: 32.72 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 44f98174ab94da3a25de3579eca37daab45aaad9, 
data reload: false
   
   query1   0.050.040.05
   query2   0.070.040.03
   query3   0.230.070.06
   query4   1.650.080.08
   query5   0.500.490.51
   query6   1.120.720.71
   query7   0.010.010.01
   query8   0.050.050.05
   query9   0.560.480.49
   query10  0.560.550.54
   query11  0.160.110.11
   query12  0.150.130.13
   query13  0.610.590.59
   query14  2.022.062.13
   query15  0.890.830.81
   query16  0.380.380.37
   query17  1.061.051.05
   query18  0.220.200.21
   query19  1.971.801.84
   query20  0.020.010.01
   query21  15.38   0.660.66
   query22  4.036.752.46
   query23  18.27   1.411.28
   query24  2.130.230.22
   query25  0.150.080.08
   query26  0.270.180.17
   query27  0.070.070.08
   query28  13.20   1.021.00
   query29  12.60   3.303.26
   query30  0.240.060.05
   query31  2.880.430.39
   query32  3.240.480.47
   query33  2.953.013.03
   query34  17.01   4.434.50
   query35  4.484.504.49
   query36  0.660.490.48
   query37  0.190.150.15
   query38  0.160.150.14
   query39  0.050.040.04
   query40  0.160.130.13
   query41  0.090.040.04
   query42  0.050.050.05
   query43  0.050.040.03
   Total cold run time: 110.59 s
   Total hot run time: 32.72 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Revert "[cherry-pick](branch-2.1) Fix `enable_mow_light_delete` default value" [doris]

2024-09-04 Thread via GitHub


yiguolei merged PR #40359:
URL: https://github.com/apache/doris/pull/40359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](cluster key) fix mow cluster key with schema change [doris]

2024-09-04 Thread via GitHub


github-actions[bot] commented on PR #40372:
URL: https://github.com/apache/doris/pull/40372#issuecomment-2328424114

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](memory) Fix conf `max_sys_mem_available_low_water_mark_bytes` [doris]

2024-09-04 Thread via GitHub


xinyiZzz commented on PR #39962:
URL: https://github.com/apache/doris/pull/39962#issuecomment-2328424874

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   >