Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]
wuwenchi commented on code in PR #34681: URL: https://github.com/apache/doris/pull/34681#discussion_r1604433431 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java: ## @@ -273,6 +273,7 @@ private LogicalPlan getLogicalPlan(TableIf table, UnboundRelation unboundRelatio return new LogicalSubQueryAlias<>(tableQualifier, hiveViewPlan); } hmsTable.setScanParams(unboundRelation.getScanParams()); + hmsTable.setTableSnapshotVersion(unboundRelation.getTableSnapshot().orElse(null)); Review Comment: Only HMS tables are supported, but can other types of iceberg tables be supported at the same time? ## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ## @@ -966,6 +966,11 @@ sampleMethod | INTEGER_VALUE ROWS #sampleByRows ; +tableSnapshot +: FOR VERSION AS OF version=number Review Comment: The range of `number` is relatively wide, and we can use `INTEGER_VALUE` ## fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java: ## @@ -169,6 +170,7 @@ public class HMSExternalTable extends ExternalTable implements MTMVRelatedTableI // for hudi incremental read private TableScanParams scanParams = null; private IncrementalRelation incrementalRelation = null; +private TableSnapshot tableSnapshot = null; Review Comment: Can we get snapshot version information directly from IcebergScanNode? 1. This naturally supports all types of iceberg tables. 2. Specify that the snapshot belongs to the query, and its valid range is related to the query, so it is not appropriate to put this information in the HMSExternalTable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]
zhannngchen commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116887058 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]
morrySnow commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2116889555 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]
gavinchou commented on code in PR #35006:
URL: https://github.com/apache/doris/pull/35006#discussion_r160866
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -2046,6 +2046,33 @@ public boolean isInDebugMode() {
return showHiddenColumns || skipDeleteBitmap || skipDeletePredicate ||
skipDeleteSign || skipStorageEngineMerge;
}
+public String printDebugModeVariables() {
Review Comment:
Naming `getDebugModeVariables()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]
github-actions[bot] commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2116891586 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): lazy get expression map when comparing hypergraph [doris]
morrySnow merged PR #34753: URL: https://github.com/apache/doris/pull/34753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (d796c43bb60 -> 5a2a0132c48)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d796c43bb60 [Improve](inverted index) improve performance by introducing bulk contains for bitmap in _build_index_result_column (#34831) add 5a2a0132c48 [opt](nereids) lazy get expression map when comparing hypergraph (#34753) No new revisions were added by this update. Summary of changes: .../rules/exploration/mv/HyperGraphComparator.java | 114 + .../mv/LogicalCompatibilityContext.java| 31 ++ 2 files changed, 80 insertions(+), 65 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]
morrySnow commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116896904 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]
github-actions[bot] commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116897351 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]
github-actions[bot] commented on PR #34694: URL: https://github.com/apache/doris/pull/34694#issuecomment-2116897305 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]
zhannngchen commented on code in PR #35006:
URL: https://github.com/apache/doris/pull/35006#discussion_r1604453198
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -2046,6 +2046,33 @@ public boolean isInDebugMode() {
return showHiddenColumns || skipDeleteBitmap || skipDeletePredicate ||
skipDeleteSign || skipStorageEngineMerge;
}
+public String printDebugModeVariables() {
Review Comment:
same style like existing functions, like `printFuzzyVariables()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](mtmv) Add threshold for relation mapping num when query rewrite [doris]
morrySnow merged PR #34694: URL: https://github.com/apache/doris/pull/34694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (5a2a0132c48 -> 21c35791337)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 5a2a0132c48 [opt](nereids) lazy get expression map when comparing
hypergraph (#34753)
add 21c35791337 [opt](mtmv) Add threshold for relation mapping num when
query rewrite (#34694)
No new revisions were added by this update.
Summary of changes:
.../mv/AbstractMaterializedViewAggregateRule.java | 3 +-
.../mv/AbstractMaterializedViewJoinRule.java | 3 +-
.../mv/AbstractMaterializedViewRule.java | 17 +--
.../exploration/mv/MaterializedViewScanRule.java | 3 +-
.../java/org/apache/doris/qe/SessionVariable.java | 13 ++
.../materialized_view_switch.out} | 52 +-
.../availability/materialized_view_switch.groovy | 38
7 files changed, 91 insertions(+), 38 deletions(-)
copy
regression-test/data/nereids_rules_p0/mv/{nested/nested_materialized_view.out
=> availability/materialized_view_switch.out} (70%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](regression) add cases for data quality error url [doris]
github-actions[bot] commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116908766 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](log)password should not be output in log [doris]
390008457 commented on PR #34324: URL: https://github.com/apache/doris/pull/34324#issuecomment-2116909328 run beut: BE UT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]
felixwluo commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2116913538 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]
gavinchou commented on code in PR #34384:
URL: https://github.com/apache/doris/pull/34384#discussion_r1604462412
##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##
@@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult
routineInfoMetadataResult(TSchemaTabl
result.setStatus(new TStatus(TStatusCode.OK));
return result;
}
+
+private static TFetchSchemaTableDataResult
tableOptionsMetadataResult(TSchemaTableRequestParams params) {
+if (!params.isSetCurrentUserIdent()) {
+return errorResult("current user ident is not set.");
+}
+
+TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+List dataBatch = Lists.newArrayList();
+List catalogIds =
Env.getCurrentEnv().getCatalogMgr().getCatalogIds();
+for (Long catalogId : catalogIds) {
+CatalogIf catalog =
Env.getCurrentEnv().getCatalogMgr().getCatalog(catalogId);
+List dbIds = catalog.getDbIds();
+for (Long dbId : dbIds) {
+DatabaseIf database = catalog.getDbNullable(dbId);
+List tables = database.getTables();
+for (TableIf table : tables) {
+if (table instanceof OlapTable) {
Review Comment:
try negative predicate to save indention
```suggestion
if (!(table instanceof OlapTable)) continue;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]
gavinchou commented on code in PR #34384:
URL: https://github.com/apache/doris/pull/34384#discussion_r1604463773
##
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##
@@ -873,4 +892,75 @@ private static TFetchSchemaTableDataResult
routineInfoMetadataResult(TSchemaTabl
result.setStatus(new TStatus(TStatusCode.OK));
return result;
}
+
+private static TFetchSchemaTableDataResult
tableOptionsMetadataResult(TSchemaTableRequestParams params) {
+if (!params.isSetCurrentUserIdent()) {
+return errorResult("current user ident is not set.");
+}
+
+TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+List dataBatch = Lists.newArrayList();
+List catalogIds =
Env.getCurrentEnv().getCatalogMgr().getCatalogIds();
+for (Long catalogId : catalogIds) {
+CatalogIf catalog =
Env.getCurrentEnv().getCatalogMgr().getCatalog(catalogId);
+List dbIds = catalog.getDbIds();
+for (Long dbId : dbIds) {
+DatabaseIf database = catalog.getDbNullable(dbId);
+List tables = database.getTables();
+for (TableIf table : tables) {
+if (table instanceof OlapTable) {
+OlapTable olapTable = (OlapTable) table;
+TRow trow = new TRow();
+trow.addToColumnValue(new
TCell().setStringVal(table.getName())); // TABLE_NAME
+trow.addToColumnValue(new
TCell().setStringVal(catalog.getName())); // TABLE_CATALOG
+trow.addToColumnValue(new
TCell().setStringVal(database.getFullName())); // TABLE_SCHEMA
+trow.addToColumnValue(
+new
TCell().setStringVal(olapTable.getKeysType().toMetadata())); //TABLE_MODEL
+trow.addToColumnValue(
+new
TCell().setStringVal(olapTable.getKeyColAsString())); // key columTypes
+
+DistributionInfo distributionInfo =
olapTable.getDefaultDistributionInfo();
+if (distributionInfo.getType() ==
DistributionInfoType.HASH) {
+HashDistributionInfo hashDistributionInfo =
(HashDistributionInfo) distributionInfo;
+List distributionColumns =
hashDistributionInfo.getDistributionColumns();
+StringBuilder distributeKey = new StringBuilder();
+for (Column c : distributionColumns) {
+if (distributeKey.length() != 0) {
+distributeKey.append(",");
+}
+distributeKey.append(c.getName());
+}
+if (distributeKey.length() == 0) {
+trow.addToColumnValue(new
TCell().setStringVal(""));
+} else {
+trow.addToColumnValue(
+new
TCell().setStringVal(distributeKey.toString()));
+}
+trow.addToColumnValue(new
TCell().setStringVal("HASH")); // DISTRIBUTE_TYPE
+} else {
+trow.addToColumnValue(new
TCell().setStringVal("RANDOM")); // DISTRIBUTE_KEY
+trow.addToColumnValue(new
TCell().setStringVal("RANDOM")); // DISTRIBUTE_TYPE
+}
+trow.addToColumnValue(new
TCell().setIntVal(distributionInfo.getBucketNum())); // BUCKETS_NUM
+trow.addToColumnValue(new
TCell().setIntVal(olapTable.getPartitionNum())); // PARTITION_NUM
+TableProperty property = olapTable.getTableProperty();
+if (property == null) {
+trow.addToColumnValue(new
TCell().setStringVal("")); // PROPERTIES
+} else {
+try {
+trow.addToColumnValue(
+new
TCell().setStringVal(property.getPropertiesString())); // PROPERTIES
+} catch (IOException e) {
+return errorResult(e.getMessage());
+}
+}
+dataBatch.add(trow);
+}
+}
+}
+}
Review Comment:
```suggestion
} // if instance of
} // for table
} // for db
} // for catalog
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
Re: [PR] [refactor](datalake) return the error status instead of static_cast [doris]
github-actions[bot] commented on PR #34873: URL: https://github.com/apache/doris/pull/34873#issuecomment-2116918665 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](log)password should not be output in log [doris]
github-actions[bot] commented on PR #34324: URL: https://github.com/apache/doris/pull/34324#issuecomment-2116919107 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): add project for joinreorder [doris]
jackwener commented on PR #34993: URL: https://github.com/apache/doris/pull/34993#issuecomment-2116919671 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] add information_schema.table_options(#32572) [doris]
gavinchou commented on code in PR #34384:
URL: https://github.com/apache/doris/pull/34384#discussion_r1604470422
##
be/src/exec/schema_scanner/schema_table_options_scanner.cpp:
##
@@ -0,0 +1,134 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exec/schema_scanner/schema_table_options_scanner.h"
+
+#include "runtime/client_cache.h"
+#include "runtime/exec_env.h"
+#include "runtime/runtime_state.h"
+#include "util/thrift_rpc_helper.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/data_types/data_type_factory.hpp"
+
+namespace doris {
+std::vector
SchemaTableOptionsScanner::_s_tbls_columns = {
+{"TABLE_NAME", TYPE_VARCHAR, sizeof(StringRef), true},
+{"TABLE_CATALOG", TYPE_VARCHAR, sizeof(StringRef), true},
+{"TABLE_SCHEMA", TYPE_VARCHAR, sizeof(StringRef), true},
+{"TABLE_MODEL", TYPE_STRING, sizeof(StringRef), true},
+{"TABLE_MODEL_KEY", TYPE_STRING, sizeof(StringRef), true},
+{"DISTRIBUTE_KEY", TYPE_STRING, sizeof(StringRef), true},
+{"DISTRIBUTE_TYPE", TYPE_STRING, sizeof(StringRef), true},
+{"BUCKETS_NUM", TYPE_INT, sizeof(int32_t), true},
+{"PARTITION_NUM", TYPE_INT, sizeof(int32_t), true},
+{"PROPERTIES", TYPE_STRING, sizeof(StringRef), true},
+};
+
+SchemaTableOptionsScanner::SchemaTableOptionsScanner()
+: SchemaScanner(_s_tbls_columns, TSchemaTableType::SCH_TABLE_OPTIONS)
{}
+
+Status SchemaTableOptionsScanner::start(RuntimeState* state) {
+_block_rows_limit = state->batch_size();
+_rpc_timeout_ms = state->execution_timeout() * 1000;
+return Status::OK();
+}
+
+Status SchemaTableOptionsScanner::get_block_from_fe() {
+TNetworkAddress master_addr =
ExecEnv::GetInstance()->master_info()->network_address;
+
+TSchemaTableRequestParams schema_table_request_params;
+for (int i = 0; i < _s_tbls_columns.size(); i++) {
Review Comment:
We may need to add a version mechanism to control if the columns in
`_s_tbls_columns` changed in the future, which keeps FE and BE seeing a
consistent "table header"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](bloom filter) Fix bloom filter memory leak [doris]
Yukang-Lian commented on PR #34871: URL: https://github.com/apache/doris/pull/34871#issuecomment-2116929775 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](plsql) improve exception message [doris]
xinyiZzz commented on PR #34452: URL: https://github.com/apache/doris/pull/34452#issuecomment-2116929929 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] rename method name and improve logging and comments [doris]
xinyiZzz commented on PR #34321: URL: https://github.com/apache/doris/pull/34321#issuecomment-2116930518 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](bloom filter) Fix bloom filter memory leak [doris]
github-actions[bot] commented on PR #34871: URL: https://github.com/apache/doris/pull/34871#issuecomment-2116937736 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]
github-actions[bot] commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939379 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]
github-actions[bot] commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939426 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]
morrySnow commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116939595 could desc the detail of bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](log) remove redundant log in segment.cpp [doris]
doris-robot commented on PR #35008: URL: https://github.com/apache/doris/pull/35008#issuecomment-2116941815 TeamCity be ut coverage result: Function Coverage: 37.78% (8074/21369) Line Coverage: 29.44% (65927/223904) Region Coverage: 28.91% (33937/117386) Branch Coverage: 24.77% (17415/70314) Coverage Report: http://coverage.selectdb-in.cc/coverage/d14edbdfa2c8b545b1f64e9a652d8aaf8341_d14edbdfa2c8b545b1f64e9a652d8aaf8341/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]
github-actions[bot] commented on PR #34994: URL: https://github.com/apache/doris/pull/34994#issuecomment-2116941758 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]
Yukang-Lian commented on PR #34447: URL: https://github.com/apache/doris/pull/34447#issuecomment-2116942700 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg)support iceberg insert grammar [doris]
wuwenchi commented on PR #34257: URL: https://github.com/apache/doris/pull/34257#issuecomment-2116946481 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]
dataroaring merged PR #34994: URL: https://github.com/apache/doris/pull/34994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](thrift exception) do not log message in thrift exception [doris]
github-actions[bot] commented on PR #34994: URL: https://github.com/apache/doris/pull/34994#issuecomment-2116946869 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore](thrift exception) do not log message in thrift exception (#34994)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7a6c0b1b478 [chore](thrift exception) do not log message in thrift
exception (#34994)
7a6c0b1b478 is described below
commit 7a6c0b1b478387fea6c152173b9107acb4bb94c7
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Fri May 17 15:43:15 2024 +0800
[chore](thrift exception) do not log message in thrift exception (#34994)
---
be/src/agent/utils.cpp| 10 +-
be/src/util/thrift_rpc_helper.cpp | 5 +++--
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/be/src/agent/utils.cpp b/be/src/agent/utils.cpp
index 25217497686..c6a801c7a93 100644
--- a/be/src/agent/utils.cpp
+++ b/be/src/agent/utils.cpp
@@ -90,6 +90,9 @@ Status MasterServerClient::finish_task(const
TFinishTaskRequest& request, TMaste
try {
client->finishTask(*result, request);
} catch (TTransportException& e) {
+#ifdef ADDRESS_SANITIZER
+return Status::RpcError("Master client finish task failed
due to {}", e.what());
+#else
LOG(WARNING) << "master client, retry finishTask: " << e.what();
client_status = client.reopen(config::thrift_rpc_timeout_ms);
if (!client_status.ok()) {
@@ -97,9 +100,10 @@ Status MasterServerClient::finish_task(const
TFinishTaskRequest& request, TMaste
<< "host=" <<
_master_info.network_address.hostname
<< ", port=" << _master_info.network_address.port
<< ", code=" << client_status.code();
-return Status::InternalError("Master client finish task
failed");
+return Status::RpcError("Master client finish task failed");
}
client->finishTask(*result, request);
+#endif
}
} catch (std::exception& e) {
RETURN_IF_ERROR(client.reopen(config::thrift_rpc_timeout_ms));
@@ -129,6 +133,9 @@ Status MasterServerClient::report(const TReportRequest&
request, TMasterResult*
try {
client->report(*result, request);
} catch (TTransportException& e) {
+#ifdef ADDRESS_SANITIZER
+return Status::RpcError("Master client report failed due to
{}", e.what());
+#else
TTransportException::TTransportExceptionType type = e.getType();
if (type !=
TTransportException::TTransportExceptionType::TIMED_OUT) {
// if not TIMED_OUT, retry
@@ -150,6 +157,7 @@ Status MasterServerClient::report(const TReportRequest&
request, TMasterResult*
LOG(WARNING) << "fail to report to master: " << e.what();
return Status::InternalError("Fail to report to master");
}
+#endif
}
} catch (std::exception& e) {
RETURN_IF_ERROR(client.reopen(config::thrift_rpc_timeout_ms));
diff --git a/be/src/util/thrift_rpc_helper.cpp
b/be/src/util/thrift_rpc_helper.cpp
index 5d11cc6abb1..77e7f377658 100644
--- a/be/src/util/thrift_rpc_helper.cpp
+++ b/be/src/util/thrift_rpc_helper.cpp
@@ -75,8 +75,9 @@ Status ThriftRpcHelper::rpc(const std::string& ip, const
int32_t port,
} catch (apache::thrift::transport::TTransportException& e) {
std::cerr << "thrift error, reason=" << e.what();
#ifdef ADDRESS_SANITIZER
-return Status::RpcError("failed to call frontend service, FE
address={}:{}, reason: {}",
-ip, port, e.what());
+return Status::RpcError(
+"failed to call frontend service, FE address={}:{},
reason: {}", ip, port,
+e.what());
#else
LOG(WARNING) << "retrying call frontend service after "
<< config::thrift_client_retry_interval_ms << " ms,
address=" << address
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]
github-actions[bot] commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116948814 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](delete) print all debug mode session variables on error [doris]
github-actions[bot] commented on PR #35006: URL: https://github.com/apache/doris/pull/35006#issuecomment-2116948866 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](jdbc_catalog) fix error datetime literal caused be core [doris]
Yulei-Yang commented on PR #34977: URL: https://github.com/apache/doris/pull/34977#issuecomment-2116949961 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2116950404 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] couldn't resolve slot descriptor when join [doris]
nextdreamblue opened a new issue, #35009:
URL: https://github.com/apache/doris/issues/35009
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
master
### What's Wrong?
CREATE TABLE `dws_mf_wms_join_t1` (
`ddate` DATE NULL COMMENT '日期字段',
`game_id` VARCHAR(65533) NULL,
`main_currency_stock` BIGINT NULL
) ENGINE=OLAP
DUPLICATE KEY(`ddate`)
DISTRIBUTED BY HASH(`ddate`) BUCKETS 10
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
CREATE TABLE `dws_mf_wms_join_t2` (
`game_id` VARCHAR(65533) NULL,
) ENGINE=OLAP
DUPLICATE KEY(`game_id`)
DISTRIBUTED BY HASH(`game_id`) BUCKETS 10
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
SELECT
a1.ddate
FROM
(
SELECT
aaa.ddate
FROM
(
SELECT
aa.ddate,
CONCAT('main', aa.main_currency_stock) AS
arr,
ROW_NUMBER() OVER (
PARTITION BY aa.ddate
) AS rn
FROM
(
SELECT
ddate,
main_currency_stock,
game_id
FROM
dws_mf_wms_join_t1 a
) aa
LEFT JOIN (
SELECT
game_id
FROM
dws_mf_wms_join_t2
) b ON aa.game_id = b.game_id
) aaa
CROSS JOIN (
select
1 as newarr
) b
WHERE
rn = 1
) a1
GROUP BY
GROUPING SETS (
(
a1.ddate
)
);
ERROR 1105 (HY000): errCode = 2, detailMessage =
(9.134.167.25)[INTERNAL_ERROR]couldn't resolve slot descriptor 21, desc: tuples:
Tuple(id=19 slots=[Slot(id=47 type=TINYINT col=-1, colname=newarr,
nullable=0)] has_varlen_slots=0)
Tuple(id=18 slots=[Slot(id=42 type=DATEV2 col=-1, colname=ddate,
nullable=1), Slot(id=43 type=VARCHAR col=-1, colname=game_id, nullable=1),
Slot(id=44 type=VARCHAR col=-1, colname=game_id, nullable=1), Slot(id=45
type=DATEV2 col=-1, colname=ddate, nullable=1), Slot(id=46 type=BIGINT col=-1,
colname=,
### What You Expected?
return success
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg)support iceberg insert grammar [doris]
github-actions[bot] commented on PR #34257: URL: https://github.com/apache/doris/pull/34257#issuecomment-2116952422 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [atomicstatus](be) add atomic status to share state between multi thread [doris]
yiguolei commented on PR #35002: URL: https://github.com/apache/doris/pull/35002#issuecomment-2116953504 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [exceptionsafe](be) only throw exception in get block and sink method , since open and prepare maybe not exception safe [doris]
yiguolei commented on PR #34998: URL: https://github.com/apache/doris/pull/34998#issuecomment-2116954610 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](regression) add cases for data quality error url [doris]
kaijchen commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116960665 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
924060929 opened a new pull request, #35010:
URL: https://github.com/apache/doris/pull/35010
## Proposed changes
embed async profiler to help user generate flame graph for frontend
There has a script file `${FE_DEPLOY_PATH}/bin/profile_fe.sh` do the profile:
This is the example:
```shell
$ PROFILE_SECONDS=1 bin/profile_fe.sh
DORIS_HOME: /Users/lanhuajian/github/doris/output/fe
JAVA:
/Users/lanhuajian/Library/Java/JavaVirtualMachines/corretto-17.0.10/Contents/Home/bin/java
DorisFE pid: 29494
Begin profiling 1 seconds and generate flame graph to
/Users/lanhuajian/github/doris/output/fe/log/profile_20240517154934.html...
Profiling for 1 seconds
Done
Generated flame graph to
/Users/lanhuajian/github/doris/output/fe/log/profile_20240517154934.html
```
You open the generated html file to troubleshooting performance issues
**Note**: this profiler use the `async-profiler` tool, so it only support in
Linux and MaxOS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
doris-robot commented on PR #35010: URL: https://github.com/apache/doris/pull/35010#issuecomment-2116962114 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
github-actions[bot] commented on PR #35010:
URL: https://github.com/apache/doris/pull/35010#issuecomment-2116963200
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/9124837824";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In bin/profile_fe.sh line 22:
cd "${curdir}/.."
^---^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... ||
return' in case cd fails.
Did you mean:
cd "${curdir}/.." || exit
In bin/profile_fe.sh line 47:
FE_PID=`jps | grep DorisFE | awk '{print $1}'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks
`...`.
Did you mean:
FE_PID=$(jps | grep DorisFE | awk '{print $1}')
In bin/profile_fe.sh line 48:
if [[ -z "$FE_PID" ]]; then
^-^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ -z "${FE_PID}" ]]; then
In bin/profile_fe.sh line 52:
echo "DorisFE pid: $FE_PID"
^-^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "DorisFE pid: ${FE_PID}"
In bin/profile_fe.sh line 55:
NOW=`date +'%Y%m%d%H%M%S'`
^^ SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
Did you mean:
NOW=$(date +'%Y%m%d%H%M%S')
For more information:
https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ...
|...
https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of
le...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- bin/profile_fe.sh.orig
+++ bin/profile_fe.sh
@@ -44,15 +44,15 @@
exit 1
fi
-FE_PID=`jps | grep DorisFE | awk '{print $1}'`
+FE_PID=$(jps | grep DorisFE | awk '{print $1}')
if [[ -z "$FE_PID" ]]; then
- echo "DorisFe not started"
- exit 1
+echo "DorisFe not started"
+exit 1
fi
echo "DorisFE pid: $FE_PID"
mkdir -p "${DORIS_HOME}/log"
-NOW=`date +'%Y%m%d%H%M%S'`
+NOW=$(date +'%Y%m%d%H%M%S')
PROFILE_OUTPUT="${DORIS_HOME}/log/profile_${NOW}.html"
if [[ -z "${PROFILE_SECONDS}" ]]; then
PROFILE_SECONDS="10"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
morrySnow commented on code in PR #35010: URL: https://github.com/apache/doris/pull/35010#discussion_r1604509072 ## fe/fe-core/pom.xml: ## @@ -783,6 +783,11 @@ under the License. io.airlift concurrent + +me.bechberger +ap-loader-all Review Comment: need update LICENSE.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [test](regression) add cases for data quality error url [doris]
github-actions[bot] commented on PR #34987: URL: https://github.com/apache/doris/pull/34987#issuecomment-2116967527 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](hive view) support inner name like _c0,_c1 for derived column in inline view for hive view [doris]
Yulei-Yang commented on code in PR #33193:
URL: https://github.com/apache/doris/pull/33193#discussion_r1604511918
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindRelation.java:
##
@@ -328,13 +333,57 @@ private Plan parseAndAnalyzeHiveView(
return hiveViewPlan;
}
+/**
+ * Support get column from hive view with column name like '_c0', '_c1'
etc for hive.
+ */
+public void addHiveViewDerivedColumn(Plan hiveViewPlan) {
+if (hiveViewPlan instanceof LogicalProject) {
+List projects = ((LogicalProject)
hiveViewPlan).getProjects();
+int counter = -1;
+for (NamedExpression project : projects) {
+counter++;
+// only set inner name for derived column
+if (project instanceof UnboundAlias) {
+UnboundAlias aliasProject = (UnboundAlias) project;
+if (aliasProject.getAlias().isPresent()) {
+continue;
+}
+if (aliasProject.child() instanceof UnboundFunction) {
+aliasProject.setAlias(Optional.of("_c" + counter));
+}
+}
+}
+}
+
+if (hiveViewPlan instanceof LogicalAggregate) {
+int counter = -1;
+List expressions = ((LogicalAggregate)
hiveViewPlan).getOutputExpressions();
+for (NamedExpression expression : expressions) {
+counter++;
+if (expression instanceof UnboundAlias) {
+UnboundAlias aliasProject = (UnboundAlias) expression;
+if (aliasProject.getAlias().isPresent()) {
+continue;
+}
+aliasProject.setAlias(Optional.of("_c" + counter));
+}
+}
+}
+
+// Recursively init subquery
+for (Plan subPlan : hiveViewPlan.children()) {
+addHiveViewDerivedColumn(subPlan);
+}
+}
+
private Plan parseAndAnalyzeView(TableIf view, String ddlSql,
CascadesContext parentContext) {
parentContext.getStatementContext().addViewDdlSql(ddlSql);
Optional sqlCacheContext =
parentContext.getStatementContext().getSqlCacheContext();
if (sqlCacheContext.isPresent()) {
sqlCacheContext.get().addUsedView(view, ddlSql);
}
LogicalPlan parsedViewPlan = new NereidsParser().parseSingle(ddlSql);
+addHiveViewDerivedColumn(parsedViewPlan);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]
kaijchen commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2116971771 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]
Jibing-Li commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2116973586 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](planner) fix unrequired slot bug when join node introduced by #25204 [doris]
nextdreamblue commented on PR #34923: URL: https://github.com/apache/doris/pull/34923#issuecomment-2116972940 > could desc the detail of bug? add a issue for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): Refactor `Eliminate_Group_By_Key` by functional dependencies [doris]
XieJiann commented on PR #34948: URL: https://github.com/apache/doris/pull/34948#issuecomment-2116977553 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](Fe) fix potential deadlock in show proc statement [doris]
lide-reed commented on PR #34988: URL: https://github.com/apache/doris/pull/34988#issuecomment-2116979110 It's said that java.util.concurrent.ForkJoinPool may degrade performance. Please confirm whether the changes here involve high-frequency operations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]
felixwluo commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2116979740 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]
github-actions[bot] commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2116980700 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Opt](Iceberg) handle count pushdown in fe side [doris]
morrySnow merged PR #34928: URL: https://github.com/apache/doris/pull/34928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (7a6c0b1b478 -> e4df4b437ed)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 7a6c0b1b478 [chore](thrift exception) do not log message in thrift exception (#34994) add e4df4b437ed [Opt](Iceberg) handle count pushdown in fe side (#34928) No new revisions were added by this update. Summary of changes: .../org/apache/doris/datasource/FileScanNode.java | 1 + .../datasource/iceberg/source/IcebergScanNode.java| 6 ++ .../java/org/apache/doris/nereids/NereidsPlanner.java | 15 +++ .../org/apache/doris/planner/OriginalPlanner.java | 19 --- 4 files changed, 38 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bugfix](hive)fix testcase for viewfs [doris]
morningman merged PR #34790: URL: https://github.com/apache/doris/pull/34790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [bugfix](hive)fix testcase for viewfs (#34790)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 813a6977b7b [bugfix](hive)fix testcase for viewfs (#34790)
813a6977b7b is described below
commit 813a6977b7babe4284a371b6972b82a05afdc86d
Author: wuwenchi
AuthorDate: Fri May 17 16:06:13 2024 +0800
[bugfix](hive)fix testcase for viewfs (#34790)
The specified `fsname` is used first, and if there is no `fsname`, the
default `fsname` is used.
Because we create an HDFS cache based on the actual `fsname`.
---
be/src/io/hdfs_util.cpp | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/be/src/io/hdfs_util.cpp b/be/src/io/hdfs_util.cpp
index 02b6fadb310..42353fb481f 100644
--- a/be/src/io/hdfs_util.cpp
+++ b/be/src/io/hdfs_util.cpp
@@ -41,10 +41,13 @@ Status create_hdfs_fs(const THdfsParams& hdfs_params, const
std::string& fs_name
return Status::OK();
}
-uint64 hdfs_hash_code(const THdfsParams& hdfs_params) {
+uint64 hdfs_hash_code(const THdfsParams& hdfs_params, const std::string&
fs_name) {
uint64 hash_code = 0;
-hash_code ^= Fingerprint(hdfs_params.fs_name);
-if (hdfs_params.__isset.user) {
+// The specified fsname is used first.
+// If there is no specified fsname, the default fsname is used
+if (!fs_name.empty()) {
+hash_code ^= Fingerprint(fs_name);
+} else if (hdfs_params.__isset.user) {
hash_code ^= Fingerprint(hdfs_params.user);
}
if (hdfs_params.__isset.hdfs_kerberos_principal) {
@@ -105,7 +108,7 @@ void HdfsHandlerCache::_clean_oldest() {
Status HdfsHandlerCache::get_connection(const THdfsParams& hdfs_params, const
std::string& fs_name,
std::shared_ptr*
fs_handle) {
-uint64 hash_code = hdfs_hash_code(hdfs_params);
+uint64 hash_code = hdfs_hash_code(hdfs_params, fs_name);
{
std::lock_guard l(_lock);
auto it = _cache.find(hash_code);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]
airborne12 commented on code in PR #34915:
URL: https://github.com/apache/doris/pull/34915#discussion_r1604522885
##
be/src/olap/tablet.h:
##
@@ -476,6 +476,8 @@ class Tablet final : public BaseTablet {
}
inline bool is_full_compaction_running() const { return
_is_full_compaction_running; }
void clear_cache() override;
+Status clac_local_file_crc(uint32_t* crc_value, int64_t start_version,
int64_t end_version,
Review Comment:
clac->calc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]
github-actions[bot] commented on PR #34447: URL: https://github.com/apache/doris/pull/34447#issuecomment-2116985660 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](snappy) fix error when reading empty snappy file [doris]
morningman closed pull request #34828: [fix](snappy) fix error when reading empty snappy file URL: https://github.com/apache/doris/pull/34828 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](default value): enable HLL_EMPTY_DEFAULT_VALUE [doris]
morrySnow merged PR #34447: URL: https://github.com/apache/doris/pull/34447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](default value) enable HLL_EMPTY_DEFAULT_VALUE (#34447)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6b50368d384 [fix](default value) enable HLL_EMPTY_DEFAULT_VALUE
(#34447)
6b50368d384 is described below
commit 6b50368d38416f83a3feb0258ad39768ba09db7d
Author: yi wang <48236141+my-vegetable-has-explo...@users.noreply.github.com>
AuthorDate: Fri May 17 16:08:23 2024 +0800
[fix](default value) enable HLL_EMPTY_DEFAULT_VALUE (#34447)
The goal of this pr is to make it possible to use `HLL_EMPTY()` to fill
missing hll column. As shown in `test_default_hll.groovy`, if we don't
specify hll column, it will use HLL_EMPTY to fill it.
https://github.com/apache/doris/blob/f180d90bb8db1af8bee43e095de55cfe72e95ecc/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java#L362-L367
Existing analysis will add HLL_EMPTY_DEFAULT_VALUE as default value for hll
column, but some relative problem would occurs if we didn't pass `hll_hash(x)`
... for this column.
This pr add `defaultValueExprDef` for HLL_EMPTY_DEFAULT_VALUE (whick is
used in streamload mode) and make default hll column pass the analysis for
`NativeInsertStmt` and `Load`.
---
.../java/org/apache/doris/analysis/ColumnDef.java | 3 +-
.../apache/doris/analysis/NativeInsertStmt.java| 3 +-
.../apache/doris/datasource/FileQueryScanNode.java | 2 +-
.../org/apache/doris/datasource/FileScanNode.java | 8 ++
.../trees/plans/commands/info/DefaultValue.java| 3 +-
.../org/apache/doris/planner/FileLoadScanNode.java | 3 +-
.../data/correctness_p0/test_default_hll.out | 29 +++
.../correctness_p0/test_default_hll_streamload.csv | 2 +
.../suites/correctness_p0/test_default_hll.groovy | 99 ++
9 files changed, 147 insertions(+), 5 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
index 46a48339d54..efb109a9233 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java
@@ -98,6 +98,7 @@ public class ColumnDef {
// default "CURRENT_TIMESTAMP", only for DATETIME type
public static String CURRENT_TIMESTAMP = "CURRENT_TIMESTAMP";
public static String NOW = "now";
+public static String HLL_EMPTY = "HLL_EMPTY";
public static DefaultValue CURRENT_TIMESTAMP_DEFAULT_VALUE = new
DefaultValue(true, CURRENT_TIMESTAMP, NOW);
// no default value
public static DefaultValue NOT_SET = new DefaultValue(false, null);
@@ -105,7 +106,7 @@ public class ColumnDef {
public static DefaultValue NULL_DEFAULT_VALUE = new DefaultValue(true,
null);
public static String ZERO = new String(new byte[] {0});
// default "value", "0" means empty hll
-public static DefaultValue HLL_EMPTY_DEFAULT_VALUE = new
DefaultValue(true, ZERO);
+public static DefaultValue HLL_EMPTY_DEFAULT_VALUE = new
DefaultValue(true, ZERO, HLL_EMPTY);
// default "value", "0" means empty bitmap
public static DefaultValue BITMAP_EMPTY_DEFAULT_VALUE = new
DefaultValue(true, ZERO);
// default "value", "[]" means empty array
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java
index ab1aaad679a..c4ef8f6597f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java
@@ -590,7 +590,8 @@ public class NativeInsertStmt extends InsertStmt {
}
// hll column must in mentionedColumns
for (Column col : targetTable.getBaseSchema()) {
-if (col.getType().isObjectStored() &&
!mentionedColumns.contains(col.getName())) {
+if (col.getType().isObjectStored() && !col.hasDefaultValue()
+&& !mentionedColumns.contains(col.getName())) {
throw new AnalysisException(
"object-stored column " + col.getName() + " must
in insert into columns");
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java
index ff25464b4c9..90c24989275 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/datasource/FileQueryScanNode.java
@@ -173,7 +173,7 @@ public abstract class FileQueryScanNode extends
FileScanNode {
slotInfo.setIsFileSlot(!partitionKeys.contains(slot.getColumn().getName()));
params.addTo
[PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]
jacktengg opened a new pull request, #35011: URL: https://github.com/apache/doris/pull/35011 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]
jacktengg commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116987609 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]
doris-robot commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116987447 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]
liaoxin01 commented on code in PR #34485:
URL: https://github.com/apache/doris/pull/34485#discussion_r1604526302
##
be/src/runtime/load_stream.cpp:
##
@@ -226,7 +226,9 @@ Status TabletStream::close() {
auto wait_func = [this, &mu, &cv] {
signal::set_signal_task_id(_load_id);
for (auto& token : _flush_tokens) {
-token->wait();
+if (token != nullptr) {
Review Comment:
When is token nullptr? If it is nullptr, an error should be reported？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]
kaka11chen opened a new pull request, #35012: URL: https://github.com/apache/doris/pull/35012 ## Proposed changes [Configurations] (multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables for workaround. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
morningman commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2116991018 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]
doris-robot commented on PR #35012: URL: https://github.com/apache/doris/pull/35012#issuecomment-2116989875 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [tmp] add debug log [doris]
morningman closed pull request #34723: [tmp] add debug log URL: https://github.com/apache/doris/pull/34723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](agg) fix DCHECK failure of agg when failed to alloc memory [doris]
github-actions[bot] commented on PR #35011: URL: https://github.com/apache/doris/pull/35011#issuecomment-2116998946 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]
kaka11chen commented on PR #35012: URL: https://github.com/apache/doris/pull/35012#issuecomment-2116999705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [conf](pipeline) Disable non-pipeline engine [doris]
doris-robot commented on PR #34812: URL: https://github.com/apache/doris/pull/34812#issuecomment-2117000245 TeamCity be ut coverage result: Function Coverage: 35.70% (9006/25226) Line Coverage: 27.37% (74525/272265) Region Coverage: 26.61% (38533/144780) Branch Coverage: 23.44% (19662/83876) Coverage Report: http://coverage.selectdb-in.cc/coverage/02bc01057dd04bf31bc6d23d2242abb8ebc495df_02bc01057dd04bf31bc6d23d2242abb8ebc495df/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Configurations](multi-catalog) Add `enable_parquet_filter_by_min_max` and `enable_orc_filter_by_min_max` Session variables. [doris]
github-actions[bot] commented on code in PR #35012: URL: https://github.com/apache/doris/pull/35012#discussion_r1604534174 ## be/src/vec/exec/format/orc/vorc_reader.cpp: ## @@ -169,6 +170,7 @@ OrcReader::OrcReader(const TFileScanRangeParams& params, const TFileRangeDesc& r _file_system(nullptr), _io_ctx(io_ctx), _enable_lazy_mat(enable_lazy_mat), + _enable_filter_by_min_max(true), Review Comment: warning: member initializer for '_enable_filter_by_min_max' is redundant [modernize-use-default-member-init] ```suggestion , ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
github-actions[bot] commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2117002238 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Refactor](Variant) refactor flush logic to support partial update [doris]
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2117004308 TeamCity be ut coverage result: Function Coverage: 35.70% (9009/25234) Line Coverage: 27.37% (74547/272374) Region Coverage: 26.61% (38546/144833) Branch Coverage: 23.44% (19664/83904) Coverage Report: http://coverage.selectdb-in.cc/coverage/a9c1dcd84b4f407b8a437204e38dcede70b0e4d4_a9c1dcd84b4f407b8a437204e38dcede70b0e4d4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
github-actions[bot] commented on PR #35010:
URL: https://github.com/apache/doris/pull/35010#issuecomment-2117005245
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/9125154944";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In bin/profile_fe.sh line 22:
cd "${curdir}/.."
^---^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... ||
return' in case cd fails.
Did you mean:
cd "${curdir}/.." || exit
In bin/profile_fe.sh line 48:
if [[ -z "$FE_PID" ]]; then
^-^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ -z "${FE_PID}" ]]; then
In bin/profile_fe.sh line 52:
echo "DorisFE pid: $FE_PID"
^-^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "DorisFE pid: ${FE_PID}"
For more information:
https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ...
|...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' found no issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [update](hudi) update hudi-spark bundle to 3.4.3 [doris]
AshinGau opened a new pull request, #35013: URL: https://github.com/apache/doris/pull/35013 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [update](hudi) update hudi-spark bundle to 3.4.3 [doris]
doris-robot commented on PR #35013: URL: https://github.com/apache/doris/pull/35013#issuecomment-2117008399 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](tools) embed async profiler to help user generate flame graph for frontend [doris]
github-actions[bot] commented on PR #35010:
URL: https://github.com/apache/doris/pull/35010#issuecomment-2117009604
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/9125189874";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In bin/profile_fe.sh line 48:
if [[ -z "$FE_PID" ]]; then
^-^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ -z "${FE_PID}" ]]; then
In bin/profile_fe.sh line 52:
echo "DorisFE pid: $FE_PID"
^-^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
echo "DorisFE pid: ${FE_PID}"
For more information:
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' found no issues.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]
github-actions[bot] commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2117010550 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive-ctas) allow use qualified name when create hive table [doris]
morrySnow commented on PR #34984: URL: https://github.com/apache/doris/pull/34984#issuecomment-2117011064 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]
xinyiZzz opened a new pull request, #35014: URL: https://github.com/apache/doris/pull/35014 ## Proposed changes to eliminate query memory leaks !!! ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]
doris-robot commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117011779 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]
xinyiZzz commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117011984 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids)new way to set pre-agg status [doris]
github-actions[bot] commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2117015246 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids)new way to set pre-agg status [doris]
github-actions[bot] commented on PR #34738: URL: https://github.com/apache/doris/pull/34738#issuecomment-2117015320 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](memory) In Debug compile, QueryMemTracker not equal to 0 will crash at query end [doris]
github-actions[bot] commented on PR #35014: URL: https://github.com/apache/doris/pull/35014#issuecomment-2117021184 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]
kaijchen commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2117021543 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](datalake) return the error status instead of static_cast [doris]
AshinGau commented on PR #34873: URL: https://github.com/apache/doris/pull/34873#issuecomment-2117024949 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Cast min/max in partition stats table to double for numeric column to get correct table level min/max value. [doris]
Jibing-Li commented on PR #34919: URL: https://github.com/apache/doris/pull/34919#issuecomment-2117025208 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]
doris-robot commented on PR #34941: URL: https://github.com/apache/doris/pull/34941#issuecomment-2117028771 TeamCity be ut coverage result: Function Coverage: 35.70% (9005/25226) Line Coverage: 27.37% (74529/272266) Region Coverage: 26.62% (38548/144804) Branch Coverage: 23.44% (19668/83900) Coverage Report: http://coverage.selectdb-in.cc/coverage/7d118c3284996db2f4b162e135779fdcaac87dd8_7d118c3284996db2f4b162e135779fdcaac87dd8/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix nullptr and token num in TabletStream::close [doris]
github-actions[bot] commented on PR #34485: URL: https://github.com/apache/doris/pull/34485#issuecomment-2117030490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]
csun5285 commented on code in PR #34915:
URL: https://github.com/apache/doris/pull/34915#discussion_r1604558667
##
be/src/olap/tablet.h:
##
@@ -476,6 +476,8 @@ class Tablet final : public BaseTablet {
}
inline bool is_full_compaction_running() const { return
_is_full_compaction_running; }
void clear_cache() override;
+Status clac_local_file_crc(uint32_t* crc_value, int64_t start_version,
int64_t end_version,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2117034536 TeamCity be ut coverage result: Function Coverage: 35.69% (9004/25226) Line Coverage: 27.37% (74508/272237) Region Coverage: 26.60% (38516/144773) Branch Coverage: 23.43% (19655/83872) Coverage Report: http://coverage.selectdb-in.cc/coverage/6637bcd8496201c9c741c0457bd5dca0a0718bd8_6637bcd8496201c9c741c0457bd5dca0a0718bd8/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
