Re: [I] Doris Roadmap 2024 [doris]

2024-05-16 Thread via GitHub


zhangm365 commented on issue #30669:
URL: https://github.com/apache/doris/issues/30669#issuecomment-2114212192

   The correct url for `async-materialized-view`  is as follows:
   
https://doris.apache.org/docs/query/view-materialized-view/async-materialized-view


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]

2024-05-16 Thread via GitHub


jackwener commented on PR #34906:
URL: https://github.com/apache/doris/pull/34906#issuecomment-2114230799

   run p1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat [doris]

2024-05-16 Thread via GitHub


ixzc commented on issue #34944:
URL: https://github.com/apache/doris/issues/34944#issuecomment-2114242439

   we will fix it, and I will update pr here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34863:
URL: https://github.com/apache/doris/pull/34863#issuecomment-2114244955

   TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219) 
Line Coverage: 27.37% (74480/272155)
Region Coverage: 26.61% (38504/144710)
Branch Coverage: 23.43% (19643/83838)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/98a3cee38c714ac65855d015d868e8d25dfa3c95_98a3cee38c714ac65855d015d868e8d25dfa3c95/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bugfix](Cloud) Offer sync vault task to thread pool to prevent bthread context switch [doris]

2024-05-16 Thread via GitHub


ByteYue commented on PR #34951:
URL: https://github.com/apache/doris/pull/34951#issuecomment-2114247279

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bugfix](Cloud) Offer sync vault task to thread pool to prevent bthread context switch [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34951:
URL: https://github.com/apache/doris/pull/34951#issuecomment-2114254484

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]

2024-05-16 Thread via GitHub


jackwener commented on PR #34906:
URL: https://github.com/apache/doris/pull/34906#issuecomment-2114263088

   run p1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](show proc) Fix insert into command cannot be seen in show proc [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34953:
URL: https://github.com/apache/doris/pull/34953#issuecomment-2114263278

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](show proc) Fix insert into command cannot be seen in show proc [doris]

2024-05-16 Thread via GitHub


zhiqiang- opened a new pull request, #34953:
URL: https://github.com/apache/doris/pull/34953

   fix insert into command can not be shown by `show proc 
'/current_query_stmts'`;
   
   
   reference https://github.com/apache/doris/pull/31742/
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix] (planner) support auto aggregation for random distributed table [doris]

2024-05-16 Thread via GitHub


DarvenDuan commented on PR #33630:
URL: https://github.com/apache/doris/pull/33630#issuecomment-2114263267

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](show proc) Fix insert into command cannot be seen in show proc [doris]

2024-05-16 Thread via GitHub


zhiqiang- commented on PR #34953:
URL: https://github.com/apache/doris/pull/34953#issuecomment-2114264228

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [branch-2.0](recover) support skipping missing version in select by session variable [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34931:
URL: https://github.com/apache/doris/pull/34931#issuecomment-2114264724

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [branch-2.0](recover) support skipping missing version in select by session variable [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34931:
URL: https://github.com/apache/doris/pull/34931#issuecomment-2114264776

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]

2024-05-16 Thread via GitHub


jackwener commented on PR #34906:
URL: https://github.com/apache/doris/pull/34906#issuecomment-2114266833

   
   run p1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](jdbc catalog) split trino jdbc executor [doris]

2024-05-16 Thread via GitHub


zy-kkk commented on PR #34932:
URL: https://github.com/apache/doris/pull/34932#issuecomment-2114271413

   run External


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch branch-2.0 updated: [branch-2.0](recover) support skipping missing version in select by session variable (#34931)

2024-05-16 Thread lide
This is an automated email from the ASF dual-hosted git repository.

lide pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-2.0 by this push:
 new 7103872fc20 [branch-2.0](recover) support skipping missing version in 
select by session variable (#34931)
7103872fc20 is described below

commit 7103872fc20ab67d47deeda2ab571d0e9a1bcc17
Author: xy720 <22125576+xy...@users.noreply.github.com>
AuthorDate: Thu May 16 15:29:38 2024 +0800

[branch-2.0](recover) support skipping missing version in select by session 
variable (#34931)
---
 be/src/olap/schema_change.cpp  |  2 +-
 be/src/olap/tablet.cpp | 23 +++-
 be/src/olap/tablet.h   |  8 +++--
 be/src/runtime/runtime_state.h |  4 +++
 be/src/vec/exec/scan/new_olap_scan_node.cpp|  2 +-
 be/src/vec/exec/scan/new_olap_scanner.cpp  |  3 +-
 be/test/olap/tablet_test.cpp   |  4 +--
 .../main/java/org/apache/doris/common/Config.java  | 14 
 .../java/org/apache/doris/catalog/Replica.java | 18 ++
 .../main/java/org/apache/doris/catalog/Tablet.java |  4 +--
 .../org/apache/doris/planner/OlapScanNode.java | 32 ++---
 .../java/org/apache/doris/qe/SessionVariable.java  | 17 +
 gensrc/thrift/PaloInternalService.thrift   |  2 ++
 .../session_variable/test_skip_missing_version.out |  4 +++
 .../test_skip_missing_version.groovy   | 42 ++
 15 files changed, 135 insertions(+), 44 deletions(-)

diff --git a/be/src/olap/schema_change.cpp b/be/src/olap/schema_change.cpp
index 4ea1ccbc3ff..80dc6003619 100644
--- a/be/src/olap/schema_change.cpp
+++ b/be/src/olap/schema_change.cpp
@@ -1004,7 +1004,7 @@ Status SchemaChangeHandler::_get_versions_to_be_changed(
 *max_rowset = rowset;
 
 RETURN_IF_ERROR(base_tablet->capture_consistent_versions(Version(0, 
rowset->version().second),
- 
versions_to_be_changed));
+ 
versions_to_be_changed, false, false));
 
 return Status::OK();
 }
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index 51811c2d22d..0d1898a5999 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -758,7 +758,7 @@ void Tablet::delete_expired_stale_rowset() {
 Version test_version = Version(0, lastest_delta->end_version());
 stale_version_path_map[*path_id_iter] = version_path;
 
-Status status = capture_consistent_versions(test_version, nullptr);
+Status status = capture_consistent_versions(test_version, nullptr, 
false, false);
 // 1. When there is no consistent versions, we must reconstruct 
the tracker.
 if (!status.ok()) {
 // 2. fetch missing version after delete
@@ -882,7 +882,8 @@ bool Tablet::_reconstruct_version_tracker_if_necessary() {
 }
 
 Status Tablet::capture_consistent_versions(const Version& spec_version,
-   std::vector* version_path, 
bool quiet) const {
+   std::vector* version_path,
+   bool skip_missing_version, bool 
quiet) const {
 Status status =
 
_timestamped_version_tracker.capture_consistent_versions(spec_version, 
version_path);
 if (!status.ok() && !quiet) {
@@ -905,6 +906,10 @@ Status Tablet::capture_consistent_versions(const Version& 
spec_version,
 LOG(WARNING) << "status:" << status << ", tablet:" << 
full_name()
  << ", missed version for version:" << 
spec_version;
 _print_missed_versions(missed_versions);
+if (skip_missing_version) {
+LOG(WARNING) << "force skipping missing version for 
tablet:" << full_name();
+return Status::OK();
+}
 }
 }
 }
@@ -913,7 +918,7 @@ Status Tablet::capture_consistent_versions(const Version& 
spec_version,
 
 Status Tablet::check_version_integrity(const Version& version, bool quiet) {
 std::shared_lock rdlock(_meta_lock);
-return capture_consistent_versions(version, nullptr, quiet);
+return capture_consistent_versions(version, nullptr, false, quiet);
 }
 
 bool Tablet::exceed_version_limit(int32_t limit) const {
@@ -946,7 +951,7 @@ void Tablet::acquire_version_and_rowsets(
 Status Tablet::capture_consistent_rowsets(const Version& spec_version,
   std::vector* 
rowsets) const {
 std::vector version_path;
-RETURN_IF_ERROR(capture_consistent_versions(spec_version, &version_path));
+RETURN_IF_ERROR(capture_consistent_versions(spec_version, &version_path, 
false, false));
 RETURN_IF_ERROR(_c

Re: [PR] [branch-2.0](recover) support skipping missing version in select by session variable [doris]

2024-05-16 Thread via GitHub


lide-reed merged PR #34931:
URL: https://github.com/apache/doris/pull/34931


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](ci) clear coredump files to avoid disk full [doris]

2024-05-16 Thread via GitHub


hello-stephen commented on PR #34900:
URL: https://github.com/apache/doris/pull/34900#issuecomment-2114272354

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](ci) clear coredump files to avoid disk full [doris]

2024-05-16 Thread via GitHub


jacktengg merged PR #34900:
URL: https://github.com/apache/doris/pull/34900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated: [fix](ci) clear coredump files to avoid disk full (#34900)

2024-05-16 Thread jacktengg
This is an automated email from the ASF dual-hosted git repository.

jacktengg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new e6d24420abb [fix](ci) clear coredump files to avoid disk full (#34900)
e6d24420abb is described below

commit e6d24420abb68b2a7fde05107b912878beb4d185
Author: Dongyang Li 
AuthorDate: Thu May 16 15:32:30 2024 +0800

[fix](ci) clear coredump files to avoid disk full (#34900)

Co-authored-by: stephen 
---
 regression-test/pipeline/cloud_p0/prepare.sh| 3 ++-
 regression-test/pipeline/common/doris-utils.sh  | 5 +
 regression-test/pipeline/performance/prepare.sh | 3 ++-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/regression-test/pipeline/cloud_p0/prepare.sh 
b/regression-test/pipeline/cloud_p0/prepare.sh
index 89bfa3150bc..211870d99d5 100644
--- a/regression-test/pipeline/cloud_p0/prepare.sh
+++ b/regression-test/pipeline/cloud_p0/prepare.sh
@@ -35,7 +35,7 @@ if ${DEBUG:-false}; then
 fi
 
 # shellcheck source=/dev/null
-# stop_doris, clean_fdb, install_fdb, install_java
+# stop_doris, clean_fdb, install_fdb, install_java, clear_coredump
 source 
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/doris-utils.sh
 # shellcheck source=/dev/null
 # check_oss_file_exist, download_oss_file
@@ -100,6 +100,7 @@ echo " 3. try to kill old doris process"
 DORIS_HOME="${teamcity_build_checkoutDir}/output"
 export DORIS_HOME
 stop_doris
+clear_coredump
 
 echo " 4. prepare fundationdb"
 install_fdb
diff --git a/regression-test/pipeline/common/doris-utils.sh 
b/regression-test/pipeline/common/doris-utils.sh
index 25ce7b5ac6e..c1cc1f6be57 100644
--- a/regression-test/pipeline/common/doris-utils.sh
+++ b/regression-test/pipeline/common/doris-utils.sh
@@ -531,6 +531,11 @@ wait_coredump_file_ready() {
 done
 }
 
+clear_coredump() {
+echo -e "INFO: clear coredump files \n$(ls /var/lib/apport/coredump/)"
+rm -rf /var/lib/apport/coredump/*
+}
+
 archive_doris_coredump() {
 if [[ ! -d "${DORIS_HOME:-}" ]]; then return 1; fi
 archive_name="$1"
diff --git a/regression-test/pipeline/performance/prepare.sh 
b/regression-test/pipeline/performance/prepare.sh
index 0a78ed136ed..1e5231bd2b4 100644
--- a/regression-test/pipeline/performance/prepare.sh
+++ b/regression-test/pipeline/performance/prepare.sh
@@ -70,7 +70,7 @@ fi
 # shellcheck source=/dev/null
 source "$(bash 
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/get-or-set-tmp-env.sh
 'get')"
 # shellcheck source=/dev/null
-# install_java
+# install_java, clear_coredump
 source 
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/doris-utils.sh
 
 if ${skip_pipeline:=false}; then echo "INFO: skip build pipline" && exit 0; 
else echo "INFO: no skip"; fi
@@ -126,3 +126,4 @@ echo " 3. try to kill old doris process"
 # stop_doris
 source 
"${teamcity_build_checkoutDir}"/regression-test/pipeline/common/doris-utils.sh
 if stop_doris; then echo; fi
+clear_coredump


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] Pick "[bugfix](Cloud) Offer sync vault task to thread pool to prevent bthread context switch #34951" [doris]

2024-05-16 Thread via GitHub


dataroaring merged PR #34952:
URL: https://github.com/apache/doris/pull/34952


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch branch-3.0-preview updated: Pick "[bugfix](Cloud) Offer sync vault task to thread pool to prevent bthread context switch #34951" (#34952)

2024-05-16 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0-preview
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.0-preview by this 
push:
 new f710608c010 Pick "[bugfix](Cloud) Offer sync vault task to thread pool 
to prevent bthread context switch #34951" (#34952)
f710608c010 is described below

commit f710608c01078492e6ea27bc808c8e340b838f55
Author: AlexYue 
AuthorDate: Thu May 16 15:39:38 2024 +0800

Pick "[bugfix](Cloud) Offer sync vault task to thread pool to prevent 
bthread context switch #34951" (#34952)
---
 be/src/cloud/cloud_internal_service.cpp | 13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/be/src/cloud/cloud_internal_service.cpp 
b/be/src/cloud/cloud_internal_service.cpp
index aba178bb34d..782e6e317b1 100644
--- a/be/src/cloud/cloud_internal_service.cpp
+++ b/be/src/cloud/cloud_internal_service.cpp
@@ -31,7 +31,18 @@ void 
CloudInternalServiceImpl::alter_vault_sync(google::protobuf::RpcController*
 PAlterVaultSyncResponse* 
response,
 google::protobuf::Closure* 
done) {
 LOG(INFO) << "alter be to sync vault info from Meta Service";
-_engine.sync_storage_vault();
+// If the vaults containing hdfs vault then it would try to create hdfs 
connection using jni
+// which would acuiqre one thread local jniEnv. But bthread context can't 
guarantee that the brpc
+// worker thread wouldn't do bthread switch between worker threads.
+bool ret = _heavy_work_pool.try_offer([&]() {
+brpc::ClosureGuard closure_guard(done);
+_engine.sync_storage_vault();
+});
+if (!ret) {
+brpc::ClosureGuard closure_guard(done);
+LOG(WARNING) << "fail to offer alter_vault_sync request to the work 
pool, pool="
+ << _heavy_work_pool.get_info();
+}
 }
 
 } // namespace doris


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [chore](ci) stop be first then stop fe to avoid thrift rpc core [doris]

2024-05-16 Thread via GitHub


hello-stephen opened a new pull request, #34954:
URL: https://github.com/apache/doris/pull/34954

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]

2024-05-16 Thread via GitHub


jackwener commented on PR #34906:
URL: https://github.com/apache/doris/pull/34906#issuecomment-2114289609

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](ci) stop be first then stop fe to avoid thrift rpc core [doris]

2024-05-16 Thread via GitHub


hello-stephen commented on PR #34954:
URL: https://github.com/apache/doris/pull/34954#issuecomment-2114290015

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](ci) stop be first then stop fe to avoid thrift rpc core [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34954:
URL: https://github.com/apache/doris/pull/34954#issuecomment-2114289888

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] 使用delete 删除的数据仍然可以查询到 [doris]

2024-05-16 Thread via GitHub


Yukang-Lian commented on issue #34551:
URL: https://github.com/apache/doris/issues/34551#issuecomment-2114299826

   **Prerequisite Knowledge:** During the process of updating partial columns, 
existing data may be read. If the key of the newly imported data for partial 
columns already exists, BE (Backend) will read the rows with the same key and 
update the data of the partial columns. If the key does not exist, BE will 
write the newly imported data of the partial columns and fill in the default 
values for other columns.
   Since the storage engine used by Doris is similar to the LSM-tree structure, 
the delete statement does not actually delete the data but marks it for 
deletion. The delete statement in Doris writes the delete information into the 
delete predicate, marking the data for deletion with a predicate.
   
   **Reason:** In step 3, the data with key=1 was deleted, so key=1 was written 
into the delete predicate. In step 5, when partially updating the columns with 
key=1, the old data was read without considering the effect of the delete 
predicate, resulting in the ID2 column showing the previously deleted value.
   
   **Solution:** When reading and completing data for partial column updates, 
consider the delete predicate to solve the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix] (planner) support auto aggregation for random distributed table [doris]

2024-05-16 Thread via GitHub


starocean999 commented on PR #33630:
URL: https://github.com/apache/doris/pull/33630#issuecomment-2114303547

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [Chore](hash) catch error when hash method variant meet valueless_by_exception [doris]

2024-05-16 Thread via GitHub


BiteThet opened a new pull request, #34956:
URL: https://github.com/apache/doris/pull/34956

   ## Proposed changes
   hash method variant may valueless when memory not enough
   ```cpp
   terminate called after throwing an instance of 'std::bad_variant_access'
 what():  std::visit: variant is valueless
   *** Query id: 6a23d37a72684550-b556b16377e1ebe6 ***
   *** is nereids: 1 ***
   *** tablet id: 0 ***
   *** Aborted at 1715768949 (unix time) try "date -d @1715768949" if you are 
using GNU date ***
   *** Current BE git commitID: 533c3ed656 ***
   *** SIGABRT unknown detail explain (@0x3eb16a) received by PID 4108650 (TID 
4112014 OR 0x7f84c459d700) from PID 4108650; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, 
siginfo_t*, void*) at 
/home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421
1# 0x7F8942E3D090 in /lib/x86_64-linux-gnu/libc.so.6
2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
4# __gnu_cxx::__verbose_terminate_handler() [clone .cold] at 
../../../../libstdc++-v3/libsupc++/vterminate.cc:75
5# __cxxabiv1::__terminate(void (*)()) at 
../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48
6# 0x55B16F22B8B1 in /mnt/hdd01/STRESS_ENV/be/lib/doris_be
7# 0x55B16F22BA04 in /mnt/hdd01/STRESS_ENV/be/lib/doris_be
8# 
doris::pipeline::DistinctStreamingAggLocalState::close(doris::RuntimeState*) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/exec/distinct_streaming_aggregation_operator.cpp:509
9# doris::pipeline::OperatorXBase::close(doris::RuntimeState*) in 
/mnt/hdd01/STRESS_ENV/be/lib/doris_be
   10# doris::pipeline::PipelineTask::close(doris::Status) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_task.cpp:418
   11# doris::pipeline::_close_task(doris::pipeline::PipelineTask*, 
doris::Status) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/task_scheduler.cpp:88
   12# doris::pipeline::TaskScheduler::_do_work(unsigned long) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/task_scheduler.cpp:172
   13# doris::ThreadPool::dispatch_thread() in 
/mnt/hdd01/STRESS_ENV/be/lib/doris_be
   14# doris::Thread::supervise_thread(void*) at 
/home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499
   15# start_thread at /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:478
   16# __clone at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
   
   ```
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](hash) catch error when hash method variant meet valueless_by_exception [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34956:
URL: https://github.com/apache/doris/pull/34956#issuecomment-2114307083

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[I] [Feature] Support SQL translater from Pinot to Doris [doris]

2024-05-16 Thread via GitHub


cxing opened a new issue, #34955:
URL: https://github.com/apache/doris/issues/34955

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Description
   
   Support pinot sql language and translate into doris supported sql will help 
us migrate service to doris easily 
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cmd) add UNSET_VARIABLE statement to set back variables [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34949:
URL: https://github.com/apache/doris/pull/34949#issuecomment-2114306813

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](cmd) add UNSET_VARIABLE statement to set back variables [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34949:
URL: https://github.com/apache/doris/pull/34949#issuecomment-2114306883

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](hash) catch error when hash method variant meet valueless_by_exception [doris]

2024-05-16 Thread via GitHub


BiteThet commented on PR #34956:
URL: https://github.com/apache/doris/pull/34956#issuecomment-2114307828

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [enhance](mtmv)Optimize mtmv logs and exception information [doris]

2024-05-16 Thread via GitHub


zddr opened a new pull request, #34957:
URL: https://github.com/apache/doris/pull/34957

   ## Proposed changes
   
   Issue Number: close #xxx
   
   Change some logs to debug
   
   Error prompt changed from MTMV to async materialized view
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](mtmv)Optimize mtmv logs and exception information [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34957:
URL: https://github.com/apache/doris/pull/34957#issuecomment-2114308527

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](mtmv)Optimize mtmv logs and exception information [doris]

2024-05-16 Thread via GitHub


zddr commented on PR #34957:
URL: https://github.com/apache/doris/pull/34957#issuecomment-2114308792

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] java.lang.ClassNotFoundException: 'org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat [doris]

2024-05-16 Thread via GitHub


ixzc commented on issue #34944:
URL: https://github.com/apache/doris/issues/34944#issuecomment-2114314996

   Is doris version 2.1.3rc? Please provide the ddl, or you can add my wechat: 
Faitch_xzc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [enhance](mtmv)Mv refresh on commit [doris]

2024-05-16 Thread via GitHub


zddr commented on PR #34548:
URL: https://github.com/apache/doris/pull/34548#issuecomment-2114327440

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](hash) catch error when hash method variant meet valueless_by_exception [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34956:
URL: https://github.com/apache/doris/pull/34956#issuecomment-2114331689

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (e6d24420abb -> 33c03e09564)

2024-05-16 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository.

panxiaolei pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from e6d24420abb [fix](ci) clear coredump files to avoid disk full (#34900)
 add 33c03e09564 [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc 
(#34947)

No new revisions were added by this update.

Summary of changes:
 gensrc/thrift/PaloInternalService.thrift | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc [doris]

2024-05-16 Thread via GitHub


BiteThet merged PR #34947:
URL: https://github.com/apache/doris/pull/34947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [optimize](sink) optimize BE load balance [doris-flink-connector]

2024-05-16 Thread via GitHub


vinlee19 opened a new pull request, #388:
URL: https://github.com/apache/doris-flink-connector/pull/388

   # Proposed changes
   When multi concurrency load data to Apache Doris , the previous load rule 
may cause some be work
   
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114364219

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-16 Thread via GitHub


morningman commented on code in PR #34422:
URL: https://github.com/apache/doris/pull/34422#discussion_r1602803384


##
fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/source/TrinoConnectorScanNode.java:
##
@@ -102,11 +113,31 @@ protected void doInitialize() throws UserException {
 table.getName()));
 }
 
-source = new TrinoConnectorSource(desc, table);
-
 computeColumnsFilter();
 initBackendPolicy();
+source = new TrinoConnectorSource(desc, table);
 initSchemaParams();
+convertPredicate();
+}
+
+protected void convertPredicate() throws UserException {
+if (conjuncts.isEmpty()) {
+constraint = Constraint.alwaysTrue();
+}
+TupleDomain summary = TupleDomain.all();
+TrinoConnectorPredicateConverter trinoConnectorPredicateConverter = 
new TrinoConnectorPredicateConverter(
+source.getTargetTable().getColumnHandleMap(),
+source.getTargetTable().getColumnMetadataMap());
+try {
+for (int i = 0; i < conjuncts.size(); ++i) {
+summary = summary.intersect(
+
trinoConnectorPredicateConverter.convertExprToTrinoTupleDomain(conjuncts.get(i)));
+}
+} catch (AnalysisException e) {
+LOG.warn("Can not convert Expr to trino tuple domain, exception: 
{}", e.getMessage());

Review Comment:
   ```suggestion
   LOG.debug("Can not convert Expr to trino tuple domain, 
exception: {}", e.getMessage());
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-16 Thread via GitHub


morningman commented on code in PR #34422:
URL: https://github.com/apache/doris/pull/34422#discussion_r1602813637


##
fe/fe-core/src/main/java/org/apache/doris/datasource/trinoconnector/source/TrinoConnectorScanNode.java:
##
@@ -102,11 +113,31 @@ protected void doInitialize() throws UserException {
 table.getName()));
 }
 
-source = new TrinoConnectorSource(desc, table);
-
 computeColumnsFilter();
 initBackendPolicy();
+source = new TrinoConnectorSource(desc, table);
 initSchemaParams();
+convertPredicate();
+}
+
+protected void convertPredicate() throws UserException {
+if (conjuncts.isEmpty()) {
+constraint = Constraint.alwaysTrue();
+}
+TupleDomain summary = TupleDomain.all();
+TrinoConnectorPredicateConverter trinoConnectorPredicateConverter = 
new TrinoConnectorPredicateConverter(
+source.getTargetTable().getColumnHandleMap(),
+source.getTargetTable().getColumnMetadataMap());
+try {
+for (int i = 0; i < conjuncts.size(); ++i) {
+summary = summary.intersect(
+
trinoConnectorPredicateConverter.convertExprToTrinoTupleDomain(conjuncts.get(i)));
+}
+} catch (AnalysisException e) {
+LOG.warn("Can not convert Expr to trino tuple domain, exception: 
{}", e.getMessage());

Review Comment:
   Modify in next PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve](fslog) The error log should be printed by caller [doris]

2024-05-16 Thread via GitHub


dataroaring commented on PR #34935:
URL: https://github.com/apache/doris/pull/34935#issuecomment-2114365379

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve](fslog) The error log should be printed by caller [doris]

2024-05-16 Thread via GitHub


dataroaring merged PR #34935:
URL: https://github.com/apache/doris/pull/34935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]

2024-05-16 Thread via GitHub


felixwluo commented on PR #34941:
URL: https://github.com/apache/doris/pull/34941#issuecomment-2114368267

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34422:
URL: https://github.com/apache/doris/pull/34422#issuecomment-2114368303

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhencement](trino-connector) The trino-connector catalog supports pushdown predicates to the connector [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34422:
URL: https://github.com/apache/doris/pull/34422#issuecomment-2114368440

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (33c03e09564 -> 4773b29e92d)

2024-05-16 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 33c03e09564 [Chore](topn) rename TTopnFilterContext to TTopnFilterDesc 
(#34947)
 add 4773b29e92d [improve](fslog) The error log should be printed by caller 
(#34935)

No new revisions were added by this update.

Summary of changes:
 be/src/io/fs/file_system.h | 1 -
 1 file changed, 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34637:
URL: https://github.com/apache/doris/pull/34637#issuecomment-2114379834

   
   
   TPC-DS: Total hot run time: 187481 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 40c4c66811262ba6f243834f6e033a07bdea086b, 
data reload: false
   
   query1   924 385 360 360
   query2   6173243122462246
   query3   6668217 213 213
   query4   23449   21860   21926   21860
   query5   3765442 424 424
   query6   263 178 174 174
   query7   4539304 302 302
   query8   248 201 190 190
   query9   8593241224362412
   query10  417 263 251 251
   query11  15401   14932   14760   14760
   query12  120 87  93  87
   query13  1636363 367 363
   query14  10520   769977487699
   query15  232 163 168 163
   query16  8155259 249 249
   query17  1703541 531 531
   query18  2081269 264 264
   query19  198 138 145 138
   query20  84  78  83  78
   query21  185 126 130 126
   query22  5048476148174761
   query23  34119   3   33658   3
   query24  10686   290028602860
   query25  601 353 368 353
   query26  1322161 153 153
   query27  2934318 309 309
   query28  7345200220042002
   query29  876 592 602 592
   query30  229 170 167 167
   query31  1002732 767 732
   query32  94  53  51  51
   query33  744 243 234 234
   query34  1071487 464 464
   query35  808 663 655 655
   query36  1069940 927 927
   query37  139 70  66  66
   query38  2910276627542754
   query39  1606158415621562
   query40  200 120 119 119
   query41  45  41  41  41
   query42  101 94  98  94
   query43  598 545 526 526
   query44  1178724 739 724
   query45  262 254 259 254
   query46  1081732 718 718
   query47  1938185618401840
   query48  364 298 289 289
   query49  896 385 382 382
   query50  746 375 381 375
   query51  6791681966966696
   query52  102 85  90  85
   query53  351 288 287 287
   query54  877 440 433 433
   query55  75  80  74  74
   query56  243 211 218 211
   query57  1234113511551135
   query58  221 195 198 195
   query59  3314307829772977
   query60  269 235 244 235
   query61  108 106 104 104
   query62  657 497 469 469
   query63  311 294 297 294
   query64  9266740273787378
   query65  3186309130833083
   query66  1357334 334 334
   query67  15543   14987   14781   14781
   query68  4519542 525 525
   query69  477 297 301 297
   query70  1156115311211121
   query71  403 263 257 257
   query72  7464258423812381
   query73  704 319 326 319
   query74  6541602060256020
   query75  3458262726372627
   query76  2748102310081008
   query77  392 262 266 262
   query78  10596   10238   10157   10157
   query79  2262515 507 507
   query80  885 425 426 425
   query81  536 239 239 239
   query82  104094  93  93
   query83  271 169 172 169
   query84  232 85  82  82
   query85  1555264 259 259
   query86  500 289 311 289
   query87  3324312830793079
   query88  4152234223332333
   query89  490 388 390 388
   query90  1976195 195 195
   query91  119 94  97  94
   query92  63  51  48  48
   query93  2040491 485 485
   query94  1165174 174 174
   query95  394 367 295 295
   query96  589 266 264 264
   query97  3168303630013001
   query98  243 222 218 218
   query99  1140872 882 872
   Total cold run time: 283873 ms
   Total hot run time: 187481 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th

[PR] [doc](stream load) Links occasionally fail when page jumps [doris-website]

2024-05-16 Thread via GitHub


wanghuan2054 opened a new pull request, #663:
URL: https://github.com/apache/doris-website/pull/663

   Links occasionally fail when page jumps , so use http access paths instead 
of relative paths


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34680:
URL: https://github.com/apache/doris/pull/34680#issuecomment-2114380301

   
   
   TPC-DS: Total hot run time: 188354 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 598ab34fb3f663fe300f3140c7298332dd75a4a2, 
data reload: false
   
   query1   913 386 373 373
   query2   6278240823082308
   query3   6632221 212 212
   query4   24230   21945   21946   21945
   query5   3598431 421 421
   query6   250 170 164 164
   query7   4531299 298 298
   query8   242 184 180 180
   query9   8617241724302417
   query10  427 242 252 242
   query11  15623   14875   14887   14875
   query12  126 88  88  88
   query13  1577378 370 370
   query14  9771768984817689
   query15  267 178 171 171
   query16  8163262 268 262
   query17  1689568 550 550
   query18  2096285 269 269
   query19  293 152 154 152
   query20  90  82  89  82
   query21  192 128 128 128
   query22  5063485948064806
   query23  34345   33662   33351   33351
   query24  11653   287928652865
   query25  629 374 373 373
   query26  1607164 152 152
   query27  2829317 318 317
   query28  7300201620212016
   query29  978 610 613 610
   query30  243 172 170 170
   query31  947 732 732 732
   query32  93  50  51  50
   query33  734 240 245 240
   query34  1026476 478 476
   query35  814 662 674 662
   query36  1051917 941 917
   query37  169 72  66  66
   query38  2891274527622745
   query39  1608156515611561
   query40  243 123 123 123
   query41  45  41  42  41
   query42  105 97  97  97
   query43  580 526 546 526
   query44  1208728 734 728
   query45  258 251 263 251
   query46  1096722 739 722
   query47  1980188918721872
   query48  362 296 296 296
   query49  1027389 382 382
   query50  755 372 381 372
   query51  6919676567246724
   query52  96  94  89  89
   query53  362 283 299 283
   query54  940 414 416 414
   query55  77  75  72  72
   query56  243 216 221 216
   query57  1233115011591150
   query58  213 198 199 198
   query59  3590316332753163
   query60  262 231 229 229
   query61  102 89  89  89
   query62  645 477 464 464
   query63  303 282 281 281
   query64  9657742873907390
   query65  3129308630973086
   query66  1338355 340 340
   query67  15520   14896   15055   14896
   query68  4635538 526 526
   query69  526 298 313 298
   query70  1191112511431125
   query71  426 258 260 258
   query72  7460259923672367
   query73  691 312 317 312
   query74  6485616961406140
   query75  3683263626262626
   query76  3387984 991 984
   query77  605 272 271 271
   query78  10618   10179   10225   10179
   query79  2712529 528 528
   query80  1418421 427 421
   query81  528 240 246 240
   query82  916 100 103 100
   query83  207 169 168 168
   query84  266 88  84  84
   query85  1383332 269 269
   query86  447 313 305 305
   query87  3364310730843084
   query88  4023230823182308
   query89  504 374 365 365
   query90  1968184 182 182
   query91  163 95  110 95
   query92  62  45  45  45
   query93  2315493 487 487
   query94  1128178 183 178
   query95  390 313 295 295
   query96  585 264 261 261
   query97  3186299029622962
   query98  243 221 216 216
   query99  1288876 880 876
   Total cold run time: 288676 ms
   Total hot run time: 188354 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the

Re: [PR] [fix](load) fix error due to jsonpaths resolution results [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34941:
URL: https://github.com/apache/doris/pull/34941#issuecomment-2114386640

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]

2024-05-16 Thread via GitHub


csun5285 commented on PR #34915:
URL: https://github.com/apache/doris/pull/34915#issuecomment-2114391328

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] 使用delete 删除的数据仍然可以查询到 [doris]

2024-05-16 Thread via GitHub


ycycse commented on issue #34551:
URL: https://github.com/apache/doris/issues/34551#issuecomment-2114393624

   Hi, I'll try this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114400185

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34637:
URL: https://github.com/apache/doris/pull/34637#issuecomment-2114401926

   
   
   ClickBench: Total hot run time: 30.07 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 40c4c66811262ba6f243834f6e033a07bdea086b, 
data reload: false
   
   query1   0.040.030.04
   query2   0.070.040.04
   query3   0.230.050.04
   query4   1.680.060.06
   query5   0.480.480.50
   query6   1.120.720.73
   query7   0.010.010.02
   query8   0.050.040.04
   query9   0.540.480.49
   query10  0.540.540.54
   query11  0.150.110.12
   query12  0.140.120.12
   query13  0.600.580.60
   query14  0.790.760.78
   query15  0.840.800.79
   query16  0.350.380.37
   query17  1.031.001.02
   query18  0.230.240.27
   query19  1.801.681.70
   query20  0.020.010.01
   query21  15.74   0.650.64
   query22  4.268.121.48
   query23  18.26   1.471.25
   query24  1.620.380.21
   query25  0.140.080.08
   query26  0.280.170.17
   query27  0.080.080.08
   query28  13.22   1.001.07
   query29  13.45   3.313.25
   query30  0.240.060.05
   query31  2.880.390.39
   query32  3.270.470.46
   query33  2.872.812.81
   query34  16.99   4.464.46
   query35  4.484.624.60
   query36  0.660.470.46
   query37  0.170.150.15
   query38  0.140.150.14
   query39  0.050.030.03
   query40  0.170.140.14
   query41  0.090.040.04
   query42  0.050.040.05
   query43  0.040.040.04
   Total cold run time: 109.86 s
   Total hot run time: 30.07 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34680:
URL: https://github.com/apache/doris/pull/34680#issuecomment-2114402489

   
   
   ClickBench: Total hot run time: 30.38 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 598ab34fb3f663fe300f3140c7298332dd75a4a2, 
data reload: false
   
   query1   0.030.030.03
   query2   0.080.040.04
   query3   0.240.060.07
   query4   1.660.080.11
   query5   0.500.490.51
   query6   1.130.720.72
   query7   0.020.020.01
   query8   0.050.040.04
   query9   0.530.480.47
   query10  0.550.550.55
   query11  0.140.110.12
   query12  0.150.120.12
   query13  0.600.580.59
   query14  0.770.790.76
   query15  0.820.810.81
   query16  0.370.370.36
   query17  0.990.980.96
   query18  0.230.230.25
   query19  1.861.701.77
   query20  0.020.010.01
   query21  15.58   0.670.67
   query22  3.997.711.97
   query23  18.26   1.361.17
   query24  1.750.260.21
   query25  0.130.080.08
   query26  0.270.170.17
   query27  0.080.080.07
   query28  13.35   1.020.98
   query29  13.07   3.323.30
   query30  0.240.060.05
   query31  2.880.380.38
   query32  3.280.470.48
   query33  2.782.802.79
   query34  17.21   4.384.40
   query35  4.514.474.52
   query36  0.670.490.49
   query37  0.180.160.16
   query38  0.150.150.15
   query39  0.040.040.04
   query40  0.160.140.16
   query41  0.090.050.04
   query42  0.060.040.04
   query43  0.040.040.03
   Total cold run time: 109.51 s
   Total hot run time: 30.38 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](ci) stop be first then stop fe to avoid thrift rpc core [doris]

2024-05-16 Thread via GitHub


hello-stephen commented on PR #34954:
URL: https://github.com/apache/doris/pull/34954#issuecomment-2114407850

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improve](http action) add http interface to calculate the crc of all files in tablet [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on code in PR #34915:
URL: https://github.com/apache/doris/pull/34915#discussion_r1602832184


##
be/src/http/action/calc_file_crc_action.h:
##
@@ -0,0 +1,53 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include 

Review Comment:
   warning: inclusion of deprecated C++ header 'stdint.h'; consider using 
'cstdint' instead [modernize-deprecated-headers]
   
   ```suggestion
   #include 
   ```
   



##
be/src/http/action/calc_file_crc_action.h:
##
@@ -0,0 +1,53 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include 
+
+#include 
+
+#include "common/status.h"
+#include "http/http_handler_with_auth.h"
+
+namespace doris {
+class HttpRequest;
+class StorageEngine;
+class ExecEnv;
+
+const std::string PARAM_START_VERSION = "start_version";
+const std::string PARAM_END_VERSION = "end_version";
+
+// This action is used to calculate the crc value of the files in the tablet.
+class CalcFileCrcAction : public HttpHandlerWithAuth {
+public:
+CalcFileCrcAction(ExecEnv* exec_env, StorageEngine& engine, 
TPrivilegeHier::type hier,
+  TPrivilegeType::type ptype);
+
+~CalcFileCrcAction() override = default;
+
+void handle(HttpRequest* req) override;
+
+private:
+Status _handle_calc_crc(HttpRequest* req, uint32_t* crc_value, int64_t* 
start_version,
+int64_t* end_version, int32_t* rowset_count, 
int64_t* file_count);
+
+private:

Review Comment:
   warning: redundant access specifier has the same accessibility as the 
previous access specifier [readability-redundant-access-specifiers]
   
   ```suggestion
   
   ```
   
   Additional context
   
   **be/src/http/action/calc_file_crc_action.h:44:** previously declared here
   ```cpp
   private:
   ^
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [cherry-pick](master)Compatible with previously enabled ldap configuration (#34… [doris]

2024-05-16 Thread via GitHub


zddr commented on PR #34899:
URL: https://github.com/apache/doris/pull/34899#issuecomment-2114429479

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114438823

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Enhancement](conf) set "enable_advance_next_id = true" to test acvance next id [doris]

2024-05-16 Thread via GitHub


dataroaring commented on PR #34921:
URL: https://github.com/apache/doris/pull/34921#issuecomment-2114442984

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv) Fix table id overturn and optimize get table qualifier method [doris]

2024-05-16 Thread via GitHub


XieJiann commented on code in PR #34768:
URL: https://github.com/apache/doris/pull/34768#discussion_r1602853568


##
fe/fe-core/src/main/java/org/apache/doris/nereids/CascadesContext.java:
##
@@ -138,6 +142,10 @@ public class CascadesContext implements ScheduleContext {
 // into AggregateFunction with distinct, we can not fold constant in this 
case
 private int distinctAggLevel;
 private final boolean isEnableExprTrace;
+// Record table id mapping, the key is the hash code of union catalogId, 
databaseId, tableId
+// the value is the auto-increment id in the cascades context
+private final Map tableIdMapping = new LinkedHashMap<>();
+private final IdGenerator talbeIdGenerator = 
TableId.createGenerator();

Review Comment:
   Use class like `TableIdentifier` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Vault) Make vaults case no concurrent run and use hms hdfs fs [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34958:
URL: https://github.com/apache/doris/pull/34958#issuecomment-2114454172

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [chore](Vault) Make vaults case no concurrent run and use hms hdfs fs [doris]

2024-05-16 Thread via GitHub


ByteYue opened a new pull request, #34958:
URL: https://github.com/apache/doris/pull/34958

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Vault) Make vaults case no concurrent run and use hms hdfs fs [doris]

2024-05-16 Thread via GitHub


ByteYue commented on PR #34958:
URL: https://github.com/apache/doris/pull/34958#issuecomment-2114454451

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Vault) Make vaults case no concurrent run and use hms hdfs fs [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34958:
URL: https://github.com/apache/doris/pull/34958#issuecomment-2114466218

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv)fix case of drop index [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34959:
URL: https://github.com/apache/doris/pull/34959#issuecomment-2114473390

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](mtmv)fix case of drop index [doris]

2024-05-16 Thread via GitHub


zddr commented on PR #34959:
URL: https://github.com/apache/doris/pull/34959#issuecomment-2114474738

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [fix](mtmv)fix case of drop index [doris]

2024-05-16 Thread via GitHub


zddr opened a new pull request, #34959:
URL: https://github.com/apache/doris/pull/34959

   ## Proposed changes
   
   Issue Number: close #xxx
   
   before drop index , need wait table NORMAL
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](hash) catch error when hash method variant meet valueless_by_exception [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34956:
URL: https://github.com/apache/doris/pull/34956#issuecomment-2114488135

   TeamCity be ut coverage result:
Function Coverage: 35.70% (9003/25221) 
Line Coverage: 27.37% (74493/272191)
Region Coverage: 26.60% (38504/144745)
Branch Coverage: 23.43% (19643/83852)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/279962d7b6eaf9ae30179252471850608b919ac8_279962d7b6eaf9ae30179252471850608b919ac8/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114492088

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](thrift rpc) skip handle retry in asan mode [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34813:
URL: https://github.com/apache/doris/pull/34813#issuecomment-2114499301

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


morningman commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114504281

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Config](thrift) set default timeout for thrift rpc in FE [doris]

2024-05-16 Thread via GitHub


hello-stephen commented on PR #33430:
URL: https://github.com/apache/doris/pull/33430#issuecomment-2114512784

   run compile


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](thrift rpc) skip handle retry in asan mode [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34813:
URL: https://github.com/apache/doris/pull/34813#issuecomment-2114514173

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](thrift rpc) skip handle retry in asan mode [doris]

2024-05-16 Thread via GitHub


dataroaring merged PR #34813:
URL: https://github.com/apache/doris/pull/34813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed [doris]

2024-05-16 Thread via GitHub


morningman commented on PR #34637:
URL: https://github.com/apache/doris/pull/34637#issuecomment-2114515211

   run performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (4773b29e92d -> d1b816b2379)

2024-05-16 Thread dataroaring
This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 4773b29e92d [improve](fslog) The error log should be printed by caller 
(#34935)
 add d1b816b2379 [fix](thrift rpc) skip handle retry in asan mode (#34813)

No new revisions were added by this update.

Summary of changes:
 be/src/util/thrift_rpc_helper.cpp | 5 +
 1 file changed, 5 insertions(+)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [catalog](benchmark) add trino connector doc [doris-website]

2024-05-16 Thread via GitHub


morningman merged PR #656:
URL: https://github.com/apache/doris-website/pull/656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris-website) branch master updated: [catalog](benchmark) add trino connector doc (#656)

2024-05-16 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-website.git


The following commit(s) were added to refs/heads/master by this push:
 new 1b13fe5263c [catalog](benchmark) add trino connector doc (#656)
1b13fe5263c is described below

commit 1b13fe5263c13a7bb460023915ffb806e0b82539
Author: Mingyu Chen 
AuthorDate: Thu May 16 16:42:31 2024 +0800

[catalog](benchmark) add trino connector doc (#656)

add tpch and tpcds catalog doc
---
 docs/lakehouse/datalake-analytics/tpcds.md | 179 
 docs/lakehouse/datalake-analytics/tpch.md  | 147 
 .../current/lakehouse/datalake-analytics/tpcds.md  | 187 +
 .../current/lakehouse/datalake-analytics/tpch.md   | 156 +
 sidebars.json  |   6 +-
 5 files changed, 673 insertions(+), 2 deletions(-)

diff --git a/docs/lakehouse/datalake-analytics/tpcds.md 
b/docs/lakehouse/datalake-analytics/tpcds.md
new file mode 100644
index 000..4b3144d9bbf
--- /dev/null
+++ b/docs/lakehouse/datalake-analytics/tpcds.md
@@ -0,0 +1,179 @@
+---
+{
+"title": "TPCDS",
+"language": "en"
+}
+---
+
+
+
+## Usage Notes
+
+TPCDS Catalog uses the [Trino 
Connector](https://doris.apache.org/community/how-to-contribute/trino-connector-developer-guide)
 compatibility framework and the [TPCDS 
Connector](https://trino.io/docs/current/connector/tpcds.html) to quickly build 
TPCDS test sets.
+
+:::tip
+This feature is supported starting from Doris version 3.0.0.
+:::
+
+## Compiling the TPCDS Connector
+
+> JDK 17 is required.
+
+```shell
+git clone https://github.com/trinodb/trino.git
+git checkout 435
+cd trino/plugin/trino-tpcds
+mvn clean install -DskipTest
+```
+
+After compiling, you will find the `trino-tpcds-435/` directory under 
`trino/plugin/trino-tpcds/target/`.
+
+You can also directly download the precompiled 
[trino-tpcds-435.tar.gz](https://github.com/morningman/trino-connectors/releases/download/trino-connectors/trino-tpcds-435.tar.gz)
 and extract it.
+
+## Deploying the TPCDS Connector
+
+Place the `trino-tpcds-435/` directory under the `connectors/` directory in 
the deployment paths of all FE and BE nodes. (If it does not exist, you can 
create it manually).
+
+```
+├── bin
+├── conf
+├── connectors
+│   ├── trino-tpcds-435
+...
+```
+
+After deployment, it is recommended to restart the FE and BE nodes to ensure 
the Connector is loaded correctly.
+
+## Creating the TPCDS Catalog
+
+```sql
+CREATE CATALOG `tpcds` PROPERTIES (
+"type" = "trino-connector",
+"connector.name" = "tpcds",
+"tpcds.split-count" = "32"
+);
+```
+
+The `tpcds.split-count` property sets the level of concurrency. It is 
recommended to set it to twice the number of cores per BE node to achieve 
optimal concurrency and improve data generation efficiency.
+
+## Using the TPCDS Catalog
+
+The TPCDS Catalog includes pre-configured TPCDS datasets of different scale 
factors, which can be viewed using the `SHOW DATABASES` and `SHOW TABLES` 
commands.
+
+```
+mysql> SWITCH tpcds;
+Query OK, 0 rows affected (0.00 sec)
+
+mysql> SHOW DATABASES;
+++
+| Database   |
+++
+| information_schema |
+| mysql  |
+| sf1|
+| sf100  |
+| sf1000 |
+| sf1|
+| sf10   |
+| sf300  |
+| sf3000 |
+| sf3|
+| tiny   |
+++
+11 rows in set (0.00 sec)
+
+mysql> USE sf1;
+mysql> SHOW TABLES;
+++
+| Tables_in_sf1  |
+++
+| call_center|
+| catalog_page   |
+| catalog_returns|
+| catalog_sales  |
+| customer   |
+| customer_address   |
+| customer_demographics  |
+| date_dim   |
+| dbgen_version  |
+| household_demographics |
+| income_band|
+| inventory  |
+| item   |
+| promotion  |
+| reason |
+| ship_mode  |
+| store  |
+| store_returns  |
+| store_sales|
+| time_dim   |
+| warehouse  |
+| web_page   |
+| web_returns|
+| web_sales  |
+| web_site   |
+++
+25 rows in set (0.00 sec)
+```
+
+You can directly query these tables using the SELECT statement.
+
+:::tip
+The data in these pre-configured datasets is not actually stored but generated 
in real-time during queries. Therefore, these datasets are not suitable for 
direct benchmarking. They are more appropriate for writing to other target 
tables (such as Doris internal tables, Hive, Iceberg, and other data sources 
supported by Doris) via `INSERT INTO SELECT`, after which performance tests can 
be 

Error while running notifications feature from .asf.yaml in doris-website!

2024-05-16 Thread Apache Infrastructure


An error occurred while running notifications feature in .asf.yaml!:
Invalid notification target 'comm...@foo.apache.org'. Must be a valid 
@doris.apache.org list!


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed [doris]

2024-05-16 Thread via GitHub


morningman merged PR #34637:
URL: https://github.com/apache/doris/pull/34637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated: [fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed (#34637)

2024-05-16 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 1434aefc3bd [fix](case)fix PolicyTest testMergeFilterNereidsPlanner 
failed (#34637)
1434aefc3bd is described below

commit 1434aefc3bda5bcedbc8689032e0b6569215e7a4
Author: zhangdong <493738...@qq.com>
AuthorDate: Thu May 16 16:42:54 2024 +0800

[fix](case)fix PolicyTest testMergeFilterNereidsPlanner failed (#34637)

The results of explain may have some order that is not fixed
---
 fe/fe-core/src/test/java/org/apache/doris/policy/PolicyTest.java | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/test/java/org/apache/doris/policy/PolicyTest.java 
b/fe/fe-core/src/test/java/org/apache/doris/policy/PolicyTest.java
index 3169a57159f..ddf0d68fd2b 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/policy/PolicyTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/policy/PolicyTest.java
@@ -283,7 +283,10 @@ public class PolicyTest extends TestWithFeService {
 createPolicy("CREATE ROW POLICY test_row_policy4 ON test.table1 AS 
PERMISSIVE TO test_policy USING (k2 = 1)");
 String queryStr = "EXPLAIN select * from test.table1";
 String explainString = getSQLPlanOrErrorMsg(queryStr);
-Assertions.assertTrue(explainString.contains("k2[#1] IN (1, 2) AND 
(k1[#0] = 1)"));
+System.out.println(explainString);
+Assertions.assertTrue(explainString.contains("IN (1, 2)") || 
explainString.contains("IN (2, 1)"));
+Assertions.assertTrue(explainString.contains("AND"));
+Assertions.assertTrue(explainString.contains("= 1)"));
 dropPolicy("DROP ROW POLICY test_row_policy1 ON test.table1");
 dropPolicy("DROP ROW POLICY test_row_policy3 ON test.table1");
 dropPolicy("DROP ROW POLICY test_row_policy4 ON test.table1");


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [chore](Vault) Make vaults case no concurrent run and use hms hdfs fs [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34958:
URL: https://github.com/apache/doris/pull/34958#issuecomment-2114549665

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix] (planner) support auto aggregation for random distributed table [doris]

2024-05-16 Thread via GitHub


DarvenDuan commented on PR #33630:
URL: https://github.com/apache/doris/pull/33630#issuecomment-2114548522

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [bugfix](Cloud) Offer sync vault task to thread pool to prevent bthread context switch [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34951:
URL: https://github.com/apache/doris/pull/34951#issuecomment-2114552691

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [I] [Bug] ${LIMIT:+${LIMIT}} "${DORIS_HOME}/lib/doris_be" "$@" 2>&1 < /dev/null doris be莫名其妙停止 [doris]

2024-05-16 Thread via GitHub


zlvcvc commented on issue #34934:
URL: https://github.com/apache/doris/issues/34934#issuecomment-2114561061

   
后面发现是flink的关系,启动flink后十分钟左右过后doris_be就会断掉。不启动flink,那就没有问题。机器是8核16G,机器上就这两个服务,应该不会存在内存爆了的问题,日志也没有打印。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



(doris) branch master updated (1434aefc3bd -> 1c962a56531)

2024-05-16 Thread zykkk
This is an automated email from the ASF dual-hosted git repository.

zykkk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 1434aefc3bd [fix](case)fix PolicyTest testMergeFilterNereidsPlanner 
failed (#34637)
 add 1c962a56531 [refactor](jdbc catalog) split trino jdbc executor (#34932)

No new revisions were added by this update.

Summary of changes:
 be/src/vec/exec/vjdbc_connector.cpp|   3 +-
 .../org/apache/doris/jdbc/JdbcExecutorFactory.java |   3 +
 ...anaJdbcExecutor.java => TrinoJdbcExecutor.java} | 105 +
 .../datasource/jdbc/client/JdbcTrinoClient.java|   4 +-
 4 files changed, 75 insertions(+), 40 deletions(-)
 copy 
fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/{SapHanaJdbcExecutor.java
 => TrinoJdbcExecutor.java} (60%)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [refactor](jdbc catalog) split trino jdbc executor [doris]

2024-05-16 Thread via GitHub


zy-kkk merged PR #34932:
URL: https://github.com/apache/doris/pull/34932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [test](case) add time funciton ut case [doris]

2024-05-16 Thread via GitHub


M1saka2003 commented on PR #34874:
URL: https://github.com/apache/doris/pull/34874#issuecomment-2114577344

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](txn insert) Fix txn insert values error when connect to follower fe [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34950:
URL: https://github.com/apache/doris/pull/34950#issuecomment-2114583601

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [fix](txn insert) Fix txn insert values error when connect to follower fe [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #34950:
URL: https://github.com/apache/doris/pull/34950#issuecomment-2114583729

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Feature][external catalog/lakesoul] support lakesoul catalog [doris]

2024-05-16 Thread via GitHub


github-actions[bot] commented on PR #32164:
URL: https://github.com/apache/doris/pull/32164#issuecomment-2114588985

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [opt](spill) handle oom exception in spill tasks [doris]

2024-05-16 Thread via GitHub


mrhhsg opened a new pull request, #34960:
URL: https://github.com/apache/doris/pull/34960

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [opt](spill) handle oom exception in spill tasks [doris]

2024-05-16 Thread via GitHub


doris-robot commented on PR #34960:
URL: https://github.com/apache/doris/pull/34960#issuecomment-2114601905

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   6   7   >