Re: [PR] [improve](txn insert) Txn load support cloud mode [doris]
github-actions[bot] commented on code in PR #34721:
URL: https://github.com/apache/doris/pull/34721#discussion_r1601061224
##
cloud/test/meta_service_test.cpp:
##
@@ -1332,6 +1332,314 @@ TEST(MetaServiceTest, CommitTxnExpiredTest) {
}
}
+TEST(MetaServiceTest, CommitTxnWithSubTxnTest) {
+auto meta_service = get_meta_service();
+int64_t db_id = 98131;
+int64_t txn_id = -1;
+int64_t t1 = 10;
+int64_t t1_index = 100;
+int64_t t1_p1 = 11;
+int64_t t1_p1_t1 = 12;
+int64_t t1_p1_t2 = 13;
+int64_t t1_p2 = 14;
+int64_t t1_p2_t1 = 15;
+int64_t t2 = 16;
+int64_t t2_index = 101;
+int64_t t2_p3 = 17;
+int64_t t2_p3_t1 = 18;
+[[maybe_unused]] int64_t t2_p4 = 19;
+[[maybe_unused]] int64_t t2_p4_t1 = 20;
+// begin txn
+{
+brpc::Controller cntl;
+BeginTxnRequest req;
+req.set_cloud_unique_id("test_cloud_unique_id");
+TxnInfoPB txn_info_pb;
+txn_info_pb.set_db_id(db_id);
+txn_info_pb.set_label("test_label");
+txn_info_pb.add_table_ids(t1);
+txn_info_pb.set_timeout_ms(36000);
+req.mutable_txn_info()->CopyFrom(txn_info_pb);
+BeginTxnResponse res;
+
meta_service->begin_txn(reinterpret_cast<::google::protobuf::RpcController*>(&cntl),
&req,
+&res, nullptr);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+txn_id = res.txn_id();
+}
+
+// mock rowset and tablet: for sub_txn1
+int64_t sub_txn_id1 = txn_id;
+{
+create_tablet(meta_service.get(), t1, t1_index, t1_p1, t1_p1_t1);
+auto tmp_rowset = create_rowset(sub_txn_id1, t1_p1_t1, t1_p1);
+CreateRowsetResponse res;
+commit_rowset(meta_service.get(), tmp_rowset, res);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+}
+{
+create_tablet(meta_service.get(), t1, t1_index, t1_p1, t1_p1_t2);
+auto tmp_rowset = create_rowset(sub_txn_id1, t1_p1_t2, t1_p1);
+CreateRowsetResponse res;
+commit_rowset(meta_service.get(), tmp_rowset, res);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+}
+{
+create_tablet(meta_service.get(), t1, t1_index, t1_p2, t1_p2_t1);
+auto tmp_rowset = create_rowset(sub_txn_id1, t1_p2_t1, t1_p2);
+CreateRowsetResponse res;
+commit_rowset(meta_service.get(), tmp_rowset, res);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+}
+
+// begin_sub_txn2
+int64_t sub_txn_id2 = -1;
+{
+brpc::Controller cntl;
+BeginSubTxnRequest req;
+req.set_cloud_unique_id("test_cloud_unique_id");
+req.set_txn_id(txn_id);
+req.set_db_id(db_id);
+req.set_label("test_label_0");
+req.set_table_id(t2);
+BeginSubTxnResponse res;
+
meta_service->begin_sub_txn(reinterpret_cast<::google::protobuf::RpcController*>(&cntl),
+&req, &res, nullptr);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+ASSERT_EQ(res.txn_info().table_ids().size(), 2);
+ASSERT_EQ(res.txn_info().sub_txn_ids().size(), 1);
+ASSERT_TRUE(res.has_sub_txn_id());
+sub_txn_id2 = res.sub_txn_id();
+ASSERT_EQ(sub_txn_id2, res.txn_info().sub_txn_ids()[0]);
+}
+// mock rowset and tablet: for sub_txn3
+{
+create_tablet(meta_service.get(), t2, t2_index, t2_p3, t2_p3_t1);
+auto tmp_rowset = create_rowset(sub_txn_id2, t2_p3_t1, t2_p3);
+CreateRowsetResponse res;
+commit_rowset(meta_service.get(), tmp_rowset, res);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+}
+
+// begin_sub_txn3
+int64_t sub_txn_id3 = -1;
+{
+brpc::Controller cntl;
+BeginSubTxnRequest req;
+req.set_cloud_unique_id("test_cloud_unique_id");
+req.set_txn_id(txn_id);
+req.set_db_id(db_id);
+req.set_label("test_label_1");
+req.set_table_id(t1);
+BeginSubTxnResponse res;
+
meta_service->begin_sub_txn(reinterpret_cast<::google::protobuf::RpcController*>(&cntl),
+&req, &res, nullptr);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+ASSERT_EQ(res.txn_info().table_ids().size(), 3);
+ASSERT_EQ(res.txn_info().sub_txn_ids().size(), 2);
+ASSERT_TRUE(res.has_sub_txn_id());
+sub_txn_id3 = res.sub_txn_id();
+ASSERT_EQ(sub_txn_id3, res.txn_info().sub_txn_ids()[1]);
+}
+// mock rowset and tablet: for sub_txn3
+{
+create_tablet(meta_service.get(), t1, t1_index, t1_p1, t1_p1_t1);
+auto tmp_rowset = create_rowset(sub_txn_id3, t1_p1_t1, t1_p1);
+CreateRowsetResponse res;
+commit_rowset(meta_service.get(), tmp_rowset, res);
+ASSERT_EQ(res.status().code(), MetaServiceCode::OK);
+}
+{
+create_tablet(meta_service.get(), t1, t
Re: [PR] [fix](cloud) unify empty_partition_prune condition with nereids [doris]
doris-robot commented on PR #34861: URL: https://github.com/apache/doris/pull/34861#issuecomment-2111735135 ClickBench: Total hot run time: 30.12 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit af97e3b9fc8b6354b74c8b3fcedd1754ccf3947b, data reload: false query1 0.040.040.03 query2 0.090.040.04 query3 0.230.040.06 query4 1.660.080.08 query5 0.490.490.52 query6 1.130.710.72 query7 0.020.010.01 query8 0.040.040.04 query9 0.530.480.49 query10 0.540.550.53 query11 0.160.110.12 query12 0.140.120.11 query13 0.590.580.61 query14 0.770.780.78 query15 0.840.810.81 query16 0.370.360.37 query17 1.000.961.01 query18 0.230.250.25 query19 1.811.681.70 query20 0.020.010.01 query21 15.71 0.660.64 query22 4.297.711.71 query23 18.28 1.441.28 query24 1.520.310.22 query25 0.150.080.08 query26 0.260.160.16 query27 0.070.070.09 query28 13.39 1.021.00 query29 13.21 3.303.26 query30 0.240.060.06 query31 2.950.380.39 query32 3.830.480.47 query33 2.822.802.82 query34 17.16 4.384.45 query35 4.504.494.52 query36 0.630.460.47 query37 0.170.160.15 query38 0.150.150.14 query39 0.050.040.03 query40 0.160.130.14 query41 0.090.050.04 query42 0.060.050.04 query43 0.040.030.04 Total cold run time: 110.43 s Total hot run time: 30.12 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [config](routine-load) adjusting the default configuration of routing load [doris]
doris-robot commented on PR #34898: URL: https://github.com/apache/doris/pull/34898#issuecomment-2111735765 TeamCity be ut coverage result: Function Coverage: 35.65% (8983/25195) Line Coverage: 27.32% (74259/271860) Region Coverage: 26.55% (38380/144543) Branch Coverage: 23.36% (19569/83754) Coverage Report: http://coverage.selectdb-in.cc/coverage/344282e967961a12fbc0c7ed19a1a8ecbc2e414b_344282e967961a12fbc0c7ed19a1a8ecbc2e414b/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [docs](doc) Update: Bitmap->BloomFilter in Table Design Best Practice [doris-website]
httpshirley opened a new pull request, #652: URL: https://github.com/apache/doris-website/pull/652 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) money format [doris]
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111748134 TPC-DS: Total hot run time: 186790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 598ab34fb3f663fe300f3140c7298332dd75a4a2, data reload: false query1 923 398 378 378 query2 6448243023312331 query3 6651210 210 210 query4 24377 21225 21348 21225 query5 4130411 415 411 query6 259 181 185 181 query7 4586295 304 295 query8 239 195 197 195 query9 8514242624272426 query10 434 240 262 240 query11 14643 14240 14202 14202 query12 146 88 87 87 query13 1637374 380 374 query14 10686 840773257325 query15 250 189 176 176 query16 8181258 259 258 query17 1890566 537 537 query18 2110276 271 271 query19 220 148 146 146 query20 93 85 86 85 query21 196 123 129 123 query22 5082488148324832 query23 34300 33694 33380 33380 query24 11604 294828612861 query25 656 367 393 367 query26 1755156 152 152 query27 2901326 321 321 query28 7293205520372037 query29 1014619 601 601 query30 307 173 182 173 query31 985 759 752 752 query32 94 50 55 50 query33 750 261 246 246 query34 1066481 488 481 query35 800 675 670 670 query36 1079922 948 922 query37 179 71 75 71 query38 2931281327782778 query39 1627159815621562 query40 284 128 128 128 query41 50 46 48 46 query42 103 99 95 95 query43 582 541 568 541 query44 1183721 738 721 query45 284 254 261 254 query46 1091715 700 700 query47 1950188218891882 query48 377 305 307 305 query49 1206409 431 409 query50 759 391 385 385 query51 6758666567616665 query52 100 89 90 89 query53 352 280 293 280 query54 991 430 435 430 query55 74 71 71 71 query56 237 223 219 219 query57 1244114911681149 query58 246 203 218 203 query59 3394312531283125 query60 248 233 234 233 query61 93 89 87 87 query62 685 472 461 461 query63 307 290 279 279 query64 9706739273277327 query65 3159309530783078 query66 1393345 354 345 query67 15228 14969 14844 14844 query68 5708540 585 540 query69 525 308 308 308 query70 1187113510861086 query71 452 270 276 270 query72 7697254324192419 query73 718 329 331 329 query74 6689614960906090 query75 3982265326492649 query76 3682987 944 944 query77 639 265 265 265 query78 10627 10098 10174 10098 query79 2338498 511 498 query80 885 433 432 432 query81 518 251 246 246 query82 132597 91 91 query83 240 163 164 163 query84 236 82 84 82 query85 1527300 309 300 query86 472 327 309 309 query87 3272310831143108 query88 3892242824322428 query89 480 387 382 382 query90 1965193 201 193 query91 133 110 107 107 query92 60 48 53 48 query93 2028522 489 489 query94 1268179 183 179 query95 392 296 299 296 query96 579 262 264 262 query97 3138301929772977 query98 234 226 228 226 query99 1136899 893 893 Total cold run time: 291144 ms Total hot run time: 186790 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](ci) clear coredump files to avoid disk full [doris]
doris-robot commented on PR #34900: URL: https://github.com/apache/doris/pull/34900#issuecomment-2111750036 TPC-H: Total hot run time: 41866 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6cfabc18dd8802690b1ee83cf297613e9090bc2b, data reload: false -- Round 1 -- q1 17610 428942284228 q2 2018194 196 194 q3 10466 128612311231 q4 10198 742 780 742 q5 7464275727912757 q6 218 130 132 130 q7 1033626 597 597 q8 9238215420912091 q9 9988675267896752 q10 9598384238823842 q11 449 244 237 237 q12 532 215 243 215 q13 18339 315831743158 q14 266 211 222 211 q15 508 478 485 478 q16 531 397 396 396 q17 969 676 633 633 q18 8364774976927692 q19 3490152915061506 q20 650 321 312 312 q21 5399422941864186 q22 363 297 278 278 Total cold run time: 117691 ms Total hot run time: 41866 ms - Round 2, with runtime_filter_mode=off - q1 4553439843614361 q2 388 274 266 266 q3 3163297927432743 q4 1869159116211591 q5 5538550254855485 q6 218 124 129 124 q7 2362194720051947 q8 3227334234043342 q9 8681869686218621 q10 3906384838833848 q11 589 489 498 489 q12 780 618 635 618 q13 16115 318831583158 q14 288 272 268 268 q15 531 463 491 463 q16 467 421 449 421 q17 1764145914621459 q18 7714762675037503 q19 1661150915831509 q20 1953178217311731 q21 9565503648954895 q22 576 497 509 497 Total cold run time: 75908 ms Total hot run time: 55339 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](binlog) Support gc binlogs by history nums and size [doris]
doris-robot commented on PR #34888: URL: https://github.com/apache/doris/pull/34888#issuecomment-2111750121 TPC-H: Total hot run time: 41871 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7f471774815824514c34a7db9660e769c54f69e0, data reload: false -- Round 1 -- q1 17598 436242414241 q2 2016191 184 184 q3 10449 123512561235 q4 10213 821 812 812 q5 7484270627082706 q6 221 129 135 129 q7 1033604 606 604 q8 9220215420772077 q9 9853672467256724 q10 9235388338283828 q11 450 248 250 248 q12 447 219 243 219 q13 17510 313831463138 q14 265 228 227 227 q15 509 477 465 465 q16 471 396 381 381 q17 983 713 724 713 q18 8406773977067706 q19 6429159115201520 q20 652 320 319 319 q21 5182411343104113 q22 350 297 282 282 Total cold run time: 118976 ms Total hot run time: 41871 ms - Round 2, with runtime_filter_mode=off - q1 4678447044544454 q2 374 264 262 262 q3 3182294229032903 q4 1838161216211612 q5 5476547354675467 q6 220 127 133 127 q7 2317198019841980 q8 3255338433763376 q9 8610870285938593 q10 3895379038353790 q11 588 497 518 497 q12 806 629 638 629 q13 16017 316032163160 q14 305 291 278 278 q15 521 472 480 472 q16 464 402 406 402 q17 1734147714731473 q18 7685755273647364 q19 2267152515331525 q20 1968177917601760 q21 5890482647854785 q22 604 498 495 495 Total cold run time: 72694 ms Total hot run time: 55404 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]
doris-robot commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2111750991 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b7012c64fdb8580e5b509931c413f8a78bb4eb69 with default session variables Insert into select: 20.0 seconds inserted 1000 Rows, about 500K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto inc) Fix multiple replica partial update auto inc data inconsistency problem [doris]
github-actions[bot] commented on PR #34788: URL: https://github.com/apache/doris/pull/34788#issuecomment-2111752415 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) money format [doris]
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111757438 ClickBench: Total hot run time: 31.4 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 598ab34fb3f663fe300f3140c7298332dd75a4a2, data reload: false query1 0.040.030.04 query2 0.080.030.04 query3 0.230.050.05 query4 1.680.070.07 query5 0.510.480.50 query6 1.120.720.72 query7 0.020.010.02 query8 0.050.040.04 query9 0.540.500.48 query10 0.540.550.54 query11 0.150.110.12 query12 0.160.110.12 query13 0.600.590.59 query14 0.770.790.77 query15 0.820.820.81 query16 0.370.380.36 query17 1.001.020.96 query18 0.210.240.26 query19 1.871.671.67 query20 0.010.010.02 query21 15.55 0.670.65 query22 4.566.692.80 query23 18.33 1.401.33 query24 1.430.280.27 query25 0.140.080.08 query26 0.250.170.16 query27 0.080.070.08 query28 13.34 1.011.01 query29 13.20 3.253.30 query30 0.240.060.05 query31 2.850.400.38 query32 3.280.460.47 query33 2.822.882.86 query34 17.18 4.494.39 query35 4.504.524.54 query36 0.650.460.46 query37 0.170.160.15 query38 0.160.140.14 query39 0.040.030.04 query40 0.170.140.14 query41 0.090.040.05 query42 0.050.040.04 query43 0.040.040.04 Total cold run time: 109.89 s Total hot run time: 31.4 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111759264 TPC-H: Total hot run time: 40655 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8b9b51a5c491abfe210d116405c0dc5b25edc4f2, data reload: false -- Round 1 -- q1 17603 440843054305 q2 2014198 194 194 q3 10453 126011681168 q4 10142 865 785 785 q5 7460271826112611 q6 217 132 132 132 q7 991 604 582 582 q8 9225210420802080 q9 8922656365046504 q10 8848371337133713 q11 465 243 239 239 q12 420 219 221 219 q13 17764 297229952972 q14 269 219 242 219 q15 509 479 470 470 q16 496 390 384 384 q17 986 645 693 645 q18 8033744575667445 q19 1616151414611461 q20 655 307 305 305 q21 5019394039623940 q22 347 282 293 282 Total cold run time: 112454 ms Total hot run time: 40655 ms - Round 2, with runtime_filter_mode=off - q1 4303429442544254 q2 375 263 262 262 q3 3012276727312731 q4 1869156915771569 q5 5286526452565256 q6 216 125 126 125 q7 2241188819481888 q8 3193338433203320 q9 8401835584058355 q10 3878375237123712 q11 585 483 478 478 q12 748 556 598 556 q13 16314 296829732968 q14 269 273 265 265 q15 520 474 470 470 q16 458 411 412 411 q17 1761149814601460 q18 7576769174897489 q19 2311158715431543 q20 1978177917511751 q21 4893499247814781 q22 590 513 483 483 Total cold run time: 70777 ms Total hot run time: 54127 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
freemandealer commented on code in PR #34615:
URL: https://github.com/apache/doris/pull/34615#discussion_r1601088953
##
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##
@@ -697,15 +700,29 @@ private CacheTable
buildCacheTableForOlapScanNode(OlapScanNode node) {
CatalogIf catalog = database.getCatalog();
ScanTable scanTable = new ScanTable(
new FullTableName(catalog.getName(), database.getFullName(),
olapTable.getName()),
-olapTable.getVisibleVersionTime(),
olapTable.getVisibleVersion());
+olapTable.getVisibleVersion());
scanTables.add(scanTable);
+if (Config.isCloudMode()) {
+// get version of related partitions in batch
Review Comment:
> How about extracting this operation into `OlapTable`, just like
`OlapTable.selectNonEmptyPartitionIds`?
The one in NereidssqlCacheManager doesn't use OlapTable but ScanTable, I
have no handy idea to unify the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix query mem tracker log when destruction not equal to 0 [doris]
doris-robot commented on PR #34901: URL: https://github.com/apache/doris/pull/34901#issuecomment-2111762071 TPC-H: Total hot run time: 41841 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3f45e796c3a8308f6abf45e96f62bceb1ff26b10, data reload: false -- Round 1 -- q1 17588 429442354235 q2 2006183 186 183 q3 10489 120011851185 q4 10199 863 862 862 q5 7475272027142714 q6 230 130 132 130 q7 1024603 593 593 q8 9238213120772077 q9 9708671366196619 q10 9069387738643864 q11 452 235 251 235 q12 417 234 233 233 q13 17201 328331723172 q14 279 220 230 220 q15 514 481 475 475 q16 498 396 400 396 q17 985 743 682 682 q18 8190793678317831 q19 4730154114921492 q20 643 331 308 308 q21 5138414340604060 q22 350 275 296 275 Total cold run time: 116423 ms Total hot run time: 41841 ms - Round 2, with runtime_filter_mode=off - q1 4508441243614361 q2 372 252 272 252 q3 3202293729522937 q4 1892159615821582 q5 5461549954915491 q6 218 126 129 126 q7 2291195820031958 q8 3253336033783360 q9 8641869286848684 q10 3880376038603760 q11 613 498 508 498 q12 792 634 638 634 q13 16255 311631793116 q14 309 259 267 259 q15 527 496 496 496 q16 460 410 415 410 q17 1765147414591459 q18 7570762474017401 q19 1632150215561502 q20 1939175417891754 q21 6127488048354835 q22 570 499 497 497 Total cold run time: 72277 ms Total hot run time: 55372 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
doris-robot commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111765198 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix query mem tracker log when destruction not equal to 0 [doris]
doris-robot commented on PR #34901: URL: https://github.com/apache/doris/pull/34901#issuecomment-2111765276 TeamCity be ut coverage result: Function Coverage: 35.65% (8981/25195) Line Coverage: 27.31% (74245/271861) Region Coverage: 26.54% (38362/144541) Branch Coverage: 23.36% (19566/83752) Coverage Report: http://coverage.selectdb-in.cc/coverage/3f45e796c3a8308f6abf45e96f62bceb1ff26b10_3f45e796c3a8308f6abf45e96f62bceb1ff26b10/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
airborne12 commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111765616 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
freemandealer commented on code in PR #34615:
URL: https://github.com/apache/doris/pull/34615#discussion_r1601093527
##
fe/fe-core/src/main/java/org/apache/doris/qe/cache/CacheAnalyzer.java:
##
@@ -697,15 +700,29 @@ private CacheTable
buildCacheTableForOlapScanNode(OlapScanNode node) {
CatalogIf catalog = database.getCatalog();
ScanTable scanTable = new ScanTable(
new FullTableName(catalog.getName(), database.getFullName(),
olapTable.getName()),
-olapTable.getVisibleVersionTime(),
olapTable.getVisibleVersion());
+olapTable.getVisibleVersion());
scanTables.add(scanTable);
+if (Config.isCloudMode()) {
+// get version of related partitions in batch
Review Comment:
Ops! On second thought, I think can give it a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
airborne12 opened a new pull request, #34903: URL: https://github.com/apache/doris/pull/34903 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
airborne12 closed pull request #34903: [Fix](inverted index) fix wrong fs in inverted_index_file_writer URL: https://github.com/apache/doris/pull/34903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [Fix](regression-test) Fix test_hive_write_type. (#34667)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new ab9ff0447da [Fix](regression-test) Fix test_hive_write_type. (#34667)
ab9ff0447da is described below
commit ab9ff0447dacf780a6d3ea353412a6f117a75228
Author: Qi Chen
AuthorDate: Wed May 15 11:34:14 2024 +0800
[Fix](regression-test) Fix test_hive_write_type. (#34667)
Because #34397 changed error code of ARITHMETIC_OVERFLOW_ERRROR, so the
error msg is not expected in the test.
---
.../suites/external_table_p0/hive/ddl/test_hive_write_type.groovy | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/regression-test/suites/external_table_p0/hive/ddl/test_hive_write_type.groovy
b/regression-test/suites/external_table_p0/hive/ddl/test_hive_write_type.groovy
index 5b8870d4b71..cf3bd2a9037 100644
---
a/regression-test/suites/external_table_p0/hive/ddl/test_hive_write_type.groovy
+++
b/regression-test/suites/external_table_p0/hive/ddl/test_hive_write_type.groovy
@@ -197,7 +197,7 @@ suite("test_hive_write_type",
"p0,external,hive,external_docker,external_docker_
} catch (Exception e) {
log.info(e.getMessage())
// BE err msg need use string contains to check
-assertTrue(e.getMessage().contains("[E-124]Arithmetic
overflow, convert failed from 1234567, expected data is [-99, 99]"))
+assertTrue(e.getMessage().contains("Arithmetic overflow,
convert failed from 1234567, expected data is [-99, 99]"))
}
try {
@@ -208,7 +208,7 @@ suite("test_hive_write_type",
"p0,external,hive,external_docker,external_docker_
"""
} catch (Exception e) {
log.info(e.getMessage())
-assertTrue(e.getMessage().contains("[E-124]Arithmetic
overflow, convert failed from 1234567, expected data is [-99, 99]"))
+assertTrue(e.getMessage().contains("Arithmetic overflow,
convert failed from 1234567, expected data is [-99, 99]"))
}
test {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](ci) clear coredump files to avoid disk full [doris]
doris-robot commented on PR #34900: URL: https://github.com/apache/doris/pull/34900#issuecomment-2111770048 TPC-DS: Total hot run time: 187426 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6cfabc18dd8802690b1ee83cf297613e9090bc2b, data reload: false query1 893 388 365 365 query2 6439249723102310 query3 6649200 208 200 query4 22972 21186 21184 21184 query5 4111411 416 411 query6 257 178 169 169 query7 4590296 284 284 query8 247 200 197 197 query9 8648240223752375 query10 452 248 256 248 query11 15028 14177 14159 14159 query12 142 91 89 89 query13 1649382 374 374 query14 10619 837883918378 query15 241 170 175 170 query16 8012252 264 252 query17 1760546 535 535 query18 2048273 265 265 query19 194 147 147 147 query20 91 82 84 82 query21 192 124 121 121 query22 5062482148644821 query23 34148 33477 33642 33477 query24 6436286328572857 query25 536 370 362 362 query26 694 160 153 153 query27 1941316 324 316 query28 3577205920572057 query29 856 609 598 598 query30 247 175 181 175 query31 981 750 730 730 query32 92 52 76 52 query33 487 249 241 241 query34 895 464 487 464 query35 750 675 688 675 query36 1066932 921 921 query37 108 68 70 68 query38 2891277527582758 query39 1617155715811557 query40 202 126 126 126 query41 49 42 46 42 query42 104 94 97 94 query43 584 545 549 545 query44 1037718 746 718 query45 265 248 221 221 query46 1072695 717 695 query47 1963189518731873 query48 377 301 297 297 query49 770 389 389 389 query50 774 375 387 375 query51 6811678868056788 query52 99 91 89 89 query53 352 285 280 280 query54 528 442 437 437 query55 77 71 73 71 query56 262 227 226 226 query57 1225114011371137 query58 229 240 203 203 query59 3361298531082985 query60 251 225 233 225 query61 89 87 90 87 query62 602 487 459 459 query63 312 284 283 283 query64 8367728974227289 query65 3105308030833080 query66 791 341 325 325 query67 15435 14891 15207 14891 query68 4545533 530 530 query69 491 307 297 297 query70 1204115311581153 query71 367 262 263 262 query72 7095261123892389 query73 708 320 319 319 query74 6529616160336033 query75 3347263126712631 query76 22841008981 981 query77 434 262 258 258 query78 10528 10287 10217 10217 query79 1245504 519 504 query80 892 420 420 420 query81 522 245 245 245 query82 965 106 102 102 query83 304 166 159 159 query84 239 85 85 85 query85 933 270 261 261 query86 417 299 308 299 query87 3299307030863070 query88 2988240623852385 query89 470 378 385 378 query90 1976186 182 182 query91 125 98 97 97 query92 55 48 54 48 query93 1031505 492 492 query94 1058177 186 177 query95 392 298 296 296 query96 574 267 262 262 query97 3166297229982972 query98 245 219 222 219 query99 1189903 876 876 Total cold run time: 266328 ms Total hot run time: 187426 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [feature](binlog) Support gc binlogs by history nums and size [doris]
doris-robot commented on PR #34888: URL: https://github.com/apache/doris/pull/34888#issuecomment-2111770380 TPC-DS: Total hot run time: 186945 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7f471774815824514c34a7db9660e769c54f69e0, data reload: false query1 903 389 363 363 query2 6444236024512360 query3 6654203 207 203 query4 23070 21050 21374 21050 query5 4141437 437 437 query6 262 188 175 175 query7 4585299 294 294 query8 273 200 194 194 query9 8607242624082408 query10 443 276 255 255 query11 14750 14239 14099 14099 query12 133 91 88 88 query13 1636384 380 380 query14 9695769079377690 query15 225 175 171 171 query16 7893270 270 270 query17 1712566 594 566 query18 2004273 271 271 query19 186 150 152 150 query20 94 83 82 82 query21 201 135 128 128 query22 5045488848874887 query23 34316 33683 33611 33611 query24 10593 287828662866 query25 562 381 364 364 query26 697 162 151 151 query27 2212320 321 320 query28 5621206120442044 query29 852 612 621 612 query30 274 175 179 175 query31 982 771 746 746 query32 93 50 55 50 query33 659 247 245 245 query34 889 512 499 499 query35 789 684 687 684 query36 1097956 912 912 query37 111 70 76 70 query38 2856276127142714 query39 1588155015671550 query40 198 125 125 125 query41 47 45 42 42 query42 102 96 100 96 query43 569 568 545 545 query44 1057722 736 722 query45 265 255 251 251 query46 1065760 741 741 query47 1948189518731873 query48 369 303 299 299 query49 881 396 401 396 query50 753 395 397 395 query51 6800677267426742 query52 102 87 94 87 query53 351 287 297 287 query54 856 426 437 426 query55 76 72 72 72 query56 237 217 216 216 query57 1196112911411129 query58 215 203 198 198 query59 3299317930923092 query60 248 230 234 230 query61 92 87 114 87 query62 652 475 475 475 query63 312 286 289 286 query64 8404732473377324 query65 3125306230763062 query66 775 346 343 343 query67 15506 15154 14855 14855 query68 4552529 538 529 query69 537 340 318 318 query70 1229107311591073 query71 404 270 268 268 query72 8138257323612361 query73 699 332 333 332 query74 6536613961266126 query75 3410267326022602 query76 3106975 911 911 query77 575 258 264 258 query78 10695 10077 99699969 query79 1444527 531 527 query80 823 439 433 433 query81 537 249 244 244 query82 635 98 98 98 query83 230 162 168 162 query84 248 85 84 84 query85 1416313 262 262 query86 461 289 291 289 query87 3284316831523152 query88 4167241324082408 query89 461 382 382 382 query90 1928187 198 187 query91 137 96 99 96 query92 56 48 48 48 query93 1849516 501 501 query94 1182180 190 180 query95 389 312 306 306 query96 585 273 275 273 query97 3164296229582958 query98 233 224 208 208 query99 1187902 870 870 Total cold run time: 276944 ms Total hot run time: 186945 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s
Re: [I] Doris support OpenTelemetry data store [Feature] [doris]
bunkrur commented on issue #32242: URL: https://github.com/apache/doris/issues/32242#issuecomment-2111770876 Wouldn't you just create a table for each signal type? The otel spec can easily be transformed in this way. I think you're looking for a collector exporter that can perform ingestion to a set of tables per signal type, rather than support for a table based on the otel schema? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
github-actions[bot] commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111773988 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
github-actions[bot] commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111774981 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): fix some bugs in or expansion [doris]
jackwener merged PR #34837: URL: https://github.com/apache/doris/pull/34837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](Nereids): fix some bugs in or expansion (#34837)
This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1e4a69c2a43 [fix](Nereids): fix some bugs in or expansion (#34837)
1e4a69c2a43 is described below
commit 1e4a69c2a43ae0078092bd709008a313cad280a4
Author: 谢健
AuthorDate: Wed May 15 15:27:05 2024 +0800
[fix](Nereids): fix some bugs in or expansion (#34837)
add unit test
---
.../doris/nereids/rules/rewrite/OrExpansion.java | 25 ++
.../trees/copier/LogicalPlanDeepCopier.java| 8 ++-
.../nereids/rules/rewrite/OrExpansionTest.java | 4
3 files changed, 36 insertions(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/OrExpansion.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/OrExpansion.java
index 9f9257f5f60..61a90e3aea4 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/OrExpansion.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/OrExpansion.java
@@ -104,6 +104,31 @@ public class OrExpansion extends
DefaultPlanRewriter implem
return hasNewChildren ? plan.withChildren(newChildren) : plan;
}
+@Override
+public Plan visitLogicalCTEAnchor(
+LogicalCTEAnchor anchor,
OrExpandsionContext ctx) {
+Plan child1 = anchor.child(0).accept(this, ctx);
+// Consumer's CTE must be child of the cteAnchor in this case:
+// anchor
+// +-producer1
+// +-agg(consumer1) join agg(consumer1)
+// >
+// anchor
+// +-producer1
+// +-anchor
+// +--producer2(agg2(consumer1))
+// +--producer3(agg3(consumer1))
+// +-consumer2 join consumer3
+OrExpandsionContext consumerContext =
+new OrExpandsionContext(ctx.statementContext,
ctx.cascadesContext);
+Plan child2 = anchor.child(1).accept(this, consumerContext);
+for (int i = consumerContext.cteProducerList.size() - 1; i >= 0; i--) {
+LogicalCTEProducer producer =
consumerContext.cteProducerList.get(i);
+child2 = new LogicalCTEAnchor<>(producer.getCteId(), producer,
child2);
+}
+return anchor.withChildren(ImmutableList.of(child1, child2));
+}
+
@Override
public Plan visitLogicalJoin(LogicalJoin
join, OrExpandsionContext ctx) {
join = (LogicalJoin) this.visit(join,
ctx);
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
index dfa881aa2e6..197de0089a3 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
@@ -340,8 +340,14 @@ public class LogicalPlanDeepCopier extends
DefaultPlanRewriter markJoinConjuncts =
join.getMarkJoinConjuncts().stream()
.map(c -> ExpressionDeepCopier.INSTANCE.deepCopy(c, context))
.collect(ImmutableList.toImmutableList());
+Optional markJoinSlotReference =
Optional.empty();
+if (join.getMarkJoinSlotReference().isPresent()) {
+markJoinSlotReference = Optional.of((MarkJoinSlotReference)
ExpressionDeepCopier.INSTANCE
+.deepCopy(join.getMarkJoinSlotReference().get(), context));
+
+}
return new LogicalJoin<>(join.getJoinType(), hashJoinConjuncts,
otherJoinConjuncts, markJoinConjuncts,
-join.getDistributeHint(), join.getMarkJoinSlotReference(),
children, join.getJoinReorderContext());
+join.getDistributeHint(), markJoinSlotReference, children,
join.getJoinReorderContext());
}
@Override
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/OrExpansionTest.java
b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/OrExpansionTest.java
index 9f8bd8bcc55..0f2d9418bff 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/OrExpansionTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/OrExpansionTest.java
@@ -19,6 +19,7 @@ package org.apache.doris.nereids.rules.rewrite;
import org.apache.doris.nereids.trees.plans.Plan;
import org.apache.doris.nereids.trees.plans.logical.LogicalCTEAnchor;
+import org.apache.doris.nereids.trees.plans.logical.LogicalCTEConsumer;
import org.apache.doris.nereids.util.MemoPatternMatchSupported;
import org.apache.doris.nereids.util.PlanChecker;
import org.apache.doris.utframe.TestWithFeService;
@@ -81,6 +82,9 @@ class OrExpansionTest extends TestWithFeService implements
MemoPatternMatchSuppo
Assertions.assertTrue(plan instanceof LogicalCTE
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111778836 TPC-DS: Total hot run time: 186606 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8b9b51a5c491abfe210d116405c0dc5b25edc4f2, data reload: false query1 925 382 371 371 query2 6482246623162316 query3 6654209 212 209 query4 24198 21243 21457 21243 query5 4181421 432 421 query6 264 174 176 174 query7 4581297 296 296 query8 241 189 195 189 query9 8575242423852385 query10 458 254 254 254 query11 14776 14232 14283 14232 query12 129 94 87 87 query13 1630365 363 363 query14 10736 736068766876 query15 206 170 178 170 query16 7823263 277 263 query17 1636543 551 543 query18 1949288 269 269 query19 205 152 147 147 query20 92 85 90 85 query21 194 125 130 125 query22 4990484149084841 query23 34201 33514 33507 33507 query24 11279 288028152815 query25 612 368 370 368 query26 1037157 153 153 query27 2339319 333 319 query28 6743207420732073 query29 853 603 605 603 query30 296 169 178 169 query31 988 757 747 747 query32 96 57 53 53 query33 747 254 249 249 query34 1044475 488 475 query35 821 684 695 684 query36 1075885 912 885 query37 107 74 73 73 query38 2895276527342734 query39 1729157615421542 query40 199 128 124 124 query41 48 45 44 44 query42 104 99 103 99 query43 583 555 528 528 query44 1229720 733 720 query45 271 257 256 256 query46 1096686 715 686 query47 1926187618681868 query48 376 300 293 293 query49 1092407 428 407 query50 771 387 401 387 query51 6831678367766776 query52 107 96 86 86 query53 349 298 294 294 query54 884 426 421 421 query55 75 74 73 73 query56 252 226 224 224 query57 1213115911291129 query58 220 216 208 208 query59 3519310331023102 query60 254 236 240 236 query61 92 89 87 87 query62 680 508 453 453 query63 309 290 290 290 query64 8743740874217408 query65 3172308731043087 query66 812 351 338 338 query67 15316 14979 14800 14800 query68 4672539 535 535 query69 486 306 314 306 query70 1185104011041040 query71 441 274 278 274 query72 7816269624762476 query73 701 325 329 325 query74 6459612461096109 query75 3408267526532653 query76 2888915 931 915 query77 426 272 272 272 query78 10633 10213 10242 10213 query79 2408519 522 519 query80 1129456 459 456 query81 548 240 254 240 query82 655 99 99 99 query83 255 171 170 170 query84 248 90 88 88 query85 1619323 311 311 query86 491 319 305 305 query87 3255306930993069 query88 4202243024252425 query89 484 377 383 377 query90 1977190 192 190 query91 155 110 107 107 query92 63 51 50 50 query93 2046519 500 500 query94 1222188 188 188 query95 396 312 311 311 query96 595 278 271 271 query97 3169297830152978 query98 236 227 218 218 query99 1205884 909 884 Total cold run time: 283783 ms Total hot run time: 186606 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](ci) clear coredump files to avoid disk full [doris]
doris-robot commented on PR #34900: URL: https://github.com/apache/doris/pull/34900#issuecomment-2111778873 ClickBench: Total hot run time: 29.85 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6cfabc18dd8802690b1ee83cf297613e9090bc2b, data reload: false query1 0.040.030.03 query2 0.080.030.04 query3 0.230.050.05 query4 1.670.090.09 query5 0.500.490.51 query6 1.120.720.72 query7 0.020.020.01 query8 0.050.040.04 query9 0.540.490.48 query10 0.580.550.54 query11 0.150.110.11 query12 0.150.110.12 query13 0.580.580.60 query14 0.770.780.78 query15 0.830.800.81 query16 0.360.350.37 query17 0.980.960.99 query18 0.240.220.23 query19 1.791.711.70 query20 0.020.010.01 query21 15.44 0.710.67 query22 4.727.361.45 query23 18.31 1.421.19 query24 1.840.270.19 query25 0.150.070.07 query26 0.250.160.16 query27 0.080.080.08 query28 13.36 1.020.99 query29 13.34 3.343.30 query30 0.240.060.06 query31 2.890.370.38 query32 3.280.460.47 query33 2.812.842.88 query34 17.17 4.424.42 query35 4.484.484.63 query36 0.650.460.46 query37 0.180.140.15 query38 0.140.150.14 query39 0.040.040.03 query40 0.160.140.13 query41 0.080.040.05 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 110.41 s Total hot run time: 29.85 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](binlog) Support gc binlogs by history nums and size [doris]
doris-robot commented on PR #34888: URL: https://github.com/apache/doris/pull/34888#issuecomment-2111779263 ClickBench: Total hot run time: 29.95 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7f471774815824514c34a7db9660e769c54f69e0, data reload: false query1 0.040.030.04 query2 0.080.040.04 query3 0.240.050.05 query4 1.670.070.08 query5 0.490.490.53 query6 1.140.720.72 query7 0.020.020.01 query8 0.040.040.05 query9 0.540.480.49 query10 0.530.550.55 query11 0.150.110.12 query12 0.140.120.12 query13 0.590.580.59 query14 0.770.790.76 query15 0.830.810.80 query16 0.360.370.37 query17 1.011.010.95 query18 0.220.250.24 query19 1.791.771.74 query20 0.010.010.01 query21 15.63 0.660.65 query22 3.848.341.46 query23 18.35 1.321.27 query24 2.060.200.21 query25 0.130.090.08 query26 0.260.160.16 query27 0.080.080.07 query28 13.27 1.000.98 query29 13.84 3.353.34 query30 0.240.060.05 query31 2.870.400.38 query32 3.280.460.46 query33 2.862.812.92 query34 17.30 4.384.40 query35 4.494.464.69 query36 0.660.460.46 query37 0.170.160.15 query38 0.160.140.15 query39 0.050.030.04 query40 0.160.140.15 query41 0.090.040.05 query42 0.050.050.04 query43 0.040.040.04 Total cold run time: 110.54 s Total hot run time: 29.95 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix query mem tracker log when destruction not equal to 0 [doris]
doris-robot commented on PR #34901: URL: https://github.com/apache/doris/pull/34901#issuecomment-2111780536 TPC-DS: Total hot run time: 186706 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3f45e796c3a8308f6abf45e96f62bceb1ff26b10, data reload: false query1 907 464 369 369 query2 6942238124792381 query3 6647206 215 206 query4 22816 21235 21135 21135 query5 4124411 412 411 query6 263 172 175 172 query7 4586293 286 286 query8 235 193 191 191 query9 8454240323912391 query10 436 254 258 254 query11 14603 14174 14168 14168 query12 136 89 88 88 query13 1656377 377 377 query14 8716771675857585 query15 214 169 175 169 query16 7927261 257 257 query17 1737549 551 549 query18 2038283 269 269 query19 200 149 147 147 query20 91 85 84 84 query21 196 130 128 128 query22 5097486948584858 query23 34106 33301 33632 33301 query24 7275285928712859 query25 574 365 367 365 query26 702 157 152 152 query27 2190312 329 312 query28 5319205420592054 query29 846 616 608 608 query30 283 174 174 174 query31 964 747 746 746 query32 91 53 53 53 query33 494 252 250 250 query34 857 473 480 473 query35 765 685 674 674 query36 1024919 925 919 query37 108 67 71 67 query38 2883281527702770 query39 1604154615611546 query40 189 126 124 124 query41 44 43 43 43 query42 107 92 95 92 query43 587 560 558 558 query44 1047715 721 715 query45 265 256 225 225 query46 1064754 713 713 query47 1968188819041888 query48 363 293 293 293 query49 873 387 390 387 query50 754 377 380 377 query51 6901682467926792 query52 103 90 100 90 query53 350 287 276 276 query54 524 434 428 428 query55 73 70 71 70 query56 244 225 223 223 query57 1231116811541154 query58 211 202 229 202 query59 3301310530303030 query60 290 227 249 227 query61 91 90 88 88 query62 620 475 469 469 query63 307 278 280 278 query64 8438745174097409 query65 3114307131093071 query66 801 367 346 346 query67 15301 14847 15214 14847 query68 4501540 530 530 query69 471 303 309 303 query70 1188114511611145 query71 352 258 265 258 query72 7226260323402340 query73 704 324 326 324 query74 6522607961366079 query75 3254264526032603 query76 23191049959 959 query77 392 263 259 259 query78 10585 10133 10226 10133 query79 2347507 518 507 query80 1075436 423 423 query81 527 237 242 237 query82 721 95 93 93 query83 222 160 171 160 query84 242 88 88 88 query85 1080270 262 262 query86 449 329 318 318 query87 3291307431023074 query88 4172240323892389 query89 470 373 378 373 query90 2044183 183 183 query91 123 97 99 97 query92 60 56 48 48 query93 1701524 501 501 query94 1137178 180 178 query95 401 305 299 299 query96 587 280 266 266 query97 3147294729602947 query98 250 228 218 218 query99 1165915 899 899 Total cold run time: 269992 ms Total hot run time: 186706 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
(doris) branch master updated (1e4a69c2a43 -> 5da8ee80dc8)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 1e4a69c2a43 [fix](Nereids): fix some bugs in or expansion (#34837) add 5da8ee80dc8 [fix](nereids)single side info is missing when pushing min-max runtime filter into cte (#34862) No new revisions were added by this update. Summary of changes: .../java/org/apache/doris/common/IdGenerator.java |1 + .../processor/post/RuntimeFilterGenerator.java |2 +- .../trees/plans/physical/RuntimeFilter.java|4 +- .../data/query_p0/join/rqg/rqg4265/rqg4265.out | 1451 .../query_p0/join/rqg/rqg4265/rqg4265.groovy | 219 +++ 5 files changed, 1674 insertions(+), 3 deletions(-) create mode 100644 regression-test/data/query_p0/join/rqg/rqg4265/rqg4265.out create mode 100644 regression-test/suites/query_p0/join/rqg/rqg4265/rqg4265.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)single side info is missing when pushing min-max runtime filter into cte [doris]
englefly merged PR #34862: URL: https://github.com/apache/doris/pull/34862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Nereids) fix leading with cte and same subqueryalias name [doris]
LiBinfeng-01 commented on PR #34838: URL: https://github.com/apache/doris/pull/34838#issuecomment-2111783893 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111788014 ClickBench: Total hot run time: 30.89 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8b9b51a5c491abfe210d116405c0dc5b25edc4f2, data reload: false query1 0.040.030.03 query2 0.080.030.04 query3 0.230.040.04 query4 1.670.060.07 query5 0.500.480.50 query6 1.120.730.73 query7 0.020.010.01 query8 0.050.040.04 query9 0.530.490.48 query10 0.550.550.54 query11 0.150.110.12 query12 0.140.120.12 query13 0.590.590.59 query14 0.790.780.78 query15 0.840.820.80 query16 0.350.340.35 query17 1.020.960.96 query18 0.210.270.23 query19 1.851.791.74 query20 0.020.010.02 query21 15.71 0.670.65 query22 4.057.542.25 query23 18.57 1.361.29 query24 1.890.250.21 query25 0.160.090.09 query26 0.260.160.16 query27 0.070.080.08 query28 13.30 1.011.01 query29 13.16 3.283.24 query30 0.240.060.06 query31 2.880.390.39 query32 3.270.490.48 query33 2.862.862.87 query34 16.96 4.454.45 query35 4.514.574.51 query36 0.650.460.46 query37 0.160.150.16 query38 0.150.150.14 query39 0.040.040.03 query40 0.160.130.14 query41 0.090.050.04 query42 0.050.050.05 query43 0.040.040.04 Total cold run time: 109.98 s Total hot run time: 30.89 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](memory) Fix query mem tracker log when destruction not equal to 0 [doris]
doris-robot commented on PR #34901: URL: https://github.com/apache/doris/pull/34901#issuecomment-2111789610 ClickBench: Total hot run time: 30.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3f45e796c3a8308f6abf45e96f62bceb1ff26b10, data reload: false query1 0.040.030.03 query2 0.080.040.04 query3 0.240.050.05 query4 1.970.070.07 query5 0.510.480.52 query6 1.120.750.73 query7 0.020.010.01 query8 0.050.040.04 query9 0.530.490.48 query10 0.550.550.54 query11 0.150.110.12 query12 0.130.110.12 query13 0.590.590.60 query14 0.770.780.77 query15 0.840.800.82 query16 0.360.370.37 query17 1.021.001.04 query18 0.210.260.23 query19 1.851.721.76 query20 0.010.000.00 query21 15.48 0.680.66 query22 4.207.152.14 query23 18.29 1.301.32 query24 1.580.320.21 query25 0.150.080.08 query26 0.260.170.16 query27 0.080.070.08 query28 13.33 1.020.98 query29 13.30 3.323.29 query30 0.240.060.05 query31 2.900.390.39 query32 3.290.450.46 query33 2.822.822.79 query34 17.14 4.394.40 query35 4.494.434.65 query36 0.660.470.48 query37 0.170.160.15 query38 0.150.140.15 query39 0.050.030.04 query40 0.160.140.13 query41 0.090.050.05 query42 0.060.050.05 query43 0.040.030.04 Total cold run time: 109.97 s Total hot run time: 30.61 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
doris-robot commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111793939 TeamCity be ut coverage result: Function Coverage: 35.65% (8983/25195) Line Coverage: 27.32% (74277/271860) Region Coverage: 26.55% (38382/144543) Branch Coverage: 23.37% (19576/83754) Coverage Report: http://coverage.selectdb-in.cc/coverage/973ba892ac7855fbf93141de02b1c0896e3fabf1_973ba892ac7855fbf93141de02b1c0896e3fabf1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num [doris]
ByteYue commented on PR #34863: URL: https://github.com/apache/doris/pull/34863#issuecomment-2111794046 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
doris-robot commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111795582 TPC-H: Total hot run time: 39885 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 973ba892ac7855fbf93141de02b1c0896e3fabf1, data reload: false -- Round 1 -- q1 17803 434842924292 q2 2030195 189 189 q3 10847 125112891251 q4 10799 798 656 656 q5 7864274126682668 q6 217 134 138 134 q7 1017605 585 585 q8 9494210921042104 q9 8963666965616561 q10 9392365637093656 q11 456 230 235 230 q12 500 216 214 214 q13 17798 292129912921 q14 265 213 224 213 q15 500 483 486 483 q16 489 388 375 375 q17 953 663 779 663 q18 8170752574097409 q19 2001154214961496 q20 649 298 310 298 q21 5104384832093209 q22 337 287 278 278 Total cold run time: 115648 ms Total hot run time: 39885 ms - Round 2, with runtime_filter_mode=off - q1 4333420242774202 q2 380 265 276 265 q3 3010274027112711 q4 1859164415861586 q5 5263524953005249 q6 212 122 125 122 q7 2244187318761873 q8 3199331833063306 q9 8384830883368308 q10 3888371137423711 q11 614 502 484 484 q12 769 616 596 596 q13 16325 299629712971 q14 280 268 279 268 q15 512 477 479 477 q16 466 420 432 420 q17 1770147314791473 q18 7818742272907290 q19 1671156015171517 q20 1969176718011767 q21 4889487349834873 q22 583 504 475 475 Total cold run time: 70438 ms Total hot run time: 53944 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
github-actions[bot] commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2111798080 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num [doris]
github-actions[bot] commented on PR #34863: URL: https://github.com/apache/doris/pull/34863#issuecomment-2111797698 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
github-actions[bot] commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2111798024 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Paimon) support deletion vector for Paimon naive reader [doris]
github-actions[bot] commented on code in PR #34743: URL: https://github.com/apache/doris/pull/34743#discussion_r1601120074 ## be/src/vec/exec/format/table/paimon_jni_reader.h: ## @@ -0,0 +1,78 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include Review Comment: warning: inclusion of deprecated C++ header 'stddef.h'; consider using 'cstddef' instead [modernize-deprecated-headers] ```suggestion #include ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
morrySnow commented on code in PR #34894:
URL: https://github.com/apache/doris/pull/34894#discussion_r1601107287
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapScan.java:
##
@@ -311,6 +311,15 @@ public LogicalOlapScan withPreAggStatus(PreAggStatus
preAggStatus) {
hints, cacheSlotWithSlotName, tableSample, directMvScan,
projectPulledUp);
}
+@Override
+public LogicalOlapScan withRelationId(RelationId relationId) {
+return new LogicalOlapScan(relationId, (Table) table, qualifier,
+Optional.empty(), Optional.empty(),
+selectedPartitionIds, partitionPruned, selectedTabletIds,
+selectedIndexId, indexSelected, preAggStatus,
manuallySpecifiedPartitions,
+hints, cacheSlotWithSlotName, tableSample, directMvScan,
projectPulledUp);
Review Comment:
cacheSlotWithSlotName should be removed
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java:
##
Review Comment:
visitLogicalDeferMaterializeOlapScan should also add to relation id map
##
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundTVFRelation.java:
##
@@ -101,6 +101,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional groupExpr
return new UnboundTVFRelation(relationId, functionName, properties,
groupExpression, logicalProperties);
}
+@Override
+public UnboundTVFRelation withRelationId(RelationId relationId) {
+throw new RuntimeException("should not call UnboundTVFRelation's
withRelationId method");
Review Comment:
UnboundException
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOneRowRelation.java:
##
@@ -89,6 +89,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional groupExpr
return new LogicalOneRowRelation(relationId, projects,
groupExpression, logicalProperties);
}
+@Override
+public LogicalOneRowRelation withRelationId(RelationId relationId) {
+return new LogicalOneRowRelation(relationId, projects,
Optional.empty(), Optional.empty());
Review Comment:
should not impl, throw exception
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalEmptyRelation.java:
##
@@ -81,6 +81,11 @@ public Plan
withGroupExprLogicalPropChildren(Optional groupExpr
return new LogicalEmptyRelation(relationId, projects, groupExpression,
logicalProperties);
}
+@Override
+public LogicalEmptyRelation withRelationId(RelationId relationId) {
+return new LogicalEmptyRelation(relationId, projects,
Optional.empty(), Optional.empty());
Review Comment:
throw exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [doc](udf) support struct type in java udf [doris-website]
luzhijing merged PR #634: URL: https://github.com/apache/doris-website/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num [doris]
github-actions[bot] commented on PR #34863: URL: https://github.com/apache/doris/pull/34863#issuecomment-2111801053 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-website) branch master updated: [doc](udf) support struct type in java udf (#634)
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 1c6ba25a38b [doc](udf) support struct type in java udf (#634) 1c6ba25a38b is described below commit 1c6ba25a38bbee25739b1e15164471b125541967 Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com> AuthorDate: Wed May 15 15:41:20 2024 +0800 [doc](udf) support struct type in java udf (#634) --- docs/query/udf/java-user-defined-function.md | 8 --- .../query/udf/java-user-defined-function.md| 15 +--- .../query/udf/java-user-defined-function.md| 26 .../query/udf/java-user-defined-function.md| 28 +- 4 files changed, 12 insertions(+), 65 deletions(-) diff --git a/docs/query/udf/java-user-defined-function.md b/docs/query/udf/java-user-defined-function.md index 41dcc76f013..09fcafaaf95 100644 --- a/docs/query/udf/java-user-defined-function.md +++ b/docs/query/udf/java-user-defined-function.md @@ -58,6 +58,7 @@ Java UDF provides users with a Java interface written in UDF to facilitate the e |Datetime|LocalDateTime| |String|String| |Decimal|BigDecimal| +|```struct```|```ArrayList```| |```array```|```ArrayList```| |```map```|```HashMap```| @@ -114,6 +115,10 @@ CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES ( * The "always_nullable" is optional attribute, if there is special treatment for the NULL value in the calculation, it is determined that the result will not return NULL, and it can be set to false, so that the performance may be better in the whole calculation process. * If you use the local path method, the jar package that the database driver depends on, the FE and BE nodes must be placed here + +* The implemented jar package can be stored at local or in a remote server and downloaded via http, And each FE/BE node must be able to obtain the jar package; +Otherwise, the error status message "Couldn't open file..." will be returned + ## Create UDAF When using Java code to write UDAF, there are some functions that must be implemented (mark required) and an inner class State, which will be explained with a specific example below. @@ -334,9 +339,6 @@ CREATE AGGREGATE FUNCTION middle_quantiles(DOUBLE,INT) RETURNS DOUBLE PROPERTIES ``` -* The implemented jar package can be stored at local or in a remote server and downloaded via http, And each BE node must be able to obtain the jar package; -Otherwise, the error status message "Couldn't open file..." will be returned - ## Create UDTF UDTF, just like UDF functions, requires users to independently implement an `evaluate` method. However, the return value of a UDTF function must be of Array type. diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/current/query/udf/java-user-defined-function.md b/i18n/zh-CN/docusaurus-plugin-content-docs/current/query/udf/java-user-defined-function.md index cbc3554259f..5259b8a30d4 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/current/query/udf/java-user-defined-function.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/current/query/udf/java-user-defined-function.md @@ -66,6 +66,7 @@ Java UDF 为用户提供 UDF 编写的 Java 接口，以方便用户使用 Java |Datetime|LocalDateTime| |String|String| |Decimal|BigDecimal| +|```struct```|```ArrayList```| |```array```|```ArrayList```| |```map```|```HashMap```| @@ -129,6 +130,11 @@ CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES ( * 如果你是**本地路径**方式，这里数据库驱动依赖的 jar 包，**FE、BE 节点都要放置** +:::tip +实现的 jar 包可以放在本地也可以存放在远程服务端通过 HTTP 下载，但必须让每个 FE/BE 节点都能获取到 jar 包; +- 否则将会返回错误状态信息"Couldn't open file ..". +::: + ## 编写 UDAF 函数 @@ -353,15 +359,6 @@ CREATE AGGREGATE FUNCTION middle_quantiles(DOUBLE,INT) RETURNS DOUBLE PROPERTIES ); ``` -:::tip -实现的 jar 包可以放在本地也可以存放在远程服务端通过 HTTP 下载，但必须让每个 BE 节点都能获取到 jar 包; - -- 否则将会返回错误状态信息"Couldn't open file ..". - -- 目前还暂不支持 UDTF - - ::: - ## 编写 UDTF 函数 UDTF 和 UDF 函数一样，需要用户自主实现一个 `evaluate` 方法，但是 UDTF 函数的返回值必须是 Array 类型。 另外 Doris 中表函数会因为 _outer 后缀有不同的表现，可查看[OUTER 组合器](../../sql-manual/sql-functions/table-functions/explode-numbers-outer) diff --git a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/query/udf/java-user-defined-function.md b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/query/udf/java-user-defined-function.md index cbc3554259f..6845ad284a5 100644 --- a/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/query/udf/java-user-defined-function.md +++ b/i18n/zh-CN/docusaurus-plugin-content-docs/version-2.1/query/udf/java-user-defined-function.md @@ -362,32 +362,6 @@ CREATE AGGREGATE FUNCTION middle_quantiles(DOUBLE,INT) RETURNS DOUBLE PROPERTIES ::: -## 编写 UDTF 函数 -UDTF 和 UDF 函数一样，需要用户自主实现一个 `evaluate` 方法，但是 UDTF 函数的返回值必须是 Array 类型。 -另外 Doris 中表函数会因为 _outer 后缀有不同的表现，可查看[OUTER 组合器](../../
Error while running notifications feature from .asf.yaml in doris-website!
An error occurred while running notifications feature in .asf.yaml!: Invalid notification target 'comm...@foo.apache.org'. Must be a valid @doris.apache.org list! - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](mtmv)Fix slot desc wrong in query rewrite by materialized view when query is complex [doris]
seawinde opened a new pull request, #34904: URL: https://github.com/apache/doris/pull/34904 ## Proposed changes If query is very complex such as it has multi union and each union has join subquery. In this scane, query rewrite by materialized view is sucessful but exec may fail with the reason `couldn't resolve slot descriptor 239, desc: tuples:` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv)Fix slot desc wrong in query rewrite by materialized view when query is complex [doris]
doris-robot commented on PR #34904: URL: https://github.com/apache/doris/pull/34904#issuecomment-2111802477 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv)Fix slot desc wrong in query rewrite by materialized view when query is complex [doris]
seawinde commented on PR #34904: URL: https://github.com/apache/doris/pull/34904#issuecomment-2111802914 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
BePPPower commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111805724 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](mtmv)Fix slot desc wrong in query rewrite by materialized view when query is complex [doris]
seawinde commented on PR #34904: URL: https://github.com/apache/doris/pull/34904#issuecomment-2111811146 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
freemandealer commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111811563 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
doris-robot commented on PR #34905: URL: https://github.com/apache/doris/pull/34905#issuecomment-2111814448 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
wangbo opened a new pull request, #34905: URL: https://github.com/apache/doris/pull/34905 Find some query without valid FE coord addr. ``` I20240514 16:13:40.403275 36382 fragment_mgr.cpp:660] query_id: 65a3b7c24d6840e5-a255ce57dc178922 coord_addr TNetworkAddress(hostname=, port=0) total fragment num on current host: 0 fe process uuid: 0 I20240514 16:13:56.078752 36575 fragment_mgr.cpp:660] query_id: c8d342bc79f54bb3-9163dc61dd3cc91f coord_addr TNetworkAddress(hostname=, port=0) total fragment num on current host: 0 fe process uuid: 0 I20240514 16:13:57.491098 36590 fragment_mgr.cpp:660] query_id: 5566395318f947f0-85c82e9d0915d4fd coord_addr TNetworkAddress(hostname=, port=0) total fragment num on current host: 0 fe process uuid: 0 I20240514 16:14:01.316201 36695 fragment_mgr.cpp:660] query_id: 99a5087b6c714059-b5f76352901cbf1a coord_addr TNetworkAddress(hostname=, port=0) total fragment num on current host: 0 fe process uuid: 0 ``` The queries are all non-pipeline select. ``` I20240514 16:13:40.403275 36382 fragment_mgr.cpp:660] query_id: 65a3b7c24d6840e5-a255ce57dc178922 coord_addr TNetworkAddress(hostname=, port=0) total fragment num on current host: 0 fe process uuid: 0 I20240514 16:13:40.403342 36382 fragment_mgr.cpp:699] Register query/load memory tracker, query/load id: 65a3b7c24d6840e5-a255ce57dc178922 limit: 0 I20240514 16:13:41.010730 36382 plan_fragment_executor.cpp:123] PlanFragmentExecutor::prepare|query_id=65a3b7c24d6840e5-a255ce57dc178922|instance_id=144f452d10cc44da-9d2611b0ce919c80|backend_num=0|pthread_id=140485081507584 I20240514 16:13:41.015050 13191 plan_fragment_executor.cpp:257] PlanFragmentExecutor::open 65a3b7c24d6840e5-a255ce57dc178922|144f452d10cc44da-9d2611b0ce919c80, mem_limit 2.00 GB I20240514 16:13:41.039989 13191 exec_node.cpp:246] query= 65a3b7c24d6840e5-a255ce57dc178922, fragment_instance_id=144f452d10cc44da-9d2611b0ce919c80, id=0 type=OLAP_SCAN_NODE closed I20240514 16:13:41.040112 13191 fragment_mgr.cpp:498] Query 65a3b7c24d6840e5-a255ce57dc178922 finished I20240514 16:13:41.040323 13191 query_context.cpp:171] Query 65a3b7c24d6840e5-a255ce57dc178922 deconstructed, , deregister query/load memory tracker, queryId=65a3b7c24d6840e5-a255ce57dc178922, Limit=2.00 GB, CurrUsed=4.00 KB, PeakUsed=379.05 KB ``` Add log and dcheck when find this query, find what the query is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
doris-robot commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111816004 TPC-DS: Total hot run time: 187683 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 973ba892ac7855fbf93141de02b1c0896e3fabf1, data reload: false query1 961 393 369 369 query2 6440236324012363 query3 6647218 212 212 query4 24495 21222 21268 21222 query5 4197417 414 414 query6 269 174 172 172 query7 4579290 302 290 query8 239 190 200 190 query9 8761241823742374 query10 434 242 246 242 query11 14840 14230 14540 14230 query12 139 93 87 87 query13 1636367 364 364 query14 10676 765877247658 query15 211 174 179 174 query16 7798261 260 260 query17 1784549 530 530 query18 1951273 269 269 query19 205 143 151 143 query20 90 84 88 84 query21 218 129 131 129 query22 5002486149194861 query23 34143 33718 33569 33569 query24 12052 293929362936 query25 679 380 395 380 query26 1786181 156 156 query27 2951316 332 316 query28 7521206320382038 query29 1106605 592 592 query30 310 172 177 172 query31 996 764 759 759 query32 89 51 56 51 query33 751 252 246 246 query34 1049472 497 472 query35 806 679 687 679 query36 1092911 924 911 query37 164 70 73 70 query38 2870276128042761 query39 1639156915801569 query40 278 132 130 130 query41 49 46 47 46 query42 108 99 99 99 query43 587 546 566 546 query44 1133707 736 707 query45 276 255 259 255 query46 1093752 758 752 query47 1965189419051894 query48 382 294 323 294 query49 1158393 394 393 query50 762 395 382 382 query51 6848677867106710 query52 106 87 90 87 query53 349 292 289 289 query54 960 419 423 419 query55 74 73 71 71 query56 242 227 218 218 query57 1265117911861179 query58 225 203 200 200 query59 3527307832583078 query60 257 238 252 238 query61 92 117 90 90 query62 659 465 463 463 query63 309 281 285 281 query64 9734747573347334 query65 3152315931293129 query66 1404351 385 351 query67 15447 14933 15321 14933 query68 4549526 529 526 query69 476 302 301 301 query70 1207114811321132 query71 396 269 266 266 query72 7285259423732373 query73 708 332 315 315 query74 6504613261316131 query75 3291264526622645 query76 25681061985 985 query77 404 261 264 261 query78 10616 10349 10229 10229 query79 2552515 508 508 query80 1023436 432 432 query81 522 244 246 244 query82 739 98 95 95 query83 238 161 165 161 query84 237 84 86 84 query85 1470279 267 267 query86 441 327 297 297 query87 3342310531233105 query88 4230241424142414 query89 460 374 393 374 query90 1955185 186 185 query91 123 98 96 96 query92 61 50 47 47 query93 1607493 491 491 query94 1258185 184 184 query95 383 298 298 298 query96 576 271 276 271 query97 3193301429802980 query98 225 218 214 214 query99 1149890 895 890 Total cold run time: 287805 ms Total hot run time: 187683 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
github-actions[bot] commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111818161 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
starocean999 commented on PR #34894: URL: https://github.com/apache/doris/pull/34894#issuecomment-2111820268 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
wangbo commented on PR #34905: URL: https://github.com/apache/doris/pull/34905#issuecomment-2111820973 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
github-actions[bot] commented on PR #34905: URL: https://github.com/apache/doris/pull/34905#issuecomment-2111824417 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
yiguolei commented on code in PR #34905:
URL: https://github.com/apache/doris/pull/34905#discussion_r1601139543
##
be/src/runtime/plan_fragment_executor.cpp:
##
@@ -610,7 +610,7 @@ void PlanFragmentExecutor::close() {
}
}
-if (_runtime_state->enable_profile()) {
+if (_runtime_state->enable_profile() ||
_query_ctx->is_coord_addr_invalid()) {
Review Comment:
why do you modify non-pipeline code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](inverted index) fix wrong fs in inverted_index_file_writer [doris]
doris-robot commented on PR #34903: URL: https://github.com/apache/doris/pull/34903#issuecomment-2111825551 ClickBench: Total hot run time: 29.8 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 973ba892ac7855fbf93141de02b1c0896e3fabf1, data reload: false query1 0.040.030.03 query2 0.080.040.04 query3 0.220.050.05 query4 1.680.070.08 query5 0.490.490.51 query6 1.130.730.74 query7 0.020.020.02 query8 0.060.050.05 query9 0.530.490.48 query10 0.540.550.54 query11 0.140.110.11 query12 0.160.120.12 query13 0.590.600.61 query14 0.780.770.76 query15 0.820.800.81 query16 0.360.350.36 query17 0.980.950.97 query18 0.210.250.24 query19 1.791.651.71 query20 0.020.000.01 query21 15.56 0.660.65 query22 4.557.491.50 query23 18.36 1.411.21 query24 1.920.200.22 query25 0.140.070.08 query26 0.270.150.16 query27 0.080.080.08 query28 13.30 1.011.01 query29 13.11 3.303.28 query30 0.260.060.06 query31 2.860.390.38 query32 3.290.480.46 query33 2.822.892.77 query34 17.05 4.384.44 query35 4.514.524.50 query36 0.650.460.47 query37 0.160.140.15 query38 0.160.140.14 query39 0.040.040.03 query40 0.170.140.13 query41 0.100.050.04 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 110.1 s Total hot run time: 29.8 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r69167 - in /dev/doris/spark-connector/1.3.2: ./ apache-doris-spark-connector-1.3.2-src.tar.gz apache-doris-spark-connector-1.3.2-src.tar.gz.asc apache-doris-spark-connector-1.3.2-src.tar.
Author: diwu Date: Wed May 15 07:57:45 2024 New Revision: 69167 Log: spark connector 1.3.2 Added: dev/doris/spark-connector/1.3.2/ dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz (with props) dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.asc (with props) dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.sha512 Added: dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz == Binary file - no diff available. Propchange: dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz -- svn:mime-type = application/x-gzip Added: dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.asc == Binary file - no diff available. Propchange: dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.asc -- svn:mime-type = application/pgp-signature Added: dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.sha512 == --- dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.sha512 (added) +++ dev/doris/spark-connector/1.3.2/apache-doris-spark-connector-1.3.2-src.tar.gz.sha512 Wed May 15 07:57:45 2024 @@ -0,0 +1 @@ +0d3e6ce295c9188212067e45bbe41108af32ca504f7258924067a11f678fb94e6a69d3272d7c2229ea7fb94fe6c53f53a8c9531b43302ab874dc7e6b4ada apache-doris-spark-connector-1.3.2-src.tar.gz - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](Hdfs) Add bvar for currently inflight hdfs file writer's num [doris]
doris-robot commented on PR #34863: URL: https://github.com/apache/doris/pull/34863#issuecomment-2111833627 TeamCity be ut coverage result: Function Coverage: 35.65% (8983/25195) Line Coverage: 27.32% (74268/271862) Region Coverage: 26.56% (38384/144543) Branch Coverage: 23.37% (19575/83754) Coverage Report: http://coverage.selectdb-in.cc/coverage/f71f8370b8bc347085f96a21e1b8ce84db16a60d_f71f8370b8bc347085f96a21e1b8ce84db16a60d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)LogicalPlanDeepCopier will lost some info when coping logical relation [doris]
starocean999 commented on PR #34894: URL: https://github.com/apache/doris/pull/34894#issuecomment-2111833341 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]
zhangstar333 commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2111838121 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111844898 TeamCity be ut coverage result: Function Coverage: 37.79% (8075/21368) Line Coverage: 29.45% (65934/223864) Region Coverage: 28.92% (33941/117353) Branch Coverage: 24.78% (17421/70292) Coverage Report: http://coverage.selectdb-in.cc/coverage/f8d629039e940d5ebe9737f26ef0d3f7ca3e305c_f8d629039e940d5ebe9737f26ef0d3f7ca3e305c/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111846170 TPC-H: Total hot run time: 49665 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f8d629039e940d5ebe9737f26ef0d3f7ca3e305c, data reload: false -- Round 1 -- q1 17727 439043854385 q2 2046158 150 150 q3 10330 186219201862 q4 10123 126813691268 q5 8485393139793931 q6 235 127 127 127 q7 2019160716111607 q8 9351273627242724 q9 10515 10248 10411 10248 q10 8643351234713471 q11 419 249 252 249 q12 469 305 300 300 q13 18343 396540363965 q14 350 335 328 328 q15 521 466 467 466 q16 664 576 569 569 q17 1149987 941 941 q18 7246679268966792 q19 1720159414981498 q20 515 311 293 293 q21 4471415240954095 q22 496 398 396 396 Total cold run time: 115837 ms Total hot run time: 49665 ms - Round 2, with runtime_filter_mode=off - q1 4329429242964292 q2 324 252 224 224 q3 4185419141244124 q4 2772277227582758 q5 7117713571177117 q6 236 122 120 120 q7 3250292228952895 q8 4367446345174463 q9 16929 16843 16684 16684 q10 4283427142624262 q11 781 690 692 690 q12 1044858 842 842 q13 7124376037463746 q14 449 412 420 412 q15 522 456 466 456 q16 736 685 689 685 q17 3835386438883864 q18 8881882388678823 q19 1715169116811681 q20 2419216721082108 q21 8477847684558455 q22 988 922 944 922 Total cold run time: 84763 ms Total hot run time: 79623 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111850392 TPC-H: Total hot run time: 40406 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 6df24c3cd0dfa298f3a64f2447c35c1a8eae9eb9, data reload: false -- Round 1 -- q1 6121427442334233 q2 652 191 192 191 q3 6792113710901090 q4 1045699 743 699 q5 2672270126502650 q6 224 134 141 134 q7 1260701 604 604 q8 1997212620592059 q9 6644668464416441 q10 3876372437203720 q11 361 234 242 234 q12 378 216 216 216 q13 17057 298029942980 q14 256 220 225 220 q15 501 469 470 469 q16 478 401 391 391 q17 961 728 717 717 q18 7870758574607460 q19 1593153914781478 q20 507 313 299 299 q21 4992395738333833 q22 338 288 288 288 Total cold run time: 66575 ms Total hot run time: 40406 ms - Round 2, with runtime_filter_mode=off - q1 4258421041884188 q2 376 271 277 271 q3 2993277027622762 q4 1850155515551555 q5 5243525552535253 q6 228 126 127 126 q7 2233186718461846 q8 3205332632883288 q9 8322832483578324 q10 3880370136643664 q11 582 492 497 492 q12 740 607 604 604 q13 13065 299229912991 q14 289 275 266 266 q15 510 478 471 471 q16 451 425 414 414 q17 1771146514731465 q18 7680758075737573 q19 1686156016131560 q20 1949178317561756 q21 5014488047554755 q22 580 491 507 491 Total cold run time: 66905 ms Total hot run time: 54115 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids): lazy get expression map [doris]
github-actions[bot] commented on PR #34753: URL: https://github.com/apache/doris/pull/34753#issuecomment-2111853887 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](nereids) fix ScalarType.getAssignmentCompatibleType() when deal boolean and decimal [doris]
github-actions[bot] commented on PR #34636: URL: https://github.com/apache/doris/pull/34636#issuecomment-2111858861 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](nereids) fix ScalarType.getAssignmentCompatibleType() when deal boolean and decimal [doris]
github-actions[bot] commented on PR #34636: URL: https://github.com/apache/doris/pull/34636#issuecomment-2111858902 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]
jackwener opened a new pull request, #34906: URL: https://github.com/apache/doris/pull/34906 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]
doris-robot commented on PR #34906: URL: https://github.com/apache/doris/pull/34906#issuecomment-2111865298 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) unify empty_partition_prune condition with nereids [doris]
freemandealer commented on PR #34861: URL: https://github.com/apache/doris/pull/34861#issuecomment-2111866263 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids): fix ColumnPruningPostProcessor [doris]
jackwener commented on PR #34906: URL: https://github.com/apache/doris/pull/34906#issuecomment-2111870296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](multi-catalog)remove http scheme in oss endpoint [doris]
wsjz opened a new pull request, #34907: URL: https://github.com/apache/doris/pull/34907 ## Proposed changes remove http scheme in oss endpoint ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111872764 TPC-DS: Total hot run time: 186773 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 6df24c3cd0dfa298f3a64f2447c35c1a8eae9eb9, data reload: false query1 913 391 370 370 query2 7019233622272227 query3 6653218 220 218 query4 24881 21426 21407 21407 query5 4161418 434 418 query6 267 172 182 172 query7 4587293 294 293 query8 248 195 194 194 query9 8558241123842384 query10 437 267 253 253 query11 14718 14268 14226 14226 query12 134 94 91 91 query13 1650374 372 372 query14 10899 709879597098 query15 214 173 171 171 query16 7871260 270 260 query17 1864552 533 533 query18 1977274 266 266 query19 204 151 151 151 query20 97 86 89 86 query21 197 141 134 134 query22 5025485948394839 query23 34086 33366 33662 33366 query24 11832 288628502850 query25 664 389 365 365 query26 1790174 162 162 query27 3051332 336 332 query28 7640203420582034 query29 1117634 606 606 query30 310 176 173 173 query31 948 754 736 736 query32 92 54 56 54 query33 752 259 252 252 query34 1077481 480 480 query35 803 696 678 678 query36 1092903 904 903 query37 309 70 72 70 query38 2924275527822755 query39 1603156815661566 query40 277 132 130 130 query41 48 46 45 45 query42 108 101 96 96 query43 580 542 559 542 query44 1204728 738 728 query45 265 251 269 251 query46 1080742 702 702 query47 1950183418691834 query48 363 301 294 294 query49 1197423 419 419 query50 763 385 387 385 query51 6916682167766776 query52 114 88 97 88 query53 354 290 288 288 query54 970 441 428 428 query55 74 71 72 71 query56 244 224 255 224 query57 1267115111261126 query58 223 210 210 210 query59 3350312132173121 query60 261 243 243 243 query61 94 92 99 92 query62 652 476 465 465 query63 312 290 294 290 query64 9717746173527352 query65 3196312330963096 query66 1399354 350 350 query67 15151 15284 15027 15027 query68 5277534 549 534 query69 532 309 311 309 query70 1194108411271084 query71 476 282 269 269 query72 7844255823602360 query73 716 323 324 323 query74 6513610562276105 query75 3801269426652665 query76 3657967 972 967 query77 637 277 264 264 query78 10722 10141 10032 10032 query79 1820510 506 506 query80 1083446 449 446 query81 507 241 240 240 query82 852 96 99 96 query83 193 162 169 162 query84 266 86 86 86 query85 1433271 266 266 query86 458 301 312 301 query87 3282311030433043 query88 4047243324232423 query89 462 385 389 385 query90 1984192 192 192 query91 124 98 99 98 query92 63 52 48 48 query93 1784513 499 499 query94 1158186 188 186 query95 399 314 307 307 query96 582 275 266 266 query97 3229299929842984 query98 243 224 220 220 query99 1268916 889 889 Total cold run time: 291399 ms Total hot run time: 186773 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111870542 TPC-DS: Total hot run time: 202881 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f8d629039e940d5ebe9737f26ef0d3f7ca3e305c, data reload: false query1 929 386 374 374 query2 6559274826152615 query3 6918204 202 202 query4 21185 17994 17907 17907 query5 19726 656964926492 query6 290 220 217 217 query7 4154301 303 301 query8 277 281 250 250 query9 3093266226062606 query10 411 309 293 293 query11 11390 10648 10681 10648 query12 120 80 68 68 query13 5584693 680 680 query14 17630 13589 14142 13589 query15 362 223 230 223 query16 6475272 262 262 query17 17141444876 876 query18 2329428 402 402 query19 210 148 144 144 query20 79 76 79 76 query21 192 88 90 88 query22 5209502750365027 query23 32517 32067 31903 31903 query24 7065659165196519 query25 516 424 414 414 query26 627 163 161 161 query27 2039292 294 292 query28 6195237223222322 query29 2921275827632758 query30 239 169 165 165 query31 911 744 742 742 query32 72 61 55 55 query33 387 254 237 237 query34 863 470 474 470 query35 1122869 912 869 query36 1300113112071131 query37 91 66 63 63 query38 3130293629432936 query39 1392132413261324 query40 245 99 91 91 query41 38 37 36 36 query42 86 85 83 83 query43 757 834 668 668 query44 1134712 719 712 query45 248 229 232 229 query46 1213948 973 948 query47 1852171218271712 query48 1033694 724 694 query49 648 365 385 365 query50 874 594 600 594 query51 4766465646244624 query52 94 85 91 85 query53 448 319 311 311 query54 2675244124822441 query55 87 82 87 82 query56 235 221 224 221 query57 1154113511261126 query58 212 199 204 199 query59 4694397537843784 query60 204 199 220 199 query61 90 82 82 82 query62 852 559 429 429 query63 474 332 336 332 query64 2412150714821482 query65 3635356835723568 query66 813 378 375 375 query67 15237 15039 15748 15039 query68 12340 646 663 646 query69 577 331 334 331 query70 1961154914291429 query71 416 308 306 306 query72 6624345834053405 query73 2354342 325 325 query74 6370584758365836 query75 5479369436043604 query76 6955118112201181 query77 1180252 254 252 query78 12682 12367 11698 11698 query79 9799672 666 666 query80 677 392 388 388 query81 463 236 237 236 query82 604 98 100 98 query83 174 131 134 131 query84 260 69 69 69 query85 795 295 316 295 query86 327 291 285 285 query87 3291302430603024 query88 4136236423502350 query89 448 299 291 291 query90 1930211 207 207 query91 183 149 135 135 query92 57 53 53 53 query93 5808605 525 525 query94 726 213 205 205 query95 1138104710431043 query96 654 331 330 330 query97 6496633263576332 query98 186 179 156 156 query99 2942837 950 837 Total cold run time: 320465 ms Total hot run time: 202881 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](multi-catalog)remove http scheme in oss endpoint [doris]
doris-robot commented on PR #34907: URL: https://github.com/apache/doris/pull/34907#issuecomment-2111870775 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111882292 ClickBench: Total hot run time: 30.43 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f8d629039e940d5ebe9737f26ef0d3f7ca3e305c, data reload: false query1 0.020.020.02 query2 0.070.020.02 query3 0.260.060.07 query4 1.750.080.08 query5 0.530.520.51 query6 1.320.630.61 query7 0.020.010.01 query8 0.030.020.02 query9 0.530.500.48 query10 0.540.540.54 query11 0.120.090.09 query12 0.110.090.09 query13 0.610.610.62 query14 0.790.780.78 query15 0.770.770.78 query16 0.370.360.38 query17 1.020.971.03 query18 0.220.260.24 query19 1.921.851.82 query20 0.020.010.01 query21 15.48 0.540.53 query22 2.362.341.28 query23 16.72 1.100.99 query24 5.680.991.19 query25 0.400.060.04 query26 0.670.150.15 query27 0.050.030.03 query28 7.290.770.71 query29 12.64 2.382.33 query30 0.560.530.53 query31 2.800.380.37 query32 3.370.490.49 query33 3.063.083.06 query34 15.23 4.794.77 query35 4.854.824.84 query36 1.051.011.02 query37 0.060.050.04 query38 0.040.020.02 query39 0.020.020.01 query40 0.160.140.14 query41 0.060.010.02 query42 0.020.020.01 query43 0.020.010.02 Total cold run time: 103.61 s Total hot run time: 30.43 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] [doris-flink-connector]
JNSimba opened a new issue, #386: URL: https://github.com/apache/doris-flink-connector/issues/386 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1 ### What's Wrong? 1 ### What You Expected? 1 ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601180459
##
be/src/runtime/load_channel.cpp:
##
@@ -195,6 +196,22 @@ Status LoadChannel::_handle_eos(BaseTabletsChannel*
channel,
auto index_id = request.index_id();
RETURN_IF_ERROR(channel->close(this, request, response, &finished));
+
+// for init node, we close waiting(hang on) all close request and let them
return together.
+if (!channel->is_incremental_channel()) {
Review Comment:
check auto partition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](cloud) batching get visible version from MetaService [doris]
doris-robot commented on PR #34615: URL: https://github.com/apache/doris/pull/34615#issuecomment-2111884625 ClickBench: Total hot run time: 31.09 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 6df24c3cd0dfa298f3a64f2447c35c1a8eae9eb9, data reload: false query1 0.040.030.03 query2 0.070.040.04 query3 0.230.050.05 query4 1.660.080.08 query5 0.500.480.50 query6 1.130.730.72 query7 0.010.010.01 query8 0.040.040.03 query9 0.540.490.50 query10 0.530.560.54 query11 0.160.110.12 query12 0.150.120.11 query13 0.600.590.60 query14 0.780.810.76 query15 0.820.800.81 query16 0.370.370.37 query17 1.021.041.03 query18 0.220.270.23 query19 1.901.821.82 query20 0.010.010.01 query21 15.71 0.660.67 query22 4.326.362.46 query23 18.31 1.241.24 query24 1.960.220.21 query25 0.140.090.08 query26 0.270.170.16 query27 0.080.090.08 query28 13.33 1.021.02 query29 13.11 3.243.23 query30 0.240.060.05 query31 2.840.390.38 query32 3.280.470.47 query33 2.812.852.88 query34 17.00 4.404.38 query35 4.474.514.55 query36 0.650.460.46 query37 0.170.140.15 query38 0.150.140.14 query39 0.040.030.04 query40 0.160.130.16 query41 0.090.050.04 query42 0.050.050.04 query43 0.050.030.04 Total cold run time: 110.01 s Total hot run time: 31.09 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](auto-partition) fix auto partition load lost data in multi sender [doris]
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601184380
##
be/src/runtime/tablets_channel.cpp:
##
@@ -142,9 +142,16 @@ Status BaseTabletsChannel::open(const
PTabletWriterOpenRequest& request) {
RETURN_IF_ERROR(_schema->init(request.schema()));
_tuple_desc = _schema->tuple_desc();
-_num_remaining_senders = request.num_senders();
-_next_seqs.resize(_num_remaining_senders, 0);
-_closed_senders.Reset(_num_remaining_senders);
+int max_sender = request.num_senders();
+// this tablets channel created by inc_open: open times = how many sender
instance know this tablets channel.
Review Comment:
add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](outfile) Fix the timing of setting the _is_closed flag in Parquet/ORC writer [doris]
doris-robot commented on PR #34669: URL: https://github.com/apache/doris/pull/34669#issuecomment-2111888259 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit f8d629039e940d5ebe9737f26ef0d3f7ca3e305c with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 21.8 seconds inserted 1000 Rows, about 458K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) branch release-1.6.1 created (now e49f7e4)
This is an automated email from the ASF dual-hosted git repository. diwu pushed a change to branch release-1.6.1 in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git at e49f7e4 [fix][cdc] fix uid conflicts during multi-database synchronization. (#382) No new revisions were added by this update. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](nereids) fix ScalarType.getAssignmentCompatibleType() when deal boolean and decimal [doris]
morrySnow merged PR #34636: URL: https://github.com/apache/doris/pull/34636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [fix](planner) fix ScalarType.getAssignmentCompatibleType() when deal boolean and decimal (#34636)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 3578ba62986 [fix](planner) fix
ScalarType.getAssignmentCompatibleType() when deal boolean and decimal (#34636)
3578ba62986 is described below
commit 3578ba6298652f8504b663afe2b3650ed1dc7437
Author: feiniaofeiafei <53502832+feiniaofeia...@users.noreply.github.com>
AuthorDate: Wed May 15 16:32:37 2024 +0800
[fix](planner) fix ScalarType.getAssignmentCompatibleType() when deal
boolean and decimal (#34636)
cherry-pick to branch-2.0 from #34435
The legacy planner encounters issues when handling filters such as:
c1(boolean type)=0.0(decimalv3).
The literal 0.0 is interpreted as decimalv3(1,1), and the boolean type c1
is coerced to decimalv3(1,1).
decimalv3(1,1) can only retain values in the range [0,1), while the boolean
true is represented as 1, exceeding the upper bound, thus causing an overflow
problem.
This pull request addresses this issue by considering the boolean type as
decimalv3(1,0), making both c1 and 0.0 being cast to decimal(2,1).
---
.../java/org/apache/doris/catalog/ScalarType.java | 8 +++-
.../get_assignment_compatible_type.out | 8
.../get_assignment_compatible_type.groovy | 52 ++
3 files changed, 67 insertions(+), 1 deletion(-)
diff --git
a/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
b/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
index 3db3739d08a..b68ae83b2e8 100644
--- a/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
+++ b/fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java
@@ -1130,7 +1130,13 @@ public class ScalarType extends Type {
if (t1.isFloatingPointType() || t2.isFloatingPointType()) {
return t1.isFloatingPointType() ? t1 : t2;
} else if (t1.isBoolean() || t2.isBoolean()) {
-return t1.isDecimalV3() ? t1 : t2;
+return t1.isDecimalV3()
+? ScalarType.createDecimalV3Type(
+Math.max(t1.precision - t1.scale, 1) +
Math.max(t1.scale, 0),
+Math.max(t1.scale, 0)) :
+ScalarType.createDecimalV3Type(
+Math.max(t2.precision - t2.scale, 1) +
Math.max(t2.scale, 0),
+Math.max(t2.scale, 0));
}
}
diff --git
a/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
b/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
new file mode 100644
index 000..5706a768d2d
--- /dev/null
+++
b/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
@@ -0,0 +1,8 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !test_sql --
+test_decimal_boolean_view CREATE VIEW `test_decimal_boolean_view` COMMENT
'VIEW' AS SELECT `id` AS `id`, `c1` AS `c1`, `c2` AS `c2` FROM
`default_cluster:regression_test_datatype_p0_scalar_types`.`test_decimal_boolean`
WHERE 0.0 = CAST(`c1` AS DECIMALV3(2, 1)) AND CAST(`c2` AS DECIMALV3(6, 1)) =
1.0; utf8utf8_general_ci
+
+-- !test_union --
+0.0
+1.0
+
diff --git
a/regression-test/suites/datatype_p0/scalar_types/get_assignment_compatible_type.groovy
b/regression-test/suites/datatype_p0/scalar_types/get_assignment_compatible_type.groovy
new file mode 100644
index 000..afbf3746259
--- /dev/null
+++
b/regression-test/suites/datatype_p0/scalar_types/get_assignment_compatible_type.groovy
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("get_assignment_compatible_type") {
+sql 'set enable_nereids_planner=false'
+sql "drop table if exists test_decimal_boolean"
+sql """create table test_decimal_boolean (
+id int,
+c1 boolean,
+c2 tinyint
+) duplicate key (`id`)
+DISTRIBUTED BY HASH(`id`) BUCKETS 1
+PROPERTIES (
+"
Re: [PR] [Fix](executor)log profile and exit when find invalid fe addr [doris]
doris-robot commented on PR #34905: URL: https://github.com/apache/doris/pull/34905#issuecomment-2111898613 TPC-H: Total hot run time: 40222 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit bcb9917fd412d6adad86698b25adcfd5bf832b2b, data reload: false -- Round 1 -- q1 18085 448843104310 q2 2016188 193 188 q3 10501 116211961162 q4 10162 839 781 781 q5 7480271727762717 q6 218 134 135 134 q7 1016607 568 568 q8 9248210420912091 q9 9048656065346534 q10 8856371137293711 q11 454 243 245 243 q12 453 224 216 216 q13 17773 297129772971 q14 262 213 212 212 q15 514 483 474 474 q16 492 395 378 378 q17 986 711 718 711 q18 8150757974267426 q19 7767153915481539 q20 659 325 312 312 q21 5099326239323262 q22 344 287 282 282 Total cold run time: 119583 ms Total hot run time: 40222 ms - Round 2, with runtime_filter_mode=off - q1 4383427542384238 q2 388 273 272 272 q3 3006281927452745 q4 1897163416181618 q5 5312530153055301 q6 213 126 126 126 q7 2283190518961896 q8 3229337833703370 q9 8398842683598359 q10 3878368837123688 q11 604 491 478 478 q12 771 580 594 580 q13 16828 299329762976 q14 283 268 251 251 q15 521 485 486 485 q16 470 407 439 407 q17 1792150414711471 q18 7615765674707470 q19 1688155815911558 q20 1982175817841758 q21 5026487549394875 q22 580 489 499 489 Total cold run time: 71147 ms Total hot run time: 54411 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) tag 1.6.1 created (now 1907b77)
This is an automated email from the ASF dual-hosted git repository. diwu pushed a change to tag 1.6.1 in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git at 1907b77 (commit) This tag includes the following new commits: new 1907b77 Commit for release 1.6.1 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) 01/01: Commit for release 1.6.1
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to tag 1.6.1 in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git commit 1907b77137fb5d9940fba085862208a4df557b00 Author: wudi <676366...@qq.com> AuthorDate: Wed May 15 16:33:51 2024 +0800 Commit for release 1.6.1 --- flink-doris-connector/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flink-doris-connector/pom.xml b/flink-doris-connector/pom.xml index 23145e4..fe23ca8 100644 --- a/flink-doris-connector/pom.xml +++ b/flink-doris-connector/pom.xml @@ -67,7 +67,7 @@ under the License. -1.6.1-SNAPSHOT +1.6.1 1.18.0 1.18 2.4.2 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](cloud) unify empty_partition_prune condition with nereids [doris]
doris-robot commented on PR #34861: URL: https://github.com/apache/doris/pull/34861#issuecomment-2111900774 TPC-H: Total hot run time: 41642 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 20f84debf9a3ec476dfe0951841b46ca75d93ff9, data reload: false -- Round 1 -- q1 6844425742614257 q2 624 191 202 191 q3 1377121712061206 q4 1007773 821 773 q5 2629271426462646 q6 220 140 139 139 q7 986 586 581 581 q8 1956220222872202 q9 6950683566876687 q10 4014394639083908 q11 366 246 244 244 q12 388 228 246 228 q13 16356 296131262961 q14 269 219 229 219 q15 535 472 489 472 q16 504 393 388 388 q17 972 715 650 650 q18 8307778378967783 q19 1661156914561456 q20 548 315 316 315 q21 5245404842044048 q22 355 289 288 288 Total cold run time: 62113 ms Total hot run time: 41642 ms - Round 2, with runtime_filter_mode=off - q1 4386435343604353 q2 385 276 271 271 q3 3189290627802780 q4 1906157816031578 q5 5271529253165292 q6 216 124 125 124 q7 2271189618871887 q8 3183336033403340 q9 8397837983548354 q10 3887373536793679 q11 574 491 491 491 q12 770 633 584 584 q13 5030300229932993 q14 282 261 255 255 q15 519 464 467 464 q16 465 415 410 410 q17 1765146514951465 q18 7639765874757475 q19 1699157515861575 q20 1993175517581755 q21 4898502048144814 q22 559 485 474 474 Total cold run time: 59284 ms Total hot run time: 54413 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids)push Limit to local agg [doris]
github-actions[bot] commented on PR #34853: URL: https://github.com/apache/doris/pull/34853#issuecomment-2111903445 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement]Optimize GeoFunctions for const columns [doris]
koarz commented on PR #34396: URL: https://github.com/apache/doris/pull/34396#issuecomment-2111909146 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
morrySnow merged PR #34761: URL: https://github.com/apache/doris/pull/34761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](planner) fix date_xxx functions without complete function signature (#34761)
This is an automated email from the ASF dual-hosted git repository.
morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0905133d555 [fix](planner) fix date_xxx functions without complete
function signature (#34761)
0905133d555 is described below
commit 0905133d555db9cde1f9723b7ab235f48c8f3043
Author: LiBinfeng <46676950+libinfeng...@users.noreply.github.com>
AuthorDate: Wed May 15 16:39:42 2024 +0800
[fix](planner) fix date_xxx functions without complete function signature
(#34761)
Problem:
When using current_date as input of functions like date_sub,
fold constant would failed cause of missing of function signature in Planner
Solved:
Add complete function signature of functions like date_sub
---
.../java/org/apache/doris/rewrite/FEFunctions.java | 68 ++
.../datetime_functions/test_date_function.groovy | 45 ++
2 files changed, 113 insertions(+)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java
index f5d03d68b26..520cdeefff0 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/rewrite/FEFunctions.java
@@ -104,6 +104,11 @@ public class FEFunctions {
return daysAdd(date, day);
}
+@FEFunction(name = "date_add", argTypes = { "DATE", "INT" }, returnType =
"DATE")
+public static DateLiteral dateAddDate(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
+return daysAdd(date, day);
+}
+
@FEFunction(name = "date_add", argTypes = { "DATEV2", "INT" }, returnType
= "DATEV2")
public static DateLiteral dateAddDateV2(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
return daysAdd(date, day);
@@ -135,6 +140,12 @@ public class FEFunctions {
return dateLiteral.plusYears(year.getLongValue());
}
+@FEFunction(name = "years_add", argTypes = { "DATE", "INT" }, returnType =
"DATE")
+public static DateLiteral yearsAddDate(LiteralExpr date, LiteralExpr year)
throws AnalysisException {
+DateLiteral dateLiteral = (DateLiteral) date;
+return dateLiteral.plusYears((int) year.getLongValue());
+}
+
@FEFunction(name = "years_add", argTypes = { "DATEV2", "INT" }, returnType
= "DATEV2")
public static DateLiteral yearsAddDateV2(LiteralExpr date, LiteralExpr
year) throws AnalysisException {
DateLiteral dateLiteral = (DateLiteral) date;
@@ -153,6 +164,12 @@ public class FEFunctions {
return dateLiteral.plusMonths(month.getLongValue());
}
+@FEFunction(name = "months_add", argTypes = { "DATE", "INT" }, returnType
= "DATE")
+public static DateLiteral monthsAddDate(LiteralExpr date, LiteralExpr
month) throws AnalysisException {
+DateLiteral dateLiteral = (DateLiteral) date;
+return dateLiteral.plusMonths((int) month.getLongValue());
+}
+
@FEFunction(name = "months_add", argTypes = { "DATEV2", "INT" },
returnType = "DATEV2")
public static DateLiteral monthsAddDateV2(LiteralExpr date, LiteralExpr
month) throws AnalysisException {
DateLiteral dateLiteral = (DateLiteral) date;
@@ -171,6 +188,12 @@ public class FEFunctions {
return dateLiteral.plusDays(day.getLongValue());
}
+@FEFunction(name = "days_add", argTypes = { "DATE", "INT" }, returnType =
"DATE")
+public static DateLiteral daysAddDate(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
+DateLiteral dateLiteral = (DateLiteral) date;
+return dateLiteral.plusDays((int) day.getLongValue());
+}
+
@FEFunction(name = "days_add", argTypes = { "DATEV2", "INT" }, returnType
= "DATEV2")
public static DateLiteral daysAddDateV2(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
DateLiteral dateLiteral = (DateLiteral) date;
@@ -224,26 +247,71 @@ public class FEFunctions {
return dateAdd(date, new IntLiteral(-(int) day.getLongValue()));
}
+@FEFunction(name = "date_sub", argTypes = { "DATE", "INT" }, returnType =
"DATE")
+public static DateLiteral dateSubDate(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
+return daysAdd(date, new IntLiteral(-(int) day.getLongValue()));
+}
+
@FEFunction(name = "date_sub", argTypes = { "DATEV2", "INT" }, returnType
= "DATEV2")
public static DateLiteral dateSubDateV2(LiteralExpr date, LiteralExpr day)
throws AnalysisException {
return dateAdd(date, new IntLiteral(-(int) day.getLongValue()));
}
+@FEFunction(name = "date_sub", argTypes = { "DATETIMEV2", "INT" },
returnType = "DATETIMEV2")
+public static DateLiteral dateSubDateTimeV2(LiteralExpr date, LiteralExpr
day) throws AnalysisException {
+return daysAd
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
github-actions[bot] commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2111910616 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]
github-actions[bot] commented on PR #34760: URL: https://github.com/apache/doris/pull/34760#issuecomment-2111910700 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
