Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
github-actions[bot] commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2053937756 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
Mryange commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053939301 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [docker](hive) add hive3 docker compose and modify scripts [doris]
suxiaogang223 commented on PR #33115: URL: https://github.com/apache/doris/pull/33115#issuecomment-2053943762 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]
github-actions[bot] commented on code in PR #33622:
URL: https://github.com/apache/doris/pull/33622#discussion_r1564534381
##
be/src/util/block_compression.cpp:
##
@@ -168,40 +170,38 @@ class Lz4BlockCompression : public BlockCompressionCodec {
private:
// reuse LZ4 compress stream
-Status _acquire_compression_ctx(Context** out) {
+Status _acquire_compression_ctx(std::shared_ptr& out) {
Review Comment:
warning: method '_acquire_compression_ctx' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status _acquire_compression_ctx(std::shared_ptr& out) {
```
##
be/src/util/block_compression.cpp:
##
@@ -373,77 +375,75 @@
private:
// acquire a compression ctx from pool, release while finish compress,
// delete if compression failed
-Status _acquire_compression_ctx(CContext** out) {
+Status _acquire_compression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_c_mutex);
if (_ctx_c_pool.empty()) {
-CContext* context = new (std::nothrow) CContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = CContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new LZ4F CContext");
}
-auto res = LZ4F_createCompressionContext(&context->ctx,
LZ4F_VERSION);
+auto res = LZ4F_createCompressionContext(&localCtx->ctx,
LZ4F_VERSION);
if (LZ4F_isError(res) != 0) {
return Status::InvalidArgument(strings::Substitute(
"LZ4F_createCompressionContext error, res=$0",
LZ4F_getErrorName(res)));
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_c_pool.back();
+out = _ctx_c_pool.back();
_ctx_c_pool.pop_back();
return Status::OK();
}
-void _release_compression_ctx(CContext* context) {
+void _release_compression_ctx(std::shared_ptr context) {
Review Comment:
warning: method '_release_compression_ctx' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void _release_compression_ctx(std::shared_ptr context) {
```
##
be/src/util/block_compression.cpp:
##
@@ -890,76 +891,74 @@
}
private:
-Status _acquire_compression_ctx(CContext** out) {
+Status _acquire_compression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_c_mutex);
if (_ctx_c_pool.empty()) {
-CContext* context = new (std::nothrow) CContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = CContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new ZSTD CContext");
}
//typedef LZ4F_cctx* LZ4F_compressionContext_t;
-context->ctx = ZSTD_createCCtx();
-if (context->ctx == nullptr) {
+localCtx->ctx = ZSTD_createCCtx();
+if (localCtx->ctx == nullptr) {
return Status::InvalidArgument("Failed to create ZSTD compress
ctx");
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_c_pool.back();
+out = _ctx_c_pool.back();
_ctx_c_pool.pop_back();
return Status::OK();
}
-void _release_compression_ctx(CContext* context) {
+void _release_compression_ctx(std::shared_ptr context) {
DCHECK(context);
auto ret = ZSTD_CCtx_reset(context->ctx, ZSTD_reset_session_only);
DCHECK(!ZSTD_isError(ret));
std::lock_guard l(_ctx_c_mutex);
_ctx_c_pool.push_back(context);
}
-void _delete_compression_ctx(CContext* context) {
+void _delete_compression_ctx(std::shared_ptr context) {
DCHECK(context);
ZSTD_freeCCtx(context->ctx);
-delete context;
}
-Status _acquire_decompression_ctx(DContext** out) {
+Status _acquire_decompression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_d_mutex);
if (_ctx_d_pool.empty()) {
-DContext* context = new (std::nothrow) DContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = DContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new ZSTD DContext");
}
-context->ctx = ZSTD_createDCtx();
-if (context->ctx == nullptr) {
+localCtx->ctx = ZSTD_createDCtx();
+if (localCtx->ctx == nullptr) {
return Status::InvalidArgument("Fail to init ZSTD decompress
context");
}
-*out = context;
+out = localCtx;
return
Re: [PR] [fix](Nereids) create view should forward to master [doris]
924060929 merged PR #33626: URL: https://github.com/apache/doris/pull/33626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](Nereids) create view should forward to master (#33626)
This is an automated email from the ASF dual-hosted git repository.
huajianlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 54ae5d4f33e [fix](Nereids) create view should forward to master
(#33626)
54ae5d4f33e is described below
commit 54ae5d4f33eb9bfd42621e2bc34f833c06e9ffba
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Sun Apr 14 15:45:07 2024 +0800
[fix](Nereids) create view should forward to master (#33626)
fix: create view should forward to master
---
.../apache/doris/nereids/trees/plans/commands/CreateViewCommand.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
index d78308664b5..25cd171959d 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
@@ -26,7 +26,7 @@ import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.StmtExecutor;
/** CreateViewCommand */
-public class CreateViewCommand extends Command {
+public class CreateViewCommand extends Command implements ForwardWithSync {
private final CreateViewInfo createViewInfo;
public CreateViewCommand(CreateViewInfo createViewInfo) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053951825 TPC-H: Total hot run time: 38876 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a2dd80fef1dc421157550b02f871454e06da32b1, data reload: false -- Round 1 -- q1 17622 444842614261 q2 2010217 200 200 q3 10444 122711971197 q4 10173 795 791 791 q5 7566276126832683 q6 215 133 140 133 q7 1049625 603 603 q8 9234210520772077 q9 7953665066326632 q10 8595354635353535 q11 467 252 247 247 q12 444 236 251 236 q13 18837 295029672950 q14 292 242 227 227 q15 520 474 459 459 q16 502 394 378 378 q17 975 703 802 703 q18 7414677366376637 q19 7460156314871487 q20 697 331 330 330 q21 3526278128002781 q22 383 329 344 329 Total cold run time: 116378 ms Total hot run time: 38876 ms - Round 2, with runtime_filter_mode=off - q1 4366422642344226 q2 367 269 259 259 q3 2972278427902784 q4 1843163416181618 q5 5359534752895289 q6 209 124 123 123 q7 2263188718971887 q8 3213341133413341 q9 8675861588588615 q10 4060400539463946 q11 606 494 516 494 q12 803 626 657 626 q13 16467 320031333133 q14 327 292 302 292 q15 525 485 476 476 q16 519 448 472 448 q17 1837155314991499 q18 8161802777537753 q19 1684154015951540 q20 2043187218331833 q21 8219497049694969 q22 579 457 486 457 Total cold run time: 75097 ms Total hot run time: 55608 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
DarvenDuan commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2053951296 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]
xinyiZzz commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2053952533 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
zclllyybb commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053952970 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]
github-actions[bot] commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2053954062 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053954610 TeamCity be ut coverage result: Function Coverage: 35.59% (8904/25020) Line Coverage: 27.31% (73129/267756) Region Coverage: 26.44% (37815/143030) Branch Coverage: 23.19% (19267/83072) Coverage Report: http://coverage.selectdb-in.cc/coverage/a2dd80fef1dc421157550b02f871454e06da32b1_a2dd80fef1dc421157550b02f871454e06da32b1/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053954817 TPC-DS: Total hot run time: 189235 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a2dd80fef1dc421157550b02f871454e06da32b1, data reload: false query1 881 112911101110 query2 7996259925622562 query3 232 221 221 query4 37347 21658 21369 21369 query5 4158531 521 521 query6 259 223 212 212 query7 4049323 296 296 query8 255 211 203 203 query9 6092260326002600 query10 440 331 331 331 query11 14624 14282 14213 14213 query12 172 128 137 128 query13 1006373 370 370 query14 10169 720474997204 query15 226 198 212 198 query16 6431335 342 335 query17 934 617 637 617 query18 1355304 296 296 query19 241 188 194 188 query20 114 114 111 111 query21 198 141 140 140 query22 4993484148494841 query23 34277 33295 33610 33295 query24 11567 300930873009 query25 555 443 449 443 query26 736 189 171 171 query27 2928380 421 380 query28 6633218221892182 query29 900 682 657 657 query30 319 171 187 171 query31 943 769 745 745 query32 97 80 87 80 query33 502 346 327 327 query34 888 521 512 512 query35 906 775 784 775 query36 1108952 992 952 query37 138 112 110 110 query38 3774372536783678 query39 1657158315901583 query40 209 159 162 159 query41 48 45 44 44 query42 137 135 144 135 query43 604 582 554 554 query44 1329830 813 813 query45 301 296 279 279 query46 1080783 783 783 query47 2050196019391939 query48 397 325 314 314 query49 895 474 475 474 query50 813 424 430 424 query51 6883678068996780 query52 142 142 133 133 query53 387 294 295 294 query54 352 337 326 326 query55 110 110 107 107 query56 320 301 317 301 query57 1257121312101210 query58 343 330 352 330 query59 3722356534103410 query60 347 323 325 323 query61 123 89 89 89 query62 618 453 476 453 query63 330 303 309 303 query64 4180380338443803 query65 3099306030693060 query66 808 334 348 334 query67 15454 14931 15098 14931 query68 5412556 555 555 query69 572 414 410 410 query70 1239123212411232 query71 447 353 370 353 query72 6388263424522452 query73 749 335 340 335 query74 6827648763746374 query75 3086239724402397 query76 3586109811371098 query77 649 375 367 367 query78 10863 10214 10226 10214 query79 3393536 543 536 query80 2225582 518 518 query81 505 238 250 238 query82 1518156 155 155 query83 339 185 185 185 query84 257 98 94 94 query85 1449325 308 308 query86 464 279 293 279 query87 3837357535763575 query88 5457247624682468 query89 508 403 404 403 query90 1819230 228 228 query91 133 113 112 112 query92 101 102 102 102 query93 4865532 512 512 query94 1171255 251 251 query95 458 386 387 386 query96 632 295 276 276 query97 2727248324902483 query98 255 232 230 230 query99 1253868 879 868 Total cold run time: 296056 ms Total hot run time: 189235 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
doris-robot commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2053954883 TPC-H: Total hot run time: 38616 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit cd1c657f17f91c9cde15531e3d3798d6144cef97, data reload: false -- Round 1 -- q1 17604 438342504250 q2 2008179 178 178 q3 10473 122311661166 q4 10199 881 896 881 q5 7555271126122612 q6 220 132 131 131 q7 1006609 588 588 q8 9205207320472047 q9 8042663465776577 q10 8592351435203514 q11 465 235 236 235 q12 433 223 214 214 q13 17774 291729312917 q14 264 225 239 225 q15 525 469 474 469 q16 529 375 375 375 q17 982 754 733 733 q18 7447685766936693 q19 6500155715061506 q20 680 321 294 294 q21 3586271128432711 q22 364 302 300 300 Total cold run time: 114453 ms Total hot run time: 38616 ms - Round 2, with runtime_filter_mode=off - q1 4351422242244222 q2 366 270 266 266 q3 2983275127752751 q4 1861156915761569 q5 5333533952765276 q6 207 126 124 124 q7 2257184718991847 q8 3224334433163316 q9 8558856686738566 q10 4078396539973965 q11 620 516 492 492 q12 808 635 640 635 q13 17485 318430483048 q14 351 280 278 278 q15 517 472 497 472 q16 486 450 460 450 q17 1806150914961496 q18 8230798178357835 q19 1696160716251607 q20 2052185618241824 q21 5184488850594888 q22 534 483 460 460 Total cold run time: 72987 ms Total hot run time: 55387 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) add session var to turn on/off common sub expressoin extraction [doris]
github-actions[bot] commented on PR #33617: URL: https://github.com/apache/doris/pull/33617#issuecomment-2053955859 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053956753 ClickBench: Total hot run time: 30.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a2dd80fef1dc421157550b02f871454e06da32b1, data reload: false query1 0.040.030.03 query2 0.080.040.04 query3 0.230.050.05 query4 1.670.070.07 query5 0.490.500.49 query6 1.490.660.66 query7 0.020.010.02 query8 0.050.050.05 query9 0.530.490.49 query10 0.540.550.54 query11 0.160.120.12 query12 0.150.130.13 query13 0.600.580.58 query14 0.770.770.77 query15 0.830.810.80 query16 0.370.400.35 query17 0.980.960.97 query18 0.220.240.24 query19 1.801.741.76 query20 0.020.010.01 query21 15.40 0.650.65 query22 4.326.722.18 query23 18.32 1.371.25 query24 1.860.210.22 query25 0.140.080.08 query26 0.270.160.16 query27 0.080.070.08 query28 13.52 0.990.98 query29 12.60 3.293.25 query30 0.260.070.06 query31 2.860.370.38 query32 3.280.460.46 query33 2.832.842.79 query34 17.11 4.404.39 query35 4.534.474.48 query36 0.650.460.47 query37 0.190.160.16 query38 0.160.150.15 query39 0.060.040.05 query40 0.170.150.13 query41 0.100.060.05 query42 0.070.060.05 query43 0.050.050.05 Total cold run time: 109.87 s Total hot run time: 30.59 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053957758 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit a2dd80fef1dc421157550b02f871454e06da32b1 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 13.5 seconds inserted 1000 Rows, about 740K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
doris-robot commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2053958864 TPC-DS: Total hot run time: 183511 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit cd1c657f17f91c9cde15531e3d3798d6144cef97, data reload: false query1 878 1141344 344 query2 7646267526072607 query3 6654205 206 205 query4 37059 21608 21182 21182 query5 4132400 393 393 query6 225 189 172 172 query7 4037283 289 283 query8 220 172 169 169 query9 5763229522912291 query10 372 239 232 232 query11 14502 14142 14197 14142 query12 141 91 85 85 query13 1015374 348 348 query14 9667692067276727 query15 200 173 175 173 query16 7073249 257 249 query17 1705580 540 540 query18 1596275 264 264 query19 196 151 153 151 query20 91 85 89 85 query21 203 127 124 124 query22 4987488548274827 query23 33647 33112 33196 33112 query24 11359 302930513029 query25 538 400 381 381 query26 892 158 151 151 query27 3069371 371 371 query28 6566217121082108 query29 893 643 639 639 query30 253 176 172 172 query31 979 741 758 741 query32 64 54 54 54 query33 546 239 245 239 query34 1009485 515 485 query35 888 737 725 725 query36 1084953 933 933 query37 107 71 70 70 query38 3687363536113611 query39 1623156515821565 query40 165 130 127 127 query41 46 45 50 45 query42 100 96 108 96 query43 597 572 552 552 query44 1329731 746 731 query45 292 281 280 280 query46 1104729 738 729 query47 2088194419831944 query48 403 303 303 303 query49 899 382 393 382 query50 763 395 403 395 query51 6913691668706870 query52 107 97 85 85 query53 342 284 280 280 query54 248 223 221 221 query55 73 72 71 71 query56 234 216 219 216 query57 1191111411321114 query58 223 228 209 209 query59 3353344434363436 query60 258 247 262 247 query61 93 92 90 90 query62 582 457 436 436 query63 299 283 276 276 query64 4319408536333633 query65 3100302130353021 query66 737 313 315 313 query67 15326 15001 15015 15001 query68 5132543 532 532 query69 519 299 294 294 query70 1274119412041194 query71 456 275 269 269 query72 6401260624722472 query73 728 314 319 314 query74 6869637963716371 query75 3128234823122312 query76 3383109510751075 query77 622 242 252 242 query78 10779 10057 10197 10057 query79 3494518 513 513 query80 2221419 425 419 query81 524 224 229 224 query82 1531102 100 100 query83 352 184 179 179 query84 258 93 83 83 query85 1421275 261 261 query86 458 317 309 309 query87 3789354035913540 query88 5380226822812268 query89 480 368 359 359 query90 1814173 232 173 query91 121 102 95 95 query92 57 47 50 47 query93 4986500 499 499 query94 1120176 177 176 query95 370 283 284 283 query96 593 265 262 262 query97 2665247424502450 query98 231 214 209 209 query99 1249853 848 848 Total cold run time: 293155 ms Total hot run time: 183511 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
doris-robot commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053960027 TeamCity be ut coverage result: Function Coverage: 35.54% (8906/25056) Line Coverage: 27.27% (73140/268215) Region Coverage: 26.41% (37829/143251) Branch Coverage: 23.16% (19271/83222) Coverage Report: http://coverage.selectdb-in.cc/coverage/78e6ecd485ea94025feb7c77edb97dfc80a883e8_78e6ecd485ea94025feb7c77edb97dfc80a883e8/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
doris-robot commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2053960682 ClickBench: Total hot run time: 30.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit cd1c657f17f91c9cde15531e3d3798d6144cef97, data reload: false query1 0.040.040.03 query2 0.080.030.03 query3 0.230.050.05 query4 1.680.070.08 query5 0.490.500.49 query6 1.530.650.66 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.490.49 query10 0.540.560.55 query11 0.160.110.11 query12 0.140.110.12 query13 0.610.590.59 query14 0.740.780.79 query15 0.820.820.81 query16 0.370.370.36 query17 0.960.960.99 query18 0.220.230.25 query19 1.871.661.78 query20 0.020.010.01 query21 15.42 0.660.65 query22 4.177.711.87 query23 18.28 1.321.30 query24 1.770.310.21 query25 0.150.080.08 query26 0.270.160.16 query27 0.080.080.08 query28 13.28 0.990.99 query29 12.58 3.383.35 query30 0.260.070.06 query31 2.840.360.38 query32 3.300.460.47 query33 2.812.872.87 query34 17.11 4.424.38 query35 4.494.444.49 query36 0.650.460.46 query37 0.180.150.15 query38 0.150.140.14 query39 0.040.030.04 query40 0.170.150.14 query41 0.090.040.05 query42 0.050.050.04 query43 0.040.040.03 Total cold run time: 109.3 s Total hot run time: 30.32 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
doris-robot commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2053961922 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit cd1c657f17f91c9cde15531e3d3798d6144cef97 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 13.5 seconds inserted 1000 Rows, about 740K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated (96ed07c83ef -> 80f25cbf755)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from 96ed07c83ef [fix](test) fix some p2 external table test cases (#33624) new 0e5226e7c34 [fix](Nereids) create view should forward to master (#33626) new 565de9d7cdd [fix](create table) Fix create table exception without cleaning the e… (#33574) new 80f25cbf755 [fix](schema change) follow fe set sc fail replicas as bad (#33569) The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: be/src/olap/schema_change.cpp | 6 + .../java/org/apache/doris/alter/AlterHandler.java | 1 + .../java/org/apache/doris/alter/AlterJobV2.java| 5 + .../java/org/apache/doris/alter/RollupJobV2.java | 27 +++-- .../org/apache/doris/alter/SchemaChangeJobV2.java | 27 +++-- .../apache/doris/datasource/InternalCatalog.java | 24 +++- .../trees/plans/commands/CreateViewCommand.java| 2 +- .../test_create_table_exception.groovy | 127 + .../test_schema_change_fail.groovy | 94 +++ 9 files changed, 286 insertions(+), 27 deletions(-) create mode 100644 regression-test/suites/partition_p0/test_create_table_exception.groovy create mode 100644 regression-test/suites/schema_change_p2/test_schema_change_fail.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) 02/03: [fix](create table) Fix create table exception without cleaning the e… (#33574)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 565de9d7cddb0e6fd84f99e21b121b10162eb7a3
Author: deardeng <565620...@qq.com>
AuthorDate: Sun Apr 14 09:44:25 2024 +0800
[fix](create table) Fix create table exception without cleaning the e…
(#33574)
---
.../apache/doris/datasource/InternalCatalog.java | 24 +++-
.../test_create_table_exception.groovy | 127 +
2 files changed, 147 insertions(+), 4 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
index 9295ab56a18..b94c8b7d076 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
@@ -126,6 +126,7 @@ import org.apache.doris.common.Pair;
import org.apache.doris.common.UserException;
import org.apache.doris.common.io.CountingDataOutputStream;
import org.apache.doris.common.util.DbUtil;
+import org.apache.doris.common.util.DebugPointUtil;
import org.apache.doris.common.util.DynamicPartitionUtil;
import org.apache.doris.common.util.IdGeneratorUtil;
import org.apache.doris.common.util.MetaLockUtils;
@@ -959,15 +960,14 @@ public class InternalCatalog implements
CatalogIf {
return true;
}
-public void replayDropTable(Database db, long tableId, boolean isForceDrop,
-Long recycleTime) throws MetaNotFoundException {
+public void dropTable(Database db, long tableId, boolean isForceDrop,
+ Long recycleTime) throws MetaNotFoundException {
Table table = db.getTableOrMetaException(tableId);
db.writeLock();
table.writeLock();
try {
unprotectDropTable(db, table, isForceDrop, true, recycleTime);
-
Env.getCurrentEnv().getQueryStats().clear(Env.getCurrentInternalCatalog().getId(),
db.getId(),
-tableId);
+
Env.getCurrentEnv().getQueryStats().clear(Env.getCurrentInternalCatalog().getId(),
db.getId(), tableId);
Env.getCurrentEnv().getAnalysisManager().removeTableStats(table.getId());
} finally {
table.writeUnlock();
@@ -975,6 +975,11 @@ public class InternalCatalog implements
CatalogIf {
}
}
+public void replayDropTable(Database db, long tableId, boolean isForceDrop,
+Long recycleTime) throws MetaNotFoundException {
+dropTable(db, tableId, isForceDrop, recycleTime);
+}
+
public void replayEraseTable(long tableId) {
Env.getCurrentRecycleBin().replayEraseTable(tableId);
}
@@ -2710,6 +2715,11 @@ public class InternalCatalog implements
CatalogIf {
if (!result.first) {
ErrorReport.reportDdlException(ErrorCode.ERR_TABLE_EXISTS_ERROR, tableName);
}
+if (DebugPointUtil.isEnable("FE.createOlapTable.exception")) {
+LOG.info("debug point FE.createOlapTable.exception, throw e");
+// not commit, not log edit
+throw new DdlException("debug point
FE.createOlapTable.exception");
+}
if (result.second) {
if (Env.getCurrentColocateIndex().isColocateTable(tableId)) {
@@ -2741,6 +2751,7 @@ public class InternalCatalog implements
CatalogIf {
TimeUtils.getCurrentFormatTime());
}
} catch (DdlException e) {
+LOG.warn("create table failed {} - {}", tabletIdSet,
e.getMessage());
for (Long tabletId : tabletIdSet) {
Env.getCurrentInvertedIndex().deleteTablet(tabletId);
}
@@ -2748,6 +2759,11 @@ public class InternalCatalog implements
CatalogIf {
if (Env.getCurrentColocateIndex().isColocateTable(tableId)) {
Env.getCurrentColocateIndex().removeTable(tableId);
}
+try {
+dropTable(db, tableId, true, 0L);
+} catch (Exception ex) {
+LOG.warn("drop table", ex);
+}
throw e;
}
diff --git
a/regression-test/suites/partition_p0/test_create_table_exception.groovy
b/regression-test/suites/partition_p0/test_create_table_exception.groovy
new file mode 100644
index 000..49cadcd3af4
--- /dev/null
+++ b/regression-test/suites/partition_p0/test_create_table_exception.groovy
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the
(doris) 01/03: [fix](Nereids) create view should forward to master (#33626)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 0e5226e7c34a249a0212d265a8f96cccf05fcacb
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Sun Apr 14 15:45:07 2024 +0800
[fix](Nereids) create view should forward to master (#33626)
fix: create view should forward to master
---
.../apache/doris/nereids/trees/plans/commands/CreateViewCommand.java| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
index d78308664b5..25cd171959d 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateViewCommand.java
@@ -26,7 +26,7 @@ import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.StmtExecutor;
/** CreateViewCommand */
-public class CreateViewCommand extends Command {
+public class CreateViewCommand extends Command implements ForwardWithSync {
private final CreateViewInfo createViewInfo;
public CreateViewCommand(CreateViewInfo createViewInfo) {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
(doris) 03/03: [fix](schema change) follow fe set sc fail replicas as bad (#33569)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 80f25cbf7553e30ca79bfd88b51f58584cf4b7b0
Author: yujun
AuthorDate: Sun Apr 14 09:44:43 2024 +0800
[fix](schema change) follow fe set sc fail replicas as bad (#33569)
---
be/src/olap/schema_change.cpp | 6 ++
.../java/org/apache/doris/alter/AlterHandler.java | 1 +
.../java/org/apache/doris/alter/AlterJobV2.java| 5 ++
.../java/org/apache/doris/alter/RollupJobV2.java | 27 ---
.../org/apache/doris/alter/SchemaChangeJobV2.java | 27 ---
.../test_schema_change_fail.groovy | 94 ++
6 files changed, 138 insertions(+), 22 deletions(-)
diff --git a/be/src/olap/schema_change.cpp b/be/src/olap/schema_change.cpp
index 3235220b21b..e753da43454 100644
--- a/be/src/olap/schema_change.cpp
+++ b/be/src/olap/schema_change.cpp
@@ -794,6 +794,12 @@ Status
SchemaChangeHandler::_do_process_alter_tablet_v2(const TAlterTabletReqV2&
break;
}
+DBUG_EXECUTE_IF("SchemaChangeJob.process_alter_tablet.alter_fail",
{
+LOG(WARNING) << "inject alter tablet failed. base_tablet=" <<
request.base_tablet_id
+ << ", new_tablet=" << request.new_tablet_id;
+break;
+});
+
// should check the max_version >= request.alter_version, if not
the convert is useless
if (max_rowset == nullptr || max_rowset->end_version() <
request.alter_version) {
res = Status::InternalError(
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/AlterHandler.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/AlterHandler.java
index 43ad9de5ffd..030fd17452d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/AlterHandler.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/AlterHandler.java
@@ -269,6 +269,7 @@ public abstract class AlterHandler extends MasterDaemon {
alterJob.replay(alterJob);
alterJobsV2.put(alterJob.getJobId(), alterJob);
} else {
+existingJob.failedTabletBackends = alterJob.failedTabletBackends;
existingJob.replay(alterJob);
}
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java
index c1a62023042..3574b1e6e6b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/AlterJobV2.java
@@ -29,6 +29,7 @@ import org.apache.doris.common.io.Writable;
import org.apache.doris.common.util.DebugPointUtil;
import org.apache.doris.persist.gson.GsonUtils;
+import com.google.common.collect.Maps;
import com.google.gson.annotations.SerializedName;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -36,6 +37,7 @@ import org.apache.logging.log4j.Logger;
import java.io.DataInput;
import java.io.IOException;
import java.util.List;
+import java.util.Map;
/*
* Version 2 of AlterJob, for replacing the old version of AlterJob.
@@ -94,6 +96,9 @@ public abstract class AlterJobV2 implements Writable {
@SerializedName(value = "watershedTxnId")
protected long watershedTxnId = -1;
+// save failed task after retry three times, tablet -> backends
+@SerializedName(value = "failedTabletBackends")
+protected Map> failedTabletBackends = Maps.newHashMap();
public AlterJobV2(String rawSql, long jobId, JobType jobType, long dbId,
long tableId, String tableName,
long timeoutMs) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
index 61e4496a358..8ad67cfd92e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
@@ -135,8 +135,6 @@ public class RollupJobV2 extends AlterJobV2 implements
GsonPostProcessable {
// save all create rollup tasks
private AgentBatchTask rollupBatchTask = new AgentBatchTask();
-// save failed task after retry three times, tabletId -> agentTask
-private Map> failedAgentTasks = Maps.newHashMap();
private Analyzer analyzer;
@@ -517,17 +515,18 @@ public class RollupJobV2 extends AlterJobV2 implements
GsonPostProcessable {
task.setFinished(true);
AgentTaskQueue.removeTask(task.getBackendId(),
TTaskType.ALTER, task.getSignature());
LOG.warn("rollup task failed: " + task.getErrorMsg());
-if (!failedAgentTasks.containsKey(task.getTabletId())) {
-failedAgentTasks.put(task.getTabletId(),
Lists.newArrayList(task));
-} else {
-
Re: [PR] [fix](merge-iterator) Fix mem leak when get next batch failed [doris]
github-actions[bot] commented on PR #33627: URL: https://github.com/apache/doris/pull/33627#issuecomment-2053963058 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
doris-robot commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053963366 TPC-H: Total hot run time: 39195 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 0db201c93f820b28c0820440ac0f3d05ccc592fc, data reload: false -- Round 1 -- q1 17610 451043534353 q2 2014201 194 194 q3 10406 125912091209 q4 10198 729 776 729 q5 7553274326272627 q6 218 136 136 136 q7 1044648 597 597 q8 9216210120672067 q9 8030663965706570 q10 8600356735443544 q11 462 249 255 249 q12 530 223 228 223 q13 18945 302930163016 q14 287 239 246 239 q15 520 479 478 478 q16 526 410 404 404 q17 980 714 780 714 q18 7391692068266826 q19 5951154015301530 q20 710 327 329 327 q21 3698284128752841 q22 387 322 322 322 Total cold run time: 115276 ms Total hot run time: 39195 ms - Round 2, with runtime_filter_mode=off - q1 4424427342944273 q2 376 273 253 253 q3 2998282127922792 q4 1937162516221622 q5 5357533453715334 q6 212 125 125 125 q7 2270189119571891 q8 3219334133403340 q9 8688862888918628 q10 4104407139973997 q11 629 517 520 517 q12 794 621 656 621 q13 17603 315631373137 q14 332 285 298 285 q15 523 480 478 478 q16 501 479 500 479 q17 1826154715041504 q18 8195797977677767 q19 1709158115841581 q20 2086186018451845 q21 5178501150035003 q22 607 475 463 463 Total cold run time: 73568 ms Total hot run time: 55935 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
doris-robot commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2053963449 TPC-H: Total hot run time: 38061 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a4f6fb1d9f0301fee11291ac546a958d6a2b3089, data reload: false -- Round 1 -- q1 17609 429042254225 q2 2005184 182 182 q3 10466 114912111149 q4 10191 726 829 726 q5 7542268826412641 q6 219 132 130 130 q7 991 597 571 571 q8 9224204420322032 q9 7903651565046504 q10 8552353635083508 q11 470 240 229 229 q12 472 220 205 205 q13 17783 290829292908 q14 272 220 233 220 q15 515 487 473 473 q16 502 373 377 373 q17 951 618 677 618 q18 7354666265466546 q19 5423152914861486 q20 692 314 308 308 q21 3467273228362732 q22 364 295 304 295 Total cold run time: 112967 ms Total hot run time: 38061 ms - Round 2, with runtime_filter_mode=off - q1 4376427742524252 q2 367 255 271 255 q3 3015275627812756 q4 1861157815571557 q5 5328531652775277 q6 210 123 124 123 q7 2230187919021879 q8 3186334533183318 q9 8564853385578533 q10 4093393839203920 q11 641 521 510 510 q12 779 670 643 643 q13 17814 327030213021 q14 321 306 302 302 q15 519 480 472 472 q16 504 442 445 442 q17 1827153015271527 q18 8113788778567856 q19 1650155416181554 q20 2038185918161816 q21 5227489249454892 q22 524 455 468 455 Total cold run time: 73187 ms Total hot run time: 55360 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
doris-robot commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053963886 TPC-H: Total hot run time: 38777 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 78e6ecd485ea94025feb7c77edb97dfc80a883e8, data reload: false -- Round 1 -- q1 17662 496143704370 q2 2647195 200 195 q3 11085 123412281228 q4 10615 833 811 811 q5 7612278726912691 q6 225 133 129 129 q7 1008611 597 597 q8 9478206120522052 q9 7945663365486548 q10 8472348735673487 q11 466 227 228 227 q12 464 220 206 206 q13 19106 293829452938 q14 275 229 235 229 q15 513 479 477 477 q16 503 394 373 373 q17 1029677 740 677 q18 7369677066836683 q19 1595153415191519 q20 703 303 296 296 q21 3570286727542754 q22 359 298 290 290 Total cold run time: 112701 ms Total hot run time: 38777 ms - Round 2, with runtime_filter_mode=off - q1 4241417541644164 q2 369 252 268 252 q3 3020272327572723 q4 1892159116141591 q5 5304527853105278 q6 205 126 120 120 q7 2278184418481844 q8 3152334733373337 q9 8514850485538504 q10 3868373537033703 q11 558 470 463 463 q12 759 587 594 587 q13 17798 292529482925 q14 302 275 275 275 q15 511 467 458 458 q16 465 405 410 405 q17 1737148114361436 q18 7488761172947294 q19 1670154315701543 q20 1964173317291729 q21 4799471546544654 q22 540 455 452 452 Total cold run time: 71434 ms Total hot run time: 53737 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
BiteThet commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053965663 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error and log msg when stacktr… [doris]
BiteThet commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053966122 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
doris-robot commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053966277 TeamCity be ut coverage result: Function Coverage: 35.57% (8905/25037) Line Coverage: 27.30% (73131/267855) Region Coverage: 26.43% (37815/143069) Branch Coverage: 23.19% (19264/83084) Coverage Report: http://coverage.selectdb-in.cc/coverage/0db201c93f820b28c0820440ac0f3d05ccc592fc_0db201c93f820b28c0820440ac0f3d05ccc592fc/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](merge-iterator) Fix mem leak when get next batch failed [doris]
yiguolei merged PR #33627: URL: https://github.com/apache/doris/pull/33627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
github-actions[bot] commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053967185 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](merge-iterator) Fix mem leak when get next batch failed (#33627)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 69df5ee [fix](merge-iterator) Fix mem leak when get next batch
failed (#33627)
69df5ee is described below
commit 69df5ee8fb7fd97c8da005e0806e65bc7e8e
Author: Xin Liao
AuthorDate: Sun Apr 14 16:37:23 2024 +0800
[fix](merge-iterator) Fix mem leak when get next batch failed (#33627)
---
be/src/vec/olap/vgeneric_iterators.cpp | 4 ++--
be/src/vec/olap/vgeneric_iterators.h | 24
2 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/be/src/vec/olap/vgeneric_iterators.cpp
b/be/src/vec/olap/vgeneric_iterators.cpp
index 26fe590dd60..4e3df66cd0f 100644
--- a/be/src/vec/olap/vgeneric_iterators.cpp
+++ b/be/src/vec/olap/vgeneric_iterators.cpp
@@ -334,14 +334,14 @@ Status VMergeIterator::init(const StorageReadOptions&
opts) {
_record_rowids = opts.record_rowids;
for (auto& iter : _origin_iters) {
-auto ctx = std::make_unique(std::move(iter),
_sequence_id_idx,
+auto ctx = std::make_shared(std::move(iter),
_sequence_id_idx,
_is_unique,
_is_reverse,
opts.read_orderby_key_columns);
RETURN_IF_ERROR(ctx->init(opts));
if (!ctx->valid()) {
continue;
}
-_merge_heap.push(ctx.release());
+_merge_heap.push(ctx);
}
_origin_iters.clear();
diff --git a/be/src/vec/olap/vgeneric_iterators.h
b/be/src/vec/olap/vgeneric_iterators.h
index d67bb68fefa..89eb130348f 100644
--- a/be/src/vec/olap/vgeneric_iterators.h
+++ b/be/src/vec/olap/vgeneric_iterators.h
@@ -194,13 +194,7 @@ public:
_is_reverse(is_reverse),
_merged_rows(merged_rows) {}
-~VMergeIterator() override {
-while (!_merge_heap.empty()) {
-auto ctx = _merge_heap.top();
-_merge_heap.pop();
-delete ctx;
-}
-}
+~VMergeIterator() override = default;
Status init(const StorageReadOptions& opts) override;
@@ -232,7 +226,7 @@ private:
_block_row_locations.resize(_block_row_max);
}
size_t row_idx = 0;
-VMergeIteratorContext* pre_ctx = nullptr;
+std::shared_ptr pre_ctx;
while (_get_size(block) < _block_row_max) {
if (_merge_heap.empty()) {
break;
@@ -249,7 +243,7 @@ private:
}
pre_ctx = ctx;
}
-pre_ctx->set_pre_ctx_same(ctx);
+pre_ctx->set_pre_ctx_same(ctx.get());
if (UNLIKELY(_record_rowids)) {
_block_row_locations[row_idx] =
ctx->current_row_location();
}
@@ -272,9 +266,6 @@ private:
RETURN_IF_ERROR(ctx->advance());
if (ctx->valid()) {
_merge_heap.push(ctx);
-} else {
-// Release ctx earlier to reduce resource consumed
-delete ctx;
}
}
if (!_merge_heap.empty()) {
@@ -295,14 +286,15 @@ private:
const Schema* _schema = nullptr;
struct VMergeContextComparator {
-bool operator()(const VMergeIteratorContext* lhs, const
VMergeIteratorContext* rhs) const {
+bool operator()(const std::shared_ptr& lhs,
+const std::shared_ptr& rhs)
const {
return lhs->compare(*rhs);
}
};
-using VMergeHeap =
-std::priority_queue,
-VMergeContextComparator>;
+using VMergeHeap =
std::priority_queue,
+
std::vector>,
+ VMergeContextComparator>;
VMergeHeap _merge_heap;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
github-actions[bot] commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053967142 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
github-actions[bot] commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053967129 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [fix](merge-iterator) Fix mem leak when get next batch failed (#33627)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 9154b5471a2 [fix](merge-iterator) Fix mem leak when get next batch
failed (#33627)
9154b5471a2 is described below
commit 9154b5471a206725b704a019a71bce880bf61164
Author: Xin Liao
AuthorDate: Sun Apr 14 16:37:23 2024 +0800
[fix](merge-iterator) Fix mem leak when get next batch failed (#33627)
---
be/src/vec/olap/vgeneric_iterators.cpp | 4 ++--
be/src/vec/olap/vgeneric_iterators.h | 24
2 files changed, 10 insertions(+), 18 deletions(-)
diff --git a/be/src/vec/olap/vgeneric_iterators.cpp
b/be/src/vec/olap/vgeneric_iterators.cpp
index 26fe590dd60..4e3df66cd0f 100644
--- a/be/src/vec/olap/vgeneric_iterators.cpp
+++ b/be/src/vec/olap/vgeneric_iterators.cpp
@@ -334,14 +334,14 @@ Status VMergeIterator::init(const StorageReadOptions&
opts) {
_record_rowids = opts.record_rowids;
for (auto& iter : _origin_iters) {
-auto ctx = std::make_unique(std::move(iter),
_sequence_id_idx,
+auto ctx = std::make_shared(std::move(iter),
_sequence_id_idx,
_is_unique,
_is_reverse,
opts.read_orderby_key_columns);
RETURN_IF_ERROR(ctx->init(opts));
if (!ctx->valid()) {
continue;
}
-_merge_heap.push(ctx.release());
+_merge_heap.push(ctx);
}
_origin_iters.clear();
diff --git a/be/src/vec/olap/vgeneric_iterators.h
b/be/src/vec/olap/vgeneric_iterators.h
index d67bb68fefa..89eb130348f 100644
--- a/be/src/vec/olap/vgeneric_iterators.h
+++ b/be/src/vec/olap/vgeneric_iterators.h
@@ -194,13 +194,7 @@ public:
_is_reverse(is_reverse),
_merged_rows(merged_rows) {}
-~VMergeIterator() override {
-while (!_merge_heap.empty()) {
-auto ctx = _merge_heap.top();
-_merge_heap.pop();
-delete ctx;
-}
-}
+~VMergeIterator() override = default;
Status init(const StorageReadOptions& opts) override;
@@ -232,7 +226,7 @@ private:
_block_row_locations.resize(_block_row_max);
}
size_t row_idx = 0;
-VMergeIteratorContext* pre_ctx = nullptr;
+std::shared_ptr pre_ctx;
while (_get_size(block) < _block_row_max) {
if (_merge_heap.empty()) {
break;
@@ -249,7 +243,7 @@ private:
}
pre_ctx = ctx;
}
-pre_ctx->set_pre_ctx_same(ctx);
+pre_ctx->set_pre_ctx_same(ctx.get());
if (UNLIKELY(_record_rowids)) {
_block_row_locations[row_idx] =
ctx->current_row_location();
}
@@ -272,9 +266,6 @@ private:
RETURN_IF_ERROR(ctx->advance());
if (ctx->valid()) {
_merge_heap.push(ctx);
-} else {
-// Release ctx earlier to reduce resource consumed
-delete ctx;
}
}
if (!_merge_heap.empty()) {
@@ -295,14 +286,15 @@ private:
const Schema* _schema = nullptr;
struct VMergeContextComparator {
-bool operator()(const VMergeIteratorContext* lhs, const
VMergeIteratorContext* rhs) const {
+bool operator()(const std::shared_ptr& lhs,
+const std::shared_ptr& rhs)
const {
return lhs->compare(*rhs);
}
};
-using VMergeHeap =
-std::priority_queue,
-VMergeContextComparator>;
+using VMergeHeap =
std::priority_queue,
+
std::vector>,
+ VMergeContextComparator>;
VMergeHeap _merge_heap;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
doris-robot commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053967724 TPC-DS: Total hot run time: 186973 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 0db201c93f820b28c0820440ac0f3d05ccc592fc, data reload: false query1 874 112211121112 query2 7556274425262526 query3 6649217 217 217 query4 36913 21560 21565 21560 query5 4323421 411 411 query6 241 197 180 180 query7 4044307 302 302 query8 217 174 182 174 query9 5947252425172517 query10 385 272 251 251 query11 14678 14292 14202 14202 query12 144 92 89 89 query13 981 380 374 374 query14 8594692869676928 query15 209 187 184 184 query16 7200281 269 269 query17 1561598 581 581 query18 1507298 288 288 query19 214 159 166 159 query20 97 95 90 90 query21 196 131 130 130 query22 5085485948474847 query23 33972 33080 33487 33080 query24 6980307230893072 query25 531 417 420 417 query26 818 175 179 175 query27 2582379 411 379 query28 4563232122682268 query29 884 682 650 650 query30 231 184 181 181 query31 963 740 768 740 query32 64 57 54 54 query33 524 266 273 266 query34 950 508 518 508 query35 834 777 745 745 query36 1132970 971 970 query37 116 76 75 75 query38 3483340333493349 query39 1638157115891571 query40 181 134 131 131 query41 58 48 48 48 query42 110 101 108 101 query43 619 584 585 584 query44 1256795 807 795 query45 290 261 293 261 query46 1128830 771 771 query47 2093199420231994 query48 411 327 336 327 query49 727 395 391 391 query50 802 417 407 407 query51 6892677567946775 query52 106 95 95 95 query53 354 278 282 278 query54 263 244 234 234 query55 81 75 80 75 query56 257 231 230 230 query57 1232118911421142 query58 225 216 220 216 query59 3693330032873287 query60 256 239 244 239 query61 91 92 107 92 query62 542 449 437 437 query63 305 279 283 279 query64 4147393239313931 query65 3067307230433043 query66 754 317 318 317 query67 15841 15445 15122 15122 query68 10692 597 596 596 query69 614 313 310 310 query70 1347121512241215 query71 509 280 282 280 query72 6460261824252425 query73 1567346 339 339 query74 6982640363736373 query75 4027268126702670 query76 6507112011231120 query77 605 253 251 251 query78 11033 10266 10100 10100 query79 11650 542 541 541 query80 2704437 425 425 query81 564 230 239 230 query82 247 103 100 100 query83 224 175 181 175 query84 264 85 88 85 query85 1154266 258 258 query86 356 307 293 293 query87 3450326532563256 query88 6693245125642451 query89 517 370 377 370 query90 2315175 176 175 query91 120 98 97 97 query92 68 81 50 50 query93 6669546 542 542 query94 1645190 183 183 query95 394 298 301 298 query96 639 271 274 271 query97 3118292529452925 query98 256 223 227 223 query99 1092853 865 853 Total cold run time: 308143 ms Total hot run time: 186973 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
github-actions[bot] commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053967761 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
doris-robot commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2053967782 TPC-DS: Total hot run time: 183526 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a4f6fb1d9f0301fee11291ac546a958d6a2b3089, data reload: false query1 868 111711321117 query2 7448255223232323 query3 6656211 201 201 query4 37017 21437 21343 21343 query5 4151390 388 388 query6 230 179 175 175 query7 4030282 282 282 query8 212 170 172 170 query9 5771228222592259 query10 361 232 241 232 query11 14803 14219 14275 14219 query12 135 93 86 86 query13 988 361 365 361 query14 8690690768676867 query15 216 182 174 174 query16 7235272 254 254 query17 1688594 557 557 query18 1474299 273 273 query19 210 156 154 154 query20 94 87 87 87 query21 198 131 125 125 query22 5045492148514851 query23 33767 32849 33381 32849 query24 11203 298630022986 query25 568 420 404 404 query26 908 160 158 158 query27 3067361 358 358 query28 6646207821042078 query29 886 659 634 634 query30 284 177 173 173 query31 954 737 750 737 query32 63 120 54 54 query33 559 244 244 244 query34 892 485 505 485 query35 829 691 717 691 query36 1055946 938 938 query37 108 70 73 70 query38 3666358135393539 query39 1628156815511551 query40 185 128 128 128 query41 47 44 43 43 query42 104 97 97 97 query43 579 541 541 541 query44 1316734 723 723 query45 296 300 255 255 query46 1080731 741 731 query47 2029200619731973 query48 369 294 295 294 query49 834 379 364 364 query50 796 395 386 386 query51 6869681068246810 query52 101 83 90 83 query53 340 282 276 276 query54 254 216 225 216 query55 72 70 69 69 query56 235 216 224 216 query57 1235113211391132 query58 214 199 198 198 query59 3207334830563056 query60 259 256 236 236 query61 111 90 86 86 query62 593 439 427 427 query63 307 273 271 271 query64 3961409439743974 query65 3068299830182998 query66 721 310 364 310 query67 15939 15033 14787 14787 query68 8820543 550 543 query69 604 299 309 299 query70 1277120611391139 query71 499 281 262 262 query72 6842264424292429 query73 903 316 317 316 query74 7132636764436367 query75 3512239523172317 query76 5323115611651156 query77 620 250 249 249 query78 10946 10372 10101 10101 query79 9868520 514 514 query80 1983458 420 420 query81 509 232 226 226 query82 818 91 91 91 query83 212 165 166 165 query84 258 84 79 79 query85 992 314 266 266 query86 420 293 315 293 query87 3739347934923479 query88 5993226423622264 query89 526 366 370 366 query90 1979177 172 172 query91 119 96 98 96 query92 64 48 47 47 query93 6661500 499 499 query94 1125176 178 176 query95 378 286 285 285 query96 601 256 259 256 query97 2659244824592448 query98 229 224 219 219 query99 1182860 887 860 Total cold run time: 306517 ms Total hot run time: 183526 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
doris-robot commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053967914 TPC-DS: Total hot run time: 182549 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 78e6ecd485ea94025feb7c77edb97dfc80a883e8, data reload: false query1 890 112611201120 query2 6505259024552455 query3 6657206 206 206 query4 37771 21570 21353 21353 query5 4159384 400 384 query6 225 177 175 175 query7 4059291 280 280 query8 224 175 175 175 query9 5770230023062300 query10 540 248 242 242 query11 14662 14224 14172 14172 query12 140 91 88 88 query13 995 370 349 349 query14 8939665166566651 query15 197 176 175 175 query16 7172265 254 254 query17 1483568 552 552 query18 1494274 269 269 query19 194 151 151 151 query20 92 87 87 87 query21 206 125 125 125 query22 4963488248504850 query23 33559 33048 32773 32773 query24 12890 293028092809 query25 554 363 369 363 query26 1864152 151 151 query27 3147305 308 305 query28 7818203720232023 query29 863 601 590 590 query30 303 156 160 156 query31 886 698 720 698 query32 60 52 53 52 query33 589 253 257 253 query34 889 483 485 483 query35 840 693 698 693 query36 1067929 944 929 query37 285 69 69 69 query38 3517346134403440 query39 1572153215231523 query40 272 128 126 126 query41 46 48 43 43 query42 106 96 91 91 query43 572 561 559 559 query44 1420698 698 698 query45 285 272 258 258 query46 1050712 729 712 query47 1970185018451845 query48 349 293 286 286 query49 1139369 360 360 query50 750 375 370 370 query51 6656656065106510 query52 104 86 93 86 query53 353 274 274 274 query54 254 227 218 218 query55 76 72 71 71 query56 243 222 238 222 query57 1198112811311128 query58 229 203 196 196 query59 3507340032303230 query60 254 232 235 232 query61 91 91 94 91 query62 640 428 440 428 query63 296 275 270 270 query64 4964367340893673 query65 3091301029992999 query66 1321342 317 317 query67 15704 14981 14940 14940 query68 4777528 536 528 query69 516 291 300 291 query70 1272114912071149 query71 424 272 265 265 query72 6498261024152415 query73 724 315 310 310 query74 6836638464786384 query75 3117237023502350 query76 3152110111421101 query77 656 246 245 245 query78 10910 10234 10170 10170 query79 2964515 510 510 query80 2106429 421 421 query81 535 234 236 234 query82 110896 99 96 query83 343 181 180 180 query84 269 86 93 86 query85 1731312 308 308 query86 476 297 294 294 query87 3828351135093509 query88 5379234222682268 query89 486 371 386 371 query90 1977177 174 174 query91 130 111 108 108 query92 62 49 48 48 query93 4884514 491 491 query94 1285182 180 180 query95 389 300 284 284 query96 593 269 260 260 query97 2671250525062505 query98 241 231 212 212 query99 1245846 869 846 Total cold run time: 296564 ms Total hot run time: 182549 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
[PR] [Chore](status) change unknow filter error to internal error [doris]
BiteThet opened a new pull request, #33633: URL: https://github.com/apache/doris/pull/33633 ## Proposed changes pick from #33632 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
doris-robot commented on PR #33633: URL: https://github.com/apache/doris/pull/33633#issuecomment-2053968125 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
yiguolei merged PR #33633: URL: https://github.com/apache/doris/pull/33633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: [Chore](status) change unknow filter error to internal error (#33633)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 6ce61eb5fc3 [Chore](status) change unknow filter error to internal
error (#33633)
6ce61eb5fc3 is described below
commit 6ce61eb5fc3732081471c27ee655891edcac2bc5
Author: Pxl
AuthorDate: Sun Apr 14 16:44:21 2024 +0800
[Chore](status) change unknow filter error to internal error (#33633)
---
be/src/runtime/runtime_filter_mgr.cpp | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/be/src/runtime/runtime_filter_mgr.cpp
b/be/src/runtime/runtime_filter_mgr.cpp
index f1adb4ed198..65c1852625b 100644
--- a/be/src/runtime/runtime_filter_mgr.cpp
+++ b/be/src/runtime/runtime_filter_mgr.cpp
@@ -72,7 +72,8 @@ Status RuntimeFilterMgr::get_consume_filters(const int
filter_id,
std::lock_guard l(_lock);
auto iter = _consumer_map.find(filter_id);
if (iter == _consumer_map.end()) {
-return Status::InvalidArgument("unknown filter: {}, role: CONSUMER.",
filter_id);
+return Status::InternalError("get_consume_filters meet unknown filter:
{}, role: CONSUMER.",
+ filter_id);
}
for (auto& holder : iter->second) {
consumer_filters.emplace_back(holder.filter);
@@ -153,8 +154,10 @@ Status RuntimeFilterMgr::get_local_merge_producer_filters(
std::lock_guard l(_lock);
auto iter = _local_merge_producer_map.find(filter_id);
if (iter == _local_merge_producer_map.end()) {
-return Status::InvalidArgument("unknown filter: {}, role:
LOCAL_MERGE_PRODUCER.",
- filter_id);
+return Status::InternalError(
+"get_local_merge_producer_filters meet unknown filter: {},
role: "
+"LOCAL_MERGE_PRODUCER.",
+filter_id);
}
*local_merge_filters = &iter->second;
DCHECK(!iter->second.filters.empty());
@@ -194,7 +197,8 @@ Status RuntimeFilterMgr::update_filter(const
PPublishFilterRequest* request,
std::lock_guard l(_lock);
auto iter = _consumer_map.find(filter_id);
if (iter == _consumer_map.end()) {
-return Status::InvalidArgument("unknown filter: {}, role:
CONSUMER.", filter_id);
+return Status::InternalError("update_filter meet unknown filter:
{}, role: CONSUMER.",
+ filter_id);
}
for (auto& holder : iter->second) {
filters.emplace_back(holder.filter);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
doris-robot commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053969381 ClickBench: Total hot run time: 31.27 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 0db201c93f820b28c0820440ac0f3d05ccc592fc, data reload: false query1 0.040.040.03 query2 0.070.040.03 query3 0.230.050.04 query4 1.670.070.07 query5 0.490.490.50 query6 1.460.730.72 query7 0.020.010.01 query8 0.040.040.04 query9 0.560.520.50 query10 0.550.550.56 query11 0.170.120.11 query12 0.150.120.13 query13 0.600.580.59 query14 0.740.800.77 query15 0.830.810.82 query16 0.380.370.36 query17 0.950.981.01 query18 0.240.240.25 query19 1.861.761.71 query20 0.020.010.01 query21 15.41 0.670.66 query22 3.907.002.56 query23 18.31 1.261.24 query24 1.540.350.22 query25 0.150.080.08 query26 0.270.170.17 query27 0.080.070.08 query28 13.37 1.010.99 query29 12.56 3.443.42 query30 0.250.080.05 query31 2.830.380.37 query32 3.300.480.46 query33 2.822.862.87 query34 17.24 4.394.43 query35 4.454.544.52 query36 0.640.470.46 query37 0.190.160.15 query38 0.150.150.15 query39 0.050.040.04 query40 0.160.130.14 query41 0.110.050.04 query42 0.050.040.05 query43 0.040.030.04 Total cold run time: 108.94 s Total hot run time: 31.27 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
doris-robot commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2053969446 ClickBench: Total hot run time: 30.35 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit a4f6fb1d9f0301fee11291ac546a958d6a2b3089, data reload: false query1 0.040.030.03 query2 0.080.030.03 query3 0.230.040.05 query4 1.680.060.07 query5 0.500.470.48 query6 1.440.640.66 query7 0.020.010.01 query8 0.050.040.05 query9 0.560.500.49 query10 0.560.570.53 query11 0.150.110.12 query12 0.150.120.12 query13 0.610.590.59 query14 0.750.760.77 query15 0.820.800.80 query16 0.400.360.37 query17 1.011.011.00 query18 0.210.260.21 query19 1.841.801.67 query20 0.010.000.01 query21 15.40 0.640.64 query22 4.466.142.22 query23 18.33 1.381.24 query24 1.760.270.21 query25 0.140.080.08 query26 0.270.160.16 query27 0.070.080.07 query28 13.42 0.991.00 query29 12.61 3.293.28 query30 0.270.060.05 query31 2.880.370.37 query32 3.280.470.46 query33 2.842.762.82 query34 17.07 4.404.38 query35 4.464.464.43 query36 0.630.480.46 query37 0.190.160.16 query38 0.160.140.15 query39 0.040.040.04 query40 0.180.150.14 query41 0.090.040.05 query42 0.050.050.04 query43 0.040.040.03 Total cold run time: 109.75 s Total hot run time: 30.35 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
doris-robot commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053969556 ClickBench: Total hot run time: 30.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 78e6ecd485ea94025feb7c77edb97dfc80a883e8, data reload: false query1 0.040.030.03 query2 0.080.030.04 query3 0.220.050.05 query4 1.680.060.08 query5 0.490.500.48 query6 1.450.660.66 query7 0.020.010.02 query8 0.050.040.04 query9 0.560.500.50 query10 0.550.560.55 query11 0.140.110.11 query12 0.140.120.12 query13 0.590.580.57 query14 0.770.760.78 query15 0.820.800.81 query16 0.370.360.37 query17 0.931.001.01 query18 0.220.230.24 query19 1.871.651.75 query20 0.020.010.01 query21 15.40 0.660.65 query22 4.267.401.95 query23 18.31 1.301.25 query24 1.770.220.23 query25 0.150.080.08 query26 0.260.160.15 query27 0.080.070.08 query28 13.46 0.990.98 query29 12.60 3.293.29 query30 0.260.060.06 query31 2.860.370.38 query32 3.280.480.45 query33 2.782.812.81 query34 17.17 4.374.40 query35 4.474.454.45 query36 0.650.460.47 query37 0.190.160.15 query38 0.160.140.15 query39 0.040.040.03 query40 0.180.140.15 query41 0.100.050.05 query42 0.050.050.04 query43 0.040.040.04 Total cold run time: 109.53 s Total hot run time: 30.22 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
github-actions[bot] commented on PR #33633: URL: https://github.com/apache/doris/pull/33633#issuecomment-2053969900 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
doris-robot commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2053970302 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit a4f6fb1d9f0301fee11291ac546a958d6a2b3089 with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s Insert into select: 13.6 seconds inserted 1000 Rows, about 735K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](Operator) When _stop_emplace_flag is not set to true, perform batch processing on the block. [doris]
doris-robot commented on PR #33173: URL: https://github.com/apache/doris/pull/33173#issuecomment-2053970209 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 0db201c93f820b28c0820440ac0f3d05ccc592fc with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s Insert into select: 13.6 seconds inserted 1000 Rows, about 735K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
doris-robot commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2053970414 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 78e6ecd485ea94025feb7c77edb97dfc80a883e8 with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 13.2 seconds inserted 1000 Rows, about 757K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](status) change unknow filter error to internal error [doris]
doris-robot commented on PR #33632: URL: https://github.com/apache/doris/pull/33632#issuecomment-2053970999 TeamCity be ut coverage result: Function Coverage: 35.59% (8905/25020) Line Coverage: 27.31% (73130/267760) Region Coverage: 26.44% (37816/143030) Branch Coverage: 23.20% (19270/83072) Coverage Report: http://coverage.selectdb-in.cc/coverage/01a270a255bad660c2a61bbae6dfb53678576dd0_01a270a255bad660c2a61bbae6dfb53678576dd0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](regression-test) fix unstable test [doris]
yiguolei merged PR #33628: URL: https://github.com/apache/doris/pull/33628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](regression-test) fix unstable test (#33628)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7fd008946f3 [fix](regression-test) fix unstable test (#33628)
7fd008946f3 is described below
commit 7fd008946f31a07a715b5333b36243fca0213bc2
Author: 924060929 <924060...@qq.com>
AuthorDate: Sun Apr 14 16:54:19 2024 +0800
[fix](regression-test) fix unstable test (#33628)
---
.../nereids_p0/cache/parse_sql_from_sql_cache.groovy | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git
a/regression-test/suites/nereids_p0/cache/parse_sql_from_sql_cache.groovy
b/regression-test/suites/nereids_p0/cache/parse_sql_from_sql_cache.groovy
index 7523df43f0c..0a318218301 100644
--- a/regression-test/suites/nereids_p0/cache/parse_sql_from_sql_cache.groovy
+++ b/regression-test/suites/nereids_p0/cache/parse_sql_from_sql_cache.groovy
@@ -226,7 +226,7 @@ suite("parse_sql_from_sql_cache") {
sql "alter view test_use_plan_cache9_view as select id from
test_use_plan_cache9"
assertNoCache "select * from test_use_plan_cache9_view"
}),
-extraThread( "testDropView", {
+extraThread("testDropView", {
createTestTable "test_use_plan_cache10"
sql "drop view if exists test_use_plan_cache10_view"
@@ -291,6 +291,8 @@ suite("parse_sql_from_sql_cache") {
sql "select * from test_use_plan_cache12"
assertHasCache "select * from test_use_plan_cache12"
+sql "sync"
+
extraThread("test_cache_user1_thread", {
connect(user = "test_cache_user1", password="DORIS@2024") {
@@ -321,6 +323,8 @@ suite("parse_sql_from_sql_cache") {
// after partition changed 10s, the sql cache can be used
sleep(1)
+sql "sync"
+
extraThread("test_cache_user2_thread", {
connect(user = "test_cache_user2", password="DORIS@2024") {
sql "use ${dbName}"
@@ -342,6 +346,8 @@ suite("parse_sql_from_sql_cache") {
USING (id = 'concat(id, "**")')"""
sql "set enable_nereids_planner=true"
+sql "sync"
+
// after row policy changed, the cache is invalidate
extraThread("test_cache_user2_thread2", {
connect(user = "test_cache_user2", password="DORIS@2024") {
@@ -377,6 +383,8 @@ suite("parse_sql_from_sql_cache") {
USING (id = 'concat(id, "**")')"""
sql "set enable_nereids_planner=true"
+sql "sync"
+
// after partition changed 10s, the sql cache can be used
sleep(1)
@@ -400,6 +408,8 @@ suite("parse_sql_from_sql_cache") {
FOR test_cache_user3"""
sql "set enable_nereids_planner=true"
+sql "sync"
+
// after row policy changed, the cache is invalidate
extraThread("test_cache_user3_thread2", {
connect(user = "test_cache_user3", password="DORIS@2024") {
@@ -425,6 +435,8 @@ suite("parse_sql_from_sql_cache") {
sql "GRANT SELECT_PRIV ON regression_test.* TO test_cache_user4"
sql "GRANT SELECT_PRIV ON ${dbName}.test_use_plan_cache15 TO
test_cache_user4"
+sql "sync"
+
extraThread("test_cache_user4_thread", {
connect(user = "test_cache_user4", password="DORIS@2024") {
sql "use ${dbName}"
@@ -440,6 +452,8 @@ suite("parse_sql_from_sql_cache") {
sql "REVOKE SELECT_PRIV ON ${dbName}.test_use_plan_cache15 FROM
test_cache_user4"
+sql "sync"
+
// after privileges changed, the cache is invalidate
extraThread("test_cache_user4_thread2", {
connect(user = "test_cache_user4", password="DORIS@2024") {
@@ -484,7 +498,7 @@ suite("parse_sql_from_sql_cache") {
extraThread("testUserVariable", {
// make sure if the table has been dropped, the cache should
invalidate,
// so we should retry twice to check
-for (i in 0..2) {
+for (def i in 0..2) {
createTestTable "test_use_plan_cache17"
// after partition changed 10s, the sql cache can be used
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]
yiguolei commented on code in PR #33622:
URL: https://github.com/apache/doris/pull/33622#discussion_r1564583352
##
be/src/util/block_compression.cpp:
##
@@ -373,77 +375,75 @@ class Lz4fBlockCompression : public BlockCompressionCodec
{
private:
// acquire a compression ctx from pool, release while finish compress,
// delete if compression failed
-Status _acquire_compression_ctx(CContext** out) {
+Status _acquire_compression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_c_mutex);
if (_ctx_c_pool.empty()) {
-CContext* context = new (std::nothrow) CContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = CContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new LZ4F CContext");
}
-auto res = LZ4F_createCompressionContext(&context->ctx,
LZ4F_VERSION);
+auto res = LZ4F_createCompressionContext(&localCtx->ctx,
LZ4F_VERSION);
if (LZ4F_isError(res) != 0) {
return Status::InvalidArgument(strings::Substitute(
"LZ4F_createCompressionContext error, res=$0",
LZ4F_getErrorName(res)));
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_c_pool.back();
+out = _ctx_c_pool.back();
_ctx_c_pool.pop_back();
return Status::OK();
}
-void _release_compression_ctx(CContext* context) {
+void _release_compression_ctx(std::shared_ptr context) {
DCHECK(context);
std::lock_guard l(_ctx_c_mutex);
_ctx_c_pool.push_back(context);
}
-void _delete_compression_ctx(CContext* context) {
+void _delete_compression_ctx(std::shared_ptr context) {
DCHECK(context);
LZ4F_freeCompressionContext(context->ctx);
-delete context;
}
-Status _acquire_decompression_ctx(DContext** out) {
+Status _acquire_decompression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_d_mutex);
if (_ctx_d_pool.empty()) {
-DContext* context = new (std::nothrow) DContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = DContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new LZ4F DContext");
}
-auto res = LZ4F_createDecompressionContext(&context->ctx,
LZ4F_VERSION);
+auto res = LZ4F_createDecompressionContext(&localCtx->ctx,
LZ4F_VERSION);
if (LZ4F_isError(res) != 0) {
return Status::InvalidArgument(strings::Substitute(
"LZ4F_createDeompressionContext error, res=$0",
LZ4F_getErrorName(res)));
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_d_pool.back();
+out = _ctx_d_pool.back();
_ctx_d_pool.pop_back();
return Status::OK();
}
-void _release_decompression_ctx(DContext* context) {
+void _release_decompression_ctx(std::shared_ptr context) {
DCHECK(context);
// reset decompression context to avoid ERROR_maxBlockSize_invalid
LZ4F_resetDecompressionContext(context->ctx);
std::lock_guard l(_ctx_d_mutex);
_ctx_d_pool.push_back(context);
}
-void _delete_decompression_ctx(DContext* context) {
+void _delete_decompression_ctx(std::shared_ptr context) {
DCHECK(context);
LZ4F_freeDecompressionContext(context->ctx);
Review Comment:
this logic should be in the deconstructor of object Context or DContext.
Because if the Context or DContext is invalid or deconstructed, context->ctx
should always be freed.
And then you will find _delete_decompression_ctx is useless, we could delete
this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](decompress)(review) context leaked in failure path [doris]
yiguolei commented on code in PR #33622:
URL: https://github.com/apache/doris/pull/33622#discussion_r1564583983
##
be/src/util/block_compression.cpp:
##
@@ -373,77 +375,75 @@ class Lz4fBlockCompression : public BlockCompressionCodec
{
private:
// acquire a compression ctx from pool, release while finish compress,
// delete if compression failed
-Status _acquire_compression_ctx(CContext** out) {
+Status _acquire_compression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_c_mutex);
if (_ctx_c_pool.empty()) {
-CContext* context = new (std::nothrow) CContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = CContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new LZ4F CContext");
}
-auto res = LZ4F_createCompressionContext(&context->ctx,
LZ4F_VERSION);
+auto res = LZ4F_createCompressionContext(&localCtx->ctx,
LZ4F_VERSION);
if (LZ4F_isError(res) != 0) {
return Status::InvalidArgument(strings::Substitute(
"LZ4F_createCompressionContext error, res=$0",
LZ4F_getErrorName(res)));
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_c_pool.back();
+out = _ctx_c_pool.back();
_ctx_c_pool.pop_back();
return Status::OK();
}
-void _release_compression_ctx(CContext* context) {
+void _release_compression_ctx(std::shared_ptr context) {
DCHECK(context);
std::lock_guard l(_ctx_c_mutex);
_ctx_c_pool.push_back(context);
}
-void _delete_compression_ctx(CContext* context) {
+void _delete_compression_ctx(std::shared_ptr context) {
DCHECK(context);
LZ4F_freeCompressionContext(context->ctx);
-delete context;
}
-Status _acquire_decompression_ctx(DContext** out) {
+Status _acquire_decompression_ctx(std::shared_ptr& out) {
std::lock_guard l(_ctx_d_mutex);
if (_ctx_d_pool.empty()) {
-DContext* context = new (std::nothrow) DContext();
-if (context == nullptr) {
+std::shared_ptr localCtx = DContext::create_shared();
+if (localCtx.get() == nullptr) {
return Status::InvalidArgument("failed to new LZ4F DContext");
}
-auto res = LZ4F_createDecompressionContext(&context->ctx,
LZ4F_VERSION);
+auto res = LZ4F_createDecompressionContext(&localCtx->ctx,
LZ4F_VERSION);
if (LZ4F_isError(res) != 0) {
return Status::InvalidArgument(strings::Substitute(
"LZ4F_createDeompressionContext error, res=$0",
LZ4F_getErrorName(res)));
}
-*out = context;
+out = localCtx;
return Status::OK();
}
-*out = _ctx_d_pool.back();
+out = _ctx_d_pool.back();
_ctx_d_pool.pop_back();
return Status::OK();
}
-void _release_decompression_ctx(DContext* context) {
+void _release_decompression_ctx(std::shared_ptr context) {
DCHECK(context);
// reset decompression context to avoid ERROR_maxBlockSize_invalid
LZ4F_resetDecompressionContext(context->ctx);
std::lock_guard l(_ctx_d_mutex);
_ctx_d_pool.push_back(context);
}
-void _delete_decompression_ctx(DContext* context) {
+void _delete_decompression_ctx(std::shared_ptr context) {
DCHECK(context);
LZ4F_freeDecompressionContext(context->ctx);
Review Comment:
And also should check ctx != null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](nereids) add session var to turn on/off common sub expressoin extraction [doris]
englefly commented on PR #33617: URL: https://github.com/apache/doris/pull/33617#issuecomment-2053989002 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] 更新模型中 array 类型的字段 ，当给这个字段建立倒排索引，整个数据库直接崩溃了，现在数据库启动不了了 [doris]
amorynan commented on issue #32802: URL: https://github.com/apache/doris/issues/32802#issuecomment-2053995901 目前array 所以创建倒排索引还有点问题， 没有正式发布这个功能的 等内部调试完成 会随着版本发布 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](pred) Support xor function [doris]
Mryange opened a new pull request, #33634: URL: https://github.com/apache/doris/pull/33634 ## Proposed changes ``` mysql [test]>select true xor false,true xor true; +--+-+ | (TRUE XOR FALSE) | (TRUE XOR TRUE) | +--+-+ |1 | 0 | +--+-+ ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pred) Support xor function [doris]
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2053999486 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pred) Support xor function [doris]
Mryange commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2053999513 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pred) Support xor function [doris]
github-actions[bot] commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054000809 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](function) support hll functions hll_from_base64, hll_to_base64 [doris]
github-actions[bot] commented on PR #32089: URL: https://github.com/apache/doris/pull/32089#issuecomment-2054006226 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) support aggregate function group_array_intersect [doris]
github-actions[bot] commented on PR #33265: URL: https://github.com/apache/doris/pull/33265#issuecomment-2054006711 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pred) Support xor function [doris]
doris-robot commented on PR #33634: URL: https://github.com/apache/doris/pull/33634#issuecomment-2054008308 TeamCity be ut coverage result: Function Coverage: 35.58% (8904/25023) Line Coverage: 27.31% (73121/267754) Region Coverage: 26.44% (37814/143032) Branch Coverage: 23.19% (19266/83074) Coverage Report: http://coverage.selectdb-in.cc/coverage/6af7024091bb0dfebd05c124eb2587aec483eabd_6af7024091bb0dfebd05c124eb2587aec483eabd/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] support string column not overflow in join merge [doris]
HappenLee commented on PR #33584: URL: https://github.com/apache/doris/pull/33584#issuecomment-2054012021 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](pred) Support xor function [doris]
HappenLee commented on code in PR #33634:
URL: https://github.com/apache/doris/pull/33634#discussion_r1564634000
##
be/src/vec/functions/functions_logical.h:
##
@@ -94,6 +94,18 @@ struct OrImpl {
static inline constexpr bool special_implementation_for_nulls() { return
true; }
};
+struct XorImpl {
+using ResultType = UInt8;
+
+static inline constexpr ResultType apply(UInt8 a, UInt8 b) { return a ^ b;
}
+// select null xor true , null xor false , false xor null , true xor null
;
+// nullnull null null
+static inline constexpr ResultType apply_null(UInt8 a, UInt8 l_null, UInt8
b, UInt8 r_null) {
+return l_null or r_null;
+}
+static inline constexpr bool special_implementation_for_nulls() { return
true; }
Review Comment:
maybe should be `false` and not need impl the `apply_null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](join) convert block to nullable after do evaluate probe expr [doris]
HappenLee commented on PR #33607: URL: https://github.com/apache/doris/pull/33607#issuecomment-2054013280 Add regression test ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] support string column not overflow in join merge [doris]
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1564634773
##
be/src/vec/columns/column_map.cpp:
##
@@ -407,6 +407,42 @@ void ColumnMap::insert_range_from(const IColumn& src,
size_t start, size_t lengt
}
}
+void ColumnMap::insert_range_from_ignore_overflow(const IColumn& src, size_t
start, size_t length) {
Review Comment:
warning: method 'insert_range_from_ignore_overflow' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_map.h:104:
```diff
- void insert_range_from_ignore_overflow(const IColumn& src, size_t
start,
+ static void insert_range_from_ignore_overflow(const IColumn& src,
size_t start,
```
##
be/src/vec/columns/column_string.cpp:
##
@@ -308,6 +357,16 @@
return max_size + sizeof(uint32_t);
}
+size_t ColumnLargeStringForJoin::get_max_row_byte_size() const {
Review Comment:
warning: method 'get_max_row_byte_size' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_string.h:606:
```diff
- size_t get_max_row_byte_size() const override;
+ static size_t get_max_row_byte_size() override;
```
```suggestion
size_t ColumnLargeStringForJoin::get_max_row_byte_size() {
```
##
be/src/vec/columns/column_array.cpp:
##
@@ -514,6 +514,40 @@ void ColumnArray::insert_range_from(const IColumn& src,
size_t start, size_t len
}
}
+void ColumnArray::insert_range_from_ignore_overflow(const IColumn& src, size_t
start,
+size_t length) {
+const ColumnArray& src_concrete = assert_cast(src);
+
+if (start + length > src_concrete.get_offsets().size()) {
+throw doris::Exception(doris::ErrorCode::INTERNAL_ERROR,
+ "Parameter out of bound in
ColumnArray::insert_range_from method. "
+ "[start({}) + length({}) > offsets.size({})]",
+ std::to_string(start), std::to_string(length),
+
std::to_string(src_concrete.get_offsets().size()));
+}
+
+size_t nested_offset = src_concrete.offset_at(start);
+size_t nested_length = src_concrete.get_offsets()[start + length - 1] -
nested_offset;
+
+get_data().insert_range_from_ignore_overflow(src_concrete.get_data(),
nested_offset,
+ nested_length);
+
+auto& cur_offsets = get_offsets();
+const auto& src_offsets = src_concrete.get_offsets();
+
+if (start == 0 && cur_offsets.empty()) {
+cur_offsets.assign(src_offsets.begin(), src_offsets.begin() + length);
+} else {
+size_t old_size = cur_offsets.size();
+// -1 is ok, because PaddedPODArray pads zeros on the left.
+size_t prev_max_offset = cur_offsets.back();
+cur_offsets.resize(old_size + length);
+
+for (size_t i = 0; i < length; ++i)
+cur_offsets[old_size + i] = src_offsets[start + i] - nested_offset
+ prev_max_offset;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
for (size_t i = 0; i < length; ++i) {
cur_offsets[old_size + i] = src_offsets[start + i] -
nested_offset + prev_max_offset;
}
```
##
be/src/vec/columns/column_string.cpp:
##
@@ -284,6 +319,20 @@
return res;
}
+StringRef ColumnLargeStringForJoin::serialize_value_into_arena(size_t n,
Arena& arena,
Review Comment:
warning: method 'serialize_value_into_arena' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_string.h:601:
```diff
- StringRef serialize_value_into_arena(size_t n, Arena& arena, char
const*& begin) const override;
+ static StringRef serialize_value_into_arena(size_t n, Arena& arena,
char const*& begin) override;
```
be/src/vec/columns/column_string.cpp:322:
```diff
-char
const*& begin) const {
+char
const*& begin) {
```
##
be/src/vec/columns/column_struct.cpp:
##
@@ -251,6 +251,15 @@ void ColumnStruct::insert_range_from(const IColumn& src,
size_t start, size_t le
}
}
+void ColumnStruct::insert_range_from_ignore_overflow(const IColumn& src,
size_t start,
Review Comment:
warning: method 'insert_range_from_ignore_overflow' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:143:
```diff
- void insert_range_from_ignore_overflow(const IColumn& src, size_t
start,
+ static void insert_range_from_ignore_overflow(const IColumn& src,
size_t start,
```
##
be
Re: [PR] [testcases](auto-partition) fix data sync [doris]
doris-robot commented on PR #33635: URL: https://github.com/apache/doris/pull/33635#issuecomment-2054014596 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [testcases](auto-partition) fix data sync [doris]
zclllyybb commented on PR #33635: URL: https://github.com/apache/doris/pull/33635#issuecomment-2054014628 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [testcases](auto-partition) fix data sync [doris]
zclllyybb opened a new pull request, #33635: URL: https://github.com/apache/doris/pull/33635 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (planner) support auto aggregation for random distributed table on legacy planner [doris]
DarvenDuan commented on PR #33630: URL: https://github.com/apache/doris/pull/33630#issuecomment-2054015774 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
zclllyybb commented on code in PR #33243:
URL: https://github.com/apache/doris/pull/33243#discussion_r1564640053
##
be/src/vec/functions/function_string.h:
##
@@ -3914,4 +3914,138 @@ class FunctionIntToChar : public IFunction {
#endif
}
};
+
+class FunctionStrInsert : public IFunction {
+public:
+static constexpr auto name = "str_insert";
+static FunctionPtr create() { return
std::make_shared(); }
+String get_name() const override { return name; }
+size_t get_number_of_arguments() const override { return 4; }
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+return std::make_shared();
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) const override
{
+DCHECK_EQ(arguments.size(), 4);
+
+bool col_const[4];
+ColumnPtr argument_columns[4];
+for (int i = 0; i < 4; ++i) {
+std::tie(argument_columns[i], col_const[i]) =
+
unpack_if_const(block.get_by_position(arguments[i]).column);
+}
+const auto* col_origin = assert_cast(argument_columns[0].get());
+
+const auto* col_pos = assert_cast*>(argument_columns[1].get())
+ ->get_data()
+ .data();
+const auto* col_len = assert_cast*>(argument_columns[2].get())
+ ->get_data()
+ .data();
+const auto* col_insert = assert_cast(argument_columns[3].get());
+
+ColumnString::MutablePtr col_res = ColumnString::create();
+
+if (col_const[1] && col_const[2] && col_const[3]) {
+vector_const(col_origin, col_pos, col_len, col_insert, col_res,
col_const[0],
+ input_rows_count);
+} else if (col_const[1]) {
Review Comment:
col1 is const is not a high probability or something to keep an eye on.
don't support this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]
xinyiZzz commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2054020462 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](memory) Allocator support address sanitizers [doris]
github-actions[bot] commented on PR #33396: URL: https://github.com/apache/doris/pull/33396#issuecomment-2054021898 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](iceberg) add iceberg transaction implement [doris]
wuwenchi commented on PR #33629: URL: https://github.com/apache/doris/pull/33629#issuecomment-2054024845 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] support string column not overflow in join merge [doris]
doris-robot commented on PR #33584: URL: https://github.com/apache/doris/pull/33584#issuecomment-2054033710 TPC-H: Total hot run time: 38693 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 307030fe4ee9d2c195f7e0cd18c49e805c098e92, data reload: false -- Round 1 -- q1 17611 448243024302 q2 2016189 187 187 q3 10439 123111931193 q4 10200 813 721 721 q5 7545272726762676 q6 213 130 129 129 q7 1003605 573 573 q8 9203207520402040 q9 7903658365686568 q10 8584354635233523 q11 475 235 234 234 q12 473 221 217 217 q13 18484 291529972915 q14 268 232 231 231 q15 513 474 483 474 q16 504 378 382 378 q17 972 658 691 658 q18 7320678367486748 q19 5067155415021502 q20 689 320 310 310 q21 3583282328782823 q22 367 308 291 291 Total cold run time: 113432 ms Total hot run time: 38693 ms - Round 2, with runtime_filter_mode=off - q1 4362419542994195 q2 364 260 259 259 q3 3009277527722772 q4 1906160815771577 q5 5389540053015301 q6 210 124 124 124 q7 2291185519091855 q8 3194332433553324 q9 8699856486408564 q10 4005394040303940 q11 627 496 512 496 q12 773 642 663 642 q13 16056 329831053105 q14 323 300 280 280 q15 505 470 481 470 q16 510 436 453 436 q17 1834158915441544 q18 8138822179257925 q19 1645151115271511 q20 2012182718551827 q21 5100493049194919 q22 550 482 469 469 Total cold run time: 71502 ms Total hot run time: 55535 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] support string column not overflow in join merge [doris]
doris-robot commented on PR #33584: URL: https://github.com/apache/doris/pull/33584#issuecomment-2054038135 TPC-DS: Total hot run time: 183457 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 307030fe4ee9d2c195f7e0cd18c49e805c098e92, data reload: false query1 869 1122354 354 query2 7818255023672367 query3 6650205 204 204 query4 36974 21627 21549 21549 query5 4135394 385 385 query6 234 183 171 171 query7 4056283 292 283 query8 218 167 175 167 query9 5705228922672267 query10 373 232 238 232 query11 14600 14178 14326 14178 query12 141 89 88 88 query13 995 363 359 359 query14 9151710368536853 query15 209 180 181 180 query16 6906263 257 257 query17 1746591 579 579 query18 1615271 273 271 query19 191 143 149 143 query20 92 84 92 84 query21 204 129 125 125 query22 4962478248544782 query23 33669 33096 33221 33096 query24 11404 308229862986 query25 538 402 379 379 query26 1336153 153 153 query27 3219373 364 364 query28 7146209221242092 query29 862 629 606 606 query30 280 169 178 169 query31 960 723 745 723 query32 62 52 53 52 query33 596 248 245 245 query34 904 509 495 495 query35 843 727 704 704 query36 1009952 944 944 query37 109 68 75 68 query38 3663361735383538 query39 1615159115571557 query40 181 133 130 130 query41 48 44 45 44 query42 102 101 100 100 query43 605 564 552 552 query44 1290760 723 723 query45 287 285 254 254 query46 1082754 740 740 query47 2041199819721972 query48 377 297 303 297 query49 900 380 380 380 query50 782 401 422 401 query51 6948673367586733 query52 104 88 90 88 query53 344 275 274 274 query54 251 231 215 215 query55 78 69 70 69 query56 235 212 218 212 query57 1190117311381138 query58 215 204 202 202 query59 3382328731423142 query60 245 265 225 225 query61 91 87 99 87 query62 591 435 442 435 query63 300 286 274 274 query64 4180384138573841 query65 3080303330493033 query66 722 315 329 315 query67 15363 15194 14869 14869 query68 4671530 527 527 query69 513 300 295 295 query70 1184113611661136 query71 386 281 276 276 query72 6394275725812581 query73 718 319 319 319 query74 6681635864396358 query75 3035237622892289 query76 3040110610821082 query77 629 244 256 244 query78 10839 10063 10206 10063 query79 7332524 521 521 query80 1945430 430 430 query81 545 246 232 232 query82 162198 98 98 query83 331 174 173 173 query84 273 84 86 84 query85 1503316 305 305 query86 461 302 321 302 query87 3792353635363536 query88 6051229623172296 query89 490 376 375 375 query90 1857177 179 177 query91 129 105 104 104 query92 60 47 50 47 query93 5914498 500 498 query94 1136186 190 186 query95 384 294 294 294 query96 610 264 265 264 query97 2700249924902490 query98 238 223 218 218 query99 1271884 863 863 Total cold run time: 297806 ms Total hot run time: 183457 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] support string column not overflow in join merge [doris]
doris-robot commented on PR #33584: URL: https://github.com/apache/doris/pull/33584#issuecomment-2054042524 ClickBench: Total hot run time: 30.13 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 307030fe4ee9d2c195f7e0cd18c49e805c098e92, data reload: false query1 0.040.030.03 query2 0.080.030.04 query3 0.230.060.04 query4 1.670.080.07 query5 0.500.490.50 query6 1.480.660.66 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.500.48 query10 0.550.560.54 query11 0.160.120.11 query12 0.140.120.12 query13 0.590.590.58 query14 0.770.760.77 query15 0.820.800.80 query16 0.360.380.36 query17 0.940.980.94 query18 0.210.250.22 query19 1.791.681.69 query20 0.020.010.01 query21 15.42 0.650.64 query22 4.207.291.93 query23 18.32 1.381.24 query24 1.960.210.22 query25 0.150.090.08 query26 0.250.160.15 query27 0.080.090.08 query28 13.36 0.990.97 query29 12.59 3.253.28 query30 0.260.060.05 query31 2.850.380.37 query32 3.310.470.46 query33 2.852.832.88 query34 17.10 4.404.41 query35 4.504.504.45 query36 0.640.470.46 query37 0.170.160.15 query38 0.160.140.14 query39 0.050.040.03 query40 0.170.150.14 query41 0.090.060.05 query42 0.060.050.04 query43 0.040.040.04 Total cold run time: 109.55 s Total hot run time: 30.13 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
koarz commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054043811 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] support string column not overflow in join merge [doris]
doris-robot commented on PR #33584: URL: https://github.com/apache/doris/pull/33584#issuecomment-2054045166 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 307030fe4ee9d2c195f7e0cd18c49e805c098e92 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 14.1 seconds inserted 1000 Rows, about 709K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](runtime-filter) registe consumer rf in local when rf is broadcast [doris]
BiteThet opened a new pull request, #33636: URL: https://github.com/apache/doris/pull/33636 ## Proposed changes registe consumer rf in local when rf is broadcast ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](runtime-filter) registe consumer rf in local when rf is broadcast [doris]
doris-robot commented on PR #33636: URL: https://github.com/apache/doris/pull/33636#issuecomment-2054052292 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](runtime-filter) registe consumer rf in local when rf is broadcast [doris]
BiteThet commented on PR #33636: URL: https://github.com/apache/doris/pull/33636#issuecomment-2054052516 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](runtime-filter) registe consumer rf in local when rf is broadcast [doris]
github-actions[bot] commented on PR #33636: URL: https://github.com/apache/doris/pull/33636#issuecomment-2054054785 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
doris-robot commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054057472 TPC-H: Total hot run time: 38828 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit b949adacc5a52a4244ec281dc95f164c864301f2, data reload: false -- Round 1 -- q1 17648 475544274427 q2 2897198 193 193 q3 11666 116412391164 q4 10423 782 735 735 q5 7591279026832683 q6 226 138 132 132 q7 1027627 618 618 q8 9340210720982098 q9 8136667665466546 q10 8482353035563530 q11 465 240 235 235 q12 497 220 216 216 q13 18802 294929092909 q14 277 229 232 229 q15 522 489 466 466 q16 507 382 378 378 q17 959 627 656 627 q18 7424685768016801 q19 6147155615321532 q20 699 335 307 307 q21 3470270328682703 q22 367 299 310 299 Total cold run time: 117572 ms Total hot run time: 38828 ms - Round 2, with runtime_filter_mode=off - q1 4406424042524240 q2 369 271 278 271 q3 3004270827612708 q4 1843157315591559 q5 5281535453205320 q6 210 121 121 121 q7 2257185818911858 q8 3225346033543354 q9 8633856285558555 q10 3924369636953695 q11 596 482 492 482 q12 759 593 594 593 q13 17617 295028872887 q14 296 267 271 267 q15 513 471 477 471 q16 491 408 420 408 q17 1773148714481448 q18 7645752774627462 q19 1639156115411541 q20 1945176317461746 q21 4955493048824882 q22 530 431 492 431 Total cold run time: 71911 ms Total hot run time: 54299 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](runtime-filter) registe consumer rf in local when rf is broadcast [doris]
doris-robot commented on PR #33636: URL: https://github.com/apache/doris/pull/33636#issuecomment-2054058840 TeamCity be ut coverage result: Function Coverage: 35.59% (8905/25020) Line Coverage: 27.32% (73148/267748) Region Coverage: 26.45% (37833/143029) Branch Coverage: 23.21% (19277/83072) Coverage Report: http://coverage.selectdb-in.cc/coverage/4bf5e14299741f42ca4e9a77685a2a0c01e99af0_4bf5e14299741f42ca4e9a77685a2a0c01e99af0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
doris-robot commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054059459 TeamCity be ut coverage result: Function Coverage: 35.60% (8909/25028) Line Coverage: 27.32% (73176/267837) Region Coverage: 26.45% (37835/143067) Branch Coverage: 23.21% (19282/83094) Coverage Report: http://coverage.selectdb-in.cc/coverage/b949adacc5a52a4244ec281dc95f164c864301f2_b949adacc5a52a4244ec281dc95f164c864301f2/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](test) fix some unstable p2 test cases [doris]
morningman opened a new pull request, #33637: URL: https://github.com/apache/doris/pull/33637 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](test) fix some unstable p2 test cases [doris]
doris-robot commented on PR #33637: URL: https://github.com/apache/doris/pull/33637#issuecomment-2054060573 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](test) fix some unstable p2 test cases [doris]
morningman commented on PR #33637: URL: https://github.com/apache/doris/pull/33637#issuecomment-2054060587 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
doris-robot commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054060633 TPC-DS: Total hot run time: 183447 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit b949adacc5a52a4244ec281dc95f164c864301f2, data reload: false query1 887 113011341130 query2 7711256323072307 query3 6654209 211 209 query4 37330 21889 21893 21889 query5 4170400 400 400 query6 238 178 178 178 query7 4049290 288 288 query8 219 170 172 170 query9 5708230623022302 query10 544 250 246 246 query11 14669 14442 14196 14196 query12 149 93 91 91 query13 1000370 359 359 query14 10089 684067116711 query15 220 185 181 181 query16 6729269 259 259 query17 1658600 560 560 query18 1375284 286 284 query19 206 160 157 157 query20 100 91 89 89 query21 199 130 136 130 query22 4981485547554755 query23 33611 33168 32836 32836 query24 12281 295230082952 query25 576 396 392 392 query26 1670153 152 152 query27 3134316 311 311 query28 7205202520192019 query29 878 632 621 621 query30 314 168 163 163 query31 896 703 731 703 query32 60 115 53 53 query33 587 243 237 237 query34 875 469 477 469 query35 838 669 697 669 query36 1035918 906 906 query37 221 69 71 69 query38 3585345234193419 query39 1690159415231523 query40 269 133 130 130 query41 47 46 45 45 query42 112 98 100 98 query43 582 555 527 527 query44 1403704 708 704 query45 277 282 264 264 query46 1067700 740 700 query47 1931185118571851 query48 354 294 289 289 query49 1114383 362 362 query50 758 378 374 374 query51 6868661565566556 query52 103 94 94 94 query53 355 280 275 275 query54 251 232 219 219 query55 74 72 71 71 query56 241 227 220 220 query57 1238112710961096 query58 246 199 202 199 query59 3396333631003100 query60 253 234 243 234 query61 95 94 95 94 query62 642 459 438 438 query63 308 282 279 279 query64 5135406939513951 query65 3151305130683051 query66 1381332 317 317 query67 15403 15188 14944 14944 query68 7162549 526 526 query69 527 311 304 304 query70 1276118810921092 query71 496 270 271 270 query72 6616260824832483 query73 827 313 313 313 query74 6837636364936363 query75 3215235023112311 query76 4255113510361036 query77 671 244 245 244 query78 10974 10308 10252 10252 query79 3820531 533 531 query80 2225434 415 415 query81 550 228 228 228 query82 138594 99 94 query83 356 176 174 174 query84 262 84 87 84 query85 1616274 315 274 query86 471 320 312 312 query87 3702353335353533 query88 5730226623672266 query89 474 369 376 369 query90 1928185 177 177 query91 125 101 98 98 query92 60 46 49 46 query93 5093515 508 508 query94 1262183 178 178 query95 386 296 301 296 query96 607 264 261 261 query97 2712249724792479 query98 246 230 212 212 query99 1256851 878 851 Total cold run time: 302517 ms Total hot run time: 183447 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th
Re: [PR] [Enhancement](function) Support insert function [doris]
doris-robot commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054062117 ClickBench: Total hot run time: 30.67 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit b949adacc5a52a4244ec281dc95f164c864301f2, data reload: false query1 0.040.030.03 query2 0.070.040.04 query3 0.230.050.04 query4 1.680.070.07 query5 0.480.480.48 query6 1.470.650.64 query7 0.020.020.01 query8 0.040.040.04 query9 0.560.490.49 query10 0.550.560.55 query11 0.160.120.12 query12 0.150.120.12 query13 0.590.590.59 query14 0.770.770.78 query15 0.820.810.80 query16 0.360.380.35 query17 0.951.020.99 query18 0.230.220.26 query19 1.771.741.71 query20 0.010.020.01 query21 15.41 0.650.64 query22 4.426.882.24 query23 18.36 1.351.24 query24 1.740.240.23 query25 0.150.080.07 query26 0.270.160.16 query27 0.080.090.08 query28 13.37 1.000.98 query29 12.60 3.393.44 query30 0.260.070.06 query31 2.850.380.37 query32 3.290.470.46 query33 2.872.812.88 query34 17.23 4.394.40 query35 4.434.444.48 query36 0.660.470.46 query37 0.170.160.15 query38 0.150.150.14 query39 0.040.040.03 query40 0.170.140.14 query41 0.100.040.04 query42 0.060.050.05 query43 0.040.030.04 Total cold run time: 109.67 s Total hot run time: 30.67 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](function) Support insert function [doris]
doris-robot commented on PR #33243: URL: https://github.com/apache/doris/pull/33243#issuecomment-2054062867 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit b949adacc5a52a4244ec281dc95f164c864301f2 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 13.5 seconds inserted 1000 Rows, about 740K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.1 updated: remove is cloud mode
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 00e082f3c41 remove is cloud mode
00e082f3c41 is described below
commit 00e082f3c4191c27505df5b73323f05b50bb90e5
Author: yiguolei
AuthorDate: Sun Apr 14 21:40:51 2024 +0800
remove is cloud mode
---
regression-test/suites/schema_change_p2/test_schema_change_fail.groovy | 3 ---
1 file changed, 3 deletions(-)
diff --git
a/regression-test/suites/schema_change_p2/test_schema_change_fail.groovy
b/regression-test/suites/schema_change_p2/test_schema_change_fail.groovy
index f7ec1b42f0c..134002f6c05 100644
--- a/regression-test/suites/schema_change_p2/test_schema_change_fail.groovy
+++ b/regression-test/suites/schema_change_p2/test_schema_change_fail.groovy
@@ -19,9 +19,6 @@ import org.apache.doris.regression.util.DebugPoint
import org.apache.doris.regression.util.NodeType
suite('test_schema_change_fail', 'nonConcurrent') {
-if (isCloudMode()) {
-return
-}
def frontends = sql_return_maparray('show frontends')
def backends = sql_return_maparray('show backends')
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [testcases](auto-partition) fix data sync [doris]
github-actions[bot] commented on PR #33635: URL: https://github.com/apache/doris/pull/33635#issuecomment-2054066742 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [testcases](auto-partition) fix data sync [doris]
github-actions[bot] commented on PR #33635: URL: https://github.com/apache/doris/pull/33635#issuecomment-2054066752 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
