Re: [PR] [fix](invert index) Fix the issue of high memory usage. [doris]
github-actions[bot] commented on PR #31739: URL: https://github.com/apache/doris/pull/31739#issuecomment-2016394618 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
zhiqiang- commented on code in PR #32518:
URL: https://github.com/apache/doris/pull/32518#discussion_r1536588367
##
be/src/vec/data_types/data_type_decimal.h:
##
@@ -655,6 +656,10 @@ void convert_to_decimal(typename ToDataType::FieldType*
dst,
for (size_t i = 0; i < size; ++i) {
dst[i].value = FromFieldType(src[i] * multiplier.value + ((src[i]
>= 0) ? 0.5 : -0.5));
}
+} else if constexpr (IsDateV2Type) {
+for (size_t i = 0; i < size; ++i) {
+dst[i].value = reinterpret_cast&>(src[i]).to_int64();
Review Comment:
1. maybe `assert_cast&>` is better
2. why convert result to int64? what if target Decimal is Decimal32 or
Decimal128?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](pointer cast) better typeid_cast [doris]
zhiqiang- commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536591316
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (typeid(from) == typeid(To)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
+To typeid_cast(From& from) noexcept(false) {
+if ((typeid(From) == typeid(To)) || (typeid(from) == typeid(To))) return
static_cast(from);
throw doris::Exception(doris::ErrorCode::BAD_CAST,
"Bad cast from type " +
demangle(typeid(from).name()) + " to " +
demangle(typeid(To).name()));
}
template
-To typeid_cast(From* from) {
-#ifndef NDEBUG
-try {
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
-#else
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
+requires std::is_pointer_v
+To typeid_cast(From* from) noexcept {
+if ((typeid(From) == typeid(std::remove_pointer_t)) ||
+(from && typeid(*from) == typeid(std::remove_pointer_t)))
return static_cast(from);
Review Comment:
> maybe we could always throw exception, not return nullptr.
https://github.com/apache/doris/blob/2c017399fbd109bb96ae09373f8dc46d8306e8a7/be/src/vec/columns/column_array.cpp#L513
the users of `typeid_cast` sometimes relay on the nullptr as their control
flow, exception has bad performance when it is used as control flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](pointer cast) better typeid_cast [doris]
zhiqiang- commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536591881
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (typeid(from) == typeid(To)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
+To typeid_cast(From& from) noexcept(false) {
+if ((typeid(From) == typeid(To)) || (typeid(from) == typeid(To))) return
static_cast(from);
throw doris::Exception(doris::ErrorCode::BAD_CAST,
"Bad cast from type " +
demangle(typeid(from).name()) + " to " +
demangle(typeid(To).name()));
}
template
-To typeid_cast(From* from) {
-#ifndef NDEBUG
-try {
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
-#else
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
+requires std::is_pointer_v
+To typeid_cast(From* from) noexcept {
Review Comment:
I dont know whether `typeid_cast(nullptr)` is designed as a common use
scenario
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] Reason: column(__DORIS_DELETE_SIGN__) values is null while columns is not nullable. [doris]
JasonLeeCoding commented on issue #30843: URL: https://github.com/apache/doris/issues/30843#issuecomment-2016413736 I think we should set the sink.enable-delete parameter to false by default -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] 创建表的时候表注释异常 [doris]
SummerShow opened a new issue, #32723: URL: https://github.com/apache/doris/issues/32723 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version v2.1.0 ### What's Wrong? 建表时，指定表注释后，表描述中（DDL）显示为 COMMENT 'OLAP' ### What You Expected? 显示为自己定义的表注释-COMMENT '企业信息表' ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] 创建表的时候表注释异常 [doris]
SummerShow opened a new issue, #32724: URL: https://github.com/apache/doris/issues/32724 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version v2.1.0 ### What's Wrong? 建表时，指定表注释后，表描述中（DDL）显示为 COMMENT 'OLAP' ### What You Expected? 显示为自己定义的表注释-COMMENT '企业信息表' ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](pipeline) FragmentMgr may return OK when some instance prepare failed [doris]
zhiqiang- closed pull request #29353: [fix](pipeline) FragmentMgr may return OK when some instance prepare failed URL: https://github.com/apache/doris/pull/29353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Num element [doris]
doris-robot commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016476154 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Num element [doris]
wyxxxcat opened a new pull request, #32725: URL: https://github.com/apache/doris/pull/32725 ## Proposed changes Issue Number: #31892 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Num element [doris]
github-actions[bot] commented on code in PR #32725:
URL: https://github.com/apache/doris/pull/32725#discussion_r1536624762
##
be/src/olap/rowset/segment_v2/column_reader.cpp:
##
@@ -1061,10 +1061,10 @@ Status FileColumnIterator::seek_to_page_start() {
return seek_to_ordinal(_page.first_ordinal);
}
-void FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
+Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const {
Review Comment:
warning: method '_seek_to_pos_in_page' can be made static
[readability-convert-member-functions-to-static]
```suggestion
Status FileColumnIterator::_seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) {
```
be/src/olap/rowset/segment_v2/column_reader.h:369:
```diff
- Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) const;
+ static Status _seek_to_pos_in_page(ParsedPage* page, ordinal_t
offset_in_page) ;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug] Error occurred while passing status up [doris]
wyxxxcat commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016478581 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
Mryange commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016485184 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
wuwenchi opened a new pull request, #32726:
URL: https://github.com/apache/doris/pull/32726
## Proposed changes
Add `ExternalTransactionManager` and `Transaction`.
`ExternalTransactionManager` is used to manage all external transactions:
```
class ExternalTransactionManager {
...
Map transactions;
...
}
```
The application layer should manage the entire transaction through this
`ExternalTransactionManager`, like:
```
Env.getExternalTransactionManager().beginTransaction();
Env.getExternalTransactionManager().beginInsert();
Env.getExternalTransactionManager().finishInsert();
Env.getExternalTransactionManager().commit();
```
`Transaction` is an interface that unifies internal and external tables. It
currently implements external tables (`ExternalTransaction`) and will continue
to unify internal tables in the future.
For the `ExternalTransaction`, it mainly interacts with the external
metadata, so it will hold an `ExternalMetadataOps`.
Therefore, when the application layer calls a `Transaction` interface
through the `ExternalTransactionManager`, it will eventually be converted into
an operation on `ExternalMetadataOps`.
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016485540 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
Mryange commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016486923 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
Mryange commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016487565 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
Mryange commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016488015 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
Mryange opened a new pull request, #32727: URL: https://github.com/apache/doris/pull/32727 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016487551 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
github-actions[bot] commented on code in PR #32727:
URL: https://github.com/apache/doris/pull/32727#discussion_r1536630287
##
be/src/exec/exec_node.h:
##
@@ -220,6 +220,26 @@ class ExecNode {
return _output_row_descriptor ? *_output_row_descriptor :
_row_descriptor;
}
virtual const RowDescriptor& intermediate_row_desc() const { return
_row_descriptor; }
+
+// input expr -> intermediate_projections[0] ->
intermediate_projections[1] -> intermediate_projections[2]... -> final
projections -> output expr
+// prepare_row_descriptor intermediate_row_desc[0]
intermediate_row_desc[1]intermediate_row_desc.end()
_output_row_descriptor
+
+[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) {
Review Comment:
warning: method 'intermediate_row_desc' can be made const
[readability-make-member-function-const]
```suggestion
[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const {
```
##
be/src/pipeline/pipeline_x/operator.h:
##
@@ -247,6 +261,25 @@ class OperatorXBase : public OperatorBase {
return _row_descriptor;
}
+// input expr -> intermediate_projections[0] ->
intermediate_projections[1] -> intermediate_projections[2]... -> final
projections -> output expr
+// prepare_row_descriptor intermediate_row_desc[0]
intermediate_row_desc[1]intermediate_row_desc.end()
_output_row_descriptor
+
+[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) {
Review Comment:
warning: method 'intermediate_row_desc' can be made const
[readability-make-member-function-const]
```suggestion
[[nodiscard]] const RowDescriptor& intermediate_row_desc(int idx) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
doris-robot commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016491537 TeamCity be ut coverage result: Function Coverage: 35.25% (8731/24770) Line Coverage: 27.05% (71497/264327) Region Coverage: 26.29% (37100/141125) Branch Coverage: 23.18% (18967/81832) Coverage Report: http://coverage.selectdb-in.cc/coverage/3e771b3a126dc19faa56c7ff35a0929a4fa340f4_3e771b3a126dc19faa56c7ff35a0929a4fa340f4/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
wuwenchi commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016492971 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug] Error occurred while passing status up [doris]
doris-robot commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016493097 TeamCity be ut coverage result: Function Coverage: 35.26% (8733/24766) Line Coverage: 27.06% (71520/264298) Region Coverage: 26.30% (37109/141101) Branch Coverage: 23.19% (18977/81818) Coverage Report: http://coverage.selectdb-in.cc/coverage/031bf87ea9183edaceef5bb90ae004f6ed484775_031bf87ea9183edaceef5bb90ae004f6ed484775/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug] Error occurred while passing status up [doris]
doris-robot commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016494162 TPC-H: Total hot run time: 38037 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 031bf87ea9183edaceef5bb90ae004f6ed484775, data reload: false -- Round 1 -- q1 17632 422941014101 q2 2116159 170 159 q3 10575 121312051205 q4 10232 721 773 721 q5 7518298929632963 q6 207 124 122 122 q7 1017594 575 575 q8 9339201319991999 q9 7289658366216583 q10 8445348635593486 q11 442 231 222 222 q12 428 202 201 201 q13 17786 284328562843 q14 239 210 213 210 q15 523 463 459 459 q16 484 380 368 368 q17 961 531 626 531 q18 7186654864876487 q19 1907143414821434 q20 539 253 248 248 q21 3618296828202820 q22 340 300 311 300 Total cold run time: 108823 ms Total hot run time: 38037 ms - Round 2, with runtime_filter_mode=off - q1 4136405240464046 q2 320 229 236 229 q3 2975286428202820 q4 1890156315981563 q5 5292537353435343 q6 198 116 118 116 q7 2253186718751867 q8 3173327733143277 q9 8715870586868686 q10 3812384938013801 q11 540 446 451 446 q12 713 551 524 524 q13 16889 286128792861 q14 271 249 272 249 q15 495 458 459 458 q16 464 416 434 416 q17 1721152514831483 q18 7503709870827082 q19 1619149714621462 q20 1928172417371724 q21 4824459547444595 q22 525 458 435 435 Total cold run time: 70256 ms Total hot run time: 53483 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016494708 TeamCity be ut coverage result: Function Coverage: 35.26% (8733/24770) Line Coverage: 27.06% (71526/264327) Region Coverage: 26.30% (37111/141125) Branch Coverage: 23.20% (18981/81832) Coverage Report: http://coverage.selectdb-in.cc/coverage/77c7a35f1d54050166cb0c9cf0ba6278d9fa5107_77c7a35f1d54050166cb0c9cf0ba6278d9fa5107/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
doris-robot commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016495568 TPC-H: Total hot run time: 37727 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3e771b3a126dc19faa56c7ff35a0929a4fa340f4, data reload: false -- Round 1 -- q1 17628 421740904090 q2 2105157 151 151 q3 10581 117012051170 q4 10233 833 793 793 q5 7461297829582958 q6 203 124 120 120 q7 1029583 570 570 q8 9363199719531953 q9 7348663765496549 q10 8412347135703471 q11 434 221 210 210 q12 400 198 195 195 q13 17793 286628742866 q14 251 200 205 200 q15 501 464 456 456 q16 484 367 369 367 q17 950 525 594 525 q18 7153649863226322 q19 4892140814661408 q20 551 250 246 246 q21 3521291428162816 q22 335 302 291 291 Total cold run time: 111628 ms Total hot run time: 37727 ms - Round 2, with runtime_filter_mode=off - q1 4124409540754075 q2 327 234 229 229 q3 2943282828162816 q4 1835154515241524 q5 5288535153315331 q6 195 114 116 114 q7 2192187318401840 q8 3160328932563256 q9 8685867786538653 q10 3816378437693769 q11 536 434 438 434 q12 737 551 592 551 q13 16903 284828932848 q14 297 239 255 239 q15 493 447 452 447 q16 448 409 426 409 q17 1715148714701470 q18 7482722270767076 q19 1587148415461484 q20 1912171917001700 q21 4751461247384612 q22 509 445 459 445 Total cold run time: 69935 ms Total hot run time: 53322 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
xiedeyantu commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016496086 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug] Error occurred while passing status up [doris]
doris-robot commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016496999 TPC-DS: Total hot run time: 186557 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 031bf87ea9183edaceef5bb90ae004f6ed484775, data reload: false query1 936 366 362 362 query2 7402199918851885 query3 6710208 218 208 query4 31869 21191 21177 21177 query5 4425410 403 403 query6 278 175 179 175 query7 4626292 311 292 query8 234 171 174 171 query9 9185223722362236 query10 573 233 267 233 query11 17385 14419 14458 14419 query12 137 91 87 87 query13 1623420 412 412 query14 11756 11130 11221 11130 query15 268 210 203 203 query16 8164267 260 260 query17 1940583 565 565 query18 2132292 276 276 query19 295 157 151 151 query20 93 88 90 88 query21 203 131 124 124 query22 4984479548594795 query23 33645 32962 32816 32816 query24 10593 288228562856 query25 618 385 392 385 query26 1193159 162 159 query27 2483349 361 349 query28 7240188418411841 query29 887 662 628 628 query30 296 149 150 149 query31 966 737 731 731 query32 100 59 62 59 query33 780 263 260 260 query34 1062476 477 476 query35 820 615 612 612 query36 994 851 896 851 query37 123 77 77 77 query38 3583345433893389 query39 1474144714081408 query40 212 115 113 113 query41 51 47 48 47 query42 106 98 97 97 query43 481 460 455 455 query44 1141717 717 717 query45 286 257 265 257 query46 1117719 697 697 query47 1936184818711848 query48 443 364 347 347 query49 1134349 354 349 query50 764 366 369 366 query51 6784657065896570 query52 110 95 94 94 query53 342 274 275 274 query54 320 253 250 250 query55 88 81 80 80 query56 253 241 240 240 query57 1239115811561156 query58 238 212 216 212 query59 2855259625352535 query60 278 258 263 258 query61 119 116 119 116 query62 647 457 461 457 query63 304 277 287 277 query64 5813403839753975 query65 3087302430233023 query66 853 352 377 352 query67 15334 14992 15132 14992 query68 6823509 505 505 query69 610 374 361 361 query70 1258117011341134 query71 477 272 280 272 query72 6997273725472547 query73 719 304 305 304 query74 7242667666876676 query75 3960284628172817 query76 4480883 892 883 query77 623 262 261 261 query78 11025 10204 10052 10052 query79 10101 517 512 512 query80 1925391 374 374 query81 528 214 213 213 query82 877 197 200 197 query83 222 148 140 140 query84 287 77 78 77 query85 1476326 311 311 query86 481 286 291 286 query87 3726351336213513 query88 4972228322772277 query89 502 382 369 369 query90 2012177 177 177 query91 171 139 141 139 query92 57 49 48 48 query93 7364499 485 485 query94 1241180 177 177 query95 435 343 333 333 query96 603 266 271 266 query97 3097286529102865 query98 232 213 209 209 query99 1166925 966 925 Total cold run time: 314099 ms Total hot run time: 186557 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016497281 TPC-H: Total hot run time: 38056 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 77c7a35f1d54050166cb0c9cf0ba6278d9fa5107, data reload: false -- Round 1 -- q1 17656 427540394039 q2 2108156 148 148 q3 10584 109011691090 q4 10234 821 782 782 q5 7465300429992999 q6 203 122 122 122 q7 1028605 578 578 q8 9353202819601960 q9 7253667066376637 q10 8488349535903495 q11 1144218 222 218 q12 400 200 192 192 q13 18025 288028952880 q14 245 215 207 207 q15 507 470 461 461 q16 491 384 373 373 q17 951 642 562 562 q18 7218649566796495 q19 1949140614411406 q20 536 265 262 262 q21 3612283630162836 q22 366 314 322 314 Total cold run time: 109816 ms Total hot run time: 38056 ms - Round 2, with runtime_filter_mode=off - q1 4182420942244209 q2 341 237 241 237 q3 3095300929062906 q4 1865158815461546 q5 5337538753515351 q6 196 118 120 118 q7 2297185018261826 q8 3157330132593259 q9 8631864887258648 q10 3769374637803746 q11 552 451 434 434 q12 729 571 563 563 q13 16929 287328702870 q14 274 249 257 249 q15 491 464 446 446 q16 468 406 412 406 q17 1709146614601460 q18 7500725970277027 q19 2879153614901490 q20 1884172817251725 q21 4815461146444611 q22 530 444 433 433 Total cold run time: 71630 ms Total hot run time: 53560 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
github-actions[bot] commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016497385 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug] Error occurred while passing status up [doris]
doris-robot commented on PR #32725: URL: https://github.com/apache/doris/pull/32725#issuecomment-2016497917 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 031bf87ea9183edaceef5bb90ae004f6ed484775 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 22.0 seconds inserted 1000 Rows, about 454K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix load timeout caused by lost wakeup [doris]
github-actions[bot] commented on PR #32720: URL: https://github.com/apache/doris/pull/32720#issuecomment-2016497984 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
doris-robot commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016498769 TPC-DS: Total hot run time: 186464 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3e771b3a126dc19faa56c7ff35a0929a4fa340f4, data reload: false query1 927 375 366 366 query2 7351197919741974 query3 6709209 217 209 query4 32360 21192 21339 21192 query5 4410413 410 410 query6 267 190 189 189 query7 4633294 295 294 query8 232 168 170 168 query9 8966230722882288 query10 550 242 270 242 query11 17340 14311 14302 14302 query12 139 88 90 88 query13 1638449 429 429 query14 11777 11123 11280 11123 query15 261 206 202 202 query16 8069261 266 261 query17 1944579 552 552 query18 1993293 284 284 query19 217 159 161 159 query20 96 88 90 88 query21 207 134 128 128 query22 5022481148454811 query23 34131 32738 33001 32738 query24 10749 289028712871 query25 614 387 390 387 query26 1187162 166 162 query27 2602354 357 354 query28 7223192719331927 query29 883 673 626 626 query30 297 151 149 149 query31 972 747 753 747 query32 89 61 58 58 query33 783 267 265 265 query34 1033486 505 486 query35 823 618 625 618 query36 1021897 920 897 query37 130 80 76 76 query38 3514344234413441 query39 1473146813971397 query40 216 119 117 117 query41 51 53 47 47 query42 106 98 100 98 query43 492 444 458 444 query44 1217741 744 741 query45 275 262 269 262 query46 1128724 721 721 query47 1941184418551844 query48 453 370 351 351 query49 1144336 345 336 query50 760 378 379 378 query51 6749655866396558 query52 106 100 90 90 query53 383 284 283 283 query54 322 255 265 255 query55 94 83 84 83 query56 254 246 259 246 query57 1216115111271127 query58 242 211 225 211 query59 2827249625422496 query60 290 265 269 265 query61 116 117 119 117 query62 653 454 456 454 query63 313 289 297 289 query64 5833408838353835 query65 3068302430163016 query66 872 364 358 358 query67 15064 14766 14942 14766 query68 6971539 552 539 query69 621 382 378 378 query70 1207114511211121 query71 512 285 288 285 query72 6428274225322532 query73 724 309 317 309 query74 6956672265546554 query75 4024284928132813 query76 4972955 935 935 query77 656 260 266 260 query78 10850 10090 10053 10053 query79 8288535 524 524 query80 1561394 396 394 query81 520 210 209 209 query82 844 200 207 200 query83 213 154 145 145 query84 281 83 81 81 query85 1470318 318 318 query86 422 291 268 268 query87 3743355534973497 query88 4775231122802280 query89 501 380 388 380 query90 2024180 177 177 query91 176 134 139 134 query92 61 49 51 49 query93 6471514 502 502 query94 1099180 176 176 query95 434 330 343 330 query96 607 267 272 267 query97 3048288628902886 query98 234 213 210 210 query99 1200912 942 912 Total cold run time: 310710 ms Total hot run time: 186464 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
doris-robot commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016499609 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 3e771b3a126dc19faa56c7ff35a0929a4fa340f4 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.2 seconds inserted 1000 Rows, about 471K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016500270 TPC-DS: Total hot run time: 186286 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 77c7a35f1d54050166cb0c9cf0ba6278d9fa5107, data reload: false query1 929 372 357 357 query2 7348201518701870 query3 6723211 213 211 query4 31602 21187 21276 21187 query5 4282408 406 406 query6 273 176 182 176 query7 4633287 279 279 query8 222 171 179 171 query9 9336226322402240 query10 556 251 244 244 query11 17386 14290 14434 14290 query12 139 91 84 84 query13 1640424 408 408 query14 13105 11489 11094 11094 query15 310 193 188 188 query16 8248250 247 247 query17 2163553 528 528 query18 2087281 274 274 query19 345 153 160 153 query20 91 87 84 84 query21 201 132 124 124 query22 5032488149024881 query23 33810 33140 33070 33070 query24 10272 283328722833 query25 578 383 388 383 query26 716 159 160 159 query27 2187344 359 344 query28 5856187918681868 query29 884 645 626 626 query30 303 146 149 146 query31 962 731 736 731 query32 90 57 56 56 query33 674 351 275 275 query34 887 483 482 482 query35 809 602 608 602 query36 1036905 897 897 query37 108 82 78 78 query38 3509343634003400 query39 1515147114311431 query40 212 118 109 109 query41 51 46 46 46 query42 108 103 96 96 query43 481 446 450 446 query44 1074714 714 714 query45 283 256 261 256 query46 1129692 697 692 query47 1924187018301830 query48 434 362 353 353 query49 1067350 340 340 query50 770 364 370 364 query51 6620670765956595 query52 105 91 86 86 query53 346 279 277 277 query54 320 243 248 243 query55 87 84 80 80 query56 253 239 229 229 query57 1201113611521136 query58 243 210 211 210 query59 2814254525302530 query60 269 246 257 246 query61 114 113 112 112 query62 657 470 461 461 query63 304 276 278 276 query64 5388404140814041 query65 3038304530363036 query66 958 381 368 368 query67 15472 14918 14661 14661 query68 6823511 524 511 query69 617 376 374 374 query70 1248110911431109 query71 514 288 273 273 query72 6405269225422542 query73 737 319 308 308 query74 8108663765896589 query75 4051282927852785 query76 4974842 875 842 query77 652 271 265 265 query78 11055 10093 10197 10093 query79 10579 515 529 515 query80 1934386 383 383 query81 525 213 218 213 query82 850 205 188 188 query83 219 149 140 140 query84 290 84 78 78 query85 1374319 309 309 query86 477 317 284 284 query87 3698353035223522 query88 5205229322862286 query89 522 388 390 388 query90 1947178 180 178 query91 166 134 138 134 query92 64 51 49 49 query93 7256503 488 488 query94 1248179 172 172 query95 445 330 330 330 query96 610 265 267 265 query97 3053286228812862 query98 244 232 212 212 query99 1200895 889 889 Total cold run time: 313659 ms Total hot run time: 186286 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016501034 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 77c7a35f1d54050166cb0c9cf0ba6278d9fa5107 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.7 seconds inserted 1000 Rows, about 460K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016501761 TPC-H: Total hot run time: 37903 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 39bdca9703de4011e352d324748ac39e78a033ba, data reload: false -- Round 1 -- q1 17640 418341164116 q2 2116175 153 153 q3 10568 112912011129 q4 10218 761 797 761 q5 7463301729712971 q6 206 127 125 125 q7 1049593 575 575 q8 9350200619911991 q9 7173662465666566 q10 8408344635343446 q11 439 236 230 230 q12 427 198 198 198 q13 17794 285528372837 q14 228 208 201 201 q15 516 471 470 470 q16 524 383 376 376 q17 952 636 582 582 q18 7128642563666366 q19 2361139014691390 q20 536 253 248 248 q21 3570287028902870 q22 351 305 302 302 Total cold run time: 109017 ms Total hot run time: 37903 ms - Round 2, with runtime_filter_mode=off - q1 4192406841074068 q2 329 238 234 234 q3 2989284627982798 q4 1844155315631553 q5 5301534953305330 q6 195 119 121 119 q7 2226185218351835 q8 3171332532893289 q9 8694867787468677 q10 3769376337633763 q11 542 445 439 439 q12 741 581 551 551 q13 16900 284629022846 q14 276 251 268 251 q15 495 444 466 444 q16 476 436 434 434 q17 1776149014741474 q18 7477719370797079 q19 1626157415341534 q20 1904172517431725 q21 4849469946234623 q22 537 450 468 450 Total cold run time: 70309 ms Total hot run time: 53516 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
doris-robot commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016502795 TeamCity be ut coverage result: Function Coverage: 35.26% (8734/24767) Line Coverage: 27.06% (71515/264306) Region Coverage: 26.30% (37103/141100) Branch Coverage: 23.19% (18973/81818) Coverage Report: http://coverage.selectdb-in.cc/coverage/fcc79fc3b0dd966cdcb79c727147cc8889e601a3_fcc79fc3b0dd966cdcb79c727147cc8889e601a3/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
xiedeyantu commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016502659 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
github-actions[bot] commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016503804 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016504765 TPC-DS: Total hot run time: 186440 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 39bdca9703de4011e352d324748ac39e78a033ba, data reload: false query1 932 361 364 361 query2 7538199920351999 query3 6703214 209 209 query4 31751 21216 21308 21216 query5 4322425 415 415 query6 279 182 186 182 query7 4630304 291 291 query8 232 187 191 187 query9 9475227122512251 query10 559 255 257 255 query11 15633 14571 14430 14430 query12 140 93 91 91 query13 1628410 416 410 query14 14360 10695 11636 10695 query15 266 207 197 197 query16 8220256 257 256 query17 1985579 545 545 query18 2095287 275 275 query19 353 162 156 156 query20 99 86 90 86 query21 199 131 127 127 query22 4961475747674757 query23 33484 32358 32755 32358 query24 10778 289128582858 query25 611 395 401 395 query26 966 162 162 162 query27 2345348 351 348 query28 6755188318431843 query29 887 679 643 643 query30 301 158 154 154 query31 976 766 737 737 query32 94 63 58 58 query33 785 257 274 257 query34 1023505 509 505 query35 847 628 624 624 query36 1046918 898 898 query37 114 79 79 79 query38 3599353334503450 query39 1479145514011401 query40 219 122 116 116 query41 52 50 48 48 query42 111 99 97 97 query43 508 450 466 450 query44 1167740 718 718 query45 276 258 269 258 query46 1135741 731 731 query47 1880184318231823 query48 456 358 352 352 query49 1104344 346 344 query50 773 380 386 380 query51 6781665867356658 query52 117 91 99 91 query53 351 280 286 280 query54 326 248 258 248 query55 85 83 81 81 query56 259 242 231 231 query57 1213111711371117 query58 242 215 215 215 query59 2922262926132613 query60 291 330 261 261 query61 131 112 113 112 query62 673 465 471 465 query63 324 288 287 287 query64 5635407740204020 query65 3119302530363025 query66 873 396 376 376 query67 15357 14770 14919 14770 query68 6892519 530 519 query69 634 402 395 395 query70 1273121511541154 query71 529 289 289 289 query72 6957271825552555 query73 746 319 327 319 query74 8151659866586598 query75 4285300930533009 query76 4998926 948 926 query77 671 259 261 259 query78 11025 10147 10088 10088 query79 10096 535 538 535 query80 1674426 389 389 query81 552 223 217 217 query82 886 199 200 199 query83 228 156 144 144 query84 287 81 88 81 query85 1452324 319 319 query86 461 309 317 309 query87 3779355735363536 query88 5053228122852281 query89 515 389 378 378 query90 1952176 178 176 query91 166 132 139 132 query92 63 50 49 49 query93 7106504 491 491 query94 1245179 176 176 query95 439 327 337 327 query96 602 270 271 270 query97 3080291828632863 query98 251 215 216 215 query99 1191914 915 914 Total cold run time: 316069 ms Total hot run time: 186440 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016505538 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 39bdca9703de4011e352d324748ac39e78a033ba with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.1 seconds inserted 1000 Rows, about 473K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (Nereids) fix date function rewrite on datetimev1 column bug [doris]
yiguolei merged PR #32569: URL: https://github.com/apache/doris/pull/32569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] [INVALID_ARGUMENT]Create Expr failed because [E33] Invalid value: 2024-03-11 24:00:00 for type DateTime [doris]
yiguolei closed issue #32329: [Bug] [INVALID_ARGUMENT]Create Expr failed because [E33] Invalid value: 2024-03-11 24:00:00 for type DateTime URL: https://github.com/apache/doris/issues/32329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix] (Nereids) fix date function rewrite on datetimev1 column bug (#32569)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ba85b022128 [fix] (Nereids) fix date function rewrite on datetimev1
column bug (#32569)
ba85b022128 is described below
commit ba85b0221285c79bca499d591d63935ec1e2c6ba
Author: Ziyan Lee <49580493+ziyan...@users.noreply.github.com>
AuthorDate: Sat Mar 23 22:15:39 2024 +0800
[fix] (Nereids) fix date function rewrite on datetimev1 column bug (#32569)
---
.../trees/expressions/literal/DateLiteral.java | 4 +-
.../datetimev1/test_datetimev1_date_function.out | 32 ++
.../test_datetimev1_date_function.groovy | 124 +
3 files changed, 158 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java
index 7dcd86a1504..a33cc32c16f 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/DateLiteral.java
@@ -458,10 +458,10 @@ public class DateLiteral extends Literal {
/**
* 2020-01-01
*
- * @return 2020-01-01 24:00:00
+ * @return 2020-01-01 23:59:59
*/
public DateTimeLiteral toEndOfTheDay() {
-return new DateTimeLiteral(year, month, day, 24, 0, 0);
+return new DateTimeLiteral(year, month, day, 23, 59, 59);
}
/**
diff --git
a/regression-test/data/datatype_p0/datetimev1/test_datetimev1_date_function.out
b/regression-test/data/datatype_p0/datetimev1/test_datetimev1_date_function.out
new file mode 100644
index 000..81a89b2286f
--- /dev/null
+++
b/regression-test/data/datatype_p0/datetimev1/test_datetimev1_date_function.out
@@ -0,0 +1,32 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !date_function_test_datetimev1_gt --
+2020-01-06T21:02:03
+2020-01-07T09:29:39
+2020-01-08T11:33:55
+2020-01-09T14:43:42
+2020-01-10T23:59:59
+
+-- !date_function_test_datetimev1_gte --
+2020-01-05T17:58:59
+2020-01-06T21:02:03
+2020-01-07T09:29:39
+2020-01-08T11:33:55
+2020-01-09T14:43:42
+2020-01-10T23:59:59
+
+-- !date_function_test_datetimev1_lt --
+2020-01-01T19:29:39
+2020-01-02T18:28:38
+2020-01-03T23:37:47
+2020-01-04T21:42:43
+
+-- !date_function_test_datetimev1_lte --
+2020-01-01T19:29:39
+2020-01-02T18:28:38
+2020-01-03T23:37:47
+2020-01-04T21:42:43
+2020-01-05T17:58:59
+
+-- !date_function_test_datetimev1_eq --
+2020-01-05T17:58:59
+
diff --git
a/regression-test/suites/datatype_p0/datetimev1/test_datetimev1_date_function.groovy
b/regression-test/suites/datatype_p0/datetimev1/test_datetimev1_date_function.groovy
new file mode 100644
index 000..ec473a82027
--- /dev/null
+++
b/regression-test/suites/datatype_p0/datetimev1/test_datetimev1_date_function.groovy
@@ -0,0 +1,124 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_datetimev1_date_function", "nonConcurrent") {
+
+/// legacy date/datetime format need to run in non concurrent mode.
+sql """
+admin set frontend config("enable_date_conversion" = "false");
+"""
+
+def table_dup = "test_datetimev1_date_function_dup_tbl" // duplicate key
+
+sql "drop table if exists ${table_dup};"
+
+sql """
+CREATE TABLE IF NOT EXISTS `${table_dup}` (
+`date_key1` datetimev1 NULL COMMENT "",
+ ) ENGINE=OLAP
+ DUPLICATE KEY(`date_key1`)
+ COMMENT "OLAP"
+ DISTRIBUTED BY HASH(`date_key1`) BUCKETS 1
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "in_memory" = "false",
+ "storage_format" = "V2"
+)
+"""
+
+def insert_data = { table_name ->
+sql """
+insert into ${table_name}
+values
+('2020-01-01 19:29:39'),
+('2020-01-02 18:28:38'),
+('2
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
doris-robot commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016508279 TeamCity be ut coverage result: Function Coverage: 35.26% (8734/24767) Line Coverage: 27.06% (71524/264306) Region Coverage: 26.30% (37112/141100) Branch Coverage: 23.20% (18980/81818) Coverage Report: http://coverage.selectdb-in.cc/coverage/a0540bd55cda57bac573d77902973f187ed9fb2d_a0540bd55cda57bac573d77902973f187ed9fb2d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix load timeout caused by lost wakeup [doris]
github-actions[bot] commented on PR #32720: URL: https://github.com/apache/doris/pull/32720#issuecomment-2016508518 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
doris-robot commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016511370 TPC-H: Total hot run time: 37989 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit a0540bd55cda57bac573d77902973f187ed9fb2d, data reload: false -- Round 1 -- q1 17683 414340884088 q2 2111151 149 149 q3 10588 110011991100 q4 10229 803 741 741 q5 7449300530033003 q6 202 126 125 125 q7 1047588 566 566 q8 9331198720181987 q9 7205662965406540 q10 8466345935533459 q11 441 221 227 221 q12 445 203 199 199 q13 17798 284428682844 q14 234 209 217 209 q15 501 472 467 467 q16 510 382 371 371 q17 946 541 589 541 q18 7157647365976473 q19 2724147314051405 q20 554 280 258 258 q21 3610295729442944 q22 357 301 299 299 Total cold run time: 109588 ms Total hot run time: 37989 ms - Round 2, with runtime_filter_mode=off - q1 4159416141114111 q2 324 233 224 224 q3 3019290328762876 q4 1883162615751575 q5 5346537653835376 q6 197 117 120 117 q7 2279186918451845 q8 3184331133163311 q9 8795892089878920 q10 4010394139473941 q11 569 470 452 452 q12 760 596 609 596 q13 18368 296629182918 q14 284 263 261 261 q15 513 470 487 470 q16 514 462 418 418 q17 1738152114661466 q18 7694738770997099 q19 1656151215381512 q20 1895170417211704 q21 4705462647614626 q22 531 435 451 435 Total cold run time: 72423 ms Total hot run time: 54253 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](move-memtable) fix load timeout caused by lost wakeup [doris]
dataroaring merged PR #32720: URL: https://github.com/apache/doris/pull/32720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (ba85b022128 -> 93124693d5e)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ba85b022128 [fix] (Nereids) fix date function rewrite on datetimev1 column bug (#32569) add 93124693d5e [fix](move-memtable) fix load timeout caused by lost wakeup (#32720) No new revisions were added by this update. Summary of changes: be/src/vec/sink/load_stream_stub.cpp | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
wuwenchi commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016512128 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
doris-robot commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016514284 TPC-DS: Total hot run time: 186397 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit a0540bd55cda57bac573d77902973f187ed9fb2d, data reload: false query1 955 366 359 359 query2 7405204619971997 query3 6700210 216 210 query4 31751 21469 21359 21359 query5 4334427 430 427 query6 270 181 174 174 query7 4638295 307 295 query8 227 170 177 170 query9 9347225022582250 query10 561 249 260 249 query11 17569 14310 14650 14310 query12 137 93 90 90 query13 1632424 415 415 query14 12688 11248 11473 11248 query15 294 206 197 197 query16 8230259 259 259 query17 2114599 545 545 query18 2113316 285 285 query19 366 164 165 164 query20 98 86 90 86 query21 205 134 133 133 query22 4992473447384734 query23 33376 32589 32764 32589 query24 10582 291128302830 query25 584 368 377 368 query26 971 153 157 153 query27 2344354 346 346 query28 6341188718421842 query29 838 645 610 610 query30 303 146 144 144 query31 967 734 733 733 query32 91 57 59 57 query33 760 264 254 254 query34 1060475 483 475 query35 843 609 608 608 query36 1015858 874 858 query37 118 78 74 74 query38 3556344434463444 query39 1463143914231423 query40 208 113 111 111 query41 47 48 46 46 query42 100 98 96 96 query43 504 440 454 440 query44 1152731 723 723 query45 267 257 274 257 query46 1118726 704 704 query47 1916180918321809 query48 443 357 344 344 query49 1073335 343 335 query50 765 363 360 360 query51 6683658466906584 query52 113 92 86 86 query53 348 281 282 281 query54 322 246 249 246 query55 82 84 84 84 query56 260 243 245 243 query57 1208114211261126 query58 245 213 216 213 query59 2890267125912591 query60 274 249 272 249 query61 114 116 114 114 query62 670 428 464 428 query63 311 276 282 276 query64 5632415540404040 query65 3071305430393039 query66 883 383 376 376 query67 15235 14741 14576 14576 query68 6333506 526 506 query69 609 408 379 379 query70 1202115411121112 query71 488 290 281 281 query72 6721284325722572 query73 729 311 315 311 query74 8291667966436643 query75 3998287728912877 query76 4399866 875 866 query77 630 271 259 259 query78 11068 10169 10073 10073 query79 10054 517 524 517 query80 1651424 388 388 query81 534 222 212 212 query82 836 207 207 207 query83 213 151 148 148 query84 287 81 86 81 query85 1389320 321 320 query86 422 297 294 294 query87 3749356935313531 query88 4699227422612261 query89 524 374 371 371 query90 2031177 176 176 query91 175 135 138 135 query92 64 48 49 48 query93 6674500 487 487 query94 1217178 181 178 query95 426 335 329 329 query96 604 275 274 274 query97 3082289028802880 query98 233 215 211 211 query99 1198951 929 929 Total cold run time: 312302 ms Total hot run time: 186397 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](paimon) support paimon with hive2 [doris]
morningman commented on PR #32455: URL: https://github.com/apache/doris/pull/32455#issuecomment-2016514648 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](agg) add aggregate function sum0 [doris]
doris-robot commented on PR #32541: URL: https://github.com/apache/doris/pull/32541#issuecomment-2016515048 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit a0540bd55cda57bac573d77902973f187ed9fb2d with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 21.6 seconds inserted 1000 Rows, about 462K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) support paimon with hive2 [doris]
doris-robot commented on PR #32455: URL: https://github.com/apache/doris/pull/32455#issuecomment-2016519447 TeamCity be ut coverage result: Function Coverage: 35.26% (8733/24766) Line Coverage: 27.06% (71510/264296) Region Coverage: 26.29% (37095/141096) Branch Coverage: 23.19% (18975/81816) Coverage Report: http://coverage.selectdb-in.cc/coverage/d620c4162ec1e3c3f79f916e5a52307eee09c003_d620c4162ec1e3c3f79f916e5a52307eee09c003/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) support paimon with hive2 [doris]
doris-robot commented on PR #32455: URL: https://github.com/apache/doris/pull/32455#issuecomment-2016519530 TPC-H: Total hot run time: 38379 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d620c4162ec1e3c3f79f916e5a52307eee09c003, data reload: false -- Round 1 -- q1 18332 457441794179 q2 2307159 160 159 q3 11593 115912221159 q4 10608 857 827 827 q5 8248309630533053 q6 209 129 125 125 q7 1081620 602 602 q8 10072 210220232023 q9 7332679765986598 q10 8435346635303466 q11 458 224 227 224 q12 373 203 200 200 q13 17795 285428422842 q14 244 205 201 201 q15 513 455 453 453 q16 491 372 376 372 q17 973 643 593 593 q18 7238648864206420 q19 1662137414491374 q20 552 259 272 259 q21 3541296229942962 q22 347 288 299 288 Total cold run time: 112404 ms Total hot run time: 38379 ms - Round 2, with runtime_filter_mode=off - q1 4204414341664143 q2 326 232 238 232 q3 2995285828312831 q4 1822154115301530 q5 5307550854785478 q6 193 116 117 116 q7 2234184618811846 q8 3155330333083303 q9 8699875887528752 q10 3840382838003800 q11 545 453 446 446 q12 737 577 536 536 q13 16928 289129012891 q14 275 245 261 245 q15 501 457 452 452 q16 483 419 425 419 q17 1739149314571457 q18 7503714971597149 q19 1627157215161516 q20 1925173617101710 q21 4833472446354635 q22 536 448 436 436 Total cold run time: 70407 ms Total hot run time: 53923 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016521291 TPC-H: Total hot run time: 37634 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d315e6ad58db534b41219b85f815f7757a97ad1c, data reload: false -- Round 1 -- q1 17643 423340774077 q2 2116158 164 158 q3 10571 109211531092 q4 10221 778 778 778 q5 7449296929242924 q6 201 122 126 122 q7 1024594 572 572 q8 9326198919541954 q9 7216661865206520 q10 8476345035973450 q11 437 228 220 220 q12 409 198 192 192 q13 17797 280928312809 q14 235 202 203 202 q15 504 462 467 462 q16 498 366 373 366 q17 941 633 577 577 q18 7053642664686426 q19 2786141014111410 q20 561 254 244 244 q21 3524279129922791 q22 329 288 292 288 Total cold run time: 109317 ms Total hot run time: 37634 ms - Round 2, with runtime_filter_mode=off - q1 4119404940084008 q2 323 231 223 223 q3 2949281028612810 q4 1833155715621557 q5 5278533653215321 q6 191 115 116 115 q7 2215182118601821 q8 3128328532653265 q9 8713867286898672 q10 3770381637443744 q11 548 443 437 437 q12 723 560 533 533 q13 16890 281628392816 q14 274 262 256 256 q15 499 458 456 456 q16 461 424 428 424 q17 1719146914621462 q18 7514723171517151 q19 2413151615401516 q20 1905171516911691 q21 4775472845794579 q22 509 449 443 443 Total cold run time: 70749 ms Total hot run time: 53300 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](paimon) support paimon with hive2 [doris]
doris-robot commented on PR #32455: URL: https://github.com/apache/doris/pull/32455#issuecomment-2016522683 TPC-DS: Total hot run time: 186922 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d620c4162ec1e3c3f79f916e5a52307eee09c003, data reload: false query1 944 372 360 360 query2 7477198220161982 query3 6703220 216 216 query4 32045 21366 21351 21351 query5 4333505 408 408 query6 268 175 175 175 query7 4635297 289 289 query8 235 175 171 171 query9 9285229022962290 query10 577 256 261 256 query11 17384 14337 14474 14337 query12 139 97 87 87 query13 1631432 410 410 query14 14523 11733 11402 11402 query15 274 211 193 193 query16 8234261 263 261 query17 1965579 527 527 query18 2098282 262 262 query19 339 148 152 148 query20 91 89 83 83 query21 199 135 137 135 query22 4985478948254789 query23 33603 32882 32402 32402 query24 10755 291228752875 query25 594 370 368 368 query26 1215153 158 153 query27 2784340 351 340 query28 7620187518191819 query29 875 662 637 637 query30 310 150 149 149 query31 1011743 723 723 query32 98 58 61 58 query33 772 255 271 255 query34 1004474 487 474 query35 838 617 621 617 query36 1037873 890 873 query37 124 76 81 76 query38 3606347234653465 query39 1441143714011401 query40 210 119 115 115 query41 51 49 47 47 query42 106 94 97 94 query43 495 449 453 449 query44 1108722 725 722 query45 280 267 269 267 query46 1126706 682 682 query47 1908184218571842 query48 444 345 352 345 query49 1099357 346 346 query50 771 369 370 369 query51 6785659566236595 query52 110 97 91 91 query53 354 282 280 280 query54 315 245 248 245 query55 88 84 88 84 query56 265 234 235 234 query57 1186112711351127 query58 248 212 225 212 query59 2759267124982498 query60 271 257 260 257 query61 113 111 114 111 query62 652 470 454 454 query63 314 287 281 281 query64 5755405640414041 query65 3098302330233023 query66 887 374 378 374 query67 15305 15168 14977 14977 query68 7041537 513 513 query69 621 408 394 394 query70 1249120211321132 query71 522 293 311 293 query72 6532268725572557 query73 720 321 309 309 query74 8546668166766676 query75 4106289628822882 query76 5042899 885 885 query77 641 269 259 259 query78 10977 10298 10079 10079 query79 11483 527 519 519 query80 1883416 410 410 query81 528 210 217 210 query82 836 213 198 198 query83 225 153 146 146 query84 285 76 86 76 query85 1487322 342 322 query86 421 297 304 297 query87 3810356335103510 query88 5237227422852274 query89 504 370 374 370 query90 2032179 175 175 query91 168 136 136 136 query92 61 48 47 47 query93 7250502 481 481 query94 1187184 179 179 query95 433 331 329 329 query96 605 270 269 269 query97 3031289829332898 query98 233 218 204 204 query99 1242938 914 914 Total cold run time: 321092 ms Total hot run time: 186922 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix](paimon) support paimon with hive2 [doris]
doris-robot commented on PR #32455: URL: https://github.com/apache/doris/pull/32455#issuecomment-2016523485 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d620c4162ec1e3c3f79f916e5a52307eee09c003 with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 20.4 seconds inserted 1000 Rows, about 490K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016524298 TPC-DS: Total hot run time: 186123 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d315e6ad58db534b41219b85f815f7757a97ad1c, data reload: false query1 942 353 345 345 query2 7429198119391939 query3 6702216 222 216 query4 31883 21186 21563 21186 query5 4379398 395 395 query6 269 180 168 168 query7 4627300 294 294 query8 230 170 173 170 query9 8877226422402240 query10 571 250 257 250 query11 14930 14511 14430 14430 query12 134 92 88 88 query13 1626433 416 416 query14 12425 10859 10982 10859 query15 273 208 191 191 query16 8004254 249 249 query17 1969559 516 516 query18 2027293 276 276 query19 237 148 155 148 query20 92 89 86 86 query21 209 130 130 130 query22 5046486348204820 query23 33341 32576 32991 32576 query24 10767 287028452845 query25 629 390 385 385 query26 1225165 163 163 query27 2602355 353 353 query28 7214187818221822 query29 918 654 635 635 query30 302 150 149 149 query31 976 779 731 731 query32 97 62 65 62 query33 766 341 339 339 query34 953 487 492 487 query35 846 637 601 601 query36 985 868 897 868 query37 129 77 80 77 query38 3575346734143414 query39 1472143214091409 query40 209 119 114 114 query41 50 47 48 47 query42 102 92 94 92 query43 479 457 435 435 query44 1276704 723 704 query45 290 271 260 260 query46 1106694 712 694 query47 1976184318541843 query48 439 360 353 353 query49 1128341 348 341 query50 763 375 375 375 query51 6665658766766587 query52 108 99 87 87 query53 343 281 279 279 query54 318 247 246 246 query55 89 82 81 81 query56 243 238 235 235 query57 1210113811321132 query58 237 219 212 212 query59 2750258526672585 query60 277 259 259 259 query61 119 113 113 113 query62 661 456 441 441 query63 326 284 278 278 query64 5695414940354035 query65 3112306130403040 query66 881 386 376 376 query67 15243 14815 15150 14815 query68 7241515 533 515 query69 619 380 379 379 query70 1268121611731173 query71 528 289 290 289 query72 6382269325622562 query73 714 320 321 320 query74 7128665866346634 query75 4052289628502850 query76 5087895 880 880 query77 668 263 265 263 query78 10960 998710184 9987 query79 8639518 527 518 query80 1673402 370 370 query81 537 216 218 216 query82 871 204 201 201 query83 219 157 148 148 query84 286 75 77 75 query85 1452328 307 307 query86 445 275 296 275 query87 3741352135383521 query88 4841227222902272 query89 501 371 359 359 query90 2015170 172 170 query91 165 131 136 131 query92 62 49 49 49 query93 6540493 487 487 query94 1099177 173 173 query95 422 329 324 324 query96 603 267 274 267 query97 3079288928892889 query98 230 215 205 205 query99 1227942 927 927 Total cold run time: 309067 ms Total hot run time: 186123 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [improvement](spill) DataQueue should not occupy too much memory [doris]
yiguolei commented on code in PR #32717:
URL: https://github.com/apache/doris/pull/32717#discussion_r1536649552
##
be/src/pipeline/exec/data_queue.cpp:
##
@@ -146,6 +151,10 @@ void
DataQueue::push_block(std::unique_ptr block, int child_i
if (_source_dependency) {
set_source_ready();
}
+
+if (_spill_dependencies[child_idx]) {
Review Comment:
我们不应当修改data queue的结构，dataqueue 是一个核心的数据结构，他只应该负责queue的逻辑。设想一下，假如我们的data
queue 是使用的第三方的实现怎么办？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)support `ExternalTransaction` for writing exteral table. [doris]
doris-robot commented on PR #32726: URL: https://github.com/apache/doris/pull/32726#issuecomment-2016525085 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d315e6ad58db534b41219b85f815f7757a97ad1c with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.9 seconds inserted 1000 Rows, about 456K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
github-actions[bot] commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530603 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
github-actions[bot] commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530740 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
AcKing-Sam commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016530928 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Enhancement] fix duplicated properties is not reported [doris]
xiedeyantu opened a new pull request, #32729: URL: https://github.com/apache/doris/pull/32729 ## Proposed changes Issue Number: close #32577 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016537821 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
xiedeyantu commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016540601 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
doris-robot commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016547961 TeamCity be ut coverage result: Function Coverage: 35.26% (8733/24766) Line Coverage: 27.05% (71508/264307) Region Coverage: 26.29% (37101/141096) Branch Coverage: 23.19% (18971/81816) Coverage Report: http://coverage.selectdb-in.cc/coverage/d29cb284fd6f4258f182d0319f06763c3fb80baf_d29cb284fd6f4258f182d0319f06763c3fb80baf/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
doris-robot commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016548901 TPC-H: Total hot run time: 38236 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d29cb284fd6f4258f182d0319f06763c3fb80baf, data reload: false -- Round 1 -- q1 17628 460441954195 q2 2109161 158 158 q3 10596 118612221186 q4 10229 806 802 802 q5 7471298430072984 q6 200 125 123 123 q7 1062597 576 576 q8 9348203419841984 q9 7231665866426642 q10 8445350935903509 q11 439 224 219 219 q12 401 197 194 194 q13 17795 283728622837 q14 238 201 219 201 q15 504 477 459 459 q16 509 370 373 370 q17 969 563 616 563 q18 7243653664776477 q19 3900140514291405 q20 540 255 247 247 q21 3547281529932815 q22 348 301 290 290 Total cold run time: 110752 ms Total hot run time: 38236 ms - Round 2, with runtime_filter_mode=off - q1 4123406340734063 q2 330 234 229 229 q3 2967281428662814 q4 1867159915591559 q5 5310537853365336 q6 202 116 118 116 q7 2256185418441844 q8 3173330333053303 q9 8728872587168716 q10 3785382637843784 q11 545 446 450 446 q12 725 528 541 528 q13 16892 288128392839 q14 284 253 254 253 q15 495 461 457 457 q16 474 425 436 425 q17 1736152814751475 q18 7509725071877187 q19 1681154015261526 q20 1920174517111711 q21 4801468347574683 q22 535 444 458 444 Total cold run time: 70338 ms Total hot run time: 53738 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016549559 TPC-H: Total hot run time: 38244 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2d094789f16c09f15b4684ab7cd92d7998c9ca0b, data reload: false -- Round 1 -- q1 19365 428441724172 q2 2109164 152 152 q3 10574 116312221163 q4 10317 730 809 730 q5 9099306929892989 q6 210 127 124 124 q7 1061623 576 576 q8 9706223520372037 q9 9356672266896689 q10 8568350335823503 q11 433 234 226 226 q12 440 196 191 191 q13 17961 290728852885 q14 236 201 201 201 q15 500 456 447 447 q16 492 375 376 375 q17 949 549 612 549 q18 7009644964216421 q19 3514144313891389 q20 567 255 243 243 q21 3669292728952895 q22 350 287 291 287 Total cold run time: 116485 ms Total hot run time: 38244 ms - Round 2, with runtime_filter_mode=off - q1 4211407340964073 q2 329 226 226 226 q3 2930282128072807 q4 1845156215411541 q5 5274533253165316 q6 194 115 117 115 q7 2229190118611861 q8 3160328333043283 q9 8745866186618661 q10 3772378337903783 q11 567 452 461 452 q12 727 564 543 543 q13 16944 286728382838 q14 280 251 246 246 q15 491 453 455 453 q16 463 425 418 418 q17 1746148514491449 q18 7460716770577057 q19 1609156915211521 q20 1903174217271727 q21 4797469145564556 q22 551 433 424 424 Total cold run time: 70227 ms Total hot run time: 53350 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](pointer cast) better typeid_cast [doris]
zclllyybb commented on code in PR #32614:
URL: https://github.com/apache/doris/pull/32614#discussion_r1536663881
##
be/src/vec/common/typeid_cast.h:
##
@@ -43,34 +43,20 @@
*/
template
requires std::is_reference_v
-To typeid_cast(From& from) {
-try {
-if (typeid(from) == typeid(To)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
+To typeid_cast(From& from) noexcept(false) {
+if ((typeid(From) == typeid(To)) || (typeid(from) == typeid(To))) return
static_cast(from);
throw doris::Exception(doris::ErrorCode::BAD_CAST,
"Bad cast from type " +
demangle(typeid(from).name()) + " to " +
demangle(typeid(To).name()));
}
template
-To typeid_cast(From* from) {
-#ifndef NDEBUG
-try {
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
-return static_cast(from);
-}
-} catch (const std::exception& e) {
-throw doris::Exception(doris::ErrorCode::BAD_CAST, e.what());
-}
-#else
-if (typeid(*from) == typeid(std::remove_pointer_t)) {
+requires std::is_pointer_v
+To typeid_cast(From* from) noexcept {
+if ((typeid(From) == typeid(std::remove_pointer_t)) ||
+(from && typeid(*from) == typeid(std::remove_pointer_t)))
return static_cast(from);
Review Comment:
不是的，我们抛异常是在入参为空指针的时候才会抛。以前的行为，如果typeid不同，就是返回空指针。因为现在这个新写法应该不会带来更多的风险，应该是靠谱的。空指针的话肯定是代码有错才会出，这种情况下前、后的使用肯定会出问题，不必在这里处理成异常的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
doris-robot commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016551923 TPC-DS: Total hot run time: 186876 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d29cb284fd6f4258f182d0319f06763c3fb80baf, data reload: false query1 928 372 342 342 query2 7348208619261926 query3 6701210 218 210 query4 31841 21226 21246 21226 query5 4368407 396 396 query6 267 185 173 173 query7 4621296 298 296 query8 223 172 175 172 query9 9245228022602260 query10 558 261 252 252 query11 17395 14402 14313 14313 query12 144 92 84 84 query13 1641434 423 423 query14 12198 11342 11205 11205 query15 310 193 191 191 query16 8225263 253 253 query17 2004572 539 539 query18 2095277 287 277 query19 355 153 155 153 query20 96 86 86 86 query21 200 129 124 124 query22 5013490648024802 query23 33175 32622 32811 32622 query24 10658 292628892889 query25 589 384 388 384 query26 724 156 160 156 query27 2212364 352 352 query28 6089191519021902 query29 849 647 636 636 query30 310 151 150 150 query31 961 739 742 739 query32 98 59 58 58 query33 771 260 340 260 query34 970 476 490 476 query35 831 619 635 619 query36 1039880 896 880 query37 112 78 82 78 query38 3476347934323432 query39 1586146414471447 query40 208 118 113 113 query41 51 48 47 47 query42 103 96 93 93 query43 499 445 446 445 query44 1152758 749 749 query45 271 258 265 258 query46 1123702 702 702 query47 1919183118761831 query48 435 365 366 365 query49 1060334 337 334 query50 761 380 369 369 query51 6759669366056605 query52 117 93 89 89 query53 350 275 273 273 query54 321 253 246 246 query55 84 82 78 78 query56 245 242 245 242 query57 1201114811651148 query58 243 210 209 209 query59 2834252025262520 query60 268 255 274 255 query61 116 112 113 112 query62 642 473 453 453 query63 304 273 280 273 query64 5429408441014084 query65 3077303830423038 query66 876 386 374 374 query67 15491 14909 14801 14801 query68 6965518 526 518 query69 625 395 378 378 query70 1247113611401136 query71 524 273 286 273 query72 6372271225382538 query73 721 320 323 320 query74 8168670565786578 query75 4185304529502950 query76 4911881 951 881 query77 676 280 258 258 query78 10872 10259 10095 10095 query79 9919536 523 523 query80 1657400 404 400 query81 533 227 215 215 query82 878 203 209 203 query83 206 145 148 145 query84 286 77 78 77 query85 1355317 307 307 query86 465 316 287 287 query87 3749357335683568 query88 5128238623672367 query89 523 373 363 363 query90 1930176 177 176 query91 185 137 138 137 query92 62 47 47 47 query93 6766495 488 488 query94 1131179 174 174 query95 434 338 329 329 query96 608 274 275 274 query97 3055289628822882 query98 220 213 211 211 query99 1206908 889 889 Total cold run time: 311727 ms Total hot run time: 186876 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016552321 TPC-DS: Total hot run time: 186280 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2d094789f16c09f15b4684ab7cd92d7998c9ca0b, data reload: false query1 925 363 356 356 query2 7454211119241924 query3 6712215 207 207 query4 31996 21298 21335 21298 query5 4319493 388 388 query6 278 174 181 174 query7 4636282 282 282 query8 223 167 170 167 query9 9243225022382238 query10 561 245 256 245 query11 14815 14388 14461 14388 query12 143 87 86 86 query13 1655413 409 409 query14 11759 11473 10976 10976 query15 326 192 195 192 query16 8233263 272 263 query17 2113562 537 537 query18 2094277 282 277 query19 345 150 151 150 query20 90 88 86 86 query21 197 129 130 129 query22 5007478448034784 query23 33556 32684 32911 32684 query24 10556 282928862829 query25 592 364 361 361 query26 1200154 151 151 query27 2550340 354 340 query28 7000185118161816 query29 905 647 624 624 query30 317 156 160 156 query31 988 750 747 747 query32 89 60 55 55 query33 790 260 271 260 query34 1015469 489 469 query35 837 618 605 605 query36 1032892 892 892 query37 114 74 74 74 query38 3512342534283425 query39 1493142914151415 query40 206 114 111 111 query41 50 51 52 51 query42 109 96 95 95 query43 490 448 447 447 query44 1192709 722 709 query45 274 255 266 255 query46 1115686 691 686 query47 1934186018611860 query48 433 351 352 351 query49 1101350 334 334 query50 767 374 362 362 query51 6766663066636630 query52 111 95 93 93 query53 342 273 277 273 query54 308 247 244 244 query55 86 82 83 82 query56 265 233 232 232 query57 1199114311511143 query58 237 222 213 213 query59 2912272926142614 query60 274 248 250 248 query61 112 115 117 115 query62 656 457 453 453 query63 311 285 276 276 query64 5717410440444044 query65 3075301930403019 query66 912 372 372 372 query67 15458 14820 14922 14820 query68 5623511 522 511 query69 584 368 359 359 query70 1238109911761099 query71 460 289 281 281 query72 6619273425732573 query73 688 311 303 303 query74 7041670766206620 query75 3829284728272827 query76 3805825 843 825 query77 736 261 255 255 query78 10929 10162 10164 10162 query79 7941519 507 507 query80 1271399 381 381 query81 524 212 217 212 query82 896 211 211 211 query83 202 145 143 143 query84 287 78 83 78 query85 1502315 311 311 query86 469 304 313 304 query87 3725353334993499 query88 5163225622792256 query89 504 369 358 358 query90 2046172 176 172 query91 164 136 137 136 query92 66 46 50 46 query93 6237501 487 487 query94 1197172 176 172 query95 445 324 329 324 query96 607 278 268 268 query97 3049287829142878 query98 236 218 210 210 query99 1229937 921 921 Total cold run time: 305394 ms Total hot run time: 186280 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix] (vectorization) fix_cast_from_date_to_decimal [doris]
doris-robot commented on PR #32518: URL: https://github.com/apache/doris/pull/32518#issuecomment-2016552686 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d29cb284fd6f4258f182d0319f06763c3fb80baf with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s Insert into select: 19.8 seconds inserted 1000 Rows, about 505K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] debug mysqlload [doris]
dataroaring commented on PR #32716: URL: https://github.com/apache/doris/pull/32716#issuecomment-2016553909 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] debug mysqlload [doris]
github-actions[bot] commented on PR #32716: URL: https://github.com/apache/doris/pull/32716#issuecomment-2016555050 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] debug mysqlload [doris]
doris-robot commented on PR #32716: URL: https://github.com/apache/doris/pull/32716#issuecomment-2016558631 TPC-H: Total hot run time: 38146 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8bf5d8a6be069771f8eafaac23dd6a1da928f2ff, data reload: false -- Round 1 -- q1 17635 425141514151 q2 2110154 157 154 q3 10602 118212251182 q4 10230 762 726 726 q5 7451305830123012 q6 208 123 123 123 q7 1052586 576 576 q8 9344202220162016 q9 7213665665946594 q10 8427346935553469 q11 437 224 207 207 q12 374 208 196 196 q13 17793 283128292829 q14 246 202 211 202 q15 503 468 465 465 q16 496 376 372 372 q17 964 542 619 542 q18 7364662564356435 q19 2874145414031403 q20 535 259 256 256 q21 3609303429332933 q22 348 304 303 303 Total cold run time: 109815 ms Total hot run time: 38146 ms - Round 2, with runtime_filter_mode=off - q1 4111409941484099 q2 329 238 226 226 q3 2980284728712847 q4 1819157316341573 q5 5342534553525345 q6 206 114 119 114 q7 2244187818491849 q8 3163331132753275 q9 8723872687018701 q10 3842379637373737 q11 556 426 458 426 q12 711 576 548 548 q13 16922 289628722872 q14 275 248 258 248 q15 490 451 469 451 q16 479 410 416 410 q17 1743149714961496 q18 7596711371137113 q19 1626154715371537 q20 1930174817441744 q21 4850477348744773 q22 556 459 431 431 Total cold run time: 70493 ms Total hot run time: 53815 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] debug mysqlload [doris]
doris-robot commented on PR #32716: URL: https://github.com/apache/doris/pull/32716#issuecomment-2016560865 TeamCity be ut coverage result: Function Coverage: 35.25% (8731/24766) Line Coverage: 27.05% (71481/264298) Region Coverage: 26.28% (37087/141096) Branch Coverage: 23.18% (18964/81816) Coverage Report: http://coverage.selectdb-in.cc/coverage/8bf5d8a6be069771f8eafaac23dd6a1da928f2ff_8bf5d8a6be069771f8eafaac23dd6a1da928f2ff/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] debug mysqlload [doris]
doris-robot commented on PR #32716: URL: https://github.com/apache/doris/pull/32716#issuecomment-2016561527 TPC-DS: Total hot run time: 186456 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8bf5d8a6be069771f8eafaac23dd6a1da928f2ff, data reload: false query1 951 375 359 359 query2 7387205119651965 query3 6712215 216 215 query4 31635 21317 21228 21228 query5 4365418 478 418 query6 278 176 172 172 query7 4638284 289 284 query8 224 172 177 172 query9 9294227422422242 query10 563 244 250 244 query11 15541 14394 14517 14394 query12 135 93 90 90 query13 1624426 408 408 query14 14714 10394 11035 10394 query15 257 204 195 195 query16 8053255 262 255 query17 1981594 557 557 query18 1380289 293 289 query19 349 159 156 156 query20 99 86 93 86 query21 206 129 127 127 query22 5073482647754775 query23 33813 32970 32922 32922 query24 10789 289128632863 query25 605 388 402 388 query26 1355153 154 153 query27 2906359 347 347 query28 7361188318511851 query29 877 670 631 631 query30 297 152 151 151 query31 986 752 717 717 query32 89 58 57 57 query33 777 267 248 248 query34 1012483 488 483 query35 820 612 602 602 query36 1000858 912 858 query37 123 78 77 77 query38 3483344334383438 query39 1463144614021402 query40 204 112 109 109 query41 48 45 45 45 query42 104 95 94 94 query43 484 447 465 447 query44 1246729 704 704 query45 280 260 268 260 query46 1124722 702 702 query47 1927183618381836 query48 461 351 346 346 query49 1109332 340 332 query50 765 375 367 367 query51 6747660266116602 query52 115 87 94 87 query53 340 271 274 271 query54 302 247 233 233 query55 84 81 75 75 query56 240 224 227 224 query57 1205114111291129 query58 241 205 199 199 query59 2916255725992557 query60 268 237 232 232 query61 101 111 111 111 query62 660 437 441 437 query63 304 270 274 270 query64 5359405340074007 query65 3156302130313021 query66 1356389 376 376 query67 15276 14923 14975 14923 query68 5299517 522 517 query69 573 397 373 373 query70 1191117711581158 query71 410 292 282 282 query72 6509288326782678 query73 715 326 326 326 query74 7299673066846684 query75 3588295929072907 query76 3025953 917 917 query77 370 271 270 270 query78 10977 10188 10224 10188 query79 8964527 511 511 query80 1953409 415 409 query81 553 214 226 214 query82 1071206 206 206 query83 285 144 150 144 query84 287 79 81 79 query85 1951322 314 314 query86 481 302 260 260 query87 3722357135523552 query88 5265232422992299 query89 534 372 382 372 query90 1954179 176 176 query91 172 139 142 139 query92 64 49 46 46 query93 7207491 482 482 query94 1232175 176 175 query95 434 330 319 319 query96 612 273 270 270 query97 3073286329032863 query98 228 215 209 209 query99 1213908 908 908 Total cold run time: 310848 ms Total hot run time: 186456 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature][insert]add FE UT and support CTAS for external table [doris]
wsjz commented on PR #32525: URL: https://github.com/apache/doris/pull/32525#issuecomment-2016568668 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][insert]add FE UT and support CTAS for external table [doris]
wsjz commented on PR #32525: URL: https://github.com/apache/doris/pull/32525#issuecomment-2016569319 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
xiedeyantu commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016574910 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][insert]add FE UT and support CTAS for external table [doris]
doris-robot commented on PR #32525: URL: https://github.com/apache/doris/pull/32525#issuecomment-2016577078 TPC-H: Total hot run time: 37576 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit d4df2b9a1bfa699ae3b9d73da24a4c56a418cf12, data reload: false -- Round 1 -- q1 17665 423040494049 q2 2392156 153 153 q3 10590 109712101097 q4 10231 763 766 763 q5 7442297229402940 q6 196 120 118 118 q7 1039579 561 561 q8 9336196819701968 q9 7302657365566556 q10 9107342735103427 q11 420 230 216 216 q12 380 196 194 194 q13 17800 288829132888 q14 249 210 208 208 q15 506 467 460 460 q16 492 368 373 368 q17 926 537 605 537 q18 7123638962666266 q19 2598144714831447 q20 560 250 246 246 q21 3588291628142814 q22 349 307 300 300 Total cold run time: 110291 ms Total hot run time: 37576 ms - Round 2, with runtime_filter_mode=off - q1 4116410841044104 q2 328 232 234 232 q3 2970288728622862 q4 1800158015861580 q5 5307538854135388 q6 199 115 118 115 q7 2263184718741847 q8 3143330532883288 q9 8736863287268632 q10 4040394939373937 q11 567 463 465 463 q12 739 593 608 593 q13 17887 304029442944 q14 276 246 255 246 q15 497 465 466 465 q16 468 428 448 428 q17 1756152514521452 q18 7572730470247024 q19 1991142615031426 q20 1875171416931693 q21 4652473745704570 q22 545 438 444 438 Total cold run time: 71727 ms Total hot run time: 53727 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][insert]add FE UT and support CTAS for external table [doris]
doris-robot commented on PR #32525: URL: https://github.com/apache/doris/pull/32525#issuecomment-2016579839 TPC-DS: Total hot run time: 185626 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit d4df2b9a1bfa699ae3b9d73da24a4c56a418cf12, data reload: false query1 1041361 340 340 query2 7383198320211983 query3 6915207 216 207 query4 31768 21451 21251 21251 query5 4270399 405 399 query6 271 170 181 170 query7 4628291 287 287 query8 230 169 171 169 query9 9213225622432243 query10 550 244 241 241 query11 15593 14274 14427 14274 query12 142 90 85 85 query13 1624407 413 407 query14 12158 11178 10784 10784 query15 299 197 191 191 query16 8225251 254 251 query17 1989587 553 553 query18 2104283 288 283 query19 361 157 155 155 query20 91 88 88 88 query21 206 128 128 128 query22 5060481848954818 query23 33364 32781 32576 32576 query24 10200 290728762876 query25 568 385 385 385 query26 722 154 151 151 query27 2193342 354 342 query28 5763184218491842 query29 864 634 625 625 query30 309 147 149 147 query31 1001764 730 730 query32 94 59 56 56 query33 663 258 252 252 query34 860 468 481 468 query35 807 611 610 610 query36 1021903 878 878 query37 105 78 76 76 query38 3572344733813381 query39 1467147914261426 query40 221 113 111 111 query41 49 48 49 48 query42 102 95 93 93 query43 482 447 450 447 query44 1043705 703 703 query45 270 261 265 261 query46 1102685 695 685 query47 1948187218721872 query48 438 352 358 352 query49 1065347 379 347 query50 771 366 367 366 query51 6635661166896611 query52 112 88 93 88 query53 345 272 273 272 query54 324 248 253 248 query55 87 79 76 76 query56 250 230 241 230 query57 1226114211471142 query58 262 207 208 207 query59 2733250225512502 query60 278 244 262 244 query61 113 126 115 115 query62 661 443 443 443 query63 307 270 281 270 query64 4919409839883988 query65 3053298330192983 query66 888 360 353 353 query67 15266 14733 14672 14672 query68 8519515 531 515 query69 624 378 389 378 query70 1295118411881184 query71 518 283 272 272 query72 6358273325832583 query73 740 314 314 314 query74 7166664867176648 query75 4440285028302830 query76 5301873 900 873 query77 668 262 258 258 query78 10996 10147 10046 10046 query79 10021 519 512 512 query80 1666392 374 374 query81 517 216 208 208 query82 821 198 209 198 query83 211 141 143 141 query84 288 75 78 75 query85 1298341 306 306 query86 437 309 318 309 query87 3779354235213521 query88 4706228222582258 query89 496 356 362 356 query90 1962172 171 171 query91 162 140 136 136 query92 61 52 48 48 query93 6588494 478 478 query94 1195175 177 175 query95 437 325 324 324 query96 609 271 266 266 query97 3099287928792879 query98 232 209 216 209 query99 1214924 936 924 Total cold run time: 309068 ms Total hot run time: 185626 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [feature][insert]add FE UT and support CTAS for external table [doris]
doris-robot commented on PR #32525: URL: https://github.com/apache/doris/pull/32525#issuecomment-2016580575 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d4df2b9a1bfa699ae3b9d73da24a4c56a418cf12 with default session variables Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 20.4 seconds inserted 1000 Rows, about 490K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016582705 TPC-H: Total hot run time: 37778 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 2d094789f16c09f15b4684ab7cd92d7998c9ca0b, data reload: false -- Round 1 -- q1 17655 417641474147 q2 2123151 150 150 q3 10592 112111881121 q4 10231 807 744 744 q5 7460299930032999 q6 196 122 122 122 q7 1030584 595 584 q8 9326198119761976 q9 7168661665486548 q10 8437346235093462 q11 442 224 223 223 q12 431 199 197 197 q13 17800 286628612861 q14 224 211 205 205 q15 514 458 461 458 q16 505 375 373 373 q17 948 540 575 540 q18 7038635363576353 q19 4908138214201382 q20 545 247 262 247 q21 3568279729862797 q22 351 289 291 289 Total cold run time: 111492 ms Total hot run time: 37778 ms - Round 2, with runtime_filter_mode=off - q1 4128404240554042 q2 325 233 228 228 q3 2960287528312831 q4 1805152315531523 q5 5287534453185318 q6 192 116 117 116 q7 2214185818631858 q8 3151329532723272 q9 8671865086528650 q10 3788380137803780 q11 549 452 433 433 q12 739 523 550 523 q13 16919 288228552855 q14 282 246 258 246 q15 500 469 458 458 q16 472 420 429 420 q17 1713148714851485 q18 7330717271437143 q19 1862151815111511 q20 1920173116891689 q21 4811470745514551 q22 520 426 438 426 Total cold run time: 70138 ms Total hot run time: 53358 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016585128 TPC-DS: Total hot run time: 186342 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 2d094789f16c09f15b4684ab7cd92d7998c9ca0b, data reload: false query1 925 365 337 337 query2 7371198719091909 query3 6714211 212 211 query4 31630 21280 21377 21280 query5 4304392 393 392 query6 268 172 171 171 query7 4652278 282 278 query8 220 163 174 163 query9 9106224922472247 query10 560 245 261 245 query11 15748 14468 14411 14411 query12 141 98 88 88 query13 1626415 413 413 query14 12962 11149 11408 11149 query15 273 204 202 202 query16 8240265 257 257 query17 2007547 522 522 query18 2092278 267 267 query19 338 144 154 144 query20 90 83 85 83 query21 196 124 125 124 query22 5020481847744774 query23 33503 32564 32724 32564 query24 10304 285328702853 query25 574 358 366 358 query26 720 149 155 149 query27 2188343 348 343 query28 6061186518551855 query29 878 658 621 621 query30 303 149 152 149 query31 976 724 721 721 query32 94 55 57 55 query33 667 262 265 262 query34 884 497 487 487 query35 838 609 603 603 query36 1017869 890 869 query37 110 76 74 74 query38 3544341834543418 query39 1456141814341418 query40 213 119 117 117 query41 53 51 48 48 query42 104 98 96 96 query43 483 473 471 471 query44 1043718 702 702 query45 287 256 258 256 query46 1115699 688 688 query47 1895183718281828 query48 447 354 343 343 query49 1069344 343 343 query50 756 365 365 365 query51 6664656066296560 query52 102 92 87 87 query53 349 270 274 270 query54 317 248 233 233 query55 85 80 78 78 query56 252 234 238 234 query57 1185115011471147 query58 230 210 202 202 query59 2810275126242624 query60 279 248 252 248 query61 114 110 108 108 query62 659 436 441 436 query63 309 277 273 273 query64 5506412940364036 query65 3036304130383038 query66 894 370 387 370 query67 15433 14951 15034 14951 query68 7118509 520 509 query69 630 381 377 377 query70 1275120311891189 query71 500 286 275 275 query72 6435270525242524 query73 720 313 303 303 query74 7225674166436643 query75 4062287929332879 query76 4900861 872 861 query77 658 249 251 249 query78 10973 10113 10282 10113 query79 8395512 519 512 query80 1548393 384 384 query81 537 222 225 222 query82 868 205 196 196 query83 207 143 142 142 query84 282 73 75 73 query85 1330313 308 308 query86 460 298 280 280 query87 3647355134933493 query88 5022226022602260 query89 521 362 361 361 query90 1926168 170 168 query91 167 135 137 135 query92 58 46 47 46 query93 6689490 477 477 query94 1134172 173 172 query95 413 316 323 316 query96 628 263 271 263 query97 3053291128802880 query98 233 232 201 201 query99 1285913 931 913 Total cold run time: 307188 ms Total hot run time: 186342 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [fix] (vectorization) regexp all_pass string [doris]
github-actions[bot] commented on PR #32515: URL: https://github.com/apache/doris/pull/32515#issuecomment-2016612692 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
Mryange commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016623198 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
xiedeyantu commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016624649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
Mryange commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016626615 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016628316 TeamCity be ut coverage result: Function Coverage: 35.25% (8732/24770) Line Coverage: 27.05% (71510/264358) Region Coverage: 26.29% (37107/141144) Branch Coverage: 23.18% (18975/81844) Coverage Report: http://coverage.selectdb-in.cc/coverage/f73fad8275bccc863c707ac596b297aac58377b6_f73fad8275bccc863c707ac596b297aac58377b6/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016630182 TPC-H: Total hot run time: 37776 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f73fad8275bccc863c707ac596b297aac58377b6, data reload: false -- Round 1 -- q1 17604 425840834083 q2 2101164 152 152 q3 10581 110311701103 q4 10229 750 799 750 q5 7450295329382938 q6 204 123 120 120 q7 1021574 556 556 q8 9329198119631963 q9 7384663165206520 q10 8470346435333464 q11 427 217 221 217 q12 420 195 196 195 q13 17790 285028902850 q14 234 199 204 199 q15 503 461 463 461 q16 489 377 375 375 q17 936 630 567 567 q18 7035649464656465 q19 2432143014771430 q20 581 244 243 243 q21 3541292228382838 q22 341 287 295 287 Total cold run time: 109102 ms Total hot run time: 37776 ms - Round 2, with runtime_filter_mode=off - q1 4171409440784078 q2 323 219 222 219 q3 2957285427982798 q4 1815150015611500 q5 5305534353815343 q6 195 116 118 116 q7 2205184418411841 q8 3167327732503250 q9 8654862386268623 q10 3791381937513751 q11 538 448 448 448 q12 715 540 523 523 q13 16926 288128332833 q14 271 254 263 254 q15 487 464 445 445 q16 463 416 425 416 q17 1707145514531453 q18 7502747874067406 q19 1618156515271527 q20 1950172616991699 q21 4692472048154720 q22 540 453 428 428 Total cold run time: 69992 ms Total hot run time: 53671 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016631779 TPC-H: Total hot run time: 38410 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 20165426302539226ef88a4eb859d3f0590504f5, data reload: false -- Round 1 -- q1 18098 428641144114 q2 2109157 152 152 q3 10579 115411981154 q4 10616 742 828 742 q5 8516304230293029 q6 201 122 123 122 q7 1047586 578 578 q8 9339199819971997 q9 7313666066416641 q10 8717359337803593 q11 1032257 247 247 q12 811 224 208 208 q13 19467 304730193019 q14 277 266 210 210 q15 531 453 455 453 q16 483 371 377 371 q17 953 539 629 539 q18 8023656665746566 q19 2290138014691380 q20 517 255 258 255 q21 3531288327552755 q22 341 285 287 285 Total cold run time: 114791 ms Total hot run time: 38410 ms - Round 2, with runtime_filter_mode=off - q1 4093405440244024 q2 325 235 233 233 q3 2924278727922787 q4 1839156715811567 q5 5283536653245324 q6 196 117 116 116 q7 2240187218301830 q8 3144330032433243 q9 8666872387598723 q10 3752379237693769 q11 544 451 437 437 q12 708 531 538 531 q13 16924 283428242824 q14 285 251 247 247 q15 500 462 451 451 q16 466 423 420 420 q17 1729146414511451 q18 7461726670727072 q19 1602150415041504 q20 1919173217231723 q21 4819467547114675 q22 523 456 442 442 Total cold run time: 69942 ms Total hot run time: 53393 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016632464 TPC-DS: Total hot run time: 185606 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f73fad8275bccc863c707ac596b297aac58377b6, data reload: false query1 937 350 352 350 query2 7386202819581958 query3 6711215 213 213 query4 31630 21210 21396 21210 query5 4503412 423 412 query6 271 179 166 166 query7 4628303 288 288 query8 228 178 176 176 query9 9232225622632256 query10 565 252 247 247 query11 15734 14223 14401 14223 query12 127 83 91 83 query13 1627422 416 416 query14 11922 10805 11288 10805 query15 323 204 190 190 query16 8241265 254 254 query17 2055579 555 555 query18 2094286 287 286 query19 344 157 159 157 query20 91 89 85 85 query21 214 130 130 130 query22 4976478348144783 query23 33401 32867 32693 32693 query24 10633 289528762876 query25 638 380 387 380 query26 1225153 159 153 query27 2403352 347 347 query28 7196186418731864 query29 883 666 635 635 query30 302 153 152 152 query31 975 748 732 732 query32 93 57 56 56 query33 780 259 250 250 query34 1054482 501 482 query35 823 613 603 603 query36 1035906 923 906 query37 127 76 79 76 query38 3540347733923392 query39 1477146714221422 query40 209 116 111 111 query41 49 48 48 48 query42 109 101 96 96 query43 448 448 447 447 query44 1230747 709 709 query45 284 233 257 233 query46 1123698 699 698 query47 1904181918591819 query48 443 354 353 353 query49 1112342 330 330 query50 771 364 371 364 query51 6589663166816631 query52 102 87 91 87 query53 345 279 271 271 query54 316 242 252 242 query55 85 79 75 75 query56 246 241 238 238 query57 1201113911461139 query58 239 208 207 207 query59 2833259124712471 query60 283 261 259 259 query61 118 115 135 115 query62 659 459 434 434 query63 312 289 276 276 query64 5823397240603972 query65 3066303330313031 query66 895 350 362 350 query67 15335 14750 14655 14655 query68 6875509 512 509 query69 611 368 379 368 query70 1215115911701159 query71 470 281 275 275 query72 6802274025372537 query73 717 318 322 318 query74 7182665666216621 query75 3839279628122796 query76 4562967 837 837 query77 605 255 268 255 query78 10955 10204 10123 10123 query79 10458 514 520 514 query80 1797395 381 381 query81 546 213 225 213 query82 1474205 197 197 query83 213 145 143 143 query84 284 82 83 82 query85 1504315 308 308 query86 467 307 297 297 query87 3742351035363510 query88 4796225022582250 query89 533 362 361 361 query90 1970177 173 173 query91 172 135 135 135 query92 63 47 48 47 query93 7209493 472 472 query94 1207174 178 174 query95 429 317 324 317 query96 607 271 266 266 query97 3053290029092900 query98 225 211 205 205 query99 1248955 940 940 Total cold run time: 312383 ms Total hot run time: 185606 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
Re: [PR] [featrue](expr) support common subexpression elimination be part [doris]
doris-robot commented on PR #32673: URL: https://github.com/apache/doris/pull/32673#issuecomment-2016632740 TeamCity be ut coverage result: Function Coverage: 35.25% (8732/24771) Line Coverage: 27.04% (71515/264450) Region Coverage: 26.28% (37110/141193) Branch Coverage: 23.18% (18977/81880) Coverage Report: http://coverage.selectdb-in.cc/coverage/5d73761908808938fb5d06567fc2eaae9830453d_5d73761908808938fb5d06567fc2eaae9830453d/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] " [featrue](expr) support common subexpression elimination" [doris]
doris-robot commented on PR #32727: URL: https://github.com/apache/doris/pull/32727#issuecomment-2016633078 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit f73fad8275bccc863c707ac596b297aac58377b6 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.9 seconds inserted 1000 Rows, about 456K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement] fix duplicated properties is not reported [doris]
doris-robot commented on PR #32729: URL: https://github.com/apache/doris/pull/32729#issuecomment-2016634018 TPC-DS: Total hot run time: 185645 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 20165426302539226ef88a4eb859d3f0590504f5, data reload: false query1 937 365 350 350 query2 7432201219901990 query3 6712214 214 214 query4 31870 21285 21260 21260 query5 4370420 391 391 query6 269 175 166 166 query7 4621298 287 287 query8 226 180 181 180 query9 9428225722392239 query10 589 245 247 245 query11 15624 14268 14506 14268 query12 141 96 90 90 query13 1626434 413 413 query14 12360 1 10463 10463 query15 326 204 194 194 query16 8225254 248 248 query17 2021553 532 532 query18 2101288 279 279 query19 349 162 158 158 query20 98 87 92 87 query21 210 132 135 132 query22 5053481749024817 query23 33490 32772 32924 32772 query24 10761 284628332833 query25 595 384 393 384 query26 931 159 160 159 query27 2372354 353 353 query28 7046187118481848 query29 904 682 646 646 query30 303 150 151 150 query31 991 757 742 742 query32 95 60 57 57 query33 782 312 258 258 query34 1001485 493 485 query35 836 619 640 619 query36 1005895 897 895 query37 115 79 77 77 query38 3514339434203394 query39 1484143214221422 query40 213 112 112 112 query41 52 49 47 47 query42 107 93 94 93 query43 481 474 455 455 query44 1169734 710 710 query45 297 261 270 261 query46 1124725 707 707 query47 1937185318491849 query48 467 347 348 347 query49 1087332 340 332 query50 755 373 371 371 query51 6705657466346574 query52 102 101 90 90 query53 353 275 279 275 query54 315 248 239 239 query55 85 84 84 84 query56 259 314 230 230 query57 1228115411511151 query58 244 207 215 207 query59 2706257824902490 query60 293 252 264 252 query61 119 115 117 115 query62 662 447 452 447 query63 305 283 275 275 query64 5724396840943968 query65 3081302330043004 query66 894 385 373 373 query67 15658 15309 14812 14812 query68 8600532 526 526 query69 659 377 373 373 query70 1252110810911091 query71 523 278 277 277 query72 6592270625702570 query73 825 313 309 309 query74 7127663567016635 query75 4340290928172817 query76 5419927 882 882 query77 682 268 268 268 query78 11041 10081 10032 10032 query79 10085 520 525 520 query80 1710390 380 380 query81 532 220 211 211 query82 823 204 202 202 query83 216 146 147 146 query84 281 78 79 78 query85 1350340 318 318 query86 418 294 281 281 query87 3747358535493549 query88 4960226922822269 query89 502 367 365 365 query90 2022175 176 175 query91 170 134 143 134 query92 57 48 49 48 query93 6536502 480 480 query94 1190180 176 176 query95 428 332 329 329 query96 605 270 266 266 query97 3077286829062868 query98 240 219 202 202 query99 1225915 901 901 Total cold run time: 314469 ms Total hot run time: 185645 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
