Re: [PR] [Improvement](hash-map) Separate fixed key hash map context creator [doris]
doris-robot commented on PR #25438: URL: https://github.com/apache/doris/pull/25438#issuecomment-1762672062 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.79 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.6 seconds inserted 1000 Rows, about 349K ops/s storage size: 17161975608 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] Doris Warning日志删除error_log [doris]
liugddx commented on issue #24587: URL: https://github.com/apache/doris/issues/24587#issuecomment-1762673248 #25108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](cooldown) Improve cooldown logs [doris]
platoneko commented on PR #25432: URL: https://github.com/apache/doris/pull/25432#issuecomment-1762699975 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Enhancement] doris服务自动拉起脚本支持 [doris]
ixzc commented on issue #25422: URL: https://github.com/apache/doris/issues/25422#issuecomment-1762702022 You can use doris manager, which includes auto-pull services and cluster management. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](dynamic) Fix error reporting when dynamic partition properties contain incorrect attributes [doris]
Zhiyu-h commented on PR #25373: URL: https://github.com/apache/doris/pull/25373#issuecomment-1762708649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](cooldown) Improve cooldown logs [doris]
doris-robot commented on PR #25432: URL: https://github.com/apache/doris/pull/25432#issuecomment-1762709824 TeamCity be ut coverage result: Function Coverage: 36.24% (8138/22454) Line Coverage: 28.49% (65276/229126) Region Coverage: 27.17% (33805/124411) Branch Coverage: 23.97% (17248/71946) Coverage Report: http://coverage.selectdb-in.cc/coverage/35f4b1d01be2a62f5e73883c90266552b50c2dde_35f4b1d01be2a62f5e73883c90266552b50c2dde/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhance](cooldown) Improve cooldown logs [doris]
doris-robot commented on PR #25432: URL: https://github.com/apache/doris/pull/25432#issuecomment-1762743283 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.6 seconds stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162199670 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](dynamic) Fix error reporting when dynamic partition properties contain incorrect attributes [doris]
doris-robot commented on PR #25373: URL: https://github.com/apache/doris/pull/25373#issuecomment-1762744120 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.22 seconds stream load tsv: 580 seconds loaded 74807831229 Bytes, about 123 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162511171 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Fix [doris]
github-actions[bot] commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1762751366 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 01/01: Revert "[improvement](scanner) Remove the predicate that is always true for the segment (#25366) (#25427)"
This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch revert-25427-pick_prune_predicates
in repository https://gitbox.apache.org/repos/asf/doris.git
commit bb764f8a6f0c86a7db02bacabc65a1141d8af2cc
Author: Kang
AuthorDate: Sat Oct 14 17:29:29 2023 +0800
Revert "[improvement](scanner) Remove the predicate that is always true for
the segment (#25366) (#25427)"
This reverts commit 52ee055f3b5026053f2d5ecac66a5b10384b143f.
---
be/src/common/config.cpp | 2 -
be/src/common/config.h | 3 -
be/src/olap/column_predicate.h | 4 --
be/src/olap/comparison_predicate.h | 25
be/src/olap/rowset/segment_v2/column_reader.cpp| 26 -
be/src/olap/rowset/segment_v2/column_reader.h | 3 -
be/src/olap/rowset/segment_v2/segment.cpp | 20 +--
.../query_p0/test_select_with_predicate_prune.out | 25
.../test_select_with_predicate_prune.groovy| 67 --
9 files changed, 1 insertion(+), 174 deletions(-)
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index f2c726a33b..63ba1a1288 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -1084,8 +1084,6 @@ DEFINE_mInt32(tablet_schema_cache_recycle_interval,
"86400");
DEFINE_Bool(exit_on_exception, "false")
-DEFINE_Bool(ignore_always_true_predicate_for_segment, "true");
-
// clang-format off
#ifdef BE_TEST
// test s3
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 06f9a18fcd..7c4ab39a40 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1141,9 +1141,6 @@ DECLARE_mInt32(tablet_schema_cache_recycle_interval);
// Use `LOG(FATAL)` to replace `throw` when true
DECLARE_mBool(exit_on_exception);
-// Remove predicate that is always true for a segment.
-DECLARE_Bool(ignore_always_true_predicate_for_segment);
-
#ifdef BE_TEST
// test s3
DECLARE_String(test_s3_resource);
diff --git a/be/src/olap/column_predicate.h b/be/src/olap/column_predicate.h
index 05e84999a8..b98156f5fb 100644
--- a/be/src/olap/column_predicate.h
+++ b/be/src/olap/column_predicate.h
@@ -173,10 +173,6 @@ public:
return true;
}
-virtual bool is_always_true(const std::pair&
statistic) const {
-return false;
-}
-
virtual bool evaluate_del(const std::pair&
statistic) const {
return false;
}
diff --git a/be/src/olap/comparison_predicate.h
b/be/src/olap/comparison_predicate.h
index fddc554f51..04dfd5dc5c 100644
--- a/be/src/olap/comparison_predicate.h
+++ b/be/src/olap/comparison_predicate.h
@@ -158,8 +158,6 @@ public:
return _operator(*reinterpret_cast(statistic.ELE->cell_ptr()), _value); \
}
-using WarpperFieldType = std::conditional_t;
-
bool evaluate_and(const std::pair&
statistic) const override {
if (statistic.first->is_null()) {
return true;
@@ -204,29 +202,6 @@ public:
}
}
-bool is_always_true(const std::pair&
statistic) const override {
-if (statistic.first->is_null() || statistic.second->is_null()) {
-return false;
-}
-
-T tmp_min_value {};
-T tmp_max_value {};
-memcpy((char*)(&tmp_min_value), statistic.first->cell_ptr(),
sizeof(WarpperFieldType));
-memcpy((char*)(&tmp_max_value), statistic.second->cell_ptr(),
sizeof(WarpperFieldType));
-
-if constexpr (PT == PredicateType::LT) {
-return _value > tmp_max_value;
-} else if constexpr (PT == PredicateType::LE) {
-return _value >= tmp_max_value;
-} else if constexpr (PT == PredicateType::GT) {
-return _value < tmp_min_value;
-} else if constexpr (PT == PredicateType::GE) {
-return _value <= tmp_min_value;
-}
-
-return false;
-}
-
bool evaluate_del(const std::pair&
statistic) const override {
if (statistic.first->is_null() || statistic.second->is_null()) {
return false;
diff --git a/be/src/olap/rowset/segment_v2/column_reader.cpp
b/be/src/olap/rowset/segment_v2/column_reader.cpp
index d9a074e290..b1b817f545 100644
--- a/be/src/olap/rowset/segment_v2/column_reader.cpp
+++ b/be/src/olap/rowset/segment_v2/column_reader.cpp
@@ -30,7 +30,6 @@
#include "io/fs/file_reader.h"
#include "olap/block_column_predicate.h"
#include "olap/column_predicate.h"
-#include "olap/comparison_predicate.h"
#include "olap/decimal12.h"
#include "olap/inverted_index_parser.h"
#include "olap/iterators.h"
@@ -340,31 +339,6 @@ bool ColumnReader::match_condition(const
AndBlockColumnPredicate* col_predicates
col_predicates);
}
-bool ColumnReader::prune_predicates_by_zone_map(std::vector&
predicates,
-const int column_id) const {
-if (_zone_map_index == nullptr) {
-return false;
-
[doris] branch revert-25427-pick_prune_predicates created (now bb764f8a6f)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch revert-25427-pick_prune_predicates in repository https://gitbox.apache.org/repos/asf/doris.git at bb764f8a6f Revert "[improvement](scanner) Remove the predicate that is always true for the segment (#25366) (#25427)" This branch includes the following new commits: new bb764f8a6f Revert "[improvement](scanner) Remove the predicate that is always true for the segment (#25366) (#25427)" The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] Revert "[improvement](scanner) Remove the predicate that is always true for the segment " [doris]
xiaokang opened a new pull request, #25440: URL: https://github.com/apache/doris/pull/25440 Reverts apache/doris#25427, since it cause coredump. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[improvement](scanner) Remove the predicate that is always true for the segment " [doris]
github-actions[bot] commented on PR #25440: URL: https://github.com/apache/doris/pull/25440#issuecomment-1762777505 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Support hive tables after alter type. [doris]
hubgeter commented on PR #25138: URL: https://github.com/apache/doris/pull/25138#issuecomment-1762781610 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] Revert "[improvement](scanner) Remove the predicate that is always true for the segment " [doris]
yiguolei merged PR #25440: URL: https://github.com/apache/doris/pull/25440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-2.0 updated: Revert "[improvement](scanner) Remove the predicate that is always true for the segment (#25366) (#25427)" (#25440)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 3e2461838a Revert "[improvement](scanner) Remove the predicate that is
always true for the segment (#25366) (#25427)" (#25440)
3e2461838a is described below
commit 3e2461838a25226e821552c555dcef63edf34b00
Author: Kang
AuthorDate: Sat Oct 14 17:53:03 2023 +0800
Revert "[improvement](scanner) Remove the predicate that is always true for
the segment (#25366) (#25427)" (#25440)
---
be/src/common/config.cpp | 2 -
be/src/common/config.h | 3 -
be/src/olap/column_predicate.h | 4 --
be/src/olap/comparison_predicate.h | 25
be/src/olap/rowset/segment_v2/column_reader.cpp| 26 -
be/src/olap/rowset/segment_v2/column_reader.h | 3 -
be/src/olap/rowset/segment_v2/segment.cpp | 20 +--
.../query_p0/test_select_with_predicate_prune.out | 25
.../test_select_with_predicate_prune.groovy| 67 --
9 files changed, 1 insertion(+), 174 deletions(-)
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index f2c726a33b..63ba1a1288 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -1084,8 +1084,6 @@ DEFINE_mInt32(tablet_schema_cache_recycle_interval,
"86400");
DEFINE_Bool(exit_on_exception, "false")
-DEFINE_Bool(ignore_always_true_predicate_for_segment, "true");
-
// clang-format off
#ifdef BE_TEST
// test s3
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 06f9a18fcd..7c4ab39a40 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1141,9 +1141,6 @@ DECLARE_mInt32(tablet_schema_cache_recycle_interval);
// Use `LOG(FATAL)` to replace `throw` when true
DECLARE_mBool(exit_on_exception);
-// Remove predicate that is always true for a segment.
-DECLARE_Bool(ignore_always_true_predicate_for_segment);
-
#ifdef BE_TEST
// test s3
DECLARE_String(test_s3_resource);
diff --git a/be/src/olap/column_predicate.h b/be/src/olap/column_predicate.h
index 05e84999a8..b98156f5fb 100644
--- a/be/src/olap/column_predicate.h
+++ b/be/src/olap/column_predicate.h
@@ -173,10 +173,6 @@ public:
return true;
}
-virtual bool is_always_true(const std::pair&
statistic) const {
-return false;
-}
-
virtual bool evaluate_del(const std::pair&
statistic) const {
return false;
}
diff --git a/be/src/olap/comparison_predicate.h
b/be/src/olap/comparison_predicate.h
index fddc554f51..04dfd5dc5c 100644
--- a/be/src/olap/comparison_predicate.h
+++ b/be/src/olap/comparison_predicate.h
@@ -158,8 +158,6 @@ public:
return _operator(*reinterpret_cast(statistic.ELE->cell_ptr()), _value); \
}
-using WarpperFieldType = std::conditional_t;
-
bool evaluate_and(const std::pair&
statistic) const override {
if (statistic.first->is_null()) {
return true;
@@ -204,29 +202,6 @@ public:
}
}
-bool is_always_true(const std::pair&
statistic) const override {
-if (statistic.first->is_null() || statistic.second->is_null()) {
-return false;
-}
-
-T tmp_min_value {};
-T tmp_max_value {};
-memcpy((char*)(&tmp_min_value), statistic.first->cell_ptr(),
sizeof(WarpperFieldType));
-memcpy((char*)(&tmp_max_value), statistic.second->cell_ptr(),
sizeof(WarpperFieldType));
-
-if constexpr (PT == PredicateType::LT) {
-return _value > tmp_max_value;
-} else if constexpr (PT == PredicateType::LE) {
-return _value >= tmp_max_value;
-} else if constexpr (PT == PredicateType::GT) {
-return _value < tmp_min_value;
-} else if constexpr (PT == PredicateType::GE) {
-return _value <= tmp_min_value;
-}
-
-return false;
-}
-
bool evaluate_del(const std::pair&
statistic) const override {
if (statistic.first->is_null() || statistic.second->is_null()) {
return false;
diff --git a/be/src/olap/rowset/segment_v2/column_reader.cpp
b/be/src/olap/rowset/segment_v2/column_reader.cpp
index d9a074e290..b1b817f545 100644
--- a/be/src/olap/rowset/segment_v2/column_reader.cpp
+++ b/be/src/olap/rowset/segment_v2/column_reader.cpp
@@ -30,7 +30,6 @@
#include "io/fs/file_reader.h"
#include "olap/block_column_predicate.h"
#include "olap/column_predicate.h"
-#include "olap/comparison_predicate.h"
#include "olap/decimal12.h"
#include "olap/inverted_index_parser.h"
#include "olap/iterators.h"
@@ -340,31 +339,6 @@ bool ColumnReader::match_condition(const
AndBlockColumnPredicate* col_predicates
col_predicates);
}
-bool ColumnReader::prune_predicates_by_zone_map(std::vector
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
zzzs commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762783523 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
github-actions[bot] commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762785224 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
doris-robot commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762814534 TeamCity be ut coverage result: Function Coverage: 36.27% (8144/22454) Line Coverage: 28.49% (65282/229119) Region Coverage: 27.18% (33814/124409) Branch Coverage: 23.98% (17251/71944) Coverage Report: http://coverage.selectdb-in.cc/coverage/8821e80bafbcc5726f5eb6e3abffbeb65bd9ee43_8821e80bafbcc5726f5eb6e3abffbeb65bd9ee43/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [refactor](mysql result format) use new serde framework to tuple convert (#25006)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e5ef0aa6d4 [refactor](mysql result format) use new serde framework to
tuple convert (#25006)
e5ef0aa6d4 is described below
commit e5ef0aa6d439c3f9b1f1fe5bc89c9ea6a71d4019
Author: zhiqiang
AuthorDate: Sat Oct 14 06:46:42 2023 -0500
[refactor](mysql result format) use new serde framework to tuple convert
(#25006)
---
be/cmake/thirdparty.cmake | 2 +
be/src/gutil/CMakeLists.txt| 2 +
be/src/gutil/strings/numbers.cc| 13 -
be/src/gutil/strings/numbers.h | 4 +-
be/src/runtime/runtime_state.h | 4 ++
be/src/util/mysql_row_buffer.cpp | 10 ++--
be/src/util/mysql_row_buffer.h | 4 ++
be/src/vec/sink/vmysql_result_writer.cpp | 3 ++
be/src/vec/sink/vmysql_result_writer.h | 2 +
be/test/util/mysql_row_buffer_test.cpp | 58 ++
.../main/java/org/apache/doris/qe/Coordinator.java | 2 +
.../java/org/apache/doris/qe/SessionVariable.java | 12 +
gensrc/thrift/PaloInternalService.thrift | 4 +-
.../mysql_tupleconvert_p0/mysql_tupleconvert.out | 10
.../mysql_tupleconvert.groovy | 40 +++
15 files changed, 160 insertions(+), 10 deletions(-)
diff --git a/be/cmake/thirdparty.cmake b/be/cmake/thirdparty.cmake
index 60d9c65055..5adf108ab6 100644
--- a/be/cmake/thirdparty.cmake
+++ b/be/cmake/thirdparty.cmake
@@ -164,6 +164,8 @@ add_thirdparty(krb5)
add_thirdparty(com_err)
add_thirdparty(k5crypto)
add_thirdparty(gssapi_krb5)
+add_thirdparty(dragonbox_to_chars LIB64)
+target_include_directories(dragonbox_to_chars INTERFACE
"${THIRDPARTY_DIR}/include/dragonbox-1.1.3")
if (OS_MACOSX)
add_thirdparty(bfd)
diff --git a/be/src/gutil/CMakeLists.txt b/be/src/gutil/CMakeLists.txt
index bac9aec303..12c2330884 100644
--- a/be/src/gutil/CMakeLists.txt
+++ b/be/src/gutil/CMakeLists.txt
@@ -57,6 +57,8 @@ add_library(Gutil STATIC ${SOURCE_FILES})
set_target_properties(Gutil PROPERTIES COMPILE_FLAGS "-funsigned-char
-Wno-deprecated")
target_compile_options(Gutil PRIVATE -Wno-char-subscripts
-Wno-implicit-fallthrough)
+target_link_libraries(Gutil PRIVATE dragonbox_to_chars)
+
# target_link_libraries(Gutil glog protobuf rt)
#set(GUTIL_LIBS
diff --git a/be/src/gutil/strings/numbers.cc b/be/src/gutil/strings/numbers.cc
index 5550757d40..9aea10155f 100644
--- a/be/src/gutil/strings/numbers.cc
+++ b/be/src/gutil/strings/numbers.cc
@@ -27,6 +27,7 @@ using std::string;
#include "common/logging.h"
#include
+#include "dragonbox/dragonbox_to_chars.h"
#include "gutil/gscoped_ptr.h"
#include "gutil/int128.h"
#include "gutil/integral_types.h"
@@ -1274,7 +1275,11 @@ int FloatToBuffer(float value, int width, char* buffer) {
return snprintf_result;
}
-int FastDoubleToBuffer(double value, char* buffer) {
+int FastDoubleToBuffer(double value, char* buffer, bool faster_float_convert) {
+if (faster_float_convert) {
+return jkj::dragonbox::to_chars_n(value, buffer) - buffer;
+}
+
auto end = fmt::format_to(buffer, "{:.15g}", value);
*end = '\0';
if (strtod(buffer, nullptr) != value) {
@@ -1283,7 +1288,11 @@ int FastDoubleToBuffer(double value, char* buffer) {
return end - buffer;
}
-int FastFloatToBuffer(float value, char* buffer) {
+int FastFloatToBuffer(float value, char* buffer, bool faster_float_convert) {
+if (faster_float_convert) {
+return jkj::dragonbox::to_chars_n(value, buffer) - buffer;
+}
+
auto end = fmt::format_to(buffer, "{:.6g}", value);
*end = '\0';
#ifdef _MSC_VER // has no strtof()
diff --git a/be/src/gutil/strings/numbers.h b/be/src/gutil/strings/numbers.h
index 8e2478794a..e7c6f93826 100644
--- a/be/src/gutil/strings/numbers.h
+++ b/be/src/gutil/strings/numbers.h
@@ -443,8 +443,8 @@ int FloatToBuffer(float i, int width, char* buffer);
char* DoubleToBuffer(double i, char* buffer);
char* FloatToBuffer(float i, char* buffer);
-int FastDoubleToBuffer(double i, char* buffer);
-int FastFloatToBuffer(float i, char* buffer);
+int FastDoubleToBuffer(double i, char* buffer, bool faster_float_convert =
false);
+int FastFloatToBuffer(float i, char* buffer, bool faster_float_convert =
false);
// In practice, doubles should never need more than 24 bytes and floats
// should never need more than 14 (including null terminators), but we
// overestimate to be safe.
diff --git a/be/src/runtime/runtime_state.h b/be/src/runtime/runtime_state.h
index 9396c41d96..06ceb699e7 100644
--- a/be/src/runtime/runtime_state.h
+++ b/be/src/runtime/runtime_state.h
@@ -151,6 +151,10 @@ public:
_query_options.enable_common_expr_push
Re: [PR] [refactor](mysql result format) use new serde framework to tuple convert [doris]
yiguolei merged PR #25006: URL: https://github.com/apache/doris/pull/25006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](fe rest api)api gets execution plan, table name case problem [doris]
yiguolei merged PR #25112: URL: https://github.com/apache/doris/pull/25112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](fe rest api)api gets execution plan, table name case problem (#25112)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 03316e2355 [fix](fe rest api)api gets execution plan, table name case
problem (#25112)
03316e2355 is described below
commit 03316e235530d85063255513d7c8d23583997222
Author: jiafeng.zhang
AuthorDate: Sat Oct 14 06:48:24 2023 -0500
[fix](fe rest api)api gets execution plan, table name case problem (#25112)
The user has configured the parameter lower_case_table_names, which ignores
the case of the table name. When executed on the SQL client, the table name can
be queried in both case.
But when using Connector to read doris data, the table names must be in the
same case, otherwise an error will be reported.
---
.../doris/httpv2/rest/TableQueryPlanAction.java | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/TableQueryPlanAction.java
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/TableQueryPlanAction.java
index f337935570..0bd83617f1 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/TableQueryPlanAction.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/TableQueryPlanAction.java
@@ -35,6 +35,7 @@ import org.apache.doris.planner.PlanFragment;
import org.apache.doris.planner.Planner;
import org.apache.doris.planner.ScanNode;
import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.GlobalVariable;
import org.apache.doris.qe.OriginStatement;
import org.apache.doris.qe.StmtExecutor;
import org.apache.doris.thrift.TDataSink;
@@ -197,10 +198,21 @@ public class TableQueryPlanAction extends
RestBaseController {
// check consistent http requested resource with sql referenced
// if consistent in this way, can avoid check privilege
TableName tableAndDb = fromTables.get(0).getName();
-if (!(tableAndDb.getDb().equals(requestDb) &&
tableAndDb.getTbl().equals(requestTable))) {
-throw new DorisHttpException(HttpResponseStatus.BAD_REQUEST,
-"requested database and table must consistent with sql:
request [ "
-+ requestDb + "." + requestTable + "]" + "and sql [" +
tableAndDb.toString() + "]");
+int lower = GlobalVariable.lowerCaseTableNames;
+//Determine whether table names are case-sensitive
+if (lower == 0) {
+if (!(tableAndDb.getDb().equals(requestDb) &&
tableAndDb.getTbl().equals(requestTable))) {
+throw new DorisHttpException(HttpResponseStatus.BAD_REQUEST,
+"requested database and table must consistent with
sql: request [ "
++ requestDb + "." + requestTable + "]" + "and
sql [" + tableAndDb.toString() + "]");
+}
+} else {
+if (!(tableAndDb.getDb().equalsIgnoreCase(requestDb)
+&& tableAndDb.getTbl().equalsIgnoreCase(requestTable))) {
+throw new DorisHttpException(HttpResponseStatus.BAD_REQUEST,
+"requested database and table must consistent with
sql: request [ "
++ requestDb + "." + requestTable + "]" + "and
sql [" + tableAndDb.toString() + "]");
+}
}
// acquired Planner to get PlanNode and fragment templates
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]
ByteYue commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762883673 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [feature](CANCEL-ALTER-SYSTEM)drop or decommission backend by ids [doris]
liugddx opened a new pull request, #25441: URL: https://github.com/apache/doris/pull/25441 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]
github-actions[bot] commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762885577 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
zzzs commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762887035 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] compilation break for aarch64 platform [doris]
Nitin-Kashyap opened a new issue, #25442: URL: https://github.com/apache/doris/issues/25442 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version latest 2.0.2++ ### What's Wrong? compilation failure symbol `backtrace` not found. issue occurs because of wrong usage of compilation restriction macros. In code: it excludes to use libunwind on aarch64, however also does not include the fallback (execinfo :: backtrace) ### What You Expected? fix the include to align with usage ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
github-actions[bot] commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762887321 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](build) aarch64 compilation fix # [doris]
Nitin-Kashyap opened a new pull request, #25443: URL: https://github.com/apache/doris/pull/25443 ## Proposed changes Compilation to include execinfo when building on aarch64 Issue Number: close #25442 synchronized the include and usage of backtrace/unwind lib usage, for ccompilation fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](CANCEL-ALTER-SYSTEM)drop or decommission backend by ids [doris]
liugddx commented on PR #25441: URL: https://github.com/apache/doris/pull/25441#issuecomment-1762889339 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762889545 TeamCity be ut coverage result: Function Coverage: 36.27% (8145/22456) Line Coverage: 28.50% (65299/229133) Region Coverage: 27.19% (33824/124421) Branch Coverage: 23.99% (17258/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/d3272945cbf8852895c8d61446cd8176ce2b8939_d3272945cbf8852895c8d61446cd8176ce2b8939/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
github-actions[bot] commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-176288 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Backup) use correct variable name to check the conf correctness when doing backup job [doris]
doris-robot commented on PR #25434: URL: https://github.com/apache/doris/pull/25434#issuecomment-1762892797 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.08 seconds stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162095659 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
doris-robot commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762893283 TeamCity be ut coverage result: Function Coverage: 36.28% (8147/22456) Line Coverage: 28.51% (65322/229131) Region Coverage: 27.20% (33838/124419) Branch Coverage: 24.00% (17269/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/2f18595384af4cba5e78a180e45d8534deace314_2f18595384af4cba5e78a180e45d8534deace314/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
github-actions[bot] commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762920651 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](CANCEL-ALTER-SYSTEM)drop or decommission backend by ids [doris]
doris-robot commented on PR #25441: URL: https://github.com/apache/doris/pull/25441#issuecomment-1762920696 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.69 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17162211751 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
zzzs commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762921535 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
doris-robot commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762927542 TeamCity be ut coverage result: Function Coverage: 36.27% (8145/22456) Line Coverage: 28.50% (65301/229131) Region Coverage: 27.18% (33818/124419) Branch Coverage: 23.99% (17259/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/16647e770a5c72ddc8c4ef1352bcb7858dac6bfd_16647e770a5c72ddc8c4ef1352bcb7858dac6bfd/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](Load) Nereids supports http_stream [doris]
doris-robot commented on PR #25049: URL: https://github.com/apache/doris/pull/25049#issuecomment-1762928165 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.61 seconds stream load tsv: 548 seconds loaded 74807831229 Bytes, about 130 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17161988313 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bugfix](regression-test) Fix a naming conflict in ccr regression test [doris]
yiguolei merged PR #25436: URL: https://github.com/apache/doris/pull/25436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: Fix a naming conflict in ccr regression test (#25436)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ed3e8f93557 Fix a naming conflict in ccr regression test (#25436)
ed3e8f93557 is described below
commit ed3e8f93557a559f133fe10b885cf325427b96a4
Author: deadlinefen
AuthorDate: Sat Oct 14 22:28:59 2023 +0800
Fix a naming conflict in ccr regression test (#25436)
---
.../test_create_table_with_binlog_config.groovy| 40 +++---
.../ccr_mow_syncer_p0/test_get_binlog.groovy | 4 +--
.../test_create_table_with_binlog_config.groovy| 2 +-
.../suites/ccr_syncer_p0/test_get_binlog.groovy| 4 +--
4 files changed, 25 insertions(+), 25 deletions(-)
diff --git
a/regression-test/suites/ccr_mow_syncer_p0/test_create_table_with_binlog_config.groovy
b/regression-test/suites/ccr_mow_syncer_p0/test_create_table_with_binlog_config.groovy
index 7f8fc5e7ce3..b847b2d02a2 100644
---
a/regression-test/suites/ccr_mow_syncer_p0/test_create_table_with_binlog_config.groovy
+++
b/regression-test/suites/ccr_mow_syncer_p0/test_create_table_with_binlog_config.groovy
@@ -21,73 +21,73 @@ suite("test_mow_create_table_with_binlog_config") {
logger.info("fe enable_feature_binlog is false, skip case
test_mow_create_table_with_binlog_config")
return
}
-sql "drop database if exists test_table_binlog"
+sql "drop database if exists test_mow_table_binlog"
sql """
-create database test_table_binlog
+create database test_mow_table_binlog
"""
-result = sql "show create database test_table_binlog"
+def result = sql "show create database test_mow_table_binlog"
logger.info("${result}")
// Case 1: database disable binlog, create table with binlog disable
sql """
-CREATE TABLE test_table_binlog.t1 ( k1 INT ) ENGINE = olap UNIQUE
KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "false" );
+CREATE TABLE test_mow_table_binlog.t1 ( k1 INT ) ENGINE = olap UNIQUE
KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "false" );
"""
-result = sql "show create table test_table_binlog.t1"
+result = sql "show create table test_mow_table_binlog.t1"
logger.info("${result}")
assertTrue(result.toString().containsIgnoreCase('"binlog.enable" =
"false"'))
sql """
-drop table if exists test_table_binlog.t1
+drop table if exists test_mow_table_binlog.t1
"""
// Case 2: database disable binlog, create table with binlog enable
sql """
-CREATE TABLE test_table_binlog.t1 ( k1 INT ) ENGINE = olap UNIQUE
KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "true" );
+CREATE TABLE test_mow_table_binlog.t1 ( k1 INT ) ENGINE = olap UNIQUE
KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "true" );
"""
-result = sql "show create table test_table_binlog.t1"
+result = sql "show create table test_mow_table_binlog.t1"
logger.info("${result}")
assertTrue(result.toString().containsIgnoreCase('"binlog.enable" =
"true"'))
sql """
-drop table if exists test_table_binlog.t1
+drop table if exists test_mow_table_binlog.t1
"""
// Case 3: database enable binlog, create table with binlog disable
sql """
-alter database test_table_binlog set properties ("binlog.enable" =
"true")
+alter database test_mow_table_binlog set properties ("binlog.enable" =
"true")
"""
assertThrows(Exception.class, {
sql """
-CREATE TABLE test_table_binlog.t1 ( k1 INT ) ENGINE = olap UNIQUE
KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "false" );
+CREATE TABLE test_mow_table_binlog.t1 ( k1 INT ) ENGINE = olap
UNIQUE KEY(k1) DISTRIBUTED BY HASH(k1) BUCKETS 3 PROPERTIES (
"enable_unique_key_merge_on_write" = "true", "replication_num" = "1",
"binlog.enable" = "false" );
"""
})
sql """
-drop table if exists test_table_binlog.t1
+drop table if exists test_mow_table_binlog.t1
"""
// Case 4: database enable binlog, create table with binlog enable
sql """
-alter database test_table_binlog set properties ("binlog.enable" =
"true")
+alter database test_mow_table_binlog set properties ("binlog.enable" =
"true")
"""
sql """
-CREATE TABLE test_table_binlo
Re: [PR] [improvement](auth) support show view priv [doris]
yiguolei merged PR #25370: URL: https://github.com/apache/doris/pull/25370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [improvement](auth) support show view priv (#25370)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 471cf2c48b5 [improvement](auth) support show view priv (#25370)
471cf2c48b5 is described below
commit 471cf2c48b5f7f01005c90603c4ed96c32bcf762
Author: zhangdong <493738...@qq.com>
AuthorDate: Sat Oct 14 22:37:51 2023 +0800
[improvement](auth) support show view priv (#25370)
Issue Number: close #xxx
current ,if user has select_priv or load_priv,he can show create table
view_name,
but this is not safe，so add show_view_priv for show create table view_name
mysql SHOW VIEW description:
https://dev.mysql.com/doc/refman/8.0/en/privileges-provided.html#priv_show-view
---
.../Account-Management-Statements/GRANT.md | 7 ++
.../Account-Management-Statements/GRANT.md | 7 ++
.../apache/doris/analysis/ShowCreateTableStmt.java | 15 +++-
.../org/apache/doris/catalog/AccessPrivilege.java | 7 +-
.../doris/mysql/privilege/PrivPredicate.java | 8 ++
.../apache/doris/mysql/privilege/Privilege.java| 13 +++-
.../org/apache/doris/mysql/privilege/AuthTest.java | 85 ++
.../suites/account_p0/test_auth_show.groovy| 62
8 files changed, 197 insertions(+), 7 deletions(-)
diff --git
a/docs/en/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
b/docs/en/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
index 93addd749aa..da18856d269 100644
---
a/docs/en/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
+++
b/docs/en/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
@@ -62,6 +62,7 @@ privilege_list is a list of privileges to be granted,
separated by commas. Curre
CREATE_PRIV: Create permission on the specified database or table
DROP_PRIV: drop privilege on the specified database or table
USAGE_PRIV: access to the specified resource
+SHOW_VIEW_PRIV: View permission to `view` creation statements (starting
from version 2.0.3, 'SELECT_PRIV' and 'LOAD_PRIV' permissions cannot be 'SHOW
CREATE TABLE view_name', has one of
`CREATE_PRIV`，`ALTER_PRIV`，`DROP_PRIV`，`SHOW_VIEW_PRIV` can `SHOW CREATE TABLE
view_name`)
ALL and READ_WRITE in legacy permissions will be converted to:
SELECT_PRIV,LOAD_PRIV,ALTER_PRIV,CREATE_PRIV,DROP_PRIV;
READ_ONLY is converted to SELECT_PRIV.
@@ -164,6 +165,12 @@ role_list is the list of roles to be assigned, separated
by commas,the specified
GRANT USAGE_PRIV ON WORKLOAD GROUP 'g1' TO ROLE 'my_role'.
+11. Allow jack to view the creation statement of view1 under db1
+
+```sql
+GRANT SHOW_VIEW_PRIV ON db1.view1 TO 'jack'@'%';
+
+
### Keywords
GRANT
diff --git
a/docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
b/docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
index 107773826bd..414cf4cfef1 100644
---
a/docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
+++
b/docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md
@@ -62,6 +62,7 @@ privilege_list 是需要赋予的权限列表，以逗号分隔。当前 Doris
CREATE_PRIV：对指定的库或表的创建权限
DROP_PRIV：对指定的库或表的删除权限
USAGE_PRIV: 对指定资源的使用权限和workload
group权限
+SHOW_VIEW_PRIV:
查看`view`创建语句的权限(从2.0.3版本开始，`SELECT_PRIV`和`LOAD_PRIV`权限不能`SHOW CREATE TABLE
view_name`，拥有`CREATE_PRIV`，`ALTER_PRIV`，`DROP_PRIV`，`SHOW_VIEW_PRIV`权限项中的任何一个，有权`SHOW
CREATE TABLE view_name`)
旧版权限中的 ALL 和 READ_WRITE
会被转换成：SELECT_PRIV,LOAD_PRIV,ALTER_PRIV,CREATE_PRIV,DROP_PRIV；
READ_ONLY 会被转换为 SELECT_PRIV。
@@ -164,6 +165,12 @@ role_list 是需要赋予的角色列表，以逗号分隔，指定的角色必
GRANT USAGE_PRIV ON WORKLOAD GROUP 'g1' TO ROLE 'my_role';
+11. 允许jack查看db1下view1的创建语句
+
+```sql
+GRANT SHOW_VIEW_PRIV ON db1.view1 TO 'jack'@'%';
+
+
### Keywords
```
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCreateTableStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCreateTableStmt.java
index 9527a061d31..ea3b442fbc7 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCreateTableStmt.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCreateTableStmt.java
@@ -20,6 +20,8 @@ package org.apache.doris.analysis;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.ScalarType;
+import org.apache.doris.catalog.TableIf;
+import org.apache.doris.catalog.View;
import org.apache.doris.common.AnalysisException;
import org.apache.doris.common.ErrorCode;
import org.apache.doris.common.ErrorReport;
@@ -103,8 +105,19 @@ public class ShowCreateTableStmt extends ShowStmt {
}
tbl.analyze(analyzer);
+TableIf tableIf = Env.getCurrentEnv(
Re: [PR] [fix](Tvf) return empty set when tvf queries an empty file or an error uri [doris]
github-actions[bot] commented on PR #25280: URL: https://github.com/apache/doris/pull/25280#issuecomment-1762956514 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] (feature)[alter backends]backend modify & drop & decommission by ids [doris]
liugddx commented on PR #25444: URL: https://github.com/apache/doris/pull/25444#issuecomment-1762960450 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] (feature)[alter backends]backend modify & drop & decommission by ids [doris]
liugddx opened a new pull request, #25444: URL: https://github.com/apache/doris/pull/25444 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](alter backends)backend modify & drop & decommission by ids [doris]
liugddx commented on PR #25444: URL: https://github.com/apache/doris/pull/25444#issuecomment-1762961175 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
github-actions[bot] commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1762962567 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
github-actions[bot] commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1762962575 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
xinyiZzz commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1762963338 Thanks for your fix, in the future, libunwind will need to be verified on other platforms besides x86. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](insert) make group commit wal_manager exit elegantly (#25250)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 7ea456ef916 [fix](insert) make group commit wal_manager exit elegantly
(#25250)
7ea456ef916 is described below
commit 7ea456ef916e5f587b86c13013a5b8bc7f60fa1f
Author: huanghaibin <284824...@qq.com>
AuthorDate: Sat Oct 14 23:14:06 2023 +0800
[fix](insert) make group commit wal_manager exit elegantly (#25250)
---
be/src/olap/wal_manager.cpp| 11 +-
be/src/runtime/exec_env_init.cpp | 2 +-
be/test/olap/wal_manager_test.cpp | 1 +
be/test/vec/exec/vtablet_sink_test.cpp | 1 +
be/test/vec/exec/vwal_scanner_test.cpp | 267 +
5 files changed, 275 insertions(+), 7 deletions(-)
diff --git a/be/src/olap/wal_manager.cpp b/be/src/olap/wal_manager.cpp
index 72f92b1fabd..cf84c4a9661 100644
--- a/be/src/olap/wal_manager.cpp
+++ b/be/src/olap/wal_manager.cpp
@@ -38,14 +38,14 @@ WalManager::WalManager(ExecEnv* exec_env, const
std::string& wal_dir_list)
}
WalManager::~WalManager() {
-_stop_background_threads_latch.count_down();
-if (_replay_thread) {
-_replay_thread->join();
-}
LOG(INFO) << "WalManager is destoried";
}
void WalManager::stop() {
_stop = true;
+_stop_background_threads_latch.count_down();
+if (_replay_thread) {
+_replay_thread->join();
+}
LOG(INFO) << "WalManager is stopped";
}
@@ -186,8 +186,7 @@ Status WalManager::replay() {
break;
}
// port == 0 means not received heartbeat yet
-while (_exec_env->master_info()->network_address.port == 0) {
-sleep(1);
+if (_exec_env->master_info()->network_address.port == 0) {
continue;
}
std::vector replay_tables;
diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index 7ab8efc839b..646c8fca2be 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -530,7 +530,6 @@ void ExecEnv::destroy() {
_s_ready = false;
SAFE_STOP(_wal_manager);
-_wal_manager.reset();
SAFE_STOP(_tablet_schema_cache);
SAFE_STOP(_load_channel_mgr);
SAFE_STOP(_scanner_scheduler);
@@ -557,6 +556,7 @@ void ExecEnv::destroy() {
// Free resource after threads are stopped.
// Some threads are still running, like threads created by
_new_load_stream_mgr ...
+_wal_manager.reset();
SAFE_DELETE(_s3_buffer_pool);
SAFE_DELETE(_tablet_schema_cache);
_deregister_metrics();
diff --git a/be/test/olap/wal_manager_test.cpp
b/be/test/olap/wal_manager_test.cpp
index a0236fd1979..fbb5fdbf03f 100644
--- a/be/test/olap/wal_manager_test.cpp
+++ b/be/test/olap/wal_manager_test.cpp
@@ -69,6 +69,7 @@ public:
}
void TearDown() override {
static_cast(io::global_local_filesystem()->delete_directory(wal_dir));
+SAFE_STOP(_env->_wal_manager);
SAFE_DELETE(_env->_function_client_cache);
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_master_info);
diff --git a/be/test/vec/exec/vtablet_sink_test.cpp
b/be/test/vec/exec/vtablet_sink_test.cpp
index be1cdd94d64..4daa9505ce5 100644
--- a/be/test/vec/exec/vtablet_sink_test.cpp
+++ b/be/test/vec/exec/vtablet_sink_test.cpp
@@ -378,6 +378,7 @@ public:
void TearDown() override {
static_cast(io::global_local_filesystem()->delete_directory(wal_dir));
+SAFE_STOP(_env->_wal_manager);
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
SAFE_DELETE(_env->_master_info);
diff --git a/be/test/vec/exec/vwal_scanner_test.cpp
b/be/test/vec/exec/vwal_scanner_test.cpp
new file mode 100644
index 000..1ae1a99e531
--- /dev/null
+++ b/be/test/vec/exec/vwal_scanner_test.cpp
@@ -0,0 +1,267 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#include
+
+#include
+#include
+
+#include "common/object_pool.h"
+#include "gen_cpp/Descriptors_types.h"
+#include "gen_cpp/PlanNodes_types.h"
+#include "olap/wal_manag
Re: [PR] [fix](insert) make group commit wal_manager exit elegantly [doris]
yiguolei merged PR #25250: URL: https://github.com/apache/doris/pull/25250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](alter backends)backend modify & drop & decommission by ids [doris]
doris-robot commented on PR #25444: URL: https://github.com/apache/doris/pull/25444#issuecomment-1762990993 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.98 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.9 seconds inserted 1000 Rows, about 346K ops/s storage size: 17162153417 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](alter backends)backend modify & drop & decommission by ids [doris]
doris-robot commented on PR #25444: URL: https://github.com/apache/doris/pull/25444#issuecomment-1762994022 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.91 seconds stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17161926052 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
github-actions[bot] commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763061556 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
github-actions[bot] commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763062505 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](be) Add default timezone files [doris]
zclllyybb commented on PR #25097: URL: https://github.com/apache/doris/pull/25097#issuecomment-1763123876 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](be) Add default timezone files [doris]
github-actions[bot] commented on PR #25097: URL: https://github.com/apache/doris/pull/25097#issuecomment-1763125756 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](be) Add default timezone files [doris]
doris-robot commented on PR #25097: URL: https://github.com/apache/doris/pull/25097#issuecomment-1763165014 TeamCity be ut coverage result: Function Coverage: 36.72% (8246/22456) Line Coverage: 28.86% (66139/229134) Region Coverage: 27.57% (34300/124420) Branch Coverage: 24.26% (17456/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/0b0c1a8e8b8ffda5b725d47eb9e3820450042b2f_0b0c1a8e8b8ffda5b725d47eb9e3820450042b2f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] SELECT @@variables does not return column names due to regression introduced in 2.0.2 [doris]
geoffreytran opened a new issue, #25445: URL: https://github.com/apache/doris/issues/25445 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 2.0.2 ### What's Wrong? When selecting SELECT @@variables, query does not return column names in 2.0.2 compared to previous versions. This causes Mysql clients that check connection information to fail on connect. ### What You Expected? ```sql SELECT @@max_allowed_packet, @@character_set_client, @@character_set_connection, @@license, @@sql_mode, @@lower_case_table_names; ``` Query Results for Doris <2.0.1.1 ``` @@max_allowed_packet | @@character_set_client | @@character_set_connection | @@license | @@sql_mode | @@lower_case_table_names 1048576 | utf8 | utf8 | Apache License, Version 2.0 | | 0 ``` https://github.com/apache/doris/assets/544500/8f5bc7cf-c8a1-48e4-96f0-2d4194ce6162";> We expect to see "@@max_allowed_packet | @@character_set_client | @@character_set_connection | @@license | @@sql_mode | @@lower_case_table_names" returned. Query Results for Doris 2.0.2 BUG ``` 1048576 | 'utf8' | 'utf8' | 'Apache License, Version 2.0' | '' | 0 1048576 | utf8 | utf8 | Apache License, Version 2.0 | | 0 ``` https://github.com/apache/doris/assets/544500/049182ea-32ac-4303-9325-0ada055c1a2a";> ### How to Reproduce? Run the following query on Doris 2.0.2: ```sql SELECT @@max_allowed_packet, @@character_set_client, @@character_set_connection, @@license, @@sql_mode, @@lower_case_table_names; ``` ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](CANCEL-ALTER-SYSTEM)decommission backend by ids [doris]
liugddx commented on PR #25441: URL: https://github.com/apache/doris/pull/25441#issuecomment-1763215780 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](CANCEL-ALTER-SYSTEM)decommission backend by ids [doris]
doris-robot commented on PR #25441: URL: https://github.com/apache/doris/pull/25441#issuecomment-1763222758 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.59 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes, about 126 MB/s stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17162102414 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
adonis0147 commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763226524 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
github-actions[bot] commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763227876 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improvement](statistics)Collect stats for hive partition column using metadata. [doris]
morningman commented on code in PR #24853:
URL: https://github.com/apache/doris/pull/24853#discussion_r1359700697
##
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyzeProperties.java:
##
@@ -42,8 +42,8 @@ public class AnalyzeProperties {
public static final String PROPERTY_NUM_BUCKETS = "num.buckets";
public static final String PROPERTY_ANALYSIS_TYPE = "analysis.type";
public static final String PROPERTY_PERIOD_SECONDS = "period.seconds";
-
public static final String PROPERTY_FORCE_FULL = "force.full";
+public static final String PROPERTY_PARTITION_COLUMN_SQL =
"partition.column.sql";
Review Comment:
how about "partition.column.from.meta"
##
fe/fe-core/src/main/cup/sql_parser.cup:
##
@@ -6141,6 +6142,12 @@ with_analysis_properties ::=
put(AnalyzeProperties.PROPERTY_FORCE_FULL, "true");
}};
:}
+| KW_SQL
Review Comment:
Need to modify the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](docker)add docker-iceberg init tables [doris]
morningman commented on code in PR #25424: URL: https://github.com/apache/doris/pull/25424#discussion_r1359704222 ## docker/thirdparties/docker-compose/iceberg/README.md: ## @@ -0,0 +1,32 @@ + + + +``` +data: +input: 初始化docker使用的数据 Review Comment: use English ## docker/thirdparties/docker-compose/iceberg/iceberg.yaml.tpl: ## @@ -18,19 +18,18 @@ version: "3" services: - doris--spark-iceberg: + spark-iceberg: Review Comment: Why remove the prefix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
doris-robot commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763242263 TeamCity be ut coverage result: Function Coverage: 36.65% (8230/22456) Line Coverage: 28.79% (65960/229131) Region Coverage: 27.50% (34215/124421) Branch Coverage: 24.21% (17418/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/032ea1e6c9ede7508363e382b5c8bb00bf45bdf6_032ea1e6c9ede7508363e382b5c8bb00bf45bdf6/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
adonis0147 commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763245827 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [runtimefilter](nerieds)support Non equal runtime filter for nested loop join [doris]
englefly commented on PR #25193: URL: https://github.com/apache/doris/pull/25193#issuecomment-1763251400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [runtimefilter](nerieds)support Non equal runtime filter for nested loop join [doris]
englefly commented on PR #25193: URL: https://github.com/apache/doris/pull/25193#issuecomment-1763252158 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Feature](Nereids) Add explain tree functionality which contains fragment ids for profile analysis. [doris]
kaka11chen opened a new pull request, #25446: URL: https://github.com/apache/doris/pull/25446 ## Proposed changes Add explain tree functionality which contains fragment ids for profile analysis. ``` mysql> explain tree select sum(l_orderkey) from lineitem, orders where l_orderkey = o_orderkey; +---+ | Explain String(Nereids Planner) | +---+ | [414]:[414: ResultSink]||[Fragment: 0]||VRESULT SINK|| MYSQL_PROTOCAL|| | | --[414]:[414: VAGGREGATE (merge finalize)]||[Fragment: 0]||cardinality=1|| | | [411]:[411: VEXCHANGE]||[Fragment: 0]||offset: 0|| | | --[411]:[411: DataStreamSink]||[Fragment: 1]||STREAM DATA SINK|| EXCHANGE ID: 411|| UNPARTITIONED | | [408]:[408: VAGGREGATE (update serialize)]||[Fragment: 1]||cardinality=1|| | | --[402]:[402: VHASH JOIN]||[Fragment: 1]||join op: INNER JOIN(PARTITIONED)[]||cardinality=593,132,346|| | | [392]:[392: VEXCHANGE]||[Fragment: 1]||offset: 0|| | | --[392]:[392: DataStreamSink]||[Fragment: 2]||STREAM DATA SINK|| EXCHANGE ID: 392|| HASH_PARTITIONED | | [386]:[386: VHIVE_SCAN_NODE]||[Fragment: 2]||table: lineitem||inputSplitNum=144, totalFileSize=16632158739, scanRanges=144||partition=1/1||cardinality=600037902, numNodes=1||pushdown agg=NONE|| | | [399]:[399: VEXCHANGE]||[Fragment: 1]||offset: 0|| | | --[399]:[399: DataStreamSink]||[Fragment: 3]||STREAM DATA SINK|| EXCHANGE ID: 399|| HASH_PARTITIONED | | [393]:[393: VHIVE_SCAN_NODE]||[Fragment: 3]||table: orders||inputSplitNum=48, totalFileSize=3984213353, scanRanges=48||partition=1/1||cardinality=15000, numNodes=1||pushdown agg=NONE|| | +---+ 12 rows in set (0.04 sec) ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](Nereids) Add explain tree functionality which contains fragment ids for profile analysis. [doris]
kaka11chen commented on PR #25446: URL: https://github.com/apache/doris/pull/25446#issuecomment-1763255227 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
doris-robot commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763259973 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.16 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 28.8 seconds inserted 1000 Rows, about 347K ops/s storage size: 17162346735 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [runtimefilter](nerieds)support Non equal runtime filter for nested loop join [doris]
doris-robot commented on PR #25193: URL: https://github.com/apache/doris/pull/25193#issuecomment-1763259813 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.93 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.0 seconds inserted 1000 Rows, about 344K ops/s storage size: 17162135498 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
adonis0147 commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763262835 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](Nereids) Add explain tree functionality which contains fragment ids for profile analysis. [doris]
doris-robot commented on PR #25446: URL: https://github.com/apache/doris/pull/25446#issuecomment-1763265708 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.1 seconds stream load tsv: 556 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.2 seconds inserted 1000 Rows, about 342K ops/s storage size: 17161979331 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](dynamic) Fix error reporting when dynamic partition properties contain incorrect attributes [doris]
Zhiyu-h commented on PR #25373: URL: https://github.com/apache/doris/pull/25373#issuecomment-1763267827 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Bug](table-function) insert default when json array parse failed [doris]
BiteThet opened a new pull request, #25447: URL: https://github.com/apache/doris/pull/25447 ## Proposed changes ```cpp 7# long unaligned_load(void const*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/common/unaligned.h:30 8# doris::vectorized::ColumnVector::insert_data(char const*, unsigned long) at /home/zcp/repo_center/doris_master/doris/be/src/vec/columns/column_vector.h:189 9# doris::vectorized::VExplodeJsonArrayTableFunction::get_value(COW::mutable_ptr&) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/table_function/vexplode_json_array.cpp:224 10# doris::vectorized::TableFunction::get_value(COW::mutable_ptr&, int) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/table_function/table_function.h:63 11# doris::vectorized::VTableFunctionNode::_get_expanded_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exec/vtable_function_node.cpp:199 ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](table-function) insert default when json array parse failed [doris]
BiteThet commented on PR #25447: URL: https://github.com/apache/doris/pull/25447#issuecomment-1763272288 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](table-function) insert default when json array parse failed [doris]
github-actions[bot] commented on PR #25447: URL: https://github.com/apache/doris/pull/25447#issuecomment-1763273088 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](dynamic) Fix error reporting when dynamic partition properties contain incorrect attributes [doris]
doris-robot commented on PR #25373: URL: https://github.com/apache/doris/pull/25373#issuecomment-1763273858 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.02 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s insert into select: 29.1 seconds inserted 1000 Rows, about 343K ops/s storage size: 17162169335 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](table-function) insert default when json array parse failed [doris]
doris-robot commented on PR #25447: URL: https://github.com/apache/doris/pull/25447#issuecomment-1763278753 TeamCity be ut coverage result: Function Coverage: 36.65% (8230/22456) Line Coverage: 28.79% (65956/229130) Region Coverage: 27.50% (34211/124422) Branch Coverage: 24.20% (17412/71954) Coverage Report: http://coverage.selectdb-in.cc/coverage/43ef5a009c022fa74fd5d08fa96fcccea8ba0c96_43ef5a009c022fa74fd5d08fa96fcccea8ba0c96/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](table-function) insert default when json array parse failed [doris]
doris-robot commented on PR #25447: URL: https://github.com/apache/doris/pull/25447#issuecomment-1763281129 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 49.79 seconds stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.1 seconds inserted 1000 Rows, about 343K ops/s storage size: 17161833258 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
yiguolei commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1763281326 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore](build) Fix compilation errors reported by GCC-13 [doris]
adonis0147 commented on PR #25439: URL: https://github.com/apache/doris/pull/25439#issuecomment-1763285726 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
doris-robot commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1763286209 TeamCity be ut coverage result: Function Coverage: 36.65% (8230/22456) Line Coverage: 28.79% (65961/229130) Region Coverage: 27.50% (34214/124420) Branch Coverage: 24.20% (17413/71952) Coverage Report: http://coverage.selectdb-in.cc/coverage/18863927cf596a770fa207837b0eca555ea44fce_18863927cf596a770fa207837b0eca555ea44fce/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](build) aarch64 compilation fix # [doris]
doris-robot commented on PR #25443: URL: https://github.com/apache/doris/pull/25443#issuecomment-1763287029 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.17 seconds stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s insert into select: 29.5 seconds inserted 1000 Rows, about 338K ops/s storage size: 17162098745 Bytes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](hive)Support hive tables after alter type. [doris]
hubgeter commented on PR #25138: URL: https://github.com/apache/doris/pull/25138#issuecomment-1763295331 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
