[GitHub] [doris] yiguolei merged pull request #22136: [Fix](config) delete unuse lazy open config

2023-07-24 Thread via GitHub


yiguolei merged PR #22136:
URL: https://github.com/apache/doris/pull/22136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [Fix](config) delete unuse lazy open config #22136

2023-07-24 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new e146969376 [Fix](config) delete unuse lazy open config #22136
e146969376 is described below

commit e14696937674d1c9a5b4a341c39ef731cc6b22a4
Author: HHoflittlefish777 <77738092+hhoflittlefish...@users.noreply.github.com>
AuthorDate: Mon Jul 24 15:02:34 2023 +0800

[Fix](config) delete unuse lazy open config #22136
---
 be/src/common/config.cpp | 3 ---
 be/src/common/config.h   | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index fec4662cd4..c727202ce3 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -472,9 +472,6 @@ DEFINE_mInt32(streaming_load_rpc_max_alive_time_sec, 
"1200");
 // the timeout of a rpc to open the tablet writer in remote BE.
 // short operation time, can set a short timeout
 DEFINE_Int32(tablet_writer_open_rpc_timeout_sec, "60");
-// The configuration is used to enable lazy open feature, and the default 
value is false.
-// When there is mixed deployment in the upgraded version, it needs to be set 
to false.
-DEFINE_mBool(enable_lazy_open_partition, "false");
 // You can ignore brpc error '[E1011]The server is overcrowded' when writing 
data.
 DEFINE_mBool(tablet_writer_ignore_eovercrowded, "true");
 DEFINE_mInt32(slave_replica_writer_rpc_timeout_sec, "60");
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 50b391ff4b..05d7fcc658 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -512,9 +512,6 @@ DECLARE_mInt32(streaming_load_rpc_max_alive_time_sec);
 // the timeout of a rpc to open the tablet writer in remote BE.
 // short operation time, can set a short timeout
 DECLARE_Int32(tablet_writer_open_rpc_timeout_sec);
-// The configuration is used to enable lazy open feature, and the default 
value is false.
-// When there is mixed deployment in the upgraded version, it needs to be set 
to false.
-DECLARE_mBool(enable_lazy_open_partition);
 // You can ignore brpc error '[E1011]The server is overcrowded' when writing 
data.
 DECLARE_mBool(tablet_writer_ignore_eovercrowded);
 DECLARE_mInt32(slave_replica_writer_rpc_timeout_sec);


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] CalvinKirs commented on pull request #22148: [Fix](Http)Check and replace user sensitive characters

2023-07-24 Thread via GitHub


CalvinKirs commented on PR #22148:
URL: https://github.com/apache/doris/pull/22148#issuecomment-1647338567

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] dataroaring opened a new pull request, #22149: [enhancement](default_config) change default value of rpc related

2023-07-24 Thread via GitHub


dataroaring opened a new pull request, #22149:
URL: https://github.com/apache/doris/pull/22149

   configs
   
   Bdbje elect timeout is 30 seconds, so we enlarge thrift_rpc_timeout_ms and 
txn_commit_rpc_timeout_ms to 60s.
   
   BTW: enlarge bdbje_lock_timeout_second from 1 to 5.
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] CalvinKirs commented on pull request #22146: [typo](doc) Modify the version supported by the function

2023-07-24 Thread via GitHub


CalvinKirs commented on PR #22146:
URL: https://github.com/apache/doris/pull/22146#issuecomment-1647339395

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22147: [bugfix](auth)fix db is null when table instanceof FunctionGenTable

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22147:
URL: https://github.com/apache/doris/pull/22147#issuecomment-1647344222

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22147: [bugfix](auth)fix db is null when table instanceof FunctionGenTable

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22147:
URL: https://github.com/apache/doris/pull/22147#issuecomment-1647344283

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #21911: [Feature](Export) Supports concurrently export of table data

2023-07-24 Thread via GitHub


hello-stephen commented on PR #21911:
URL: https://github.com/apache/doris/pull/21911#issuecomment-1647344608

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.08 seconds
stream load tsv:  508 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17162946336 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] dataroaring commented on pull request #22149: [enhancement](default_config) change default value of rpc related

2023-07-24 Thread via GitHub


dataroaring commented on PR #22149:
URL: https://github.com/apache/doris/pull/22149#issuecomment-1647347738

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22149: [enhancement](default_config) change default value of rpc related

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22149:
URL: https://github.com/apache/doris/pull/22149#issuecomment-1647349184

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22133: [fix](partial-update) disable partial update when undergoing a schema changing process

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22133:
URL: https://github.com/apache/doris/pull/22133#issuecomment-1647351327

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22133: [fix](partial-update) disable partial update when undergoing a schema changing process

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22133:
URL: https://github.com/apache/doris/pull/22133#issuecomment-1647351376

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22149: [enhancement](default_config) change default value of rpc related

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22149:
URL: https://github.com/apache/doris/pull/22149#issuecomment-1647353255

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Mryange commented on pull request #22047: [feature](executor) using fe version to set instance_num

2023-07-24 Thread via GitHub


Mryange commented on PR #22047:
URL: https://github.com/apache/doris/pull/22047#issuecomment-1647361878

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647363459

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647368055

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow opened a new pull request, #22150: [refactor](Nereids) add sink interface and abstract class

2023-07-24 Thread via GitHub


morrySnow opened a new pull request, #22150:
URL: https://github.com/apache/doris/pull/22150

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   1. add trait Sink
   2. add abstract class LogicalSink and PhysicalSink
   3. replace some sink visitor by visitLogicalSink and visitPhysicalSink
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22047: [feature](executor) using fe version to set instance_num

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22047:
URL: https://github.com/apache/doris/pull/22047#issuecomment-1647370459

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on pull request #22150: [refactor](Nereids) add sink interface and abstract class

2023-07-24 Thread via GitHub


morrySnow commented on PR #22150:
URL: https://github.com/apache/doris/pull/22150#issuecomment-1647371480

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow merged pull request #22034: [refactor](Nereids) push down all non-slot order key in sort and prune them upper sort

2023-07-24 Thread via GitHub


morrySnow merged PR #22034:
URL: https://github.com/apache/doris/pull/22034


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [refactor](Nereids) push down all non-slot order key in sort and prune them upper sort (#22034)

2023-07-24 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new ac9480123c [refactor](Nereids) push down all non-slot order key in 
sort and prune them upper sort (#22034)
ac9480123c is described below

commit ac9480123cc8e073866019f0ea617013f0d46cca
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Mon Jul 24 15:36:33 2023 +0800

[refactor](Nereids) push down all non-slot order key in sort and prune them 
upper sort (#22034)

According the implementation in execution engine, all order keys
in SortNode will be output. We must normalize LogicalSort follow
by it.
We push down all non-slot order key in sort to materialize them
behind sort. So, all order key will be slot and do not need do
projection by SortNode itself.
This will simplify translation of SortNode by avoid to generate
resolvedTupleExprs and sortTupleDesc.
---
 .../main/java/org/apache/doris/analysis/Expr.java  |  10 +
 .../glue/translator/PhysicalPlanTranslator.java| 245 -
 .../doris/nereids/rules/rewrite/NormalizeSort.java |  47 ++--
 .../nereids/trees/plans/logical/LogicalSort.java   |  35 +--
 .../apache/doris/planner/PartitionSortNode.java|  76 +--
 .../java/org/apache/doris/planner/SortNode.java|  28 ---
 .../nereids_tpcds_shape_sf100_p0/shape/query47.out |   4 +-
 .../nereids_tpcds_shape_sf100_p0/shape/query57.out |   4 +-
 8 files changed, 150 insertions(+), 299 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
index 3e1f3943a7..24031bfb89 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
@@ -722,6 +722,16 @@ public abstract class Expr extends TreeNode 
implements ParseNode, Cloneabl
 return false;
 }
 
+public static void extractSlots(Expr root, Set slotIdSet) {
+if (root instanceof SlotRef) {
+slotIdSet.add(((SlotRef) root).getDesc().getId());
+return;
+}
+for (Expr child : root.getChildren()) {
+extractSlots(child, slotIdSet);
+}
+}
+
 /**
  * Returns an analyzed clone of 'this' with exprs substituted according to 
smap.
  * Removes implicit casts and analysis state while cloning/substituting 
exprs within
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
index 0ae104ed5a..d9a8aba8ce 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java
@@ -65,7 +65,6 @@ import 
org.apache.doris.nereids.rules.implementation.LogicalWindowToPhysicalWind
 import org.apache.doris.nereids.stats.StatsErrorEstimator;
 import org.apache.doris.nereids.trees.UnaryNode;
 import org.apache.doris.nereids.trees.expressions.AggregateExpression;
-import org.apache.doris.nereids.trees.expressions.Alias;
 import org.apache.doris.nereids.trees.expressions.CTEId;
 import org.apache.doris.nereids.trees.expressions.EqualTo;
 import org.apache.doris.nereids.trees.expressions.ExprId;
@@ -176,6 +175,7 @@ import com.google.common.collect.ImmutableSet;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Sets;
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -1430,12 +1430,11 @@ public class PhysicalPlanTranslator extends 
DefaultPlanVisitor execExprList = project.getProjects()
+List projectionExprs = project.getProjects()
 .stream()
 .map(e -> ExpressionTranslator.translate(e, context))
 .collect(Collectors.toList());
-// TODO: fix the project alias of an aliased relation.
-List slotList = project.getProjects()
+List slots = project.getProjects()
 .stream()
 .map(NamedExpression::toSlot)
 .collect(Collectors.toList());
@@ -1445,45 +1444,45 @@ public class PhysicalPlanTranslator extends 
DefaultPlanVisitor predicateList = inputPlanNode.getConjuncts();
+List conjuncts = inputPlanNode.getConjuncts();
 Set requiredSlotIdSet = Sets.newHashSet();
-for (Expr expr : execExprList) {
-extractExecSlot(expr, requiredSlotIdSet);
+for (Expr expr : projectionExprs) {
+Expr.extractSlots(expr, requiredSlotIdSet);
 }
 Set requiredByProjectSlotIdSet = 
Sets.newHash

[GitHub] [doris] github-actions[bot] commented on pull request #22134: [fix](Nereids) remove double sigature of ceil, floor and round

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22134:
URL: https://github.com/apache/doris/pull/22134#issuecomment-1647377600

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [fix](inverted index) fix regression case test_index_change_7 occasional failure (#22066)

2023-07-24 Thread jianliangqi
This is an automated email from the ASF dual-hosted git repository.

jianliangqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new d2531db1cf [fix](inverted index) fix regression case 
test_index_change_7 occasional failure (#22066)
d2531db1cf is described below

commit d2531db1cfea319cd0cc3657bac904516bd0bf61
Author: YueW <45946325+tany...@users.noreply.github.com>
AuthorDate: Mon Jul 24 15:39:08 2023 +0800

[fix](inverted index) fix regression case test_index_change_7 occasional 
failure (#22066)
---
 be/src/vec/functions/match.h   | 10 -
 .../index_change/test_index_change_7.groovy| 25 +-
 2 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/be/src/vec/functions/match.h b/be/src/vec/functions/match.h
index 2e1e2d78ae..8f66f7866d 100644
--- a/be/src/vec/functions/match.h
+++ b/be/src/vec/functions/match.h
@@ -129,7 +129,7 @@ public:
 class FunctionMatchElementEQ : public FunctionMatchBase {
 public:
 static constexpr auto name = "match_element_eq";
-static FunctionPtr create() { return 
std::make_shared(); }
+static FunctionPtr create() { return 
std::make_shared(); }
 
 String get_name() const override { return name; }
 
@@ -146,7 +146,7 @@ public:
 class FunctionMatchElementLT : public FunctionMatchBase {
 public:
 static constexpr auto name = "match_element_lt";
-static FunctionPtr create() { return 
std::make_shared(); }
+static FunctionPtr create() { return 
std::make_shared(); }
 
 String get_name() const override { return name; }
 
@@ -163,7 +163,7 @@ public:
 class FunctionMatchElementGT : public FunctionMatchBase {
 public:
 static constexpr auto name = "match_element_gt";
-static FunctionPtr create() { return 
std::make_shared(); }
+static FunctionPtr create() { return 
std::make_shared(); }
 
 String get_name() const override { return name; }
 
@@ -180,7 +180,7 @@ public:
 class FunctionMatchElementLE : public FunctionMatchBase {
 public:
 static constexpr auto name = "match_element_le";
-static FunctionPtr create() { return 
std::make_shared(); }
+static FunctionPtr create() { return 
std::make_shared(); }
 
 String get_name() const override { return name; }
 
@@ -197,7 +197,7 @@ public:
 class FunctionMatchElementGE : public FunctionMatchBase {
 public:
 static constexpr auto name = "match_element_ge";
-static FunctionPtr create() { return 
std::make_shared(); }
+static FunctionPtr create() { return 
std::make_shared(); }
 
 String get_name() const override { return name; }
 
diff --git 
a/regression-test/suites/inverted_index_p0/index_change/test_index_change_7.groovy
 
b/regression-test/suites/inverted_index_p0/index_change/test_index_change_7.groovy
index f26cf6792f..b1cbe7080b 100644
--- 
a/regression-test/suites/inverted_index_p0/index_change/test_index_change_7.groovy
+++ 
b/regression-test/suites/inverted_index_p0/index_change/test_index_change_7.groovy
@@ -105,14 +105,19 @@ suite("test_index_change_7") {
 qt_select17 """ SELECT * FROM ${tableName} t WHERE c_array MATCH 'love' 
ORDER BY id; """
 qt_select18 """ SELECT * FROM ${tableName} t WHERE c_array MATCH 'north' 
ORDER BY id; """
 qt_select19 """ SELECT * FROM ${tableName} t WHERE c_array MATCH 'korea' 
ORDER BY id; """
-qt_select20 """ SELECT * FROM ${tableName} t WHERE int_array element_ge 40 
ORDER BY id; """
-qt_select21 """ SELECT * FROM ${tableName} t WHERE int_array element_le 40 
ORDER BY id; """
-qt_select22 """ SELECT * FROM ${tableName} t WHERE int_array element_gt 40 
ORDER BY id; """
-qt_select23 """ SELECT * FROM ${tableName} t WHERE int_array element_lt 40 
ORDER BY id; """
-qt_select24 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 10 
ORDER BY id; """
-qt_select25 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 20 
ORDER BY id; """
-qt_select26 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 30 
ORDER BY id; """
-qt_select27 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 40 
ORDER BY id; """
-qt_select28 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 50 
ORDER BY id; """
-qt_select29 """ SELECT * FROM ${tableName} t WHERE int_array element_eq 60 
ORDER BY id; """
+
+try {
+qt_select20 """ SELECT * FROM ${tableName} t WHERE int_array 
element_ge 40 ORDER BY id; """
+qt_select21 """ SELECT * FROM ${tableName} t WHERE int_array 
element_le 40 ORDER BY id; """
+qt_select22 """ SELECT * FROM ${tableName} t WHERE int_array 
element_gt 40 ORDER BY id; """
+qt_select23 """ SELECT * FROM ${tableName} t WHERE int_array 
element_lt 40 ORDER BY id; """
+qt_select24 """ SELECT * FROM ${tableName} t WHERE int_array 
element_eq 10 ORDER BY id; """
+qt_select25 """ SELECT * FROM ${tableName} t 

[GitHub] [doris] qidaye merged pull request #22066: [fix](inverted index) fix regression case test_index_change_7 occasional failure

2023-07-24 Thread via GitHub


qidaye merged PR #22066:
URL: https://github.com/apache/doris/pull/22066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] kaijchen opened a new issue, #22151: [Enhancement] Make LRUFileCache test faster

2023-07-24 Thread via GitHub


kaijchen opened a new issue, #22151:
URL: https://github.com/apache/doris/issues/22151

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Description
   
   LRUFileCache test takes about 200s to complete, this is too slow for a unit 
test.
   
   Let's reduce the sleep time in this test.
   
   ```
   [--] 5 tests from LRUFileCache
   [ RUN  ] LRUFileCache.init
   [   OK ] LRUFileCache.init (0 ms)
   [ RUN  ] LRUFileCache.normal
   [   OK ] LRUFileCache.normal (120010 ms)
   [ RUN  ] LRUFileCache.resize
   [   OK ] LRUFileCache.resize (40003 ms)
   [ RUN  ] LRUFileCache.query_limit_heap_use_after_free
   [   OK ] LRUFileCache.query_limit_heap_use_after_free (20001 ms)
   [ RUN  ] LRUFileCache.query_limit_dcheck
   [   OK ] LRUFileCache.query_limit_dcheck (20001 ms)
   [--] 5 tests from LRUFileCache (200016 ms total)
   ```
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] BiteTheDDDDt opened a new pull request, #22152: [Bug](runtime-filter) fix probe expr prepare twice on minmax runtime filter

2023-07-24 Thread via GitHub


BiteThet opened a new pull request, #22152:
URL: https://github.com/apache/doris/pull/22152

   ## Proposed changes
   fix probe expr prepare twice on minmax runtime filter
   
   ```cpp
   0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, 
siginfo_t*, void*) at 
/home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:413
1# 0x7F8F52477090 in /lib/x86_64-linux-gnu/libc.so.6
2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
4# 0x564C7F098FD9 in /mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
5# 0x564C7F08E5ED in /mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
6# google::LogMessage::SendToLog() in 
/mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
7# google::LogMessage::Flush() in 
/mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
8# google::LogMessageFatal::~LogMessageFatal() in 
/mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
9# doris::vectorized::VExprContext::fn_context(int) at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vexpr_context.h:64
   10# 
doris::vectorized::VExpr::init_function_context(doris::vectorized::VExprContext*,
 doris::FunctionContext::FunctionStateScope, std::shared_ptr const&) const at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vexpr.cpp:410
   11# doris::vectorized::VCastExpr::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vcast_expr.cpp:85
   12# doris::vectorized::VExpr::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vexpr.cpp:115
   13# doris::vectorized::VCaseExpr::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vcase_expr.cpp:82
   14# doris::vectorized::VExpr::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at /home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vexpr.cpp:115
   15# doris::vectorized::VectorizedFnCall::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vectorized_fn_call.cpp:124
   16# doris::vectorized::VRuntimeFilterWrapper::open(doris::RuntimeState*, 
doris::vectorized::VExprContext*, doris::FunctionContext::FunctionStateScope) 
at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exprs/vruntimefilter_wrapper.cpp:66
   17# doris::vectorized::VExprContext::open(doris::RuntimeState*) in 
/mnt/ssd01/doris-master/VEC_UBSAN/be/lib/doris_be
   18# 
doris::vectorized::RuntimeFilterConsumer::_append_rf_into_conjuncts(std::vector,
 std::allocator > > const&) at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exec/runtime_filter_consumer.cpp:124
   19# doris::vectorized::RuntimeFilterConsumer::_acquire_runtime_filter() at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exec/runtime_filter_consumer.cpp:108
   20# doris::vectorized::VScanNode::alloc_resource(doris::RuntimeState*) at 
/home/zcp/repo_center/doris_master/doris/be/src/vec/exec/scan/vscan_node.cpp:171
   21# doris::pipeline::StreamingOperator::open(doris::RuntimeState*) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/exec/operator.h:332
   22# doris::pipeline::PipelineTask::_open() at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_task.cpp:179
   23# doris::pipeline::PipelineTask::execute(bool*) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/pipeline_task.cpp:208
   24# doris::pipeline::TaskScheduler::_do_work(unsigned long) at 
/home/zcp/repo_center/doris_master/doris/be/src/pipeline/task_scheduler.cpp:275
   25# void std::__invoke_impl(std::__invoke_memfun_deref, void 
(doris::pipeline::TaskScheduler::*&)(unsigned long), 
doris::pipeline::TaskScheduler*&, unsigned long&) at 
/var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:74
   26# std::__invoke_result::type std::__invoke(void 
(doris::pipeline::TaskScheduler::*&)(unsigned long), 
doris::pipeline::TaskScheduler*&, unsigned long&) at 
/var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96
   27# void std::_Bind::__call(std::tuple<>&&, std::_Index_tuple<0ul, 1ul>) at 
/var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:420
   28# void std::_Bind::operator()<, void>() at 
/var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/functional:503
   29# void std::__invoke_impl&>(std::__invoke_other, std::_Bind&) at 
/var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:

[GitHub] [doris] BiteTheDDDDt commented on pull request #22152: [Bug](runtime-filter) fix probe expr prepared twice on minmax runtime filter

2023-07-24 Thread via GitHub


BiteThet commented on PR #22152:
URL: https://github.com/apache/doris/pull/22152#issuecomment-1647401639

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow opened a new pull request, #22153: [fix](Nereids) forbid gather sort with explict shuffle

2023-07-24 Thread via GitHub


morrySnow opened a new pull request, #22153:
URL: https://github.com/apache/doris/pull/22153

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Yukang-Lian opened a new pull request, #22154: [Fix](MoW) Fix dup key when do schema change add new key

2023-07-24 Thread via GitHub


Yukang-Lian opened a new pull request, #22154:
URL: https://github.com/apache/doris/pull/22154

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 commented on pull request #21940: [Bug](pipeline) fix pipeline shared scan + topn optimization

2023-07-24 Thread via GitHub


Gabriel39 commented on PR #21940:
URL: https://github.com/apache/doris/pull/21940#issuecomment-1647410757

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Yukang-Lian commented on pull request #22154: [Fix](MoW) Fix dup key when do schema change add new key

2023-07-24 Thread via GitHub


Yukang-Lian commented on PR #22154:
URL: https://github.com/apache/doris/pull/22154#issuecomment-1647411034

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22152: [Bug](runtime-filter) fix probe expr prepared twice on minmax runtime filter

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22152:
URL: https://github.com/apache/doris/pull/22152#issuecomment-1647413483

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zxealous opened a new pull request, #22155: [improvement](case function) add check to avoid stack overflow

2023-07-24 Thread via GitHub


zxealous opened a new pull request, #22155:
URL: https://github.com/apache/doris/pull/22155

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   add check for batch size, some operators batch size may be exceeding 4096, 
so we added some tolerance to check 65536 to prevent stack overflow.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow merged pull request #22134: [fix](Nereids) remove double sigature of ceil, floor and round

2023-07-24 Thread via GitHub


morrySnow merged PR #22134:
URL: https://github.com/apache/doris/pull/22134


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated (d2531db1cf -> 21deb57a4d)

2023-07-24 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from d2531db1cf [fix](inverted index) fix regression case 
test_index_change_7 occasional failure (#22066)
 add 21deb57a4d [fix](Nereids) remove double sigature of ceil, floor and 
round (#22134)

No new revisions were added by this update.

Summary of changes:
 .../trees/expressions/functions/scalar/Ceil.java   |   2 -
 .../trees/expressions/functions/scalar/Dceil.java  |   2 -
 .../trees/expressions/functions/scalar/Dfloor.java |   2 -
 .../trees/expressions/functions/scalar/Dround.java |   3 -
 .../trees/expressions/functions/scalar/Floor.java  |   2 -
 .../trees/expressions/functions/scalar/Round.java  |   3 -
 .../expressions/functions/scalar/RoundBankers.java |   3 -
 .../expressions/functions/scalar/Truncate.java |   2 -
 .../doris/nereids/trees/expressions/UdfTest.java   |   9 +-
 .../data/nereids_function_p0/scalar_function/D.out | 200 ++---
 .../data/nereids_function_p0/scalar_function/R.out | 192 ++--
 .../sql_functions/math_functions/test_round.out|  13 +-
 12 files changed, 208 insertions(+), 225 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zxealous commented on pull request #22155: [improvement](case function) add check to avoid stack overflow

2023-07-24 Thread via GitHub


zxealous commented on PR #22155:
URL: https://github.com/apache/doris/pull/22155#issuecomment-1647419979

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] caiconghui commented on a diff in pull request #21996: [Enhance](Publish) improve publish version performance

2023-07-24 Thread via GitHub


caiconghui commented on code in PR #21996:
URL: https://github.com/apache/doris/pull/21996#discussion_r1271897612


##
fe/fe-core/src/main/java/org/apache/doris/catalog/Table.java:
##
@@ -162,11 +162,15 @@ public boolean tryReadLock(long timeout, TimeUnit unit) {
 }
 
 public void readUnlock() {
+long nanoTime = System.nanoTime();
 this.rwLock.readLock().unlock();
+LOG.debug("table {} get read lock spent {} ms", getId(), (nanoTime - 
System.nanoTime()) / 100L);

Review Comment:
   should not  add time cost caculate here? especial for doris release version? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21940: [Bug](pipeline) fix pipeline shared scan + topn optimization

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21940:
URL: https://github.com/apache/doris/pull/21940#issuecomment-1647423182

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22148: [Fix](Http)Check and replace user sensitive characters

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22148:
URL: https://github.com/apache/doris/pull/22148#issuecomment-1647423646

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.08 seconds
stream load tsv:  510 seconds loaded 74807831229 Bytes, about 139 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.2 seconds inserted 1000 Rows, about 
342K ops/s
storage size: 17168663163 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22154: [Fix](MoW) Fix dup key when do schema change add new key

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22154:
URL: https://github.com/apache/doris/pull/22154#issuecomment-1647422714

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22149: [enhancement](default_config) change default value of rpc related

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22149:
URL: https://github.com/apache/doris/pull/22149#issuecomment-1647424153

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.8 seconds
stream load tsv:  509 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17162262473 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] airborne12 commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


airborne12 commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647424854

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22155: [improvement](case function) add check to avoid stack overflow

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22155:
URL: https://github.com/apache/doris/pull/22155#issuecomment-1647425638

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris-thirdparty] qidaye merged pull request #103: [improvement](invert index) Added lucene9.5 standard tokenizer

2023-07-24 Thread via GitHub


qidaye merged PR #103:
URL: https://github.com/apache/doris-thirdparty/pull/103


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647436251

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on pull request #22153: [fix](Nereids) forbid gather sort with explict shuffle

2023-07-24 Thread via GitHub


morrySnow commented on PR #22153:
URL: https://github.com/apache/doris/pull/22153#issuecomment-1647448200

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow commented on a diff in pull request #21903: [fix](nereids) Fix analytic expr

2023-07-24 Thread via GitHub


morrySnow commented on code in PR #21903:
URL: https://github.com/apache/doris/pull/21903#discussion_r1271921140


##
fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java:
##
@@ -700,10 +700,10 @@ private void standardize(Analyzer analyzer) throws 
AnalysisException {
 + 
getFnCall().getChildren().get(0).getType());
 }
 
-if (getFnCall().getChildren().get(2) instanceof CastExpr) {
-throw new AnalysisException("Type = " + type + " can't not 
convert to "
-+ 
getFnCall().getChildren().get(0).getType());
-}
+// if (getFnCall().getChildren().get(2) instanceof CastExpr) {
+// throw new AnalysisException("Type = " + type + " can't not 
convert to "
+// + 
getFnCall().getChildren().get(0).getType());
+// }

Review Comment:
   just remove it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] KassieZ closed pull request #21872: [Docs](Catalog) Optimize the documentation catalog and add the Join Our Community Documentation

2023-07-24 Thread via GitHub


KassieZ closed pull request #21872: [Docs](Catalog) Optimize the documentation 
catalog and add the Join Our Community Documentation
URL: https://github.com/apache/doris/pull/21872


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] caiconghui commented on a diff in pull request #21996: [Enhance](Publish) improve publish version performance

2023-07-24 Thread via GitHub


caiconghui commented on code in PR #21996:
URL: https://github.com/apache/doris/pull/21996#discussion_r1271924309


##
fe/fe-core/src/main/java/org/apache/doris/common/util/Daemon.java:
##
@@ -98,10 +98,18 @@ public void setInterval(long intervalMs) {
 this.intervalMs = intervalMs;
 }
 
+public boolean isStop() {
+return isStop.get();
+}
+
+public boolean isStart() {
+return isStart.get();
+}
+
 /**
  * implement in child
  */
-protected void runOneCycle() {
+protected void runOneCycle() throws Exception {

Review Comment:
   why add thorw exception declaration here 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris-thirdparty] zzzxl1993 opened a new pull request, #104: [improvement](invert index) chinese word cutall does not cut english and numbers

2023-07-24 Thread via GitHub


zzzxl1993 opened a new pull request, #104:
URL: https://github.com/apache/doris-thirdparty/pull/104

   1. Only the cutall mode is supported
   
   "昨天我参加了一个编程比赛,遇到了一位技术很棒的朋友。His name is 
David,他今年28岁,电话号码是135。David来自美国,他的邮箱是da...@gmail.com。编程比赛持续了2个小时,最后David赢得了冠军。虽然我只得了第三名,但我学到了很多编程技巧。David给我推荐了一个学习编程的网站
 www.codingforeveryone.com,这个网站包含许多免费的在线课程。我们都觉得这个网站很有用,可以提高编程技能。After the 
contest, David and I exchanged contacts. 
我给David我的身份证号码1234891987654321作为联系方式。我相信通过我的努力,我的编程水平一定会越来越好。这次参加比赛让我结交了一位知音好友,也激励了我不断学习进步。赛扬1.7
 微星845E >硬盘40G 内存256想是HY的 ATI9000 想换主机或升级,如果要升级先换主板和CPU,卖了能卖多少,我想买台AMD3800+ 939 
双核 主版要好的700以下,硬盘是麦拓
 200G,8M的,>内存用威刚512M 机箱用一般的200以下,电源用350W的,我还需要多少钱"
   
   
昨天|参加|一个|编程|比赛|遇到|一位|技术|很棒|朋友|His|David|今年|28|岁|电话|电话号码|号码|135|David|美国|邮箱|david|gmail|com|编程|比赛|持续|小时|最后|David|赢得|冠军|只得|第三|第三名|三名|学到|很多|编程|技巧|David|推荐|一个|学习|编程|网站|www|codingforeveryone|com|网站|包含|免费|在线|课程|觉得|网站|有用|提高|编程|技能|After|contest|David|exchanged|contacts|David|身份|身份证|身份证号|证号|证号码|号码|1234891987654321|联系|联系方式|方式|相信|信通|努力|编程|水平|平一|一定|定会|越来|越来越|越好|参加|加比|比赛|结交|一位|知音|好友|激励|不断|学习|进步|赛扬|微星|845|E|硬盘|40|G|内存|256|想|HY|ATI|9000|想|换|主机|升级|升级|先|换|主板|CPU|卖|卖|想买|台|AMD|3800|939|双核|主|版|700|以下|硬盘|麦|拓|200|G|M|内存|威|刚|512|M|机箱|200|以下|电源|350|W|需要|多少钱|
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] caiconghui commented on a diff in pull request #21996: [Enhance](Publish) improve publish version performance

2023-07-24 Thread via GitHub


caiconghui commented on code in PR #21996:
URL: https://github.com/apache/doris/pull/21996#discussion_r1271925053


##
fe/fe-core/src/main/java/org/apache/doris/common/util/Daemon.java:
##
@@ -98,10 +98,18 @@ public void setInterval(long intervalMs) {
 this.intervalMs = intervalMs;
 }
 
+public boolean isStop() {
+return isStop.get();
+}
+

Review Comment:
   where to use it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] starocean999 merged pull request #22054: [fix](planner)push conjuncts into inlineview

2023-07-24 Thread via GitHub


starocean999 merged PR #22054:
URL: https://github.com/apache/doris/pull/22054


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch branch-1.2-lts updated: [fix](planner)push conjuncts into inlineview (#22054)

2023-07-24 Thread starocean999
This is an automated email from the ASF dual-hosted git repository.

starocean999 pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
 new bd45f778a4 [fix](planner)push conjuncts into inlineview (#22054)
bd45f778a4 is described below

commit bd45f778a4e0d6370a1bc94637c0c62309463498
Author: starocean999 <40539150+starocean...@users.noreply.github.com>
AuthorDate: Mon Jul 24 16:33:15 2023 +0800

[fix](planner)push conjuncts into inlineview (#22054)

* [fix](planner)push conjuncts into inlineview
---
 .../java/org/apache/doris/analysis/Analyzer.java   | 11 +
 .../apache/doris/planner/SingleNodePlanner.java| 27 ++
 2 files changed, 30 insertions(+), 8 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
index 7fad314167..11032bcb7d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
@@ -43,6 +43,7 @@ import org.apache.doris.common.util.TimeUtils;
 import org.apache.doris.common.util.VectorizedUtil;
 import org.apache.doris.external.hudi.HudiTable;
 import org.apache.doris.external.hudi.HudiUtils;
+import org.apache.doris.planner.AggregationNode;
 import org.apache.doris.planner.PlanNode;
 import org.apache.doris.planner.RuntimeFilter;
 import org.apache.doris.qe.ConnectContext;
@@ -1868,7 +1869,7 @@ public class Analyzer {
 // aliases and having it analyzed is needed for the 
following EvalPredicate() call
 conjunct.analyze(this);
 }
-Expr newConjunct = conjunct.getResultValue(true);
+Expr newConjunct = conjunct.clone().getResultValue(true);
 newConjunct = FoldConstantsRule.INSTANCE.apply(newConjunct, 
this, null);
 if (newConjunct instanceof BoolLiteral || newConjunct 
instanceof NullLiteral) {
 boolean evalResult = true;
@@ -2425,10 +2426,12 @@ public class Analyzer {
  * Wrapper around getUnassignedConjuncts(List tupleIds).
  */
 public List getUnassignedConjuncts(PlanNode node) {
-// constant conjuncts should be push down to all leaf node.
+// constant conjuncts should be push down to all leaf node except agg 
node.
+// (see getPredicatesBoundedByGroupbysSourceExpr method)
 // so we need remove constant conjuncts when expr is not a leaf node.
-List unassigned = getUnassignedConjuncts(node.getTblRefIds());
-if (!node.getChildren().isEmpty()) {
+List unassigned = getUnassignedConjuncts(
+node instanceof AggregationNode ? node.getTupleIds() : 
node.getTblRefIds());
+if (!node.getChildren().isEmpty() && !(node instanceof 
AggregationNode)) {
 unassigned = unassigned.stream()
 .filter(e -> !e.isConstant()).collect(Collectors.toList());
 }
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java 
b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
index a145b6e9f1..27c01dd03b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
@@ -21,6 +21,7 @@
 package org.apache.doris.planner;
 
 import org.apache.doris.analysis.AggregateInfo;
+import org.apache.doris.analysis.AnalyticExpr;
 import org.apache.doris.analysis.AnalyticInfo;
 import org.apache.doris.analysis.Analyzer;
 import org.apache.doris.analysis.AssertNumRowsElement;
@@ -264,6 +265,13 @@ public class SingleNodePlanner {
 AggregateInfo aggInfo = selectStmt.getAggInfo();
 root = analyticPlanner.createSingleNodePlan(root,
 aggInfo != null ? aggInfo.getGroupingExprs() : null, 
inputPartitionExprs);
+List predicates = getBoundPredicates(analyzer,
+selectStmt.getAnalyticInfo().getOutputTupleDesc());
+if (!predicates.isEmpty()) {
+root = new SelectNode(ctx.getNextNodeId(), root, 
predicates);
+root.init(analyzer);
+Preconditions.checkState(root.hasValidStats());
+}
 if (aggInfo != null && !inputPartitionExprs.isEmpty()) {
 // analytic computation will benefit from a partition on 
inputPartitionExprs
 aggInfo.setPartitionExprs(inputPartitionExprs);
@@ -1782,7 +1790,6 @@ public class SingleNodePlanner {
 e.setIsOnClauseConjunct(false);
 }
 inlineViewRef.getAnalyzer().registerConjuncts(viewPredicates, 
inlineViewRef.getAllTupleIds());
-
 // mark (fully resolve) slots referenced by remaining

[GitHub] [doris] caiconghui commented on a diff in pull request #21996: [Enhance](Publish) improve publish version performance

2023-07-24 Thread via GitHub


caiconghui commented on code in PR #21996:
URL: https://github.com/apache/doris/pull/21996#discussion_r1271925998


##
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##
@@ -1088,7 +1099,12 @@ protected void 
unprotectedCommitTransaction2PC(TransactionState transactionState
 return;
 }
 // update transaction state version
-transactionState.setCommitTime(System.currentTimeMillis());
+long commitTime = System.currentTimeMillis();
+if (preCommitTime == commitTime || preCommitTime == 0) {
+commitTime += 1;
+}
+preCommitTime = commitTime;
+transactionState.setCommitTime(commitTime);

Review Comment:
   why add preCommitTime logic?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22126: (enhancement)(config) Enlarge broker scanner bytes conf to 50G, 5G is still not enough

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22126:
URL: https://github.com/apache/doris/pull/22126#issuecomment-1647462918

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] XieJiann commented on a diff in pull request #21747: [improvement](nereids)dphyper GraphSimplifier should consider missed edges when estimating join cost

2023-07-24 Thread via GitHub


XieJiann commented on code in PR #21747:
URL: https://github.com/apache/doris/pull/21747#discussion_r1264815211


##
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/joinorder/hypergraph/GraphSimplifier.java:
##
@@ -381,12 +385,40 @@ Pair threeRightJoin(long bitmap1, Edge 
edge1, long bitmap2, Ed
 return Pair.of(joinStats, edge);
 }
 
+private Edge processMissedEdges(int edgeIndex1, int edgeIndex2, Edge edge) 
{
+List edges = Lists.newArrayList(edge);
+edges.addAll(graph.getEdges().stream()
+.filter(e -> e.getIndex() != edgeIndex1 && e.getIndex() != 
edgeIndex2

Review Comment:
   This function needs to test all edges. The time complexity is turned from 
O(n^2) into O(n^3). Does it affect the time of the graph simplified?  Or cache 
the missed edge?



##
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Group.java:
##
@@ -378,10 +379,15 @@ public boolean isInnerJoinGroup() {
 Plan plan = getLogicalExpression().getPlan();
 if (plan instanceof LogicalJoin
 && ((LogicalJoin) plan).getJoinType() == JoinType.INNER_JOIN) {
-// Right now, we only support inner join
 Preconditions.checkArgument(!((LogicalJoin) 
plan).getExpressions().isEmpty(),
 "inner join must have join conjuncts");
-return true;
+if (((LogicalJoin) plan).getHashJoinConjuncts().isEmpty()
+&& ((LogicalJoin) plan).getOtherJoinConjuncts().get(0) 
instanceof Literal) {
+return false;
+} else {
+// Right now, we only support inner join with some conjuncts 
referencing any side of the child's output
+return true;
+}

Review Comment:
   The else is redundant. The follow format is better
   ```
   if (xxx) {
  return true;
   }
   return false;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morrySnow merged pull request #21626: [enhancement](Nereids) check multiple distinct functions that cannot be transformed into muti_distinct

2023-07-24 Thread via GitHub


morrySnow merged PR #21626:
URL: https://github.com/apache/doris/pull/21626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [opt](Nereids) check multiple distinct functions that cannot be transformed into muti_distinct (#21626)

2023-07-24 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository.

morrysnow pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 68bd4a1a96 [opt](Nereids) check multiple distinct functions that 
cannot be transformed into muti_distinct (#21626)
68bd4a1a96 is described below

commit 68bd4a1a96b988fab31ffc3a1aeeda831347e1bd
Author: 谢健 
AuthorDate: Mon Jul 24 16:34:17 2023 +0800

[opt](Nereids) check multiple distinct functions that cannot be transformed 
into muti_distinct (#21626)

This commit introduces a transformation for SQL queries that contain 
multiple distinct aggregate functions. When the number of distinct values 
processed by these functions is greater than 1, they are converted into 
multi_distinct functions for more efficient handling.

Example:
```
SELECT COUNT(DISTINCT c1), SUM(DISTINCT c2) FROM tbl GROUP BY c3
-- Transformed to
SELECT MULTI_DISTINCT_COUNT(c1), MULTI_DISTINCT_SUM(c2) FROM tbl GROUP BY c3
```

The following functions can be transformed:
- COUNT
- SUM
- AVG
- GROUP_CONCAT

If any unsupported functions are encountered, an error is now reported 
during the optimization phase.

To ensure the absence of such cases, a final check has been implemented 
after the rewriting phase.
---
 .../doris/nereids/jobs/executor/Rewriter.java  |  2 +
 .../nereids/rules/rewrite/CheckMultiDistinct.java  | 62 ++
 .../suites/nereids_syntax_p0/analyze_agg.groovy|  5 ++
 3 files changed, 69 insertions(+)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
index 3fb3208e5e..8e2f0260bb 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java
@@ -40,6 +40,7 @@ import org.apache.doris.nereids.rules.rewrite.CTEInline;
 import 
org.apache.doris.nereids.rules.rewrite.CheckAndStandardizeWindowFunctionAndFrame;
 import org.apache.doris.nereids.rules.rewrite.CheckDataTypes;
 import org.apache.doris.nereids.rules.rewrite.CheckMatchExpression;
+import org.apache.doris.nereids.rules.rewrite.CheckMultiDistinct;
 import org.apache.doris.nereids.rules.rewrite.CollectFilterAboveConsumer;
 import org.apache.doris.nereids.rules.rewrite.CollectProjectAboveConsumer;
 import org.apache.doris.nereids.rules.rewrite.ColumnPruning;
@@ -291,6 +292,7 @@ public class Rewriter extends AbstractBatchJobExecutor {
 bottomUp(
 new 
ExpressionRewrite(CheckLegalityAfterRewrite.INSTANCE),
 new CheckMatchExpression(),
+new CheckMultiDistinct(),
 new CheckAfterRewrite()
 )
 ),
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CheckMultiDistinct.java
 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CheckMultiDistinct.java
new file mode 100644
index 00..4488a94b8d
--- /dev/null
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CheckMultiDistinct.java
@@ -0,0 +1,62 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite;
+
+import org.apache.doris.nereids.exceptions.AnalysisException;
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import 
org.apache.doris.nereids.trees.expressions.functions.agg.AggregateFunction;
+import org.apache.doris.nereids.trees.expressions.functions.agg.Avg;
+import org.apache.doris.nereids.trees.expressions.functions.agg.Count;
+import org.apache.doris.nereids.trees.expressions.functions.agg.GroupConcat;
+import org.apache.doris.nereids.trees.expressions.functions.agg.Sum;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate;
+
+import com.google.common.collect.ImmutableSet;
+
+/**
+ * If there are multiple 

[GitHub] [doris] hello-stephen commented on pull request #21940: [Bug](pipeline) fix pipeline shared scan + topn optimization

2023-07-24 Thread via GitHub


hello-stephen commented on PR #21940:
URL: https://github.com/apache/doris/pull/21940#issuecomment-1647469432

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.97 seconds
stream load tsv:  506 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.9 seconds inserted 1000 Rows, about 
334K ops/s
storage size: 17163636030 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22154: [Fix](MoW) Fix dup key when do schema change add new key

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22154:
URL: https://github.com/apache/doris/pull/22154#issuecomment-1647469672

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.02 seconds
stream load tsv:  505 seconds loaded 74807831229 Bytes, about 141 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.2 seconds inserted 1000 Rows, about 
342K ops/s
storage size: 17170510428 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22155: [improvement](case function) add check to avoid stack overflow

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22155:
URL: https://github.com/apache/doris/pull/22155#issuecomment-1647473625

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.72 seconds
stream load tsv:  515 seconds loaded 74807831229 Bytes, about 138 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17167461293 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22047: [feature](executor) using fe version to set instance_num

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22047:
URL: https://github.com/apache/doris/pull/22047#issuecomment-1647474348

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.68 seconds
stream load tsv:  508 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.4 seconds inserted 1000 Rows, about 
340K ops/s
storage size: 17162057178 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22150: [refactor](Nereids) add sink interface and abstract class

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22150:
URL: https://github.com/apache/doris/pull/22150#issuecomment-1647474601

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.78 seconds
stream load tsv:  509 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.1 seconds inserted 1000 Rows, about 
343K ops/s
storage size: 17169941759 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647475863

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21813: [Feature](inverted index) add tokenize function for inverted index

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21813:
URL: https://github.com/apache/doris/pull/21813#issuecomment-1647475926

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] LiBinfeng-01 commented on pull request #22145: [Fix](Nereids) Fix problem of infer predicates not completely

2023-07-24 Thread via GitHub


LiBinfeng-01 commented on PR #22145:
URL: https://github.com/apache/doris/pull/22145#issuecomment-1647476070

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] englefly opened a new pull request, #22156: [stats](nereids)in predicate range adjust

2023-07-24 Thread via GitHub


englefly opened a new pull request, #22156:
URL: https://github.com/apache/doris/pull/22156

   ## Proposed changes
   A in (1, 2, 3, 4)
   after in-preidcate filter, A.stats.max<=4 and A.stats.min>=1
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] KassieZ opened a new pull request, #22157: [Docs](docs) Rename Release Note Title and File name of CN & EN Version

2023-07-24 Thread via GitHub


KassieZ opened a new pull request, #22157:
URL: https://github.com/apache/doris/pull/22157

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] englefly commented on pull request #22156: [stats](nereids)in predicate range adjust

2023-07-24 Thread via GitHub


englefly commented on PR #22156:
URL: https://github.com/apache/doris/pull/22156#issuecomment-1647477215

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] KassieZ commented on pull request #22157: [Docs](docs) Rename Release Note Title and File name of CN & EN Version

2023-07-24 Thread via GitHub


KassieZ commented on PR #22157:
URL: https://github.com/apache/doris/pull/22157#issuecomment-1647477655

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] jixxiong opened a new pull request, #22158: [improvement](stream-load) add http request field check for stream load in BE

2023-07-24 Thread via GitHub


jixxiong opened a new pull request, #22158:
URL: https://github.com/apache/doris/pull/22158

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   As the title, we add http request field check for stream load in BE.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22154: [Fix](MoW) Fix dup key when do schema change add new key

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22154:
URL: https://github.com/apache/doris/pull/22154#issuecomment-1647480293

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] csun5285 opened a new pull request, #22159: [improvement](compaction) Configuring compaction policy and options in the properties of a table

2023-07-24 Thread via GitHub


csun5285 opened a new pull request, #22159:
URL: https://github.com/apache/doris/pull/22159

   ## Proposed changes
   
   Now, there were two global compaction policies available: "size_based" and 
"time_series". The compaction policy can be specified during table creation.
   
   ``` 
   CREATE TABLE IF NOT EXISTS example_db.example_tbl
   (
   `user_id` LARGEINT NOT NULL,
   `date` DATE NOT NULL,
   `city` VARCHAR(20),
   `age` SMALLINT,
   )
   DUPLICATE KEY(`user_id`)
   DISTRIBUTED BY HASH(`user_id`) BUCKETS 1
   PROPERTIES (
   "replication_allocation" = "tag.location.default: 1"
   "compaction_policy"="time_series",
   "time_series_compaction_goal_size_mbyte"="1024"
   );
   
   ```
   
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22152: [Bug](runtime-filter) fix probe expr prepared twice on minmax runtime filter

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22152:
URL: https://github.com/apache/doris/pull/22152#issuecomment-1647490786

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.24 seconds
stream load tsv:  507 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.0 seconds inserted 1000 Rows, about 
344K ops/s
storage size: 17162254269 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] vinlee19 opened a new pull request, #22160: [type](docs) add jdbc catalog error handling methods

2023-07-24 Thread via GitHub


vinlee19 opened a new pull request, #22160:
URL: https://github.com/apache/doris/pull/22160

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22158: [improvement](stream-load) add http request field check for stream load in BE

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22158:
URL: https://github.com/apache/doris/pull/22158#issuecomment-1647492593

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22159: [improvement](compaction) Configuring compaction policy and options in the properties of a table

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22159:
URL: https://github.com/apache/doris/pull/22159#issuecomment-1647493243

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] chenchurong opened a new issue, #22161: [Bug]

2023-07-24 Thread via GitHub


chenchurong opened a new issue, #22161:
URL: https://github.com/apache/doris/issues/22161

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Version
   
   2.0-beta (Latest)
   
   ### What's Wrong?
   
   can not executeQuery by jdbc statement when i use [inverted index]
   
   **i guess mysql driver can not Adapter  fuction match_all or match_any**
   
   
   ![Uploading image.png…]()
   
   
   ### What You Expected?
   
   get result by query sql
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22158: [improvement](stream-load) add http request field check for stream load in BE

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22158:
URL: https://github.com/apache/doris/pull/22158#issuecomment-1647504526

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22153: [fix](Nereids) forbid gather sort with explict shuffle

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22153:
URL: https://github.com/apache/doris/pull/22153#issuecomment-1647506353

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv:  504 seconds loaded 74807831229 Bytes, about 141 
MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.3 seconds inserted 1000 Rows, about 
341K ops/s
storage size: 17165677132 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] csun5285 closed pull request #20920: [improvement](compaction) Support for configuring the compaction policy during table creation

2023-07-24 Thread via GitHub


csun5285 closed pull request #20920: [improvement](compaction) Support for 
configuring the compaction policy during table creation
URL: https://github.com/apache/doris/pull/20920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22145: [Fix](Nereids) Fix problem of infer predicates not completely

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22145:
URL: https://github.com/apache/doris/pull/22145#issuecomment-1647520964

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.93 seconds
stream load tsv:  506 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  32 seconds loaded 861443392 Bytes, about 25 
MB/s
insert into select:  29.5 seconds inserted 1000 Rows, about 
338K ops/s
storage size: 17168571999 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] hello-stephen commented on pull request #22156: [stats](nereids)in predicate range adjust

2023-07-24 Thread via GitHub


hello-stephen commented on PR #22156:
URL: https://github.com/apache/doris/pull/22156#issuecomment-1647521868

   (From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.08 seconds
stream load tsv:  509 seconds loaded 74807831229 Bytes, about 140 
MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc:  65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 
MB/s
insert into select:  29.5 seconds inserted 1000 Rows, about 
338K ops/s
storage size: 17169824336 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22138: [round](decimalv2) round decimalv2 to precision value

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22138:
URL: https://github.com/apache/doris/pull/22138#issuecomment-1647534742

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22158: [improvement](stream-load) add http request field check for stream load in BE

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22158:
URL: https://github.com/apache/doris/pull/22158#issuecomment-1647547242

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zenoyang commented on pull request #21888: [improvement](vectorized) Deserialized elements of count distinct aggregation directly inserted into target hashset

2023-07-24 Thread via GitHub


zenoyang commented on PR #21888:
URL: https://github.com/apache/doris/pull/21888#issuecomment-1647550202

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21888: [improvement](vectorized) Deserialized elements of count distinct aggregation directly inserted into target hashset

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21888:
URL: https://github.com/apache/doris/pull/21888#issuecomment-1647554273

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22158: [improvement](stream-load) add http request field check for stream load in BE

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22158:
URL: https://github.com/apache/doris/pull/22158#issuecomment-1647556109

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22138: [round](decimalv2) round decimalv2 to precision value

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22138:
URL: https://github.com/apache/doris/pull/22138#issuecomment-1647556822

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zxealous commented on pull request #22155: [improvement](case function) add check to avoid stack overflow

2023-07-24 Thread via GitHub


zxealous commented on PR #22155:
URL: https://github.com/apache/doris/pull/22155#issuecomment-1647558701

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #21888: [improvement](vectorized) Deserialized elements of count distinct aggregation directly inserted into target hashset

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #21888:
URL: https://github.com/apache/doris/pull/21888#issuecomment-1647558818

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 opened a new pull request, #22162: Pick round decimalv2

2023-07-24 Thread via GitHub


Gabriel39 opened a new pull request, #22162:
URL: https://github.com/apache/doris/pull/22162

   ## Proposed changes
   
   pick #22138
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #20866: [WIP](vertical compaction) fix vertical compaction core

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #20866:
URL: https://github.com/apache/doris/pull/20866#issuecomment-1647568947

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 closed pull request #19485: [refactor](scan) refactor scan node on pipeline engine

2023-07-24 Thread via GitHub


Gabriel39 closed pull request #19485: [refactor](scan) refactor scan node on 
pipeline engine
URL: https://github.com/apache/doris/pull/19485


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 closed pull request #17867: [Improvement](agg) use adaptive string hash map for small string columns

2023-07-24 Thread via GitHub


Gabriel39 closed pull request #17867: [Improvement](agg) use adaptive string 
hash map for small string columns
URL: https://github.com/apache/doris/pull/17867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 closed pull request #18890: [refactor](conf) delete enable_local_exchange and set it to true

2023-07-24 Thread via GitHub


Gabriel39 closed pull request #18890: [refactor](conf) delete 
enable_local_exchange and set it to true
URL: https://github.com/apache/doris/pull/18890


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #22138: [round](decimalv2) round decimalv2 to precision value

2023-07-24 Thread via GitHub


github-actions[bot] commented on PR #22138:
URL: https://github.com/apache/doris/pull/22138#issuecomment-1647576701

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] eldenmoon opened a new pull request, #22163: [Improve](topn opt) modify fetch rpc timeout from 20s to 30s, since f…

2023-07-24 Thread via GitHub


eldenmoon opened a new pull request, #22163:
URL: https://github.com/apache/doris/pull/22163

   …etch is quite heavy sometimes
   
   and add more logs
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] eldenmoon commented on pull request #22163: [Improve](topn opt) modify fetch rpc timeout from 20s to 30s, since f…

2023-07-24 Thread via GitHub


eldenmoon commented on PR #22163:
URL: https://github.com/apache/doris/pull/22163#issuecomment-1647578298

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] zhangguoqiang666 opened a new pull request, #22164: [fix][jdbc_case]Change the method of obtaining the driver for case test_doris_jdbc_catalog 0724

2023-07-24 Thread via GitHub


zhangguoqiang666 opened a new pull request, #22164:
URL: https://github.com/apache/doris/pull/22164

   ## Proposed changes
   
   
   Change the method of obtaining the driver for case test_doris_jdbc_catalog.
   The previous driver_url is written dead, which is not conducive to 
subsequent extension.
   This mysql driver jar has been uploaded to object storage in Beijing and 
Hong Kong respectively.
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



  1   2   3   4   5   >