[GitHub] [doris] shuke987 closed pull request #20980: [fix](test) dynamic_partition_check_interval_seconds=10
shuke987 closed pull request #20980: [fix](test) dynamic_partition_check_interval_seconds=10 URL: https://github.com/apache/doris/pull/20980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #20977: [enhancement](pk) add bvar stating cached io
xiaokang merged PR #20977: URL: https://github.com/apache/doris/pull/20977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhancement](pk) add bvar stating cached io (#20977)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new b65b821813 [enhancement](pk) add bvar stating cached io (#20977) b65b821813 is described below commit b65b8218131ae8b8244d747addd7d6d88b5d96b7 Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com> AuthorDate: Wed Jun 21 15:02:10 2023 +0800 [enhancement](pk) add bvar stating cached io (#20977) --- be/src/olap/rowset/segment_v2/indexed_column_reader.cpp | 4 1 file changed, 4 insertions(+) diff --git a/be/src/olap/rowset/segment_v2/indexed_column_reader.cpp b/be/src/olap/rowset/segment_v2/indexed_column_reader.cpp index 258d5ce4cd..d5a84a4c9c 100644 --- a/be/src/olap/rowset/segment_v2/indexed_column_reader.cpp +++ b/be/src/olap/rowset/segment_v2/indexed_column_reader.cpp @@ -44,6 +44,9 @@ static bvar::PerSecond> g_index_reader_bytes_per_second( static bvar::Adder g_index_reader_pages("doris_pk", "index_reader_pages"); static bvar::PerSecond> g_index_reader_pages_per_second( "doris_pk", "index_reader_pages_per_second", &g_index_reader_pages, 60); +static bvar::Adder g_index_reader_cached_pages("doris_pk", "index_reader_cached_pages"); +static bvar::PerSecond> g_index_reader_cached_pages_per_second( +"doris_pk", "index_reader_cached_pages_per_second", &g_index_reader_cached_pages, 60); static bvar::Adder g_index_reader_seek_count("doris_pk", "index_reader_seek_count"); static bvar::PerSecond> g_index_reader_seek_per_second( "doris_pk", "index_reader_seek_per_second", &g_index_reader_seek_count, 60); @@ -124,6 +127,7 @@ Status IndexedColumnReader::read_page(const PagePointer& pp, PageHandle* handle, g_index_reader_compressed_bytes << pp.size; g_index_reader_bytes << footer->uncompressed_size(); g_index_reader_pages << 1; +g_index_reader_cached_pages << tmp_stats.cached_pages_num; return st; } - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21022: [Test](regression) CCR syncer thrift interface regression
github-actions[bot] commented on PR #21022: URL: https://github.com/apache/doris/pull/21022#issuecomment-1600292769 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21022: [Test](regression) CCR syncer thrift interface regression
github-actions[bot] commented on PR #21022: URL: https://github.com/apache/doris/pull/21022#issuecomment-1600292807 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li commented on a diff in pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
Jibing-Li commented on code in PR #21070: URL: https://github.com/apache/doris/pull/21070#discussion_r1236477567 ## fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java: ## @@ -17,12 +17,7 @@ package org.apache.doris.catalog; -import org.apache.doris.analysis.CreateTableStmt; -import org.apache.doris.analysis.DropTableStmt; -import org.apache.doris.analysis.RefreshCatalogStmt; -import org.apache.doris.analysis.RefreshDbStmt; -import org.apache.doris.analysis.RefreshTableStmt; -import org.apache.doris.analysis.TableName; +import org.apache.doris.analysis.*; Review Comment: This * will fail the code format check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
github-actions[bot] commented on PR #21070: URL: https://github.com/apache/doris/pull/21070#issuecomment-1600302696 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21039: [enhancement](merge-on-write) some misc optimizations
github-actions[bot] commented on PR #21039: URL: https://github.com/apache/doris/pull/21039#issuecomment-1600303802 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] shuke987 opened a new pull request, #21071: fix: test case variable scope bug.
shuke987 opened a new pull request, #21071: URL: https://github.com/apache/doris/pull/21071 ## Proposed changes Issue Number: close #xxx groovy's variable is global without def, which introduce multi-thread bug. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #20957: [fix](multi-catalog)fix max compute scanner OOM and datetime
wsjz commented on PR #20957: URL: https://github.com/apache/doris/pull/20957#issuecomment-1600305793 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #21029: [fix](multi-catalog)add oss and cos sdk, supported their properties
wsjz commented on PR #21029: URL: https://github.com/apache/doris/pull/21029#issuecomment-1600307698 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #21070: [Fix](multi-catalog) Invalidate cache when enable auto refresh catalog.
dutyu commented on PR #21070: URL: https://github.com/apache/doris/pull/21070#issuecomment-1600308164 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #21022: [Test](regression) CCR syncer thrift interface regression
xiaokang merged PR #21022: URL: https://github.com/apache/doris/pull/21022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20926: [feature](fs)add fs_s3 benchmark tool
github-actions[bot] commented on PR #20926: URL: https://github.com/apache/doris/pull/20926#issuecomment-1600311367 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21071: fix: test case variable scope bug.
github-actions[bot] commented on PR #21071: URL: https://github.com/apache/doris/pull/21071#issuecomment-1600311102 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21071: fix: test case variable scope bug.
github-actions[bot] commented on PR #21071: URL: https://github.com/apache/doris/pull/21071#issuecomment-1600311055 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (b65b821813 -> 4d84cd8ca1)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b65b821813 [enhancement](pk) add bvar stating cached io (#20977) add 4d84cd8ca1 Revert "Revert "[Test](regression) CCR syncer thrift interface regression test (#20935)" (#20990)" (#21022) No new revisions were added by this update. Summary of changes: .gitignore | 1 + regression-test/conf/regression-conf.groovy| 6 + .../storage/test_dup_table_auto_inc_col.out| 4 +- .../test_duplicate_table_without_keys.out | 8 +- regression-test/data/ddl_p0/test_ctas.out | 4 +- regression-test/data/ddl_p0/test_ctl.out | 2 +- regression-test/data/ddl_p0/test_recover.out | 224 +++ regression-test/data/ddl_p0/test_unicode_name.out | 2 +- .../nereids_p0/show/test_array_show_create.out | 2 +- .../data/query_p0/show/test_array_show_create.out | 2 +- .../data/query_p0/show/test_map_show_create.out| 2 +- .../data/query_p0/show/test_show_create_table.out | 4 +- .../data/query_p0/show/test_struct_show_create.out | 2 +- regression-test/framework/pom.xml | 11 + .../org/apache/doris/regression/Config.groovy | 67 ++- .../apache/doris/regression/ConfigOptions.groovy | 40 ++ .../apache/doris/regression/RegressionTest.groovy | 1 - .../apache/doris/regression/json/BinlogData.groovy | 53 ++ .../org/apache/doris/regression/suite/Suite.groovy | 14 +- .../doris/regression/suite/SuiteContext.groovy | 32 + .../apache/doris/regression/suite/Syncer.groovy| 670 + .../doris/regression/suite/SyncerContext.groovy| 212 +++ .../suite/client/BackendClientImpl.groovy | 48 ++ .../suite/client/FrontendClientImpl.groovy | 40 ++ .../doris/regression/util/SyncerUtils.groovy | 114 regression-test/pipeline/p0/conf/be.conf | 1 + regression-test/pipeline/p0/conf/fe.conf | 1 + regression-test/pipeline/p1/conf/be.conf | 1 + regression-test/pipeline/p1/conf/fe.conf | 2 + .../ccr_syncer_p0/test_binlog_config_change.groovy | 106 .../suites/ccr_syncer_p0/test_get_binlog.groovy| 140 + .../suites/ccr_syncer_p0/test_ingest_binlog.groovy | 119 .../suites/ccr_syncer_p0/test_multi_buckets.groovy | 96 +++ .../suites/ccr_syncer_p0/test_txn_case.groovy | 298 + .../ccr_syncer_p1/test_backup_restore.groovy | 68 +++ run-regression-test.sh | 13 + 36 files changed, 2272 insertions(+), 138 deletions(-) create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/json/BinlogData.groovy create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/Syncer.groovy create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/SyncerContext.groovy create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/client/BackendClientImpl.groovy create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/suite/client/FrontendClientImpl.groovy create mode 100644 regression-test/framework/src/main/groovy/org/apache/doris/regression/util/SyncerUtils.groovy create mode 100644 regression-test/suites/ccr_syncer_p0/test_binlog_config_change.groovy create mode 100644 regression-test/suites/ccr_syncer_p0/test_get_binlog.groovy create mode 100644 regression-test/suites/ccr_syncer_p0/test_ingest_binlog.groovy create mode 100644 regression-test/suites/ccr_syncer_p0/test_multi_buckets.groovy create mode 100644 regression-test/suites/ccr_syncer_p0/test_txn_case.groovy create mode 100644 regression-test/suites/ccr_syncer_p1/test_backup_restore.groovy - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li commented on pull request #21053: [Improvement](statistics, multi catalog)Implement hive table statistic connector.
Jibing-Li commented on PR #21053: URL: https://github.com/apache/doris/pull/21053#issuecomment-1600313373 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-2.0 updated (b4773e1195 -> 4d84cd8ca1)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a change to branch branch-2.0 in repository https://gitbox.apache.org/repos/asf/doris.git from b4773e1195 [Chore](materialized-view) enable nereids planner on regression test mv_p0 (#21023) add ef17289925 [feature](jni) add jni metrics and attach to BE profile automatically (#21004) add 5f760a8939 [fix](runtime_filter) remove incorrect DCHECK (#21050) add 18beb822a3 [FIX](array-type) fix array string output with fe const expr (#21042) add fcd778fb4f [Fix](mysql proto) avoid send duplicated `OK` packet (#21032) add 5f0bb49d46 [Feature](materialized-view) support create mv contain aggstate column (#20812) add 81abdeffbc [Improvement](pipeline) Improve shared scan performance (#20785) add 6f20cac1da [bugfix](cooldown) Fix potential deadlock while calling handleCooldownConf (#20975) add 62fb0e642e [chore](dynamic schema) deprecated create dynamic schema table (#21058) add 564b3533cf [enhancement](merge-on-write) update publish/streamload/compaction co… (#21040) add bad22dd4e2 [Fix](orc-reader) Fix orc dict filter null value issue in `_convert_dict_cols_to_string_cols` which caused incorrect result. (#21047) add c5560b8f93 [fix](load) segcompaction does not signal waiters when an error hanppens (#21043) add b65b821813 [enhancement](pk) add bvar stating cached io (#20977) add 4d84cd8ca1 Revert "Revert "[Test](regression) CCR syncer thrift interface regression test (#20935)" (#20990)" (#21022) No new revisions were added by this update. Summary of changes: .gitignore |1 + be/src/agent/task_worker_pool.cpp |3 +- be/src/common/config.cpp |6 +- be/src/common/config.h |2 + be/src/exprs/runtime_filter.cpp|2 - be/src/olap/rowset/segcompaction.cpp |2 +- .../rowset/segment_v2/indexed_column_reader.cpp|4 + be/src/olap/task/engine_alter_tablet_task.cpp |9 +- be/src/util/jni-util.cpp | 81 ++ be/src/util/jni-util.h |3 + .../aggregate_function_min_max_by.h|4 + be/src/vec/columns/column_string.h |2 + be/src/vec/data_types/data_type_nullable.cpp |8 +- be/src/vec/exec/format/orc/vorc_reader.cpp | 47 +- be/src/vec/exec/format/orc/vorc_reader.h |1 + .../format/parquet/byte_array_dict_decoder.cpp |4 +- be/src/vec/exec/jni_connector.cpp | 74 +- be/src/vec/exec/jni_connector.h| 19 +- be/src/vec/exec/scan/pip_scanner_context.h | 137 +- be/src/vec/exec/scan/scanner_context.cpp | 38 +- be/src/vec/exec/scan/scanner_context.h | 32 +- be/src/vec/exec/scan/scanner_scheduler.cpp |4 + be/src/vec/exec/scan/vscan_node.cpp| 22 +- be/src/vec/exec/scan/vscan_node.h |7 +- docs/en/docs/data-table/dynamic-schema-table.md| 146 --- docs/sidebars.json |1 - docs/zh-CN/docs/data-table/dynamic-schema-table.md | 145 --- .../java/org/apache/doris/hudi/HudiJniScanner.java |9 + .../org/apache/doris/common/jni/JniScanner.java| 11 + fe/fe-core/src/main/cup/sql_parser.cup | 17 +- .../java/org/apache/doris/analysis/ColumnDef.java |3 +- .../doris/analysis/CreateMaterializedViewStmt.java | 31 +- .../org/apache/doris/analysis/PrepareStmt.java | 87 +- .../org/apache/doris/analysis/StatementBase.java | 13 + .../main/java/org/apache/doris/catalog/Column.java | 31 +- .../main/java/org/apache/doris/catalog/Env.java|4 + .../java/org/apache/doris/catalog/FunctionSet.java | 1305 +--- .../doris/catalog/MaterializedIndexMeta.java |2 +- .../apache/doris/catalog/TabletInvertedIndex.java | 21 +- .../doris/catalog/external/HMSExternalTable.java |5 +- .../org/apache/doris/common/util/LiteralUtils.java |2 +- .../apache/doris/common/util/PropertyAnalyzer.java |2 +- .../doris/external/jdbc/JdbcMySQLClient.java |3 +- .../org/apache/doris/mysql/MysqlCapability.java|4 + .../java/org/apache/doris/mysql/MysqlChannel.java | 11 + .../java/org/apache/doris/mysql/MysqlProto.java|3 + .../java/org/apache/doris/qe/ConnectProcessor.java |1 + .../java/org/apache/doris/qe/StmtExecutor.java | 28 +- regression-test/conf/regression-conf.groovy|6 + .../storage/test_dup_table_auto_inc_col.out|4 +- .../test_duplicate_table_without_keys.out |8 +- regression-test/data/ddl_p0/test_ctas.out |4 +- regression-test/data/ddl_p0/test_ctl.out |2 +- regression-test/data/ddl_p0/test_recover.out | 224 ++-- regres
[GitHub] [doris] hello-stephen opened a new pull request, #21072: [pipeline](ckb) debug
hello-stephen opened a new pull request, #21072: URL: https://github.com/apache/doris/pull/21072 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen closed pull request #21072: [pipeline](ckb) debug
hello-stephen closed pull request #21072: [pipeline](ckb) debug URL: https://github.com/apache/doris/pull/21072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21072: [pipeline](ckb) debug
github-actions[bot] commented on PR #21072: URL: https://github.com/apache/doris/pull/21072#issuecomment-1600359362 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5331480587";) output. shellcheck errors ``` 'shellcheck ' found no issues. ``` shfmt errors ``` 'shfmt ' returned error 1 finding the following formatting issues: -- --- build.sh.orig +++ build.sh @@ -690,4 +690,3 @@ fi exit 0 - -- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21072: [pipeline](ckb) debug
github-actions[bot] commented on PR #21072: URL: https://github.com/apache/doris/pull/21072#issuecomment-1600360526 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5331484139";) output. shellcheck errors ``` 'shellcheck ' found no issues. ``` shfmt errors ``` 'shfmt ' returned error 1 finding the following formatting issues: -- --- build.sh.orig +++ build.sh @@ -690,5 +690,3 @@ fi exit 0 - - -- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen opened a new pull request, #21073: [pipeline](ckb)Debug2
hello-stephen opened a new pull request, #21073: URL: https://github.com/apache/doris/pull/21073 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21073: [pipeline](ckb)Debug2
github-actions[bot] commented on PR #21073: URL: https://github.com/apache/doris/pull/21073#issuecomment-1600363305 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5331495111";) output. shellcheck errors ``` 'shellcheck ' found no issues. ``` shfmt errors ``` 'shfmt ' returned error 1 finding the following formatting issues: -- --- build.sh.orig +++ build.sh @@ -690,5 +690,3 @@ fi exit 0 - - -- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #21073: [pipeline](ckb)Debug2
hello-stephen commented on PR #21073: URL: https://github.com/apache/doris/pull/21073#issuecomment-1600363430 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] xinxingi opened a new pull request, #247: [fix] doc index link
xinxingi opened a new pull request, #247: URL: https://github.com/apache/doris-website/pull/247 Fix wrong jump link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21037: [test](regression) update some case in p2
github-actions[bot] commented on PR #21037: URL: https://github.com/apache/doris/pull/21037#issuecomment-1600371613 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21037: [test](regression) update some case in p2
github-actions[bot] commented on PR #21037: URL: https://github.com/apache/doris/pull/21037#issuecomment-1600371700 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinxingi commented on issue #20917: [Bug] 文档错误
xinxingi commented on issue #20917: URL: https://github.com/apache/doris/issues/20917#issuecomment-1600371801 > 你可以提一个文档修复的PR,然后就成为apache doris contribute了。 Submitted pr waiting to be merged. https://github.com/apache/doris-website/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #20907: [Enhancement](Compaction) Caculate all committed rowsets delete bitmaps when do comapction
zhannngchen commented on code in PR #20907: URL: https://github.com/apache/doris/pull/20907#discussion_r1236558263 ## be/src/olap/compaction.cpp: ## @@ -529,8 +532,58 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { } } +// Here we will calculate all the rowsets delete bitmaps which are committed but not published to reduce the calculation pressure +// of publish phase. +// All rowsets which need to recalculate have been published so we don't need to acquire lock. +// Step1: collect this tablet's all committed rowsets' delete bitmaps +TxnManager::txn_tablet_map_t txn_tablet_map {}; + StorageEngine::instance()->txn_manager()->get_all_tablet_txn_infos_by_tablet( +_tablet, txn_tablet_map); + +// Step2: calculate all rowsets' delete bitmaps which are published during compaction. +// e.g. before compaction: +// 5-5 6-6 published +// 7-7 8-8 committed not published +// then 5-5 delete bitmap versions are 6, 7(dummy), 8(dummy). +// 6-6 delete bitmap versions are 7(dummy), 8(dummy). +// when compaction: +// 5-5 6-6 7-7 published +// 8-8 committed not published +// then 5-5 delete bitmap versions are 6, 7, 8(dummy). +// 6-6 delete bitmap versions are 7, 8(dummy). +// 7-7 doesn't have delete bitmap. +// 8-8 has committed, so we want 7-7 delete bitmap version is 8(dummy). +// This part is to calculate 7-7's delete bitmap. +int64_t cur_max_version = _tablet->max_version().second; +for (const auto& it : txn_tablet_map) { +for (const auto& tablet_load_it : it.second) { +DeltaWriter* delta_writer = + StorageEngine::instance()->txn_manager()->get_txn_tablet_delta_writer( +it.first.second, _tablet->tablet_id()); +if (!delta_writer) { +continue; +} +const TabletTxnInfo& tablet_txn_info = tablet_load_it.second; + commit_rowset_delete_bitmap.merge(*tablet_txn_info.delete_bitmap); +auto beta_rowset = reinterpret_cast(tablet_txn_info.rowset.get()); +std::vector segments; +RETURN_IF_ERROR(beta_rowset->load_segments(&segments)); +RETURN_IF_ERROR(_tablet->commit_phase_update_delete_bitmap( Review Comment: We should not calculate delete bitmap here, which might be quite slow ## be/src/olap/compaction.cpp: ## @@ -529,8 +532,58 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { } } +// Here we will calculate all the rowsets delete bitmaps which are committed but not published to reduce the calculation pressure +// of publish phase. +// All rowsets which need to recalculate have been published so we don't need to acquire lock. +// Step1: collect this tablet's all committed rowsets' delete bitmaps +TxnManager::txn_tablet_map_t txn_tablet_map {}; Review Comment: we'd better to move this part after L589, do these works with lock, which can avoid potential consistency issues ## be/src/olap/compaction.cpp: ## @@ -529,8 +532,58 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { } } +// Here we will calculate all the rowsets delete bitmaps which are committed but not published to reduce the calculation pressure +// of publish phase. +// All rowsets which need to recalculate have been published so we don't need to acquire lock. +// Step1: collect this tablet's all committed rowsets' delete bitmaps +TxnManager::txn_tablet_map_t txn_tablet_map {}; + StorageEngine::instance()->txn_manager()->get_all_tablet_txn_infos_by_tablet( +_tablet, txn_tablet_map); + +// Step2: calculate all rowsets' delete bitmaps which are published during compaction. +// e.g. before compaction: +// 5-5 6-6 published +// 7-7 8-8 committed not published +// then 5-5 delete bitmap versions are 6, 7(dummy), 8(dummy). +// 6-6 delete bitmap versions are 7(dummy), 8(dummy). +// when compaction: +// 5-5 6-6 7-7 published +// 8-8 committed not published +// then 5-5 delete bitmap versions are 6, 7, 8(dummy). +// 6-6 delete bitmap versions are 7, 8(dummy). +// 7-7 doesn't have delete bitmap. +// 8-8 has committed, so we want 7-7 delete bitmap version is 8(dummy). +// This part is to calculate 7-7's delete bitmap. +int64_t cur_max_version = _tablet->max_version().second; +for (const auto& it : txn_tablet_map) { +for (const auto& tablet_load_it : it.second)
[GitHub] [doris] morrySnow commented on a diff in pull request #21068: [Enhancement](planner)support sql_select_limit for 1.2
morrySnow commented on code in PR #21068: URL: https://github.com/apache/doris/pull/21068#discussion_r1236565281 ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java: ## @@ -282,6 +282,8 @@ private PlanNode createQueryPlan(QueryStmt stmt, Analyzer analyzer, long default } } +long sqlSelectLimit = analyzer.getContext().getSessionVariable().sqlSelectLimit; Review Comment: createQueryPlan is called recursively, should make sqlSelectLimit as a parameter of this function just like defaultOrderByLimit ## fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java: ## @@ -295,7 +297,8 @@ private PlanNode createQueryPlan(QueryStmt stmt, Analyzer analyzer, long default ((SortNode) root).setDefaultLimit(limit == -1); ((SortNode) root).setOffset(stmt.getOffset()); if (useTopN) { -root.setLimit(limit != -1 ? limit : newDefaultOrderByLimit); +// if limit != -1, it means limit clause exists, we get the minimum. +root.setLimit(limit != -1 ? limit : Math.min(newDefaultOrderByLimit, sqlSelectLimit)); Review Comment: sqlSelectLimit could small than 0, in this case, sqlSelectLimit should not be set to limit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #21066: [test](regression) add analyze after stream load
xiaokang merged PR #21066: URL: https://github.com/apache/doris/pull/21066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [test](regression) add analyze after stream load (#21066)
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 4766e75d4e [test](regression) add analyze after stream load (#21066) 4766e75d4e is described below commit 4766e75d4ead704f8ecd67ee830e910ce57c13b0 Author: shuke <37901441+shuke...@users.noreply.github.com> AuthorDate: Wed Jun 21 16:03:46 2023 +0800 [test](regression) add analyze after stream load (#21066) --- regression-test/suites/brown_p2/load.groovy| 1 + regression-test/suites/tpcds_sf100_dup_without_key_p2/load.groovy | 1 + regression-test/suites/tpcds_sf100_p2/load.groovy | 1 + regression-test/suites/tpcds_sf1_p1/load.groovy| 1 + regression-test/suites/tpcds_sf1_p2/load.groovy| 1 + regression-test/suites/tpcds_sf1_unique_p1/load.groovy | 1 + regression-test/suites/tpch_sf0.1_unique_p1/load.groovy| 2 ++ regression-test/suites/tpch_sf100_p2/load.groovy | 2 +- regression-test/suites/tpch_sf100_unique_p2/load_four_step/load.groovy | 1 + regression-test/suites/tpch_sf100_unique_p2/load_one_step/load.groovy | 2 ++ .../suites/tpch_sf100_unique_p2/load_three_step/load.groovy| 1 + regression-test/suites/tpch_sf100_unique_p2/load_two_step/load.groovy | 1 + regression-test/suites/tpch_sf100_unique_sql_p2/load.groovy| 2 +- regression-test/suites/tpch_sf10_unique_p2/load_four_step/load.groovy | 2 ++ regression-test/suites/tpch_sf10_unique_p2/load_one_step/load.groovy | 2 ++ regression-test/suites/tpch_sf10_unique_p2/load_three_step/load.groovy | 3 ++- regression-test/suites/tpch_sf10_unique_p2/load_two_step/load.groovy | 2 +- regression-test/suites/tpch_sf1_p2/load.groovy | 2 ++ regression-test/suites/tpch_sf1_unique_p2/load.groovy | 1 + regression-test/suites/tpch_unique_sql_zstd_p0/load.groovy | 1 + .../ssb_unique_load_zstd/three/load_three_step.groovy | 1 + 21 files changed, 27 insertions(+), 4 deletions(-) diff --git a/regression-test/suites/brown_p2/load.groovy b/regression-test/suites/brown_p2/load.groovy index f74a1244ce..ebd51fde2a 100644 --- a/regression-test/suites/brown_p2/load.groovy +++ b/regression-test/suites/brown_p2/load.groovy @@ -72,5 +72,6 @@ suite("load") { assertTrue(json.NumberLoadedRows > 0 && json.LoadBytes > 0) } } +sql """ ANALYZE TABLE $tableName WITH SYNC """ } } diff --git a/regression-test/suites/tpcds_sf100_dup_without_key_p2/load.groovy b/regression-test/suites/tpcds_sf100_dup_without_key_p2/load.groovy index ccc22a1273..e28da95065 100644 --- a/regression-test/suites/tpcds_sf100_dup_without_key_p2/load.groovy +++ b/regression-test/suites/tpcds_sf100_dup_without_key_p2/load.groovy @@ -73,5 +73,6 @@ suite('load') { rowCount = sql "select count(*) from ${table}" } assertEquals(rows, rowCount[0][0]) +sql """ ANALYZE TABLE $table WITH SYNC """ } } diff --git a/regression-test/suites/tpcds_sf100_p2/load.groovy b/regression-test/suites/tpcds_sf100_p2/load.groovy index ccc22a1273..e28da95065 100644 --- a/regression-test/suites/tpcds_sf100_p2/load.groovy +++ b/regression-test/suites/tpcds_sf100_p2/load.groovy @@ -73,5 +73,6 @@ suite('load') { rowCount = sql "select count(*) from ${table}" } assertEquals(rows, rowCount[0][0]) +sql """ ANALYZE TABLE $table WITH SYNC """ } } diff --git a/regression-test/suites/tpcds_sf1_p1/load.groovy b/regression-test/suites/tpcds_sf1_p1/load.groovy index 1b527dcc81..d44fd13e11 100644 --- a/regression-test/suites/tpcds_sf1_p1/load.groovy +++ b/regression-test/suites/tpcds_sf1_p1/load.groovy @@ -98,5 +98,6 @@ suite("load") { assertTrue(json.NumberLoadedRows > 0 && json.LoadBytes > 0) } } +sql """ ANALYZE TABLE $tableName WITH SYNC """ } } diff --git a/regression-test/suites/tpcds_sf1_p2/load.groovy b/regression-test/suites/tpcds_sf1_p2/load.groovy index b8e5e059d3..e8275d0fb4 100644 --- a/regression-test/suites/tpcds_sf1_p2/load.groovy +++ b/regression-test/suites/tpcds_sf1_p2/load.groovy @@ -67,5 +67,6 @@ suite("load") { assertTrue(json.NumberLoadedRows > 0 && json.LoadBytes > 0) } } +sql """ ANALYZE TABLE $tableName WITH SYNC """ } } diff --git a/regression-test/suites/tpcds_sf1_unique_p1/load.groovy b/regression-test/suites/tpcds_sf1_unique_p1/load.groovy index b48d538fa3..b157211a48 100644 --- a/regression-test/suites/tpcds_sf1_unique_p1/load.groovy +++ b/regression-test/suites/tpcds_sf1_unique_p1/load.groovy @@ -137,6 +137,7 @@ suite("load") { assertTrue(json.Numb
[GitHub] [doris] xinyiZzz commented on a diff in pull request #21069: [enhancement](memory) print stacktrace for large allocation
xinyiZzz commented on code in PR #21069: URL: https://github.com/apache/doris/pull/21069#discussion_r1236576076 ## be/src/runtime/memory/thread_mem_tracker_mgr.h: ## @@ -173,7 +173,7 @@ inline void ThreadMemTrackerMgr::consume(int64_t size) { } // Large memory alloc should use allocator.h // Direct malloc or new large memory, unable to catch std::bad_alloc, BE may OOM. -if (size > 4294967296) { // 4G +if (size > 1024l * 1024 * 1024) { // 4G Review Comment: modify comment : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21069: [enhancement](memory) print stacktrace for large allocation
github-actions[bot] commented on PR #21069: URL: https://github.com/apache/doris/pull/21069#issuecomment-1600387520 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21069: [enhancement](memory) print stacktrace for large allocation
github-actions[bot] commented on PR #21069: URL: https://github.com/apache/doris/pull/21069#issuecomment-1600387463 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE
zclllyybb commented on PR #21027: URL: https://github.com/apache/doris/pull/21027#issuecomment-1600388745 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21056: [profile](sort) add some metrics in profile
github-actions[bot] commented on PR #21056: URL: https://github.com/apache/doris/pull/21056#issuecomment-1600389868 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21056: [profile](sort) add some metrics in profile
github-actions[bot] commented on PR #21056: URL: https://github.com/apache/doris/pull/21056#issuecomment-1600389818 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21027: [fix](log) fix the too large warning log of BE
github-actions[bot] commented on PR #21027: URL: https://github.com/apache/doris/pull/21027#issuecomment-1600393305 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #21039: [enhancement](merge-on-write) some misc optimizations
dataroaring merged PR #21039: URL: https://github.com/apache/doris/pull/21039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhancement](merge-on-write) some misc optimizations (#21039)
This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 85ce6a22c0 [enhancement](merge-on-write) some misc optimizations (#21039) 85ce6a22c0 is described below commit 85ce6a22c0ecc47c83cb621040471bf1d56e8c62 Author: zhannngchen <48427519+zhannngc...@users.noreply.github.com> AuthorDate: Wed Jun 21 16:16:06 2023 +0800 [enhancement](merge-on-write) some misc optimizations (#21039) --- be/src/olap/primary_key_index.cpp | 9 + be/src/olap/rowset/segment_v2/segment.cpp | 3 --- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/be/src/olap/primary_key_index.cpp b/be/src/olap/primary_key_index.cpp index 3f30529732..7b2f1593ca 100644 --- a/be/src/olap/primary_key_index.cpp +++ b/be/src/olap/primary_key_index.cpp @@ -40,14 +40,15 @@ Status PrimaryKeyIndexBuilder::init() { options.write_value_index = true; options.data_page_size = config::primary_key_data_page_size; options.encoding = segment_v2::EncodingInfo::get_default_encoding(type_info, true); -// TODO(liaoxin) test to confirm whether it needs to be compressed -options.compression = segment_v2::NO_COMPRESSION; // currently not compressed +options.compression = segment_v2::ZSTD; _primary_key_index_builder.reset( new segment_v2::IndexedColumnWriter(options, type_info, _file_writer)); RETURN_IF_ERROR(_primary_key_index_builder->init()); -_bloom_filter_index_builder.reset(new segment_v2::PrimaryKeyBloomFilterIndexWriterImpl( -segment_v2::BloomFilterOptions(), type_info)); +auto opt = segment_v2::BloomFilterOptions(); +opt.fpp = 0.01; +_bloom_filter_index_builder.reset( +new segment_v2::PrimaryKeyBloomFilterIndexWriterImpl(opt, type_info)); return Status::OK(); } diff --git a/be/src/olap/rowset/segment_v2/segment.cpp b/be/src/olap/rowset/segment_v2/segment.cpp index 50dc44ee73..70ac2c108e 100644 --- a/be/src/olap/rowset/segment_v2/segment.cpp +++ b/be/src/olap/rowset/segment_v2/segment.cpp @@ -73,8 +73,6 @@ class InvertedIndexIterator; using io::FileCacheManager; -static bvar::LatencyRecorder g_segment_lookup_rowkey_latency("doris_pk", "segment_lookup_rowkey"); - Status Segment::open(io::FileSystemSPtr fs, const std::string& path, uint32_t segment_id, RowsetId rowset_id, TabletSchemaSPtr tablet_schema, const io::FileReaderOptions& reader_options, @@ -358,7 +356,6 @@ Status Segment::new_inverted_index_iterator(const TabletColumn& tablet_column, } Status Segment::lookup_row_key(const Slice& key, bool with_seq_col, RowLocation* row_location) { -SCOPED_BVAR_LATENCY(g_segment_lookup_rowkey_latency); RETURN_IF_ERROR(load_pk_index_and_bf()); bool has_seq_col = _tablet_schema->has_sequence_col(); size_t seq_col_length = 0; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #21035: [Feature](inverted index) add unicode parser for inverted index
airborne12 commented on PR #21035: URL: https://github.com/apache/doris/pull/21035#issuecomment-1600399343 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE
BiteThet commented on code in PR #21027: URL: https://github.com/apache/doris/pull/21027#discussion_r1236596435 ## be/src/pipeline/task_scheduler.cpp: ## @@ -278,8 +278,8 @@ void TaskScheduler::_do_work(size_t index) { task->set_previous_core_id(index); if (!status.ok()) { Review Comment: I think warning should be used here, because `status` may return some internal errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600402330 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen opened a new pull request, #21074: [Feature](multi-catalog) Add hdfs benchmark tools.
kaka11chen opened a new pull request, #21074: URL: https://github.com/apache/doris/pull/21074 ## Proposed changes Issue Number: close #xxx Add hdfs benchmark tools. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #21067: [Feature](materialized view) support query match mv with agg_state on nereids planner
BiteThet commented on PR #21067: URL: https://github.com/apache/doris/pull/21067#issuecomment-1600404083 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21041: Revert "[feature](merge-on-write) enable merge on write by default (#…
github-actions[bot] commented on PR #21041: URL: https://github.com/apache/doris/pull/21041#issuecomment-1600403280 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21041: Revert "[feature](merge-on-write) enable merge on write by default (#…
github-actions[bot] commented on PR #21041: URL: https://github.com/apache/doris/pull/21041#issuecomment-1600403206 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21074: [Feature](multi-catalog) Add hdfs benchmark tools.
github-actions[bot] commented on PR #21074: URL: https://github.com/apache/doris/pull/21074#issuecomment-1600404324 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5331763134";) output. shellcheck errors ``` 'shellcheck ' returned error 1 finding the following syntactical issues: -- In bin/run-fs-benchmark.sh line 29: params="$@" ^--^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. In bin/run-fs-benchmark.sh line 77: echo "CONF: $CONF" ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "CONF: ${CONF}" In bin/run-fs-benchmark.sh line 78: echo "FS_TYPE: $FS_TYPE" ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "FS_TYPE: ${FS_TYPE}" In bin/run-fs-benchmark.sh line 79: echo "OPERATION: $OPERATION" ^^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "OPERATION: ${OPERATION}" In bin/run-fs-benchmark.sh line 80: echo "THREADS: $THREADS" ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "THREADS: ${THREADS}" In bin/run-fs-benchmark.sh line 81: echo "ITERATIONS: $ITERATIONS" ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "ITERATIONS: ${ITERATIONS}" In bin/run-fs-benchmark.sh line 82: echo "FILE_SIZE: $FILE_SIZE" ^^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "FILE_SIZE: ${FILE_SIZE}" In bin/run-fs-benchmark.sh line 84: echo $params ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. Did you mean: echo "${params}" In bin/run-fs-benchmark.sh line 231: if [[ "${RUN_IN_AWS}" -eq 0 ]]; then ^---^ SC2154 (warning): RUN_IN_AWS is referenced but not assigned. In bin/run-fs-benchmark.sh line 329: ${LIMIT:+${LIMIT}} ${DORIS_HOME}/lib/fs_benchmark_tool --conf $CONF --fs_type=$FS_TYPE --operation=$OPERATION --threads=$THREADS --iterations=$ITERATIONS --file_size=$FILE_SIZE 2>&1 | tee "${LOG_DIR}/fs_benchmark_tool.log" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. ^^ SC2086 (info): Double quote to prevent globbing and word splitting. ^^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
[GitHub] [doris] github-actions[bot] commented on pull request #21035: [Feature](inverted index) add unicode parser for inverted index
github-actions[bot] commented on PR #21035: URL: https://github.com/apache/doris/pull/21035#issuecomment-1600406681 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600407595 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #21037: [test](regression) update some case in p2
xiaokang merged PR #21037: URL: https://github.com/apache/doris/pull/21037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [test](regression) update some case in brown_p2 #21037
This is an automated email from the ASF dual-hosted git repository. kxiao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 8bcd42d3f6 [test](regression) update some case in brown_p2 #21037 8bcd42d3f6 is described below commit 8bcd42d3f6df2f5aa83b4d4bde9d3fcd6422f547 Author: Mryange <59914473+mrya...@users.noreply.github.com> AuthorDate: Wed Jun 21 16:25:07 2023 +0800 [test](regression) update some case in brown_p2 #21037 --- .../brown_p2/sql/CPUNetworkUtilization_order.out | 6 +- .../data/brown_p2/sql/powerConsumptionMetrics.out | 56 +++--- .../tpcds_sf100_dup_without_key_p2/sql/q49.out | 202 ++--- .../sql/q49_rewrite.out| 200 ++-- 4 files changed, 232 insertions(+), 232 deletions(-) diff --git a/regression-test/data/brown_p2/sql/CPUNetworkUtilization_order.out b/regression-test/data/brown_p2/sql/CPUNetworkUtilization_order.out index 8721bed5d8..982d0a97ad 100644 --- a/regression-test/data/brown_p2/sql/CPUNetworkUtilization_order.out +++ b/regression-test/data/brown_p2/sql/CPUNetworkUtilization_order.out @@ -1,6 +1,6 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !CPUNetworkUtilization_order -- -anansi 0 22.497440.142686086 938.9564 2355335.637499904 9177.160292675 216.880005122354536.236711936 13467.316295748 -aragog 0 31.137440.466084818 1318.689964032 27836488.351744 328922.023920031308.950007808 40642403.643686912 825490.561812005 -urd0 23.4933329921.499065356 1168.349986816 368025.61415577622100.285069203 220.950003712 108069.656723456 8129.441452354 +anansi 0.0 22.50.14268608779353878 938.95 2355335.8 9177.160319882514 216.88 2354536.2 13467.316303191717 +aragog 0.0 31.14 0.4660848216252758 1318.69 2.7836488E7 328922.0219290647 308.95 4.0642404E7 825490.5598814549 +urd0.0 23.493334 1.4990653583589646 1168.35 368025.62 22100.285077492692 220.95 108069.66 8129.441453910114 diff --git a/regression-test/data/brown_p2/sql/powerConsumptionMetrics.out b/regression-test/data/brown_p2/sql/powerConsumptionMetrics.out index 46fde47fd6..3d284c65ea 100644 --- a/regression-test/data/brown_p2/sql/powerConsumptionMetrics.out +++ b/regression-test/data/brown_p2/sql/powerConsumptionMetrics.out @@ -1,31 +1,31 @@ -- This file is automatically generated. You should know what you did if you want to edit this -- !powerConsumptionMetrics -- -2017 9 721638.3414064787 1252.844342719581 65268.73919188455 113.31378331924401 174895.7715174624 330.6158251747871 176421.94104524452 388.59458380009806 -2017 10 702508.0664338227 1256.7228379853716 66960.70685831291 120.0012667711701 131314.92843738294 270.75242976779987 212072.4254061825 379.3782207624016 -2017 11 903660.5956517102 1258.5802167851116 79376.1443387 110.55173306251932 178488.04901201383 304.0682265962757 257457.2271247641 358.575525243404 -2017 12 931357.6830229171 1251.824842772738 76585.03687197335 102.93687751609322 112836.92815090143 198.6565636459532 241257.5071419921 324.27084293278506 -2018 1 800695.0232504867 1268.9303062606762 52913.86179851603 83.85715023536613 36392.480584571706 83.46899216644887 191628.70119383492 303.69049317564964 -2018 2 788872.0573169803 1188.060327284609 85621.32358955592 128.94777649029507 83922.79400835952 176.6795668846 230227.25133465914 346.72778815460714 -2018 3 896816.2190436656 1205.3981438758947 88325.94803945153 118.71767209603699 114322.79839365481 193.7674549044997 269070.60609120084 361.6540404451624 -2018 4 581954.6102904761 1199.906412970054 55146.13846078817 113.70337826966633 107909.63419773092 260.6512903326834 172977.56835847028 356.6547801205573 -2018 5 810269.3225697614 1246.5681885688637 69687.035837944 107.2108243660677 83644.78159173671 143.47303875083483 248284.77976738196 381.9765842575107 -2018 6 824150.0588949085 1252.5076882901346 52047.118737002979.09896464590106 61491.795137032634 113.24455826341185 242561.98528653942 368.6352359977803 -2018 7 920527.3411698388 1237.2679316798908 54001.805264369934 72.58307159189508 110136.29401019627 175.65597130812802 284977.68054289324 383.0345168587275 -2018 8
[GitHub] [doris] github-actions[bot] commented on pull request #21074: [Feature](multi-catalog) Add hdfs benchmark tools.
github-actions[bot] commented on PR #21074: URL: https://github.com/apache/doris/pull/21074#issuecomment-1600411248 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
dataroaring commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600412853 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #21035: [Feature](inverted index) add unicode parser for inverted index
airborne12 commented on PR #21035: URL: https://github.com/apache/doris/pull/21035#issuecomment-1600413100 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600414035 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600414121 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on a diff in pull request #21027: [fix](log) fix the too large warning log of BE
zclllyybb commented on code in PR #21027: URL: https://github.com/apache/doris/pull/21027#discussion_r1236612208 ## be/src/pipeline/task_scheduler.cpp: ## @@ -278,8 +278,8 @@ void TaskScheduler::_do_work(size_t index) { task->set_previous_core_id(index); if (!status.ok()) { Review Comment: how do you think if we print a WARNING message of PipelineTask failure, and print verbose information in INFO? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20247: [feature](datetime) "timediff" supports calculating microseconds.
Mryange commented on PR #20247: URL: https://github.com/apache/doris/pull/20247#issuecomment-1600417724 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
dataroaring commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600419846 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #21065: [fix](nereids)create datev2 and datetimev2 literal if enable_date_conversion is true
starocean999 commented on PR #21065: URL: https://github.com/apache/doris/pull/21065#issuecomment-1600420540 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600421141 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liaoxin01 commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
liaoxin01 commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600422869 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600424629 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20247: [feature](datetime) "timediff" supports calculating microseconds.
github-actions[bot] commented on PR #20247: URL: https://github.com/apache/doris/pull/20247#issuecomment-1600425669 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen closed pull request #21073: [pipeline](ckb)Debug2
hello-stephen closed pull request #21073: [pipeline](ckb)Debug2 URL: https://github.com/apache/doris/pull/21073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21065: [fix](nereids)create datev2 and datetimev2 literal if enable_date_conversion is true
github-actions[bot] commented on PR #21065: URL: https://github.com/apache/doris/pull/21065#issuecomment-1600426982 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21025: [enhancement](merge-on-write) add aync publish task when version is discontinous for merge on write table when clone
github-actions[bot] commented on PR #21025: URL: https://github.com/apache/doris/pull/21025#issuecomment-1600428790 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen opened a new pull request, #21075: [pipeline](ckb)Debug3
hello-stephen opened a new pull request, #21075: URL: https://github.com/apache/doris/pull/21075 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #21075: [pipeline](ckb)Debug3
hello-stephen commented on PR #21075: URL: https://github.com/apache/doris/pull/21075#issuecomment-1600434507 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21075: [pipeline](ckb)Debug3
github-actions[bot] commented on PR #21075: URL: https://github.com/apache/doris/pull/21075#issuecomment-1600435588 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5331965007";) output. shellcheck errors ``` 'shellcheck ' found no issues. ``` shfmt errors ``` 'shfmt ' returned error 1 finding the following formatting issues: -- --- build.sh.orig +++ build.sh @@ -690,4 +690,3 @@ fi exit 0 - -- You can reformat the above files to meet shfmt's requirements by typing: shfmt -w filename ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #21076: [Chore](vectorized) remove all isVectorized
BiteThet opened a new pull request, #21076: URL: https://github.com/apache/doris/pull/21076 ## Proposed changes isVectorized is always true now ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #21076: [Chore](vectorized) remove all isVectorized
BiteThet commented on PR #21076: URL: https://github.com/apache/doris/pull/21076#issuecomment-1600439340 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #21060: [improvement](config) update Be config max_runnings_transactions_per_txn_map default value
dataroaring commented on PR #21060: URL: https://github.com/apache/doris/pull/21060#issuecomment-1600443320 change it to 2000. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #21033: [fix](memory) arena support memory reuse after clear()
xinyiZzz commented on PR #21033: URL: https://github.com/apache/doris/pull/21033#issuecomment-1600443842 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] CalvinKirs commented on pull request #20986: [Improve](load)Solve the problem of RoutineLoadTaskScheduler idling when there is no data
CalvinKirs commented on PR #20986: URL: https://github.com/apache/doris/pull/20986#issuecomment-160002 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21076: [Chore](vectorized) remove all isVectorized
github-actions[bot] commented on PR #21076: URL: https://github.com/apache/doris/pull/21076#issuecomment-160075 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21076: [Chore](vectorized) remove all isVectorized
github-actions[bot] commented on PR #21076: URL: https://github.com/apache/doris/pull/21076#issuecomment-1600444535 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LiBinfeng-01 opened a new pull request, #21077: [Fix](Nereids) fix cast compare of varchar with double
LiBinfeng-01 opened a new pull request, #21077: URL: https://github.com/apache/doris/pull/21077 ## Proposed changes Problem: when using nereids planner, some constant folding does not work. like: explain select case 'a' when 1 then 'a' when 'a' then 'b' else 'other' end as col212; which will add cast to 'a' to double, but Cast is not treated as constant, so this folding can not be done Solve: Treat Cast(constant as Literal) as constant, and add equal to of Cast with other Literal ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #21033: [fix](memory) arena support memory reuse after clear()
xinyiZzz commented on PR #21033: URL: https://github.com/apache/doris/pull/21033#issuecomment-1600445469 > recheck all place use area reuse the mem? some places arena.reset has also been changed to clear, cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on pull request #21036: [refactor](nereids) update Agg stats derive method
englefly commented on PR #21036: URL: https://github.com/apache/doris/pull/21036#issuecomment-1600448150 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] DongLiang-0 commented on pull request #21060: [improvement](config) update Be config max_runnings_transactions_per_txn_map default value
DongLiang-0 commented on PR #21060: URL: https://github.com/apache/doris/pull/21060#issuecomment-1600450533 > change it to 2000. Thanks for your suggestion, I will change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21033: [fix](memory) arena support memory reuse after clear()
github-actions[bot] commented on PR #21033: URL: https://github.com/apache/doris/pull/21033#issuecomment-1600454158 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21060: [improvement](config) update Be config max_runnings_transactions_per_txn_map default value
github-actions[bot] commented on PR #21060: URL: https://github.com/apache/doris/pull/21060#issuecomment-1600455417 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yagagagaga opened a new pull request, #21078: [typo](docs) add a sample
yagagagaga opened a new pull request, #21078: URL: https://github.com/apache/doris/pull/21078 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20617: [Feature](log)friendly hint for creating table failed
github-actions[bot] commented on PR #20617: URL: https://github.com/apache/doris/pull/20617#issuecomment-1600458047 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21035: [Feature](inverted index) add unicode parser for inverted index
github-actions[bot] commented on PR #21035: URL: https://github.com/apache/doris/pull/21035#issuecomment-1600459949 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] didiaode18 commented on pull request #20617: [Feature](log)friendly hint for creating table failed
didiaode18 commented on PR #20617: URL: https://github.com/apache/doris/pull/20617#issuecomment-1600462915 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #21068: [Enhancement](planner)support sql_select_limit for 1.2
morrySnow commented on code in PR #21068: URL: https://github.com/apache/doris/pull/21068#discussion_r1236656944 ## fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java: ## @@ -27,6 +27,7 @@ import org.apache.doris.common.ErrorReport; import org.apache.doris.common.UserException; import org.apache.doris.common.util.VectorizedUtil; +import org.apache.doris.qe.ConnectContext; Review Comment: remove this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21068: [Enhancement](planner)support sql_select_limit for 1.2
github-actions[bot] commented on PR #21068: URL: https://github.com/apache/doris/pull/21068#issuecomment-1600471019 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21068: [Enhancement](planner)support sql_select_limit for 1.2
github-actions[bot] commented on PR #21068: URL: https://github.com/apache/doris/pull/21068#issuecomment-1600471240 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] csun5285 opened a new pull request, #21079: [fix](compaction)Modify time series compaction policy config
csun5285 opened a new pull request, #21079: URL: https://github.com/apache/doris/pull/21079 ## Proposed changes The default parameters may lead to excessive memory usage. Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #21069: [enhancement](memory) print stacktrace for large allocation
dataroaring commented on PR #21069: URL: https://github.com/apache/doris/pull/21069#issuecomment-1600473231 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #21027: [fix](log) fix the too large warning log of BE
zclllyybb commented on PR #21027: URL: https://github.com/apache/doris/pull/21027#issuecomment-1600478393 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 opened a new pull request, #21080: [fix](planner) fix push filter through agg
Kikyou1997 opened a new pull request, #21080: URL: https://github.com/apache/doris/pull/21080 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] hf200012 merged pull request #247: [fix] doc index link
hf200012 merged PR #247: URL: https://github.com/apache/doris-website/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: [fix] doc index link (#247)
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new adda5962482 [fix] doc index link (#247) adda5962482 is described below commit adda5962482d42f5dc04a7073a1830f977ab1a69 Author: Xinxing <49302071+xinxi...@users.noreply.github.com> AuthorDate: Wed Jun 21 17:11:18 2023 +0800 [fix] doc index link (#247) --- src/pages/learning/index.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/pages/learning/index.tsx b/src/pages/learning/index.tsx index ccc78051dc8..bc67cdbd6cd 100644 --- a/src/pages/learning/index.tsx +++ b/src/pages/learning/index.tsx @@ -126,7 +126,7 @@ const sitemapList = [ }, { title: Sequence Column, -link: '/docs/dev/data-table/best-practice', +link: '/docs/dev/data-operate/update-delete/sequence-column-manual', }, ], }, @@ -148,11 +148,11 @@ const sitemapList = [ }, { title: Join Optimization, -link: '/docs/dev/advanced/join-optimization/doris-join-optimization', +link: '/docs/dev/query-acceleration/join-optimization/doris-join-optimization', }, { title: Materialized view, -link: '/docs/dev/advanced/materialized-view', +link: '/docs/dev/query-acceleration/materialized-view', }, { title: BITMAP Precise De-duplication, - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org