[GitHub] [doris] github-actions[bot] commented on pull request #20678: [fix](decimalv3) fix result error when cast a round decimalv3 to double
github-actions[bot] commented on PR #20678: URL: https://github.com/apache/doris/pull/20678#issuecomment-1586703230 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544:
URL: https://github.com/apache/doris/pull/20544#issuecomment-1586704610
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5240498367";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In run-be-ut.sh line 347:
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
^---^ SC2154 (warning): MACHINE_OS is referenced but not
assigned.
In run-be-ut.sh line 366:
export JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
^-^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
export JAVA_OPTS="-Xmx1024m -DlogPath=${DORIS_HOME}/log/jni.log
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- MACHINE_OS is referenced but not
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -326,7 +326,6 @@
jdk_version "${JAVA_HOME}/bin/java"
)"
-
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_TEST_BINARY_DIR}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBETEST -XX:-CriticalJNINatives"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lvshaokang opened a new pull request, #20699: [fix](load) fix mysql load parse response npe
lvshaokang opened a new pull request, #20699:
URL: https://github.com/apache/doris/pull/20699
## Proposed changes
Issue Number: close #20603
return err msg, instead of null
```
mysql> LOAD DATA LOCAL
-> INFILE '/client_local.csv'
-> INTO TABLE test.t1
-> COLUMNS TERMINATED BY ','
-> LINES TERMINATED BY '\n'
-> IGNORE 1 LINES
-> (pk, v1)
-> PROPERTIES ("strict_mode"="true");
ERROR 1105 (HY000): errCode = 2, detailMessage =
[PUBLISH_TIMEOUT]transaction commit successfully, BUT data will be visible
later with load id 44ad1ada-e221-4d2c-a2ea-5f09a6791b48
```
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] shuke987 commented on pull request #20689: [regression-test](test) fix mv_p0/test_drop_partition_from_index/test_drop_partition_from_index.groovy
shuke987 commented on PR #20689: URL: https://github.com/apache/doris/pull/20689#issuecomment-1586706953 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
morningman commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1586710308 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544:
URL: https://github.com/apache/doris/pull/20544#issuecomment-1586710946
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5240533056";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In run-be-ut.sh line 347:
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
^---^ SC2154 (warning): MACHINE_OS is referenced but not
assigned.
In run-be-ut.sh line 366:
export JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
^-^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
export JAVA_OPTS="-Xmx1024m -DlogPath=${DORIS_HOME}/log/jni.log
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- MACHINE_OS is referenced but not
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -326,7 +326,6 @@
jdk_version "${JAVA_HOME}/bin/java"
)"
-
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_TEST_BINARY_DIR}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBETEST -XX:-CriticalJNINatives"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #20693: [Refactor](Profile) Add and refactor the join profile
HappenLee commented on PR #20693: URL: https://github.com/apache/doris/pull/20693#issuecomment-1586712782 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #20671: [fix](ssl) fix some version of jdbc may result connect error
eldenmoon commented on PR #20671: URL: https://github.com/apache/doris/pull/20671#issuecomment-1586718633 seems ut failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20693: [Refactor](Profile) Add and refactor the join profile
github-actions[bot] commented on PR #20693: URL: https://github.com/apache/doris/pull/20693#issuecomment-1586717633 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544:
URL: https://github.com/apache/doris/pull/20544#issuecomment-1586729598
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5240654923";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In run-be-ut.sh line 347:
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
^---^ SC2154 (warning): MACHINE_OS is referenced but not
assigned.
In run-be-ut.sh line 366:
export JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
^-^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
export JAVA_OPTS="-Xmx1024m -DlogPath=${DORIS_HOME}/log/jni.log
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- MACHINE_OS is referenced but not
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -326,7 +326,6 @@
jdk_version "${JAVA_HOME}/bin/java"
)"
-
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_TEST_BINARY_DIR}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBETEST -XX:-CriticalJNINatives"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on code in PR #20544: URL: https://github.com/apache/doris/pull/20544#discussion_r1226192783 ## be/test/util/lru_multi_cache_test.cpp: ## @@ -0,0 +1,480 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +// +// This file is copied from +// https://github.com/apache/impala/blob/master/be/src/util/lru-multi-cache-test.cc +// and modified by Doris + +#include +#include + +#include + +#include "gtest/gtest_pred_impl.h" +#include "util/lru_multi_cache.inline.h" Review Comment: warning: 'util/lru_multi_cache.inline.h' file not found [clang-diagnostic-error] ```cpp #include "util/lru_multi_cache.inline.h" ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dujl commented on pull request #20678: [fix](decimalv3) fix result error when cast a round decimalv3 to double
dujl commented on PR #20678: URL: https://github.com/apache/doris/pull/20678#issuecomment-1586738141 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dujl commented on pull request #20688: [fix](decimalv3) fix result error when cast a round decimalv3 to double
dujl commented on PR #20688: URL: https://github.com/apache/doris/pull/20688#issuecomment-1586739989 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
morningman commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1586740769 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20700: [Fix](planner)fix create table like stmt from a table distributed by random error.
sohardforaname commented on PR #20700: URL: https://github.com/apache/doris/pull/20700#issuecomment-1586750217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #20700: [Fix](planner)fix create table like stmt from a table distributed by random error.
sohardforaname opened a new pull request, #20700: URL: https://github.com/apache/doris/pull/20700 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1586752108 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20607: [Fix](Nereids)add foldable function timestamp()
sohardforaname commented on PR #20607: URL: https://github.com/apache/doris/pull/20607#issuecomment-1586762977 run fe ut p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #20701: [Fix](planner)fix cast yyyy-mm-31 incorrectly in original planner for 1.2
sohardforaname opened a new pull request, #20701: URL: https://github.com/apache/doris/pull/20701 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20701: [Fix](planner)fix cast yyyy-mm-31 incorrectly in original planner for 1.2
sohardforaname commented on PR #20701: URL: https://github.com/apache/doris/pull/20701#issuecomment-1586775714 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #20702: [Chore](pipeline-engine) adjus queryt canceled log on pipeline engine
BiteThet opened a new pull request, #20702: URL: https://github.com/apache/doris/pull/20702 ## Proposed changes adjus queryt canceled log on pipeline engine ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20702: [Chore](pipeline-engine) adjus queryt canceled log on pipeline engine
github-actions[bot] commented on PR #20702: URL: https://github.com/apache/doris/pull/20702#issuecomment-1586782387 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20702: [Chore](pipeline-engine) adjus queryt canceled log on pipeline engine
BiteThet commented on PR #20702: URL: https://github.com/apache/doris/pull/20702#issuecomment-1586783468 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuxuan-luo opened a new issue, #20703: [Bug] JDBC [INTERNAL_ERROR]NoSuchFieldError: table_type
yuxuan-luo opened a new issue, #20703: URL: https://github.com/apache/doris/issues/20703 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? 使用 jdbc catalog 时，查询数据出现错误。在 1.2 上能正常运行 MySQL [hugo]> select * from hugoluo; ERROR 1105 (HY000): errCode = 2, detailMessage = (172.16.64.36)[INTERNAL_ERROR]NoSuchFieldError: table_type ### What You Expected? 正常返回数据 ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lvshaokang commented on pull request #20699: [fix](load) fix mysql load parse response npe
lvshaokang commented on PR #20699: URL: https://github.com/apache/doris/pull/20699#issuecomment-1586788367 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #20585: [Opt](join) short circuit probe for join node
BiteThet merged PR #20585: URL: https://github.com/apache/doris/pull/20585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Opt](join) short circuit probe for join node (#20585)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ea264ce9de [Opt](join) short circuit probe for join node (#20585)
ea264ce9de is described below
commit ea264ce9de3329d661a1e89a8d33d4496118fb64
Author: HappenLee
AuthorDate: Mon Jun 12 16:01:09 2023 +0800
[Opt](join) short circuit probe for join node (#20585)
Support the _short_circuit_for_probe for join node
---
be/src/pipeline/exec/operator.h | 3 ++-
be/src/vec/exec/join/vhash_join_node.cpp | 16
be/src/vec/exec/join/vhash_join_node.h | 11 +++
be/src/vec/exec/join/vjoin_node_base.h | 7 +++
4 files changed, 28 insertions(+), 9 deletions(-)
diff --git a/be/src/pipeline/exec/operator.h b/be/src/pipeline/exec/operator.h
index 2ef903b0e4..0a31435b8f 100644
--- a/be/src/pipeline/exec/operator.h
+++ b/be/src/pipeline/exec/operator.h
@@ -419,7 +419,8 @@ public:
return Status::OK();
}
node->prepare_for_next();
-node->push(state, _child_block.get(), _child_source_state ==
SourceState::FINISHED);
+RETURN_IF_ERROR(node->push(state, _child_block.get(),
+ _child_source_state ==
SourceState::FINISHED));
}
if (!node->need_more_input_data()) {
diff --git a/be/src/vec/exec/join/vhash_join_node.cpp
b/be/src/vec/exec/join/vhash_join_node.cpp
index 1628af157e..2dfb93a98d 100644
--- a/be/src/vec/exec/join/vhash_join_node.cpp
+++ b/be/src/vec/exec/join/vhash_join_node.cpp
@@ -521,7 +521,7 @@ Status HashJoinNode::close(RuntimeState* state) {
bool HashJoinNode::need_more_input_data() const {
return (_probe_block.rows() == 0 || _probe_index == _probe_block.rows())
&& !_probe_eos &&
- !_short_circuit_for_null_in_probe_side;
+ !_short_circuit_for_probe;
}
void HashJoinNode::prepare_for_next() {
@@ -531,9 +531,8 @@ void HashJoinNode::prepare_for_next() {
Status HashJoinNode::pull(doris::RuntimeState* state, vectorized::Block*
output_block, bool* eos) {
SCOPED_TIMER(_probe_timer);
-if (_short_circuit_for_null_in_probe_side) {
-// If we use a short-circuit strategy for null value in build side
(e.g. if join operator is
-// NULL_AWARE_LEFT_ANTI_JOIN), we should return empty block directly.
+if (_short_circuit_for_probe) {
+// If we use a short-circuit strategy, should return empty block
directly.
*eos = true;
return Status::OK();
}
@@ -664,9 +663,8 @@ Status HashJoinNode::push(RuntimeState* /*state*/,
vectorized::Block* input_bloc
Status HashJoinNode::get_next(RuntimeState* state, Block* output_block, bool*
eos) {
SCOPED_TIMER(_runtime_profile->total_time_counter());
-if (_short_circuit_for_null_in_probe_side) {
-// If we use a short-circuit strategy for null value in build side
(e.g. if join operator is
-// NULL_AWARE_LEFT_ANTI_JOIN), we should return empty block directly.
+if (_short_circuit_for_probe) {
+// If we use a short-circuit strategy, should return empty block
directly.
*eos = true;
return Status::OK();
}
@@ -952,6 +950,8 @@ Status HashJoinNode::sink(doris::RuntimeState* state,
vectorized::Block* in_bloc
if (!_build_blocks->empty() && _join_op ==
TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) {
_probe_ignore_null = true;
}
+_init_short_circuit_for_probe();
+
return Status::OK();
}
@@ -960,7 +960,7 @@ void HashJoinNode::debug_string(int indentation_level,
std::stringstream* out) c
*out << "HashJoin(need_more_input_data=" << (need_more_input_data() ?
"true" : "false")
<< " _probe_block.rows()=" << _probe_block.rows() << " _probe_index="
<< _probe_index
<< " _probe_eos=" << _probe_eos
- << " _short_circuit_for_null_in_probe_side=" <<
_short_circuit_for_null_in_probe_side;
+ << " _short_circuit_for_probe_side=" << _short_circuit_for_probe;
*out << ")\n children=(";
ExecNode::debug_string(indentation_level, out);
*out << ")";
diff --git a/be/src/vec/exec/join/vhash_join_node.h
b/be/src/vec/exec/join/vhash_join_node.h
index 7430bd6ab1..286a0783a6 100644
--- a/be/src/vec/exec/join/vhash_join_node.h
+++ b/be/src/vec/exec/join/vhash_join_node.h
@@ -253,6 +253,17 @@ public:
bool should_build_hash_table() const { return _should_build_hash_table; }
private:
+void _init_short_circuit_for_probe() override {
+_short_circuit_for_probe =
+(_short_circuit_for_null_in_probe_side &&
+ _join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN) ||
+(_build_blocks->empty() && _join_op == TJoinOp::INNER_JOIN &&
!_is_mark_join) ||
+(_build_blocks->empty() && _join_op == TJoinOp::LEFT_SEMI_JOIN
[GitHub] [doris] adonis0147 commented on issue #20665: [Bug] aws-sdk compile error makes build doris from scratch failed
adonis0147 commented on issue #20665: URL: https://github.com/apache/doris/issues/20665#issuecomment-1586798919 Hi @zhiqiang-, I think the solution #2 is better than #1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #20704: [fix](routine-load) fix stackoverflow bug in routine load
morningman opened a new pull request, #20704: URL: https://github.com/apache/doris/pull/20704 ## Proposed changes When executing routine load job, there may encounter StackOverflowException. This is because the expr in column setting list will be analyze for each routine load sub task, and there is a self-reference bug that may cause endless loop when analyzing expr. The following columns expr list may trigger this bug: ``` columns(col1, col2, col2=null_or_empty(col2), col1=null_or_empty(col2)) ``` This fix is verified by user, but I can't add regression test for this case, because I can't submit a routine load job in our regression test, and this bug can only be triggered in routine load. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20566: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
github-actions[bot] commented on PR #20566: URL: https://github.com/apache/doris/pull/20566#issuecomment-1586805551 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20566: [Refactor](External) Move Common ODBC Methods to JDBC Class and Add Default config to Disable ODBC Creation
github-actions[bot] commented on PR #20566: URL: https://github.com/apache/doris/pull/20566#issuecomment-1586805640 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengzhou-spark commented on issue #5103: doris怎么删除昨天的数据
zhengzhou-spark commented on issue #5103: URL: https://github.com/apache/doris/issues/5103#issuecomment-1586805983 Right expr of binary predicate should be value。类似删除昨天的数据，哪个版本能支持这个特性？还是不准备支持？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #20562: [bug](function) fix is_null/is_not_null check is_const has error
zhangstar333 commented on PR #20562: URL: https://github.com/apache/doris/pull/20562#issuecomment-1586808220 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [1.2][improvement](jdbc) Set the JDBC connection timeout to be configurable (#20687)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new b3bed1c5e7 [1.2][improvement](jdbc) Set the JDBC connection timeout to
be configurable (#20687)
b3bed1c5e7 is described below
commit b3bed1c5e7fc8626cf5c3b475a204f58614c04cf
Author: zy-kkk
AuthorDate: Mon Jun 12 16:11:30 2023 +0800
[1.2][improvement](jdbc) Set the JDBC connection timeout to be configurable
(#20687)
---
bin/start_be.sh | 12 ++--
conf/be.conf | 4 ++--
.../src/main/java/org/apache/doris/udf/JdbcExecutor.java | 7 +--
3 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/bin/start_be.sh b/bin/start_be.sh
index b36c1569a4..e0821b2e00 100755
--- a/bin/start_be.sh
+++ b/bin/start_be.sh
@@ -271,18 +271,18 @@ java_version="$(
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_HOME}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBE -XX:-CriticalJNINatives"
-JDBC_OPTS="-DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100 -DJDBC_MAX_IDEL_TIME=30"
+JDBC_OPTS="-DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100 -DJDBC_MAX_IDEL_TIME=30
-DJDBC_MAX_WAIT_TIME=5000"
if [[ "${java_version}" -gt 8 ]]; then
-if [[ -z ${JAVA_OPTS} ]]; then
-JAVA_OPTS="-Xmx1024m ${LOG_PATH}
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} ${COMMON_OPTS} ${JDBC_OPTS}"
-fi
-final_java_opt="${JAVA_OPTS}"
-else
if [[ -z ${JAVA_OPTS_FOR_JDK_9} ]]; then
JAVA_OPTS_FOR_JDK_9="-Xmx1024m ${LOG_PATH}
-Xlog:gc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} ${COMMON_OPTS} ${JDBC_OPTS}"
fi
final_java_opt="${JAVA_OPTS_FOR_JDK_9}"
+else
+if [[ -z ${JAVA_OPTS} ]]; then
+JAVA_OPTS="-Xmx1024m ${LOG_PATH}
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} ${COMMON_OPTS} ${JDBC_OPTS}"
+fi
+final_java_opt="${JAVA_OPTS}"
fi
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
diff --git a/conf/be.conf b/conf/be.conf
index dcb9135813..4604d2b9ad 100644
--- a/conf/be.conf
+++ b/conf/be.conf
@@ -18,10 +18,10 @@
PPROF_TMPDIR="$DORIS_HOME/log/"
CUR_DATE=`date +%Y%m%d-%H%M%S`
-JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
+JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30 -DJDBC_MAX_WAIT_TIME=5000"
# For jdk 9+, this JAVA_OPTS will be used as default JVM options
-JAVA_OPTS_FOR_JDK_9="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xlog:gc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
+JAVA_OPTS_FOR_JDK_9="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xlog:gc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30 -DJDBC_MAX_WAIT_TIME=5000"
# since 1.2, the JAVA_HOME need to be set to run BE process.
# JAVA_HOME=/path/to/jdk/
diff --git a/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
b/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
index 2dfb81020d..e6ef69196f 100644
--- a/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
+++ b/fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java
@@ -76,6 +76,7 @@ public class JdbcExecutor {
private int maxPoolSize;
private int minIdleSize;
private int maxIdelTime;
+private int maxWaitTime;
public JdbcExecutor(byte[] thriftParams) throws Exception {
TJdbcExecutorCtorParams request = new TJdbcExecutorCtorParams();
@@ -88,11 +89,13 @@ public class JdbcExecutor {
minPoolSize = Integer.valueOf(System.getProperty("JDBC_MIN_POOL",
"1"));
maxPoolSize = Integer.valueOf(System.getProperty("JDBC_MAX_POOL",
"100"));
maxIdelTime = Integer.valueOf(System.getProperty("JDBC_MAX_IDEL_TIME",
"30"));
+maxWaitTime = Integer.valueOf(System.getProperty("JDBC_MAX_WAIT_TIME",
"5000"));
minIdleSize = minPoolSize > 0 ? 1 : 0;
LOG.info("JdbcExecutor set minPoolSize = " + minPoolSize
+ ", maxPoolSize = " + maxPoolSize
+ ", maxIdelTime = " + maxIdelTime
-+ ", minIdleSize = " + minIdleSize);
++ ", minIdleSize = " + minIdleSize
++ ", maxWaitTime = " + maxWaitTime);
init(request.driver_path, request.statement, request.batch_size,
request.jdbc_driver_class,
request.jdbc_url, request.jdbc_user, reque
[GitHub] [doris] morningman merged pull request #20687: [1.2][improvement](jdbc) Set the JDBC connection timeout to be configurable
morningman merged PR #20687: URL: https://github.com/apache/doris/pull/20687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20696: [fix](mtmv)create mtmv failed when not specifying refresh strategy
github-actions[bot] commented on PR #20696: URL: https://github.com/apache/doris/pull/20696#issuecomment-1586811397 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20696: [fix](mtmv)create mtmv failed when not specifying refresh strategy
github-actions[bot] commented on PR #20696: URL: https://github.com/apache/doris/pull/20696#issuecomment-1586811461 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhengzhou-spark opened a new issue, #20705: Right expr of binary predicate should be value
zhengzhou-spark opened a new issue, #20705: URL: https://github.com/apache/doris/issues/20705 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description 删除语句中的动态条件，目前版本是不支持的。如果执行SQL语句： delete from db.table where stat_date >= date_sub(CURRENT_DATE(), interval 7 day); 报错： SQL 错误 [1105] [HY000]: errCode = 2, detailMessage = Right expr of binary predicate should be value Doris后续版本能否支持这个动态删除条件？哪个版本能够支持？实时数仓中，类似"删除昨天的数据"场景是比较多的。 ### Solution from db.table where stat_date >= date_sub(CURRENT_DATE(), interval 7 day);能够正常执行，不报错。 ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20108: [fix](mtmv)all mv add manual job
github-actions[bot] commented on PR #20108: URL: https://github.com/apache/doris/pull/20108#issuecomment-1586816248 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1586819163 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586825146 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on a diff in pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen commented on code in PR #20679:
URL: https://github.com/apache/doris/pull/20679#discussion_r1226267783
##
fe/fe-core/src/main/java/org/apache/doris/planner/external/HiveScanNode.java:
##
@@ -192,12 +195,50 @@ private void getFileSplitByPartitions(HiveMetaStoreCache
cache, List splitFile(Path path, long blockSize, BlockLocation[]
blockLocations, long length,
Review Comment:
ok
##
fe/fe-core/src/main/java/org/apache/doris/common/util/BrokerUtil.java:
##
@@ -114,17 +114,19 @@ public static String printBroker(String brokerName,
TNetworkAddress address) {
public static List parseColumnsFromPath(String filePath,
List columnsFromPath)
throws UserException {
-return parseColumnsFromPath(filePath, columnsFromPath, true);
+return parseColumnsFromPath(filePath, columnsFromPath, true, false);
}
public static List parseColumnsFromPath(
String filePath,
List columnsFromPath,
-boolean caseSensitive)
+boolean caseSensitive,
+boolean isACID)
throws UserException {
if (columnsFromPath == null || columnsFromPath.isEmpty()) {
return Collections.emptyList();
}
+int pathCount = isACID ? 3 : 2;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xzj7019 commented on a diff in pull request #20642: [tpcds](nereids) estimate distribution cost by byte size instead of row count
xzj7019 commented on code in PR #20642:
URL: https://github.com/apache/doris/pull/20642#discussion_r1226268711
##
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##
@@ -191,7 +191,7 @@ public Cost visitPhysicalDistribute(
return CostV1.of(
0,
0,
-childStatistics.getRowCount() * Math.pow(beNumber, 0.5));
Review Comment:
In cost model v1, we use row count as the unified metrics to measure the
cost. So here we would better to also use row-count based cost system, if we
need to distinguish the distribute cost for different cases, we can use a
factor parameter using dataSize as the input with a minimal value 1.
##
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##
@@ -161,27 +161,27 @@ public Cost
visitPhysicalPartitionTopN(PhysicalPartitionTopN par
@Override
public Cost visitPhysicalDistribute(
PhysicalDistribute distribute, PlanContext
context) {
+int kBytes = 1024;
Statistics childStatistics = context.getChildStatistics(0);
DistributionSpec spec = distribute.getDistributionSpec();
+int beNumber =
ConnectContext.get().getEnv().getClusterInfo().getBackendsNumber(true);
+beNumber = Math.max(1, beNumber);
+double dataSize = childStatistics.computeSize() / kBytes; // in K bytes
// shuffle
if (spec instanceof DistributionSpecHash) {
return CostV1.of(
0,
0,
-childStatistics.getRowCount());
Review Comment:
In cost model v1, we use row count as the unified metrics to measure the
cost. So here we would better to also use row-count based cost system, if we
need to distinguish the distribute cost for different cases, we can use a
factor parameter using dataSize as the input with a minimal value 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #20642: [tpcds](nereids) estimate distribution cost by byte size instead of row count
englefly commented on code in PR #20642:
URL: https://github.com/apache/doris/pull/20642#discussion_r1226270669
##
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##
@@ -161,27 +161,27 @@ public Cost
visitPhysicalPartitionTopN(PhysicalPartitionTopN par
@Override
public Cost visitPhysicalDistribute(
PhysicalDistribute distribute, PlanContext
context) {
+int kBytes = 1024;
Statistics childStatistics = context.getChildStatistics(0);
DistributionSpec spec = distribute.getDistributionSpec();
+int beNumber =
ConnectContext.get().getEnv().getClusterInfo().getBackendsNumber(true);
+beNumber = Math.max(1, beNumber);
+double dataSize = childStatistics.computeSize() / kBytes; // in K bytes
// shuffle
if (spec instanceof DistributionSpecHash) {
return CostV1.of(
0,
0,
-childStatistics.getRowCount());
Review Comment:
ok, let's do it in next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [fix](routine-load) fix stackoverflow bug in routine load #20704
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 4c942d7e38 [fix](routine-load) fix stackoverflow bug in routine load
#20704
4c942d7e38 is described below
commit 4c942d7e38dad7c405901abda800a26c974995f3
Author: morningman
AuthorDate: Mon Jun 12 16:22:53 2023 +0800
[fix](routine-load) fix stackoverflow bug in routine load #20704
cherry-pick #20704
---
.../java/org/apache/doris/analysis/DataDescription.java | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
index 4755825d40..974f90ea72 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
@@ -729,13 +729,16 @@ public class DataDescription {
// hadoop load only supports the FunctionCallExpr
Expr child1 = predicate.getChild(1);
if (isHadoopLoad && !(child1 instanceof FunctionCallExpr)) {
-throw new AnalysisException("Hadoop load only supports the
designated function. "
-+ "The error mapping function is:" + child1.toSql());
+throw new AnalysisException(
+"Hadoop load only supports the designated function. "
+ "The error mapping function is:"
++ child1.toSql());
}
-ImportColumnDesc importColumnDesc = new ImportColumnDesc(column,
child1);
+// Must clone the expr, because in routine load, the expr will be
analyzed for each task.
+Expr cloned = child1.clone();
+ImportColumnDesc importColumnDesc = new ImportColumnDesc(column,
cloned);
parsedColumnExprList.add(importColumnDesc);
-if (child1 instanceof FunctionCallExpr) {
-analyzeColumnToHadoopFunction(column, child1);
+if (cloned instanceof FunctionCallExpr) {
+analyzeColumnToHadoopFunction(column, cloned);
}
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly merged pull request #20642: [tpcds](nereids) estimate distribution cost by byte size instead of row count
englefly merged PR #20642: URL: https://github.com/apache/doris/pull/20642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load
morningman commented on PR #20704: URL: https://github.com/apache/doris/pull/20704#issuecomment-1586829299 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
github-actions[bot] commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586829720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (ea264ce9de -> 141813b476)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from ea264ce9de [Opt](join) short circuit probe for join node (#20585) add 141813b476 [tpcds](nereids) estimate distribution cost by byte size instead of row count (#20642) No new revisions were added by this update. Summary of changes: .../org/apache/doris/nereids/cost/CostModelV1.java | 16 ++-- .../org/apache/doris/system/SystemInfoService.java | 2 +- .../nereids_tpcds_shape_sf100_p0/shape/query11.out | 32 .../nereids_tpcds_shape_sf100_p0/shape/query18.out | 8 +- .../nereids_tpcds_shape_sf100_p0/shape/query2.out | 28 --- .../nereids_tpcds_shape_sf100_p0/shape/query26.out | 12 +-- .../nereids_tpcds_shape_sf100_p0/shape/query30.out | 13 +-- .../nereids_tpcds_shape_sf100_p0/shape/query31.out | 36 .../nereids_tpcds_shape_sf100_p0/shape/query33.out | 28 +++ .../nereids_tpcds_shape_sf100_p0/shape/query35.out | 37 + .../nereids_tpcds_shape_sf100_p0/shape/query38.out | 14 ++-- .../nereids_tpcds_shape_sf100_p0/shape/query4.out | 32 .../nereids_tpcds_shape_sf100_p0/shape/query44.out | 96 +++--- .../nereids_tpcds_shape_sf100_p0/shape/query45.out | 30 +++ .../nereids_tpcds_shape_sf100_p0/shape/query46.out | 55 +++-- .../nereids_tpcds_shape_sf100_p0/shape/query56.out | 38 - .../nereids_tpcds_shape_sf100_p0/shape/query59.out | 7 +- .../nereids_tpcds_shape_sf100_p0/shape/query6.out | 19 +++-- .../nereids_tpcds_shape_sf100_p0/shape/query60.out | 36 .../nereids_tpcds_shape_sf100_p0/shape/query65.out | 59 ++--- .../nereids_tpcds_shape_sf100_p0/shape/query72.out | 84 +-- .../nereids_tpcds_shape_sf100_p0/shape/query74.out | 22 ++--- .../nereids_tpcds_shape_sf100_p0/shape/query75.out | 5 +- .../nereids_tpcds_shape_sf100_p0/shape/query81.out | 17 ++-- .../nereids_tpcds_shape_sf100_p0/shape/query84.out | 28 +++ .../nereids_tpcds_shape_sf100_p0/shape/query87.out | 14 ++-- .../nereids_tpcds_shape_sf100_p0/shape/query91.out | 15 ++-- .../nereids_tpch_shape_sf1000_p0/shape/q10.out | 8 +- .../nereids_tpch_shape_sf1000_p0/shape/q16.out | 29 --- .../data/nereids_tpch_shape_sf1000_p0/shape/q2.out | 32 .../data/nereids_tpch_shape_sf500_p0/shape/q10.out | 8 +- .../data/nereids_tpch_shape_sf500_p0/shape/q16.out | 29 --- .../data/nereids_tpch_shape_sf500_p0/shape/q2.out | 32 33 files changed, 472 insertions(+), 449 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
github-actions[bot] commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586834153 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
github-actions[bot] commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586834222 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #20683: [test](regression) update some case in p2
Mryange commented on PR #20683: URL: https://github.com/apache/doris/pull/20683#issuecomment-1586855887 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liaoxin01 opened a new pull request, #20706: [Enhancement](merge-on-write) parallel calculate delete bitmap when tablet has multi segments
liaoxin01 opened a new pull request, #20706: URL: https://github.com/apache/doris/pull/20706 ## Proposed changes Issue Number: close #xxx In order to accelerate the processing time of publish for merge-on-write table，parallel calculate delete bitmap when tablet has multi segments. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #20707: [Fix](planner)inplement foldable function to_monday() on fe
sohardforaname opened a new pull request, #20707: URL: https://github.com/apache/doris/pull/20707 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20706: [Enhancement](merge-on-write) parallel calculate delete bitmap when tablet has multi segments
github-actions[bot] commented on PR #20706: URL: https://github.com/apache/doris/pull/20706#issuecomment-1586864883 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
BiteThet commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586867470 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20701: [Fix](planner)fix cast yyyy-mm-31 incorrectly in original planner for 1.2
sohardforaname commented on PR #20701: URL: https://github.com/apache/doris/pull/20701#issuecomment-1586869800 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20700: [Fix](planner)fix create table like stmt from a table distributed by random error.
sohardforaname commented on PR #20700: URL: https://github.com/apache/doris/pull/20700#issuecomment-1586869953 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20685: [Fix](planner)fix cast yyyy-mm-31 incorrectly in original planner and Nereids
sohardforaname commented on PR #20685: URL: https://github.com/apache/doris/pull/20685#issuecomment-1586870309 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20607: [Fix](Nereids)add foldable function timestamp()
sohardforaname commented on PR #20607: URL: https://github.com/apache/doris/pull/20607#issuecomment-1586870534 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #20694: [enhancement](insert-stmt) Make `insert into tbl values();` compatible with mysql
TangSiyang2001 commented on PR #20694: URL: https://github.com/apache/doris/pull/20694#issuecomment-1586873639 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
github-actions[bot] commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586874529 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname opened a new pull request, #20708: [Fix](planner)inplement foldable function to_monday() on fe for master
sohardforaname opened a new pull request, #20708: URL: https://github.com/apache/doris/pull/20708 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yagagagaga opened a new pull request, #19998: [typo](docs) fix some mistake in Doris & Spark Column Type Mapping
yagagagaga opened a new pull request, #19998: URL: https://github.com/apache/doris/pull/19998 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [x] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #20708: [Fix](planner)inplement foldable function to_monday() on fe for master
sohardforaname commented on PR #20708: URL: https://github.com/apache/doris/pull/20708#issuecomment-1586876038 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei closed issue #17417: [Feature] (array function) support array_pushback function
yiguolei closed issue #17417: [Feature] (array function) support array_pushback function URL: https://github.com/apache/doris/issues/17417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19988: [Feature](array-function) Support array_pushback function #17417
yiguolei merged PR #19988: URL: https://github.com/apache/doris/pull/19988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Feature](array-function) Support array_pushback function #17417 (#19988)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 99c0592157 [Feature](array-function) Support array_pushback function
#17417 (#19988)
99c0592157 is described below
commit 99c059215702f321632e987b244d27cb3a6a073d
Author: jiawei liang <72728602+liangjiawei1...@users.noreply.github.com>
AuthorDate: Mon Jun 12 16:51:12 2023 +0800
[Feature](array-function) Support array_pushback function #17417 (#19988)
Implement array_pushback.
mysql> select array_pushback([1, 2], 3);
++
| array_pushback(ARRAY(1, 2), 3) |
++
| [1, 2, 3] |
++
1 row in set (0.01 sec)
---
.../functions/array/function_array_pushback.cpp| 120 +++
.../functions/array/function_array_register.cpp| 2 +
.../array-functions/array_pushback.md | 84 +
docs/sidebars.json | 1 +
.../array-functions/array_pushback.md | 84 +
.../apache/doris/analysis/FunctionCallExpr.java| 2 +
gensrc/script/doris_builtins_functions.py | 19 +++
.../array_functions/test_array_functions.out | 132 +
.../test_array_functions_by_literal.out| 33 ++
.../array_functions/test_array_with_scale_type.out | 20
.../array_functions/test_array_functions.groovy| 13 ++
.../test_array_functions_by_literal.groovy | 13 ++
.../test_array_with_scale_type.groovy | 6 +
13 files changed, 529 insertions(+)
diff --git a/be/src/vec/functions/array/function_array_pushback.cpp
b/be/src/vec/functions/array/function_array_pushback.cpp
new file mode 100644
index 00..b7b83f7f6d
--- /dev/null
+++ b/be/src/vec/functions/array/function_array_pushback.cpp
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+//
https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arrayIndex.h
+// and modified by Doris
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column.h"
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/columns/column_nullable.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/column_with_type_and_name.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type.h"
+#include "vec/data_types/data_type_nullable.h"
+#include "vec/functions/function.h"
+#include "vec/functions/simple_function_factory.h"
+
+namespace doris {
+class FunctionContext;
+} // namespace doris
+
+namespace doris::vectorized {
+class FunctionArrayPushback : public IFunction {
+public:
+static constexpr auto name = "array_pushback";
+
+static FunctionPtr create() { return
std::make_shared(); }
+
+String get_name() const override { return name; }
+
+bool is_variadic() const override { return false; }
+
+size_t get_number_of_arguments() const override { return 2; }
+
+bool use_default_implementation_for_nulls() const override { return false;
}
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+return
std::make_shared(remove_nullable(arguments[0]));
+};
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) override {
+const auto& [src_column, src_const] =
+unpack_if_const(block.get_by_position(arguments[0]).column);
+const auto& [right_column, right_const] =
+unpack_if_const(block.get_by_position(arguments[1]).column);
+// extract src array column
+const ColumnArray* array_column = nullptr;
+const UInt8* array_null_map = nullptr;
+if (src_column->is_nullable()) {
+auto nullable_array = sta
[GitHub] [doris] starocean999 opened a new pull request, #20709: [fix](planner)cast string literal to date like type should not be an implict cast
starocean999 opened a new pull request, #20709: URL: https://github.com/apache/doris/pull/20709 ## Proposed changes 1. cast string literal to date like type should not be an implict cast 2. the string representation of float like type should not be scientific notation 3. the data type of like function's regex expr should be string type even if it's a null literal 4. add -Xss4m in fe.conf to prevent stack overflow in some case ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] starocean999 commented on pull request #20709: [fix](planner)cast string literal to date like type should not be an implict cast
starocean999 commented on PR #20709: URL: https://github.com/apache/doris/pull/20709#issuecomment-1586894712 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19685: [feature-wip](auto_partition) support automatic partition
github-actions[bot] commented on PR #19685: URL: https://github.com/apache/doris/pull/19685#issuecomment-1586896050 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20698: [fix](columnstring) fix bug of columnstring prefetch
yiguolei merged PR #20698: URL: https://github.com/apache/doris/pull/20698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](columnstring) fix bug of columnstring prefetch (#20698)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9d47c6a871 [fix](columnstring) fix bug of columnstring prefetch
(#20698)
9d47c6a871 is described below
commit 9d47c6a871cf6ce48f7e1cc7a6b4581f9f1cee2a
Author: TengJianPing <18241664+jackte...@users.noreply.github.com>
AuthorDate: Mon Jun 12 17:03:44 2023 +0800
[fix](columnstring) fix bug of columnstring prefetch (#20698)
---
be/src/vec/columns/column_string.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/vec/columns/column_string.cpp
b/be/src/vec/columns/column_string.cpp
index 81ee29a70f..e5bab2899f 100644
--- a/be/src/vec/columns/column_string.cpp
+++ b/be/src/vec/columns/column_string.cpp
@@ -113,7 +113,7 @@ void ColumnString::insert_indices_from(const IColumn& src,
const int* indices_be
if (*x == -1) {
ColumnString::insert_default();
} else {
-if (x + IColumn::PREFETCH_STEP < indices_end) {
+if (x + IColumn::PREFETCH_STEP < indices_end && (-1 !=
x[IColumn::PREFETCH_STEP])) {
ColumnString::prefetch(src, *(x + IColumn::PREFETCH_STEP));
}
ColumnString::insert_from(src, *x);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #20696: [fix](mtmv)create mtmv failed when not specifying refresh strategy
yiguolei commented on PR #20696: URL: https://github.com/apache/doris/pull/20696#issuecomment-1586906144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load
github-actions[bot] commented on PR #20704: URL: https://github.com/apache/doris/pull/20704#issuecomment-1586911773 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20704: [fix](routine-load) fix stackoverflow bug in routine load
github-actions[bot] commented on PR #20704: URL: https://github.com/apache/doris/pull/20704#issuecomment-1586911628 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hechao-ustc commented on issue #20703: [Bug] JDBC [INTERNAL_ERROR]NoSuchFieldError: table_type
hechao-ustc commented on issue #20703: URL: https://github.com/apache/doris/issues/20703#issuecomment-1586932843 查询的数据源是什么？fe.log中报错的堆栈信息可以发下吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #20710: [Bug](pipeline) fix memory leak because pipeline shared ptr not release
BiteThet opened a new pull request, #20710: URL: https://github.com/apache/doris/pull/20710 ## Proposed changes fix memory leak because pipeline shared ptr not release ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20710: [Bug](pipeline) fix memory leak because pipeline shared ptr not release
BiteThet commented on PR #20710: URL: https://github.com/apache/doris/pull/20710#issuecomment-1586935133 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20710: [Bug](pipeline) fix memory leak because pipeline shared ptr not release
github-actions[bot] commented on PR #20710: URL: https://github.com/apache/doris/pull/20710#issuecomment-1586940305 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz opened a new pull request, #20711: [fix](case expr) fix coredump of case for null value 3
xinyiZzz opened a new pull request, #20711: URL: https://github.com/apache/doris/pull/20711 ## Proposed changes better fix about #20635 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #20711: [fix](case expr) fix coredump of case for null value 3
xinyiZzz commented on PR #20711: URL: https://github.com/apache/doris/pull/20711#issuecomment-1586945112 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #20600: [Fix](Planner) Add tinyint result support in where, having and on clause
morningman merged PR #20600: URL: https://github.com/apache/doris/pull/20600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586946977 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [Fix](Planner) Add tinyint result support in where, having and on clause (#20600)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 049b5c4907 [Fix](Planner) Add tinyint result support in where, having
and on clause (#20600)
049b5c4907 is described below
commit 049b5c4907a9ace7cf30a8b3efd30adac1f64c0b
Author: LiBinfeng <46676950+libinfeng...@users.noreply.github.com>
AuthorDate: Mon Jun 12 17:26:06 2023 +0800
[Fix](Planner) Add tinyint result support in where, having and on clause
(#20600)
Enable planner of using tinyint as expr return type like: select *** from
*** where case when *** then 1 else 0 end;
---
.../main/java/org/apache/doris/catalog/Type.java | 4 ++
.../main/java/org/apache/doris/analysis/Expr.java | 2 +-
.../suites/query_p0/cast/test_cast.groovy | 55 ++
3 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
b/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
index 671da2c252..10a0b7d6f7 100644
--- a/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
+++ b/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
@@ -260,6 +260,10 @@ public abstract class Type {
return isScalarType(PrimitiveType.BOOLEAN);
}
+public boolean isTinyint() {
+return isScalarType(PrimitiveType.TINYINT);
+}
+
public boolean isDecimalV2() {
return isScalarType(PrimitiveType.DECIMALV2);
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
index abed221866..c5a4f81bac 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
@@ -1324,7 +1324,7 @@ public abstract class Expr extends TreeNode
implements ParseNode, Cloneabl
* The error message only contains this.toSql() if printExpr is true.
*/
public void checkReturnsBool(String name, boolean printExpr) throws
AnalysisException {
-if (!type.isBoolean() && !type.isNull()) {
+if (!type.isBoolean() && !type.isNull() && !type.isTinyint()) {
if (this instanceof BoolLiteral) {
return;
}
diff --git a/regression-test/suites/query_p0/cast/test_cast.groovy
b/regression-test/suites/query_p0/cast/test_cast.groovy
new file mode 100644
index 00..dcd04b076f
--- /dev/null
+++ b/regression-test/suites/query_p0/cast/test_cast.groovy
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite('test_cast') {
+def date = "date '2020-01-01'"
+def datev2 = "datev2 '2020-01-01'"
+def datetime = "timestamp '2020-01-01 12:34:45'"
+def tbl = "test_cast"
+
+sql """ DROP TABLE IF EXISTS ${tbl}"""
+sql """
+CREATE TABLE IF NOT EXISTS ${tbl} (
+`k0` int
+)
+DISTRIBUTED BY HASH(`k0`) BUCKETS 5 properties("replication_num" = "1")
+"""
+sql """ INSERT INTO ${tbl} VALUES (101);"""
+
+test {
+sql "select * from ${tbl} where case when k0 = 101 then 1 else 0 end"
+result([[101]])
+}
+
+test {
+sql "select * from ${tbl} where case when k0 = 101 then 0 else 1 end"
+result([])
+}
+
+test {
+sql "select cast(${date} as int), cast(${date} as bigint),
cast(${date} as float), cast(${date} as double)"
+result([[20200101, 20200101l, ((float) 20200101), ((double)
20200101)]])
+}
+test {
+sql "select cast(${datev2} as int), cast(${datev2} as bigint),
cast(${datev2} as float), cast(${datev2} as double)"
+result([[20200101, 20200101l, ((float) 20200101), ((double)
20200101)]])
+}
+test {
+sql "select cast(${datetime} as int), cast(${datetime} as bigint),
cast(${datetime} as float), cast(${datetime} as double)"
+result([[869930357, 20200101123445l, ((float) 20200101123445l),
((double) 20200101123445l)]])
+}
+}
-
[GitHub] [doris] github-actions[bot] commented on pull request #20711: [fix](case expr) fix coredump of case for null value 3
github-actions[bot] commented on PR #20711: URL: https://github.com/apache/doris/pull/20711#issuecomment-1586951774 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [fix](planner) fix RewriteInPredicateRule may be useless (#20668)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new d6a632972b [fix](planner) fix RewriteInPredicateRule may be useless
(#20668)
d6a632972b is described below
commit d6a632972bcff5b81363cbac9c0b45450735653c
Author: zxealous
AuthorDate: Mon Jun 12 14:39:01 2023 +0800
[fix](planner) fix RewriteInPredicateRule may be useless (#20668)
Issue Number: close #20669
RewriteInPredicateRule may cast InPredicate expr's two child to the same
type, for example: where cast(age as char) in ('11'), the type of age is int,
RewriteInPredicateRule will cast expr's two child type to int. As in the
example above, child 0 will be such struct:
```
child 0: type: int
|--- child: type : char
|-- child: type : int
```
Due to the RewriteInPredicateRule cast the type of the expr to int, it will
reanalyze stmt, but it will reset stmt first before reanalyze the stmt, and
reset opt will change child 0 to such struct:
```
child: type : char
|-- child: type : int
```
It cause two child's type will be cast to varchar in func
castAllToCompatibleType, the logic of RewriteInPredicateRule will be useless.
In 1.1-lts and 1.2-lts, such case " where cast(age as char) in ('11')"
can't work well, because func castAllToCompatibleType will cast int to char
but int can't cast to char(master can work well because func
castAllToCompatibleType will cast int to varchar in such case).
```
MySQL [test]> select user_id from test_cast where cast(age as char) in
('45');
ERROR 1105 (HY000): errCode = 2, detailMessage = type not match,
originType=INT, targeType=CHAR(*)
```
---
.../org/apache/doris/rewrite/RewriteInPredicateRule.java | 14 --
.../sql_functions/conditional_functions/test_query_in.out | 3 +++
.../conditional_functions/test_query_in.groovy | 1 +
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java
index ea7996c3fc..acf26abffb 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/RewriteInPredicateRule.java
@@ -19,6 +19,7 @@ package org.apache.doris.rewrite;
import org.apache.doris.analysis.Analyzer;
import org.apache.doris.analysis.BoolLiteral;
+import org.apache.doris.analysis.CastExpr;
import org.apache.doris.analysis.Expr;
import org.apache.doris.analysis.InPredicate;
import org.apache.doris.analysis.LiteralExpr;
@@ -68,8 +69,17 @@ public class RewriteInPredicateRule implements
ExprRewriteRule {
return expr;
}
-Expr newColumnExpr = expr.getChild(0).getType().getPrimitiveType() ==
columnType.getPrimitiveType()
-? expr.getChild(0) : expr.getChild(0).castTo(columnType);
+Expr newColumnExpr;
+if (expr.getChild(0).getType().getPrimitiveType() ==
columnType.getPrimitiveType()) {
+newColumnExpr = expr.getChild(0);
+} else {
+if (inPredicate.getChild(0) instanceof CastExpr &&
inPredicate.getChild(0).getChild(0).getType()
+.equals(columnType)) {
+newColumnExpr = inPredicate.getChild(0).getChild(0);
+} else {
+newColumnExpr = expr.getChild(0).castTo(columnType);
+}
+}
List newInList = Lists.newArrayList();
boolean isCast = false;
for (int i = 1; i < inPredicate.getChildren().size(); ++i) {
diff --git
a/regression-test/data/query_p0/sql_functions/conditional_functions/test_query_in.out
b/regression-test/data/query_p0/sql_functions/conditional_functions/test_query_in.out
index 0ecbaff177..9c076298e9 100644
---
a/regression-test/data/query_p0/sql_functions/conditional_functions/test_query_in.out
+++
b/regression-test/data/query_p0/sql_functions/conditional_functions/test_query_in.out
@@ -100,3 +100,6 @@ jj -28532
-- !in31 --
jj -28532
+-- !in32 --
+false 1 1989100111011902123.123 true1989-03-21
1989-03-21T13:00wangjuoo4 0.1 6.333 string12345
170141183460469231731687303715884105727
+false 3 198910021101190524453.325 false
2012-03-14 2000-01-01T00:00yunlj8@nk 78945.0 3654.0
string12345 0
diff --git
a/regression-test/suites/query_p0/sql_functions/conditional_functions/test_query_in.groovy
b/regression-test/suites/query_p0/sql_functions/conditional_functions/test_query_in.groovy
index f35517712c..0e98327927 100644
---
a/regression-test/suites/query_p0/sql_functions/conditional_func
[GitHub] [doris] englefly opened a new pull request, #20713: [tpcds](nereids)adjust cost model for BroadCastJoin and PartitionJoin
englefly opened a new pull request, #20713: URL: https://github.com/apache/doris/pull/20713 ## Proposed changes good for ds15/44 Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuxuan-luo commented on issue #20703: [Bug] JDBC [INTERNAL_ERROR]NoSuchFieldError: table_type
yuxuan-luo commented on issue #20703: URL: https://github.com/apache/doris/issues/20703#issuecomment-1586970087 > 查询的数据源是什么？fe.log中报错的堆栈信息可以发下吗？ mysql 8.0 https://github.com/apache/doris/assets/119841515/c6fe1c83-4136-45a2-bc00-72d0e7f2fc3c";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586970248 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (9d47c6a871 -> 153f91f77e)
This is an automated email from the ASF dual-hosted git repository. diwu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9d47c6a871 [fix](columnstring) fix bug of columnstring prefetch (#20698) add 153f91f77e [typo](doc) Update doc for newly released 1.2.0 version of spark connector (#20639) No new revisions were added by this update. Summary of changes: docs/en/docs/ecosystem/spark-doris-connector.md| 15 --- docs/zh-CN/docs/ecosystem/spark-doris-connector.md | 15 --- 2 files changed, 16 insertions(+), 14 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JNSimba merged pull request #20639: [typo](doc) Update doc for newly released 1.2.0 version of spark connector
JNSimba merged PR #20639: URL: https://github.com/apache/doris/pull/20639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xzj7019 opened a new pull request, #20714: [feature](nereids) Support multi target rf
xzj7019 opened a new pull request, #20714: URL: https://github.com/apache/doris/pull/20714 ## Proposed changes Issue Number: close #xxx Support multi target runtime filter, mainly for set operation, such as union/intersect/except. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #20714: [feature](nereids) Support multi target rf
Kikyou1997 commented on PR #20714: URL: https://github.com/apache/doris/pull/20714#issuecomment-1586975702 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xzj7019 commented on pull request #20714: [feature](nereids) Support multi target rf
xzj7019 commented on PR #20714: URL: https://github.com/apache/doris/pull/20714#issuecomment-1586975888 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20714: [feature](nereids) Support multi target rf
github-actions[bot] commented on PR #20714: URL: https://github.com/apache/doris/pull/20714#issuecomment-1586979625 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20645: [typo](doc)document optimization
github-actions[bot] commented on PR #20645: URL: https://github.com/apache/doris/pull/20645#issuecomment-1586985783 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20645: [typo](doc)document optimization
github-actions[bot] commented on PR #20645: URL: https://github.com/apache/doris/pull/20645#issuecomment-1586985839 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #20108: [fix](MTMV) Support refreshing data manually
adonis0147 merged PR #20108: URL: https://github.com/apache/doris/pull/20108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 closed issue #20105: [Bug] When refreshing the mv, prompt no job
adonis0147 closed issue #20105: [Bug] When refreshing the mv, prompt no job URL: https://github.com/apache/doris/issues/20105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
