[GitHub] [doris] dataroaring merged pull request #20662: [Bug](load) fix crash when be exit
dataroaring merged PR #20662: URL: https://github.com/apache/doris/pull/20662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](streamload) fix crash when be exit (#20662)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8ea61a1ce6 [fix](streamload) fix crash when be exit (#20662)
8ea61a1ce6 is described below
commit 8ea61a1ce61fe9287380fd2efd03e5b0243ff349
Author: HHoflittlefish777 <77738092+hhoflittlefish...@users.noreply.github.com>
AuthorDate: Sun Jun 11 15:58:44 2023 +0800
[fix](streamload) fix crash when be exit (#20662)
---
be/src/runtime/exec_env_init.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/be/src/runtime/exec_env_init.cpp b/be/src/runtime/exec_env_init.cpp
index fb14db11f3..e803fd0da9 100644
--- a/be/src/runtime/exec_env_init.cpp
+++ b/be/src/runtime/exec_env_init.cpp
@@ -411,6 +411,7 @@ void ExecEnv::_destroy() {
// info is deconstructed then BE process will core at coordinator back
method in fragment mgr.
SAFE_DELETE(_master_info);
+_new_load_stream_mgr.reset();
_send_batch_thread_pool.reset(nullptr);
_buffered_reader_prefetch_thread_pool.reset(nullptr);
_send_report_thread_pool.reset(nullptr);
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian closed pull request #20660: [doc](ssl) add doc for ssl jdbc
Yukang-Lian closed pull request #20660: [doc](ssl) add doc for ssl jdbc URL: https://github.com/apache/doris/pull/20660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian opened a new pull request, #20671: [fix](ssl) fix some version of jdbc may result connect error
Yukang-Lian opened a new pull request, #20671: URL: https://github.com/apache/doris/pull/20671 ## Proposed changes Issue Number: close #20365 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on pull request #20671: [fix](ssl) fix some version of jdbc may result connect error
Yukang-Lian commented on PR #20671: URL: https://github.com/apache/doris/pull/20671#issuecomment-1586083548 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SaintBacchus commented on pull request #20241: [Regression](MTMV)Use lock instead of tryLock to get the jobManager lock
SaintBacchus commented on PR #20241: URL: https://github.com/apache/doris/pull/20241#issuecomment-1586086450 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yuanyuan8983 opened a new pull request, #20672: [typo](docs) add parameter version
yuanyuan8983 opened a new pull request, #20672: URL: https://github.com/apache/doris/pull/20672 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586087978 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hk-lrzy commented on pull request #18640: [enhancement](storage) lazy-open necessary partitions when load
hk-lrzy commented on PR #18640: URL: https://github.com/apache/doris/pull/18640#issuecomment-1586089238 I see the PR no progress right now, can we continue it, it's very very important for us. BTW, if @ freemandealer have no time to finish it, maybe i can do this job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586093706 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zxealous commented on pull request #20668: [fix](planner) fix RewriteInPredicateRule may be useless
zxealous commented on PR #20668: URL: https://github.com/apache/doris/pull/20668#issuecomment-1586097293 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #20654: [doc](create-function) Update CREATE-FUNCTION.md to remove the usage of c++
yiguolei commented on PR #20654: URL: https://github.com/apache/doris/pull/20654#issuecomment-1586098016 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic (#20480)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8162d0062b [fix](alter) fix potential concurrent issue for alter when
check olap table state normal outside write lock scope is not atomic (#20480)
8162d0062b is described below
commit 8162d0062bc42435aaa0145d7a3ebe4629744a55
Author: caiconghui <55968745+caicong...@users.noreply.github.com>
AuthorDate: Sun Jun 11 18:17:41 2023 +0800
[fix](alter) fix potential concurrent issue for alter when check olap table
state normal outside write lock scope is not atomic (#20480)
now, we check some olap table state normal outside write lock scope, the
table state may be changed to unnormal when we do alter operation
-
Co-authored-by: caiconghui1
---
.../main/java/org/apache/doris/alter/Alter.java| 14 ++--
.../doris/alter/MaterializedViewHandler.java | 13 +++-
.../apache/doris/alter/SchemaChangeHandler.java| 14 +---
.../main/java/org/apache/doris/catalog/Env.java| 20 +++-
.../java/org/apache/doris/catalog/OlapTable.java | 18 ++-
.../apache/doris/datasource/InternalCatalog.java | 37 ++
.../apache/doris/service/FrontendServiceImpl.java | 1 +
.../doris/alter/MaterializedViewHandlerTest.java | 2 --
8 files changed, 25 insertions(+), 94 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
index b89cb0b733..ef018b04d2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java
@@ -52,7 +52,6 @@ import org.apache.doris.catalog.MaterializedView;
import org.apache.doris.catalog.MysqlTable;
import org.apache.doris.catalog.OdbcTable;
import org.apache.doris.catalog.OlapTable;
-import org.apache.doris.catalog.OlapTable.OlapTableState;
import org.apache.doris.catalog.Partition;
import org.apache.doris.catalog.PartitionInfo;
import org.apache.doris.catalog.Replica;
@@ -189,11 +188,7 @@ public class Alter {
db.checkQuota();
}
-if (olapTable.getState() != OlapTableState.NORMAL) {
-throw new DdlException(
-"Table[" + olapTable.getName() + "]'s state is not NORMAL.
Do not allow doing ALTER ops");
-}
-
+olapTable.checkNormalStateForAlter();
boolean needProcessOutsideTableLock = false;
if (currentAlterOps.checkTableStoragePolicy(alterClauses)) {
String tableStoragePolicy = olapTable.getStoragePolicy();
@@ -256,7 +251,7 @@ public class Alter {
if
(properties.containsKey(PropertyAnalyzer.PROPERTIES_INMEMORY)) {
boolean isInMemory =
Boolean.parseBoolean(properties.get(PropertyAnalyzer.PROPERTIES_INMEMORY));
-if (isInMemory == true) {
+if (isInMemory) {
throw new UserException("Not support set
'in_memory'='true' now!");
}
needProcessOutsideTableLock = true;
@@ -780,10 +775,7 @@ public class Alter {
throws DdlException, AnalysisException {
Preconditions.checkArgument(olapTable.isWriteLockHeldByCurrentThread());
List modifyPartitionInfos = Lists.newArrayList();
-if (olapTable.getState() != OlapTableState.NORMAL) {
-throw new DdlException("Table[" + olapTable.getName() + "]'s state
is not NORMAL");
-}
-
+olapTable.checkNormalStateForAlter();
for (String partitionName : partitionNames) {
Partition partition = olapTable.getPartition(partitionName,
isTempPartition);
if (partition == null) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
index e54c18a357..baf0fd60f3 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
@@ -185,7 +185,7 @@ public class MaterializedViewHandler extends AlterHandler {
throws DdlException, AnalysisException {
olapTable.writeLockOrDdlException();
try {
-olapTable.checkStableAndNormal(db.getClusterName());
+olapTable.checkNormalStateForAlter();
if (olapTable.existTempPartitions()) {
throw new DdlException("Can not alter table when there are
temp partitions in table");
}
@@ -244,6 +244,7 @@ public class MaterializedViewHandler extends AlterHandler {
Set logJobIdSet = new HashSet<>();
olapTable.writeLockOrDdlE
[GitHub] [doris] yiguolei merged pull request #20480: [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic
yiguolei merged PR #20480: URL: https://github.com/apache/doris/pull/20480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] shuke987 commented on pull request #20607: [Fix](Nereids)add foldable function timestamp()
shuke987 commented on PR #20607: URL: https://github.com/apache/doris/pull/20607#issuecomment-1586112051 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
BiteThet commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586115917 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185:
URL: https://github.com/apache/doris/pull/20185#issuecomment-1586118611
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5235082378";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In build.sh line 636:
for extensions_module in ${extensions_modules[@]}
^--^ SC2068 (error): Double
quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to
...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- build.sh.orig
+++ build.sh
@@ -633,8 +633,7 @@
fi
extensions_modules=("java-udf" "jdbc-scanner" "hudi-scanner"
"paimon-scanner" "max-compute-scanner")
-for extensions_module in ${extensions_modules[@]}
-do
+for extensions_module in ${extensions_modules[@]}; do
module_path="${DORIS_HOME}/fe/be-java-extensions/${extensions_module}/target/${extensions_module}-jar-with-dependencies.jar"
if [[ -f "${module_path}" ]]; then
cp "${module_path}" "${DORIS_OUTPUT}/be/lib"/
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586119647 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185:
URL: https://github.com/apache/doris/pull/20185#issuecomment-1586121739
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5235146455";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In build.sh line 636:
for extensions_module in ${extensions_modules[@]}
^--^ SC2068 (error): Double
quote array expansions to avoid re-splitting elements.
For more information:
https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to
...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- build.sh.orig
+++ build.sh
@@ -633,8 +633,7 @@
fi
extensions_modules=("java-udf" "jdbc-scanner" "hudi-scanner"
"paimon-scanner" "max-compute-scanner")
-for extensions_module in ${extensions_modules[@]}
-do
+for extensions_module in ${extensions_modules[@]}; do
module_path="${DORIS_HOME}/fe/be-java-extensions/${extensions_module}/target/${extensions_module}-jar-with-dependencies.jar"
if [[ -f "${module_path}" ]]; then
cp "${module_path}" "${DORIS_OUTPUT}/be/lib"/
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586122844 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-2.0-beta updated: [bugfix](s3 fs) fix s3 uri parsing for http/https uri (#20656)
This is an automated email from the ASF dual-hosted git repository.
kxiao pushed a commit to branch branch-2.0-beta
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0-beta by this push:
new ee97899deb [bugfix](s3 fs) fix s3 uri parsing for http/https uri
(#20656)
ee97899deb is described below
commit ee97899deb2dfe681f630c76df65dab76319df2b
Author: Kang
AuthorDate: Sun Jun 11 14:00:04 2023 +0800
[bugfix](s3 fs) fix s3 uri parsing for http/https uri (#20656)
---
be/src/util/s3_uri.cpp | 32 +---
be/src/util/s3_uri.h | 3 +++
be/test/util/s3_uri_test.cpp | 29 +
3 files changed, 57 insertions(+), 7 deletions(-)
diff --git a/be/src/util/s3_uri.cpp b/be/src/util/s3_uri.cpp
index 08041fece8..c2e4a72098 100644
--- a/be/src/util/s3_uri.cpp
+++ b/be/src/util/s3_uri.cpp
@@ -25,6 +25,9 @@
namespace doris {
+const std::string S3URI::_SCHEME_S3 = "s3";
+const std::string S3URI::_SCHEME_HTTP = "http";
+const std::string S3URI::_SCHEME_HTTPS = "https";
const std::string S3URI::_SCHEME_DELIM = "://";
const std::string S3URI::_PATH_DELIM = "/";
const std::string S3URI::_QUERY_DELIM = "?";
@@ -42,15 +45,30 @@ Status S3URI::parse() {
std::vector scheme_split = strings::Split(_location,
_SCHEME_DELIM);
std::string rest;
if (scheme_split.size() == 2) {
-// has scheme, eg: s3://bucket1/path/to/file.txt
-rest = scheme_split[1];
-std::vector authority_split =
-strings::Split(rest, strings::delimiter::Limit(_PATH_DELIM,
1));
-if (authority_split.size() != 2) {
+if (scheme_split[0] == _SCHEME_S3) {
+// has scheme, eg: s3://bucket1/path/to/file.txt
+rest = scheme_split[1];
+std::vector authority_split =
+strings::Split(rest,
strings::delimiter::Limit(_PATH_DELIM, 1));
+if (authority_split.size() != 2) {
+return Status::InvalidArgument("Invalid S3 URI: {}",
_location);
+}
+_bucket = authority_split[0];
+_key = authority_split[1];
+} else if (scheme_split[0] == _SCHEME_HTTP || scheme_split[0] ==
_SCHEME_HTTPS) {
+// has scheme, eg: http(s)://host/bucket1/path/to/file.txt
+rest = scheme_split[1];
+std::vector authority_split =
+strings::Split(rest,
strings::delimiter::Limit(_PATH_DELIM, 2));
+if (authority_split.size() != 3) {
+return Status::InvalidArgument("Invalid S3 HTTP URI: {}",
_location);
+}
+// authority_split[1] is host
+_bucket = authority_split[1];
+_key = authority_split[2];
+} else {
return Status::InvalidArgument("Invalid S3 URI: {}", _location);
}
-_bucket = authority_split[0];
-_key = authority_split[1];
} else if (scheme_split.size() == 1) {
// no scheme, eg: path/to/file.txt
_bucket = ""; // unknown
diff --git a/be/src/util/s3_uri.h b/be/src/util/s3_uri.h
index 76ffea5824..769053450b 100644
--- a/be/src/util/s3_uri.h
+++ b/be/src/util/s3_uri.h
@@ -41,6 +41,9 @@ public:
std::string to_string() const;
private:
+static const std::string _SCHEME_S3;
+static const std::string _SCHEME_HTTP;
+static const std::string _SCHEME_HTTPS;
static const std::string _SCHEME_DELIM;
static const std::string _PATH_DELIM;
static const std::string _QUERY_DELIM;
diff --git a/be/test/util/s3_uri_test.cpp b/be/test/util/s3_uri_test.cpp
index ab5192a8a0..93aa2c72eb 100644
--- a/be/test/util/s3_uri_test.cpp
+++ b/be/test/util/s3_uri_test.cpp
@@ -56,13 +56,42 @@ TEST_F(S3URITest, EncodedString) {
EXPECT_EQ("path%20to%20file", uri1.get_key());
}
+TEST_F(S3URITest, HttpURI) {
+std::string p1 = "http://a.b.com/bucket/path/to/file";;
+S3URI uri1(p1);
+EXPECT_TRUE(uri1.parse());
+EXPECT_EQ("bucket", uri1.get_bucket());
+EXPECT_EQ("path/to/file", uri1.get_key());
+
+std::string p2 = "https://a.b.com/bucket/path/to/file";;
+S3URI uri2(p2);
+EXPECT_TRUE(uri2.parse());
+EXPECT_EQ("bucket", uri2.get_bucket());
+EXPECT_EQ("path/to/file", uri2.get_key());
+}
+
+TEST_F(S3URITest, InvalidSchema) {
+std::string p1 = "xxx://a.b.com/bucket/path/to/file";
+S3URI uri1(p1);
+EXPECT_FALSE(uri1.parse());
+}
+
TEST_F(S3URITest, MissingKey) {
std::string p1 = "https://bucket/";;
S3URI uri1(p1);
EXPECT_FALSE(uri1.parse());
+
std::string p2 = "s3://bucket/";
S3URI uri2(p2);
EXPECT_FALSE(uri2.parse());
+
+std::string p3 = "http://a.b.com/bucket/";;
+S3URI uri3(p3);
+EXPECT_FALSE(uri3.parse());
+
+std::string p4 = "http://a.b.com/";;
+S3URI uri4(p4);
+EXPECT_FALSE(uri4.parse());
}
TEST_F(S3URITest, RelativePathing) {
[GitHub] [doris-thirdparty] airborne12 opened a new pull request, #88: [Fix](PFOR) revert TurboPFOR to last version, and fix some build issue
airborne12 opened a new pull request, #88: URL: https://github.com/apache/doris-thirdparty/pull/88 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) Unify streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586137029 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
github-actions[bot] commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586137768 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586138827 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586139093 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586144071 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
github-actions[bot] commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586147861 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185:
URL: https://github.com/apache/doris/pull/20185#issuecomment-1586148825
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5235422699";) output.
shellcheck errors
```
'shellcheck ' found no issues.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- build.sh.orig
+++ build.sh
@@ -633,8 +633,7 @@
fi
extensions_modules=("java-udf" "jdbc-scanner" "hudi-scanner"
"paimon-scanner" "max-compute-scanner")
-for extensions_module in "${extensions_modules[@]}"
-do
+for extensions_module in "${extensions_modules[@]}"; do
module_path="${DORIS_HOME}/fe/be-java-extensions/${extensions_module}/target/${extensions_module}-jar-with-dependencies.jar"
if [[ -f "${module_path}" ]]; then
cp "${module_path}" "${DORIS_OUTPUT}/be/lib"/
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zddr opened a new pull request, #20673: [doc](mtmv)Mtmv doc
zddr opened a new pull request, #20673: URL: https://github.com/apache/doris/pull/20673 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586150021 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185:
URL: https://github.com/apache/doris/pull/20185#issuecomment-1586154072
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5235528141";) output.
shellcheck errors
```
'shellcheck ' found no issues.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- build.sh.orig
+++ build.sh
@@ -639,8 +639,7 @@
extensions_modules+=("paimon-scanner")
extensions_modules+=("max-compute-scanner")
-for extensions_module in "${extensions_modules[@]}"
-do
+for extensions_module in "${extensions_modules[@]}"; do
module_path="${DORIS_HOME}/fe/be-java-extensions/${extensions_module}/target/${extensions_module}-jar-with-dependencies.jar"
if [[ -f "${module_path}" ]]; then
cp "${module_path}" "${DORIS_OUTPUT}/be/lib"/
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20672: [typo](docs) add parameter version
github-actions[bot] commented on PR #20672: URL: https://github.com/apache/doris/pull/20672#issuecomment-1586154270 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20672: [typo](docs) add parameter version
github-actions[bot] commented on PR #20672: URL: https://github.com/apache/doris/pull/20672#issuecomment-1586154261 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586156153 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
BiteThet commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586156392 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JNSimba commented on pull request #20672: [typo](docs) add parameter version
JNSimba commented on PR #20672: URL: https://github.com/apache/doris/pull/20672#issuecomment-1586157031 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #20674: [fix](test) fix unstable dynamic partition regression test
morningman opened a new pull request, #20674: URL: https://github.com/apache/doris/pull/20674 ## Proposed changes Add to define variable with `def` keyword ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
github-actions[bot] commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586159080 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20674: [fix](test) fix unstable dynamic partition regression test
morningman commented on PR #20674: URL: https://github.com/apache/doris/pull/20674#issuecomment-1586159077 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586160913 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] airborne12 opened a new pull request, #20675: [Enhancement](cmake) refine build option for clucene
airborne12 opened a new pull request, #20675: URL: https://github.com/apache/doris/pull/20675 ## Proposed changes Issue Number: close #xxx fix build warning message like "cc1: warning: command-line option '-Wno-non-virtual-dtor' is valid for C++/ObjC++ but not for C" ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] airborne12 commented on pull request #20675: [Enhancement](cmake) refine build option for clucene
airborne12 commented on PR #20675: URL: https://github.com/apache/doris/pull/20675#issuecomment-1586163597 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20675: [Enhancement](cmake) refine build option for clucene
github-actions[bot] commented on PR #20675: URL: https://github.com/apache/doris/pull/20675#issuecomment-1586164161 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20668: [fix](planner) fix RewriteInPredicateRule may be useless
github-actions[bot] commented on PR #20668: URL: https://github.com/apache/doris/pull/20668#issuecomment-1586166396 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20668: [fix](planner) fix RewriteInPredicateRule may be useless
github-actions[bot] commented on PR #20668: URL: https://github.com/apache/doris/pull/20668#issuecomment-1586166410 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei opened a new pull request, #20676: [profile](remove child) child is for node, should not be used to organize counters
yiguolei opened a new pull request, #20676: URL: https://github.com/apache/doris/pull/20676 ## Proposed changes Currently, there are many profiles using add child profile to orgnanize profile into blocks. But it is wrong. Child profile will have a total time counter. Actually, what we should use is just a label. - MemoryUsage: - HashTable: 23.98 KB - SerializeKeyArena: 446.75 KB ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #20676: [profile](remove child) child is for node, should not be used to organize counters
yiguolei commented on PR #20676: URL: https://github.com/apache/doris/pull/20676#issuecomment-1586168672 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zxealous commented on pull request #20668: [fix](planner) fix RewriteInPredicateRule may be useless
zxealous commented on PR #20668: URL: https://github.com/apache/doris/pull/20668#issuecomment-1586168789 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20676: [profile](remove child) child is for node, should not be used to organize counters
github-actions[bot] commented on PR #20676: URL: https://github.com/apache/doris/pull/20676#issuecomment-1586169357 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
BiteThet commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586174097 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20658: [Bug](materialized-view) fix problems about create mv on ssb_flat q4.1 failed
github-actions[bot] commented on PR #20658: URL: https://github.com/apache/doris/pull/20658#issuecomment-1586174882 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #20635: [fix](case expr) fix coredump of case for null value 2
jacktengg commented on PR #20635: URL: https://github.com/apache/doris/pull/20635#issuecomment-1586176374 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586178022 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
github-actions[bot] commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586179091 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
morningman commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586181108 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] gree2 commented on issue #18618: [Bug] org.apache.thrift.TApplicationException: Invalid method name: 'get_table_req'
gree2 commented on issue #18618: URL: https://github.com/apache/doris/issues/18618#issuecomment-1586181542 根据官方手册，指定 Hive 版本即可。 CREATE CATALOG hive PROPERTIES ( 'type'='hms', 'hive.metastore.uris' = 'thrift://172.0.0.1:9083', 'hive.version' = '2.1.1' ); [指定使用 Hive 版本为 2.1.1 即可以查询 CDH 6.2.1 中对应的 Hive](https://zhuanlan.zhihu.com/p/636316507) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
morningman commented on code in PR #20185:
URL: https://github.com/apache/doris/pull/20185#discussion_r1225827444
##
fe/be-java-extensions/paimon-scanner/pom.xml:
##
@@ -0,0 +1,83 @@
+
+http://maven.apache.org/POM/4.0.0";
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+be-java-extensions
+org.apache.doris
+${revision}
+
+4.0.0
+
+paimon-scanner
+
+
+8
+8
+0.4-SNAPSHOT
Review Comment:
change to `0.4.0-incubating`
##
fe/be-java-extensions/hudi-scanner/src/main/java/org/apache/doris/hudi/Utils.java:
##
@@ -15,9 +15,9 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.jni.utils;
+package org.apache.doris.hudi;
-import org.apache.commons.io.FileUtils;
+import com.facebook.presto.hadoop.$internal.org.apache.commons.io.FileUtils;
Review Comment:
Why changing to this?
##
fe/pom.xml:
##
@@ -263,16 +263,24 @@ under the License.
0.8.13
2.4.6
3.1.3
+2.3.9
+2.10.1
1.33.0
1.22.0
1.1.0
0.43.3-public
+9.0.0
1.11.1
0.13.0
+2.7.4-11
+3.0.0-8
+
+0.12.2
Review Comment:
should be 0.13?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zxealous commented on pull request #20668: [fix](planner) fix RewriteInPredicateRule may be useless
zxealous commented on PR #20668: URL: https://github.com/apache/doris/pull/20668#issuecomment-1586191827 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #19597: [feature](planner) multi partition create by integer column
morningman merged PR #19597: URL: https://github.com/apache/doris/pull/19597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (8162d0062b -> c9b08d5c20)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 8162d0062b [fix](alter) fix potential concurrent issue for alter when check olap table state normal outside write lock scope is not atomic (#20480) add c9b08d5c20 [feature](planner) multi partition create by integer column (#19597) No new revisions were added by this update. Summary of changes: fe/fe-core/src/main/cup/sql_parser.cup | 26 .../apache/doris/analysis/MultiPartitionDesc.java | 169 ++--- .../apache/doris/analysis/PartitionKeyDesc.java| 13 ++ .../org/apache/doris/analysis/PartitionValue.java | 4 + .../multi_partition/test_multi_partition.groovy| 132 5 files changed, 292 insertions(+), 52 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20675: [Enhancement](cmake) refine build option for clucene
github-actions[bot] commented on PR #20675: URL: https://github.com/apache/doris/pull/20675#issuecomment-1586192603 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20675: [Enhancement](cmake) refine build option for clucene
github-actions[bot] commented on PR #20675: URL: https://github.com/apache/doris/pull/20675#issuecomment-1586192614 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dujl opened a new pull request, #20678: [fix](decimalv3) fix result error when cast a round decimalv3 to double
dujl opened a new pull request, #20678: URL: https://github.com/apache/doris/pull/20678 ## Proposed changes Issue Number: close #xxx in round function, when the src data is decimalv3 and the scale parameter is large than src data's scale, the round result scale will be set to source data's scale, but it use scale parameter to create the result column. This will result in the round result is wrong. ``` CREATE TABLE `tb_round_decimal` ( `id` int NOT NULL COMMENT '', `d1` decimalv3(9, 4) NULL COMMENT '', `d2` decimalv3(27, 4) NULL DEFAULT "0" , `d3` decimalv3(38, 4) NULL ) ENGINE=OLAP UNIQUE KEY(`id`) DISTRIBUTED BY HASH(`id`) BUCKETS 10 PROPERTIES ( "replication_allocation" = "tag.location.default: 1" ); insert into tb_round_decimal values (1, 123.56789, 234.67895, 345.78956); insert into tb_round_decimal values (2, 123.56789, 234.67895, 345.78956); select cast(round(sum(d1), 6) as double), cast(round(sum(d2), 6) as double), cast(round(sum(d3), 6) as double) from tb_round_decimal ; ``` before: ``` 2.471356 4.693578 6.91579 ``` after: ``` 247.1356 469.3578691.579 ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20678: [fix](decimalv3) fix result error when cast a round decimalv3 to double
github-actions[bot] commented on PR #20678: URL: https://github.com/apache/doris/pull/20678#issuecomment-1586195896 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20242: [feature-wip](workload-group) Support for workload group Authentication
morningman commented on code in PR #20242:
URL: https://github.com/apache/doris/pull/20242#discussion_r1225835449
##
docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/GRANT.md:
##
@@ -68,7 +70,7 @@ privilege_list 是需要赋予的权限列表，以逗号分隔。当前 Doris
1. 节点权限：NODE_PRIV
2. 库表权限：SELECT_PRIV,LOAD_PRIV,ALTER_PRIV,CREATE_PRIV,DROP_PRIV
-3. 资源权限：USAGE_PRIV
+3. 资源权限和workload group权限：USAGE_PRIV
Review Comment:
Need to use `` for inline version tag.
See:
https://doris.apache.org/zh-CN/community/how-to-contribute/contribute-doc#%E8%A1%8C%E5%86%85%E6%A0%87%E7%AD%BE
##
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java:
##
@@ -53,12 +55,21 @@ public class Role implements Writable, GsonPostProcessable {
// admin is like DBA, who has all privileges except for NODE privilege
held by operator
public static String ADMIN_ROLE = "admin";
-public static Role OPERATOR = new Role(OPERATOR_ROLE,
-TablePattern.ALL, PrivBitSet.of(Privilege.NODE_PRIV,
Privilege.ADMIN_PRIV),
-ResourcePattern.ALL, PrivBitSet.of(Privilege.NODE_PRIV,
Privilege.ADMIN_PRIV));
-public static Role ADMIN = new Role(ADMIN_ROLE,
-TablePattern.ALL, PrivBitSet.of(Privilege.ADMIN_PRIV),
-ResourcePattern.ALL, PrivBitSet.of(Privilege.ADMIN_PRIV));
+public static Role OPERATOR;
+public static Role ADMIN;
+
+static {
+try {
+// Global privileges do not distinguish Patter, global admin and
node privileges contain all privileges
Review Comment:
```suggestion
// Global privileges do not distinguish Pattern, global admin
and node privileges contain all privileges
```
##
fe/fe-core/src/main/java/org/apache/doris/analysis/GrantStmt.java:
##
@@ -69,6 +71,21 @@ public GrantStmt(UserIdentity userIdent, String role,
this.role = role;
this.tblPattern = null;
this.resourcePattern = resourcePattern;
+this.workloadGroupPattern = null;
Review Comment:
I think we can unify all these constructors, to avoid writing duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](case expr) fix coredump of case for null value 2 (#20635)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a347063390 [fix](case expr) fix coredump of case for null value 2
(#20635)
a347063390 is described below
commit a3470633902a0f42d60017d47d916004312fefe3
Author: Xinyi Zou
AuthorDate: Sun Jun 11 23:08:53 2023 +0800
[fix](case expr) fix coredump of case for null value 2 (#20635)
fix coredump of case for null value 2
---
be/src/vec/functions/function_case.h | 8 +--
.../sql_functions/case_function/case_null2.csv | 5 ++
.../case_function/test_case_function_null.out | 12 +
.../case_function/test_case_function_null.groovy | 57 +-
4 files changed, 77 insertions(+), 5 deletions(-)
diff --git a/be/src/vec/functions/function_case.h
b/be/src/vec/functions/function_case.h
index 0b336a4ecd..0c72e98aaf 100644
--- a/be/src/vec/functions/function_case.h
+++ b/be/src/vec/functions/function_case.h
@@ -332,13 +332,13 @@ public:
bool then_null = false;
for (int i = 1 + has_case; i < arguments.size() - has_else; i += 2) {
auto then_column_ptr = block.get_by_position(arguments[i]).column;
-if (then_column_ptr->is_nullable() ||
then_column_ptr->only_null()) {
+if (then_column_ptr->get_data_type() == TypeIndex::Nullable) {
then_null = true;
}
}
if constexpr (has_else) {
auto else_column_ptr =
block.get_by_position(arguments[arguments.size() - 1]).column;
-if (else_column_ptr->is_nullable() ||
else_column_ptr->only_null()) {
+if (else_column_ptr->get_data_type() == TypeIndex::Nullable) {
then_null = true;
}
} else {
@@ -364,13 +364,13 @@ public:
bool when_null = false;
if constexpr (has_case) {
auto case_column_ptr = block.get_by_position(arguments[0]).column;
-if (case_column_ptr->is_nullable() ||
case_column_ptr->only_null()) {
+if (case_column_ptr->get_data_type() == TypeIndex::Nullable) {
when_null = true;
}
}
for (int i = has_case; i < arguments.size() - has_else; i += 2) {
auto when_column_ptr = block.get_by_position(arguments[i]).column;
-if (when_column_ptr->is_nullable() ||
when_column_ptr->only_null()) {
+if (when_column_ptr->get_data_type() == TypeIndex::Nullable) {
when_null = true;
}
}
diff --git
a/regression-test/data/query_p0/sql_functions/case_function/case_null2.csv
b/regression-test/data/query_p0/sql_functions/case_function/case_null2.csv
new file mode 100644
index 00..08d0c1e007
--- /dev/null
+++ b/regression-test/data/query_p0/sql_functions/case_function/case_null2.csv
@@ -0,0 +1,5 @@
+1
+1
+1
+0
+-1
diff --git
a/regression-test/data/query_p0/sql_functions/case_function/test_case_function_null.out
b/regression-test/data/query_p0/sql_functions/case_function/test_case_function_null.out
index e671ae0ee4..de51eb0306 100644
---
a/regression-test/data/query_p0/sql_functions/case_function/test_case_function_null.out
+++
b/regression-test/data/query_p0/sql_functions/case_function/test_case_function_null.out
@@ -4,3 +4,15 @@
1970-10-29 false
1970-11-13 true
+-- !sql_case1 --
+-2.0
+
+-- !sql_case2 --
+-2
+
+-- !sql_case1 --
+-2.0
+
+-- !sql_case2 --
+-2
+
diff --git
a/regression-test/suites/query_p0/sql_functions/case_function/test_case_function_null.groovy
b/regression-test/suites/query_p0/sql_functions/case_function/test_case_function_null.groovy
index e625023525..63e67a40f0 100644
---
a/regression-test/suites/query_p0/sql_functions/case_function/test_case_function_null.groovy
+++
b/regression-test/suites/query_p0/sql_functions/case_function/test_case_function_null.groovy
@@ -41,7 +41,19 @@ suite("test_case_function_null", "query,p0") {
);
"""
-def tables = ["case_null0", "case_null1"]
+sql """ drop table if exists `case_null2` """
+sql """
+CREATE TABLE `case_null2` (
+ `c0` tinyint(4) NULL
+) ENGINE=OLAP
+DUPLICATE KEY(`c0`)
+DISTRIBUTED BY HASH(`c0`) BUCKETS 20
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1"
+);
+"""
+
+def tables = ["case_null0", "case_null1", "case_null2"]
for (String tableName in tables) {
streamLoad {
@@ -173,4 +185,47 @@ suite("test_case_function_null", "query,p0") {
c2,
c1;
"""
+
+qt_sql_case1 """
+SELECT SUM(
+CASE (((NULL BETWEEN NULL AND NULL)) and (CAST(0.4716 AS BOOLEAN)))
+WHEN ((CAST('-1530390546' AS VARCHAR)) LIKE ('-1678299490'))
+THEN (- (+ case_null2.c0))
+
[GitHub] [doris] BiteTheDDDDt merged pull request #20635: [fix](case expr) fix coredump of case for null value 2
BiteThet merged PR #20635: URL: https://github.com/apache/doris/pull/20635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lexluo09 commented on a diff in pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
lexluo09 commented on code in PR #20185:
URL: https://github.com/apache/doris/pull/20185#discussion_r1225841904
##
fe/pom.xml:
##
@@ -263,16 +263,24 @@ under the License.
0.8.13
2.4.6
3.1.3
+2.3.9
+2.10.1
1.33.0
1.22.0
1.1.0
0.43.3-public
+9.0.0
1.11.1
0.13.0
+2.7.4-11
+3.0.0-8
+
+0.12.2
Review Comment:
yes.
##
fe/be-java-extensions/paimon-scanner/pom.xml:
##
@@ -0,0 +1,83 @@
+
+http://maven.apache.org/POM/4.0.0";
+xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+be-java-extensions
+org.apache.doris
+${revision}
+
+4.0.0
+
+paimon-scanner
+
+
+8
+8
+0.4-SNAPSHOT
Review Comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HHoflittlefish777 commented on pull request #19655: [Refactor](load) merge streamload BE and FE properties parsing
HHoflittlefish777 commented on PR #19655: URL: https://github.com/apache/doris/pull/19655#issuecomment-1586214544 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544:
URL: https://github.com/apache/doris/pull/20544#issuecomment-1586215182
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5236205777";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In run-be-ut.sh line 347:
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
^---^ SC2154 (warning): MACHINE_OS is referenced but not
assigned.
In run-be-ut.sh line 366:
export JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
^-^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
export JAVA_OPTS="-Xmx1024m -DlogPath=${DORIS_HOME}/log/jni.log
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- MACHINE_OS is referenced but not
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -326,7 +326,6 @@
jdk_version "${JAVA_HOME}/bin/java"
)"
-
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_TEST_BINARY_DIR}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBETEST -XX:-CriticalJNINatives"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1586215708 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544:
URL: https://github.com/apache/doris/pull/20544#issuecomment-1586225450
`sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/5236301865";) output.
shellcheck errors
```
'shellcheck ' returned error 1 finding the following syntactical issues:
--
In run-be-ut.sh line 347:
if [[ "${MACHINE_OS}" == "Darwin" ]]; then
^---^ SC2154 (warning): MACHINE_OS is referenced but not
assigned.
In run-be-ut.sh line 366:
export JAVA_OPTS="-Xmx1024m -DlogPath=$DORIS_HOME/log/jni.log
-Xloggc:$DORIS_HOME/log/be.gc.log.$CUR_DATE -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
^-^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^-^ SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
^---^ SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
export JAVA_OPTS="-Xmx1024m -DlogPath=${DORIS_HOME}/log/jni.log
-Xloggc:${DORIS_HOME}/log/be.gc.log.${CUR_DATE} -Dsun.java.command=DorisBE
-XX:-CriticalJNINatives -DJDBC_MIN_POOL=1 -DJDBC_MAX_POOL=100
-DJDBC_MAX_IDEL_TIME=30"
For more information:
https://www.shellcheck.net/wiki/SC2154 -- MACHINE_OS is referenced but not
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
--
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=
above the line that contains the issue, where is the error code;
3. Add '-e ' to the SHELLCHECK_OPTS setting in your .yml action file.
```
shfmt errors
```
'shfmt ' returned error 1 finding the following formatting issues:
--
--- run-be-ut.sh.orig
+++ run-be-ut.sh
@@ -326,7 +326,6 @@
jdk_version "${JAVA_HOME}/bin/java"
)"
-
CUR_DATE=$(date +%Y%m%d-%H%M%S)
LOG_PATH="-DlogPath=${DORIS_TEST_BINARY_DIR}/log/jni.log"
COMMON_OPTS="-Dsun.java.command=DorisBETEST -XX:-CriticalJNINatives"
--
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20544: [improvement](hdfs) add parquet footer cache and hdfs file handle cache
github-actions[bot] commented on PR #20544: URL: https://github.com/apache/doris/pull/20544#issuecomment-1586226362 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen opened a new pull request, #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen opened a new pull request, #20679: URL: https://github.com/apache/doris/pull/20679 ## Proposed changes After supporting insert-only transactional hive full acid tables https://github.com/apache/doris/pull/19518, https://github.com/apache/doris/pull/19419, this PR support transactional hive full acid tables. - Support hive3 transactional hive full acid tables. - Hive2 transactional hive full acid tables need to run major compactions. ## Further comments Regression test only test with hive2 transactional hive full acid tables now, because the docker image version is hive 2.x, will add hive 3.x. docker later. If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586234352 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #19840: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables and fix some lazy materialization bugs in orc-reader.
kaka11chen commented on PR #19840: URL: https://github.com/apache/doris/pull/19840#issuecomment-1586234707 Created a new PR #20679, this PR will be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen closed pull request #19840: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables and fix some lazy materialization bugs in orc-reader.
kaka11chen closed pull request #19840: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables and fix some lazy materialization bugs in orc-reader. URL: https://github.com/apache/doris/pull/19840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
github-actions[bot] commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586235437 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
morningman commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586236681 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20185: [Enhancement](java-udf) java-udf module split to sub modules
github-actions[bot] commented on PR #20185: URL: https://github.com/apache/doris/pull/20185#issuecomment-1586239616 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #18640: [enhancement](storage) lazy-open necessary partitions when load
freemandealer commented on PR #18640: URL: https://github.com/apache/doris/pull/18640#issuecomment-1586374210 Already merged in https://github.com/apache/doris/pull/18874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer closed pull request #18640: [enhancement](storage) lazy-open necessary partitions when load
freemandealer closed pull request #18640: [enhancement](storage) lazy-open necessary partitions when load URL: https://github.com/apache/doris/pull/18640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] kaka11chen commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
kaka11chen commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586394016 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20679: [Feature][Fix](multi-catalog) Implements transactional hive full acid tables.
github-actions[bot] commented on PR #20679: URL: https://github.com/apache/doris/pull/20679#issuecomment-1586396128 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 closed issue #20527: [Bug] Could not insert into columns with default values with `insert into target select * from source`
TangSiyang2001 closed issue #20527: [Bug] Could not insert into columns with default values with `insert into target select * from source` URL: https://github.com/apache/doris/issues/20527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] shuke987 commented on pull request #20601: [fix](regression) fix vertical compaction test
shuke987 commented on PR #20601: URL: https://github.com/apache/doris/pull/20601#issuecomment-1586409562 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20601: [fix](regression) fix vertical compaction test
yujun777 commented on PR #20601: URL: https://github.com/apache/doris/pull/20601#issuecomment-1586411614 @run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20655: [fix] total_time of select_node not include the open phase
yiguolei merged PR #20655: URL: https://github.com/apache/doris/pull/20655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [fix] total_time of select_node.cpp and vselect_node.cpp not include the open phase (#20655)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 96d7b37f32 [fix] total_time of select_node.cpp and vselect_node.cpp
not include the open phase (#20655)
96d7b37f32 is described below
commit 96d7b37f325a1e6ff1784fbb524e6ccb90cfd179
Author: nsn_huang <38585669+nsnhu...@users.noreply.github.com>
AuthorDate: Mon Jun 12 09:10:36 2023 +0800
[fix] total_time of select_node.cpp and vselect_node.cpp not include the
open phase (#20655)
Co-authored-by: huangwenbo add SCOPED_TIMER at the begin
of select_node's open function
---
be/src/exec/select_node.cpp | 1 +
be/src/vec/exec/vselect_node.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/be/src/exec/select_node.cpp b/be/src/exec/select_node.cpp
index 81574ac9cc..511f6c214f 100644
--- a/be/src/exec/select_node.cpp
+++ b/be/src/exec/select_node.cpp
@@ -41,6 +41,7 @@ Status SelectNode::prepare(RuntimeState* state) {
}
Status SelectNode::open(RuntimeState* state) {
+SCOPED_TIMER(_runtime_profile->total_time_counter());
RETURN_IF_ERROR(ExecNode::open(state));
SCOPED_CONSUME_MEM_TRACKER(mem_tracker());
RETURN_IF_ERROR(child(0)->open(state));
diff --git a/be/src/vec/exec/vselect_node.cpp b/be/src/vec/exec/vselect_node.cpp
index 8f561f10a0..a0e84e9abd 100644
--- a/be/src/vec/exec/vselect_node.cpp
+++ b/be/src/vec/exec/vselect_node.cpp
@@ -33,6 +33,7 @@ Status VSelectNode::prepare(RuntimeState* state) {
Status VSelectNode::open(RuntimeState* state) {
START_AND_SCOPE_SPAN(state->get_tracer(), span, "VSelectNode::open");
+SCOPED_TIMER(_runtime_profile->total_time_counter());
RETURN_IF_ERROR(ExecNode::open(state));
RETURN_IF_ERROR(child(0)->open(state));
return Status::OK();
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #20644: [Chore](case) fix failed on test_big_pad when enable pipeline engine
yiguolei merged PR #20644: URL: https://github.com/apache/doris/pull/20644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Chore](case) fix failed on test_big_pad when enable pipeline engine #20644
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ab7ac31d89 [Chore](case) fix failed on test_big_pad when enable
pipeline engine #20644
ab7ac31d89 is described below
commit ab7ac31d89c0fc6d4fa88fba5dd3d0c1ae9a58d2
Author: Pxl
AuthorDate: Mon Jun 12 09:15:55 2023 +0800
[Chore](case) fix failed on test_big_pad when enable pipeline engine #20644
---
be/src/pipeline/task_scheduler.cpp | 13 +++--
be/src/service/internal_service.cpp| 5 ++--
be/src/vec/columns/column_string.h | 9 +++---
be/src/vec/functions/function_string.h | 33 +++---
.../suites/query_p1/test_big_pad.groovy| 5 +---
5 files changed, 40 insertions(+), 25 deletions(-)
diff --git a/be/src/pipeline/task_scheduler.cpp
b/be/src/pipeline/task_scheduler.cpp
index 335cd51a3e..831c5e2546 100644
--- a/be/src/pipeline/task_scheduler.cpp
+++ b/be/src/pipeline/task_scheduler.cpp
@@ -250,8 +250,8 @@ void TaskScheduler::_do_work(size_t index) {
}
task->set_task_queue(_task_queue.get());
auto* fragment_ctx = task->fragment_context();
-doris::signal::query_id_hi = fragment_ctx->get_query_id().hi;
-doris::signal::query_id_lo = fragment_ctx->get_query_id().lo;
+signal::query_id_hi = fragment_ctx->get_query_id().hi;
+signal::query_id_lo = fragment_ctx->get_query_id().lo;
bool canceled = fragment_ctx->is_canceled();
auto check_state = task->get_state();
@@ -279,7 +279,14 @@ void TaskScheduler::_do_work(size_t index) {
DCHECK(check_state == PipelineTaskState::RUNNABLE);
// task exec
bool eos = false;
-auto status = task->execute(&eos);
+auto status = Status::OK();
+
+try {
+status = task->execute(&eos);
+} catch (const Exception& e) {
+status = Status::Error(e.code(), e.to_string());
+}
+
task->set_previous_core_id(index);
if (!status.ok()) {
LOG(WARNING) << fmt::format("Pipeline task [{}] failed: {}",
task->debug_string(),
diff --git a/be/src/service/internal_service.cpp
b/be/src/service/internal_service.cpp
index 971302b810..502d897a76 100644
--- a/be/src/service/internal_service.cpp
+++ b/be/src/service/internal_service.cpp
@@ -147,9 +147,8 @@ class NewHttpClosure : public ::google::protobuf::Closure {
public:
NewHttpClosure(google::protobuf::Closure* done) : _done(done) {}
NewHttpClosure(T* request, google::protobuf::Closure* done) :
_request(request), _done(done) {}
-~NewHttpClosure() {}
-void Run() {
+void Run() override {
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(ExecEnv::GetInstance()->orphan_mem_tracker());
if (_request != nullptr) {
delete _request;
@@ -285,7 +284,7 @@ void
PInternalServiceImpl::exec_plan_fragment(google::protobuf::RpcController* c
request->has_version() ? request->version() :
PFragmentRequestVersion::VERSION_1;
try {
st = _exec_plan_fragment(request->request(), version, compact);
-} catch (const doris::Exception& e) {
+} catch (const Exception& e) {
st = Status::Error(e.code(), e.to_string());
}
if (!st.ok()) {
diff --git a/be/src/vec/columns/column_string.h
b/be/src/vec/columns/column_string.h
index 66d0a77e5d..eb27cdc4ed 100644
--- a/be/src/vec/columns/column_string.h
+++ b/be/src/vec/columns/column_string.h
@@ -66,10 +66,9 @@ public:
void static check_chars_length(size_t total_length, size_t element_number)
{
if (UNLIKELY(total_length > MAX_STRING_SIZE)) {
-throw doris::Exception(
-ErrorCode::STRING_OVERFLOW_IN_VEC_ENGINE,
-"string column length is too large: total_length={},
element_number={}",
-total_length, element_number);
+throw Exception(ErrorCode::STRING_OVERFLOW_IN_VEC_ENGINE,
+"string column length is too large:
total_length={}, element_number={}",
+total_length, element_number);
}
}
@@ -137,7 +136,7 @@ public:
}
void insert(const Field& x) override {
-const String& s = doris::vectorized::get(x);
+const String& s = vectorized::get(x);
const size_t old_size = chars.size();
const size_t size_to_append = s.size();
const size_t new_size = old_size + size_to_append;
diff --git a/be/src/vec/functions/function_string.h
b/be/src/vec/functions/function_string.h
index 7428d19aef..ff48e01e26 100644
--- a/be/src/vec/functions/function_string.h
+++ b/be/src/vec/functions/function_string.h
@@ -60,14 +60,13 @@
#include "vec/core/types.h"
#include "vec/data_types/data_type.h"
#include "vec/io/io_
[GitHub] [doris] smallhibiscus commented on pull request #20654: [doc](create-function) Update CREATE-FUNCTION.md to remove the usage of c++
smallhibiscus commented on PR #20654: URL: https://github.com/apache/doris/pull/20654#issuecomment-1586427521 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caoliang-web commented on pull request #18743: [BUG](es_catalog)Solve the problem of querying es catalog Unexpected exception: Index:…
caoliang-web commented on PR #18743: URL: https://github.com/apache/doris/pull/18743#issuecomment-1586438845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #20624: [fix](load)Support load json data with default value
eldenmoon commented on PR #20624: URL: https://github.com/apache/doris/pull/20624#issuecomment-1586442971 you should format your code `./build-support/clang-format.sh` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon commented on pull request #20671: [fix](ssl) fix some version of jdbc may result connect error
eldenmoon commented on PR #20671: URL: https://github.com/apache/doris/pull/20671#issuecomment-1586451270 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #20628: [Feature](broker-load) Support priority for Broker Load job.
dutyu commented on PR #20628: URL: https://github.com/apache/doris/pull/20628#issuecomment-1586454799 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20676: [profile](remove child) child is for node, should not be used to organize counters
github-actions[bot] commented on PR #20676: URL: https://github.com/apache/doris/pull/20676#issuecomment-1586457649 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20676: [profile](remove child) child is for node, should not be used to organize counters
github-actions[bot] commented on PR #20676: URL: https://github.com/apache/doris/pull/20676#issuecomment-1586457613 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20678: [fix](decimalv3) fix result error when cast a round decimalv3 to double
github-actions[bot] commented on PR #20678: URL: https://github.com/apache/doris/pull/20678#issuecomment-1586458787 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
