[GitHub] [doris] Mryange commented on pull request #19238: [feature](executor) Use the BE info to set pipeline variables.
Mryange commented on PR #19238: URL: https://github.com/apache/doris/pull/19238#issuecomment-1537338759 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19238: [feature](executor) Use the BE info to set pipeline variables.
github-actions[bot] commented on PR #19238: URL: https://github.com/apache/doris/pull/19238#issuecomment-1537339300 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix FullTextIndexReader doesn't check indexfile exists and query fail
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537339902 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix FullTextIndexReader doesn't check indexfile exists and query fail
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537340302 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537341731 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537342932 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537343291 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue opened a new pull request, #19360: [enhance](regression) add timeout for cold&heat case
ByteYue opened a new pull request, #19360: URL: https://github.com/apache/doris/pull/19360 # Proposed changes Issue Number: close #xxx Before this pr, the `cold_heat_separation_p2/create_table_use_partition_policy.groovy` case might result in one endless loop. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #19360: [enhance](regression) add timeout for cold&heat case
ByteYue commented on PR #19360: URL: https://github.com/apache/doris/pull/19360#issuecomment-1537343883 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537344706 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537347393 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
hello-stephen commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537348905 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.46 seconds stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230507074838_clickbench_pr_139755.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537357331 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19350: Enhancement-19322 add a session variable enable_pp_fuzzy
github-actions[bot] commented on PR #19350: URL: https://github.com/apache/doris/pull/19350#issuecomment-1537358248 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19350: Enhancement-19322 add a session variable enable_pp_fuzzy
github-actions[bot] commented on PR #19350: URL: https://github.com/apache/doris/pull/19350#issuecomment-1537362489 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537363455 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537363558 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537363901 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537365758 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix FullTextIndexReader doesn't check index file whether exists and query fail
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537373864 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix FullTextIndexReader doesn't check index file whether exists and query fail
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537373917 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537381193 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19355: [refactor](cluster)(step-1) remove cluster related stmt
yiguolei merged PR #19355: URL: https://github.com/apache/doris/pull/19355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537395476 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537396189 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
Mryange commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537397255 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537399035 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #19068: [refactor](complex-type) refactor array/map/struct literal to not invoke execute() function in prepare state
xy720 commented on PR #19068: URL: https://github.com/apache/doris/pull/19068#issuecomment-1537428703 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537431542 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman closed issue #17423: [Enhancement] Single BE / FE default table rep num
morningman closed issue #17423: [Enhancement] Single BE / FE default table rep num URL: https://github.com/apache/doris/issues/17423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #19211: [improvement](backend)Optimized error messages for insufficient replication
morningman merged PR #19211: URL: https://github.com/apache/doris/pull/19211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [improvement](backend)Optimized error messages for insufficient replication (#19211)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 32273a7a9b [improvement](backend)Optimized error messages for
insufficient replication (#19211)
32273a7a9b is described below
commit 32273a7a9b2714ae4949dd92a13cf4caec518527
Author: yongkang.zhong
AuthorDate: Sun May 7 20:45:21 2023 +0800
[improvement](backend)Optimized error messages for insufficient replication
(#19211)
optimized the error message for creating insufficient table replications
---
.../org/apache/doris/system/SystemInfoService.java | 47 --
.../org/apache/doris/catalog/CreateTableTest.java | 6 ++-
.../apache/doris/catalog/ModifyBackendTest.java| 6 ++-
3 files changed, 43 insertions(+), 16 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
b/fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
index d2e8044964..76a664bb28 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
@@ -38,6 +38,7 @@ import org.apache.doris.system.Backend.BackendState;
import org.apache.doris.thrift.TStatusCode;
import org.apache.doris.thrift.TStorageMedium;
+import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
import com.google.common.collect.ImmutableMap;
@@ -969,26 +970,48 @@ public class SystemInfoService {
public Map> selectBackendIdsForReplicaCreation(
ReplicaAllocation replicaAlloc, String clusterName, TStorageMedium
storageMedium)
throws DdlException {
+Map copiedBackends = Maps.newHashMap(idToBackendRef);
Map> chosenBackendIds = Maps.newHashMap();
Map allocMap = replicaAlloc.getAllocMap();
short totalReplicaNum = 0;
-for (Map.Entry entry : allocMap.entrySet()) {
-BeSelectionPolicy.Builder builder = new
BeSelectionPolicy.Builder().setCluster(clusterName)
-
.needScheduleAvailable().needCheckDiskUsage().addTags(Sets.newHashSet(entry.getKey()))
-.setStorageMedium(storageMedium);
-if (FeConstants.runningUnitTest ||
Config.allow_replica_on_same_host) {
-builder.allowOnSameHost();
+int aliveBackendNum = (int)
copiedBackends.values().stream().filter(Backend::isAlive).count();
+if (aliveBackendNum < replicaAlloc.getTotalReplicaNum()) {
+throw new DdlException("replication num should be less than the
number of available backends. "
++ "replication num is " + replicaAlloc.getTotalReplicaNum()
++ ", available backend num is " + aliveBackendNum);
+} else {
+List failedEntries = Lists.newArrayList();
+
+for (Map.Entry entry : allocMap.entrySet()) {
+BeSelectionPolicy.Builder builder = new
BeSelectionPolicy.Builder().setCluster(clusterName)
+
.needScheduleAvailable().needCheckDiskUsage().addTags(Sets.newHashSet(entry.getKey()))
+.setStorageMedium(storageMedium);
+if (FeConstants.runningUnitTest ||
Config.allow_replica_on_same_host) {
+builder.allowOnSameHost();
+}
+
+BeSelectionPolicy policy = builder.build();
+List beIds = selectBackendIdsByPolicy(policy,
entry.getValue());
+if (beIds.isEmpty()) {
+LOG.error("failed backend(s) for policy:" + policy);
+String errorReplication = "replication tag: " +
entry.getKey()
++ ", replication num: " + entry.getValue()
++ ", storage medium: " + storageMedium;
+failedEntries.add(errorReplication);
+} else {
+chosenBackendIds.put(entry.getKey(), beIds);
+totalReplicaNum += beIds.size();
+}
}
-BeSelectionPolicy policy = builder.build();
-List beIds = selectBackendIdsByPolicy(policy,
entry.getValue());
-if (beIds.isEmpty()) {
-throw new DdlException("Failed to find " + entry.getValue() +
" backend(s) for policy: " + policy);
+if (!failedEntries.isEmpty()) {
+String failedMsg = Joiner.on("\n").join(failedEntries);
+throw new DdlException("Failed to find enough backend, please
check the replication num,"
++ "replication tag and storage medium.\n" + "Create
failed replications:\n" + failedMsg);
}
-chosenBackendIds.put(entry.getKey(), beIds);
-totalReplicaNum += beIds.
[GitHub] [doris] morningman commented on pull request #19346: [Fix](multi-catalog) Make BE selection policy works fine when enable prefer_compute_node_for_external_table
morningman commented on PR #19346: URL: https://github.com/apache/doris/pull/19346#issuecomment-1537433243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537449705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537450039 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg opened a new pull request, #19361: [fix](olap) Not enough rows have been read with aggregate model
mrhhsg opened a new pull request, #19361: URL: https://github.com/apache/doris/pull/19361 # Proposed changes `raw_rows_read` was not the same as `_num_rows_returned` with aggregate model. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] gitccl opened a new pull request, #19362: [Refact](scanner_context) move increase num_scheduling_ctx into submit function
gitccl opened a new pull request, #19362: URL: https://github.com/apache/doris/pull/19362 # Proposed changes Issue Number: close #xxx ## Problem summary I found that the `num_scheduling_ctx` variable is always incremented by one before calling the submit function, so we can move it into the submit function. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #19362: [Refact](scanner_context) move increase num_scheduling_ctx into submit function
gitccl commented on PR #19362: URL: https://github.com/apache/doris/pull/19362#issuecomment-1537454202 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19362: [Refact](scanner_context) move increase num_scheduling_ctx into submit function
github-actions[bot] commented on PR #19362: URL: https://github.com/apache/doris/pull/19362#issuecomment-1537454857 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18557: [vectorized](function) support array_count function
github-actions[bot] commented on PR #18557: URL: https://github.com/apache/doris/pull/18557#issuecomment-1537460686 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537466739 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537467032 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #19363: [fix](meta) fix image file checksum error
morningman opened a new pull request, #19363: URL: https://github.com/apache/doris/pull/19363 # Proposed changes Issue Number: close #xxx ## Problem summary Introduced from #19355 in #19355, I skip the "cluster" module in image file, but forget to update the checksum when reading image file. This PR change it back, the "cluster" module will still be read, so that the checksum can be validated. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19363: [fix](meta) fix image file checksum error
morningman commented on PR #19363: URL: https://github.com/apache/doris/pull/19363#issuecomment-1537474672 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537483142 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537483589 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537485282 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18557: [vectorized](function) support array_count function
github-actions[bot] commented on PR #18557: URL: https://github.com/apache/doris/pull/18557#issuecomment-1537487130 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19363: [fix](meta) fix image file checksum error
hello-stephen commented on PR #19363: URL: https://github.com/apache/doris/pull/19363#issuecomment-1537487418 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.66 seconds stream load tsv: 421 seconds loaded 74807831229 Bytes, about 169 MB/s stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230507163621_clickbench_pr_139829.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537567954 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537568023 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] closed pull request #14005: [improvement](fuzzy) add thread fuzzy
github-actions[bot] closed pull request #14005: [improvement](fuzzy) add thread fuzzy URL: https://github.com/apache/doris/pull/14005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangYu0123 commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
ZhangYu0123 commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537582014 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19358: [fix](inverted index) fix query fail caused by FullTextIndexReader doesn't check index file whether exists
github-actions[bot] commented on PR #19358: URL: https://github.com/apache/doris/pull/19358#issuecomment-1537583294 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19363: [fix](meta) fix image file checksum error
github-actions[bot] commented on PR #19363: URL: https://github.com/apache/doris/pull/19363#issuecomment-1537598743 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19363: [fix](meta) fix image file checksum error
github-actions[bot] commented on PR #19363: URL: https://github.com/apache/doris/pull/19363#issuecomment-1537598774 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19109: [refactor](function) let agg functions exception safety
zhangstar333 commented on PR #19109: URL: https://github.com/apache/doris/pull/19109#issuecomment-1537601796 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan
zhangstar333 commented on PR #18903: URL: https://github.com/apache/doris/pull/18903#issuecomment-1537603590 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19109: [refactor](function) let agg functions exception safety
github-actions[bot] commented on PR #19109: URL: https://github.com/apache/doris/pull/19109#issuecomment-1537603911 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19320: [vectorized](function) fix array_map funtion return type maybe get wrong
zhangstar333 commented on PR #19320: URL: https://github.com/apache/doris/pull/19320#issuecomment-1537605099 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18903: [refactor](vectorized) fix some undefined behaviors in BE under ubsan
github-actions[bot] commented on PR #18903: URL: https://github.com/apache/doris/pull/18903#issuecomment-1537606990 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
github-actions[bot] commented on PR #19123: URL: https://github.com/apache/doris/pull/19123#issuecomment-1537609144 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] gitccl commented on pull request #19362: [Refact](scanner_context) move increase num_scheduling_ctx into submit function
gitccl commented on PR #19362: URL: https://github.com/apache/doris/pull/19362#issuecomment-1537612586 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19123: [improvement](FQDN)Change the implementation of fqdn
morningman commented on PR #19123: URL: https://github.com/apache/doris/pull/19123#issuecomment-1537615144 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19332: [refactor](remove unused file) remove progresss updater
yiguolei merged PR #19332: URL: https://github.com/apache/doris/pull/19332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [refactor](remove unused file) remove progresss updater (#19332)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1f6898a091 [refactor](remove unused file) remove progresss updater
(#19332)
1f6898a091 is described below
commit 1f6898a0919142044306f378e861593076d9a47a
Author: yiguolei <676222...@qq.com>
AuthorDate: Mon May 8 09:27:52 2023 +0800
[refactor](remove unused file) remove progresss updater (#19332)
Co-authored-by: yiguolei
---
be/src/util/CMakeLists.txt | 1 -
be/src/util/progress_updater.cpp | 69
be/src/util/progress_updater.h | 64 -
3 files changed, 134 deletions(-)
diff --git a/be/src/util/CMakeLists.txt b/be/src/util/CMakeLists.txt
index 251cf325e2..8c217f0acd 100644
--- a/be/src/util/CMakeLists.txt
+++ b/be/src/util/CMakeLists.txt
@@ -47,7 +47,6 @@ set(UTIL_FILES
path_builder.cpp
# TODO: not supported on RHEL 5
perf_counters.cpp
- progress_updater.cpp
runtime_profile.cpp
static_asserts.cpp
string_parser.cpp
diff --git a/be/src/util/progress_updater.cpp b/be/src/util/progress_updater.cpp
deleted file mode 100644
index 320b37ed31..00
--- a/be/src/util/progress_updater.cpp
+++ /dev/null
@@ -1,69 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-// This file is copied from
-//
https://github.com/apache/impala/blob/branch-2.9.0/be/src/util/progress-updater.cpp
-// and modified by Doris
-
-#include "util/progress_updater.h"
-
-#include
-
-#include "common/logging.h"
-
-namespace doris {
-
-ProgressUpdater::ProgressUpdater(const std::string& label, int64_t total, int
period)
-: _label(label),
- _total(total),
- _update_period(period),
- _num_complete(0),
- _last_output_percentage(0) {}
-
-ProgressUpdater::ProgressUpdater()
-: _total(0), _update_period(0), _num_complete(0),
_last_output_percentage(0) {}
-
-void ProgressUpdater::update(int64_t delta) {
-DCHECK_GE(delta, 0);
-
-if (delta == 0) {
-return;
-}
-
-__sync_fetch_and_add(&_num_complete, delta);
-
-// Cache some shared variables to avoid locking. It's possible the
progress
-// update is out of order (e.g. prints 1 out of 10 after 2 out of 10)
-double old_percentage = _last_output_percentage;
-int64_t num_complete = _num_complete;
-
-if (num_complete >= _total) {
-// Always print the final 100% complete
-VLOG_DEBUG << _label << " 100%% Complete (" << num_complete << " out
of " << _total << ")";
-return;
-}
-
-// Convert to percentage as int
-int new_percentage = (static_cast(num_complete) / _total) * 100;
-
-if (new_percentage - old_percentage > _update_period) {
-// Only update shared variable if this guy was the latest.
-__sync_val_compare_and_swap(&_last_output_percentage, old_percentage,
new_percentage);
-VLOG_DEBUG << _label << ": " << new_percentage << "%% Complete (" <<
num_complete
- << " out of " << _total << ")";
-}
-}
-} // namespace doris
diff --git a/be/src/util/progress_updater.h b/be/src/util/progress_updater.h
deleted file mode 100644
index f37de88335..00
--- a/be/src/util/progress_updater.h
+++ /dev/null
@@ -1,64 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// und
[GitHub] [doris] yiguolei commented on pull request #19351: [Refact](Literal)refact literal get field and value
yiguolei commented on PR #19351: URL: https://github.com/apache/doris/pull/19351#issuecomment-1537616758 We could add some sql based literal SQL test like cast.groovy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #19257: [Improvement](string function) optimize substring and in string set
HappenLee commented on code in PR #19257:
URL: https://github.com/apache/doris/pull/19257#discussion_r1186959431
##
be/src/vec/functions/function_string.h:
##
@@ -170,71 +170,126 @@ struct SubstringUtil {
const PaddedPODArray& start, const
PaddedPODArray& len,
NullMap& null_map, ColumnString::Chars& res_chars,
ColumnString::Offsets& res_offsets) {
-int size = offsets.size();
+size_t size = offsets.size();
res_offsets.resize(size);
res_chars.reserve(chars.size());
std::array buf;
PMR::monotonic_buffer_resource pool {buf.data(), buf.size()};
PMR::vector index {&pool};
-PMR::vector> strs(&pool);
-strs.resize(size);
auto* __restrict data_ptr = chars.data();
auto* __restrict offset_ptr = offsets.data();
-for (int i = 0; i < size; ++i) {
-strs[i].first = data_ptr + offset_ptr[i - 1];
-strs[i].second = offset_ptr[i] - offset_ptr[i - 1];
-}
-
-for (int i = 0; i < size; ++i) {
-auto [raw_str, str_size] = strs[i];
-const auto& start_value = start[index_check_const(i, Const)];
-const auto& len_value = len[index_check_const(i, Const)];
-// return empty string if start > src.length
-if (start_value > str_size || str_size == 0 || start_value == 0 ||
len_value <= 0) {
-StringOP::push_empty_string(i, res_chars, res_offsets);
-continue;
-}
-// reference to string_function.cpp: substring
-size_t byte_pos = 0;
-index.clear();
-for (size_t j = 0, char_size = 0; j < str_size; j += char_size) {
-char_size = UTF8_BYTE_LENGTH[(unsigned char)(raw_str)[j]];
-index.push_back(j);
-if (start_value > 0 && index.size() > start_value + len_value)
{
-break;
+if constexpr (Const) {
+const auto start_value = start[0];
+const auto len_value = len[0];
+if (start_value == 0 || len_value <= 0) {
+for (size_t i = 0; i < size; ++i) {
+StringOP::push_empty_string(i, res_chars, res_offsets);
}
-}
+} else {
+for (size_t i = 0; i < size; ++i) {
+const int str_size = offset_ptr[i] - offset_ptr[i - 1];
+const uint8_t* raw_str = data_ptr + offset_ptr[i - 1];
+// return empty string if start > src.length
+if (start_value > str_size || start_value < -str_size ||
str_size == 0) {
+StringOP::push_empty_string(i, res_chars, res_offsets);
+continue;
+}
+// reference to string_function.cpp: substring
+size_t byte_pos = 0;
+index.clear();
+for (size_t j = 0, char_size = 0;
+ j < str_size &&
+ (start_value <= 0 || index.size() <= start_value +
len_value);
+ j += char_size) {
+char_size = UTF8_BYTE_LENGTH[(unsigned
char)(raw_str)[j]];
+index.push_back(j);
+}
-int fixed_pos = start_value;
-if (fixed_pos < -(int)index.size()) {
-StringOP::push_empty_string(i, res_chars, res_offsets);
-continue;
-}
-if (fixed_pos < 0) {
-fixed_pos = index.size() + fixed_pos + 1;
+int fixed_pos = start_value;
+if (fixed_pos < 0) {
+fixed_pos = str_size + fixed_pos + 1;
+} else if (fixed_pos > index.size()) {
+StringOP::push_null_string(i, res_chars, res_offsets,
null_map);
+continue;
+}
+
+byte_pos = index[fixed_pos - 1];
+int fixed_len = str_size - byte_pos;
+if (fixed_pos + len_value <= index.size()) {
+fixed_len = index[fixed_pos + len_value - 1] -
byte_pos;
+}
+
+if (byte_pos <= str_size && fixed_len > 0) {
+// return StringRef(str.data + byte_pos, fixed_len);
+StringOP::push_value_string(
+std::string_view {reinterpret_cast(raw_str + byte_pos),
+ (size_t)fixed_len},
+i, res_chars, res_offsets);
+} else {
+StringOP::push_empty_string(i, res_chars, res_offsets);
+}
+}
}
-if (fixed_pos > index.si
[GitHub] [doris] github-actions[bot] commented on pull request #19349: [Improvement](fuzzy) record fuzzy variables of BE in fuzzy mode
github-actions[bot] commented on PR #19349: URL: https://github.com/apache/doris/pull/19349#issuecomment-1537628918 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19349: [Improvement](fuzzy) record fuzzy variables of BE in fuzzy mode
github-actions[bot] commented on PR #19349: URL: https://github.com/apache/doris/pull/19349#issuecomment-1537628938 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SWJTU-ZhangLei commented on pull request #19335: [fix](bdbje) remove `System.exit(-1)` in BDBEnvironment.close()
SWJTU-ZhangLei commented on PR #19335: URL: https://github.com/apache/doris/pull/19335#issuecomment-1537630628 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1537631295 run buildp0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #19363: [fix](meta) fix image file checksum error
Gabriel39 merged PR #19363: URL: https://github.com/apache/doris/pull/19363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (1f6898a091 -> fb5b3029a7)
This is an automated email from the ASF dual-hosted git repository. gabriellee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 1f6898a091 [refactor](remove unused file) remove progresss updater (#19332) add fb5b3029a7 [fix](meta) fix image file checksum error (#19363) No new revisions were added by this update. Summary of changes: fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java | 1 + .../src/main/java/org/apache/doris/datasource/InternalCatalog.java | 6 +- .../main/java/org/apache/doris/persist/meta/PersistMetaModules.java | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nanfeng1999 commented on issue #19260: [Feature] support partition on datetime in varchar
nanfeng1999 commented on issue #19260: URL: https://github.com/apache/doris/issues/19260#issuecomment-1537633092 hello,I am interested in this issue, can you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zengxiangqi1031 opened a new issue, #19364: [Bug] doris-1.2.4.1 is much slower than doris-1.2.1
zengxiangqi1031 opened a new issue, #19364: URL: https://github.com/apache/doris/issues/19364 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris 1.2.4.1 ### What's Wrong? when i run ssb test, doris 1.2.4.1 is much slower than doris 1.2.1 ; my machine is 32 core and 128GB RAM , all the parameters are the same.   ### What You Expected? new version should be faster than old version ### How to Reproduce? just run ssb test with different doris version ### Anything Else? no ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wzymumon commented on a diff in pull request #18557: [vectorized](function) support array_count function
wzymumon commented on code in PR #18557:
URL: https://github.com/apache/doris/pull/18557#discussion_r1186966399
##
be/src/vec/functions/array/function_array_count.cpp:
##
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace doris::vectorized {
+
+// array_count([1, 2, 3, 0, 0]) -> [3]
+class FunctionArrayCount : public IFunction {
+public:
+static constexpr auto name = "array_count";
+
+static FunctionPtr create() { return
std::make_shared(); }
+
+String get_name() const override { return name; }
+
+bool is_variadic() const override { return false; }
+
+size_t get_number_of_arguments() const override { return 1; }
+
+bool use_default_implementation_for_nulls() const override { return false;
}
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+return std::make_shared();
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) override {
+auto src_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+
+const ColumnArray* array_column = nullptr;
+const UInt8* array_null_map = nullptr;
+if (src_column->is_nullable()) {
+auto nullable_array = assert_cast(src_column.get());
+array_column = assert_cast(&nullable_array->get_nested_column());
+array_null_map =
nullable_array->get_null_map_column().get_data().data();
+} else {
+array_column = assert_cast(src_column.get());
+}
+
+auto& src_nested_data = array_column->get_data();
+auto& src_offset = array_column->get_offsets();
+
+auto result_data_col = ColumnInt64::create(input_rows_count, 0);
+auto& result_data = result_data_col->get_data();
+
+for (size_t i = 0; i < input_rows_count; ++i) {
+if (array_null_map && array_null_map[i]) {
+continue;
+}
+
+// default count is 0 if no-zero elment is not found
+Int64 count = 0;
+for (size_t off = src_offset[i - 1]; off < src_offset[i]; ++off) {
+if (!src_nested_data.is_null_at(off) &&
src_nested_data.get_bool(off)) {
+++count;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Bingandbing commented on pull request #18747: [Enhancement](Nereids)Add nereids minidump
Bingandbing commented on PR #18747: URL: https://github.com/apache/doris/pull/18747#issuecomment-1537640557 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dutyu closed pull request #16316: [Draft](plugin) add ProfileLoader plugin.
dutyu closed pull request #16316: [Draft](plugin) add ProfileLoader plugin. URL: https://github.com/apache/doris/pull/16316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dutyu closed pull request #15957: [Feature](profile) support SHOW EXPORT PROFILE stmt.
dutyu closed pull request #15957: [Feature](profile) support SHOW EXPORT PROFILE stmt. URL: https://github.com/apache/doris/pull/15957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Jibing-Li opened a new pull request, #19365: [Fix](statistics)Fix hive table statistic bug.
Jibing-Li opened a new pull request, #19365: URL: https://github.com/apache/doris/pull/19365 Fix hive table statistic bug. Collect table/partition level statistics. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19293: [chore](build) Porting to GCC-13
github-actions[bot] commented on PR #19293: URL: https://github.com/apache/doris/pull/19293#issuecomment-1537651260 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19293: [chore](build) Porting to GCC-13
github-actions[bot] commented on PR #19293: URL: https://github.com/apache/doris/pull/19293#issuecomment-1537651279 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] cst4049 opened a new issue, #19366: [Enhancement] The image is too large, how to optimize and streamline it
cst4049 opened a new issue, #19366: URL: https://github.com/apache/doris/issues/19366 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description The image is too large, how to optimize and streamline it  ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #19143: [log](fe)add log partitionInfo is null, fe not start service
zy-kkk commented on PR #19143: URL: https://github.com/apache/doris/pull/19143#issuecomment-1537652437 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #19307: [improvement](JDBC Catalog)Added Presto connection to Presto/Trino
zy-kkk commented on PR #19307: URL: https://github.com/apache/doris/pull/19307#issuecomment-1537652528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19361: [fix](olap) Not enough rows have been read with aggregate model
yiguolei merged PR #19361: URL: https://github.com/apache/doris/pull/19361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.1-lts updated: [fix](olap) Not enough rows have been read with aggregate model (#19361)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-1.1-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.1-lts by this push:
new c867912d1c [fix](olap) Not enough rows have been read with aggregate
model (#19361)
c867912d1c is described below
commit c867912d1cba18c595ae50f731698026dd336689
Author: Jerry Hu
AuthorDate: Mon May 8 10:30:50 2023 +0800
[fix](olap) Not enough rows have been read with aggregate model (#19361)
---
be/src/exec/olap_scan_node.cpp | 4
1 file changed, 4 deletions(-)
diff --git a/be/src/exec/olap_scan_node.cpp b/be/src/exec/olap_scan_node.cpp
index d9c0506ce5..9421ddd105 100644
--- a/be/src/exec/olap_scan_node.cpp
+++ b/be/src/exec/olap_scan_node.cpp
@@ -1642,10 +1642,6 @@ void OlapScanNode::scanner_thread(OlapScanner* scanner) {
raw_bytes_read +=
row_batch->tuple_data_pool()->total_reserved_bytes();
}
raw_rows_read = scanner->raw_rows_read();
-if (limit() != -1 && raw_rows_read >= limit()) {
-eos = true;
-break;
-}
}
{
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19307: [improvement](JDBC Catalog)Added Presto connection to Presto/Trino
github-actions[bot] commented on PR #19307: URL: https://github.com/apache/doris/pull/19307#issuecomment-1537653780 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #19325: [Chore](build) update some doc about build enviroment
BiteThet commented on PR #19325: URL: https://github.com/apache/doris/pull/19325#issuecomment-1537655233 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537656705 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19325: [Chore](build) update some doc about build enviroment
github-actions[bot] commented on PR #19325: URL: https://github.com/apache/doris/pull/19325#issuecomment-1537657028 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #19360: [enhance](regression) add timeout for cold&heat case
ByteYue commented on PR #19360: URL: https://github.com/apache/doris/pull/19360#issuecomment-1537657359 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19345: [Only-Test](pipeline)use fuzzy in pipeline
github-actions[bot] commented on PR #19345: URL: https://github.com/apache/doris/pull/19345#issuecomment-1537657399 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
github-actions[bot] commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1537657661 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #19293: [chore](build) Porting to GCC-13
adonis0147 merged PR #19293: URL: https://github.com/apache/doris/pull/19293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (fb5b3029a7 -> 673cbe3317)
This is an automated email from the ASF dual-hosted git repository. adonisling pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from fb5b3029a7 [fix](meta) fix image file checksum error (#19363) add 673cbe3317 [chore](build) Porting to GCC-13 (#19293) No new revisions were added by this update. Summary of changes: be/CMakeLists.txt | 5 - be/src/agent/task_worker_pool.cpp | 2 +- be/src/glibc-compatibility/CMakeLists.txt | 16 ++-- be/src/pipeline/pipeline_fragment_context.cpp | 11 ++- be/src/runtime/plan_fragment_executor.cpp | 7 --- be/src/util/block_compression.cpp | 2 +- be/src/util/container_util.hpp | 6 -- be/src/vec/exec/vaggregation_node.cpp | 3 +-- be/src/vec/functions/function_json.cpp | 2 ++ be/src/vec/functions/function_math_unary.h | 2 ++ be/src/vec/functions/function_math_unary_to_null_type.h | 4 +++- thirdparty/build-thirdparty.sh | 7 +-- thirdparty/download-thirdparty.sh | 10 ++ thirdparty/patches/brpc-1.4.0-gcc13.patch | 12 14 files changed, 69 insertions(+), 20 deletions(-) create mode 100644 thirdparty/patches/brpc-1.4.0-gcc13.patch - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yulei-Yang commented on pull request #19242: [Improvement](multicatalog) support show_partitions for hms catalog
Yulei-Yang commented on PR #19242: URL: https://github.com/apache/doris/pull/19242#issuecomment-1537659751 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk opened a new pull request, #19367: [typo](docs) fix err to mac local dev doc
zy-kkk opened a new pull request, #19367: URL: https://github.com/apache/doris/pull/19367 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #19367: [typo](docs) fix err to mac local dev doc
zy-kkk commented on PR #19367: URL: https://github.com/apache/doris/pull/19367#issuecomment-1537662286 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
