[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1528695419 run buildp0p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wzymumon commented on a diff in pull request #18557: [vectorized](function) support array_count function
wzymumon commented on code in PR #18557:
URL: https://github.com/apache/doris/pull/18557#discussion_r1181007747
##
be/src/vec/functions/array/function_array_count.cpp:
##
@@ -0,0 +1,93 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+namespace doris::vectorized {
+
+// array_count([1, 2, 3, 0, 0]) -> [3]
Review Comment:
how about this? `array_count(x->x, [0, 1, 1, 1, 0]) -> [3]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1528724088 run buildp1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528725375 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528740046 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nanfeng1999 commented on pull request #19210: [Enhancement] separate life cycle of base table and its materialized views
nanfeng1999 commented on PR #19210: URL: https://github.com/apache/doris/pull/19210#issuecomment-1528752413 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed
lvshaokang commented on PR #18933: URL: https://github.com/apache/doris/pull/18933#issuecomment-1528753089 > we will fix the p0 regression soonly @zclllyybb Ok, if already fix the p0 regression, could you call me? I will re-run it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528754505 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528762611 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1528762680 run buildp1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528762798 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19142: [feature-wip](load-refactor) InsertStmt as facade layer and and run S3/Broker Load as POC
TangSiyang2001 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1528770357 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19142: [feature](load-refactor) Step1: InsertStmt as facade layer and and run S3/Broker Load as POC
TangSiyang2001 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1528772577 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19221: [bugfix](low cardinality) cached code is wrong will result wrong query result when many null pages
github-actions[bot] commented on PR #19221: URL: https://github.com/apache/doris/pull/19221#issuecomment-1528774655 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1528780728 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yixiutt commented on pull request #19187: [fix](vertical_compaction) Fix `continuous_agg_count` PODArray wrong boundary judgment
yixiutt commented on PR #19187: URL: https://github.com/apache/doris/pull/19187#issuecomment-1528785203 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #19210: [Enhancement] separate life cycle of base table and its materialized views
dataroaring commented on PR #19210: URL: https://github.com/apache/doris/pull/19210#issuecomment-1528785253 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19187: [fix](vertical_compaction) Fix `continuous_agg_count` PODArray wrong boundary judgment
github-actions[bot] commented on PR #19187: URL: https://github.com/apache/doris/pull/19187#issuecomment-1528785386 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19210: [feature-wip](mv) separate life cycle of base table and its materialized views
github-actions[bot] commented on PR #19210: URL: https://github.com/apache/doris/pull/19210#issuecomment-1528785462 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19210: [feature-wip](mv) separate life cycle of base table and its materialized views
github-actions[bot] commented on PR #19210: URL: https://github.com/apache/doris/pull/19210#issuecomment-1528785477 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19142: [feature](load-refactor) Step1: InsertStmt as facade layer and run S3/Broker Load as POC
TangSiyang2001 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1528788401 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19221: [bugfix](low cardinality) cached code is wrong will result wrong query result when many null pages
yiguolei merged PR #19221: URL: https://github.com/apache/doris/pull/19221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [bugfix](low cardinality) cached code is wrong will result wrong query result when many null pages (#19221)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8eab20d3df [bugfix](low cardinality) cached code is wrong will result
wrong query result when many null pages (#19221)
8eab20d3df is described below
commit 8eab20d3dfb7b73e9572d843cb7001c2952f5364
Author: yiguolei <676222...@qq.com>
AuthorDate: Sat Apr 29 21:28:41 2023 +0800
[bugfix](low cardinality) cached code is wrong will result wrong query
result when many null pages (#19221)
Sometimes the dict is not initialized when run comparison predicate here,
for example, the full page is null, then the reader will skip read, so that the
dictionary is not inited. The cached code is wrong during this case, because
the following page maybe not null, and the dict should have items in the future.
This will result the dict string column query return wrong result, if there
are many null values in the column.
I also add some regression test for dict column's equal query, larger than
query, less than query.
-
Co-authored-by: yiguolei
---
be/src/common/config.h | 1 +
be/src/olap/comparison_predicate.h | 20 +++-
be/src/vec/columns/column_dictionary.h | 4 +-
.../data/nereids_p0/test_dict_with_null.out| 112 +
.../data/query_p0/test_dict_with_null.out | 112 +
.../suites/nereids_p0/test_dict_with_null.groovy | 5 +-
.../suites/query_p0/test_dict_with_null.groovy | 5 +-
7 files changed, 255 insertions(+), 4 deletions(-)
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 29ae1c3ba9..fa6a516bc4 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -284,6 +284,7 @@ CONF_Bool(disable_storage_page_cache, "false");
CONF_Bool(disable_storage_row_cache, "true");
CONF_Bool(enable_low_cardinality_optimize, "true");
+CONF_Bool(enable_low_cardinality_cache_code, "true");
// be policy
// whether check compaction checksum
diff --git a/be/src/olap/comparison_predicate.h
b/be/src/olap/comparison_predicate.h
index c74b06eaf3..a830319088 100644
--- a/be/src/olap/comparison_predicate.h
+++ b/be/src/olap/comparison_predicate.h
@@ -565,8 +565,26 @@ private:
const vectorized::ColumnDictI32& column) const {
/// if _cache_code_enabled is false, always find the code from dict.
if (UNLIKELY(!_cache_code_enabled || _cached_code ==
_InvalidateCodeValue)) {
-_cached_code = _is_range() ? column.find_code_by_bound(_value,
_is_greater(), _is_eq())
+int32_t code = _is_range() ? column.find_code_by_bound(_value,
_is_greater(), _is_eq())
: column.find_code(_value);
+
+// Protect the invalid code logic, to avoid data error.
+if (code == _InvalidateCodeValue) {
+LOG(FATAL) << "column dictionary should not return the code "
<< code
+ << ", because it is assumed as an invalid code in
comparison predicate";
+}
+// Sometimes the dict is not initialized when run comparison
predicate here, for example,
+// the full page is null, then the reader will skip read, so that
the dictionary is not
+// inited. The cached code is wrong during this case, because the
following page maybe not
+// null, and the dict should have items in the future.
+//
+// Cached code may have problems, so that add a config here, if
not opened, then
+// we will return the code and not cache it.
+if (column.is_dict_empty() ||
!config::enable_low_cardinality_cache_code) {
+return code;
+}
+// If the dict is not empty, then the dict is inited and we could
cache the value.
+_cached_code = code;
}
return _cached_code;
}
diff --git a/be/src/vec/columns/column_dictionary.h
b/be/src/vec/columns/column_dictionary.h
index 8a2c055d13..0d3b4ee8de 100644
--- a/be/src/vec/columns/column_dictionary.h
+++ b/be/src/vec/columns/column_dictionary.h
@@ -306,6 +306,8 @@ public:
bool is_dict_sorted() const { return _dict_sorted; }
+bool is_dict_empty() const { return _dict.empty(); }
+
bool is_dict_code_converted() const { return _dict_code_converted; }
MutableColumnPtr convert_to_predicate_column_if_dictionary() override {
@@ -507,7 +509,7 @@ public:
size_t byte_size() { return _dict_data->size() *
sizeof((*_dict_data)[0]); }
-bool empty() { return _dict_data->empty(); }
+bool empty() const { return _dict_data->empty(); }
size_t avg_str_len() { return empty() ? 0 : _total_str_len /
_dict_data->size(); }
diff --git a/regression-t
[GitHub] [doris] ZashJie commented on pull request #18831: [Improvement] enhance show data types stmt
ZashJie commented on PR #18831: URL: https://github.com/apache/doris/pull/18831#issuecomment-1528796083 run buildp1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring opened a new pull request, #19223: [improvement](log) log timeout seconds when creating partitions timeout
dataroaring opened a new pull request, #19223: URL: https://github.com/apache/doris/pull/19223 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #19223: [improvement](log) log timeout seconds when creating partitions timeout
dataroaring commented on PR #19223: URL: https://github.com/apache/doris/pull/19223#issuecomment-1528799442 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19223: [improvement](log) log timeout seconds when creating partitions timeout
hello-stephen commented on PR #19223: URL: https://github.com/apache/doris/pull/19223#issuecomment-1528803977 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.45 seconds stream load tsv: 424 seconds loaded 74807831229 Bytes, about 168 MB/s stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230429144312_clickbench_pr_137377.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] 16601746291 commented on issue #18837: [Bug] postgresql - CATALOG cannot get data
16601746291 commented on issue #18837: URL: https://github.com/apache/doris/issues/18837#issuecomment-1528804488 that OK,Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #19167: [feature](table) implement the round robin selection be when create tablet
dataroaring commented on PR #19167: URL: https://github.com/apache/doris/pull/19167#issuecomment-1528804872 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19185: [bug](jsonb) fix jsonb query bug When the json key value contains "."
github-actions[bot] commented on PR #19185: URL: https://github.com/apache/doris/pull/19185#issuecomment-1528807207 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] 16601746291 opened a new issue, #19224: [Bug] array_map function error
16601746291 opened a new issue, #19224: URL: https://github.com/apache/doris/issues/19224 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris1.2.3 ### What's Wrong? mysql> set enable_vectorized_engine = true; Query OK, 0 rows affected (0.00 sec) mysql> select array(1,2,3); ++ | array(1, 2, 3) | ++ | [1, 2, 3] | ++ 1 row in set (0.00 sec) mysql> select array_map(x -> x+1 ,array(1,2,3)); ERROR 1105 (HY000): errCode = 2, detailMessage = Syntax error in line 1: select array_map(x -> x+1 ,array(1,2,3)) ^ Encountered: > Expected: IDENTIFIER mysql> What happened? when i execute array_map function ,report error info: Encountered: > Expected: IDENTIFIER lambda is right, so why happen this? ### What You Expected? use array_map function run some logic ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #19167: [feature](table) implement the round robin selection be when create tablet
hello-stephen commented on PR #19167: URL: https://github.com/apache/doris/pull/19167#issuecomment-1528809480 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.93 seconds stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230429151038_clickbench_pr_137382.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] beTaller99 commented on issue #17176: [Good First Issue] Doris' Future
beTaller99 commented on issue #17176: URL: https://github.com/apache/doris/issues/17176#issuecomment-1528812188 hi~ I am new to open-source, can I complete task 87 in Java? I don't know if this task is suitable for Java? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] 16601746291 opened a new issue, #19225: [Bug] Document Error
16601746291 opened a new issue, #19225: URL: https://github.com/apache/doris/issues/19225 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris1.2.3 ### What's Wrong?  above example, i run in my doirs1.2.3  ### What You Expected? i refer to the documentation, but incorrect ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring opened a new pull request, #19226: [improvement](load) log time consumed by waiting flush
dataroaring opened a new pull request, #19226: URL: https://github.com/apache/doris/pull/19226 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #19226: [improvement](load) log time consumed by waiting flush
dataroaring commented on PR #19226: URL: https://github.com/apache/doris/pull/19226#issuecomment-1528815834 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] byrantwithyou commented on issue #17176: [Good First Issue] Doris' Future
byrantwithyou commented on issue #17176: URL: https://github.com/apache/doris/issues/17176#issuecomment-1528816175 Hi. I want to do issue #86. Could you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang opened a new pull request, #19227: [chore](testcase) change tpcds q67 testcase name to q67_ignore_temporarily
xiaokang opened a new pull request, #19227: URL: https://github.com/apache/doris/pull/19227 # Proposed changes Issue Number: close #xxx ## Problem summary change tpcds q67 testcase name to q67_ignore_temporarily since the error should be ignored temporarily due to precision problem that will be fixed further. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #19227: [chore](testcase) change tpcds q67 testcase name to q67_ignore_temporarily
xiaokang commented on PR #19227: URL: https://github.com/apache/doris/pull/19227#issuecomment-1528816226 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19226: [improvement](load) log time consumed by waiting flush
github-actions[bot] commented on PR #19226: URL: https://github.com/apache/doris/pull/19226#issuecomment-1528816402 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19228: [vectorized](function) add some check about result type in array map
zhangstar333 commented on PR #19228: URL: https://github.com/apache/doris/pull/19228#issuecomment-1528822281 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 opened a new pull request, #19228: [vectorized](function) add some check about result type in array map
zhangstar333 opened a new pull request, #19228: URL: https://github.com/apache/doris/pull/19228 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19228: [vectorized](function) add some check about result type in array map
github-actions[bot] commented on PR #19228: URL: https://github.com/apache/doris/pull/19228#issuecomment-1528822929 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhangstar333 commented on pull request #19228: [vectorized](function) add some check about result type in array map
zhangstar333 commented on PR #19228: URL: https://github.com/apache/doris/pull/19228#issuecomment-1528897930 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19228: [vectorized](function) add some check about result type in array map
github-actions[bot] commented on PR #19228: URL: https://github.com/apache/doris/pull/19228#issuecomment-1528898274 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #19142: [feature](load-refactor) Step1: InsertStmt as facade layer and run S3/Broker Load as POC
TangSiyang2001 commented on PR #19142: URL: https://github.com/apache/doris/pull/19142#issuecomment-1528909119 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch asf-site updated: Automated deployment with doris branch @ 663060f6603b5e435ec13fa606b2e6b7b13cd17a
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/doris-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new e8872586056 Automated deployment with doris branch @
663060f6603b5e435ec13fa606b2e6b7b13cd17a
e8872586056 is described below
commit e8872586056020e1e0fbb6324eea885f097503b5
Author: github-actions[bot]
AuthorDate: Sun Apr 30 02:04:17 2023 +
Automated deployment with doris branch @
663060f6603b5e435ec13fa606b2e6b7b13cd17a
---
docs/0.15/search-index.json | 2 +-
docs/search-index.json| 2 +-
search-index.json | 2 +-
zh-CN/docs/0.15/search-index.json | 2 +-
zh-CN/docs/search-index.json | 2 +-
zh-CN/search-index.json | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/0.15/search-index.json b/docs/0.15/search-index.json
index 6d2584f4341..1a25ebee31b 100644
--- a/docs/0.15/search-index.json
+++ b/docs/0.15/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":15515,"t":"Bitmap
Index","u":"/docs/0.15/administrator-guide/alter-table/alter-table-bitmap-index","b":["Administrator
Guide","Schema Change"]},{"i":15531,"t":"Replace
Table","u":"/docs/0.15/administrator-guide/alter-table/alter-table-replace-table","b":["Administrator
Guide","Schema Change"]},{"i":15541,"t":"Schema
Change","u":"/docs/0.15/administrator-guide/alter-table/alter-table-schema-change","b":["Administrator
Guide","Schema Change"]},{"i":15564,"t":"Temporary [...]
\ No newline at end of file
+[{"documents":[{"i":15515,"t":"Bitmap
Index","u":"/docs/0.15/administrator-guide/alter-table/alter-table-bitmap-index","b":["Administrator
Guide","Schema Change"]},{"i":15531,"t":"Replace
Table","u":"/docs/0.15/administrator-guide/alter-table/alter-table-replace-table","b":["Administrator
Guide","Schema Change"]},{"i":15541,"t":"Schema
Change","u":"/docs/0.15/administrator-guide/alter-table/alter-table-schema-change","b":["Administrator
Guide","Schema Change"]},{"i":15564,"t":"Rollup","u [...]
\ No newline at end of file
diff --git a/docs/search-index.json b/docs/search-index.json
index d5ac29d189d..d49173df96b 100644
--- a/docs/search-index.json
+++ b/docs/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":1,"t":"Elastic
scaling","u":"/docs/admin-manual/cluster-management/elastic-expansion","b":["Docs","Admin
Manual","cluster management"]},{"i":17,"t":"load
balancing","u":"/docs/admin-manual/cluster-management/load-balancing","b":["Docs","Admin
Manual","cluster management"]},{"i":44,"t":"Cluster
upgrade","u":"/docs/admin-manual/cluster-management/upgrade","b":["Docs","Admin
Manual","cluster management"]},{"i":60,"t":"BE
Configuration","u":"/docs/admin-manual/config/be-c [...]
\ No newline at end of file
+[{"documents":[{"i":1,"t":"Elastic
scaling","u":"/docs/admin-manual/cluster-management/elastic-expansion","b":["Docs","Admin
Manual","cluster management"]},{"i":17,"t":"load
balancing","u":"/docs/admin-manual/cluster-management/load-balancing","b":["Docs","Admin
Manual","cluster management"]},{"i":44,"t":"Cluster
upgrade","u":"/docs/admin-manual/cluster-management/upgrade","b":["Docs","Admin
Manual","cluster management"]},{"i":60,"t":"BE
Configuration","u":"/docs/admin-manual/config/be-c [...]
\ No newline at end of file
diff --git a/search-index.json b/search-index.json
index 3f979bfe221..2eb810040fa 100644
--- a/search-index.json
+++ b/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":7166,"t":"TLS
certificate","u":"/docs/dev/admin-manual/certificate","b":["Admin
Manual"]},{"i":7171,"t":"Elastic
scaling","u":"/docs/dev/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster
management"]},{"i":7187,"t":"FQDN","u":"/docs/dev/admin-manual/cluster-management/fqdn","b":["Admin
Manual","cluster management"]},{"i":7199,"t":"load
balancing","u":"/docs/dev/admin-manual/cluster-management/load-balancing","b":["Admin
Manual","cluster m [...]
\ No newline at end of file
+[{"documents":[{"i":7166,"t":"TLS
certificate","u":"/docs/dev/admin-manual/certificate","b":["Admin
Manual"]},{"i":7171,"t":"Elastic
scaling","u":"/docs/dev/admin-manual/cluster-management/elastic-expansion","b":["Admin
Manual","cluster management"]},{"i":7187,"t":"load
balancing","u":"/docs/dev/admin-manual/cluster-management/load-balancing","b":["Admin
Manual","cluster
management"]},{"i":7214,"t":"FQDN","u":"/docs/dev/admin-manual/cluster-management/fqdn","b":["Admin
Manual","cluster m [...]
\ No newline at end of file
diff --git a/zh-CN/docs/0.15/search-index.json
b/zh-CN/docs/0.15/search-index.json
index a08087bc970..3595c2b5125 100644
--- a/zh-CN/docs/0.15/search-index.json
+++ b/zh-CN/docs/0.15/search-index.json
@@ -1 +1 @@
-[{"documents":[{"i":37039,"t":"Bitmap
索引","u":"/zh-CN/docs/0.15/administrator-guide/alter-table/alter-table-bitmap-index","b":["操作手册","表结构变更"]},{"i":37055,"t"
[GitHub] [doris] Yukang-Lian opened a new pull request, #19229: [community](collaborator) add more collaborators
Yukang-Lian opened a new pull request, #19229: URL: https://github.com/apache/doris/pull/19229 # Proposed changes Issue Number: close #xxx ## Problem summary Add @TangSiyang2001 as collaborator, and he helped a lot in good first issue. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on pull request #19229: [community](collaborator) add more collaborators
Yukang-Lian commented on PR #19229: URL: https://github.com/apache/doris/pull/19229#issuecomment-1528934938 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chenlinzhong commented on pull request #19209: [feature](graph)Support querying data from the Nebula graph database
chenlinzhong commented on PR #19209: URL: https://github.com/apache/doris/pull/19209#issuecomment-1528939361 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
