[GitHub] [doris] yiguolei commented on pull request #17107: [fix](regression) fix regression test case of convert function
yiguolei commented on PR #17107: URL: https://github.com/apache/doris/pull/17107#issuecomment-1443053942 ./run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443054449 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17104: [fix](load) fix add broken tablet core dump
github-actions[bot] commented on PR #17104: URL: https://github.com/apache/doris/pull/17104#issuecomment-1443061295 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17104: [fix](load) fix add broken tablet core dump
github-actions[bot] commented on PR #17104: URL: https://github.com/apache/doris/pull/17104#issuecomment-1443061451 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #17073: [Enhancement](HttpServer) Provide authentication interface for BE
yongjinhou commented on PR #17073: URL: https://github.com/apache/doris/pull/17073#issuecomment-1443070974 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #17073: [Enhancement](HttpServer) Provide authentication interface for BE
yongjinhou commented on PR #17073: URL: https://github.com/apache/doris/pull/17073#issuecomment-1443073535 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #16731: segcompaction featuring verticalcompaction
freemandealer commented on PR #16731: URL: https://github.com/apache/doris/pull/16731#issuecomment-1443101521 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17074: [feature](cooldown)get tablet return cooldown conf
github-actions[bot] commented on PR #17074: URL: https://github.com/apache/doris/pull/17074#issuecomment-144357 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17074: [feature](cooldown)get tablet return cooldown conf
github-actions[bot] commented on PR #17074: URL: https://github.com/apache/doris/pull/17074#issuecomment-1443111300 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16731: segcompaction featuring verticalcompaction
github-actions[bot] commented on code in PR #16731:
URL: https://github.com/apache/doris/pull/16731#discussion_r1116650659
##
be/src/olap/rowset/segcompaction.h:
##
@@ -0,0 +1,69 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+#include
+
+#include // time
+#include
+#include
+
+#include "common/status.h"
+#include "olap/merger.h"
+#include "olap/rowset/rowset_writer.h"
+#include "segment_v2/segment.h"
+#include "segment_v2/segment_writer.h"
+#include "vec/olap/vertical_block_reader.h"
+
+namespace doris {
+using SegCompactionCandidates = std::vector;
+using SegCompactionCandidatesSharedPtr =
std::shared_ptr;
+
+class BetaRowsetWriter;
+
+class SegcompactionWorker {
+friend class BetaRowsetWriter;
+
+public:
+SegcompactionWorker(BetaRowsetWriter* writer) { _writer = writer; }
+
+void compact_segments(SegCompactionCandidatesSharedPtr segments);
+
+io::FileWriterPtr& get_file_writer() { return _file_writer; }
+
+private:
+Status _create_segment_writer_for_segcompaction(
+std::unique_ptr* writer, uint64_t
begin, uint64_t end);
+Status _get_segcompaction_reader(SegCompactionCandidatesSharedPtr segments,
+ TabletSharedPtr tablet,
std::shared_ptr schema,
+ OlapReaderStatistics* stat,
+ vectorized::RowSourcesBuffer&
row_sources_buf, bool is_key,
+ std::vector& return_columns,
+
std::unique_ptr* reader);
+std::unique_ptr
_create_segcompaction_writer(uint64_t begin,
+
uint64_t end);
+Status _delete_original_segments(uint32_t begin, uint32_t end);
+Status _check_correctness(OlapReaderStatistics& reader_stat,
Merger::Statistics& merger_stat,
+ uint64_t begin, uint64_t end);
+Status _do_compact_segments(SegCompactionCandidatesSharedPtr segments);
+
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
**be/src/olap/rowset/segcompaction.h:47:** previously declared here
```cpp
private:
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] lide-reed commented on a diff in pull request #17108: [Enhancement](spark load)Support spark time out config
lide-reed commented on code in PR #17108:
URL: https://github.com/apache/doris/pull/17108#discussion_r1116649465
##
fe/fe-core/src/test/java/org/apache/doris/load/loadv2/SparkLauncherMonitorTest.java:
##
@@ -57,7 +58,7 @@ public void testLogMonitorNormal() {
try {
Process process = Runtime.getRuntime().exec(cmd);
handle = new SparkLoadAppHandle(process);
-SparkLauncherMonitor.LogMonitor logMonitor =
SparkLauncherMonitor.createLogMonitor(handle);
+SparkLauncherMonitor.LogMonitor logMonitor =
SparkLauncherMonitor.createLogMonitor(handle, new HashedMap());
Review Comment:
Can you create a hashmap which include SUBMIT_TIMEOUT_KEY info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16731: segcompaction featuring verticalcompaction
github-actions[bot] commented on code in PR #16731:
URL: https://github.com/apache/doris/pull/16731#discussion_r1116652879
##
be/src/olap/rowset/segcompaction.h:
##
@@ -0,0 +1,69 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+#include
+
+#include // time
+#include
+#include
+
+#include "common/status.h"
+#include "olap/merger.h"
+#include "olap/rowset/rowset_writer.h"
+#include "segment_v2/segment.h"
+#include "segment_v2/segment_writer.h"
+#include "vec/olap/vertical_block_reader.h"
+
+namespace doris {
+using SegCompactionCandidates = std::vector;
+using SegCompactionCandidatesSharedPtr =
std::shared_ptr;
+
+class BetaRowsetWriter;
+
+class SegcompactionWorker {
+friend class BetaRowsetWriter;
+
+public:
+SegcompactionWorker(BetaRowsetWriter* writer) { _writer = writer; }
+
+void compact_segments(SegCompactionCandidatesSharedPtr segments);
+
+io::FileWriterPtr& get_file_writer() { return _file_writer; }
+
+private:
+Status _create_segment_writer_for_segcompaction(
+std::unique_ptr* writer, uint64_t
begin, uint64_t end);
+Status _get_segcompaction_reader(SegCompactionCandidatesSharedPtr segments,
+ TabletSharedPtr tablet,
std::shared_ptr schema,
+ OlapReaderStatistics* stat,
+ vectorized::RowSourcesBuffer&
row_sources_buf, bool is_key,
+ std::vector& return_columns,
+
std::unique_ptr* reader);
+std::unique_ptr
_create_segcompaction_writer(uint64_t begin,
+
uint64_t end);
+Status _delete_original_segments(uint32_t begin, uint32_t end);
+Status _check_correctness(OlapReaderStatistics& reader_stat,
Merger::Statistics& merger_stat,
+ uint64_t begin, uint64_t end);
+Status _do_compact_segments(SegCompactionCandidatesSharedPtr segments);
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
**be/src/olap/rowset/segcompaction.h:47:** previously declared here
```cpp
private:
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luzhijing commented on pull request #17103: [Docs](docs) Fix typo in property name of pipeline-execution-engine.md to `enable_pipeline_engine`
luzhijing commented on PR #17103: URL: https://github.com/apache/doris/pull/17103#issuecomment-1443132832 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17103: [Docs](docs) Fix typo in property name of pipeline-execution-engine.md to `enable_pipeline_engine`
github-actions[bot] commented on PR #17103: URL: https://github.com/apache/doris/pull/17103#issuecomment-1443134651 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17103: [Docs](docs) Fix typo in property name of pipeline-execution-engine.md to `enable_pipeline_engine`
github-actions[bot] commented on PR #17103: URL: https://github.com/apache/doris/pull/17103#issuecomment-1443134543 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18
BiteThet opened a new pull request, #17109: URL: https://github.com/apache/doris/pull/17109 # Proposed changes I found that `thrift` often has some crash under `asan`, I want to try to upgrade it to the latest version and see if the problem still occurs ```cpp = ==3313527==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f620d10adb0 at pc 0x560af1186b17 bp 0x7f620d10ad80 sp 0x7f620d10a528 WRITE of size 24 at 0x7f620d10adb0 thread T861 (EvHttpServer [w) #0 0x560af1186b16 in __interceptor_sigaltstack.part.0 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x7049b16) #1 0x560af11ec8bf in __asan::PlatformUnpoisonStacks() (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x70af8bf) #2 0x560af11f2224 in __asan_handle_no_return (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x70b5224) #3 0x560af38641bf in __gnu_cxx::new_allocator::~new_allocator() /var/local/ldb-toolchain/include/c++/11/ext/new_allocator.h:89 #4 0x560af38641bf in std::allocator::~allocator() /var/local/ldb-toolchain/include/c++/11/bits/allocator.h:162 #5 0x560af38641bf in std::__cxx11::basic_string, std::allocator >::_Alloc_hider::~_Alloc_hider() /var/local/ldb-toolchain/include/c++/11/bits/basic_string.h:150 #6 0x560af38641bf in std::__cxx11::basic_string, std::allocator >::~basic_string() /var/local/ldb-toolchain/include/c++/11/bits/basic_string.h:658 #7 0x560af38641bf in doris::FrontendServiceClient::recv_streamLoadPut(doris::TStreamLoadPutResult&) /root/doris/gensrc/build/gen_cpp/FrontendService.cpp:6420 #8 0x560af3864369 in doris::FrontendServiceClient::streamLoadPut(doris::TStreamLoadPutResult&, doris::TStreamLoadPutRequest const&) /root/doris/gensrc/build/gen_cpp/FrontendService.cpp:6367 #9 0x560af4220b56 in operator() /root/doris/be/src/http/action/stream_load.cpp:584 #10 0x560af4220b56 in __invoke_impl&, doris::ClientConnection&> /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:61 #11 0x560af4220b56 in __invoke_r&, doris::ClientConnection&> /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:111 #12 0x560af4220b56 in _M_invoke /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:291 #13 0x560af325f612 in std::function&)>::operator()(doris::ClientConnection&) const /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:560 #14 0x560af325f612 in doris::Status doris::ThriftRpcHelper::rpc(std::__cxx11::basic_string, std::allocator > const&, int, std::function&)>, int) /root/doris/be/src/util/thrift_rpc_helper.cpp:59 #15 0x560af4231bef in doris::Status doris::ThriftRpcHelper::rpc(std::__cxx11::basic_string, std::allocator > const&, int, std::function&)>) /root/doris/be/src/util/thrift_rpc_helper.h:40 #16 0x560af4231bef in doris::StreamLoadAction::_process_put(doris::HttpRequest*, doris::StreamLoadContext*) /root/doris/be/src/http/action/stream_load.cpp:584 #17 0x560af4235da4 in doris::StreamLoadAction::_on_header(doris::HttpRequest*, doris::StreamLoadContext*) /root/doris/be/src/http/action/stream_load.cpp:341 #18 0x560af4241834 in doris::StreamLoadAction::on_header(doris::HttpRequest*) /root/doris/be/src/http/action/stream_load.cpp:242 #19 0x560af416de47 in doris::EvHttpServer::on_header(evhttp_request*) /root/doris/be/src/http/ev_http_server.cpp:242 #20 0x560af416e259 in on_header /root/doris/be/src/http/ev_http_server.cpp:64 #21 0x560b07a898b9 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d94c8b9) #22 0x560b07a6bf50 in bufferevent_run_readcb_ (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d92ef50) #23 0x560b07a8ddf2 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d950df2) #24 0x560b07a74d58 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d937d58) #25 0x560b07a753d6 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d9383d6) #26 0x560b07a77a07 (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster7/be/lib/doris_be+0x1d93aa07) #27 0x560af416737a in operator() /root/doris/be/src/http/ev_http_server.cpp:105 #28 0x560af416737a in __invoke_impl&> /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:61 #29 0x560af416737a in __invoke_r&> /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:111 #30 0x560af416737a in _M_invoke /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:291 #31 0x560af32fc1c2 in std::function::operator()() const /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:560 #32 0x560af32fc1c2 in doris::FunctionRunnable::run() /root/doris/be/src/util/threadpool.cpp:46 #33 0x560af
[GitHub] [doris] BiteTheDDDDt merged pull request #16825: [Chore](regression-test) add createMV action && add some mv case from fe ut MaterializedViewFunctionTest
BiteThet merged PR #16825: URL: https://github.com/apache/doris/pull/16825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Chore](regression-test) add createMV action && add some mv case from fe ut MaterializedViewFunctionTest (#16825)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0691586eb7 [Chore](regression-test) add createMV action && add some mv
case from fe ut MaterializedViewFunctionTest (#16825)
0691586eb7 is described below
commit 0691586eb7d3834a9b405ef75f4b3d2df24f7001
Author: Pxl
AuthorDate: Fri Feb 24 16:35:37 2023 +0800
[Chore](regression-test) add createMV action && add some mv case from fe ut
MaterializedViewFunctionTest (#16825)
1. add createMV action
2. add some mv case from fe ut MaterializedViewFunctionTest
3. reduce mv scheduler interval time from 10s to 0.3s
---
.../doris/alter/MaterializedViewHandler.java | 4 +-
.../org/apache/doris/alter/BatchRollupJobTest.java | 4 +-
.../ut/testProjectionMV1/testProjectionMV1.out | 11 +++
.../ut/testProjectionMV2/testProjectionMV2.out | 14 +++
.../ut/testProjectionMV3/testProjectionMV3.out | 14 +++
.../ut/testProjectionMV4/testProjectionMV4.out | 12 +++
.../doris/regression/action/CreateMVAction.groovy | 110 +
.../org/apache/doris/regression/suite/Suite.groovy | 9 ++
.../ut/testProjectionMV1/testProjectionMV1.groovy | 53 ++
.../ut/testProjectionMV2/testProjectionMV2.groovy | 59 +++
.../ut/testProjectionMV3/testProjectionMV3.groovy | 61
.../ut/testProjectionMV4/testProjectionMV4.groovy | 61
12 files changed, 409 insertions(+), 3 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
index c2b654e23f..5a7ff739ca 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
@@ -93,8 +93,10 @@ public class MaterializedViewHandler extends AlterHandler {
private static final Logger LOG =
LogManager.getLogger(MaterializedViewHandler.class);
public static final String NEW_STORAGE_FORMAT_INDEX_NAME_PREFIX = "__v2_";
+public static int scheduler_interval_millisecond = 333;
+
public MaterializedViewHandler() {
-super("materialized view");
+super("materialized view", scheduler_interval_millisecond);
}
// for batch submit rollup job, tableId -> jobId
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/alter/BatchRollupJobTest.java
b/fe/fe-core/src/test/java/org/apache/doris/alter/BatchRollupJobTest.java
index 987d90215b..ac3522ad83 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/alter/BatchRollupJobTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/alter/BatchRollupJobTest.java
@@ -92,7 +92,7 @@ public class BatchRollupJobTest {
while (!alterJobV2.getJobState().isFinalState()) {
System.out.println(
"rollup job " + alterJobV2.getJobId() + " is running.
state: " + alterJobV2.getJobState());
-Thread.sleep(5000);
+Thread.sleep(1000);
}
System.out.println("rollup job " + alterJobV2.getJobId() + " is
done. state: " + alterJobV2.getJobState());
Assert.assertEquals(AlterJobV2.JobState.FINISHED,
alterJobV2.getJobState());
@@ -142,7 +142,7 @@ public class BatchRollupJobTest {
while (!alterJobV2.getJobState().isFinalState()) {
System.out.println(
"rollup job " + alterJobV2.getJobId() + " is running.
state: " + alterJobV2.getJobState());
-Thread.sleep(5000);
+Thread.sleep(1000);
}
System.out.println("rollup job " + alterJobV2.getJobId() + " is
done. state: " + alterJobV2.getJobState());
Assert.assertEquals(AlterJobV2.JobState.FINISHED,
alterJobV2.getJobState());
diff --git
a/regression-test/data/materialized_view_p0/ut/testProjectionMV1/testProjectionMV1.out
b/regression-test/data/materialized_view_p0/ut/testProjectionMV1/testProjectionMV1.out
new file mode 100644
index 00..ba455b7e85
--- /dev/null
+++
b/regression-test/data/materialized_view_p0/ut/testProjectionMV1/testProjectionMV1.out
@@ -0,0 +1,11 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select_star --
+2020-01-01 1 a 1 1 1
+2020-01-01 1 a 1 1 1
+2020-01-02 2 b 2 2 2
+
+-- !select_mv --
+1 1
+1 1
+2 2
+
diff --git
a/regression-test/data/materialized_view_p0/ut/testProjectionMV2/testProjectionMV2.out
b/regression-test/data/materialized_view_p0/ut/testProjectionMV2/testProjectionMV2.out
new file mode 100644
index 00..934d3208d4
--- /dev/null
+++
b/regression-test/dat
[GitHub] [doris] github-actions[bot] commented on pull request #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18
github-actions[bot] commented on PR #17109: URL: https://github.com/apache/doris/pull/17109#issuecomment-1443144746 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W opened a new pull request, #17110: [enhancement](inverted index) Support inverted index without specified parser to use match query
Tanya-W opened a new pull request, #17110: URL: https://github.com/apache/doris/pull/17110 # Proposed changes Issue Number: close #xxx ## Problem summary Support inverted index without specified parser to use match query. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz commented on pull request #17054: [fix](parquet-reader)support parquet data page v2
wsjz commented on PR #17054: URL: https://github.com/apache/doris/pull/17054#issuecomment-1443153858 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #17099: [enhance](Nereids): refactor LogicalJoin.
jackwener commented on PR #17099: URL: https://github.com/apache/doris/pull/17099#issuecomment-1443155090 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17110: [enhancement](inverted index) Support inverted index without specified parser to use match query
github-actions[bot] commented on PR #17110: URL: https://github.com/apache/doris/pull/17110#issuecomment-1443158576 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17110: [enhancement](inverted index) Support inverted index without specified parser to use match query
github-actions[bot] commented on PR #17110: URL: https://github.com/apache/doris/pull/17110#issuecomment-1443164951 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17110: [enhancement](inverted index) Support inverted index without specified parser to use match query
github-actions[bot] commented on PR #17110: URL: https://github.com/apache/doris/pull/17110#issuecomment-1443165166 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443196755 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #17110: [enhancement](inverted index) Support inverted index without specified parser to use match query
Tanya-W commented on PR #17110: URL: https://github.com/apache/doris/pull/17110#issuecomment-1443202512 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wsjz opened a new pull request, #17112: [feature](parquet-reader) add delta bit pack decoder
wsjz opened a new pull request, #17112: URL: https://github.com/apache/doris/pull/17112 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17112: [feature](parquet-reader) add delta bit pack decoder
github-actions[bot] commented on code in PR #17112:
URL: https://github.com/apache/doris/pull/17112#discussion_r1116695489
##
be/src/vec/exec/format/parquet/decoder.cpp:
##
@@ -88,6 +89,19 @@ Status Decoder::get_decoder(tparquet::Type::type type,
tparquet::Encoding::type
tparquet::to_string(type),
tparquet::to_string(encoding));
}
break;
+case tparquet::Encoding::DELTA_BINARY_PACKED:
+// Supports only INT32 and INT64.
+switch (type) {
+case tparquet::Type::INT32:
+[[fallthrough]];
+case tparquet::Type::INT64:
+decoder.reset(new DeltaBitPackDecoder());
Review Comment:
warning: no viable constructor or deduction guide for deduction of template
arguments of 'DeltaBitPackDecoder' [clang-diagnostic-error]
```cpp
decoder.reset(new DeltaBitPackDecoder());
^
```
**be/src/vec/exec/format/parquet/delta_bit_pack_decoder.h:38:** candidate
template ignored: couldn't infer template argument 'Type'
```cpp
DeltaBitPackDecoder() {};
^
```
**be/src/vec/exec/format/parquet/delta_bit_pack_decoder.h:33:** candidate
function template not viable: requires 1 argument, but 0 were provided
```cpp
class DeltaBitPackDecoder final : public Decoder {
^
```
##
be/src/util/bit_stream_utils.inline.h:
##
@@ -195,20 +208,29 @@ inline bool BitReader::GetAligned(int num_bytes, T* v) {
return true;
}
-inline bool BitReader::GetVlqInt(int32_t* v) {
+inline bool BitReader::GetVlqInt(uint32_t* v) {
*v = 0;
int shift = 0;
int num_bytes = 0;
uint8_t byte = 0;
do {
if (!GetAligned(1, &byte)) return false;
-*v |= (byte & 0x7F) << shift;
+*v |= static_cast(byte & 0x7F) << shift;
shift += 7;
DCHECK_LE(++num_bytes, MAX_VLQ_BYTE_LEN);
} while ((byte & 0x80) != 0);
return true;
}
+inline bool BitReader::GetZigZagVlqInt(int32_t* v) {
+uint32_t u;
+if (!GetVlqInt(&u)) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (!GetVlqInt(&u)) { return false;
}
```
##
be/src/vec/exec/format/parquet/delta_bit_pack_decoder.cpp:
##
@@ -0,0 +1,168 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "delta_bit_pack_decoder.h"
+
+namespace doris::vectorized {
+
+Status DeltaBitPackDecoder::decode_values(MutableColumnPtr& doris_column,
DataTypePtr& data_type,
+ ColumnSelectVector& select_vector) {
+select_vector.num_values();
+return Status::OK();
+}
+
+Status DeltaBitPackDecoder::skip_values(size_t num_values) {
Review Comment:
warning: 'DeltaBitPackDecoder' is not a class, namespace, or enumeration
[clang-diagnostic-error]
```cpp
Status DeltaBitPackDecoder::skip_values(size_t num_values) {
^
```
**be/src/vec/exec/format/parquet/delta_bit_pack_decoder.h:33:**
'DeltaBitPackDecoder' declared here
```cpp
class DeltaBitPackDecoder final : public Decoder {
^
```
##
be/src/vec/exec/format/parquet/delta_bit_pack_decoder.cpp:
##
@@ -0,0 +1,168 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "delta_bit_pack_decoder.h"
+
+namespace doris::vectorize
[GitHub] [doris] pengxiangyu merged pull request #17007: [feature](cooldown)add ut for CooldownConfHandler
pengxiangyu merged PR #17007: URL: https://github.com/apache/doris/pull/17007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature](cooldown)add ut for CooldownConfHandler (#17007)
This is an automated email from the ASF dual-hosted git repository.
pengxiangyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 54e68fe250 [feature](cooldown)add ut for CooldownConfHandler (#17007)
54e68fe250 is described below
commit 54e68fe25085e881b5e5ace1a03b782db1bc8793
Author: pengxiangyu
AuthorDate: Fri Feb 24 17:06:55 2023 +0800
[feature](cooldown)add ut for CooldownConfHandler (#17007)
* add ut for CooldownConfHandler
* add ut for CooldownConfHandler
* add ut for CooldownConfHandler
---
.../doris/cooldown/CooldownConfHandlerTest.java| 120 +
1 file changed, 120 insertions(+)
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/cooldown/CooldownConfHandlerTest.java
b/fe/fe-core/src/test/java/org/apache/doris/cooldown/CooldownConfHandlerTest.java
new file mode 100644
index 00..ea3e239533
--- /dev/null
+++
b/fe/fe-core/src/test/java/org/apache/doris/cooldown/CooldownConfHandlerTest.java
@@ -0,0 +1,120 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.cooldown;
+
+import org.apache.doris.analysis.CreateUserStmt;
+import org.apache.doris.analysis.GrantStmt;
+import org.apache.doris.analysis.TablePattern;
+import org.apache.doris.analysis.UserDesc;
+import org.apache.doris.analysis.UserIdentity;
+import org.apache.doris.catalog.AccessPrivilege;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.Env;
+import org.apache.doris.catalog.MaterializedIndex;
+import org.apache.doris.catalog.Partition;
+import org.apache.doris.catalog.Replica;
+import org.apache.doris.catalog.Table;
+import org.apache.doris.catalog.Tablet;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.FeConstants;
+import org.apache.doris.common.Pair;
+import org.apache.doris.system.SystemInfoService;
+import org.apache.doris.utframe.TestWithFeService;
+
+import com.google.common.collect.Lists;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.junit.Assert;
+import org.junit.jupiter.api.Test;
+
+import java.util.LinkedList;
+import java.util.List;
+
+public class CooldownConfHandlerTest extends TestWithFeService {
+private static final Logger LOG =
LogManager.getLogger(CooldownConfHandlerTest.class);
+private long dbId = 100L;
+private long tableId = 101L;
+private long partitionId = 102L;
+private long indexId = 103L;
+private long tabletId = 104;
+
+private Tablet tablet = null;
+
+@Override
+protected void runBeforeAll() throws Exception {
+Config.enable_storage_policy = true;
+FeConstants.runningUnitTest = true;
+createDatabase("test");
+useDatabase("test");
+createTable("create table table1\n"
++ "(k1 int, k2 int) distributed by hash(k1) buckets 1\n"
++ "properties(\"replication_num\" = \"1\");");
+// create user
+UserIdentity user = new UserIdentity("test_cooldown", "%");
+user.analyze(SystemInfoService.DEFAULT_CLUSTER);
+CreateUserStmt createUserStmt = new CreateUserStmt(new UserDesc(user));
+Env.getCurrentEnv().getAuth().createUser(createUserStmt);
+List privileges =
Lists.newArrayList(AccessPrivilege.ADMIN_PRIV);
+TablePattern tablePattern = new TablePattern("*", "*", "*");
+tablePattern.analyze(SystemInfoService.DEFAULT_CLUSTER);
+GrantStmt grantStmt = new GrantStmt(user, null, tablePattern,
privileges);
+Env.getCurrentEnv().getAuth().grant(grantStmt);
+useUser("test_cooldown");
+Database db =
Env.getCurrentInternalCatalog().getDb(SystemInfoService.DEFAULT_CLUSTER + ":" +
"test")
+.orElse(null);
+assert db != null;
+dbId = db.getId();
+Table tbl = db.getTable("table1").orElse(null);
+assert tbl != null;
+tableId = tbl.getId();
+assert tbl.getPartitionNames().size() == 1;
+Partition partition = tbl.getPartition("table1");
+partitionId = partition.getId();
+Materialized
[GitHub] [doris] github-actions[bot] commented on pull request #17108: [Enhancement](spark load)Support spark time out config
github-actions[bot] commented on PR #17108: URL: https://github.com/apache/doris/pull/17108#issuecomment-1443266012 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17108: [Enhancement](spark load)Support spark time out config
github-actions[bot] commented on PR #17108: URL: https://github.com/apache/doris/pull/17108#issuecomment-1443266248 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16731: segcompaction featuring verticalcompaction
hello-stephen commented on PR #16731: URL: https://github.com/apache/doris/pull/16731#issuecomment-1443300918 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.91 seconds stream load tsv: 465 seconds loaded 74807831229 Bytes, about 153 MB/s stream load json: 36 seconds loaded 2358488459 Bytes, about 62 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230224092145_clickbench_pr_103969.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17100: [Fix](DOE)Fix be core dump when parse es epoch_millis date format
github-actions[bot] commented on PR #17100: URL: https://github.com/apache/doris/pull/17100#issuecomment-1443316047 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ya-dao opened a new pull request, #17113: 补充批量删除注意事项
ya-dao opened a new pull request, #17113: URL: https://github.com/apache/doris/pull/17113 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [x] Does it affect the original behavior * [x] Has unit tests been added * [ ] Has document been added or modified * [x] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments * 按照批量删除文档前文的介绍, 用户可能会开启`show_hidden_columns`的session variable来查看表是否支持批量删除. * 后续按示例进行DELETE/MERGE的导入作业后, 如果在同一个session中执行`select count(*) from xxx`语句时, 可能会发现结果与预期不一致 * 无法快速联想到是因为之前开启的session variable导致被删除的语句也被查出来了. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443326726 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443339727 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yinzhijian commented on a diff in pull request #16315: [enhancement](k8s) Support fqdn mode for fe in k8s enviroment
yinzhijian commented on code in PR #16315:
URL: https://github.com/apache/doris/pull/16315#discussion_r1116725982
##
fe/fe-core/src/main/java/org/apache/doris/service/FrontendOptions.java:
##
@@ -98,6 +98,10 @@ public static String getHostname() {
return localAddr.getHostName();
}
+public static String getCanonicalHostName() {
Review Comment:
Are you running on Docker or physical machines?
This issue may not be related to gethostname or getCanonicalHostName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yinzhijian commented on pull request #16315: [enhancement](k8s) Support fqdn mode for fe in k8s enviroment
yinzhijian commented on PR #16315: URL: https://github.com/apache/doris/pull/16315#issuecomment-1443357725 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] SaintBacchus commented on pull request #17100: [Fix](DOE)Fix be core dump when parse es epoch_millis date format
SaintBacchus commented on PR #17100: URL: https://github.com/apache/doris/pull/17100#issuecomment-1443366895 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17100: [Fix](DOE)Fix be core dump when parse es epoch_millis date format
github-actions[bot] commented on PR #17100: URL: https://github.com/apache/doris/pull/17100#issuecomment-1443369937 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #17101: [enhancement](session-variable)add a use_fix_replica session variable to fix query replica
yiguolei commented on code in PR #17101:
URL: https://github.com/apache/doris/pull/17101#discussion_r1116747143
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -272,6 +272,9 @@ public class SessionVariable implements Serializable,
Writable {
public static final String MAX_TABLE_COUNT_USE_CASCADES_JOIN_REORDER =
"max_table_count_use_cascades_join_reorder";
+// fix replic to query. If num = 1, query the smallest replic, if 2 is the
second smallest replic.
Review Comment:
typo error replic ---> replica
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16916: [feature](map) basic functions for map datatype
github-actions[bot] commented on PR #16916: URL: https://github.com/apache/doris/pull/16916#issuecomment-1443386071 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17079: [enhancement](Nereids) datetime v2 type precision derive
morrySnow commented on PR #17079: URL: https://github.com/apache/doris/pull/17079#issuecomment-1443389774 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caoliang-web opened a new pull request, #17115: [typo](doc)Added stream load import csv file title filter document example
caoliang-web opened a new pull request, #17115: URL: https://github.com/apache/doris/pull/17115 # Proposed changes Issue Number: close #xxx ## Problem summary 1. Added stream load import csv file title filter document example ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] wangtianyi2004 opened a new pull request, #17116: Update run-docker-cluster.md
wangtianyi2004 opened a new pull request, #17116: URL: https://github.com/apache/doris/pull/17116 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #17117: [branch-1.2](pom) remove unsafe log4j
morningman opened a new pull request, #17117: URL: https://github.com/apache/doris/pull/17117 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18
github-actions[bot] commented on PR #17109: URL: https://github.com/apache/doris/pull/17109#issuecomment-1443413510 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17107: [fix](regression) fix regression test case of convert function
yiguolei merged PR #17107: URL: https://github.com/apache/doris/pull/17107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (54e68fe250 -> 707160ab73)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 54e68fe250 [feature](cooldown)add ut for CooldownConfHandler (#17007) add 707160ab73 [fix](regression) fix regression test case of convert function (#17107) No new revisions were added by this update. Summary of changes: .../suites/query_p0/sql_functions/string_functions/test_convert.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt closed pull request #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18
BiteThet closed pull request #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18 URL: https://github.com/apache/doris/pull/17109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #17109: [Chore](third-party) upgrade thrift from 0.13 to 0.18
BiteThet commented on PR #17109: URL: https://github.com/apache/doris/pull/17109#issuecomment-1443434977 thrift 0.18 only support jdk11, so I will close this pr temporary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] MnameHZJ commented on issue #17106: [Bug] doris join查询使用dateTime类型关联查询，数据时有时无
MnameHZJ commented on issue #17106: URL: https://github.com/apache/doris/issues/17106#issuecomment-1443453381 将原语句中的`f.post_time = p.post_time` 改为 `f.post_time >= '2022-12-23 00:00:00' AND f.post_time <= '2022-12-26 00:00:00'` 以及 `t.post_time = p.post_time` 改为 `t.post_time >= '2022-12-23 00:00:00' AND t.post_time <= '2022-12-26 00:00:00'` ，就不会出现该问题： ``` SELECT /*+SET_VAR(parallel_fragment_exec_instance_num=4) */ p.enterprise_id, u.id user_name, p.id pack_id, f.id frame_id, t.id TId, t.ticket_id, UNIX_TIMESTAMP(p.post_time), UNIX_TIMESTAMP(t.post_time), UNIX_TIMESTAMP(f.post_time) FROM gsms_user_5 AS u JOIN gsms_msg_pack_sms_8 AS p ON u.id = p.user_id JOIN gsms_msg_frame_sms_8 AS f ON p.id = f.msg_pack_id AND f.post_time >= '2022-12-23 00:00:00' AND f.post_time <= '2022-12-26 00:00:00' JOIN gsms_msg_ticket_sms_8 t ON t.frame_id = f.id AND t.post_time >= '2022-12-23 00:00:00' AND t.post_time <= '2022-12-26 00:00:00' WHERE t.user_id = 182615 -- AND p.enterprise_id = 186213 AND p.post_time >= '2022-12-23 00:00:00' AND p.post_time <= '2022-12-26 00:00:00' AND p.msg_type IN (0, 1) AND ( t.sms_type = 0 OR (t.sms_type = 2 AND t.number = 1) ) ORDER BY t.id LIMIT 0, 20; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #17101: [enhancement](session-variable)add a use_fix_replica session variable to fix query replica
yiguolei commented on code in PR #17101:
URL: https://github.com/apache/doris/pull/17101#discussion_r1116804564
##
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##
@@ -690,11 +690,39 @@ private void addScanRangeLocations(Partition partition,
throw new UserException("Failed to get scan range, no
queryable replica found in tablet: " + tabletId);
}
-Collections.shuffle(replicas);
+int useFixReplica = -1;
+if (ConnectContext.get() != null) {
+useFixReplica =
ConnectContext.get().getSessionVariable().useFixReplica;
+}
+if (useFixReplica == -1) {
+Collections.shuffle(replicas);
+} else {
+LOG.debug("use fix replica, value: {}, replica num: {}",
useFixReplica, replicas.size());
+// sort by replica id
Review Comment:
the logic is too complicated!!!
if (useFixReplica == -1) {
Collections.shuffle(replicas);
} else {
LOG.debug("use fix replica, value: {}, replica num: {}",
useFixReplica, replicas.size());
// sort by replica id
replicas.sort(Replica.ID_COMPARATOR);
Replica replica = replicas.get(useFixReplica >=
replicas.size() : replicas.size() - 1 ? useFixReplica);
replicas.clear();
replicas.add(replica);
}
Then other code does not need change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaojunjie commented on pull request #17034: [Enhancement](HttpServer) Support https in be
xiaojunjie commented on PR #17034: URL: https://github.com/apache/doris/pull/17034#issuecomment-1443465099 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaojunjie commented on pull request #17034: [Enhancement](HttpServer) Support https in be
xiaojunjie commented on PR #17034: URL: https://github.com/apache/doris/pull/17034#issuecomment-1443484378 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann opened a new pull request, #17118: [fix](Nereids): fix rank
XieJiann opened a new pull request, #17118: URL: https://github.com/apache/doris/pull/17118 # Proposed changes xx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaojunjie commented on pull request #16980: [feature](nereids) support query cache and partition cache
xiaojunjie commented on PR #16980: URL: https://github.com/apache/doris/pull/16980#issuecomment-1443490619 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #16916: [feature](map) basic functions for map datatype
xiaokang commented on PR #16916: URL: https://github.com/apache/doris/pull/16916#issuecomment-1443492288 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann commented on pull request #17118: [fix](Nereids): fix rank
XieJiann commented on PR #17118: URL: https://github.com/apache/doris/pull/17118#issuecomment-1443496566 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue opened a new pull request, #17119: [fix](multi-catalog) fix not find dbname from internal catalog
nextdreamblue opened a new pull request, #17119: URL: https://github.com/apache/doris/pull/17119 # Proposed changes Issue Number: close #xxx ## Problem summary when: mysql -h127.0.0.1 -P9030 -uroot -Dinternal.information_schema will get error: ERROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 0 because not use fulldbname ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443507091 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei opened a new pull request, #17120: [cherry-pick](#16194) pick remove mempool pr from master in default value iterator
yiguolei opened a new pull request, #17120: URL: https://github.com/apache/doris/pull/17120 # Proposed changes Remove mempool usage from default value column iterator. The mempool does not have memtracker but spark load will use it, then it will core. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17120: [cherry-pick](#16194) pick remove mempool pr from master in default value iterator
yiguolei merged PR #17120: URL: https://github.com/apache/doris/pull/17120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch branch-1.2-lts updated: [cherry-pick](#16194) pick remove mempool pr from master in default value iterator (#17120)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new 30145d2ccc [cherry-pick](#16194) pick remove mempool pr from master in
default value iterator (#17120)
30145d2ccc is described below
commit 30145d2ccc5f036e6f27437f6729e8bb461f1738
Author: yiguolei <676222...@qq.com>
AuthorDate: Fri Feb 24 19:06:51 2023 +0800
[cherry-pick](#16194) pick remove mempool pr from master in default value
iterator (#17120)
* [cherry-pick](#16194) pick remove mempool pr from master in default
column iterator
Remove mempool usage from default value column iterator. The mempool does
not have memtracker but spark load will use it, then it will core.
pick from ##16194
-
Co-authored-by: yiguolei
---
be/src/olap/rowset/segment_v2/column_reader.cpp| 33 +---
be/src/olap/rowset/segment_v2/column_reader.h | 8 +--
.../correctness_p0/test_char_default_value.out | 11
.../correctness_p0/test_char_default_value.groovy | 63 ++
4 files changed, 89 insertions(+), 26 deletions(-)
diff --git a/be/src/olap/rowset/segment_v2/column_reader.cpp
b/be/src/olap/rowset/segment_v2/column_reader.cpp
index 430251aac2..c8da3c8a7c 100644
--- a/be/src/olap/rowset/segment_v2/column_reader.cpp
+++ b/be/src/olap/rowset/segment_v2/column_reader.cpp
@@ -981,29 +981,22 @@ Status DefaultValueColumnIterator::init(const
ColumnIteratorOptions& opts) {
_is_default_value_null = true;
} else {
_type_size = _type_info->size();
-_mem_value = reinterpret_cast(_pool->allocate(_type_size));
+_mem_value.resize(_type_size);
Status s = Status::OK();
-if (_type_info->type() == OLAP_FIELD_TYPE_CHAR) {
-int32_t length = _schema_length;
-char* string_buffer =
reinterpret_cast(_pool->allocate(length));
-memset(string_buffer, 0, length);
-memory_copy(string_buffer, _default_value.c_str(),
_default_value.length());
-((Slice*)_mem_value)->size = length;
-((Slice*)_mem_value)->data = string_buffer;
-} else if (_type_info->type() == OLAP_FIELD_TYPE_VARCHAR ||
- _type_info->type() == OLAP_FIELD_TYPE_HLL ||
- _type_info->type() == OLAP_FIELD_TYPE_OBJECT ||
- _type_info->type() == OLAP_FIELD_TYPE_STRING) {
-int32_t length = _default_value.length();
-char* string_buffer =
reinterpret_cast(_pool->allocate(length));
-memory_copy(string_buffer, _default_value.c_str(), length);
-((Slice*)_mem_value)->size = length;
-((Slice*)_mem_value)->data = string_buffer;
+// If char length is 10, but default value is 'a' , it's length is
1
+// not fill 0 to the ending, because segment iterator will shrink
the tail 0 char
+if (_type_info->type() == OLAP_FIELD_TYPE_VARCHAR ||
+_type_info->type() == OLAP_FIELD_TYPE_HLL ||
+_type_info->type() == OLAP_FIELD_TYPE_OBJECT ||
+_type_info->type() == OLAP_FIELD_TYPE_STRING ||
+_type_info->type() == OLAP_FIELD_TYPE_CHAR) {
+((Slice*)_mem_value.data())->size = _default_value.length();
+((Slice*)_mem_value.data())->data = _default_value.data();
} else if (_type_info->type() == OLAP_FIELD_TYPE_ARRAY) {
// TODO llj for Array default value
return Status::NotSupported("Array default type is
unsupported");
} else {
-s = _type_info->from_string(_mem_value, _default_value,
_precision, _scale);
+s = _type_info->from_string(_mem_value.data(), _default_value,
_precision, _scale);
}
if (!s.ok()) {
return s;
@@ -1030,7 +1023,7 @@ Status DefaultValueColumnIterator::next_batch(size_t* n,
ColumnBlockView* dst, b
} else {
*has_null = false;
for (int i = 0; i < *n; ++i) {
-memcpy(dst->data(), _mem_value, _type_size);
+memcpy(dst->data(), _mem_value.data(), _type_size);
dst->advance(1);
}
}
@@ -1117,7 +1110,7 @@ void
DefaultValueColumnIterator::_insert_many_default(vectorized::MutableColumnP
if (_is_default_value_null) {
dst->insert_many_defaults(n);
} else {
-insert_default_data(_type_info.get(), _type_size, _mem_value, dst, n);
+insert_default_data(_type_info.get(), _type_size, _mem_value.data(),
dst, n);
}
}
diff --git a/be/src/olap/rowset/segment_v2/column_reader.h
b/be/src/olap/rowset/segment_v2/column_reader.h
index 5a86bdec10..81be872f3d 100644
---
[GitHub] [doris] yiguolei commented on pull request #17085: [Fix](load) Fix memory leak for stream load 2pc #16430
yiguolei commented on PR #17085: URL: https://github.com/apache/doris/pull/17085#issuecomment-1443528838 ./run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443529940 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #17085: [Fix](load) Fix memory leak for stream load 2pc #16430
ZhangGuoqiang666 commented on PR #17085: URL: https://github.com/apache/doris/pull/17085#issuecomment-1443536384 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #16869: [Improvement](jsonb) add suport for JSONB type for arrow
xiaokang commented on PR #16869: URL: https://github.com/apache/doris/pull/16869#issuecomment-1443537520 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #17028: [fix](Nereids) mow unique table's preagg should work like duplicate table
morrySnow commented on PR #17028: URL: https://github.com/apache/doris/pull/17028#issuecomment-1443538380 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16869: [Improvement](jsonb) add suport for JSONB type for arrow
github-actions[bot] commented on PR #16869: URL: https://github.com/apache/doris/pull/16869#issuecomment-1443541239 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443551304 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17118: [fix](Nereids): fix rank
github-actions[bot] commented on PR #17118: URL: https://github.com/apache/doris/pull/17118#issuecomment-1443555026 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17118: [fix](Nereids): fix rank
github-actions[bot] commented on PR #17118: URL: https://github.com/apache/doris/pull/17118#issuecomment-1443555076 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443577161 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zhannngchen opened a new pull request, #17121: [cherry-pick](storage) add a new hidden column __DORIS_VERSION_COL__ for unique key table
zhannngchen opened a new pull request, #17121: URL: https://github.com/apache/doris/pull/17121 cp #16509 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly opened a new pull request, #17122: [fix](regression case)fix regression case: test_materialized_view_struct
englefly opened a new pull request, #17122:
URL: https://github.com/apache/doris/pull/17122
# Proposed changes
this case missed
sql "ADMIN SET FRONTEND CONFIG ('enable_struct_type' = 'true');"
if enable_struct_type==false, the case will fail
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee merged pull request #16935: [Fix](function)fix datatime-diff function's overflow
HappenLee merged PR #16935: URL: https://github.com/apache/doris/pull/16935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (707160ab73 -> b5d67781a2)
This is an automated email from the ASF dual-hosted git repository.
lihaopeng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
from 707160ab73 [fix](regression) fix regression test case of convert
function (#17107)
add b5d67781a2 [Fix](function)fix datatime-diff function's overflow
(#16935)
No new revisions were added by this update.
Summary of changes:
.../function_date_or_datetime_computation.h| 8 +++-
be/src/vec/runtime/vdatetime_value.cpp | 12 +
be/src/vec/runtime/vdatetime_value.h | 55 ++
.../datetime_functions/test_time_diff.out} | 12 ++---
.../datetime_functions/test_time_diff.groovy | 21 -
5 files changed, 48 insertions(+), 60 deletions(-)
copy
regression-test/data/{nereids_p0/sql_functions/cast_function/test_cast_function.out
=> query_p0/sql_functions/datetime_functions/test_time_diff.out} (73%)
copy be/src/common/global_types.h =>
regression-test/suites/query_p0/sql_functions/datetime_functions/test_time_diff.groovy
(59%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16616: [Feature](nereids) Support Mark join
github-actions[bot] commented on PR #16616: URL: https://github.com/apache/doris/pull/16616#issuecomment-1443598095 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann opened a new pull request, #17123: [feature](Nereids): show cost for each plan
XieJiann opened a new pull request, #17123: URL: https://github.com/apache/doris/pull/17123 # Proposed changes 1. Show cost in optimized plan 2. show plan time ... in profile ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon opened a new pull request, #17124: [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint.
eldenmoon opened a new pull request, #17124: URL: https://github.com/apache/doris/pull/17124 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17122: [fix](regression case)fix regression case: test_materialized_view_struct
github-actions[bot] commented on PR #17122: URL: https://github.com/apache/doris/pull/17122#issuecomment-1443611403 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17122: [fix](regression case)fix regression case: test_materialized_view_struct
github-actions[bot] commented on PR #17122: URL: https://github.com/apache/doris/pull/17122#issuecomment-1443611348 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17124: [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint.
github-actions[bot] commented on code in PR #17124:
URL: https://github.com/apache/doris/pull/17124#discussion_r1116920411
##
be/src/vec/exec/format/json/new_json_reader.cpp:
##
@@ -1303,27 +1304,49 @@ Status
NewJsonReader::_simdjson_handle_nested_complex_json(
return Status::OK();
}
+size_t NewJsonReader::_column_index(const StringRef& name, size_t key_index) {
+/// Optimization by caching the order of fields (which is almost always
the same)
+/// and a quick check to match the next expected field, instead of
searching the hash table.
+if (_prev_positions.size() > key_index && _prev_positions[key_index] &&
+name == _prev_positions[key_index]->get_first()) {
+return _prev_positions[key_index]->get_second();
+} else {
+auto* it = _slot_desc_index.find(name);
+if (it) {
+if (key_index < _prev_positions.size()) {
+_prev_positions[key_index] = it;
+}
+return it->get_second();
+} else
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
e {
;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luzhijing commented on pull request #17116: [doc](typo)Update run-docker-cluster.md
luzhijing commented on PR #17116: URL: https://github.com/apache/doris/pull/17116#issuecomment-1443614229 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luzhijing commented on pull request #17115: [typo](doc)Added stream load import csv file title filter document example
luzhijing commented on PR #17115: URL: https://github.com/apache/doris/pull/17115#issuecomment-1443615525 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17116: [doc](typo)Update run-docker-cluster.md
github-actions[bot] commented on PR #17116: URL: https://github.com/apache/doris/pull/17116#issuecomment-1443614828 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17116: [doc](typo)Update run-docker-cluster.md
github-actions[bot] commented on PR #17116: URL: https://github.com/apache/doris/pull/17116#issuecomment-1443614882 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17115: [typo](doc)Added stream load import csv file title filter document example
github-actions[bot] commented on PR #17115: URL: https://github.com/apache/doris/pull/17115#issuecomment-1443616008 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17115: [typo](doc)Added stream load import csv file title filter document example
github-actions[bot] commented on PR #17115: URL: https://github.com/apache/doris/pull/17115#issuecomment-1443616067 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17124: [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint.
github-actions[bot] commented on PR #17124: URL: https://github.com/apache/doris/pull/17124#issuecomment-1443618066 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #17124: [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint.
github-actions[bot] commented on code in PR #17124:
URL: https://github.com/apache/doris/pull/17124#discussion_r1116925372
##
be/src/vec/exec/format/json/new_json_reader.cpp:
##
@@ -1303,27 +1304,50 @@ Status
NewJsonReader::_simdjson_handle_nested_complex_json(
return Status::OK();
}
+size_t NewJsonReader::_column_index(const StringRef& name, size_t key_index) {
+/// Optimization by caching the order of fields (which is almost always
the same)
+/// and a quick check to match the next expected field, instead of
searching the hash table.
+if (_prev_positions.size() > key_index && _prev_positions[key_index] &&
+name == _prev_positions[key_index]->get_first()) {
+return _prev_positions[key_index]->get_second();
+} else {
+auto* it = _slot_desc_index.find(name);
+if (it) {
+if (key_index < _prev_positions.size()) {
+_prev_positions[key_index] = it;
+}
+return it->get_second();
+} else {
+return size_t(-1);
+}
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
e {
;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luzhijing commented on pull request #17113: 补充批量删除注意事项
luzhijing commented on PR #17113: URL: https://github.com/apache/doris/pull/17113#issuecomment-1443619590 Hello, please use English in community and supplement the corresponding English documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17030: [Feature](Materialized-View) forbiden rename column on materialized view
github-actions[bot] commented on PR #17030: URL: https://github.com/apache/doris/pull/17030#issuecomment-1443619720 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17030: [Feature](Materialized-View) forbiden rename column on materialized view
github-actions[bot] commented on PR #17030: URL: https://github.com/apache/doris/pull/17030#issuecomment-1443619788 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #17122: [fix](regression case)fix regression case: test_materialized_view_struct
xy720 commented on PR #17122: URL: https://github.com/apache/doris/pull/17122#issuecomment-1443620680 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #17122: [fix](regression case)fix regression case: test_materialized_view_struct
xy720 commented on PR #17122: URL: https://github.com/apache/doris/pull/17122#issuecomment-1443620873 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #17125: [improvement](mysql) merge connect context and mysql channel and reduce send buffer memory
morningman opened a new pull request, #17125: URL: https://github.com/apache/doris/pull/17125 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
