[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436952496 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
Tanya-W commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436953081 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436953979 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1436954435 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map
xy720 commented on code in PR #16948:
URL: https://github.com/apache/doris/pull/16948#discussion_r890046
##
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##
@@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws
AnalysisException {
Type keyType = Type.NULL;
Type valueType = Type.NULL;
children = new ArrayList<>();
-int idx = 0;
-// TODO(xy): limit key type to scalar type
-for (LiteralExpr expr : exprs) {
-if (idx % 2 == 0) {
-if (keyType == Type.NULL) {
-keyType = expr.getType();
-} else {
-keyType = Type.getAssignmentCompatibleType(keyType,
expr.getType(), true);
-}
-if (keyType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
-} else {
-if (valueType == Type.NULL) {
-valueType = expr.getType();
-} else {
-valueType = Type.getAssignmentCompatibleType(valueType,
expr.getType(), true);
-}
-if (valueType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
+for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx +=
2) {
+// limit key type to scalar type
+keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
+if (keyType == Type.INVALID || !keyType.isScalarType()) {
+throw new AnalysisException("Invalid key type in Map Only
support scalar type");
+}
+valueType = Type.getAssignmentCompatibleType(valueType, exprs[idx
+ 1].getType(), true);
+if (valueType == Type.INVALID) {
+throw new AnalysisException("Invalid value type in Map");
}
-children.add(expr);
-++ idx;
+children.add(exprs[idx]);
+children.add(exprs[idx + 1]);
Review Comment:
Just a example:
```
for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx += 2) {
if (MapType.supportKeyType(exprs[idx].getType())) {
throw new AnalysisException("Invalid key type in Map, not support "
+ keyType);
}
keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
valueType = Type.getAssignmentCompatibleType(valueType, exprs[idx +
1].getType(), true);
}
if (keyType == Type.INVALID) {
throw new AnalysisException("Invalid key type in Map.");
}
if (valueType == Type.INVALID) {
throw new AnalysisException("Invalid value type in Map.");
}
for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx += 2) {
if (exprs[idx].getType().equals(keyType)) {
children.add(expr[idx]);
} else {
children.add(expr[idx].castTo(keyType));
}
if (exprs[idx+1].getType().equals(valueType)) {
children.add(expr[idx+1]);
} else {
children.add(expr[idx+1].castTo(valueType));
}
}
```
##
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##
@@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws
AnalysisException {
Type keyType = Type.NULL;
Type valueType = Type.NULL;
children = new ArrayList<>();
-int idx = 0;
-// TODO(xy): limit key type to scalar type
-for (LiteralExpr expr : exprs) {
-if (idx % 2 == 0) {
-if (keyType == Type.NULL) {
-keyType = expr.getType();
-} else {
-keyType = Type.getAssignmentCompatibleType(keyType,
expr.getType(), true);
-}
-if (keyType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
-} else {
-if (valueType == Type.NULL) {
-valueType = expr.getType();
-} else {
-valueType = Type.getAssignmentCompatibleType(valueType,
expr.getType(), true);
-}
-if (valueType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
+for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx +=
2) {
+// limit key type to scalar type
+keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
+if (keyType == Type.INVALID || !keyType.isScalarType()) {
+throw new AnalysisException("Invalid key type in Map Only
support scalar type");
Review Comment:
1、Put this error outside the loop.
2、Types such as float、double、bitmap、hll is al
[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map
xy720 commented on code in PR #16948:
URL: https://github.com/apache/doris/pull/16948#discussion_r821110
##
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##
@@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws
AnalysisException {
Type keyType = Type.NULL;
Type valueType = Type.NULL;
children = new ArrayList<>();
-int idx = 0;
-// TODO(xy): limit key type to scalar type
-for (LiteralExpr expr : exprs) {
-if (idx % 2 == 0) {
-if (keyType == Type.NULL) {
-keyType = expr.getType();
-} else {
-keyType = Type.getAssignmentCompatibleType(keyType,
expr.getType(), true);
-}
-if (keyType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
-} else {
-if (valueType == Type.NULL) {
-valueType = expr.getType();
-} else {
-valueType = Type.getAssignmentCompatibleType(valueType,
expr.getType(), true);
-}
-if (valueType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
+for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx +=
2) {
+// limit key type to scalar type
+keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
+if (keyType == Type.INVALID || !keyType.isScalarType()) {
+throw new AnalysisException("Invalid key type in Map Only
support scalar type");
Review Comment:
1、Put this error outside the loop.
2、When the exprs are all scala types, this error may still be thrown.
3、Types such as float、double、bitmap、hll is also scala type but shouldn't be
key type.
4、Users may be don't know what is `scala type`. Use actual type in msg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map
xy720 commented on code in PR #16948:
URL: https://github.com/apache/doris/pull/16948#discussion_r821110
##
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##
@@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws
AnalysisException {
Type keyType = Type.NULL;
Type valueType = Type.NULL;
children = new ArrayList<>();
-int idx = 0;
-// TODO(xy): limit key type to scalar type
-for (LiteralExpr expr : exprs) {
-if (idx % 2 == 0) {
-if (keyType == Type.NULL) {
-keyType = expr.getType();
-} else {
-keyType = Type.getAssignmentCompatibleType(keyType,
expr.getType(), true);
-}
-if (keyType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
-} else {
-if (valueType == Type.NULL) {
-valueType = expr.getType();
-} else {
-valueType = Type.getAssignmentCompatibleType(valueType,
expr.getType(), true);
-}
-if (valueType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
+for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx +=
2) {
+// limit key type to scalar type
+keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
+if (keyType == Type.INVALID || !keyType.isScalarType()) {
+throw new AnalysisException("Invalid key type in Map Only
support scalar type");
Review Comment:
1、Put this error outside the loop.
2、When the exprs are all scala types, this error may still be thrown.
3、Types such as float、double、bitmap、hll are also scala type but shouldn't be
key type.
4、Users may be don't know what is `scala type`. Use actual type in msg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16564: [feature](merge-on-write) add DCHECK in compaction to detect data inconsistency
github-actions[bot] commented on PR #16564: URL: https://github.com/apache/doris/pull/16564#issuecomment-1436984938 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #16953: [Function](vec) use const column to opt function current_time()
HappenLee opened a new pull request, #16953: URL: https://github.com/apache/doris/pull/16953 # Proposed changes Before： ``` mysql> select count(current_time()) from hits; +---+ | count(current_time()) | +---+ | 7497 | +---+ 1 row in set (0.52 sec) ``` After: ``` mysql> select count(current_time()) from hits; +---+ | count(current_time()) | +---+ | 7497 | +---+ 1 row in set (0.36 sec) ``` ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1436998931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437005544 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] xy720 closed issue #9302: [Feature] Support protobuf format for routine load
xy720 closed issue #9302: [Feature] Support protobuf format for routine load URL: https://github.com/apache/doris/issues/9302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437015994 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437016465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16941: (feature)[DOE]Support array for Doris on ES
github-actions[bot] commented on PR #16941: URL: https://github.com/apache/doris/pull/16941#issuecomment-1437021424 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …
freemandealer commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437022897 After apply this pr, the error output would be like: ``` "Message": "[INTERNAL_ERROR]cancelled: [INTERNAL_ERROR]tablet error: tablet writer write failed, tablet_id=10083, txn_id=2, err=[E-238], host: 127.0.0.1", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] sohardforaname commented on pull request #16824: [regression-test](Nereids) add agg function, tvf, generator, window function test cases
sohardforaname commented on PR #16824: URL: https://github.com/apache/doris/pull/16824#issuecomment-1437023157 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16941: (feature)[DOE]Support array for Doris on ES
github-actions[bot] commented on PR #16941: URL: https://github.com/apache/doris/pull/16941#issuecomment-1437027164 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16931: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module.
hello-stephen commented on PR #16931: URL: https://github.com/apache/doris/pull/16931#issuecomment-1437030622 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.95 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220133047_clickbench_pr_100319.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer opened a new issue, #16954: [Bug] useless error message when tablet write failed
freemandealer opened a new issue, #16954:
URL: https://github.com/apache/doris/issues/16954
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
newest upstream
### What's Wrong?
{
"TxnId": 2,
"Label": "540c920e-65b4-40ac-a024-3560d770acf4",
"TwoPhaseCommit": "false",
"Status": "Fail",
"Message": "[INTERNAL_ERROR]cancelled: [INTERNAL_ERROR]tablet error:
tablet writer write failed, tablet_id=10083, txn_id=2, err=**false**, host:
127.0.0.1",
"NumberTotalRows": 0,
"NumberLoadedRows": 0,
"NumberFilteredRows": 0,
"NumberUnselectedRows": 0,
"LoadBytes": 20840448,
"LoadTimeMs": 1372,
"BeginTxnTimeMs": 16,
"StreamLoadPutTimeMs": 134,
"ReadDataTimeMs": 99,
"WriteDataTimeMs": 144,
"CommitAndPublishTimeMs": 0
}
### What You Expected?
The message should be clear reason where the writing is failing at, not just
'false'
### How to Reproduce?
use less max segment per rowset parameter to trigger tablet writer failed at
-238
then you can see the stale dummy message in both command output or logs.
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #16931: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module.
BiteThet merged PR #16931: URL: https://github.com/apache/doris/pull/16931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog module. (#16931)
This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a46941c684 [Fix](multi-catalog) Fix switch-case fall-through issue in
multi-catalog module. (#16931)
a46941c684 is described below
commit a46941c684a7dc3610ce09eafb9130bc764ca8a6
Author: Qi Chen
AuthorDate: Mon Feb 20 21:35:41 2023 +0800
[Fix](multi-catalog) Fix switch-case fall-through issue in multi-catalog
module. (#16931)
Fix switch-case fall-through issue in multi-catalog module.
---
be/src/vec/exec/format/csv/csv_reader.cpp| 6 ++
.../vec/exec/format/file_reader/new_plain_binary_line_reader.cpp | 2 ++
be/src/vec/exec/format/json/new_json_reader.cpp | 2 ++
be/src/vec/exec/format/orc/vorc_reader.cpp | 3 +++
be/src/vec/exec/format/parquet/byte_array_dict_decoder.cpp | 1 +
be/src/vec/exec/format/parquet/byte_array_plain_decoder.cpp | 1 +
be/src/vec/exec/format/parquet/decoder.cpp | 9 ++---
be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp | 2 ++
be/src/vec/exec/format/parquet/fix_length_plain_decoder.cpp | 1 +
be/src/vec/exec/format/parquet/parquet_pred_cmp.h| 6 ++
be/src/vec/exec/format/parquet/schema_desc.cpp | 7 +++
be/src/vec/exec/format/parquet/vparquet_column_chunk_reader.cpp | 2 ++
12 files changed, 39 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/exec/format/csv/csv_reader.cpp
b/be/src/vec/exec/format/csv/csv_reader.cpp
index cbd8954207..f4cb13e85d 100644
--- a/be/src/vec/exec/format/csv/csv_reader.cpp
+++ b/be/src/vec/exec/format/csv/csv_reader.cpp
@@ -155,10 +155,15 @@ Status CsvReader::init_reader(bool is_load) {
switch (_file_format_type) {
case TFileFormatType::FORMAT_CSV_PLAIN:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_GZ:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_BZ2:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_LZ4FRAME:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_LZOP:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_DEFLATE:
_line_reader.reset(new NewPlainTextLineReader(_profile, _file_reader,
_decompressor.get(),
_size, _line_delimiter,
@@ -298,6 +303,7 @@ Status CsvReader::_create_decompressor() {
} else {
switch (_file_format_type) {
case TFileFormatType::FORMAT_PROTO:
+[[fallthrough]];
case TFileFormatType::FORMAT_CSV_PLAIN:
compress_type = CompressType::UNCOMPRESSED;
break;
diff --git
a/be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.cpp
b/be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.cpp
index ca80428c38..493fad180a 100644
--- a/be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.cpp
+++ b/be/src/vec/exec/format/file_reader/new_plain_binary_line_reader.cpp
@@ -40,7 +40,9 @@ Status NewPlainBinaryLineReader::read_line(const uint8_t**
ptr, size_t* size, bo
size_t read_size = 0;
switch (_file_type) {
case TFileType::FILE_LOCAL:
+[[fallthrough]];
case TFileType::FILE_HDFS:
+[[fallthrough]];
case TFileType::FILE_S3: {
size_t file_size = _file_reader->size();
file_buf.reset(new uint8_t[file_size]);
diff --git a/be/src/vec/exec/format/json/new_json_reader.cpp
b/be/src/vec/exec/format/json/new_json_reader.cpp
index ce6d371658..f321a43d9c 100644
--- a/be/src/vec/exec/format/json/new_json_reader.cpp
+++ b/be/src/vec/exec/format/json/new_json_reader.cpp
@@ -988,7 +988,9 @@ std::string NewJsonReader::_print_json_value(const
rapidjson::Value& value) {
Status NewJsonReader::_read_one_message(std::unique_ptr* file_buf,
size_t* read_size) {
switch (_params.file_type) {
case TFileType::FILE_LOCAL:
+[[fallthrough]];
case TFileType::FILE_HDFS:
+[[fallthrough]];
case TFileType::FILE_S3: {
size_t file_size = _file_reader->size();
file_buf->reset(new uint8_t[file_size]);
diff --git a/be/src/vec/exec/format/orc/vorc_reader.cpp
b/be/src/vec/exec/format/orc/vorc_reader.cpp
index 6710642834..8662f52ebf 100644
--- a/be/src/vec/exec/format/orc/vorc_reader.cpp
+++ b/be/src/vec/exec/format/orc/vorc_reader.cpp
@@ -331,8 +331,11 @@ static std::tuple
convert_to_orc_literal(const orc::Type* ty
case orc::TypeKind::DOUBLE:
return std::make_tuple(true, orc::Literal(*((double*)value)));
case orc::TypeKind::STRING:
+[[fallthrough]];
case orc::TypeKind::BINARY:
+[[fallthrough]];
case orc::TypeKind::CHAR:
+[[fallthrough]];
case orc::TypeKind::VARCHAR: {
String
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #16955: [Enchancement](function) refact and optimize some function register
BiteThet opened a new pull request, #16955: URL: https://github.com/apache/doris/pull/16955 # Proposed changes 1. refact function create helper 2. use AggregateFunctionNullUnaryInline to optimize group_by_or/and/xor and distinct combinator. 3.42 sec -> 3.27 sec ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16955: [Enchancement](function) refact and optimize some function register
github-actions[bot] commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437047271 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052296 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437052447 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #16955: [Enchancement](function) refact and optimize some function register
BiteThet commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437055466 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
Tanya-W commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1437057948 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16952: [improve](inverted index) not apply inverted index on 'in' or 'not_in' predicate which is produced by runtime_filter
github-actions[bot] commented on PR #16952: URL: https://github.com/apache/doris/pull/16952#issuecomment-1437060541 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
github-actions[bot] commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437062027 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded
github-actions[bot] commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437063933 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437065821 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066021 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437066287 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different
github-actions[bot] commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437068284 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437069243 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16955: [Enchancement](function) refact and optimize some function register
hello-stephen commented on PR #16955: URL: https://github.com/apache/doris/pull/16955#issuecomment-1437082077 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.77 seconds stream load tsv: 471 seconds loaded 74807831229 Bytes, about 151 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220140949_clickbench_pr_100395.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16953: [Function](vec) use const column to opt function current_time()
github-actions[bot] commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437085365 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437094418 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16850: [improvement](vec) avoid creating a new column while filtering mutable columns
github-actions[bot] commented on PR #16850: URL: https://github.com/apache/doris/pull/16850#issuecomment-1437105520 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko opened a new pull request, #16956: [fix](cooldown) Forbid re-add replica with cooldowned rowsets
platoneko opened a new pull request, #16956: URL: https://github.com/apache/doris/pull/16956 # Proposed changes Issue Number: close #xxx ## Problem summary Forbid re-add replica with cooldowned rowsets, because these cooldowned rowsets may already been confirmed as unused data and deleted. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #16957: [fix](auth) fix losing global priv bug and refactor default role name
morningman opened a new pull request, #16957: URL: https://github.com/apache/doris/pull/16957 # Proposed changes Issue Number: close #xxx ## Problem summary This PR mainly changes: 1. When upgrading from old version to master, the ADMIN_PRIV for normal user may be lost. This may only happen if: 1. Create a user with ADMIN_PRIV privilege. 2. Upgrade Doris to v1.2.x or master before the meta image which contains the edit log in step 1 is generate. And the ADMIN_PRIV will be lost in Global Privileges This PR will rectify this bug and set ADMIN_PRIV to the right place 2. Refactor the user's implicit role name In #16091, we refactor the Doris auth model by introducing RBAC. And each user will have an implicit role, named with prefix `default_role_rbac_`. But it has wrong format like: `default_role_rbac_'default_cluster:user1'@'%'` This PR change the role name's format, like: ``` default_role_rbac_user1@% default_role_rbac_user2@[domain] ``` NOTICE: this change may cause incompatible metadata, but since #16091 is not released, we should fix it soon. 3. Add a new session variable `show_user_default_role` When set to true, it will show implicit role of user in the result of `show roles` stmt. Default is false ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 02/03: 3
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch auth_replay_bg
in repository https://gitbox.apache.org/repos/asf/doris.git
commit c6f30fadc2aaedbfd164f96874f525325eb66d5f
Author: morningman
AuthorDate: Mon Feb 20 22:06:08 2023 +0800
3
---
.../java/org/apache/doris/analysis/UserIdentity.java | 15 +++
.../java/org/apache/doris/mysql/privilege/Role.java | 19 ---
.../org/apache/doris/mysql/privilege/RoleManager.java | 14 ++
.../java/org/apache/doris/qe/SessionVariable.java | 10 ++
4 files changed, 51 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/UserIdentity.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/UserIdentity.java
index 4b50479f66..0dae2ff17a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/UserIdentity.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/UserIdentity.java
@@ -27,6 +27,7 @@ import org.apache.doris.common.PatternMatcherWrapper;
import org.apache.doris.common.io.Text;
import org.apache.doris.common.io.Writable;
import org.apache.doris.mysql.privilege.Auth;
+import org.apache.doris.mysql.privilege.RoleManager;
import org.apache.doris.persist.gson.GsonPostProcessable;
import org.apache.doris.persist.gson.GsonUtils;
import org.apache.doris.thrift.TUserIdentity;
@@ -210,6 +211,20 @@ public class UserIdentity implements Writable,
GsonPostProcessable {
return tUserIdent;
}
+// return default_role_rbac_username@host or
default_role_rbac_username@[domain]
+public String toDefaultRoleName() {
+StringBuilder sb = new StringBuilder(
+RoleManager.DEFAULT_ROLE_PREFIX +
ClusterNamespace.getNameFromFullName(user) + "@");
+if (isDomain) {
+sb.append("[");
+}
+sb.append(host);
+if (isDomain) {
+sb.append("]");
+}
+return sb.toString();
+}
+
public static UserIdentity read(DataInput in) throws IOException {
// Use Gson in the VERSION_109
if (Env.getCurrentEnvJournalVersion() < FeMetaVersion.VERSION_109) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
b/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
index 3894a32094..dc7b5a161b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Role.java
@@ -546,7 +546,7 @@ public class Role implements Writable, GsonPostProcessable {
PrivBitSet privs = entry.getValue();
if (privs.containsPrivs(Privilege.ADMIN_PRIV, Privilege.NODE_PRIV,
Privilege.USAGE_PRIV)
&& tblPattern.getPrivLevel() != PrivLevel.GLOBAL) {
-LOG.info("retify privs: {} -> {}", tblPattern, privs);
+LOG.debug("rectify privs {}: {} -> {}", roleName, tblPattern,
privs);
PrivBitSet copiedPrivs = privs.copy();
copiedPrivs.and(PrivBitSet.of(Privilege.ADMIN_PRIV,
Privilege.NODE_PRIV, Privilege.USAGE_PRIV));
modifiedGlobalPrivs.or(copiedPrivs);
@@ -554,7 +554,8 @@ public class Role implements Writable, GsonPostProcessable {
privs.unset(Privilege.USAGE_PRIV.getIdx());
privs.unset(Privilege.NODE_PRIV.getIdx());
privs.unset(Privilege.ADMIN_PRIV.getIdx());
-
+LOG.debug("alter rectify privs {}: {} -> {}, modified global
priv: {}",
+roleName, tblPattern, privs, modifiedGlobalPrivs);
}
}
if (!modifiedGlobalPrivs.isEmpty()) {
@@ -565,6 +566,9 @@ public class Role implements Writable, GsonPostProcessable {
privBitSet.or(modifiedGlobalPrivs);
}
}
+
+// rebuild these priv tables
+rebuildPrivTables();
}
@Override
@@ -621,7 +625,16 @@ public class Role implements Writable, GsonPostProcessable
{
}
@Override
-public void gsonPostProcess() throws IOException {
+public void gsonPostProcess() {
+rebuildPrivTables();
+}
+
+private void rebuildPrivTables() {
+globalPrivTable = new GlobalPrivTable();
+catalogPrivTable = new CatalogPrivTable();
+dbPrivTable = new DbPrivTable();
+tablePrivTable = new TablePrivTable();
+resourcePrivTable = new ResourcePrivTable();
for (Entry entry :
tblPatternToPrivs.entrySet()) {
try {
grantPrivs(entry.getKey(), entry.getValue().copy());
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/RoleManager.java
b/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/RoleManager.java
index b09ee99f4f..85a148399c 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/RoleManager.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/
[doris] branch auth_replay_bg created (now 0b574c532d)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git at 0b574c532d add doc This branch includes the following new commits: new c17eceaad4 1 new c6f30fadc2 3 new 0b574c532d add doc The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 03/03: add doc
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch auth_replay_bg in repository https://gitbox.apache.org/repos/asf/doris.git commit 0b574c532d8aa6954859404d3baa5b2e63c96c34 Author: morningman AuthorDate: Mon Feb 20 22:17:32 2023 +0800 add doc --- docs/en/docs/advanced/variables.md| 6 ++ docs/zh-CN/docs/advanced/variables.md | 6 ++ 2 files changed, 12 insertions(+) diff --git a/docs/en/docs/advanced/variables.md b/docs/en/docs/advanced/variables.md index 59e8bf1fac..2d82126091 100644 --- a/docs/en/docs/advanced/variables.md +++ b/docs/en/docs/advanced/variables.md @@ -584,3 +584,9 @@ Translated with www.DeepL.com/Translator (free version) * `drop_table_if_ctas_failed` Controls whether create table as select deletes created tables when a insert error occurs, the default value is true. + +* `show_user_default_role` + + + +Controls whether to show each user's implicit roles in the results of `show roles`. Default is false. diff --git a/docs/zh-CN/docs/advanced/variables.md b/docs/zh-CN/docs/advanced/variables.md index a660683362..f67f02ef90 100644 --- a/docs/zh-CN/docs/advanced/variables.md +++ b/docs/zh-CN/docs/advanced/variables.md @@ -571,3 +571,9 @@ SELECT /*+ SET_VAR(query_timeout = 1, enable_partition_cache=true) */ sleep(3); * `drop_table_if_ctas_failed` 控制create table as select在写入发生错误时是否删除已创建的表，默认为true。 + +* `show_user_default_role` + + + +控制是否在 `show roles` 的结果里显示每个用户隐式对应的角色。默认为 false。 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 01/03: 1
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch auth_replay_bg
in repository https://gitbox.apache.org/repos/asf/doris.git
commit c17eceaad4533d628662de19f97e334e0b083ac6
Author: morningman
AuthorDate: Mon Feb 20 18:41:55 2023 +0800
1
---
.../src/main/java/org/apache/doris/PaloFe.java | 6 ++--
.../main/java/org/apache/doris/catalog/Env.java| 8 +++--
.../org/apache/doris/mysql/privilege/Auth.java | 41 +-
.../org/apache/doris/mysql/privilege/Role.java | 35 ++
.../apache/doris/mysql/privilege/RoleManager.java | 6
.../doris/persist/meta/MetaPersistMethod.java | 4 +--
6 files changed, 75 insertions(+), 25 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
index 6fb315dced..61095e141d 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
@@ -121,7 +121,7 @@ public class PaloFe {
// check command line options
checkCommandLineOptions(cmdLineOpts);
-LOG.info("Palo FE starting...");
+LOG.info("Doris FE starting...");
FrontendOptions.init();
@@ -196,7 +196,7 @@ public class PaloFe {
/*
* -v --version
- * Print the version of Palo Frontend
+ * Print the version of Doris Frontend
* -h --helper
* Specify the helper node when joining a bdb je replication group
* -i --image
@@ -222,7 +222,7 @@ public class PaloFe {
private static CommandLineOptions parseArgs(String[] args) {
CommandLineParser commandLineParser = new DefaultParser();
Options options = new Options();
-options.addOption("v", "version", false, "Print the version of Palo
Frontend");
+options.addOption("v", "version", false, "Print the version of Doris
Frontend");
options.addOption("h", "helper", true, "Specify the helper node when
joining a bdb je replication group");
options.addOption("i", "image", true, "Check if the specified image is
valid");
options.addOption("b", "bdb", false, "Run bdbje debug tools");
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index febad5ea76..55bda1f4dc 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -1350,6 +1350,8 @@ public class Env {
}
}
}
+
+auth.rectifyPrivs();
}
// start all daemon threads only running on Master
@@ -1821,10 +1823,10 @@ public class Env {
return checksum;
}
-public long loadPaloAuth(DataInputStream dis, long checksum) throws
IOException {
+public long loadAuth(DataInputStream dis, long checksum) throws
IOException {
// CAN NOT use Auth.read(), cause this auth instance is already passed
to DomainResolver
auth.readFields(dis);
-LOG.info("finished replay paloAuth from image");
+LOG.info("finished replay auth from image");
return checksum;
}
@@ -2095,7 +2097,7 @@ public class Env {
return checksum;
}
-public long savePaloAuth(CountingDataOutputStream dos, long checksum)
throws IOException {
+public long saveAuth(CountingDataOutputStream dos, long checksum) throws
IOException {
auth.write(dos);
return checksum;
}
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
b/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
index 441573dda1..14af84b91e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/Auth.java
@@ -84,7 +84,7 @@ public class Auth implements Writable {
private static final Logger LOG = LogManager.getLogger(Auth.class);
// root user's role is operator.
-// each Palo system has only one root user.
+// each Doris system has only one root user.
public static final String ROOT_USER = "root";
public static final String ADMIN_USER = "admin";
// unknown user does not have any privilege, this is just to be compatible
with old version.
@@ -1222,13 +1222,13 @@ public class Auth implements Writable {
.getNameFromFullName(user.getUserIdentity().getQualifiedUser()))
.concat("\'@\'").concat(user.getUserIdentity().getHost()).concat("\'");
String isGrantable =
tablePrivEntry.getPrivSet().get(2) ? "YES" : "NO"; // GRANT_PRIV
-for (Privilege paloPriv :
tablePrivEntry.getPrivSet().toPrivilegeList()) {
-if
(!Privilege.privInDorisToMysql.c
[GitHub] [doris] dataroaring commented on a diff in pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error
dataroaring commented on code in PR #16472:
URL: https://github.com/apache/doris/pull/16472#discussion_r1112009136
##
be/src/olap/tablet.h:
##
@@ -391,6 +391,14 @@ class Tablet : public BaseTablet {
}
}
+inline void increase_io_error_times() { ++_io_error_times; }
+
+inline int64_t get_io_error_times() const { return _io_error_times; }
+
+inline bool is_io_error_too_times() const {
Review Comment:
Maybe we can use a name like exceeds_threshold or too_many?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1437135172 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1437135104 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] wangyf0555 closed pull request #192: website optimization
wangyf0555 closed pull request #192: website optimization URL: https://github.com/apache/doris-website/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #16928: [fix](tvf) fix bug that failed to get schema of tvf when file is empty
morningman commented on PR #16928: URL: https://github.com/apache/doris/pull/16928#issuecomment-1437146050 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] amorynan commented on a diff in pull request #16948: [Improve](map-type) Add contains_null for map
amorynan commented on code in PR #16948:
URL: https://github.com/apache/doris/pull/16948#discussion_r1112054418
##
fe/fe-core/src/main/java/org/apache/doris/analysis/MapLiteral.java:
##
@@ -47,30 +47,18 @@ public MapLiteral(LiteralExpr... exprs) throws
AnalysisException {
Type keyType = Type.NULL;
Type valueType = Type.NULL;
children = new ArrayList<>();
-int idx = 0;
-// TODO(xy): limit key type to scalar type
-for (LiteralExpr expr : exprs) {
-if (idx % 2 == 0) {
-if (keyType == Type.NULL) {
-keyType = expr.getType();
-} else {
-keyType = Type.getAssignmentCompatibleType(keyType,
expr.getType(), true);
-}
-if (keyType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
-} else {
-if (valueType == Type.NULL) {
-valueType = expr.getType();
-} else {
-valueType = Type.getAssignmentCompatibleType(valueType,
expr.getType(), true);
-}
-if (valueType == Type.INVALID) {
-throw new AnalysisException("Invalid element type in Map");
-}
+for (int idx = 0; idx < exprs.length && idx + 1 < exprs.length; idx +=
2) {
+// limit key type to scalar type
+keyType = Type.getAssignmentCompatibleType(keyType,
exprs[idx].getType(), true);
+if (keyType == Type.INVALID || !keyType.isScalarType()) {
+throw new AnalysisException("Invalid key type in Map Only
support scalar type");
Review Comment:
1, 3, 4 I got it !
but 2 u means, expr type may be valid scalar type for key but also throw
error ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool
morningman commented on PR #16891: URL: https://github.com/apache/doris/pull/16891#issuecomment-1437150551 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool
morningman commented on code in PR #16891:
URL: https://github.com/apache/doris/pull/16891#discussion_r1112056687
##
be/src/vec/exec/scan/new_olap_scanner.cpp:
##
@@ -385,6 +385,23 @@ Status NewOlapScanner::_init_return_columns() {
return Status::OK();
}
+doris::TabletStorageType NewOlapScanner::get_storage_type() {
+int local_reader = 0;
+for (const auto& reader : _tablet_reader_params.rs_readers) {
+if (reader->rowset()->rowset_meta()->resource_id().empty()) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
github-actions[bot] commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437151221 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16928: [fix](tvf) fix bug that failed to get schema of tvf when file is empty
github-actions[bot] commented on PR #16928: URL: https://github.com/apache/doris/pull/16928#issuecomment-1437154080 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #16771: [enhancement](exception safe) make function state exception safe
morningman merged PR #16771: URL: https://github.com/apache/doris/pull/16771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [enhancement](exception safe) make function state exception safe (#16771)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new e04c13b7a6 [enhancement](exception safe) make function state exception
safe (#16771)
e04c13b7a6 is described below
commit e04c13b7a636687d871d528c3935254a0933ab49
Author: yiguolei <676222...@qq.com>
AuthorDate: Mon Feb 20 23:01:45 2023 +0800
[enhancement](exception safe) make function state exception safe (#16771)
---
be/src/exprs/json_functions.cpp| 34 ---
be/src/exprs/json_functions.h | 3 --
be/src/exprs/string_functions.cpp | 15 +-
be/src/exprs/string_functions.h| 4 +--
be/src/olap/in_list_predicate.h| 15 +-
be/src/olap/like_column_predicate.cpp | 10 +++
be/src/olap/like_column_predicate.h| 1 -
be/src/udf/udf.cpp | 10 +++
be/src/udf/udf.h | 3 +-
be/src/udf/udf_internal.h | 4 +--
be/src/vec/functions/function_convert_tz.h | 8 +-
be/src/vec/functions/function_java_udf.cpp | 10 +++
be/src/vec/functions/function_java_udf.h | 14 --
be/src/vec/functions/function_regexp.cpp | 44 ++
be/src/vec/functions/function_string.h | 23 ++--
be/src/vec/functions/functions_geo.cpp | 23 ++--
be/src/vec/functions/in.h | 6 +---
be/src/vec/functions/like.cpp | 9 ++
be/src/vec/functions/random.cpp| 14 +-
19 files changed, 83 insertions(+), 167 deletions(-)
diff --git a/be/src/exprs/json_functions.cpp b/be/src/exprs/json_functions.cpp
index 8600fd9041..3016463482 100644
--- a/be/src/exprs/json_functions.cpp
+++ b/be/src/exprs/json_functions.cpp
@@ -43,40 +43,6 @@ namespace doris {
// json path cannot contains: ", [, ]
static const re2::RE2 JSON_PATTERN("^([^\\\"\\[\\]]*)(?:\\[([0-9]+|\\*)\\])?");
-rapidjson::Value JsonFunctions::parse_str_with_flag(const StringVal& arg,
const StringVal& flag,
-const int num,
-
rapidjson::Document::AllocatorType& allocator) {
-rapidjson::Value val;
-if (arg.is_null || *(flag.ptr + num) == '0') { //null
-rapidjson::Value nullObject(rapidjson::kNullType);
-val = nullObject;
-} else if (*(flag.ptr + num) == '1') { //bool
-bool res = ((arg == "1") ? true : false);
-val.SetBool(res);
-} else if (*(flag.ptr + num) == '2') { //int
-std::stringstream ss;
-ss << arg.ptr;
-int number = 0;
-ss >> number;
-val.SetInt(number);
-} else if (*(flag.ptr + num) == '3') { //double
-std::stringstream ss;
-ss << arg.ptr;
-double number = 0.0;
-ss >> number;
-val.SetDouble(number);
-} else if (*(flag.ptr + num) == '4' || *(flag.ptr + num) == '5') {
-StringPiece str((char*)arg.ptr, arg.len);
-if (*(flag.ptr + num) == '4') {
-str = str.substr(1, str.length() - 2);
-}
-val.SetString(str.data(), str.length(), allocator);
-} else {
-DCHECK(false) << "parse json type error with unknown type";
-}
-return val;
-}
-
rapidjson::Value* JsonFunctions::match_value(const std::vector&
parsed_paths,
rapidjson::Value* document,
rapidjson::Document::AllocatorType& mem_allocator,
diff --git a/be/src/exprs/json_functions.h b/be/src/exprs/json_functions.h
index 5740427867..39fbda875b 100644
--- a/be/src/exprs/json_functions.h
+++ b/be/src/exprs/json_functions.h
@@ -121,8 +121,5 @@ private:
bool is_insert_null = false);
static void get_parsed_paths(const std::vector& path_exprs,
std::vector* parsed_paths);
-static rapidjson::Value parse_str_with_flag(const StringVal& arg, const
StringVal& flag,
-const int num,
-
rapidjson::Document::AllocatorType& allocator);
};
} // namespace doris
diff --git a/be/src/exprs/string_functions.cpp
b/be/src/exprs/string_functions.cpp
index 4ef1039c73..a9b4b737e8 100644
--- a/be/src/exprs/string_functions.cpp
+++ b/be/src/exprs/string_functions.cpp
@@ -62,8 +62,9 @@ bool StringFunctions::set_re2_options(const StringVal&
match_parameter, std::str
}
// The caller owns the returned regex. Returns nullptr if the pattern could
not be compiled.
-re2::RE2* StringFunctions::compile_regex(const StringVal& pattern,
std::string* error_str,
- const StringVal& match_parameter) {
+bool StringFunctions::com
[GitHub] [doris] github-actions[bot] commented on pull request #16891: [improvement](scan) separate scanner into local and remote scanner pool
github-actions[bot] commented on PR #16891: URL: https://github.com/apache/doris/pull/16891#issuecomment-1437157720 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437169917 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170358 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #16123: [feature-wip](BE http)Support BE http service with brpc
TangSiyang2001 commented on PR #16123: URL: https://github.com/apache/doris/pull/16123#issuecomment-1437170109 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower opened a new pull request, #16958: [BugFix](Jdbc Catalog) Fix null pointer exception in JdbcExecutor
BePPPower opened a new pull request, #16958: URL: https://github.com/apache/doris/pull/16958 # Proposed changes Issue Number: close #xxx This pr do two things: 1. fix: It use `column[0]` to judge class type in JdbcExecutor, but column[0] may be null ! 3. enhencement: In the original logic, all fields in jdbc catalog table will be set Nullable. Howerver, it is inefficient for nullable fields. Actually, we can know if the fields in data source table is nullable throught jdbc. So we can set the corresponding fields in doris jdbc catalog to nullable or not. ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
hello-stephen commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437174813 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.56 seconds stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 27 seconds loaded 861443392 Bytes, about 30 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220151406_clickbench_pr_100420.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 opened a new issue, #16959: [Enhancement](regression-test) complete the regression-test of BE brpc-http api
TangSiyang2001 opened a new issue, #16959: URL: https://github.com/apache/doris/issues/16959 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description When implementing BE http server with brpc, there are some APIs hard to be included in the regression-test for several reasons. 1. /api/_download_load - token must be specified - file path must be legal and effective 2. /api/reload_tablet - tablets should be constructed in somewhere else 3. /api/restore_tablet - tablet should be removed during the regression test first 4. /api/*/_stream_load_2pc - current regression test cases do not include stream_load_2pc 5. /api/tablet_migration - should specify the disk name in testing pipeline env ### Solution related work #16123 ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16944: [improvement](test)Set compile required and add clickbench,arm to buildall
ZhangGuoqiang666 commented on PR #16944: URL: https://github.com/apache/doris/pull/16944#issuecomment-1437196914 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg commented on pull request #16850: [improvement](vec) avoid creating a new column while filtering mutable columns
mrhhsg commented on PR #16850: URL: https://github.com/apache/doris/pull/16850#issuecomment-1437211532 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16953: [Function](vec) use const column to opt function current_time()
hello-stephen commented on PR #16953: URL: https://github.com/apache/doris/pull/16953#issuecomment-1437214414 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35 seconds stream load tsv: 468 seconds loaded 74807831229 Bytes, about 152 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220154003_clickbench_pr_100436.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1112107754
##
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##
@@ -31,122 +33,180 @@
namespace doris::vectorized {
-template
+template
struct AggregateFunctionCollectSetData {
using ElementType = T;
using ColVecType = ColumnVectorOrDecimal;
using ElementNativeType = typename NativeType::Type;
+using SelfType = AggregateFunctionCollectSetData;
using Set = HashSetWithStackMemory, 4>;
-Set set;
+Set data_set;
+UInt64 max_size;
+
+size_t size() const { return data_set.size(); }
void add(const IColumn& column, size_t row_num) {
-const auto& vec = assert_cast(column).get_data();
-set.insert(vec[row_num]);
+data_set.insert(assert_cast(column).get_data()[row_num]);
+}
+
+void merge(const SelfType& rhs) {
+if constexpr (HasLimit::value) {
+for (auto& rhs_elem : rhs.data_set) {
+if (size() >= max_size) {
+return;
+}
+data_set.insert(rhs_elem.get_value());
+}
+} else {
+data_set.merge(rhs.data_set);
+}
}
-void merge(const AggregateFunctionCollectSetData& rhs) {
set.merge(rhs.set); }
-void write(BufferWritable& buf) const { set.write(buf); }
-void read(BufferReadable& buf) { set.read(buf); }
-void reset() { set.clear(); }
+
+void write(BufferWritable& buf) const { data_set.write(buf); }
+
+void read(BufferReadable& buf) { data_set.read(buf); }
+
void insert_result_into(IColumn& to) const {
auto& vec = assert_cast(to).get_data();
-vec.reserve(set.size());
-for (auto item : set) {
+vec.reserve(size());
+for (auto item : data_set) {
Review Comment:
Recieved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1112109843
##
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##
@@ -202,27 +266,36 @@ class AggregateFunctionCollect final
}
DataTypePtr get_return_type() const override {
-return std::make_shared(make_nullable(_argument_type));
+return std::make_shared(make_nullable(return_type));
}
+bool allocates_memory_in_arena() const override { return ENABLE_ARENA; }
+
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena* arena) const override {
-assert(!columns[0]->is_null_at(row_num));
-if constexpr (alloc_memory_in_arena) {
-this->data(place).add(*columns[0], row_num, arena);
+auto& data = this->data(place);
+if constexpr (HasLimit::value) {
+data.max_size =
+(UInt64) static_cast(columns[1])->get_element(row_num);
Review Comment:
May you specify it please? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener commented on pull request #16910: [feature](Nereids): Eliminate duplicate join condition.
jackwener commented on PR #16910: URL: https://github.com/apache/doris/pull/16910#issuecomment-1437219935 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1112110316
##
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##
@@ -31,122 +33,180 @@
namespace doris::vectorized {
-template
+template
struct AggregateFunctionCollectSetData {
using ElementType = T;
using ColVecType = ColumnVectorOrDecimal;
using ElementNativeType = typename NativeType::Type;
+using SelfType = AggregateFunctionCollectSetData;
using Set = HashSetWithStackMemory, 4>;
-Set set;
+Set data_set;
+UInt64 max_size;
+
+size_t size() const { return data_set.size(); }
void add(const IColumn& column, size_t row_num) {
-const auto& vec = assert_cast(column).get_data();
-set.insert(vec[row_num]);
+data_set.insert(assert_cast(column).get_data()[row_num]);
+}
+
+void merge(const SelfType& rhs) {
+if constexpr (HasLimit::value) {
+for (auto& rhs_elem : rhs.data_set) {
+if (size() >= max_size) {
+return;
+}
+data_set.insert(rhs_elem.get_value());
+}
+} else {
+data_set.merge(rhs.data_set);
+}
}
-void merge(const AggregateFunctionCollectSetData& rhs) {
set.merge(rhs.set); }
-void write(BufferWritable& buf) const { set.write(buf); }
-void read(BufferReadable& buf) { set.read(buf); }
-void reset() { set.clear(); }
+
+void write(BufferWritable& buf) const { data_set.write(buf); }
+
+void read(BufferReadable& buf) { data_set.read(buf); }
+
void insert_result_into(IColumn& to) const {
auto& vec = assert_cast(to).get_data();
-vec.reserve(set.size());
-for (auto item : set) {
+vec.reserve(size());
+for (auto item : data_set) {
vec.push_back(item.key);
}
}
+
+void reset() { data_set.clear(); }
};
-template <>
-struct AggregateFunctionCollectSetData {
+template
+struct AggregateFunctionCollectSetData {
using ElementType = StringRef;
using ColVecType = ColumnString;
+using SelfType = AggregateFunctionCollectSetData;
using Set = HashSetWithSavedHashWithStackMemory, 4>;
-Set set;
+Set data_set;
+UInt64 max_size;
Review Comment:
Ok, I will enhance it in that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1112116359
##
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##
@@ -202,27 +266,36 @@ class AggregateFunctionCollect final
}
DataTypePtr get_return_type() const override {
-return std::make_shared(make_nullable(_argument_type));
+return std::make_shared(make_nullable(return_type));
}
+bool allocates_memory_in_arena() const override { return ENABLE_ARENA; }
+
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena* arena) const override {
-assert(!columns[0]->is_null_at(row_num));
-if constexpr (alloc_memory_in_arena) {
-this->data(place).add(*columns[0], row_num, arena);
+auto& data = this->data(place);
+if constexpr (HasLimit::value) {
+data.max_size =
+(UInt64) static_cast(columns[1])->get_element(row_num);
Review Comment:
> Could you please specify it further? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on a diff in pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on code in PR #15339:
URL: https://github.com/apache/doris/pull/15339#discussion_r1112109843
##
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##
@@ -202,27 +266,36 @@ class AggregateFunctionCollect final
}
DataTypePtr get_return_type() const override {
-return std::make_shared(make_nullable(_argument_type));
+return std::make_shared(make_nullable(return_type));
}
+bool allocates_memory_in_arena() const override { return ENABLE_ARENA; }
+
void add(AggregateDataPtr __restrict place, const IColumn** columns,
size_t row_num,
Arena* arena) const override {
-assert(!columns[0]->is_null_at(row_num));
-if constexpr (alloc_memory_in_arena) {
-this->data(place).add(*columns[0], row_num, arena);
+auto& data = this->data(place);
+if constexpr (HasLimit::value) {
+data.max_size =
+(UInt64) static_cast(columns[1])->get_element(row_num);
Review Comment:
Could you please specify it further? Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] zclllyybb commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow
zclllyybb commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437229100 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437230112 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437231788 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris-website] wangyf0555 closed pull request #194: website optimization
wangyf0555 closed pull request #194: website optimization URL: https://github.com/apache/doris-website/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437237916 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437239157 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16957: [fix](auth) fix losing global priv bug and refactor default role name
hello-stephen commented on PR #16957: URL: https://github.com/apache/doris/pull/16957#issuecomment-1437238704 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.91 seconds stream load tsv: 472 seconds loaded 74807831229 Bytes, about 151 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 67 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230220155946_clickbench_pr_100446.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #16384: [regression-test](fuzzy) fuzzy session variable batch_size
jacktengg commented on PR #16384: URL: https://github.com/apache/doris/pull/16384#issuecomment-1437238820 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different
jacktengg commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437240354 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16935: [Fix](function)fix datatime-diff function's overflow
github-actions[bot] commented on PR #16935: URL: https://github.com/apache/doris/pull/16935#issuecomment-1437240412 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #16938: [fix](union iterator) fix bug that result data order of VUnionIterator is different
jacktengg commented on PR #16938: URL: https://github.com/apache/doris/pull/16938#issuecomment-1437240573 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437242528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …
freemandealer commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437244329 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16950: [fix](log) fix and clarify error msg for tablet writer write failure …
github-actions[bot] commented on PR #16950: URL: https://github.com/apache/doris/pull/16950#issuecomment-1437246918 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437247396 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437266720 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] TangSiyang2001 commented on pull request #15339: [enhancement](aggregate-function) enhance aggregate funtion collect and add group_array aliases
TangSiyang2001 commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1437266948 run p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437328855 run feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437330260 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16956: [fix](cooldown) Forbid re-add replica with cooldowned rowsets
platoneko commented on PR #16956: URL: https://github.com/apache/doris/pull/16956#issuecomment-1437332691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded
platoneko commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437332001 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yukang-Lian commented on pull request #16340: [feature](mysql) Support secure MySQL connection to FE
Yukang-Lian commented on PR #16340: URL: https://github.com/apache/doris/pull/16340#issuecomment-1437352057 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16803: [fix](cooldown) Use `pending_remote_rowsets` to avoid deleting rowset files being uploaded
platoneko commented on PR #16803: URL: https://github.com/apache/doris/pull/16803#issuecomment-1437391303 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392582 build p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] platoneko commented on pull request #16889: [fix](replica) Fix inconsistent replica id between BE and FE in corner case of tablet rebalance
platoneko commented on PR #16889: URL: https://github.com/apache/doris/pull/16889#issuecomment-1437392701 build feut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] WinkerDu commented on issue #16561: [Enhancement] Support function `microseconds_add` and `microseconds_sub`
WinkerDu commented on issue #16561: URL: https://github.com/apache/doris/issues/16561#issuecomment-1437421552 @Gabriel39 I have finished datatimev2 `microseconds_add` support, will push a commit soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
