[GitHub] [doris] github-actions[bot] commented on pull request #16655: [fix](mark join) fix bug of mark join with other conjuncts
github-actions[bot] commented on PR #16655: URL: https://github.com/apache/doris/pull/16655#issuecomment-1427501236 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] nextdreamblue commented on issue #16534: [Bug] "count" sql has an error result
nextdreamblue commented on issue #16534: URL: https://github.com/apache/doris/issues/16534#issuecomment-1427502287 pr:#16556，just fix some bug about count()，if select like this: ``` select max(user_id) from( select max(user_id), 100 as user_id FROM A )t; ``` will get wrong resout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower opened a new pull request, #16661: [Enhencement](CsvReader) Optimize CsvReader
BePPPower opened a new pull request, #16661: URL: https://github.com/apache/doris/pull/16661 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [x] Does it affect the original behavior * [] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mmx1960 opened a new issue, #16662: [Bug] some function result is not correct
mmx1960 opened a new issue, #16662:
URL: https://github.com/apache/doris/issues/16662
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
1.1.3 & 1.2.1
### What's Wrong?
**case 1:**
` with vb1 as(
select '7.1' as col
union all
select '8.123456' as col
)
select 'decimal-原始未截断' as type,cast(col as decimal(25,6)) col from vb1
union all
select 'decimal-截断保留3位小数' as type,truncate (cast(col as
decimal(25,6)),3) col from vb1
union all
select 'decimal-截断保留5位小数' as type,truncate (cast(col as
decimal(25,6)),5) col from vb1
union all
select 'decimal-截断保留7位小数' as type,truncate (cast(col as
decimal(25,6)),7) col from vb1`
the 1.1.3 and 1.2.1 result is :
**case2:**
`with vb1 as(
select '7.1' as col
union all
select '8.123456' as col
)
select 'double-原始未截断' as type,cast(col as double) col from vb1
union all
select 'double-截断保留3位小数' as type,truncate (cast(col as double),3) col
from vb1
union all
select 'double-截断保留5位小数' as type,truncate (cast(col as double),5) col
from vb1
union all
-- **结果不符合预期：8.1234559*
select 'double-截断保留7位小数' as type,truncate (cast(col as double),7) col
from vb1`
the 1.1.3 result is:
the 1.2.1 result is:
**case3:**
`with vb1 as(
select cast('8.12' as decimal(20, 2)) as
decimal_20_2,cast('9.123456' as decimal(20, 6)) as decimal_20_6
union all
select cast('8.45' as decimal(20, 2)) as
decimal_20_2,cast('9.654321' as decimal(20, 6)) as decimal_20_6
)
select '原始数据-未做类型和精度转换' as type
, decimal_20_2
,decimal_20_6
from vb1
union all
select 'decimal-扩大类型' as type
,cast(decimal_20_2 as decimal(25,6)) decimal_20_2
,cast(decimal_20_6 as decimal(25,6)) decimal_20_6
from vb1
union all
select 'decimal-round四舍五入保留两位小数' as type
-- *** 扩大精度后四舍五入结果错误8.12结果为8.11999
,round(cast(decimal_20_2 as decimal(25,6)),2) decimal_20_2
,round(cast(decimal_20_6 as decimal(25,6)),2) decimal_20_6
from vb1`
the 1.1.3 and 1.2.1 result is:
### What You Expected?
return the correct result
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16661: [Enhencement](CsvReader) Optimize CsvReader
github-actions[bot] commented on PR #16661: URL: https://github.com/apache/doris/pull/16661#issuecomment-1427513244 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] liujunfei2230 opened a new issue, #16663: [Bug] Execution optimizer doesn't display correctly when useing "explain select ..."
liujunfei2230 opened a new issue, #16663: URL: https://github.com/apache/doris/issues/16663 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.1 ### What's Wrong? https://user-images.githubusercontent.com/53937394/218403474-1f67e926-9289-4262-9031-c02732e3e2a4.png";> ### What You Expected? the value of cardinality should be 4360137/3 other than 4360137. ### How to Reproduce? with doris version 1.2.1, using explain sq the sql creating table only used buckets. the following is the demo: CREATE TABLE `bill_log` ( `org_id` bigint(20) NULL, `created_time` datetime NULL, `team_id` bigint(20) NULL, `agent_org_id` bigint(20) NULL, `id` bigint(20) NULL, ... ... `last_updated_time` datetime NULL, `__DELETE_SIGN__` varchar(10) NULL DEFAULT "false" ) ENGINE=OLAP UNIQUE KEY(`org_id`, `created_time`, `team_id`, `agent_org_id`, `id`) COMMENT 'OLAP' DISTRIBUTED BY HASH(`org_id`) BUCKETS 8 PROPERTIES ( "replication_allocation" = "tag.location.default: 3", "bloom_filter_columns" = "parent_id, target_id", "in_memory" = "false", "storage_format" = "V2", "disable_auto_compaction" = "false" ); ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] BePPPower opened a new pull request, #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
BePPPower opened a new pull request, #16664: URL: https://github.com/apache/doris/pull/16664 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [x] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
github-actions[bot] commented on PR #16664: URL: https://github.com/apache/doris/pull/16664#issuecomment-1427520029 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] stalary closed issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
stalary closed issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema' URL: https://github.com/apache/doris/issues/16426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JackDrogon opened a new issue, #16665: [Enhancement] clean be include header
JackDrogon opened a new issue, #16665: URL: https://github.com/apache/doris/issues/16665 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Description Doris be often compiles very long . Through the analysis found that many times is included irrelevant header triggered. ### Solution Use iwyu to remove unused headers. ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming commented on issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
luguangming commented on issue #16426: URL: https://github.com/apache/doris/issues/16426#issuecomment-1427531365 Mysql client or fe http request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming commented on issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
luguangming commented on issue #16426: URL: https://github.com/apache/doris/issues/16426#issuecomment-1427532491 > What tool did you use to connect doris? Mysql client and fe http request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16661: [Enhencement](CsvReader) Optimize CsvReader
github-actions[bot] commented on PR #16661: URL: https://github.com/apache/doris/pull/16661#issuecomment-1427532549 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming commented on issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
luguangming commented on issue #16426: URL: https://github.com/apache/doris/issues/16426#issuecomment-1427533220 Why we disable statistic tables at version 1.2.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JackDrogon commented on issue #16665: [Enhancement] clean be include header
JackDrogon commented on issue #16665:
URL: https://github.com/apache/doris/issues/16665#issuecomment-1427535309
现在工作目录创建iwyu目录，然后使用find导出所有文件列表到iwyu/files_list，然后就可以使用iwyu-patch 从1到n
挨个一个个文件进行清理，关于这些需要挨个文件commit。因为iwyu会过度清理，需要有些添加iwyu guard.
下面是iwyu-patch的示例脚本
```bash
#!/bin/bash
num=$1
filename=$(sed "${num}q;d" ./iwyu/files_list)
shortname=$(echo $filename | awk -F/ '{print $NF}')
iwyu_outfile="./iwyu/${shortname}.iwyuout"
build_dir=build_Release
echo $filename $shortname $iwyu_outfile
iwyu_tool.py -p $build_dir $filename > $iwyu_outfile
fix_includes.py --comments --update_comments -b < $iwyu_outfile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 opened a new pull request, #16666: [fix](planner) Fix view
Kikyou1997 opened a new pull request, #1: URL: https://github.com/apache/doris/pull/1 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427551025 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on issue #16446: [VOTING] Release Note 1.2.2
morningman commented on issue #16446: URL: https://github.com/apache/doris/issues/16446#issuecomment-1427556510 > `https://doris.apache.org/en/docs/dev/lakehouse/multi-catalog/jdbc` is not found. fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] LizZhang315 opened a new issue, #16667: [Bug] [daily] create materialized contains columns that are not keys
LizZhang315 opened a new issue, #16667: URL: https://github.com/apache/doris/issues/16667 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version doris-0.0.0-trunk-1de4e31 ### What's Wrong? Jenkins failed case:https://ci-builds.apache.org/job/Doris/job/doris_daily_enable_vectorized/lastBuild/testReport/junit/(root)/test_sys_materialized_view_2/test_create_agg_mv_failed/ https://user-images.githubusercontent.com/24400239/218412869-3500c7df-e6fe-4225-859c-28f24d82ac51.png";> ### What You Expected? execution fails. ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
XieJiann commented on code in PR #16436:
URL: https://github.com/apache/doris/pull/16436#discussion_r1104164265
##
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##
@@ -99,6 +99,8 @@
*/
public class StatsCalculator extends DefaultPlanVisitor {
+public static final StatsCalculator STATS_CALCULATOR = new
StatsCalculator(null);
Review Comment:
Calculate cost for plan without groupexpression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16661: [Enhencement](CsvReader) Optimize CsvReader
github-actions[bot] commented on PR #16661: URL: https://github.com/apache/doris/pull/16661#issuecomment-1427581540 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
XieJiann commented on code in PR #16436:
URL: https://github.com/apache/doris/pull/16436#discussion_r1104164265
##
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##
@@ -99,6 +99,8 @@
*/
public class StatsCalculator extends DefaultPlanVisitor {
+public static final StatsCalculator STATS_CALCULATOR = new
StatsCalculator(null);
Review Comment:
Calculate cost for plan without groupexpression originally. However, I use
JoinEstimiate to replace it.
Has deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
XieJiann commented on code in PR #16436:
URL: https://github.com/apache/doris/pull/16436#discussion_r1104164265
##
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##
@@ -99,6 +99,8 @@
*/
public class StatsCalculator extends DefaultPlanVisitor {
+public static final StatsCalculator STATS_CALCULATOR = new
StatsCalculator(null);
Review Comment:
Calculate cost for plan without groupexpression originally. However, I use
JoinEstimiate to replace it latter.
Has deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] XieJiann commented on a diff in pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
XieJiann commented on code in PR #16436:
URL: https://github.com/apache/doris/pull/16436#discussion_r1104164265
##
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/StatsCalculator.java:
##
@@ -99,6 +99,8 @@
*/
public class StatsCalculator extends DefaultPlanVisitor {
+public static final StatsCalculator STATS_CALCULATOR = new
StatsCalculator(null);
Review Comment:
Calculate cost for plan without groupexpression originally. However, I use
`JoinEstimation` to replace it latter.
Has deleted it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427600712 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] HappenLee opened a new pull request, #16668: [Refactor](exchange) Remove unless variable and change block mem count way
HappenLee opened a new pull request, #16668: URL: https://github.com/apache/doris/pull/16668 # Proposed changes 1. remove unless variable :_num_buffered_bytes 2. reduce block allocte byte function calll ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16668: [Refactor](exchange) Remove unless variable and change block mem count way
github-actions[bot] commented on PR #16668: URL: https://github.com/apache/doris/pull/16668#issuecomment-1427608516 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427610505 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16668: [Refactor](exchange) Remove unless variable and change block mem count way
github-actions[bot] commented on PR #16668: URL: https://github.com/apache/doris/pull/16668#issuecomment-1427614306 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427619890 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427623227 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] eldenmoon opened a new pull request, #16669: [doc](dynamic-table) Add docs for dynamic-table
eldenmoon opened a new pull request, #16669: URL: https://github.com/apache/doris/pull/16669 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427626407 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JackDrogon opened a new pull request, #16670: [Fix](cpp17) fix gutil unary_function/binary_function for cpp17
JackDrogon opened a new pull request, #16670: URL: https://github.com/apache/doris/pull/16670 # Proposed changes be gutil contains unary_function/binary_function, but they are removed in C++17. Fix these for gcc12 to compile be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16670: [Fix](cpp17) fix gutil unary_function/binary_function for cpp17
github-actions[bot] commented on PR #16670: URL: https://github.com/apache/doris/pull/16670#issuecomment-1427635672 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16661: [Enhencement](CsvReader) Optimize CsvReader
hello-stephen commented on PR #16661: URL: https://github.com/apache/doris/pull/16661#issuecomment-1427640432 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.73 seconds stream load tsv: 534 seconds loaded 74807831229 Bytes, about 133 MB/s stream load json: 38 seconds loaded 2358488459 Bytes, about 59 MB/s stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230213095114_clickbench_pr_95185.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming commented on issue #16426: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
luguangming commented on issue #16426: URL: https://github.com/apache/doris/issues/16426#issuecomment-1427643084 [stalary](https://github.com/stalary) Why is this list closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming opened a new issue, #16672: [Bug] execute count from table, Unknown database 'default_cluster:__internal_schema'
luguangming opened a new issue, #16672: URL: https://github.com/apache/doris/issues/16672 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no similar issues. ### Version 1.2.0 ### What's Wrong? select count(*) from table, we can see fe.log : 2023-02-06 10:23:38,370 WARN (ForkJoinPool.commonPool-worker-5|57515) [StmtExecutor.executeInternalQuery():1799] Internal SQL execution failed, SQL: org.apache.doris.qe.OriginStatement@6eca8c46 org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = Unknown database 'default_cluster:__internal_schema' at org.apache.doris.datasource.CatalogIf.lambda$getDbOrAnalysisException$4(CatalogIf.java:107) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.datasource.CatalogIf.getDbOrException(CatalogIf.java:72) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.datasource.CatalogIf.getDbOrAnalysisException(CatalogIf.java:106) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.analysis.SelectStmt.getTables(SelectStmt.java:322) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.analyze(StmtExecutor.java:702) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.executeInternalQuery(StmtExecutor.java:1797) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.statistics.util.StatisticsUtil.execStatisticQuery(StatisticsUtil.java:84) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.statistics.StatisticsCacheLoader.lambda$asyncLoad$0(StatisticsCacheLoader.java:69) ~[doris-fe.jar:1.0-SNAPSHOT] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604) ~[?:1.8.0_332] at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1596) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175) ~[?:1.8.0_332] 2023-02-06 10:23:38,370 WARN (ForkJoinPool.commonPool-worker-5|57515) [StatisticsCacheLoader.lambda$asyncLoad$0():75] Failed to deserialize column statistics java.lang.NullPointerException: null at org.apache.doris.statistics.util.StatisticsUtil.deserializeToColumnStatistics(StatisticsUtil.java:105) ~[doris-fe.jar:1.0-SNAPSHOT] at org.apache.doris.statistics.StatisticsCacheLoader.lambda$asyncLoad$0(StatisticsCacheLoader.java:73) ~[doris-fe.jar:1.0-SNAPSHOT] at java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1604) ~[?:1.8.0_332] at java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1596) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) ~[?:1.8.0_332] at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175) ~[?:1.8.0_332] ### What You Expected? Hi [stalary](https://github.com/stalary) Why is this list closed and what is the solution? https://github.com/apache/doris/issues/16426 ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16670: [Fix](cpp17) fix gutil unary_function/binary_function for cpp17
github-actions[bot] commented on PR #16670: URL: https://github.com/apache/doris/pull/16670#issuecomment-1427657795 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16670: [Fix](cpp17) fix gutil unary_function/binary_function for cpp17
github-actions[bot] commented on PR #16670: URL: https://github.com/apache/doris/pull/16670#issuecomment-1427657870 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Tanya-W opened a new pull request, #16673: [fix](regression) fix add drop inverted index case
Tanya-W opened a new pull request, #16673: URL: https://github.com/apache/doris/pull/16673 # Proposed changes Issue Number: close #xxx ## Problem summary 1. fix test_add_drop_index.groovy 2. fix assert failed when process alter inverted index call `OlapBlockDataConvertor::set_source_content` ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has unit tests been added * [ ] Has document been added or modified * [ ] Does it need to update dependencies * [ ] Is this PR support rollback (If NO, please explain WHY) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16673: [fix](regression) fix add drop inverted index case
github-actions[bot] commented on PR #16673: URL: https://github.com/apache/doris/pull/16673#issuecomment-1427675774 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14397: [feature](nereids)support window function
morrySnow commented on code in PR #14397:
URL: https://github.com/apache/doris/pull/14397#discussion_r1104245323
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/WindowExpression.java:
##
@@ -0,0 +1,211 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions;
+
+import org.apache.doris.nereids.exceptions.UnboundException;
+import org.apache.doris.nereids.trees.expressions.functions.PropagateNullable;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.DataType;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Lists;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * represents window function. WindowFunction of this window is saved as
Window's child,
+ * which is an UnboundFunction at first and will be analyzed as relevant
BoundFunction
+ * (can be a WindowFunction or AggregateFunction) after BindFunction.
+ */
+public class WindowExpression extends Expression implements PropagateNullable {
Review Comment:
```suggestion
public class WindowExpression extends Expression {
@Override
public boolean nullable() {
return function.nullable();
}
```
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Ntile.java:
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.functions.window;
+
+import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.functions.AlwaysNotNullable;
+import
org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.shape.LeafExpression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.BigIntType;
+import org.apache.doris.nereids.types.DataType;
+import org.apache.doris.nereids.types.IntegerType;
+import org.apache.doris.nereids.types.LargeIntType;
+import org.apache.doris.nereids.types.SmallIntType;
+import org.apache.doris.nereids.types.TinyIntType;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
+/**
+ * window function: Ntile()
+ */
+public class Ntile extends WindowFunction implements LeafExpression,
AlwaysNotNullable, ExplicitlyCastableSignature {
+
+public static final List SIGNATURES = ImmutableList.of(
+
FunctionSignature.ret(BigIntType.INSTANCE).args(TinyIntType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(SmallIntType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(IntegerType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(BigIntType.INSTANCE),
+
FunctionSignature.ret(LargeIntType.INSTANCE).args(LargeIntType.INSTANCE)
+);
+
+private Expression buckets;
+
+public Ntile(Expression buckets) {
+super("ntile", buckets);
+this.buckets = buckets;
+}
+
+public Expression getBuckets() {
+return buckets;
+}
+
+@Override
+public Nt
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16383: [Improvement](thrift) optimize thrift message
github-actions[bot] commented on code in PR #16383:
URL: https://github.com/apache/doris/pull/16383#discussion_r1104251108
##
be/src/vec/sink/vdata_stream_sender.h:
##
@@ -392,14 +392,32 @@ Status VDataStreamSender::channel_add_rows(Channels&
channels, int num_channels,
return Status::OK();
}
-class PipChannel : public Channel {
+class PipChannel final : public Channel {
public:
PipChannel(VDataStreamSender* parent, const RowDescriptor& row_desc,
const TNetworkAddress& brpc_dest, const TUniqueId&
fragment_instance_id,
PlanNodeId dest_node_id, int buffer_size, bool
is_transfer_chain,
bool send_query_statistics_with_every_batch)
: Channel(parent, row_desc, brpc_dest, fragment_instance_id,
dest_node_id, buffer_size,
- is_transfer_chain,
send_query_statistics_with_every_batch) {}
+ is_transfer_chain,
send_query_statistics_with_every_batch) {
+ch_roll_pb_block();
+}
+
+~PipChannel() {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~PipChannel() override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16673: [fix](regression) fix add drop inverted index case
github-actions[bot] commented on PR #16673: URL: https://github.com/apache/doris/pull/16673#issuecomment-1427680157 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14397: [feature](nereids)support window function
morrySnow commented on code in PR #14397:
URL: https://github.com/apache/doris/pull/14397#discussion_r1104253370
##
regression-test/suites/nereids_syntax_p0/window_function.groovy:
##
@@ -0,0 +1,121 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_window_function") {
+sql "SET enable_nereids_planner=true"
+
+sql "DROP TABLE IF EXISTS window_test"
+
+sql """
+CREATE TABLE `window_test` (
+`c1` int NULL,
+`c2` int NULL,
+`c3` double NULL
+) ENGINE=OLAP
+DISTRIBUTED BY HASH(`c1`) BUCKETS 1
+PROPERTIES (
+"replication_allocation" = "tag.location.default: 1"
+);
+"""
+sql """INSERT INTO window_test VALUES(1, 1, 1)"""
+sql """INSERT INTO window_test VALUES(1, 2, 1)"""
+sql """INSERT INTO window_test VALUES(1, 3, 1)"""
+sql """INSERT INTO window_test VALUES(2, 1, 1)"""
+sql """INSERT INTO window_test VALUES(2, 2, 1)"""
+sql """INSERT INTO window_test VALUES(2, 3, 1)"""
+sql """INSERT INTO window_test VALUES(1, 1, 2)"""
+sql """INSERT INTO window_test VALUES(1, 2, 2)"""
+sql """INSERT INTO window_test VALUES(2, 1, 2)"""
+sql """INSERT INTO window_test VALUES(2, 2, 2)"""
+sql """INSERT INTO window_test VALUES(1, 2, null)"""
+sql """INSERT INTO window_test VALUES(1, 3, null)"""
+sql """INSERT INTO window_test VALUES(1, null, 3)"""
+sql """INSERT INTO window_test VALUES(2, null, 3)"""
+
+sql "SET enable_fallback_to_original_planner=false"
+
+order_qt_empty_over "SELECT rank() over() FROM window_test"
+order_qt_with_star "SELECT *, rank() over(partition by c3 order by c2)
FROM window_test"
+order_qt_multi_window_1 "SELECT rank() over(), row_number() over() FROM
window_test"
+order_qt_multi_window_2 """
+SELECT sum(c1) over(), count(c2) over(), rank() over(partition by c3
order by c2)
+FROM window_test
+"""
+
+// todo: fix unknown bug of dense_rank(), ntile() in Nereids
+// order_qt_select "SELECT dense_rank() over(partition by c3 order by c2)
FROM window_test"
+order_qt_rank "SELECT rank() over(partition by c3 order by c2) FROM
window_test"
+order_qt_row_number "SELECT row_number() over(partition by c3 order by c2)
FROM window_test"
+order_qt_sum "SELECT sum(c1) over(partition by c3 order by c2) FROM
window_test"
+order_qt_avg "SELECT avg(c1) over(partition by c3 order by c2) FROM
window_test"
+order_qt_count "SELECT count(c1) over(partition by c3 order by c2) FROM
window_test"
+order_qt_first_value "SELECT first_value(c1) over(partition by c3 order by
c2) FROM window_test"
+order_qt_last_value "SELECT last_value(c1) over(partition by c3 order by
c2) FROM window_test"
+order_qt_lead "SELECT lead(c1, 1, 111) over(partition by c3 order by c2)
FROM window_test"
+order_qt_lag "SELECT lag(c1, 1, 222) over(partition by c3 order by c2)
FROM window_test"
+// order_qt_lead "SELECT ntile(5) over(partition by c3 order by c2) FROM
window_test"
+order_qt_max "SELECT max(c1) over(partition by c3 order by c2) FROM
window_test"
+order_qt_min "SELECT min(c1) over(partition by c3 order by c2) FROM
window_test"
+
+order_qt_agg_1 """
+SELECT c1+1, c2, sum(c1), sum(c1) over(partition by c2 order by c1)
+FROM window_test
+GROUP BY c1, c2
+"""
+
+order_qt_agg_2 """
+SELECT c1, c2, sum(c1+1), sum(c1+1) over(partition by c2 order by
c1+1)
+FROM window_test
+GROUP BY c1, c2
+"""
+
+order_qt_agg_3 """
+SELECT row_number() over(partition by (grouping(c2) + grouping(c3)))
+FROM window_test
+GROUP BY ROLLUP (c2, c3)
+"""
+
+qt_subquery_1 """
+SELECT *, row_number() over(partition by c1)
+FROM (
+SELECT *, row_number() over(partition by c2)
+FROM window_test
Review Comment:
need order by in over to get a stable result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16579: [fix](subquery) fix bug of using constexpr and some agg func(like count,max) as subquery's output
github-actions[bot] commented on PR #16579: URL: https://github.com/apache/doris/pull/16579#issuecomment-1427693724 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16579: [fix](subquery) fix bug of using constexpr and some agg func(like count,max) as subquery's output
github-actions[bot] commented on PR #16579: URL: https://github.com/apache/doris/pull/16579#issuecomment-1427693556 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on pull request #16666: [fix](planner) Fix view
morrySnow commented on PR #1: URL: https://github.com/apache/doris/pull/1#issuecomment-142772 add desc in commit msg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16673: [fix](regression) fix add drop inverted index case
hello-stephen commented on PR #16673: URL: https://github.com/apache/doris/pull/16673#issuecomment-1427708936 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 34.09 seconds stream load tsv: 481 seconds loaded 74807831229 Bytes, about 148 MB/s stream load json: 37 seconds loaded 2358488459 Bytes, about 60 MB/s stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230213103525_clickbench_pr_95323.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16668: [Refactor](exchange) Remove unless variable and change block mem count way
github-actions[bot] commented on PR #16668: URL: https://github.com/apache/doris/pull/16668#issuecomment-1427708656 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16668: [Refactor](exchange) Remove unless variable and change block mem count way
github-actions[bot] commented on PR #16668: URL: https://github.com/apache/doris/pull/16668#issuecomment-1427708732 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #14397: [feature](nereids)support window function
morrySnow commented on code in PR #14397:
URL: https://github.com/apache/doris/pull/14397#discussion_r1104276282
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/window/Ntile.java:
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.expressions.functions.window;
+
+import org.apache.doris.catalog.FunctionSignature;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.functions.AlwaysNotNullable;
+import
org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature;
+import org.apache.doris.nereids.trees.expressions.shape.LeafExpression;
+import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor;
+import org.apache.doris.nereids.types.BigIntType;
+import org.apache.doris.nereids.types.DataType;
+import org.apache.doris.nereids.types.IntegerType;
+import org.apache.doris.nereids.types.LargeIntType;
+import org.apache.doris.nereids.types.SmallIntType;
+import org.apache.doris.nereids.types.TinyIntType;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.ImmutableList;
+
+import java.util.List;
+
+/**
+ * window function: Ntile()
+ */
+public class Ntile extends WindowFunction implements LeafExpression,
AlwaysNotNullable, ExplicitlyCastableSignature {
+
+public static final List SIGNATURES = ImmutableList.of(
+
FunctionSignature.ret(BigIntType.INSTANCE).args(TinyIntType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(SmallIntType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(IntegerType.INSTANCE),
+
FunctionSignature.ret(BigIntType.INSTANCE).args(BigIntType.INSTANCE),
+
FunctionSignature.ret(LargeIntType.INSTANCE).args(LargeIntType.INSTANCE)
+);
+
+private Expression buckets;
Review Comment:
bucket is not use anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
github-actions[bot] commented on PR #16664: URL: https://github.com/apache/doris/pull/16664#issuecomment-1427721119 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] streetbaby opened a new issue, #16674: [Bug] Failed to send brpc batch, error=Host is down，Not connected to 127.0.0.1:8060 yet
streetbaby opened a new issue, #16674:
URL: https://github.com/apache/doris/issues/16674
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
DORIS VERSION : 1.2.1
MYSQL CLIENT : 5.7
### What's Wrong?
### 1.
Fe and Be started Successfully.
The amount of data is very small （only test）.
### 2. Partial information :
fe.conf
stream_load_default_timeout_second=7200
fetch_stream_load_record_interval_second=60
max_stream_load_record_size=100
be.conf :
streaming_load_max_mb=20480
stream_load_record_batch_size=100
brpc_max_body_size=1073741824
brpc_socket_max_unwritten_bytes=1073741824
tablet_writer_ignore_eovercrowded=true
### 3. MYSQL CLIENT ERROR :
mysql> select count(*) from cdn_log;
ERROR 1105 (HY000): RpcException, msg: org.apache.doris.rpc.RpcException:
failed to send brpc batch, error=Host is down, error_text=[E112]Not connected
to 127.0.0.1:8060 yet, server_id=769 [R1][E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R2][E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R3][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R4][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R5][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R6][E112]Not connected to 127.0.0.1:
### 4. DORIS BE LOG :
W0213 18:11:14.618918 213384 vdata_stream_sender.h:262] failed to send brpc
batch, error=Host is down, error_text=[E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R1][E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R2][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R3][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R4][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R5][E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R6][E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R7][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R8][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R9][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R10][E112]Not connected to 127.0.0.1:8060
yet, server_id=769, client: 10.186.59.82, latency = 112
W0213 18:11:14.684383 213384 fragment_mgr.cpp:391] report error status: RPC
error(error -1): failed to send brpc batch, error=Host is down,
error_text=[E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R1][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R2][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R3][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R4][E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R5][E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R6][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R7][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R8][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R9][E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R10][E112]Not connected to 127.0.0.1:8060 yet,
server_id=769, client: 10.186.59.82, latency = 112/n@ 0x55dbbc99719a
doris::Status::ConstructErrorStatus()
@ 0x55dbc0b4197f
doris::vectorized::VDataStreamSender::Channel::_wait_last_brpc()
@ 0x55dbc0b39c7c
doris::vectorized::VDataStreamSender::Channel::close_wait()
@ 0x55dbc0b3f28d doris::vectorized::VDataStreamSender::close()
@ 0x55dbbd2b3fe7
doris::PlanFragmentExecutor::open_vectorized_internal()
@ 0x55dbbd2b51e5 doris::PlanFragmentExecutor::open()
@ 0x55dbbd28d1bc doris::FragmentExecState::execute()
@ 0x55dbbd29058a doris::FragmentMgr::_exec_actual()
@ 0x55dbbd290d4a
_ZNSt17_Function_handlerIFvvEZN5doris11FragmentMgr18exec_plan_fragmentERKNS1_23TExecPlanFragmentParamsESt8functionIFvPNS1_20PlanFragmentExecutorUlvE_E9_M_invokeERKSt9_Any_data
@ 0x55dbbd541805 doris::ThreadPool::dispatch_thread()
@ 0x55dbbd537bef doris::Thread::supervise_thread()
@ 0x7ff0d0667e25 start_thread
@ 0x7ff0d097abad __clone
@ (nil) (unknown)
to coordinator: TNetworkAddress(hostname=10.186.59.146, port=9020), query
id: bd65fe9a5abb4b69-92c646992f80bc8d, instance id:
bd65fe9a5abb4b69-92c646992f80bc8e
W0213 18:11:14.686898 213384 fragment_mgr.cpp:250] Got error while opening
fragment bd65fe9a5abb4b69-92c646992f80bc8e, query id:
bd65fe9a5abb4b69-92c646992f80bc8d: RPC error(error -1): failed to send brpc
batch, error=Host is down, error_text=[E112]Not connected to 127.0.0.1:8060
yet, server_id=769 [R1][E112]Not connected to 127.0.0.1:8060 yet, server_id=769
[R2][E112]Not connected to 127.0.0.1:8060 yet, server_id=769 [R3][E112]Not
connected to 127.0.0.1:8060 yet, server_id=769 [R4][E112]Not connected to
127.0.0.1:8060 yet, server_id=769 [R5][E112]Not conn
[GitHub] [doris] github-actions[bot] commented on pull request #16673: [fix](regression) fix add drop inverted index case
github-actions[bot] commented on PR #16673: URL: https://github.com/apache/doris/pull/16673#issuecomment-1427731222 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] jackwener merged pull request #16668: [Refactor](exchange) Remove unless variable and change block mem count way
jackwener merged PR #16668: URL: https://github.com/apache/doris/pull/16668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [Refactor](exchange) Remove unless variable and change block mem count way (#16668)
This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a34cc6ed23 [Refactor](exchange) Remove unless variable and change
block mem count way (#16668)
a34cc6ed23 is described below
commit a34cc6ed2326836551beeebb94bd1d0873c4c10c
Author: HappenLee
AuthorDate: Mon Feb 13 19:14:01 2023 +0800
[Refactor](exchange) Remove unless variable and change block mem count way
(#16668)
---
be/src/vec/runtime/vdata_stream_recvr.cpp | 20 +++-
be/src/vec/runtime/vdata_stream_recvr.h | 14 +-
2 files changed, 12 insertions(+), 22 deletions(-)
diff --git a/be/src/vec/runtime/vdata_stream_recvr.cpp
b/be/src/vec/runtime/vdata_stream_recvr.cpp
index a1e0ea4c32..79cb7b5cfd 100644
--- a/be/src/vec/runtime/vdata_stream_recvr.cpp
+++ b/be/src/vec/runtime/vdata_stream_recvr.cpp
@@ -82,9 +82,7 @@ Status VDataStreamRecvr::SenderQueue::_inner_get_batch(Block*
block, bool* eos)
_received_first_batch = true;
DCHECK(!_block_queue.empty());
-BlockUPtr next_block = std::move(_block_queue.front());
-auto block_byte_size = block->allocated_bytes();
-_recvr->_num_buffered_bytes -= block_byte_size;
+auto [next_block, block_byte_size] = std::move(_block_queue.front());
_recvr->_blocks_memory_usage->add(-block_byte_size);
_block_queue.pop_front();
_update_block_queue_empty();
@@ -156,9 +154,8 @@ void VDataStreamRecvr::SenderQueue::add_block(const PBlock&
pblock, int be_numbe
COUNTER_UPDATE(_recvr->_deserialize_row_batch_timer, deserialize_time);
COUNTER_UPDATE(_recvr->_decompress_timer, block->get_decompress_time());
COUNTER_UPDATE(_recvr->_decompress_bytes, block->get_decompressed_bytes());
-_recvr->_blocks_memory_usage->add(block_byte_size);
-_block_queue.emplace_back(std::move(block));
+_block_queue.emplace_back(std::move(block), block_byte_size);
_update_block_queue_empty();
// if done is nullptr, this function can't delay this response
if (done != nullptr && _recvr->exceeds_limit(block_byte_size)) {
@@ -168,7 +165,7 @@ void VDataStreamRecvr::SenderQueue::add_block(const PBlock&
pblock, int be_numbe
_pending_closures.emplace_back(*done, monotonicStopWatch);
*done = nullptr;
}
-_recvr->_num_buffered_bytes += block_byte_size;
+_recvr->_blocks_memory_usage->add(block_byte_size);
_data_arrival_cv.notify_one();
}
@@ -199,20 +196,18 @@ void VDataStreamRecvr::SenderQueue::add_block(Block*
block, bool use_move) {
}
materialize_block_inplace(*nblock);
-size_t block_size = nblock->bytes();
-
+size_t block_mem_size = nblock->allocated_bytes();
std::unique_lock l(_lock);
if (_is_cancelled) {
return;
}
COUNTER_UPDATE(_recvr->_local_bytes_received_counter,
block_bytes_received);
-_recvr->_blocks_memory_usage->add(nblock->allocated_bytes());
-_block_queue.emplace_back(std::move(nblock));
+_block_queue.emplace_back(std::move(nblock), block_mem_size);
_update_block_queue_empty();
_data_arrival_cv.notify_one();
-if (_recvr->exceeds_limit(block_size)) {
+if (_recvr->exceeds_limit(block_mem_size)) {
// yiguolei
// It is too tricky here, if the running thread is bthread then the
tid may be wrong.
std::thread::id tid = std::this_thread::get_id();
@@ -227,7 +222,7 @@ void VDataStreamRecvr::SenderQueue::add_block(Block* block,
bool use_move) {
iter->second->wait(l);
}
-_recvr->_num_buffered_bytes += block_size;
+_recvr->_blocks_memory_usage->add(block_mem_size);
}
void VDataStreamRecvr::SenderQueue::decrement_senders(int be_number) {
@@ -304,7 +299,6 @@ VDataStreamRecvr::VDataStreamRecvr(
_row_desc(row_desc),
_is_merging(is_merging),
_is_closed(false),
- _num_buffered_bytes(0),
_profile(profile),
_sub_plan_query_statistics_recvr(sub_plan_query_statistics_recvr),
_enable_pipeline(state->enable_pipeline_exec()) {
diff --git a/be/src/vec/runtime/vdata_stream_recvr.h
b/be/src/vec/runtime/vdata_stream_recvr.h
index 523d364fdf..1fc635a7f7 100644
--- a/be/src/vec/runtime/vdata_stream_recvr.h
+++ b/be/src/vec/runtime/vdata_stream_recvr.h
@@ -89,7 +89,8 @@ public:
void close();
bool exceeds_limit(int batch_size) {
-return _num_buffered_bytes + batch_size >
config::exchg_node_buffer_size_bytes;
+return _blocks_memory_usage->current_value() + batch_size >
+ config::exchg_node_buffer_size_bytes;
}
bool is_closed() const { return _is_closed; }
@@ -119,7 +120,6 @@ private:
bool _is_merging;
bool _is_closed;
-std::atomic _num_buffered_bytes;
std::unique_ptr _mem_tracker;
// Managed by object pool
std::vector _sender_queues;
[GitHub] [doris] github-actions[bot] commented on pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
github-actions[bot] commented on PR #16436: URL: https://github.com/apache/doris/pull/16436#issuecomment-1427767548 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16436: [enhancement](Nereids): avoid contruct groupExpr in graph-simplifier
github-actions[bot] commented on PR #16436: URL: https://github.com/apache/doris/pull/16436#issuecomment-1427767621 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luguangming commented on issue #15582: [Bug] Failed to deserialize column statistics
luguangming commented on issue #15582: URL: https://github.com/apache/doris/issues/15582#issuecomment-1427792019 seem like https://github.com/apache/doris/issues/16672 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.
github-actions[bot] commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1427792770 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15509: [feature](partition)add default list partition
github-actions[bot] commented on PR #15509: URL: https://github.com/apache/doris/pull/15509#issuecomment-1427804115 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16661: [Enhencement](CsvReader) Optimize CsvReader
github-actions[bot] commented on PR #16661: URL: https://github.com/apache/doris/pull/16661#issuecomment-1427810901 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427811472 just test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427812488 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16588: [feature](cooldown) Auto delete unused remote files
github-actions[bot] commented on PR #16588: URL: https://github.com/apache/doris/pull/16588#issuecomment-1427816472 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427817395 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427821894 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427833007 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427834796 external test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427846652 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427849102 this will not run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427849996 this will run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427852428 external aaa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16642: [typo](docs)fix the alter frontend statement description
github-actions[bot] commented on PR #16642: URL: https://github.com/apache/doris/pull/16642#issuecomment-1427856394 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] JNSimba merged pull request #16642: [typo](docs)fix the alter frontend statement description
JNSimba merged PR #16642: URL: https://github.com/apache/doris/pull/16642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (a34cc6ed23 -> e7af583935)
This is an automated email from the ASF dual-hosted git repository. diwu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a34cc6ed23 [Refactor](exchange) Remove unless variable and change block mem count way (#16668) add e7af583935 [typo](docs)fix the alter frontend statement description (#16642) No new revisions were added by this update. Summary of changes: .../Cluster-Management-Statements/ALTER-SYSTEM-ADD-FOLLOWER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-ADD-OBSERVER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-DROP-FOLLOWER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-DROP-OBSERVER.md | 2 +- docs/en/docs/sql-manual/sql-reference/Show-Statements/SHOW-VARIABLES.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-ADD-FOLLOWER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-ADD-OBSERVER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-DROP-FOLLOWER.md | 2 +- .../Cluster-Management-Statements/ALTER-SYSTEM-DROP-OBSERVER.md | 2 +- .../docs/sql-manual/sql-reference/Show-Statements/SHOW-VARIABLES.md | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (e7af583935 -> 15d9dd114b)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from e7af583935 [typo](docs)fix the alter frontend statement description (#16642) add 15d9dd114b [Fix](cpp17) fix gutil unary_function binary_function for cpp17 (#16670) No new revisions were added by this update. Summary of changes: be/src/gutil/stl_util.h| 15 +-- be/src/gutil/strings/numbers.h | 9 - be/src/gutil/strings/util.h| 5 ++--- be/src/util/container_util.hpp | 4 ++-- 4 files changed, 13 insertions(+), 20 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16670: [Fix](cpp17) fix gutil unary_function/binary_function for cpp17
yiguolei merged PR #16670: URL: https://github.com/apache/doris/pull/16670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427876834 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
github-actions[bot] commented on PR #16664: URL: https://github.com/apache/doris/pull/16664#issuecomment-1427903994 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
github-actions[bot] commented on PR #16664: URL: https://github.com/apache/doris/pull/16664#issuecomment-1427904056 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (15d9dd114b -> c620e06f6a)
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 15d9dd114b [Fix](cpp17) fix gutil unary_function binary_function for cpp17 (#16670) add c620e06f6a [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader No new revisions were added by this update. Summary of changes: be/src/io/broker_reader.cpp | 3 +-- be/src/io/fs/broker_file_system.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16664: [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader
yiguolei merged PR #16664: URL: https://github.com/apache/doris/pull/16664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14397: [feature](nereids)support window function
github-actions[bot] commented on PR #14397: URL: https://github.com/apache/doris/pull/14397#issuecomment-1427905270 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #14397: [feature](nereids)support window function
github-actions[bot] commented on PR #14397: URL: https://github.com/apache/doris/pull/14397#issuecomment-1427905391 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16621: [Enhancement](func)Introduce non_nullable extraction function.
github-actions[bot] commented on PR #16621: URL: https://github.com/apache/doris/pull/16621#issuecomment-1427907065 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427926000 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #14397: [feature](nereids)support window function
morrySnow merged PR #14397: URL: https://github.com/apache/doris/pull/14397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated (c620e06f6a -> 77a3288ce7)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from c620e06f6a [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader add 77a3288ce7 [feature](Nereids) support window function (#14397) No new revisions were added by this update. Summary of changes: .../antlr4/org/apache/doris/nereids/DorisParser.g4 | 35 +- .../org/apache/doris/analysis/AnalyticExpr.java| 8 +- .../org/apache/doris/analysis/AnalyticWindow.java | 6 +- .../java/org/apache/doris/analysis/Analyzer.java | 4 +- .../apache/doris/catalog/AggregateFunction.java| 4 + .../doris/catalog/BuiltinWindowFunctions.java | 54 ++ .../org/apache/doris/catalog/FunctionHelper.java | 11 + .../org/apache/doris/catalog/FunctionRegistry.java | 1 + .../org/apache/doris/nereids/NereidsPlanner.java | 4 - .../glue/translator/ExpressionTranslator.java | 48 +- .../glue/translator/PhysicalPlanTranslator.java| 231 - .../glue/translator/PlanTranslatorContext.java | 15 + .../jobs/batch/NereidsRewriteJobExecutor.java | 7 + .../java/org/apache/doris/nereids/memo/Memo.java | 4 +- .../doris/nereids/parser/LogicalPlanBuilder.java | 111 - .../nereids/properties/PhysicalProperties.java | 4 + .../nereids/properties/RequestPropertyDeriver.java | 2 +- .../org/apache/doris/nereids/rules/RuleSet.java| 2 + .../org/apache/doris/nereids/rules/RuleType.java | 4 +- .../nereids/rules/analysis/BindExpression.java | 3 +- .../rules/analysis/ProjectToGlobalAggregate.java | 6 +- .../rules/analysis/WindowFunctionChecker.java | 438 + .../LogicalWindowToPhysicalWindow.java | 545 + .../CheckAndStandardizeWindowFunctionAndFrame.java | 65 +++ .../ExtractAndNormalizeWindowExpression.java | 117 + .../rules/rewrite/logical/NormalizeAggregate.java | 37 +- .../rules/rewrite/logical/NormalizeToSlot.java | 4 + .../doris/nereids/stats/StatsCalculator.java | 38 ++ .../trees/expressions/WindowExpression.java| 215 .../nereids/trees/expressions/WindowFrame.java | 270 ++ .../expressions/functions/window/DenseRank.java| 61 +++ .../functions/window/FirstOrLastValue.java | 48 ++ .../expressions/functions/window/FirstValue.java | 52 ++ .../trees/expressions/functions/window/Lag.java| 84 .../expressions/functions/window/LastValue.java| 42 ++ .../trees/expressions/functions/window/Lead.java | 85 .../trees/expressions/functions/window/Ntile.java | 76 +++ .../trees/expressions/functions/window/Rank.java | 61 +++ .../expressions/functions/window/RowNumber.java| 62 +++ .../functions/window/WindowFunction.java | 56 +++ .../expressions/visitor/ExpressionVisitor.java | 19 +- .../expressions/visitor/WindowFunctionVisitor.java | 66 +++ .../apache/doris/nereids/trees/plans/PlanType.java | 2 + .../doris/nereids/trees/plans/algebra/Window.java | 89 .../nereids/trees/plans/logical/LogicalWindow.java | 156 ++ .../trees/plans/physical/PhysicalQuickSort.java| 17 +- .../trees/plans/physical/PhysicalWindow.java | 164 +++ .../nereids/trees/plans/visitor/PlanVisitor.java | 10 + .../org/apache/doris/nereids/types/DataType.java | 4 + .../org/apache/doris/planner/AnalyticEvalNode.java | 30 +- .../org/apache/doris/planner/AnalyticPlanner.java | 6 +- .../doris/nereids/parser/NereidsParserTest.java| 21 +- .../CheckAndStandardizeWindowFunctionTest.java | 260 ++ .../ExtractAndNormalizeWindowExpressionTest.java | 233 + .../logical/LogicalWindowToPhysicalWindowTest.java | 95 .../java/org/apache/doris/planner/PlannerTest.java | 2 - .../data/nereids_syntax_p0/window_function.out | 359 ++ .../nereids_syntax_p0/window_function.groovy | 119 + 58 files changed, 4513 insertions(+), 59 deletions(-) create mode 100644 fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinWindowFunctions.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/WindowFunctionChecker.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/rules/implementation/LogicalWindowToPhysicalWindow.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/CheckAndStandardizeWindowFunctionAndFrame.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/ExtractAndNormalizeWindowExpression.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/WindowExpression.java create mode 100644 fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/WindowFrame.java create mode 100644 fe/fe-core/src/main/java/org/a
[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1427940852 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427942919 external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427943862 this run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16633: [Improvement](ES)Supprt datav2 and datetimev2 for es query
github-actions[bot] commented on PR #16633: URL: https://github.com/apache/doris/pull/16633#issuecomment-1427944003 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427945556 external run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427947575 external run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427947823 run external run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16673: [fix](regression) fix add drop inverted index case
github-actions[bot] commented on PR #16673: URL: https://github.com/apache/doris/pull/16673#issuecomment-1427956332 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] ZhangGuoqiang666 commented on pull request #16660: 【external test】adjust docker compose yml about hive
ZhangGuoqiang666 commented on PR #16660: URL: https://github.com/apache/doris/pull/16660#issuecomment-1427963077 external aaa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
