[GitHub] [doris] dataroaring merged pull request #11548: [improvement](test) group some cases and group a case to p0 if it is not grouped
dataroaring merged PR #11548: URL: https://github.com/apache/doris/pull/11548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [improvement](test) group some cases and group a case to p0 if it is not grouped (#11548)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ee4d9d4347 [improvement](test) group some cases and group a case to p0
if it is not grouped (#11548)
ee4d9d4347 is described below
commit ee4d9d43470efd48bfb6f928833c758a2bfc91ad
Author: Yongqiang YANG <98214048+dataroar...@users.noreply.github.com>
AuthorDate: Sat Aug 6 15:12:08 2022 +0800
[improvement](test) group some cases and group a case to p0 if it is not
grouped (#11548)
---
.../test_create_table_with_bloom_filter.out | 0
regression-test/data/{csv_header => csv_header_p0}/csv.txt | 0
.../data/{csv_header => csv_header_p0}/csv_with_names.txt| 0
.../data/{csv_header => csv_header_p0}/csv_with_names_and_types.txt | 0
.../{data_model => data_model_p0}/aggregate/test_aggregate_table.out | 0
.../duplicate/storage/test_dup_tab_char.out | 0
.../duplicate/storage/test_dup_tab_char_nullable.out | 0
.../duplicate/storage/test_dup_tab_date.out | 0
.../duplicate/storage/test_dup_tab_date_nullable.out | 0
.../duplicate/storage/test_dup_tab_datetime.out | 0
.../duplicate/storage/test_dup_tab_datetime_nullable.out | 0
.../{data_model => data_model_p0}/duplicate/test_duplicate_table.out | 0
.../data/{data_model => data_model_p0}/unique/test_unique_table.out | 0
.../{data_model => data_model_p0}/unique/test_unique_table_like.out | 0
regression-test/data/{delete => delete_p0}/test_delete.out | 0
.../data/{delete => delete_p0}/test_multi_columns_delete.out | 0
regression-test/data/{nereids_syntax => nereids_syntax_p0}/join.out | 0
.../data/{performance => performance_p0}/redundant_conjuncts.out | 4 ++--
.../{sql_block_rule => sql_block_rule_p0}/test_sql_block_rule.out| 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q1.1.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q1.2.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q1.3.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q2.1.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q2.2.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q2.3.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q3.1.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q3.2.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q3.3.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q3.4.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q4.1.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q4.2.out | 0
.../{ssb_unique_sql_zstd => ssb_unique_sql_zstd_p0}/sql/q4.3.out | 0
.../main/groovy/org/apache/doris/regression/suite/SuiteScript.groovy | 5 +
regression-test/suites/bitmap_functions/test_bitmap_intersect.groovy | 2 +-
.../{bloom_filter => bloom_filter_p0}/test_bloom_filter.groovy | 2 +-
.../test_create_table_with_bloom_filter.groovy | 2 +-
.../suites/{csv_header => csv_header_p0}/test_csv_with_header.groovy | 2 +-
.../aggregate/test_aggregate_table.groovy| 0
.../duplicate/storage/test_dup_tab_basic_int.groovy | 0
.../duplicate/storage/test_dup_tab_basic_int_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_basic_varchar.groovy | 0
.../duplicate/storage/test_dup_tab_basic_varchar_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_char.groovy | 0
.../duplicate/storage/test_dup_tab_char_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_date.groovy | 0
.../duplicate/storage/test_dup_tab_date_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_datetime.groovy | 0
.../duplicate/storage/test_dup_tab_datetime_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_decimal.groovy| 0
.../duplicate/storage/test_dup_tab_decimal_nullable.groovy | 0
.../duplicate/storage/test_dup_tab_mixed_type.groovy | 0
.../duplicate/storage/test_dup_tab_mixed_type_nullable.groovy| 0
.../duplicate/test_duplicate_table.groovy| 0
.../{data_model => data_model_p0}/unique/test_unique_table.groovy| 0
.../unique/test_unique_table_like.groovy | 0
regression-test/suites/{delete => delete_p0}/test_delete.groovy | 2 +-
.../suites/{delete => delete_p0}/test_multi_columns_delete.groovy| 2 +-
.../suites/{nereids_syntax => nereids_syntax_p0}/join.groovy | 0
.../suites/{nereids_syntax =
[GitHub] [doris] Kikyou1997 opened a new pull request, #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization
Kikyou1997 opened a new pull request, #11569: URL: https://github.com/apache/doris/pull/11569 # Proposed changes Issue Number: noissue ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on pull request #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization
Kikyou1997 commented on PR #11569: URL: https://github.com/apache/doris/pull/11569#issuecomment-1207184468 @morrySnow @morningman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caiconghui opened a new issue, #11570: [Enhancement] Support loading hdfs config from hdfs_site.xml
caiconghui opened a new issue, #11570: URL: https://github.com/apache/doris/issues/11570 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Now, user may need to write a lot of hdfs config when create hive table, which may be hard for user to use, I think we should support loading hdfs config from hdfs_site.xml, so user only need to know about the hive metastore url, database and table. ### Solution _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] caiconghui opened a new pull request, #11571: [Enhancement](hdfs) Support loading hdfs config from hdfs-site.xml
caiconghui opened a new pull request, #11571: URL: https://github.com/apache/doris/pull/11571 # Proposed changes Issue Number: close #11570 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #11527: [fix](planner)push constant expr in predicate to outer join's other conjuncts by mistake
Gabriel39 commented on code in PR #11527:
URL: https://github.com/apache/doris/pull/11527#discussion_r939517284
##
regression-test/suites/correctness/test_constant_push_down_through_outer_join.groovy:
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+ // or more contributor license agreements. See the NOTICE file
+ // distributed with this work for additional information
+ // regarding copyright ownership. The ASF licenses this file
+ // to you under the Apache License, Version 2.0 (the
+ // "License"); you may not use this file except in compliance
+ // with the License. You may obtain a copy of the License at
+ //
+ // http://www.apache.org/licenses/LICENSE-2.0
+ //
+ // Unless required by applicable law or agreed to in writing,
+ // software distributed under the License is distributed on an
+ // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ // KIND, either express or implied. See the License for the
+ // specific language governing permissions and limitations
+ // under the License.
+
+ suite("constant_push_down_through_outer_join") {
+ sql """ DROP TABLE IF EXISTS wftest1 """
+ sql """ DROP TABLE IF EXISTS wftest2 """
+ sql """
+ CREATE TABLE `wftest1` (
+ `aa` varchar(200) NULL COMMENT "",
+ `bb` int NULL COMMENT ""
+ ) ENGINE=OLAP
+ UNIQUE KEY (`aa`) COMMENT "aa"
+ DISTRIBUTED BY HASH(`aa`) BUCKETS 3
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "in_memory" = "false",
+ "storage_format" = "V2"
+ )
+ """
+ sql """
+ CREATE TABLE `wftest2` (
+ `cc` varchar(200) NULL COMMENT "",
+ `dd` int NULL COMMENT ""
+ ) ENGINE=OLAP
+ UNIQUE KEY (`cc`)
+ COMMENT "OLAP"
+ DISTRIBUTED BY HASH(`cc`) BUCKETS 3
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "in_memory" = "false",
+ "storage_format" = "V2"
+ )
+ """
+
+ sql """
+ INSERT INTO wftest1 VALUES('a', 1), ('b', 1), ('c', 1);
+ """
+
+ sql """
+ INSERT INTO wftest2 VALUES('a', 1), ('b', 1), ('d', 1);
+ """
+
+ order_qt_select """
+ select t.* from (select * from wftest1 t1 left join wftest2 t2 on
t1.aa=t2.cc) t where dayofweek(current_date())=8;
Review Comment:
What should be returned for query `select * from wftest1 t1 left join
wftest2 t2 on t1.aa=t2.cc and dayofweek(current_date())=8` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11527: [fix](planner)push constant expr in predicate to outer join's other conjuncts by mistake
morrySnow commented on code in PR #11527:
URL: https://github.com/apache/doris/pull/11527#discussion_r939517612
##
regression-test/suites/correctness/test_constant_push_down_through_outer_join.groovy:
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+ // or more contributor license agreements. See the NOTICE file
+ // distributed with this work for additional information
+ // regarding copyright ownership. The ASF licenses this file
+ // to you under the Apache License, Version 2.0 (the
+ // "License"); you may not use this file except in compliance
+ // with the License. You may obtain a copy of the License at
+ //
+ // http://www.apache.org/licenses/LICENSE-2.0
+ //
+ // Unless required by applicable law or agreed to in writing,
+ // software distributed under the License is distributed on an
+ // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ // KIND, either express or implied. See the License for the
+ // specific language governing permissions and limitations
+ // under the License.
+
+ suite("constant_push_down_through_outer_join") {
+ sql """ DROP TABLE IF EXISTS wftest1 """
+ sql """ DROP TABLE IF EXISTS wftest2 """
+ sql """
+ CREATE TABLE `wftest1` (
+ `aa` varchar(200) NULL COMMENT "",
+ `bb` int NULL COMMENT ""
+ ) ENGINE=OLAP
+ UNIQUE KEY (`aa`) COMMENT "aa"
+ DISTRIBUTED BY HASH(`aa`) BUCKETS 3
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "in_memory" = "false",
+ "storage_format" = "V2"
+ )
+ """
+ sql """
+ CREATE TABLE `wftest2` (
+ `cc` varchar(200) NULL COMMENT "",
+ `dd` int NULL COMMENT ""
+ ) ENGINE=OLAP
+ UNIQUE KEY (`cc`)
+ COMMENT "OLAP"
+ DISTRIBUTED BY HASH(`cc`) BUCKETS 3
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1",
+ "in_memory" = "false",
+ "storage_format" = "V2"
+ )
+ """
+
+ sql """
+ INSERT INTO wftest1 VALUES('a', 1), ('b', 1), ('c', 1);
+ """
+
+ sql """
+ INSERT INTO wftest2 VALUES('a', 1), ('b', 1), ('d', 1);
+ """
+
+ order_qt_select """
+ select t.* from (select * from wftest1 t1 left join wftest2 t2 on
t1.aa=t2.cc) t where dayofweek(current_date())=8;
Review Comment:
all rows of left table with all columns of right table filled by null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin opened a new issue, #11572: [Bug] the value may be changed of date and datetime types
luozenglin opened a new issue, #11572:
URL: https://github.com/apache/doris/issues/11572
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
master
### What's Wrong?
mysql> select dayofweek("2022-02-30");
+--+
| dayofweek('2022-02-28 00:00:00') |
+--+
|2 |
+--+
### What You Expected?
mysql> select dayofyear("2022-02-30");
+-+
| dayofyear('2022-02-30') |
+-+
|NULL |
+-+
### How to Reproduce?
mysql> select dayofweek("2022-02-30");
+--+
| dayofweek('2022-02-28 00:00:00') |
+--+
|2 |
+--+
1 row in set (0.06 sec)
mysql> select dayofyear("2022-02-30");
+--+
| dayofyear('2022-02-28 00:00:00') |
+--+
| 59 |
+--+
1 row in set (0.06 sec)
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin opened a new pull request, #11573: [fix](date) fix the value may be changed during the parsing of date and datetime types
luozenglin opened a new pull request, #11573: URL: https://github.com/apache/doris/pull/11573 # Proposed changes Issue Number: close #11572 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring commented on a diff in pull request #11550: [improvement](alter) modify table's default replica if table is unpartitioned
dataroaring commented on code in PR #11550:
URL: https://github.com/apache/doris/pull/11550#discussion_r939534767
##
docs/en/docs/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-TABLE-PROPERTY.md:
##
@@ -154,6 +154,21 @@ Only the MySQL type can be changed to the ODBC type. The
value of driver is the
ALTER TABLE example_db.mysql_table MODIFY ENGINE TO odbc PROPERTIES("driver" =
"MySQL");
```
+12. Modify the number of copies
Review Comment:
the number of replicas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[doris] 01/01: [doc](asf) update .asf.ymal to stop sending notification to dev@doris
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch morningman-patch-3 in repository https://gitbox.apache.org/repos/asf/doris.git commit fbf2ffc417f9dfba7ebdf1abbca0136d00eab56f Author: Mingyu Chen AuthorDate: Sat Aug 6 22:45:40 2022 +0800 [doc](asf) update .asf.ymal to stop sending notification to dev@doris --- .asf.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index adc150ff89..d3f49b8a62 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -61,8 +61,6 @@ github: required_pull_request_reviews: dismiss_stale_reviews: true required_approving_review_count: 1 - notifications: -pullrequests_status: commits@doris.apache.org collaborators: - jackwener - tinke @@ -73,3 +71,6 @@ github: - dataroaring - morrySnow - dataalive + +notifications: +pullrequests_status: commits@doris.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch morningman-patch-3 created (now fbf2ffc417)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch morningman-patch-3 in repository https://gitbox.apache.org/repos/asf/doris.git at fbf2ffc417 [doc](asf) update .asf.ymal to stop sending notification to dev@doris This branch includes the following new commits: new fbf2ffc417 [doc](asf) update .asf.ymal to stop sending notification to dev@doris The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman opened a new pull request, #11574: [doc](asf) update .asf.ymal to stop sending notification to dev@doris
morningman opened a new pull request, #11574: URL: https://github.com/apache/doris/pull/11574 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: [doc](asf) update .asf.ymal to stop sending notification to dev@doris
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new d4cac502ab4 [doc](asf) update .asf.ymal to stop sending notification to dev@doris d4cac502ab4 is described below commit d4cac502ab49af43874beeac831b8c2d47d5a173 Author: morningman AuthorDate: Sat Aug 6 22:48:02 2022 +0800 [doc](asf) update .asf.ymal to stop sending notification to dev@doris --- .asf.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index 70d2e1d2e35..4272f5105e9 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -41,5 +41,5 @@ github: squash: true merge: false rebase: false - notifications: -pullrequests_status: commits@doris.apache.org +notifications: + pullrequests_status: commits@doris.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-thirdparty] branch main updated (c1caa4c -> 4dace92)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git from c1caa4c update readme add 9a9ad82 [github] add .asf.yaml add 13f46f8 [doc](asf) update .asf.ymal to stop sending notification to dev@doris new 4dace92 [github] add .asf.yaml The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .asf.yaml | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 .asf.yaml - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-thirdparty] 01/01: [github] add .asf.yaml
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git commit 4dace92dbf4c99498e7808ee3552aa56b569cbd8 Merge: c1caa4c 13f46f8 Author: Mingyu Chen AuthorDate: Sat Aug 6 22:50:59 2022 +0800 [github] add .asf.yaml .asf.yaml | 46 ++ 1 file changed, 46 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] dataroaring opened a new pull request, #11575: remove docs for direct compiling on Centos
dataroaring opened a new pull request, #11575: URL: https://github.com/apache/doris/pull/11575 I tried to compile doris on Centos directly according to docs, however it does not work. It is very difficult to find tools needed by doris compilation on Centos. # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes - [ ] No - [ ] I don't know 2. Has unit tests been added: - [ ] Yes - [ ] No - [ ] No Need 3. Has document been added or modified: - [ ] Yes - [ ] No - [ ] No Need 4. Does it need to update dependencies: - [ ] Yes - [ ] No 5. Are there any changes that cannot be rolled back: - [ ] Yes (If Yes, please explain WHY) - [ ] No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #11458: [enhancement](tracing) append the profile counter to trace.
morningman commented on code in PR #11458: URL: https://github.com/apache/doris/pull/11458#discussion_r939545430 ## be/src/vec/exec/volap_scan_node.cpp: ## @@ -1876,7 +1870,6 @@ int VOlapScanNode::_start_scanner_thread_task(RuntimeState* state, int block_per } // post volap scanners to thread-pool -auto cur_span = opentelemetry::trace::Tracer::GetCurrentSpan(); Review Comment: Why remove this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11377: [fix](docs) Fix some errors related to privilege and grant in the docs
github-actions[bot] commented on PR #11377: URL: https://github.com/apache/doris/pull/11377#issuecomment-1207239617 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11377: [fix](docs) Fix some errors related to privilege and grant in the docs
github-actions[bot] commented on PR #11377: URL: https://github.com/apache/doris/pull/11377#issuecomment-1207239630 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #11458: [enhancement](tracing) append the profile counter to trace.
luozenglin commented on code in PR #11458: URL: https://github.com/apache/doris/pull/11458#discussion_r939546580 ## be/src/vec/exec/volap_scan_node.cpp: ## @@ -1876,7 +1870,6 @@ int VOlapScanNode::_start_scanner_thread_task(RuntimeState* state, int block_per } // post volap scanners to thread-pool -auto cur_span = opentelemetry::trace::Tracer::GetCurrentSpan(); Review Comment: This span is passed into the scanner thread, and a span is collected in each scanner thread, which may cause too many spans to be generated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization
morrySnow commented on code in PR #11569:
URL: https://github.com/apache/doris/pull/11569#discussion_r939547384
##
fe/fe-core/src/main/java/org/apache/doris/planner/SortNode.java:
##
@@ -211,9 +211,6 @@ public void init(Analyzer analyzer) throws UserException {
outputSmap = new ExprSubstitutionMap();
for (int i = 0; i < slotExprs.size(); ++i) {
-if (!sortTupleSlots.get(i).isMaterialized()) {
Review Comment:
add a comment that we rely on projectionPlanner to get a correct plan.
##
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##
@@ -1031,9 +1031,33 @@ private PlanNode createSelectPlan(SelectStmt selectStmt,
Analyzer analyzer, long
for (int i = 1; i < selectStmt.getTableRefs().size(); ++i) {
TableRef innerRef = selectStmt.getTableRefs().get(i);
+boolean aggOutputNotHaveMaterializedSlot = false;
+AggregateInfo aggregateInfo = null;
+TupleDescriptor output = null;
+if (innerRef instanceof InlineViewRef) {
+InlineViewRef inlineViewRef = (InlineViewRef) innerRef;
+QueryStmt queryStmt = inlineViewRef.getViewStmt();
+if (queryStmt instanceof SelectStmt) {
Review Comment:
set operation do not has this bug?
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotDescriptor.java:
##
@@ -162,6 +162,21 @@ public void setIsMaterialized(boolean value) {
isMaterialized = value;
}
+public void materializeSrcExpr() {
+if (sourceExprs == null) {
+return;
+}
+for (Expr expr : sourceExprs) {
Review Comment:
should we need to do chain replace? such as set `IsMaterialized` on the
source expr of source expr's slot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11531: [feature](Nereids):refactor and add outer join LAsscom.
morrySnow commented on code in PR #11531:
URL: https://github.com/apache/doris/pull/11531#discussion_r939548389
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##
@@ -0,0 +1,219 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.exploration.join;
+
+import org.apache.doris.common.Pair;
+import org.apache.doris.nereids.trees.expressions.Expression;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.plans.GroupPlan;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.logical.LogicalJoin;
+import org.apache.doris.nereids.trees.plans.logical.LogicalProject;
+import org.apache.doris.nereids.util.ExpressionUtils;
+import org.apache.doris.nereids.util.Utils;
+
+import com.google.common.base.Preconditions;
+import com.google.common.collect.Lists;
+
+import java.util.HashSet;
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * Common function for JoinLAsscom
+ */
+public class JoinLAsscomHelper {
+/*
+ * topJoinnewTopJoin
+ * / \ / \
+ * bottomJoin C --> newBottomJoin B
+ * /\ /\
+ * A BA C
+ */
+private final LogicalJoin topJoin;
+private final LogicalJoin bottomJoin;
+private final Plan a;
+private final Plan b;
+private final Plan c;
+
+private final Expression topJoinOnClause;
+private final Expression bottomJoinOnClause;
+
+private final List aOutputSlots;
+private final List bOutputSlots;
+private final List cOutputSlots;
+
+private final List newBottomJoinOnCondition =
Lists.newArrayList();
+private final List newTopJoinOnCondition =
Lists.newArrayList();
+
+/**
+ * Init plan and output.
+ */
+public JoinLAsscomHelper(LogicalJoin topJoin,
+LogicalJoin bottomJoin) {
+this.topJoin = topJoin;
+this.bottomJoin = bottomJoin;
+
+a = bottomJoin.left();
+b = bottomJoin.right();
+c = (Plan) topJoin.right();
Review Comment:
```suggestion
c = topJoin.right();
```
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##
@@ -167,32 +173,26 @@ private LogicalJoin newBottomJoin()
{
* Create topJoin for project-inside.
*/
public LogicalJoin newProjectTopJoin() {
+Plan left;
+Plan right;
+
List newLeftProjectExpr = getProjectExprs().first;
List newRightProjectExprs = getProjectExprs().second;
-
-// no right project
-if (newRightProjectExprs.size() == 0) {
-return new LogicalJoin(
-topJoin.getJoinType(),
-Optional.of(ExpressionUtils.and(newTopJoinOnCondition)),
-newBottomJoin(), b);
+if (!newLeftProjectExpr.isEmpty()) {
+left = new LogicalProject<>(newLeftProjectExpr, newBottomJoin());
+} else {
+left = newBottomJoin();
}
-
-LogicalProject newRightProject = new
LogicalProject<>(newRightProjectExprs, b);
-if (newLeftProjectExpr.size() == 0) {
-// no left project
-return new LogicalJoin(
-topJoin.getJoinType(),
-Optional.of(ExpressionUtils.and(newTopJoinOnCondition)),
-newBottomJoin(), newRightProject);
+if (!newRightProjectExprs.isEmpty()) {
+right = new LogicalProject<>(newLeftProjectExpr, newBottomJoin());
Review Comment:
error intro by copy code from left project?
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/JoinLAsscomHelper.java:
##
@@ -0,0 +1,219 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization
Kikyou1997 commented on code in PR #11569:
URL: https://github.com/apache/doris/pull/11569#discussion_r939599726
##
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotDescriptor.java:
##
@@ -162,6 +162,21 @@ public void setIsMaterialized(boolean value) {
isMaterialized = value;
}
+public void materializeSrcExpr() {
+if (sourceExprs == null) {
+return;
+}
+for (Expr expr : sourceExprs) {
Review Comment:
Yes, we do need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #11569: [Fix](planner) Fix wrong planner with count(*) optmizer for cross join optimization
Kikyou1997 commented on code in PR #11569:
URL: https://github.com/apache/doris/pull/11569#discussion_r939600077
##
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java:
##
@@ -1031,9 +1031,33 @@ private PlanNode createSelectPlan(SelectStmt selectStmt,
Analyzer analyzer, long
for (int i = 1; i < selectStmt.getTableRefs().size(); ++i) {
TableRef innerRef = selectStmt.getTableRefs().get(i);
+boolean aggOutputNotHaveMaterializedSlot = false;
+AggregateInfo aggregateInfo = null;
+TupleDescriptor output = null;
+if (innerRef instanceof InlineViewRef) {
+InlineViewRef inlineViewRef = (InlineViewRef) innerRef;
+QueryStmt queryStmt = inlineViewRef.getViewStmt();
+if (queryStmt instanceof SelectStmt) {
Review Comment:
I think this bug is just about query block, no matter the stmt of origin SQL
is SetOperationStmt or SelectStmt
##
fe/fe-core/src/main/java/org/apache/doris/planner/SortNode.java:
##
@@ -211,9 +211,6 @@ public void init(Analyzer analyzer) throws UserException {
outputSmap = new ExprSubstitutionMap();
for (int i = 0; i < slotExprs.size(); ++i) {
-if (!sortTupleSlots.get(i).isMaterialized()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11574: [doc](asf) update .asf.ymal to stop sending notification to dev@doris
github-actions[bot] commented on PR #11574: URL: https://github.com/apache/doris/pull/11574#issuecomment-1207322768 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11574: [doc](asf) update .asf.ymal to stop sending notification to dev@doris
github-actions[bot] commented on PR #11574: URL: https://github.com/apache/doris/pull/11574#issuecomment-1207322775 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11562: [refactor](ddl) Encapsulate table's properties
adonis0147 commented on PR #11562: URL: https://github.com/apache/doris/pull/11562#issuecomment-1207342793 > Actually we had a class named `TableProperty` yet. Is there any different? Oops, it seems that I can merge these two classes. I will update this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
