[GitHub] [doris] cambyzju commented on a diff in pull request #10388: [feature-wip] (array-type) add the array_distinct function

2022-07-02 Thread GitBox


cambyzju commented on code in PR #10388:
URL: https://github.com/apache/doris/pull/10388#discussion_r912330918


##
be/src/vec/functions/array/function_array_distinct.h:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// This file is copied from
+// 
https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/array/arrayDistinct.cpp
+// and modified by Doris
+#pragma once
+
+#include "vec/columns/column_array.h"
+#include "vec/columns/column_const.h"
+#include "vec/common/hash_table/hash_set.h"
+#include "vec/common/hash_table/hash_table.h"
+#include "vec/common/sip_hash.h"
+#include "vec/data_types/data_type_array.h"
+#include "vec/data_types/data_type_number.h"
+#include "vec/functions/function.h"
+#include "vec/functions/function_helpers.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+class FunctionArrayDistinct : public IFunction {
+public:
+static constexpr auto name = "array_distinct";
+static FunctionPtr create() { return 
std::make_shared(); }
+using NullMapType = PaddedPODArray;
+
+/// Get function name.
+String get_name() const override { return name; }
+
+bool is_variadic() const override { return false; }
+
+size_t get_number_of_arguments() const override { return 1; }
+
+DataTypePtr get_return_type_impl(const DataTypes& arguments) const 
override {
+DCHECK(is_array(arguments[0]))
+<< "first argument for function: " << name << " should be 
DataTypeArray"
+<< " and arguments[0] is " << arguments[0]->get_name();
+return arguments[0];
+}
+
+Status execute_impl(FunctionContext* context, Block& block, const 
ColumnNumbers& arguments,
+size_t result, size_t input_rows_count) override {
+ColumnPtr src_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+const auto& src_column_array = 
check_and_get_column(*src_column);
+if (!src_column_array) {
+return Status::RuntimeError(
+fmt::format("unsupported types for function {}({})", 
get_name(),
+
block.get_by_position(arguments[0]).type->get_name()));
+}
+const auto& src_offsets = src_column_array->get_offsets();
+const auto& src_nested_column = src_column_array->get_data();
+
+DataTypePtr src_column_type = 
remove_nullable(block.get_by_position(arguments[0]).type);

Review Comment:
   we use default nullable process logic, input type will not be nullable, no 
need to remove_nullable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] luozenglin commented on a diff in pull request #10533: [feature][tracing] Support query tracing to improve doris observabil…

2022-07-02 Thread GitBox


luozenglin commented on code in PR #10533:
URL: https://github.com/apache/doris/pull/10533#discussion_r912332779


##
be/src/runtime/plan_fragment_executor.cpp:
##
@@ -262,30 +270,36 @@ Status PlanFragmentExecutor::open_vectorized_internal() {
 RETURN_IF_ERROR(_sink->open(runtime_state()));
 }
 
-while (true) {
-doris::vectorized::Block* block;
+{
+telemetry::SpanGuard sink_send_span_guard {};
+while (true) {
+doris::vectorized::Block* block;
 
-{
-SCOPED_CPU_TIMER(_fragment_cpu_timer);
-RETURN_IF_ERROR(get_vectorized_internal(&block));
-}
+{
+SCOPED_CPU_TIMER(_fragment_cpu_timer);
+RETURN_IF_ERROR(get_vectorized_internal(&block));
+}
 
-if (block == NULL) {
-break;
-}
+if (block == NULL) {
+break;
+}
 
-SCOPED_TIMER(profile()->total_time_counter());
-SCOPED_CPU_TIMER(_fragment_cpu_timer);
-// Collect this plan and sub plan statistics, and send to parent plan.
-if (_collect_query_statistics_with_every_batch) {
-_collect_query_statistics();
-}
+SCOPED_TIMER(profile()->total_time_counter());
+SCOPED_CPU_TIMER(_fragment_cpu_timer);
+// Collect this plan and sub plan statistics, and send to parent 
plan.
+if (_collect_query_statistics_with_every_batch) {
+_collect_query_statistics();
+}
 
-auto st = _sink->send(runtime_state(), block);
-if (st.is_end_of_file()) {
-break;
+auto st = _sink->send(runtime_state(), block);
+if (UNLIKELY(!sink_send_span_guard.has_span())) {
+sink_send_span_guard.set_span(_sink->get_send_span());

Review Comment:
   The `_send_span` overrides the first to last call to `send`, and I've 
changed the `sink_send_span_guard` to a more concise code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] wangyf0555 opened a new pull request, #10558: [website](doc)add package-lock.json to resolve docs build failure

2022-07-02 Thread GitBox


wangyf0555 opened a new pull request, #10558:
URL: https://github.com/apache/doris/pull/10558

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10537: [hotfix](dev-1.0.1) fall back to non vec engine for some outer join cases

2022-07-02 Thread GitBox


morningman merged PR #10537:
URL: https://github.com/apache/doris/pull/10537


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch dev-1.0.1 updated: [hotfix](dev-1.0.1) fall back to non vec engine for some outer join cases (#10537)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/dev-1.0.1 by this push:
 new e264ae2a72 [hotfix](dev-1.0.1) fall back to non vec engine for some 
outer join cases (#10537)
e264ae2a72 is described below

commit e264ae2a727b6680689efa060ba32af58108370b
Author: Mingyu Chen 
AuthorDate: Sat Jul 2 15:54:54 2022 +0800

[hotfix](dev-1.0.1) fall back to non vec engine for some outer join cases 
(#10537)
---
 .../java/org/apache/doris/analysis/Analyzer.java   | 236 +
 .../java/org/apache/doris/analysis/SelectStmt.java |  12 +-
 .../java/org/apache/doris/analysis/TableRef.java   |   5 +-
 .../org/apache/doris/planner/OlapScanNode.java |   2 +-
 4 files changed, 163 insertions(+), 92 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
index fa40b57d2b..26bf81e5b2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
@@ -33,6 +33,7 @@ import org.apache.doris.common.ErrorCode;
 import org.apache.doris.common.ErrorReport;
 import org.apache.doris.common.IdGenerator;
 import org.apache.doris.common.Pair;
+import org.apache.doris.common.VecNotImplException;
 import org.apache.doris.common.util.TimeUtils;
 import org.apache.doris.planner.PlanNode;
 import org.apache.doris.planner.RuntimeFilter;
@@ -66,7 +67,6 @@ import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Sets;
-
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
@@ -164,18 +164,27 @@ public class Analyzer {
 isSubquery = true;
 globalState.containsSubquery = true;
 }
+
 public boolean setHasPlanHints() { return globalState.hasPlanHints = true; 
}
+
 public boolean hasPlanHints() { return globalState.hasPlanHints; }
+
 public void setIsWithClause() { isWithClause_ = true; }
+
 public boolean isWithClause() { return isWithClause_; }
-
+
 public void setUDFAllowed(boolean val) { this.isUDFAllowed = val; }
+
 public boolean isUDFAllowed() { return this.isUDFAllowed; }
+
 public void setTimezone(String timezone) { this.timezone = timezone; }
+
 public String getTimezone() { return timezone; }
 
 public void putAssignedRuntimeFilter(RuntimeFilter rf) { 
assignedRuntimeFilters.add(rf); }
+
 public List getAssignedRuntimeFilter() { return 
assignedRuntimeFilters; }
+
 public void clearAssignedRuntimeFilters() { 
assignedRuntimeFilters.clear(); }
 
 public long getAutoBroadcastJoinThreshold() {
@@ -225,6 +234,8 @@ public class Analyzer {
 // to the last Join clause (represented by its rhs table ref) that 
outer-joined it
 private final Map outerJoinedTupleIds = 
Maps.newHashMap();
 
+private final Set outerJoinedMaterializedTupleIds = 
Sets.newHashSet();
+
 // Map of registered conjunct to the last full outer join (represented 
by its
 // rhs table ref) that outer joined it.
 public final Map fullOuterJoinedConjuncts = 
Maps.newHashMap();
@@ -425,6 +436,7 @@ public class Analyzer {
 }
 
 public void setIsExplain() { globalState.isExplain = true; }
+
 public boolean isExplain() { return globalState.isExplain; }
 
 public int incrementCallDepth() {
@@ -450,15 +462,14 @@ public class Analyzer {
 List viewLabels = view.getColLabels();
 List queryStmtLabels = view.getQueryStmt().getColLabels();
 if (viewLabels.size() > queryStmtLabels.size()) {
-throw new AnalysisException("WITH-clause view '" + 
view.getName() +
-"' returns " + queryStmtLabels.size() + " columns, but 
" +
-viewLabels.size() + " labels were specified. The 
number of column " +
-"labels must be smaller or equal to the number of 
returned columns.");
+throw new AnalysisException(
+"WITH-clause view '" + view.getName() + "' returns " + 
queryStmtLabels.size() + " columns, but "
++ viewLabels.size() + " labels were specified. 
The number of column "
++ "labels must be smaller or equal to the 
number of returned columns.");
 }
 }
 if (localViews_.put(view.getName(), view) != null) {
-throw new AnalysisException(
-String.format("Duplicate table alias: '%s'", 
view.getName()));
+throw new AnalysisException(String.format("Duplicate table alias: 
'%s'", view.getName()));
 }
 }
 
@@ -615,11 +626,11 @@ public class Analyzer {
 

[GitHub] [doris] github-actions[bot] commented on pull request #10558: [website](doc)add package-lock.json to resolve docs build failure

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10558:
URL: https://github.com/apache/doris/pull/10558#issuecomment-1172859786

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10558: [website](doc)add package-lock.json to resolve docs build failure

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10558:
URL: https://github.com/apache/doris/pull/10558#issuecomment-1172859782

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10558: [website](doc)add package-lock.json to resolve docs build failure

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10558:
URL: https://github.com/apache/doris/pull/10558#issuecomment-1172863441

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] chenlinzhong opened a new pull request, #10559: [docs] add quick compaction configs

2022-07-02 Thread GitBox


chenlinzhong opened a new pull request, #10559:
URL: https://github.com/apache/doris/pull/10559

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   add quick compaction configs 
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10558: [website](doc)add package-lock.json to resolve docs build failure

2022-07-02 Thread GitBox


morningman merged PR #10558:
URL: https://github.com/apache/doris/pull/10558


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] luwei16 opened a new issue, #10560: [Bug] core dump when run regression case

2022-07-02 Thread GitBox


luwei16 opened a new issue, #10560:
URL: https://github.com/apache/doris/issues/10560

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   master
   
   ### What's Wrong?
   
   
   
   
   *** Aborted at 1656745620 (unix time) try "date -d @1656745620" if you are 
using GNU date ***
   *** SIGSEGV address not mapped to object (@0x8) received by PID 3460756 (TID 
0x7f41dad7d640) from PID 8; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, 
siginfo_t*, void*) at 
/mnt/hdd01/repo_center/doris_master/be/src/common/signal_handler.h:407
1# 0x7F422C5E4040 in /lib/x86_64-linux-gnu/libc.so.6
2# doris::vectorized::VLiteral::debug_string[abi:cxx11]() const at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exprs/vliteral.cpp:186
3# doris::vectorized::VCaseExpr::debug_string[abi:cxx11]() const at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exprs/vcase_expr.cpp:129
4# doris::vectorized::VectorizedFnCall::debug_string[abi:cxx11]() const at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exprs/vectorized_fn_call.cpp:118
5# doris::vectorized::VcompoundPred::debug_string[abi:cxx11]() const at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exprs/vcompound_pred.h:47
6# doris::ScanNode::_peel_pushed_vconjunct[abi:cxx11](doris::RuntimeState*, 
std::function const&) at 
/mnt/hdd01/repo_center/doris_master/be/src/exec/scan_node.cpp:68
7# 
doris::vectorized::VOlapScanNode::remove_pushed_conjuncts(doris::RuntimeState*) 
at /mnt/hdd01/repo_center/doris_master/be/src/vec/exec/volap_scan_node.cpp:1049
8# doris::vectorized::VOlapScanNode::start_scan(doris::RuntimeState*) at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exec/volap_scan_node.cpp:813
9# doris::vectorized::VOlapScanNode::get_next(doris::RuntimeState*, 
doris::vectorized::Block*, bool*) at 
/mnt/hdd01/repo_center/doris_master/be/src/vec/exec/volap_scan_node.cpp:1581
   10# 
doris::PlanFragmentExecutor::get_vectorized_internal(doris::vectorized::Block**)
 at 
/mnt/hdd01/repo_center/doris_master/be/src/runtime/plan_fragment_executor.cpp:321
   11# doris::PlanFragmentExecutor::open_vectorized_internal() at 
/mnt/hdd01/repo_center/doris_master/be/src/runtime/plan_fragment_executor.cpp:270
   12# doris::PlanFragmentExecutor::open() at 
/mnt/hdd01/repo_center/doris_master/be/src/runtime/plan_fragment_executor.cpp:228
   13# doris::FragmentExecState::execute() at 
/mnt/hdd01/repo_center/doris_master/be/src/runtime/fragment_mgr.cpp:242
   14# 
doris::FragmentMgr::_exec_actual(std::shared_ptr, 
std::function) at 
/mnt/hdd01/repo_center/doris_master/be/src/runtime/fragment_mgr.cpp:483
   15# void std::__invoke_impl, 
std::function), doris::FragmentMgr*&, 
std::shared_ptr&, std::function&>(std::__invoke_memfun_deref, void 
(doris::FragmentMgr::*&)(std::shared_ptr, 
std::function), doris::FragmentMgr*&, 
std::shared_ptr&, std::function&) at 
/var/local/ldb_toolchain/include/c++/11/bits/invoke.h:74
   16# std::enable_if, 
std::function), doris::FragmentMgr*&, 
std::shared_ptr&, std::function&>, void>::type std::__invoke_r, 
std::function), doris::FragmentMgr*&, 
std::shared_ptr&, std::function&>(void 
(doris::FragmentMgr::*&)(std::shared_ptr, 
std::function), doris::FragmentMgr*&, 
std::shared_ptr&, std::function&) at 
/var/local/ldb_toolchain/include/c++/11/bits/invoke.h:117
   17# void std::_Bind_result, std::function))(std::shared_ptr, 
std::function)>::__call(std::tuple<>&&, std::_Index_tuple<0ul, 1ul, 2ul>) at 
/var/local/ldb_toolchain/include/c++/11/functional:571
   18# void std::_Bind_result, std::function))(std::shared_ptr, 
std::function)>::operator()<>() at 
/var/local/ldb_toolchain/include/c++/11/functional:631
   19# void std::__invoke_impl, std::function))(std::shared_ptr, 
std::function)>&>(std::__invoke_other, 
std::_Bind_result, std::function))(std::shared_ptr, 
std::function)>&) at 
/var/local/ldb_toolchain/include/c++/11/bits/invoke.h:61
   20# std::enable_if, std::function))(std::shared_ptr, 
std::function)>&>, void>::type 
std::__invoke_r, std::function))(std::shared_ptr, 
std::function)>&>(std::_Bind_result, std::function))(std::shared_ptr, 
std::function)>&) at 
/var/local/ldb_toolchain/include/c++/11/bits/invoke.h:117
   21# std::_Function_handler, std::function))(std::shared_ptr, 
std::function)> 
>::_M_invoke(std::_Any_data const&) at 
/var/local/ldb_toolchain/include/c++/11/bits/std_function.h:292
   22# std::function::operator()() const at 
/var/local/ldb_toolchain/include/c++/11/bits/std_function.h:560
   23# doris::FunctionRunnable::run() at 
/mnt/hdd01/repo_center/doris_master/be/src/util/threadpool.cpp:45
   24# doris::ThreadPool::dispatch_thread() at 
/mnt/hdd01/repo_center/doris_master/be/src/util/threadpool.cpp:548
   25# void std::__invoke_impl(std::__invoke_memfun_deref, void 
(doris::ThreadPool::*&)(), doris::ThreadPool

[GitHub] [doris] github-actions[bot] commented on pull request #9533: [refactor] Refactoring Status static methods to format message using …

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #9533:
URL: https://github.com/apache/doris/pull/9533#issuecomment-1172879144

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #9533: [refactor] Refactoring Status static methods to format message using …

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #9533:
URL: https://github.com/apache/doris/pull/9533#issuecomment-1172879142

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yiguolei merged pull request #9533: [refactor] Refactoring Status static methods to format message using …

2022-07-02 Thread GitBox


yiguolei merged PR #9533:
URL: https://github.com/apache/doris/pull/9533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yiguolei merged pull request #10552: [hot-fix] fix a typo error and limit the max wait time in VOlapTableSink::send

2022-07-02 Thread GitBox


yiguolei merged PR #10552:
URL: https://github.com/apache/doris/pull/10552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch dev-1.0.1 updated: [hot-fix] fix a typo error and limit the max wait time in VOlapTableSink::send (#10552)

2022-07-02 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/dev-1.0.1 by this push:
 new 94a883d68e [hot-fix] fix a typo error and limit the max wait time in 
VOlapTableSink::send (#10552)
94a883d68e is described below

commit 94a883d68eb9deaa0d76960479295fb0fc0e2715
Author: minghong 
AuthorDate: Sat Jul 2 19:01:28 2022 +0800

[hot-fix] fix a typo error and limit the max wait time in 
VOlapTableSink::send (#10552)
---
 be/src/common/config.h   |  3 +++
 be/src/vec/sink/vtablet_sink.cpp | 19 +--
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/be/src/common/config.h b/be/src/common/config.h
index ddee9165b8..3174b445c2 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -721,6 +721,9 @@ CONF_Int32(quick_compaction_batch_size, "10");
 // do compaction min rowsets
 CONF_Int32(quick_compaction_min_rowsets, "10");
 
+//memory limitation for batches in pending queue, default 500M
+CONF_Int64(table_sink_pending_bytes_limitation, "524288000");
+
 } // namespace config
 
 } // namespace doris
diff --git a/be/src/vec/sink/vtablet_sink.cpp b/be/src/vec/sink/vtablet_sink.cpp
index e78fc094aa..c90e3b65b7 100644
--- a/be/src/vec/sink/vtablet_sink.cpp
+++ b/be/src/vec/sink/vtablet_sink.cpp
@@ -117,12 +117,19 @@ Status VOlapTableSink::send(RuntimeState* state, 
vectorized::Block* input_block)
 _partition_to_tablet_map.clear();
 }
 
-//if pending bytes is more than 500M, wait
-constexpr size_t MAX_PENDING_BYTES = 500 * 1024 * 1024;
-if ( get_pending_bytes() > MAX_PENDING_BYTES){
-while(get_pending_bytes() < MAX_PENDING_BYTES){
-std::this_thread::sleep_for(std::chrono::microseconds(500));
-}
+//if pending bytes is more than table_sink_pending_bytes_limitation, wait 
at most 1 min
+size_t MAX_PENDING_BYTES = config::table_sink_pending_bytes_limitation;
+constexpr int max_retry = 120;
+int retry = 0;
+while (get_pending_bytes() > MAX_PENDING_BYTES && retry++ < max_retry) {
+std::this_thread::sleep_for(std::chrono::microseconds(500));
+}
+if (get_pending_bytes() > MAX_PENDING_BYTES) {
+std::stringstream str;
+str << "Load task " << _load_id
+<< ": pending bytes exceed limit 
(config::table_sink_pending_bytes_limitation):"
+<< MAX_PENDING_BYTES;
+return Status::MemoryLimitExceeded(str.str());
 }
 
 for (int i = 0; i < num_rows; ++i) {


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] biandou1313 opened a new issue, #10561: [Bug] doris安装官方文档镜像编译

2022-07-02 Thread GitBox


biandou1313 opened a new issue, #10561:
URL: https://github.com/apache/doris/issues/10561

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   
![1656759930715](https://user-images.githubusercontent.com/34857750/176998077-98ca8808-5129-44c6-9bc0-0e5d17d9b823.png)
   
   
   ### What's Wrong?
   
   
![1656759930715](https://user-images.githubusercontent.com/34857750/176998088-fe851e57-6043-48ec-a09b-a69ca2566f5c.png)
   
   
   ### What You Expected?
   
   编译完成
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] yiguolei commented on a diff in pull request #10136: [Feature] Lightweight schema change of add/drop column

2022-07-02 Thread GitBox


yiguolei commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912351667


##
be/src/olap/tablet.cpp:
##
@@ -1636,4 +1641,13 @@ std::shared_ptr& 
Tablet::get_compaction_mem_tracker(CompactionType c
 }
 }
 
+const TabletSchema& Tablet::tablet_schema() const {
+std::shared_lock wrlock(_meta_lock);
+const RowsetSharedPtr last_rowset = rowset_with_max_version();

Review Comment:
   Currently rowset does not have tablet schema. So tablet schema == null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10521: [feature-wip](multi-catalog) end to end to support multi-catalog

2022-07-02 Thread GitBox


morningman merged PR #10521:
URL: https://github.com/apache/doris/pull/10521


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [feature-wip](multi-catalog) end to end to support multi-catalog (#10521)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 078cb3b4db [feature-wip](multi-catalog) end to end to support 
multi-catalog (#10521)
078cb3b4db is described below

commit 078cb3b4dbc69736521749e779c4947d83591bd7
Author: Ashin Gau 
AuthorDate: Sat Jul 2 20:43:10 2022 +0800

[feature-wip](multi-catalog) end to end to support multi-catalog (#10521)

Get through the previous pull requests that support multi-catalog, and end 
to end to achieve multi-catalog.
---
 .../doris/analysis/AdminCancelRepairTableStmt.java | 16 +-
 .../doris/analysis/AdminCompactTableStmt.java  | 16 +-
 .../doris/analysis/AdminRepairTableStmt.java   | 16 +-
 .../analysis/AdminShowReplicaDistributionStmt.java | 16 +-
 .../doris/analysis/AdminShowReplicaStatusStmt.java | 16 +-
 .../java/org/apache/doris/analysis/Analyzer.java   | 19 ++-
 .../org/apache/doris/analysis/DescribeStmt.java| 64 +-
 .../java/org/apache/doris/analysis/FromClause.java | 32 ---
 .../apache/doris/analysis/FunctionCallExpr.java|  3 +-
 .../org/apache/doris/analysis/SlotDescriptor.java  |  4 +-
 .../java/org/apache/doris/analysis/SlotRef.java|  8 +--
 .../java/org/apache/doris/catalog/Catalog.java | 10 ++--
 .../org/apache/doris/datasource/DataSourceMgr.java | 14 +
 .../doris/datasource/ExternalDataSource.java   |  8 +++
 .../doris/datasource/HMSExternalDataSource.java|  5 +-
 .../apache/doris/httpv2/rest/MetaInfoAction.java   | 13 -
 .../org/apache/doris/planner/HashJoinNode.java | 10 ++--
 .../main/java/org/apache/doris/policy/Policy.java  |  9 ++-
 .../java/org/apache/doris/qe/ConnectContext.java   | 11 +++-
 .../java/org/apache/doris/qe/ConnectProcessor.java |  2 +-
 .../java/org/apache/doris/qe/ShowExecutor.java | 37 +++--
 .../rewrite/mvrewrite/CountDistinctToBitmap.java   |  4 +-
 .../doris/rewrite/mvrewrite/CountFieldToSum.java   |  4 +-
 .../rewrite/mvrewrite/HLLHashToSlotRefRule.java|  4 +-
 .../apache/doris/rewrite/mvrewrite/NDVToHll.java   |  4 +-
 .../rewrite/mvrewrite/ToBitmapToSlotRefRule.java   |  4 +-
 .../apache/doris/service/FrontendServiceImpl.java  |  4 +-
 .../org/apache/doris/analysis/AccessTestUtil.java  | 44 +++
 .../apache/doris/analysis/VirtualSlotRefTest.java  |  4 +-
 .../org/apache/doris/http/DorisHttpTestCase.java   | 23 
 .../org/apache/doris/qe/ConnectProcessorTest.java  |  7 +++
 .../org/apache/doris/qe/PartitionCacheTest.java| 39 ++---
 .../java/org/apache/doris/qe/ShowExecutorTest.java | 23 
 33 files changed, 303 insertions(+), 190 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCancelRepairTableStmt.java
 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCancelRepairTableStmt.java
index 1c6c442615..d1643b72cd 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCancelRepairTableStmt.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCancelRepairTableStmt.java
@@ -18,15 +18,14 @@
 package org.apache.doris.analysis;
 
 import org.apache.doris.catalog.Catalog;
-import org.apache.doris.cluster.ClusterNamespace;
 import org.apache.doris.common.AnalysisException;
 import org.apache.doris.common.ErrorCode;
 import org.apache.doris.common.ErrorReport;
 import org.apache.doris.common.UserException;
+import org.apache.doris.common.util.Util;
 import org.apache.doris.mysql.privilege.PrivPredicate;
 import org.apache.doris.qe.ConnectContext;
 
-import com.google.common.base.Strings;
 import com.google.common.collect.Lists;
 
 import java.util.List;
@@ -48,17 +47,8 @@ public class AdminCancelRepairTableStmt extends DdlStmt {
 
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, 
"ADMIN");
 }
 
-String dbName = null;
-if (Strings.isNullOrEmpty(tblRef.getName().getDb())) {
-dbName = analyzer.getDefaultDb();
-if (Strings.isNullOrEmpty(dbName)) {
-ErrorReport.reportAnalysisException(ErrorCode.ERR_NO_DB_ERROR);
-}
-} else {
-dbName = ClusterNamespace.getFullName(getClusterName(), 
tblRef.getName().getDb());
-}
-
-tblRef.getName().setDb(dbName);
+tblRef.getName().analyze(analyzer);
+Util.prohibitExternalCatalog(tblRef.getName().getCtl(), 
this.getClass().getSimpleName());
 
 PartitionNames partitionNames = tblRef.getPartitionNames();
 if (partitionNames != null) {
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCompactTableStmt.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/AdminCompactTableStmt.java
index d65ad0acff..143aa4daaf 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/analysis/Ad

[GitHub] [doris] morningman commented on a diff in pull request #10555: [feature] support `max_by` and `min_by` on row-based engine

2022-07-02 Thread GitBox


morningman commented on code in PR #10555:
URL: https://github.com/apache/doris/pull/10555#discussion_r912361287


##
be/src/exprs/aggregate_functions.cpp:
##
@@ -363,6 +363,320 @@ struct DecimalV2AvgState {
 int64_t count = 0;
 };
 
+template 
+struct MaxMinByState {
+T val1;
+KT val2;
+bool flag = false;
+};
+
+template 
+struct MaxMinByStateWithString {
+T val1;
+KT val2;
+bool flag = false;
+
+static const int STRING_LENGTH_RECORD_LENGTH = 4;
+StringVal serialize(FunctionContext* ctx) {
+// calculate total serialize buffer length
+int total_serialized_set_length = 1;
+if constexpr (std::is_same_v) {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
((StringVal)val1).len;
+} else {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
sizeof(T);
+}
+
+if constexpr (std::is_same_v) {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
((StringVal)val2).len;
+} else {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
sizeof(KT);
+}
+
+StringVal result(ctx, total_serialized_set_length);
+uint8_t* writer = result.ptr;
+// type
+*writer = flag;
+writer++;
+
+if constexpr (std::is_same_v) {
+*(int*)writer = ((StringVal)val1).len;
+writer += STRING_LENGTH_RECORD_LENGTH;
+memcpy(writer, ((StringVal)val1).ptr, ((StringVal)val1).len);
+writer += ((StringVal)val1).len;
+} else {
+*(int*)writer = sizeof(T);
+writer += STRING_LENGTH_RECORD_LENGTH;
+*(T*)writer = val1;
+writer += sizeof(T);
+}
+
+if constexpr (std::is_same_v) {
+*(int*)writer = ((StringVal)val2).len;
+writer += STRING_LENGTH_RECORD_LENGTH;
+memcpy(writer, ((StringVal)val2).ptr, ((StringVal)val2).len);
+} else {
+*(int*)writer = sizeof(KT);
+writer += STRING_LENGTH_RECORD_LENGTH;
+*(KT*)writer = val2;
+}
+return result;
+}
+
+void deserialize(const StringVal& src) {
+uint8_t* reader = src.ptr;
+// skip type ,no used now
+flag = (bool)*reader;
+reader++;
+const uint8_t* end = src.ptr + src.len;
+
+const int val1_length = *(int*)reader;
+reader += STRING_LENGTH_RECORD_LENGTH;
+
+if constexpr (std::is_same_v) {
+StringVal value((uint8_t*)reader, val1_length);
+val1 = value;
+} else {
+val1 = *(T*)reader;
+}
+reader += val1_length;
+
+const int val2_length = *(int*)reader;
+reader += STRING_LENGTH_RECORD_LENGTH;
+if constexpr (std::is_same_v) {
+StringVal value((uint8_t*)reader, val2_length);
+val2 = value;
+} else {
+val2 = *(KT*)reader;
+}
+reader += val2_length;
+DCHECK(reader == end);
+}
+};
+
+template 
+void AggregateFunctions::maxminby_init(FunctionContext* ctx, StringVal* dst) {
+dst->is_null = false;
+int len;
+if constexpr (std::is_same_v || std::is_same_v) {
+len = sizeof(MaxMinByStateWithString);
+dst->ptr = (uint8_t*)new MaxMinByStateWithString;
+} else {
+len = sizeof(MaxMinByState);
+dst->ptr = (uint8_t*)new MaxMinByState;
+}
+dst->len = len;
+}
+
+template 
+constexpr bool maxminby_compare(T x, T y) {
+if constexpr (max_by_fn) {
+if constexpr (std::is_same_v) {
+return x.to_string() > y.to_string();
+} else if constexpr (std::is_same_v) {
+return x.packed_time > y.packed_time;
+} else {
+return x.val > y.val;
+}
+} else {
+if constexpr (std::is_same_v) {
+return x.to_string() < y.to_string();
+} else if constexpr (std::is_same_v) {
+return x.packed_time < y.packed_time;
+} else {
+return x.val < y.val;
+}
+}
+}
+
+template 
+void AggregateFunctions::maxminby_update(FunctionContext* ctx, const T& slot1, 
const KT& slot2,
+ StringVal* dst) {
+if (slot1.is_null) {
+return;
+}
+DCHECK(dst->ptr != nullptr);
+if constexpr (std::is_same_v || std::is_same_v) {
+DCHECK_EQ(sizeof(MaxMinByStateWithString), dst->len);
+auto max_by = reinterpret_cast*>(dst->ptr);
+
+bool condition = false;
+if constexpr (std::is_same_v) {
+condition = !max_by->flag || maxminby_compare(slot2, max_by->val2);

Review Comment:
   I can't see the difference among these `if else`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits

[GitHub] [doris] github-actions[bot] commented on pull request #10559: [docs] add quick compaction configs

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10559:
URL: https://github.com/apache/doris/pull/10559#issuecomment-1172898065

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10559: [docs] add quick compaction configs

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10559:
URL: https://github.com/apache/doris/pull/10559#issuecomment-1172898076

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman opened a new pull request, #10562: [fix](fe-ut) fix ut compile bug

2022-07-02 Thread GitBox


morningman opened a new pull request, #10562:
URL: https://github.com/apache/doris/pull/10562

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] dataroaring commented on pull request #10280: [Feature] move cold data to object storage without losing any feature

2022-07-02 Thread GitBox


dataroaring commented on PR #10280:
URL: https://github.com/apache/doris/pull/10280#issuecomment-1172904244

   [冷热分离详细设计.pdf](https://github.com/apache/doris/files/9033096/default.pdf) 
@pengxiangyu 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman commented on a diff in pull request #10136: [Feature] Lightweight schema change of add/drop column

2022-07-02 Thread GitBox


morningman commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912365661


##
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##
@@ -4922,4 +4916,190 @@ private static void addTableComment(Table table, 
StringBuilder sb) {
 sb.append("\nCOMMENT 
'").append(table.getComment(true)).append("'");
 }
 }
+
+// the invoker should keep table's write lock
+public void modifyTableAddOrDropColumns(Database db, OlapTable olapTable,

Review Comment:
   Better move this method to `SchemaChangeHandler`, don't make Catalog.java 
too big



##
fe/fe-core/src/main/java/org/apache/doris/persist/OperationType.java:
##
@@ -222,6 +222,8 @@ public class OperationType {
 // policy 310-320
 public static final short OP_CREATE_POLICY = 310;
 public static final short OP_DROP_POLICY = 311;
+//schema change for add and drop columns 320-329
+public static final short OP_MODIFY_TABLE_ADD_OR_DROP_COLUMNS = 320;

Review Comment:
   better put it after `public static final short OP_MODIFY_TABLE_ENGINE = 127;`
   and use `128`



##
fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java:
##
@@ -4922,4 +4916,190 @@ private static void addTableComment(Table table, 
StringBuilder sb) {
 sb.append("\nCOMMENT 
'").append(table.getComment(true)).append("'");
 }
 }
+
+// the invoker should keep table's write lock
+public void modifyTableAddOrDropColumns(Database db, OlapTable olapTable,
+Map> indexSchemaMap,
+List indexes, long jobId, boolean isReplay) throws 
DdlException {
+
+LOG.debug("indexSchemaMap:{}, indexes:{}", indexSchemaMap, indexes);
+if (olapTable.getState() == OlapTableState.ROLLUP) {
+throw new DdlException("Table[" + olapTable.getName() + "]'s is 
doing ROLLUP job");
+}
+
+// for now table's state can only be NORMAL
+Preconditions.checkState(olapTable.getState() == 
OlapTableState.NORMAL, olapTable.getState().name());
+
+// for bitmapIndex
+boolean hasIndexChange = false;
+Set newSet = new HashSet<>(indexes);
+Set oriSet = new HashSet<>(olapTable.getIndexes());
+if (!newSet.equals(oriSet)) {
+hasIndexChange = true;
+}
+
+// begin checking each table
+// ATTN: DO NOT change any meta in this loop
+Map> changedIndexIdToSchema = Maps.newHashMap();
+for (Long alterIndexId : indexSchemaMap.keySet()) {
+// Must get all columns including invisible columns.
+// Because in alter process, all columns must be considered.
+List alterSchema = indexSchemaMap.get(alterIndexId);
+
+LOG.debug("index[{}] is changed. start checking...", alterIndexId);
+// 1. check order: a) has key; b) value after key
+boolean meetValue = false;
+boolean hasKey = false;
+for (Column column : alterSchema) {
+if (column.isKey() && meetValue) {
+throw new DdlException(
+"Invalid column order. value should be after key. 
index[" + olapTable.getIndexNameById(
+alterIndexId) + "]");
+}
+if (!column.isKey()) {
+meetValue = true;
+} else {
+hasKey = true;
+}
+}
+if (!hasKey) {
+throw new DdlException("No key column left. index[" + 
olapTable.getIndexNameById(alterIndexId) + "]");
+}
+
+// 2. check partition key
+PartitionInfo partitionInfo = olapTable.getPartitionInfo();
+if (partitionInfo.getType() == PartitionType.RANGE || 
partitionInfo.getType() == PartitionType.LIST) {
+List partitionColumns = 
partitionInfo.getPartitionColumns();
+for (Column partitionCol : partitionColumns) {
+boolean found = false;
+for (Column alterColumn : alterSchema) {
+if (alterColumn.nameEquals(partitionCol.getName(), 
true)) {
+found = true;
+break;
+}
+} // end for alterColumns
+
+if (!found && alterIndexId == olapTable.getBaseIndexId()) {
+// 2.1 partition column cannot be deleted.
+throw new DdlException(
+"Partition column[" + partitionCol.getName() + 
"] cannot be dropped. index["
++ 
olapTable.getIndexNameById(alterIndexId) + "]");
+}
+} // end for partitionColumns
+}
+
+// 3. check distribution key:
+DistributionInfo distributionInfo = 
olapTable.

[GitHub] [doris] github-actions[bot] commented on pull request #10562: [fix](fe-ut) fix ut compile bug

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10562:
URL: https://github.com/apache/doris/pull/10562#issuecomment-1172906828

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10562: [fix](fe-ut) fix ut compile bug

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10562:
URL: https://github.com/apache/doris/pull/10562#issuecomment-1172906833

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10555: [feature] support `max_by` and `min_by` on row-based engine

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/doris/pull/10555#issuecomment-1172907628

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10555: [feature] support `max_by` and `min_by` on row-based engine

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10555:
URL: https://github.com/apache/doris/pull/10555#issuecomment-1172907634

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Lchangliang commented on a diff in pull request #10136: [Feature] Lightweight schema change of add/drop column

2022-07-02 Thread GitBox


Lchangliang commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912368929


##
gensrc/proto/olap_file.proto:
##
@@ -93,6 +93,8 @@ message RowsetMetaPB {
 optional int64 num_segments = 22;
 // rowset id definition, it will replace required rowset id 
 optional string rowset_id_v2 = 23;
+// tablet meta pb, for compaction
+optional TabletSchemaPB tablet_schema = 24;

Review Comment:
   There are two reasons that RowsetMeta need the new field. 
   1. When compaction, we need to use newset version schema not the schema 
which newest rowset has. The diff is that when a long load is going, the schema 
change, and then a short load begin. When the short load was over faster than 
the long load, the newest schema is the short load rowset has. That's because 
of that segment don't persist the  schema version too.
   2. When we need to use rowset schema,we can read it directly not need to 
read segment footer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Lchangliang commented on a diff in pull request #10136: [Feature] Lightweight schema change of add/drop column

2022-07-02 Thread GitBox


Lchangliang commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912368972


##
be/src/exec/olap_scanner.cpp:
##
@@ -86,6 +88,14 @@ Status OlapScanner::prepare(
 LOG(WARNING) << ss.str();
 return Status::InternalError(ss.str());
 }
+_tablet_schema = _tablet->tablet_schema();

Review Comment:
   VOlapScanner is modified too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Lchangliang commented on a diff in pull request #10136: [Feature] Lightweight schema change of add/drop column

2022-07-02 Thread GitBox


Lchangliang commented on code in PR #10136:
URL: https://github.com/apache/doris/pull/10136#discussion_r912369245


##
be/src/olap/tablet.cpp:
##
@@ -1636,4 +1641,13 @@ std::shared_ptr& 
Tablet::get_compaction_mem_tracker(CompactionType c
 }
 }
 
+const TabletSchema& Tablet::tablet_schema() const {
+std::shared_lock wrlock(_meta_lock);
+const RowsetSharedPtr last_rowset = rowset_with_max_version();

Review Comment:
   the continue code process it. 
   if (last_rowset == nullptr) {
   return _schema;
}
   that will use the schema from BE saves.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman closed issue #10489: [Bug] Unsupported correlated subquery: SELECT

2022-07-02 Thread GitBox


morningman closed issue #10489: [Bug] Unsupported correlated subquery: SELECT
URL: https://github.com/apache/doris/issues/10489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10519: [fix](planner)infer predicate generate infered predicate using wrong information from another scope

2022-07-02 Thread GitBox


morningman merged PR #10519:
URL: https://github.com/apache/doris/pull/10519


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated (078cb3b4db -> 848e0c5987)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


from 078cb3b4db [feature-wip](multi-catalog) end to end to support 
multi-catalog (#10521)
 add 848e0c5987 [fix](planner)infer predicate generate infered predicate 
using wrong information from another scope (#10519)

No new revisions were added by this update.

Summary of changes:
 .../java/org/apache/doris/analysis/SlotRef.java|  2 +-
 .../org/apache/doris/rewrite/InferFiltersRule.java | 83 ++
 .../apache/doris/rewrite/InferFiltersRuleTest.java | 70 ++
 3 files changed, 97 insertions(+), 58 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman commented on pull request #10534: [hotfix](dev-1.0.1) abort load task if pending data exceed limit in table sink

2022-07-02 Thread GitBox


morningman commented on PR #10534:
URL: https://github.com/apache/doris/pull/10534#issuecomment-1172909529

   Resolve by #10552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman closed pull request #10534: [hotfix](dev-1.0.1) abort load task if pending data exceed limit in table sink

2022-07-02 Thread GitBox


morningman closed pull request #10534: [hotfix](dev-1.0.1) abort load task if 
pending data exceed limit in table sink
URL: https://github.com/apache/doris/pull/10534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch master updated: [fix](fe-ut) fix ut compile bug (#10562)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
 new bfaa60b695 [fix](fe-ut) fix ut compile bug (#10562)
bfaa60b695 is described below

commit bfaa60b695c35a2c930566c8fd6678e5d9637208
Author: Mingyu Chen 
AuthorDate: Sat Jul 2 22:54:14 2022 +0800

[fix](fe-ut) fix ut compile bug (#10562)

Introduced from #10306
---
 .../doris/nereids/util/ExpressionUtilsTest.java| 36 ++
 1 file changed, 16 insertions(+), 20 deletions(-)

diff --git 
a/fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java
 
b/fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java
index e60b322804..27d85b5f0b 100644
--- 
a/fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java
+++ 
b/fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java
@@ -37,16 +37,15 @@ public class ExpressionUtilsTest {
 List expressions;
 Expression expr;
 
-expr = PARSER.createExpression("a");
+expr = PARSER.parseExpression("a");
 expressions = ExpressionUtils.extractConjunct(expr);
 Assertions.assertEquals(expressions.size(), 1);
 Assertions.assertEquals(expressions.get(0), expr);
 
-
-expr = PARSER.createExpression("a and b and c");
-Expression a = PARSER.createExpression("a");
-Expression b = PARSER.createExpression("b");
-Expression c = PARSER.createExpression("c");
+expr = PARSER.parseExpression("a and b and c");
+Expression a = PARSER.parseExpression("a");
+Expression b = PARSER.parseExpression("b");
+Expression c = PARSER.parseExpression("c");
 
 expressions = ExpressionUtils.extractConjunct(expr);
 Assertions.assertEquals(expressions.size(), 3);
@@ -55,15 +54,14 @@ public class ExpressionUtilsTest {
 Assertions.assertEquals(expressions.get(2), c);
 
 
-expr = PARSER.createExpression("(a or b) and c and (e or f)");
+expr = PARSER.parseExpression("(a or b) and c and (e or f)");
 expressions = ExpressionUtils.extractConjunct(expr);
-Expression aOrb = PARSER.createExpression("a or b");
-Expression eOrf = PARSER.createExpression("e or f");
+Expression aOrb = PARSER.parseExpression("a or b");
+Expression eOrf = PARSER.parseExpression("e or f");
 Assertions.assertEquals(expressions.size(), 3);
 Assertions.assertEquals(expressions.get(0), aOrb);
 Assertions.assertEquals(expressions.get(1), c);
 Assertions.assertEquals(expressions.get(2), eOrf);
-
 }
 
 @Test
@@ -71,16 +69,15 @@ public class ExpressionUtilsTest {
 List expressions;
 Expression expr;
 
-expr = PARSER.createExpression("a");
+expr = PARSER.parseExpression("a");
 expressions = ExpressionUtils.extractDisjunct(expr);
 Assertions.assertEquals(expressions.size(), 1);
 Assertions.assertEquals(expressions.get(0), expr);
 
-
-expr = PARSER.createExpression("a or b or c");
-Expression a = PARSER.createExpression("a");
-Expression b = PARSER.createExpression("b");
-Expression c = PARSER.createExpression("c");
+expr = PARSER.parseExpression("a or b or c");
+Expression a = PARSER.parseExpression("a");
+Expression b = PARSER.parseExpression("b");
+Expression c = PARSER.parseExpression("c");
 
 expressions = ExpressionUtils.extractDisjunct(expr);
 Assertions.assertEquals(expressions.size(), 3);
@@ -88,11 +85,10 @@ public class ExpressionUtilsTest {
 Assertions.assertEquals(expressions.get(1), b);
 Assertions.assertEquals(expressions.get(2), c);
 
-
-expr = PARSER.createExpression("(a and b) or c or (e and f)");
+expr = PARSER.parseExpression("(a and b) or c or (e and f)");
 expressions = ExpressionUtils.extractDisjunct(expr);
-Expression aAndb = PARSER.createExpression("a and b");
-Expression eAndf = PARSER.createExpression("e and f");
+Expression aAndb = PARSER.parseExpression("a and b");
+Expression eAndf = PARSER.parseExpression("e and f");
 Assertions.assertEquals(expressions.size(), 3);
 Assertions.assertEquals(expressions.get(0), aAndb);
 Assertions.assertEquals(expressions.get(1), c);


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10562: [fix](fe-ut) fix ut compile bug

2022-07-02 Thread GitBox


morningman merged PR #10562:
URL: https://github.com/apache/doris/pull/10562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Lchangliang opened a new issue, #10563: [Bug] select default value error when enable_vectorized_engine = true

2022-07-02 Thread GitBox


Lchangliang opened a new issue, #10563:
URL: https://github.com/apache/doris/issues/10563

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   master
   
   ### What's Wrong?
   
   CREATE TABLE schema_change_update_regression_test (
   `user_id` LARGEINT NOT NULL COMMENT "用户id",
   `date` DATE NOT NULL COMMENT "数据灌入日期时间",
   `city` VARCHAR(20) COMMENT "用户所在城市",
   `age` SMALLINT COMMENT "用户年龄",
   `sex` TINYINT COMMENT "用户性别",
   `last_visit_date` DATETIME DEFAULT "1970-01-01 00:00:00" 
COMMENT "用户最后一次访问时间",
   `last_update_date` DATETIME DEFAULT "1970-01-01 00:00:00" 
COMMENT "用户最后一次更新时间",
   `last_visit_date_not_null` DATETIME NOT NULL DEFAULT 
"1970-01-01 00:00:00" COMMENT "用户最后一次访问时间",
   `cost` BIGINT DEFAULT "0" COMMENT "用户总消费",
   `max_dwell_time` INT DEFAULT "0" COMMENT "用户最大停留时间",
   `min_dwell_time` INT DEFAULT "9" COMMENT "用户最小停留时间")
   UNIQUE KEY(`user_id`, `date`, `city`, `age`, `sex`) DISTRIBUTED 
BY HASH(`user_id`)
   PROPERTIES ( "replication_num" = "1" );
   
   INSERT INTO schema_change_update_regression_test VALUES
(1, '2017-10-01', 'Beijing', 10, 1, '2020-01-01', '2020-01-01', 
'2020-01-01', 1, 30, 20);
   
   INSERT INTO schema_change_update_regression_test VALUES
(2, '2017-10-01', 'Beijing', 10, 1, '2020-01-02', '2020-01-02', 
'2020-01-02', 1, 31, 21);
   
   ALTER table schema_change_update_regression_test ADD COLUMN new_column INT 
default "1";
   
   SELECT * FROM schema_change_update_regression_test order by user_id DESC, 
last_visit_date;
   
   
   
+-++-+--+--+-+-+--+--++++
   | user_id | date   | city| age  | sex  | last_visit_date | 
last_update_date| last_visit_date_not_null | cost | max_dwell_time | 
min_dwell_time | new_column |
   
+-++-+--+--+-+-+--+--++++
   | 2   | 2017-10-01 | Beijing |   10 |1 | 2020-01-02 00:00:00 | 
2020-01-02 00:00:00 | 2020-01-02 00:00:00  |1 | 31 |
 21 |  1 |
   | 1   | 2017-10-01 | Beijing |   10 |1 | 2020-01-01 00:00:00 | 
2020-01-01 00:00:00 | 2020-01-01 00:00:00  |1 | 30 |
 20 |  0 |
   
+-++-+--+--+-+-+--+--++++
   
   
   new_column should be '1'.
   
   ### What You Expected?
   
   default value is correct.
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch dev-1.0.1 updated (94a883d68e -> 70354f2f4d)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git


from 94a883d68e [hot-fix] fix a typo error and limit the max wait time in 
VOlapTableSink::send (#10552)
 new 378a5a3a4e [fix](proc) Fix show proc '/current_query_stmts' error due 
to wrong index for execTime (#10488)
 new dcb66e084f [bugfix]fix core dump on outfile with expr (#10491)
 new 70354f2f4d [fix](planner)infer predicate generate infered predicate 
using wrong information from another scope (#10519)

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 be/src/vec/runtime/vfile_result_writer.cpp | 34 +---
 be/src/vec/runtime/vfile_result_writer.h   | 14 ++--
 be/src/vec/sink/vresult_file_sink.cpp  | 13 ++--
 be/src/vec/sink/vresult_file_sink.h| 18 ++---
 .../java/org/apache/doris/analysis/SlotRef.java|  2 +-
 .../proc/CurrentQueryStatementsProcNode.java   |  2 +-
 .../org/apache/doris/common/proc/TrashProcDir.java |  4 +-
 .../org/apache/doris/rewrite/InferFiltersRule.java | 90 ++
 .../apache/doris/rewrite/InferFiltersRuleTest.java | 70 +
 9 files changed, 147 insertions(+), 100 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] 02/03: [bugfix]fix core dump on outfile with expr (#10491)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit dcb66e084fa58a9c6ce797f961dfac2fbc430fc3
Author: Pxl <952130...@qq.com>
AuthorDate: Wed Jun 29 20:38:49 2022 +0800

[bugfix]fix core dump on outfile with expr (#10491)

remove log
---
 be/src/vec/runtime/vfile_result_writer.cpp | 34 +++---
 be/src/vec/runtime/vfile_result_writer.h   | 14 ++--
 be/src/vec/sink/vresult_file_sink.cpp  | 13 ++--
 be/src/vec/sink/vresult_file_sink.h| 18 
 4 files changed, 45 insertions(+), 34 deletions(-)

diff --git a/be/src/vec/runtime/vfile_result_writer.cpp 
b/be/src/vec/runtime/vfile_result_writer.cpp
index 71a748e565..6d4ecb8db1 100644
--- a/be/src/vec/runtime/vfile_result_writer.cpp
+++ b/be/src/vec/runtime/vfile_result_writer.cpp
@@ -17,6 +17,7 @@
 
 #include "vec/runtime/vfile_result_writer.h"
 
+#include "common/status.h"
 #include "exprs/expr_context.h"
 #include "gutil/strings/numbers.h"
 #include "gutil/strings/substitute.h"
@@ -35,22 +36,23 @@
 #include "util/mysql_global.h"
 #include "util/mysql_row_buffer.h"
 #include "vec/core/block.h"
+#include "vec/exprs/vexpr.h"
+#include "vec/exprs/vexpr_context.h"
 
 namespace doris::vectorized {
 const size_t VFileResultWriter::OUTSTREAM_BUFFER_SIZE_BYTES = 1024 * 1024;
 using doris::operator<<;
 
-VFileResultWriter::VFileResultWriter(const ResultFileOptions* file_opts,
- const TStorageBackendType::type 
storage_type,
- const TUniqueId fragment_instance_id,
- const std::vector& 
output_expr_ctxs,
- RuntimeProfile* parent_profile, 
BufferControlBlock* sinker,
- Block* output_block, bool 
output_object_data,
- const RowDescriptor& 
output_row_descriptor)
+VFileResultWriter::VFileResultWriter(
+const ResultFileOptions* file_opts, const TStorageBackendType::type 
storage_type,
+const TUniqueId fragment_instance_id,
+const std::vector& output_vexpr_ctxs,
+RuntimeProfile* parent_profile, BufferControlBlock* sinker, Block* 
output_block,
+bool output_object_data, const RowDescriptor& output_row_descriptor)
 : _file_opts(file_opts),
   _storage_type(storage_type),
   _fragment_instance_id(fragment_instance_id),
-  _output_expr_ctxs(output_expr_ctxs),
+  _output_vexpr_ctxs(output_vexpr_ctxs),
   _parent_profile(parent_profile),
   _sinker(sinker),
   _output_block(output_block),
@@ -196,7 +198,16 @@ Status VFileResultWriter::append_block(Block& block) {
 if (_parquet_writer != nullptr) {
 return Status::NotSupported("Parquet Writer is not supported yet!");
 } else {
-RETURN_IF_ERROR(_write_csv_file(block));
+Status status = Status::OK();
+// Exec vectorized expr here to speed up, block.rows() == 0 means expr 
exec
+// failed, just return the error status
+auto output_block = 
VExprContext::get_output_block_after_execute_exprs(_output_vexpr_ctxs,
+   
block, status);
+auto num_rows = output_block.rows();
+if (UNLIKELY(num_rows == 0)) {
+return status;
+}
+RETURN_IF_ERROR(_write_csv_file(output_block));
 }
 
 _written_rows += block.rows();
@@ -210,7 +221,7 @@ Status VFileResultWriter::_write_csv_file(const Block& 
block) {
 if (col.column->is_null_at(i)) {
 _plain_text_outstream << NULL_IN_CSV;
 } else {
-switch (_output_expr_ctxs[col_id]->root()->type().type) {
+switch (_output_vexpr_ctxs[col_id]->root()->type().type) {
 case TYPE_BOOLEAN:
 case TYPE_TINYINT:
 _plain_text_outstream << (int)*reinterpret_cast(
@@ -280,8 +291,7 @@ Status VFileResultWriter::_write_csv_file(const Block& 
block) {
 reinterpret_cast(col.column->get_data_at(i).data)
 ->value);
 std::string decimal_str;
-int output_scale = 
_output_expr_ctxs[col_id]->root()->output_scale();
-decimal_str = decimal_val.to_string(output_scale);
+decimal_str = decimal_val.to_string();
 _plain_text_outstream << decimal_str;
 break;
 }
diff --git a/be/src/vec/runtime/vfile_result_writer.h 
b/be/src/vec/runtime/vfile_result_writer.h
index b7fd2cd737..5f0bb7971e 100644
--- a/be/src/vec/runtime/vfile_result_writer.h
+++ b/be/src/vec/runtime/vfile_result_writer.h
@@ -30,22 +30,22 @@ public:
 VFileResultWriter

[doris] 03/03: [fix](planner)infer predicate generate infered predicate using wrong information from another scope (#10519)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 70354f2f4d4edce7a0d624bd0eb4b90dfbecdf44
Author: morrySnow <101034200+morrys...@users.noreply.github.com>
AuthorDate: Sat Jul 2 22:41:04 2022 +0800

[fix](planner)infer predicate generate infered predicate using wrong 
information from another scope (#10519)

This PR fix a bug in predicate inference.

The original predicate inference compare two slot without SlotId. This will 
arise an error when a query has SetOperand and more than one SetOperand's child 
use same table alias. e.g.

```
select * from tb1 inner join tb2 on tb1.k1 = tb2.k1
union
select * from tb1 inner join tb2 on tb1.k2 = tb2.k2 where tb1.k1 = 3;
```

in this case, we infer a predicate `tb2.k1 = 3` on table 'tbl2' of 
SetOperand's second child by mistake.
---
 .../java/org/apache/doris/analysis/SlotRef.java|  2 +-
 .../org/apache/doris/rewrite/InferFiltersRule.java | 90 ++
 .../apache/doris/rewrite/InferFiltersRuleTest.java | 70 +
 3 files changed, 99 insertions(+), 63 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java 
b/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
index f2f87e0586..09c6138a6d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java
@@ -303,7 +303,7 @@ public class SlotRef extends Expr {
 if ((col == null) != (other.col == null)) {
 return false;
 }
-if (col != null && !col.toLowerCase().equals(other.col.toLowerCase())) 
{
+if (col != null && !col.equalsIgnoreCase(other.col)) {
 return false;
 }
 return true;
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/InferFiltersRule.java 
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/InferFiltersRule.java
index 47f8153485..c83d3b94c8 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/rewrite/InferFiltersRule.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/rewrite/InferFiltersRule.java
@@ -44,6 +44,8 @@ import java.util.Map;
 
 /**
  * The function of this rule is to derive a new predicate based on the current 
predicate.
+ *
+ * 
  * eg.
  * t1.id = t2.id and t2.id = t3.id and t3.id = 100;
  * -->
@@ -52,8 +54,9 @@ import java.util.Map;
  * 1. Register a new rule InferFiltersRule and add it to GlobalState.
  * 2. Traverse Conjunct to construct on/where equivalence connection, 
numerical connection and isNullPredicate.
  * 3. Use Warshall to infer all equivalence connections.
- *details:https://en.wikipedia.org/wiki/Floyd%E2%80%93Warshall_algorithm
+ *details: https://en.wikipedia.org/wiki/Floyd%E2%80%93Warshall_algorithm
  * 4. Construct additional numerical connections and isNullPredicate.
+ * 
  */
 public class InferFiltersRule implements ExprRewriteRule {
 private final static Logger LOG = 
LogManager.getLogger(InferFiltersRule.class);
@@ -127,10 +130,10 @@ public class InferFiltersRule implements ExprRewriteRule {
 
 if (!newExprWithState.isEmpty()) {
 Expr rewriteExpr = expr;
-for (int index = 0; index < newExprWithState.size(); index++) {
-if (newExprWithState.get(index).second) {
-rewriteExpr = new 
CompoundPredicate(CompoundPredicate.Operator.AND,
-rewriteExpr, newExprWithState.get(index).first);
+for (Pair exprBooleanPair : newExprWithState) {
+if (exprBooleanPair.second) {
+rewriteExpr = new 
CompoundPredicate(CompoundPredicate.Operator.AND, rewriteExpr,
+exprBooleanPair.first);
 }
 }
 return rewriteExpr;
@@ -169,9 +172,9 @@ public class InferFiltersRule implements ExprRewriteRule {
 }
 
 if (conjunct instanceof BinaryPredicate
-&& conjunct.getChild(0) != null
-&& conjunct.getChild(1) != null) {
-if (conjunct.getChild(0).unwrapSlotRef() instanceof SlotRef
+&& conjunct.getChild(0) != null
+&& conjunct.getChild(1) != null) {
+if (conjunct.getChild(0).unwrapSlotRef() != null
 && conjunct.getChild(1) instanceof LiteralExpr) {
 Pair pair = new 
Pair<>(conjunct.getChild(0).unwrapSlotRef(), conjunct.getChild(1));
 if (!slotToLiteralDeDuplication.contains(pair)) {
@@ -184,8 +187,8 @@ public class InferFiltersRule implements ExprRewriteRule {
 analyzer.registerGlobalSlotToLiteralDeDuplication(pair);
 }
 } else if (((BinaryPredicate) conjunct).getOp().isEquivalence()
-&& conjunct.getChild(0).unwrapSlotRef() instanceof SlotRef
-

[doris] 01/03: [fix](proc) Fix show proc '/current_query_stmts' error due to wrong index for execTime (#10488)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git

commit 378a5a3a4e14b3280d37c2092a8fb7c83709c3d3
Author: caiconghui <55968745+caicong...@users.noreply.github.com>
AuthorDate: Wed Jun 29 17:41:47 2022 +0800

[fix](proc) Fix show proc '/current_query_stmts' error due to wrong index 
for execTime (#10488)

Co-authored-by: caiconghui1 
---
 .../org/apache/doris/common/proc/CurrentQueryStatementsProcNode.java  | 2 +-
 .../src/main/java/org/apache/doris/common/proc/TrashProcDir.java  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryStatementsProcNode.java
 
b/fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryStatementsProcNode.java
index 3b0474d9b0..e9ccb9c3e3 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryStatementsProcNode.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/common/proc/CurrentQueryStatementsProcNode.java
@@ -35,7 +35,7 @@ public class CurrentQueryStatementsProcNode implements 
ProcNodeInterface {
 .add("QueryId").add("ConnectionId").add("Database").add("User")
 .add("ExecTime").add("SqlHash").add("Statement").build();
 
-private static final int EXEC_TIME_INDEX = 5;
+private static final int EXEC_TIME_INDEX = 4;
 
 @Override
 public ProcResult fetchResult() throws AnalysisException {
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java 
b/fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java
index 493ce936cc..b54f6f8aa9 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/common/proc/TrashProcDir.java
@@ -94,9 +94,9 @@ public class TrashProcDir implements ProcDirInterface {
 }
 }
 
-List backendInfo = new ArrayList();
+List backendInfo = new ArrayList<>();
 backendInfo.add(String.valueOf(backend.getId()));
-backendInfo.add(backend.getHost() + ":" + 
String.valueOf(backend.getHeartbeatPort()));
+backendInfo.add(backend.getHost() + ":" + 
backend.getHeartbeatPort());
 if (trashUsedCapacityB != null) {
 Pair trashUsedCapacity = 
DebugUtil.getByteUint(trashUsedCapacityB);
 
backendInfo.add(DebugUtil.DECIMAL_FORMAT_SCALE_3.format(trashUsedCapacity.first)
 + " "


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] mrhhsg opened a new pull request, #10564: [improvement]No need to memset flags for vectorization predicates

2022-07-02 Thread GitBox


mrhhsg opened a new pull request, #10564:
URL: https://github.com/apache/doris/pull/10564

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Every calling of `evaluate_vec` will set every item of flags, so there is no 
need to memset the flags.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] morningman merged pull request #10555: [hotfix][feature](dev-1.0.1) support `max_by` and `min_by` on row-based engine

2022-07-02 Thread GitBox


morningman merged PR #10555:
URL: https://github.com/apache/doris/pull/10555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[doris] branch dev-1.0.1 updated: [hotfix][feature](dev-1.0.1) support `max_by` and `min_by` on row-based engine (#10555)

2022-07-02 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/dev-1.0.1 by this push:
 new c89166ffd4 [hotfix][feature](dev-1.0.1) support `max_by` and `min_by` 
on row-based engine (#10555)
c89166ffd4 is described below

commit c89166ffd4ee2fa5b6cbbea0ed909741eb2a39af
Author: Gabriel 
AuthorDate: Sat Jul 2 23:33:11 2022 +0800

[hotfix][feature](dev-1.0.1) support `max_by` and `min_by` on row-based 
engine (#10555)

This is because in previous, we only implement `max/min_by` function in vec 
engine.
But the vec is not working well will outer join operation for now, so use 
can not use
`max/min_by` with outer join in vec engine.

So I implement the `max/min_by` in non-vec engine so that user can use it 
in non-vec.
This is just a compromise way and I just push it to dev-1.0.1 branch.

We are still working on supporting outer join in vec engine in master 
branch.
So maybe I will not push this implement to master branch.
---
 be/src/exprs/aggregate_functions.cpp   | 441 -
 be/src/exprs/aggregate_functions.h |  14 +
 .../org/apache/doris/analysis/AggregateInfo.java   |   5 +-
 .../java/org/apache/doris/catalog/FunctionSet.java | 167 +++-
 4 files changed, 608 insertions(+), 19 deletions(-)

diff --git a/be/src/exprs/aggregate_functions.cpp 
b/be/src/exprs/aggregate_functions.cpp
index 3e2f4b3fe5..885c52d5fe 100644
--- a/be/src/exprs/aggregate_functions.cpp
+++ b/be/src/exprs/aggregate_functions.cpp
@@ -363,6 +363,295 @@ struct DecimalV2AvgState {
 int64_t count = 0;
 };
 
+template 
+struct MaxMinByState {
+T val1;
+KT val2;
+bool flag = false;
+};
+
+template 
+struct MaxMinByStateWithString {
+T val1;
+KT val2;
+bool flag = false;
+
+static const int STRING_LENGTH_RECORD_LENGTH = 4;
+StringVal serialize(FunctionContext* ctx) {
+// calculate total serialize buffer length
+int total_serialized_set_length = 1;
+if constexpr (std::is_same_v) {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
((StringVal)val1).len;
+} else {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
sizeof(T);
+}
+
+if constexpr (std::is_same_v) {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
((StringVal)val2).len;
+} else {
+total_serialized_set_length += STRING_LENGTH_RECORD_LENGTH + 
sizeof(KT);
+}
+
+StringVal result(ctx, total_serialized_set_length);
+uint8_t* writer = result.ptr;
+// type
+*writer = flag;
+writer++;
+
+if constexpr (std::is_same_v) {
+*(int*)writer = ((StringVal)val1).len;
+writer += STRING_LENGTH_RECORD_LENGTH;
+memcpy(writer, ((StringVal)val1).ptr, ((StringVal)val1).len);
+writer += ((StringVal)val1).len;
+} else {
+*(int*)writer = sizeof(T);
+writer += STRING_LENGTH_RECORD_LENGTH;
+*(T*)writer = val1;
+writer += sizeof(T);
+}
+
+if constexpr (std::is_same_v) {
+*(int*)writer = ((StringVal)val2).len;
+writer += STRING_LENGTH_RECORD_LENGTH;
+memcpy(writer, ((StringVal)val2).ptr, ((StringVal)val2).len);
+} else {
+*(int*)writer = sizeof(KT);
+writer += STRING_LENGTH_RECORD_LENGTH;
+*(KT*)writer = val2;
+}
+return result;
+}
+
+void deserialize(const StringVal& src) {
+uint8_t* reader = src.ptr;
+// skip type ,no used now
+flag = (bool)*reader;
+reader++;
+const uint8_t* end = src.ptr + src.len;
+
+const int val1_length = *(int*)reader;
+reader += STRING_LENGTH_RECORD_LENGTH;
+
+if constexpr (std::is_same_v) {
+StringVal value((uint8_t*)reader, val1_length);
+val1 = value;
+} else {
+val1 = *(T*)reader;
+}
+reader += val1_length;
+
+const int val2_length = *(int*)reader;
+reader += STRING_LENGTH_RECORD_LENGTH;
+if constexpr (std::is_same_v) {
+StringVal value((uint8_t*)reader, val2_length);
+val2 = value;
+} else {
+val2 = *(KT*)reader;
+}
+reader += val2_length;
+DCHECK(reader == end);
+}
+};
+
+template 
+void AggregateFunctions::maxminby_init(FunctionContext* ctx, StringVal* dst) {
+dst->is_null = false;
+int len;
+if constexpr (std::is_same_v || std::is_same_v) {
+len = sizeof(MaxMinByStateWithString);
+dst->ptr = (uint8_t*)new MaxMinByStateWithString;
+} else {
+len = sizeof(MaxMinByState);
+dst->ptr = (uint8_t*)new MaxMinByState;
+  

[GitHub] [doris] stalary opened a new pull request, #10565: [feature-wip](multi-catalog) Support es datasource

2022-07-02 Thread GitBox


stalary opened a new pull request, #10565:
URL: https://github.com/apache/doris/pull/10565

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Support es datasource, This PR supports query index related metadata.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 opened a new issue, #10566: [BUG] fix bug in literal `debug_string` when literal is null

2022-07-02 Thread GitBox


Gabriel39 opened a new issue, #10566:
URL: https://github.com/apache/doris/issues/10566

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   master
   
   ### What's Wrong?
   
   core dump in literal `debug_string` when literal is null
   
   ### What You Expected?
   
   fixed
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 opened a new pull request, #10567: [BUG] fix bug in literal `debug_string` when literal is null

2022-07-02 Thread GitBox


Gabriel39 opened a new pull request, #10567:
URL: https://github.com/apache/doris/pull/10567

   # Proposed changes
   
   Issue Number: close #10566
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 opened a new issue, #10568: [Enhancement] turn off java-udf by default when compliling in parallel

2022-07-02 Thread GitBox


Gabriel39 opened a new issue, #10568:
URL: https://github.com/apache/doris/issues/10568

   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Description
   
   we should only turn on java-udf when users specify java-udf explicitly.
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] Gabriel39 opened a new pull request, #10569: [Compile] turn off java-udf by default when compliling in parallel

2022-07-02 Thread GitBox


Gabriel39 opened a new pull request, #10569:
URL: https://github.com/apache/doris/pull/10569

   # Proposed changes
   
   Issue Number: close #10568
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10569: [Compile] turn off java-udf by default when compliling in parallel

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10569:
URL: https://github.com/apache/doris/pull/10569#issuecomment-1173001071

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [doris] github-actions[bot] commented on pull request #10569: [Compile] turn off java-udf by default when compliling in parallel

2022-07-02 Thread GitBox


github-actions[bot] commented on PR #10569:
URL: https://github.com/apache/doris/pull/10569#issuecomment-1173001074

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org