[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10240: [Refactor](nereids) Abstract interface of statistics framework for new optimizer reuse
Kikyou1997 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900717225
##
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##
@@ -353,6 +327,11 @@ public List getConjuncts() {
return conjuncts;
}
+@Override
+public List getChildrenStats() {
+return children;
Review Comment:
It chould get StatsDeriveResult by `PlanStats::getStatsDeriveResult`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10240: [Refactor](nereids) Abstract interface of statistics framework for new optimizer reuse
Kikyou1997 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900735138
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ExprId.java:
##
@@ -17,13 +17,15 @@
package org.apache.doris.nereids.trees.expressions;
+import org.apache.doris.common.Id;
+
import java.util.Objects;
import java.util.UUID;
/**
* UUID for Expression in Nereids.
*/
-public class ExprId {
+public class ExprId extends Id {
private final long id;
private final UUID jvmId;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10240: [Refactor](nereids) Abstract interface of statistics framework for new optimizer reuse
Kikyou1997 commented on code in PR #10240:
URL: https://github.com/apache/doris/pull/10240#discussion_r900735365
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ExprId.java:
##
@@ -17,13 +17,15 @@
package org.apache.doris.nereids.trees.expressions;
+import org.apache.doris.common.Id;
+
import java.util.Objects;
import java.util.UUID;
/**
* UUID for Expression in Nereids.
*/
-public class ExprId {
+public class ExprId extends Id {
private final long id;
private final UUID jvmId;
Review Comment:
And removed the jvmId by the way
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/PlaceHolderPlan.java:
##
@@ -81,4 +85,34 @@ public PlaceHolderPlan withChildren(List children) {
Preconditions.checkArgument(children.size() == 0);
return new PlaceHolderPlan(logicalProperties);
}
+
+@Override
+public List getChildrenStats() {
+return null;
+}
+
+@Override
+public StatsDeriveResult getStatsDeriveResult() {
+return null;
+}
+
+@Override
+public StatisticalType getNodeType() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] chovy-3012 commented on issue #10229: [UserCase] User list collection
chovy-3012 commented on issue #10229: URL: https://github.com/apache/doris/issues/10229#issuecomment-1159404849 ![Uploading aispeech-logo.png…]() 思必驰 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10127: [Bug] Fix heap-use-after-free when using type array
github-actions[bot] commented on PR #10127: URL: https://github.com/apache/doris/pull/10127#issuecomment-1159415209 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10127: [Bug] Fix heap-use-after-free when using type array
github-actions[bot] commented on PR #10127: URL: https://github.com/apache/doris/pull/10127#issuecomment-1159415238 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris-website] branch master updated: 2
This is an automated email from the ASF dual-hosted git repository. jiafengzheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new d34bba96fde 2 d34bba96fde is described below commit d34bba96fde06a4a81f2db603c6f4a6ca6d0 Author: jiafeng.zhang AuthorDate: Sat Jun 18 19:06:10 2022 +0800 2 2 --- blogs/en/ReleaseNote/Announcing.md| 2 +- blogs/zh-CN/ReleaseNote/Announcing.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/blogs/en/ReleaseNote/Announcing.md b/blogs/en/ReleaseNote/Announcing.md index d7122949128..d7c4cc73133 100644 --- a/blogs/en/ReleaseNote/Announcing.md +++ b/blogs/en/ReleaseNote/Announcing.md @@ -70,7 +70,7 @@ Once again, we sincerely thank all contributors who participated in the construc **Apache Doris GitHub：** -[https://github.com/apache/incubator-doris](https://github.com/apache/incubator-doris) +[doris](https://github.com/apache/doris) **Apache Doris website:** diff --git a/blogs/zh-CN/ReleaseNote/Announcing.md b/blogs/zh-CN/ReleaseNote/Announcing.md index b61a5192799..a9cee35efa9 100644 --- a/blogs/zh-CN/ReleaseNote/Announcing.md +++ b/blogs/zh-CN/ReleaseNote/Announcing.md @@ -70,7 +70,7 @@ Apache Doris 后续将开展更多富有挑战且有意义的工作，包括新 **Apache Doris GitHub：** -[https://github.com/apache/incubator-doris](https://github.com/apache/incubator-doris) +[doris](https://github.com/apache/doris) **Apache Doris website:** - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10244: [BENCHMARK] Change all `replication_num` to 1 for TPCH tables
github-actions[bot] commented on PR #10244: URL: https://github.com/apache/doris/pull/10244#issuecomment-1159445846 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10244: [BENCHMARK] Change all `replication_num` to 1 for TPCH tables
github-actions[bot] commented on PR #10244: URL: https://github.com/apache/doris/pull/10244#issuecomment-1159445853 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10243: [typo] Replace some comments in product code
github-actions[bot] commented on PR #10243: URL: https://github.com/apache/doris/pull/10243#issuecomment-1159446016 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10243: [typo] Replace some comments in product code
github-actions[bot] commented on PR #10243: URL: https://github.com/apache/doris/pull/10243#issuecomment-1159446024 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10242: [typo](docs) Modify the link in the develop documentation
github-actions[bot] commented on PR #10242: URL: https://github.com/apache/doris/pull/10242#issuecomment-1159446139 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10242: [typo](docs) Modify the link in the develop documentation
github-actions[bot] commented on PR #10242: URL: https://github.com/apache/doris/pull/10242#issuecomment-1159446147 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yankee24 opened a new pull request, #10245: [typo](docs) Remove docker-doris in developer
Yankee24 opened a new pull request, #10245: URL: https://github.com/apache/doris/pull/10245 ## Problem Summary: Delete docker-doris in developer because it is outdated and duplicates compilation.md in the documentation. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No) 3. Has document been added or modified: (Yes) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10237: [chore] update fe check style workflow to required
morningman merged PR #10237: URL: https://github.com/apache/doris/pull/10237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [chore] update fe checkstyle workflow to required (#10237)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 534844ead6 [chore] update fe checkstyle workflow to required (#10237) 534844ead6 is described below commit 534844ead6e9888b33d6068c667b02803ab675d7 Author: morrySnow <101034200+morrys...@users.noreply.github.com> AuthorDate: Sat Jun 18 21:32:28 2022 +0800 [chore] update fe checkstyle workflow to required (#10237) --- .asf.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.asf.yaml b/.asf.yaml index ad8c40c072..f4405c31a8 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -41,6 +41,7 @@ github: - P0 regression (Doris P0 Regression) - FE UT (Doris FE UT) - BE UT (Doris BE UT) + - CheckStyle required_pull_request_reviews: dismiss_stale_reviews: true - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] Yankee24 commented on pull request #10245: [typo](docs) Remove docker-doris in developer
Yankee24 commented on PR #10245: URL: https://github.com/apache/doris/pull/10245#issuecomment-1159469758 There may be some minor issues with direct deletion, and finally decided to delete some outdated content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau opened a new pull request, #10246: [feature-wip](multi-catalog) add CatalogPrivTable to support unified authority management of datalake
AshinGau opened a new pull request, #10246: URL: https://github.com/apache/doris/pull/10246 # Proposed changes Issue Number: close #xxx ## Problem Summary: Support unified authority management of datalake. Supported: 1. Change FeMetaVersion to 111, compatible with upgrade from 110. 2. Add catalog level privileges, and degrade global level privileges to catalog level if FeMetaVersion < 111. 3. Support 'show all grants', 'show roles' statement. 4. Previous version of SQL syntax. Todo: 1. three-segement format catalog.database.table in SQL syntax. 2. User document for the unified authority management of datalake. 3. LDAP services to provide authentication. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (Yes) 3. Has document been added or modified: (No) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau commented on a diff in pull request #10246: [feature-wip](multi-catalog) add CatalogPrivTable to support unified authority management of datalake
AshinGau commented on code in PR #10246:
URL: https://github.com/apache/doris/pull/10246#discussion_r900931944
##
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##
@@ -198,7 +198,7 @@
* There is only one internal data source in a cluster. And its id is always 0.
*/
public class InternalDataSource implements DataSourceIf {
-public static final String INTERNAL_DS_NAME = "__internal";
Review Comment:
Need #10213 to be merged first. Underscores will case authentication
exception. I will remove this after #10213 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #8831: each tuple starting at aligned address to build with ubsan enabled
github-actions[bot] commented on PR #8831: URL: https://github.com/apache/doris/pull/8831#issuecomment-1159602669 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10070: [enhancement] Change array offset type from UInt32 to UInt64
morningman merged PR #10070: URL: https://github.com/apache/doris/pull/10070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [improvement] Change array offset type from UInt32 to UInt64 (#10070)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0e404edf54 [improvement] Change array offset type from UInt32 to
UInt64 (#10070)
0e404edf54 is described below
commit 0e404edf54f11499b1697958edab761cd52dae54
Author: camby <104178...@qq.com>
AuthorDate: Sun Jun 19 10:24:08 2022 +0800
[improvement] Change array offset type from UInt32 to UInt64 (#10070)
Now column `Array` contains column `offsets` and `data`, and type of
column `offsets` is UInt32 now.
If we call array_union to merge arrays repeatedly, the size of array may
overflow.
So we need to extend it before `Array Data Type` release.
---
be/src/exec/olap_scanner.cpp | 2 +-
be/src/olap/column_vector.cpp | 6 ++--
be/src/olap/column_vector.h| 4 +--
be/src/olap/row_block2.cpp | 6 ++--
be/src/olap/rowset/segment_v2/column_reader.cpp| 2 +-
be/src/olap/rowset/segment_v2/column_reader.h | 2 +-
be/src/olap/rowset/segment_v2/column_writer.cpp| 4 +--
be/src/runtime/collection_value.cpp| 18 ++--
be/src/runtime/collection_value.h | 32 +++---
be/src/runtime/tuple.cpp | 4 +--
be/src/udf/udf.h | 4 +--
be/src/vec/columns/column.h| 2 +-
be/src/vec/columns/column_string.cpp | 4 +--
be/src/vec/columns/column_vector.cpp | 2 +-
be/src/vec/data_types/data_type_array.cpp | 4 +--
be/src/vec/data_types/data_type_string.cpp | 18 ++--
be/src/vec/functions/array/function_array_size.h | 2 +-
be/src/vec/functions/function_string.h | 2 +-
be/src/vec/sink/mysql_result_writer.cpp| 4 +--
be/src/vec/utils/arrow_column_to_doris_column.cpp | 8 +++---
be/test/olap/column_vector_test.cpp| 10 +++
.../org/apache/doris/catalog/PrimitiveType.java| 3 +-
22 files changed, 72 insertions(+), 71 deletions(-)
diff --git a/be/src/exec/olap_scanner.cpp b/be/src/exec/olap_scanner.cpp
index 69d23f5219..3bd2783ea0 100644
--- a/be/src/exec/olap_scanner.cpp
+++ b/be/src/exec/olap_scanner.cpp
@@ -395,7 +395,7 @@ Status OlapScanner::get_batch(RuntimeState* state,
RowBatch* batch, bool* eof) {
auto pool = batch->tuple_data_pool();
CollectionValue::deep_copy_collection(
slot, item_type,
-[pool](int size) -> MemFootprint {
+[pool](int64_t size) -> MemFootprint {
int64_t offset = pool->total_allocated_bytes();
uint8_t* data = pool->allocate(size);
return {offset, data};
diff --git a/be/src/olap/column_vector.cpp b/be/src/olap/column_vector.cpp
index 41e91b9d63..c4962926f2 100644
--- a/be/src/olap/column_vector.cpp
+++ b/be/src/olap/column_vector.cpp
@@ -144,13 +144,13 @@ Status ColumnVectorBatch::create(size_t init_capacity,
bool is_nullable, const T
array_type_info->item_type_info(),
field->get_sub_field(0), &elements));
std::unique_ptr offsets;
-const auto* offsets_type_info =
get_scalar_type_info();
+const auto* offsets_type_info =
get_scalar_type_info();
RETURN_IF_ERROR(ColumnVectorBatch::create(init_capacity + 1,
false, offsets_type_info,
nullptr, &offsets));
std::unique_ptr local(new
ArrayColumnVectorBatch(
type_info, is_nullable,
-
reinterpret_cast*>(offsets.release()),
+
reinterpret_cast*>(offsets.release()),
elements.release()));
RETURN_IF_ERROR(local->resize(init_capacity));
*column_vector_batch = std::move(local);
@@ -181,7 +181,7 @@ Status ScalarColumnVectorBatch::resize(size_t
new_cap) {
}
ArrayColumnVectorBatch::ArrayColumnVectorBatch(const TypeInfo* type_info, bool
is_nullable,
-
ScalarColumnVectorBatch* offsets,
+
ScalarColumnVectorBatch* offsets,
ColumnVectorBatch* elements)
: ColumnVectorBatch(type_info, is_nullable), _data(0) {
_offsets.reset(offsets);
diff --git a/be/src/olap/column_vector.h b/be/src/olap/column_vector.h
index 70ee6e3041..28139fe7d2 100644
--- a/be/src/olap/column_vector.h
+++ b/be/src/olap/column_vector.h
@@ -178,7 +178,7 @@ private:
class ArrayColumnVectorBatch : public ColumnVectorBatch {
public:
explicit ArrayColumnVectorB
[GitHub] [doris] morningman merged pull request #10081: [Feature] support backup/restore connect to HDFS
morningman merged PR #10081: URL: https://github.com/apache/doris/pull/10081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [feature] support backup/restore connect to HDFS (#10081)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1d3496c6ab [feature] support backup/restore connect to HDFS (#10081)
1d3496c6ab is described below
commit 1d3496c6ab4fd718342ea8cfa6c57eebb5a7ee72
Author: xiepengcheng01 <100340096+xiepengchen...@users.noreply.github.com>
AuthorDate: Sun Jun 19 10:26:20 2022 +0800
[feature] support backup/restore connect to HDFS (#10081)
---
be/src/agent/task_worker_pool.cpp | 12 +-
be/src/io/hdfs_builder.cpp | 37 +-
be/src/io/hdfs_builder.h | 11 +
be/src/io/hdfs_file_reader.cpp | 39 +-
be/src/io/hdfs_file_reader.h | 7 +-
be/src/io/hdfs_reader_writer.cpp | 9 +-
be/src/io/hdfs_reader_writer.h | 5 +-
be/src/io/hdfs_writer.cpp | 46 +-
be/src/io/hdfs_writer.h| 6 +-
be/src/runtime/snapshot_loader.cpp | 12 +-
be/src/runtime/snapshot_loader.h | 7 +-
be/src/util/CMakeLists.txt | 2 +
be/src/util/hdfs_storage_backend.cpp | 309
be/src/util/hdfs_storage_backend.h | 63 +++
.../hdfs_reader_writer.cpp => util/hdfs_util.cpp} | 37 +-
.../HdfsStorage.java => be/src/util/hdfs_util.h| 34 +-
be/src/util/s3_util.cpp| 9 +-
be/test/CMakeLists.txt | 1 +
be/test/util/hdfs_storage_backend_test.cpp | 171 +++
docs/en/docs/admin-manual/data-admin/backup.md | 10 +-
docs/en/docs/admin-manual/data-admin/restore.md| 8 +-
.../Backup-and-Restore/CREATE-REPOSITORY.md| 18 +-
docs/zh-CN/docs/admin-manual/data-admin/backup.md | 10 +-
docs/zh-CN/docs/admin-manual/data-admin/restore.md | 14 +-
.../Backup-and-Restore/CREATE-REPOSITORY.md| 19 +-
.../org/apache/doris/analysis/StorageBackend.java | 3 +-
.../java/org/apache/doris/backup/BlobStorage.java | 2 +
.../java/org/apache/doris/backup/HdfsStorage.java | 533 -
.../java/org/apache/doris/backup/Repository.java | 12 +
29 files changed, 1320 insertions(+), 126 deletions(-)
diff --git a/be/src/agent/task_worker_pool.cpp
b/be/src/agent/task_worker_pool.cpp
index c5fbe42c8d..9ad97f9a3c 100644
--- a/be/src/agent/task_worker_pool.cpp
+++ b/be/src/agent/task_worker_pool.cpp
@@ -1266,10 +1266,10 @@ void TaskWorkerPool::_upload_worker_thread_callback() {
std::map> tablet_files;
std::unique_ptr loader = nullptr;
-if (upload_request.__isset.storage_backend &&
-upload_request.storage_backend == TStorageBackendType::S3) {
+if (upload_request.__isset.storage_backend) {
loader.reset(new SnapshotLoader(_env, upload_request.job_id,
agent_task_req.signature,
-upload_request.broker_prop));
+upload_request.broker_prop,
+upload_request.storage_backend));
} else {
loader.reset(new SnapshotLoader(_env, upload_request.job_id,
agent_task_req.signature,
upload_request.broker_addr,
@@ -1333,10 +1333,10 @@ void TaskWorkerPool::_download_worker_thread_callback()
{
std::vector downloaded_tablet_ids;
std::unique_ptr loader = nullptr;
-if (download_request.__isset.storage_backend &&
-download_request.storage_backend == TStorageBackendType::S3) {
+if (download_request.__isset.storage_backend) {
loader.reset(new SnapshotLoader(_env, download_request.job_id,
agent_task_req.signature,
-download_request.broker_prop));
+download_request.broker_prop,
+download_request.storage_backend));
} else {
loader.reset(new SnapshotLoader(_env, download_request.job_id,
agent_task_req.signature,
download_request.broker_addr,
diff --git a/be/src/io/hdfs_builder.cpp b/be/src/io/hdfs_builder.cpp
index 951e787afb..637e40c6a7 100644
--- a/be/src/io/hdfs_builder.cpp
+++ b/be/src/io/hdfs_builder.cpp
@@ -23,12 +23,11 @@
#include "agent/utils.h"
#include "common/logging.h"
+#include "util/string_util.h"
#include "util/uid_util.h"
#include "util/url_coding.h"
namespace doris {
-const std::string TICKET_CACHE_PATH = "/tmp/krb5cc_doris_";
-
Status HDFSCommonBuilder::run_kinit() {
if (hdfs_kerberos_principal.empty() || hdfs_kerberos_keytab.empty()) {
return Status::InvalidArgument("Invalid hdfs_kerberos
[GitHub] [doris] morningman merged pull request #10127: [Bug] Fix heap-use-after-free when using type array
morningman merged PR #10127: URL: https://github.com/apache/doris/pull/10127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman closed issue #9934: [Bug] heap-use-after-free when using type array
morningman closed issue #9934: [Bug] heap-use-after-free when using type array URL: https://github.com/apache/doris/issues/9934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix] Fix heap-use-after-free when using type array (#10127)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5fdd995b4c [fix] Fix heap-use-after-free when using type array
(#10127)
5fdd995b4c is described below
commit 5fdd995b4cdb4023838c96889b0df4a9f51b6052
Author: Adonis Ling
AuthorDate: Sun Jun 19 10:27:36 2022 +0800
[fix] Fix heap-use-after-free when using type array (#10127)
---
be/src/vec/olap/olap_data_convertor.cpp | 47 +++--
be/src/vec/olap/olap_data_convertor.h | 29 +++-
2 files changed, 55 insertions(+), 21 deletions(-)
diff --git a/be/src/vec/olap/olap_data_convertor.cpp
b/be/src/vec/olap/olap_data_convertor.cpp
index 604d2a02ec..abfaaef57f 100644
--- a/be/src/vec/olap/olap_data_convertor.cpp
+++ b/be/src/vec/olap/olap_data_convertor.cpp
@@ -17,6 +17,7 @@
#include "vec/olap/olap_data_convertor.h"
+#include "olap/tablet_schema.h"
#include "vec/columns/column_array.h"
#include "vec/columns/column_complex.h"
#include "vec/columns/column_vector.h"
@@ -599,25 +600,50 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorDecimal::convert_to_olap()
Status OlapBlockDataConvertor::OlapColumnDataConvertorArray::convert_to_olap()
{
const ColumnArray* column_array = nullptr;
-const DataTypeArray* data_type_ptr_array = nullptr;
+const DataTypeArray* data_type_array = nullptr;
if (_nullmap) {
const auto* nullable_column =
assert_cast(_typed_column.column.get());
column_array =
assert_cast(nullable_column->get_nested_column_ptr().get());
-data_type_ptr_array = assert_cast(
+data_type_array = assert_cast(
(assert_cast(_typed_column.type.get())->get_nested_type())
.get());
} else {
column_array = assert_cast(_typed_column.column.get());
-data_type_ptr_array = assert_cast(_typed_column.type.get());
+data_type_array = assert_cast(_typed_column.type.get());
}
assert(column_array);
-assert(data_type_ptr_array);
+assert(data_type_array);
+
+return convert_to_olap(_nullmap, column_array, data_type_array);
+}
+
+Status OlapBlockDataConvertor::OlapColumnDataConvertorArray::convert_to_olap(
+const UInt8* null_map, const ColumnArray* column_array,
+const DataTypeArray* data_type_array) {
+const UInt8* item_null_map = nullptr;
+ColumnPtr item_data = column_array->get_data_ptr();
+if (column_array->get_data().is_nullable()) {
+const auto& data_nullable_column =
+assert_cast(column_array->get_data());
+item_null_map = data_nullable_column.get_null_map_data().data();
+item_data = data_nullable_column.get_nested_column_ptr();
+}
const auto& offsets = column_array->get_offsets();
+int64_t start_index = _row_pos - 1;
+int64_t end_index = _row_pos + _num_rows - 1;
+auto start = offsets[start_index];
+auto size = offsets[end_index] - start;
+
+ColumnWithTypeAndName item_typed_column = {
+item_data, remove_nullable(data_type_array->get_nested_type()),
""};
+_item_convertor->set_source_column(item_typed_column, start, size);
+_item_convertor->convert_to_olap();
+
CollectionValue* collection_value = _values.data();
-for (int i = 0; i < _num_rows; ++i, ++collection_value) {
+for (size_t i = 0; i < _num_rows; ++i, ++collection_value) {
int64_t cur_pos = _row_pos + i;
int64_t prev_pos = cur_pos - 1;
if (_nullmap && _nullmap[cur_pos]) {
@@ -632,18 +658,11 @@ Status
OlapBlockDataConvertor::OlapColumnDataConvertorArray::convert_to_olap() {
}
if (column_array->get_data().is_nullable()) {
-const auto& data_nullable_column =
-assert_cast(column_array->get_data());
-const auto* data_null_map =
data_nullable_column.get_null_map_data().data();
collection_value->set_has_null(true);
collection_value->set_null_signs(
-const_cast(reinterpret_cast(data_null_map + offset)));
+const_cast(reinterpret_cast(item_null_map + offset)));
}
-ColumnWithTypeAndName item_typed_column =
{column_array->get_data_ptr(),
-
data_type_ptr_array->get_nested_type(), ""};
-_item_convertor->set_source_column(item_typed_column, offset, size);
-_item_convertor->convert_to_olap();
-
collection_value->set_data(const_cast(_item_convertor->get_data()));
+
collection_value->set_data(const_cast(_item_convertor->get_data_at(offset)));
}
return Status::OK();
}
diff --git a/be/src/vec/olap/olap_data_convertor.h
b/be/src/vec/olap/olap_data_convertor.h
index e11fb672b2..2cf0f79dc3 100644
--- a/be
[GitHub] [doris] morningman closed issue #10162: [Bug] failed to initialize storage reader***res=-3111
morningman closed issue #10162: [Bug] failed to initialize storage reader***res=-3111 URL: https://github.com/apache/doris/issues/10162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [fix](reader)replace an auto with size_t to avoid integer overflow (#10163)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ffe466cbc7 [fix](reader)replace an auto with size_t to avoid integer
overflow (#10163)
ffe466cbc7 is described below
commit ffe466cbc7558733f1e36ce04c2d8d295081979b
Author: SleepyBear
AuthorDate: Sun Jun 19 10:29:01 2022 +0800
[fix](reader)replace an auto with size_t to avoid integer overflow (#10163)
---
be/src/olap/rowset/segment_v2/binary_dict_page.cpp | 2 +-
be/src/olap/rowset/segment_v2/binary_plain_page.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/olap/rowset/segment_v2/binary_dict_page.cpp
b/be/src/olap/rowset/segment_v2/binary_dict_page.cpp
index b7a7c07681..b53ff52ade 100644
--- a/be/src/olap/rowset/segment_v2/binary_dict_page.cpp
+++ b/be/src/olap/rowset/segment_v2/binary_dict_page.cpp
@@ -291,7 +291,7 @@ Status BinaryDictPageDecoder::next_batch(size_t* n,
ColumnBlockView* dst) {
}
// use SIMD instruction to speed up call function `RoundUpToPowerOfTwo`
-auto mem_size = 0;
+size_t mem_size = 0;
for (int i = 0; i < len; ++i) {
mem_len[i] = BitUtil::RoundUpToPowerOf2Int32(mem_len[i],
MemPool::DEFAULT_ALIGNMENT);
mem_size += mem_len[i];
diff --git a/be/src/olap/rowset/segment_v2/binary_plain_page.h
b/be/src/olap/rowset/segment_v2/binary_plain_page.h
index 58dad51b90..cac9da3709 100644
--- a/be/src/olap/rowset/segment_v2/binary_plain_page.h
+++ b/be/src/olap/rowset/segment_v2/binary_plain_page.h
@@ -208,7 +208,7 @@ public:
}
// use SIMD instruction to speed up call function `RoundUpToPowerOfTwo`
-auto mem_size = 0;
+size_t mem_size = 0;
for (int i = 0; i < max_fetch; ++i) {
mem_len[i] = BitUtil::RoundUpToPowerOf2Int32(mem_len[i],
MemPool::DEFAULT_ALIGNMENT);
mem_size += mem_len[i];
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10163: [fix](reader)replace an auto with size_t to avoid integer overflow
morningman merged PR #10163: URL: https://github.com/apache/doris/pull/10163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10172: [typo] Fix typos in comments
morningman merged PR #10172: URL: https://github.com/apache/doris/pull/10172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [typo] Fix typos in comments (#10172)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 70450d04ba [typo] Fix typos in comments (#10172)
70450d04ba is described below
commit 70450d04ba1abc872f5f0514c9f541d0581e93a6
Author: yinzhijian <373141...@qq.com>
AuthorDate: Sun Jun 19 10:30:17 2022 +0800
[typo] Fix typos in comments (#10172)
---
be/src/runtime/thread_mem_tracker_mgr.h | 2 +-
be/src/runtime/user_function_cache.cpp | 4 ++--
be/src/service/doris_main.cpp | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/be/src/runtime/thread_mem_tracker_mgr.h
b/be/src/runtime/thread_mem_tracker_mgr.h
index e5b82fc939..d582c3a46a 100644
--- a/be/src/runtime/thread_mem_tracker_mgr.h
+++ b/be/src/runtime/thread_mem_tracker_mgr.h
@@ -61,7 +61,7 @@ inline thread_local bool start_thread_mem_tracker = false;
// If the consume succeeds, the memory is actually allocated, otherwise an
exception is thrown.
// But the statistics of memory through TCMalloc new/delete Hook are after the
memory is actually allocated,
// which is different from the previous behavior. Therefore, when alloc for
some large memory,
-// need to manually call cosume after stop_mem_tracker, and then
start_mem_tracker.
+// need to manually call consume after stop_mem_tracker, and then
start_mem_tracker.
class ThreadMemTrackerMgr {
public:
ThreadMemTrackerMgr() {}
diff --git a/be/src/runtime/user_function_cache.cpp
b/be/src/runtime/user_function_cache.cpp
index 33786d2cb0..150cdc6e8f 100644
--- a/be/src/runtime/user_function_cache.cpp
+++ b/be/src/runtime/user_function_cache.cpp
@@ -118,7 +118,7 @@ UserFunctionCache* UserFunctionCache::instance() {
Status UserFunctionCache::init(const std::string& lib_dir) {
#ifndef BE_TEST
-// _lib_dir may reuesd bettween unit tests
+// _lib_dir may be reused between unit tests
DCHECK(_lib_dir.empty()) << _lib_dir;
#endif
_lib_dir = lib_dir;
@@ -265,7 +265,7 @@ Status UserFunctionCache::_get_cache_entry(int64_t fid,
const std::string& url,
if (!st.ok()) {
LOG(WARNING) << "fail to load cache entry, fid=" << fid;
// if we load a cache entry failed, I think we should delete this
entry cache
-// evenif this cache was valid before.
+// even if this cache was valid before.
_destroy_cache_entry(entry);
return st;
}
diff --git a/be/src/service/doris_main.cpp b/be/src/service/doris_main.cpp
index 3230de6e65..00d0900af8 100644
--- a/be/src/service/doris_main.cpp
+++ b/be/src/service/doris_main.cpp
@@ -399,7 +399,7 @@ int main(int argc, char** argv) {
exec_env->set_storage_engine(engine);
engine->set_heartbeat_flags(exec_env->heartbeat_flags());
-// start all backgroud threads of storage engine.
+// start all background threads of storage engine.
// SHOULD be called after exec env is initialized.
EXIT_IF_ERROR(engine->start_bg_threads());
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10205: [chore] Fix a warning reported by maven
morningman merged PR #10205: URL: https://github.com/apache/doris/pull/10205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman closed issue #10204: [chore] Fix a warning reported by maven
morningman closed issue #10204: [chore] Fix a warning reported by maven URL: https://github.com/apache/doris/issues/10204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [chore] Fix a warning reported by maven (#10205)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6b61b970f5 [chore] Fix a warning reported by maven (#10205)
6b61b970f5 is described below
commit 6b61b970f5df3ec2079e78d9d10f846dedd4e2a9
Author: Adonis Ling
AuthorDate: Sun Jun 19 10:34:27 2022 +0800
[chore] Fix a warning reported by maven (#10205)
---
fe/fe-core/pom.xml | 6 --
1 file changed, 6 deletions(-)
diff --git a/fe/fe-core/pom.xml b/fe/fe-core/pom.xml
index 0382b6f4aa..98eb139d05 100644
--- a/fe/fe-core/pom.xml
+++ b/fe/fe-core/pom.xml
@@ -643,12 +643,6 @@ under the License.
${antlr4.version}
-
-javax.annotation
-javax.annotation-api
-1.3.2
-
-
org.apache.maven.plugins
maven-compiler-plugin
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman merged pull request #10226: [docs] update array functions docs'location
morningman merged PR #10226: URL: https://github.com/apache/doris/pull/10226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [doc] update array functions docs' location (#10226)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8439adad05 [doc] update array functions docs' location (#10226)
8439adad05 is described below
commit 8439adad058aa1eec14811dba23fb625f24807c9
Author: camby <104178...@qq.com>
AuthorDate: Sun Jun 19 10:40:40 2022 +0800
[doc] update array functions docs' location (#10226)
Change docs about array functions to correct directory.
Because we already refractor the docs directory.
```
docs/en/sql-manual/sql-functions/array-functions/===>
docs/en/docs/sql-manual/sql-functions/array-functions
```
```
docs/zh-CN/sql-manual/sql-functions/array-functions/===>
docs/zh-CN/docs/sql-manual/sql-functions/array-functions/
```
---
docs/en/{ => docs}/sql-manual/sql-functions/array-functions/array_avg.md | 0
docs/en/{ => docs}/sql-manual/sql-functions/array-functions/array_max.md | 0
docs/en/{ => docs}/sql-manual/sql-functions/array-functions/array_min.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_product.md | 0
docs/en/{ => docs}/sql-manual/sql-functions/array-functions/array_sum.md | 0
docs/en/{ => docs}/sql-manual/sql-functions/array-functions/size.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_avg.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_max.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_min.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_product.md | 0
.../{ => docs}/sql-manual/sql-functions/array-functions/array_sum.md | 0
docs/zh-CN/{ => docs}/sql-manual/sql-functions/array-functions/size.md| 0
12 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/docs/en/sql-manual/sql-functions/array-functions/array_avg.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/array_avg.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/array_avg.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/array_avg.md
diff --git a/docs/en/sql-manual/sql-functions/array-functions/array_max.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/array_max.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/array_max.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/array_max.md
diff --git a/docs/en/sql-manual/sql-functions/array-functions/array_min.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/array_min.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/array_min.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/array_min.md
diff --git a/docs/en/sql-manual/sql-functions/array-functions/array_product.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/array_product.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/array_product.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/array_product.md
diff --git a/docs/en/sql-manual/sql-functions/array-functions/array_sum.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/array_sum.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/array_sum.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/array_sum.md
diff --git a/docs/en/sql-manual/sql-functions/array-functions/size.md
b/docs/en/docs/sql-manual/sql-functions/array-functions/size.md
similarity index 100%
rename from docs/en/sql-manual/sql-functions/array-functions/size.md
rename to docs/en/docs/sql-manual/sql-functions/array-functions/size.md
diff --git a/docs/zh-CN/sql-manual/sql-functions/array-functions/array_avg.md
b/docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_avg.md
similarity index 100%
rename from docs/zh-CN/sql-manual/sql-functions/array-functions/array_avg.md
rename to docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_avg.md
diff --git a/docs/zh-CN/sql-manual/sql-functions/array-functions/array_max.md
b/docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_max.md
similarity index 100%
rename from docs/zh-CN/sql-manual/sql-functions/array-functions/array_max.md
rename to docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_max.md
diff --git a/docs/zh-CN/sql-manual/sql-functions/array-functions/array_min.md
b/docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_min.md
similarity index 100%
rename from docs/zh-CN/sql-manual/sql-functions/array-functions/array_min.md
rename to docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_min.md
diff --git
a/docs/zh-CN/sql-manual/sql-functions/array-functions/array_product.md
b/docs/zh-CN/docs/sql-manual/sql-functions/array-functions/array_product.md
sim
[GitHub] [doris] morningman merged pull request #10244: [BENCHMARK] Change all `replication_num` to 1 for TPCH tables
morningman merged PR #10244: URL: https://github.com/apache/doris/pull/10244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[doris] branch master updated: [tpch] Change all `replication_num` to 1 (#10244)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 61d7724ab3 [tpch] Change all `replication_num` to 1 (#10244) 61d7724ab3 is described below commit 61d7724ab3c25f33c6a293102ce6207a87f1d702 Author: Gabriel AuthorDate: Sun Jun 19 10:42:04 2022 +0800 [tpch] Change all `replication_num` to 1 (#10244) --- tools/tpch-tools/create-tpch-tables.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/tpch-tools/create-tpch-tables.sql b/tools/tpch-tools/create-tpch-tables.sql index c86d7b6c51..1627720899 100644 --- a/tools/tpch-tools/create-tpch-tables.sql +++ b/tools/tpch-tools/create-tpch-tables.sql @@ -144,7 +144,7 @@ DUPLICATE KEY(`N_NATIONKEY`) COMMENT "OLAP" DISTRIBUTED BY HASH(`N_NATIONKEY`) BUCKETS 1 PROPERTIES ( -"replication_num" = "3" +"replication_num" = "1" ); drop table if exists region; @@ -157,7 +157,7 @@ DUPLICATE KEY(`r_regionkey`) COMMENT "OLAP" DISTRIBUTED BY HASH(`r_regionkey`) BUCKETS 1 PROPERTIES ( -"replication_num" = "3" +"replication_num" = "1" ); drop view if exists revenue0; - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #10213: [fix](auth) Authentication exception when the name of database or table contains an underscore in grant statement.
morningman commented on code in PR #10213:
URL: https://github.com/apache/doris/pull/10213#discussion_r901039146
##
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/DbPrivEntry.java:
##
@@ -70,8 +70,7 @@ private static PatternMatcher createDbPatternMatcher(String
db) throws AnalysisE
dbCaseSensibility = false;
}
-PatternMatcher dbPattern =
PatternMatcher.createMysqlPattern(db.equals(ANY_DB) ? "%" : db,
dbCaseSensibility);
-return dbPattern;
+return PatternMatcher.createFlatPattern(db, dbCaseSensibility,
db.equals(ANY_DB));
Review Comment:
```suggestion
return PatternMatcher.createFlatPattern(db, dbCaseSensibility,
db.equals(ANY_DB));
```
##
fe/fe-core/src/main/java/org/apache/doris/common/PatternMatcher.java:
##
@@ -20,27 +20,58 @@
import com.google.common.base.Strings;
import com.google.common.collect.Sets;
+import java.util.Locale;
import java.util.Set;
import java.util.regex.Pattern;
// Wrap for Java pattern and matcher
public class PatternMatcher {
+public static final PatternMatcher MATCH_ANY = new
PatternMatcher(Pattern.compile(".*"));
private Pattern pattern;
+private String flatPattern;
Review Comment:
Add some comment in code to explain the different between `pattern` and
`flatPattern`. Better to give some example.
And looks like the `flatPattern` is not a real pattern, more like an `origin
string`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] AshinGau commented on a diff in pull request #10213: [fix](auth) Authentication exception when the name of database or table contains an underscore in grant statement.
AshinGau commented on code in PR #10213:
URL: https://github.com/apache/doris/pull/10213#discussion_r901041856
##
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/DbPrivEntry.java:
##
@@ -70,8 +70,7 @@ private static PatternMatcher createDbPatternMatcher(String
db) throws AnalysisE
dbCaseSensibility = false;
}
-PatternMatcher dbPattern =
PatternMatcher.createMysqlPattern(db.equals(ANY_DB) ? "%" : db,
dbCaseSensibility);
-return dbPattern;
+return PatternMatcher.createFlatPattern(db, dbCaseSensibility,
db.equals(ANY_DB));
Review Comment:
done
##
fe/fe-core/src/main/java/org/apache/doris/common/PatternMatcher.java:
##
@@ -20,27 +20,58 @@
import com.google.common.base.Strings;
import com.google.common.collect.Sets;
+import java.util.Locale;
import java.util.Set;
import java.util.regex.Pattern;
// Wrap for Java pattern and matcher
public class PatternMatcher {
+public static final PatternMatcher MATCH_ANY = new
PatternMatcher(Pattern.compile(".*"));
private Pattern pattern;
+private String flatPattern;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] mrhhsg closed pull request #10220: [improvement]No need to initialize selection array for predicates
mrhhsg closed pull request #10220: [improvement]No need to initialize selection array for predicates URL: https://github.com/apache/doris/pull/10220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10213: [fix](auth) Authentication exception when the name of database or table contains an underscore in grant statement.
github-actions[bot] commented on PR #10213: URL: https://github.com/apache/doris/pull/10213#issuecomment-1159616627 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [doris] englefly closed pull request #10099: [Refactor] change the macro style of the InListPredicate
englefly closed pull request #10099: [Refactor] change the macro style of the InListPredicate URL: https://github.com/apache/doris/pull/10099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
