[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue, #9936: [Enhancement][Chore] remove breakpad and unused variable
BiteThet opened a new issue, #9936: URL: https://github.com/apache/incubator-doris/issues/9936 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description _No response_ ### Solution _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request, #9937: [Enhancement][Chore] remove breakpad and unused variable
BiteThet opened a new pull request, #9937: URL: https://github.com/apache/incubator-doris/pull/9937 # Proposed changes Issue Number: close #9936 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9937: [Enhancement][Chore] remove breakpad and unused variable
github-actions[bot] commented on PR #9937: URL: https://github.com/apache/incubator-doris/pull/9937#issuecomment-1144524428 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9937: [Enhancement][Chore] remove breakpad and unused variable
github-actions[bot] commented on PR #9937: URL: https://github.com/apache/incubator-doris/pull/9937#issuecomment-1144524504 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9930: [Vectorized][UDF] support java-udaf
BiteThet commented on code in PR #9930:
URL: https://github.com/apache/incubator-doris/pull/9930#discussion_r887636880
##
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##
@@ -0,0 +1,392 @@
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#ifdef LIBJVM
+
+#include
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "gen_cpp/Exprs_types.h"
+#include "runtime/user_function_cache.h"
+#include "util/jni-util.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column_string.h"
+#include "vec/common/exception.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/field.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+const char* UDAF_EXECUTOR_CLASS = "org/apache/doris/udf/UdafExecutor";
+const char* UDAF_EXECUTOR_CTOR_SIGNATURE = "([B)V";
+const char* UDAF_EXECUTOR_CLOSE_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_CREATE_SIGNATURE = "()Ljava/lang/Object;";
+const char* UDAF_EXECUTOR_DESTORY_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_ADD_SIGNATURE = "(J)V";
+const char* UDAF_EXECUTOR_MERGE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_SERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_DESERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_RESULT_SIGNATURE = "(J)Z";
+
+struct AggregateJavaUdafData {
+public:
+AggregateJavaUdafData() = default;
+AggregateJavaUdafData(int64_t num_args) {
+argument_size = num_args;
+first_init = true;
+input_values_buffer_ptr.reset(new int64_t[num_args]);
+input_nulls_buffer_ptr.reset(new int64_t[num_args]);
+input_offsets_ptrs.reset(new int64_t[num_args]);
+output_value_buffer.reset(new int64_t);
+output_null_value.reset(new int64_t);
+batch_size_ptr.reset(new int32_t);
+output_offsets_ptr.reset(new int64_t);
+output_intermediate_state_ptr.reset(new int64_t);
+}
+
+~AggregateJavaUdafData() {
+JNIEnv* env;
+Status status;
+RETURN_IF_STATUS_ERROR(status, JniUtil::GetJNIEnv(&env));
+env->CallNonvirtualVoidMethod(executor_obj, executor_cl_,
executor_close_id_);
+Status s = JniUtil::GetJniExceptionMsg(env);
+if (!s.ok()) {
+LOG(WARNING) << "meet some error in destroy: " <<
s.get_error_msg();
+}
+env->DeleteGlobalRef(executor_obj);
+}
+
+Status init_udaf(const TFunction& fn) {
+if (first_init) {
+JNIEnv* env = nullptr;
+RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
+if (env == nullptr) {
+return Status::InternalError("Failed to get/create JVM");
+}
+RETURN_IF_ERROR(JniUtil::GetGlobalClassRef(env,
UDAF_EXECUTOR_CLASS, &executor_cl_));
+
+Status ret_code = register_func_id(env);
+if (!ret_code.ok()) {
+LOG(WARNING) << "register_func_id has error : " <<
ret_code.get_error_msg();
+}
+
+// Add a scoped cleanup jni reference object. This cleans up local
refs made below.
+JniLocalFrame jni_frame;
+{
+std::string local_location;
+auto function_cache = UserFunctionCache::instance();
+RETURN_IF_ERROR(function_cache->get_jarpath(fn.id,
fn.hdfs_location, fn.checksum,
+&local_location));
+TJavaUdfExecutorCtorParams ctor_params;
+ctor_params.__set_fn(fn);
+ctor_params.__set_location(local_location);
+
ctor_params.__set_input_offsets_ptrs((int64_t)input_offsets_ptrs.get());
+
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
+
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
+
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
+
ctor_params.__set_output_null_ptr((int64_t)output_null_value.get());
+
ctor_params.__set_output_offsets_ptr((int64_t)output_offsets_ptr.get
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9930: [Vectorized][UDF] support java-udaf
BiteThet commented on code in PR #9930:
URL: https://github.com/apache/incubator-doris/pull/9930#discussion_r887636880
##
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##
@@ -0,0 +1,392 @@
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#ifdef LIBJVM
+
+#include
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "gen_cpp/Exprs_types.h"
+#include "runtime/user_function_cache.h"
+#include "util/jni-util.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column_string.h"
+#include "vec/common/exception.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/field.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+const char* UDAF_EXECUTOR_CLASS = "org/apache/doris/udf/UdafExecutor";
+const char* UDAF_EXECUTOR_CTOR_SIGNATURE = "([B)V";
+const char* UDAF_EXECUTOR_CLOSE_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_CREATE_SIGNATURE = "()Ljava/lang/Object;";
+const char* UDAF_EXECUTOR_DESTORY_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_ADD_SIGNATURE = "(J)V";
+const char* UDAF_EXECUTOR_MERGE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_SERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_DESERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_RESULT_SIGNATURE = "(J)Z";
+
+struct AggregateJavaUdafData {
+public:
+AggregateJavaUdafData() = default;
+AggregateJavaUdafData(int64_t num_args) {
+argument_size = num_args;
+first_init = true;
+input_values_buffer_ptr.reset(new int64_t[num_args]);
+input_nulls_buffer_ptr.reset(new int64_t[num_args]);
+input_offsets_ptrs.reset(new int64_t[num_args]);
+output_value_buffer.reset(new int64_t);
+output_null_value.reset(new int64_t);
+batch_size_ptr.reset(new int32_t);
+output_offsets_ptr.reset(new int64_t);
+output_intermediate_state_ptr.reset(new int64_t);
+}
+
+~AggregateJavaUdafData() {
+JNIEnv* env;
+Status status;
+RETURN_IF_STATUS_ERROR(status, JniUtil::GetJNIEnv(&env));
+env->CallNonvirtualVoidMethod(executor_obj, executor_cl_,
executor_close_id_);
+Status s = JniUtil::GetJniExceptionMsg(env);
+if (!s.ok()) {
+LOG(WARNING) << "meet some error in destroy: " <<
s.get_error_msg();
+}
+env->DeleteGlobalRef(executor_obj);
+}
+
+Status init_udaf(const TFunction& fn) {
+if (first_init) {
+JNIEnv* env = nullptr;
+RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
+if (env == nullptr) {
+return Status::InternalError("Failed to get/create JVM");
+}
+RETURN_IF_ERROR(JniUtil::GetGlobalClassRef(env,
UDAF_EXECUTOR_CLASS, &executor_cl_));
+
+Status ret_code = register_func_id(env);
+if (!ret_code.ok()) {
+LOG(WARNING) << "register_func_id has error : " <<
ret_code.get_error_msg();
+}
+
+// Add a scoped cleanup jni reference object. This cleans up local
refs made below.
+JniLocalFrame jni_frame;
+{
+std::string local_location;
+auto function_cache = UserFunctionCache::instance();
+RETURN_IF_ERROR(function_cache->get_jarpath(fn.id,
fn.hdfs_location, fn.checksum,
+&local_location));
+TJavaUdfExecutorCtorParams ctor_params;
+ctor_params.__set_fn(fn);
+ctor_params.__set_location(local_location);
+
ctor_params.__set_input_offsets_ptrs((int64_t)input_offsets_ptrs.get());
+
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
+
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
+
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
+
ctor_params.__set_output_null_ptr((int64_t)output_null_value.get());
+
ctor_params.__set_output_offsets_ptr((int64_t)output_offsets_ptr.get
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9930: [Vectorized][UDF] support java-udaf
BiteThet commented on code in PR #9930:
URL: https://github.com/apache/incubator-doris/pull/9930#discussion_r887644383
##
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##
@@ -0,0 +1,392 @@
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#ifdef LIBJVM
+
+#include
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "gen_cpp/Exprs_types.h"
+#include "runtime/user_function_cache.h"
+#include "util/jni-util.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column_string.h"
+#include "vec/common/exception.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/field.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+const char* UDAF_EXECUTOR_CLASS = "org/apache/doris/udf/UdafExecutor";
+const char* UDAF_EXECUTOR_CTOR_SIGNATURE = "([B)V";
+const char* UDAF_EXECUTOR_CLOSE_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_CREATE_SIGNATURE = "()Ljava/lang/Object;";
+const char* UDAF_EXECUTOR_DESTORY_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_ADD_SIGNATURE = "(J)V";
+const char* UDAF_EXECUTOR_MERGE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_SERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_DESERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_RESULT_SIGNATURE = "(J)Z";
+
+struct AggregateJavaUdafData {
+public:
+AggregateJavaUdafData() = default;
+AggregateJavaUdafData(int64_t num_args) {
+argument_size = num_args;
+first_init = true;
+input_values_buffer_ptr.reset(new int64_t[num_args]);
+input_nulls_buffer_ptr.reset(new int64_t[num_args]);
+input_offsets_ptrs.reset(new int64_t[num_args]);
+output_value_buffer.reset(new int64_t);
+output_null_value.reset(new int64_t);
+batch_size_ptr.reset(new int32_t);
+output_offsets_ptr.reset(new int64_t);
+output_intermediate_state_ptr.reset(new int64_t);
+}
+
+~AggregateJavaUdafData() {
+JNIEnv* env;
+Status status;
+RETURN_IF_STATUS_ERROR(status, JniUtil::GetJNIEnv(&env));
+env->CallNonvirtualVoidMethod(executor_obj, executor_cl_,
executor_close_id_);
+Status s = JniUtil::GetJniExceptionMsg(env);
+if (!s.ok()) {
+LOG(WARNING) << "meet some error in destroy: " <<
s.get_error_msg();
+}
+env->DeleteGlobalRef(executor_obj);
+}
+
+Status init_udaf(const TFunction& fn) {
+if (first_init) {
+JNIEnv* env = nullptr;
+RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
+if (env == nullptr) {
+return Status::InternalError("Failed to get/create JVM");
+}
+RETURN_IF_ERROR(JniUtil::GetGlobalClassRef(env,
UDAF_EXECUTOR_CLASS, &executor_cl_));
+
+Status ret_code = register_func_id(env);
+if (!ret_code.ok()) {
+LOG(WARNING) << "register_func_id has error : " <<
ret_code.get_error_msg();
+}
+
+// Add a scoped cleanup jni reference object. This cleans up local
refs made below.
+JniLocalFrame jni_frame;
+{
+std::string local_location;
+auto function_cache = UserFunctionCache::instance();
+RETURN_IF_ERROR(function_cache->get_jarpath(fn.id,
fn.hdfs_location, fn.checksum,
+&local_location));
+TJavaUdfExecutorCtorParams ctor_params;
+ctor_params.__set_fn(fn);
+ctor_params.__set_location(local_location);
+
ctor_params.__set_input_offsets_ptrs((int64_t)input_offsets_ptrs.get());
+
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
+
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
+
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
+
ctor_params.__set_output_null_ptr((int64_t)output_null_value.get());
+
ctor_params.__set_output_offsets_ptr((int64_t)output_offsets_ptr.get
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9935: [doc][fix]English document title case
github-actions[bot] commented on PR #9935: URL: https://github.com/apache/incubator-doris/pull/9935#issuecomment-1144534324 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9935: [doc][fix]English document title case
github-actions[bot] commented on PR #9935: URL: https://github.com/apache/incubator-doris/pull/9935#issuecomment-1144534366 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9930: [Vectorized][UDF] support java-udaf
BiteThet commented on code in PR #9930:
URL: https://github.com/apache/incubator-doris/pull/9930#discussion_r887645411
##
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##
@@ -0,0 +1,392 @@
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#ifdef LIBJVM
+
+#include
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "gen_cpp/Exprs_types.h"
+#include "runtime/user_function_cache.h"
+#include "util/jni-util.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column_string.h"
+#include "vec/common/exception.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/field.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+const char* UDAF_EXECUTOR_CLASS = "org/apache/doris/udf/UdafExecutor";
+const char* UDAF_EXECUTOR_CTOR_SIGNATURE = "([B)V";
+const char* UDAF_EXECUTOR_CLOSE_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_CREATE_SIGNATURE = "()Ljava/lang/Object;";
+const char* UDAF_EXECUTOR_DESTORY_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_ADD_SIGNATURE = "(J)V";
+const char* UDAF_EXECUTOR_MERGE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_SERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_DESERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_RESULT_SIGNATURE = "(J)Z";
+
+struct AggregateJavaUdafData {
+public:
+AggregateJavaUdafData() = default;
+AggregateJavaUdafData(int64_t num_args) {
+argument_size = num_args;
+first_init = true;
+input_values_buffer_ptr.reset(new int64_t[num_args]);
+input_nulls_buffer_ptr.reset(new int64_t[num_args]);
+input_offsets_ptrs.reset(new int64_t[num_args]);
+output_value_buffer.reset(new int64_t);
+output_null_value.reset(new int64_t);
+batch_size_ptr.reset(new int32_t);
+output_offsets_ptr.reset(new int64_t);
+output_intermediate_state_ptr.reset(new int64_t);
+}
+
+~AggregateJavaUdafData() {
+JNIEnv* env;
+Status status;
+RETURN_IF_STATUS_ERROR(status, JniUtil::GetJNIEnv(&env));
+env->CallNonvirtualVoidMethod(executor_obj, executor_cl_,
executor_close_id_);
+Status s = JniUtil::GetJniExceptionMsg(env);
+if (!s.ok()) {
+LOG(WARNING) << "meet some error in destroy: " <<
s.get_error_msg();
+}
+env->DeleteGlobalRef(executor_obj);
+}
+
+Status init_udaf(const TFunction& fn) {
+if (first_init) {
+JNIEnv* env = nullptr;
+RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
+if (env == nullptr) {
+return Status::InternalError("Failed to get/create JVM");
+}
+RETURN_IF_ERROR(JniUtil::GetGlobalClassRef(env,
UDAF_EXECUTOR_CLASS, &executor_cl_));
+
+Status ret_code = register_func_id(env);
+if (!ret_code.ok()) {
+LOG(WARNING) << "register_func_id has error : " <<
ret_code.get_error_msg();
+}
+
+// Add a scoped cleanup jni reference object. This cleans up local
refs made below.
+JniLocalFrame jni_frame;
+{
+std::string local_location;
+auto function_cache = UserFunctionCache::instance();
+RETURN_IF_ERROR(function_cache->get_jarpath(fn.id,
fn.hdfs_location, fn.checksum,
+&local_location));
+TJavaUdfExecutorCtorParams ctor_params;
+ctor_params.__set_fn(fn);
+ctor_params.__set_location(local_location);
+
ctor_params.__set_input_offsets_ptrs((int64_t)input_offsets_ptrs.get());
+
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
+
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
+
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
+
ctor_params.__set_output_null_ptr((int64_t)output_null_value.get());
+
ctor_params.__set_output_offsets_ptr((int64_t)output_offsets_ptr.get
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9930: [Vectorized][UDF] support java-udaf
BiteThet commented on code in PR #9930:
URL: https://github.com/apache/incubator-doris/pull/9930#discussion_r887649309
##
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##
@@ -0,0 +1,392 @@
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#pragma once
+
+#ifdef LIBJVM
+
+#include
+#include
+
+#include
+#include
+
+#include "common/status.h"
+#include "gen_cpp/Exprs_types.h"
+#include "runtime/user_function_cache.h"
+#include "util/jni-util.h"
+#include "vec/aggregate_functions/aggregate_function.h"
+#include "vec/columns/column_string.h"
+#include "vec/common/exception.h"
+#include "vec/common/string_ref.h"
+#include "vec/core/block.h"
+#include "vec/core/column_numbers.h"
+#include "vec/core/field.h"
+#include "vec/core/types.h"
+#include "vec/data_types/data_type_string.h"
+#include "vec/io/io_helper.h"
+
+namespace doris::vectorized {
+
+const char* UDAF_EXECUTOR_CLASS = "org/apache/doris/udf/UdafExecutor";
+const char* UDAF_EXECUTOR_CTOR_SIGNATURE = "([B)V";
+const char* UDAF_EXECUTOR_CLOSE_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_CREATE_SIGNATURE = "()Ljava/lang/Object;";
+const char* UDAF_EXECUTOR_DESTORY_SIGNATURE = "()V";
+const char* UDAF_EXECUTOR_ADD_SIGNATURE = "(J)V";
+const char* UDAF_EXECUTOR_MERGE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_SERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_DESERIALIZE_SIGNATURE = "(Ljava/lang/Object;)V";
+const char* UDAF_EXECUTOR_RESULT_SIGNATURE = "(J)Z";
+
+struct AggregateJavaUdafData {
+public:
+AggregateJavaUdafData() = default;
+AggregateJavaUdafData(int64_t num_args) {
+argument_size = num_args;
+first_init = true;
+input_values_buffer_ptr.reset(new int64_t[num_args]);
+input_nulls_buffer_ptr.reset(new int64_t[num_args]);
+input_offsets_ptrs.reset(new int64_t[num_args]);
+output_value_buffer.reset(new int64_t);
+output_null_value.reset(new int64_t);
+batch_size_ptr.reset(new int32_t);
+output_offsets_ptr.reset(new int64_t);
+output_intermediate_state_ptr.reset(new int64_t);
+}
+
+~AggregateJavaUdafData() {
+JNIEnv* env;
+Status status;
+RETURN_IF_STATUS_ERROR(status, JniUtil::GetJNIEnv(&env));
+env->CallNonvirtualVoidMethod(executor_obj, executor_cl_,
executor_close_id_);
+Status s = JniUtil::GetJniExceptionMsg(env);
+if (!s.ok()) {
+LOG(WARNING) << "meet some error in destroy: " <<
s.get_error_msg();
+}
+env->DeleteGlobalRef(executor_obj);
+}
+
+Status init_udaf(const TFunction& fn) {
+if (first_init) {
+JNIEnv* env = nullptr;
+RETURN_IF_ERROR(JniUtil::GetJNIEnv(&env));
+if (env == nullptr) {
+return Status::InternalError("Failed to get/create JVM");
+}
+RETURN_IF_ERROR(JniUtil::GetGlobalClassRef(env,
UDAF_EXECUTOR_CLASS, &executor_cl_));
+
+Status ret_code = register_func_id(env);
+if (!ret_code.ok()) {
+LOG(WARNING) << "register_func_id has error : " <<
ret_code.get_error_msg();
+}
+
+// Add a scoped cleanup jni reference object. This cleans up local
refs made below.
+JniLocalFrame jni_frame;
+{
+std::string local_location;
+auto function_cache = UserFunctionCache::instance();
+RETURN_IF_ERROR(function_cache->get_jarpath(fn.id,
fn.hdfs_location, fn.checksum,
+&local_location));
+TJavaUdfExecutorCtorParams ctor_params;
+ctor_params.__set_fn(fn);
+ctor_params.__set_location(local_location);
+
ctor_params.__set_input_offsets_ptrs((int64_t)input_offsets_ptrs.get());
+
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
+
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
+
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
+
ctor_params.__set_output_null_ptr((int64_t)output_null_value.get());
+
ctor_params.__set_output_offsets_ptr((int64_t)output_offsets_ptr.get
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9933: [deps] upgrade k8s client to compitable new k8s cluster
github-actions[bot] commented on PR #9933: URL: https://github.com/apache/incubator-doris/pull/9933#issuecomment-1144553521 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9933: [deps] upgrade k8s client to compitable new k8s cluster
github-actions[bot] commented on PR #9933: URL: https://github.com/apache/incubator-doris/pull/9933#issuecomment-1144553555 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zy-kkk commented on pull request #9929: Add regression test method for regression function
zy-kkk commented on PR #9929: URL: https://github.com/apache/incubator-doris/pull/9929#issuecomment-1144563813 Don't forget to put [test] in front of the title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] jacktengg opened a new pull request, #9938: [bugfix] fix grammar of ADMIN SHOW TABLET STORAGE FORMAT stmt
jacktengg opened a new pull request, #9938: URL: https://github.com/apache/incubator-doris/pull/9938 # Proposed changes Related to PR https://github.com/apache/incubator-doris/pull/9037, use correct grammar. ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] FreeOnePlus commented on pull request #9929: [test]Add regression test method for regression function
FreeOnePlus commented on PR #9929: URL: https://github.com/apache/incubator-doris/pull/9929#issuecomment-1144571804 > 不要忘记在标题前加上 [test] Title modification completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] PragmaTwice opened a new pull request, #9939: [Enhancement] Refactor functions in int_exp by templates
PragmaTwice opened a new pull request, #9939: URL: https://github.com/apache/incubator-doris/pull/9939 # Proposed changes Issue Number: close #xxx ## Problem Summary: The current implementation of functions in `int_exp.h` used some hand-written, hard-coded arrays, which made the code lengthy. These functions can be rewritten using templates, and this implementation is more generalized and less error-prone. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (?) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9927: [fix] (planner) slot nullable does not set correctly when plan outer join with inline view
github-actions[bot] commented on PR #9927: URL: https://github.com/apache/incubator-doris/pull/9927#issuecomment-1144576493 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9927: [fix] (planner) slot nullable does not set correctly when plan outer join with inline view
github-actions[bot] commented on PR #9927: URL: https://github.com/apache/incubator-doris/pull/9927#issuecomment-1144576543 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9877: [Bug] fix bugs of analyzation of rewrited SQL when triggered the materialized vew
github-actions[bot] commented on PR #9877: URL: https://github.com/apache/incubator-doris/pull/9877#issuecomment-1144578302 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9930: [Vectorized][UDF] support java-udaf
morningman commented on PR #9930: URL: https://github.com/apache/incubator-doris/pull/9930#issuecomment-1144580502 Hi @zhangstar333 , could you explain more about what does this PR do? Because we already supported part of JAVA udf feature, so you need to explain what's new in your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9940: [refactor] (planner) separate statistic package to stats, collection and derivation
morrySnow opened a new pull request, #9940: URL: https://github.com/apache/incubator-doris/pull/9940 # Proposed changes Currently, we put all statistic files in one package. To make the code structure clearer, this PR: - separate them to three part: stats, collection and derivation - create two sub package under statistics: collection and derivation - move collection related files to collection package - move derivation related files to derivation package - keep stats info files in place ## Checklist(Required) 1. Does it affect the original behavior: No 2. Has unit tests been added: No Need 3. Has document been added or modified: No Need 4. Does it need to update dependencies: No 5. Are there any changes that cannot be rolled back: No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #9803: [fix](brpc) Embed serialized request into the attachment and transmit it through http brpc
xinyiZzz commented on PR #9803: URL: https://github.com/apache/incubator-doris/pull/9803#issuecomment-1144598040 @yangzhg @morningman PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Kikyou1997 opened a new pull request, #9941: [Enhancement] Column prune for olap scan node
Kikyou1997 opened a new pull request, #9941: URL: https://github.com/apache/incubator-doris/pull/9941 # Proposed changes Add Column prune for olap scan node based on the project planner framework ## Problem Summary: Implement the `initOutputSlotIds` method ## Checklist(Required) 1. Does it affect the original behavior: (Yes) 2. Has unit tests been added: (Yes) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9938: [bugfix] fix grammar of ADMIN SHOW TABLET STORAGE FORMAT stmt
github-actions[bot] commented on PR #9938: URL: https://github.com/apache/incubator-doris/pull/9938#issuecomment-1144642819 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9938: [bugfix] fix grammar of ADMIN SHOW TABLET STORAGE FORMAT stmt
github-actions[bot] commented on PR #9938: URL: https://github.com/apache/incubator-doris/pull/9938#issuecomment-1144642849 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on pull request #9941: [Enhancement] Column prune for olap scan node
yiguolei commented on PR #9941: URL: https://github.com/apache/incubator-doris/pull/9941#issuecomment-1144643467 Do not need any changes in BE? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #9940: [refactor] (planner) separate statistic package to stats, collection and derivation
EmmyMiao87 commented on PR #9940: URL: https://github.com/apache/incubator-doris/pull/9940#issuecomment-1144652108 This PR causes code conflicts in ongoing pr 9458. This PR is closed firstly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 closed pull request #9940: [refactor] (planner) separate statistic package to stats, collection and derivation
EmmyMiao87 closed pull request #9940: [refactor] (planner) separate statistic package to stats, collection and derivation URL: https://github.com/apache/incubator-doris/pull/9940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qzsee opened a new pull request, #9942: [Enhancement] (Nereids) scalar expression rewrite framework
qzsee opened a new pull request, #9942: URL: https://github.com/apache/incubator-doris/pull/9942 # Proposed changes Issue Number: close #9633 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9941: [Enhancement] Column prune for olap scan node
EmmyMiao87 commented on code in PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#discussion_r887773039
##
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java:
##
@@ -984,4 +984,17 @@ public String toString() {
sb.append("\n").append(getNodeExplainString("", TExplainLevel.BRIEF));
return sb.toString();
}
+
+/**
+ * Used to append some common explains to output
+ */
+protected void appendCommonExplainString(String detailPrefix,
StringBuilder output) {
Review Comment:
It seems that there is already a getExplainString in the plan node for
common string output.
##
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##
@@ -941,4 +943,17 @@ public DataPartition
constructInputPartitionByDistributionInfo() throws UserExce
return DataPartition.RANDOM;
}
}
+
+@Override
+public void initOutputSlotIds(Set requiredSlotIdSet, Analyzer
analyzer) throws NotImplementedException {
Review Comment:
Although fe calculates the output slot of the scan node, if be does not make
any changes, the function of project cannot be realized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zenoyang closed issue #8914: [Enhancement] AggregationNode optimization
zenoyang closed issue #8914: [Enhancement] AggregationNode optimization URL: https://github.com/apache/incubator-doris/issues/8914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Kikyou1997 commented on a diff in pull request #9941: [Enhancement] Column prune for olap scan node
Kikyou1997 commented on code in PR #9941:
URL: https://github.com/apache/incubator-doris/pull/9941#discussion_r887785975
##
fe/fe-core/src/main/java/org/apache/doris/planner/OlapScanNode.java:
##
@@ -941,4 +943,17 @@ public DataPartition
constructInputPartitionByDistributionInfo() throws UserExce
return DataPartition.RANDOM;
}
}
+
+@Override
+public void initOutputSlotIds(Set requiredSlotIdSet, Analyzer
analyzer) throws NotImplementedException {
Review Comment:
OK, I'll add supports in BE later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9939: [Enhancement] Refactor functions in int_exp by templates
github-actions[bot] commented on PR #9939: URL: https://github.com/apache/incubator-doris/pull/9939#issuecomment-1144684424 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9939: [Enhancement] Refactor functions in int_exp by templates
github-actions[bot] commented on PR #9939: URL: https://github.com/apache/incubator-doris/pull/9939#issuecomment-1144684467 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz opened a new pull request, #9943: [fix][mem tracker] Fix load task mem tracker
xinyiZzz opened a new pull request, #9943: URL: https://github.com/apache/incubator-doris/pull/9943 # Proposed changes Issue Number: close #9905 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caoliang-web opened a new pull request, #9944: [doc]Optimize cluster upgrade and Modify binlog load document modification
caoliang-web opened a new pull request, #9944: URL: https://github.com/apache/incubator-doris/pull/9944 ## Problem Summary: 1.Optimize cluster upgrade documentation 2.Modify binlog documentation ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] wangyf0555 opened a new pull request, #9945: [feature](docs)update new docs
wangyf0555 opened a new pull request, #9945: URL: https://github.com/apache/incubator-doris/pull/9945 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9929: [test]Add regression test method for regression function
github-actions[bot] commented on PR #9929: URL: https://github.com/apache/incubator-doris/pull/9929#issuecomment-1144727232 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9929: [test]Add regression test method for regression function
github-actions[bot] commented on PR #9929: URL: https://github.com/apache/incubator-doris/pull/9929#issuecomment-1144727208 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris-spark-connector] hf200012 merged pull request #33: [fix] Fix pom.xml when compile occur error.
hf200012 merged PR #33: URL: https://github.com/apache/incubator-doris-spark-connector/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] branch master updated: update pom.xml (#33)
This is an automated email from the ASF dual-hosted git repository.
jiafengzheng pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git
The following commit(s) were added to refs/heads/master by this push:
new e617b7a update pom.xml (#33)
e617b7a is described below
commit e617b7ae50064f1c3ef8bcd2da314063c083ccb1
Author: smallhibiscus <844981...@qq.com>
AuthorDate: Thu Jun 2 19:05:01 2022 +0800
update pom.xml (#33)
update pom.xml
---
spark-doris-connector/pom.xml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/spark-doris-connector/pom.xml b/spark-doris-connector/pom.xml
index 854fd43..8e728d8 100644
--- a/spark-doris-connector/pom.xml
+++ b/spark-doris-connector/pom.xml
@@ -65,7 +65,7 @@
${env.scala.version}
${env.spark.version}
${env.spark.minor.version}
-0.14.0
+0.13.0
5.0.0
3.8.1
3.3.0
@@ -74,7 +74,7 @@
${env.THRIFT_BIN}
github
4.1.27.Final
-2.12.6.1
+2.10.0
@@ -190,7 +190,7 @@
junit
junit
-4.13.1
+4.11
hamcrest-core
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] FreeOnePlus opened a new pull request, #9946: [test] Add regression test case for math function
FreeOnePlus opened a new pull request, #9946: URL: https://github.com/apache/incubator-doris/pull/9946 This PR mainly completes the regression test case of the math function # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] FreeOnePlus opened a new pull request, #9947: [test] Add regression test case for Table function
FreeOnePlus opened a new pull request, #9947: URL: https://github.com/apache/incubator-doris/pull/9947 This PR mainly completes the regression test case of the Table function # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9943: [fix][mem tracker] Fix logout load task mem tracker dcheck fail
github-actions[bot] commented on PR #9943: URL: https://github.com/apache/incubator-doris/pull/9943#issuecomment-1144770151 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9943: [fix][mem tracker] Fix logout load task mem tracker dcheck fail
github-actions[bot] commented on PR #9943: URL: https://github.com/apache/incubator-doris/pull/9943#issuecomment-1144770126 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9924: [test] Add window cast bitmap digital_masking function regression test.
github-actions[bot] commented on PR #9924: URL: https://github.com/apache/incubator-doris/pull/9924#issuecomment-1144770235 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9924: [test] Add window cast bitmap digital_masking function regression test.
github-actions[bot] commented on PR #9924: URL: https://github.com/apache/incubator-doris/pull/9924#issuecomment-1144770196 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9944: [doc]Optimize cluster upgrade and Modify binlog load document modification
github-actions[bot] commented on PR #9944: URL: https://github.com/apache/incubator-doris/pull/9944#issuecomment-1144776071 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9944: [doc]Optimize cluster upgrade and Modify binlog load document modification
github-actions[bot] commented on PR #9944: URL: https://github.com/apache/incubator-doris/pull/9944#issuecomment-1144776047 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9854: [test] Add bitmap_intersect and schema_change test for regression test.
github-actions[bot] commented on PR #9854: URL: https://github.com/apache/incubator-doris/pull/9854#issuecomment-1144791853 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9854: [test] Add bitmap_intersect and schema_change test for regression test.
github-actions[bot] commented on PR #9854: URL: https://github.com/apache/incubator-doris/pull/9854#issuecomment-1144791889 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] FreeOnePlus opened a new pull request, #9948: [fix] Error when compiling under ARM architecture machine, fixed a loop
FreeOnePlus opened a new pull request, #9948:
URL: https://github.com/apache/incubator-doris/pull/9948
An error is reported when compiling under the ARM architecture machine, and
the compilation cannot be executed. According to the prompt, change a loop in
the bits.h file under the util toolkit of BE from the original one:
for (size_t i = 0; i < 32; ++i) {
mask |= static_cast(1 == *(data + i)) << i;
}
change into:
for (std::size_t i = 0; i < 32; ++i) {
mask |= static_cast(1 == *(data + i)) << i;
}
After the correction, the compilation is passed and no error is reported
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new issue, #9949: Release note 1.1 (Draft)
morningman opened a new issue, #9949: URL: https://github.com/apache/incubator-doris/issues/9949 (DRAFT!!!) ## New features ## Important bug fixes ## Optimization ## Ease of use ## Others ## Thanks Thanks to everyone who has contributed to this release: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9937: [Enhancement][Chore] remove breakpad and unused variable
yiguolei merged PR #9937: URL: https://github.com/apache/incubator-doris/pull/9937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei closed issue #9936: [Enhancement][Chore] remove breakpad and unused variable
yiguolei closed issue #9936: [Enhancement][Chore] remove breakpad and unused variable URL: https://github.com/apache/incubator-doris/issues/9936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [Enhancement][Chore] remove breakpad and unused variable (#9937)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new c0ad1be1bd [Enhancement][Chore] remove breakpad and unused variable
(#9937)
c0ad1be1bd is described below
commit c0ad1be1bdf165bc8472d1042c0030d928b11aa3
Author: Pxl
AuthorDate: Thu Jun 2 20:52:17 2022 +0800
[Enhancement][Chore] remove breakpad and unused variable (#9937)
---
be/test/vec/exec/vorc_scanner_test.cpp | 1 -
thirdparty/build-thirdparty.sh | 10 --
thirdparty/vars.sh | 9 -
3 files changed, 20 deletions(-)
diff --git a/be/test/vec/exec/vorc_scanner_test.cpp
b/be/test/vec/exec/vorc_scanner_test.cpp
index f5f8bf522c..92a9013786 100644
--- a/be/test/vec/exec/vorc_scanner_test.cpp
+++ b/be/test/vec/exec/vorc_scanner_test.cpp
@@ -71,7 +71,6 @@ private:
std::vector _addresses;
ScannerCounter _counter;
std::vector _pre_filter;
-bool _fill_tuple;
};
TEST_F(VOrcScannerTest, normal) {
diff --git a/thirdparty/build-thirdparty.sh b/thirdparty/build-thirdparty.sh
index a352f9a3ab..ec4bf9b985 100755
--- a/thirdparty/build-thirdparty.sh
+++ b/thirdparty/build-thirdparty.sh
@@ -985,15 +985,6 @@ build_benchmark() {
cp $TP_SOURCE_DIR/$BENCHMARK_SOURCE/build/src/libbenchmark.a $TP_LIB_DIR/
}
-# breakpad
-build_breakpad() {
-check_if_source_exist $BREAKPAD_SOURCE
-
-cd $TP_SOURCE_DIR/$BREAKPAD_SOURCE
-./configure --prefix=$TP_INSTALL_DIR
-make -j $PARALLEL && make install
-}
-
# simdjson
build_simdjson() {
check_if_source_exist $SIMDJSON_SOURCE
@@ -1058,7 +1049,6 @@ build_krb5
build_hdfs3
build_hdfs3_with_kerberos
build_benchmark
-build_breakpad
build_simdjson
build_libbacktrace
diff --git a/thirdparty/vars.sh b/thirdparty/vars.sh
index b3dc39aa0a..9696c76a48 100755
--- a/thirdparty/vars.sh
+++ b/thirdparty/vars.sh
@@ -365,14 +365,6 @@ BENCHMARK_NAME=benchmark-1.5.6.tar.gz
BENCHMARK_SOURCE=benchmark-1.5.6
BENCHMARK_MD5SUM="668b9e10d8b0795e5d461894db18db3c"
-# breakpad
-# breakpad has no release version, the source is from commit@38ee0be,
-# and also add lss files. See README.md in it.
-BREAKPAD_DOWNLOAD="https://doris-thirdparty-repo.bj.bcebos.com/thirdparty/breakpad-src-38ee0be-with-lss.tar.gz";
-BREAKPAD_NAME=breakpad-src-38ee0be-with-lss.tar.gz
-BREAKPAD_SOURCE=breakpad-src-38ee0be-with-lss
-BREAKPAD_MD5SUM="fd8c4f6f5cf8b5e03a4c3c39fde83368"
-
# xsimd
# for arrow-7.0.0, if arrow upgrade, this version may also need to be changed
XSIMD_DOWNLOAD="https://github.com/xtensor-stack/xsimd/archive/aeec9c872c8b475dedd7781336710f2dd2666cb2.tar.gz";
@@ -444,7 +436,6 @@ HDFS3
LIBDIVIDE
PDQSORT
BENCHMARK
-BREAKPAD
XSIMD
SIMDJSON
LIBBACKTRACE"
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9935: [doc][fix]English document title case
yiguolei merged PR #9935: URL: https://github.com/apache/incubator-doris/pull/9935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [doc][fix]English document title case (#9935)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 3241cc2bfd [doc][fix]English document title case (#9935)
3241cc2bfd is described below
commit 3241cc2bfde698dbf40fa97c12e5392f630695ca
Author: jiafeng.zhang
AuthorDate: Thu Jun 2 20:52:58 2022 +0800
[doc][fix]English document title case (#9935)
---
docs/en/community/how-to-contribute/how-to-be-a-committer.md | 4 ++--
docs/en/community/subscribe-mail-list.md | 4 ++--
docs/en/downloads/downloads.md | 6 +++---
docs/zh-CN/downloads/downloads.md| 6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/docs/en/community/how-to-contribute/how-to-be-a-committer.md
b/docs/en/community/how-to-contribute/how-to-be-a-committer.md
index d6f4b2ea9e..5da0e6db64 100644
--- a/docs/en/community/how-to-contribute/how-to-be-a-committer.md
+++ b/docs/en/community/how-to-contribute/how-to-be-a-committer.md
@@ -1,6 +1,6 @@
---
{
-"title": "How To Be A Committer",
+"title": "How to Become Doris Committer",
"language": "zh-CN"
}
---
@@ -24,7 +24,7 @@ specific language governing permissions and limitations
under the License.
-->
-# How To Be A Committer
+# How to Become Doris Committer
In an Apache project, developers have three roles:
diff --git a/docs/en/community/subscribe-mail-list.md
b/docs/en/community/subscribe-mail-list.md
index bdd75a68d6..d8067d1345 100644
--- a/docs/en/community/subscribe-mail-list.md
+++ b/docs/en/community/subscribe-mail-list.md
@@ -1,6 +1,6 @@
---
{
-"title": "Subscribe to mailing lists",
+"title": "Subscribe Mailing Lists",
"language": "en"
}
---
@@ -24,7 +24,7 @@ specific language governing permissions and limitations
under the License.
-->
-# Subscribe to mailing lists
+# Subscribe Mailing Lists
Mail List is the most recognized form of communication in Apache community.
Generally speaking, open source community questions and answers, technical
discussions, transaction decisions are carried through mailing lists. The
asynchronous and broadcasting features of mailing lists are also very suitable
for communication in open source communities. So how do you subscribe to Apache
Doris (incubating) mailing lists? It mainly includes the following five steps.
diff --git a/docs/en/downloads/downloads.md b/docs/en/downloads/downloads.md
index 1e303fb4bc..c756fe9020 100644
--- a/docs/en/downloads/downloads.md
+++ b/docs/en/downloads/downloads.md
@@ -28,11 +28,11 @@ under the License.
## Apache Doris
-You can download source code from following links, then compile and install
Doris.
+You can download the Doris source code from the following link for compilation
and deployment. After version 1.0, you can download the binary version for
direct installation and deployment.
-| Version | Release Date | Download Source | Download Binary |
+| Version | Release Date | Download Source | Binary Version |
|---|---|---| --- |
-| 1.0.0 | 2022-04-18 |
[Source](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz)
([Signature](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz.asc)
[SHA512](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz.sha512))|
[Binary [362MB]](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0
[...]
+| 1.0.0 | 2022-04-18 |
[Source](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz)
([Signature](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz.asc)
[SHA512](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0/1.0.0-incubating/apache-doris-1.0.0-incubating-src.tar.gz.sha512))|
[Binary [362MB]](https://www.apache.org/dyn/closer.cgi/incubator/doris/1.0
[...]
| 0.15.0 | 2021-11-29 |
[Source](http://archive.apache.org/dist/incubator/doris/0.15.0-incubating/apache-doris-0.15.0-incubating-src.tar.gz)
([Signature](http://archive.apache.org/dist/incubator/doris/0.15.0-incubating/apache-doris-0.15.0-incubating-src.tar.gz.asc)
[SHA512](http://archive.apache.org/dist/incubator/doris/0.15.0-incubating/apache-doris-0.15.0-incubating-src.tar.gz.sha512))||
| 0.14.0 | 2021-05-26 |
[Source](https://archive.apache.org/dist/incubator/doris/0.14.0-incubating/apache-doris-0.14.0-incubating-src.tar.gz)
([Signature](https://archive.apache.org/dist/incubator/doris/0.14.0-incubating/apache-doris-0.14.0-incubating-src.tar.gz.asc)
[SHA512](https://archive.apache.org/dist/incubator/doris/0.14.0-incubating/apache-doris-0.14.0-incubating-src.tar.
[GitHub] [incubator-doris] morningman commented on pull request #9931: [fix](regression-test) fix the comparison errors caused by inconsistent accuracy
morningman commented on PR #9931: URL: https://github.com/apache/incubator-doris/pull/9931#issuecomment-1145007268 > Will this cause the bug to be covered up? The decimal type doesn't seem to have precision errors Maybe we should change this back after the decimal v3 is completed. Because currently, the decimal type doesn't return real precision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9877: [Bug] fix bugs of analyzation of rewrited SQL when triggered the materialized vew
github-actions[bot] commented on PR #9877: URL: https://github.com/apache/incubator-doris/pull/9877#issuecomment-1145010516 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9877: [Bug] fix bugs of analyzation of rewrited SQL when triggered the materialized vew
morningman merged PR #9877: URL: https://github.com/apache/incubator-doris/pull/9877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [fix] fix invalid SQL rewrite for field in materialized view (#9877)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 67fa1fcf2a [fix] fix invalid SQL rewrite for field in materialized
view (#9877)
67fa1fcf2a is described below
commit 67fa1fcf2a69228e5f680260ef839474b4c312bb
Author: Kikyou1997 <33112463+kikyou1...@users.noreply.github.com>
AuthorDate: Thu Jun 2 23:43:13 2022 +0800
[fix] fix invalid SQL rewrite for field in materialized view (#9877)
---
.../apache/doris/rewrite/mvrewrite/CountFieldToSum.java | 16 +---
.../doris/planner/MaterializedViewFunctionTest.java | 10 ++
.../suites/rollup/test_materialized_view.groovy | 15 +++
3 files changed, 34 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
index 6068f1bdd7..11e9981121 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
@@ -22,7 +22,6 @@ import org.apache.doris.analysis.CreateMaterializedViewStmt;
import org.apache.doris.analysis.Expr;
import org.apache.doris.analysis.FunctionCallExpr;
import org.apache.doris.analysis.SlotRef;
-import org.apache.doris.analysis.TableName;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.FunctionSet;
import org.apache.doris.catalog.OlapTable;
@@ -81,15 +80,18 @@ public class CountFieldToSum implements ExprRewriteRule {
}
// rewrite expr
-return rewriteExpr(fnChild0, mvColumn, analyzer);
+return rewriteExpr(mvColumn, analyzer);
}
-private Expr rewriteExpr(SlotRef queryColumnSlotRef, Column mvColumn,
Analyzer analyzer) {
+private Expr rewriteExpr(Column mvColumn, Analyzer analyzer) {
Preconditions.checkNotNull(mvColumn);
-Preconditions.checkNotNull(queryColumnSlotRef);
-TableName tableName = queryColumnSlotRef.getTableName();
-Preconditions.checkNotNull(tableName);
-SlotRef mvSlotRef = new SlotRef(tableName, mvColumn.getName());
+// Notice that we shouldn't set table name field of mvSlotRef here,
for we will analyze the new mvSlotRef
+// later, if the table name was set here, the
Analyzer::registerColumnRef would invoke
+// Analyzer::resolveColumnRef(TableName, String) which only try to
find the column from the tupleByAlias,
+// as at the most time the alias is not equal with the origin table
name, so it would cause the unexpected
+// exception to Unknown column, because we can't find an alias which
named as origin table name that has
+// required column.
+SlotRef mvSlotRef = new SlotRef(null, mvColumn.getName());
List newFnParams = Lists.newArrayList();
newFnParams.add(mvSlotRef);
FunctionCallExpr result = new FunctionCallExpr("sum", newFnParams);
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
b/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
index 5f4bf368da..7f920023bd 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
@@ -850,4 +850,14 @@ public class MaterializedViewFunctionTest {
dorisAssert.query(query).explainContains("mv");
dorisAssert.dropTable("agg_table", true);
}
+
+@Test
+public void testSelectMVWithTableAlias() throws Exception {
+String createUserTagMVSql = "create materialized view " +
USER_TAG_MV_NAME + " as select user_id, "
++ "count(tag_id) from " + USER_TAG_TABLE_NAME + " group by
user_id;";
+dorisAssert.withMaterializedView(createUserTagMVSql);
+String query = "select count(tag_id) from " + USER_TAG_TABLE_NAME + "
t ;";
+String mvColumnName =
CreateMaterializedViewStmt.mvColumnBuilder(FunctionSet.COUNT, "tag_id");
+dorisAssert.query(query).explainContains(USER_TAG_MV_NAME,
mvColumnName);
+}
}
diff --git a/regression-test/suites/rollup/test_materialized_view.groovy
b/regression-test/suites/rollup/test_materialized_view.groovy
index 5d41dca6de..1a801d01c2 100644
--- a/regression-test/suites/rollup/test_materialized_view.groovy
+++ b/regression-test/suites/rollup/test_materialized_view.groovy
@@ -76,8 +76,23 @@ suite("test_materialized_view", "rollup") {
qt_sql "SELECT store_id, sum(sale_amt) FROM ${tbName1} GROUP BY store_id
order by store_id;"
qt_sql "SELECT * FROM ${tbName2} order by record_id;"
qt_sql "SELECT store_id, sum(sale_amt) FROM ${tbName2} GROUP BY store_id
[incubator-doris] branch dev-1.0.1 updated (8bdc7195a9 -> ad0216f823)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
from 8bdc7195a9 [hotfix] fix unused import from ##9618
new 3182672279 [fix](Function) fix to_bitmap to return always not nullable
(#9859)
new 9a7d70b2f0 [fix] fix invalid SQL rewrite for field in materialized
view (#9877)
new c4ef128d55 [Vectorized][Function] fix bitmap_intersect get wrong
result (#9907)
new ad0216f823 [fix](hive) fix bug of invalid user info in external
table's scan node (#9908)
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../aggregate_function_bitmap.h| 13 +--
be/src/vec/functions/function_bitmap.cpp | 45 ++
.../org/apache/doris/planner/BrokerScanNode.java | 2 +-
.../doris/rewrite/mvrewrite/CountFieldToSum.java | 16
.../planner/MaterializedViewFunctionTest.java | 10 +
..._variance_agg.out => test_bitmap_intersect.out} | 5 +--
...nce_agg.groovy => test_bitmap_intersect.groovy} | 26 ++---
7 files changed, 74 insertions(+), 43 deletions(-)
copy regression-test/data/correctness/{test_select_variance_agg.out =>
test_bitmap_intersect.out} (71%)
copy regression-test/suites/correctness/{test_select_variance_agg.groovy =>
test_bitmap_intersect.groovy} (55%)
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 03/04: [Vectorized][Function] fix bitmap_intersect get wrong result (#9907)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit c4ef128d559b8a5cf989684dd95a57acf95f83b5
Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>
AuthorDate: Wed Jun 1 23:51:52 2022 +0800
[Vectorized][Function] fix bitmap_intersect get wrong result (#9907)
---
.../aggregate_function_bitmap.h| 13 +--
.../data/correctness/test_bitmap_intersect.out | 4 +++
.../correctness/test_bitmap_intersect.groovy | 41 ++
3 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
b/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
index 939421656e..f4a237dbb9 100644
--- a/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
+++ b/be/src/vec/aggregate_functions/aggregate_function_bitmap.h
@@ -38,7 +38,7 @@ struct AggregateFunctionBitmapUnionOp {
static void add(BitmapValue& res, const BitmapValue& data, bool& is_first)
{ res |= data; }
-static void merge(BitmapValue& res, const BitmapValue& data) { res |=
data; }
+static void merge(BitmapValue& res, const BitmapValue& data, bool&
is_first) { res |= data; }
};
struct AggregateFunctionBitmapIntersectOp {
@@ -53,7 +53,14 @@ struct AggregateFunctionBitmapIntersectOp {
}
}
-static void merge(BitmapValue& res, const BitmapValue& data) { res &=
data; }
+static void merge(BitmapValue& res, const BitmapValue& data, bool&
is_first) {
+if (UNLIKELY(is_first)) {
+res = data;
+is_first = false;
+} else {
+res &= data;
+}
+}
};
template
@@ -66,7 +73,7 @@ struct AggregateFunctionBitmapData {
Op::add(value, data, is_first);
}
-void merge(const BitmapValue& data) { Op::merge(value, data); }
+void merge(const BitmapValue& data) { Op::merge(value, data, is_first); }
void write(BufferWritable& buf) const {
DataTypeBitMap::serialize_as_stream(value, buf); }
diff --git a/regression-test/data/correctness/test_bitmap_intersect.out
b/regression-test/data/correctness/test_bitmap_intersect.out
new file mode 100644
index 00..eb88af08bf
--- /dev/null
+++ b/regression-test/data/correctness/test_bitmap_intersect.out
@@ -0,0 +1,4 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select_default --
+1,2
+
diff --git a/regression-test/suites/correctness/test_bitmap_intersect.groovy
b/regression-test/suites/correctness/test_bitmap_intersect.groovy
new file mode 100644
index 00..63fd337411
--- /dev/null
+++ b/regression-test/suites/correctness/test_bitmap_intersect.groovy
@@ -0,0 +1,41 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+ // or more contributor license agreements. See the NOTICE file
+ // distributed with this work for additional information
+ // regarding copyright ownership. The ASF licenses this file
+ // to you under the Apache License, Version 2.0 (the
+ // "License"); you may not use this file except in compliance
+ // with the License. You may obtain a copy of the License at
+ //
+ // http://www.apache.org/licenses/LICENSE-2.0
+ //
+ // Unless required by applicable law or agreed to in writing,
+ // software distributed under the License is distributed on an
+ // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ // KIND, either express or implied. See the License for the
+ // specific language governing permissions and limitations
+ // under the License.
+
+ suite("test_bitmap_intersect") {
+ def tableName = "test_bitmap"
+
+
+ sql """ DROP TABLE IF EXISTS ${tableName} """
+ sql """
+create table ${tableName} (tag varchar(20),user_ids bitmap
bitmap_union) aggregate key (tag)
+distributed by hash (tag) PROPERTIES("replication_num" = "1");
+ """
+
+ sql " insert into ${tableName} values('A', to_bitmap(1)); "
+ sql " insert into ${tableName} values('A', to_bitmap(2)); "
+ sql " insert into ${tableName} values('A', to_bitmap(3)); "
+ sql " insert into ${tableName} values('B', to_bitmap(1)); "
+ sql " insert into ${tableName} values('B', to_bitmap(2)); "
+
+ // test_vectorized
+ sql """ set enable_vectorized_engine = true; """
+
+ qt_select_default """
+ select bitmap_to_string(bitmap_intersect(user_ids)) from ( select tag,
bitmap_union(user_ids) user_ids
+ from ${tableName} group by tag ) t; """
+
+ }
\ No newline at end of file
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 04/04: [fix](hive) fix bug of invalid user info in external table's scan node (#9908)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit ad0216f8236112e80996208f4bfccc873d9bc379
Author: slothever <18522955+w...@users.noreply.github.com>
AuthorDate: Thu Jun 2 10:41:40 2022 +0800
[fix](hive) fix bug of invalid user info in external table's scan node
(#9908)
Fix the hive external table scan node null exception
Now hive external table query will fail when use local user@ip
---
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java
b/fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java
index 3a99bc0203..417b91e145 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java
@@ -151,7 +151,7 @@ public class BrokerScanNode extends LoadScanNode {
this.fileStatusesList = fileStatusesList;
this.filesAdded = filesAdded;
if (ConnectContext.get() != null) {
-this.userIdentity = ConnectContext.get().getUserIdentity();
+this.userIdentity = ConnectContext.get().getCurrentUserIdentity();
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 01/04: [fix](Function) fix to_bitmap to return always not nullable (#9859)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 318267227961c1d347e77e8ab07c9b85b99dc3b0
Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>
AuthorDate: Thu Jun 2 10:37:45 2022 +0800
[fix](Function) fix to_bitmap to return always not nullable (#9859)
---
be/src/vec/functions/function_bitmap.cpp | 45 +---
1 file changed, 30 insertions(+), 15 deletions(-)
diff --git a/be/src/vec/functions/function_bitmap.cpp
b/be/src/vec/functions/function_bitmap.cpp
index 0b80c88b5d..69b5bd6737 100644
--- a/be/src/vec/functions/function_bitmap.cpp
+++ b/be/src/vec/functions/function_bitmap.cpp
@@ -39,24 +39,39 @@ struct BitmapEmpty {
struct ToBitmap {
static constexpr auto name = "to_bitmap";
+using ReturnType = DataTypeBitMap;
-static Status vector(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
- std::vector& res, NullMap& null_map) {
-auto size = offsets.size();
-res.reserve(size);
-for (size_t i = 0; i < size; ++i) {
-res.emplace_back();
+static void vector(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
+ MutableColumnPtr& col_res) {
+execute(data, offsets, nullptr, col_res);
+}
-const char* raw_str = reinterpret_cast(&data[offsets[i - 1]]);
-size_t str_size = offsets[i] - offsets[i - 1] - 1;
-StringParser::ParseResult parse_result =
StringParser::PARSE_SUCCESS;
-uint64_t int_value =
StringParser::string_to_unsigned_int(raw_str, str_size,
-
&parse_result);
-if (LIKELY(parse_result == StringParser::PARSE_SUCCESS)) {
-res.back().add(int_value);
+static void vector_nullable(const ColumnString::Chars& data,
+const ColumnString::Offsets& offsets, const
NullMap& nullmap,
+MutableColumnPtr& col_res) {
+execute(data, offsets, &nullmap, col_res);
+}
+template
+static void execute(const ColumnString::Chars& data, const
ColumnString::Offsets& offsets,
+const NullMap* nullmap, MutableColumnPtr& col_res) {
+auto* res_column = reinterpret_cast(col_res.get());
+auto& res_data = res_column->get_data();
+size_t size = offsets.size();
+
+for (size_t i = 0; i < size; ++i) {
+if (arg_is_nullable && ((*nullmap)[i])) {
+continue;
+} else {
+const char* raw_str = reinterpret_cast(&data[offsets[i - 1]]);
+size_t str_size = offsets[i] - offsets[i - 1] - 1;
+StringParser::ParseResult parse_result =
StringParser::PARSE_SUCCESS;
+uint64_t int_value =
StringParser::string_to_unsigned_int(
+raw_str, str_size, &parse_result);
+if (LIKELY(parse_result == StringParser::PARSE_SUCCESS)) {
+res_data[i].add(int_value);
+}
}
}
-return Status::OK();
}
};
@@ -494,7 +509,7 @@ public:
};
using FunctionBitmapEmpty = FunctionConst;
-using FunctionToBitmap = FunctionBitmapAlwaysNull;
+using FunctionToBitmap = FunctionAlwaysNotNullable;
using FunctionBitmapFromString = FunctionBitmapAlwaysNull;
using FunctionBitmapHash = FunctionAlwaysNotNullable;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 02/04: [fix] fix invalid SQL rewrite for field in materialized view (#9877)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.1
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 9a7d70b2f097d0c29ba85dca18f72018503cf71a
Author: Kikyou1997 <33112463+kikyou1...@users.noreply.github.com>
AuthorDate: Thu Jun 2 23:43:13 2022 +0800
[fix] fix invalid SQL rewrite for field in materialized view (#9877)
---
.../apache/doris/rewrite/mvrewrite/CountFieldToSum.java | 16 +---
.../doris/planner/MaterializedViewFunctionTest.java | 10 ++
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
index ec3ce7e670..0b06cd52eb 100644
---
a/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
+++
b/fe/fe-core/src/main/java/org/apache/doris/rewrite/mvrewrite/CountFieldToSum.java
@@ -22,7 +22,6 @@ import org.apache.doris.analysis.CreateMaterializedViewStmt;
import org.apache.doris.analysis.Expr;
import org.apache.doris.analysis.FunctionCallExpr;
import org.apache.doris.analysis.SlotRef;
-import org.apache.doris.analysis.TableName;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.FunctionSet;
import org.apache.doris.catalog.OlapTable;
@@ -81,15 +80,18 @@ public class CountFieldToSum implements ExprRewriteRule {
}
// rewrite expr
-return rewriteExpr(fnChild0, mvColumn, analyzer);
+return rewriteExpr(mvColumn, analyzer);
}
-private Expr rewriteExpr(SlotRef queryColumnSlotRef, Column mvColumn,
Analyzer analyzer) {
+private Expr rewriteExpr(Column mvColumn, Analyzer analyzer) {
Preconditions.checkNotNull(mvColumn);
-Preconditions.checkNotNull(queryColumnSlotRef);
-TableName tableName = queryColumnSlotRef.getTableName();
-Preconditions.checkNotNull(tableName);
-SlotRef mvSlotRef = new SlotRef(tableName, mvColumn.getName());
+// Notice that we shouldn't set table name field of mvSlotRef here,
for we will analyze the new mvSlotRef
+// later, if the table name was set here, the
Analyzer::registerColumnRef would invoke
+// Analyzer::resolveColumnRef(TableName, String) which only try to
find the column from the tupleByAlias,
+// as at the most time the alias is not equal with the origin table
name, so it would cause the unexpected
+// exception to Unknown column, because we can't find an alias which
named as origin table name that has
+// required column.
+SlotRef mvSlotRef = new SlotRef(null, mvColumn.getName());
List newFnParams = Lists.newArrayList();
newFnParams.add(mvSlotRef);
FunctionCallExpr result = new FunctionCallExpr("sum", newFnParams);
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
b/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
index a980ff9a67..1e34a47b84 100644
---
a/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
+++
b/fe/fe-core/src/test/java/org/apache/doris/planner/MaterializedViewFunctionTest.java
@@ -850,4 +850,14 @@ public class MaterializedViewFunctionTest {
dorisAssert.query(query).explainContains("mv");
dorisAssert.dropTable("agg_table", true);
}
+
+@Test
+public void testSelectMVWithTableAlias() throws Exception {
+String createUserTagMVSql = "create materialized view " +
USER_TAG_MV_NAME + " as select user_id, "
++ "count(tag_id) from " + USER_TAG_TABLE_NAME + " group by
user_id;";
+dorisAssert.withMaterializedView(createUserTagMVSql);
+String query = "select count(tag_id) from " + USER_TAG_TABLE_NAME + "
t ;";
+String mvColumnName =
CreateMaterializedViewStmt.mvColumnBuilder(FunctionSet.COUNT, "tag_id");
+dorisAssert.query(query).explainContains(USER_TAG_MV_NAME,
mvColumnName);
+}
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] annotated tag 1.1.0-preview1 updated (e7203d9491 -> 6f2ad19da8)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 1.1.0-preview1 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git *** WARNING: tag 1.1.0-preview1 was modified! *** from e7203d9491 (commit) to 6f2ad19da8 (tag) tagging e7203d949173c0ec1a3c1b3cebe12adbb7ae0063 (commit) by morningman on Fri Jun 3 00:21:19 2022 +0800 - Log - 1.1.0-preview1 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 opened a new pull request, #9950: [Improvement] change the condition of vectorized compaction
Gabriel39 opened a new pull request, #9950: URL: https://github.com/apache/incubator-doris/pull/9950 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on issue #9949: Release Note 1.1 (Draft)
Gabriel39 commented on issue #9949: URL: https://github.com/apache/incubator-doris/issues/9949#issuecomment-1145073468 Maybe Java UDF should be mentioned in features as we have supported all types except HLL and Bitmap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #9950: [Improvement] change the condition of vectorized compaction
Gabriel39 commented on PR #9950: URL: https://github.com/apache/incubator-doris/pull/9950#issuecomment-1145075748 cc @liaoxin01 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] gaodayue commented on pull request #9894: [Enhancement] Remove minidump
gaodayue commented on PR #9894: URL: https://github.com/apache/incubator-doris/pull/9894#issuecomment-1145414782 > Minidump is not useful in a real online environment, instead it introduces additional errors. @xinyiZzz What is the additional errors introduced by minidump? I think minidump is still useful in scenarios where coredump is too large to be enabled, what's the alternative to minidump in those scenarios? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [fix] Error when compiling under ARM architecture machine, fixed a loop (#9948)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new cacad64d2c [fix] Error when compiling under ARM architecture machine,
fixed a loop (#9948)
cacad64d2c is described below
commit cacad64d2cdc020a181d4afa98bddf89a42ad785
Author: FreeOnePlus <54164178+freeonep...@users.noreply.github.com>
AuthorDate: Fri Jun 3 08:00:55 2022 +0800
[fix] Error when compiling under ARM architecture machine, fixed a loop
(#9948)
---
be/src/util/simd/bits.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/util/simd/bits.h b/be/src/util/simd/bits.h
index b907ebb5ef..09b1fe519b 100644
--- a/be/src/util/simd/bits.h
+++ b/be/src/util/simd/bits.h
@@ -46,7 +46,7 @@ inline uint32_t bytes32_mask_to_bits32_mask(const uint8_t*
data) {
0x);
#else
uint32_t mask = 0;
-for (size_t i = 0; i < 32; ++i) {
+for (std::size_t i = 0; i < 32; ++i) {
mask |= static_cast(1 == *(data + i)) << i;
}
#endif
@@ -58,4 +58,4 @@ inline uint32_t bytes32_mask_to_bits32_mask(const bool* data)
{
}
} // namespace simd
-} // namespace doris
\ No newline at end of file
+} // namespace doris
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9948: [fix] Error when compiling under ARM architecture machine, fixed a loop
yiguolei merged PR #9948: URL: https://github.com/apache/incubator-doris/pull/9948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9946: [test] Add regression test case for math function
github-actions[bot] commented on PR #9946: URL: https://github.com/apache/incubator-doris/pull/9946#issuecomment-1145457291 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9946: [test] Add regression test case for math function
github-actions[bot] commented on PR #9946: URL: https://github.com/apache/incubator-doris/pull/9946#issuecomment-1145457316 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed pull request #9885: [fix](planner): fix pushdown predicate incompletely
morningman closed pull request #9885: [fix](planner): fix pushdown predicate incompletely URL: https://github.com/apache/incubator-doris/pull/9885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9885: [fix](planner): fix pushdown predicate incompletely
morningman commented on PR #9885: URL: https://github.com/apache/incubator-doris/pull/9885#issuecomment-1145485165 closed, we can not push down this predicate for analytic function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup
github-actions[bot] commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1145497693 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup
github-actions[bot] commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1145497676 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup
caiconghui commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1145529002 why modify the default Xmx from 4G to 8G can solve oom problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9683: [fix]Set the memory size used when FE starts according to the user's available memory at startup
morningman commented on PR #9683: URL: https://github.com/apache/incubator-doris/pull/9683#issuecomment-1145552785 > why modify the default Xmx from 4G to 8G can solve oom problem? No, just because many new user does not modify the default value. And 4GB is too small for default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error
github-actions[bot] commented on PR #9720: URL: https://github.com/apache/incubator-doris/pull/9720#issuecomment-1145553516 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9720: [improvement] Optimize send fragment logic to reduce send fragment timeout error
github-actions[bot] commented on PR #9720: URL: https://github.com/apache/incubator-doris/pull/9720#issuecomment-1145553533 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
