[GitHub] [incubator-doris] morningman opened a new issue #8264: [Bug] Insert into with select constants failed
morningman opened a new issue #8264: URL: https://github.com/apache/incubator-doris/issues/8264 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk ### What's Wrong? ``` Unexpected exception: Index 0 out of bounds for length 0 ``` ### What You Expected? Works well ### How to Reproduce? ``` CREATE TABLE `decimal_tb` ( `k1` decimal(1, 0) NULL COMMENT "", `v1` decimal(1, 0) SUM NULL COMMENT "", `v2` decimal(1, 0) MAX NULL COMMENT "", `v3` decimal(1, 0) MIN NULL COMMENT "", `v4` decimal(1, 0) REPLACE NULL COMMENT "" ) ENGINE=OLAP AGGREGATE KEY(`k1`) COMMENT "OLAP" DISTRIBUTED BY HASH(`k1`) BUCKETS 15 PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "in_memory" = "false", "storage_format" = "V2" ); insert into decimal_tb select 1, 10, 1, 1, 1; ``` ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #8265: [fix](chore)(insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency
morningman opened a new pull request #8265: URL: https://github.com/apache/incubator-doris/pull/8265 # Proposed changes Issue Number: close #8264 ## Problem Summary: This bug is introduced from #8112. Also , I change the `grpc-netty` dependency to `grpc-netty-shaded`, to avoid dependency conflict: ``` java.lang.NoSuchMethodError: io.netty.buffer.PooledByteBufAllocator. ``` ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (Yes) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (Yes) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8265: [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency
github-actions[bot] commented on pull request #8265: URL: https://github.com/apache/incubator-doris/pull/8265#issuecomment-1054013842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8263: [refactor] remove unused new_in_predicate code
github-actions[bot] commented on pull request #8263: URL: https://github.com/apache/incubator-doris/pull/8263#issuecomment-1054014358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] lljqy opened a new issue #8266: [Enhancement]
lljqy opened a new issue #8266: URL: https://github.com/apache/incubator-doris/issues/8266 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description 希望兼容两个参数“storage_engine”和“default_storage_engine” ### Solution _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] spaces-X commented on a change in pull request #8234: [Feature] Support pre-aggregation for quantile type
spaces-X commented on a change in pull request #8234:
URL: https://github.com/apache/incubator-doris/pull/8234#discussion_r815708161
##
File path: be/src/exprs/quantile_function.cpp
##
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/quantile_function.h"
+#include "exprs/anyval_util.h"
+#include "gutil/strings/numbers.h"
+#include "gutil/strings/split.h"
+#include "util/quantile_state.h"
+#include "util/string_parser.hpp"
+#include "util/slice.h"
+
+namespace doris {
+
+using doris_udf::DoubleVal;
+using doris_udf::StringVal;
+using doris_udf::FloatVal;
+
+void QuantileStateFunctions::init(){}
+
+void QuantileStateFunctions::quantile_state_init(FunctionContext* ctx,
StringVal* dst) {
+dst->is_null = false;
+dst->len = sizeof(QuantileState);
+dst->ptr = (uint8_t*) new QuantileState();
+}
+
+static StringVal serialize(FunctionContext* ctx, QuantileState* value)
{
+StringVal result(ctx, value->get_serialized_size());
+value->serialize(result.ptr);
+return result;
+}
+
+StringVal QuantileStateFunctions::to_quantile_state(FunctionContext* ctx,
const StringVal& src) {
+QuantileState quantile_state;
+quantile_state.set_compression(2048);
+const AnyVal* digest_compression = ctx->get_constant_arg(1);
+if (digest_compression != nullptr) {
+float compression = reinterpret_cast(digest_compression)->val;
+if (compression >= 2048 && compression <= 1) {
+quantile_state.set_compression(compression);
+}
+}
+
+if(!src.is_null) {
+StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
+double double_value = StringParser::string_to_float(
+reinterpret_cast(src.ptr), src.len, &parse_result);
+if (UNLIKELY(parse_result != StringParser::PARSE_SUCCESS)) {
+std::stringstream error_msg;
+error_msg << "The input: " <<
std::string(reinterpret_cast(src.ptr), src.len)
+ << " is not valid, to_bitmap only support bigint value
from 0 to "
+ "18446744073709551615 currently";
+ctx->set_error(error_msg.str().c_str());
+return StringVal::null();
+}
+quantile_state.add_value(double_value);
+}
+return serialize(ctx, &quantile_state);
+}
+
+void QuantileStateFunctions::quantile_union(FunctionContext* ctx, const
StringVal& src, StringVal* dst) {
+if(src.is_null) {
+return;
+}
+auto dst_quantile = reinterpret_cast*>(dst->ptr);
+if(src.len == 0) {
+
dst_quantile->merge(*reinterpret_cast*>(src.ptr));
+} else {
+QuantileState state(Slice(src.ptr, src.len));
+dst_quantile->merge(state);
+}
+}
+
+DoubleVal QuantileStateFunctions::quantile_percent(FunctionContext* ctx,
StringVal& src) {
+const AnyVal* percentile = ctx->get_constant_arg(1);
+if (percentile != nullptr) {
+float percentile_value = reinterpret_cast(percentile)->val;
+if (percentile_value > 1 || percentile_value <0)
+{
+std::stringstream error_msg;
+error_msg<< "The percentile must between 0 and 1, but input is:"
<< std::to_string(percentile_value);
+ctx->set_error(error_msg.str().c_str());
+return DoubleVal::null();
+}
+
+if (src.len == 0) {
+auto quantile_state =
reinterpret_cast*>(src.ptr);
+return
{static_cast(quantile_state->get_value_by_percentile(percentile_value))};
+} else {
+QuantileState quantile_state(Slice(src.ptr, src.len));
+return
{static_cast(quantile_state.get_value_by_percentile(percentile_value))};
+}
+
+
+} else {
+std::stringstream error_msg;
+error_msg << "quantile_percent function's second argument must be
constant. eg: quantile_percent(col, 0.95)";
+ctx->set_error(error_msg.str().c_str());
+}
+return DoubleVal::null();
+}
+
+StringVal QuantileStateFunctions::quantile_state_serialize(FunctionContext*
ctx, const StringVal& src) {
+if(src.is_null) {
+return src;
+
+}
+auto tmp_ptr = reinterpret_cast*>(src.ptr);
[GitHub] [incubator-doris] spaces-X commented on pull request #8234: [Feature] Support pre-aggregation for quantile type
spaces-X commented on pull request #8234: URL: https://github.com/apache/incubator-doris/pull/8234#issuecomment-1054058228 > before we release the feature, maybe we should support it in vec exec engine both. yeap, i think it is more reasonable to put it in another pr and i will implement it in the near future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
caiconghui commented on a change in pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156#discussion_r815721636
##
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowTransactionStmt.java
##
@@ -108,13 +114,29 @@ private void analyzeWhereClause() throws
AnalysisException {
txnId = ((IntLiteral) whereClause.getChild(1)).getLongValue();
} else if (leftKey.equalsIgnoreCase("label") &&
(whereClause.getChild(1) instanceof StringLiteral)) {
label = ((StringLiteral)
whereClause.getChild(1)).getStringValue();
+} else if (leftKey.equalsIgnoreCase("status") &&
(whereClause.getChild(1) instanceof StringLiteral)) {
+String txnStatus = ((StringLiteral)
whereClause.getChild(1)).getStringValue();
Review comment:
```suggestion
String txnStatus = ((StringLiteral)
whereClause.getChild(1)).getStringValue();
status = TransactionStatus.valueOf(txnStatus.toUpperCase());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8246: Remove old fe meta version
morningman merged pull request #8246: URL: https://github.com/apache/incubator-doris/pull/8246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (c66a9bf -> 27d2e3e)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from c66a9bf [fix](be-ut) fix unit test bug for tablet_info_test (#8253) add 27d2e3e [refactor](fe) Remove old fe meta version (#8246) No new revisions were added by this update. Summary of changes: be/src/runtime/string_search.hpp | 68 ++--- .../java/org/apache/doris/alter/AlterJobV2.java| 20 +- .../java/org/apache/doris/alter/RollupJobV2.java | 4 +- .../org/apache/doris/alter/SchemaChangeJobV2.java | 39 +-- .../org/apache/doris/analysis/DateLiteral.java | 28 +- .../java/org/apache/doris/analysis/LabelName.java | 9 +- .../java/org/apache/doris/analysis/TableRef.java | 13 +- .../java/org/apache/doris/backup/BackupJob.java| 5 - .../java/org/apache/doris/backup/BackupMeta.java | 5 - .../java/org/apache/doris/backup/RestoreJob.java | 4 - .../java/org/apache/doris/catalog/Catalog.java | 299 + .../apache/doris/catalog/CatalogRecycleBin.java| 11 +- .../apache/doris/catalog/ColocateTableIndex.java | 89 +++--- .../main/java/org/apache/doris/catalog/Column.java | 40 +-- .../java/org/apache/doris/catalog/ColumnType.java | 7 +- .../java/org/apache/doris/catalog/Database.java| 45 ++-- .../java/org/apache/doris/catalog/DiskInfo.java| 25 +- .../java/org/apache/doris/catalog/EsTable.java | 125 - .../java/org/apache/doris/catalog/FsBroker.java| 11 +- .../java/org/apache/doris/catalog/MetaObject.java | 10 +- .../java/org/apache/doris/catalog/MysqlTable.java | 40 ++- .../java/org/apache/doris/catalog/OlapTable.java | 102 ++- .../java/org/apache/doris/catalog/Partition.java | 35 +-- .../org/apache/doris/catalog/PartitionInfo.java| 7 +- .../apache/doris/catalog/RangePartitionInfo.java | 13 +- .../java/org/apache/doris/catalog/Replica.java | 11 +- .../main/java/org/apache/doris/catalog/Table.java | 13 +- .../main/java/org/apache/doris/catalog/Tablet.java | 9 +- .../org/apache/doris/catalog/TempPartitions.java | 11 +- .../org/apache/doris/load/BrokerFileGroup.java | 17 +- .../java/org/apache/doris/load/DeleteInfo.java | 48 +--- .../main/java/org/apache/doris/load/DppConfig.java | 19 +- .../main/java/org/apache/doris/load/ExportJob.java | 40 +-- .../org/apache/doris/load/HadoopEtlJobInfo.java| 11 +- .../main/java/org/apache/doris/load/LoadJob.java | 96 +++ .../main/java/org/apache/doris/load/Source.java| 8 +- .../java/org/apache/doris/load/TabletLoadInfo.java | 6 +- .../org/apache/doris/load/loadv2/BulkLoadJob.java | 41 +-- .../java/org/apache/doris/load/loadv2/LoadJob.java | 58 .../org/apache/doris/load/loadv2/SparkLoadJob.java | 5 +- .../load/routineload/KafkaRoutineLoadJob.java | 15 +- .../doris/load/routineload/RoutineLoadJob.java | 43 +-- .../org/apache/doris/mysql/privilege/PaloAuth.java | 4 +- .../org/apache/doris/mysql/privilege/PaloRole.java | 14 +- .../apache/doris/mysql/privilege/PrivEntry.java| 8 +- .../apache/doris/mysql/privilege/UserProperty.java | 80 +- .../apache/doris/mysql/privilege/WhiteList.java| 72 + .../apache/doris/persist/ColocatePersistInfo.java | 20 +- .../org/apache/doris/persist/CreateTableInfo.java | 11 +- .../org/apache/doris/persist/DatabaseInfo.java | 16 +- .../java/org/apache/doris/persist/DropDbInfo.java | 12 +- .../java/org/apache/doris/persist/DropInfo.java| 6 +- .../apache/doris/persist/DropPartitionInfo.java| 12 +- .../apache/doris/persist/ModifyPartitionInfo.java | 4 +- .../apache/doris/persist/PartitionPersistInfo.java | 16 +- .../java/org/apache/doris/persist/PrivInfo.java| 8 +- .../apache/doris/persist/ReplicaPersistInfo.java | 23 +- .../apache/doris/persist/TablePropertyInfo.java| 14 +- .../apache/doris/persist/TruncateTableInfo.java| 12 +- .../java/org/apache/doris/qe/SessionVariable.java | 55 +--- .../main/java/org/apache/doris/qe/VariableMgr.java | 7 +- .../main/java/org/apache/doris/system/Backend.java | 59 ++-- .../java/org/apache/doris/system/Frontend.java | 8 +- .../org/apache/doris/system/SystemInfoService.java | 5 - .../apache/doris/transaction/TransactionState.java | 44 +-- .../org/apache/doris/alter/RollupJobV2Test.java| 2 - .../java/org/apache/doris/catalog/FakeCatalog.java | 5 - .../doris/external/elasticsearch/EsTestCase.java | 1 - 68 files changed, 534 insertions(+), 1489 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #8247: [refactor] Upgrade to MySQL 5.7.37 to reduce unnecessary CVE issues
morningman commented on pull request #8247: URL: https://github.com/apache/incubator-doris/pull/8247#issuecomment-1054074936 Hi @aopangzi , please rebase the master to solve the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8252: [community] add more collaborators in .asf.yaml (#8029)
morningman merged pull request #8252: URL: https://github.com/apache/incubator-doris/pull/8252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [community] add more collaborators in .asf.yaml (#8029) (#8252)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 01365f1 [community] add more collaborators in .asf.yaml (#8029) (#8252) 01365f1 is described below commit 01365f1a1d6eaaf14a6492f38676788d71c2424e Author: Mingyu Chen AuthorDate: Mon Feb 28 17:49:11 2022 +0800 [community] add more collaborators in .asf.yaml (#8029) (#8252) Add following 2 collaborators: zuochunwei thomascai126 --- .asf.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.asf.yaml b/.asf.yaml index be6a58b..158c8d1 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -42,3 +42,5 @@ github: - tinke - luzhijing - spaces-X +- zuochunwei +- thomascai126 - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] wangbo opened a new pull request #8267: [fix](vectorization)Some small fix for SegmentIter Vectorization
wangbo opened a new pull request #8267: URL: https://github.com/apache/incubator-doris/pull/8267 # Proposed changes 1 No longer using short-circuit to evaluate date type, because the cost of read date type is small, lazy materialization has higher costs. 2 Fix read hll/bitmap/date type error results. ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qidaye opened a new pull request #8268: [fix](fold-constant)(hive) fix constant-folding in order by and optimize logs in hive client
qidaye opened a new pull request #8268: URL: https://github.com/apache/incubator-doris/pull/8268 # Proposed changes fix: #7509 1. fix order by clause constant folding 2. optimize Hive exception message 3. change hive file status log type ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris-flink-connector] madongz opened a new pull request #12: [refactor]doris sink enable 2pc
madongz opened a new pull request #12: URL: https://github.com/apache/incubator-doris-flink-connector/pull/12 # Proposed changes Issue Number: close #xxx ## Problem Summary: At present, Doris has supported 2pc. On this basis, we have implemented doris-flink-connector based on Flink's unified sink API, DorisWriter uploads data via http in streaming mode and DorisCommitter commit the transaction after checkpoint completed. ## Main Change Points 1. Replace output format with DorisSink. 2. Unified serialization interface, user could implement DorisRecordSerializer to define how to serialize record. 3. Upload data in streaming mode. ## Data processing flow 1. when job start or checkpoint, doris writer send new http request to doris for load. 2. write data into data stream. 3. before next checkpoint, mark data load finished and get the http response. 4. get txnId from response and send to doris committer. 5. after checkpoint completed, doris committer commit the transactions. ## Checklist(Required) 1. Does it affect the original behavior: (Yes) 7. Has unit tests been added: (Yes) 8. Has document been added or modified: (Todo) 9. Does it need to update dependencies: (No) 10. Are there any changes that cannot be rolled back: (No) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] dataroaring opened a new pull request #8271: make options of build.sh and run-be-ut.sh work
dataroaring opened a new pull request #8271: URL: https://github.com/apache/incubator-doris/pull/8271 The h option of build.sh and j option of run-be-ut.sh do not work in the docker with image apache/incubator-doris:build-env-ldb-toolchain-latest. # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8271: make options of build.sh and run-be-ut.sh work
github-actions[bot] commented on pull request #8271: URL: https://github.com/apache/incubator-doris/pull/8271#issuecomment-1054268899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8256: [Enhancement](routine-load) Support routine load task succeed with empty data consumed
github-actions[bot] commented on pull request #8256: URL: https://github.com/apache/incubator-doris/pull/8256#issuecomment-1054273002 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8268: [fix](fold-constant)(hive) fix constant-folding in order by and optimize logs in hive client
github-actions[bot] commented on pull request #8268: URL: https://github.com/apache/incubator-doris/pull/8268#issuecomment-1054303894 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #8268: [fix](fold-constant)(hive) fix constant-folding in order by and optimize logs in hive client
jackwener commented on pull request #8268: URL: https://github.com/apache/incubator-doris/pull/8268#issuecomment-1054304192 @steadyBoy Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] leafgodgood removed a comment on issue #6483: New Optimizer
leafgodgood removed a comment on issue #6483: URL: https://github.com/apache/incubator-doris/issues/6483#issuecomment-908509707 【英文缩写】 3R 【词性类别】 生物科学 【英文全称】 Reduction Refinement Replacement 【中文解释】 减少、优化和替代 【缩写简介】 在对待实验动物问题上，国际上目前推崇的“3R法则”。减少，即可能减少实验中所用动物的数量，提高实验动物的利用率核试验的精确度；优化，即减少动物的精神紧张和痛苦；替代，即不再利用活体动物进行试验。而是以单细胞生物、微生物或细胞、组织、器官甚至电脑模拟来加以替代。 借鉴生物学科界的”3R法则“，建议一个名字：3R优化器（3R-Optimizer） 缘由:1、简单、易记、有意义 2、优化器主要也是来减少、优化、替代一些算子或执行计划等来实现优化的目的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] longfengpili opened a new issue #8272: failed to get tuple idx when prepare with tuple id: 6, slot id: 20
longfengpili opened a new issue #8272: URL: https://github.com/apache/incubator-doris/issues/8272 ### Discussed in https://github.com/apache/incubator-doris/discussions/8270 Originally posted by **longfengpili** February 28, 2022 SQL 错误 [1105] [HY000]: errCode = 2, detailMessage = failed to get tuple idx when prepare with tuple id: 6, slot id: 20 ```sql drop table if exists test.new_user1; create table if not exists test.new_user1( role_id varchar(255), gsrv_id varchar(255), iap float, INDEX uid (role_id) USING BITMAP COMMENT 'uid索引' ) ENGINE=OLAP DUPLICATE KEY(role_id, gsrv_id) COMMENT "OLAP" DISTRIBUTED BY HASH(role_id) BUCKETS 10 PROPERTIES ( "replication_num" = "1", "in_memory" = "false", "storage_format" = "V2" ); truncate table test.new_user1; insert into test.new_user1 (role_id, gsrv_id, iap ) with raw_t as ( select date, role_id, gsrv_id, row_number()over(partition by role_id, gsrv_id order by date asc) as rn from test.user_daily where role_id = '708542885217499579' ), first_t as ( select role_id, date as reg_day, gsrv_id from raw_t where rn=1 ), iap_temp as ( select row_number()over(partition by role_id, gsrv_id order by time asc) as rn, time, role_id, gsrv_id, round(currency_amount/currency_rate/100,2) as iap -- sum(round(currency_amount/(currency_rate*100),2)) as iap from test.pcenter_role_credit as a left join fact_10001123_15.currency_type as b on a.currency_type=b.currency_id where time>="2022-01-13 00:00:00" -- group by 1, 2, 3 ), iap_t_1 as ( select * from iap_temp where rn=1 ), tx as ( select a.role_id, a.gsrv_id, b.iap from first_t as a left join iap_t_1 b on a.role_id = b.role_id and a.gsrv_id = b.gsrv_id ) select role_id, gsrv_id, iap from tx ; ``` insert 下面语句能正常返回，返回内容： |role_id|gsrv_id|iap| |--|--|--| |708542885217499579|20007|0.99| |708542885217499579|20008|null| |708542885217499579|20009|null| 这个报错是什么意思呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] longfengpili commented on issue #8272: failed to get tuple idx when prepare with tuple id: 6, slot id: 20
longfengpili commented on issue #8272: URL: https://github.com/apache/incubator-doris/issues/8272#issuecomment-1054873530 如果修改为sum就可以 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8268: [fix](fold-constant)(hive) fix constant-folding in order by and optimize logs in hive client
github-actions[bot] commented on pull request #8268: URL: https://github.com/apache/incubator-doris/pull/8268#issuecomment-1054898532 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] branch master updated: [chore] modify some script for building connector (#7)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git The following commit(s) were added to refs/heads/master by this push: new d2e3f7e [chore] modify some script for building connector (#7) d2e3f7e is described below commit d2e3f7e71f6807d91f83e052c91052aefab763fb Author: Mingyu Chen AuthorDate: Tue Mar 1 10:00:20 2022 +0800 [chore] modify some script for building connector (#7) --- .asf.yaml | 41 ++ .github/workflows/build-extension.yml | 4 +-- CONTRIBUTING.md | 4 +-- CONTRIBUTING_CN.md| 7 +++-- NOTICE.txt| 2 +- spark-doris-connector/build.sh| 54 +++ spark-doris-connector/pom.xml | 19 ++-- 7 files changed, 108 insertions(+), 23 deletions(-) diff --git a/.asf.yaml b/.asf.yaml new file mode 100644 index 000..bb7e17f --- /dev/null +++ b/.asf.yaml @@ -0,0 +1,41 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +github: + description: Spark Connector for Apache Doris(incubating) + homepage: https://doris.apache.org/ + labels: +- data-warehousing +- mpp +- olap +- dbms +- apache +- doris +- spark + enabled_merge_buttons: +squash: true +merge: false +rebase: false + protected_branches: +master: + required_pull_request_reviews: +dismiss_stale_reviews: true +required_approving_review_count: 1 +notifications: + issues: commits@doris.apache.org + commits: commits@doris.apache.org + pullrequests: commits@doris.apache.org diff --git a/.github/workflows/build-extension.yml b/.github/workflows/build-extension.yml index bce2a12..38e55e5 100644 --- a/.github/workflows/build-extension.yml +++ b/.github/workflows/build-extension.yml @@ -48,9 +48,9 @@ jobs: - name: Build spark connector v2 run: | -cd spark-doris-connector/ && /bin/bash build.sh 2.3.4 2.11 +cd spark-doris-connector/ && /bin/bash build.sh --spark 2.3.4 --scala 2.11 - name: Build spark connector v3 run: | -cd spark-doris-connector/ && /bin/bash build.sh 3.1.2 2.12 +cd spark-doris-connector/ && /bin/bash build.sh --spark 3.1.2 --scala 2.12 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3c353cb..e132d9c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -17,8 +17,8 @@ specific language governing permissions and limitations under the License. --> -# Contribute to Doris +# Contribute to Doris and its surrounding projects -Thank you very much for your interest in the Doris project. We welcome your suggestions, comments (including criticisms), comments and contributions to the Doris project. +Thank you very much for your interest in the Doris and its surrounding projects. We welcome your suggestions, comments (including criticisms), comments and contributions to the Doris. For more information on how to contribute to Doris, please go to the Doris main repository [CONTRIBUTING](https://github.com/apache/incubator-doris/blob/master/CONTRIBUTING.md) diff --git a/CONTRIBUTING_CN.md b/CONTRIBUTING_CN.md index 5dc5fbe..528a1ce 100644 --- a/CONTRIBUTING_CN.md +++ b/CONTRIBUTING_CN.md @@ -17,8 +17,9 @@ specific language governing permissions and limitations under the License. --> -# 为 Doris 做贡献 -非常感谢您对 Doris 项目感兴趣，我们非常欢迎您对 Doris 项目的各种建议、意见（包括批评）、评论和贡献。 +# 为 Doris 及其周边项目做贡献 -关于如何为 Doris 做贡献，请前往 Doris 主库查阅 [CONTRIBUTING_CN](https://github.com/apache/incubator-doris/blob/master/CONTRIBUTING_CN.md) +非常感谢您对 Doris 及其周边项目感兴趣，我们非常欢迎您对 Doris 的各种建议、意见（包括批评）、评论和贡献。 + +关于如何为 Doris 及周边项目做贡献，请前往 Doris 主库查阅 [CONTRIBUTING_CN](https://github.com/apache/incubator-doris/blob/master/CONTRIBUTING_CN.md) diff --git a/NOTICE.txt b/NOTICE.txt index f8c43b1..6bb64b1 100644 --- a/NOTICE.txt +++ b/NOTICE.txt @@ -1,4 +1,4 @@ -Apache Doris (incubating) +Spark Connector for Apache Doris (incubating) Copyright 2018-2022 The Apache Software Foundation This product includes software developed at diff --git a/spark-doris-connecto
[incubator-doris-spark-connector] annotated tag 2.3.4-2.11-1.0.0 updated (5a67837 -> dbb5f2a)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 2.3.4-2.11-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git. *** WARNING: tag 2.3.4-2.11-1.0.0 was modified! *** from 5a67837 (commit) to dbb5f2a (tag) tagging 5a6783703e273dc0171cc0709599af6f56195777 (commit) by morningman on Tue Mar 1 10:25:49 2022 +0800 - Log - [maven-release-plugin] copy for tag 2.3.4-2.11-1.0.0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yiguolei opened a new pull request #8273: [Refactor] Remove agent status
yiguolei opened a new pull request #8273: URL: https://github.com/apache/incubator-doris/pull/8273 # Proposed changes Issue Number: close #xxx ## Problem Summary: There are 3 error code types in BE: OLAPStatus AgentStatus Status. It is very confused and sometimes conflict during write code. I will try to unify them to Status. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] annotated tag 2.3.4-2.11-1.0.0 updated (51debfd -> b88974f)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 2.3.4-2.11-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git. *** WARNING: tag 2.3.4-2.11-1.0.0 was modified! *** from 51debfd (commit) to b88974f (tag) tagging 51debfd8c10b61e18b126864397ed4d18954 (commit) by morningman on Tue Mar 1 10:31:20 2022 +0800 - Log - [maven-release-plugin] copy for tag 2.3.4-2.11-1.0.0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] weizuo93 commented on a change in pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
weizuo93 commented on a change in pull request #8156:
URL: https://github.com/apache/incubator-doris/pull/8156#discussion_r816404516
##
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowTransactionStmt.java
##
@@ -108,13 +114,29 @@ private void analyzeWhereClause() throws
AnalysisException {
txnId = ((IntLiteral) whereClause.getChild(1)).getLongValue();
} else if (leftKey.equalsIgnoreCase("label") &&
(whereClause.getChild(1) instanceof StringLiteral)) {
label = ((StringLiteral)
whereClause.getChild(1)).getStringValue();
+} else if (leftKey.equalsIgnoreCase("status") &&
(whereClause.getChild(1) instanceof StringLiteral)) {
+String txnStatus = ((StringLiteral)
whereClause.getChild(1)).getStringValue();
Review comment:
>
Thanks for your code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris-spark-connector] morningman opened a new pull request #8: [chore] add release plugin
morningman opened a new pull request #8: URL: https://github.com/apache/incubator-doris-spark-connector/pull/8 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris-spark-connector] morningman merged pull request #8: [chore] add release plugin
morningman merged pull request #8: URL: https://github.com/apache/incubator-doris-spark-connector/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] branch master updated: [chore] add release plugin (#8)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git
The following commit(s) were added to refs/heads/master by this push:
new 208624a [chore] add release plugin (#8)
208624a is described below
commit 208624adf13b24baa9f2318f23a1309a2a5baf71
Author: Mingyu Chen
AuthorDate: Tue Mar 1 10:41:21 2022 +0800
[chore] add release plugin (#8)
---
spark-doris-connector/pom.xml | 8
1 file changed, 8 insertions(+)
diff --git a/spark-doris-connector/pom.xml b/spark-doris-connector/pom.xml
index 492e501..f787920 100644
--- a/spark-doris-connector/pom.xml
+++ b/spark-doris-connector/pom.xml
@@ -396,6 +396,14 @@
+
+org.apache.maven.plugins
+maven-release-plugin
+3.0.0-M5
+
+${releaseArgs}
+
+
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] annotated tag 2.3.4-2.11-1.0.0 updated (183a031 -> 24ee1ea)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 2.3.4-2.11-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git. *** WARNING: tag 2.3.4-2.11-1.0.0 was modified! *** from 183a031 (commit) to 24ee1ea (tag) tagging 183a031c28ac2cbd0eb499c7d1d34082d0e4be2b (commit) by morningman on Tue Mar 1 10:44:09 2022 +0800 - Log - [maven-release-plugin] copy for tag 2.3.4-2.11-1.0.0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris-spark-connector] annotated tag 3.1.2-2.12-1.0.0 updated (353fa68 -> 8238868)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to annotated tag 3.1.2-2.12-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris-spark-connector.git. *** WARNING: tag 3.1.2-2.12-1.0.0 was modified! *** from 353fa68 (commit) to 8238868 (tag) tagging 353fa6852f8b3b2625ae801e5fb287c1cb61c647 (commit) by morningman on Tue Mar 1 10:49:35 2022 +0800 - Log - [maven-release-plugin] copy for tag 3.1.2-2.12-1.0.0 --- No new revisions were added by this update. Summary of changes: - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
svn commit: r52787 - in /dev/incubator/doris/spark-connector: ./ 1.0.0/
Author: morningman Date: Tue Mar 1 02:57:20 2022 New Revision: 52787 Log: release spark connector v1.0.0 for doris Added: dev/incubator/doris/spark-connector/ dev/incubator/doris/spark-connector/1.0.0/ dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz (with props) dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.asc dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.sha512 dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz (with props) dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz.asc dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz.sha512 Added: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz == Binary file - no diff available. Propchange: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz -- svn:mime-type = application/octet-stream Added: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.asc == --- dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.asc (added) +++ dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.asc Tue Mar 1 02:57:20 2022 @@ -0,0 +1,14 @@ +-BEGIN PGP SIGNATURE- + +iQHKBAABCAA0FiEEfDkqHpxmyczPOIYY8QYm42JFg8sFAmIdiv8WHGNoZW5taW5n +eXVAYXBhY2hlLm9yZwAKCRDxBibjYkWDywwNDACAu5cWUV1wuRul6d4QBZhPUEOu +QaWI4n8V85/Y+6Y6cyKh5Ru6qn3JCsi7nvMmdA4JBZY5Y3EPT0ScvD67iwc+WZ3C +IzYYlmgP2agySoQEaF8g4hveQDXCIJRvvcsg1FKyTYSNH9kLVUDEzZ3HTLI2tHEk +Mg3KnpmPYPIXoP05VYmU2T+cxg3t+ER6kJEXKeEYVhQMfMhMnMHjtItZUdt5wq+u +UHGfCJM+KWi6IW4hyebrad7Lt/hUZzDobNk8sjwa60i6BFKeM5Gl0ljFxv3ttJKC +skqMx0g6ZNWR7JZirmuENjrxO44N23Wv2hYK9ysee0WGV8ur3jcMgOTL+1vbGYve +WLzMgfZNX08VlCyUk2r6/yGAziAjJgkiuZKBdsVYYBhjoJ8ZZ8e9vX6NgPkrYPBT +pDrFOl5T3KbjpSAeINXAyGX10jReQSzdonvaqTkopspHHbbzUPmgygG8h4u1bOis +4juo7F+dYkLYO94nlxYXl0Ck8LSJb1/wPcK09EM= +=8aOC +-END PGP SIGNATURE- Added: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.sha512 == --- dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.sha512 (added) +++ dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz.sha512 Tue Mar 1 02:57:20 2022 @@ -0,0 +1 @@ +8874a9ce4822f3ac1e0bb1dd4e3f9fd5daf888c37bf6ccf8b43ba9d64376cea5553627bc4d99980cf08242312ce44bc5f6e14c27d9ed244d91183005a200 apache-doris-spark-connector-2.3.4-2.11-1.0.0-incubating-src.tar.gz Added: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz == Binary file - no diff available. Propchange: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz -- svn:mime-type = application/octet-stream Added: dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz.asc == --- dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz.asc (added) +++ dev/incubator/doris/spark-connector/1.0.0/apache-doris-spark-connector-3.1.2-2.12-1.0.0-incubating-src.tar.gz.asc Tue Mar 1 02:57:20 2022 @@ -0,0 +1,14 @@ +-BEGIN PGP SIGNATURE- + +iQHKBAABCAA0FiEEfDkqHpxmyczPOIYY8QYm42JFg8sFAmIdiw8WHGNoZW5taW5n +eXVAYXBhY2hlLm9yZwAKCRDxBibjYkWDywZ7DACqlfpXT8p1eUaKV4QWnDeg8qHs +2fR0azWinNKdImcN9vpb2UTW9uXkoN2a5RNcyAN5KZsM+dZ61qWzqNftVOD0PyRi +2Fd9zj6O7qlVz9/83TG5UihLHTlu0VGB7BtRDK+LkP5lCZUbNcxmSNlapcrDyFDb +fzTLZ1Wi+ryHqHd+CE5tMaKitvCC5L8s2LF6ltK2+Wc6qB1iuybHv8pNoJB3JOYK +AIVf+GPODknMTHrxesCriUHj6dSpo6LYEUzk5taPrjWQYfQTgNffE515GMka3h98 +mTlvW1c94BjLQCAMq0EBjXqOrtOWk8oEe8ONpVBioyMSyroahJpdBEheqgkRqNIM +FQrCfrZ4W6oJtbc+WH9yUhOhXScxYOVbeqlKCwEulODSkG0xmtNW+gSFdLCTamVx +KTr7JWa5mnCLGTEUYtlzZ3hcfX7cMMigY4vDf1Dfjs7cGjDdmFP7bNs3VsqucwE0 +AXv/ZU5hIuQ97pqIcJRUB3XxAx8VQDxZvOhwRz0= +=tAb6 +-END PGP SIGNATU
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8202: [[improvment] show export support label like
EmmyMiao87 commented on a change in pull request #8202:
URL: https://github.com/apache/incubator-doris/pull/8202#discussion_r816409256
##
File path: docs/en/sql-reference/sql-statements/Data Manipulation/SHOW EXPORT.md
##
@@ -61,6 +61,9 @@ Explain:
5. Show the export task of specifying dB and label
SHOW EXPORT FROM example_db WHERE LABEL = "mylabel";
+6. Show the export task of specifying dB and label prefix is "labelprefix"
Review comment:
```suggestion
6. Show the export task of specifying DB and label prefix is "labelprefix"
```
##
File path: docs/zh-CN/sql-reference/sql-statements/Data Manipulation/SHOW
EXPORT.md
##
@@ -61,6 +61,9 @@ under the License.
5. 展示指定db，指定label的导出任务
SHOW EXPORT FROM example_db WHERE LABEL = "mylabel";
+6. 展示指定db，label中前缀是labelprefix的导出任务
Review comment:
```suggestion
6. 展示指定 db，label 中前缀是 labelprefix 的导出任务
```
##
File path: docs/en/sql-reference/sql-statements/Data Manipulation/SHOW EXPORT.md
##
@@ -61,6 +61,9 @@ Explain:
5. Show the export task of specifying dB and label
Review comment:
```suggestion
5. Show the export task of specifying DB and label
```
##
File path:
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowExportStmt.java
##
@@ -132,82 +137,47 @@ private void analyzePredicate(Expr whereExpr) throws
AnalysisException {
return;
}
-boolean valid = true;
-boolean hasJobId = false;
-boolean hasState = false;
-boolean hasLabel = false;
-
-CHECK: {
-// check predicate type
-if (whereExpr instanceof BinaryPredicate) {
-BinaryPredicate binaryPredicate = (BinaryPredicate) whereExpr;
-if (binaryPredicate.getOp() != Operator.EQ) {
-valid = false;
-break CHECK;
-}
-} else {
-valid = false;
-break CHECK;
-}
-
-// left child
-if (!(whereExpr.getChild(0) instanceof SlotRef)) {
-valid = false;
-break CHECK;
-}
-String leftKey = ((SlotRef) whereExpr.getChild(0)).getColumnName();
-if (leftKey.equalsIgnoreCase("id")) {
-hasJobId = true;
-} else if (leftKey.equalsIgnoreCase("state")) {
-hasState = true;
-} else if (leftKey.equalsIgnoreCase("label")) {
-hasLabel = true;
-} else {
-valid = false;
-break CHECK;
-}
-
-// right child
-if (hasState) {
-if (!(whereExpr.getChild(1) instanceof StringLiteral)) {
-valid = false;
-break CHECK;
+boolean valid = false;
+
+// enumerate all possible conditions
+if (whereExpr.getChild(0) instanceof SlotRef) {
Review comment:
Could you please add some test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8251: [improvement](lateral-view) Add number rows filtered in profile
morningman merged pull request #8251: URL: https://github.com/apache/incubator-doris/pull/8251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8254: [doc] Modify document of compilation on ARM64
morningman merged pull request #8254: URL: https://github.com/apache/incubator-doris/pull/8254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (01365f1 -> e77e2b0)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 01365f1 [community] add more collaborators in .asf.yaml (#8029) (#8252) add e77e2b0 [improvement](lateral-view) Add number rows filtered in profile (#8251) No new revisions were added by this update. Summary of changes: be/src/exec/table_function_node.cpp| 8 +++- be/src/exec/table_function_node.h | 3 +++ be/src/exprs/table_function/explode_bitmap.cpp | 4 +++- be/src/exprs/table_function/explode_json_array.cpp | 14 ++ be/src/exprs/table_function/explode_split.cpp | 1 + be/src/exprs/table_function/table_function.h | 1 + 6 files changed, 29 insertions(+), 2 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (e77e2b0 -> 13f007b)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from e77e2b0 [improvement](lateral-view) Add number rows filtered in profile (#8251) add 13f007b [doc] Modify document of compilation on ARM64 (#8254) No new revisions were added by this update. Summary of changes: docker/Dockerfile| 2 +- docs/en/installing/compilation-arm.md| 29 + docs/zh-CN/installing/compilation-arm.md | 30 +- 3 files changed, 43 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8156: [Transactions][Stmt] Support view transactions info for specified status by `SHOW TRANSACTION` stmt
github-actions[bot] commented on pull request #8156: URL: https://github.com/apache/incubator-doris/pull/8156#issuecomment-1054948848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [typo] fix listdb description error (#8257)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0fce094 [typo] fix listdb description error (#8257)
0fce094 is described below
commit 0fce094080dcfc721b8f0e393adf1b7db2aa6399
Author: ZHAOLIPAN <1185807...@qq.com>
AuthorDate: Tue Mar 1 11:08:34 2022 +0800
[typo] fix listdb description error (#8257)
Co-authored-by: zhaolipan
---
fe/fe-core/src/main/java/org/apache/doris/PaloFe.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
index e5e04ba..c1be920 100755
--- a/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/PaloFe.java
@@ -213,7 +213,7 @@ public class PaloFe {
options.addOption("v", "version", false, "Print the version of Palo
Frontend");
options.addOption("h", "helper", true, "Specify the helper node when
joining a bdb je replication group");
options.addOption("b", "bdb", false, "Run bdbje debug tools");
-options.addOption("l", "listdb", false, "Run bdbje debug tools");
+options.addOption("l", "listdb", false, "List databases in bdbje");
options.addOption("d", "db", true, "Specify a database in bdbje");
options.addOption("s", "stat", false, "Print statistic of a database,
including count, first key, last key");
options.addOption("f", "from", true, "Specify the start scan key");
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8257: fix listdb description error
morningman merged pull request #8257: URL: https://github.com/apache/incubator-doris/pull/8257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8261: [Bug][Vectorized] fix bitmap_ut result wrong && fix schema_change compile error
morningman merged pull request #8261: URL: https://github.com/apache/incubator-doris/pull/8261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #8260: [Bug][Vectorized] fix bitmap_ut result wrong && fix schema_change compile error
morningman closed issue #8260: URL: https://github.com/apache/incubator-doris/issues/8260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8263: [refactor] remove unused new_in_predicate code
morningman merged pull request #8263: URL: https://github.com/apache/incubator-doris/pull/8263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman closed issue #8264: [Bug] Insert into with select constants failed
morningman closed issue #8264: URL: https://github.com/apache/incubator-doris/issues/8264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8265: [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency
morningman merged pull request #8265: URL: https://github.com/apache/incubator-doris/pull/8265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (0fce094 -> 7d0e36a)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0fce094 [typo] fix listdb description error (#8257) add 7d0e36a [fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error (#8261) No new revisions were added by this update. Summary of changes: be/test/olap/schema_change_test.cpp | 96 ++- be/test/vec/function/function_bitmap_test.cpp | 39 ++- 2 files changed, 70 insertions(+), 65 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (7d0e36a -> 757e357)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 7d0e36a [fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error (#8261) add 757e357 [refactor] remove unused new_in_predicate code (#8263) No new revisions were added by this update. Summary of changes: be/src/common/daemon.cpp | 2 - be/src/exprs/CMakeLists.txt | 1 - be/src/exprs/new_in_predicate.cpp | 185 be/src/exprs/new_in_predicate.h | 348 -- 4 files changed, 536 deletions(-) delete mode 100644 be/src/exprs/new_in_predicate.cpp delete mode 100644 be/src/exprs/new_in_predicate.h - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (757e357 -> 93c638f)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 757e357 [refactor] remove unused new_in_predicate code (#8263) add 93c638f [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency (#8265) No new revisions were added by this update. Summary of changes: fe/fe-core/pom.xml | 2 +- .../apache/doris/analysis/CreateFunctionStmt.java | 2 +- .../java/org/apache/doris/analysis/InsertStmt.java | 4 +- .../org/apache/doris/rpc/BackendServiceClient.java | 2 +- .../org/apache/doris/planner/QueryPlanTest.java| 62 ++ fe/pom.xml | 2 +- 6 files changed, 48 insertions(+), 26 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] liaoxin01 opened a new pull request #8274: [Docs] Fix a typo in downloads.md
liaoxin01 opened a new pull request #8274: URL: https://github.com/apache/incubator-doris/pull/8274 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8274: [Docs] Fix a typo in downloads.md
github-actions[bot] commented on pull request #8274: URL: https://github.com/apache/incubator-doris/pull/8274#issuecomment-1054957266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch dev-1.0.0 updated (699d065 -> 2be9380)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch dev-1.0.0 in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 699d065 [fix](olap) add check statement to protect get_dict_word_info() from crash (#8241) new dfb0076 [improvement](lateral-view) Add number rows filtered in profile (#8251) new 2efcbfa [fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error (#8261) new 3c872f2 [refactor] remove unused new_in_predicate code (#8263) new 2be9380 [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency (#8265) The 4 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: be/src/common/daemon.cpp | 2 - be/src/exec/table_function_node.cpp| 8 +- be/src/exec/table_function_node.h | 3 + be/src/exprs/CMakeLists.txt| 1 - be/src/exprs/new_in_predicate.cpp | 185 --- be/src/exprs/new_in_predicate.h| 348 - be/src/exprs/table_function/explode_bitmap.cpp | 4 +- be/src/exprs/table_function/explode_json_array.cpp | 14 + be/src/exprs/table_function/explode_split.cpp | 1 + be/src/exprs/table_function/table_function.h | 1 + be/test/olap/schema_change_test.cpp| 96 +++--- be/test/vec/function/function_bitmap_test.cpp | 39 +-- fe/fe-core/pom.xml | 2 +- .../apache/doris/analysis/CreateFunctionStmt.java | 2 +- .../java/org/apache/doris/analysis/InsertStmt.java | 4 +- .../org/apache/doris/rpc/BackendServiceClient.java | 2 +- .../org/apache/doris/planner/QueryPlanTest.java| 62 ++-- fe/pom.xml | 2 +- 18 files changed, 147 insertions(+), 629 deletions(-) delete mode 100644 be/src/exprs/new_in_predicate.cpp delete mode 100644 be/src/exprs/new_in_predicate.h - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 01/04: [improvement](lateral-view) Add number rows filtered in profile (#8251)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.0
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit dfb0076ac04e6b66a861a868a351a0ae4500fe11
Author: Mingyu Chen
AuthorDate: Tue Mar 1 11:04:57 2022 +0800
[improvement](lateral-view) Add number rows filtered in profile (#8251)
Add `RowsFiltered` counter in TableFunctionNode profile.
So that we can know the total number of rows that TableFunctionNode
processed
---
be/src/exec/table_function_node.cpp| 8 +++-
be/src/exec/table_function_node.h | 3 +++
be/src/exprs/table_function/explode_bitmap.cpp | 4 +++-
be/src/exprs/table_function/explode_json_array.cpp | 14 ++
be/src/exprs/table_function/explode_split.cpp | 1 +
be/src/exprs/table_function/table_function.h | 1 +
6 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/be/src/exec/table_function_node.cpp
b/be/src/exec/table_function_node.cpp
index 6eac8eb..8829c79 100644
--- a/be/src/exec/table_function_node.cpp
+++ b/be/src/exec/table_function_node.cpp
@@ -81,7 +81,9 @@ Status TableFunctionNode::_prepare_output_slot_ids(const
TPlanNode& tnode) {
Status TableFunctionNode::prepare(RuntimeState* state) {
RETURN_IF_ERROR(ExecNode::prepare(state));
-
+
+_num_rows_filtered_counter = ADD_COUNTER(_runtime_profile, "RowsFiltered",
TUnit::UNIT);
+
RETURN_IF_ERROR(Expr::prepare(_fn_ctxs, state, _row_descriptor,
expr_mem_tracker()));
for (auto fn : _fns) {
RETURN_IF_ERROR(fn->prepare());
@@ -303,6 +305,7 @@ Status TableFunctionNode::get_next(RuntimeState* state,
RowBatch* row_batch, boo
++_num_rows_returned;
} else {
tuple_ptr = pre_tuple_ptr;
+++_num_rows_filtered;
}
// Forward after write success.
@@ -340,6 +343,9 @@ Status TableFunctionNode::close(RuntimeState* state) {
}
RETURN_IF_ERROR(exec_debug_action(TExecNodePhase::CLOSE));
Expr::close(_fn_ctxs, state);
+
+COUNTER_SET(_num_rows_filtered_counter,
static_cast(_num_rows_filtered));
+
return ExecNode::close(state);
}
diff --git a/be/src/exec/table_function_node.h
b/be/src/exec/table_function_node.h
index daf4d91..0e59790 100644
--- a/be/src/exec/table_function_node.h
+++ b/be/src/exec/table_function_node.h
@@ -74,6 +74,9 @@ private:
std::vector _child_slot_sizes;
// indicate if child node reach the end
bool _child_eos = false;
+
+RuntimeProfile::Counter* _num_rows_filtered_counter = nullptr;
+uint64_t _num_rows_filtered = 0;
};
}; // namespace doris
diff --git a/be/src/exprs/table_function/explode_bitmap.cpp
b/be/src/exprs/table_function/explode_bitmap.cpp
index 1d1ca4d..3b5518b 100644
--- a/be/src/exprs/table_function/explode_bitmap.cpp
+++ b/be/src/exprs/table_function/explode_bitmap.cpp
@@ -22,7 +22,9 @@
namespace doris {
-ExplodeBitmapTableFunction::ExplodeBitmapTableFunction() {}
+ExplodeBitmapTableFunction::ExplodeBitmapTableFunction() {
+_fn_name = "explode_bitmap";
+}
ExplodeBitmapTableFunction::~ExplodeBitmapTableFunction() {
if (_cur_iter != nullptr) {
diff --git a/be/src/exprs/table_function/explode_json_array.cpp
b/be/src/exprs/table_function/explode_json_array.cpp
index 43fb1f3..59db64e 100644
--- a/be/src/exprs/table_function/explode_json_array.cpp
+++ b/be/src/exprs/table_function/explode_json_array.cpp
@@ -128,6 +128,20 @@ int ParsedData::set_output(ExplodeJsonArrayType type,
rapidjson::Document& docum
ExplodeJsonArrayTableFunction::ExplodeJsonArrayTableFunction(ExplodeJsonArrayType
type)
: _type(type) {
+switch (type) {
+case ExplodeJsonArrayType::INT:
+_fn_name = "explode_json_array_int";
+break;
+case ExplodeJsonArrayType::DOUBLE:
+_fn_name = "explode_json_array_double";
+break;
+case ExplodeJsonArrayType::STRING:
+_fn_name = "explode_json_array_string";
+break;
+default:
+_fn_name = "unknown";
+break;
+}
}
ExplodeJsonArrayTableFunction::~ExplodeJsonArrayTableFunction() {
diff --git a/be/src/exprs/table_function/explode_split.cpp
b/be/src/exprs/table_function/explode_split.cpp
index b1a0fe7..fa576dc 100644
--- a/be/src/exprs/table_function/explode_split.cpp
+++ b/be/src/exprs/table_function/explode_split.cpp
@@ -24,6 +24,7 @@
namespace doris {
ExplodeSplitTableFunction::ExplodeSplitTableFunction() {
+_fn_name = "explode_split";
}
ExplodeSplitTableFunction::~ExplodeSplitTableFunction() {
diff --git a/be/src/exprs/table_function/table_function.h
b/be/src/exprs/table_function/table_function.h
index a2b8b00..9671e6b 100644
--- a/be/src/exprs/table_function/table_function.h
+++ b/be/src/exprs/table_function/table_function.h
@@ -42,6 +42,7 @@ public:
virtual Status forward(bool *eos) = 0
[incubator-doris] 04/04: [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency (#8265)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.0
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 2be9380508085051881b3617546f0ac992dedd47
Author: Mingyu Chen
AuthorDate: Tue Mar 1 11:12:10 2022 +0800
[fix][chore](insert)(fe) Fix analysis error of insert stmt and modify
grpc-netty dependency (#8265)
This bug is introduced from #8112.
Also , I change the `grpc-netty` dependency to `grpc-netty-shaded`, to
avoid dependency conflict:
```
java.lang.NoSuchMethodError: io.netty.buffer.PooledByteBufAllocator.
```
---
fe/fe-core/pom.xml | 2 +-
.../apache/doris/analysis/CreateFunctionStmt.java | 2 +-
.../java/org/apache/doris/analysis/InsertStmt.java | 4 +-
.../org/apache/doris/rpc/BackendServiceClient.java | 2 +-
.../org/apache/doris/planner/QueryPlanTest.java| 62 ++
fe/pom.xml | 2 +-
6 files changed, 48 insertions(+), 26 deletions(-)
diff --git a/fe/fe-core/pom.xml b/fe/fe-core/pom.xml
index 9b11108..10aa192 100644
--- a/fe/fe-core/pom.xml
+++ b/fe/fe-core/pom.xml
@@ -560,7 +560,7 @@ under the License.
io.grpc
-grpc-netty
+grpc-netty-shaded
io.grpc
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
index df609a9..6a5c18d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateFunctionStmt.java
@@ -55,7 +55,7 @@ import java.util.List;
import java.util.Map;
import io.grpc.ManagedChannel;
-import io.grpc.netty.NettyChannelBuilder;
+import io.grpc.netty.shaded.io.grpc.netty.NettyChannelBuilder;
// create a user define function
public class CreateFunctionStmt extends DdlStmt {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
index f750749..cfb4ecf 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java
@@ -511,7 +511,9 @@ public class InsertStmt extends DdlStmt {
} else {
// INSERT INTO SELECT 1,2,3 ...
List> rows = Lists.newArrayList();
-rows.add(selectStmt.getResultExprs());
+// ATTN: must copy the `selectStmt.getResultExprs()`,
otherwise the following
+// `selectStmt.getResultExprs().clear();` will clear the
`rows` too, causing error.
+rows.add(Lists.newArrayList(selectStmt.getResultExprs()));
analyzeRow(analyzer, targetColumns, rows, 0,
origColIdxsForExtendCols);
// rows may be changed in analyzeRow(), so rebuild the result
exprs
selectStmt.getResultExprs().clear();
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceClient.java
b/fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceClient.java
index 370f425..7330904 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceClient.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceClient.java
@@ -29,7 +29,7 @@ import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit;
import io.grpc.ManagedChannel;
-import io.grpc.netty.NettyChannelBuilder;
+import io.grpc.netty.shaded.io.grpc.netty.NettyChannelBuilder;
public class BackendServiceClient {
public static final Logger LOG =
LogManager.getLogger(BackendServiceClient.class);
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
b/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
index 94417eb..8626eda 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/planner/QueryPlanTest.java
@@ -432,21 +432,6 @@ public class QueryPlanTest {
"PROPERTIES (\n" +
"\"replication_num\" = \"1\"" +
");");
-
-createTable("CREATE TABLE test.result_exprs (\n" +
-" `aid` int(11) NULL,\n" +
-" `bid` int(11) NULL\n" +
-") ENGINE=OLAP\n" +
-"DUPLICATE KEY(`aid`)\n" +
-"COMMENT \"OLAP\"\n" +
-"DISTRIBUTED BY HASH(`aid`) BUCKETS 7\n" +
-"PROPERTIES (\n" +
-"\"replication_num\" = \"1\",\n" +
-"\"in_memory\" = \"false\",\n" +
-"\"business_key_column_name\" = \"\",\n" +
-"\"storage_medium\" = \"HDD\",\n" +
-"\"storage_format\" = \"V2\"\n" +
-");\n");
}
@AfterCla
[incubator-doris] 02/04: [fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error (#8261)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.0
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 2efcbfabfce000bfc8f63747820b2bc99c3ddab4
Author: Pxl <952130...@qq.com>
AuthorDate: Tue Mar 1 11:11:02 2022 +0800
[fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error
(#8261)
---
be/test/olap/schema_change_test.cpp | 96 ++-
be/test/vec/function/function_bitmap_test.cpp | 39 ++-
2 files changed, 70 insertions(+), 65 deletions(-)
diff --git a/be/test/olap/schema_change_test.cpp
b/be/test/olap/schema_change_test.cpp
index 9efcedf..1976f9a 100644
--- a/be/test/olap/schema_change_test.cpp
+++ b/be/test/olap/schema_change_test.cpp
@@ -180,8 +180,8 @@ public:
}
void set_tablet_schema(const std::string& name, const std::string& type,
- const std::string& aggregation, uint32_t length, bool
is_allow_null,
- bool is_key, TabletSchema* tablet_schema) {
+ const std::string& aggregation, uint32_t length,
bool is_allow_null,
+ bool is_key, TabletSchema* tablet_schema) {
TabletSchemaPB tablet_schema_pb;
ColumnPB* column = tablet_schema_pb.add_column();
column->set_unique_id(0);
@@ -204,7 +204,7 @@ public:
int varchar_len = 255) {
TabletSchema src_tablet_schema;
set_tablet_schema("ConvertColumn", type_name, "REPLACE", type_size,
false, false,
-&src_tablet_schema);
+ &src_tablet_schema);
create_column_writer(src_tablet_schema);
RowCursor write_row;
@@ -223,7 +223,7 @@ public:
TabletSchema dst_tablet_schema;
set_tablet_schema("VarcharColumn", "VARCHAR", "REPLACE", varchar_len,
false, false,
-&dst_tablet_schema);
+ &dst_tablet_schema);
create_column_reader(src_tablet_schema);
RowCursor read_row;
read_row.init(dst_tablet_schema);
@@ -267,7 +267,7 @@ public:
TabletSchema converted_tablet_schema;
set_tablet_schema("ConvertColumn", type_name, "REPLACE", type_size,
false, false,
-&converted_tablet_schema);
+ &converted_tablet_schema);
create_column_reader(tablet_schema);
RowCursor read_row;
read_row.init(converted_tablet_schema);
@@ -355,7 +355,7 @@ TEST_F(TestColumn, ConvertFloatToDouble) {
sprintf(buf, "%f", val2);
char* tg;
double v2 = strtod(buf, &tg);
-ASSERT_TRUE(v2 == 1.234);
+ASSERT_EQ(v2, 1.234);
//test not support type
TypeInfo* tp = get_scalar_type_info(OLAP_FIELD_TYPE_HLL);
@@ -434,7 +434,7 @@ TEST_F(TestColumn, ConvertDateToDatetime) {
TabletSchema convert_tablet_schema;
set_tablet_schema("DateTimeColumn", "DATETIME", "REPLACE", 8, false, false,
-&convert_tablet_schema);
+ &convert_tablet_schema);
create_column_reader(tablet_schema);
RowCursor read_row;
read_row.init(convert_tablet_schema);
@@ -691,47 +691,44 @@ TEST_F(TestColumn, ConvertBigIntToVarchar22) {
TEST_F(TestColumn, ConvertLargeIntToVarchar39) {
std::string str_val("170141183460469231731687303715884105727");
StringParser::ParseResult result;
-int128_t int128_val =
StringParser::string_to_int(str_val.c_str(),
-
str_val.length(), &result);
+int128_t int128_val =
+StringParser::string_to_int(str_val.c_str(),
str_val.length(), &result);
DCHECK(result == StringParser::PARSE_SUCCESS);
-test_convert_to_varchar("LARGEINT", 16, int128_val,
- "", OLAP_ERR_INPUT_PARAMETER_ERROR, 39);
+test_convert_to_varchar("LARGEINT", 16, int128_val, "",
+ OLAP_ERR_INPUT_PARAMETER_ERROR, 39);
}
TEST_F(TestColumn, ConvertLargeIntToVarchar41) {
std::string str_val("170141183460469231731687303715884105727");
StringParser::ParseResult result;
-int128_t int128_val =
StringParser::string_to_int(str_val.c_str(),
-
str_val.length(), &result);
+int128_t int128_val =
+StringParser::string_to_int(str_val.c_str(),
str_val.length(), &result);
DCHECK(result == StringParser::PARSE_SUCCESS);
-test_convert_to_varchar("LARGEINT", 16, int128_val,
- str_val,
- OLAP_SUCCESS, 41);
+test_convert_to_varchar("LARGEINT", 16, int128_val, str_val,
OLAP_SUCCESS, 41);
}
TEST_F(TestColumn, ConvertLargeIntToVarchar40) {
std::string str_val = "-170141183460469231731687303715884105727";
StringParser::ParseResult result;
-
[incubator-doris] 03/04: [refactor] remove unused new_in_predicate code (#8263)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch dev-1.0.0
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 3c872f2fccbe25db3e98137c49bb2271dda19d24
Author: Zhengguo Yang
AuthorDate: Tue Mar 1 11:11:42 2022 +0800
[refactor] remove unused new_in_predicate code (#8263)
remove unused code of new_in_predicate.h/cpp
---
be/src/common/daemon.cpp | 2 -
be/src/exprs/CMakeLists.txt | 1 -
be/src/exprs/new_in_predicate.cpp | 185
be/src/exprs/new_in_predicate.h | 348 --
4 files changed, 536 deletions(-)
diff --git a/be/src/common/daemon.cpp b/be/src/common/daemon.cpp
index 044feda..04625e3 100644
--- a/be/src/common/daemon.cpp
+++ b/be/src/common/daemon.cpp
@@ -37,7 +37,6 @@
#include "exprs/json_functions.h"
#include "exprs/like_predicate.h"
#include "exprs/math_functions.h"
-#include "exprs/new_in_predicate.h"
#include "exprs/operators.h"
#include "exprs/string_functions.h"
#include "exprs/table_function/dummy_table_functions.h"
@@ -250,7 +249,6 @@ void Daemon::init(int argc, char** argv, const
std::vector& paths) {
StringFunctions::init();
ArrayFunctions::init();
CastFunctions::init();
-InPredicate::init();
MathFunctions::init();
EncryptionFunctions::init();
TimestampFunctions::init();
diff --git a/be/src/exprs/CMakeLists.txt b/be/src/exprs/CMakeLists.txt
index c71f23e..f266fd9 100644
--- a/be/src/exprs/CMakeLists.txt
+++ b/be/src/exprs/CMakeLists.txt
@@ -41,7 +41,6 @@ add_library(Exprs
expr.cpp
expr_context.cpp
in_predicate.cpp
- new_in_predicate.cpp
bloomfilter_predicate.cpp
block_bloom_filter_avx_impl.cc
block_bloom_filter_impl.cc
diff --git a/be/src/exprs/new_in_predicate.cpp
b/be/src/exprs/new_in_predicate.cpp
deleted file mode 100644
index b0a6390..000
--- a/be/src/exprs/new_in_predicate.cpp
+++ /dev/null
@@ -1,185 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements. See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership. The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied. See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-#include "exprs/new_in_predicate.h"
-
-#include
-
-#include "exprs/anyval_util.h"
-#include "runtime/string_value.hpp"
-
-namespace doris {
-
-void InPredicate::init() {}
-
-// Templated getter functions for extracting 'SetType' values from AnyVals
-template
-SetType get_val(const FunctionContext::TypeDesc* type, const T& x) {
-DCHECK(!x.is_null);
-return x.val;
-}
-
-template <>
-StringValue get_val(const FunctionContext::TypeDesc* type, const StringVal& x)
{
-DCHECK(!x.is_null);
-return StringValue::from_string_val(x);
-}
-
-template <>
-DateTimeValue get_val(const FunctionContext::TypeDesc* type, const
DateTimeVal& x) {
-return DateTimeValue::from_datetime_val(x);
-}
-
-template <>
-DecimalV2Value get_val(const FunctionContext::TypeDesc* type, const
DecimalV2Val& x) {
-return DecimalV2Value::from_decimal_val(x);
-}
-
-template
-void InPredicate::set_lookup_prepare(FunctionContext* ctx,
- FunctionContext::FunctionStateScope
scope) {
-if (scope != FunctionContext::FRAGMENT_LOCAL) {
-return;
-}
-
-SetLookupState* state = new SetLookupState;
-state->type = ctx->get_arg_type(0);
-state->contains_null = false;
-for (int i = 1; i < ctx->get_num_args(); ++i) {
-DCHECK(ctx->is_arg_constant(i));
-T* arg = reinterpret_cast(ctx->get_constant_arg(i));
-if (arg->is_null) {
-state->contains_null = true;
-} else {
-state->val_set.insert(get_val(state->type, *arg));
-}
-}
-ctx->set_function_state(scope, state);
-}
-
-template
-void InPredicate::set_lookup_close(FunctionContext* ctx,
- FunctionContext::FunctionStateScope scope) {
-if (scope != FunctionContext::FRAGMENT_LOCAL) {
-return;
-}
-SetLookupState* state =
-
reinterpret_cast*>(ctx->get_function_state(scope));
-delete state;
-}
-
-template
-BooleanVal InPredicate::templated_in(FunctionContext* ctx, const T& val, int
num_args,
- const T* args) {
-if (val.is_null) {
-return BooleanVal::null();
-}
-
-BooleanV
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8229: [Vec][Opt] better memequal impl to speed up string compare
github-actions[bot] commented on pull request #8229: URL: https://github.com/apache/incubator-doris/pull/8229#issuecomment-1054960513 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated: [improvement][vec] better memequal impl to speed up string compare (#8229)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new ada39dd [improvement][vec] better memequal impl to speed up string
compare (#8229)
ada39dd is described below
commit ada39dd9adf6108a7015c192f4878766af71c488
Author: zbtzbtzbt <35688959+zbtzbt...@users.noreply.github.com>
AuthorDate: Tue Mar 1 11:25:12 2022 +0800
[improvement][vec] better memequal impl to speed up string compare (#8229)
like #8214
faster string compare operator in vec engine.
---
be/src/runtime/string_value.hpp | 4 ++
be/src/vec/common/string_ref.h | 107 +---
2 files changed, 37 insertions(+), 74 deletions(-)
diff --git a/be/src/runtime/string_value.hpp b/be/src/runtime/string_value.hpp
index c44115d..aac9e3a 100644
--- a/be/src/runtime/string_value.hpp
+++ b/be/src/runtime/string_value.hpp
@@ -22,6 +22,7 @@
#include "runtime/string_value.h"
#include "util/cpu_info.h"
+#include "vec/common/string_ref.h"
#ifdef __SSE4_2__
#include "util/sse_util.hpp"
#endif
@@ -88,6 +89,9 @@ inline bool StringValue::eq(const StringValue& other) const {
if (this->len != other.len) {
return false;
}
+#if defined(__SSE2__)
+return memequalSSE2Wide(this->ptr, other.ptr, this->len);
+#endif
return string_compare(this->ptr, this->len, other.ptr, other.len,
this->len) == 0;
}
diff --git a/be/src/vec/common/string_ref.h b/be/src/vec/common/string_ref.h
index 5dd146e..8ecbe07 100644
--- a/be/src/vec/common/string_ref.h
+++ b/be/src/vec/common/string_ref.h
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
// This file is copied from
-// https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/StringRef.h
+// https://github.com/ClickHouse/ClickHouse/blob/master/base/base/StringRef.h
// and modified by Doris
#pragma once
@@ -98,6 +98,32 @@ inline bool compareSSE2x4(const char* p1, const char* p2) {
}
inline bool memequalSSE2Wide(const char* p1, const char* p2, size_t size) {
+/** The order of branches and the trick with overlapping comparisons
+ * are the same as in memcpy implementation.
+ * See the comments in
+ *
https://github.com/ClickHouse/ClickHouse/blob/master/base/glibc-compatibility/memcpy/memcpy.h
+ */
+
+if (size <= 16) {
+if (size >= 8) {
+/// Chunks of [8,16] bytes.
+return unaligned_load(p1) ==
unaligned_load(p2) &&
+ unaligned_load(p1 + size - 8) ==
unaligned_load(p2 + size - 8);
+} else if (size >= 4) {
+/// Chunks of [4,7] bytes.
+return unaligned_load(p1) ==
unaligned_load(p2) &&
+ unaligned_load(p1 + size - 4) ==
unaligned_load(p2 + size - 4);
+} else if (size >= 2) {
+/// Chunks of [2,3] bytes.
+return unaligned_load(p1) ==
unaligned_load(p2) &&
+ unaligned_load(p1 + size - 2) ==
unaligned_load(p2 + size - 2);
+} else if (size >= 1) {
+/// A single byte.
+return *p1 == *p2;
+}
+return true;
+}
+
while (size >= 64) {
if (compareSSE2x4(p1, p2)) {
p1 += 64;
@@ -107,74 +133,14 @@ inline bool memequalSSE2Wide(const char* p1, const char*
p2, size_t size) {
return false;
}
-switch ((size % 64) / 16) {
-case 3:
-if (!compareSSE2(p1 + 32, p2 + 32)) return false;
-[[fallthrough]];
-case 2:
-if (!compareSSE2(p1 + 16, p2 + 16)) return false;
-[[fallthrough]];
-case 1:
-if (!compareSSE2(p1, p2)) return false;
-[[fallthrough]];
-case 0:
-break;
-}
-
-p1 += (size % 64) / 16 * 16;
-p2 += (size % 64) / 16 * 16;
-
-switch (size % 16) {
-case 15:
-if (p1[14] != p2[14]) return false;
-[[fallthrough]];
-case 14:
-if (p1[13] != p2[13]) return false;
-[[fallthrough]];
-case 13:
-if (p1[12] != p2[12]) return false;
-[[fallthrough]];
-case 12:
-if (unaligned_load(p1 + 8) == unaligned_load(p2 +
8))
-goto l8;
-else
-return false;
-case 11:
-if (p1[10] != p2[10]) return false;
-[[fallthrough]];
-case 10:
-if (p1[9] != p2[9]) return false;
-[[fallthrough]];
-case 9:
-if (p1[8] != p2[8]) return false;
-l8:
-[[fallthrough]];
-case 8:
-return unaligned_load(p1) == unaligned_load(p2);
-case 7:
-if (p1[6] != p2[6]) return false;
-[[fallthrough]];
-case 6:
-if (p1[5] != p2[5]) return false;
-[[fallthrough]];
-case 5:
-if (p1[4] != p2[4]) return false;
-[[fallthrough]];
-case 4:
-r
[GitHub] [incubator-doris] morningman merged pull request #8229: [Vec][Opt] better memequal impl to speed up string compare
morningman merged pull request #8229: URL: https://github.com/apache/incubator-doris/pull/8229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8256: [Enhancement](routine-load) Support routine load task succeed with empty data consumed
github-actions[bot] commented on pull request #8256: URL: https://github.com/apache/incubator-doris/pull/8256#issuecomment-1054964705 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #8275: [community] Modify doris connector release doc
morningman opened a new pull request #8275: URL: https://github.com/apache/incubator-doris/pull/8275 # Proposed changes Issue Number: close #xxx ## Problem Summary: Modify some comment ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8275: [community] Modify doris connector release doc
EmmyMiao87 commented on a change in pull request #8275:
URL: https://github.com/apache/incubator-doris/pull/8275#discussion_r816428257
##
File path: docs/en/community/release-and-verify/release-doris-connectors.md
##
@@ -71,17 +78,17 @@ Execute the following command to start generating the
release tag.
```bash
cd flink-doris-connector/
-mvn release:clean -DreleaseArgs="-Dflink.version=1.13.5 -Dscala.version=2.12"
-Dflink.version=1.13.5 -Dscala.version=2.12
-mvn release:prepare -DreleaseArgs="-Dflink.version=1.13.5
-Dscala.version=2.12" -Dflink.version=1.13.5 -Dscala.version=2.12
-DpushChanges=false
+mvn release:clean
+mvn release:prepare -DpushChanges=false
```
where `-DpushChanges=false` means that the newly generated branches and tags
are not pushed to the codebase during execution.
After executing the `release:prepare` command, the following three pieces of
information will be requested.
-1. the version of the Doris Flink Connector, which we can do by default,
either by entering a carriage return or by typing in the version you want. The
version format is `{flink.version}-{scala.version}-{connector.version}`, e.g.
`1.13.5-2.12-1.0.0`. 2.
-2. The release tag of Doris Flink Connector, the release process will generate
a tag locally, we can use the default tag name, such as `1.13.5-2.12-1.0.0`.
-3. The version number of the next version of Doris Flink Connector. This
version number is only used for generating local branches and has no real
meaning. For example, if the current release is `1.13.5-2.12-1.0.0`, then the
next version number should be `1.13.5-2.12-1.0.1`.
+1. the version of the Doris Flink Connector: which we can do by default,
either by entering a carriage return or by typing in the version you want. The
version format is `{flink.version}-{scala.version}-{connector.version}`, e.g.
`1.13.5-2.12-1.0.0`. 2.
Review comment:
```suggestion
1. the version of the Doris Flink Connector: which we can do by default,
either by entering a carriage return or by typing in the version you want. The
version format is `{flink.version}-{scala.version}-{connector.version}`, e.g.
`1.13.5-2.12-1.0.0`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] 02/02: [feature-wip][array-type] Support ArrayLiteral in SQL. (#8089)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch array-type
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit d256206049df5a74740375a118cc693045656c7d
Author: Adonis Ling
AuthorDate: Fri Feb 18 10:59:57 2022 +0800
[feature-wip][array-type] Support ArrayLiteral in SQL. (#8089)
Please refer to #8074
---
be/src/olap/column_vector.cpp | 21 ++--
be/src/olap/rowset/segment_v2/column_reader.cpp| 8 +-
be/src/olap/rowset/segment_v2/column_reader.h | 13 +++
be/src/olap/rowset/segment_v2/column_writer.cpp| 10 +-
be/src/olap/rowset/segment_v2/column_writer.h | 5 +-
be/src/runtime/collection_value.cpp| 16 ++-
be/src/runtime/mysql_result_writer.cpp | 6 +-
be/src/runtime/raw_value.cpp | 1 +
be/src/runtime/row_batch.cpp | 10 +-
be/src/runtime/tuple.cpp | 29 +++---
.../segment_v2/column_reader_writer_test.cpp | 24 +
fe/fe-core/src/main/cup/sql_parser.cup | 14 +++
.../org/apache/doris/analysis/ArrayLiteral.java| 28 +++--
.../org/apache/doris/analysis/CreateTableStmt.java | 10 +-
.../main/java/org/apache/doris/analysis/Expr.java | 3 +-
.../java/org/apache/doris/catalog/ArrayType.java | 4 +
.../main/java/org/apache/doris/catalog/Column.java | 13 ++-
.../main/java/org/apache/doris/catalog/Type.java | 4 +-
.../org/apache/doris/analysis/ColumnDefTest.java | 18 +++-
.../apache/doris/analysis/InsertArrayStmtTest.java | 114 +
.../org/apache/doris/utframe/UtFrameUtils.java | 9 ++
21 files changed, 306 insertions(+), 54 deletions(-)
diff --git a/be/src/olap/column_vector.cpp b/be/src/olap/column_vector.cpp
index 8672339..949c802 100644
--- a/be/src/olap/column_vector.cpp
+++ b/be/src/olap/column_vector.cpp
@@ -210,14 +210,19 @@ void ArrayColumnVectorBatch::prepare_for_read(size_t
start_idx, size_t size, boo
DCHECK(start_idx + size <= capacity());
for (size_t i = 0; i < size; ++i) {
if (!is_null_at(start_idx + i)) {
-_data[start_idx + i] = CollectionValue(
-
_elements->mutable_cell_ptr(*(_offsets->scalar_cell_ptr(start_idx + i))),
-*(_offsets->scalar_cell_ptr(start_idx + i + 1)) -
-*(_offsets->scalar_cell_ptr(start_idx + i)),
-item_has_null,
-_elements->is_nullable() ?
const_cast(&_elements->null_signs()[*(
-
_offsets->scalar_cell_ptr(start_idx + i))])
- : nullptr);
+auto next_offset = *(_offsets->scalar_cell_ptr(start_idx + i + 1));
+auto offset = *(_offsets->scalar_cell_ptr(start_idx + i));
+uint32_t length = next_offset - offset;
+if (length == 0) {
+_data[start_idx + i] = CollectionValue(length);
+} else {
+_data[start_idx + i] = CollectionValue(
+_elements->mutable_cell_ptr(offset),
+length,
+item_has_null,
+_elements->is_nullable() ?
const_cast(&_elements->null_signs()[offset])
+ : nullptr);
+}
}
}
}
diff --git a/be/src/olap/rowset/segment_v2/column_reader.cpp
b/be/src/olap/rowset/segment_v2/column_reader.cpp
index dbd5097..cbb4529 100644
--- a/be/src/olap/rowset/segment_v2/column_reader.cpp
+++ b/be/src/olap/rowset/segment_v2/column_reader.cpp
@@ -127,7 +127,7 @@ Status ColumnReader::init() {
"Bad file $0: invalid column index type $1",
_path_desc.filepath, index_meta.type()));
}
}
-if (_ordinal_index_meta == nullptr) {
+if (!is_empty() && _ordinal_index_meta == nullptr) {
return Status::Corruption(strings::Substitute(
"Bad file $0: missing ordinal index for column $1",
_path_desc.filepath, _meta.column_id()));
}
@@ -339,6 +339,10 @@ Status ColumnReader::seek_at_or_before(ordinal_t ordinal,
OrdinalPageIndexIterat
}
Status ColumnReader::new_iterator(ColumnIterator** iterator) {
+if (is_empty()) {
+*iterator = new EmptyFileColumnIterator();
+return Status::OK();
+}
if (is_scalar_type((FieldType)_meta.type())) {
*iterator = new FileColumnIterator(this);
return Status::OK();
@@ -427,7 +431,7 @@ Status ArrayFileColumnIterator::next_batch(size_t* n,
ColumnBlockView* dst, bool
// read item
size_t item_size = array_batch->get_item_size(dst->current_offset(), *n);
-if (item_size > 0) {
+if (item_size >= 0) {
bool item_has_null = false;
ColumnVectorBatch* item_vector_batch = array_batch->elements();
diff --git a/be/src/olap/rowset/segment
[incubator-doris] 01/02: [feature-wip](array-type) Create table with nested array type. (#8003)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch array-type
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
commit 37becad1ff454d2c1f2a78a4fd95de71dbe1a572
Author: Adonis Ling
AuthorDate: Wed Feb 16 12:44:30 2022 +0800
[feature-wip](array-type) Create table with nested array type. (#8003)
```
create table array_type_table(k1 INT, k2 Array>) duplicate key
(k1)
distributed by hash(k1) buckets 1 properties('replication_num' = '1');
```
---
be/src/olap/tablet_meta.cpp | 9 -
.../org/apache/doris/analysis/CreateTableStmt.java | 16
.../main/java/org/apache/doris/analysis/TypeDef.java | 10 --
.../java/org/apache/doris/catalog/ArrayType.java | 9 +
.../main/java/org/apache/doris/catalog/Column.java | 10 --
.../src/main/java/org/apache/doris/catalog/Type.java | 20 +++-
.../org/apache/doris/catalog/CreateTableTest.java| 13 +
7 files changed, 41 insertions(+), 46 deletions(-)
diff --git a/be/src/olap/tablet_meta.cpp b/be/src/olap/tablet_meta.cpp
index 6e6195d..73632a1 100644
--- a/be/src/olap/tablet_meta.cpp
+++ b/be/src/olap/tablet_meta.cpp
@@ -128,11 +128,6 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t
partition_id, int64_t tablet_id
}
}
}
-
-if (tcolumn.column_type.type == TPrimitiveType::ARRAY) {
-ColumnPB* children_column = column->add_children_columns();
-_init_column_from_tcolumn(0, tcolumn.children_column[0],
children_column);
-}
}
schema->set_next_column_unique_id(next_unique_id);
@@ -210,6 +205,10 @@ void TabletMeta::_init_column_from_tcolumn(uint32_t
unique_id, const TColumn& tc
if (tcolumn.__isset.is_bloom_filter_column) {
column->set_is_bf_column(tcolumn.is_bloom_filter_column);
}
+if (tcolumn.column_type.type == TPrimitiveType::ARRAY) {
+ColumnPB* children_column = column->add_children_columns();
+_init_column_from_tcolumn(0, tcolumn.children_column[0],
children_column);
+}
}
OLAPStatus TabletMeta::create_from_file(const string& file_path) {
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
index ed2b689..5fb937e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableStmt.java
@@ -17,8 +17,11 @@
package org.apache.doris.analysis;
+import com.google.common.base.Strings;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Sets;
+import org.apache.commons.collections.CollectionUtils;
import org.apache.doris.catalog.AggregateType;
-import org.apache.doris.catalog.ArrayType;
import org.apache.doris.catalog.Catalog;
import org.apache.doris.catalog.Column;
import org.apache.doris.catalog.Index;
@@ -35,12 +38,6 @@ import org.apache.doris.common.util.PrintableMap;
import org.apache.doris.external.elasticsearch.EsUtil;
import org.apache.doris.mysql.privilege.PrivPredicate;
import org.apache.doris.qe.ConnectContext;
-
-import com.google.common.base.Strings;
-import com.google.common.collect.Lists;
-import com.google.common.collect.Sets;
-
-import org.apache.commons.collections.CollectionUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -372,11 +369,6 @@ public class CreateTableStmt extends DdlStmt {
columnDef.analyze(engineName.equals("olap"));
if (columnDef.getType().isArrayType()) {
-ArrayType tp = (ArrayType) columnDef.getType();
-if (!tp.getItemType().getPrimitiveType().isIntegerType() &&
-!tp.getItemType().getPrimitiveType().isCharFamily()) {
-throw new AnalysisException("Array column just support
INT/VARCHAR sub-type");
-}
if (columnDef.getAggregateType() != null &&
columnDef.getAggregateType() != AggregateType.NONE) {
throw new AnalysisException("Array column can't support
aggregation " + columnDef.getAggregateType());
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java
b/fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java
index 6bce9b5..d81d633 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/TypeDef.java
@@ -92,8 +92,10 @@ public class TypeDef implements ParseNode {
throw new AnalysisException("Unsupported data type: " + type.toSql());
}
if (type.isArrayType()) {
-ScalarType itemType = (ScalarType) ((ArrayType) type).getItemType();
-analyzeNestedType(itemType);
+Type itemType = ((ArrayType) type).getItem
[incubator-doris] branch array-type updated (e1d75ee -> d256206)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch array-type in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. omit e1d75ee [feature-wip][array-type] Support ArrayLiteral in SQL. (#8089) omit 0d14205 [feature-wip](array-type) Create table with nested array type. (#8003) add b1e7343 [Vectorized] [HashJoin] Opt HashJoin Performance (#8119) add f4c6de5 [docs] update backup and restore docs (#8161) add 9120de2 [refactor] fix some typos (#8159) add 31ab569 [Vectorized][Feature] support some bitmap functions (#8138) add d17ed5e [vectorization](storage)support seq column in storage layer (#8186) add e3f1efc [Vec][Storage] Support delete condition;ut (#8091) add 01fb25a [UT] Fix the UT of column_nullable_test (#8180) add 83543c6 [improvement](storage)Using Be config to switch storage layer vectorization #8166 add 0726a43 [fix](be-ut) Fix unused-but-set-variable errors. (#8211) add 9a7931c [fix](mem-pool) fix bug that mem pool failed to allocate in ASAN mode (#8216) add 90a8ca8 [Bug][Vectorized] fix bitmap_min(empty) not return null (#8190) add a6bc9cb [Function] Refactor the function code of log (#8199) add 0dcbfbd [fix](load) Fix InsertStmt prepareExpressions (#8112) add dccb3cf [git] Ignore all the .flattened-pom.xml files (#8197) add b93936c [Feature][array-type]add proto for complex data type ARRAY (#8212) add df7e848 [chore](dependency) upgrade-grpc-version (#8218) add 4c5d7c2 [Bug] group_concat(value,null) not return null add 8642fa3 [Bug] Double/Float % 0 should be NULL (#8230) add 6f4cf57 [Bug][Vectorized] Fix bug of decimal cast to double loss precision (#8221) add ddf08cc [refactor](fe) Remove version hash on FE side (#8099) add cce721a [improvement](olap) using placement-new to avoid dynamic mallocing for ParsedPage (#8172) add f7c18d3 [Improvement] Add minimum fe meta version check (#8203) add 40c1fa2 [refactor] change mysql server version to avoid some cve issues (#8223) add a630e03 [Enhancement](routine_load) Support show routine load statement with like predicate (#8188) add 83521a8 [Feature](create_table) Support create table with random distribution to avoid data skew (#8041) add 668188b [improvement][vectorized] support es node predicate peel (#8174) add 87b96cf [feature](iceberg) Step3: Support query iceberg external table (#8179) add 385ccf7 [fix](routine-load) fix show routine load task error (#8195) add 30fbf1d [typo](doc)fix some confusing doc content (#8239) add 351fbbc [fix](olap) add check statement to protect get_dict_word_info() from crash (#8241) add 7f3564c [chore] Support aarch64 target with ldb_toolchain (#8249) add c66a9bf [fix](be-ut) fix unit test bug for tablet_info_test (#8253) add 27d2e3e [refactor](fe) Remove old fe meta version (#8246) add 01365f1 [community] add more collaborators in .asf.yaml (#8029) (#8252) add e77e2b0 [improvement](lateral-view) Add number rows filtered in profile (#8251) add 13f007b [doc] Modify document of compilation on ARM64 (#8254) add 0fce094 [typo] fix listdb description error (#8257) add 7d0e36a [fix](be-ut) fix bitmap_ut result wrong && fix schema_change compile error (#8261) add 757e357 [refactor] remove unused new_in_predicate code (#8263) add 93c638f [fix][chore](insert)(fe) Fix analysis error of insert stmt and modify grpc-netty dependency (#8265) add ada39dd [improvement][vec] better memequal impl to speed up string compare (#8229) new 37becad [feature-wip](array-type) Create table with nested array type. (#8003) new d256206 [feature-wip][array-type] Support ArrayLiteral in SQL. (#8089) This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (e1d75ee) \ N -- N -- N refs/heads/array-type (d256206) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .asf.yaml | 2 + .gitignore | 8 +- be/CMakeLists.txt
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8250: [revert] "[improvement]upgrade-grpc-version"
github-actions[bot] commented on pull request #8250: URL: https://github.com/apache/incubator-doris/pull/8250#issuecomment-1054980910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8247: [refactor] Upgrade to MySQL 5.7.37 to reduce unnecessary CVE issues
github-actions[bot] commented on pull request #8247: URL: https://github.com/apache/incubator-doris/pull/8247#issuecomment-1054981592 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] maninhill commented on issue #7986: Apache Doris Manager 2022 Roadmap
maninhill commented on issue #7986: URL: https://github.com/apache/incubator-doris/issues/7986#issuecomment-1055028485 Is there any progress on this Doris visualization management tool? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8240: [feature-wip][array-type] Refactor type info for nested array.
morningman commented on a change in pull request #8240:
URL: https://github.com/apache/incubator-doris/pull/8240#discussion_r816456289
##
File path: be/src/olap/types.cpp
##
@@ -97,30 +98,51 @@ bool is_scalar_type(FieldType field_type) {
}
}
-TypeInfo* get_scalar_type_info(FieldType field_type) {
+std::shared_ptr get_scalar_type_info(FieldType field_type) {
return ScalarTypeInfoResolver::instance()->get_type_info(field_type);
}
class ArrayTypeInfoResolver {
DECLARE_SINGLETON(ArrayTypeInfoResolver);
public:
-TypeInfo* get_type_info(const FieldType t) {
+std::shared_ptr get_type_info(const FieldType t) {
auto pair = _type_mapping.find(t);
DCHECK(pair != _type_mapping.end()) << "Bad field type: list<" << t <<
">";
-return pair->second.get();
+return pair->second;
+}
+
+std::shared_ptr get_type_info(const TabletColumn& column) {
+DCHECK(column.get_subtype_count() == 1) << "more than 1 child type.";
+const auto &sub_column = column.get_sub_column(0);
+if (is_scalar_type(sub_column.type())) {
+return get_type_info(sub_column.type());
+} else {
+return std::shared_ptr(new
ArrayTypeInfo(get_type_info(sub_column)));
Review comment:
```suggestion
return std::make_shared(get_type_info(sub_column));
```
##
File path: be/src/olap/types.cpp
##
@@ -97,30 +98,51 @@ bool is_scalar_type(FieldType field_type) {
}
}
-TypeInfo* get_scalar_type_info(FieldType field_type) {
+std::shared_ptr get_scalar_type_info(FieldType field_type) {
return ScalarTypeInfoResolver::instance()->get_type_info(field_type);
}
class ArrayTypeInfoResolver {
DECLARE_SINGLETON(ArrayTypeInfoResolver);
public:
-TypeInfo* get_type_info(const FieldType t) {
+std::shared_ptr get_type_info(const FieldType t) {
auto pair = _type_mapping.find(t);
DCHECK(pair != _type_mapping.end()) << "Bad field type: list<" << t <<
">";
-return pair->second.get();
+return pair->second;
+}
+
+std::shared_ptr get_type_info(const TabletColumn& column) {
+DCHECK(column.get_subtype_count() == 1) << "more than 1 child type.";
+const auto &sub_column = column.get_sub_column(0);
+if (is_scalar_type(sub_column.type())) {
+return get_type_info(sub_column.type());
+} else {
+return std::shared_ptr(new
ArrayTypeInfo(get_type_info(sub_column)));
+}
+}
+
+std::shared_ptr get_type_info(const
segment_v2::ColumnMetaPB& column_meta_pb) {
+DCHECK(column_meta_pb.children_columns_size() >= 1 &&
column_meta_pb.children_columns_size() <= 3)
+<< "more than 3 children or no children.";
+const auto& child_type = column_meta_pb.children_columns(0);
+if (is_scalar_type((FieldType)child_type.type())) {
+return get_type_info((FieldType)child_type.type());
+} else {
+return std::shared_ptr(new
ArrayTypeInfo(get_type_info(child_type)));
Review comment:
```suggestion
return std::make_shared(get_type_info(child_type));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg opened a new issue #8276: [Bug] encryption functions with iv may return wrong result
yangzhg opened a new issue #8276:
URL: https://github.com/apache/incubator-doris/issues/8276
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
0.15
### What's Wrong?
encryption function with iv may return wrong result
```
MySQL [test]> select
to_base64(SM4_ENCRYPT('text','F3229A0B371ED2D9441B830D21A390C3',
'0123456789','SM4_128_CBC'));
+-+
| to_base64(sm4_encrypt('text', '***', '0123456789')) |
+-+
| /Q0/XwXDm8Vy2kpDtSERZQ==|
+-+
1 row in set (0.004 sec)
MySQL [test]> select
to_base64(SM4_ENCRYPT('text','F3229A0B371ED2D9441B830D21A390C3',
'0123456789','SM4_128_CBC'));
+-+
| to_base64(sm4_encrypt('text', '***', '0123456789')) |
+-+
| Yd/afQ1l5WZZ1VFSiWPQVg==|
+-+
1 row in set (0.004 sec)
MySQL [test]> select
to_base64(SM4_ENCRYPT('text','F3229A0B371ED2D9441B830D21A390C3',
'0123456789','SM4_128_CBC'));
+-+
| to_base64(sm4_encrypt('text', '***', '0123456789')) |
+-+
| FgDet0kcwM5jumAsE8vh9g==|
+-+
1 row in set (0.006 sec)
```
### What You Expected?
result for same text, key, iv the result should be same
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg opened a new pull request #8277: [fix] fix a bug of encryption function with iv may return wrong result
yangzhg opened a new pull request #8277: URL: https://github.com/apache/incubator-doris/pull/8277 # Proposed changes Issue Number: close #8276 ## Problem Summary: this bug is caused by the iv should be the same length of block， so if iv is less than block we should pad some char to the length ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (yes) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8238: [fix] Function percentile input null return null
github-actions[bot] commented on pull request #8238: URL: https://github.com/apache/incubator-doris/pull/8238#issuecomment-1055048655 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee opened a new issue #8278: [Bug] [Vectorized] Coredump in TPCDS-14
HappenLee opened a new issue #8278: URL: https://github.com/apache/incubator-doris/issues/8278 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version vectorized ### What's Wrong? ``` #0 0x56420bce1899 in doris::vectorized::VSetOperationNode::extract_build_column (this=0x5642bd9fdb00, block=..., raw_ptrs=...) at /root/doris-release/be/src/vec/common/cow.h:210 #1 0x56420bce1d5d in doris::vectorized::VSetOperationNode::process_build_block (this=0x5642bd9fdb00, block=..., offset=) at /root/doris-release/be/src/vec/exec/vset_operation_node.cpp:277 #2 0x56420bce24b8 in doris::vectorized::VSetOperationNode::hash_table_build (this=, state=0x564269f52800) at /var/local/ldb-toolchain/include/c++/11/bits/stl_vector.h:1043 #3 0x56420bce57e6 in doris::vectorized::VSetOperationNode::open (this=this@entry=0x5642bd9fdb00, state=0x564269f52800) at /root/doris-release/be/src/vec/exec/vset_operation_node.cpp:122 #4 0x56420ae88149 in doris::vectorized::VIntersectNode::open (this=0x5642bd9fdb00, state=) at /root/doris-release/be/src/vec/exec/vintersect_node.cpp:45 #5 0x56420a5737a0 in doris::PlanFragmentExecutor::open_vectorized_internal (this=0x56428ba75770) at /var/local/ldb-toolchain/include/c++/11/bits/unique_ptr.h:421 #6 0x56420a57544e in doris::PlanFragmentExecutor::open (this=this@entry=0x56428ba75770) at /root/doris-release/be/src/runtime/plan_fragment_executor.cpp:250 #7 0x56420a4ec435 in doris::FragmentExecState::execute (this=0x56428ba75700) at /root/doris-release/be/src/runtime/fragment_mgr.cpp:234 #8 0x56420a4f0b9a in doris::FragmentMgr::_exec_actual(std::shared_ptr, std::function) ( this=0x564211658e00, exec_state=..., cb=...) at /var/local/ldb-toolchain/include/c++/11/bits/shared_ptr_base.h:1290 #9 0x56420a4fa1bc in std::__invoke_impl, std::function), doris::FragmentMgr*&, std::shared_ptr&, std::function&>(std::__invoke_memfun_deref, void (doris::FragmentMgr::*&)(std::shared_ptr, std::function), doris::FragmentMgr*&, std::shared_ptr&, std::function&) (__f= @0x56424d69fcc0: (void (doris::FragmentMgr::*)(doris::FragmentMgr * const, std::shared_ptr, std::function)) 0x56420a4f0670 , std::function)>, __t=@0x56424d69fd00: 0x564211658e00, __f= @0x56424d69fcc0: (void (doris::FragmentMgr::*)(doris::FragmentMgr * const, std::shared_ptr, std::function)) 0x56420a4f0670 , std::function)>, __t=@0x56424d69fd00: 0x564211658e00) at /var/local/ldb-toolchain/include/c++/11/ext/atomicity.h:109 #10 std::__invoke_r, std::function), doris::FragmentMgr*&, std::shared_ptr&, std::function&>(void (doris::FragmentMgr::*&)(std::shared_ptr, std::function), doris::FragmentMgr*&, std::shared_ptr&, std::function&) (__fn= @0x56424d69fcc0: (void (doris::FragmentMgr::*)(doris::FragmentMgr * const, std::shared_ptr, std::function)) 0x56420a4f0670 , std::function)>) at /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:111 #11 std::_Bind_result, std::function))(std::shared_ptr, std::function)>::__call(std::tuple<>&&, std::_Index_tuple<0ul, 1ul, 2ul>) (__args=..., this=0x56424d69fcc0) at /var/local/ldb-toolchain/include/c++/11/functional:570 #12 std::_Bind_result, std::function))(std::shared_ptr, std::function)>::operator()<>() (this=0x56424d69fcc0) at /var/local/ldb-toolchain/include/c++/11/functional:629 #13 std::__invoke_impl, std::function))(std::shared_ptr, std::function)>&>(std::__invoke_other, std::_Bind_result, std::function))(std::shared_ptr, std::function)>&) (__f=...) at /var/local/ldb-toolchain/include/c++/11/bits/invoke.h:61 ``` ### What You Expected? right result ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #8226: [Bug][Vectorized] fix arithmetic calculate get wrong result
EmmyMiao87 commented on a change in pull request #8226:
URL: https://github.com/apache/incubator-doris/pull/8226#discussion_r816475600
##
File path: fe/fe-core/src/main/cup/sql_parser.cup
##
@@ -4951,24 +4951,44 @@ window_boundary ::=
arithmetic_expr ::=
expr:e1 STAR expr:e2
{: RESULT = new ArithmeticExpr(ArithmeticExpr.Operator.MULTIPLY, e1, e2); :}
+ | KW_MULTIPLY LPAREN expr:e1 COMMA expr:e2 RPAREN
Review comment:
```functioname(param1, param2)``` is belongs to FunctionCallExpr .
If each functionname has to add grammar, the grammar file will not be able
to be put down long ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 opened a new pull request #8279: [feature-wip][array-type] Refactor type info for nested array.
adonis0147 opened a new pull request #8279: URL: https://github.com/apache/incubator-doris/pull/8279 # Proposed changes Issue Number: close #8237 ## Problem Summary: Please refer to #8237 . ## Checklist(Required) 1. Does it affect the original behavior: No 2. Has unit tests been added: No Need 3. Has document been added or modified: No Need 4. Does it need to update dependencies: No 5. Are there any changes that cannot be rolled back: No ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee opened a new pull request #8280: [Bug][Vectorized] Fix core dump of mutable block different of block
HappenLee opened a new pull request #8280: URL: https://github.com/apache/incubator-doris/pull/8280 # Proposed changes Issue Number: close #8278 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No Need) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (Yes) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee closed issue #8236: [Bug] Function percentile input null return 0
HappenLee closed issue #8236: URL: https://github.com/apache/incubator-doris/issues/8236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #8238: [fix] Function percentile input null return null
HappenLee merged pull request #8238: URL: https://github.com/apache/incubator-doris/pull/8238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[incubator-doris] branch master updated (ada39dd -> 2b9b0fc)
This is an automated email from the ASF dual-hosted git repository. lihaopeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from ada39dd [improvement][vec] better memequal impl to speed up string compare (#8229) add 2b9b0fc [Fix] Function percentile input null return null (#8238) No new revisions were added by this update. Summary of changes: be/src/exec/mysql_scanner.cpp | 1 - be/src/exprs/minmax_predicate.h | 1 + be/src/util/counts.h | 2 +- be/src/vec/functions/function_json.cpp| 8 be/src/vec/functions/function_string.cpp | 18 +- be/src/vec/functions/function_timestamp.cpp | 9 +++-- be/src/vec/functions/function_totype.h| 4 ++-- be/test/vec/function/function_string_test.cpp | 19 +++ .../sql-functions/aggregate-functions/percentile.md | 8 .../sql-functions/aggregate-functions/percentile.md | 7 +++ 10 files changed, 58 insertions(+), 19 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8281: [Bug] fix string type length limit error && add runtime filter decimal support
BiteThet opened a new issue #8281: URL: https://github.com/apache/incubator-doris/issues/8281 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? fix string type length limit error && add runtime filter decimal support ### What You Expected? fix ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
BiteThet opened a new pull request #8282: URL: https://github.com/apache/incubator-doris/pull/8282 # Proposed changes @HappenLee Issue Number: close #8281 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt opened a new issue #8283: [Enhancement] faster string cmp implement
zbtzbtzbt opened a new issue #8283: URL: https://github.com/apache/incubator-doris/issues/8283 In this issue, i record the experimental data of pull request https://github.com/apache/incubator-doris/pull/8229 better than old pr https://github.com/apache/incubator-doris/pull/8214 (so i closed the old pr) **it will faster 2.5X for str1==str2 operator** https://user-images.githubusercontent.com/35688959/156122704-aa7650a7-4476-49d4-9554-c55e98012a70.png";> **source data:** time cost unit is micro-seconds https://user-images.githubusercontent.com/35688959/156123129-5fdf4de1-17d9-45a6-9d57-09a0d22ebfc2.png";> **test code:** https://godbolt.org/z/W3Mdncv1P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zbtzbtzbt closed issue #8283: [Enhancement] faster string cmp implement
zbtzbtzbt closed issue #8283: URL: https://github.com/apache/incubator-doris/issues/8283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 opened a new pull request #8284: [fix] delete the repeat same code to compile
zhangstar333 opened a new pull request #8284: URL: https://github.com/apache/incubator-doris/pull/8284 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
