[GitHub] [incubator-doris] Nivane opened a new pull request #8257: fix listdb description error
Nivane opened a new pull request #8257: URL: https://github.com/apache/incubator-doris/pull/8257 ## Problem Summary: command line args 'listdb' description error ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) No 2. Has unit tests been added: (Yes/No/No Need) No Need 3. Has document been added or modified: (Yes/No/No Need) No Need 4. Does it need to update dependencies: (Yes/No) No Need 5. Are there any changes that cannot be rolled back: (Yes/No) No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui opened a new issue #8258: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution
caiconghui opened a new issue #8258:
URL: https://github.com/apache/incubator-doris/issues/8258
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Description
_No response_
### Use case
ALTER TABLE example_db.my_table set ("distribution_type" = "random");
### Related issues
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui opened a new pull request #8259: [Feature] Support Changing the bucketing mode of the table from Hash Distribution to Random Distribution
caiconghui opened a new pull request #8259: URL: https://github.com/apache/incubator-doris/pull/8259 # Proposed changes Issue Number: close #8258 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8254: [doc] Modify document of compilation on ARM64
github-actions[bot] commented on pull request #8254: URL: https://github.com/apache/incubator-doris/pull/8254#issuecomment-1053793668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8260: [Bug][Vectorized] fix bitmap_ut result wrong && fix schema_change compile error
BiteThet opened a new issue #8260: URL: https://github.com/apache/incubator-doris/issues/8260 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? fix bitmap_ut result wrong && fix schema_change compile error ### What You Expected? fix it ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8261: [Bug][Vectorized] fix bitmap_ut result wrong && fix schema_change compile error
BiteThet opened a new pull request #8261: URL: https://github.com/apache/incubator-doris/pull/8261 # Proposed changes Issue Number: close #8260 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on a change in pull request #8234: [Feature] Support pre-aggregation for quantile type
wangbo commented on a change in pull request #8234:
URL: https://github.com/apache/incubator-doris/pull/8234#discussion_r81742
##
File path: be/src/exprs/quantile_function.cpp
##
@@ -0,0 +1,127 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include "exprs/quantile_function.h"
+#include "exprs/anyval_util.h"
+#include "gutil/strings/numbers.h"
+#include "gutil/strings/split.h"
+#include "util/quantile_state.h"
+#include "util/string_parser.hpp"
+#include "util/slice.h"
+
+namespace doris {
+
+using doris_udf::DoubleVal;
+using doris_udf::StringVal;
+using doris_udf::FloatVal;
+
+void QuantileStateFunctions::init(){}
+
+void QuantileStateFunctions::quantile_state_init(FunctionContext* ctx,
StringVal* dst) {
+dst->is_null = false;
+dst->len = sizeof(QuantileState);
+dst->ptr = (uint8_t*) new QuantileState();
+}
+
+static StringVal serialize(FunctionContext* ctx, QuantileState* value)
{
+StringVal result(ctx, value->get_serialized_size());
+value->serialize(result.ptr);
+return result;
+}
+
+StringVal QuantileStateFunctions::to_quantile_state(FunctionContext* ctx,
const StringVal& src) {
+QuantileState quantile_state;
+quantile_state.set_compression(2048);
+const AnyVal* digest_compression = ctx->get_constant_arg(1);
+if (digest_compression != nullptr) {
+float compression = reinterpret_cast(digest_compression)->val;
+if (compression >= 2048 && compression <= 1) {
+quantile_state.set_compression(compression);
+}
+}
+
+if(!src.is_null) {
+StringParser::ParseResult parse_result = StringParser::PARSE_SUCCESS;
+double double_value = StringParser::string_to_float(
+reinterpret_cast(src.ptr), src.len, &parse_result);
+if (UNLIKELY(parse_result != StringParser::PARSE_SUCCESS)) {
+std::stringstream error_msg;
+error_msg << "The input: " <<
std::string(reinterpret_cast(src.ptr), src.len)
+ << " is not valid, to_bitmap only support bigint value
from 0 to "
+ "18446744073709551615 currently";
+ctx->set_error(error_msg.str().c_str());
+return StringVal::null();
+}
+quantile_state.add_value(double_value);
+}
+return serialize(ctx, &quantile_state);
+}
+
+void QuantileStateFunctions::quantile_union(FunctionContext* ctx, const
StringVal& src, StringVal* dst) {
+if(src.is_null) {
+return;
+}
+auto dst_quantile = reinterpret_cast*>(dst->ptr);
+if(src.len == 0) {
+
dst_quantile->merge(*reinterpret_cast*>(src.ptr));
+} else {
+QuantileState state(Slice(src.ptr, src.len));
+dst_quantile->merge(state);
+}
+}
+
+DoubleVal QuantileStateFunctions::quantile_percent(FunctionContext* ctx,
StringVal& src) {
+const AnyVal* percentile = ctx->get_constant_arg(1);
+if (percentile != nullptr) {
+float percentile_value = reinterpret_cast(percentile)->val;
+if (percentile_value > 1 || percentile_value <0)
+{
+std::stringstream error_msg;
+error_msg<< "The percentile must between 0 and 1, but input is:"
<< std::to_string(percentile_value);
+ctx->set_error(error_msg.str().c_str());
+return DoubleVal::null();
+}
+
+if (src.len == 0) {
+auto quantile_state =
reinterpret_cast*>(src.ptr);
+return
{static_cast(quantile_state->get_value_by_percentile(percentile_value))};
+} else {
+QuantileState quantile_state(Slice(src.ptr, src.len));
+return
{static_cast(quantile_state.get_value_by_percentile(percentile_value))};
+}
+
+
+} else {
+std::stringstream error_msg;
+error_msg << "quantile_percent function's second argument must be
constant. eg: quantile_percent(col, 0.95)";
+ctx->set_error(error_msg.str().c_str());
+}
+return DoubleVal::null();
+}
+
+StringVal QuantileStateFunctions::quantile_state_serialize(FunctionContext*
ctx, const StringVal& src) {
+if(src.is_null) {
+return src;
+
+}
+auto tmp_ptr = reinterpret_cast*>(src.ptr);
+
[GitHub] [incubator-doris] HappenLee commented on a change in pull request #8238: [fix] Function percentile input null return null
HappenLee commented on a change in pull request #8238:
URL: https://github.com/apache/incubator-doris/pull/8238#discussion_r815556429
##
File path: be/src/vec/functions/function_timestamp.cpp
##
@@ -52,8 +52,60 @@ struct StrToDate {
if (!ts_val.from_date_format_str(r_raw_str, r_str_size, l_raw_str,
l_str_size)) {
null_map[i] = 1;
}
-ts_val.to_datetime();
+if (context->impl()->get_return_type().type ==
+doris_udf::FunctionContext::Type::TYPE_DATETIME) {
+ts_val.to_datetime();
+} else {
+ts_val.cast_to_date();
+}
+}
+}
+};
+
+template
+class FunctionStrToDateOrDateTime : public IFunction {
Review comment:
should change other function of `FunctionBinaryStringOperateToNullType`
and add `FunctionContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on pull request #8234: [Feature] Support pre-aggregation for quantile type
HappenLee commented on pull request #8234: URL: https://github.com/apache/incubator-doris/pull/8234#issuecomment-1053850074 before we release the feature, maybe we should support it in vec exec engine both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] HappenLee closed pull request #8214: [Opt] special cmp for equal string compare
HappenLee closed pull request #8214: URL: https://github.com/apache/incubator-doris/pull/8214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8261: [Bug][Vectorized] fix bitmap_ut result wrong && fix schema_change compile error
github-actions[bot] commented on pull request #8261: URL: https://github.com/apache/incubator-doris/pull/8261#issuecomment-1053854868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #7970: [Feature] Support show tablets stmt
caiconghui edited a comment on pull request #7970: URL: https://github.com/apache/incubator-doris/pull/7970#issuecomment-1053900981 please alse update doc @ChPi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #7970: [Feature] Support show tablets stmt
caiconghui commented on pull request #7970: URL: https://github.com/apache/incubator-doris/pull/7970#issuecomment-1053900981 please alse update doc, please @ChPi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt opened a new issue #8262: [Bug][Vectorized] Be core dump on memtable
BiteThet opened a new issue #8262:
URL: https://github.com/apache/incubator-doris/issues/8262
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
master
### What's Wrong?
core dump
```cpp
#0 0x56124100c929 in memcpy ()
#1 0x56124119d05c in
doris::FieldTypeTraits<(doris::FieldType)13>::deep_copy(void*, void const*,
doris::MemPool*) ()
at /root/doris-release/be/src/olap/types.h:1010
#2 0x56124129e078 in doris::MemTable::_tuple_to_row(doris::Tuple
const*, doris::ContiguousRow*, doris::MemPool*) ()
at /var/local/ldb-toolchain/include/c++/11/bits/stl_vector.h:1061
#3 0x56124129eb27 in doris::MemTable::insert(doris::Tuple const*)
(this=0x561258334280, tuple=0x5613efd2a125)
at /var/local/ldb-toolchain/include/c++/11/bits/unique_ptr.h:421
#4 0x561241bca62a in doris::DeltaWriter::write(doris::RowBatch const*,
std::vector > const&)
(this=0x56127d0d7cc0, row_batch=0x7f77a72f56b0, row_idxs=Unhandled dwarf
expression opcode 0xf3
) at /root/doris-release/be/src/runtime/tuple_row.h:31
#5 0x5612413d1bfc in
doris::TabletsChannel::add_batch(doris::PTabletWriterAddBatchRequest const&,
doris::PTabletWriterAddBatchResult*) (this=0x56126dc55900, request=...,
response=0x561278996bd0)
at /root/doris-release/be/src/runtime/tablets_channel.cpp:128
#6 0x5612413ce2bf in
doris::LoadChannel::add_batch(doris::PTabletWriterAddBatchRequest const&,
doris::PTabletWriterAddBatchResult*) (this=0x5612868a4700, request=...,
response=0x561278996bd0)
at /root/doris-release/be/src/runtime/load_channel.cpp:93
#7 0x5612413c7fa3 in
doris::LoadChannelMgr::add_batch(doris::PTabletWriterAddBatchRequest const&,
doris::PTabletWriterAddBatchResult*) (this=0x561248906780, request=...,
response=0x561278996bd0)
at /root/doris-release/be/src/runtime/load_channel_mgr.cpp:160
#8 0x561241476d7b in
doris::PInternalServiceImpl::tablet_writer_add_batch(google::protobuf::RpcController*,
doris::PTabletWriterAddBatchRequest const*,
doris::PTabletWriterAddBatchResult*,
google::protobuf::Closure*)::{lambda()#1}::operator()() const () at
/root/doris-release/be/src/runtime/exec_env.h:144
#9 0x561241369eb3 in doris::PriorityThreadPool::work_thread(int) ()
at /var/local/ldb-toolchain/include/c++/11/bits/std_function.h:556
#10 0x561244b32b50 in execute_native_thread_routine ()
#11 0x7f7847519851 in start_thread () from /lib64/libpthread.so.0
#12 0x7f784781667d in clone () from /lib64/libc.so.6
```
### What You Expected?
fix
### How to Reproduce?
_No response_
### Anything Else?
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8251: [improvement](lateral-view) Add number rows filtered in profile
github-actions[bot] commented on pull request #8251: URL: https://github.com/apache/incubator-doris/pull/8251#issuecomment-1053933457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8257: fix listdb description error
github-actions[bot] commented on pull request #8257: URL: https://github.com/apache/incubator-doris/pull/8257#issuecomment-1053934301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zhangstar333 commented on a change in pull request #8238: [fix] Function percentile input null return null
zhangstar333 commented on a change in pull request #8238:
URL: https://github.com/apache/incubator-doris/pull/8238#discussion_r815622144
##
File path: be/src/vec/functions/function_timestamp.cpp
##
@@ -52,8 +52,60 @@ struct StrToDate {
if (!ts_val.from_date_format_str(r_raw_str, r_str_size, l_raw_str,
l_str_size)) {
null_map[i] = 1;
}
-ts_val.to_datetime();
+if (context->impl()->get_return_type().type ==
+doris_udf::FunctionContext::Type::TYPE_DATETIME) {
+ts_val.to_datetime();
+} else {
+ts_val.cast_to_date();
+}
+}
+}
+};
+
+template
+class FunctionStrToDateOrDateTime : public IFunction {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] yangzhg opened a new pull request #8263: [refactor] remove unused new_in_predicate code
yangzhg opened a new pull request #8263: URL: https://github.com/apache/incubator-doris/pull/8263 # Proposed changes remove unused code of new_in_predicate.h/cpp ## Problem Summary: remove unused code of new_in_predicate.h/cpp ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No Need) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
