[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing
zuochunwei commented on pull request #7906: URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022973342 > We'd better not add `Timer` in hot code path, especially in Page.next_batch, because the Timer itself may cost lots of time. i got, just for test this version is not the final -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 closed pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
adonis0147 closed pull request #7874: URL: https://github.com/apache/incubator-doris/pull/7874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 closed issue #7873: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
adonis0147 closed issue #7873: URL: https://github.com/apache/incubator-doris/issues/7873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 commented on issue #7873: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
adonis0147 commented on issue #7873: URL: https://github.com/apache/incubator-doris/issues/7873#issuecomment-1022976001 There are some alternatives which can achieve the same effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing
zuochunwei commented on pull request #7906: URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022979072 i just want to provide this method for testing any code cost, so i marked as '//demo DEBUG timer ' to indicate that this codes will be deleted later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] bingzxy opened a new pull request #7907: fix typo
bingzxy opened a new pull request #7907: URL: https://github.com/apache/incubator-doris/pull/7907 - fix typo # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No Need) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 opened a new issue #7908: [Enhancement] [Compilation] CMake may use wrong ninja to build the code.
adonis0147 opened a new issue #7908: URL: https://github.com/apache/incubator-doris/issues/7908 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Use ldb_toolchain with custom_env.sh without changing the system-wide environment `PATH` to build Doris, CMake may use system-wide ninja to build Doris and invoke some ninja error because the unmatched versions of ninja when recompiling Doris unit test code. ```shell ninja: error failed recompaction: No such file or directory ``` ### Solution Set the full path of make program to CMake explicitly. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 opened a new pull request #7909: Set the full path of make program to CMake.
adonis0147 opened a new pull request #7909: URL: https://github.com/apache/incubator-doris/pull/7909 # Proposed changes Issue Number: close #7908 ## Problem Summary: ## Checklist(Required) 1. Does it affect the original behavior: No. 2. Has unit tests been added: No Need. 3. Has document been added or modified: No Need. 4. Does it need to update dependencies: No. 5. Are there any changes that cannot be rolled back: Yes/No. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] spaces-X opened a new issue #7910: [Bug] query analyze failed after change the default bucket num
spaces-X opened a new issue #7910:
URL: https://github.com/apache/incubator-doris/issues/7910
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and
found no similar issues.
### Version
0.15 or 0.14
### What's Wrong?
Increase the default bucket num of and then the sql queried this table will
encounter error `Index XXX out of bounds for length XXX`.
See Reproduce SQL
### What You Expected?
The SQL can run normally.
### How to Reproduce?
```
CREATE TABLE `bucket_test` (
`dt` bigint(20) NULL COMMENT "",
`id1` bigint(20) NULL COMMENT "",
`first_time` varchar(20) MIN NULL COMMENT "",
`last_time` varchar(20) MAX NULL COMMENT ""
) ENGINE=OLAP
AGGREGATE KEY(`dt`, `id1`)
PARTITION BY RANGE(`dt`)
(
PARTITION p1 VALUES [("20220101"),("20220201")),
partition p2 VALUES [("20211201"),("20220101"))
)
DISTRIBUTED BY HASH(`id1`) BUCKETS 1
PROPERTIES (
"replication_num" = "3",
"in_memory" = "false",
"storage_format" = "V2"
);
insert into bucket_test values (20211201,1,"50","50");
insert into bucket_test values (20211201,2,"50","50");
insert into bucket_test values (20211201,3,"50","50");
insert into bucket_test values (20211201,4,"50","50");
alter table bucket_test modify distribution DISTRIBUTED BY HASH(id1) BUCKETS
20
select * from bucket_test where dt = 20211201 and id1 =1;
```
error `Index XXX out of bounds for length XXX`.
### Anything Else?
Quick recovery SOP：
First, Extract master node query traffic.
If not recovered then restart fe-master
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of
Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz opened a new pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
xinyiZzz opened a new pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911 ## Problem Summary: Error details in be.out: /home/disk3/zxy/baidu/bdg/doris/core/output/be/lib/palo_be: /lib64/libc.so.6: version `GLIBC_2.18' not found (required by /home/disk3/zxy/ baidu/bdg/doris/core/output/be/lib/palo_be) nm looks at palo_be and finds that the method that depends on GLIBC_2.18 is `__cxa_thread_atexit_impl`  I found that the `__cxa_thread_atexit_impl` method was introduced by glibc to support thread_local variables https://sourceware.org/glibc/wiki/Destructor%20support%20for%20thread_local%20variables It was no problem to compile through gcc10 before, our development machine glibc version only reaches GLIBC_2.12, and it is not allowed to upgrade the glibc version... So, how can I avoid this problem, please help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on issue #7901: [Feature] [Vectorized] Some Join opt in vec exec engine
EmmyMiao87 commented on issue #7901: URL: https://github.com/apache/incubator-doris/issues/7901#issuecomment-1023087786 I will resolve this issue together ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] htyoung opened a new pull request #7912: fix(ui):fix home page spin bug #7170
htyoung opened a new pull request #7912: URL: https://github.com/apache/incubator-doris/pull/7912 1. The Spin(loading circle) will disappear after hardware info loaded # Proposed changes Issue Number: close #7170 ## Problem Summary: when I visit apache doris ui home page，it still exists a Spin(loading circle) after hardware info loaded，but the Spin(loading circle) should disappear after hardware info loaded。 ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No Need) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui opened a new issue #7913: [Enhancement] Support that user can use show data skew statement instead of admin
caiconghui opened a new issue #7913: URL: https://github.com/apache/incubator-doris/issues/7913 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description now only admin can execute show data skew statement which is inconvenient for general user ### Solution Support that user can use show data skew statement instead of admin ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui opened a new pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
caiconghui opened a new pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914 # Proposed changes Issue Number: close #7913 ## Problem Summary: This PR mainly do two things: 1. Support that user can use show data skew statement instead of admin 2. Fix fe ut failed caused by pr #7876 ## Checklist(Required) 1. Does it affect the original behavior: (Yes) 2. Has unit tests been added: (No) 3. Has document been added or modified: (Yes) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
caiconghui commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023164720 ut failed cc @EmmyMiao87 show data skew cc @morningman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] dongweizhao opened a new pull request #7915: Add substr function description document
dongweizhao opened a new pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915 # Proposed changes Issue Number: close #xxx ## Problem Summary: Add substr function description ## Checklist(Required) 1. Does it affect the original behavior: No 2. Has unit tests been added: No 3. Has document been added or modified: Yes 4. Does it need to update dependencies: No 5. Are there any changes that cannot be rolled back:No ## Further comments Local tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zenoyang opened a new issue #7916: [Enhancement](Vectorized) Optinmize dict page decoder init
zenoyang opened a new issue #7916: URL: https://github.com/apache/incubator-doris/issues/7916 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description The current code, every time the data page is read, it will traverse the dict page once to obtain `_dict_start_offset_array`, `_dict_len_array`, in fact, it is only used to initialize the `_dict_decoder` in the FileColumnIterator, traverse the dict page once, and then call each time `dict_page_decoder->set_dict_decoder` reuses the original result. ### Solution Traverse the dict page once, and then call each time `dict_page_decoder->set_dict_decoder` reuses the original result. ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zenoyang opened a new pull request #7917: [Enhancement](Vectorized) Optinmize dict page decoder init
zenoyang opened a new pull request #7917: URL: https://github.com/apache/incubator-doris/pull/7917 # Proposed changes Issue Number: close #7916 Traverse the dict page once, and then call each time `dict_page_decoder->set_dict_decoder` reuses the result of `_dict_start_offset_array, _dict_len_array` ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui edited a comment on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
caiconghui edited a comment on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023164720 ut failed cc @EmmyMiao87 show data skew cc @morningman cc @qidaye -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7907: [docs] fix typo
github-actions[bot] commented on pull request #7907: URL: https://github.com/apache/incubator-doris/pull/7907#issuecomment-1023257876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 opened a new issue #7918: [Bug] Fail to rerun build-thirdparty.sh.
adonis0147 opened a new issue #7918: URL: https://github.com/apache/incubator-doris/issues/7918 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master ### What's Wrong? Due to the merge #7867 , the script `build-thirdparty.sh` will exit immediately when the errors occur. However the code returned by function `download_func` in `download-thirdparty.sh` is wrong. The function in bash should return __*zero*__ to indicate success. ### What You Expected? Fix the return code of function `download_func` in `download-thirdparty.sh`. ### How to Reproduce? Rerun `build-thirdparty.sh`. ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] adonis0147 opened a new pull request #7919: [chore] Fix the return code of function download_func
adonis0147 opened a new pull request #7919: URL: https://github.com/apache/incubator-doris/pull/7919 # Proposed changes Issue Number: close #7918 ## Problem Summary: Please refer to #7918 ## Checklist(Required) 1. Does it affect the original behavior: No. 2. Has unit tests been added: No Need. 3. Has document been added or modified: No Need. 4. Does it need to update dependencies: No. 5. Are there any changes that cannot be rolled back: No. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
morningman commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023367102 PTAL @amosbird , if you have time, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
EmmyMiao87 commented on a change in pull request #7914:
URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r793757061
##
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/MetadataViewer.java
##
@@ -288,7 +287,7 @@ private static String graph(long num, long totalNum) {
List tabletIds = mIndex.getTabletIdsInOrder();
for (int i = 0; i < tabletIds.size(); i++) {
Tablet tablet = mIndex.getTablet(tabletIds.get(i));
-long dataSize = tablet.getDataSize(false);
+long dataSize = tablet.getDataSize(true);
Review comment:
Maybe single replica is better ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
EmmyMiao87 commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023367991 The document could not be built correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023369852 Is it for some future PRs with thread local? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
morningman commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023372778 > Is it for some future PRs with thread local? Yes, @xinyiZzz is developing memory tracking and management based on thread local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
morningman edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023372778 > Is it for some future PRs with thread local? Yes, @xinyiZzz is developing memory tracking and management based on thread local. And this is just a PR for troubleshooting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023375876 > > Is it for some future PRs with thread local? > > Yes, @xinyiZzz is developing memory tracking and management based on thread local. And this is just a PR for troubleshooting. Cool. Will take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
caiconghui commented on a change in pull request #7914:
URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r793765347
##
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/MetadataViewer.java
##
@@ -288,7 +287,7 @@ private static String graph(long num, long totalNum) {
List tabletIds = mIndex.getTabletIdsInOrder();
for (int i = 0; i < tabletIds.size(); i++) {
Tablet tablet = mIndex.getTablet(tabletIds.get(i));
-long dataSize = tablet.getDataSize(false);
+long dataSize = tablet.getDataSize(true);
Review comment:
now，just according to the average data size column，here should compute
average data size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new issue #7920: [Bug]
morningman opened a new issue #7920: URL: https://github.com/apache/incubator-doris/issues/7920 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk ### What's Wrong? When set be config `transfer_data_by_brpc_attachment` to true. And run some join query which has exchange node, BE may crash with following stack: ``` start time: Thu Jan 27 15:57:55 CST 2022 Minidump created at: /home/cmy/palo/be/minidump/c9476a55-12e8-493c-21b4f1ab-c2308bc9.dmp *** Aborted at 1643270317 (unix time) try "date -d @1643270317" if you are using GNU date *** PC: @ 0x1b06030 doris::HashTable::hash_variable_len_row() *** SIGSEGV (@0x17539d10) received by PID 21897 (TID 0x7fa129f58700) from PID 391355664; stack trace: *** @ 0x21e6e22 google::(anonymous namespace)::FailureSignalHandler() @ 0x7fa22d6c4f90 (unknown) @ 0x1b06030 doris::HashTable::hash_variable_len_row() @ 0x1b05473 doris::HashJoinNode::process_build_batch() @ 0x1b02510 doris::HashJoinNode::construct_hash_table() @ 0x1b02a12 doris::HashJoinNode::build_side_thread() @ 0x3a403a0 execute_native_thread_routine @ 0x7fa22d674f84 start_thread @ 0x7fa22d781ddf __GI___clone @0x0 (unknown) ``` ### What You Expected? Not crash ### How to Reproduce? _No response_ ### Anything Else? _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman opened a new pull request #7921: [fix](brpc-attachment) Fix bug that may cause BE crash when enable `transfer_data_by_brpc_attachment`
morningman opened a new pull request #7921: URL: https://github.com/apache/incubator-doris/pull/7921 # Proposed changes Issue Number: close #7920 ## Problem Summary: In `data_stream_sender`, we will send a serialized PRowBatch data to multiple Channels. And if `transfer_data_by_brpc_attachment` is enabled, we will mistakenly clear the data in PRowBatch after sending PRowBatch to the first Channel. As a result, the following Channel cannot receive the correct data, causing an error. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No) 3. Has document been added or modified: (No Need) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023508528 I did some investigation. It's not easy to mask the symbol, which is from libc++abi https://libcxxabi.llvm.org/spec.html . It's also not safe to use the polyfill implementation from some libc++api directly. I'd suggest the following: 1. use clang toolchain 2. keep thread_local with trivial destructor if gcc is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] amosbird edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
amosbird edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023508528 I did some investigation. It's not easy to mask this symbol, which is meant to be added to the libc++abi. It's also not safe to use the polyfill implementation from some libc++api directly. I'd suggest the following: 1. use clang toolchain 2. keep thread_local with trivial destructor if gcc is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] dataroaring opened a new pull request #7922: rename DDL Statements to SQL Statements in sidebars of docs in english
dataroaring opened a new pull request #7922: URL: https://github.com/apache/incubator-doris/pull/7922 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] luzhijing commented on pull request #7915: Add substr function description document
luzhijing commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023819319 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qidaye commented on a change in pull request #7915: Add substr function description document
qidaye commented on a change in pull request #7915:
URL: https://github.com/apache/incubator-doris/pull/7915#discussion_r794157060
##
File path: docs/en/sql-reference/sql-functions/string-functions/substr.md
##
@@ -0,0 +1,55 @@
+---
+{
+"title": "substr",
+"language": "en"
+}
+---
+
+
+
+# substr
+## description
+### Syntax
+
+`VARCHAR substr(VARCHAR content, INT start, INT length)`
+
+Find a substring, return the part of the string described by the first
parameter starting from start and having a length of len. The index of the
first letter is 1.
+
+## example
+
+```
+mysql> select substr("Hello doris",2,1);
Review comment:
```suggestion
mysql> select substr("Hello doris", 2, 1);
```
##
File path: docs/.vuepress/sidebar/zh-CN.js
##
@@ -373,6 +373,7 @@ module.exports = [
"starts_with",
"strleft",
"strright",
+ "substr",
Review comment:
```suggestion
"substr",
```
##
File path: docs/en/sql-reference/sql-functions/string-functions/substr.md
##
@@ -0,0 +1,55 @@
+---
+{
+"title": "substr",
+"language": "en"
+}
+---
+
+
+
+# substr
+## description
+### Syntax
+
+`VARCHAR substr(VARCHAR content, INT start, INT length)`
+
+Find a substring, return the part of the string described by the first
parameter starting from start and having a length of len. The index of the
first letter is 1.
+
+## example
+
+```
+mysql> select substr("Hello doris",2,1);
++-+
+| substr('Hello doris', 2, 1) |
++-+
+| e |
++-+
+
+
+mysql> select substr("Hello doris",1,2);
Review comment:
```suggestion
mysql> select substr("Hello doris", 1, 2);
```
##
File path: docs/zh-CN/sql-reference/sql-functions/string-functions/substr.md
##
@@ -0,0 +1,55 @@
+---
+{
+"title": "substr",
+"language": "zh-CN"
+}
+---
+
+
+
+# substr
+## description
+### Syntax
+
+`VARCHAR substr(VARCHAR content, INT start, INT length)`
+
+求子字符串，返回第一个参数描述的字符串中从start开始长度为len的部分字符串。首字母的下标为1。
+
+## example
+
+```
+mysql> select substr("Hello doris",2,1);
++-+
+| substr('Hello doris', 2, 1) |
++-+
+| e |
++-+
+
+
+mysql> select substr("Hello doris",1,2);
Review comment:
```suggestion
mysql> select substr("Hello doris", 1, 2);
```
##
File path: docs/zh-CN/sql-reference/sql-functions/string-functions/substr.md
##
@@ -0,0 +1,55 @@
+---
+{
+"title": "substr",
+"language": "zh-CN"
+}
+---
+
+
+
+# substr
+## description
+### Syntax
+
+`VARCHAR substr(VARCHAR content, INT start, INT length)`
+
+求子字符串，返回第一个参数描述的字符串中从start开始长度为len的部分字符串。首字母的下标为1。
+
+## example
+
+```
+mysql> select substr("Hello doris",2,1);
Review comment:
```suggestion
mysql> select substr("Hello doris", 2, 1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qidaye commented on pull request #7922: rename DDL Statements to SQL Statements in sidebars of docs in english
qidaye commented on pull request #7922: URL: https://github.com/apache/incubator-doris/pull/7922#issuecomment-1023827810 LGTM. Please format your commit info according to the document [commit-format](https://doris.apache.org/zh-CN/community/commit-format-specification.html) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qidaye commented on pull request #7915: Add substr function description document
qidaye commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023831431 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] qidaye removed a comment on pull request #7915: Add substr function description document
qidaye removed a comment on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023831431 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] dongweizhao commented on pull request #7915: Add substr function description document
dongweizhao commented on pull request #7915: URL: https://github.com/apache/incubator-doris/pull/7915#issuecomment-1023833929 > Attention to the format. Please format your commit info according to the document [commit-format](https://doris.apache.org/zh-CN/community/commit-format-specification.html) OK, pay attention next time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7923: [storage]add Generic debug timer for debugging or profiling
zuochunwei opened a new pull request #7923: URL: https://github.com/apache/incubator-doris/pull/7923 # Proposed changes add a group of debug-timer for the purpose of profiling or testing you can use these timers for custom meaning purpose unlike the specific named timer i will close the same PR #7906 Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7198: [Memory] Refactor MemTracker and new memory statistics framework based on TCMalloc Hook
xinyiZzz commented on a change in pull request #7198: URL: https://github.com/apache/incubator-doris/pull/7198#discussion_r794177942 ## File path: be/src/common/config.h ## @@ -594,12 +594,28 @@ CONF_Int32(aws_log_level, "3"); // the buffer size when read data from remote storage like s3 CONF_mInt32(remote_storage_read_buffer_mb, "16"); +// Whether to initialize TCmalloc new/delete Hook, MemTracker is currently counted in Hook. +CONF_mBool(use_tc_hook, "true"); Review comment: done, thats sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7865: [fix](lateral-view) fix bugs of lateral view with CTE or where clause
github-actions[bot] commented on pull request #7865: URL: https://github.com/apache/incubator-doris/pull/7865#issuecomment-1023853768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7917: [typo](storage) Optinmize dict page decoder init
github-actions[bot] commented on pull request #7917: URL: https://github.com/apache/incubator-doris/pull/7917#issuecomment-1023855007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7924: (documation) Update debug-tool.md for scan debug-timer group
zuochunwei opened a new pull request #7924:
URL: https://github.com/apache/incubator-doris/pull/7924
scan debug timer
OlapScanNode中有一组调试定时器（_general_debug_timer）可供debugging和profiling之用，_general_debug_timer是一个定时器组，通过_general_debug_timer+下标非常方面的使用具体的某一个定时器。
_general_debug_timer有别于特定用途的有明确含义的定时器，testing和profiling过程中，你可以根据需要，记录任何你想记录的内容，但最终这些代码记录不需要提交。
比如你修改了某个函数，想测这个函数或者代码片段的开销，便可以借助_general_debug_timer，示例代码如下
SCOPED_RAW_TIMER(&stats->general_debug_ns[2]); //demo debug timer
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
EmmyMiao87 commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r794181689 ## File path: docs/.vuepress/sidebar/en.js ## @@ -616,6 +615,7 @@ module.exports = [ "SHOW CREATE FUNCTION", "SHOW CREATE ROUTINE LOAD", "SHOW DATA", + "SHOW DATA SKEW", Review comment: This name must be same as the name of document ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
xinyiZzz commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023861894 > I did some investigation. It's not easy to mask this symbol, which is meant to be added to the libc++abi. It's also not safe to use the polyfill implementation from some libc++api directly. I'd suggest the following: > > 1. use clang toolchain > 2. keep thread_local with trivial destructor if gcc is used. Thanks for the answer~ @amosbird Compiling with clang is indeed fine. Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this variable. or other meanings. My pr: https://github.com/apache/incubator-doris/pull/7198 I want to track all memory requests during a thread lifetime via thread_local + TCMalloc hook, like Clickhouse does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
caiconghui commented on a change in pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#discussion_r794189411 ## File path: docs/.vuepress/sidebar/en.js ## @@ -616,6 +615,7 @@ module.exports = [ "SHOW CREATE FUNCTION", "SHOW CREATE ROUTINE LOAD", "SHOW DATA", + "SHOW DATA SKEW", Review comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7914: [improvement](show) Support that user can use show data skew statement instead of admin
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/incubator-doris/pull/7914#issuecomment-1023873830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] hf200012 commented on pull request #7848: [Compatible]http v2 and v1 interface compatible
hf200012 commented on pull request #7848: URL: https://github.com/apache/incubator-doris/pull/7848#issuecomment-1023880219 > Please config your IDEA to enable auto code format ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] amosbird commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
amosbird commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023889347 > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this variable. or other meanings. You can redesign the implementation of your thread_local structs to have trivial destructor. The definition is in https://en.cppreference.com/w/cpp/language/destructor . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
xinyiZzz commented on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023917862 > > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this variable. or other meanings. > > You can redesign the implementation of your thread_local structs to have trivial destructor. The definition is in https://en.cppreference.com/w/cpp/language/destructor . I think I understand trivial destructor, For non-trivial classes in thread_local, such as std::string, I plan to store them as pointers. To ensure that thread_local is trivial, these non-trivial pointers will uniformly call destructors elsewhere. thanks again, very helpful @amosbird -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz edited a comment on pull request #7911: [Help] gcc11 compiles `thread_local` variable, BE start: version `GLIBC_2.18' not found
xinyiZzz edited a comment on pull request #7911: URL: https://github.com/apache/incubator-doris/pull/7911#issuecomment-1023917862 > > Regarding the second point, do you mean changing the thread_local variable to a member variable of the class? For example, abstract a parent class to save this variable. or other meanings. > > You can redesign the implementation of your thread_local structs to have trivial destructor. The definition is in https://en.cppreference.com/w/cpp/language/destructor . I think I understand trivial destructor, For non-trivial variables in thread_local, such as std::string, I plan to store them as pointers. To ensure that thread_local is trivial, these non-trivial pointers will uniformly call destructors elsewhere. And try to use POD type. thanks again, very helpful @amosbird -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] hf200012 opened a new pull request #7925: [optimization]Remove the old http module and completely replace it with http v2
hf200012 opened a new pull request #7925: URL: https://github.com/apache/incubator-doris/pull/7925 The http v2 version can completely replace the old http module. In order to avoid the problem of inconsistency between the two codes, the old http module will be removed. # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (No) 2. Has unit tests been added: (No) 3. Has document been added or modified: (Yes) 4. Does it need to update dependencies: (No) 5. Are there any changes that cannot be rolled back: (No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7924: (documation) Update debug-tool.md for scan debug-timer group
github-actions[bot] commented on pull request #7924: URL: https://github.com/apache/incubator-doris/pull/7924#issuecomment-1023971494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
