[GitHub] [incubator-doris] hf200012 opened a new pull request #7135: [Blog]Doris monitoring metrics description

2021-11-17 Thread GitBox


hf200012 opened a new pull request #7135:
URL: https://github.com/apache/incubator-doris/pull/7135


   Doris monitoring metrics description
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [ ] Optimization. Including functional usability improvements and 
performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature 
there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
d...@doris.apache.org by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] THUMarkLau opened a new pull request #7136: [Doc] Fix typo in CONTRIBUTING.md and CONTRIBUTING_CN.md

2021-11-17 Thread GitBox


THUMarkLau opened a new pull request #7136:
URL: https://github.com/apache/incubator-doris/pull/7136


   "Apache" is incorrectly spelled as "Aapche"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7136: [Doc] Fix typo in CONTRIBUTING.md and CONTRIBUTING_CN.md

2021-11-17 Thread GitBox


github-actions[bot] commented on pull request #7136:
URL: https://github.com/apache/incubator-doris/pull/7136#issuecomment-971399401






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] hf200012 opened a new pull request #7137: remove Invalid code

2021-11-17 Thread GitBox


hf200012 opened a new pull request #7137:
URL: https://github.com/apache/incubator-doris/pull/7137


   remove Invalid code
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [ ] Optimization. Including functional usability improvements and 
performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature 
there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
d...@doris.apache.org by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xy720 opened a new pull request #7138: [Binlog]Add how to open binlog load to the error message

2021-11-17 Thread GitBox


xy720 opened a new pull request #7138:
URL: https://github.com/apache/incubator-doris/pull/7138


   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the 
maintainers why we should accept this pull request. If it fixes a bug or 
resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
d...@doris.apache.org by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman opened a new issue #7139: [Bug] Root user has been dropped

2021-11-17 Thread GitBox


morningman opened a new issue #7139:
URL: https://github.com/apache/incubator-doris/issues/7139


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   0.15
   
   ### What's Wrong?
   
   root user can be dropped. And after that, user can not create a real root 
user anymore.
   
   ### What You Expected?
   
   root user can not be created or dropped.
   
   ### How to Reproduce?
   
   `drop user root@'%'`
   
   Then if try to login with root, it will fail
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman opened a new pull request #7140: [Bug] Do not allow drop or create root user

2021-11-17 Thread GitBox


morningman opened a new pull request #7140:
URL: https://github.com/apache/incubator-doris/pull/7140


   ## Proposed changes
   
   root user should not be dropped or created
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [ ] Optimization. Including functional usability improvements and 
performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [x] I have created an issue on (Fix #7139) and described the bug/feature 
there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
d...@doris.apache.org by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] weizuo93 opened a new issue #7141: [Feature] [Stream Load] Two-Phase Commit for stream load

2021-11-17 Thread GitBox


weizuo93 opened a new issue #7141:
URL: https://github.com/apache/incubator-doris/issues/7141


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Description
   
   ### Background
   In the sample Doris application, data flow is as follows:
   * read streaming data from Kafka
   * Execute ETL in Flink
   * Sink data batch to Doris by `stream load`
   
   Flink generates checkpoints on a regular, configurable interval and then 
writes the checkpoint to a persistent storage system, such as HDFS. A 
checkpoint in Flink is a consistent snapshot of:
   * The current state of an application
   * The consumption progress of data stream(`offset`)
   
   ![2021-11-17 20-43-16 
的屏幕截图](https://user-images.githubusercontent.com/68884553/142202896-1402fe7f-adb2-42fb-9ac9-9f7dfe7e1acc.png)
   
   In the event of a machine or Flink software failure and upon restart, the 
Flink application resumes processing from the most recent 
successfully-completed checkpoint, which causes partial data to be loaded to 
Doris twice and duplicate data.
   
   To provide exactly-once semantics, Doris must provide a means to commit or 
rollback load that coordinate with Flink's checkpoints. So, it's better to 
support `Two-Phase Commit(2PC)` for stream load.
   
   For the data sink to provide exactly-once guarantees, it must:
   * write all data to Doris through several stream load tasks between two 
checkpoints (All data is non-visible).
   * commit all stream load tasks between two checkpoints(All data is visible).
   
   In the event of a machine or Flink software failure and upon restart, commit 
all stream load tasks between the most recent two checkpoints(It is ok to 
execute commit repeatedly for a stream load task).
   
   ### Design
   
   The design of the two phase for stream load is as follows:
   
   * First Phase:
   
   ![2021-11-02 15-55-26 
的屏幕截图](https://user-images.githubusercontent.com/68884553/142198985-18bf0b3a-eb36-4ee1-bb37-fc79c6f70ab5.png)
   
   
   * Second Phase:
   ![2021-11-02 15-57-47 
的屏幕截图](https://user-images.githubusercontent.com/68884553/142199038-4c36a277-cdcc-4de8-bcb1-4d0ffcde88f8.png)
   
   Once the `pre-commit` is complete, we must ensure that the `commit` can be 
successful.
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinyiZzz opened a new issue #7142: [Bug] Coordinator automatically retry Export task always fails

2021-11-17 Thread GitBox


xinyiZzz opened a new issue #7142:
URL: https://github.com/apache/incubator-doris/issues/7142


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### Version
   
   trunk
   
   ### What's Wrong?
   
   When the Export task fails, FE will retry by default, but the retry always 
fails.
   
   The reason is incomplete clear export status before Coordinator retry Export 
task
   
   Report an error:
   `2021-11-17 15:01:04,537 INFO (thrift-server-pool-1748|466474) 
[QeProcessorImpl.reportExecStatus():174] ReportExecStatus(): 
fragment_instance_id=57fa74e88ff54b35-b6c5c90bb3ed51de, query 
id=57fa74e88ff54b35-b6c5c90bb3ed51db, backend num: 2, ip: 
TNetworkAddress(hostname:172.16.0.95, port:57906)
   **2021-11-17 15:01:04,537 INFO (thrift-server-pool-1748|466474) 
[QeProcessorImpl.reportExecStatus():183] ReportExecStatus() runtime error, 
query TUniqueId(hi:6339507967673846581, lo:-5276590336294170149) does not 
exist**
   2021-11-17 15:01:04,539 INFO (doris-mysql-nio I/O-3|92) 
[AcceptListener.handleEvent():50] Connection established. 
remote=/127.0.0.1:36772
   2021-11-17 15:01:04,540 WARN (export_exporting_job_pool-4|451822) 
[Coordinator.sendFragment():593] exec plan fragment failed, errmsg=Failed to 
get query fragments context. Query may be timeout or be cancelled. host: , 
code: INTERNAL_ERROR, fragmentId=F01, backend=172.16.0.95:9060
   2021-11-17 15:01:04,541 INFO (doris-mysql-nio-pool-20189|466388) 
[StmtExecutor.analyze():484] begin to analyze stmt: 11466983, forwarded stmt 
id: 0
   2021-11-17 15:01:04,541 INFO (export_exporting_job_pool-4|451822) 
[Coordinator.cancelInternal():809] unfinished instance: 
57fa74e88ff54b35-9b79f741478841a7
   2021-11-17 15:01:04,541 WARN (export_exporting_job_pool-4|451822) 
[ExportExportingTask.actualExecCoord():213] export Coordinator execute failed. 
job: 93044
   org.apache.doris.common.UserException: errCode = 2, detailMessage = Failed 
to get query fragments context. Query may be timeout or be cancelled. host:
at org.apache.doris.qe.Coordinator.sendFragment(Coordinator.java:605) 
~[palo-fe.jar:3.4.0]
at org.apache.doris.qe.Coordinator.exec(Coordinator.java:490) 
~[palo-fe.jar:3.4.0]
at 
org.apache.doris.task.ExportExportingTask.actualExecCoord(ExportExportingTask.java:211)
 [palo-fe.jar:3.4.0]
at 
org.apache.doris.task.ExportExportingTask.execOneCoord(ExportExportingTask.java:190)
 [palo-fe.jar:3.4.0]
at 
org.apache.doris.task.ExportExportingTask.exec(ExportExportingTask.java:106) 
[palo-fe.jar:3.4.0]
at org.apache.doris.task.MasterTask.run(MasterTask.java:31) 
[palo-fe.jar:3.4.0]
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
[?:1.8.0_161]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
[?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
[?:1.8.0_161]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
[?:1.8.0_161]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_161]`
   
   ### What You Expected?
   
   Can retry normally after Export task fails
   
   ### How to Reproduce?
   
   _No response_
   
   ### Anything Else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinyiZzz opened a new pull request #7143: [Export] Fix Export task automatic retry always fail

2021-11-17 Thread GitBox


xinyiZzz opened a new pull request #7143:
URL: https://github.com/apache/incubator-doris/pull/7143


   ## Proposed changes
   
   fix #7142
   clear export status `alreadySentBackendIds` before Coordinator retry Export 
task.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   - [ ] Code refactor (Modify the code structure, format the code, etc...)
   - [ ] Optimization. Including functional usability improvements and 
performance improvements.
   - [ ] Dependency. Such as changes related to third-party components.
   - [ ] Other.
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after 
creating the PR. If you're unsure about any of them, don't hesitate to ask. 
We're here to help! This is simply a reminder of what we are going to look for 
before merging your code._
   
   - [x] I have created an issue on (Fix #7142) and described the bug/feature 
there in detail
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature 
works
   - [ ] If these changes need document changes, I have updated the document
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
d...@doris.apache.org by explaining why you chose the solution you did and what 
alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7140: [Bug] Do not allow drop or create root user

2021-11-17 Thread GitBox


github-actions[bot] commented on pull request #7140:
URL: https://github.com/apache/incubator-doris/pull/7140#issuecomment-972399372






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinghuayu007 commented on issue #3897: subquery can not reslove the grandpa column

2021-11-17 Thread GitBox


xinghuayu007 commented on issue #3897:
URL: 
https://github.com/apache/incubator-doris/issues/3897#issuecomment-972461600


   Did this problem be solved?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7032: [Heartbeat] Support cancel outdated query after FE restart

2021-11-17 Thread GitBox


xinyiZzz commented on a change in pull request #7032:
URL: https://github.com/apache/incubator-doris/pull/7032#discussion_r751867135



##
File path: be/src/agent/heartbeat_server.h
##
@@ -34,9 +35,22 @@ class StorageEngine;
 class Status;
 class ThriftServer;
 
+struct FrontendStartInfo {
+int64_t start_time;
+bool is_alive;
+DateTimeValue* last_heartbeat; // Invalid time of Info

Review comment:
   Doris use int_64 uniformly?

##
File path: be/src/agent/heartbeat_server.cpp
##
@@ -78,6 +78,32 @@ void HeartbeatServer::heartbeat(THeartbeatResult& 
heartbeat_result,
 Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) {
 std::lock_guard lk(_hb_mtx);
 
+if (master_info.__isset.frontends_info) {
+std::stringstream ss;
+ss << "Heartbeat frontends info len: " << 
master_info.frontends_info.size();
+for (auto info: master_info.frontends_info) {

Review comment:
   done, Thats good




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7138: [Binlog]Add how to open binlog load to the error message

2021-11-17 Thread GitBox


github-actions[bot] commented on pull request #7138:
URL: https://github.com/apache/incubator-doris/pull/7138#issuecomment-972512117






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7137: remove Invalid code

2021-11-17 Thread GitBox


github-actions[bot] commented on pull request #7137:
URL: https://github.com/apache/incubator-doris/pull/7137#issuecomment-972524571






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7032: [Heartbeat] Support cancel outdated query after FE restart

2021-11-17 Thread GitBox


xinyiZzz commented on a change in pull request #7032:
URL: https://github.com/apache/incubator-doris/pull/7032#discussion_r751896740



##
File path: be/src/agent/heartbeat_server.cpp
##
@@ -78,6 +78,32 @@ void HeartbeatServer::heartbeat(THeartbeatResult& 
heartbeat_result,
 Status HeartbeatServer::_heartbeat(const TMasterInfo& master_info) {
 std::lock_guard lk(_hb_mtx);
 
+if (master_info.__isset.frontends_info) {
+std::stringstream ss;
+ss << "Heartbeat frontends info len: " << 
master_info.frontends_info.size();
+for (auto info: master_info.frontends_info) {
+ss << "; host:" << info.network_address.hostname
+<< ", port:" << info.network_address.port
+<< ", fe_start_time:" << info.fe_start_time
+<< ", is_alive:" << info.is_alive;
+std::string coord_addr_str = info.network_address.hostname + ":" + 
std::to_string(info.network_address.port);
+auto fsi_ptr = 
_exec_env->frontends_start_time().find(coord_addr_str);
+if (LIKELY(fsi_ptr != _exec_env->frontends_start_time().end())) {
+fsi_ptr->second->is_alive = info.is_alive;

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] Userwhite commented on pull request #6990: Doris on es 聚合下推

2021-11-17 Thread GitBox


Userwhite commented on pull request #6990:
URL: https://github.com/apache/incubator-doris/pull/6990#issuecomment-972546875


   > 
   OK, I know it. I will deal with it recently. Now nothing has done because I 
am busy in the last and this week😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] Userwhite commented on pull request #6990: Doris on es 聚合下推

2021-11-17 Thread GitBox


Userwhite commented on pull request #6990:
URL: https://github.com/apache/incubator-doris/pull/6990#issuecomment-972547344


   > > 
   > 
   > 
   
   
   
   > @Userwhite As discussed in our online meeting,we should move the 
predicate-transform from BE (backends) to FE (frontends) which would contribute 
significant effect for subsequent planning and extension. We will continue to 
pay more attention and participation in this PR
   
   OK, I know it. I will deal with it recently. Now nothing has done because I 
am busy in the last and this week😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] Userwhite removed a comment on pull request #6990: Doris on es 聚合下推

2021-11-17 Thread GitBox


Userwhite removed a comment on pull request #6990:
URL: https://github.com/apache/incubator-doris/pull/6990#issuecomment-972546875


   > 
   OK, I know it. I will deal with it recently. Now nothing has done because I 
am busy in the last and this week😂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7108: [Bug] Fix the incompatibility of sql mode between Doris and MySQL

2021-11-17 Thread GitBox


morningman merged pull request #7108:
URL: https://github.com/apache/incubator-doris/pull/7108


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman closed issue #7106: [Bug] Fix the incompatibility of sql mode between Doris and MySQL

2021-11-17 Thread GitBox


morningman closed issue #7106:
URL: https://github.com/apache/incubator-doris/issues/7106


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (9487899 -> 74e8264)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from 9487899  Update members.md (#7115)
 add 74e8264  [fix](session-var) Fix the incompatibility of sql mode 
between Doris and MySQL (#7108)

No new revisions were added by this update.

Summary of changes:
 .../main/java/org/apache/doris/analysis/ExpressionFunctions.java | 9 +
 .../src/main/java/org/apache/doris/analysis/SysVariableDesc.java | 3 +--
 .../src/main/java/org/apache/doris/qe/VariableVarConverters.java | 4 ++--
 .../src/test/java/org/apache/doris/analysis/SetVariableTest.java | 2 +-
 4 files changed, 5 insertions(+), 13 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7114: [Routine load] Support show offset lag in show routine load stmt

2021-11-17 Thread GitBox


morningman merged pull request #7114:
URL: https://github.com/apache/incubator-doris/pull/7114


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman closed issue #7113: [Feature] Show offset lag for routine load job

2021-11-17 Thread GitBox


morningman closed issue #7113:
URL: https://github.com/apache/incubator-doris/issues/7113


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (74e8264 -> be89f0f)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from 74e8264  [fix](session-var) Fix the incompatibility of sql mode 
between Doris and MySQL (#7108)
 add be89f0f  [feat-opt](routine-load) Support show offset lag in show 
routine load stmt (#7114)

No new revisions were added by this update.

Summary of changes:
 .../Data Manipulation/SHOW ROUTINE LOAD.md | 45 ++
 .../Data Manipulation/SHOW ROUTINE LOAD.md | 45 ++
 .../apache/doris/analysis/ShowRoutineLoadStmt.java |  1 +
 .../doris/common/proc/RoutineLoadsNameProcDir.java |  3 +-
 .../apache/doris/common/util/PropertyAnalyzer.java |  1 -
 .../doris/load/routineload/KafkaProgress.java  | 21 ++
 .../load/routineload/KafkaRoutineLoadJob.java  |  7 
 .../doris/load/routineload/RoutineLoadJob.java |  6 ++-
 8 files changed, 126 insertions(+), 3 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7127: correct getLogger argument

2021-11-17 Thread GitBox


morningman merged pull request #7127:
URL: https://github.com/apache/incubator-doris/pull/7127


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (be89f0f -> eaebe6a)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from be89f0f  [feat-opt](routine-load) Support show offset lag in show 
routine load stmt (#7114)
 add eaebe6a  [typo] correct getLogger argument (#7127)

No new revisions were added by this update.

Summary of changes:
 fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java   | 2 +-
 .../src/main/java/org/apache/doris/rewrite/RewriteEncryptKeyRule.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7128: [Dependency] Add breakpad for minidump

2021-11-17 Thread GitBox


morningman merged pull request #7128:
URL: https://github.com/apache/incubator-doris/pull/7128


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (eaebe6a -> 00e653e)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from eaebe6a  [typo] correct getLogger argument (#7127)
 add 00e653e  [deps] add breakpad for minidump (#7128)

No new revisions were added by this update.

Summary of changes:
 thirdparty/CHANGELOG.md|  6 ++
 thirdparty/build-thirdparty.sh | 12 ++--
 thirdparty/vars.sh | 11 ++-
 3 files changed, 26 insertions(+), 3 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (00e653e -> b842b28)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from 00e653e  [deps] add breakpad for minidump (#7128)
 add b842b28  [typo] fix typo in CONTRIBUTING.md and CONTRIBUTING_CN.md 
(#7136)

No new revisions were added by this update.

Summary of changes:
 CONTRIBUTING.md| 2 +-
 CONTRIBUTING_CN.md | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7136: [Doc] Fix typo in CONTRIBUTING.md and CONTRIBUTING_CN.md

2021-11-17 Thread GitBox


morningman merged pull request #7136:
URL: https://github.com/apache/incubator-doris/pull/7136


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated: [refactor] remove unused code (#7137)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
 new 4f7d7a5  [refactor] remove unused code (#7137)
4f7d7a5 is described below

commit 4f7d7a52bdd24073da66e51316f7d96dd8fb1442
Author: jiafeng.zhang 
AuthorDate: Thu Nov 18 14:37:31 2021 +0800

[refactor] remove unused code (#7137)

Remove unused code in ImportAction.java
---
 .../java/org/apache/doris/httpv2/restv2/ImportAction.java | 15 ---
 1 file changed, 15 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/httpv2/restv2/ImportAction.java 
b/fe/fe-core/src/main/java/org/apache/doris/httpv2/restv2/ImportAction.java
index 267ae98..98748cb 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/httpv2/restv2/ImportAction.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/httpv2/restv2/ImportAction.java
@@ -210,19 +210,4 @@ public class ImportAction {
 private List colNames;
 private List> sampleFileLines;
 }
-
-
-public static void main(String[] args) {
-ImportAction importAction = new ImportAction();
-String str = "1,2,3\n4,5,6\n,7,8,9,中国";
-byte[] fileContentBytes = str.getBytes();
-System.out.println(fileContentBytes.length);
-String newStr = new String(fileContentBytes, 0,fileContentBytes.length 
- 2);
-System.out.println(newStr);
-
-FileSample fileSample = new FileSample();
-importAction.parseContent(",", "\n", newStr.getBytes(), fileSample);
-System.out.println(fileSample.sampleFileLines);
-}
-
 }

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7137: remove Invalid code

2021-11-17 Thread GitBox


morningman merged pull request #7137:
URL: https://github.com/apache/incubator-doris/pull/7137


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (4f7d7a5 -> 94fa6db)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from 4f7d7a5  [refactor] remove unused code (#7137)
 add 94fa6db  [feat-opt](binlog-load) add how to open binlog load to the 
error message (#7138)

No new revisions were added by this update.

Summary of changes:
 .../src/main/java/org/apache/doris/analysis/CreateDataSyncJobStmt.java | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7138: [Binlog]Add how to open binlog load to the error message

2021-11-17 Thread GitBox


morningman merged pull request #7138:
URL: https://github.com/apache/incubator-doris/pull/7138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman closed issue #7139: [Bug] Root user has been dropped

2021-11-17 Thread GitBox


morningman closed issue #7139:
URL: https://github.com/apache/incubator-doris/issues/7139


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman merged pull request #7140: [Bug] Do not allow drop or create root user

2021-11-17 Thread GitBox


morningman merged pull request #7140:
URL: https://github.com/apache/incubator-doris/pull/7140


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[incubator-doris] branch master updated (94fa6db -> 1238f8d)

2021-11-17 Thread morningman
This is an automated email from the ASF dual-hosted git repository.

morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.


from 94fa6db  [feat-opt](binlog-load) add how to open binlog load to the 
error message (#7138)
 add 1238f8d  [fix](auth) do not allow drop or create root user (#7140)

No new revisions were added by this update.

Summary of changes:
 .../org/apache/doris/analysis/CreateUserStmt.java  |  9 +-
 .../org/apache/doris/analysis/DropUserStmt.java|  4 +
 .../org/apache/doris/analysis/UserIdentity.java|  4 +
 .../org/apache/doris/mysql/privilege/AuthTest.java | 96 +-
 4 files changed, 73 insertions(+), 40 deletions(-)

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] github-actions[bot] commented on pull request #7143: [Export] Fix Export task automatic retry always fail

2021-11-17 Thread GitBox


github-actions[bot] commented on pull request #7143:
URL: https://github.com/apache/incubator-doris/pull/7143#issuecomment-972582137






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] morningman commented on pull request #7135: [Blog]Doris monitoring metrics description

2021-11-17 Thread GitBox


morningman commented on pull request #7135:
URL: https://github.com/apache/incubator-doris/pull/7135#issuecomment-972589094


   There will be more and more pictures saving in code repo, which is not 
suitable for a code repository.
   I am thinking about moving `docs/` to 
`https://github.com/apache/incubator-doris-website`.
   
   But I am very sure about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] hf200012 commented on pull request #7135: [Blog]Doris monitoring metrics description

2021-11-17 Thread GitBox


hf200012 commented on pull request #7135:
URL: https://github.com/apache/incubator-doris/pull/7135#issuecomment-972590966


   > There will be more and more pictures saving in code repo, which is not 
suitable for a code repository. I am thinking about moving `docs/` to 
`https://github.com/apache/incubator-doris-website`.
   > 
   > But I am very sure about it.
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] hf200012 closed pull request #7135: [Blog]Doris monitoring metrics description

2021-11-17 Thread GitBox


hf200012 closed pull request #7135:
URL: https://github.com/apache/incubator-doris/pull/7135


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7032: [Heartbeat] Support cancel outdated query after FE restart

2021-11-17 Thread GitBox


xinyiZzz commented on a change in pull request #7032:
URL: https://github.com/apache/incubator-doris/pull/7032#discussion_r751956364



##
File path: be/src/agent/heartbeat_server.h
##
@@ -34,9 +35,22 @@ class StorageEngine;
 class Status;
 class ThriftServer;
 
+struct FrontendStartInfo {
+int64_t start_time;
+bool is_alive;
+DateTimeValue* last_heartbeat; // Invalid time of Info

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org