(cloudstack) branch main updated: resolve merge problems in the backup framework (#10457)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 48f890a6931 resolve merge problems in the backup framework (#10457)
48f890a6931 is described below
commit 48f890a6931d912542577564a6c9bab591c68940
Author: dahn
AuthorDate: Wed Feb 26 14:12:40 2025 +0100
resolve merge problems in the backup framework (#10457)
Co-authored-by: Wei Zhou
---
.../apache/cloudstack/backup/BackupProvider.java | 37 +++
.../cloudstack/backup/DummyBackupProvider.java | 6 +--
.../cloudstack/backup/NASBackupProvider.java | 25 --
.../cloudstack/backup/NetworkerBackupProvider.java | 45 +-
.../cloudstack/backup/VeeamBackupProvider.java | 55 +-
5 files changed, 54 insertions(+), 114 deletions(-)
diff --git a/api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java
b/api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java
index e3a6c3a62bd..39582b0e423 100644
--- a/api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java
+++ b/api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java
@@ -49,22 +49,21 @@ public interface BackupProvider {
/**
* Assign a VM to a backup offering or policy
- * @param vm
- * @param backup
- * @param policy
- * @return
+ * @param vm the machine to back up
+ * @param backupOffering the SLA definition for the backup
+ * @return succeeded?
*/
boolean assignVMToBackupOffering(VirtualMachine vm, BackupOffering
backupOffering);
/**
* Removes a VM from a backup offering or policy
- * @param vm
- * @return
+ * @param vm the machine to stop backing up
+ * @return succeeded?
*/
boolean removeVMFromBackupOffering(VirtualMachine vm);
/**
- * Whether the provide will delete backups on removal of VM from the
offfering
+ * Whether the provider will delete backups on removal of VM from the
offering
* @return boolean result
*/
boolean willDeleteBackupsOnOfferingRemoval();
@@ -72,16 +71,16 @@ public interface BackupProvider {
/**
* Starts and creates an adhoc backup process
* for a previously registered VM backup
- * @param backup
- * @return
+ * @param vm the machine to make a backup of
+ * @return the result and {code}Backup{code} {code}Object{code}
*/
Pair takeBackup(VirtualMachine vm);
/**
* Delete an existing backup
- * @param backuo The backup to exclude
+ * @param backup The backup to exclude
* @param forced Indicates if backup will be force removed or not
- * @return
+ * @return succeeded?
*/
boolean deleteBackup(Backup backup, boolean forced);
@@ -97,23 +96,23 @@ public interface BackupProvider {
/**
* Returns backup metrics for a list of VMs in a zone
- * @param zoneId
- * @param vms
- * @return
+ * @param zoneId the zone for which to return metrics
+ * @param vms a list of machines to get measurements for
+ * @return a map of machine -> backup metrics
*/
Map getBackupMetrics(Long zoneId,
List vms);
/**
* This method should TODO
- * @param
+ * @param vm the machine to get restore point for
*/
-public List listRestorePoints(VirtualMachine vm);
+List listRestorePoints(VirtualMachine vm);
/**
* This method should TODO
- * @param
- * @param
- * @param metric
+ * @param restorePoint the restore point to create a backup for
+ * @param vm The machine for which to create a backup
+ * @param metric the metric object to update with the new backup data
*/
Backup createNewBackupEntryForRestorePoint(Backup.RestorePoint
restorePoint, VirtualMachine vm, Backup.Metric metric);
}
diff --git
a/plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvider.java
b/plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvider.java
index 6935d177c72..2d43f9e8d3c 100644
---
a/plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvider.java
+++
b/plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvider.java
@@ -112,7 +112,7 @@ public class DummyBackupProvider extends AdapterBase
implements BackupProvider {
@Override
public boolean removeVMFromBackupOffering(VirtualMachine vm) {
-logger.debug(String.format("Removing VM %s from backup offering by the
Dummy Backup Provider", vm));
+logger.debug("Removing VM {} from backup offering by the Dummy Backup
Provider", vm);
return true;
}
@@ -123,7 +123,7 @@ public class DummyBackupProvider extends AdapterBase
implements BackupProvider {
@Override
public Pair takeBackup(Virt
[PR] add xcpng 8.3 support data [cloudstack]
DaanHoogland opened a new pull request, #10470:
URL: https://github.com/apache/cloudstack/pull/10470
### Description
This PR add data for xcpng 8.3 support, as discussed in #8964
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
DaanHoogland commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2685131235 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: fix volume migration across cluster-scope pools [cloudstack]
Pearl1594 commented on PR #10266: URL: https://github.com/apache/cloudstack/pull/10266#issuecomment-2685118277 @weizhouapache Could you please check if the test failures are in any way related to this PR. I thought they weren't, but would like your confirmation. ``` 2025-02-25 23:01:26,106 - CRITICAL - EXCEPTION: test_01_secure_vm_migration: ... Execute cmd: deployvirtualmachine failed, due to: errorCode: 431, errorText:Unable to deploy the VM as the host: ol8.localdomain is not in the right state\n' 2025-02-25 23:01:26,111 - CRITICAL - EXCEPTION: test_01_secure_vm_migration: ... errorcode : 530, errortext : 'Failed to generate keystore and get CSR from the host/agent id=1' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: support skipGroupAction [cloudstack]
github-actions[bot] commented on PR #10250: URL: https://github.com/apache/cloudstack/pull/10250#issuecomment-2684948325 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
DaanHoogland commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2685134266 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
blueorangutan commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2685139689 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: fix volume migration across cluster-scope pools [cloudstack]
weizhouapache commented on PR #10266: URL: https://github.com/apache/cloudstack/pull/10266#issuecomment-2685143896 > test_01_secure_vm_migration @Pearl1594 I have seen same failures with other PRs, let's rekick the tests @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
blueorangutan commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685475384 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
blueorangutan commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2685475390 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow modification of user vm details if user.vm.readonly.details is empty [cloudstack]
blueorangutan commented on PR #10456: URL: https://github.com/apache/cloudstack/pull/10456#issuecomment-2685475386 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
blueorangutan commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2685663688 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
blueorangutan commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2685663686 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: List host OOBM details when enabled and configured [cloudstack]
sonarqubecloud[bot] commented on PR #10472: URL: https://github.com/apache/cloudstack/pull/10472#issuecomment-2685722167 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10472) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10472&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10472&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10472&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10472&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10472&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10472) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: UI: List host OOBM details when enabled and configured
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch ui-fix-host-enable-oob
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 79f7881c29e03f3f37e324d39c573e5f5e72c836
Author: Pearl Dsilva
AuthorDate: Wed Feb 26 11:24:18 2025 -0500
UI: List host OOBM details when enabled and configured
---
ui/public/locales/en.json | 4
ui/src/views/infra/HostInfo.vue | 38 --
2 files changed, 36 insertions(+), 6 deletions(-)
diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index 666d2a31e39..174b81639da 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -2419,6 +2419,10 @@
"label.zonewizard.traffictype.storage": "Storage: Traffic between primary and
secondary storage servers, such as Instance Templates and Snapshots.",
"label.buckets": "Buckets",
"label.objectstorageid": "Object Storage Pool",
+"label.oobm.address": "Out-of-band management address",
+"label.oobm.driver": "Out-of-band management driver",
+"label.oobm.port": "Out-of-band management port",
+"label.oobm.powerstate": "Out-of-band management Power state",
"label.bucket.update": "Update Bucket",
"label.bucket.delete": "Delete Bucket",
"label.quotagb": "Quota in GB",
diff --git a/ui/src/views/infra/HostInfo.vue b/ui/src/views/infra/HostInfo.vue
index 4b1f55b22b7..17d2b0b25d9 100644
--- a/ui/src/views/infra/HostInfo.vue
+++ b/ui/src/views/infra/HostInfo.vue
@@ -80,14 +80,40 @@
-
-
- {{ $t('label.powerstate') }}
+
+
-{{ host.outofbandmanagement.powerstate }}
+{{ $t('label.oobm.powerstate') }}
+
+ {{ host.outofbandmanagement.powerstate }}
+
-
-
+
+
+
+{{ $t('label.oobm.driver') }}
+
+ {{ host.outofbandmanagement.driver }}
+
+
+
+
+
+{{ $t('label.oobm.address') }}
+
+ {{ host.outofbandmanagement.address }}
+
+
+
+
+
+{{ $t('label.oobm.port') }}
+
+ {{ host.outofbandmanagement.port }}
+
+
+
+
{{ $t('label.haenable') }}
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
winterhazel commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685778777 > @winterhazel I marked this for 4.21 as it is based off main, but would this be a good improvement for 4.20.1 as well? Yeah, it would be great to have it in 4.20.1. I'll rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]
winterhazel commented on PR #10364: URL: https://github.com/apache/cloudstack/pull/10364#issuecomment-2685799964 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
blueorangutan commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685800086 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove isMirrored parameter when creating a disk offering through UI [cloudstack]
julien-vaz opened a new pull request, #10474:
URL: https://github.com/apache/cloudstack/pull/10474
### Description
When a Disk Offering is created through UI, CloudStack passes the
`isMirrored` value as a parameter. However, the `createDiskOffering` API does
not have this parameter.
Therefore, the UI was changed in order to not send the `isMirrored`
parameter to the `createDiskOffering` API.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
After the changes, a Disk Offering was created through UI and the
`isMirrored` parameter was no longer being send in the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Fix volume allocation logs [cloudstack]
julien-vaz opened a new pull request, #10475:
URL: https://github.com/apache/cloudstack/pull/10475
### Description
The logs in storage allocation algorithms were displaying incorrect
information about the allocation pool. Therefore, the logs were rewritten.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
When trying to migrate a volume, the expected log messages were displayed
correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]
blueorangutan commented on PR #10364: URL: https://github.com/apache/cloudstack/pull/10364#issuecomment-2685993081 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
blueorangutan commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685993138 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [VMware] Disk controller mappings [cloudstack]
blueorangutan commented on PR #10454: URL: https://github.com/apache/cloudstack/pull/10454#issuecomment-2685993154 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2685475388 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
blueorangutan commented on PR #10466: URL: https://github.com/apache/cloudstack/pull/10466#issuecomment-2685171110 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow modification of user vm details if user.vm.readonly.details is empty [cloudstack]
weizhouapache commented on PR #10456: URL: https://github.com/apache/cloudstack/pull/10456#issuecomment-2685158853 @Pearl1594 would be good to add a parameter to ConfigKey to indicate whether `use default value if empty` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
DaanHoogland commented on PR #10466: URL: https://github.com/apache/cloudstack/pull/10466#issuecomment-2685166251 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
winterhazel commented on code in PR #10363:
URL: https://github.com/apache/cloudstack/pull/10363#discussion_r1971697221
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##
@@ -605,6 +597,118 @@ public void handleTemplateSync(DataStore store) {
}
+protected void tryDownloadingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+if (tmplt.getUrl() == null) {
+logger.info("Not downloading template [{}] to image store [{}], as
it has no URL.", tmplt.getUniqueName(),
+destStore.getName());
+return;
+}
+logger.info("Downloading template [{}] to image store [{}].",
tmplt.getUniqueName(), destStore.getName());
+associateTemplateToZone(tmplt.getId(),
destStore.getScope().getScopeId());
+TemplateInfo tmpl = _templateFactory.getTemplate(tmplt.getId(),
destStore);
+TemplateOpContext context = new
TemplateOpContext<>(null,(TemplateObject)tmpl, null);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createTemplateAsyncCallBack(null, null));
+caller.setContext(context);
+createTemplateAsync(tmpl, destStore, caller);
+}
+
+protected boolean tryCopyingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+Long zoneId = destStore.getScope().getScopeId();
+List storesInZone =
_storeMgr.getImageStoresByZoneIds(zoneId);
+for (DataStore sourceStore : storesInZone) {
+Map existingTemplatesInSourceStore =
listTemplate(sourceStore);
+if (existingTemplatesInSourceStore == null ||
!existingTemplatesInSourceStore.containsKey(tmplt.getUniqueName())) {
+logger.debug("Template [{}] does not exist on image store
[{}]; searching on another one.",
+tmplt.getUniqueName(), sourceStore.getName());
+continue;
+}
+TemplateObject sourceTmpl = (TemplateObject)
_templateFactory.getTemplate(tmplt.getId(), sourceStore);
+if (sourceTmpl.getInstallPath() == null) {
+logger.warn("Can not copy template [{}] from image store [{}],
as it returned a null install path.", tmplt.getUniqueName(),
+sourceStore.getName());
+continue;
+}
+
storageOrchestrator.orchestrateTemplateCopyToImageStore(sourceTmpl, destStore);
+return true;
+}
+logger.debug("Can't copy template [{}] from another image store.",
tmplt.getUniqueName());
+return false;
+}
+
+@Override
+public AsyncCallFuture
copyTemplateToImageStore(DataObject source, DataStore destStore) {
+TemplateObject sourceTmpl = (TemplateObject) source;
+logger.debug("Copying template [{}] from image store [{}] to [{}].",
sourceTmpl.getUniqueName(), sourceTmpl.getDataStore().getName(),
+destStore.getName());
+TemplateObject destTmpl = (TemplateObject)
destStore.create(sourceTmpl);
+destTmpl.processEvent(Event.CreateOnlyRequested);
+
+AsyncCallFuture future = new AsyncCallFuture<>();
+TemplateOpContext context = new
TemplateOpContext<>(null, destTmpl, future);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().copyTemplateToImageStoreCallback(null,
null)).setContext(context);
+_motionSrv.copyAsync(sourceTmpl, destTmpl, caller);
+return future;
+}
+
+protected Void
copyTemplateToImageStoreCallback(AsyncCallbackDispatcher callback, TemplateOpContext context) {
+TemplateInfo tmplt = context.getTemplate();
+CopyCommandResult result = callback.getResult();
+AsyncCallFuture future = context.getFuture();
+TemplateApiResult res = new TemplateApiResult(tmplt);
+if (result.isSuccess()) {
+logger.info("Copied template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+tmplt.processEvent(Event.OperationSuccessed, result.getAnswer());
+publishTemplateCreation(tmplt);
+} else {
+logger.warn("Failed to copy template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+res.setResult(result.getResult());
+tmplt.processEvent(Event.OperationFailed);
+}
+future.complete(res);
+return null;
+}
+
+protected boolean isCopyFromOtherStoragesEnabled(Long zoneId) {
+return
StorageManager.COPY_PUBLIC_TEMPLATES_FROM_OTHER_STORAGES.valueIn(zoneId);
+}
+
+protected void publishTemplateCreation(TemplateInfo tmplt) {
+VMTemplateVO tmpltVo = _templateDao.findById(tmplt.getId());
+
+if (tmpltVo.isPublicTemplate()) {
+_messageBus.publish(null,
TemplateM
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2685321412 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] DB connection is interrupted with multiple management servers [cloudstack]
DaanHoogland closed issue #10469: DB connection is interrupted with multiple management servers URL: https://github.com/apache/cloudstack/issues/10469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
weizhouapache commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2685364447 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2685369492 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2685366521 > [SF] Trillian test result (tid-12420) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 63806 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8756-t12420-vmware-70u3.zip Smoke tests completed. 130 look OK, 11 have errors, 0 did not run Only failed and skipped tests results shown below: > > Test Result Time (s)Test File > test_01_events_resource`Error` 341.36 test_events_resource.py > test_04_deploy_vm_with_extraconfig_throws_exception_vmware `Error` 4.49 test_deploy_vm_extra_config_data.py > test_deploy_more_vms_than_limit_allows `Error` 165.21 test_deploy_vms_in_parallel.py > test_04_list_domains_level_filter `Failure` 0.05 test_list_domains.py > test_05_list_domains_no_filter `Failure` 0.03 test_list_domains.py > test_01_prepare_and_cancel_maintenance `Error` 0.08 test_ms_maintenance_and_safe_shutdown.py > test_04_deploy_vm_for_other_user_and_test_vm_operations`Error` 123.59 test_network_permissions.py > test_01_deployVMInSharedNetwork`Error` 156.38 test_network.py > test_06_purge_expunged_vm_background_task `Failure` 393.74 test_purge_expunged_vms.py > test_02_restore_vm_with_disk_offering `Error` 66.18 test_restore_vm.py > test_03_restore_vm_with_disk_offering_custom_size `Error` 58.00 test_restore_vm.py > test_14_destroy_vm_delete_protection `Error` 10.64 test_vm_life_cycle.py > test_02_restore_vm_strict_tags_failure `Error` 63.72 test_vm_strict_host_tags.py these failures are almost same as 4.21 health check https://github.com/apache/cloudstack/pull/10149#issuecomment-2664798716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
weizhouapache commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2685382121 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
blueorangutan commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2685387814 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
DaanHoogland commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2684989331 @winterhazel I marked this for 4.21 as it is based off main, but would this be a good improvement for 4.20.1 as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow modification of user vm details if user.vm.readonly.details is empty [cloudstack]
blueorangutan commented on PR #10456: URL: https://github.com/apache/cloudstack/pull/10456#issuecomment-2684987173 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow modification of user vm details if user.vm.readonly.details is empty [cloudstack]
Pearl1594 commented on PR #10456: URL: https://github.com/apache/cloudstack/pull/10456#issuecomment-2684986047 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch backup-framework-merge-problems deleted (was 6da5db5120a)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch backup-framework-merge-problems in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 6da5db5120a Veeam: set backed_volumes for each backup (#9898) The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository.
Re: [PR] resolve merge problems in the backup framework [cloudstack]
DaanHoogland merged PR #10457: URL: https://github.com/apache/cloudstack/pull/10457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
blueorangutan commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2684954680 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: fix volume migration across cluster-scope pools [cloudstack]
blueorangutan commented on PR #10266: URL: https://github.com/apache/cloudstack/pull/10266#issuecomment-2685149985 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add xcpng 8.3 support data [cloudstack]
codecov[bot] commented on PR #10470: URL: https://github.com/apache/cloudstack/pull/10470#issuecomment-2685135182 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10470?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`37c4df9`)](https://app.codecov.io/gh/apache/cloudstack/commit/37c4df9ada1d81f76dc89f7d60b67c652b71aa10?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b91511d`)](https://app.codecov.io/gh/apache/cloudstack/commit/b91511d72771ded46777069594980cf8213137bd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (37c4df9) and HEAD (b91511d). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (37c4df9) | HEAD (b91511d) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #10470 +/- ## = - Coverage 15.99%4.01% -11.99% = Files 5649 395 -5254 Lines49571432433 -463281 Branches 60017 5750-54267 = - Hits 79289 1301-77988 + Misses 40757230983 -376589 + Partials 8853 149 -8704 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10470/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10470/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10470?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
DaanHoogland commented on code in PR #10376:
URL: https://github.com/apache/cloudstack/pull/10376#discussion_r1971827902
##
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapperTest.java:
##
@@ -0,0 +1,301 @@
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.ArgumentMatchers.anyList;
+import static org.mockito.Mockito.mockStatic;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.MockedStatic;
+import org.mockito.MockitoAnnotations;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.GetVmIpAddressCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.utils.Pair;
+import com.cloud.utils.script.Script;
+
+public class LibvirtGetVmIpAddressCommandWrapperTest {
+
+private static String VIRSH_DOMIF_OUTPUT = " Name MAC address
Protocol Address\n" + //
+
"---\n"
+ //
+" lo 00:00:00:00:00:70ipv4 127.0.0.1/8\n" + //
+" eth0 02:0c:02:f9:00:80ipv4 192.168.0.10/24\n"
+ //
+" net1 b2:41:19:69:a4:90N/A N/A\n" + //
+" net2 52:a2:36:cf:d1:50ipv4 10.244.6.93/32\n" + //
+" net3 a6:1d:d3:52:d3:40N/A N/A\n" + //
+" net4 2e:9b:60:dc:49:30N/A N/A\n" + //
+" lxc5b7327203b6f 92:b2:77:0b:a9:20N/A N/A\n";
+
+@Before
+public void setUp() {
+MockitoAnnotations.openMocks(this);
+}
+
+@Test
+public void testExecuteWithValidVmName() {
+LibvirtComputingResource libvirtComputingResource =
mock(LibvirtComputingResource.class);
+GetVmIpAddressCommand getVmIpAddressCommand =
mock(GetVmIpAddressCommand.class);
+LibvirtGetVmIpAddressCommandWrapper commandWrapper = new
LibvirtGetVmIpAddressCommandWrapper();
+MockedStatic
Re: [PR] pom.xml: Upgrade gson version to 2.10.1 [cloudstack]
weizhouapache commented on PR #8756: URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2685365243 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
JoaoJandre commented on code in PR #10363:
URL: https://github.com/apache/cloudstack/pull/10363#discussion_r1971838533
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##
@@ -605,6 +597,118 @@ public void handleTemplateSync(DataStore store) {
}
+protected void tryDownloadingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+if (tmplt.getUrl() == null) {
+logger.info("Not downloading template [{}] to image store [{}], as
it has no URL.", tmplt.getUniqueName(),
+destStore.getName());
+return;
+}
+logger.info("Downloading template [{}] to image store [{}].",
tmplt.getUniqueName(), destStore.getName());
+associateTemplateToZone(tmplt.getId(),
destStore.getScope().getScopeId());
+TemplateInfo tmpl = _templateFactory.getTemplate(tmplt.getId(),
destStore);
+TemplateOpContext context = new
TemplateOpContext<>(null,(TemplateObject)tmpl, null);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createTemplateAsyncCallBack(null, null));
+caller.setContext(context);
+createTemplateAsync(tmpl, destStore, caller);
+}
+
+protected boolean tryCopyingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+Long zoneId = destStore.getScope().getScopeId();
+List storesInZone =
_storeMgr.getImageStoresByZoneIds(zoneId);
+for (DataStore sourceStore : storesInZone) {
+Map existingTemplatesInSourceStore =
listTemplate(sourceStore);
+if (existingTemplatesInSourceStore == null ||
!existingTemplatesInSourceStore.containsKey(tmplt.getUniqueName())) {
+logger.debug("Template [{}] does not exist on image store
[{}]; searching on another one.",
+tmplt.getUniqueName(), sourceStore.getName());
+continue;
+}
+TemplateObject sourceTmpl = (TemplateObject)
_templateFactory.getTemplate(tmplt.getId(), sourceStore);
+if (sourceTmpl.getInstallPath() == null) {
+logger.warn("Can not copy template [{}] from image store [{}],
as it returned a null install path.", tmplt.getUniqueName(),
+sourceStore.getName());
+continue;
+}
+
storageOrchestrator.orchestrateTemplateCopyToImageStore(sourceTmpl, destStore);
+return true;
+}
+logger.debug("Can't copy template [{}] from another image store.",
tmplt.getUniqueName());
+return false;
+}
+
+@Override
+public AsyncCallFuture
copyTemplateToImageStore(DataObject source, DataStore destStore) {
+TemplateObject sourceTmpl = (TemplateObject) source;
+logger.debug("Copying template [{}] from image store [{}] to [{}].",
sourceTmpl.getUniqueName(), sourceTmpl.getDataStore().getName(),
+destStore.getName());
+TemplateObject destTmpl = (TemplateObject)
destStore.create(sourceTmpl);
+destTmpl.processEvent(Event.CreateOnlyRequested);
+
+AsyncCallFuture future = new AsyncCallFuture<>();
+TemplateOpContext context = new
TemplateOpContext<>(null, destTmpl, future);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().copyTemplateToImageStoreCallback(null,
null)).setContext(context);
+_motionSrv.copyAsync(sourceTmpl, destTmpl, caller);
+return future;
+}
+
+protected Void
copyTemplateToImageStoreCallback(AsyncCallbackDispatcher callback, TemplateOpContext context) {
+TemplateInfo tmplt = context.getTemplate();
+CopyCommandResult result = callback.getResult();
+AsyncCallFuture future = context.getFuture();
+TemplateApiResult res = new TemplateApiResult(tmplt);
+if (result.isSuccess()) {
+logger.info("Copied template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+tmplt.processEvent(Event.OperationSuccessed, result.getAnswer());
+publishTemplateCreation(tmplt);
+} else {
+logger.warn("Failed to copy template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+res.setResult(result.getResult());
+tmplt.processEvent(Event.OperationFailed);
+}
+future.complete(res);
+return null;
+}
+
+protected boolean isCopyFromOtherStoragesEnabled(Long zoneId) {
+return
StorageManager.COPY_PUBLIC_TEMPLATES_FROM_OTHER_STORAGES.valueIn(zoneId);
+}
+
+protected void publishTemplateCreation(TemplateInfo tmplt) {
+VMTemplateVO tmpltVo = _templateDao.findById(tmplt.getId());
+
+if (tmpltVo.isPublicTemplate()) {
+_messageBus.publish(null,
TemplateMa
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
JoaoJandre commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685443620 @winterhazel could you fix the compilation errors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS Enhancements [cloudstack]
nvazquez commented on PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#issuecomment-2684953180 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack-documentation) branch 4.19.2-release updated (243ef38 -> dd02ce7)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19.2-release in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git from 243ef38 4.19.2 changes add dd02ce7 merge in data from announce blog No new revisions were added by this update. Summary of changes: source/releasenotes/about.rst | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-)
[I] DB connection is interrupted with multiple management servers [cloudstack]
Luskan777 opened a new issue, #10469: URL: https://github.com/apache/cloudstack/issues/10469 ### problem Hello, I am using an environment with 2 management servers, using MariaDB Galera as the database server. A few minutes after starting the management server service, the connection to the database is dropped, and the management server logs show the following record: `ERROR [c.c.u.d.T.Transaction] (AsyncJobMgr-Heartbeat-1:[ctx-c66c8126]) (logid:cfb46db0) Unexpected exception: java.sql.SQLTransientConnectionException: cloud - Connection is not available, request timed out after 30001ms (total=250, active=250, idle=0, waiting=24)` My current MariaDB server configuration is as follows: ``` [mysqld] binlog_format=ROW default_storage_engine=InnoDB innodb_autoinc_lock_mode=2 query_cache_size=0 query_cache_type=0 bind-address=0.0.0.0 innodb_rollback_on_timeout=1 innodb_lock_wait_timeout=600 max_connections=1000 log-bin=mysql-bin max_allowed_packet=1024M net_read_timeout=120 net_write_timeout=120 ``` And the configuration of access to the management servers database (db.properties) are these: ``` # CloudStack database tuning parameters db.cloud.connectionPoolLib=hikaricp db.cloud.maxActive=1000 db.cloud.maxIdle=100 db.cloud.maxWait=90 db.cloud.minIdleConnections=20 db.cloud.connectionTimeout=8 db.cloud.keepAliveTime=80 db.cloud.validationQuery=/* ping */ SELECT 1 db.cloud.testOnBorrow=true db.cloud.testWhileIdle=true db.cloud.timeBetweenEvictionRunsMillis=4 db.cloud.minEvictableIdleTimeMillis=24 db.cloud.poolPreparedStatements=false db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_T ABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC ``` PS: I changed some parameters of both the database server (max_connections, max_allowed_packet and timeout parameters) and the connection pools in the db.properties file (db.cloud.maxActive, db.cloud.connectionTimeout, db.cloud.minIdleConnections), but none of them seem to have solved it, it just takes a little longer to interrupt. When I check the database server logs I can only get the following error records: ``` Feb 26 10:19:14 acs-stg-mngt-01 mariadbd[20527]: 2025-02-26 10:19:14 3320 [Warning] Aborted connection 3320 to db: 'cloud_usage' user: 'cloud' host: 'IP_MNGT_SERVER' (Got an error reading communication packets) Feb 26 10:18:34 acs-stg-mngt-01 mariadbd[20527]: 2025-02-26 10:18:34 2282 [Warning] Aborted connection 2282 to db: 'cloud' user: 'cloud' host: 'IP_MNGT_SERVER' (Got an error reading communication packets) ``` PS: I noticed that this started happening after installing cloudstack-usage, this same problem already occurred in a Standalone installation (without HA) of Cloudstack and it occurred precisely after installing cloudstack-usage, but I'm still debugging to find out if it is really related to the current problem. ### versions Cloudstack: 4.20 MariaDB: 10.6 ### The steps to reproduce the bug 1. Configure Cloudstack in HA mode (MariaDB, HA Proxy) 2. Add 3 KVM hosts 3. Enable HA hosts ### What to do about it? _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] kvm: fix volume migration across cluster-scope pools [cloudstack]
JoaoJandre commented on PR #10266: URL: https://github.com/apache/cloudstack/pull/10266#issuecomment-2685222564 > > @weizhouapache could you explain a bit about how your patch fixes the problem and which tests did you do to verify it? > > @JoaoJandre The steps to reproduce the issue is described in #10078 > > when migrate volume from a cluster-wide storage to another cluster-wide storage in another cluster, we should treat it as similar as migration between local storages, because the source host is not able to mount the destination pool, although it is shared(e.g. nfs). > > I have verified the volume migrations between nfs/nfs,nfs/lcoal,local/local storage across clusters. I see, thank you for the explanations :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
winterhazel commented on code in PR #10363:
URL: https://github.com/apache/cloudstack/pull/10363#discussion_r1971697221
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##
@@ -605,6 +597,118 @@ public void handleTemplateSync(DataStore store) {
}
+protected void tryDownloadingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+if (tmplt.getUrl() == null) {
+logger.info("Not downloading template [{}] to image store [{}], as
it has no URL.", tmplt.getUniqueName(),
+destStore.getName());
+return;
+}
+logger.info("Downloading template [{}] to image store [{}].",
tmplt.getUniqueName(), destStore.getName());
+associateTemplateToZone(tmplt.getId(),
destStore.getScope().getScopeId());
+TemplateInfo tmpl = _templateFactory.getTemplate(tmplt.getId(),
destStore);
+TemplateOpContext context = new
TemplateOpContext<>(null,(TemplateObject)tmpl, null);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createTemplateAsyncCallBack(null, null));
+caller.setContext(context);
+createTemplateAsync(tmpl, destStore, caller);
+}
+
+protected boolean tryCopyingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+Long zoneId = destStore.getScope().getScopeId();
+List storesInZone =
_storeMgr.getImageStoresByZoneIds(zoneId);
+for (DataStore sourceStore : storesInZone) {
+Map existingTemplatesInSourceStore =
listTemplate(sourceStore);
+if (existingTemplatesInSourceStore == null ||
!existingTemplatesInSourceStore.containsKey(tmplt.getUniqueName())) {
+logger.debug("Template [{}] does not exist on image store
[{}]; searching on another one.",
+tmplt.getUniqueName(), sourceStore.getName());
+continue;
+}
+TemplateObject sourceTmpl = (TemplateObject)
_templateFactory.getTemplate(tmplt.getId(), sourceStore);
+if (sourceTmpl.getInstallPath() == null) {
+logger.warn("Can not copy template [{}] from image store [{}],
as it returned a null install path.", tmplt.getUniqueName(),
+sourceStore.getName());
+continue;
+}
+
storageOrchestrator.orchestrateTemplateCopyToImageStore(sourceTmpl, destStore);
+return true;
+}
+logger.debug("Can't copy template [{}] from another image store.",
tmplt.getUniqueName());
+return false;
+}
+
+@Override
+public AsyncCallFuture
copyTemplateToImageStore(DataObject source, DataStore destStore) {
+TemplateObject sourceTmpl = (TemplateObject) source;
+logger.debug("Copying template [{}] from image store [{}] to [{}].",
sourceTmpl.getUniqueName(), sourceTmpl.getDataStore().getName(),
+destStore.getName());
+TemplateObject destTmpl = (TemplateObject)
destStore.create(sourceTmpl);
+destTmpl.processEvent(Event.CreateOnlyRequested);
+
+AsyncCallFuture future = new AsyncCallFuture<>();
+TemplateOpContext context = new
TemplateOpContext<>(null, destTmpl, future);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().copyTemplateToImageStoreCallback(null,
null)).setContext(context);
+_motionSrv.copyAsync(sourceTmpl, destTmpl, caller);
+return future;
+}
+
+protected Void
copyTemplateToImageStoreCallback(AsyncCallbackDispatcher callback, TemplateOpContext context) {
+TemplateInfo tmplt = context.getTemplate();
+CopyCommandResult result = callback.getResult();
+AsyncCallFuture future = context.getFuture();
+TemplateApiResult res = new TemplateApiResult(tmplt);
+if (result.isSuccess()) {
+logger.info("Copied template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+tmplt.processEvent(Event.OperationSuccessed, result.getAnswer());
+publishTemplateCreation(tmplt);
+} else {
+logger.warn("Failed to copy template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+res.setResult(result.getResult());
+tmplt.processEvent(Event.OperationFailed);
+}
+future.complete(res);
+return null;
+}
+
+protected boolean isCopyFromOtherStoragesEnabled(Long zoneId) {
+return
StorageManager.COPY_PUBLIC_TEMPLATES_FROM_OTHER_STORAGES.valueIn(zoneId);
+}
+
+protected void publishTemplateCreation(TemplateInfo tmplt) {
+VMTemplateVO tmpltVo = _templateDao.findById(tmplt.getId());
+
+if (tmpltVo.isPublicTemplate()) {
+_messageBus.publish(null,
TemplateM
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
winterhazel commented on code in PR #10363:
URL: https://github.com/apache/cloudstack/pull/10363#discussion_r1971697221
##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##
@@ -605,6 +597,118 @@ public void handleTemplateSync(DataStore store) {
}
+protected void tryDownloadingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+if (tmplt.getUrl() == null) {
+logger.info("Not downloading template [{}] to image store [{}], as
it has no URL.", tmplt.getUniqueName(),
+destStore.getName());
+return;
+}
+logger.info("Downloading template [{}] to image store [{}].",
tmplt.getUniqueName(), destStore.getName());
+associateTemplateToZone(tmplt.getId(),
destStore.getScope().getScopeId());
+TemplateInfo tmpl = _templateFactory.getTemplate(tmplt.getId(),
destStore);
+TemplateOpContext context = new
TemplateOpContext<>(null,(TemplateObject)tmpl, null);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().createTemplateAsyncCallBack(null, null));
+caller.setContext(context);
+createTemplateAsync(tmpl, destStore, caller);
+}
+
+protected boolean tryCopyingTemplateToImageStore(VMTemplateVO tmplt,
DataStore destStore) {
+Long zoneId = destStore.getScope().getScopeId();
+List storesInZone =
_storeMgr.getImageStoresByZoneIds(zoneId);
+for (DataStore sourceStore : storesInZone) {
+Map existingTemplatesInSourceStore =
listTemplate(sourceStore);
+if (existingTemplatesInSourceStore == null ||
!existingTemplatesInSourceStore.containsKey(tmplt.getUniqueName())) {
+logger.debug("Template [{}] does not exist on image store
[{}]; searching on another one.",
+tmplt.getUniqueName(), sourceStore.getName());
+continue;
+}
+TemplateObject sourceTmpl = (TemplateObject)
_templateFactory.getTemplate(tmplt.getId(), sourceStore);
+if (sourceTmpl.getInstallPath() == null) {
+logger.warn("Can not copy template [{}] from image store [{}],
as it returned a null install path.", tmplt.getUniqueName(),
+sourceStore.getName());
+continue;
+}
+
storageOrchestrator.orchestrateTemplateCopyToImageStore(sourceTmpl, destStore);
+return true;
+}
+logger.debug("Can't copy template [{}] from another image store.",
tmplt.getUniqueName());
+return false;
+}
+
+@Override
+public AsyncCallFuture
copyTemplateToImageStore(DataObject source, DataStore destStore) {
+TemplateObject sourceTmpl = (TemplateObject) source;
+logger.debug("Copying template [{}] from image store [{}] to [{}].",
sourceTmpl.getUniqueName(), sourceTmpl.getDataStore().getName(),
+destStore.getName());
+TemplateObject destTmpl = (TemplateObject)
destStore.create(sourceTmpl);
+destTmpl.processEvent(Event.CreateOnlyRequested);
+
+AsyncCallFuture future = new AsyncCallFuture<>();
+TemplateOpContext context = new
TemplateOpContext<>(null, destTmpl, future);
+AsyncCallbackDispatcher caller
= AsyncCallbackDispatcher.create(this);
+
caller.setCallback(caller.getTarget().copyTemplateToImageStoreCallback(null,
null)).setContext(context);
+_motionSrv.copyAsync(sourceTmpl, destTmpl, caller);
+return future;
+}
+
+protected Void
copyTemplateToImageStoreCallback(AsyncCallbackDispatcher callback, TemplateOpContext context) {
+TemplateInfo tmplt = context.getTemplate();
+CopyCommandResult result = callback.getResult();
+AsyncCallFuture future = context.getFuture();
+TemplateApiResult res = new TemplateApiResult(tmplt);
+if (result.isSuccess()) {
+logger.info("Copied template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+tmplt.processEvent(Event.OperationSuccessed, result.getAnswer());
+publishTemplateCreation(tmplt);
+} else {
+logger.warn("Failed to copy template [{}] to image store [{}].",
tmplt.getUniqueName(), tmplt.getDataStore().getName());
+res.setResult(result.getResult());
+tmplt.processEvent(Event.OperationFailed);
+}
+future.complete(res);
+return null;
+}
+
+protected boolean isCopyFromOtherStoragesEnabled(Long zoneId) {
+return
StorageManager.COPY_PUBLIC_TEMPLATES_FROM_OTHER_STORAGES.valueIn(zoneId);
+}
+
+protected void publishTemplateCreation(TemplateInfo tmplt) {
+VMTemplateVO tmpltVo = _templateDao.findById(tmplt.getId());
+
+if (tmpltVo.isPublicTemplate()) {
+_messageBus.publish(null,
TemplateM
Re: [PR] Add API command remove management server [cloudstack]
blueorangutan commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2685226440 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Allow custom footer in password reset page [cloudstack]
blueorangutan commented on PR #10461: URL: https://github.com/apache/cloudstack/pull/10461#issuecomment-2685226446 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
nicoschmdt commented on code in PR #9504:
URL: https://github.com/apache/cloudstack/pull/9504#discussion_r1971730462
##
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42010to42100.java:
##
@@ -57,9 +60,52 @@ public InputStream[] getPrepareScripts() {
return new InputStream[] {script};
}
+protected void performKeyPairMigration(Connection conn) throws
SQLException {
Review Comment:
I modified the code to migrate the key pairs directly through SQL.
To test the migration, I created, in version 4.20 of CloudStack, one domain
admin account and added to it three users, and for the third user I generated a
key pair. When updating CloudStack to version 4.21, I verified the key pair was
correctly migrated to the new table and asserted the CloudMonkey requisitions
were functioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
blueorangutan commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2685299152 @nicoschmdt a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add API command remove management server [cloudstack]
nicoschmdt commented on PR #10325: URL: https://github.com/apache/cloudstack/pull/10325#issuecomment-2685297487 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
rg9975 commented on code in PR #10376:
URL: https://github.com/apache/cloudstack/pull/10376#discussion_r1971767387
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java:
##
@@ -47,15 +47,33 @@ public Answer execute(final GetVmIpAddressCommand command,
final LibvirtComputin
}
String sanitizedVmName = sanitizeBashCommandArgument(vmName);
String networkCidr = command.getVmNetworkCidr();
-List commands = new ArrayList<>();
final String virt_ls_path =
Script.getExecutableAbsolutePath("virt-ls");
final String virt_cat_path =
Script.getExecutableAbsolutePath("virt-cat");
final String virt_win_reg_path =
Script.getExecutableAbsolutePath("virt-win-reg");
final String tail_path = Script.getExecutableAbsolutePath("tail");
final String grep_path = Script.getExecutableAbsolutePath("grep");
final String awk_path = Script.getExecutableAbsolutePath("awk");
final String sed_path = Script.getExecutableAbsolutePath("sed");
-if(!command.isWindows()) {
+final String virsh_path = Script.getExecutableAbsolutePath("virsh");
+
+// first run virsh domiflist to get the network interface name from
libvirt. This is set if qemu guest agent is running in the VM
+// and is the most reliable and least intrusive
+List commands = new ArrayList<>();
+commands.add(new String[]{virsh_path, "domifaddr", sanitizedVmName,
"--source", "agent"});
+String output = Script.executePipedCommands(commands, 0).second();
+if (output != null) {
+String[] lines = output.split("\n");
+for (String line : lines) {
+ip = parseDomIfListOutput(line, networkCidr);
+if (ip != null) {
+break;
+}
+}
+}
Review Comment:
modularized better, fixed a few issues, and added test cases.
##
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapper.java:
##
@@ -47,15 +47,33 @@ public Answer execute(final GetVmIpAddressCommand command,
final LibvirtComputin
}
String sanitizedVmName = sanitizeBashCommandArgument(vmName);
String networkCidr = command.getVmNetworkCidr();
-List commands = new ArrayList<>();
final String virt_ls_path =
Script.getExecutableAbsolutePath("virt-ls");
final String virt_cat_path =
Script.getExecutableAbsolutePath("virt-cat");
final String virt_win_reg_path =
Script.getExecutableAbsolutePath("virt-win-reg");
final String tail_path = Script.getExecutableAbsolutePath("tail");
final String grep_path = Script.getExecutableAbsolutePath("grep");
final String awk_path = Script.getExecutableAbsolutePath("awk");
final String sed_path = Script.getExecutableAbsolutePath("sed");
-if(!command.isWindows()) {
+final String virsh_path = Script.getExecutableAbsolutePath("virsh");
+
+// first run virsh domiflist to get the network interface name from
libvirt. This is set if qemu guest agent is running in the VM
+// and is the most reliable and least intrusive
+List commands = new ArrayList<>();
+commands.add(new String[]{virsh_path, "domifaddr", sanitizedVmName,
"--source", "agent"});
+String output = Script.executePipedCommands(commands, 0).second();
+if (output != null) {
+String[] lines = output.split("\n");
+for (String line : lines) {
+ip = parseDomIfListOutput(line, networkCidr);
+if (ip != null) {
+break;
+}
+}
+}
+
+commands.clear();
+commands.add(new String[]{grep_path, ".*\\*"});
+if(ip == null && !command.isWindows()) {
Review Comment:
modularized better, fixed a few issues, and added test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] UI: List host OOBM details when enabled and configured [cloudstack]
Pearl1594 opened a new pull request, #10472:
URL: https://github.com/apache/cloudstack/pull/10472
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/10194
Adds the OOBM details when configured and is enabled.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
sonarqubecloud[bot] commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686402289 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10476) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10476&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10476&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10476&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [30.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10476&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10476&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10476) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2686340471 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
blueorangutan commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2686436939 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2686438410 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
tpodowd commented on code in PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#discussion_r1972592802 ## plugins/storage/object/cloudian/pom.xml: ## @@ -0,0 +1,70 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 +cloud-plugin-storage-object-cloudian +Apache CloudStack Plugin - Cloudian HyperStore object storage provider + +org.apache.cloudstack +cloudstack-plugins +4.20.0.0-SNAPSHOT Review Comment: This is resolved. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
Pearl1594 commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686508806 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
blueorangutan commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686511475 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
blueorangutan commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686589234 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
abh1sar commented on code in PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1828980905
##
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##
@@ -470,16 +468,30 @@ public List listBackupSchedule(final Long
vmId) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_VM_BACKUP_SCHEDULE_DELETE,
eventDescription = "deleting VM backup schedule")
-public boolean deleteBackupSchedule(final Long vmId) {
-final VMInstanceVO vm = findVmById(vmId);
-validateForZone(vm.getDataCenterId());
-accountManager.checkAccess(CallContext.current().getCallingAccount(),
null, true, vm);
+public boolean deleteBackupSchedule(DeleteBackupScheduleCmd cmd) {
+Long vmId = cmd.getVmId();
+Long id = cmd.getId();
Review Comment:
In DeleteBackupScheduleCmd, both vmId and id parameters are declared with
required = true, but here it looks like either of them could be null.
##
scripts/vm/hypervisor/kvm/nasbackup.sh:
##
@@ -99,7 +151,16 @@ delete_backup() {
mount_operation() {
mount_point=$(mktemp -d -t csbackup.X)
dest="$mount_point/${BACKUP_DIR}"
- mount -t ${NAS_TYPE} ${NAS_ADDRESS} ${mount_point} $([[ ! -z "${MOUNT_OPTS}"
]] && echo -o ${MOUNT_OPTS})
+ if [ ${NAS_TYPE} == "cifs" ]; then
+MOUNT_OPTS="${MOUNT_OPTS},nobrl"
Review Comment:
nobrl is added in mountBackupDirectory. Is it required here as well?
##
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##
@@ -373,8 +375,12 @@ public Map
getBackupMetrics(Long zoneId, List
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
abh1sar commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2686612995 > We discussed this internally. HyperStore does not currently support Bucket Quota limits. We have added an internal feature request for this which we may implement in a future HyperStore release. At such time, we will re-address and update the CloudStack HyperStore plugin bucket quota functionality. As the CloudStack UI and API currently both require a quota setting, we decided to allow the user to specify a value of 0 as the quota. The 0 quota will indicate no quota restriction for the bucket. > > I rebased this branch on top of the latest main branch. I fixed 2 issues in commit [01be768](https://github.com/apache/cloudstack/commit/01be768a6955313f6e5962b6939124a97e54481c): > > 1. The pom.xml was updated for the correct version number. > 2. Quota of 0 is now accepted and I added an extra test for the 0 case. > > I built everything cleanly and tested adding a bucket successfully using a quota of 0. I also confirmed the error case worked with any other quota value and that UI shows the user the exception message to help them choose the 0 value. > > Please let me know if you have any questions or comments. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
blueorangutan commented on PR #9561: URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2686711801 [SF] Trillian test result (tid-12495) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56479 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9561-t12495-kvm-ol8.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_purge_expunged_vm_background_task | `Failure` | 405.75 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch ui-fix-host-enable-oob created (now 79f7881c29e)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch ui-fix-host-enable-oob in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 79f7881c29e UI: List host OOBM details when enabled and configured This branch includes the following new commits: new 79f7881c29e UI: List host OOBM details when enabled and configured The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
weizhouapache commented on PR #10466: URL: https://github.com/apache/cloudstack/pull/10466#issuecomment-2685708771 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
blueorangutan commented on PR #10466: URL: https://github.com/apache/cloudstack/pull/10466#issuecomment-2685712116 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [VMware] Disk controller mappings [cloudstack]
blueorangutan commented on PR #10454: URL: https://github.com/apache/cloudstack/pull/10454#issuecomment-2685804276 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]
blueorangutan commented on PR #10364: URL: https://github.com/apache/cloudstack/pull/10364#issuecomment-2685804388 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prioritize copying templates from other secondary storages instead of downloading them [cloudstack]
winterhazel commented on PR #10363: URL: https://github.com/apache/cloudstack/pull/10363#issuecomment-2685794880 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [VMware] Disk controller mappings [cloudstack]
winterhazel commented on PR #10454: URL: https://github.com/apache/cloudstack/pull/10454#issuecomment-2685803466 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: List host OOBM details when enabled and configured [cloudstack]
codecov[bot] commented on PR #10472: URL: https://github.com/apache/cloudstack/pull/10472#issuecomment-2685587838 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10472?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`1f09266`)](https://app.codecov.io/gh/apache/cloudstack/commit/1f09266764147ed957164494fe4b4449aeb1e592?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`79f7881`)](https://app.codecov.io/gh/apache/cloudstack/commit/79f7881c29e03f3f37e324d39c573e5f5e72c836?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (1f09266) and HEAD (79f7881). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (1f09266) | HEAD (79f7881) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10472 +/- ## = - Coverage 15.15%4.29% -10.87% = Files 5413 367 -5046 Lines47470729634 -445073 Branches 57894 5201-52693 = - Hits 71940 1272-70668 + Misses 39472228217 -366505 + Partials 8045 145 -7900 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10472/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10472/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10472?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
blueorangutan commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2685694842 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2685694847 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2685694881 Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add use of virsh domifaddr to get VM external DHCP IP [cloudstack]
blueorangutan commented on PR #10376: URL: https://github.com/apache/cloudstack/pull/10376#issuecomment-2685694873 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
blueorangutan commented on PR #10466: URL: https://github.com/apache/cloudstack/pull/10466#issuecomment-2685639216 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] listDiskOfferings on new instance results in 530 internal error [cloudstack]
gioporta opened a new issue, #10473: URL: https://github.com/apache/cloudstack/issues/10473 ### problem When attempting to use the "Create and Add Volume" function in the GUI on a newly created instance that has not yet been started, the list of disk offerings returns "No Data". The list refuses to populate until the instance has been started.  I checked the API traffic and observed that when the browser sends the API request for listDiskOfferings, the API response returns with status code 530. It appears that the server is unable to determine suitable disk offerings since the instance is not assigned to any cluster yet. Management server logs show the following error: ``` 2025-02-26 10:25:14,140 DEBUG [c.c.v.ClusteredVirtualMachineManagerImpl] (qtp765242091-3745:[ctx-5a2e6448, ctx-7473445a]) (logid:d7af02c4) host id is null, using last host id null 2025-02-26 10:25:14,141 ERROR [c.c.a.ApiServer] (qtp765242091-3745:[ctx-5a2e6448, ctx-7473445a]) (logid:d7af02c4) unhandled exception executing api command: [Ljava.lang.String;@4c73bab7 java.lang.NullPointerException: Cannot invoke "com.cloud.org.Cluster.getPodId()" because "cluster" is null at com.cloud.vm.VirtualMachineManagerImpl.getDiskOfferingSuitabilityForVm(VirtualMachineManagerImpl.java:6083) at com.cloud.api.ApiDBUtils.newDiskOfferingResponses(ApiDBUtils.java:2135) at com.cloud.api.query.ViewResponseHelper.createDiskOfferingResponses(ViewResponseHelper.java:558) at com.cloud.api.query.QueryManagerImpl.searchForDiskOfferings(QueryManagerImpl.java:3396) at org.apache.cloudstack.api.command.user.offering.ListDiskOfferingsCmd.execute(ListDiskOfferingsCmd.java:134) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:173) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:831) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:652) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:354) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:157) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:154) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:108) at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:600) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:235) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1624) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1594) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:772) at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:146) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) at org.eclipse.jetty.server.Server.handle(Server.java:516) at org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487) at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.jav
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
Pearl1594 commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686313674 @blueorangitan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch fix-list-disk-off-nonstartedvm created (now fc0a643097f)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch fix-list-disk-off-nonstartedvm in repository https://gitbox.apache.org/repos/asf/cloudstack.git at fc0a643097f Fix listing disk offerings for newly created VMs that haven't yet been started This branch includes the following new commits: new fc0a643097f Fix listing disk offerings for newly created VMs that haven't yet been started The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
(cloudstack) 01/01: Fix listing disk offerings for newly created VMs that haven't yet been started
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch fix-list-disk-off-nonstartedvm
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit fc0a643097f16b1c1106fb3025bd341e43f685fb
Author: Pearl Dsilva
AuthorDate: Wed Feb 26 16:57:20 2025 -0500
Fix listing disk offerings for newly created VMs that haven't yet been
started
---
.../src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | 3 +++
server/src/main/java/com/cloud/api/ApiDBUtils.java | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
index 7b231d02cb0..472fe148a5d 100755
---
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
+++
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -6071,6 +6071,9 @@ public class VirtualMachineManagerImpl extends
ManagerBase implements VirtualMac
@Override
public Map getDiskOfferingSuitabilityForVm(long vmId,
List diskOfferingIds) {
VMInstanceVO vm = _vmDao.findById(vmId);
+if (userVmDetailsDao.findDetail(vm.getId(),
VmDetailConstants.DEPLOY_VM) != null) {
+return new HashMap<>();
+}
VirtualMachineProfile profile = new VirtualMachineProfileImpl(vm);
Pair clusterAndHost = findClusterAndHostIdForVm(vm, false);
Long clusterId = clusterAndHost.first();
diff --git a/server/src/main/java/com/cloud/api/ApiDBUtils.java
b/server/src/main/java/com/cloud/api/ApiDBUtils.java
index 944f60d292c..4ef1b28b9c0 100644
--- a/server/src/main/java/com/cloud/api/ApiDBUtils.java
+++ b/server/src/main/java/com/cloud/api/ApiDBUtils.java
@@ -2137,7 +2137,7 @@ public class ApiDBUtils {
for (DiskOfferingJoinVO offering : offerings) {
DiskOfferingResponse response =
s_diskOfferingJoinDao.newDiskOfferingResponse(offering);
if (vmId != null) {
-response.setSuitableForVm(suitability.get(offering.getId()));
+
response.setSuitableForVm(suitability.getOrDefault(offering.getId(), true));
}
list.add(response);
}
Re: [PR] GUI whitelabel runtime system [cloudstack]
BryanMLima commented on code in PR #8942:
URL: https://github.com/apache/cloudstack/pull/8942#discussion_r1972476459
##
ui/src/store/modules/user.js:
##
@@ -231,6 +235,10 @@ const user = {
commit('SET_LATEST_VERSION', latestVersion)
notification.destroy()
+ await api('listUsers', { userid: result.userid }).then(async
response => {
+await
applyCustomGuiTheme(response.listusersresponse.user[0].accountid,
result.domainid)
+ })
Review Comment:
@hsato03 thanks for the warning, I'm without an environment at the moment,
could you test the patch in the current state to check if it's good, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
Pearl1594 opened a new pull request, #10476:
URL: https://github.com/apache/cloudstack/pull/10476
### Description
This PR fixes: #10473
This seems to be a regression in 4.20, where in we check if the disk
offering is suitable for the VM based on the host/cluster/pod it is on. But for
a VM that hasn't yet been started, these parameters aren't yet set, as the VM
is just created in the DB.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Prior fix:
Post fix:
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2686338045 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
Pearl1594 commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2686330023 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix listing disk offerings for newly created VMs that haven't yet been started [cloudstack]
codecov[bot] commented on PR #10476: URL: https://github.com/apache/cloudstack/pull/10476#issuecomment-2686312224 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10476?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`37c4df9`)](https://app.codecov.io/gh/apache/cloudstack/commit/37c4df9ada1d81f76dc89f7d60b67c652b71aa10?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fc0a643`)](https://app.codecov.io/gh/apache/cloudstack/commit/fc0a643097f16b1c1106fb3025bd341e43f685fb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (37c4df9) and HEAD (fc0a643). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (37c4df9) | HEAD (fc0a643) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #10476 +/- ## = - Coverage 15.99%4.01% -11.99% = Files 5649 395 -5254 Lines49571432433 -463281 Branches 60017 5750-54267 = - Hits 79289 1301-77988 + Misses 40757230983 -376589 + Partials 8853 149 -8704 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10476/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10476/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10476?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
Pearl1594 commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2686329726 @weizhouapache Could you please address the comment provided? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Veeam B&R : Restore and attach backup volume is not possible [cloudstack]
Pearl1594 commented on issue #9897: URL: https://github.com/apache/cloudstack/issues/9897#issuecomment-2686332853 This has been fixed with #9898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Veeam B&R : Restore and attach backup volume is not possible [cloudstack]
Pearl1594 closed issue #9897: Veeam B&R : Restore and attach backup volume is not possible URL: https://github.com/apache/cloudstack/issues/9897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] VPC: fix private mtu of vpc tier [cloudstack]
blueorangutan commented on PR #10257: URL: https://github.com/apache/cloudstack/pull/10257#issuecomment-2686333137 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
Pearl1594 commented on code in PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1972765171 ## plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java: ## @@ -373,8 +375,12 @@ public Map getBackupMetrics(Long zoneId, List
Re: [I] Importing Vmware instance L2 Setup network not available [cloudstack]
DaanHoogland commented on issue #10432: URL: https://github.com/apache/cloudstack/issues/10432#issuecomment-2684369453 @okodhe2 this fix should be available since 4.18.1. What version are you using? Can you explain which steps you are taking and where you get stuck? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] cloudstack-setup-databases: fix mode and group of key file [cloudstack]
weizhouapache opened a new pull request, #10466:
URL: https://github.com/apache/cloudstack/pull/10466
### Description
This PR fixes the mode and group of `key` file, which should have same
setting as db.properties file
see issue below:
```
# ls -l /etc/cloudstack/management/key
/etc/cloudstack/management/db.properties
-rw-r-. 1 root cloud 4802 Feb 8 13:50
/etc/cloudstack/management/db.properties
-rw-r--r--. 1 root root 8 Feb 8 13:50 /etc/cloudstack/management/key
```
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
