Re: [PR] UI: Add change host password [cloudstack]
bernardodemarco commented on code in PR #10337:
URL: https://github.com/apache/cloudstack/pull/10337#discussion_r1960687155
##
ui/src/views/infra/ChangeHostPassword.vue:
##
@@ -0,0 +1,150 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ {{ $t('label.cancel') }}
+ {{ $t('label.ok') }}
+
+
+
+
+
+
+
Re: [PR] UI: Fix filtering of templates by account [cloudstack]
codecov[bot] commented on PR #10425: URL: https://github.com/apache/cloudstack/pull/10425#issuecomment-2667182435 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10425?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.29%. Comparing base [(`b9ebc7b`)](https://app.codecov.io/gh/apache/cloudstack/commit/b9ebc7b721b9dc187c38e3c97a3d43a12de09e12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`69551a0`)](https://app.codecov.io/gh/apache/cloudstack/commit/69551a05f2d2aeaa01709b6806c5685fea1fe5f7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (b9ebc7b) and HEAD (69551a0). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (b9ebc7b) | HEAD (69551a0) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #10425 +/- ## = - Coverage 15.15%4.29% -10.87% = Files 5413 367 -5046 Lines47469429629 -445065 Branches 57891 5200-52691 = - Hits 71942 1272-70670 + Misses 39470628212 -366494 + Partials 8046 145 -7901 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10425/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10425/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10425/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10425?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
tpodowd commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2667339592 Hi @DaanHoogland - please ignore this PR for the moment. I'm going to look at the plugin again with the new information that @abh1sar has provided regarding the quota being required. I'll fix the build issue before I push anything to the branch. @abh1sar - can you check my reply above also regarding how I think we might handle this? Thanks @shwstppr for pointing out the issue with the pom versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix filtering of templates by account [cloudstack]
blueorangutan commented on PR #10425: URL: https://github.com/apache/cloudstack/pull/10425#issuecomment-2667197569 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10425 (QA-JID-557) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inconsistencies that result in Usage generating usage records when it should not [cloudstack]
blueorangutan commented on PR #9888: URL: https://github.com/apache/cloudstack/pull/9888#issuecomment-2667559886 [SF] Trillian test result (tid-12463) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51966 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9888-t12463-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.34 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.45 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.45 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 391.90 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2667692883 [SF] Trillian test result (tid-12465) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 55625 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9721-t12465-kvm-ubuntu22.zip Smoke tests completed. 137 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.34 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.43 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.43 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.89 | test_outofbandmanagement.py test_06_purge_expunged_vm_background_task | `Failure` | 385.67 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
abh1sar commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2667733014 @Pearl1594 added some minor comments. Please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add cpu speed detection methods [cloudstack]
blueorangutan commented on PR #9762: URL: https://github.com/apache/cloudstack/pull/9762#issuecomment-2667716869 [SF] Trillian test result (tid-12468) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 55829 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9762-t12468-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.33 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.47 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.48 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 391.44 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] kubernetes goes to ERROR state with IP limitation [cloudstack]
kiranchavala commented on issue #10402: URL: https://github.com/apache/cloudstack/issues/10402#issuecomment-2667698375 @ahmadamirahmadi007 I had tried to reproduce the issue and found that when user tries to launch a cks cluster, an error is thrown mentioning that public IP address are not available. Also I am able to destroy the cks cluster in error state  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
blueorangutan commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2667528715 [SF] Trillian test result (tid-12461) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 56397 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10407-t12461-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.27 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 392.82 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: enforce the minimum cgroup cpu shares value to 2 [cloudstack]
blueorangutan commented on PR #10221: URL: https://github.com/apache/cloudstack/pull/10221#issuecomment-2667529234 [SF] Trillian test result (tid-12462) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51811 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10221-t12462-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.31 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.38 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.38 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 381.60 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2667581878 [SF] Trillian test result (tid-12456) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 123816 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10006-t12456-vmware-70u3.zip Smoke tests completed. 96 look OK, 45 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 345.21 | test_events_resource.py test_01_events_resource | `Error` | 345.22 | test_events_resource.py ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py test_04_deploy_vm_with_extraconfig_throws_exception_vmware | `Error` | 4.65 | test_deploy_vm_extra_config_data.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.34 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.50 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.50 | test_ipv4_routing.py test_deploy_more_vms_than_limit_allows | `Error` | 177.94 | test_deploy_vms_in_parallel.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3688.24 | test_kubernetes_clusters.py test_04_list_domains_level_filter | `Failure` | 0.06 | test_list_domains.py test_05_list_domains_no_filter | `Failure` | 0.04 | test_list_domains.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Error` | 157.17 | test_network_permissions.py test_01_deployVMInSharedNetwork | `Error` | 162.20 | test_network.py ContextSuite context=TestPurgeExpungedVms>:setup | `Error` | 0.00 | test_purge_expunged_vms.py test_another_user_can_allocate_ip_after_quarantined_has_ended_network | `Error` | 6.63 | test_quarantined_ips.py test_another_user_can_allocate_ip_after_quarantined_has_ended_vpc | `Error` | 0.36 | test_quarantined_ips.py test_only_owner_can_allocate_ip_in_quarantine_network | `Error` | 0.35 | test_quarantined_ips.py test_only_owner_can_allocate_ip_in_quarantine_vpc | `Error` | 0.38 | test_quarantined_ips.py test_CRUD_operations_userdata | `Error` | 1521.73 | test_register_userdata.py test_deploy_vm_with_registered_userdata | `Error` | 7.63 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 7.27 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 7.41 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 7.35 | test_register_userdata.py test_deploy_vm_with_registered_userdata_with_params | `Error` | 7.45 | test_register_userdata.py test_link_and_unlink_userdata_to_template | `Error` | 7.08 | test_register_userdata.py test_user_userdata_crud | `Error` | 7.52 | test_register_userdata.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestResourceNames>:setup | `Error` | 0.00 | test_resource_names.py ContextSuite context=TestRestoreVM>:setup | `Error` | 0.00 | test_restore_vm.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py ContextSuite context=TestVolumes>:setup | `Error` | 1517.73 | test_volumes.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_register_vnf_template | `Error` | 0.07 | test_vnf_templates.py test_02_list_vnf_template | `Error` | 0.07 | test_vnf_templates.py test_03_edit_vnf_template | `Error` | 0.09 | test_vnf_templates.py test_04_deploy_vnf_appliance | `Error` | 0.07 | test_vnf_templates.py test_05_delete_vnf_template | `Error` | 0.07 | test_vnf_templates.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_change_service_offering_for_vm_with_snapshots | `Error` | 1.45 | test_vm_snapshots.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 12.20 | test_vm_snapshots.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error`
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
tpodowd commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2667602018 I got my local build working again and confirmed that indeed we cannot add buckets currently as quota is now a requirement and create bucket fails with: > Failed to create bucket with name: testbucket com.cloud.utils.exception.CloudRuntimeException: This bucket does not support quotas. This is because the Cloudian plugin as written does not implement bucket quota and fails the request. I need to figure out an approach for this. I guess there are two approaches: 1. The plugin ignores the quota and creates the bucket regardless. 2. We implement the user quota that I mentioned in an earlier comment. I am guessing that option 1 is not really an option and I need to implement option 2? Let me know if I am wrong about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Failed to setup keystore on the KVM [cloudstack]
tomorrrow666 opened a new issue, #10426:
URL: https://github.com/apache/cloudstack/issues/10426
idrl@management1:~$ sudo tail -f /var/log/cloudstack/agent/agent.log
2025-02-19 10:33:21,758 INFO [cloud.agent.AgentShell] (main:[]) (logid:)
Using default Java settings for IPv6 preference for agent connection
2025-02-19 10:33:21,823 INFO [cloud.agent.Agent] (main:[]) (logid:) id is
2025-02-19 10:33:21,829 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) uefi.properties file found at
/etc/cloudstack/agent/uefi.properties
2025-02-19 10:33:21,829 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) guest.nvram.template.legacy = null
2025-02-19 10:33:21,829 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) guest.loader.legacy = null
2025-02-19 10:33:21,829 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) guest.nvram.template.secure = null
2025-02-19 10:33:21,830 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) guest.loader.secure =null
2025-02-19 10:33:21,830 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) guest.nvram.path = null
2025-02-19 10:33:21,882 INFO [kvm.resource.LibvirtConnection] (main:[])
(logid:) No existing libvirtd connection found. Opening a new one
2025-02-19 10:33:22,027 INFO [kvm.resource.LibvirtComputingResource]
(main:[]) (logid:) IO uring driver for Qemu: enabled
idrl@management1:~$ sudo tail -f /var/log/cloudstack/agent/agent.err
at com.cloud.agent.AgentShell.launchNewAgent(AgentShell.java:453)
at
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:432)
at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:416)
at com.cloud.agent.AgentShell.start(AgentShell.java:512)
at com.cloud.agent.AgentShell.main(AgentShell.java:542)
Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:527)
... 14 more
idrl@management1:~$ sudo tail -f
/var/log/cloudstack/management/management-server.log
2025-02-19 10:36:13,976 DEBUG [c.c.s.S.AutoScaleMonitor]
(StatsCollector-3:[ctx-2e1a9507]) (logid:bac1a6d1) AutoScaling Monitor is
running...
2025-02-19 10:36:13,978 DEBUG [c.c.v.d.VmStatsDaoImpl]
(StatsCollector-4:[ctx-4e3079a0]) (logid:92b0a506) Starting to remove all
vm_stats rows older than [Tue Feb 18 22:36:13 GMT+08:00 2025].
2025-02-19 10:36:13,981 DEBUG [c.c.s.d.VolumeStatsDaoImpl]
(StatsCollector-6:[ctx-a93b8a32]) (logid:65fd1ad6) Starting to remove all
volume_stats rows older than [Tue Feb 18 22:36:13 GMT+08:00 2025].
2025-02-19 10:36:13,981 INFO [c.c.v.d.VmStatsDaoImpl]
(StatsCollector-4:[ctx-4e3079a0]) (logid:92b0a506) Removed a total of [0]
vm_stats rows older than [Tue Feb 18 22:36:13 GMT+08:00 2025].
2025-02-19 10:36:13,983 INFO [c.c.s.d.VolumeStatsDaoImpl]
(StatsCollector-6:[ctx-a93b8a32]) (logid:65fd1ad6) Removed a total of [0]
volume_stats rows older than [Tue Feb 18 22:36:13 GMT+08:00 2025].
2025-02-19 10:36:14,438 DEBUG [c.c.a.ApiServlet]
(qtp1215904751-317:[ctx-2deeed7d]) (logid:afa45fb2) ===START=== 192.168.1.199
-- GET
command=readyForShutdown&response=json&sessionkey=pPCweXbSXlsOq0_Ld76jsBBY9P8
2025-02-19 10:36:14,439 DEBUG [c.c.a.ApiServlet]
(qtp1215904751-317:[ctx-2deeed7d]) (logid:afa45fb2) Two factor authentication
is already verified for the user 2, so skipping
2025-02-19 10:36:14,458 DEBUG [c.c.a.ApiServer]
(qtp1215904751-317:[ctx-2deeed7d, ctx-30259112]) (logid:afa45fb2) CIDRs from
which account 'Account
[{"accountName":"admin","id":2,"uuid":"2b7da926-ed9c-11ef-838c-000c29e7ae90"}]'
is allowed to perform API calls: 0.0.0.0/0,::/0
2025-02-19 10:36:14,466 DEBUG [o.a.c.a.StaticRoleBasedAPIAccessChecker]
(qtp1215904751-317:[ctx-2deeed7d, ctx-30259112]) (logid:afa45fb2) RoleService
is enabled. We will use it instead of StaticRoleBasedAPIAccessChecker.
2025-02-19 10:36:14,466 DEBUG [o.a.c.r.ApiRateLimitServiceImpl]
(qtp1215904751-317:[ctx-2deeed7d, ctx-30259112]) (logid:afa45fb2) API rate
limiting is disabled. We will not use ApiRateLimitService.
2025-02-19 10:36:14,471 INFO [c.c.a.ApiServlet]
(qtp1215904751-317:[ctx-2deeed7d, ctx-30259112]) (logid:afa45fb2) (userId=2
accountId=2 sessionId=node0maw0vegqs5xy16hqy8rj7uvkq0) 192.168.1.199 -- GET
command=readyForShutdown&response=json&sessionkey=pPCweXbSXlsOq0_Ld76jsBBY9P8
200
{"readyforshutdownresponse":{"readyforshutdown":{"readyforshutdown":true,"shutdowntriggered":false,"pendingjobscount":0}}}
2025-02-19 10:36:14,471 DEBUG [c.c.a.ApiServlet]
(qtp1215904751-317:[ctx-2deeed7d, ctx-30259112]) (logid:afa45fb2) ===END===
[PR] UI: Fix filtering of templates by account [cloudstack]
bernardodemarco opened a new pull request, #10425:
URL: https://github.com/apache/cloudstack/pull/10425
### Description
Currently, an account's `InfoCard` contains buttons that enable the users to
view the resources of a given account. However, the `View Templates` button is
not working. When selected, all templates are listed.
This PR proposes to fix this issue by only listing the templates associated
to an account when the `View Templates` button on its `InfoCard` is selected.
---
Fixes #10391
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Verified that when selecting the `View Templates` button present on an
account's `InfoCard`, the UI redirects the user to the following path
`/template?templatefilter=self&account=&domainid=`.
Therefore, only the templates associated with the account are listed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI: Fix filtering of templates by account [cloudstack]
bernardodemarco commented on PR #10425: URL: https://github.com/apache/cloudstack/pull/10425#issuecomment-2667175848 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix filtering of templates by account [cloudstack]
blueorangutan commented on PR #10425: URL: https://github.com/apache/cloudstack/pull/10425#issuecomment-2667176812 @bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MS maintenance improvements [cloudstack]
blueorangutan commented on PR #10417: URL: https://github.com/apache/cloudstack/pull/10417#issuecomment-2667246782 [SF] Trillian test result (tid-12458) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51474 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10417-t12458-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.29 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.40 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.41 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 386.49 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
Pearl1594 commented on PR #9561: URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666074314 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2666179951 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Proper explanation for the global setting to avoid ambiguity [cloudstack]
Pearl1594 commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2665891980 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666122848 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
Pearl1594 merged PR #9898: URL: https://github.com/apache/cloudstack/pull/9898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: Veeam: set backed_volumes for each backup (#9898)
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 21b5e4dcae5 Veeam: set backed_volumes for each backup (#9898)
21b5e4dcae5 is described below
commit 21b5e4dcae5b3cb73637fc82410bd8e4fd55e99c
Author: Wei Zhou
AuthorDate: Tue Feb 18 17:31:15 2025 +0100
Veeam: set backed_volumes for each backup (#9898)
---
.../main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java | 4
1 file changed, 4 insertions(+)
diff --git
a/plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
b/plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
index c120d8bd599..50caa2ea888 100644
---
a/plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
+++
b/plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/VeeamBackupProvider.java
@@ -50,6 +50,7 @@ import com.cloud.dc.VmwareDatacenter;
import com.cloud.hypervisor.vmware.VmwareDatacenterZoneMap;
import com.cloud.dc.dao.VmwareDatacenterDao;
import com.cloud.hypervisor.vmware.dao.VmwareDatacenterZoneMapDao;
+import com.cloud.storage.dao.VolumeDao;
import com.cloud.user.User;
import com.cloud.utils.Pair;
import com.cloud.utils.component.AdapterBase;
@@ -109,6 +110,8 @@ public class VeeamBackupProvider extends AdapterBase
implements BackupProvider,
private AgentManager agentMgr;
@Inject
private VirtualMachineManager virtualMachineManager;
+@Inject
+private VolumeDao volumeDao;
protected VeeamClient getClient(final Long zoneId) {
try {
@@ -378,6 +381,7 @@ public class VeeamBackupProvider extends AdapterBase
implements BackupProvider,
backup.setAccountId(vm.getAccountId());
backup.setDomainId(vm.getDomainId());
backup.setZoneId(vm.getDataCenterId());
+
backup.setBackedUpVolumes(BackupManagerImpl.createVolumeInfoFromVolumes(volumeDao.findByInstance(vm.getId(;
logger.debug("Creating a new entry in backups: [id:
{}, uuid: {}, name: {}, vm_id: {}, external_id: {}, type: {}, date: {},
backup_offering_id: {}, account_id: {}, "
+ "domain_id: {}, zone_id: {}].",
backup.getId(), backup.getUuid(), backup.getName(), backup.getVmId(),
backup.getExternalId(), backup.getType(), backup.getDate(),
backup.getBackupOfferingId(), backup.getAccountId(), backup.getDomainId(),
backup.getZoneId());
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
blueorangutan commented on PR #9898: URL: https://github.com/apache/cloudstack/pull/9898#issuecomment-2666188200 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
blueorangutan commented on PR #10413: URL: https://github.com/apache/cloudstack/pull/10413#issuecomment-2666179943 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add nicoschmdt as a project collaborator [cloudstack]
nicoschmdt opened a new pull request, #10422:
URL: https://github.com/apache/cloudstack/pull/10422
### Description
This PR adds myself as a collaborator in `.asf.yaml` in order to be able to
add, remove and edit tags to issues/PRs, and to be assigned to issues.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
Pearl1594 commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666090489 @blueorangutan ol8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Proper explanation for the global setting to avoid ambiguity [cloudstack]
sonarqubecloud[bot] commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2666055024 ## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) **Quality Gate failed** Failed conditions  [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) (required ≥ B) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10042) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
Pearl1594 commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666083224 @blueorangutan help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666087177 @Pearl1594 [SL] I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups] Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82'] Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu. When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced) Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates. Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87'] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2666152344 [SF] Trillian test result (tid-12457) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 73968 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10006-t12457-xcpng82.zip Smoke tests completed. 134 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 175.38 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 175.46 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.37 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.48 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.48 | test_ipv4_routing.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 7.48 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 230.06 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 119.28 | test_nonstrict_affinity_group.py test_06_purge_expunged_vm_background_task | `Failure` | 410.73 | test_purge_expunged_vms.py test_02_create_volume | `Error` | 3.22 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 70.55 | test_scale_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666150157 [SF] Trillian Build Failed (tid-12469) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
blueorangutan commented on PR #9561: URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666261798 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] small UI regressions in convert Vmware to KVM VMs [cloudstack]
DaanHoogland commented on issue #10412: URL: https://github.com/apache/cloudstack/issues/10412#issuecomment-2665276953 during testing of this an NPE was encountered: ``` java.lang.NullPointerException at com.cloud.hypervisor.vmware.mo.BaseMO.createReturnObjectPair(BaseMO.java:68) at com.cloud.hypervisor.vmware.mo.HostMO.getVmProperties(HostMO.java:760) at com.cloud.hypervisor.vmware.mo.HostMO.getVmProperties(HostMO.java:1399) at com.cloud.hypervisor.vmware.mo.HostMO.getVms(HostMO.java:1379) at com.cloud.hypervisor.vmware.manager.VmwareManagerImpl.listVMsInDatacenter(VmwareManagerImpl.java:1605) at jdk.internal.reflect.GeneratedMethodAccessor473.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.jav a:198) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215) at com.sun.proxy.$Proxy447.listVMsInDatacenter(Unknown Source) at org.apache.cloudstack.api.command.admin.zone.ListVmwareDcVmsCmd.execute(ListVmwareDcVmsCmd.java:121) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:172) at com.cloud.api.ApiServer.queueCommand(ApiServer.java:833) at com.cloud.api.ApiServer.handleRequest(ApiServer.java:654) at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:349) at com.cloud.api.ApiServlet$1.run(ApiServlet.java:152) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java :102) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java: 52) at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:149) at com.cloud.api.ApiServlet.doGet(ApiServlet.java:103) at javax.servlet.http.HttpServlet.service(HttpServlet.java:645) at javax.servlet.http.HttpServlet.service(HttpServlet.java:750) at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450) ``` this is addressed in https://github.com/apache/cloudstack/pull/10413/commits/9b2a83df36c89884d63767f17b55277c694bd9ba -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix hostId verification on unsuccessful expunge operation [cloudstack]
nicoschmdt opened a new pull request, #10418:
URL: https://github.com/apache/cloudstack/pull/10418
### Description
In Java, the operator and has a higher precedence than the operator or. This
caused the method `handleUnsuccessfulExpungeOperation` to execute even when the
`hostId` or `lastHostId` value was `null`, allowing CloudStack to send a
command to a host that doesn't exist.
This PR fixes this verification logic adding parenthesis to ensure the
method will not execute when the value of the parameter `hostId` is `null`.
To reproduce this error you need to deploy a VM with a tag with no matches
and then try to expunge it.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
Through debug mode I tested different values for `finalizeExpungeCommands`,
`nicExpungeCommands` and `hostId` and I checked that it is not possible to
execute the method when `hostId` is null or when both of the command lists are
empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
blueorangutan commented on PR #10413: URL: https://github.com/apache/cloudstack/pull/10413#issuecomment-2665485202 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665485199 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add cpu speed detection methods [cloudstack]
Pearl1594 commented on PR #9762: URL: https://github.com/apache/cloudstack/pull/9762#issuecomment-2665978190 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
Pearl1594 commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2665981478 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2665983866 @Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add cpu speed detection methods [cloudstack]
blueorangutan commented on PR #9762: URL: https://github.com/apache/cloudstack/pull/9762#issuecomment-2665983987 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
DaanHoogland commented on PR #9898: URL: https://github.com/apache/cloudstack/pull/9898#issuecomment-2665987058 Blue ape only listens to last message @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Enhancing CloudStack Monitoring with eBPF [cloudstack]
soreana commented on issue #10415: URL: https://github.com/apache/cloudstack/issues/10415#issuecomment-2666882065 Hey @DaanHoogland, I have not been entirely absent. ;) I've been working on a Master's degree for the past year, and it's kept me pretty busy. But fingers crossed, I should be able to wrap that up before summer! > Would you consider this a part-time or full-time project? The scope of a project can determine whether it is a full-time or part-time. For example, monitoring the CPU usage of a virtual machine could be considered a part-time task, but implementing all the mentioned eBPF projects require full-time commitment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow uploading of ISO for creating kubernetes supported versions [cloudstack]
blueorangutan commented on PR #9561: URL: https://github.com/apache/cloudstack/pull/9561#issuecomment-2666081167 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Proper explanation for the global setting to avoid ambiguity [cloudstack]
blueorangutan commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2666129828 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add View ISO Button to Accounts / Domain [cloudstack]
bernardodemarco commented on issue #10393: URL: https://github.com/apache/cloudstack/issues/10393#issuecomment-2666531345 Yes, I can try to work on all of them. The current behavior for the `listIsos` API is similar to the `listTemplates`. It is possible to list ISOs by account through the API; however, filtering by domain is not supported. Therefore, I'll probably open four PRs: 1. Add UI support for filtering templates by account; 2. Add UI support for filtering ISOs by account; 3. Add API and UI support for filtering templates by domain; 4. Add API and UI support for filtering ISOs by domain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add logs for host removal [cloudstack]
julien-vaz opened a new pull request, #10423:
URL: https://github.com/apache/cloudstack/pull/10423
### Description
While removing a host via API `deleteHost`, only a few log messages were
being displayed, so following the removal process was difficult. Therefore,
more debug level log messages were added to facilitate troubleshooting.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
1. The host list was accessed;
2. A host was disabled and removed with the force option selected;
3. The log messages were successfully displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]
Pearl1594 commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2666120243 @blueorangutan test ol8 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs for host removal [cloudstack]
bernardodemarco commented on code in PR #10423:
URL: https://github.com/apache/cloudstack/pull/10423#discussion_r1960402339
##
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##
@@ -1002,7 +1019,7 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
storagePool.setClusterId(null);
_storagePoolDao.update(poolId, storagePool);
_storagePoolDao.remove(poolId);
-logger.debug("Local storage [id: {}] is removed as a
part of {} removal", storagePool, hostRemoved);
+logger.debug("Local storage [id: {}] is removed as a
part of host [{}] removal", poolId, hostRemoved.toString());
Review Comment:
```suggestion
logger.debug("Local storage [ID: {}] is removed as a
part of host [{}] removal", poolId, hostRemoved.toString());
```
##
server/src/main/java/com/cloud/resource/ResourceManagerImpl.java:
##
@@ -909,31 +909,41 @@ protected boolean doDeleteHost(final long hostId, final
boolean isForced, final
// Verify that host exists
final HostVO host = _hostDao.findById(hostId);
if (host == null) {
-throw new InvalidParameterValueException("Host with id " + hostId
+ " doesn't exist");
+String errorMessage = String.format("Host with ID [%s] was not
found", hostId);
+logger.warn(errorMessage);
+throw new InvalidParameterValueException(errorMessage);
}
+logger.info("Attempting to delete host with UUID [{}].",
host.getUuid());
+
_accountMgr.checkAccessAndSpecifyAuthority(CallContext.current().getCallingAccount(),
host.getDataCenterId());
if (!canDeleteHost(host) && !isForced) {
-throw new CloudRuntimeException("Host " + host.getUuid() +
-" cannot be deleted as it is not in maintenance mode.
Either put the host into maintenance or perform a forced deletion.");
+String errorMessage = String.format("Host with UUID [%s] is not in
maintenance mode and no forced deletion was requested.", host.getUuid());
+logger.warn(errorMessage);
+throw new CloudRuntimeException(errorMessage);
}
// Get storage pool host mappings here because they can be removed as a
// part of handleDisconnect later
final List pools =
_storagePoolHostDao.listByHostIdIncludingRemoved(hostId);
+logger.debug("Getting storage pools including those removed by host
with UUID [{}]: [{}].", host.getUuid(), pools);
+
final ResourceStateAdapter.DeleteHostAnswer answer =
(ResourceStateAdapter.DeleteHostAnswer)dispatchToStateAdapters(ResourceStateAdapter.Event.DELETE_HOST,
false, host, isForced,
isForceDeleteStorage);
if (answer == null) {
-throw new CloudRuntimeException(String.format("No resource adapter
respond to DELETE_HOST event for %s, hypervisorType is %s, host type is %s",
-host, host.getHypervisorType(), host.getType()));
+String errorMessage = String.format("No resource adapter answer
was returned to DELETE_HOST event for host [%s] with ID [%s], hypervisor type
[%s] and host type [%s]. ",
Review Comment:
```suggestion
String errorMessage = String.format("No resource adapter answer
was returned to DELETE_HOST event for host [%s] with ID [%s], hypervisor type
[%s] and host type [%s].",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
blueorangutan commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665399235 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] No method to apply quota on storage tags [cloudstack]
DaanHoogland commented on issue #10382: URL: https://github.com/apache/cloudstack/issues/10382#issuecomment-2665564287 I have no idea if this is possible yet @GutoVeronezi @JoaoJandre do you gys know the answer to this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] usage: use runtime scope when running maven usage profile [cloudstack]
Pearl1594 merged PR #10331: URL: https://github.com/apache/cloudstack/pull/10331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: enforce the minimum cgroup cpu shares value to 2 [cloudstack]
Pearl1594 commented on PR #10221: URL: https://github.com/apache/cloudstack/pull/10221#issuecomment-2665830326 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
boring-cyborg[bot] commented on PR #10419: URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2665834876 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) Here are some useful points: - In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation) - Be patient and persistent. It might take some time to get a review or get the final approval from the committers. - Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts. - Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack. - Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions). Apache CloudStack is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html) Slack: https://apachecloudstack.slack.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix: enforce the minimum cgroup cpu shares value to 2 [cloudstack]
blueorangutan commented on PR #10221: URL: https://github.com/apache/cloudstack/pull/10221#issuecomment-2665833593 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add logs for storage pools reordering [cloudstack]
julien-vaz opened a new pull request, #10419:
URL: https://github.com/apache/cloudstack/pull/10419
### Description
Since the storage pool reordering process was lacking logs for
troubleshooting, some debug level log messages were added and trace level log
messages were changed to the debug level. Also, the log messages were rewritten
according to the new Log4j2 syntax.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
1. A volume was created;
2. Its disk offering was changed;
3. It was verified that the log messages were properly being displayed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) branch 4.20 updated: Fixup alerting and logging error in BGPServiceImpl (#10252)
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch 4.20
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.20 by this push:
new 6a3314c40b9 Fixup alerting and logging error in BGPServiceImpl (#10252)
6a3314c40b9 is described below
commit 6a3314c40b9769bda90b5798b8878668c764c1a2
Author: Vishesh
AuthorDate: Tue Feb 18 19:53:43 2025 +0530
Fixup alerting and logging error in BGPServiceImpl (#10252)
* Fixup alerting and logging error in BGPServiceImpl
* Update unit tests
* Apply suggestions from code review
Co-authored-by: dahn
-
Co-authored-by: dahn
---
.../java/com/cloud/alert/AlertManagerImpl.java | 5 +-
.../main/java/com/cloud/bgp/BGPServiceImpl.java| 6 +-
.../java/com/cloud/alert/AlertManagerImplTest.java | 71 ++
3 files changed, 65 insertions(+), 17 deletions(-)
diff --git a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
index f4a8167c5a2..60ba90b77d5 100644
--- a/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
+++ b/server/src/main/java/com/cloud/alert/AlertManagerImpl.java
@@ -778,13 +778,14 @@ public class AlertManagerImpl extends ManagerBase
implements AlertManager, Confi
AlertVO alert = null;
Long clusterId = cluster == null ? null : cluster.getId();
Long podId = pod == null ? null : pod.getId();
+long dcId = dataCenter == null ? 0L : dataCenter.getId();
if ((alertType != AlertManager.AlertType.ALERT_TYPE_HOST) &&
(alertType != AlertManager.AlertType.ALERT_TYPE_USERVM)
&& (alertType !=
AlertManager.AlertType.ALERT_TYPE_DOMAIN_ROUTER) && (alertType !=
AlertManager.AlertType.ALERT_TYPE_CONSOLE_PROXY)
&& (alertType != AlertManager.AlertType.ALERT_TYPE_SSVM) &&
(alertType != AlertManager.AlertType.ALERT_TYPE_STORAGE_MISC)
&& (alertType !=
AlertManager.AlertType.ALERT_TYPE_MANAGEMENT_NODE) && (alertType !=
AlertManager.AlertType.ALERT_TYPE_RESOURCE_LIMIT_EXCEEDED)
&& (alertType !=
AlertManager.AlertType.ALERT_TYPE_UPLOAD_FAILED) && (alertType !=
AlertManager.AlertType.ALERT_TYPE_OOBM_AUTH_ERROR)
&& (alertType != AlertManager.AlertType.ALERT_TYPE_HA_ACTION)
&& (alertType != AlertManager.AlertType.ALERT_TYPE_CA_CERT)) {
-alert = _alertDao.getLastAlert(alertType.getType(),
dataCenter.getId(), podId, clusterId);
+alert = _alertDao.getLastAlert(alertType.getType(), dcId, podId,
clusterId);
}
if (alert == null) {
@@ -794,7 +795,7 @@ public class AlertManagerImpl extends ManagerBase
implements AlertManager, Confi
newAlert.setContent(content);
newAlert.setClusterId(clusterId);
newAlert.setPodId(podId);
-newAlert.setDataCenterId(dataCenter.getId());
+newAlert.setDataCenterId(dcId);
newAlert.setSentCount(1);
newAlert.setLastSent(new Date());
newAlert.setName(alertType.getName());
diff --git a/server/src/main/java/com/cloud/bgp/BGPServiceImpl.java
b/server/src/main/java/com/cloud/bgp/BGPServiceImpl.java
index 101731774e7..c003bd05a51 100644
--- a/server/src/main/java/com/cloud/bgp/BGPServiceImpl.java
+++ b/server/src/main/java/com/cloud/bgp/BGPServiceImpl.java
@@ -255,9 +255,9 @@ public class BGPServiceImpl implements BGPService {
netName = network.getName();
}
-LOGGER.debug("Allocating the AS Number {} to {} on zone {}",
asNumber::toString,
-(Objects.nonNull(vpcId) ? "VPC " + vpc : "network " +
network)::toString,
-() -> dataCenterDao.findById(zoneId));
+String networkName = Objects.nonNull(vpcId) ? ("VPC " + vpc) :
("network " + network);
+LOGGER.debug("Allocating the AS Number {} to {} on zone {}",
asNumberVO::toString,
+networkName::toString, () -> dataCenterDao.findById(zoneId));
asNumberVO.setAllocated(true);
asNumberVO.setAllocatedTime(new Date());
if (Objects.nonNull(vpcId)) {
diff --git a/server/src/test/java/com/cloud/alert/AlertManagerImplTest.java
b/server/src/test/java/com/cloud/alert/AlertManagerImplTest.java
index 2959e73ae9e..d34d0b5873f 100644
--- a/server/src/test/java/com/cloud/alert/AlertManagerImplTest.java
+++ b/server/src/test/java/com/cloud/alert/AlertManagerImplTest.java
@@ -26,8 +26,10 @@ import
org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
import org.apache.cloudstack.utils.mailing.SMTPMailSender;
import org.apache.logging.log4j.Logger;
import org.junit.Assert;
+import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mock
Re: [PR] Fixup alerting and logging error in BGPServiceImpl [cloudstack]
Pearl1594 merged PR #10252: URL: https://github.com/apache/cloudstack/pull/10252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
shwstppr commented on code in PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#discussion_r1959450513 ## plugins/storage/object/cloudian/pom.xml: ## @@ -0,0 +1,70 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> +4.0.0 +cloud-plugin-storage-object-cloudian +Apache CloudStack Plugin - Cloudian HyperStore object storage provider + +org.apache.cloudstack +cloudstack-plugins +4.20.0.0-SNAPSHOT Review Comment: ```suggestion 4.21.0.0-SNAPSHOT ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
blueorangutan commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665199626 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2665319751 [SF] Trillian test result (tid-12454) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 55574 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10006-t12454-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.24 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.34 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.34 | test_ipv4_routing.py test_06_purge_expunged_vm_background_task | `Failure` | 385.26 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665340320 @nicoschmdt a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
kiranchavala commented on PR #10413: URL: https://github.com/apache/cloudstack/pull/10413#issuecomment-2665294471 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
nicoschmdt commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665335311 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix hostId verification on unsuccessful expunge operation [cloudstack]
codecov[bot] commented on PR #10418: URL: https://github.com/apache/cloudstack/pull/10418#issuecomment-2665777946 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10418?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.00%. Comparing base [(`864751d`)](https://app.codecov.io/gh/apache/cloudstack/commit/864751d5f990d2848b3b00559202a4a590193c78?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`f674ee6`)](https://app.codecov.io/gh/apache/cloudstack/commit/f674ee60c1d4b28fc04e6ac345a43d6094e3b9df?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (864751d) and HEAD (f674ee6). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (864751d) | HEAD (f674ee6) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10418 +/- ## = - Coverage 16.15%4.00% -12.16% = Files 5666 396 -5270 Lines49796032519 -465441 Branches 60241 5759-54482 = - Hits 80459 1302-79157 + Misses 40849931067 -377432 + Partials 9002 150 -8852 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10418?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
DaanHoogland commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665625998 sorry @nicoschmdt , you missed some double imports: ``` 12:23:17 [INFO] Starting audit... 12:23:19 [ERROR] /jenkins/workspace/acs-deb-pkg-builder/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42010to42100.java:30:1: Duplicate import to line 23 - java.sql.PreparedStatement. [RedundantImport] 12:23:19 [ERROR] /jenkins/workspace/acs-deb-pkg-builder/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42010to42100.java:31:1: Duplicate import to line 25 - java.sql.SQLException. [RedundantImport] 12:23:19 Audit done. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] No method to apply quota on storage tags [cloudstack]
alsko-icom commented on issue #10382: URL: https://github.com/apache/cloudstack/issues/10382#issuecomment-2665631879 I guess maybe if its not achievable, I am "thinking in a smaller box" in terms of charging a customer according to what quotas I have assigned to him and tried to limit him to use. Instead of the a better idea you already implemented which is the metering service that cloudstack offers and bills customers after using whatever. Maybe my use case methodology is "old-school/obsolete" and it is better to allow everything to everyone and charge them based on what they use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Add View ISO Button to Accounts / Domain [cloudstack]
DaanHoogland commented on issue #10393: URL: https://github.com/apache/cloudstack/issues/10393#issuecomment-2665630834 @bernardodemarco , are you considdering this one as well, in addition to #10391 and #10392 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #10006: URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2665635537 [SF] Trillian test result (tid-12455) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 62470 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10006-t12455-kvm-ubuntu22.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.38 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.46 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.46 | test_ipv4_routing.py test_oobm_multiple_mgmt_server_ownership | `Failure` | 31.86 | test_outofbandmanagement.py test_06_purge_expunged_vm_background_task | `Failure` | 406.87 | test_purge_expunged_vms.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
DaanHoogland commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665634920 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
blueorangutan commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665639794 @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch rename-ambiguous-globalsetting updated (04e5a4413d9 -> d2b2419a54c)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch rename-ambiguous-globalsetting in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 04e5a4413d9 change log statements add d2b2419a54c modify logs No new revisions were added by this update. Summary of changes: .../src/main/java/com/cloud/agent/manager/AgentManagerImpl.java | 2 +- server/src/main/java/com/cloud/resource/ResourceManagerImpl.java| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
Pearl1594 commented on PR #9898: URL: https://github.com/apache/cloudstack/pull/9898#issuecomment-2665887715 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.20 updated: usage: use runtime scope when running maven usage profile (#10331)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a commit to branch 4.20 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.20 by this push: new c121d5bb6db usage: use runtime scope when running maven usage profile (#10331) c121d5bb6db is described below commit c121d5bb6db9822efed9fef7a8a19215dc7218e0 Author: Manoj Kumar AuthorDate: Tue Feb 18 19:51:29 2025 +0530 usage: use runtime scope when running maven usage profile (#10331) Fixes error running usage server with maven. Signed-off-by: Abhishek Kumar Co-authored-by: Abhishek Kumar --- usage/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usage/pom.xml b/usage/pom.xml index 325e56c3151..aea5a6a4706 100644 --- a/usage/pom.xml +++ b/usage/pom.xml @@ -61,7 +61,7 @@ com.mysql mysql-connector-j -provided +runtime org.dbunit
Re: [PR] Fix inconsistencies that result in Usage generating usage records when it should not [cloudstack]
Pearl1594 commented on PR #9888: URL: https://github.com/apache/cloudstack/pull/9888#issuecomment-2665892480 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix inconsistencies that result in Usage generating usage records when it should not [cloudstack]
blueorangutan commented on PR #9888: URL: https://github.com/apache/cloudstack/pull/9888#issuecomment-2665893814 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
Pearl1594 commented on PR #9898: URL: https://github.com/apache/cloudstack/pull/9898#issuecomment-2665888541 Thanks @weizhouapache - will build packages. Once done, will merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Proper explanation for the global setting to avoid ambiguity [cloudstack]
blueorangutan commented on PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#issuecomment-2665893904 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
nicoschmdt commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665918596 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
blueorangutan commented on PR #10413: URL: https://github.com/apache/cloudstack/pull/10413#issuecomment-2665299189 @kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
shwstppr commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665197274 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2665922362 @nicoschmdt a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Create Instance menu show empty values for offerings [cloudstack]
boring-cyborg[bot] commented on issue #10420: URL: https://github.com/apache/cloudstack/issues/10420#issuecomment-2665958116 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Create Instance menu show empty values for offerings [cloudstack]
ManuFe opened a new issue, #10420: URL: https://github.com/apache/cloudstack/issues/10420 Hello, I've successfully installed CloudStack 4.20 and registered my first host. I can see it in the hosts session with the green flag for the Resource state column.  And I can see all the default offerings, for example:  But when I try to create a new instance I've got no offering selectable for any of the options:  It seems like all the api requests return blank. Instead the zone, pod, cluster and host settings are correctly shown and I can select them all if I want. This is done with the default admin account created at the start. Got any solution for this kind of error? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix hostId verification on unsuccessful expunge operation [cloudstack]
DaanHoogland commented on PR #10418: URL: https://github.com/apache/cloudstack/pull/10418#issuecomment-2665974095 @nicoschmdt , I see this bug is also present in 4.20, could you rebase your code on that branch please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Veeam: set backed_volumes for each backup [cloudstack]
blueorangutan commented on PR #9898: URL: https://github.com/apache/cloudstack/pull/9898#issuecomment-2665989461 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add logs for storage pools reordering [cloudstack]
codecov[bot] commented on PR #10419: URL: https://github.com/apache/cloudstack/pull/10419#issuecomment-2666012095 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10419?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.00%. Comparing base [(`22c7192`)](https://app.codecov.io/gh/apache/cloudstack/commit/22c71928dd28dc3217e59c9d4d7dacc56621a02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fce33d9`)](https://app.codecov.io/gh/apache/cloudstack/commit/fce33d91c6594e3571f8b59b668526ab7e431ef9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 36 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (22c7192) and HEAD (fce33d9). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (22c7192) | HEAD (fce33d9) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10419 +/- ## = - Coverage 16.02%4.00% -12.03% = Files 5658 396 -5262 Lines49631232519 -463793 Branches 60109 5759-54350 = - Hits 79538 1302-78236 + Misses 40792531067 -376858 + Partials 8849 150 -8699 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10419/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10419?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MS maintenance improvements [cloudstack]
sureshanaparti commented on PR #10417: URL: https://github.com/apache/cloudstack/pull/10417#issuecomment-2664940089 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MS maintenance improvements [cloudstack]
codecov[bot] commented on PR #10417: URL: https://github.com/apache/cloudstack/pull/10417#issuecomment-2664954790 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10417?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.00%. Comparing base [(`2ef1613`)](https://app.codecov.io/gh/apache/cloudstack/commit/2ef16132ee92a51bed093c602a706446bd4cd88c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e8699b3`)](https://app.codecov.io/gh/apache/cloudstack/commit/e8699b374ae990b213538cab87feba56ad52db9a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 34 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (2ef1613) and HEAD (e8699b3). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2ef1613) | HEAD (e8699b3) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10417 +/- ## = - Coverage 16.02%4.00% -12.03% = Files 5658 396 -5262 Lines49631232519 -463793 Branches 60109 5759-54350 = - Hits 79537 1302-78235 + Misses 40792631067 -376859 + Partials 8849 150 -8699 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10417?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
sureshanaparti commented on code in PR #10413:
URL: https://github.com/apache/cloudstack/pull/10413#discussion_r1959310803
##
ui/src/views/tools/SelectVmwareVcenter.vue:
##
@@ -299,18 +300,23 @@ export default {
this.hosts = response.listvmwaredchostsresponse.host
}
}).catch(error => {
-this.$notifyError(error)
+if (doNotify) {
+ this.$notifyError(error)
Review Comment:
instead of not notifying the error, can we stop calling the list dc hosts
until some pause or enter key pressed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
sureshanaparti commented on code in PR #10413:
URL: https://github.com/apache/cloudstack/pull/10413#discussion_r1959308254
##
ui/src/views/tools/SelectVmwareVcenter.vue:
##
@@ -299,18 +300,23 @@ export default {
this.hosts = response.listvmwaredchostsresponse.host
}
}).catch(error => {
-this.$notifyError(error)
+if (doNotify) {
+ this.$notifyError(error)
+}
+this.hosts = []
+return false
}).finally(() => {
this.loading = false
+return true
Review Comment:
no need to return stmts here? @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [HEALTH] 4.21/main Health Check, please don't merge this [cloudstack]
blueorangutan commented on PR #10149: URL: https://github.com/apache/cloudstack/pull/10149#issuecomment-2664974738 [SF] Trillian test result (tid-12449) Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 73204 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10149-t12449-xcpng82.zip Smoke tests completed. 133 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_condensed_drs_algorithm | `Failure` | 177.29 | test_cluster_drs.py test_02_balanced_drs_algorithm | `Failure` | 173.21 | test_cluster_drs.py test_11_isolated_network_with_dynamic_routed_mode | `Error` | 1.28 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.41 | test_ipv4_routing.py test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 4.41 | test_ipv4_routing.py test_01_prepare_and_cancel_maintenance | `Error` | 0.08 | test_ms_maintenance_and_safe_shutdown.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 10.48 | test_network.py test_01_non_strict_host_anti_affinity | `Error` | 221.95 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 116.18 | test_nonstrict_affinity_group.py test_06_purge_expunged_vm_background_task | `Failure` | 415.08 | test_purge_expunged_vms.py test_02_create_volume | `Error` | 2.18 | test_resource_names.py test_05_scale_vm_dont_allow_disk_offering_change | `Failure` | 71.41 | test_scale_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
shwstppr commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665032122 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
shwstppr commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665031241 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] engine/orchestration: fix missing vm powerstate update vm state [cloudstack]
blueorangutan commented on PR #10407: URL: https://github.com/apache/cloudstack/pull/10407#issuecomment-2665037513 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
DaanHoogland commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2664887768 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
blueorangutan commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2664895967 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]
blueorangutan commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2664891493 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] migrate Vmware to KVM ui issues [cloudstack]
blueorangutan commented on PR #10413: URL: https://github.com/apache/cloudstack/pull/10413#issuecomment-2664911132 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10413 (QA-JID-556) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
