Re: [PR] Support multi-scope configuration settings [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10300:
URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2650553774

   @borisstoyanov a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, 
Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Autoscale Load Balancing Rule looses VMs during a node failure. [cloudstack]

2025-02-11 Thread via GitHub


btzq commented on issue #9145:
URL: https://github.com/apache/cloudstack/issues/9145#issuecomment-2650872739

   Hi @vishesh92 , 
   
   We experienced and outage with where the hypervisor host was alive, but the 
CS Agent was not able to talk to CS MGMT during heartbeat checks. As a result, 
VMs were live migrated out or restarted in another host. 
   
   It caused alot of issues with our VR, where we had to recreate it. 
   
   But we managed to re-encounter this issue which i reported in the ticket. 
   
   Some observations made:
   - Ping VMs Directly via Private IP -> Works Fine
   - Hit LB to reach VMs -> Cant Reach
   - Recreate VMs by using rolling upgrade method -> Doesnt add VMs to the LB
   - Disable ASG, Destory all VMs, Create VMs from scratch -> VMs created are 
added back to the LB
   
   I have a video recording but its got some sensitive customer info. So i will 
send it to Shapeblue directly. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9315:
URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2650862787

   [SF] Trillian test result (tid-12368)
   Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
   Total time taken: 62957 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12368-xcpng82.zip
   Smoke tests completed. 130 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_condensed_drs_algorithm | `Failure` | 174.39 | test_cluster_drs.py
   test_02_balanced_drs_algorithm | `Failure` | 171.44 | test_cluster_drs.py
   test_01_non_strict_host_anti_affinity | `Error` | 208.18 | 
test_nonstrict_affinity_group.py
   test_02_non_strict_host_affinity | `Error` | 128.97 | 
test_nonstrict_affinity_group.py
   test_01_volume_usage | `Error` | 100.27 | test_usage.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch list-only-src-arch-hosts updated (e6cbf8a9823 -> 0ba42ce1a63)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


omit e6cbf8a9823 List only those hosts matching source host arch in 
multi-arch zones
 add 0ba42ce1a63 List only those hosts matching source host arch in 
multi-arch zones

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (e6cbf8a9823)
\
 N -- N -- N   refs/heads/list-only-src-arch-hosts (0ba42ce1a63)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


rohityadavcloud commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2650889192

   @Pearl1594 can you address conflicts and advise if this is ready for 
reviewing and testing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2650501878

   @tomorrrow666 
   any new logs on 2025-02-11 ?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) 01/01: List only those hosts matching source host arch in multi-arch zones

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit eab55863b583cbc4932be9dd8663b0f2059c4f4b
Author: Pearl Dsilva 
AuthorDate: Tue Feb 11 08:22:51 2025 -0500

List only those hosts matching source host arch in multi-arch zones
---
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 5 +
 1 file changed, 5 insertions(+)

diff --git a/server/src/main/java/com/cloud/server/ManagementServerImpl.java 
b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
index 76d2943e18c..9d51cf02990 100644
--- a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
@@ -44,6 +44,7 @@ import javax.crypto.spec.SecretKeySpec;
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import com.cloud.cpu.CPU;
 import com.cloud.utils.security.CertificateHelper;
 import org.apache.cloudstack.acl.ControlledEntity;
 import org.apache.cloudstack.acl.SecurityChecker;
@@ -1612,6 +1613,10 @@ public class ManagementServerImpl extends ManagerBase 
implements ManagementServe
 logger.debug("Hosts having capacity and suitable for migration: 
{}", suitableHosts);
 }
 
+// Only list hosts of the same architecture as the source Host
+CPU.CPUArch hostArch = srcHost.getArch();
+suitableHosts = suitableHosts.stream().filter(h -> h.getArch() == 
hostArch).collect(Collectors.toList());
+
 return new Ternary<>(otherHosts, suitableHosts, requiresStorageMotion);
 }
 



(cloudstack) branch list-only-src-arch-hosts created (now eab55863b58)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at eab55863b58 List only those hosts matching source host arch in 
multi-arch zones

This branch includes the following new commits:

 new eab55863b58 List only those hosts matching source host arch in 
multi-arch zones

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack) branch list-only-src-arch-hosts updated (eab55863b58 -> 367accacff2)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


 discard eab55863b58 List only those hosts matching source host arch in 
multi-arch zones
omit 2739c0112c5 UI: Fix all list items appearing twice in search view
 add 7e295ec4e19 [KVM] Add watchdog model none to disable use of watchdogs 
on KVM agent (#10203)
 add 91f1adab862 UI: set redundant state as N/A for non-redundant routers 
(#10227)
 add d053bb97ecf Fix to allow actions on the network if it belongs to a 
project (#9550)
 add b186272f687 kvm: add SCSI controllers based on the number of 
virtio-SCSI disks (#9823)
 add 09f154796a2 server: Fix host CPU number (#10218)
 add 1e59f5cd0cd ui: fix passing vlan while creating vpc tier (#10239)
 add 20759187b31 Fix local storage deletion cases (#10231)
 add 4d9fd1b73fa Added displaynetwork option in filters for listnetwork 
only for admin (#10209)
 add c9fea62276c [UI] Switch between allocated and used capacity on 
dashboard (#10215)
 add 2aa2e92dff4 Handle special characters when exporting ACLs (#10259)
 add 4787885fc09 cks: prevent npe on cluster listing with removed offering 
(#10075)
 add 0a77eb7f85f deal with NPE during host reconnect (#10158)
 add 34d2a3bc86d Merge branch '4.19' into 4.20
 add 33a37da9ec7 server: investigate pending HA work when executing in new 
MS session (#10167)
 add f652ad0d98c extra null guard (#10264)
 add 717ce981d4d Merge release branch 4.19 to 4.20
 add 4201a2dc11b Fix Usage job not executing successfully (#10244)
 add 1c84ce4e23e server: fix attach uploaded volume (#10267)
 add 6f03f9e726e validate inserted values in numeric global settings 
(#10279)
 add 3313cc58295 ui: fix loading for hypervisor filter in serachview 
(#10292)
 add ee0dc5b2d64 list hosts API fix, when any stale entries exists on 
storage_pool_host_ref for the removed pools (#9852)
 add 0f544c9a3b0 api/ui: add specifyvlan to network response (#10236)
 add b9890875cc1 CKS: use --delete-emptydir-data instead of deprecated 
--delete-local-data (#10234)
 add b93589b5bdf server: reset 2fa user configuration on incomplete setup 
(#10247)
 add d9af9bdb36e fix SQL syntax erros and target 419 (#10273)
 add c70e4e29be4 fix npe on account creation (#10274)
 add 0fbf6379f98 UI: Fix domain view when opening details for a specific 
domainid (#10245)
 add bbe9c905926 packaging: support both mysql and mariadb on EL8/EL9 
(#9941)
 add 641a60670e1 changed the kubernetestool url (#10295)
 add a335feab6a3 fix allocation of vmfs storage pools (#10201)
 add 97be6f2e5d1 ui: fix column filter for templates, isos (#10288)
 add ae2ffbe40bf Merge remote-tracking branch 'apache/4.19' into 4.20
 add 0b5a5e8043d api,agent,server,engine-schema: scalability improvements 
(#9840)
 add fbb1ff78d63 Static Routes: fix check on wrong global configuration 
(#10066)
 add 5447950f095 Allow creation of Shared Networks without IP range if 
network offering has no services - specifyvlan = true (#10168)
 add 27efc779eac api,ui: fix empty source cidr value for firewall rule 
(#10208)
 add 0d5047b8b73 Improve listing of HA and non-HA hosts when ha.tag setting 
is defined and hosts have multiple tags along with ha tag (#10240)
 add 085bd3bda5f Merge branch '4.19' into 4.20
 add 986ec81b664 Add direct download option to Users GUI (#10193)
 add c5afee21018 UI improvements  (#9773)
 add 50a54dde5cc Make Description as optional in network acl list (#10343)
 add 5aa79a6e05d UI: Add offer ha column to system offerings table (#10297)
 new 367accacff2 List only those hosts matching source host arch in 
multi-arch zones

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (eab55863b58)
\
 N -- N -- N   refs/heads/list-only-src-arch-hosts (367accacff2)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .python-version|   2 +-
 agent/conf/agent.properties|   8 +
 agent/src/main/java/com/cloud/agent/Agent.java | 78

(cloudstack) branch list-only-src-arch-hosts updated (367accacff2 -> e6cbf8a9823)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


 discard 367accacff2 List only those hosts matching source host arch in 
multi-arch zones
 new e6cbf8a9823 List only those hosts matching source host arch in 
multi-arch zones

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (367accacff2)
\
 N -- N -- N   refs/heads/list-only-src-arch-hosts (e6cbf8a9823)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 3 ---
 1 file changed, 3 deletions(-)



(cloudstack) 01/01: List only those hosts matching source host arch in multi-arch zones

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 367accacff2b5d697de643728680841ba6a89e31
Author: Pearl Dsilva 
AuthorDate: Tue Feb 11 08:25:07 2025 -0500

List only those hosts matching source host arch in multi-arch zones
---
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 9 +
 1 file changed, 9 insertions(+)

diff --git a/server/src/main/java/com/cloud/server/ManagementServerImpl.java 
b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
index 9ffad8b8418..db085d1980a 100644
--- a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
@@ -44,6 +44,11 @@ import javax.crypto.spec.SecretKeySpec;
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+<<< Updated upstream
+===
+import com.cloud.cpu.CPU;
+import com.cloud.utils.security.CertificateHelper;
+>>> Stashed changes
 import org.apache.cloudstack.acl.ControlledEntity;
 import org.apache.cloudstack.acl.SecurityChecker;
 import org.apache.cloudstack.affinity.AffinityGroupProcessor;
@@ -1612,6 +1617,10 @@ public class ManagementServerImpl extends ManagerBase 
implements ManagementServe
 logger.debug("Hosts having capacity and suitable for migration: 
{}", suitableHosts);
 }
 
+// Only list hosts of the same architecture as the source Host
+CPU.CPUArch hostArch = srcHost.getArch();
+suitableHosts = suitableHosts.stream().filter(h -> h.getArch() == 
hostArch).collect(Collectors.toList());
+
 return new Ternary<>(otherHosts, suitableHosts, requiresStorageMotion);
 }
 



[PR] List only those hosts matching source host arch in multi-arch zones [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 opened a new pull request, #10369:
URL: https://github.com/apache/cloudstack/pull/10369

   ### Description
   
   Fixes: https://github.com/apache/cloudstack/issues/9981
   This PR attempts to list only those hosts that match source host 
architecture in a multi-arch zone
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] List only those hosts matching source host arch in multi-arch zones [cloudstack]

2025-02-11 Thread via GitHub


codecov[bot] commented on PR #10369:
URL: https://github.com/apache/cloudstack/pull/10369#issuecomment-2650844216

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10369?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.01%. Comparing base 
[(`5aa79a6`)](https://app.codecov.io/gh/apache/cloudstack/commit/5aa79a6e05d04440587ab26da70c1b3fae6e3a20?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`e6cbf8a`)](https://app.codecov.io/gh/apache/cloudstack/commit/e6cbf8a98239281a171bee19481c1f4184de357a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   > :exclamation:  There is a different number of reports uploaded between 
BASE (5aa79a6) and HEAD (e6cbf8a). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (5aa79a6) | HEAD (e6cbf8a) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   4.20   #10369   +/-   ##
   =
   - Coverage 15.99%4.01%   -11.99% 
   =
 Files  5644  394 -5250 
 Lines49491532399   -462516 
 Branches  59960 5738-54222 
   =
   - Hits  79173 1301-77872 
   + Misses   40691030949   -375961 
   + Partials   8832  149 -8683 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10369/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.01% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10369/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10369?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) 01/01: List only those hosts matching source host arch in multi-arch zones

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e6cbf8a98239281a171bee19481c1f4184de357a
Author: Pearl Dsilva 
AuthorDate: Tue Feb 11 08:25:07 2025 -0500

List only those hosts matching source host arch in multi-arch zones
---
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/server/src/main/java/com/cloud/server/ManagementServerImpl.java 
b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
index 9ffad8b8418..d391e55bce3 100644
--- a/server/src/main/java/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/main/java/com/cloud/server/ManagementServerImpl.java
@@ -44,6 +44,8 @@ import javax.crypto.spec.SecretKeySpec;
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import com.cloud.cpu.CPU;
+import com.cloud.utils.security.CertificateHelper;
 import org.apache.cloudstack.acl.ControlledEntity;
 import org.apache.cloudstack.acl.SecurityChecker;
 import org.apache.cloudstack.affinity.AffinityGroupProcessor;
@@ -1612,6 +1614,10 @@ public class ManagementServerImpl extends ManagerBase 
implements ManagementServe
 logger.debug("Hosts having capacity and suitable for migration: 
{}", suitableHosts);
 }
 
+// Only list hosts of the same architecture as the source Host
+CPU.CPUArch hostArch = srcHost.getArch();
+suitableHosts = suitableHosts.stream().filter(h -> h.getArch() == 
hostArch).collect(Collectors.toList());
+
 return new Ternary<>(otherHosts, suitableHosts, requiresStorageMotion);
 }
 



Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 commented on code in PR #10042:
URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1950868581


##
ui/src/views/infra/HostEnableDisable.vue:
##
@@ -31,7 +31,7 @@
   

Review Comment:
   The global config name has a whole lot of enable - disable reference which 
was ambiguous - which was why the gs name was changed. Do you think that isn't 
required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650958532

   @DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch 4.19.2.0-RC20250211T1518 created (now f05fa27bfd8)

2025-02-11 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch 4.19.2.0-RC20250211T1518
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at f05fa27bfd8 Updating pom.xml version numbers for release 4.19.2.0

This branch includes the following new commits:

 new f05fa27bfd8 Updating pom.xml version numbers for release 4.19.2.0

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




svn commit: r74848 - in /dev/cloudstack/4.19.2.0: apache-cloudstack-4.19.2.0-src.tar.bz2 apache-cloudstack-4.19.2.0-src.tar.bz2.asc apache-cloudstack-4.19.2.0-src.tar.bz2.sha512

2025-02-11 Thread dahn
Author: dahn
Date: Tue Feb 11 14:18:58 2025
New Revision: 74848

Log:
Committing release candidate artifacts for 4.19.2.0 to dist/dev/cloudstack in 
preparation for release vote

Added:
dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2   (with 
props)
dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc   (with 
props)
dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512

Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2
==
Binary file - no diff available.

Propchange: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2
--
svn:mime-type = application/x-bzip2

Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc
==
Binary file - no diff available.

Propchange: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.asc
--
svn:mime-type = application/pgp-signature

Added: dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512
==
--- dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 
(added)
+++ dev/cloudstack/4.19.2.0/apache-cloudstack-4.19.2.0-src.tar.bz2.sha512 Tue 
Feb 11 14:18:58 2025
@@ -0,0 +1 @@
+6295534be2a9b051a0c6a25f40fb6d6112dd3b8650bb9241501de433518d51462dc3ee957068b0df41a28a2c5a8dcfb89a642f5f1b9fdf9db18e3fb652812be7
  apache-cloudstack-4.19.2.0-src.tar.bz2




(cloudstack) 01/01: Updating pom.xml version numbers for release 4.19.2.0

2025-02-11 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.19.2.0-RC20250211T1518
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit f05fa27bfd843c6fea7b4a2d9e5c62ee21d57019
Author: Daan Hoogland 
AuthorDate: Tue Feb 11 15:18:29 2025 +0100

Updating pom.xml version numbers for release 4.19.2.0

Signed-off-by: Daan Hoogland 
---
 agent/pom.xml   | 2 +-
 api/pom.xml | 2 +-
 client/pom.xml  | 2 +-
 core/pom.xml| 2 +-
 debian/changelog| 6 ++
 developer/pom.xml   | 2 +-
 engine/api/pom.xml  | 2 +-
 engine/components-api/pom.xml   | 2 +-
 engine/orchestration/pom.xml| 2 +-
 engine/pom.xml  | 2 +-
 engine/schema/pom.xml   | 2 +-
 engine/service/pom.xml  | 2 +-
 engine/storage/cache/pom.xml| 2 +-
 engine/storage/configdrive/pom.xml  | 2 +-
 engine/storage/datamotion/pom.xml   | 2 +-
 engine/storage/image/pom.xml| 2 +-
 engine/storage/integration-test/pom.xml | 2 +-
 engine/storage/object/pom.xml   | 2 +-
 engine/storage/pom.xml  | 2 +-
 engine/storage/snapshot/pom.xml | 2 +-
 engine/storage/volume/pom.xml   | 2 +-
 engine/userdata/cloud-init/pom.xml  | 2 +-
 engine/userdata/pom.xml | 2 +-
 framework/agent-lb/pom.xml  | 2 +-
 framework/ca/pom.xml| 2 +-
 framework/cluster/pom.xml   | 2 +-
 framework/config/pom.xml| 2 +-
 framework/db/pom.xml| 2 +-
 framework/direct-download/pom.xml   | 2 +-
 framework/events/pom.xml| 2 +-
 framework/ipc/pom.xml   | 2 +-
 framework/jobs/pom.xml  | 2 +-
 framework/managed-context/pom.xml   | 2 +-
 framework/pom.xml   | 2 +-
 framework/quota/pom.xml | 2 +-
 framework/rest/pom.xml  | 2 +-
 framework/security/pom.xml  | 2 +-
 framework/spring/lifecycle/pom.xml  | 2 +-
 framework/spring/module/pom.xml | 2 +-
 plugins/acl/dynamic-role-based/pom.xml  | 2 +-
 plugins/acl/project-role-based/pom.xml  | 2 +-
 plugins/acl/static-role-based/pom.xml   | 2 +-
 plugins/affinity-group-processors/explicit-dedication/pom.xml   | 2 +-
 plugins/affinity-group-processors/host-affinity/pom.xml | 2 +-
 plugins/affinity-group-processors/host-anti-affinity/pom.xml| 2 +-
 plugins/affinity-group-processors/non-strict-host-affinity/pom.xml  | 2 +-
 .../affinity-group-processors/non-strict-host-anti-affinity/pom.xml | 2 +-
 plugins/alert-handlers/snmp-alerts/pom.xml  | 2 +-
 plugins/alert-handlers/syslog-alerts/pom.xml| 2 +-
 plugins/api/discovery/pom.xml   | 2 +-
 plugins/api/rate-limit/pom.xml  | 2 +-
 plugins/api/solidfire-intg-test/pom.xml | 2 +-
 plugins/api/vmware-sioc/pom.xml | 2 +-
 plugins/backup/dummy/pom.xml| 2 +-
 plugins/backup/networker/pom.xml| 2 +-
 plugins/backup/veeam/pom.xml| 2 +-
 plugins/ca/root-ca/pom.xml  | 2 +-
 plugins/database/mysql-ha/pom.xml   | 2 +-
 plugins/database/quota/pom.xml  | 2 +-
 plugins/dedicated-resources/pom.xml | 2 +-
 plugins/deployment-planners

Re: [PR] Added project id to kubeadmin user for Kubernetes service [cloudstack]

2025-02-11 Thread via GitHub


parkinr commented on code in PR #10362:
URL: https://github.com/apache/cloudstack/pull/10362#discussion_r1951184380


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1384,7 +1384,15 @@ private String[] getServiceUserKeys(KubernetesClusterVO 
kubernetesCluster) {
 if (owner == null || owner.getType() == Account.Type.PROJECT) {
 owner = CallContext.current().getCallingAccount();
 }
-String username = owner.getAccountName() + "-" + 
KUBEADMIN_ACCOUNT_NAME;
+
+String projectId = "default";
+Account account = 
ApiDBUtils.findAccountById(kubernetesCluster.getAccountId());
+Project project = 
ApiDBUtils.findProjectByProjectAccountId(account.getId());
+if ( project != null ) {
+  projectId = project.getUuid();
+}
+
+String username = owner.getAccountName() + "-" + projectId + "-" + 
KUBEADMIN_ACCOUNT_NAME;

Review Comment:
   That's a good idea. Will update the code as such. In our case, we always 
have projectId.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added project id to kubeadmin user for Kubernetes service [cloudstack]

2025-02-11 Thread via GitHub


parkinr commented on code in PR #10362:
URL: https://github.com/apache/cloudstack/pull/10362#discussion_r1951205895


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1384,7 +1384,15 @@ private String[] getServiceUserKeys(KubernetesClusterVO 
kubernetesCluster) {
 if (owner == null || owner.getType() == Account.Type.PROJECT) {
 owner = CallContext.current().getCallingAccount();
 }
-String username = owner.getAccountName() + "-" + 
KUBEADMIN_ACCOUNT_NAME;

Review Comment:
   Without this PR, the username is: flexcloud-admin-account-kubeadmin
   With this PR, the username is 
flexcloud-admin-account-f316789i-2bgg-4r87-95h7-58j5327892ef-kubeadmin with 
sample projectId=f316789i-2bgg-4r87-95h7-58j5327892ef. And you can see this 
projectId in cloudstack-secret on the Kubernetes cluster.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Reserve IP address for out of bounds machines [cloudstack]

2025-02-11 Thread via GitHub


wido commented on issue #4542:
URL: https://github.com/apache/cloudstack/issues/4542#issuecomment-2650638813

   It all depends on what we put in the HAProxy config on the Virtual Router. 
It could technically point to an outside address.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Support multi-scope configuration settings [cloudstack]

2025-02-11 Thread via GitHub


borisstoyanov commented on PR #10300:
URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2650551350

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650752718

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] XCP-ng Management network on VLAN [cloudstack]

2025-02-11 Thread via GitHub


UAnton commented on issue #10272:
URL: https://github.com/apache/cloudstack/issues/10272#issuecomment-2650750561

   > Seems similar to: [#4286](https://github.com/apache/cloudstack/issues/4286)
   
   Read last post in https://github.com/apache/cloudstack/issues/4286


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650750018

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650749711

   @sureshanaparti could you review/test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2651023923

   @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2651020530

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2651866957

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2651870526

   @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been 
kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added project id to kubeadmin user for Kubernetes service [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on code in PR #10362:
URL: https://github.com/apache/cloudstack/pull/10362#discussion_r1951476598


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1384,7 +1384,15 @@ private String[] getServiceUserKeys(KubernetesClusterVO 
kubernetesCluster) {
 if (owner == null || owner.getType() == Account.Type.PROJECT) {
 owner = CallContext.current().getCallingAccount();
 }
-String username = owner.getAccountName() + "-" + 
KUBEADMIN_ACCOUNT_NAME;

Review Comment:
   thanks @parkinr for the reply.
   However, the security issue is  not resolved I think.
   
   @DaanHoogland 
   we may need to treat this as a serious security issue.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10365:
URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2652019076

   @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 commented on PR #10365:
URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2652017829

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2650089628

   > "Modify IP, but the issue is not resolved."
   
   @tomorrrow666 
   what's the error ?
   you can search by keyword "Exception"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9315:
URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2650335691

   [SF] Trillian test result (tid-12366)
   Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
   Total time taken: 49968 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12366-kvm-ubuntu22.zip
   Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


tomorrrow666 commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2650346848

   idrl@management1:~$ sudo systemctl restart cloudstack-management.service
   idrl@management1:~$ sudo grep -i -E 'error|exception' 
/var/log/cloudstack/management/management-server.log
   2025-02-06 08:09:25,526 ERROR [c.c.u.d.Merovingian2] (main:null) (logid:) 
Unable to get a new db connection
   java.sql.SQLNonTransientConnectionException: Could not create connection to 
database server. Attempted reconnect 3 times. Giving up.
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:110)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
   at 
com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:211)
   Caused by: com.mysql.cj.exceptions.CJCommunicationsException: Communications 
link failure
   Caused by: java.net.ConnectException: 连接被拒绝 (Connection refused)
   2025-02-06 08:30:19,518 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE TABLE `cloud`.`s3` (   `id` bigint unsigned NOT NULL AUTO_INCREMENT 
COMMENT 'id',   `uuid` varchar(40),   `access_key` varchar(20) NOT NULL COMMENT 
' The S3 access key',   `secret_key` varchar(40) NOT NULL COMMENT ' The S3 
secret key',   `end_point` varchar(1024) COMMENT ' The S3 host',   `bucket` 
varchar(63) NOT NULL COMMENT ' The S3 host',   `https` tinyint unsigned DEFAULT 
NULL COMMENT ' Flag indicating whether or not to connect over HTTPS',   
`connection_timeout` integer COMMENT ' The amount of time to wait (in 
milliseconds) when initially establishing a connection before giving up and 
timing out.',   `max_error_retry` integer  COMMENT ' The maximum number of 
retry attempts for failed retryable requests (ex: 5xx error responses from 
services).',   `socket_timeout` integer COMMENT ' The amount of time to wait 
(in milliseconds) for data to be transferred over an established, open 
connection before t
 he connection times out and is closed.',   `created` datetime COMMENT 'date 
the s3 first signed on',   PRIMARY KEY (`id`),   CONSTRAINT `uc_s3__uuid` 
UNIQUE (`uuid`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 
   2025-02-06 08:30:21,380 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE VIEW `cloud`.`volume_view` AS select  volumes.id, 
volumes.uuid, volumes.name, volumes.device_id, 
volumes.volume_type, volumes.size, volumes.created, 
volumes.state, volumes.attached, volumes.removed, 
volumes.pod_id, account.id account_id, account.uuid 
account_uuid, account.account_name account_name, account.type 
account_type, domain.id domain_id, domain.uuid domain_uuid, 
domain.name domain_name, domain.path domain_path, 
projects.id project_id, projects.uuid project_uuid, 
projects.name project_name, data_center.id data_center_id, 
data_center.uuid data_center_uuid, data_center.name data_center_name,   
  vm_instance.id vm_id, vm_instance.uuid vm_uuid, 
vm_instance.name vm_name, 
 vm_instance.state vm_state, vm_instance.vm_type, 
user_vm.display_name vm_display_name, volume_host_ref.size 
volume_host_size, volume_host_ref.created volume_host_created, 
volume_host_ref.format, volume_host_ref.download_pct, 
volume_host_ref.download_state, volume_host_ref.error_str, 
disk_offering.id disk_offering_id, disk_offering.uuid 
disk_offering_uuid, disk_offering.name disk_offering_name, 
disk_offering.display_text disk_offering_display_text, 
disk_offering.use_local_storage, disk_offering.system_use, 
storage_pool.id pool_id, storage_pool.uuid pool_uuid, 
storage_pool.name pool_name, cluster.hypervisor_type, 
vm_template.id template_id, vm_template.uuid template_uuid, 
vm_template.extractable, vm_template.type template_type, 
resource_tags.id tag_id, resource_tags.uuid tag_uuid, resourc
 e_tags.key tag_key, resource_tags.value tag_value, 
resource_tags.domain_id tag_domain_id, resource_tags.account_id 
tag_account_id, resource_tags.resource_id tag_resource_id, 
resource_tags.resource_uuid tag_resource_uuid, 
resource_tags.resource_type tag_resource_type, resource_tags.customer 
tag_customer, async_job.id job_id, async_job.uuid job_uuid, 
async_job.job_status job_statu

(cloudstack-www) branch staging-site updated: user groups in upcoming events (#288)

2025-02-11 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch staging-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/staging-site by this push:
 new 2a5efd583 user groups in upcoming events (#288)
2a5efd583 is described below

commit 2a5efd5832d303f0e20295d73470d5a1f138c4d7
Author: dahn 
AuthorDate: Tue Feb 11 11:16:59 2025 +0100

user groups in upcoming events (#288)
---
 src/components/Events/index.tsx |  22 ++
 static/img/cseug-2025.png   | Bin 0 -> 1219842 bytes
 static/img/csiug-2025.png   | Bin 0 -> 286628 bytes
 3 files changed, 22 insertions(+)

diff --git a/src/components/Events/index.tsx b/src/components/Events/index.tsx
index e93b1c25a..c62023e5a 100644
--- a/src/components/Events/index.tsx
+++ b/src/components/Events/index.tsx
@@ -22,6 +22,28 @@ involved with the community.
 
 
   Upcoming Events:
+  
+
+  
+  CloudStack European User Group 
2025
+  Vienna, Austria
+  May 8th, 2025
+
+
+  https://www.eventbrite.com/e/cloudstack-european-user-group-2025-vienna-austria-tickets-1217321664869?aff=oddtdtcreator";
 className="btn btn-primary me-3">Register
+  Read More
+
+  
+  
+
+  
+  CloudStack Indian User Group 
2025
+  TBD, India
+  TBD
+
+
+
+  
 
 
 
diff --git a/static/img/cseug-2025.png b/static/img/cseug-2025.png
new file mode 100644
index 0..865fb0dda
Binary files /dev/null and b/static/img/cseug-2025.png differ
diff --git a/static/img/csiug-2025.png b/static/img/csiug-2025.png
new file mode 100644
index 0..f6cc09c7b
Binary files /dev/null and b/static/img/csiug-2025.png differ



(cloudstack-www) branch main updated (111560cee -> 2a5efd583)

2025-02-11 Thread dahn
This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


from 111560cee location location location (#287)
 add 2a5efd583 user groups in upcoming events (#288)

No new revisions were added by this update.

Summary of changes:
 src/components/Events/index.tsx|  22 +
 .../Banner.png => static/img/cseug-2025.png| Bin
 static/img/csiug-2025.png  | Bin 0 -> 286628 bytes
 3 files changed, 22 insertions(+)
 copy blog/2025-01-27-cseug2025/Banner.png => static/img/cseug-2025.png (100%)
 create mode 100644 static/img/csiug-2025.png



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2650222597

   @tomorrrow666 
   have you restarted the cloudstack-management service ?
   please upload the new logs after restarting
   
   can you set it to a valid address on your server ?
   if you are not sure, you can test with `127.0.0.1` which normally works
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on code in PR #10364:
URL: https://github.com/apache/cloudstack/pull/10364#discussion_r1950496622


##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java:
##
@@ -160,6 +157,69 @@ public AsyncCallFuture 
migrateData(DataObject srcDataObject, D
 return future;
 }
 
+/**
+ * Returns a boolean indicating whether a template is ready on the 
provided data store. If the template is being downloaded,
+ * waits until the download finishes.
+ * @param srcDataObject the template.
+ * @param destDatastore the data store.
+ */
+protected boolean templateIsOnDestination(DataObject srcDataObject, 
DataStore destDatastore) {
+if (!(srcDataObject instanceof TemplateInfo)) {
+return false;
+}
+
+String templateAsString = srcDataObject.getTO().toString();
+String destDatastoreAsString = destDatastore.getTO().toString();
+TemplateDataStoreVO templateStoreVO;
+
+long timer = getTemplateDownloadTimeoutInSeconds();
+int secondsToSleep = 10;
+int previousDownloadPercentage = -1;
+
+while (true) {
+templateStoreVO = 
templateStoreDao.findByStoreTemplate(destDatastore.getId(), 
srcDataObject.getId());
+if (templateStoreVO == null) {
+logger.debug("{} is not present at destination [{}].", 
templateAsString, destDatastoreAsString);
+return false;
+}
+VMTemplateStorageResourceAssoc.Status downloadState = 
templateStoreVO.getDownloadState();
+if (downloadState == null || 
!VMTemplateStorageResourceAssoc.PENDING_DOWNLOAD_STATES.contains(downloadState))
 {
+break;
+}
+if (previousDownloadPercentage == 
templateStoreVO.getDownloadPercent()) {
+timer -= secondsToSleep;
+} else {
+timer = getTemplateDownloadTimeoutInSeconds();
+}
+if (timer <= 0) {
+throw new CloudRuntimeException(String.format("Timeout while 
waiting for %s to be downloaded to image store [%s]. " +
+"The download percentage has not changed for %d 
seconds.", templateAsString, destDatastoreAsString, 
getTemplateDownloadTimeoutInSeconds()));
+}
+waitForTemplateDownload(secondsToSleep, templateAsString, 
destDatastoreAsString);
+}
+
+if (templateStoreVO.getState() == 
ObjectInDataStoreStateMachine.State.Ready) {
+logger.debug("{} already exists on destination [{}].", 
templateAsString, destDatastoreAsString);
+return true;
+}
+return false;
+}
+
+protected long getTemplateDownloadTimeoutInSeconds() {
+return 1800L;
+}

Review Comment:
   hard-coded in a method? better either a setting or a static final.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19 fix saml account selector [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2650060846

   @rg9975 there is a  unit test failure. Can you look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added project id to kubeadmin user for Kubernetes service [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on code in PR #10362:
URL: https://github.com/apache/cloudstack/pull/10362#discussion_r1950395119


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1384,7 +1384,15 @@ private String[] getServiceUserKeys(KubernetesClusterVO 
kubernetesCluster) {
 if (owner == null || owner.getType() == Account.Type.PROJECT) {
 owner = CallContext.current().getCallingAccount();
 }
-String username = owner.getAccountName() + "-" + 
KUBEADMIN_ACCOUNT_NAME;
+
+String projectId = "default";
+Account account = 
ApiDBUtils.findAccountById(kubernetesCluster.getAccountId());
+Project project = 
ApiDBUtils.findProjectByProjectAccountId(account.getId());
+if ( project != null ) {
+  projectId = project.getUuid();
+}
+
+String username = owner.getAccountName() + "-" + projectId + "-" + 
KUBEADMIN_ACCOUNT_NAME;

Review Comment:
   does this mean accounts cannot have a kubernetes instance without being part 
of a project? I would expect something like 
   ```suggestion
   String projectId = null;
   Account account = 
ApiDBUtils.findAccountById(kubernetesCluster.getAccountId());
   Project project = 
ApiDBUtils.findProjectByProjectAccountId(account.getId());
   if ( project != null ) {
 projectId = project.getUuid();
   }
   
   String username = owner.getAccountName() + (projectId == null ? : "" 
: "-" + projectId) + "-" + KUBEADMIN_ACCOUNT_NAME;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] server: fix npe during start vr edge case [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10366:
URL: https://github.com/apache/cloudstack/pull/10366#issuecomment-2650079972

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12407


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Added project id to kubeadmin user for Kubernetes service [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on code in PR #10362:
URL: https://github.com/apache/cloudstack/pull/10362#discussion_r1950411416


##
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##
@@ -1384,7 +1384,15 @@ private String[] getServiceUserKeys(KubernetesClusterVO 
kubernetesCluster) {
 if (owner == null || owner.getType() == Account.Type.PROJECT) {
 owner = CallContext.current().getCallingAccount();
 }
-String username = owner.getAccountName() + "-" + 
KUBEADMIN_ACCOUNT_NAME;

Review Comment:
   @parkinr 
   can you explain more ?
   - without this PR, what's the username ?
   - with this PR, what's the username ?
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


tomorrrow666 commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2650184193

   idrl@management1:~$ sudo grep -i -E 'error|exception' 
/var/log/cloudstack/management/management-server.log
   [sudo] idrl 的密码: 
   2025-02-06 08:09:25,526 ERROR [c.c.u.d.Merovingian2] (main:null) (logid:) 
Unable to get a new db connection
   java.sql.SQLNonTransientConnectionException: Could not create connection to 
database server. Attempted reconnect 3 times. Giving up.
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:110)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
   at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
   at 
com.cloud.utils.db.TransactionLegacy.getStandaloneConnectionWithException(TransactionLegacy.java:211)
   Caused by: com.mysql.cj.exceptions.CJCommunicationsException: Communications 
link failure
   Caused by: java.net.ConnectException: 连接被拒绝 (Connection refused)
   2025-02-06 08:30:19,518 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE TABLE `cloud`.`s3` (   `id` bigint unsigned NOT NULL AUTO_INCREMENT 
COMMENT 'id',   `uuid` varchar(40),   `access_key` varchar(20) NOT NULL COMMENT 
' The S3 access key',   `secret_key` varchar(40) NOT NULL COMMENT ' The S3 
secret key',   `end_point` varchar(1024) COMMENT ' The S3 host',   `bucket` 
varchar(63) NOT NULL COMMENT ' The S3 host',   `https` tinyint unsigned DEFAULT 
NULL COMMENT ' Flag indicating whether or not to connect over HTTPS',   
`connection_timeout` integer COMMENT ' The amount of time to wait (in 
milliseconds) when initially establishing a connection before giving up and 
timing out.',   `max_error_retry` integer  COMMENT ' The maximum number of 
retry attempts for failed retryable requests (ex: 5xx error responses from 
services).',   `socket_timeout` integer COMMENT ' The amount of time to wait 
(in milliseconds) for data to be transferred over an established, open 
connection before t
 he connection times out and is closed.',   `created` datetime COMMENT 'date 
the s3 first signed on',   PRIMARY KEY (`id`),   CONSTRAINT `uc_s3__uuid` 
UNIQUE (`uuid`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8 
   2025-02-06 08:30:21,380 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) 
CREATE VIEW `cloud`.`volume_view` AS select  volumes.id, 
volumes.uuid, volumes.name, volumes.device_id, 
volumes.volume_type, volumes.size, volumes.created, 
volumes.state, volumes.attached, volumes.removed, 
volumes.pod_id, account.id account_id, account.uuid 
account_uuid, account.account_name account_name, account.type 
account_type, domain.id domain_id, domain.uuid domain_uuid, 
domain.name domain_name, domain.path domain_path, 
projects.id project_id, projects.uuid project_uuid, 
projects.name project_name, data_center.id data_center_id, 
data_center.uuid data_center_uuid, data_center.name data_center_name,   
  vm_instance.id vm_id, vm_instance.uuid vm_uuid, 
vm_instance.name vm_name, 
 vm_instance.state vm_state, vm_instance.vm_type, 
user_vm.display_name vm_display_name, volume_host_ref.size 
volume_host_size, volume_host_ref.created volume_host_created, 
volume_host_ref.format, volume_host_ref.download_pct, 
volume_host_ref.download_state, volume_host_ref.error_str, 
disk_offering.id disk_offering_id, disk_offering.uuid 
disk_offering_uuid, disk_offering.name disk_offering_name, 
disk_offering.display_text disk_offering_display_text, 
disk_offering.use_local_storage, disk_offering.system_use, 
storage_pool.id pool_id, storage_pool.uuid pool_uuid, 
storage_pool.name pool_name, cluster.hypervisor_type, 
vm_template.id template_id, vm_template.uuid template_uuid, 
vm_template.extractable, vm_template.type template_type, 
resource_tags.id tag_id, resource_tags.uuid tag_uuid, resourc
 e_tags.key tag_key, resource_tags.value tag_value, 
resource_tags.domain_id tag_domain_id, resource_tags.account_id 
tag_account_id, resource_tags.resource_id tag_resource_id, 
resource_tags.resource_uuid tag_resource_uuid, 
resource_tags.resource_type tag_resource_type, resource_tags.customer 
tag_customer, async_job.id job_id, async_job.uuid job_uuid, 
async_job.job_status job_status, async_job.account_id 
job_account_id fro

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9315:
URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2650206569

   [SF] Trillian test result (tid-12365)
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 46137 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12365-kvm-ol8.zip
   Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_redundant_vpc_site2site_vpn | `Failure` | 412.55 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] XCP-ng Management network on VLAN [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 commented on issue #10272:
URL: https://github.com/apache/cloudstack/issues/10272#issuecomment-2650730109

   Seems similar to: https://github.com/apache/cloudstack/issues/4286 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bnr resource limits [cloudstack]

2025-02-11 Thread via GitHub


rohityadavcloud commented on PR #9765:
URL: https://github.com/apache/cloudstack/pull/9765#issuecomment-2650891417

   @Pearl1594 @abh1sar @rajujith can your review and advise if the other PR has 
already addressed this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650939885

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12408


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


DaanHoogland commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2650954885

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2651242977

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9315:
URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2651119417

   [SF] Trillian test result (tid-12367)
   Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 68109 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9315-t12367-vmware-70u3.zip
   Smoke tests completed. 128 look OK, 5 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 320.11 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Error` | 110.40 | 
test_network_permissions.py
   test_01_restore_vm | `Error` | 3613.49 | test_restore_vm.py
   test_02_restore_vm_allocated_root | `Error` | 7.81 | test_restore_vm.py
   test_01_deploy_vm_on_specific_host | `Error` | 19.87 | 
test_vm_deployment_planner.py
   test_02_deploy_vm_on_specific_cluster | `Error` | 3602.57 | 
test_vm_deployment_planner.py
   test_03_deploy_vm_on_specific_pod | `Error` | 2.39 | 
test_vm_deployment_planner.py
   test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 2.40 | 
test_vm_deployment_planner.py
   test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.34 | 
test_vm_deployment_planner.py
   test_09_expunge_vm | `Failure` | 424.63 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch enable-multiple-svc-configdrive created (now c385454d39a)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch enable-multiple-svc-configdrive
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


  at c385454d39a Enable multiple services on configdrive network service 
provider

This branch includes the following new commits:

 new c385454d39a Enable multiple services on configdrive network service 
provider

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.




(cloudstack) 01/01: Enable multiple services on configdrive network service provider

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a commit to branch enable-multiple-svc-configdrive
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit c385454d39af2587c3687d5465f7b4d965571042
Author: Pearl Dsilva 
AuthorDate: Tue Feb 11 13:25:41 2025 -0500

Enable multiple services on configdrive network service provider
---
 .../main/java/com/cloud/network/element/ConfigDriveNetworkElement.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java 
b/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
index 6ef84a04b9f..8dec7a913a5 100644
--- 
a/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
+++ 
b/server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
@@ -220,7 +220,7 @@ public class ConfigDriveNetworkElement extends AdapterBase 
implements NetworkEle
 
 @Override
 public boolean canEnableIndividualServices() {
-return false;
+return true;
 }
 
 private String getSshKey(VirtualMachineProfile profile) {



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


tomorrrow666 commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2652337359

   
[management-server.log](https://github.com/user-attachments/files/18760121/management-server.log)
   
   the latest log


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]

2025-02-11 Thread via GitHub


winterhazel commented on code in PR #10364:
URL: https://github.com/apache/cloudstack/pull/10364#discussion_r1951828167


##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java:
##
@@ -160,6 +157,69 @@ public AsyncCallFuture 
migrateData(DataObject srcDataObject, D
 return future;
 }
 
+/**
+ * Returns a boolean indicating whether a template is ready on the 
provided data store. If the template is being downloaded,
+ * waits until the download finishes.
+ * @param srcDataObject the template.
+ * @param destDatastore the data store.
+ */
+protected boolean templateIsOnDestination(DataObject srcDataObject, 
DataStore destDatastore) {
+if (!(srcDataObject instanceof TemplateInfo)) {
+return false;
+}
+
+String templateAsString = srcDataObject.getTO().toString();
+String destDatastoreAsString = destDatastore.getTO().toString();
+TemplateDataStoreVO templateStoreVO;
+
+long timer = getTemplateDownloadTimeoutInSeconds();
+int secondsToSleep = 10;
+int previousDownloadPercentage = -1;
+
+while (true) {
+templateStoreVO = 
templateStoreDao.findByStoreTemplate(destDatastore.getId(), 
srcDataObject.getId());
+if (templateStoreVO == null) {
+logger.debug("{} is not present at destination [{}].", 
templateAsString, destDatastoreAsString);
+return false;
+}
+VMTemplateStorageResourceAssoc.Status downloadState = 
templateStoreVO.getDownloadState();
+if (downloadState == null || 
!VMTemplateStorageResourceAssoc.PENDING_DOWNLOAD_STATES.contains(downloadState))
 {
+break;
+}
+if (previousDownloadPercentage == 
templateStoreVO.getDownloadPercent()) {
+timer -= secondsToSleep;
+} else {
+timer = getTemplateDownloadTimeoutInSeconds();
+}
+if (timer <= 0) {
+throw new CloudRuntimeException(String.format("Timeout while 
waiting for %s to be downloaded to image store [%s]. " +
+"The download percentage has not changed for %d 
seconds.", templateAsString, destDatastoreAsString, 
getTemplateDownloadTimeoutInSeconds()));
+}
+waitForTemplateDownload(secondsToSleep, templateAsString, 
destDatastoreAsString);
+}
+
+if (templateStoreVO.getState() == 
ObjectInDataStoreStateMachine.State.Ready) {
+logger.debug("{} already exists on destination [{}].", 
templateAsString, destDatastoreAsString);
+return true;
+}
+return false;
+}
+
+protected long getTemplateDownloadTimeoutInSeconds() {
+return 1800L;
+}

Review Comment:
   The actual template download timeout is also hard-coded in a method 
(`com.cloud.storage.download.DownloadActiveState#handleTimeout`). I'm planning 
on making this timeout configurable in a separate PR, so for this one I'll just 
adjust so that they match the same value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Migrate public templates that have URLs on data migration across secondary storages [cloudstack]

2025-02-11 Thread via GitHub


winterhazel commented on code in PR #10364:
URL: https://github.com/apache/cloudstack/pull/10364#discussion_r1951828167


##
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/SecondaryStorageServiceImpl.java:
##
@@ -160,6 +157,69 @@ public AsyncCallFuture 
migrateData(DataObject srcDataObject, D
 return future;
 }
 
+/**
+ * Returns a boolean indicating whether a template is ready on the 
provided data store. If the template is being downloaded,
+ * waits until the download finishes.
+ * @param srcDataObject the template.
+ * @param destDatastore the data store.
+ */
+protected boolean templateIsOnDestination(DataObject srcDataObject, 
DataStore destDatastore) {
+if (!(srcDataObject instanceof TemplateInfo)) {
+return false;
+}
+
+String templateAsString = srcDataObject.getTO().toString();
+String destDatastoreAsString = destDatastore.getTO().toString();
+TemplateDataStoreVO templateStoreVO;
+
+long timer = getTemplateDownloadTimeoutInSeconds();
+int secondsToSleep = 10;
+int previousDownloadPercentage = -1;
+
+while (true) {
+templateStoreVO = 
templateStoreDao.findByStoreTemplate(destDatastore.getId(), 
srcDataObject.getId());
+if (templateStoreVO == null) {
+logger.debug("{} is not present at destination [{}].", 
templateAsString, destDatastoreAsString);
+return false;
+}
+VMTemplateStorageResourceAssoc.Status downloadState = 
templateStoreVO.getDownloadState();
+if (downloadState == null || 
!VMTemplateStorageResourceAssoc.PENDING_DOWNLOAD_STATES.contains(downloadState))
 {
+break;
+}
+if (previousDownloadPercentage == 
templateStoreVO.getDownloadPercent()) {
+timer -= secondsToSleep;
+} else {
+timer = getTemplateDownloadTimeoutInSeconds();
+}
+if (timer <= 0) {
+throw new CloudRuntimeException(String.format("Timeout while 
waiting for %s to be downloaded to image store [%s]. " +
+"The download percentage has not changed for %d 
seconds.", templateAsString, destDatastoreAsString, 
getTemplateDownloadTimeoutInSeconds()));
+}
+waitForTemplateDownload(secondsToSleep, templateAsString, 
destDatastoreAsString);
+}
+
+if (templateStoreVO.getState() == 
ObjectInDataStoreStateMachine.State.Ready) {
+logger.debug("{} already exists on destination [{}].", 
templateAsString, destDatastoreAsString);
+return true;
+}
+return false;
+}
+
+protected long getTemplateDownloadTimeoutInSeconds() {
+return 1800L;
+}

Review Comment:
   The actual template download timeout is also hard-coded in a method 
(`com.cloud.storage.download.DownloadActiveState#handleTimeout`). I'm planning 
on making this timeout configurable in a separate PR, so for this one I'll just 
adjust so that they match the same value by using the static value instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] List only those hosts matching source host arch in multi-arch zones [cloudstack]

2025-02-11 Thread via GitHub


sonarqubecloud[bot] commented on PR #10369:
URL: https://github.com/apache/cloudstack/pull/10369#issuecomment-2652728274

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10369)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10369&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10369&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10369&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10369&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10369&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10369)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fix NPE during kubernetes cluster creation when network has rules with ports saved as null on DB [cloudstack]

2025-02-11 Thread via GitHub


kiranchavala commented on PR #9223:
URL: https://github.com/apache/cloudstack/pull/9223#issuecomment-2652732398

   Thanks @winterhazel 
   
   
   @DaanHoogland  this can be merged, I will create separate enhancement 
requests  for the issues reported


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


sureshanaparti commented on PR #10006:
URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2652731172

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10006:
URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2652733117

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] custom AccessLogger [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #9733:
URL: https://github.com/apache/cloudstack/pull/9733#issuecomment-2652735337

   [SF] Trillian test result (tid-12375)
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 53233 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9733-t12375-kvm-ol8.zip
   Smoke tests completed. 132 look OK, 2 have errors, 7 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.26 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.39 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.39 | 
test_ipv4_routing.py
   test_12_start_vm_multiple_volumes_allocated | `Error` | 14.89 | 
test_vm_life_cycle.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
   all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10006:
URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2652825124

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] List only those hosts matching source host arch in multi-arch zones [cloudstack]

2025-02-11 Thread via GitHub


nvazquez commented on code in PR #10369:
URL: https://github.com/apache/cloudstack/pull/10369#discussion_r1951947156


##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -1612,6 +1614,13 @@ public Ternary, Integer>, 
List, Map clusterArchs = 
ApiDBUtils.listZoneClustersArchs(vm.getDataCenterId());
+if (CollectionUtils.isNotEmpty(clusterArchs) && clusterArchs.size() > 
1) {
+CPU.CPUArch hostArch = srcHost.getArch();

Review Comment:
   Can we remove this line and compare directly on the line below without 
defining the variable?



##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -44,6 +44,8 @@
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import com.cloud.cpu.CPU;
+import com.cloud.utils.security.CertificateHelper;

Review Comment:
   I think this is imported but not used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Support multi-scope configuration settings [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10300:
URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2652626457

   [SF] Trillian test result (tid-12370)
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 57252 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10300-t12370-kvm-ol8.zip
   Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.26 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.35 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.36 | 
test_ipv4_routing.py
   test_12_start_vm_multiple_volumes_allocated | `Error` | 14.86 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



(cloudstack) branch list-only-src-arch-hosts updated (0ba42ce1a63 -> f6324286f07)

2025-02-11 Thread pearl11594
This is an automated email from the ASF dual-hosted git repository.

pearl11594 pushed a change to branch list-only-src-arch-hosts
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


from 0ba42ce1a63 List only those hosts matching source host arch in 
multi-arch zones
 add f6324286f07 remove duplicate import due to merge conflict

No new revisions were added by this update.

Summary of changes:
 server/src/main/java/com/cloud/server/ManagementServerImpl.java | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)



Re: [PR] Enable multiple services on configdrive network service provider [cloudstack]

2025-02-11 Thread via GitHub


sonarqubecloud[bot] commented on PR #10372:
URL: https://github.com/apache/cloudstack/pull/10372#issuecomment-2651876570

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10372)
 **Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10372&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=10372&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=10372&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10372&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=10372&metric=new_duplicated_lines_density&view=list)
  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=10372)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Bnr resource limits [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 closed pull request #9765: Bnr resource limits
URL: https://github.com/apache/cloudstack/pull/9765


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Enable multiple services on configdrive network service provider [cloudstack]

2025-02-11 Thread via GitHub


Pearl1594 opened a new pull request, #10372:
URL: https://github.com/apache/cloudstack/pull/10372

   ### Description
   
   This PR fixes: https://github.com/apache/cloudstack/issues/10296
   Historically, Configdrive only allowed a single service to be provided - 
namely, userdata. However, it can be used to provide DHCP and dns service as 
well.
   
   after fix:
   ```
   (localcloud) 🐱 > update networkserviceprovider 
id=1f32db86-e7a8-4b38-af32-387049438db9 servicelist=userdata,dns,dhcp
   {
 "networkserviceprovider": {
   "canenableindividualservice": true,
   "id": "1f32db86-e7a8-4b38-af32-387049438db9",
   "name": "ConfigDrive",
   "physicalnetworkid": "5e575189-779f-416b-843a-625e813119b6",
   "servicelist": [
 "Dhcp",
 "Dns",
 "UserData"
   ],
   "state": "Enabled"
 }
   }
   
   
   
   (localcloud) 🐱 > list networkserviceproviders name=Configdrive
   {
 "count": 2,
 "networkserviceprovider": [
   {
 "canenableindividualservice": true,
 "id": "1f32db86-e7a8-4b38-af32-387049438db9",
 "name": "ConfigDrive",
 "physicalnetworkid": "5e575189-779f-416b-843a-625e813119b6",
 "servicelist": [
   "Dhcp",
   "Dns",
   "UserData"
 ],
 "state": "Enabled"
   },
   {
 "canenableindividualservice": true,
 "id": "2150b514-4b83-45d5-9ac9-a8feafe10b8e",
 "name": "ConfigDrive",
 "physicalnetworkid": "aad89f31-82ad-4ec3-86c8-bd4abc823605",
 "servicelist": [
   "UserData"
 ],
 "state": "Enabled"
   }
 ]
   }
   
   ```
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Enable multiple services on configdrive network service provider [cloudstack]

2025-02-11 Thread via GitHub


codecov[bot] commented on PR #10372:
URL: https://github.com/apache/cloudstack/pull/10372#issuecomment-2651693761

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10372?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.01%. Comparing base 
[(`5aa79a6`)](https://app.codecov.io/gh/apache/cloudstack/commit/5aa79a6e05d04440587ab26da70c1b3fae6e3a20?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`c385454`)](https://app.codecov.io/gh/apache/cloudstack/commit/c385454d39af2587c3687d5465f7b4d965571042?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   > :exclamation:  There is a different number of reports uploaded between 
BASE (5aa79a6) and HEAD (c385454). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (5aa79a6) | HEAD (c385454) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   4.20   #10372   +/-   ##
   =
   - Coverage 15.99%4.01%   -11.99% 
   =
 Files  5644  394 -5250 
 Lines49491532399   -462516 
 Branches  59960 5738-54222 
   =
   - Hits  79173 1301-77872 
   + Misses   40691030949   -375961 
   + Partials   8832  149 -8683 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10372/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.01% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10372/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10372?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: Fix all list items appearing twice in search view [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10365:
URL: https://github.com/apache/cloudstack/pull/10365#issuecomment-2652142049

   Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12416


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] 4.19 fix saml account selector [cloudstack]

2025-02-11 Thread via GitHub


rg9975 commented on PR #10311:
URL: https://github.com/apache/cloudstack/pull/10311#issuecomment-2652149503

   Aware of test case failure, working on resolution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Validate the direct downloaded template file format (QCOW2) if the template file exists [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10332:
URL: https://github.com/apache/cloudstack/pull/10332#issuecomment-2652246524

   [SF] Trillian test result (tid-12369)
   Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 62950 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10332-t12369-kvm-ol8.zip
   Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.25 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.37 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 2.37 | 
test_ipv4_routing.py
   test_06_purge_expunged_vm_background_task | `Failure` | 388.54 | 
test_purge_expunged_vms.py
   test_12_start_vm_multiple_volumes_allocated | `Error` | 13.09 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Add API command remove management server [cloudstack]

2025-02-11 Thread via GitHub


bernardodemarco commented on code in PR #10325:
URL: https://github.com/apache/cloudstack/pull/10325#discussion_r1951742648


##
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##
@@ -5493,4 +5500,24 @@ public void setLockControllerListener(final 
LockControllerListener lockControlle
 _lockControllerListener = lockControllerListener;
 }
 
+@Override
+@DB
+@ActionEvent(eventType = EventTypes.EVENT_MANAGEMENT_SERVER_REMOVE, 
eventDescription = "removing Management Server")
+public boolean removeManagementServer(RemoveManagementServerCmd cmd) {
+final Long id = cmd.getId();
+ManagementServerJoinVO managementServer = 
managementServerJoinDao.findById(id);
+
+if (managementServer == null) {
+throw new InvalidParameterValueException(String.format("Unable to 
find a Management Server with ID equal to [%s]", managementServer.getUuid()));
+}
+
+if 
(!ManagementServerHost.State.Down.equals(managementServer.getState())) {
+throw new InvalidParameterValueException(String.format("Unable to 
remove Management Server with ID [%s]. It can only be removed when it is in the 
[%s] state, however currently it is in the [%s] state", 
managementServer.getUuid(), ManagementServerHost.State.Down.name(), 
ManagementServerHost.State.Up.name()));
+}

Review Comment:
   ```suggestion
   if 
(!ManagementServerHost.State.Down.equals(managementServer.getState())) {
   throw new InvalidParameterValueException(String.format("Unable 
to remove Management Server with ID [%s]. It can only be removed when it is in 
the [%s] state, however currently it is in the [%s] state", 
managementServer.getUuid(), ManagementServerHost.State.Down.name(), 
managementServer.getState().name()));
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] UI: Fix Apache CloudStack description on the onboarding page [cloudstack]

2025-02-11 Thread via GitHub


bernardodemarco opened a new pull request, #10373:
URL: https://github.com/apache/cloudstack/pull/10373

   ### Description
   
   Currently, the Apache CloudStack description on the onboarding page states 
that:
   
   ```
   Both open-source and Premium versions are available, with the open-source 
version offering nearly identical features
   ```
   
   This PR removes this outdated sentence.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [X] Trivial


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] UI: Fix Apache CloudStack description on the onboarding page [cloudstack]

2025-02-11 Thread via GitHub


codecov[bot] commented on PR #10373:
URL: https://github.com/apache/cloudstack/pull/10373#issuecomment-2652382984

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10373?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.29%. Comparing base 
[(`ae1d7cc`)](https://app.codecov.io/gh/apache/cloudstack/commit/ae1d7cc86091ce1612dba9981c01d63544c5c426?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 to head 
[(`1ba7d33`)](https://app.codecov.io/gh/apache/cloudstack/commit/1ba7d33a73fc587339a7a96eb796a47a0eb9c796?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   > :exclamation:  There is a different number of reports uploaded between 
BASE (ae1d7cc) and HEAD (1ba7d33). Click for more details.
   > 
   > HEAD has 1 upload less than BASE
   >
   >| Flag | BASE (ae1d7cc) | HEAD (1ba7d33) |
   >|--|--|--|
   >|unittests|1|0|
   >
   
   Additional details and impacted files
   
   
   ```diff
   @@  Coverage Diff  @@
   ##   4.19   #10373   +/-   ##
   =
   - Coverage 15.15%4.29%   -10.87% 
   =
 Files  5413  367 -5046 
 Lines47467029627   -445043 
 Branches  57890 5199-52691 
   =
   - Hits  71943 1272-70671 
   + Misses   39468028210   -366470 
   + Partials   8047  145 -7902 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10373/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `4.29% <ø> (ø)` | |
   | 
[unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10373/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10373?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Support multi-scope configuration settings [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10300:
URL: https://github.com/apache/cloudstack/pull/10300#issuecomment-2652872599

   [SF] Trillian test result (tid-12372)
   Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
   Total time taken: 68883 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10300-t12372-vmware-70u3.zip
   Smoke tests completed. 135 look OK, 6 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_11_isolated_network_with_dynamic_routed_mode | `Error` | 2.27 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.38 | 
test_ipv4_routing.py
   test_12_vpc_and_tier_with_dynamic_routed_mode | `Error` | 3.39 | 
test_ipv4_routing.py
   test_deploy_more_vms_than_limit_allows | `Error` | 170.78 | 
test_deploy_vms_in_parallel.py
   test_01_prepare_and_cancel_maintenance | `Error` | 0.11 | 
test_ms_maintenance_and_safe_shutdown.py
   test_01_deployVMInSharedNetwork | `Failure` | 1807.94 | test_network.py
   ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown | `Error` | 
1808.10 | test_network.py
   test_02_restore_vm_with_disk_offering | `Error` | 62.21 | test_restore_vm.py
   test_03_restore_vm_with_disk_offering_custom_size | `Error` | 60.13 | 
test_restore_vm.py
   test_12_start_vm_multiple_volumes_allocated | `Error` | 17.01 | 
test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] Cloudstack 4.18 HTTP 503 错误 (MySQL 8.0) [cloudstack]

2025-02-11 Thread via GitHub


weizhouapache commented on issue #10350:
URL: https://github.com/apache/cloudstack/issues/10350#issuecomment-2652891410

   it looks like db.properties file cannot be loaded.
   
   @tomorrrow666 
   if this is a fresh installation, I suggest you set up the database again.
   you can specify the management server ip with `-i`
   ```
 -i MSHOSTIP, --mshost=MSHOSTIP
   Cluster management server host IP. A string, by
   default it will try to detect a local IP
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


blueorangutan commented on PR #10006:
URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2652892809

   @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [HEALTH] 4.20 Health Check, please don't merge this! [cloudstack]

2025-02-11 Thread via GitHub


sureshanaparti commented on PR #10006:
URL: https://github.com/apache/cloudstack/pull/10006#issuecomment-2652890389

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org