Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
blueorangutan commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562149132 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
vishesh92 commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562148246 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
vishesh92 commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2562201247 @blueorangutan LLtest rocky8 kvm-rocky8 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
blueorangutan commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2562201786 @vishesh92 a [LL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
blueorangutan commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2562200474 @vishesh92 [LL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections [cloudstack]
blueorangutan commented on PR #9903: URL: https://github.com/apache/cloudstack/pull/9903#issuecomment-2562199291 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
blueorangutan commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562184142 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
vishesh92 commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562182868 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections [cloudstack]
sureshanaparti commented on PR #9903: URL: https://github.com/apache/cloudstack/pull/9903#issuecomment-2562198091 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve logging to include more identifiable information [cloudstack]
vishesh92 commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2562199159 @blueorangutan LLtest ol8 kvm-ol8 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections [cloudstack]
blueorangutan commented on PR #9903: URL: https://github.com/apache/cloudstack/pull/9903#issuecomment-2562249666 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: fix `.cs` files with the `trailing-whitespace` hook [cloudstack]
vishesh92 commented on PR #9794: URL: https://github.com/apache/cloudstack/pull/9794#issuecomment-2562258500 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
blueorangutan commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562221608 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Rename ambiguous global setting: enable.kvm.host.auto.enable.disable [cloudstack]
shwstppr commented on code in PR #10042: URL: https://github.com/apache/cloudstack/pull/10042#discussion_r1897689732 ## ui/src/views/infra/HostEnableDisable.vue: ## @@ -31,7 +31,7 @@ Review Comment: ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: fix `.cs` files with the `trailing-whitespace` hook [cloudstack]
blueorangutan commented on PR #9794: URL: https://github.com/apache/cloudstack/pull/9794#issuecomment-2562260406 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: remove trailing-whitespace from more file types [cloudstack]
blueorangutan commented on PR #10131: URL: https://github.com/apache/cloudstack/pull/10131#issuecomment-2561716324 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable markdownlint rule `MD012` [cloudstack]
blueorangutan commented on PR #9364: URL: https://github.com/apache/cloudstack/pull/9364#issuecomment-2561719975 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] pre-commit: enable `markdownlint` rule `MD018` [cloudstack]
blueorangutan commented on PR #9134: URL: https://github.com/apache/cloudstack/pull/9134#issuecomment-2561737903 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
vishesh92 commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562153926 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
blueorangutan commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562154753 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removal of UI blockage to access the `changeOfferingForVolume` API [cloudstack]
shwstppr commented on PR #10135: URL: https://github.com/apache/cloudstack/pull/10135#issuecomment-2562165669 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removal of UI blockage to access the `changeOfferingForVolume` API [cloudstack]
shwstppr commented on code in PR #10135:
URL: https://github.com/apache/cloudstack/pull/10135#discussion_r1897637528
##
ui/src/config/section/storage.js:
##
@@ -223,7 +223,7 @@ export default {
label: 'label.change.offering.for.volume',
args: ['id', 'diskofferingid', 'size', 'miniops', 'maxiops',
'automigrate'],
dataView: true,
- show: (record, store) => { return ['Allocated',
'Ready'].includes(record.state) && ['Admin'].includes(store.userInfo.roletype)
},
+ show: (record, store) => { return ['Allocated',
'Ready'].includes(record.state) && (['Admin'].includes(store.userInfo.roletype)
|| !!store.apis.changeOfferingForVolume) },
Review Comment:
Should we remove the roletype check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Removal of UI blockage to access the `changeOfferingForVolume` API [cloudstack]
blueorangutan commented on PR #10135: URL: https://github.com/apache/cloudstack/pull/10135#issuecomment-2562165922 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removal of UI blockage to access the `changeOfferingForVolume` API [cloudstack]
codecov[bot] commented on PR #10135: URL: https://github.com/apache/cloudstack/pull/10135#issuecomment-2562169474 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10135?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.01%. Comparing base [(`0b2952c`)](https://app.codecov.io/gh/apache/cloudstack/commit/0b2952ca43f67bb2bbf7ddd4e850b1bb5c79a763?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`13078a7`)](https://app.codecov.io/gh/apache/cloudstack/commit/13078a7e56af1f1514306df00ece5e0c6aad4821?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 1 commits behind head on main. > :exclamation: There is a different number of reports uploaded between BASE (0b2952c) and HEAD (13078a7). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (0b2952c) | HEAD (13078a7) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10135 +/- ## = - Coverage 16.06%4.01% -12.05% = Files 5642 394 -5248 Lines49397332406 -461567 Branches 59895 5725-54170 = - Hits 79351 1301-78050 + Misses 40583730957 -374880 + Partials 8785 148 -8637 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10135/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.01% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10135/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10135?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Removal of UI blockage to access the `changeOfferingForVolume` API [cloudstack]
blueorangutan commented on PR #10135: URL: https://github.com/apache/cloudstack/pull/10135#issuecomment-2562175550 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-504) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to attach Ceph as primary storage [cloudstack]
li-liwen commented on issue #8405: URL: https://github.com/apache/cloudstack/issues/8405#issuecomment-2562061705 Glad that I could help! In addition to the official tutorial on CloudStack website, I was also following the tutorial on Ceph website. For example: https://docs.ceph.com/en/latest/rbd/rbd-cloudstack/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] check tags while fetching storage pool for importing vm [cloudstack]
blueorangutan commented on PR #9764: URL: https://github.com/apache/cloudstack/pull/9764#issuecomment-2562175426 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
