[PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]
FelipeM525 opened a new pull request, #9725:
URL: https://github.com/apache/cloudstack/pull/9725
### Description
This PR restricts users from migrating volumes attached to VMs that are in
starting state. Migrating volumes while their VMs are starting shouldn't be
allowed because sometimes the VM could end up not actually starting, and if ACS
starts migrating its volume, this could lead to other issues.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Image
### How Has This Been Tested?
I tested this PR by deploying an instance and then trying to migrate its
volume while the instance was starting. Before the changes, the volume
migration process would start. After the migration, an error is thrown, as
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]
codecov[bot] commented on PR #9725: URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2371865443 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9725?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.76%. Comparing base [(`9df783c`)](https://app.codecov.io/gh/apache/cloudstack/commit/9df783ca4be80ac028b4df985ddc9d723e024171?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e263fe5`)](https://app.codecov.io/gh/apache/cloudstack/commit/e263fe5126b705994963fc62f28f7b1209eb537d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 4 commits behind head on 4.19. > :exclamation: There is a different number of reports uploaded between BASE (9df783c) and HEAD (e263fe5). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (9df783c) | HEAD (e263fe5) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9725 +/- ## - Coverage 15.11% 4.76% -10.35% Files 5402 366 -5036 Lines473120 29528 -443592 Branches 583275168-53159 - Hits 715071408-70099 + Misses 393812 28114 -365698 + Partials 7801 6 -7795 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9725/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9725/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.76% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9725/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9725?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM console cannot access after VNC certificate expired [cloudstack]
weizhouapache commented on issue #9718: URL: https://github.com/apache/cloudstack/issues/9718#issuecomment-2370584807 > Yes , the vnc tls were enabled in all host. It seems that the qemu process that is running, does not recognize the certificate change and still uses the old certificate. Stop the startup or migrate and the new qemu process will use the new certificate. vnc_tls=1 vnc_tls_x509_verify=1 vnc_tls_x509_cert_dir="/etc/pki/libvirt-vnc" thanks @havengit good to know that migration fixes the issue. stopping/starting all vms is not possible for large production environments. To summarize, - vm console becomes unavailable if cloudstack-agent certificates expires and is renewed. - it is a qemu issue. ACS cannot do anything to fix it. - users have to migrate or stop/start the VMs so that new qemu process will use the new certificates cc @DaanHoogland @rohityadavcloud @nvazquez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM console cannot access after VNC certificate expired [cloudstack]
havengit commented on issue #9718: URL: https://github.com/apache/cloudstack/issues/9718#issuecomment-2370610757 Thanks ,weizhou and community , I have change **Ca framework cert validity period** to a very long time . I won't run into this problem in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM console cannot access after VNC certificate expired [cloudstack]
havengit closed issue #9718: VM console cannot access after VNC certificate expired URL: https://github.com/apache/cloudstack/issues/9718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
BartJM commented on code in PR #9721:
URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1773292202
##
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java:
##
@@ -22,13 +22,45 @@
import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;
import com.cloud.vm.UserVmDetailVO;
+import com.cloud.vm.VMInstanceVO;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
@Component
public class UserVmDetailsDaoImpl extends
ResourceDetailsDaoBase implements UserVmDetailsDao {
+@Inject
+protected UserVmDetailsDao _detailsDao;
+
@Override
public void addDetail(long resourceId, String key, String value, boolean
display) {
super.addDetail(new UserVmDetailVO(resourceId, key, value, display));
}
+@Override
+public void saveDetails(VMInstanceVO vm) {
+saveDetails(vm, new ArrayList());
+}
+
+@Override
+public void saveDetails(VMInstanceVO vm, List hiddenDetails) {
Review Comment:
This is a copy of the code used in UserVmManagerImpl for user vms where the
method is used. Think that could be moved to the UserVmDetailsDaoImpl too.
Would this move be wanted in this PR too? if so it is not ready. Otherwise
the PR is ready imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Shutdown expunged resources cleanup executor properly, and allow other components to configure/start/stop on error [cloudstack]
blueorangutan commented on PR #9723: URL: https://github.com/apache/cloudstack/pull/9723#issuecomment-2370837406 [SF] Trillian test result (tid-11539) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 62071 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9723-t11539-kvm-ol8.zip Smoke tests completed. 134 look OK, 2 have errors, 5 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_03_secured_to_nonsecured_vm_migration | `Error` | 375.65 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 282.02 | test_vm_life_cycle.py all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-2370855076 [SF] Trillian test result (tid-11538) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 66078 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11538-kvm-ol8.zip Smoke tests completed. 138 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_secure_vm_migration | `Error` | 135.11 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 135.12 | test_vm_life_cycle.py ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM console cannot access after VNC certificate expired [cloudstack]
havengit commented on issue #9718: URL: https://github.com/apache/cloudstack/issues/9718#issuecomment-2370459380 Yes , the vnc tls were enabled in all host. It seems that the qemu process that is running, does not recognize the certificate change and still uses the old certificate. Stop the startup or migrate and the new qemu process will use the new certificate. vnc_tls=1 vnc_tls_x509_verify=1 vnc_tls_x509_cert_dir="/etc/pki/libvirt-vnc" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: apply network ACL even if there is no network ACLs rules in the ACL list [cloudstack]
DaanHoogland merged PR #9374: URL: https://github.com/apache/cloudstack/pull/9374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch 4.19 updated: server: apply network ACL even if there is no network ACLs in the ACL list (#9374)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.19 by this push:
new 2398b5c8c99 server: apply network ACL even if there is no network ACLs
in the ACL list (#9374)
2398b5c8c99 is described below
commit 2398b5c8c99437745cbbbdc87373fbb1ed93538a
Author: Wei Zhou
AuthorDate: Tue Sep 24 09:18:05 2024 +0200
server: apply network ACL even if there is no network ACLs in the ACL list
(#9374)
---
.../apache/cloudstack/network/topology/AdvancedNetworkTopology.java | 5 -
1 file changed, 5 deletions(-)
diff --git
a/server/src/main/java/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
b/server/src/main/java/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
index fc29fcca998..8ee5d12c69a 100644
---
a/server/src/main/java/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
+++
b/server/src/main/java/org/apache/cloudstack/network/topology/AdvancedNetworkTopology.java
@@ -228,11 +228,6 @@ public class AdvancedNetworkTopology extends
BasicNetworkTopology {
public boolean applyNetworkACLs(final Network network, final List rules, final VirtualRouter router, final boolean
isPrivateGateway)
throws ResourceUnavailableException {
-if (rules == null || rules.isEmpty()) {
-s_logger.debug("No network ACLs to be applied for network " +
network.getId());
-return true;
-}
-
s_logger.debug("APPLYING NETWORK ACLs RULES");
final String typeString = "network acls";
(cloudstack-www) branch staging-site updated: events widget update (#251)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch staging-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/staging-site by this push: new 1d67d758c events widget update (#251) 1d67d758c is described below commit 1d67d758c7e802343b7383a64017a82844cbcf13 Author: dahn AuthorDate: Tue Sep 24 09:04:41 2024 +0200 events widget update (#251) --- src/components/Events/index.tsx | 35 +++ 1 file changed, 11 insertions(+), 24 deletions(-) diff --git a/src/components/Events/index.tsx b/src/components/Events/index.tsx index ce63dab0f..83fbc3964 100644 --- a/src/components/Events/index.tsx +++ b/src/components/Events/index.tsx @@ -22,18 +22,6 @@ involved with the community. Upcoming Events: - - - - CloudStack European User Group 2024 - Frankfurt, Germany - Sep 19, 2024 - - - Read More - https://www.eventbrite.co.uk/e/cloudstack-european-user-group-germany-tickets-879369205967"; target="_blank">Register Now - - @@ -64,6 +52,17 @@ involved with the community. Past Events: + + + + CloudStack European User Group 2024 + Frankfurt, Germany + Sep 19, 2024 + + + Read More + + @@ -98,18 +97,6 @@ involved with the community. https://www.youtube.com/playlist?list=PLnIKk7GjgFlZsBJestxnL-xF5DxgewxYh"; className="btn btn-primary">Watch - - - - CloudStack European User Group 2023 - London, UK - May 4, 2023 - - - https://cloudstack.apache.org/blog/cseug-2023-roundup"; className="btn btn-outline-secondary me-3">Read More - https://www.youtube.com/playlist?list=PLnIKk7GjgFlZtSvP7zSXDKr-r5qLCKCFd"; className="btn btn-primary">Watch - -
(cloudstack-www) branch main updated (45c13b3d5 -> 1d67d758c)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 45c13b3d5 Bump braces from 3.0.2 to 3.0.3 (#240) add 20e21a518 link to playlist (#250) add 1d67d758c events widget update (#251) No new revisions were added by this update. Summary of changes: src/components/Events/index.tsx | 36 1 file changed, 12 insertions(+), 24 deletions(-)
Re: [PR] CKS: fix creation on shared network if HA is enabled [cloudstack]
weizhouapache commented on PR #8588: URL: https://github.com/apache/cloudstack/pull/8588#issuecomment-2370455007 @kiranchavala are you testing it ? please note, you need to setup the lb (nginx/haproxy) for the external IP it does not work in advanced zone with security groups. some ports need to be opened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370655460 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: fix creation on shared network if HA is enabled [cloudstack]
kiranchavala commented on PR #8588: URL: https://github.com/apache/cloudstack/pull/8588#issuecomment-2370442864 > > @weizhouapache , i am getting the following exception when I provide a external loadbalancer IP during cks cluster creation in a shared network > >  > > because 10.0.0.96.6 is not valid address try 10.0.96.6 😄 > > @weizhouapache , i am getting the following exception when I provide a external loadbalancer IP during cks cluster creation in a shared network > >  > > because 10.0.0.96.6 is not valid address try 10.0.96.6 😄 My bad should check my eye sight :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
weizhouapache commented on code in PR #9721:
URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1772801880
##
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java:
##
@@ -22,13 +22,45 @@
import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;
import com.cloud.vm.UserVmDetailVO;
+import com.cloud.vm.VMInstanceVO;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
@Component
public class UserVmDetailsDaoImpl extends
ResourceDetailsDaoBase implements UserVmDetailsDao {
+@Inject
+protected UserVmDetailsDao _detailsDao;
+
@Override
public void addDetail(long resourceId, String key, String value, boolean
display) {
super.addDetail(new UserVmDetailVO(resourceId, key, value, display));
}
+@Override
+public void saveDetails(VMInstanceVO vm) {
+saveDetails(vm, new ArrayList());
+}
+
+@Override
+public void saveDetails(VMInstanceVO vm, List hiddenDetails) {
Review Comment:
@DaanHoogland
it is called by
```
public void saveDetails(VMInstanceVO vm) {
```
which is called by
```
userVmDetailsDao.saveDetails
```
##
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java:
##
@@ -22,13 +22,45 @@
import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;
import com.cloud.vm.UserVmDetailVO;
+import com.cloud.vm.VMInstanceVO;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
@Component
public class UserVmDetailsDaoImpl extends
ResourceDetailsDaoBase implements UserVmDetailsDao {
+@Inject
+protected UserVmDetailsDao _detailsDao;
Review Comment:
these are not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
weizhouapache commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370446634 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
blueorangutan commented on PR #9721: URL: https://github.com/apache/cloudstack/pull/9721#issuecomment-2370449731 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Shutdown expunged resources cleanup executor properly, and allow other components to configure/start/stop on error [cloudstack]
sureshanaparti commented on PR #9723: URL: https://github.com/apache/cloudstack/pull/9723#issuecomment-2370703381 > @sureshanaparti , this looks like a good cleanup. I wonder what it fixes other than just the looks of the code, though. We have two shutdown issues: > > 1. prolonged time of shutdown > 2. no status update for shutdown MSses >does this address voth, @sureshanaparti ? (I can see you showed some evidence for the second) @DaanHoogland this updates MS status to Down when service is stopped/shutdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
Pearl1594 commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2371630347 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NAS B&R Plugin enhancements [cloudstack]
blueorangutan commented on PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#issuecomment-2371635331 @Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-2371916097 [SF] Trillian test result (tid-11536) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 92977 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11536-vmware-70u3.zip Smoke tests completed. 137 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_deployVMInSharedNetwork | `Error` | 152.06 | test_network.py test_02_restore_vm_with_disk_offering | `Error` | 60.04 | test_restore_vm.py test_03_restore_vm_with_disk_offering_custom_size | `Error` | 57.06 | test_restore_vm.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_migrate_vm_strict_tags_success | `Error` | 3604.18 | test_vm_strict_host_tags.py test_02_migrate_vm_strict_tags_failure | `Error` | 3603.89 | test_vm_strict_host_tags.py test_01_restore_vm_strict_tags_success | `Error` | 3604.82 | test_vm_strict_host_tags.py test_02_restore_vm_strict_tags_failure | `Error` | 3.74 | test_vm_strict_host_tags.py test_01_scale_vm_strict_tags_success | `Error` | 15.96 | test_vm_strict_host_tags.py test_02_scale_vm_strict_tags_failure | `Error` | 3603.77 | test_vm_strict_host_tags.py test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 23.20 | test_vm_strict_host_tags.py test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 3606.47 | test_vm_strict_host_tags.py test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 3.76 | test_vm_strict_host_tags.py test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 5.68 | test_vm_strict_host_tags.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: Merge branch '4.19'
This is an automated email from the ASF dual-hosted git repository.
vishesh pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 21d107c349984c6a73daf09062f1d5769d54956c
Merge: a303c7c91ae 2398b5c8c99
Author: Vishesh
AuthorDate: Tue Sep 24 14:04:51 2024 +0530
Merge branch '4.19'
.../main/java/com/cloud/network/NetworkModel.java | 4 +-
client/pom.xml | 21 ++
plugins/hypervisors/kvm/pom.xml| 5 --
.../tungsten/agent/api/SetupTfRouteCommand.java| 64 +
.../agent/api/SetupTungstenVRouterCommand.java | 77
.../api/UpdateTungstenLoadbalancerSslCommand.java | 83 ++
.../UpdateTungstenLoadbalancerStatsCommand.java| 71 ++
...ernetesClusterResourceModifierActionWorker.java | 2 +-
.../KubernetesClusterStartWorker.java | 5 +-
plugins/network-elements/tungsten/pom.xml | 7 --
plugins/pom.xml| 2 +-
server/pom.xml | 11 ---
.../java/com/cloud/network/NetworkModelImpl.java | 13 +++-
.../java/com/cloud/network/NetworkServiceImpl.java | 6 +-
.../com/cloud/network/as/AutoScaleManagerImpl.java | 2 +-
.../main/java/com/cloud/vm/UserVmManagerImpl.java | 11 ++-
.../com/cloud/network/MockNetworkModelImpl.java| 4 +-
.../cloud/network/as/AutoScaleManagerImplTest.java | 6 +-
.../java/com/cloud/vpc/MockNetworkModelImpl.java | 5 +-
tools/docker/Dockerfile| 3 +-
tools/docker/Dockerfile.marvin | 3 +-
tools/docker/Dockerfile.smokedev | 3 +-
ui/Dockerfile | 2 +-
ui/src/components/header/ProjectMenu.vue | 2 +-
ui/src/config/section/compute.js | 4 +-
ui/src/views/iam/DomainActionForm.vue | 5 ++
26 files changed, 349 insertions(+), 72 deletions(-)
diff --cc api/src/main/java/com/cloud/network/NetworkModel.java
index d7de9df5325,ed3506c0da1..a4cd87af008
--- a/api/src/main/java/com/cloud/network/NetworkModel.java
+++ b/api/src/main/java/com/cloud/network/NetworkModel.java
@@@ -358,8 -356,4 +358,8 @@@ public interface NetworkModel
void verifyIp6DnsPair(final String ip6Dns1, final String ip6Dns2);
+boolean isSecurityGroupSupportedForZone(Long zoneId);
+
- boolean checkSecurityGroupSupportForNetwork(DataCenter zone, List
networkIds,
++boolean checkSecurityGroupSupportForNetwork(Account account, DataCenter
zone, List networkIds,
+List securityGroupsIds);
}
diff --cc client/pom.xml
index 03f6520cb05,53baebbc2b4..d89de9d
--- a/client/pom.xml
+++ b/client/pom.xml
@@@ -25,20 -25,9 +25,9 @@@
org.apache.cloudstack
cloudstack
-4.19.2.0-SNAPSHOT
+4.20.0.0-SNAPSHOT
-
-
- juniper-tungsten-api
-
https://github.com/radu-todirica/tungsten-api/raw/master
-
-
-
- net.juniper.tungsten
- juniper-tungsten-api
- 2.0
-
javax.servlet
javax.servlet-api
@@@ -1107,12 -1071,12 +1091,17 @@@
org.apache.cloudstack
cloud-plugin-network-cisco-vnmc
${project.version}
+
+
+org.apache.cloudstack
+cloud-plugin-network-nsx
+${project.version}
+
+ org.apache.cloudstack
+ cloud-plugin-network-tungsten
+ ${project.version}
+
org.apache.cloudstack
cloud-plugin-api-vmware-sioc
diff --cc
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java
index ec461610e32,d721db4b6b4..2a001c4aa94
---
a/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java
+++
b/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java
@@@ -406,7 -407,7 +406,7 @@@ public class KubernetesClusterResourceM
if (StringUtils.isNotBlank(kubernetesCluster.getKeyPair())) {
keypairs.add(kubernetesCluster.getKeyPair());
}
- if (kubernetesCluster.getSecurityGroupId() != null &&
networkModel.checkSecurityGroupSupportForNetwork(zone, networkIds,
List.of(kubernetesCluster.getSecurityGroupId( {
-if (zone.isSecurityGroupEnabled()) {
++if (kubernetesCluster.getSecurityGroupId() != null &&
networkM
(cloudstack) branch main updated (a303c7c91ae -> 21d107c3499)
This is an automated email from the ASF dual-hosted git repository.
vishesh pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
from a303c7c91ae Fix build errors (#9714)
add ee1cd91e988 fixed an issue where requests to the api createDomain were
being sent with the field networkdomain as an empty string whenever the user
typed something in the form and cleared it causing an exception (#9637)
add 9ce7ef49cf9 build/packaging: build tungsten plugin only if noredist is
passed (#9006)
add 0a93dcec742 ui: load project list with minimum details (#9711)
add 9df783ca4be Filter out networks without access while getting networks
with SG with free IPs (#9596)
add 727b3b0d5b2 Removed deprecated instruction MAINTAINER (#8846)
add d15a0744251 Revert "list by displayname instead of name (#8503)"
(#9720)
add 00bb9ecc0bd Merge branch '4.18' into 4.19
add 2398b5c8c99 server: apply network ACL even if there is no network ACLs
in the ACL list (#9374)
new 21d107c3499 Merge branch '4.19'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../main/java/com/cloud/network/NetworkModel.java | 4 ++--
client/pom.xml | 21 +
plugins/hypervisors/kvm/pom.xml | 5 -
.../tungsten/agent/api/SetupTfRouteCommand.java | 0
.../agent/api/SetupTungstenVRouterCommand.java | 0
.../api/UpdateTungstenLoadbalancerSslCommand.java | 0
.../api/UpdateTungstenLoadbalancerStatsCommand.java | 0
...bernetesClusterResourceModifierActionWorker.java | 2 +-
.../actionworkers/KubernetesClusterStartWorker.java | 5 +++--
plugins/network-elements/tungsten/pom.xml | 7 ---
plugins/pom.xml | 2 +-
server/pom.xml | 11 ---
.../java/com/cloud/network/NetworkModelImpl.java| 13 ++---
.../java/com/cloud/network/NetworkServiceImpl.java | 6 +-
.../com/cloud/network/as/AutoScaleManagerImpl.java | 2 +-
.../main/java/com/cloud/vm/UserVmManagerImpl.java | 11 +--
.../com/cloud/network/MockNetworkModelImpl.java | 4 ++--
.../cloud/network/as/AutoScaleManagerImplTest.java | 6 --
.../java/com/cloud/vpc/MockNetworkModelImpl.java| 5 +++--
tools/docker/Dockerfile | 3 +--
tools/docker/Dockerfile.marvin | 3 +--
tools/docker/Dockerfile.smokedev| 3 +--
ui/Dockerfile | 2 +-
ui/src/components/header/ProjectMenu.vue| 2 +-
ui/src/config/section/compute.js| 4 ++--
ui/src/views/iam/DomainActionForm.vue | 5 +
26 files changed, 54 insertions(+), 72 deletions(-)
copy plugins/{network-elements/tungsten =>
hypervisors/kvm}/src/main/java/org/apache/cloudstack/network/tungsten/agent/api/SetupTfRouteCommand.java
(100%)
copy plugins/{network-elements/tungsten =>
hypervisors/kvm}/src/main/java/org/apache/cloudstack/network/tungsten/agent/api/SetupTungstenVRouterCommand.java
(100%)
copy plugins/{network-elements/tungsten =>
hypervisors/kvm}/src/main/java/org/apache/cloudstack/network/tungsten/agent/api/UpdateTungstenLoadbalancerSslCommand.java
(100%)
copy plugins/{network-elements/tungsten =>
hypervisors/kvm}/src/main/java/org/apache/cloudstack/network/tungsten/agent/api/UpdateTungstenLoadbalancerStatsCommand.java
(100%)
Re: [I] VM console cannot access after VNC certificate expired [cloudstack]
weizhouapache commented on issue #9718: URL: https://github.com/apache/cloudstack/issues/9718#issuecomment-2370433665 this may be related to #7015 can you check if - `vnc_tls` is set to 1 in /etc/libvirt/qemu.conf ? - console works after live migration to another host ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: fix creation on shared network if HA is enabled [cloudstack]
weizhouapache commented on PR #8588: URL: https://github.com/apache/cloudstack/pull/8588#issuecomment-2370436681 > @weizhouapache , i am getting the following exception when I provide a external loadbalancer IP during cks cluster creation in a shared network > >  because 10.0.0.96.6 is not valid address try 10.0.96.6 :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] CKS: add ConfigDrive to cloud-init datasource_list in systemvm template [cloudstack]
blueorangutan commented on PR #7650: URL: https://github.com/apache/cloudstack/pull/7650#issuecomment-2370713242 [SF] Trillian test result (tid-11537) Environment: xcpng76 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 62722 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7650-t11537-xcpng76.zip Smoke tests completed. 115 look OK, 26 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 2.68 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 3.72 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.62 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.64 | test_internal_lb.py ContextSuite context=TestIpv4Routing>:setup | `Error` | 0.00 | test_ipv4_routing.py test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 2.34 | test_kubernetes_clusters.py test_02_upgrade_kubernetes_cluster | `Failure` | 2.29 | test_kubernetes_clusters.py test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 2.27 | test_kubernetes_clusters.py test_04_autoscale_kubernetes_cluster | `Failure` | 2.28 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 2.28 | test_kubernetes_clusters.py test_06_delete_kubernetes_cluster | `Failure` | 2.26 | test_kubernetes_clusters.py test_08_upgrade_kubernetes_ha_cluster | `Failure` | 2.28 | test_kubernetes_clusters.py test_10_vpc_tier_kubernetes_cluster | `Error` | 4.54 | test_kubernetes_clusters.py test_11_test_unmanaged_cluster_lifecycle | `Error` | 4.59 | test_kubernetes_clusters.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py ContextSuite context=TestListVolumes>:setup | `Error` | 0.00 | test_list_volumes.py ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py test_list_system_vms_metrics_history | `Failure` | 0.17 | test_metrics_api.py test_list_vms_metrics_admin | `Error` | 1.68 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 1.51 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 1.54 | test_metrics_api.py test_list_volumes_metrics_history | `Error` | 1.35 | test_metrics_api.py test_nic_secondaryip_add_remove | `Error` | 19.31 | test_multipleips_per_nic.py test_network_acl | `Error` | 2.27 | test_network_acl.py test_01_verify_ipv6_network | `Error` | 2.83 | test_network_ipv6.py test_01_verify_ipv6_network | `Error` | 2.84 | test_network_ipv6.py test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.49 | test_network_permissions.py test_03_network_operations_on_created_vm_of_otheruser | `Error` | 2.49 | test_network_permissions.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 1.36 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.40 | test_network_permissions.py test_delete_account | `Error` | 19.45 | test_network.py test_delete_network_while_vm_on_it | `Error` | 2.36 | test_network.py test_delete_network_while_vm_on_it | `Error` | 2.37 | test_network.py test_deploy_vm_l2network | `Error` | 2.35 | test_network.py test_deploy_vm_l2network | `Error` | 2.35 | test_network.py test_l2network_restart | `Error` | 3.51 | test_network.py test_l2network_restart | `Error` | 3.51 | test_network.py ContextSuite context=TestL2Networks>:teardown | `Error` | 4.60 | test_network.py ContextSuite context=TestPortForwarding>:setup | `Error` | 8.71 | test_network.py ContextSuite context=TestPublicIP>:setup | `Error` | 6.85 | test_network.py test_reboot_router | `Error` | 4.13 | test_network.py test_releaseIP | `Error` | 4.17 | test_network.py test_releaseIP_using_IP | `Error` | 4.16 | test_network.py ContextSuite context=TestRouterRules>:setup | `Error` | 8.36 | test_network.py test_01_deployVMInSharedNetwork | `Failure` | 1.22 | test_network.py test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 1.08 | test_network.py test_03_destroySharedNetwork | `Failure` | 1.08 | test_network.py ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.18 | test_network.py ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 2.38 | test_network.py test_01_nic | `Error` | 68.89 | test_nic.py test_01_non_strict_host_anti_affinity | `Error` | 2.40 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 2.42 | test_nonstrict_affinity_group.py test_09_project_suspend | `Error` | 2.35 | test_projects.py test_10_project_activation | `Error` | 2.29 | test_projects.py ContextSuite context=TestIsolatedNetworksPa
Re: [PR] Save systemvm template details for cpvm, ssvm and vr's. [cloudstack]
DaanHoogland commented on code in PR #9721:
URL: https://github.com/apache/cloudstack/pull/9721#discussion_r1772967440
##
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDetailsDaoImpl.java:
##
@@ -22,13 +22,45 @@
import org.apache.cloudstack.resourcedetail.ResourceDetailsDaoBase;
import com.cloud.vm.UserVmDetailVO;
+import com.cloud.vm.VMInstanceVO;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+
+import javax.inject.Inject;
@Component
public class UserVmDetailsDaoImpl extends
ResourceDetailsDaoBase implements UserVmDetailsDao {
+@Inject
+protected UserVmDetailsDao _detailsDao;
+
@Override
public void addDetail(long resourceId, String key, String value, boolean
display) {
super.addDetail(new UserVmDetailVO(resourceId, key, value, display));
}
+@Override
+public void saveDetails(VMInstanceVO vm) {
+saveDetails(vm, new ArrayList());
+}
+
+@Override
+public void saveDetails(VMInstanceVO vm, List hiddenDetails) {
Review Comment:
yes, so it is not needed as `saveDetails(VMInstanceVO vm)` passes a constant
empty `ArrayList`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
