Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
weizhouapache commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2295924914 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2295927021 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Storage issues on VMware 8.0U1 (8.0.1.0) [cloudstack]
weizhouapache commented on issue #7572: URL: https://github.com/apache/cloudstack/issues/7572#issuecomment-2295951266 > > this issue still exist in 4.19.0.0 RC4, so VMware 8.0.1 is still unsupported. > >  > > cc @vladimirpetrov @shwstppr > > I was able to workaround this problem forcing a fsck on first image boot. To do this you need to do a "touch /forcefsck" > > It worked on 8.0u3 with vsan esa. > > Detailed description bellow: > > ``` > tar -xf systemvmtemplate-4.19.1-vmware.ova > qemu-img convert -O raw systemvmtemplate-4.19.1-vmware-disk1.vmdk your_file.raw > losetup -fP your_file.raw > mount /dev/loop0p6 /mnt > touch /mnt/forcefsck > umount /mnt > losetup -d /dev/loop0 > qemu-img convert -O vmdk -o subformat=streamOptimized your_file.raw systemvmtemplate-4.19.1-vmware-disk1.vmdk > ls -la systemvmtemplate-4.19.1-vmware-disk1.vmdk > # Changed ovf:size with the new image size in bytes from "ls -la systemvmtemplate-4.19.1-vmware-disk1.vmdk" inside file systemvmtemplate-4.19.1-vmware.ovf > sha256sum --tag systemvmtemplate-4.19.1-vmware.ovf > systemvmtemplate-4.19.1-vmware.mf > sha256sum --tag systemvmtemplate-4.19.1-vmware-disk1.vmdk >> systemvmtemplate-4.19.1-vmware.mf > tar -cvf systemvmtemplate-4.19.1-vmware.ova systemvmtemplate-4.19.1-vmware.ovf systemvmtemplate-4.19.1-vmware-disk1.vmdk systemvmtemplate-4.19.1-vmware.mf > # Published a new template image inside UI > # Changed global settings router.template.vmware to new image name > ``` thanks a lot for the update @leolns how long `fsck` take in your environment ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] allow users to apply extraconfig on updating VMs [cloudstack]
vladimirpetrov commented on PR #9422: URL: https://github.com/apache/cloudstack/pull/9422#issuecomment-2296038840 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] allow users to apply extraconfig on updating VMs [cloudstack]
blueorangutan commented on PR #9422: URL: https://github.com/apache/cloudstack/pull/9422#issuecomment-2296039660 @vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Added domain path to all entities [cloudstack]
harikrishna-patnala opened a new pull request, #9540:
URL: https://github.com/apache/cloudstack/pull/9540
### Description
This PR fixes the ticket #8086. Added domain path to all the responses
whereever domain and domain names are already used.
Added domain path to all the responses which implements the interfaces
ControlledViewEntityResponse and ControlledEntityResponse
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
(localcloud) 🐱 > list virtualmachines filter=name,domainpath,domain
{
"count": 6,
"virtualmachine": [
{
"domain": "ROOT",
"domainpath": "/",
"name": "Vm1N1"
},
{
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Added domain path to all entities [cloudstack]
harikrishna-patnala commented on PR #9540: URL: https://github.com/apache/cloudstack/pull/9540#issuecomment-2296042694 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added domain path to all entities [cloudstack]
blueorangutan commented on PR #9540: URL: https://github.com/apache/cloudstack/pull/9540#issuecomment-2296044104 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added domain path to all entities [cloudstack]
codecov[bot] commented on PR #9540: URL: https://github.com/apache/cloudstack/pull/9540#issuecomment-2296063660 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`6e6a276`)](https://app.codecov.io/gh/apache/cloudstack/commit/6e6a2766637c604d4cc812d34c6a05b767904991?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`79c7adc`)](https://app.codecov.io/gh/apache/cloudstack/commit/79c7adc39b88093a11e9699529ce30a92fd8b01f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (6e6a276) and HEAD (79c7adc). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (6e6a276) | HEAD (79c7adc) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9540 +/- ## - Coverage 15.08% 4.30% -10.79% Files 5406 366 -5040 Lines472889 29514 -443375 Branches 577385162-52576 - Hits 713521270-70082 + Misses 393593 28100 -365493 + Partials 7944 144 -7800 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9540?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2296076429 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
weizhouapache commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2296106057 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2296109980 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] allow users to apply extraconfig on updating VMs [cloudstack]
blueorangutan commented on PR #9422: URL: https://github.com/apache/cloudstack/pull/9422#issuecomment-2296117588 [SF] Trillian Build Failed (tid-11097) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added domain path to all entities [cloudstack]
blueorangutan commented on PR #9540: URL: https://github.com/apache/cloudstack/pull/9540#issuecomment-2296175106 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Cloud-init not running when guest network use UsedData: ConfigDrive [cloudstack]
weizhouapache commented on issue #9404: URL: https://github.com/apache/cloudstack/issues/9404#issuecomment-2296179245 @leduyquy it seems `cloud-init` does not support password reset if data source is ConfigDrive. Can you check with cloud-init community ? (this may be related to https://github.com/canonical/cloud-init/issues/2402) as a workaround, you can add a script to the image please refer to https://lists.apache.org/thread/3wwnx2bj8g4lyjzvw5ffq0ddhhcxsq0n You can also try with a userdata which contains the username/new password. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Unable to delete failed VM snapshot [cloudstack]
harikrishna-patnala commented on issue #9369: URL: https://github.com/apache/cloudstack/issues/9369#issuecomment-2296181989 @rohityadavcloud I could create a VM snapshot even without qemu-guest-agent in a ubuntu VM. Even I've some how made a vm snapshot creation failed and I could delete the failed snapshot. Am I missing anything or any other specific reproduction steps you have ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2296252430 [SF] Trillian Build Failed (tid-11098) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Not able to delete service offering from UI or API [cloudstack]
harikrishna-patnala commented on issue #9475: URL: https://github.com/apache/cloudstack/issues/9475#issuecomment-2296254365 @rohityadavcloud I don't find any API which marks the service offering's removed column. deleteServiceOffering API and updateServiceOffering (using state parameter) API are updating the column "State" with Active and Inactive values. This was the behaviour even before also. With the PR https://github.com/apache/cloudstack/pull/8821 we have now new filter for Active and Inactive offerings which can also lists all types of offerings Created two offerings and then deleted both the offerings from UI. Following are the screenshots for Active and Inactive offerings Active offerings  Inactive offerings  After enabled one of the offerings, it came back to Active list  Please check and let me know if anything else I'm missing here, otherwise we can close the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: do not check affinity groups if no vm group mappings [cloudstack]
weizhouapache opened a new pull request, #9542:
URL: https://github.com/apache/cloudstack/pull/9542
this fixes the exception in smoke test test_affinity_groups
```
2024-08-19T08:34:15,132 ERROR [c.c.a.ApiAsyncJobDispatcher]
(API-Job-Executor-87:[ctx-f7804a8e, job-9232]) (logid:b71ddec8) Unexpected
exception while executing
org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin
com.cloud.utils.exception.CloudRuntimeException: Unable to find on DB, due to:
You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near ') FOR UPDATE' at line 1
at
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:441)
at
com.cloud.utils.db.GenericDaoBase.searchIncludingRemoved(GenericDaoBase.java:368)
at com.cloud.utils.db.GenericDaoBase.search(GenericDaoBase.java:357)
at com.cloud.utils.db.GenericDaoBase.lockRows(GenericDaoBase.java:343)
at
org.apache.cloudstack.affinity.dao.AffinityGroupDaoImpl.listByIds(AffinityGroupDaoImpl.java:171)
```
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: do not check affinity groups if no vm group mappings [cloudstack]
weizhouapache commented on PR #9542: URL: https://github.com/apache/cloudstack/pull/9542#issuecomment-2296266406 #9201 /4.19 does have the code, but main does not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: do not check affinity groups if no vm group mappings [cloudstack]
codecov[bot] commented on PR #9542: URL: https://github.com/apache/cloudstack/pull/9542#issuecomment-2296284880 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9542?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`8ca1843`)](https://app.codecov.io/gh/apache/cloudstack/commit/8ca1843efae60b24a802377aaad48b8838228200?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`aeef138`)](https://app.codecov.io/gh/apache/cloudstack/commit/aeef1380786e65f6b0db9ab64484c83e3cea6034?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (8ca1843) and HEAD (aeef138). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (8ca1843) | HEAD (aeef138) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9542 +/- ## - Coverage 15.54% 4.17% -11.38% Files 5499 377 -5122 Lines481706 30866 -450840 Branches 626235463-57160 - Hits 748841288-73596 + Misses 398536 29432 -369104 + Partials 8286 146 -8140 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9542/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9542/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9542?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-4.19 updated (b46e35478f5 -> f656b2c607f)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch healthcheck-4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
discard b46e35478f5 DO NOT MERGE
add 2e0024e216d server, api: account and api entity access improvements
add d541e9014df Merge branch '4.18' into 4.19
add 6fbdda951ac [4.19] server, api, ui: access improvements and assorted
fixes (#22)
add 150e7e0b16a Fix imports
add 21f3fde7b40 libvirtstorageadaptor: better handle failed libvirt
storagepool destroy (#9390)
add bf116762788 test: fix component test
test_acl_sharednetwork_deployVM-impersonation.py (#9499)
add c98f1b8b3ca Ensure affinity groups are honored when VMs are deployed
in parallel (#9201)
add 6e6a2766637 add procedures procedure (#9385)
add f656b2c607f DO NOT MERGE
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (b46e35478f5)
\
N -- N -- N refs/heads/healthcheck-4.19 (f656b2c607f)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
No new revisions were added by this update.
Summary of changes:
.github/workflows/ci.yml | 1 +
.../com/cloud/upgrade/DatabaseUpgradeChecker.java | 160 ++--
.../cloudstack/affinity/dao/AffinityGroupDao.java | 3 +
.../affinity/dao/AffinityGroupDaoImpl.java | 12 ++
.../cloud.add_guest_os_and_hypervisor_mapping.sql | 49 +
.../cloud.idempotent_add_column.sql} | 18 +-
.../cloud.idempotent_add_key.sql} | 15 +-
.../cloud.idempotent_add_unique_index.sql} | 12 +-
.../cloud.idempotent_add_unique_key.sql} | 12 +-
.../cloud.idempotent_change_column.sql}| 13 +-
.../cloud.idempotent_create_unique_index.sql} | 17 +-
.../cloud.idempotent_drop_foreign_key.sql} | 14 +-
.../cloud.idempotent_drop_index.sql} | 15 +-
...dempotent_insert_guestos_hypervisor_mapping.sql | 48 +
.../usage.idempotent_add_column.sql} | 12 +-
.../usage.idempotent_change_column.sql}| 13 +-
.../usage.idempotent_drop_index.sql} | 11 +-
.../resources/META-INF/db/schema-41000to41100.sql | 45 -
.../resources/META-INF/db/schema-41520to41600.sql | 47 -
.../resources/META-INF/db/schema-41600to41610.sql | 54 --
.../resources/META-INF/db/schema-41610to41700.sql | 45 -
.../resources/META-INF/db/schema-41720to41800.sql | 59 --
.../resources/META-INF/db/schema-4910to4920.sql| 38
.../cloudstack/affinity/HostAffinityProcessor.java | 39 +++-
.../affinity/HostAntiAffinityProcessor.java| 114 ++-
.../kvm/storage/LibvirtStorageAdaptor.java | 56 --
.../src/main/java/com/cloud/acl/DomainChecker.java | 68 +--
.../java/com/cloud/network/NetworkServiceImpl.java | 209 ++---
.../java/com/cloud/user/AccountManagerImpl.java| 18 +-
.../test/java/com/cloud/acl/DomainCheckerTest.java | 166
.../com/cloud/user/AccountManagerImplTest.java | 110 ---
...est_acl_sharednetwork_deployVM-impersonation.py | 16 +-
test/integration/smoke/test_account_access.py | 198 +++
tools/marvin/marvin/cloudstackException.py | 1 +
34 files changed, 1067 insertions(+), 641 deletions(-)
create mode 100644
engine/schema/src/main/resources/META-INF/db/procedures/cloud.add_guest_os_and_hypervisor_mapping.sql
copy
engine/schema/src/main/resources/META-INF/db/{schema-41120to41200-cleanup.sql
=> procedures/cloud.idempotent_add_column.sql} (59%)
copy
engine/schema/src/main/resources/META-INF/db/{schema-41900to41910-cleanup.sql
=> procedures/cloud.idempotent_add_key.sql} (60%)
copy engine/schema/src/main/resources/META-INF/db/{schema-40to410-cleanup.sql
=> procedures/cloud.idempotent_add_unique_index.sql} (58%)
copy engine/schema/src/main/resources/META-INF/db/{schema-40to410-cleanup.sql
=> procedures/cloud.idempotent_add_unique_key.sql} (60%)
copy engine/schema/src/main/resources/META-INF/db/{schema-40to410-cleanup.sql
=> procedures/cloud.idempotent_change_column.sql} (53%)
copy
engine/schema/src/main/resources/META-INF/db/{schema-41310to41400-cleanup.sql
=> procedures/cloud.idempotent_create_unique_index.sql} (59%)
copy
engine/schema/src/main/resources/META-INF/db/{schema-41200to41300-cleanup.sql
=> procedures/cloud.idempotent_drop_foreign_key.sql} (62%)
copy
engi
Re: [PR] fix removeSecondaryStorageSelector response for docs [cloudstack]
DaanHoogland merged PR #9264: URL: https://github.com/apache/cloudstack/pull/9264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch main updated: fix removeSecondaryStorageSelector response for docs (#9264)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/main by this push:
new 2ba64f2521a fix removeSecondaryStorageSelector response for docs
(#9264)
2ba64f2521a is described below
commit 2ba64f2521ad3a62078f3ab1c5f26c49f8f2fb3e
Author: ahmedali6 <87921765+ahmeda...@users.noreply.github.com>
AuthorDate: Mon Aug 19 13:39:51 2024 +0200
fix removeSecondaryStorageSelector response for docs (#9264)
Co-authored-by: Ahmed Awlaqi
---
.../admin/storage/heuristics/RemoveSecondaryStorageSelectorCmd.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/RemoveSecondaryStorageSelectorCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/RemoveSecondaryStorageSelectorCmd.java
index 79554f44782..468c87d4d99 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/RemoveSecondaryStorageSelectorCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/admin/storage/heuristics/RemoveSecondaryStorageSelectorCmd.java
@@ -27,7 +27,7 @@ import org.apache.cloudstack.api.response.SuccessResponse;
import org.apache.cloudstack.secstorage.heuristics.Heuristic;
@APICommand(name = "removeSecondaryStorageSelector", description = "Removes an
existing secondary storage selector.", since = "4.19.0", responseObject =
-SecondaryStorageHeuristicsResponse.class, requestHasSensitiveInfo =
false, entityType = {Heuristic.class}, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin})
+SuccessResponse.class, requestHasSensitiveInfo = false, entityType =
{Heuristic.class}, responseHasSensitiveInfo = false, authorized =
{RoleType.Admin})
public class RemoveSecondaryStorageSelectorCmd extends BaseCmd {
@Parameter(name = ApiConstants.ID, type = BaseCmd.CommandType.UUID,
entityType = SecondaryStorageHeuristicsResponse.class, required = true,
description = "The unique identifier of the secondary storage
selector to be removed.")
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
JoaoJandre commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2296406988 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2296411555 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
rajujith commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2296412214 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2296415050 @rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Added update, enable, disable events to the updateStoragePool API [cloudstack]
harikrishna-patnala opened a new pull request, #9543:
URL: https://github.com/apache/cloudstack/pull/9543
### Description
This PR addresses the issue #8494
Fixes the issue of missing Enable, Disable action events when trying to do
that using updateStoragePool. Also added new Action event UPDATE.PS to the
actual update storage pool event.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Added update, enable, disable events to the updateStoragePool API [cloudstack]
harikrishna-patnala commented on PR #9543: URL: https://github.com/apache/cloudstack/pull/9543#issuecomment-2296449380 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added update, enable, disable events to the updateStoragePool API [cloudstack]
blueorangutan commented on PR #9543: URL: https://github.com/apache/cloudstack/pull/9543#issuecomment-2296452253 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Filter icon is missing from the service offerings [cloudstack]
harikrishna-patnala commented on issue #8064: URL: https://github.com/apache/cloudstack/issues/8064#issuecomment-2296460397 This was fixed in all the offering pages with the PR https://github.com/apache/cloudstack/pull/9068 in 4.19.1 release  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Allow users to import ACL from a CSV File [cloudstack]
harikrishna-patnala closed issue #8858: Allow users to import ACL from a CSV File URL: https://github.com/apache/cloudstack/issues/8858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Filter icon is missing from the service offerings [cloudstack]
harikrishna-patnala closed issue #8064: Filter icon is missing from the service offerings URL: https://github.com/apache/cloudstack/issues/8064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added update, enable, disable events to the updateStoragePool API [cloudstack]
codecov[bot] commented on PR #9543: URL: https://github.com/apache/cloudstack/pull/9543#issuecomment-2296463512 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9543?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`2ba64f2`)](https://app.codecov.io/gh/apache/cloudstack/commit/2ba64f2521ad3a62078f3ab1c5f26c49f8f2fb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`df62852`)](https://app.codecov.io/gh/apache/cloudstack/commit/df628529c80dfe0fb2f78657b8ff96430e98a532?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (df62852). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2ba64f2) | HEAD (df62852) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9543 +/- ## - Coverage 15.54% 4.17% -11.38% Files 5499 377 -5122 Lines481706 30866 -450840 Branches 586605463-53197 - Hits 748791288-73591 + Misses 398541 29432 -369109 + Partials 8286 146 -8140 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9543/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9543/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9543?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Allow users to import ACL from a CSV File [cloudstack]
btzq opened a new issue, #8858: URL: https://github.com/apache/cloudstack/issues/8858 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Improvement Request (UI, Functionality) ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION N/A # OS / ENVIRONMENT N/A # SUMMARY Note: This ticket is broken down as requested from the origianl post, https://github.com/apache/cloudstack/issues/8841 **Allow users to import ACL from a CSV File** - As an admin, id like the ability to plan my ACL lists offline first in an excel. - Once ive finalised my list, i would like to be able to import it to cloudstack via CSV - This would greatly help my workflow (i can also keep the excel as a backup) # STEPS TO REPRODUCE N/A ~~~ N/A ~~~ # EXPECTED RESULTS ~~~ To be able to manage ACL Rules more easily for large scale projects ~~~ # ACTUAL RESULTS ~~~ Challenging to use ACL rules for large scale projects. ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2296559742 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Api keypair restructure [cloudstack]
blueorangutan commented on PR #9504: URL: https://github.com/apache/cloudstack/pull/9504#issuecomment-2296559745 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Events related to kubernetes are not marked as complete [cloudstack]
DaanHoogland closed issue #9292: Events related to kubernetes are not marked as complete URL: https://github.com/apache/cloudstack/issues/9292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Events related to kubernetes are not marked as complete [cloudstack]
DaanHoogland commented on issue #9292: URL: https://github.com/apache/cloudstack/issues/9292#issuecomment-2296564397 checked that it works as specified above in 4.19 and discussed with @kiranchavala , closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] VM Console Token Expired - VMware maximum number of connected consoles: 40 [cloudstack]
vikyoto opened a new issue, #9544: URL: https://github.com/apache/cloudstack/issues/9544 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMWARE ~~~ # CLOUDSTACK VERSION ~~~ 4.18 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY "View console" does not work after reaching the maximum number of connections.  When trying to access the VMware "Web Console", I receive the following message:  VM Vmware Options:  # STEPS TO REPRODUCE ~~~ Open and close the VM console 40 times and the error will appear. The error will be resolved if you migrate the host VM. ~~~ # EXPECTED RESULTS ~~~ When closing the console tab, the session must be interrupted to avoid the accumulation of these connections. ~~~ # ACTUAL RESULTS ~~~ ~~~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Added update, enable, disable events to the updateStoragePool API [cloudstack]
blueorangutan commented on PR #9543: URL: https://github.com/apache/cloudstack/pull/9543#issuecomment-2296601501 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] VM Console Token Expired - VMware maximum number of connected consoles: 40 [cloudstack]
DaanHoogland commented on issue #9544: URL: https://github.com/apache/cloudstack/issues/9544#issuecomment-2296609607 @vikyoto , I am not sure this can be implemented as you describe. how do you think ACS would know that a client closes their console? Opening is an action in ACS, but closing isn't. An alternative is to create an explicit close console API, but I am not sure what parameters to give it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) branch healthcheck-main updated (a87a7cf7754 -> f2f1dbc5aee)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch healthcheck-main in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard a87a7cf7754 DO NOT MERGE add 0be87ac6545 Fixup CKS UI for external managed clusters (#9434) add d606ee7a07b ui: vm metrics note about behaviour across hypervisors (#9399) add f0ba90568d8 api: Fix missing keys in listZonesMetrics response (#9419) add 9033ab709e6 Fix snapshot chain being deleted on XenServer (#9447) add 2e0024e216d server, api: account and api entity access improvements add d541e9014df Merge branch '4.18' into 4.19 add 6fbdda951ac [4.19] server, api, ui: access improvements and assorted fixes (#22) add b73f634ea61 Merge branch '4.19' add 47a6b7011d7 Fix build add 161d156af1a Support user resource name / displaytext with emoji, unicode chars, and some sql exception msg improvements (#9340) add cb0527d7050 ui: rename autoscale instance group to simply autoscaling group (#9487) add 150e7e0b16a Fix imports add 21f3fde7b40 libvirtstorageadaptor: better handle failed libvirt storagepool destroy (#9390) add bf116762788 test: fix component test test_acl_sharednetwork_deployVM-impersonation.py (#9499) add cc1dcf51b77 Merge remote-tracking branch 'origin/4.19' add b429e843cd1 created VPC message a little less misleading (#9396) add cf1428ddcca Fix column from op_dc_ip_address_alloc not being referenced correctly by its ORM class (#8812) add c98f1b8b3ca Ensure affinity groups are honored when VMs are deployed in parallel (#9201) add 6e6a2766637 add procedures procedure (#9385) add 287a47266b0 Merge branch '4.19' add 3399abddb0c NSX: add back removed code for NSX (#9435) add 01c721fcda5 Improvements to quota tariffs APIs and UI (#9225) add 8ca1843efae Allow deletion of system VM templates (#8556) add 2ba64f2521a fix removeSecondaryStorageSelector response for docs (#9264) add f2f1dbc5aee DO NOT MERGE This update added new revisions after undoing existing revisions. That is to say, some revisions that were in the old version of the branch are not in the new version. This situation occurs when a user --force pushes a change and generates a repository containing something like this: * -- * -- B -- O -- O -- O (a87a7cf7754) \ N -- N -- N refs/heads/healthcheck-main (f2f1dbc5aee) You should already have received notification emails for all of the O revisions, and so the following emails describe only the N revisions from the common base, B. Any revisions marked "omit" are not gone; other references still refer to them. Any revisions marked "discard" are gone forever. No new revisions were added by this update. Summary of changes: .github/workflows/ci.yml | 1 + .../org/apache/cloudstack/api/ApiArgValidator.java | 5 + .../org/apache/cloudstack/api/ApiConstants.java| 6 + .../RemoveSecondaryStorageSelectorCmd.java | 2 +- .../api/command/admin/usage/ListUsageTypesCmd.java | 5 +- .../command/user/template/DeleteTemplateCmd.java | 8 + .../api/command/user/vm/DeployVMCmd.java | 3 +- .../api/command/user/vm/UpdateVMCmd.java | 4 +- .../api/response/AcquirePodIpCmdResponse.java | 10 +- .../cloudstack/api/response/ClusterResponse.java | 38 ++- .../cloudstack/api/response/HostResponse.java | 82 +- .../api/response/ManagementServerResponse.java | 4 + .../api/response/StoragePoolResponse.java | 12 + .../cloudstack/api/response/UsageTypeResponse.java | 14 +- .../cloudstack/api/response/UserVmResponse.java| 4 + .../cloudstack/api/response/VolumeResponse.java| 18 +- .../cloudstack/api/response/ZoneResponse.java | 30 ++- .../org/apache/cloudstack/usage/UsageService.java | 3 - .../org/apache/cloudstack/usage/UsageTypes.java| 50 ++-- .../engine/orchestration/NetworkOrchestrator.java | 6 + .../java/com/cloud/dc/DataCenterIpAddressVO.java | 10 +- .../java/com/cloud/dc/dao/DataCenterDaoImpl.java | 18 +- .../cloud/dc/dao/DataCenterIpAddressDaoImpl.java | 26 +- .../com/cloud/upgrade/DatabaseUpgradeChecker.java | 160 ++- .../com/cloud/upgrade/dao/Upgrade41910to42000.java | 33 +++ .../cloudstack/affinity/dao/AffinityGroupDao.java | 3 + .../affinity/dao/AffinityGroupDaoImpl.java | 12 + .../cloud.add_guest_os_and_hypervisor_mapping.sql | 49 .../db/procedures/cloud.idempotent_add_column.sql | 27 ++ .../db/procedures/cloud.idempotent_add_key.sql | 27 ++ .../cloud.idempotent_add_unique_index.sql | 26 ++ .../procedures/cloud.idempotent_add_unique_key.sql | 26 ++ .../procedures/cloud.idempotent_change_column.sql | 27 ++ .../cloud.idempotent_create_unique_index.sql | 27 ++ .../cloud.idempotent_drop_foreign_key.sql | 25 ++ .../db/procedures
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
DaanHoogland commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2296613693 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2296615818 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix Template and ISO upload events [cloudstack]
nvazquez opened a new pull request, #9545:
URL: https://github.com/apache/cloudstack/pull/9545
### Description
This PR adds the missing events when uploading templates and ISOs.
Fixes: #8052
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
https://github.com/user-attachments/assets/8abe739f-fe7f-4073-b55e-631dd2ea6b2a";>
### How Has This Been Tested?
Tested uploading templates, ISOs and volumes for comparisson
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
nvazquez commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296771470 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
blueorangutan commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296773045 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-229683 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
Pearl1594 commented on code in PR #9545:
URL: https://github.com/apache/cloudstack/pull/9545#discussion_r1721926713
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -359,6 +361,16 @@ public List
doInTransaction(TransactionStatus
throw new CloudRuntimeException("Unable to persist the
template " + profile.getTemplate());
}
+// Set Event Details for Template/ISO Upload
+String eventType =
template.getFormat().equals(ImageFormat.ISO) ? "Iso" : "Template";
+String eventResourceId = template.getUuid();
+CallContext.current().setEventDetails(String.format("%s Id:
%s", eventType, eventResourceId));
+
CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType :
VirtualMachineTemplate.class, eventResourceId);
+if (template.getFormat().equals(ImageFormat.ISO)) {
+
CallContext.current().setEventResourceType(ApiCommandResourceType.Iso);
+CallContext.current().setEventResourceId(template.getId());
+}
+
Review Comment:
Is this spe
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -359,6 +361,16 @@ public List
doInTransaction(TransactionStatus
throw new CloudRuntimeException("Unable to persist the
template " + profile.getTemplate());
}
+// Set Event Details for Template/ISO Upload
+String eventType =
template.getFormat().equals(ImageFormat.ISO) ? "Iso" : "Template";
+String eventResourceId = template.getUuid();
+CallContext.current().setEventDetails(String.format("%s Id:
%s", eventType, eventResourceId));
+
CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType :
VirtualMachineTemplate.class, eventResourceId);
+if (template.getFormat().equals(ImageFormat.ISO)) {
+
CallContext.current().setEventResourceType(ApiCommandResourceType.Iso);
+CallContext.current().setEventResourceId(template.getId());
+}
+
Review Comment:
Is this spe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
Pearl1594 commented on code in PR #9545:
URL: https://github.com/apache/cloudstack/pull/9545#discussion_r1721927292
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -359,6 +361,16 @@ public List
doInTransaction(TransactionStatus
throw new CloudRuntimeException("Unable to persist the
template " + profile.getTemplate());
}
+// Set Event Details for Template/ISO Upload
+String eventType =
template.getFormat().equals(ImageFormat.ISO) ? "Iso" : "Template";
+String eventResourceId = template.getUuid();
+CallContext.current().setEventDetails(String.format("%s Id:
%s", eventType, eventResourceId));
+
CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType :
VirtualMachineTemplate.class, eventResourceId);
+if (template.getFormat().equals(ImageFormat.ISO)) {
Review Comment:
Is this required to be specific to only ISOs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
nvazquez commented on code in PR #9545:
URL: https://github.com/apache/cloudstack/pull/9545#discussion_r1721931735
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -359,6 +361,16 @@ public List
doInTransaction(TransactionStatus
throw new CloudRuntimeException("Unable to persist the
template " + profile.getTemplate());
}
+// Set Event Details for Template/ISO Upload
+String eventType =
template.getFormat().equals(ImageFormat.ISO) ? "Iso" : "Template";
+String eventResourceId = template.getUuid();
+CallContext.current().setEventDetails(String.format("%s Id:
%s", eventType, eventResourceId));
+
CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType :
VirtualMachineTemplate.class, eventResourceId);
+if (template.getFormat().equals(ImageFormat.ISO)) {
Review Comment:
Yes, otherwise the event resource was not being obtained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
nvazquez commented on code in PR #9545:
URL: https://github.com/apache/cloudstack/pull/9545#discussion_r1721931735
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -359,6 +361,16 @@ public List
doInTransaction(TransactionStatus
throw new CloudRuntimeException("Unable to persist the
template " + profile.getTemplate());
}
+// Set Event Details for Template/ISO Upload
+String eventType =
template.getFormat().equals(ImageFormat.ISO) ? "Iso" : "Template";
+String eventResourceId = template.getUuid();
+CallContext.current().setEventDetails(String.format("%s Id:
%s", eventType, eventResourceId));
+
CallContext.current().putContextParameter(eventType.equals("Iso") ? eventType :
VirtualMachineTemplate.class, eventResourceId);
+if (template.getFormat().equals(ImageFormat.ISO)) {
Review Comment:
Yes, otherwise the event resource was not being obtained. For templates it
wasn't needed as the event resource was properly set on the event
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] Storage issues on VMware 8.0U1 (8.0.1.0) [cloudstack]
leolns commented on issue #7572: URL: https://github.com/apache/cloudstack/issues/7572#issuecomment-2296867637 > > > this issue still exist in 4.19.0.0 RC4, so VMware 8.0.1 is still unsupported. > > >  > > > cc @vladimirpetrov @shwstppr > > > > > > I was able to workaround this problem forcing a fsck on first image boot. To do this you need to do a "touch /forcefsck" > > It worked on 8.0u3 with vsan esa. > > Detailed description bellow: > > ``` > > tar -xf systemvmtemplate-4.19.1-vmware.ova > > qemu-img convert -O raw systemvmtemplate-4.19.1-vmware-disk1.vmdk your_file.raw > > losetup -fP your_file.raw > > mount /dev/loop0p6 /mnt > > touch /mnt/forcefsck > > umount /mnt > > losetup -d /dev/loop0 > > qemu-img convert -O vmdk -o subformat=streamOptimized your_file.raw systemvmtemplate-4.19.1-vmware-disk1.vmdk > > ls -la systemvmtemplate-4.19.1-vmware-disk1.vmdk > > # Changed ovf:size with the new image size in bytes from "ls -la systemvmtemplate-4.19.1-vmware-disk1.vmdk" inside file systemvmtemplate-4.19.1-vmware.ovf > > sha256sum --tag systemvmtemplate-4.19.1-vmware.ovf > systemvmtemplate-4.19.1-vmware.mf > > sha256sum --tag systemvmtemplate-4.19.1-vmware-disk1.vmdk >> systemvmtemplate-4.19.1-vmware.mf > > tar -cvf systemvmtemplate-4.19.1-vmware.ova systemvmtemplate-4.19.1-vmware.ovf systemvmtemplate-4.19.1-vmware-disk1.vmdk systemvmtemplate-4.19.1-vmware.mf > > # Published a new template image inside UI > > # Changed global settings router.template.vmware to new image name > > ``` > > thanks a lot for the update @leolns > > how long `fsck` take in your environment ? I took only a few seconds and it only runs on the first boot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
codecov[bot] commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296885022 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9545?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `0%` with `7 lines` in your changes missing coverage. Please review. > Project coverage is 12.27%. Comparing base [(`2e0024e`)](https://app.codecov.io/gh/apache/cloudstack/commit/2e0024e216d2821bca91e5bc99c9695d94c09e83?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`908b2fc`)](https://app.codecov.io/gh/apache/cloudstack/commit/908b2fc52951b4362138b2ec7ab32055389e4b62?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/9545?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [.../com/cloud/template/HypervisorTemplateAdapter.java](https://app.codecov.io/gh/apache/cloudstack/pull/9545?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Ftemplate%2FHypervisorTemplateAdapter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3RlbXBsYXRlL0h5cGVydmlzb3JUZW1wbGF0ZUFkYXB0ZXIuamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/9545?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.18#9545 +/- ## === Coverage 12.27% 12.27% - Complexity 9334 9337 +3 === Files 4699 4699 Lines414650 414657 +7 Branches 5196350963 -1000 === + Hits 5088050897 +17 + Misses 357446 357434 -12 - Partials 6324 6326 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9545/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9545/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `12.27% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9545?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
blueorangutan commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296903466 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10697 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
nvazquez commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296931562 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
blueorangutan commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2296934461 @nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add support for disabling serivce / system and disk offerings [cloudstack]
Pearl1594 opened a new pull request, #9546:
URL: https://github.com/apache/cloudstack/pull/9546
### Description
This PR addresses: https://github.com/apache/cloudstack/issues/8440
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
codecov[bot] commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2297046353 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`2ba64f2`)](https://app.codecov.io/gh/apache/cloudstack/commit/2ba64f2521ad3a62078f3ab1c5f26c49f8f2fb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`6932fb0`)](https://app.codecov.io/gh/apache/cloudstack/commit/6932fb08666cfed8a96c34cd2268407707d27bcb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (6932fb0). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2ba64f2) | HEAD (6932fb0) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9546 +/- ## - Coverage 15.54% 4.17% -11.38% Files 5499 377 -5122 Lines481706 30872 -450834 Branches 586605463-53197 - Hits 748791288-73591 + Misses 398541 29438 -369103 + Partials 8286 146 -8140 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9546/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9546?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
Pearl1594 commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2297273219 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
blueorangutan commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2297274549 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] adding KVM primary disk for a host is not possible from UI [cloudstack]
JoaoJandre closed issue #9533: adding KVM primary disk for a host is not possible from UI URL: https://github.com/apache/cloudstack/issues/9533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
blueorangutan commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2297400276 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
nvazquez commented on code in PR #9546:
URL: https://github.com/apache/cloudstack/pull/9546#discussion_r1722349605
##
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java:
##
@@ -111,14 +109,7 @@ public String getStorageType() {
}
public State getState() {
-if (StringUtils.isBlank(diskOfferingState)) {
-return Active;
-}
-State state = EnumUtils.getEnumIgnoreCase(State.class,
diskOfferingState);
-if (!diskOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
Are these checks not relevant anymore?
##
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##
@@ -157,14 +154,7 @@ public String getStorageType() {
}
public State getState() {
-if (StringUtils.isBlank(serviceOfferingState)) {
-return Active;
-}
-State state = EnumUtils.getEnumIgnoreCase(State.class,
serviceOfferingState);
-if (!serviceOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]
Pearl1594 commented on code in PR #9546:
URL: https://github.com/apache/cloudstack/pull/9546#discussion_r1722369998
##
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java:
##
@@ -157,14 +154,7 @@ public String getStorageType() {
}
public State getState() {
-if (StringUtils.isBlank(serviceOfferingState)) {
-return Active;
-}
-State state = EnumUtils.getEnumIgnoreCase(State.class,
serviceOfferingState);
-if (!serviceOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
I just made this uniform to how it works with listing network and vpc
offerings ; wherein when the state isn't passed, we list all offerings - so we
do not explicitly need "all"
##
api/src/main/java/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java:
##
@@ -111,14 +109,7 @@ public String getStorageType() {
}
public State getState() {
-if (StringUtils.isBlank(diskOfferingState)) {
-return Active;
-}
-State state = EnumUtils.getEnumIgnoreCase(State.class,
diskOfferingState);
-if (!diskOfferingState.equalsIgnoreCase("all") && state == null) {
Review Comment:
I just made this uniform to how it works with listing network and vpc
offerings ; wherein when the state isn't passed, we list all offerings - so we
do not explicitly need "all"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
(cloudstack) 01/01: Filter list VMs by IP address
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch fix-filter-vms-ip
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit dbb2650f088686987cf2ba6138f75a92984ee2dd
Author: Pearl Dsilva
AuthorDate: Mon Aug 19 17:56:47 2024 -0400
Filter list VMs by IP address
---
.../java/com/cloud/api/query/QueryManagerImpl.java | 26 ++
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
index 5286dad29e4..bf5bc8e639b 100644
--- a/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
+++ b/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
@@ -1447,13 +1447,18 @@ public class QueryManagerImpl extends
MutualExclusiveIdsManagerBase implements Q
}
if (keyword != null) {
-userVmSearchBuilder.and().op("keywordDisplayName",
userVmSearchBuilder.entity().getDisplayName(), Op.LIKE);
-userVmSearchBuilder.or("keywordName",
userVmSearchBuilder.entity().getHostName(), Op.LIKE);
-userVmSearchBuilder.or("keywordState",
userVmSearchBuilder.entity().getState(), Op.EQ);
+SearchBuilder userVmJoinSearchBuilder =
_userVmJoinDao.createSearchBuilder();
+userVmJoinSearchBuilder.and().op("keywordDisplayName",
userVmJoinSearchBuilder.entity().getDisplayName(), Op.LIKE);
+userVmJoinSearchBuilder.or("keywordName",
userVmJoinSearchBuilder.entity().getHostName(), Op.LIKE);
+userVmJoinSearchBuilder.or("keywordState",
userVmJoinSearchBuilder.entity().getState(), Op.EQ);
+userVmJoinSearchBuilder.or("keywordIpAddress",
userVmJoinSearchBuilder.entity().getIpAddress(), Op.LIKE);
+userVmJoinSearchBuilder.or("keywordPublicIpAddress",
userVmJoinSearchBuilder.entity().getPublicIpAddress(), Op.LIKE);
+userVmJoinSearchBuilder.or("keywordIp6Address",
userVmJoinSearchBuilder.entity().getIp6Address(), Op.LIKE);
if (isRootAdmin) {
-userVmSearchBuilder.or("keywordInstanceName",
userVmSearchBuilder.entity().getInstanceName(), Op.LIKE );
+userVmJoinSearchBuilder.or("keywordInstanceName",
userVmJoinSearchBuilder.entity().getInstanceName(), Op.LIKE );
}
-userVmSearchBuilder.cp();
+userVmJoinSearchBuilder.cp();
+userVmSearchBuilder.join("keyword", userVmJoinSearchBuilder,
userVmJoinSearchBuilder.entity().getId(), userVmSearchBuilder.entity().getId(),
JoinBuilder.JoinType.INNER);
}
if (backupOfferingId != null) {
@@ -1543,11 +1548,14 @@ public class QueryManagerImpl extends
MutualExclusiveIdsManagerBase implements Q
if (keyword != null) {
String keywordMatch = "%" + keyword + "%";
-userVmSearchCriteria.setParameters("keywordDisplayName",
keywordMatch);
-userVmSearchCriteria.setParameters("keywordName", keywordMatch);
-userVmSearchCriteria.setParameters("keywordState", keyword);
+
userVmSearchCriteria.setJoinParameters("keyword","keywordDisplayName",
keywordMatch);
+userVmSearchCriteria.setJoinParameters("keyword","keywordName",
keywordMatch);
+userVmSearchCriteria.setJoinParameters("keyword","keywordState",
keywordMatch);
+
userVmSearchCriteria.setJoinParameters("keyword","keywordIpAddress",
keywordMatch);
+
userVmSearchCriteria.setJoinParameters("keyword","keywordPublicIpAddress",
keywordMatch);
+userVmSearchCriteria.setJoinParameters("keyword",
"keywordIp6Address", keywordMatch);
if (isRootAdmin) {
-userVmSearchCriteria.setParameters("keywordInstanceName",
keywordMatch);
+userVmSearchCriteria.setJoinParameters("keyword",
"keywordInstanceName", keywordMatch);
}
}
(cloudstack) branch fix-filter-vms-ip created (now dbb2650f088)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch fix-filter-vms-ip in repository https://gitbox.apache.org/repos/asf/cloudstack.git at dbb2650f088 Filter list VMs by IP address This branch includes the following new commits: new dbb2650f088 Filter list VMs by IP address The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[PR] Filter list VMs by IP address [cloudstack]
Pearl1594 opened a new pull request, #9547:
URL: https://github.com/apache/cloudstack/pull/9547
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/9486
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
List VMs without any filter:
Listing VMs with a specific IP:
Listing VMs with a part of an IP used as filter:
Listing VMs with an IP that doesn't match:
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Filter list VMs by IP address [cloudstack]
codecov[bot] commented on PR #9547: URL: https://github.com/apache/cloudstack/pull/9547#issuecomment-2297541957 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9547?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.30%. Comparing base [(`6e6a276`)](https://app.codecov.io/gh/apache/cloudstack/commit/6e6a2766637c604d4cc812d34c6a05b767904991?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`dbb2650`)](https://app.codecov.io/gh/apache/cloudstack/commit/dbb2650f088686987cf2ba6138f75a92984ee2dd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (6e6a276) and HEAD (dbb2650). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (6e6a276) | HEAD (dbb2650) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #9547 +/- ## - Coverage 15.08% 4.30% -10.79% Files 5406 366 -5040 Lines472889 29514 -443375 Branches 577385162-52576 - Hits 713521270-70082 + Misses 393593 28100 -365493 + Partials 7944 144 -7800 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9547/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9547?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(cloudstack) 01/01: UI: Add filter to list encrypted volumes
This is an automated email from the ASF dual-hosted git repository.
pearl11594 pushed a commit to branch add-is-encrypted-vol-filter
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 42380ea49312dd5186064c1d58da72e96d0d11d7
Author: Pearl Dsilva
AuthorDate: Mon Aug 19 19:00:26 2024 -0400
UI: Add filter to list encrypted volumes
---
ui/public/locales/en.json | 1 +
ui/src/components/view/SearchView.vue | 30 +-
ui/src/config/section/storage.js | 2 +-
3 files changed, 31 insertions(+), 2 deletions(-)
diff --git a/ui/public/locales/en.json b/ui/public/locales/en.json
index b42899fc631..cda4e34618a 100644
--- a/ui/public/locales/en.json
+++ b/ui/public/locales/en.json
@@ -1166,6 +1166,7 @@
"label.isdedicated": "Dedicated",
"label.isdefault": "Is default",
"label.isdynamicallyscalable": "Dynamically scalable",
+"label.isencrypted": "Encrypted",
"label.istagarule": "Tag as JS rule",
"label.isextractable": "Extractable",
"label.isfeatured": "Featured",
diff --git a/ui/src/components/view/SearchView.vue
b/ui/src/components/view/SearchView.vue
index 7883b162d66..07e2d14e8bc 100644
--- a/ui/src/components/view/SearchView.vue
+++ b/ui/src/components/view/SearchView.vue
@@ -111,6 +111,10 @@
+
item.name ===
'isencrypted')
+this.fields[volumeIndex].loading = true
+promises.push(await this.fetchVolumes(searchKeyword))
+ }
+
Promise.all(promises).then(response => {
if (typeIndex > -1) {
const types = response.filter(item => item.type === 'type')
@@ -884,6 +899,19 @@ export default {
})
}
},
+fetchVolumes (searchKeyword) {
+ return new Promise((resolve, reject) => {
+api('listvolumes', { listAll: true, isencrypted: searchKeyword
}).then(json => {
+ const volumes = json.listvolumesresponse.volume
+ resolve({
+type: 'isencrypted',
+data: volumes
+ })
+}).catch(error => {
+ reject(error.response.headers['x-description'])
+})
+ })
+},
fetchManagementServers (searchKeyword) {
return new Promise((resolve, reject) => {
api('listManagementServers', { listAll: true, keyword: searchKeyword
}).then(json => {
diff --git a/ui/src/config/section/storage.js b/ui/src/config/section/storage.js
index 28c451105a1..4c76ebf8db3 100644
--- a/ui/src/config/section/storage.js
+++ b/ui/src/config/section/storage.js
@@ -91,7 +91,7 @@ export default {
}
],
searchFilters: () => {
-var filters = ['name', 'zoneid', 'domainid', 'account', 'state',
'tags', 'serviceofferingid', 'diskofferingid']
+var filters = ['name', 'zoneid', 'domainid', 'account', 'state',
'tags', 'serviceofferingid', 'diskofferingid', 'isencrypted']
if (['Admin',
'DomainAdmin'].includes(store.getters.userInfo.roletype)) {
filters.push('storageid')
}
(cloudstack) branch add-is-encrypted-vol-filter created (now 42380ea4931)
This is an automated email from the ASF dual-hosted git repository. pearl11594 pushed a change to branch add-is-encrypted-vol-filter in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 42380ea4931 UI: Add filter to list encrypted volumes This branch includes the following new commits: new 42380ea4931 UI: Add filter to list encrypted volumes The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[PR] UI: Add filter to list encrypted volumes [cloudstack]
Pearl1594 opened a new pull request, #9548:
URL: https://github.com/apache/cloudstack/pull/9548
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/9130
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
Added toggle button for filtering only encrypted volumes:
When set to true, passes 'isencrypted' parameter to the listVolumes API call:
When set to false, returns all non-encrypted volumes:
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Filter list VMs by IP address [cloudstack]
Pearl1594 commented on PR #9547: URL: https://github.com/apache/cloudstack/pull/9547#issuecomment-2297669678 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add filter to list encrypted volumes [cloudstack]
Pearl1594 commented on PR #9548: URL: https://github.com/apache/cloudstack/pull/9548#issuecomment-2297669900 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add filter to list encrypted volumes [cloudstack]
blueorangutan commented on PR #9548: URL: https://github.com/apache/cloudstack/pull/9548#issuecomment-2297671131 @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Filter list VMs by IP address [cloudstack]
blueorangutan commented on PR #9547: URL: https://github.com/apache/cloudstack/pull/9547#issuecomment-2297671145 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add filter to list encrypted volumes [cloudstack]
codecov[bot] commented on PR #9548: URL: https://github.com/apache/cloudstack/pull/9548#issuecomment-2297671742 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9548?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`2ba64f2`)](https://app.codecov.io/gh/apache/cloudstack/commit/2ba64f2521ad3a62078f3ab1c5f26c49f8f2fb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`42380ea`)](https://app.codecov.io/gh/apache/cloudstack/commit/42380ea49312dd5186064c1d58da72e96d0d11d7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (42380ea). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2ba64f2) | HEAD (42380ea) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9548 +/- ## - Coverage 15.54% 4.17% -11.38% Files 5499 377 -5122 Lines481706 30880 -450826 Branches 586605466-53194 - Hits 748791288-73591 + Misses 398541 29446 -369095 + Partials 8286 146 -8140 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9548/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9548?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Add filter to list encrypted volumes [cloudstack]
blueorangutan commented on PR #9548: URL: https://github.com/apache/cloudstack/pull/9548#issuecomment-2297686313 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9548 (QA-JID-424) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Filter list VMs by IP address [cloudstack]
blueorangutan commented on PR #9547: URL: https://github.com/apache/cloudstack/pull/9547#issuecomment-2297732346 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [WIP] Improvement: Enable/Disable Roles [cloudstack]
nvazquez opened a new pull request, #9549:
URL: https://github.com/apache/cloudstack/pull/9549
### Description
This PR allows enabling/disabling roles. By default all the existing roles
are set as 'enabled'
Fixes: #8460
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [WIP] Improvement: Enable/Disable Roles [cloudstack]
codecov[bot] commented on PR #9549: URL: https://github.com/apache/cloudstack/pull/9549#issuecomment-2297828856 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9549?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.17%. Comparing base [(`2ba64f2`)](https://app.codecov.io/gh/apache/cloudstack/commit/2ba64f2521ad3a62078f3ab1c5f26c49f8f2fb3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`75bbbd5`)](https://app.codecov.io/gh/apache/cloudstack/commit/75bbbd5dcebabb9214349a19cda7361f2551?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > :exclamation: There is a different number of reports uploaded between BASE (2ba64f2) and HEAD (75bbbd5). Click for more details. > > HEAD has 1 upload less than BASE > >| Flag | BASE (2ba64f2) | HEAD (75bbbd5) | >|--|--|--| >|unittests|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9549 +/- ## - Coverage 15.54% 4.17% -11.38% Files 5499 377 -5122 Lines481706 30866 -450840 Branches 586605463-53197 - Hits 748791288-73591 + Misses 398541 29432 -369109 + Partials 8286 146 -8140 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9549/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.17% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/9549?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improvement: Enable/Disable Roles [cloudstack]
nvazquez commented on PR #9549: URL: https://github.com/apache/cloudstack/pull/9549#issuecomment-2297889393 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improvement: Enable/Disable Roles [cloudstack]
blueorangutan commented on PR #9549: URL: https://github.com/apache/cloudstack/pull/9549#issuecomment-2297890235 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] New Feature: Enable/Disable Roles [cloudstack]
blueorangutan commented on PR #9549: URL: https://github.com/apache/cloudstack/pull/9549#issuecomment-2297910558 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix Template and ISO upload events [cloudstack]
blueorangutan commented on PR #9545: URL: https://github.com/apache/cloudstack/pull/9545#issuecomment-2297964456 [SF] Trillian test result (tid-11102) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 43608 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9545-t11102-kvm-ol8.zip Smoke tests completed. 110 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_migrate_VM_and_root_volume | `Error` | 85.96 | test_vm_life_cycle.py test_02_migrate_VM_with_two_data_disks | `Error` | 51.21 | test_vm_life_cycle.py test_08_migrate_vm | `Error` | 46.35 | test_vm_life_cycle.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2298026541 [SF] Trillian test result (tid-11099) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 67108 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9470-t11099-kvm-ol8.zip Smoke tests completed. 134 look OK, 6 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_DeployVmAffinityGroup | `Error` | 1.44 | test_affinity_groups.py ContextSuite context=TestIpv4Routing>:setup | `Error` | 0.00 | test_ipv4_routing.py test_04_list_domains_level_filter | `Failure` | 0.06 | test_list_domains.py test_05_list_domains_no_filter | `Failure` | 0.03 | test_list_domains.py test_01_non_strict_host_anti_affinity | `Error` | 3.62 | test_nonstrict_affinity_group.py test_02_non_strict_host_affinity | `Error` | 3.66 | test_nonstrict_affinity_group.py test_01_secure_vm_migration | `Error` | 137.59 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 137.59 | test_vm_life_cycle.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 549.42 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix to allow actions on the network if it belongs to a project [cloudstack]
harikrishna-patnala opened a new pull request, #9550:
URL: https://github.com/apache/cloudstack/pull/9550
### Description
This PR fixes the issue #9413
The original fix was to allow user to do actions (update, restart, delete)
on the network only if the user owns the network and if user role is of Admin
or domain admin.
If the network belongs to a project then the actions can be allowed as it
belongs to only to that project.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
Before fix with a network in project
After fix with a network in project
### How Has This Been Tested?
1. Create an account of type user
2. Login with that user
3. Create a project and switch to that project
4. Create a new network in that project
5. Before fix user won't be able to do any actions on that network, after
fix it is allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Fix to allow actions on the network if it belongs to a project [cloudstack]
harikrishna-patnala commented on PR #9550: URL: https://github.com/apache/cloudstack/pull/9550#issuecomment-2298088732 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix to allow actions on the network if it belongs to a project [cloudstack]
blueorangutan commented on PR #9550: URL: https://github.com/apache/cloudstack/pull/9550#issuecomment-2298090027 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add support for network data in Config Drive [cloudstack]
blueorangutan commented on PR #9329: URL: https://github.com/apache/cloudstack/pull/9329#issuecomment-2298095223 [SF] Trillian Build Failed (tid-11103) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
