[GitHub] [cloudstack] shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
shwstppr commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505314088 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505315292 Updated heght of the dilague box -  @andrijapanic , @rhtyd , @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505316548 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
anuragaw commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505316461 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3417: engine/schema: add upgrade path for source 4.11.2.0 version
rhtyd commented on issue #3417: engine/schema: add upgrade path for source 4.11.2.0 version URL: https://github.com/apache/cloudstack/pull/3417#issuecomment-505317743 KVM env test failed due to backend IP-range issues, I've rekicked the test job. Will merge this as soon as the KVM tests are in. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
borisstoyanov commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505321122 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505321402 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505323540 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505328380 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-13 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505335453 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505335529 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
rhtyd commented on a change in pull request #3421: RvR: VPC redundant vrs run
on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#discussion_r297060395
##
File path: server/src/com/cloud/network/router/NetworkHelperImpl.java
##
@@ -388,6 +388,19 @@ public DomainRouterVO startVirtualRouter(final
DomainRouterVO router, final User
routerToBeAvoid = rrouter;
}
}
+} else if (router.getVpcId() != null) {
+final List routerList =
_routerDao.listByVpcId(router.getVpcId());
+for (final DomainRouterVO rrouter : routerList) {
+if (rrouter.getHostId() != null &&
rrouter.getIsRedundantRouter() && rrouter.getState() == State.Running) {
+if (routerToBeAvoid != null) {
Review comment:
should this also check that the routerList.size() is >= 2?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3415: Fix interval descrption
rhtyd removed a comment on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340163 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340163 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340681 Since this is strictly a doc string change, LGTM based on travis job #1, packging+smoketests are not necessary. @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3415: Fix interval descrption
rhtyd edited a comment on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505340681 Since this is strictly a doc string change, LGTM based on travis job1 https://travis-ci.org/apache/cloudstack/jobs/549120173, packging+smoketests are not necessary. @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3246: server: allow disk offering selection for volume from snapshot
rhtyd commented on issue #3246: server: allow disk offering selection for volume from snapshot URL: https://github.com/apache/cloudstack/pull/3246#issuecomment-505341004 This can be merged as soon as the tests are in and are OK. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
blueorangutan commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505341617 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s)
rhtyd commented on issue #3248: [WIP DO NOT MERGE] server: offerings for specified domain(s) and zone(s) URL: https://github.com/apache/cloudstack/pull/3248#issuecomment-505341539 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3268: Support sort_key for vpc_offerings table
rhtyd commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505341916 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
rhtyd commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-505342014 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-505342340 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table
blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505342357 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-505342418 @anuragaw @shwstppr @DaanHoogland please review, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-505342961 is this branch/PR stable and ready for review @nvazquez ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3365: KVM: DPDK live migrations
rhtyd commented on issue #3365: KVM: DPDK live migrations URL: https://github.com/apache/cloudstack/pull/3365#issuecomment-505342817 @anuragaw @shwstppr @DaanHoogland please review, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-505343395 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-505343262 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505343337 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505343402 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
rhtyd commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-505343548 @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505343766 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3413: vmware: add support for VMware 6.7
rhtyd commented on issue #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413#issuecomment-505343709 @PaulAngus @andrijapanic @borisstoyanov @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3418: server: fix potential NPE while ldap authentication
rhtyd commented on issue #3418: server: fix potential NPE while ldap authentication URL: https://github.com/apache/cloudstack/pull/3418#issuecomment-505343817 @DaanHoogland @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3419: console-proxy: fix potential NPE condition
rhtyd commented on issue #3419: console-proxy: fix potential NPE condition URL: https://github.com/apache/cloudstack/pull/3419#issuecomment-505343927 @anuragaw @shwstppr @nvazquez please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-505345287 Hi @DaanHoogland - can you help review and stabilize this PR? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505358896 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-505358897 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table
blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505358899 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
rhtyd commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505365182 @blueorangutan test centos7 vmware-65u2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-505365361 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505365641 This will require upgrade path changes to update the description as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
rhtyd commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505366175 Packaging race condition, the repo may be inconsistent. Will rekick packaging. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
rhtyd commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505366311 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505366400 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text
blueorangutan commented on issue #3240: [WIP DO NOT MERGE] api: instance and template details are free text URL: https://github.com/apache/cloudstack/pull/3240#issuecomment-505366395 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3268: Support sort_key for vpc_offerings table
rhtyd commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505366441 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table
blueorangutan commented on issue #3268: Support sort_key for vpc_offerings table URL: https://github.com/apache/cloudstack/pull/3268#issuecomment-505366735 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3415: Fix interval descrption
rhtyd removed a comment on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505365641 This will require upgrade path changes to update the description as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3415: Fix interval descrption
rhtyd commented on issue #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415#issuecomment-505372331 Merging based on reviews and 1st job of travis: https://travis-ci.org/apache/cloudstack/jobs/549120173 Note: this fixes only the description on fresh installation. Ping @anuragaw @shwstppr - can you convert the global setting to a config key? Please open a new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: Fix volume.stats.interval description (#3415)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 2c70c73 server: Fix volume.stats.interval description (#3415)
2c70c73 is described below
commit 2c70c7357de385bab58a8a555246a285bd09d703
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Tue Jun 25 11:50:28 2019 +0200
server: Fix volume.stats.interval description (#3415)
Tested manually - value is in miliseconds, not seconds for the setting
volume.stats.interval
---
server/src/main/java/com/cloud/configuration/Config.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/main/java/com/cloud/configuration/Config.java
b/server/src/main/java/com/cloud/configuration/Config.java
index 09238ea..1aad66d 100644
--- a/server/src/main/java/com/cloud/configuration/Config.java
+++ b/server/src/main/java/com/cloud/configuration/Config.java
@@ -849,7 +849,7 @@ public enum Config {
"The interval (in milliseconds) when vm stats are retrieved from
agents.",
null),
VmDiskStatsInterval("Advanced", ManagementServer.class, Integer.class,
"vm.disk.stats.interval", "0", "Interval (in seconds) to report vm disk
statistics.", null),
-VolumeStatsInterval("Advanced", ManagementServer.class, Integer.class,
"volume.stats.interval", "6", "Interval (in seconds) to report volume
statistics.", null),
+VolumeStatsInterval("Advanced", ManagementServer.class, Integer.class,
"volume.stats.interval", "6", "Interval (in miliseconds) to report volume
statistics.", null),
VmTransitionWaitInterval(
"Advanced",
ManagementServer.class,
[GitHub] [cloudstack] rhtyd merged pull request #3415: Fix interval descrption
rhtyd merged pull request #3415: Fix interval descrption URL: https://github.com/apache/cloudstack/pull/3415 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505373868 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3126: Improve System VM startup and memory usage
rhtyd commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-505374098 Pinging for review - @nvazquez @shwstppr @anuragaw @borisstoyanov @andrijapanic @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3126: Improve System VM startup and memory usage
blueorangutan commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-505374165 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
rhtyd commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505374594 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support
blueorangutan commented on issue #3228: [WIP DO NOT MERGE] api: snapshot, snapshotpolicy tag support URL: https://github.com/apache/cloudstack/pull/3228#issuecomment-505374875 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-cloudmonkey] branch master updated: completer: on hostid autocompletion use type=Routing
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git
The following commit(s) were added to refs/heads/master by this push:
new 9111c77 completer: on hostid autocompletion use type=Routing
9111c77 is described below
commit 9111c7788439a74b158963fb56685e7a24d163db
Author: Rohit Yadav
AuthorDate: Tue Jun 25 15:34:08 2019 +0530
completer: on hostid autocompletion use type=Routing
This fixes the issue that hostid autocompletion only shows Routing
resources (hypervisor hosts) except for the provisionCertificate API.
Signed-off-by: Rohit Yadav
---
cli/completer.go | 4
1 file changed, 4 insertions(+)
diff --git a/cli/completer.go b/cli/completer.go
index da3311c..ce2b7e2 100644
--- a/cli/completer.go
+++ b/cli/completer.go
@@ -360,6 +360,10 @@ func (t *autoCompleter) Do(line []rune, pos int) (options
[][]rune, offset int)
autocompleteAPIArgs =
append(autocompleteAPIArgs, "templatefilter=executable")
}
+ if apiFound.Name != "provisionCertificate" &&
autocompleteAPI.Name == "listHosts" {
+ autocompleteAPIArgs =
append(autocompleteAPIArgs, "type=Routing")
+ }
+
spinner := t.Config.StartSpinner("fetching options,
please wait...")
request := cmd.NewRequest(nil, completer.Config, nil)
response, _ := cmd.NewAPIRequest(request,
autocompleteAPI.Name, autocompleteAPIArgs, false)
[GitHub] [cloudstack] rhtyd commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable
rhtyd commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-505379475 @nathanejohnson @giorgiomassar8 @GabrielBrascher @wido kindly discuss and advise a milestone in case a PR is coming soon. I've removed this issue from 4.13.0.0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC
rhtyd commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-505379695 @gmueller-ewerk can you merge/rebase against latest master and fix the conflicts? cc @svenvogel This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3172: java download client - unable to download/register when there's a trusted ssl connection
rhtyd commented on issue #3172: java download client - unable to download/register when there's a trusted ssl connection URL: https://github.com/apache/cloudstack/issues/3172#issuecomment-505380189 Per the docs, upload should work over http https://github.com/apache/cloudstack-documentation/pull/37/files The failure could be env related and needs investigation. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3313: Simulator: Better VR Redundant Status Behaviour
rhtyd commented on issue #3313: Simulator: Better VR Redundant Status Behaviour URL: https://github.com/apache/cloudstack/pull/3313#issuecomment-505380985 Pinging for review - @anuragaw @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3126: Improve System VM startup and memory usage
blueorangutan commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-505381396 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2539: Admin Dashboard System Capacity broken with German Locale
rhtyd commented on issue #2539: Admin Dashboard System Capacity broken with German Locale URL: https://github.com/apache/cloudstack/issues/2539#issuecomment-505383856 I'm not sure how to fix this one, any ideas @DaanHoogland @rafaelweingartner ? Should we export LANG via the /etc/default/cloudstack-management or open a docs PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2740: Potential mismatch on guest OS - hypervisor mappings on upgrades
rhtyd commented on issue #2740: Potential mismatch on guest OS - hypervisor mappings on upgrades URL: https://github.com/apache/cloudstack/issues/2740#issuecomment-505383989 @nvazquez can you advise what is necessary to remedy the issue? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #2863: Cloudstack 4.11.1.0 - Unable to create shared network in advanced zone
rhtyd closed issue #2863: Cloudstack 4.11.1.0 - Unable to create shared network in advanced zone URL: https://github.com/apache/cloudstack/issues/2863 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2863: Cloudstack 4.11.1.0 - Unable to create shared network in advanced zone
rhtyd commented on issue #2863: Cloudstack 4.11.1.0 - Unable to create shared network in advanced zone URL: https://github.com/apache/cloudstack/issues/2863#issuecomment-505384330 Relevant issue opened, closing this one as https://github.com/apache/cloudstack/issues/2885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3001: storage upload -> "custom disk offerings" not displayed correctly (ui bug)
rhtyd commented on issue #3001: storage upload -> "custom disk offerings" not displayed correctly (ui bug) URL: https://github.com/apache/cloudstack/issues/3001#issuecomment-505384666 Is this bug fixed or are you working on it - @svenvogel @DennisKonrad ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3006: Secondary Storage server fails if multiple Management servers are defined
rhtyd closed issue #3006: Secondary Storage server fails if multiple Management servers are defined URL: https://github.com/apache/cloudstack/issues/3006 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3006: Secondary Storage server fails if multiple Management servers are defined
rhtyd commented on issue #3006: Secondary Storage server fails if multiple Management servers are defined URL: https://github.com/apache/cloudstack/issues/3006#issuecomment-505384913 Can you test with 4.11.2.0 or latest? I'm unable to reproduce this @ccheline This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses
rhtyd commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses URL: https://github.com/apache/cloudstack/issues/3025#issuecomment-505385251 @dubauski sorry we couldn't get to this earlier, we'll try to reproduce this and get back to you. Could you also consider testing 4.11.2.0 which has several improvements and fixes over 4.11.1.0? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3047: Direct Download with IPv6 only fails
rhtyd commented on issue #3047: Direct Download with IPv6 only fails URL: https://github.com/apache/cloudstack/issues/3047#issuecomment-505385355 ping @nvazquez can you advise? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-505385686 yes @rhtyd, he's working on an issue I've reported to him but this branch is stable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3050: Sort list of templates in the deploy VM wizard
rhtyd closed issue #3050: Sort list of templates in the deploy VM wizard URL: https://github.com/apache/cloudstack/issues/3050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3051: dozens WARN messages: Commit called when it is not a transaction
rhtyd closed issue #3051: dozens WARN messages: Commit called when it is not a transaction URL: https://github.com/apache/cloudstack/issues/3051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3051: dozens WARN messages: Commit called when it is not a transaction
rhtyd edited a comment on issue #3051: dozens WARN messages: Commit called when it is not a transaction URL: https://github.com/apache/cloudstack/issues/3051#issuecomment-505385809 Not able to reproduce it on latest master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3051: dozens WARN messages: Commit called when it is not a transaction
rhtyd commented on issue #3051: dozens WARN messages: Commit called when it is not a transaction URL: https://github.com/apache/cloudstack/issues/3051#issuecomment-505385809 Not able to reproduce it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3050: Sort list of templates in the deploy VM wizard
rhtyd commented on issue #3050: Sort list of templates in the deploy VM wizard URL: https://github.com/apache/cloudstack/issues/3050#issuecomment-505385696 Closing the issue, will carry discussion and testing over the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3126: Improve System VM startup and memory usage
blueorangutan commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-505388460 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3126: Improve System VM startup and memory usage
borisstoyanov commented on issue #3126: Improve System VM startup and memory usage URL: https://github.com/apache/cloudstack/pull/3126#issuecomment-505388287 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses
ustcweizhou commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses URL: https://github.com/apache/cloudstack/issues/3025#issuecomment-505390566 @dubauski are the public ips in same subnet or different subnets ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
ustcweizhou commented on a change in pull request #3421: RvR: VPC redundant vrs
run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#discussion_r297126788
##
File path: server/src/com/cloud/network/router/NetworkHelperImpl.java
##
@@ -388,6 +388,19 @@ public DomainRouterVO startVirtualRouter(final
DomainRouterVO router, final User
routerToBeAvoid = rrouter;
}
}
+} else if (router.getVpcId() != null) {
+final List routerList =
_routerDao.listByVpcId(router.getVpcId());
+for (final DomainRouterVO rrouter : routerList) {
+if (rrouter.getHostId() != null &&
rrouter.getIsRedundantRouter() && rrouter.getState() == State.Running) {
+if (routerToBeAvoid != null) {
Review comment:
it should be checked at some other places I think.
I am too lazy I just copied the lines from 380 to 390
https://github.com/apache/cloudstack/blob/4.11/server/src/com/cloud/network/router/NetworkHelperImpl.java#L380,L390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3421: RvR: VPC redundant vrs run on same hypervisor
ustcweizhou commented on a change in pull request #3421: RvR: VPC redundant vrs
run on same hypervisor
URL: https://github.com/apache/cloudstack/pull/3421#discussion_r297126890
##
File path: server/src/com/cloud/network/router/NetworkHelperImpl.java
##
@@ -388,6 +388,19 @@ public DomainRouterVO startVirtualRouter(final
DomainRouterVO router, final User
routerToBeAvoid = rrouter;
}
}
+} else if (router.getVpcId() != null) {
+final List routerList =
_routerDao.listByVpcId(router.getVpcId());
+for (final DomainRouterVO rrouter : routerList) {
+if (rrouter.getHostId() != null &&
rrouter.getIsRedundantRouter() && rrouter.getState() == State.Running) {
+if (routerToBeAvoid != null) {
Review comment:
it should be checked at some other places I think.
I am too lazy I just copied the lines from 380 to 390
https://github.com/apache/cloudstack/blob/4.11/server/src/com/cloud/network/router/NetworkHelperImpl.java#L380,L390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3418: server: fix potential NPE while ldap authentication
rhtyd commented on issue #3418: server: fix potential NPE while ldap authentication URL: https://github.com/apache/cloudstack/pull/3418#issuecomment-505397407 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3419: console-proxy: fix potential NPE condition
rhtyd commented on issue #3419: console-proxy: fix potential NPE condition URL: https://github.com/apache/cloudstack/pull/3419#issuecomment-505397447 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3419: console-proxy: fix potential NPE condition
blueorangutan commented on issue #3419: console-proxy: fix potential NPE condition URL: https://github.com/apache/cloudstack/pull/3419#issuecomment-505397693 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-505397521 Trillian test result (tid-10) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21197 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t10-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 50 look OK, 21 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py test_02_create_template_with_checksum_sha1 | `Error` | 65.37 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.33 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.37 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.40 | test_templates.py test_02_deploy_vm_from_direct_download_template | `Error` | 1.20 | test_templates.py test_03_deploy_vm_wrong_checksum | `Error` | 1.29 | test_templates.py ContextSuite context=TestTemplates>:setup | `Error` | 15.77 | test_templates.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.12 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.11 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.26 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.09 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.09 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.14 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py test_06_stop_cp
[GitHub] [cloudstack] blueorangutan commented on issue #3418: server: fix potential NPE while ldap authentication
blueorangutan commented on issue #3418: server: fix potential NPE while ldap authentication URL: https://github.com/apache/cloudstack/pull/3418#issuecomment-505397698 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3422: Fix hostname is localhost in some VRs
rhtyd commented on issue #3422: Fix hostname is localhost in some VRs URL: https://github.com/apache/cloudstack/pull/3422#issuecomment-505397958 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local
rhtyd commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local URL: https://github.com/apache/cloudstack/pull/3420#issuecomment-505398166 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3422: Fix hostname is localhost in some VRs
blueorangutan commented on issue #3422: Fix hostname is localhost in some VRs URL: https://github.com/apache/cloudstack/pull/3422#issuecomment-505398297 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local
blueorangutan commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local URL: https://github.com/apache/cloudstack/pull/3420#issuecomment-505398285 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local
anuragaw commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local URL: https://github.com/apache/cloudstack/pull/3420#issuecomment-505400159 The PR is for 4.11 - just wanted to confirm it's on purpose. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw edited a comment on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local
anuragaw edited a comment on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local URL: https://github.com/apache/cloudstack/pull/3420#issuecomment-505400159 The PR is for 4.11 - just wanted to confirm it's on purpose. CC- @rhtyd , @ustcweizhou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-cloudmonkey] branch master updated: travis: enable go v1.12
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git The following commit(s) were added to refs/heads/master by this push: new 359249e travis: enable go v1.12 359249e is described below commit 359249e970beb54873140e5389b30342c91077c5 Author: Rohit Yadav AuthorDate: Tue Jun 25 16:52:08 2019 +0530 travis: enable go v1.12 Signed-off-by: Rohit Yadav --- .travis.yml | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 532662a..7d75af9 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,10 +18,7 @@ sudo: false language: go go: - - 1.11.x + - 1.12 script: - make all - -env: - - GO111MODULE=on
[GitHub] [cloudstack] rhtyd merged pull request #3413: vmware: add support for VMware 6.7
rhtyd merged pull request #3413: vmware: add support for VMware 6.7 URL: https://github.com/apache/cloudstack/pull/3413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #2700: Add support to vCenter/vSphere 6.7
rhtyd closed issue #2700: Add support to vCenter/vSphere 6.7 URL: https://github.com/apache/cloudstack/issues/2700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (2c70c73 -> 1ef0598)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2c70c73 server: Fix volume.stats.interval description (#3415) add 1ef0598 vmware: add support for VMware 6.7 (#3413) No new revisions were added by this update. Summary of changes: engine/schema/src/main/resources/META-INF/db/schema-41200to41300.sql | 4 pom.xml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local
rhtyd commented on issue #3420: ssvm: use secstorage.ssl.cert.domain as hostname if it does not start with '*' when upload a template or volume from local URL: https://github.com/apache/cloudstack/pull/3420#issuecomment-505407336 Sometimes authors send PR for older branches, we'll forward merge in that case @anuragaw This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3422: Fix hostname is localhost in some VRs
rhtyd commented on issue #3422: Fix hostname is localhost in some VRs URL: https://github.com/apache/cloudstack/pull/3422#issuecomment-505407538 @anuragaw sometimes authors send PRs to older branches, in which case we forward merge the PR after testing/review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
