[GitHub] [cloudstack] blueorangutan commented on issue #3320: server: fix for inactive service offering for VM
blueorangutan commented on issue #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#issuecomment-495092842 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
shwstppr commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495096030 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495096207 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3320: server: fix for inactive service offering for VM
blueorangutan commented on issue #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#issuecomment-495099177 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
anuragaw commented on a change in pull request #: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r286809527
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -1362,7 +1362,7 @@ private boolean checkOvsNetwork(final String
networkName) {
}
public boolean passCmdLine(final String vmName, final String cmdLine)
throws InternalErrorException {
-final Script command = new Script(_patchScriptPath, 30 * 1000,
s_logger);
+final Script command = new Script(_patchScriptPath, 300 * 1000,
s_logger);
Review comment:
Curious question - Is that a desired timeout value? Seems too high.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on a change in pull request #: server: ssh-keygen in PEM
format and reduce main systemvm patching script
URL: https://github.com/apache/cloudstack/pull/#discussion_r286810482
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -1362,7 +1362,7 @@ private boolean checkOvsNetwork(final String
networkName) {
}
public boolean passCmdLine(final String vmName, final String cmdLine)
throws InternalErrorException {
-final Script command = new Script(_patchScriptPath, 30 * 1000,
s_logger);
+final Script command = new Script(_patchScriptPath, 300 * 1000,
s_logger);
Review comment:
In environment with slow cpu and storage network, the timeout may be even
higher. The logic of 5minute timeout comes from the libvirt wrapper command
handler:
```
// try to patch and SSH into the systemvm for up to 5 minutes
for (int count = 0; count < 10; count++) {
```
For historic reasons, you can see CLOUDSTACK-2823
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495102832 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland opened a new pull request #3348: [WIP] fix duplicate tag exception as CloudRuntimeException
DaanHoogland opened a new pull request #3348: [WIP] fix duplicate tag exception as CloudRuntimeException URL: https://github.com/apache/cloudstack/pull/3348 ## Description see #3339: a runtime exception is thrown but it should be converted to an error return. Wrapping it in a CloudRuntimeException should do the trick. Fixes: #3339 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3348: [WIP] fix duplicate tag exception as CloudRuntimeException
DaanHoogland commented on issue #3348: [WIP] fix duplicate tag exception as CloudRuntimeException URL: https://github.com/apache/cloudstack/pull/3348#issuecomment-495126527 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3323: Fixed: User not allowed to tag project created by him
DaanHoogland commented on issue #3323: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323#issuecomment-495132713 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3323: Fixed: User not allowed to tag project created by him
blueorangutan commented on issue #3323: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323#issuecomment-495133055 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3328: Enhancement scss refactoring
DaanHoogland merged pull request #3328: Enhancement scss refactoring URL: https://github.com/apache/cloudstack/pull/3328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495136464 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-'
DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495136331 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for NIC
DaanHoogland commented on issue #3186: Add possibility to set KVM MTU size for
NIC
URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-495135215
@gmueller-ewerk there is a small conflict:
```
.detail-view .details.group-multiple {
float: left;
<<< nic_set_mtu_size
height: 700px;
===
>>> master
width: 100%;
height: 600px;
margin-bottom: 30px;
}
```
Can you quickly decide to use 600px or 700px?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
DaanHoogland commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-495135715 I see two approvals and a perfectly passed test suite. Is this still WIP? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
DaanHoogland commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342#issuecomment-495137793 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342#issuecomment-495137872 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware:
don't use redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r286851911
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##
@@ -961,16 +961,19 @@ private void
exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String volume
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
-if (clonedVm == null) {
-String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
-s_logger.error(msg);
-throw new Exception(msg);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm =
vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
+if (clonedVm == null) {
+String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
+s_logger.error(msg);
+throw new Exception(msg);
+}
+clonedVm.exportVm(exportPath, exportName, false, false);
//Note: volss: not to create ova.
Review comment:
It's because, if we need to clone i.e. require a worker VM `clonedVm`, then
in finally we need to detach and destroy that worker VM. This is why we cannot
refactor them to use a single variable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware:
don't use redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r286852747
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##
@@ -1014,16 +1018,19 @@ private void
exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String volume
String datastoreVolumePath = getVolumePathInDatastore(dsMo,
volumePath + ".vmdk", searchExcludedFolders);
workerVm.attachDisk(new String[] {datastoreVolumePath}, morDs);
vmMo = workerVm;
Review comment:
Same reason as before, using different instances/variable, it's easier to
track is we need to destroy the worker vm after we're done. If we re-use
`vmMo`, we might accidently destroy the user-vm.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
rhtyd commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware:
don't use redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r286853324
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##
@@ -1684,14 +1688,18 @@ public Answer createTemplateFromSnapshot(CopyCommand
cmd) {
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-Pair cloneResult =
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = cloneResult.first();
-String disks[] = cloneResult.second();
-
-clonedVm.exportVm(exportPath, exportName, false, false);
-return new Pair<>(volumeDeviceInfo.second(), disks);
+String diskDevice = volumeDeviceInfo.second();
+String disks[] =
vmMo.getCurrentSnapshotDiskChainDatastorePaths(diskDevice);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+Pair cloneResult =
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
diskDevice, VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm = cloneResult.first();
+clonedVm.exportVm(exportPath, exportName, false, false);
Review comment:
In the current mechanism, we need a worker VM to take snapshot and export
the disk; without at least one worker VM I'm not sure how we can export
template/disk?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on a change in pull request #3218: [WIP DO NOT MERGE]
vmware: don't use redundant worker VM to extract volume
URL: https://github.com/apache/cloudstack/pull/3218#discussion_r286854454
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
##
@@ -961,16 +961,19 @@ private void
exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String volume
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
-if (clonedVm == null) {
-String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
-s_logger.error(msg);
-throw new Exception(msg);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm =
vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
+if (clonedVm == null) {
+String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
+s_logger.error(msg);
+throw new Exception(msg);
+}
+clonedVm.exportVm(exportPath, exportName, false, false);
//Note: volss: not to create ova.
Review comment:
ok, as said it is a matter of style but we have that boolean to decide:
clonedWorkerVMNeeded
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
rhtyd commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-495140618 @DaanHoogland I'm not exactly sure how you want us to refactor the changes, we'll need at least one worker VM to extract/snapshot the disks to a single vmdk file because the disk in question may be linked-one (multiple files). If we do figure out a clever way out, I'll raise another PR without blocking this, if that's okay. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-495141130 I am not 👎 and was about to merge, @rhtyd . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
DaanHoogland commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-495141539 actually ask if merge is ok (tag [WIP] still in place) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-495144154 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3304: server: Fix exception while update domain resource count (#3204)
blueorangutan commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-495144338 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
DaanHoogland commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-495147252 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-495147338 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
DaanHoogland commented on issue #3346: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3346#issuecomment-495151901 /me nitpicking: "rename createtmplt.sh to createtemplt to unify the files in overall context" in the PR description (fortunately) doesn't occur, does it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3320: server: fix for inactive service offering for VM
blueorangutan commented on issue #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#issuecomment-495153265 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3320: server: fix for inactive service offering for VM
DaanHoogland commented on issue #3320: server: fix for inactive service offering for VM URL: https://github.com/apache/cloudstack/pull/3320#issuecomment-495153188 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3320: server: fix for inactive service offering for VM
DaanHoogland commented on a change in pull request #3320: server: fix for
inactive service offering for VM
URL: https://github.com/apache/cloudstack/pull/3320#discussion_r286868381
##
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##
@@ -965,6 +965,9 @@ public UserVm upgradeVirtualMachine(UpgradeVMCmd cmd)
throws ResourceAllocationE
// Check resource limits for CPU and Memory.
Map customParameters = cmd.getDetails();
ServiceOfferingVO newServiceOffering = _offeringDao.findById(svcOffId);
+if (newServiceOffering.getState() == DiskOffering.State.Inactive) {
+throw new InvalidParameterValueException(String.format("Unable to
upgrade virtual machine %s with an inactive service offering %s",
vmInstance.getUuid(), newServiceOffering.getUuid()));
Review comment:
👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495154073 @shwstppr please rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342#issuecomment-495158667 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495158666 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
blueorangutan commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-495161010 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume
borisstoyanov commented on issue #3218: [WIP DO NOT MERGE] vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-495173759 yes I think so, if @rhtyd doesn't have something in mind This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-'
DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495173963 @blueorangutan help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance
borisstoyanov commented on issue #3239: [WIP DO NOT MERGE] KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-495173938 ping @nvazquez This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495174204 @DaanHoogland I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS options: ['centos6', 'centos7', 'ubuntu'] Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'xenserver-62sp1', 'vmware-65', 'vmware-60u2', 'vmware-55u3', 'vmware-51u1', 'vmware-50u1'] Additional tests: list of space separated tests with paths relative to the `test/integration` directory, for example: component/test_acl_listvm.py component/test_volumes.py Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the `matrix` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'anuragaw', 'shwstppr', 'andrijapanic', 'DagSonsteboSB', 'gsirett'] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts
DaanHoogland commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-495174114 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-'
DaanHoogland commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495175188 not sure if it will cover the changes here as to specific libvirt and or component tests, but @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-495175268 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-495175338 @svanharmelen did you try that workaround? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: vmware: don't use redundant worker VM to extract volume (#3218)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 4f35639 vmware: don't use redundant worker VM to extract volume
(#3218)
4f35639 is described below
commit 4f356392ab8b5ac064966af9b2e29e10f5867132
Author: Rohit Yadav
AuthorDate: Thu May 23 16:48:30 2019 +0530
vmware: don't use redundant worker VM to extract volume (#3218)
This fixes the issue that VM with VMsnapshots fails to start after
extract volume is done on a stopped VM, on VMware.
Signed-off-by: Rohit Yadav
---
.../vmware/manager/VmwareStorageManagerImpl.java | 41 +-
.../storage/resource/VmwareStorageProcessor.java | 38
2 files changed, 47 insertions(+), 32 deletions(-)
diff --git
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
index b6f207a..b73d250 100644
---
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
+++
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
@@ -930,12 +930,12 @@ public class VmwareStorageManagerImpl implements
VmwareStorageManager {
String prevSnapshotUuid, String prevBackupUuid, String
workerVmName, Integer nfsVersion) throws Exception {
String backupUuid = UUID.randomUUID().toString();
-exportVolumeToSecondaryStroage(vmMo, volumePath, secStorageUrl,
getSnapshotRelativeDirInSecStorage(accountId, volumeId), backupUuid,
workerVmName, nfsVersion);
+exportVolumeToSecondaryStorage(vmMo, volumePath, secStorageUrl,
getSnapshotRelativeDirInSecStorage(accountId, volumeId), backupUuid,
workerVmName, nfsVersion, true);
return backupUuid + "/" + backupUuid;
}
-private void exportVolumeToSecondaryStroage(VirtualMachineMO vmMo, String
volumePath, String secStorageUrl, String secStorageDir, String exportName,
String workerVmName,
-Integer nfsVersion) throws Exception {
+private void exportVolumeToSecondaryStorage(VirtualMachineMO vmMo, String
volumePath, String secStorageUrl, String secStorageDir, String exportName,
String workerVmName,
+Integer nfsVersion, boolean
clonedWorkerVMNeeded) throws Exception {
String secondaryMountPoint =
_mountService.getMountPoint(secStorageUrl, nfsVersion);
String exportPath = secondaryMountPoint + "/" + secStorageDir + "/" +
exportName;
@@ -961,16 +961,19 @@ public class VmwareStorageManagerImpl implements
VmwareStorageManager {
throw new Exception(msg);
}
-// 4 MB is the minimum requirement for VM memory in VMware
-vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
-clonedVm = vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
-if (clonedVm == null) {
-String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
-s_logger.error(msg);
-throw new Exception(msg);
+if (clonedWorkerVMNeeded) {
+// 4 MB is the minimum requirement for VM memory in VMware
+vmMo.cloneFromCurrentSnapshot(workerVmName, 0, 4,
volumeDeviceInfo.second(),
VmwareHelper.getDiskDeviceDatastore(volumeDeviceInfo.first()));
+clonedVm =
vmMo.getRunningHost().findVmOnHyperHost(workerVmName);
+if (clonedVm == null) {
+String msg = "Unable to create dummy VM to export volume.
volume path: " + volumePath;
+s_logger.error(msg);
+throw new Exception(msg);
+}
+clonedVm.exportVm(exportPath, exportName, false, false);
//Note: volss: not to create ova.
+} else {
+vmMo.exportVm(exportPath, exportName, false, false);
}
-
-clonedVm.exportVm(exportPath, exportName, false, false); //Note:
volss: not to create ova.
} finally {
if (clonedVm != null) {
clonedVm.detachAllDisks();
@@ -998,6 +1001,7 @@ public class VmwareStorageManagerImpl implements
VmwareStorageManager {
throw new Exception(msg);
}
+boolean clonedWorkerVMNeeded = true;
vmMo = hyperHost.findVmOnHyperHost(vmName);
if (vmMo == null) {
// create a dummy worker vm for attaching the volume
@@ -1014,16 +1018,19 @@ public class VmwareStorageManagerImpl implements
VmwareStorageManager {
[GitHub] [cloudstack] DaanHoogland merged pull request #3218: vmware: don't use redundant worker VM to extract volume
DaanHoogland merged pull request #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
shwstppr commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495176760 Rebased to latest master @DaanHoogland @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: Fix iops values when creating a compute offering (#3345)
This is an automated email from the ASF dual-hosted git repository.
dkonrad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 62c8a11 Fix iops values when creating a compute offering (#3345)
62c8a11 is described below
commit 62c8a1110cbb06c4b337d5b024c3042971502e75
Author: Philipp Bankonier
AuthorDate: Thu May 23 13:25:49 2019 +0200
Fix iops values when creating a compute offering (#3345)
@mike-tutkowski @syed If there's something more that needs to be
added/changed, we'll just open another PR for this.
For now this seems to be a very straightforward fix for the UI problem with
managed storage.
* Fix iops values when creating a compute offering
* Fix iops values when creating a disk offering
---
.../main/java/com/cloud/configuration/ConfigurationManagerImpl.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
index a104bfb..cebc9e1 100755
--- a/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -2411,7 +2411,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
limitResourceUse, volatileVm, displayText,
typedProvisioningType, localStorageRequired, false, tags, isSystem, vmType,
domainId, hostTag, deploymentPlanner);
-if (Boolean.TRUE.equals(isCustomizedIops)) {
+if (Boolean.TRUE.equals(isCustomizedIops) || isCustomizedIops == null)
{
minIops = null;
maxIops = null;
} else {
@@ -2632,7 +2632,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
isCustomized = true;
}
-if (Boolean.TRUE.equals(isCustomizedIops)) {
+if (Boolean.TRUE.equals(isCustomizedIops) || isCustomizedIops == null)
{
minIops = null;
maxIops = null;
} else {
[GitHub] [cloudstack] DennisKonrad merged pull request #3345: Fix iops values when creating a compute offering
DennisKonrad merged pull request #3345: Fix iops values when creating a compute offering URL: https://github.com/apache/cloudstack/pull/3345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DennisKonrad commented on issue #3345: Fix iops values when creating a compute offering
DennisKonrad commented on issue #3345: Fix iops values when creating a compute offering URL: https://github.com/apache/cloudstack/pull/3345#issuecomment-495179574 @mike-tutkowski @syed Do you see something more that need to be changed/added to this to restore normal behaviour for managed storage? We will open a new PR if there's needed more than this small fix @pbankonier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3239: KVM: Fix agents dont reconnect post maintenance
nvazquez commented on issue #3239: KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-495181313 Thanks @DaanHoogland @borisstoyanov, this feature is completed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495191900 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495192129 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
DaanHoogland commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342#issuecomment-495192353 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets
blueorangutan commented on issue #3342: VPC: Fail to restart VPC with cleanup if there are multiple public IPs in different subnets URL: https://github.com/apache/cloudstack/pull/3342#issuecomment-495192444 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland merged pull request #3239: KVM: Fix agents dont reconnect post maintenance
DaanHoogland merged pull request #3239: KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: KVM: Fix agents dont reconnect post maintenance (#3239)
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new e86f671 KVM: Fix agents dont reconnect post maintenance (#3239)
e86f671 is described below
commit e86f671c8e9318309f802603e53f39cd4fd61a69
Author: Nicolas Vazquez
AuthorDate: Thu May 23 09:13:17 2019 -0300
KVM: Fix agents dont reconnect post maintenance (#3239)
* Keep connection alive when on maintenance
* Refactor cancel maintenance and unit tests
* Add marvin tests
* Refactor
* Changing the way we get ssh credentials
* Add check on SSH restart and improve marvin tests
---
agent/src/com/cloud/agent/Agent.java | 4 +-
.../src/com/cloud/resource/ResourceManager.java| 5 +
.../src/com/cloud/agent/manager/AgentAttache.java | 3 +-
server/src/com/cloud/configuration/Config.java | 8 -
.../com/cloud/resource/ResourceManagerImpl.java| 92 +++--
.../cloud/resource/ResourceManagerImplTest.java| 105 +-
test/integration/smoke/test_host_maintenance.py| 402 ++---
7 files changed, 530 insertions(+), 89 deletions(-)
diff --git a/agent/src/com/cloud/agent/Agent.java
b/agent/src/com/cloud/agent/Agent.java
index df0448d..500724d 100644
--- a/agent/src/com/cloud/agent/Agent.java
+++ b/agent/src/com/cloud/agent/Agent.java
@@ -606,9 +606,7 @@ public class Agent implements HandlerFactory, IAgentControl
{
System.exit(1);
return;
} else if (cmd instanceof MaintainCommand) {
-s_logger.debug("Received maintainCommand");
-cancelTasks();
-_reconnectAllowed = false;
+s_logger.debug("Received maintainCommand, do not
cancel current tasks");
answer = new MaintainAnswer((MaintainCommand)cmd);
} else if (cmd instanceof AgentControlCommand) {
answer = null;
diff --git a/engine/components-api/src/com/cloud/resource/ResourceManager.java
b/engine/components-api/src/com/cloud/resource/ResourceManager.java
index 720a980..b66f792 100755
--- a/engine/components-api/src/com/cloud/resource/ResourceManager.java
+++ b/engine/components-api/src/com/cloud/resource/ResourceManager.java
@@ -52,6 +52,11 @@ public interface ResourceManager extends ResourceService,
Configurable {
"Number of retries when preparing a host into Maintenance Mode is
faulty before failing",
true, ConfigKey.Scope.Cluster);
+ConfigKey KvmSshToAgentEnabled = new ConfigKey<>("Advanced",
Boolean.class,
+"kvm.ssh.to.agent","true",
+"Number of retries when preparing a host into Maintenance Mode is
faulty before failing",
+false);
+
/**
* Register a listener for different types of resource life cycle events.
* There can only be one type of listener per type of host.
diff --git a/engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java
b/engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java
index a3838e1..4f03acd 100644
--- a/engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java
+++ b/engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java
@@ -32,6 +32,7 @@ import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import com.cloud.agent.api.ModifySshKeysCommand;
+import com.cloud.agent.api.ModifyStoragePoolCommand;
import org.apache.cloudstack.managed.context.ManagedContextRunnable;
import org.apache.log4j.Logger;
@@ -115,7 +116,7 @@ public abstract class AgentAttache {
StopCommand.class.toString(),
CheckVirtualMachineCommand.class.toString(), PingTestCommand.class.toString(),
CheckHealthCommand.class.toString(),
ReadyCommand.class.toString(), ShutdownCommand.class.toString(),
SetupCommand.class.toString(),
CleanupNetworkRulesCmd.class.toString(),
CheckNetworkCommand.class.toString(), PvlanSetupCommand.class.toString(),
CheckOnHostCommand.class.toString(),
-ModifyTargetsCommand.class.toString(),
ModifySshKeysCommand.class.toString()};
+ModifyTargetsCommand.class.toString(),
ModifySshKeysCommand.class.toString(),
ModifyStoragePoolCommand.class.toString()};
protected final static String[] s_commandsNotAllowedInConnectingMode = new
String[] { StartCommand.class.toString(), CreateCommand.class.toString() };
static {
Arrays.sort(s_commandsAllowedInMaintenanceMode);
diff --git a/server/src/com/cloud/configuration/Config.java
b/server/src/com/cloud/configuration/Config.java
index 98bacf2..098d5d7 100644
--- a/server/src/com/cloud/configuration/Config.java
+++ b/server/src/com/cloud/configuration/Config.java
@@ -1211,14 +1211,6 @@ public enu
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-495194404 Yes I did! And sorry for the late reply... But t doesn't seem to make a difference. I can do some more tests early next week (I hope). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3218: vmware: don't use redundant worker VM to extract volume
rhtyd commented on issue #3218: vmware: don't use redundant worker VM to extract volume URL: https://github.com/apache/cloudstack/pull/3218#issuecomment-495194758 Thanks @DaanHoogland This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3239: KVM: Fix agents dont reconnect post maintenance
rhtyd commented on a change in pull request #3239: KVM: Fix agents dont
reconnect post maintenance
URL: https://github.com/apache/cloudstack/pull/3239#discussion_r286913960
##
File path: server/src/com/cloud/resource/ResourceManagerImpl.java
##
@@ -2344,45 +2345,76 @@ private boolean doCancelMaintenance(final long hostId)
{
}
}
+handleAgentIfNotConnected(host, vms_migrating);
+
try {
resourceStateTransitTo(host,
ResourceState.Event.AdminCancelMaintenance, _nodeId);
_agentMgr.pullAgentOutMaintenance(hostId);
retryHostMaintenance.remove(hostId);
+} catch (final NoTransitionException e) {
+s_logger.debug("Cannot transmit host " + host.getId() + "to
Enabled state", e);
+return false;
+}
-// for kvm, need to log into kvm host, restart cloudstack-agent
-if ((host.getHypervisorType() == HypervisorType.KVM &&
!vms_migrating) || host.getHypervisorType() == HypervisorType.LXC) {
+return true;
-final boolean sshToAgent =
Boolean.parseBoolean(_configDao.getValue(Config.KvmSshToAgentEnabled.key()));
-if (!sshToAgent) {
-s_logger.info("Configuration tells us not to SSH into
Agents. Please restart the Agent (" + hostId + ") manually");
-return true;
-}
+}
-_hostDao.loadDetails(host);
-final String password = host.getDetail("password");
-final String username = host.getDetail("username");
-if (password == null || username == null) {
-s_logger.debug("Can't find password/username");
-return false;
-}
-final com.trilead.ssh2.Connection connection =
SSHCmdHelper.acquireAuthorizedConnection(host.getPrivateIpAddress(), 22,
username, password);
-if (connection == null) {
-s_logger.debug("Failed to connect to host: " +
host.getPrivateIpAddress());
-return false;
-}
+/**
+ * Handle agent (if available) if its not connected before cancelling
maintenance.
+ * Agent must be connected before cancelling maintenance.
+ * If the host status is not Up:
+ * - If kvm.ssh.to.agent is true, then SSH into the host and restart the
agent.
+ * - If kvm.shh.to.agent is false, then fail cancelling maintenance
+ */
+protected void handleAgentIfNotConnected(HostVO host, boolean
vmsMigrating) {
+final boolean isAgentOnHost = host.getHypervisorType() ==
HypervisorType.KVM ||
+host.getHypervisorType() == HypervisorType.LXC;
+if (!isAgentOnHost || vmsMigrating || host.getStatus() == Status.Up) {
+return;
+}
+final boolean sshToAgent =
Boolean.parseBoolean(_configDao.getValue(KvmSshToAgentEnabled.key()));
+if (sshToAgent) {
+Pair credentials = getHostCredentials(host);
+connectAndRestartAgentOnHost(host, credentials.first(),
credentials.second());
+} else {
+throw new CloudRuntimeException("SSH access is disabled, cannot
cancel maintenance mode as " +
+"host agent is not connected");
+}
+}
-try {
-SSHCmdHelper.SSHCmdResult result =
SSHCmdHelper.sshExecuteCmdOneShot(connection, "service cloudstack-agent
restart");
-s_logger.debug("cloudstack-agent restart result: " +
result.toString());
-} catch (final SshException e) {
-return false;
-}
-}
+/**
+ * Get host credentials
+ * @throws CloudRuntimeException if username or password are not found
+ */
+protected Pair getHostCredentials(HostVO host) {
+_hostDao.loadDetails(host);
+final String password = host.getDetail("password");
+final String username = host.getDetail("username");
+if (password == null || username == null) {
+throw new CloudRuntimeException("SSH to agent is enabled, but
username/password credentials are not found");
+}
+return new Pair<>(username, password);
+}
-return true;
-} catch (final NoTransitionException e) {
-s_logger.debug("Cannot transmit host " + host.getId() + "to
Enabled state", e);
-return false;
+/**
+ * True if agent is restarted via SSH. Assumes kvm.ssh.to.agent = true and
host status is not Up
+ */
+protected void connectAndRestartAgentOnHost(HostVO host, String username,
String password) {
+final com.trilead.ssh2.Connection connection =
SSHCmdHelper.acquireAuthorizedConnection(
+host.getPrivateIpAddress(), 22, username, password);
+if (connection == null) {
+throw new CloudRuntimeException("SSH t
[GitHub] [cloudstack] DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
DaanHoogland commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-495195228 np, I hope we get to a solution that serves both use cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3239: KVM: Fix agents dont reconnect post maintenance
DaanHoogland commented on issue #3239: KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-495196693 @rhtyd @nvazquez this one won't fwd-merge again due to moved files. I'll be looking at it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.12 updated (00ff536 -> 29918e2)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 00ff536 Merge remote-tracking branch 'origin/4.11' into 4.12 add e86f671 KVM: Fix agents dont reconnect post maintenance (#3239) new 29918e2 Merge release branch 4.11 to 4.12 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/src/main/java/com/cloud/agent/Agent.java | 4 +- .../java/com/cloud/resource/ResourceManager.java | 5 + .../java/com/cloud/agent/manager/AgentAttache.java | 3 +- .../main/java/com/cloud/configuration/Config.java | 8 - .../com/cloud/resource/ResourceManagerImpl.java| 92 +++-- .../cloud/resource/ResourceManagerImplTest.java| 105 +- test/integration/smoke/test_host_maintenance.py| 402 ++--- 7 files changed, 530 insertions(+), 89 deletions(-)
[cloudstack] 01/01: Merge release branch 4.12 to master
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8b75d61ffc27eafa8fc67bdd6085f7f6fbd87c9c Merge: 62c8a11 29918e2 Author: Daan Hoogland AuthorDate: Thu May 23 14:31:21 2019 +0200 Merge release branch 4.12 to master * 4.12: KVM: Fix agents dont reconnect post maintenance (#3239) agent/src/main/java/com/cloud/agent/Agent.java | 4 +- .../java/com/cloud/resource/ResourceManager.java | 5 + .../java/com/cloud/agent/manager/AgentAttache.java | 3 +- .../main/java/com/cloud/configuration/Config.java | 8 - .../com/cloud/resource/ResourceManagerImpl.java| 92 +++-- .../cloud/resource/ResourceManagerImplTest.java| 105 +- test/integration/smoke/test_host_maintenance.py| 402 ++--- 7 files changed, 530 insertions(+), 89 deletions(-)
[cloudstack] branch master updated (62c8a11 -> 8b75d61)
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 62c8a11 Fix iops values when creating a compute offering (#3345) add e86f671 KVM: Fix agents dont reconnect post maintenance (#3239) add 29918e2 Merge release branch 4.11 to 4.12 new 8b75d61 Merge release branch 4.12 to master The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/src/main/java/com/cloud/agent/Agent.java | 4 +- .../java/com/cloud/resource/ResourceManager.java | 5 + .../java/com/cloud/agent/manager/AgentAttache.java | 3 +- .../main/java/com/cloud/configuration/Config.java | 8 - .../com/cloud/resource/ResourceManagerImpl.java| 92 +++-- .../cloud/resource/ResourceManagerImplTest.java| 105 +- test/integration/smoke/test_host_maintenance.py| 402 ++--- 7 files changed, 530 insertions(+), 89 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495198870 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3239: KVM: Fix agents dont reconnect post maintenance
DaanHoogland commented on issue #3239: KVM: Fix agents dont reconnect post maintenance URL: https://github.com/apache/cloudstack/pull/3239#issuecomment-495199831 done. simpler than thought This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-495200710 Merging based on code reviews from Bobby, Abhishek and Anurag and smoke test results and Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: server: ssh-keygen in PEM format and reduce main systemvm patching script (#3333)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 0929866 server: ssh-keygen in PEM format and reduce main systemvm
patching script (#)
0929866 is described below
commit 09298669562032c6f112cf8d407009abc42f1135
Author: Rohit Yadav
AuthorDate: Thu May 23 18:08:00 2019 +0530
server: ssh-keygen in PEM format and reduce main systemvm patching script
(#)
On first startup, the management server creates and saves a random
ssh keypair using ssh-keygen in the database. The command does
not specify keys in PEM format which is not the default as generated
by latest ssh-keygen tool.
The systemvmtemplate always needs re-building whenever there is a change
in the cloud-early-config file. This also tries to fix that by introducing a
stage 2 bootstrap.sh where the changes specific to hypervisor detection
etc are refactored/moved. The initial cloud-early-config only patches
before the other scripts are called.
Signed-off-by: Rohit Yadav
---
.travis.yml| 46 ---
.../kvm/resource/LibvirtComputingResource.java | 2 +-
.../wrapper/LibvirtStartCommandWrapper.java| 11 +-
.../com/cloud/server/ConfigurationServerImpl.java | 29 ++--
services/console-proxy-rdp/rdpconsole/pom.xml | 11 ++
.../bin/setup/{cloud-early-config => bootstrap.sh} | 114 ++--
.../debian/opt/cloud/bin/setup/cloud-early-config | 147 ++---
.../debian/opt/cloud/bin/setup/patchsystemvm.sh| 63 -
systemvm/debian/opt/cloud/bin/setup/router.sh | 4 +-
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh | 6 +-
.../scripts/install_systemvm_packages.sh | 1 +
11 files changed, 115 insertions(+), 319 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 43f2bb2..49bbc33 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -99,28 +99,30 @@ env:
smoke/test_volumes
smoke/test_vpc_redundant
smoke/test_vpc_router_nics
- smoke/test_vpc_vpn
- smoke/misc/test_deploy_vm
+ smoke/test_vpc_vpn"
+
+- TESTS="smoke/misc/test_deploy_vm
smoke/misc/test_escalations_templates
smoke/misc/test_vm_ha
- smoke/misc/test_vm_sync"
-
-- TESTS="component/find_hosts_for_migration
+ smoke/misc/test_vm_sync
+ component/find_hosts_for_migration
component/test_acl_isolatednetwork_delete
component/test_acl_listsnapshot
component/test_acl_listvm
- component/test_acl_listvolume
- component/test_acl_sharednetwork"
-
-- TESTS="component/test_allocation_states
- component/test_acl_sharednetwork_deployVM-impersonation
- component/test_affinity_groups_projects
- component/test_cpu_domain_limits
- component/test_cpu_limits"
-
-- TESTS="component/test_cpu_max_limits
- component/test_cpu_project_limits
- component/test_deploy_vm_userdata_multi_nic
+ component/test_acl_listvolume"
+
+- TESTS="component/test_acl_sharednetwork
+ component/test_acl_sharednetwork_deployVM-impersonation"
+
+- TESTS="component/test_affinity_groups_projects
+ component/test_allocation_states"
+
+- TESTS="component/test_cpu_domain_limits
+ component/test_cpu_limits
+ component/test_cpu_max_limits
+ component/test_cpu_project_limits"
+
+- TESTS="component/test_deploy_vm_userdata_multi_nic
component/test_egress_fw_rules
component/test_invalid_gw_nm
component/test_ip_reservation
@@ -129,16 +131,18 @@ env:
- TESTS="component/test_memory_limits
component/test_mm_domain_limits
component/test_mm_max_limits
- component/test_mm_project_limits
- component/test_network_offering
+ component/test_mm_project_limits"
+
+- TESTS="component/test_network_offering
component/test_non_contiguous_vlan
component/test_persistent_networks"
- TESTS="component/test_project_limits
component/test_project_configs
component/test_project_usage
- component/test_project_resources
- component/test_regions_accounts
+ component/test_project_resources"
+
+- TESTS="component/test_regions_accounts
component/test_routers
component/test_snapshots
component/test_stopped_vm"
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtC
[GitHub] [cloudstack] rhtyd merged pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script
rhtyd merged pull request #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-495201697 closing, setting ```git config global merge.renamelimit=5635``` would have done the trick. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland closed pull request #3304: server: Fix exception while update domain resource count (#3204)
DaanHoogland closed pull request #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
DaanHoogland commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495203498 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
blueorangutan commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495203658 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.12 updated (29918e2 -> d77e69a)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch 4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 29918e2 Merge release branch 4.11 to 4.12
add 0929866 server: ssh-keygen in PEM format and reduce main systemvm
patching script (#)
new d77e69a Merge remote-tracking branch 'origin/4.11' into 4.12
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.travis.yml| 46 ---
.../kvm/resource/LibvirtComputingResource.java | 2 +-
.../wrapper/LibvirtStartCommandWrapper.java| 11 +-
.../com/cloud/server/ConfigurationServerImpl.java | 29 ++--
.../bin/setup/{cloud-early-config => bootstrap.sh} | 114 ++--
.../debian/opt/cloud/bin/setup/cloud-early-config | 147 ++---
.../debian/opt/cloud/bin/setup/patchsystemvm.sh| 63 -
systemvm/debian/opt/cloud/bin/setup/router.sh | 4 +-
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh | 6 +-
.../scripts/install_systemvm_packages.sh | 1 +
10 files changed, 104 insertions(+), 319 deletions(-)
copy systemvm/debian/opt/cloud/bin/setup/{cloud-early-config => bootstrap.sh}
(68%)
delete mode 100755 systemvm/debian/opt/cloud/bin/setup/patchsystemvm.sh
[cloudstack] branch master updated (8b75d61 -> 2aa4842)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 8b75d61 Merge release branch 4.12 to master
add 0929866 server: ssh-keygen in PEM format and reduce main systemvm
patching script (#)
add d77e69a Merge remote-tracking branch 'origin/4.11' into 4.12
new 2aa4842 Merge remote-tracking branch 'origin/4.12'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.travis.yml| 46 ---
.../kvm/resource/LibvirtComputingResource.java | 2 +-
.../wrapper/LibvirtStartCommandWrapper.java| 11 +-
.../com/cloud/server/ConfigurationServerImpl.java | 29 ++--
.../bin/setup/{cloud-early-config => bootstrap.sh} | 114 ++--
.../debian/opt/cloud/bin/setup/cloud-early-config | 147 ++---
.../debian/opt/cloud/bin/setup/patchsystemvm.sh| 63 -
systemvm/debian/opt/cloud/bin/setup/router.sh | 4 +-
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh | 6 +-
.../scripts/install_systemvm_packages.sh | 1 +
10 files changed, 104 insertions(+), 319 deletions(-)
copy systemvm/debian/opt/cloud/bin/setup/{cloud-early-config => bootstrap.sh}
(68%)
delete mode 100755 systemvm/debian/opt/cloud/bin/setup/patchsystemvm.sh
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.12'
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 2aa4842a94d9ca699bd436ac2f7de275fed62fc3
Merge: 8b75d61 d77e69a
Author: Rohit Yadav
AuthorDate: Thu May 23 18:17:42 2019 +0530
Merge remote-tracking branch 'origin/4.12'
.travis.yml| 46 ---
.../kvm/resource/LibvirtComputingResource.java | 2 +-
.../wrapper/LibvirtStartCommandWrapper.java| 11 +-
.../com/cloud/server/ConfigurationServerImpl.java | 29 ++--
.../bin/setup/{cloud-early-config => bootstrap.sh} | 114 ++--
.../debian/opt/cloud/bin/setup/cloud-early-config | 147 ++---
.../debian/opt/cloud/bin/setup/patchsystemvm.sh| 63 -
systemvm/debian/opt/cloud/bin/setup/router.sh | 4 +-
systemvm/debian/opt/cloud/bin/setup/vpcrouter.sh | 6 +-
.../scripts/install_systemvm_packages.sh | 1 +
10 files changed, 104 insertions(+), 319 deletions(-)
[GitHub] [cloudstack] rhtyd commented on issue #3267: [WIP] travis reorganisation
rhtyd commented on issue #3267: [WIP] travis reorganisation URL: https://github.com/apache/cloudstack/pull/3267#issuecomment-495207061 @DaanHoogland can you test latest master, I've tried to re-arrange and fix the failing travis tests due to timeout on 4.11 and forward merged them on 4.12 and master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3267: [WIP] travis reorganisation
DaanHoogland commented on issue #3267: [WIP] travis reorganisation URL: https://github.com/apache/cloudstack/pull/3267#issuecomment-495233518 ok @rhtyd , i will rebase and force push to looksee This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3323: Fixed: User not allowed to tag project created by him
blueorangutan commented on issue #3323: Fixed: User not allowed to tag project created by him URL: https://github.com/apache/cloudstack/pull/3323#issuecomment-495237549 Trillian test result (tid-3568) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 16721 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3323-t3568-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 50 look OK, 20 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.16 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.17 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.35 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.10 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.20 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
[GitHub] [cloudstack] rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates
rhtyd commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-495242311 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates
blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-495242475 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3153: DPDK vHost User mode selection
rhtyd commented on issue #3153: DPDK vHost User mode selection URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-495242691 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates
rhtyd commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-495242611 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI
blueorangutan commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-495242868 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates
blueorangutan commented on issue #3075: WIP: Prevent regenerating keystore and add background task to upload certificates URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-495242909 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3153: DPDK vHost User mode selection
blueorangutan commented on issue #3153: DPDK vHost User mode selection URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-495242891 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
rhtyd commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-495242852 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI
rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-495242789 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3222: [WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user
rhtyd commented on issue #3222: [WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user URL: https://github.com/apache/cloudstack/pull/3222#issuecomment-495243081 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3222: [WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user
blueorangutan commented on issue #3222: [WIP DO NOT MERGE] volume: fix volume metrics view from returning sensitive info to end user URL: https://github.com/apache/cloudstack/pull/3222#issuecomment-495243280 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-495243322 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file
rhtyd commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#issuecomment-495243380 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file
blueorangutan commented on issue #3258: [WIP DO NOT MERGE] Configurable UI branding, keyboard list and hide-able columns through a new config.js file URL: https://github.com/apache/cloudstack/pull/3258#issuecomment-495243688 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility
rhtyd commented on issue #3244: [WIP DO NOT MERGE] ui: instance settings visibility URL: https://github.com/apache/cloudstack/pull/3244#issuecomment-495244310 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] dudarra commented on issue #3138: StrongSwan with several rightsubnet's - ikev1
dudarra commented on issue #3138: StrongSwan with several rightsubnet's - ikev1 URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-495244318 @andrijapanic yes! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
rhtyd commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-495243963 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3308: [WIP Do not Merge] Ignore META key mask if control was pressed.
blueorangutan commented on issue #3308: [WIP Do not Merge] Ignore META key mask if control was pressed. URL: https://github.com/apache/cloudstack/pull/3308#issuecomment-495244129 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-495244150 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
