MonetDB: Dec2023 - cleanup no longer used history api

2023-11-20 Thread Niels Nes via checkin-list
Changeset: 3a917ae41c40 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/3a917ae41c40
Modified Files:
clients/Tests/exports.stable.out
monetdb5/extras/mal_optimizer_template/opt_sql_append.c
monetdb5/mal/mal.h
monetdb5/mal/mal_instruction.c
monetdb5/mal/mal_instruction.h
monetdb5/mal/mal_listing.c
monetdb5/mal/mal_listing.h
monetdb5/mal/mal_session.c
monetdb5/optimizer/opt_wrapper.c
monetdb5/optimizer/optimizer.c
sql/backends/monet5/sql_optimizer.c
Branch: Dec2023
Log Message:

cleanup no longer used history api


diffs (truncated from 310 to 300 lines):

diff --git a/clients/Tests/exports.stable.out b/clients/Tests/exports.stable.out
--- a/clients/Tests/exports.stable.out
+++ b/clients/Tests/exports.stable.out
@@ -810,7 +810,6 @@ int UTF8_strwidth(const char *restrict s
 void addMalException(MalBlkPtr mb, str msg);
 str addOptimizerPipe(Client cntxt, MalBlkPtr mb, const char *name);
 str addPipeDefinition(Client cntxt, const char *name, const char *pipe);
-void addtoMalBlkHistory(MalBlkPtr mb);
 const char *affectedRowsRef;
 const char *aggrRef;
 const char *alarmRef;
@@ -982,8 +981,6 @@ Symbol getFunctionSymbol(Module scope, I
 int getHgeConstant(MalBlkPtr mb, hge val);
 int getIntConstant(MalBlkPtr mb, int val);
 int getLngConstant(MalBlkPtr mb, lng val);
-MalBlkPtr getMalBlkHistory(MalBlkPtr mb, int idx);
-MalBlkPtr getMalBlkOptimized(MalBlkPtr mb, const char *name);
 Module getModule(const char *nme);
 void getModuleList(Module **out, int *length);
 BAT *getModules(void);
@@ -1208,7 +1205,6 @@ const char *remapRef;
 const char *remoteRef;
 void removeInstruction(MalBlkPtr mb, InstrPtr p);
 void removeInstructionBlock(MalBlkPtr mb, int pc, int cnt);
-void removeMalBlkHistory(MalBlkPtr mb);
 void renameVariables(MalBlkPtr mb);
 const char *rename_columnRef;
 const char *rename_schemaRef;
@@ -1246,7 +1242,6 @@ const char *setVariableRef;
 void setVariableScope(MalBlkPtr mb);
 void setVariableType(MalBlkPtr mb, const int idx, malType type);
 const char *set_protocolRef;
-void showMalBlkHistory(stream *out, MalBlkPtr mb);
 const char *singleRef;
 void slash_2_dir_sep(str fname);
 const char *sliceRef;
diff --git a/monetdb5/extras/mal_optimizer_template/opt_sql_append.c 
b/monetdb5/extras/mal_optimizer_template/opt_sql_append.c
--- a/monetdb5/extras/mal_optimizer_template/opt_sql_append.c
+++ b/monetdb5/extras/mal_optimizer_template/opt_sql_append.c
@@ -292,11 +292,8 @@ OPTsql_append(Client cntxt, MalBlkPtr mb
mb = s->def;
stk= 0;
}
-   if( mb->errors ){
-   /* when we have errors, we still want to see them */
-   addtoMalBlkHistory(mb);
+   if (mb->errors)
return MAL_SUCCEED;
-   }
actions = OPTsql_appendImplementation(cntxt, mb,stk,p);
 
/* Defense line against incorrect plans */
diff --git a/monetdb5/mal/mal.h b/monetdb5/mal/mal.h
--- a/monetdb5/mal/mal.h
+++ b/monetdb5/mal/mal.h
@@ -180,10 +180,7 @@ typedef struct MALBLK {
 unsafeProp:1;  /* unsafe property */
 
str errors; /* left over errors */
-   struct MALBLK *history; /* of optimizer actions */
-   short keephistory;  /* do we need the history at 
all */
int maxarg; /* keep track on the 
maximal arguments used */
-   ptr replica;/* for the replicator tests */
 
/* During the run we keep track on the maximum number of concurrent 
threads and memory claim */
ATOMIC_TYPE workers;
diff --git a/monetdb5/mal/mal_instruction.c b/monetdb5/mal/mal_instruction.c
--- a/monetdb5/mal/mal_instruction.c
+++ b/monetdb5/mal/mal_instruction.c
@@ -265,10 +265,6 @@ freeMalBlk(MalBlkPtr mb)
GDKfree(mb->var);
mb->var = 0;
 
-   if (mb->history) {
-   freeMalBlk(mb->history);
-   mb->history = NULL;
-   }
mb->binding[0] = 0;
mb->tag = 0;
mb->memory = 0;
@@ -295,8 +291,6 @@ copyMalBlk(MalBlkPtr old)
if (mb == NULL)
return NULL;
mb->alternative = old->alternative;
-   mb->history = NULL;
-   mb->keephistory = old->keephistory;
 
mb->var = (VarRecord *) GDKzalloc(sizeof(VarRecord) * old->vsize);
if (mb->var == NULL) {
@@ -342,7 +336,6 @@ copyMalBlk(MalBlkPtr old)
mb->runtime = old->runtime;
mb->calls = old->calls;
mb->optimize = old->optimize;
-   mb->replica = old->replica;
mb->maxarg = old->maxarg;
mb->inlineProp = old->inlineProp;
mb->unsafeProp = old->unsafeProp;
@@ -359,74 +352,6 @@ copyMalBlk(MalBlkPtr old)
return NULL;
 }
 
-void
-addtoMalBlkHistory(MalBlkPtr mb)
-{
-   if (mb->keephistory) {
-   MalBlkPtr cpy = copyMalBlk(mb);
-   if (cpy == NULL)
- 

MonetDB: Jun2023 - Jun2023-SP3 was released.

2023-11-20 Thread Sjoerd Mullender via checkin-list
Changeset: df731c8a698d for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/df731c8a698d
Modified Files:
.hgtags
Branch: Jun2023
Log Message:

Jun2023-SP3 was released.


diffs (8 lines):

diff --git a/.hgtags b/.hgtags
--- a/.hgtags
+++ b/.hgtags
@@ -816,3 +816,4 @@ 6f88424ebfd9d82c072cf21d89070e04321983da
 e6eb06773c17035954ac5d001cfe1f09ff3425cc Jun2023_13
 5683fd900f28d65ad7c98d1ed1efd992023a7fa4 Jun2023_15
 c9e6096e7519636a4e840c7a0c2e27cccb7dc0fe Jun2023_17
+c9e6096e7519636a4e840c7a0c2e27cccb7dc0fe Jun2023_SP3_release
___
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org


MonetDB: Jun2023 - Approve upgrades after release.

2023-11-20 Thread Sjoerd Mullender via checkin-list
Changeset: b2d23d71172c for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/b2d23d71172c
Modified Files:
sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-chain/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-hge/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade/Tests/upgrade.stable.out.int128
Branch: Jun2023
Log Message:

Approve upgrades after release.


diffs (96 lines):

diff --git a/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
@@ -1,5 +0,0 @@
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
@@ -69,8 +69,3 @@ update sys.functions set system = true w
 update sys.functions set system = true where system <> true and name in 
('stddev_samp', 'stddev_pop', 'var_samp', 'covar_samp', 'var_pop', 'covar_pop', 
'corr') and schema_id = (select id from sys.schemas where name = 'sys') and 
type = 6;
 update sys.functions set system = true where system <> true and name = 
'filter' and schema_id = (select id from sys.schemas where name = 'json') and 
type = 1;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git 
a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128 
b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
--- a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
+++ b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
@@ -69,8 +69,3 @@ update sys.functions set system = true w
 update sys.functions set system = true where system <> true and name in 
('stddev_samp', 'stddev_pop', 'var_samp', 'covar_samp', 'var_pop', 'covar_pop', 
'corr') and schema_id = (select id from sys.schemas where name = 'sys') and 
type = 6;
 update sys.functions set system = true where system <> true and name = 
'filter' and schema_id = (select id from sys.schemas where name = 'json') and 
type = 1;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
@@ -1,5 +0,0 @@
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
@@ -69,8 +69,3 @@ update sys.functions set system = true w
 update sys.functions set system = true where system <> true and name in 
('stddev_samp', 'stddev_pop', 'var_samp', 'covar_samp', 'var_pop', 'covar_pop', 
'corr') and schema_id = (select id from sys.schemas where name = 'sys') and 
type = 6;
 update sys.functions set system = true where system <> true and name = 
'

MonetDB: Dec2023 - Merge with Jun2023 branch.

2023-11-20 Thread Sjoerd Mullender via checkin-list
Changeset: b998f28b6825 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/b998f28b6825
Modified Files:
.hgtags
sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-chain/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade-hge/Tests/upgrade.stable.out.int128
sql/test/testdb-upgrade/Tests/upgrade.stable.out.int128
testing/CMakeLists.txt
Branch: Dec2023
Log Message:

Merge with Jun2023 branch.


diffs (116 lines):

diff --git a/.hgtags b/.hgtags
--- a/.hgtags
+++ b/.hgtags
@@ -817,3 +817,4 @@ e6eb06773c17035954ac5d001cfe1f09ff3425cc
 5683fd900f28d65ad7c98d1ed1efd992023a7fa4 Jun2023_15
 c5b17681b55e6ca155db28be59913699e561502a Dec2023_root
 c9e6096e7519636a4e840c7a0c2e27cccb7dc0fe Jun2023_17
+c9e6096e7519636a4e840c7a0c2e27cccb7dc0fe Jun2023_SP3_release
diff --git a/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-chain-hge/Tests/upgrade.stable.out.int128
@@ -550,8 +550,3 @@ GRANT EXECUTE ON FUNCTION sys.persist_un
 UPDATE sys.functions SET system = true WHERE system <> true AND
 name = 'persist_unlogged' AND schema_id = 2000;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.int128
@@ -619,8 +619,3 @@ GRANT EXECUTE ON FUNCTION sys.persist_un
 UPDATE sys.functions SET system = true WHERE system <> true AND
 name = 'persist_unlogged' AND schema_id = 2000;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git 
a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128 
b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
--- a/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
+++ b/sql/test/emptydb-upgrade-chain/Tests/upgrade.stable.out.ppc64.int128
@@ -619,8 +619,3 @@ GRANT EXECUTE ON FUNCTION sys.persist_un
 UPDATE sys.functions SET system = true WHERE system <> true AND
 name = 'persist_unlogged' AND schema_id = 2000;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade-hge/Tests/upgrade.stable.out.int128
@@ -550,8 +550,3 @@ GRANT EXECUTE ON FUNCTION sys.persist_un
 UPDATE sys.functions SET system = true WHERE system <> true AND
 name = 'persist_unlogged' AND schema_id = 2000;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_str(d TIMESTAMP, format STRING) RETURNS STRING 
EXTERNAL NAME mtime."timestamp_to_str";
-GRANT EXECUTE ON FUNCTION timestamp_to_str(TIMESTAMP, STRING) TO PUBLIC;
-UPDATE sys.functions SET system = true WHERE system <> true AND name = 
'timestamp_to_str' AND schema_id = 2000 and type = 1;
-
diff --git a/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128 
b/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
--- a/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
+++ b/sql/test/emptydb-upgrade/Tests/upgrade.stable.out.int128
@@ -619,8 +619,3 @@ GRANT EXECUTE ON FUNCTION sys.persist_un
 UPDATE sys.functions SET system = true WHERE system <> true AND
 name = 'persist_unlogged' AND schema_id = 2000;
 
-Running database upgrade commands:
-CREATE FUNCTION timestamp_to_

MonetDB: Dec2023 - Removed BATroles and tident (T.id) field in B...

2023-11-20 Thread Sjoerd Mullender via checkin-list
Changeset: d6875b13c087 for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/d6875b13c087
Modified Files:
clients/Tests/MAL-signatures-hge.test
clients/Tests/MAL-signatures.test
clients/Tests/exports.stable.out
gdk/ChangeLog.Dec2023
gdk/gdk.h
gdk/gdk_bat.c
gdk/gdk_bbp.c
gdk/gdk_private.h
gdk/gdk_storage.c
gdk/gdk_string.c
monetdb5/ChangeLog.Dec2023
monetdb5/mal/Tests/tst1604.maltest
monetdb5/mal/Tests/tst202.maltest
monetdb5/mal/Tests/tst210.maltest
monetdb5/modules/kernel/bat5.c
monetdb5/modules/mal/bbp.c
monetdb5/modules/mal/clients.c
monetdb5/modules/mal/inspect.c
monetdb5/modules/mal/mdb.c
testing/mapicursor.py
Branch: Dec2023
Log Message:

Removed BATroles and tident (T.id) field in BATs.
Also removed bat.getRole and bat.setColumn which uses/sets this
information.


diffs (truncated from 819 to 300 lines):

diff --git a/clients/Tests/MAL-signatures-hge.test 
b/clients/Tests/MAL-signatures-hge.test
--- a/clients/Tests/MAL-signatures-hge.test
+++ b/clients/Tests/MAL-signatures-hge.test
@@ -3784,11 +3784,6 @@ command bat.getName(X_0:bat[:any_1]):str
 BKCgetBBPname;
 Gives back the logical name of a BAT.
 bat
-getRole
-command bat.getRole(X_0:bat[:any_1]):str 
-BKCgetRole;
-Returns the rolename of the head column of a BAT.
-bat
 getSequenceBase
 command bat.getSequenceBase(X_0:bat[:any_1]):oid 
 BKCgetSequenceBase;
@@ -4039,11 +4034,6 @@ command bat.setAccess(X_0:bat[:any_1], X
 BKCsetAccess;
 Try to change the update access privileges @to this BAT. Mode:@r[ead-only] 
 - allow only read access.@a[append-only]   - allow reads and 
update.@w[riteable]  - allow all operations.@BATs are updatable by default. 
On making a BAT read-only, @all subsequent updates fail with an error 
message.@Returns the BAT itself.
 bat
-setColumn
-command bat.setColumn(X_0:bat[:any_1], X_1:str):void 
-BKCsetColumn;
-Give a logical name to the tail column of a BAT.
-bat
 setHash
 command bat.setHash(X_0:bat[:any_1]):bit 
 BKCsetHash;
diff --git a/clients/Tests/MAL-signatures.test 
b/clients/Tests/MAL-signatures.test
--- a/clients/Tests/MAL-signatures.test
+++ b/clients/Tests/MAL-signatures.test
@@ -3219,11 +3219,6 @@ command bat.getName(X_0:bat[:any_1]):str
 BKCgetBBPname;
 Gives back the logical name of a BAT.
 bat
-getRole
-command bat.getRole(X_0:bat[:any_1]):str 
-BKCgetRole;
-Returns the rolename of the head column of a BAT.
-bat
 getSequenceBase
 command bat.getSequenceBase(X_0:bat[:any_1]):oid 
 BKCgetSequenceBase;
@@ -3464,11 +3459,6 @@ command bat.setAccess(X_0:bat[:any_1], X
 BKCsetAccess;
 Try to change the update access privileges @to this BAT. Mode:@r[ead-only] 
 - allow only read access.@a[append-only]   - allow reads and 
update.@w[riteable]  - allow all operations.@BATs are updatable by default. 
On making a BAT read-only, @all subsequent updates fail with an error 
message.@Returns the BAT itself.
 bat
-setColumn
-command bat.setColumn(X_0:bat[:any_1], X_1:str):void 
-BKCsetColumn;
-Give a logical name to the tail column of a BAT.
-bat
 setHash
 command bat.setHash(X_0:bat[:any_1]):bit 
 BKCsetHash;
diff --git a/clients/Tests/exports.stable.out b/clients/Tests/exports.stable.out
--- a/clients/Tests/exports.stable.out
+++ b/clients/Tests/exports.stable.out
@@ -187,7 +187,6 @@ gdk_return BATreplace(BAT *b, BAT *p, BA
 gdk_return BATreplacepos(BAT *b, const oid *positions, BAT *n, bool autoincr, 
bool force) __attribute__((__warn_unused_result__));
 void BATrmprop(BAT *b, enum prop_t idx);
 void BATrmprop_nolock(BAT *b, enum prop_t idx);
-gdk_return BATroles(BAT *b, const char *tnme);
 gdk_return BATrtree(BAT *wkb, BAT *mbr);
 BAT *BATsample(BAT *b, BUN n);
 BAT *BATsample_with_seed(BAT *b, BUN n, uint64_t seed);
diff --git a/gdk/ChangeLog.Dec2023 b/gdk/ChangeLog.Dec2023
--- a/gdk/ChangeLog.Dec2023
+++ b/gdk/ChangeLog.Dec2023
@@ -1,6 +1,9 @@
 # ChangeLog file for GDK
 # This file is updated with Maddlog
 
+* Mon Nov 20 2023 Sjoerd Mullender 
+- Removed function BATroles to set column names on BATs.
+
 * Thu Nov  2 2023 Sjoerd Mullender 
 - Removed the compiled-in limit on the number of threads that can be used.
   The number of threads are still limited, but the limit is dictated
diff --git a/gdk/gdk.h b/gdk/gdk.h
--- a/gdk/gdk.h
+++ b/gdk/gdk.h
@@ -686,7 +686,6 @@ gdk_export bool VALisnil(const ValRecord
  *   BUNbatCount; // Tuple count
  *   // Tail properties
  *   intttype;// Tail type number
- *   strtident;   // name for tail column
  *   bool   tkey; // tail values are unique
  *   bool   tnonil;   // tail has no nils
  *   bool   tsorted;  // are tail values currently ordered?
@@ -718,8 +717,6 @@ typedef struct PROPrec PROPrec;
 /* see also comment near BATassertProps() for more information about
  * the prope

MonetDB: default - Renames remote replica tests

2023-11-20 Thread stefanos mavros via checkin-list
Changeset: 17370b1fb3bc for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/17370b1fb3bc
Added Files:
sql/test/rel-optimizers/Tests/remote-replica-plan.reqtests
sql/test/rel-optimizers/Tests/remote-replica-plan.test
Removed Files:
sql/test/rel-optimizers/Tests/remote-replica.reqtests
sql/test/rel-optimizers/Tests/remote-replica.test
Branch: default
Log Message:

Renames remote replica tests


diffs (6 lines):

diff --git a/sql/test/rel-optimizers/Tests/remote-replica.reqtests 
b/sql/test/rel-optimizers/Tests/remote-replica-plan.reqtests
rename from sql/test/rel-optimizers/Tests/remote-replica.reqtests
rename to sql/test/rel-optimizers/Tests/remote-replica-plan.reqtests
diff --git a/sql/test/rel-optimizers/Tests/remote-replica.test 
b/sql/test/rel-optimizers/Tests/remote-replica-plan.test
rename from sql/test/rel-optimizers/Tests/remote-replica.test
rename to sql/test/rel-optimizers/Tests/remote-replica-plan.test
___
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org


MonetDB: default - Fixes crash for replicas with non local parts

2023-11-20 Thread stefanos mavros via checkin-list
Changeset: e69252fa5bae for MonetDB
URL: https://dev.monetdb.org/hg/MonetDB/rev/e69252fa5bae
Modified Files:
sql/server/rel_distribute.c
Branch: default
Log Message:

Fixes crash for replicas with non local parts


diffs (13 lines):

diff --git a/sql/server/rel_distribute.c b/sql/server/rel_distribute.c
--- a/sql/server/rel_distribute.c
+++ b/sql/server/rel_distribute.c
@@ -149,7 +149,8 @@ replica_rewrite(visitor *v, sql_table *t
if (list_length(rp->value.pval) > 1) {
list *uri = sa_list(v->sql->sa);
tid_uri *tu = 
SA_NEW(v->sql->sa, tid_uri);
-   tu->id = 0;
+   /* sql_gencode requires the 
proper tableid */
+   tu->id = p->member;
tu->uri = pt->query;
append(uri, tu);
rp->value.pval = uri;
___
checkin-list mailing list -- checkin-list@monetdb.org
To unsubscribe send an email to checkin-list-le...@monetdb.org