[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

2021-10-21 Thread ntfshard via Phabricator via cfe-commits 
ntfshard added a comment.

It seems I faced with degradation in compile time.




Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:68
+return hash_value(
+std::pair(Tag.getDevice(), Tag.getFile()));
+  }

In this line a narrow conversion, and MSVC compiler can't build it with 
warnings as error key. 
getDevice and getFile returns uint64_t but pair expects unsigned ints.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110925/new/

https://reviews.llvm.org/D110925

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110925: [clangd] Follow-up on rGdea48079b90d

2021-10-21 Thread ntfshard via Phabricator via cfe-commits 
ntfshard added a comment.

Still not sure, getHashValue function returns unsigned, but seems it should 
return hash_code or result of operator size_t()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110925/new/

https://reviews.llvm.org/D110925

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits