[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea updated this revision to Diff 546962.
SuperSodaSea added a comment.

Update patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154646/new/

https://reviews.llvm.org/D154646

Files:
  clang/include/clang/AST/Expr.h
  clang/lib/Serialization/ASTWriter.cpp
  flang/include/flang/Lower/Support/Utils.h
  flang/lib/Evaluate/shape.cpp
  mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
  openmp/libomptarget/test/lit.cfg

Index: openmp/libomptarget/test/lit.cfg
===
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -49,7 +49,7 @@
 else:
 config.environment[name] = value
 
-# Evalute the environment variable which is a string boolean value.
+# Evaluate the environment variable which is a string boolean value.
 def evaluate_bool_env(env):
 env = env.lower()
 possible_true_values = ["on", "true", "1"]
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
===
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
@@ -324,7 +324,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_front(
 cast(*this->getOperation())
 .getNumDpsInputs());
@@ -342,7 +342,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_back(
 cast(*this->getOperation())
 .getNumDpsInits());
@@ -421,7 +421,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return *(indexingMaps.begin() +
  cast(*this->getOperation())
  .getNumDpsInputs() +
@@ -442,7 +442,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 int64_t resultIndex =
 opOperand->getOperandNumber() -
 cast(*this->getOperation())
@@ -807,7 +807,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 ////
 
 int64_t getNumDpsInputs() {
Index: flang/lib/Evaluate/shape.cpp
===
--- flang/lib/Evaluate/shape.cpp
+++ flang/lib/Evaluate/shape.cpp
@@ -1066,7 +1066,7 @@
   result = std::move(result) + std::move(n);
   if (context_) {
 // Fold during expression creation to avoid creating an expression so
-// large we can't evalute it without overflowing the stack.
+// large we can't evaluate it without overflowing the stack.
 result = Fold(*context_, std::move(result));
   }
 }
Index: flang/include/flang/Lower/Support/Utils.h
===
--- flang/include/flang/Lower/Support/Utils.h
+++ flang/include/flang/Lower/Support/Utils.h
@@ -89,7 +89,7 @@
 // Fortran::evaluate::Expr are functional values organized like an AST. A
 // Fortran::evaluate::Expr is meant to be moved and cloned. Using the front end
 // tools can often cause copies and extra wrapper classes to be added to any
-// Fortran::evalute::Expr. These values should not be assumed or relied upon to
+// Fortran::evaluate::Expr. These values should not be assumed or relied upon to
 // have an *object* identity. They are deeply recursive, irregular structures
 // built from a 

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea added a comment.

I don't have commit access, so if anyone could help commit this patch for me, I 
would appreciate it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154646/new/

https://reviews.llvm.org/D154646

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea abandoned this revision.
SuperSodaSea added a comment.

(Moved to https://github.com/llvm/llvm-project/pull/65906.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154646/new/

https://reviews.llvm.org/D154646

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea created this revision.
Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, 
mravishankar, awarzynski, sdasgup3, wenzhicui, wrengr, jsetoain, hanchung, 
cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, 
Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, 
rriddle, mehdi_amini.
Herald added projects: Flang, All.
SuperSodaSea requested review of this revision.
Herald added subscribers: openmp-commits, cfe-commits, stephenneuendorffer, 
nicolasvasilache, jdoerfert.
Herald added a reviewer: nicolasvasilache.
Herald added projects: clang, OpenMP, MLIR.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154646

Files:
  clang/include/clang/AST/Expr.h
  clang/lib/Serialization/ASTWriter.cpp
  flang/include/flang/Lower/Support/Utils.h
  flang/lib/Evaluate/shape.cpp
  mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
  openmp/libomptarget/test/lit.cfg

Index: openmp/libomptarget/test/lit.cfg
===
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -41,7 +41,7 @@
 else:
 config.environment[name] = value
 
-# Evalute the environment variable which is a string boolean value.
+# Evaluate the environment variable which is a string boolean value.
 def evaluate_bool_env(env):
 env = env.lower()
 possible_true_values = ["on", "true", "1"]
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
===
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
@@ -324,7 +324,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_front(
 cast(*this->getOperation())
 .getNumDpsInputs());
@@ -342,7 +342,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_back(
 cast(*this->getOperation())
 .getNumDpsInits());
@@ -421,7 +421,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return *(indexingMaps.begin() +
  cast(*this->getOperation())
  .getNumDpsInputs() +
@@ -442,7 +442,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 int64_t resultIndex =
 opOperand->getOperandNumber() -
 cast(*this->getOperation())
@@ -807,7 +807,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 ////
 
 int64_t getNumDpsInputs() {
Index: flang/lib/Evaluate/shape.cpp
===
--- flang/lib/Evaluate/shape.cpp
+++ flang/lib/Evaluate/shape.cpp
@@ -1039,7 +1039,7 @@
   result = std::move(result) + std::move(n);
   if (context_) {
 // Fold during expression creation to avoid creating an expression so
-// large we can't evalute it without overflowing the stack.
+// large we can't evaluate it without overflowing the stack.
 result = Fold(*context_, std::move(result));
   }
 }
Index: flang/include/flang/Lower/Support/Utils.h
===
--- flang/include/flang/Lower/Support/Utils.h
+++ flang/include/flang/Lower/Support/Utils.h
@@

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea updated this revision to Diff 537842.
SuperSodaSea added a comment.
Herald added a reviewer: jdoerfert.
Herald added subscribers: jplehr, sstefan1.

Add more context in patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154646/new/

https://reviews.llvm.org/D154646

Files:
  clang/include/clang/AST/Expr.h
  clang/lib/Serialization/ASTWriter.cpp
  flang/include/flang/Lower/Support/Utils.h
  flang/lib/Evaluate/shape.cpp
  mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
  openmp/libomptarget/test/lit.cfg

Index: openmp/libomptarget/test/lit.cfg
===
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -41,7 +41,7 @@
 else:
 config.environment[name] = value
 
-# Evalute the environment variable which is a string boolean value.
+# Evaluate the environment variable which is a string boolean value.
 def evaluate_bool_env(env):
 env = env.lower()
 possible_true_values = ["on", "true", "1"]
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
===
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
@@ -324,7 +324,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_front(
 cast(*this->getOperation())
 .getNumDpsInputs());
@@ -342,7 +342,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_back(
 cast(*this->getOperation())
 .getNumDpsInits());
@@ -421,7 +421,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return *(indexingMaps.begin() +
  cast(*this->getOperation())
  .getNumDpsInputs() +
@@ -442,7 +442,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 int64_t resultIndex =
 opOperand->getOperandNumber() -
 cast(*this->getOperation())
@@ -807,7 +807,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 ////
 
 int64_t getNumDpsInputs() {
Index: flang/lib/Evaluate/shape.cpp
===
--- flang/lib/Evaluate/shape.cpp
+++ flang/lib/Evaluate/shape.cpp
@@ -1039,7 +1039,7 @@
   result = std::move(result) + std::move(n);
   if (context_) {
 // Fold during expression creation to avoid creating an expression so
-// large we can't evalute it without overflowing the stack.
+// large we can't evaluate it without overflowing the stack.
 result = Fold(*context_, std::move(result));
   }
 }
Index: flang/include/flang/Lower/Support/Utils.h
===
--- flang/include/flang/Lower/Support/Utils.h
+++ flang/include/flang/Lower/Support/Utils.h
@@ -89,7 +89,7 @@
 // Fortran::evaluate::Expr are functional values organized like an AST. A
 // Fortran::evaluate::Expr is meant to be moved and cloned. Using the front end
 // tools can often cause copies and extra wrapper classes to be added to any
-// Fortran::evalute::Expr. These values should not be assumed or relied upon to
+// Fortran::evaluate::Expr. These values should not be assumed or relied upon to
 //

[PATCH] D154646: Fix some typos in comments: evalute -> evaluate (NFC)

[Tianlan Zhou via Phabricator via cfe-commits]

SuperSodaSea updated this revision to Diff 540621.
SuperSodaSea retitled this revision from "Fix some typos in comments: evalute 
-> evaluate" to "Fix some typos in comments: evalute -> evaluate (NFC)".
SuperSodaSea added a comment.

Update patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154646/new/

https://reviews.llvm.org/D154646

Files:
  clang/include/clang/AST/Expr.h
  clang/lib/Serialization/ASTWriter.cpp
  flang/include/flang/Lower/Support/Utils.h
  flang/lib/Evaluate/shape.cpp
  mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
  openmp/libomptarget/test/lit.cfg

Index: openmp/libomptarget/test/lit.cfg
===
--- openmp/libomptarget/test/lit.cfg
+++ openmp/libomptarget/test/lit.cfg
@@ -49,7 +49,7 @@
 else:
 config.environment[name] = value
 
-# Evalute the environment variable which is a string boolean value.
+# Evaluate the environment variable which is a string boolean value.
 def evaluate_bool_env(env):
 env = env.lower()
 possible_true_values = ["on", "true", "1"]
Index: mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
===
--- mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
+++ mlir/include/mlir/Dialect/Linalg/IR/LinalgInterfaces.td
@@ -324,7 +324,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_front(
 cast(*this->getOperation())
 .getNumDpsInputs());
@@ -342,7 +342,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return getBlock()->getArguments().take_back(
 cast(*this->getOperation())
 .getNumDpsInits());
@@ -421,7 +421,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 return *(indexingMaps.begin() +
  cast(*this->getOperation())
  .getNumDpsInputs() +
@@ -442,7 +442,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 int64_t resultIndex =
 opOperand->getOperandNumber() -
 cast(*this->getOperation())
@@ -807,7 +807,7 @@
 // MLIR currently does not support dependent interfaces or interface
 // inheritance. By construction all ops with StructuredOpInterface must
 // implement DestinationStyleOpInterface.
-// TODO: reevalute the need for a cast when a better mechanism exists.
+// TODO: reevaluate the need for a cast when a better mechanism exists.
 ////
 
 int64_t getNumDpsInputs() {
Index: flang/lib/Evaluate/shape.cpp
===
--- flang/lib/Evaluate/shape.cpp
+++ flang/lib/Evaluate/shape.cpp
@@ -1039,7 +1039,7 @@
   result = std::move(result) + std::move(n);
   if (context_) {
 // Fold during expression creation to avoid creating an expression so
-// large we can't evalute it without overflowing the stack.
+// large we can't evaluate it without overflowing the stack.
 result = Fold(*context_, std::move(result));
   }
 }
Index: flang/include/flang/Lower/Support/Utils.h
===
--- flang/include/flang/Lower/Support/Utils.h
+++ flang/include/flang/Lower/Support/Utils.h
@@ -89,7 +89,7 @@
 // Fortran::evaluate::Expr are functional values organized like an AST. A
 // Fortran::evaluate::Expr is meant to be moved and cloned. Using the front end
 // tools can often cause copies and extra wrapper classes to be added to any
-// Fortran::evalute::Expr. These values should not be assumed or relied upon to
+// Fortran::evaluate::Expr