[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets
rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm I get: CMake Error in /Users/shubhamrastogi/Development/llvm-project-cas/llvm-project/clang/lib/Headers/CMakeLists.txt: The custom command generating /Users/shubhamrastogi/Development/llvm-project-cas/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/float.h is attached to multiple targets: x86-resource-headers windows-resource-headers webassembly-resource-headers systemz-resource-headers mips-resource-headers arm-resource-headers cuda-resource-headers riscv-resource-headers ppc-resource-headers opencl-resource-headers aarch64-resource-headers hip-resource-headers ve-resource-headers hexagon-resource-headers clang-resource-headers but none of these is a common dependency of the other(s). This is not allowed by the Xcode "new build system". CMake Error in /Users/shubhamrastogi/Development/llvm-project-cas/llvm-project/third-party/benchmark/CMakeLists.txt: The custom command generating /Users/shubhamrastogi/Development/llvm-project-cas/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/float.h is attached to multiple targets: x86-resource-headers windows-resource-headers webassembly-resource-headers systemz-resource-headers mips-resource-headers arm-resource-headers cuda-resource-headers riscv-resource-headers ppc-resource-headers opencl-resource-headers aarch64-resource-headers hip-resource-headers ve-resource-headers hexagon-resource-headers clang-resource-headers but none of these is a common dependency of the other(s). This is not allowed by the Xcode "new build system". I used git bisect to figure this out, is there some solution to this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets
rastogishubham added a comment. Hi Qiongsi Thanks for the response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets
rastogishubham added a comment. Hi Qiongsi, Thank you for your work on the patch, it seems to work now! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D125052: [HLSL] Enable vector types for hlsl.
rastogishubham added a comment. Hi, this patch causes an issue with the CMake Xcode build configuration, if I try to use xcode as the generator with CMake, using the build command: xcrun cmake -G Xcode -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DLLVM_ENABLE_PROJECTS='clang;' -DCMAKE_IGNORE_PATH="/usr/lib;/usr/local/lib;/lib" -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm I get: CMake Error in /Users/shubham/Development/llvm-project/clang/lib/Headers/CMakeLists.txt: The custom command generating /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h is attached to multiple targets: hlsl-resource-headers clang-resource-headers but none of these is a common dependency of the other(s). This is not allowed by the Xcode "new build system". CMake Error in /Users/shubham/Development/llvm-project/third-party/benchmark/CMakeLists.txt: The custom command generating /Users/shubham/Development/llvm-project/build/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)/lib/clang/15.0.0/include/hlsl.h is attached to multiple targets: hlsl-resource-headers clang-resource-headers but none of these is a common dependency of the other(s). This is not allowed by the Xcode "new build system". CMake Generate step failed. Build files cannot be regenerated correctly. This is similar to the issue that was found in this patch: https://reviews.llvm.org/D123498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.
rastogishubham added a comment. Hi! This seems to work just fine. LGTM! Shubham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126892/new/ https://reviews.llvm.org/D126892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D147747: Add test to verify behavior of .cfi_sections .debug_frame intrinsic
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfe8eab468eee: Add tests to verify behavior of .cfi_sections
.debug_frame intrinsic. (authored by rastogishubham).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147747/new/
https://reviews.llvm.org/D147747
Files:
clang/test/Driver/test-uwtable.cpp
llvm/test/DebugInfo/AArch64/test-fexceptions-debug-frame.ll
llvm/test/DebugInfo/AArch64/test-fno-exceptions-debug-frame.ll
llvm/test/DebugInfo/X86/test-fexceptions-debug-frame.ll
llvm/test/DebugInfo/X86/test-fno-exceptions-debug-frame.ll
Index: llvm/test/DebugInfo/X86/test-fno-exceptions-debug-frame.ll
===
--- /dev/null
+++ llvm/test/DebugInfo/X86/test-fno-exceptions-debug-frame.ll
@@ -0,0 +1,43 @@
+; This test is added to provide test coverage for the
+; .cfi_sections .debug_frame intrinsic. It aims to make sure that for an X86_64
+; output compiled with -fno-exceptions, no .cfi_sections .debug_frame is
+; emitted.
+
+; RUN: llc --filetype=asm %s -o - | FileCheck %s
+; CHECK-NOT: .cfi_sections .debug_frame
+; CHECK: .cfi_startproc
+
+; ModuleID = 'test.cpp'
+source_filename = "test.cpp"
+target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx13.0.0"
+
+; Function Attrs: noinline norecurse nounwind optnone ssp uwtable
+define i32 @main() #0 !dbg !10 {
+ %1 = alloca i32, align 4
+ store i32 0, ptr %1, align 4
+ ret i32 1, !dbg !15
+}
+
+attributes #0 = { noinline norecurse nounwind optnone ssp uwtable }
+
+!llvm.module.flags = !{!0, !1, !2, !3, !4, !5, !6}
+!llvm.dbg.cu = !{!7}
+!llvm.ident = !{!9}
+
+!0 = !{i32 2, !"SDK Version", [2 x i32] [i32 14, i32 0]}
+!1 = !{i32 7, !"Dwarf Version", i32 4}
+!2 = !{i32 2, !"Debug Info Version", i32 3}
+!3 = !{i32 1, !"wchar_size", i32 4}
+!4 = !{i32 8, !"PIC Level", i32 2}
+!5 = !{i32 7, !"uwtable", i32 2}
+!6 = !{i32 7, !"frame-pointer", i32 2}
+!7 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !8, producer: "clang", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, splitDebugInlining: false, nameTableKind: None, sysroot: "/Applications/Xcode.app", sdk: "MacOSX.sdk")
+!8 = !DIFile(filename: "test.cpp", directory: "/Users/shubham/Development")
+!9 = !{!"clang"}
+!10 = distinct !DISubprogram(name: "main", scope: !8, file: !8, line: 1, type: !11, scopeLine: 1, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !7, retainedNodes: !14)
+!11 = !DISubroutineType(types: !12)
+!12 = !{!13}
+!13 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
+!14 = !{}
+!15 = !DILocation(line: 2, column: 5, scope: !10)
Index: llvm/test/DebugInfo/X86/test-fexceptions-debug-frame.ll
===
--- /dev/null
+++ llvm/test/DebugInfo/X86/test-fexceptions-debug-frame.ll
@@ -0,0 +1,42 @@
+; This test is added to provide test coverage for the
+; .cfi_sections .debug_frame intrinsic. It aims to make sure that for an X86_64
+; output compiled with -fexceptions, no .cfi_sections .debug_frame is emitted.
+
+; RUN: llc --filetype=asm %s -o - | FileCheck %s
+; CHECK-NOT: .cfi_sections .debug_frame
+; CHECK: .cfi_startproc
+
+; ModuleID = 'test.cpp'
+source_filename = "test.cpp"
+target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-apple-macosx13.0.0"
+
+; Function Attrs: noinline norecurse nounwind optnone ssp uwtable
+define i32 @main() #0 !dbg !10 {
+ %1 = alloca i32, align 4
+ store i32 0, ptr %1, align 4
+ ret i32 1, !dbg !15
+}
+
+attributes #0 = { noinline norecurse nounwind optnone ssp uwtable }
+
+!llvm.module.flags = !{!0, !1, !2, !3, !4, !5, !6}
+!llvm.dbg.cu = !{!7}
+!llvm.ident = !{!9}
+
+!0 = !{i32 2, !"SDK Version", [2 x i32] [i32 14, i32 0]}
+!1 = !{i32 7, !"Dwarf Version", i32 4}
+!2 = !{i32 2, !"Debug Info Version", i32 3}
+!3 = !{i32 1, !"wchar_size", i32 4}
+!4 = !{i32 8, !"PIC Level", i32 2}
+!5 = !{i32 7, !"uwtable", i32 2}
+!6 = !{i32 7, !"frame-pointer", i32 2}
+!7 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !8, producer: "clang", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, splitDebugInlining: false, nameTableKind: None, sysroot: "/Applications/Xcode.app", sdk: "MacOSX.sdk")
+!8 = !DIFile(filename: "test.cpp", directory: "/Users/shubham/Development")
+!9 = !{!"clang"}
+!10 = distinct !DISubprogram(name: "main", scope: !8, file: !8, line: 1, type: !11, scopeLine: 1, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition, unit: !7, retainedNodes: !14)
+!11 = !DISubroutineType(types: !12)
+!12 = !{!13}
+!13 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
+!14 = !{}
+!15 = !DILocation(line: 2, column: 5, scope: !10)
Index: llvm/test/DebugInfo/AArch64/tes
[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support
rastogishubham added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2271-2274
+ const TargetInfo &TI = getASTContext().getTargetInfo();
+ if (NumBits > TI.getMaxBitIntWidth()) {
Diag(Loc, diag::err_bit_int_max_size)
+<< IsUnsigned << TI.getMaxBitIntWidth();
Seems like this change broke the greendragon
https://green.lab.llvm.org/green/job/lldb-cmake/40733/console
Can you please take a look and either fix or revert your change?
Error message:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
error: use of overloaded operator '<<' is ambiguous (with operand types 'const
clang::StreamingDiagnostic' and 'typename remove_reference::type' (aka 'unsigned long'))
DB << std::move(V);
~~ ^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Sema/Sema.h:1686:16:
note: in instantiation of function template specialization
'clang::DiagnosticBuilder::operator<<' requested here
BaseDiag << std::move(V);
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Sema/Sema.h:1760:24:
note: in instantiation of function template specialization
'clang::Sema::ImmediateDiagBuilder::operator<<' requested
here
*ImmediateDiag << std::move(V);
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/lib/Sema/SemaType.cpp:2274:23:
note: in instantiation of function template specialization
'clang::Sema::SemaDiagnosticBuilder::operator<<' requested
here
<< IsUnsigned << TI.getMaxBitIntWidth();
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1399:35:
note: candidate function
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1405:35:
note: candidate function
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1421:35:
note: candidate function
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1427:35:
note: candidate function
inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, unsigned long)
DB << std::move(V);
^
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, int)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, long long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, __int128)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, unsigned int)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, unsigned long long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(int, unsigned __int128)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(long, unsigned long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(long long, unsigned long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(__int128, unsigned long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(unsigned int, unsigned long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(unsigned long, unsigned long)
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/clang/include/clang/Basic/Diagnostic.h:1352:8:
note: built-in candidate operator<<(unsigned
